| songwenping | iurygregory, why ironic_tempest_plugin skips case like tempest with microversion, https://zuul.opendev.org/t/openstack/build/29dc0212c508406b964ddf1914ec1a6f/log/job-output.txt#24812 | 00:48 |
|---|---|---|
| opendevreview | Steve Baker proposed openstack/ironic-inspector master: Change policy to enforce only new policy https://review.opendev.org/c/openstack/ironic-inspector/+/905119 | 01:01 |
| TheJulia | stevebaker[m]: thanks | 01:10 |
| TheJulia | songwenping: tests can have upper and lower bounds, if the remote endpoint doesn't support the version the test is written for, the test skips. | 01:11 |
| TheJulia | otherwise, the test could not possibly pass, since the remote endpoint is not a new enough version | 01:11 |
| songwenping | how to check the remote endpoint support the test version? | 01:15 |
| JayF | TheJulia: https://github.com/rhboot/shim/commit/0226b56513b2b8bd5fd281bce77c40c9bf07c66d thought you might find that interesting given the weird behavior we used to see if you mixed OS grub/shim builds | 02:09 |
| TheJulia | What we were seeing was an artifact of signing and the chain of trust, fwiw | 02:15 |
| TheJulia | songwenping: what is what the test is doing, it checks the available micro version from the far endpoint, and if not in the range the skip triggers. If you look at the raw tempest log you can see the version discovery response | 02:17 |
| TheJulia | Err, that is what the test is doing | 02:18 |
| opendevreview | Merged openstack/ironic-inspector master: Change policy to enforce only new policy https://review.opendev.org/c/openstack/ironic-inspector/+/905119 | 04:03 |
| opendevreview | Adam McArthur proposed openstack/ironic-prometheus-exporter master: [codespell] Fixing Spelling Mistakes https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/906777 | 04:05 |
| opendevreview | Adam McArthur proposed openstack/ironic-prometheus-exporter master: [codespell] Adding Tox Target for Codespell https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/906778 | 04:05 |
| opendevreview | Adam McArthur proposed openstack/ironic-prometheus-exporter master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/906779 | 04:05 |
| opendevreview | Adam McArthur proposed openstack/ironic-python-agent-builder master: [codespell] Fixing Spelling Mistakes https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/906780 | 04:11 |
| opendevreview | Adam McArthur proposed openstack/ironic-python-agent-builder master: [codespell] Adding Tox Target for Codespell https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/906781 | 04:11 |
| opendevreview | Adam McArthur proposed openstack/ironic-python-agent-builder master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/906782 | 04:11 |
| opendevreview | Adam McArthur proposed openstack/ironic-ui master: [codespell] Fixing Spelling Mistakes https://review.opendev.org/c/openstack/ironic-ui/+/906783 | 04:22 |
| opendevreview | Adam McArthur proposed openstack/ironic-ui master: [codespell] Adding Tox Target for Codespell https://review.opendev.org/c/openstack/ironic-ui/+/906784 | 04:22 |
| opendevreview | Adam McArthur proposed openstack/ironic-ui master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/ironic-ui/+/906785 | 04:22 |
| opendevreview | Adam McArthur proposed openstack/metalsmith master: [codespell] Adding Tox Target for Codespell https://review.opendev.org/c/openstack/metalsmith/+/906786 | 04:26 |
| opendevreview | Adam McArthur proposed openstack/metalsmith master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/metalsmith/+/906787 | 04:26 |
| opendevreview | Adam McArthur proposed openstack/networking-baremetal master: [codespell] Fixing Spelling Mistakes https://review.opendev.org/c/openstack/networking-baremetal/+/906788 | 04:44 |
| opendevreview | Adam McArthur proposed openstack/networking-baremetal master: [codespell] Adding Tox Target for Codespell https://review.opendev.org/c/openstack/networking-baremetal/+/906789 | 04:44 |
| opendevreview | Adam McArthur proposed openstack/networking-baremetal master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/networking-baremetal/+/906790 | 04:44 |
| opendevreview | Adam McArthur proposed openstack/networking-generic-switch master: [codespell] Fixing Spelling Mistakes https://review.opendev.org/c/openstack/networking-generic-switch/+/906791 | 04:55 |
| opendevreview | Adam McArthur proposed openstack/networking-generic-switch master: [codespell] Adding Tox Target for Codespell https://review.opendev.org/c/openstack/networking-generic-switch/+/906792 | 04:55 |
| opendevreview | Adam McArthur proposed openstack/networking-generic-switch master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/networking-generic-switch/+/906793 | 04:55 |
| opendevreview | Adam McArthur proposed openstack/python-ironicclient master: [codespell] Fixing Spelling Mistakes https://review.opendev.org/c/openstack/python-ironicclient/+/906794 | 05:03 |
| opendevreview | Adam McArthur proposed openstack/python-ironicclient master: [codespell] Adding Tox Target for Codespell https://review.opendev.org/c/openstack/python-ironicclient/+/906795 | 05:03 |
| opendevreview | Adam McArthur proposed openstack/python-ironicclient master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/python-ironicclient/+/906796 | 05:03 |
| opendevreview | Adam McArthur proposed openstack/sushy master: [codespell] Fixing Spelling Mistakes https://review.opendev.org/c/openstack/sushy/+/906797 | 05:06 |
| opendevreview | Adam McArthur proposed openstack/sushy master: [codespell] Adding Tox Target for Codespell https://review.opendev.org/c/openstack/sushy/+/906798 | 05:06 |
| opendevreview | Adam McArthur proposed openstack/sushy master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/sushy/+/906799 | 05:06 |
| opendevreview | Adam McArthur proposed openstack/sushy-tools master: [codespell] Fixing Spelling Mistakes https://review.opendev.org/c/openstack/sushy-tools/+/906800 | 05:11 |
| opendevreview | Adam McArthur proposed openstack/sushy-tools master: [codespell] Adding Tox Target for Codespell https://review.opendev.org/c/openstack/sushy-tools/+/906801 | 05:11 |
| opendevreview | Adam McArthur proposed openstack/sushy-tools master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/sushy-tools/+/906802 | 05:11 |
| opendevreview | Adam McArthur proposed openstack/virtualbmc master: [codespell] Fixing Spelling Mistakes https://review.opendev.org/c/openstack/virtualbmc/+/906803 | 05:18 |
| opendevreview | Adam McArthur proposed openstack/virtualbmc master: [codespell] Adding Tox Target for Codespell https://review.opendev.org/c/openstack/virtualbmc/+/906804 | 05:18 |
| opendevreview | Adam McArthur proposed openstack/virtualbmc master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/virtualbmc/+/906805 | 05:18 |
| opendevreview | Adam McArthur proposed openstack/ironic master: [codespell] Fixing Spelling Mistakes https://review.opendev.org/c/openstack/ironic/+/906806 | 05:27 |
| opendevreview | Adam McArthur proposed openstack/ironic master: [codespell] Adding Tox Target for Codespell https://review.opendev.org/c/openstack/ironic/+/906807 | 05:27 |
| opendevreview | Adam McArthur proposed openstack/ironic master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/ironic/+/906808 | 05:27 |
| adamcarthur5 | Alrighty, that is them all done except for tenks, python-ironic-inspector-client and molteniron. I wanted to check about these before doing them? | 05:28 |
| rpittau | adamcarthur5: thanks! I think you can move forward with tenks and python-ironic-inspector-client, while molteniron hasn't received updates in a while and I think it's a bit abandoned at this point | 08:05 |
| rpittau | good morning ironic ironic! happy friday! | 08:05 |
| rpittau | adamcarthur5: one thing about your changes, you should change the topic to something more "significant" and remove "ironic-week-prio" to put it in the Hashtags field instead | 08:07 |
| rpittau | a good topic would be something like "codespell-ironic" so we can group them all | 08:09 |
| rpittau | easier to review :) | 08:09 |
| *** ravlew is now known as Guest444 | 10:09 | |
| opendevreview | Merged openstack/tenks master: Add Python 3.10 to supported versions https://review.opendev.org/c/openstack/tenks/+/906215 | 10:54 |
| iurygregory | songwenping_, well the ironic service is not enabled in the job config =) | 11:20 |
| iurygregory | good morning Ironic | 11:20 |
| iurygregory | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_29d/879923/24/check/tempest-full-yoga/29dc021/controller/logs/local_conf.txt | 11:21 |
| iurygregory | oh something interesting https://zuul.opendev.org/t/openstack/build/92c95176c3c049578a00639a1f277f31/log/job-output.txt#13938 we also skip in our functional tests =X (because Neutron is not enabled on it) | 11:47 |
| opendevreview | Mahnoor Asghar proposed openstack/ironic master: Remove the sphinxcontrib-seqdiag dependency https://review.opendev.org/c/openstack/ironic/+/906825 | 12:17 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic stable/2023.2: Fix two severe errors in the firmware caching code https://review.opendev.org/c/openstack/ironic/+/906826 | 12:44 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic stable/2023.2: Cache firwmare components on the transition to "manageable" https://review.opendev.org/c/openstack/ironic/+/906827 | 12:53 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic stable/2023.2: RedfishFirmwareInterface - Unit Tests & More logs https://review.opendev.org/c/openstack/ironic/+/906500 | 12:54 |
| iurygregory | ok, all fixes for Firmware Interface backported to 2023.2 (Bobcat) | 12:54 |
| dtantsur | +2 | 13:10 |
| iurygregory | ty | 13:17 |
| opendevreview | Mahnoor Asghar proposed openstack/ironic master: Remove the sphinxcontrib-seqdiag dependency https://review.opendev.org/c/openstack/ironic/+/906825 | 13:58 |
| opendevreview | Mahnoor Asghar proposed openstack/ironic master: Remove the sphinxcontrib-seqdiag dependency https://review.opendev.org/c/openstack/ironic/+/906825 | 14:09 |
| TheJulia | good morning | 14:18 |
| TheJulia | rpittau: I think we can likely just close up molteniron | 14:22 |
| rpittau | TheJulia: mmm yeah :/ | 14:25 |
| rpittau | good morning! | 14:25 |
| masghar | good morning! | 14:30 |
| TheJulia | rpittau: it was never meant as a project to go, just an easy lightweight way to checkout baremetal nodes for CI | 14:42 |
| rpittau | yeah, I think I never really got into it | 14:43 |
| rpittau | we should retire it | 14:43 |
| TheJulia | for some reason https://review.opendev.org/c/openstack/ironic-python-agent/+/904026 makes me nervous | 15:05 |
| dtantsur | TheJulia: I'm curious :) | 15:06 |
| TheJulia | I've not hunted far, but I think the net effect is we always introspect | 15:07 |
| TheJulia | and I'm worried if that is going to cause confusion at all | 15:07 |
| TheJulia | and... always is not a bad thing, *really* | 15:08 |
| dtantsur | TheJulia: my intention is only to introspect when an explicit list of collectors is provided OR an explicit callback URL (the latter being mostly for compatibility) | 15:08 |
| dtantsur | We don't introspect if neither is provided (at least that's my intention, let me know if I missed something) | 15:08 |
| TheJulia | So I don't see the bit about explicit list of collectors on the code path modified, but I'll look again after I finish this update to a jira item | 15:08 |
| dtantsur | TheJulia: https://review.opendev.org/c/openstack/ironic-python-agent/+/904026/6/ironic_python_agent/inspector.py#71 | 15:10 |
| dtantsur | together with the change at https://review.opendev.org/c/openstack/ironic-python-agent/+/904026/6/ironic_python_agent/config.py#170 | 15:11 |
| dtantsur | (take your time, it's not urgent for me) | 15:11 |
| TheJulia | oooh kay | 15:14 |
| TheJulia | I see now | 15:14 |
| TheJulia | I didn't see it in inspector.py, only https://review.opendev.org/c/openstack/ironic-python-agent/+/904026/6/ironic_python_agent/agent.py is what my feeling was based upon | 15:15 |
| TheJulia | But now there are no defaults when the entry says there are :) | 15:16 |
| dtantsur | Well, yeah. It's a bit weird. If you provide the URL, there are defaults (again, backward compatibility) | 15:18 |
| TheJulia | yeah | 15:19 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-python-agent master: Also retry inspection on HTTP CONFLICT https://review.opendev.org/c/openstack/ironic-python-agent/+/906843 | 15:21 |
| dtantsur | Somehow you made me realize ^^^ | 15:21 |
| TheJulia | rechecking the inspector job on that change, it *looks* like it was almost there so really just another data point for comfort or not | 15:25 |
| TheJulia | (even though it is non-voting) | 15:25 |
| rpittau | bye everyone, have a great weekend! o/ | 15:56 |
| TheJulia | o/ | 16:03 |
| iurygregory | bye o/ | 16:28 |
| adamcarthur5 | rpittau appreciate the feedback. I'll get on that later today as I'm travelling. | 17:19 |
| opendevreview | Julia Kreger proposed openstack/ironic stable/2023.2: Kickstart: Don't error unit tests ksvalidate is present https://review.opendev.org/c/openstack/ironic/+/906882 | 19:09 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Handle Power On/Off for child node cases https://review.opendev.org/c/openstack/ironic/+/896570 | 19:10 |
| opendevreview | Julia Kreger proposed openstack/ironic stable/2023.1: Fixes Secureboot with Anaconda deploy https://review.opendev.org/c/openstack/ironic/+/906913 | 19:22 |
| opendevreview | Julia Kreger proposed openstack/ironic stable/2023.1: Kickstart: Don't error unit tests ksvalidate is present https://review.opendev.org/c/openstack/ironic/+/906914 | 19:22 |
| TheJulia | a few backports to fix unit test usage if ksvalidator is actually present | 19:27 |
| JayF | TheJulia: might need to push our chat if possible; GC here is going to have to cut *all power off* for a short period of time | 19:34 |
| TheJulia | okay | 19:35 |
| JayF | other question: you remember when we pitched doing ARM CI to that UNM group? | 19:35 |
| * TheJulia recommends a "priority load subpanel" coupled with "large battery" | 19:35 | |
| JayF | I have another potentially interested college professor with students wanting to point in Ironic | 19:35 |
| JayF | TheJulia: eh, I have my internet on a UPS, but it's more that I expect it to be disruptive :/ | 19:36 |
| TheJulia | uhh... was that back in september? or did it get lost in november? | 19:36 |
| JayF | I have no real idea; but it seemed like a good opportunity | 19:36 |
| * TheJulia was thinking 14kW ;) | 19:36 | |
| TheJulia | *big* battery | 19:36 |
| TheJulia | granted, when we loose power, we power down desktops and just use laptops | 19:37 |
| JayF | Yeah no lol. The only reason main breaker has to go off is stupid (smart switches can make non-contact voltage testers go boop because they leech power even when the power is off) | 19:37 |
| JayF | so it's not even like, a valid need, just the GC guy wants it off even though he himself said he confirmed with contact testers it's cold | 19:37 |
| JayF | this contractor getting zero of my money after this is done, but I sure as hell want it done /o\ | 19:37 |
| JayF | ^ more of my money; I mean no more work not that I'll stiff 'em LOL | 19:38 |
| TheJulia | ugh | 19:38 |
| TheJulia | anyway, I'm available until 2pm | 19:39 |
| JayF | aight; I'll get this guy in and started as quick as possible. Hopefully it can't take him too long to hang and center a vanity light | 19:39 |
| opendevreview | Merged openstack/ironic stable/2023.2: Fix two severe errors in the firmware caching code https://review.opendev.org/c/openstack/ironic/+/906826 | 20:36 |
| opendevreview | Verification of a change to openstack/ironic stable/2023.2 failed: Cache firwmare components on the transition to "manageable" https://review.opendev.org/c/openstack/ironic/+/906827 | 20:36 |
| opendevreview | Verification of a change to openstack/ironic stable/2023.2 failed: RedfishFirmwareInterface - Unit Tests & More logs https://review.opendev.org/c/openstack/ironic/+/906500 | 20:36 |
| opendevreview | Jay Faulkner proposed openstack/ironic-specs master: Self-Service via Templates https://review.opendev.org/c/openstack/ironic-specs/+/890164 | 21:32 |
| opendevreview | Verification of a change to openstack/ironic stable/2023.2 failed: Cache firwmare components on the transition to "manageable" https://review.opendev.org/c/openstack/ironic/+/906827 | 21:51 |
| opendevreview | Merged openstack/ironic stable/2023.2: Kickstart: Don't error unit tests ksvalidate is present https://review.opendev.org/c/openstack/ironic/+/906882 | 22:05 |
| JayF | I landed the spelling fixes that this is on top of, https://review.opendev.org/c/openstack/ironic-inspector/+/906757/1 should be an easy approval to land the tox target+CI targets (well, CI target needs a recheck, but another +2 still needed) | 22:38 |
| TheJulia | interestingly it feels like suddenly ci is a little grumpier | 22:39 |
| JayF | CI is a lot busier | 22:44 |
| JayF | more noisy neighboring | 22:44 |
| JayF | we're just in the "oh crap it's the third part of the cycle land things!" part | 22:44 |
| TheJulia | ahh, yes | 22:46 |
| TheJulia | so, back to evening rechecks/posting changes | 22:46 |
| iurygregory | have a great weekend everyone o/ | 22:58 |
| opendevreview | Jay Faulkner proposed openstack/virtualbmc master: [CI] Fix releasenotes build by setting language https://review.opendev.org/c/openstack/virtualbmc/+/906920 | 23:11 |
| JayF | ^ trivial but fixes a broken gate | 23:11 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: More precise comment about when to disable v6 https://review.opendev.org/c/openstack/ironic/+/906922 | 23:17 |
| JayF | TheJulia: https://zuul.opendev.org/t/openstack/build/110753300cb04f88903cb98d2d09b980 RBAC change broke python-ironicclient gate as well, it appers | 23:23 |
| JayF | adamcarthur5 basically is forcing us to make sure our gates work :D | 23:23 |
| JayF | > b'"baremetal:deploy_template:create": "role:admin and system_scope:all" requires a scope of [\'system\'], request was made with project scope. (HTTP 500)\n' | 23:23 |
| JayF | talk about relevance to our chat, lol | 23:24 |
| TheJulia | woot, the old functional stuffs | 23:25 |
| TheJulia | I'll sort it out next week | 23:25 |
| JayF | yeah no rush, I'm just making sure I do a pass on all Adam's stuff before EOD | 23:25 |
| JayF | and that's where the vbmc gate fix came from, too lol | 23:26 |
| JayF | if I have time left I might see how low-hanging that failure is (turn on system scope; call it a winner?) | 23:26 |
| TheJulia | it likely is that the tests launch with env vars which means it is likely the really old style of params, so might not be the quickest just change the user fix :) | 23:27 |
| JayF | NO_REALLY_JUST_LET_ME_BE_SYSTEM_SCOPE_PLEASE = true | 23:27 |
| JayF | that doesn't exist? | 23:27 |
| JayF | oh, of course, I forgot to prepend OS_ | 23:28 |
| JayF | ;) | 23:28 |
| TheJulia | lol | 23:28 |
| TheJulia | OS_CLOUD=devstack-system-admin "maybe" | 23:28 |
| JayF | if I get to the end of this stack of tabs and there's time left in the week I will take a look :D | 23:29 |
| JayF | just gotta get Adam's changes in, pump those numbers up | 23:30 |
| JayF | he's going to have the most prolific week of ironic contribution ever in terms of lines changed :P | 23:30 |
| JayF | although I think the actual ironic change in that stack broke something in tests for real :) | 23:30 |
| TheJulia | yeah, all that stuff has been reliant upon old style policies for ages, downside of not making the changes required elsewhere a long long time ago | 23:32 |
| JayF | https://zuul.opendev.org/t/openstack/build/b0c919bac7e544fa956d7bdee761794e is generally suspicious too | 23:33 |
| JayF | networking-baremetal-multitenant-vlans | 23:33 |
| TheJulia | that one should be easier | 23:35 |
| * TheJulia clones the repo | 23:35 | |
| TheJulia | hmmmmmm | 23:40 |
| TheJulia | hmmmmmmmm | 23:40 |
| JayF | fwiw, that seems to be it for the repos that adam exercised | 23:44 |
| opendevreview | Julia Kreger proposed openstack/networking-baremetal master: Fix networking-baremetal gate break due to RBAC https://review.opendev.org/c/openstack/networking-baremetal/+/906923 | 23:53 |
| TheJulia | hjensas: so, we should likely chat about ^ next week | 23:53 |
| TheJulia | since it occurs to me we may have a constraint about use of scoped accounts to enumerate all the nodes | 23:54 |
| TheJulia | at least, downstream. | 23:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!