Wednesday, 2023-05-24

opendevreviewMerged openstack/ironic master: Explicitly pin CIRROS_VERSION  https://review.opendev.org/c/openstack/ironic/+/88398301:41
iurygregory\o/01:51
iurygregoryrecheck in the patch to see grenade green <301:51
TheJulia\o/01:53
iurygregorygrenade success <3 03:27
TheJuliaNow, nothing else is allowed to break!03:27
iurygregoryYES!03:28
iurygregoryand we should probably merge the DPU patch before merging https://review.opendev.org/c/openstack/ironic/+/883968 I would say03:31
iurygregorynow I'm going to sleep, midnight already, and i have early meeting03:32
opendevreviewMerged openstack/ironic-tempest-plugin master: CI: Advance stable jobs to 2023.1  https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/88360003:45
opendevreviewJulia Kreger proposed openstack/ironic master: Support sha256/sha512 with the ilo firmware upgrade logic  https://review.opendev.org/c/openstack/ironic/+/88216403:51
opendevreviewVerification of a change to openstack/ironic stable/yoga failed: [stable-only] [CI] BFV, RBAC jobs marked non-voting  https://review.opendev.org/c/openstack/ironic/+/88358904:07
opendevreviewJulia Kreger proposed openstack/ironic master: Handle nova policy change  https://review.opendev.org/c/openstack/ironic/+/88399804:37
opendevreviewMerged openstack/ironic-python-agent-builder stable/2023.1: Add checksum generation support  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/88356905:17
opendevreviewVerification of a change to openstack/ironic master failed: Explicitly use a session for DB version check  https://review.opendev.org/c/openstack/ironic/+/88396705:58
* TheJulia has a growing urge to start reverting devstack changes06:03
TheJulialooks like the default policy changes which merged are tanking multiple jobs for us, the posted change should fix us up, in theory06:04
rpittaugood morning ironic! o/07:00
opendevreviewMerged openstack/ironic stable/yoga: [stable-only] [CI] BFV, RBAC jobs marked non-voting  https://review.opendev.org/c/openstack/ironic/+/88358907:42
opendevreviewVerification of a change to openstack/ironic master failed: Explicitly use a session for DB version check  https://review.opendev.org/c/openstack/ironic/+/88396708:46
opendevreviewMerged openstack/ironic master: Remove indicators list by component from api-ref  https://review.opendev.org/c/openstack/ironic/+/88271009:05
opendevreviewMerged openstack/metalsmith master: Reduce retry timeout for Metalsmith CI  https://review.opendev.org/c/openstack/metalsmith/+/88368310:44
opendevreviewMerged openstack/metalsmith master: Update MD5 checksum references  https://review.opendev.org/c/openstack/metalsmith/+/88217010:45
iurygregorygood morning Ironic10:53
iurygregoryreally? I went to sleep and CI went broken again >.< (ofc the fix for grenade didn't get merged, sad =( )10:54
dtantsuriurygregory: :( which fix is the most important now?10:54
iurygregorydtantsur, probably https://review.opendev.org/c/openstack/ironic/+/88399810:55
iurygregoryI've +W already10:56
opendevreviewMerged openstack/ironic master: Handle nova policy change  https://review.opendev.org/c/openstack/ironic/+/88399812:10
dtantsuryay12:14
iurygregory ok time to recheck the fix for grenade12:23
iurygregorynothing is allowed to break now12:26
opendevreviewMark Goddard proposed openstack/bifrost master: Restart systemd services on failure  https://review.opendev.org/c/openstack/bifrost/+/88419812:58
TheJuliagood morning13:19
iurygregorygood morning TheJulia 13:20
iurygregorygrenade fix on check \o/ bfv is green again13:20
TheJuliaI was worried about bfv, stumbled upon a super weird failure yesterday13:23
iurygregoryyeah, but the fix was quick \o/ great job TheJulia =D13:37
TheJuliamgoddard: o/ w/r/t https://review.opendev.org/c/openstack/bifrost/+/884198 was there a specific failure?13:42
mgoddardTheJulia: often when we reboot, bifrost services (in a kolla container) don't all come up properly14:26
mgoddardTheJulia: mariadb seems the root cause, preventing ironic from starting14:26
TheJuliamgoddard: ahh, that *would* do it14:26
mgoddarddidn't find a solution to mariadb, but this seemed like a step forward at least14:26
TheJuliaif it was anything else, I would wonder if there is a bug to fix14:26
TheJuliathe only other way is a precise order14:27
mgoddardsystemd should make it possible14:27
TheJuliaif you know the service names :)14:27
mgoddardbut in this case mariadb just isn't running at all, and unsure why14:28
TheJuliaweird14:32
TheJuliasystemd is only going to retry so many times14:32
iurygregoryhopefully in 1h30min the DB fix will be merged \o/14:34
TheJuliaindeed14:36
opendevreviewJulia Kreger proposed openstack/ironic-tempest-plugin master: Fix rbac indicator tests  https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/88261914:59
opendevreviewJulia Kreger proposed openstack/ironic-tempest-plugin master: Add RBAC specific tempest jobs to gate plugin  https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/88231214:59
opendevreviewJulia Kreger proposed openstack/ironic-tempest-plugin master: rbac - Fix vif_attach expected return values  https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/88303214:59
TheJuliajust rebases14:59
opendevreviewJulia Kreger proposed openstack/ironic master: execute on child node support  https://review.opendev.org/c/openstack/ironic/+/88054515:09
opendevreviewJulia Kreger proposed openstack/ironic master: Add hold steps  https://review.opendev.org/c/openstack/ironic/+/87906015:10
opendevreviewJulia Kreger proposed openstack/ironic master: Enable vendor interfaces to be called as steps  https://review.opendev.org/c/openstack/ironic/+/87908915:10
opendevreviewJulia Kreger proposed openstack/ironic master: DNM: Move Ironic to scope enforced  https://review.opendev.org/c/openstack/ironic/+/88423515:17
opendevreviewJulia Kreger proposed openstack/ironic-inspector master: DNM: Change inspector to enforce scope  https://review.opendev.org/c/openstack/ironic-inspector/+/88423615:20
iurygregoryI'm surprised that the job that requires more time is the metalsmith-integration-glance-centos8-legacy15:22
TheJuliaI'm thinking we ought to drop it, tbh15:24
TheJuliaso! in other thoughts, which is a better name "sleep" or "pause"15:24
iurygregoryfor?15:24
TheJuliasleep/pause steps15:24
iurygregoryoh15:24
TheJulia"power_on", "pause|sleep", "power_off", "pause|sleep", "power_on", "do_magical_thing"15:25
iurygregorysleep steps would only make sense to me if the only thing it could do is "sleep X" 15:25
TheJuliawell the original idea was without argument, it just sleeps until the next heartbeat15:25
TheJuliaso a pause15:25
JayFTheJulia: pause or wait15:25
TheJuliaor a sleep15:25
JayFTheJulia: very much not sleep15:25
JayFsleep is a power action that means a specific thing for computers15:26
JayFand unless we're doing that thing, we shouldn't use that word15:26
TheJuliaoh, good point15:26
dtantsurreminder: we added the metalsmith job to get coverage for a feature that is not covered otherwise15:26
iurygregoryI'm +1 to pause15:26
TheJuliadtantsur: which was?15:26
dtantsurTheJulia: local legacy boot for partition images15:27
dtantsuri.e. all the grub-install magic in IPA15:27
TheJuliaoh, right15:27
* TheJulia wonders how long we should keep that going15:27
dtantsurnot that it *requires* metalsmith, but so far it's the only job that exercises it15:27
dtantsurwell, people still use legacy boot....15:28
TheJuliaunfortunately15:28
dtantsur*nod*15:28
TheJuliaalthough, we've really been pushing in my area to get rid of partition image usage15:28
TheJuliamaybe a topic for next spring's PTG15:28
dtantsurI've definitely met at least one operator who said "I'll migrate away from Ironic if you drop partition images"15:29
dtantsurnot sure how serious they were, of course15:29
JayFpartition *legacy boot*, right?15:29
JayFnot partition uefi?15:29
dtantsurpartition + uefi is kinda-sorta checked in cirros jobs15:29
dtantsur(by using the asset copy mechanism)15:29
* TheJulia wonders how many vendors are carrying proto-legacy-boot-firmware-stuffs15:30
TheJulia... (then again, it wasn't universally dropped by the hardware vendors)15:30
dtantsurit's all UEFI emulating BIOS nowadays, right?15:30
TheJulianot *always*15:30
dtantsuroh no15:30
TheJuliawe've run across some weird hardware which has the option, but it just ignores the request15:31
TheJuliaand then other hardware which has it "grayed out"15:31
* TheJulia doesn't want to encourage folks to consider beverages early15:31
dtantsurit's not that early here :D15:32
* dtantsur has a bottle of local blueberry wine15:32
TheJuliaI know yummie15:32
TheJuliaerr15:32
TheJuliayummie15:32
TheJuliaI know a lot of people don't comprehend the actual *advantage* to uefi15:32
dtantsurnot everyone even understands the difference :)15:33
TheJuliawell, it is a 32bit-ism15:33
TheJulia:)15:33
TheJuliaI have the Star Trek Voyager episode "nemesis" playing in the background. This feels like the clash, and 32bit is the nemesis.15:34
TheJuliaso the consensus is pause > wait > sleep right?15:35
JayFI am like .00001% more of a fan of wait than pause15:35
TheJuliahmmmmmmm15:37
JayFI can't tell you *why* I have this association15:41
JayFbut I think wait is for a set period of time. Wait 30 seconds. Wait until 2pm. etc15:41
TheJuliago vote https://civs1.civs.us/cgi-bin/vote.pl?id=E_f7b08705f48174a4&akey=d4fce31a35c805a0 :)15:41
JayFPause is indefinate. You pause until someone hits play.15:41
TheJuliatrue15:41
TheJuliaI'm leaning towards wait personally15:42
TheJulia2 votes so far15:44
TheJuliacould I get reviews on https://review.opendev.org/c/openstack/ironic/+/883577 and https://review.opendev.org/c/openstack/ironic/+/883578 ?16:04
JayFlooking16:04
JayF+2A16:05
iurygregory\o/16:20
rpittaugood night! o/16:21
iurygregorygn rpittau o/16:22
JayFo/16:22
iurygregorythe longest 1min today https://zuul.opendev.org/t/openstack/status#88396716:23
iurygregoryEstimated time remaining < 30 seconds 16:24
opendevreviewMerged openstack/ironic master: Explicitly use a session for DB version check  https://review.opendev.org/c/openstack/ironic/+/88396716:44
iurygregory\o/16:44
iurygregoryyay16:44
iurygregorynow we can go with patches that have DB changes \o/16:44
TheJulia\o/16:58
TheJuliawheeeeeeeeeee16:58
TheJuliaclosing poll, 3 votes17:06
TheJuliawait wins, pause wins with 2 votes, other is 3rd... and sleep 417:06
opendevreviewJulia Kreger proposed openstack/ironic stable/wallaby: Fix Cinder Integration fallout from CVE-2023-2088  https://review.opendev.org/c/openstack/ironic/+/88358117:38
TheJuliaI *think* that will work, it is a sort of weird case17:38
TheJuliawe'll see, I'll likely need to add a unit tests but getting tons of unrelated weird failures which I think is just my local repo17:39
opendevreviewMerged openstack/ironic stable/2023.1: Fix Cinder Integration fallout from CVE-2023-2088  https://review.opendev.org/c/openstack/ironic/+/88357717:55
opendevreviewMerged openstack/ironic stable/zed: Fix Cinder Integration fallout from CVE-2023-2088  https://review.opendev.org/c/openstack/ironic/+/88357818:05
TheJuliareviews on https://review.opendev.org/c/openstack/ironic/+/883579?usp=search and https://review.opendev.org/c/openstack/ironic/+/883580 pleaes :)18:43
JayFWe should've enabled BFV job with those same PRs 18:52
JayFtoo late now but we should re-voting them asap18:52
ashinclouds[m]Yeah18:54
TheJuliaErr yeah18:54
opendevreviewJay Faulkner proposed openstack/ironic stable/2023.1: Cinder bugs fixed; make BFV job vote again  https://review.opendev.org/c/openstack/ironic/+/88428019:35
opendevreviewJay Faulkner proposed openstack/ironic stable/2023.1: [ci] [stable-only] Cinderfixed; make BFV job vote  https://review.opendev.org/c/openstack/ironic/+/88428019:35
opendevreviewJay Faulkner proposed openstack/ironic stable/2023.1: [ci] [stable-only] Cinder fixed; make BFV job vote  https://review.opendev.org/c/openstack/ironic/+/88428019:36
opendevreviewJay Faulkner proposed openstack/ironic stable/zed: [ci] [stable-only] Cinder fixed; make BFV job vote  https://review.opendev.org/c/openstack/ironic/+/88422019:36
opendevreviewJay Faulkner proposed openstack/ironic stable/yoga: [ci] [stable-only] Cinder fixed; make BFV job vote  https://review.opendev.org/c/openstack/ironic/+/88422119:36
JayFdid we determine that https://review.opendev.org/c/openstack/ironic/+/883699 did nothing? 19:48
JayFI saw some chatter about mysql counters in grenade, curious if that patch is still valid19:48
opendevreviewJulia Kreger proposed openstack/ironic stable/wallaby: DNM Fix Cinder Integration fallout from CVE-2023-2088  https://review.opendev.org/c/openstack/ironic/+/88358119:52
TheJuliaI think it helped with python 3.1019:52
TheJuliathe question is what base python is being used19:52
JayFso it will do no harm and potentially good to merge it19:52
JayFit's not a noop change or actively harmful19:52
JayFsounds like a do-it to me19:52
opendevreviewJay Faulkner proposed openstack/ironic stable/2023.1: CI: Disable mysql counters for grenade  https://review.opendev.org/c/openstack/ironic/+/88369919:53
opendevreviewJay Faulkner proposed openstack/ironic master: Add ironic-grenade-skip-level Job  https://review.opendev.org/c/openstack/ironic/+/83696619:59
JayFgrenade (both) actually passed ^ \o/ I rebased it so the other jobs could pass20:02
NobodyCamGood morning Ironic Folks, Happy Hump day20:07
NobodyCamoh rescue more needs to hart beat :(20:08
JayFo/20:08
JayFrescue mode does this:20:08
NobodyCam\o JayF 20:08
JayF1) boots a ramdisk / 2) ramdisk does usual lookup/hb flow / 3) ramdisk gets command to flip network as conductor flips networks in neutron20:09
* JayF curious what your actual goal is20:09
NobodyCam:) 20:09
NobodyCamboot a ramdisk on top of an instance that automatically runs some hardware tests and then boots back in to the instance20:10
JayFyou want active steps20:10
JayFcoming to an ironic near you in a few months, we hope20:10
NobodyCamnice20:11
JayFno real way to do that in Ironic today without patching20:11
NobodyCamyep, I for see some hacking 20:11
JayFactive steps (or what did we call them, service steps?) basically let you automate arbitrary steps, ala cleaning20:11
JayFjust on a machine that's active20:11
JayFso active -> servicing -> active20:11
TheJuliaservice steps20:11
JayFplus some extra magic things TheJulia is adding that I think some crazy green NICs need ;) 20:12
NobodyCamhehehehe20:12
* JayF remains team red until NobodyCam ships him a 4090Ti20:12
NobodyCamLoL 20:12
NobodyCamoh looks like lunch is ready... BRB20:13
* TheJulia will need an array of 4090s20:14
TheJuliaRAIGPU20:14
TheJuliasounds sort of like a star wars character20:16
JayFsounds like a brand of tomato sauce20:16
NobodyCamhehheh20:25
TheJuliahttps://review.opendev.org/c/openstack/ironic-specs/+/872349 <-- could use a +A....20:26
TheJuliaoh, where are we at with sharding client patches?20:27
JayFopenstacksdk is landed20:38
JayFI haven't looked at python-ironicclient in a while tbh20:38
JayFI need to. Will set aside time tomorrow.20:38
TheJuliak20:40
opendevreviewMaksim Malchuk proposed openstack/ironic-python-agent-builder master: Extend the DIB_CHECKSUM variable usage  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/88129920:44
opendevreviewMerged openstack/ironic-specs master: Add service steps framework  https://review.opendev.org/c/openstack/ironic-specs/+/87234920:51
iurygregoryThanks for doing the rebase while I was out JayF o/21:22
iurygregoryhttps://review.opendev.org/c/openstack/ironic/+/883580 didn't pass bfv job...21:25
TheJuliaoh joy21:27
TheJuliaokay21:27
TheJuliaso xena and wallaby21:27
TheJuliagood to konw21:27
iurygregoryyeah21:27
TheJuliac'est la vie21:27
TheJuliaI expected this on wallaby21:27
TheJuliaof sorts21:27
iurygregoryI will try to take a look (added to my list here)21:28
opendevreviewJulia Kreger proposed openstack/ironic master: Add hold steps  https://review.opendev.org/c/openstack/ironic/+/87906021:37
opendevreviewJulia Kreger proposed openstack/ironic master: Add wait step  https://review.opendev.org/c/openstack/ironic/+/87906121:37
opendevreviewJulia Kreger proposed openstack/ironic stable/wallaby: DNM Fix Cinder Integration fallout from CVE-2023-2088  https://review.opendev.org/c/openstack/ironic/+/88358121:42
TheJuliaso yeah, we're jut navigating around support/behavior on the url format21:43
TheJuliaI think if we just drop our shorterner it might just work, there were some funky caveats/behavior around it21:43
opendevreviewJulia Kreger proposed openstack/ironic master: follow-up on DPU change api-ref  https://review.opendev.org/c/openstack/ironic/+/88430122:28
opendevreviewMerged openstack/ironic-tempest-plugin master: Fix rbac indicator tests  https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/88261922:31
TheJulia\o/22:49
iurygregory\o/23:06
opendevreviewMerged openstack/ironic stable/yoga: Fix Cinder Integration fallout from CVE-2023-2088  https://review.opendev.org/c/openstack/ironic/+/88357923:18
opendevreviewMerged openstack/ironic master: DPU modeling - parent_node DB/Model/API  https://review.opendev.org/c/openstack/ironic/+/88011423:18
* TheJulia dances23:18
opendevreviewJulia Kreger proposed openstack/ironic master: execute on child node support  https://review.opendev.org/c/openstack/ironic/+/88054523:18
opendevreviewJulia Kreger proposed openstack/ironic master: Add hold steps  https://review.opendev.org/c/openstack/ironic/+/87906023:18
iurygregoryI'm surprised that it didn't cause merge conflict with https://review.opendev.org/c/openstack/ironic/+/883968/23:19
iurygregoryO.o23:19
iurygregorynow it's time for me to update my DB patch and change revision etc23:20
NobodyCamcrazy question would anyone be interested in a patch to bypass rescue wait mode? to boot up non ipa rescue images? 23:21
NobodyCamie a configuration option to enable / disable  rescue wait ?23:21
TheJuliacould you elaborate a little more?23:22
iurygregorythis would probably require some discussion I think (maybe at the weekly meeting)23:22
iurygregoryor maybe I'm thinking too much XD23:22
TheJuliaI'm trying to understand what the underlying issue is23:22
TheJuliaiurygregory: sorry for the revision issues, we're going to be goin gback and forth I suspect23:22
TheJuliaand I just double checked mine, no model_query usage23:22
TheJuliawe'll just need to be mindful moving forward23:23
NobodyCamrescue wait expects a hart beat. The image I am deploying is a hardware test image, it is not built on a ipa image, so it is unable to hart beat. But it I skip rescue wait things work as expected.23:24
iurygregoryTheJulia, no worries, I was planning to have your patch landing first, since it also contains a bump in API etc23:24
iurygregorynewbie question, do a need to create a new revision or I can just update the down_revision and Revises in https://review.opendev.org/c/openstack/ironic/+/883031/12/ironic/db/sqlalchemy/alembic/versions/163040c5513f_add_firmware_information.py to match revision in your patch TheJulia ?23:28
TheJuliaNobodyCam: oh, your deploying a custom ramdisk without an agent23:28
NobodyCamcorrect23:28
TheJuliaahh :\23:28
TheJuliadunno, tbh23:28
TheJuliaiurygregory: just update down_revision23:29
TheJulia*magic*23:29
iurygregory=O23:29
iurygregorynice23:29
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic master: Add DB model for Firmware  https://review.opendev.org/c/openstack/ironic/+/88303123:37
opendevreviewJulia Kreger proposed openstack/ironic stable/xena: DNM: Test commit to get unpatched logs  https://review.opendev.org/c/openstack/ironic/+/88430223:53
TheJuliato get logs w/r/t cinder, because I think we have a harder break to contend with on xena/wallaby23:55

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!