Tuesday, 2023-05-23

NobodyCamTheJulia: Thank you, working now00:10
TheJuliaiurygregory: so, replaying everything on the connection, can't reproduce00:12
iurygregoryTheJulia, ack =(03:32
TheJuliaI had a theory to explore tomorrow03:32
iurygregoryok 03:35
iurygregoryfingers crossed03:35
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic master: Add DB model for Firmware  https://review.opendev.org/c/openstack/ironic/+/88303103:52
iurygregorynew attempt just to see 03:52
iurygregorygnight03:52
opendevreviewGraeme Moss proposed openstack/networking-generic-switch master: Fix fallback to plug_port_to_network on 802_3ad bonds  https://review.opendev.org/c/openstack/networking-generic-switch/+/88195907:51
opendevreviewGraeme Moss proposed openstack/networking-generic-switch master: Fix fallback to plug_port_to_network on 802_3ad bonds  https://review.opendev.org/c/openstack/networking-generic-switch/+/88195909:29
iurygregorygood morning Ironic11:42
opendevreviewJacob Anders proposed openstack/ironic master: [WIP] Follow up change to 880575  https://review.opendev.org/c/openstack/ironic/+/88393813:14
iurygregory<eyes> ^13:16
TheJuliaiurygregory: still froze eh?13:19
iurygregoryTheJulia, yeah, I've spent part of my morning now reading things13:20
TheJuliaanything interesting?13:20
iurygregoryfound https://github.com/miguelgrinberg/Flask-Migrate/issues/4113:20
iurygregorysaw some people mentioning that a process is try to access the DB we are modifying and it could cause this problem13:21
TheJuliayeah13:22
TheJuliaI could stop everything, restart just the db, and reproduce yesterday13:22
iurygregoryhttps://prog.world/the-process-gets-stuck-in-info-alembic-migration-running-upgrade/13:22
TheJuliaI'm starting to think it is alembic13:22
iurygregoryyeah, I remember that part .-.13:22
iurygregorynow I'm reading https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-33.html to see if there is something13:23
TheJuliagood plan13:23
TheJuliaI started digging through our migraiton to alembic migration code to get an understanding of it yesterday13:24
TheJuliawhat I don't understand is it looks like alembic is trying some sort of random order13:24
TheJuliaand then figures out what to do from there13:24
iurygregoryoh jesus .-.13:44
iurygregorywhat blows my mind is "why only in grenade?"13:45
TheJuliaevery other job runs as a clean slate13:54
iurygregoryyeah13:56
BobZAnnapolis____Following docs to install Bifrost (ussuri,victoria,wallaby,yoga) w/testenv, crashing out on sushy-tools installation : AttributeError: module 'lib' has no attribute 'X509_V_FLAG_CB_ISSUER_CHECK' <- no Google search responses to this error code worked; https://docs.openstack.org/bifrost/any_vsn/install/index.html# <- all failing :-( tia13:56
TheJuliaBobZAnnapolis____: any chance we can get more around that error, possibly a exception backtrace?13:58
TheJuliaBobZAnnapolis____:  also, same with master branch? what distribution are you using?14:11
iurygregoryseems like a problem with pyopenssl 14:15
iurygregoryI never saw it in my deployments 14:15
TheJuliapip freeze output would help too14:19
* TheJulia does the whole t'pol intruiging look from enterprise and digs back into the migration code14:19
* JayF wonders if pyopenssl wants OpenSSL 3.0 and BobZAnnapolis____ has 1.x or vice-versa14:19
opendevreviewAlex Welsh proposed openstack/bifrost master: Replace Cirros references with generic descriptors  https://review.opendev.org/c/openstack/bifrost/+/88394314:25
BobZAnnapolis____i deleted the vm, will rebuild/retry. The stack trace indicates the lib imported from _lib OpenSSL can't find those attributes;i've tried different versions of openSSL, pyOpenSSL (>22.#) & cryptography (>34.#) - i know it works (obviously), just trying to find the correct link / instructions / docs - tia14:31
JayFiurygregory: TheJulia: aw hell ... https://3df9d8624791e146e7ca-5b369dc32177e920b38f658289f2b193.ssl.cf2.rackcdn.com/836966/5/check/ironic-grenade-skip-level/69a6b89/controller/logs/grenade.sh_log.txt14:38
JayFiurygregory: TheJulia: tl;dr: on the grenade-skip-level job, it looks like we're hanging on *different* migrations from last cycle14:39
JayFiurygregory: TheJulia: implying to me right now with the current state of master, we're unable to run migrations :| 14:39
TheJuliayup14:39
iurygregoryoh jesus14:41
* TheJulia resumes trying to get the upgrade command to dump the process list output14:41
iurygregorymaybe we forgot something from Node Inventory - Shard - New Migrations?14:44
TheJuliadunno14:45
TheJuliahttps://paste.openstack.org/show/b2UHxNEXW2ZvmBstjBTT/14:47
iurygregorymaybe we could stop everything :D and only start them after we do things (but I don't think it would help, since we tested without any process running... )14:48
TheJuliawhat do you mean stop everything?14:49
iurygregoryall serivces14:50
iurygregory:D14:50
iurygregorynova, neutron etc14:50
TheJulialogin and take a look, basically that is what I did, I've not managed to get the wsgi apps from re-spawning14:50
TheJuliabut non of them open the db14:50
TheJuliathe ironic db that is14:50
TheJuliahttps://paste.openstack.org/show/bZJaNtZriBO6hJhlPX48/14:51
TheJuliawhen the ironic-dbsync process has been control-c'ed, and I've run the db query directly14:51
* TheJulia wonders about downgrading mysql14:54
JayFI owe something downstream that's now late since I had to take yesterday off; I'm gonig to focus on that but if we're still here when I come back, I'll start setting up a testbed14:57
TheJuliaso I got it to complete, but I had to kill all open database connections also opened by alembic looking at the database15:19
iurygregorywow15:36
iurygregoryTheJulia, so downgrading mysql seems to work? 15:37
* iurygregory brb lunch15:37
TheJuliawell, got it to complete by hunting down one of the hanging alembic connections15:38
TheJuliawell, I've gotten a query to hang directly against the db15:52
TheJuliasomehow https://paste.openstack.org/show/bbz0PNZmXNwpJftylCPG/ requires a lock15:56
iurygregorywow15:57
TheJuliahttps://paste.openstack.org/show/b88nn8APJ9bUZFvLzxcS/15:58
TheJuliait is only frozen because we're already frozen though15:58
TheJuliabut the fact it *needs* a lock is... weird to me15:59
iurygregoryinteresting 16:04
iurygregoryfrom https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-3.html  https://paste.opendev.org/show/bGjTJuIZPRcInACDqBrI/16:09
iurygregoryseems like there was a change in the default of innodb_autoinc_lock_mode16:09
TheJulia8.0.3 vs 8.0.3316:11
JayFholy hell that's a giant change in behavior16:14
TheJulia201716:15
iurygregoryfor some reason I only looked at the first number after the 0 /facepalm16:15
TheJuliamysql doesn't permit downgrade16:33
iurygregory.-.16:38
dtantsurSo, I assume I'm not the only person who wants to burn all the bloody computers today?16:38
iurygregoryI want to do this since last week16:39
TheJuliadtantsur: I was thinking molten computers would be appropriate16:53
dtantsur*nod*16:57
TheJuliahttps://dev.mysql.com/doc/refman/8.0/en/metadata-locking.html#metadata-lock-release17:10
TheJuliawell, the entire page, not just on how the lock release pattern works17:10
JayFWhat version of alembic we using? https://alembic.sqlalchemy.org/en/latest/changelog.html#change-3374635e9b84c495d2ede3c978cd57e617:12
JayFthat sounds highly suspect17:12
JayFI was thinking, if mysql changed behavior there might be a matching alembic change/fix17:12
TheJuliaoh, I think I see what is going on17:18
TheJuliabbingo17:21
TheJuliaworking on two patches now17:44
iurygregory\o/18:08
JayFTheJulia: is it an ironic bug or something systemmic for openstack?18:12
TheJuliaits our code18:12
TheJuliawell, from an openstack pattern18:12
opendevreviewJulia Kreger proposed openstack/ironic master: Explicitly use a session for DB version check  https://review.opendev.org/c/openstack/ironic/+/88396718:22
opendevreviewJulia Kreger proposed openstack/ironic master: Remove model_query use from general dbapi calls  https://review.opendev.org/c/openstack/ironic/+/88396818:22
opendevreviewJulia Kreger proposed openstack/ironic master: Remove unused get_not_vesions from dbapi  https://review.opendev.org/c/openstack/ironic/+/88396918:22
TheJuliajust the first one is the one that is needed18:22
opendevreviewJulia Kreger proposed openstack/ironic master: DPU modeling - parent_node DB/Model/API  https://review.opendev.org/c/openstack/ironic/+/88011418:23
JayFTheJulia: so we had a query object outstanding until it was GC'd, more or less?18:29
TheJuliayup, exactly18:30
TheJuliaand because the way the locking works if they didn't compeltely rollback a transaction, they blocked the alter table update18:30
TheJulianothing forces it in the model_query pattern, the with _session_for_read() pattern *does* force it on the unwind of the session18:31
TheJuliaiurygregory: okay if I let infra remove the held vm?18:45
opendevreviewJulia Kreger proposed openstack/ironic-tempest-plugin master: CI: Advance stable jobs to 2023.1  https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/88360019:09
opendevreviewJulia Kreger proposed openstack/ironic-tempest-plugin master: CI: Advance stable jobs to 2023.1  https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/88360019:11
opendevreviewHarald JensÃ¥s proposed openstack/ironic-tempest-plugin master: rbac - Fix vif_attach expected return values  https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/88303219:27
opendevreviewVerification of a change to openstack/ironic stable/2023.1 failed: [stable-only] [CI] BFV, RBAC jobs marked non-voting  https://review.opendev.org/c/openstack/ironic/+/88369719:39
opendevreviewPierre Riteau proposed openstack/virtualbmc master: Remove duplicate space in log message  https://review.opendev.org/c/openstack/virtualbmc/+/88397720:07
opendevreviewJulia Kreger proposed openstack/ironic master: Explicitly use a session for DB version check  https://review.opendev.org/c/openstack/ironic/+/88396720:24
JayFTheJulia: you missed your own comment on that patch (adding back the _)20:25
opendevreviewJulia Kreger proposed openstack/ironic master: Explicitly use a session for DB version check  https://review.opendev.org/c/openstack/ironic/+/88396720:26
TheJuliaack, going to the post office20:26
JayFTheJulia: did that need a backport, too, once it lands?20:26
TheJuliayeah, likely20:30
TheJuliawe've seen some raceiness before py3.10, but 3.10 seems to be very.. racey20:31
JayFaight, you have a +2 from me20:36
iurygregoryTheJulia, sure (sorry I was at the physiotherapy20:38
iurygregoryok, so we shouldn't be using model_query ?20:40
JayFso model_query, and similar, returns a result that's a sqla model20:42
JayFthat until it's GC'd represents an open session to the db20:42
iurygregoryI think need more coffee now 20:43
iurygregoryand I will review the patches 20:43
TheJuliayeah, we should not be using model query20:47
TheJuliaI think we need to rip it out entirely20:47
TheJuliabut we can't go backporting that20:47
TheJuliause "with _session_for_read() as session:\n               session.query(model).filter.whatever.magic20:49
TheJulia"20:49
iurygregorytime refactor my patche and put in chain with the first one with the fix20:56
TheJuliaI need to fix my second patch, it basically weeds the rest of model_query out20:57
iurygregorybut with the first one we should get grenade working right?20:58
TheJuliaYeah20:58
iurygregorycool cool cool 20:58
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic master: Add DB model for Firmware  https://review.opendev.org/c/openstack/ironic/+/88303121:17
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic master: Add ironic-grenade-skip-level Job  https://review.opendev.org/c/openstack/ironic/+/83696621:19
opendevreviewJulia Kreger proposed openstack/ironic master: Remove model_query use from general dbapi calls  https://review.opendev.org/c/openstack/ironic/+/88396821:38
opendevreviewJulia Kreger proposed openstack/ironic master: Remove unused get_not_versions from dbapi  https://review.opendev.org/c/openstack/ironic/+/88396921:38
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic master: Add DB API for Firmware  https://review.opendev.org/c/openstack/ironic/+/88306221:41
opendevreviewMerged openstack/virtualbmc master: Remove duplicate space in log message  https://review.opendev.org/c/openstack/virtualbmc/+/88397721:42
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic master: FW Object structure  https://review.opendev.org/c/openstack/ironic/+/88309321:46
TheJuliaand... looks like they reverted the revert to the revert on the cirros version22:06
opendevreviewJulia Kreger proposed openstack/ironic master: Explicitly pin CIRROS_VERSION  https://review.opendev.org/c/openstack/ironic/+/88398322:11
opendevreviewMerged openstack/ironic stable/2023.1: [stable-only] [CI] BFV, RBAC jobs marked non-voting  https://review.opendev.org/c/openstack/ironic/+/88369722:41

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!