opendevreview | Vanou Ishii proposed openstack/ironic master: Deal with iRMC virtual media incompatibility https://review.opendev.org/c/openstack/ironic/+/823790 | 09:12 |
---|---|---|
opendevreview | Merged openstack/ironic bugfix/19.0: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871038 | 11:23 |
iurygregory | good morning Ironic | 11:47 |
dking | good morning | 12:22 |
opendevreview | Riccardo Pittau proposed openstack/ironic master: [WIP] [PoC] A metal3 CI job https://review.opendev.org/c/openstack/ironic/+/863873 | 13:15 |
TheJulia | good morning | 14:27 |
kubajj | TheJulia: good morning | 15:08 |
kubajj | and good morning everybody | 15:08 |
opendevreview | Merged openstack/bifrost stable/zed: Fix CI https://review.opendev.org/c/openstack/bifrost/+/871041 | 15:21 |
JayF | Heads up: I will generally not be around today. If you need me urgently I'll have my cell phone (which I think many of you have?) | 16:18 |
TheJulia | ack, I think so :) | 16:27 |
opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Disable use of the SSH agent for the rescue test https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/872567 | 16:33 |
rpittau | good night! o/ | 16:52 |
opendevreview | Merged openstack/ironic-tempest-plugin master: Prevent protected node tests from orphaning test nodes https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/871301 | 18:00 |
opendevreview | Steve Baker proposed openstack/ironic master: Respond to rpc requests on stop until hash ring reset https://review.opendev.org/c/openstack/ironic/+/872601 | 21:50 |
TheJulia | stevebaker[m]: release note please :) | 22:02 |
stevebaker[m] | haha, yes | 22:02 |
TheJulia | So one thing that does also jump into my mind (and definitely an additional patch, is we may also want to wait or provide the option of waiting until there are no locks for conductor which is being stopped. | 22:03 |
TheJulia | That way we first loose the ability to get new work and then only exit once we're free from work. | 22:03 |
stevebaker[m] | TheJulia: yeah this is just a start, would you call this a fix or a feature, wrt the release note | 22:06 |
TheJulia | I'd lean towards feature | 22:07 |
TheJulia | unfortunately | 22:07 |
TheJulia | This is definitely one of those gray areas where if we get a report of a bad issue we can consider backporting it | 22:07 |
TheJulia | and then call it a bugfix | 22:07 |
stevebaker[m] | ack | 22:07 |
TheJulia | speaking of patches, I can go do code reviews and put off making a bunch of meeting invites! | 22:08 |
stevebaker[m] | :D | 22:11 |
opendevreview | Steve Baker proposed openstack/ironic master: Respond to rpc requests on stop until hash ring reset https://review.opendev.org/c/openstack/ironic/+/872601 | 22:23 |
TheJulia | JayF: couple minor things on https://review.opendev.org/c/openstack/ironic/+/872361 but overall lgtm, you might want to glance at the comments | 22:40 |
TheJulia | stevebaker[m]: +2'ed | 22:45 |
TheJulia | stevebaker[m]: super great suggestion w/r/t metrics lock logging | 22:49 |
TheJulia | since the lock stuff also for images is super annoying noisy even though it is needed. I don't think I've ever needed it in troubleshooting anything with ironic... ever | 22:51 |
stevebaker[m] | I wonder if we should do other tweaks to logging defaults | 22:59 |
TheJulia | ++ | 23:13 |
TheJulia | vanou: I guess the bulk of the code in https://review.opendev.org/c/openstack/ironic/+/823790 is also in relation to the need in your case to also handle the difference in capabilities with the shared filesystem between irmc controllers... which makes more sense actually. Thank you for the additional comments | 23:13 |
TheJulia | vanou: the pep8 failures need to be fixed :) | 23:15 |
opendevreview | Julia Kreger proposed openstack/ironic master: Set lockutils default logging https://review.opendev.org/c/openstack/ironic/+/872608 | 23:56 |
TheJulia | stevebaker[m]: my local log is so much quieter with ^^^ :) | 23:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!