| opendevreview | Jay Faulkner proposed openstack/ironic master: Allow port queries by shard list https://review.opendev.org/c/openstack/ironic/+/872361 | 00:16 |
|---|---|---|
| JayF | I need some docs updates, but that should be reviewable | 00:16 |
| JayF | haven't touched api_ref for the ports change, haven't done the sharded=true change yet | 00:16 |
| JayF | going to tackle that tomorrow | 00:16 |
| rpittau | good morning ironic! o/ | 08:17 |
| rpittau | JayF: re virtualpdu: I'll move forward with the adoption steps then, keep you and the rest of the community informed, thanks! | 08:22 |
| MikeCTZA | morning (here anyway) ironic, been ages since I've had chance to work on my ironic setup with other priorities, back at it now | 08:31 |
| MikeCTZA | having a few networking challenges, but not sure I'm doing things right so ... if anyone has any experience would be cool to ping a few ideas/questions off someone | 08:35 |
| opendevreview | Verification of a change to openstack/ironic stable/xena failed: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871039 | 09:31 |
| opendevreview | Merged openstack/ironic-python-agent bugfix/9.3: Update .gitreview for bugfix/9.3 https://review.opendev.org/c/openstack/ironic-python-agent/+/872287 | 09:57 |
| opendevreview | Merged openstack/ironic bugfix/21.3: Update .gitreview for bugfix/21.3 https://review.opendev.org/c/openstack/ironic/+/872319 | 10:24 |
| opendevreview | Merged openstack/ironic-inspector bugfix/11.3: Update .gitreview for bugfix/11.3 https://review.opendev.org/c/openstack/ironic-inspector/+/872288 | 10:24 |
| iurygregory | good morning Ironic | 12:12 |
| opendevreview | Merged openstack/ironic stable/xena: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871039 | 12:56 |
| vanou | Good morning ironic | 13:08 |
| vanou | JayF: Regarding review on https://review.opendev.org/c/openstack/ironic/+/870880, my explanation was not good and makes you misunderstand situation. I adds explanation to Gerrit. So please check it. Thanks. | 13:09 |
| *** dking is now known as Guest3146 | 14:38 | |
| opendevreview | Dan Smith proposed openstack/ironic master: DNM: Test ironic against nova stable uuid change https://review.opendev.org/c/openstack/ironic/+/871838 | 14:39 |
| opendevreview | Kaifeng Wang proposed openstack/ironic master: Relaxing console pid looking https://review.opendev.org/c/openstack/ironic/+/871262 | 14:47 |
| kubajj | JayF: about https://review.opendev.org/c/openstack/ironic/+/871394/comments/0b3199d5_204e2310 I think I am already doing this. The SwiftObjectStillExists contains a message about it which is then logged: https://review.opendev.org/c/openstack/ironic/+/871394/8/ironic/common/exception.py#871 | 14:49 |
| dtantsur | TheJulia: https://review.opendev.org/c/openstack/requirements/+/872065 includes SQLA 2.0, the failures are weird | 14:59 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: Erase swift inventory entry on node deletion https://review.opendev.org/c/openstack/ironic/+/871394 | 15:14 |
| TheJulia | hmm, looks like something else has changed | 15:16 |
| TheJulia | at least since we tried on the beta1 release | 15:16 |
| TheJulia | I wouldn't expect it to really work though until we get rid of the autocommit flag | 15:17 |
| TheJulia | I need to do a couple different things this morning, but I'll give it as spin and peel off the patch and see how bad (or good) things are | 15:18 |
| opendevreview | Jonathan Rosser proposed openstack/ironic master: Fix debug log message argument formatting https://review.opendev.org/c/openstack/ironic/+/866856 | 15:37 |
| TheJulia | yeah, looks like we're going to need to revise our test database invocation code | 15:37 |
| TheJulia | which is why basically every test fails right now | 15:37 |
| TheJulia | hmmm... just creating a connection detonates | 15:51 |
| opendevreview | Verification of a change to openstack/ironic stable/zed failed: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871032 | 15:55 |
| opendevreview | Verification of a change to openstack/ironic stable/yoga failed: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871053 | 15:56 |
| JayF | kubajj: AFAICT; that sets a message *on the exception* but does not log it | 16:09 |
| JayF | kubajj: it's possible I'm missing something though | 16:09 |
| kubajj | JayF: I thought that the e in https://review.opendev.org/c/openstack/ironic/+/871394/8/ironic/conductor/manager.py#2033 is logged | 16:11 |
| rpittau | so virtualpdu is now python 3.8/3.10 compliant https://review.opendev.org/c/x/virtualpdu/+/869983 just need approval and reviews | 16:20 |
| JayF | kubajj: ++ I understand | 16:23 |
| TheJulia | ... so it is the ping listener | 16:23 |
| JayF | Anyone else wanna PTL? :P | 16:33 |
| rpittau | lol | 16:33 |
| JayF | If not, I'm going to re-nominate myself. Hopefully I learned a thing at all. | 16:33 |
| JayF | But we really should line up someone else for C or D cycle | 16:33 |
| JayF | do a warm handover | 16:33 |
| JayF | rpittau: as the first person to speak, you've volunteered, thanks ;) | 16:33 |
| TheJulia | lol | 16:34 |
| *** rpittau is now known as elfosardo | 16:34 | |
| elfosardo | who? | 16:34 |
| TheJulia | JayF: that is *evil* | 16:34 |
| * TheJulia feels stumped | 16:37 | |
| *** elfosardo is now known as rpittau | 16:43 | |
| rpittau | good night! o/ | 16:43 |
| JayF | TheJulia: what has ya stumped? | 17:14 |
| JayF | I have time if you need unstumping | 17:14 |
| JayF | or we can stump together lol | 17:14 |
| TheJulia | sqlalchemy 2.0 with our unit tests | 17:24 |
| TheJulia | it changed after 2.0.0b1 and now fails on .. | 17:24 |
| TheJulia | oh | 17:24 |
| TheJulia | actually, i might have just figured this out | 17:24 |
| NobodyCam | Good Morning Ironic Folks, Happy Hump day | 17:25 |
| JayF | o/ | 17:25 |
| JayF | NobodyCam: hey, you're at NVIDIA, right? | 17:25 |
| JayF | NobodyCam: Can you please help me make sure a docs followup happens to that HW mgr PR I merged yesterday? :D | 17:25 |
| NobodyCam | can you shoot me the link? | 17:26 |
| JayF | https://review.opendev.org/c/openstack/ironic-python-agent/+/566544/36#message-1d51201b7d2818f3cb7e8bdabb8f2db47bd1a93a | 17:26 |
| JayF | that one moved a bit slowly, so I presume whoever is working on it has a stuffed-full plate | 17:27 |
| JayF | so just wanted to make sure the docs patch didn't fall off the edge LOL | 17:27 |
| * JayF might have been guilty of that a time or two | 17:27 | |
| * TheJulia suspects we've all been guilty of it at least twice ;) | 17:28 | |
| TheJulia | JayF: so... the bump of the requirements repo ended up with errors like: https://zuul.opendev.org/t/openstack/build/34d9e8af0c334e30bd5738a5d8dc198a | 17:29 |
| TheJulia | and between 2.0.0b1 which we tested and 2.0.0, https://github.com/sqlalchemy/sqlalchemy/commit/5c6081ddb03447697f909a03572b6d6d79e61b71#diff-d7d8e1d13beabd529adc4c29b2f9c2d5091210fcdad4ac9163a42a893409205b occured | 17:30 |
| TheJulia | but, that in itself is not an issue, it seems the method name for the callback is actually problematic, at least that is as far as I got to begin looking at oslo_db. | 17:31 |
| TheJulia | to the point of changing line 219 from event.listen(engine, "engine_connect", _connect_ping_listener) to event.listen(engine, "connect", _connect_ping_listener) and the unit tests pass with flying colors. | 17:32 |
| JayF | *blink* | 17:32 |
| TheJulia | in oslo.db's oslo_db/sqlalchemy/engine.py | 17:32 |
| JayF | do you understand why? | 17:32 |
| TheJulia | yeah. Exactly | 17:32 |
| TheJulia | no, I have no understanding *why* | 17:32 |
| TheJulia | it makes "" <-- that much sense to me | 17:32 |
| JayF | yeah I've got nothing | 17:33 |
| JayF | can we ask the upstream? | 17:34 |
| TheJulia | I guess we will have to ask oslo folk | 17:34 |
| TheJulia | I starte ddown the path of entirely changing the decorator | 17:34 |
| TheJulia | and found it behaved the same exact way to the new style decorator indicator, so then I just changed the name and *boom* it worked | 17:34 |
| TheJulia | and now I'm like.... whaaat?! | 17:34 |
| JayF | have you re-run the tests with it returned to what it was before | 17:35 |
| JayF | to rule out, e.g., a bad pypi upload or something causing stupid-breakage | 17:35 |
| TheJulia | of oslo.db | 17:36 |
| TheJulia | ? | 17:36 |
| * TheJulia re-runs all unit tests just to make sure | 17:37 | |
| JayF | of sqla | 17:37 |
| JayF | I'm conjecturing about if /something else/ could | 17:37 |
| JayF | have changed the behavior | 17:38 |
| JayF | basically if the facts as they seem are unbelievable, find better facts lol | 17:38 |
| *** Guest3146 is now known as dking | 17:41 | |
| TheJulia | heh | 17:43 |
| TheJulia | once my tox run is done, I'll double check the version at least | 17:43 |
| TheJulia | making sure we don't have any hidden errors in the test run output | 17:43 |
| TheJulia | yeah, no unexpected deprecation warnings | 17:47 |
| opendevreview | Merged openstack/ironic bugfix/21.0: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871033 | 17:47 |
| TheJulia | 2.0.0 | 17:47 |
| dking | You guys are working late this morning. | 17:48 |
| JayF | it's 9:50am Pacific time :) | 17:49 |
| ashinclouds[m] | Indeed! | 17:54 |
| ashinclouds[m] | Err | 17:54 |
| TheJulia | Indeed! | 17:54 |
| TheJulia | Much better | 17:54 |
| TheJulia | JayF: take a look at slide 9 now | 18:30 |
| JayF | TheJulia: I really like the idea of taking this narrative in the direction of "we are part of the problem" when talking about that | 18:33 |
| TheJulia | ++ | 18:33 |
| TheJulia | should I add another animation transition? | 18:33 |
| JayF | I haven't looked at any of the transitions | 18:34 |
| TheJulia | hmmm | 18:34 |
| TheJulia | actually, I'm going to collapse in slide 11 | 18:34 |
| TheJulia | hmmm | 18:39 |
| TheJulia | flow is difficult here | 18:39 |
| TheJulia | JayF: I love "fog of war" | 18:48 |
| JayF | I don't, I turn it off in all my RTS's ;) | 18:48 |
| TheJulia | lol | 18:49 |
| opendevreview | Merged openstack/ironic bugfix/20.2: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871052 | 19:49 |
| opendevreview | Merged openstack/ironic stable/yoga: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871053 | 20:27 |
| opendevreview | Merged openstack/ironic stable/zed: Fix selinux context of published image hardlink https://review.opendev.org/c/openstack/ironic/+/871032 | 20:27 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: API support for CRUD node.shard https://review.opendev.org/c/openstack/ironic/+/866235 | 22:10 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Allow port queries by shard list https://review.opendev.org/c/openstack/ironic/+/872361 | 22:10 |
| JayF | TheJulia: ^ curious if you think my updates to shard api-ref is sufficient operator docs until we get networking-baremetal or nova driver using shards... | 22:11 |
| JayF | if so; this change should be completely ready to review and land | 22:11 |
| JayF | aw hell, except the /v1/nodes?sharded=true | 22:11 |
| JayF | well, i'll do that in a follow on and leave these alone, since they are good and well tested | 22:11 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: API support for CRUD node.shard https://review.opendev.org/c/openstack/ironic/+/866235 | 22:54 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Allow port queries by shard list https://review.opendev.org/c/openstack/ironic/+/872361 | 22:55 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Add support for filtering for sharded nodes https://review.opendev.org/c/openstack/ironic/+/872472 | 22:55 |
| JayF | NOW that is completely ready for review | 22:55 |
| JayF | including sharded support | 22:55 |
| opendevreview | Merged openstack/ironic master: Fix snmp driver sleep call count https://review.opendev.org/c/openstack/ironic/+/861393 | 23:07 |
| vanou | good morning ironic | 23:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!