| opendevreview | Jacob Anders proposed openstack/sushy master: Fix setting boot related attributes https://review.opendev.org/c/openstack/sushy/+/856597 | 00:30 |
|---|---|---|
| janders | ^ finally this one should be good to go - fixed up the final tests | 00:32 |
| janders | (thank you for the +2 earlier TheJulia - have another look if you have time :) | 00:32 |
| *** tkajinam is now known as Guest2162 | 02:04 | |
| *** tkajinam is now known as Guest2174 | 03:28 | |
| *** tkajinam is now known as Guest2179 | 05:36 | |
| opendevreview | Merged openstack/ironic master: Change boot_interface order of iRMC driver https://review.opendev.org/c/openstack/ironic/+/862616 | 05:54 |
| arne_wiebalck | Good morning, Ironic! | 07:22 |
| kubajj | Good morning arne_wiebalck and Ironic! | 07:55 |
| rpittau | good morning ironic! o/ | 08:16 |
| arne_wiebalck | hey rpittau and kubajj o/ | 08:31 |
| rpittau | hey arne_wiebalck :) | 08:31 |
| opendevreview | Merged openstack/sushy master: Fix setting boot related attributes https://review.opendev.org/c/openstack/sushy/+/856597 | 09:20 |
| opendevreview | kamlesh chauvhan proposed openstack/sushy master: Fix volume deletion on newer iDRACs https://review.opendev.org/c/openstack/sushy/+/864845 | 09:24 |
| janders | ^ \o/ took a while but the SettingsURI/Lenovo fix has merged. Thank you to all involved! | 09:36 |
| opendevreview | Merged openstack/ironic master: Add ports statistics to tools/benchmark scripts https://review.opendev.org/c/openstack/ironic/+/864762 | 09:52 |
| opendevreview | Verification of a change to openstack/ironic bugfix/19.0 failed: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/864465 | 10:06 |
| opendevreview | Verification of a change to openstack/ironic bugfix/18.1 failed: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/864466 | 10:13 |
| opendevreview | Merged openstack/ironic stable/xena: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/850554 | 10:44 |
| opendevreview | Merged openstack/ironic stable/wallaby: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/850707 | 10:48 |
| opendevreview | Merged openstack/ironic stable/wallaby: Remove un-needed tabs from script https://review.opendev.org/c/openstack/ironic/+/865192 | 10:48 |
| opendevreview | Harald Jensås proposed openstack/ironic master: benchmark: Create chassis, set chassis_id for node https://review.opendev.org/c/openstack/ironic/+/865270 | 12:04 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [WIP] [PoC] A metal3 CI job https://review.opendev.org/c/openstack/ironic/+/863873 | 13:38 |
| *** hjensas is now known as hjensas|afk | 16:57 | |
| opendevreview | Julia Kreger proposed openstack/ironic-lib master: Provide an interface to store metrics https://review.opendev.org/c/openstack/ironic-lib/+/865311 | 16:59 |
| TheJulia | JayF: ^ might interest you | 17:00 |
| JayF | ack | 17:00 |
| TheJulia | iurygregory: so, steve and I are pondering hijacking the prometheus exporter to get more metrics data out of ironic, and I think ^ is our avenue to use the ye olde metrics framework | 17:00 |
| TheJulia | ideally get things like a gauge counter of nodes in maintenance, number of tasks launched, etc | 17:08 |
| iurygregory | TheJulia, that would be awesome | 17:09 |
| iurygregory | if you need help let me know | 17:09 |
| TheJulia | I don't think so, it seems like a relatively easy thing to do with some additional metrics hooks needing to be added to the conducotr | 17:10 |
| TheJulia | ultimately, a first ironic_lib review would be appreciated | 17:10 |
| iurygregory | ack, I will add to my list | 17:10 |
| iurygregory | the one above right? | 17:11 |
| TheJulia | yes please | 17:11 |
| TheJulia | its the first step, since we need to save the data somehow to be able to get it back out | 17:12 |
| kubajj | TheJulia: Is it possible to mock the node_inventory object for testing in https://review.opendev.org/c/openstack/ironic/+/864057/ ? | 17:15 |
| dtantsur | I think it's not unreasonable for something called ironic-prometheus-exporter to also export ironic-native stuff | 17:15 |
| kubajj | or dtantsur, I didn't know that you were still around | 17:15 |
| TheJulia | kubajj: should be, any reason not to use the base object, just not saved to the db yet? | 17:15 |
| dtantsur | kubajj: you can mock nearly anything in python, but you also just let the temporary database take it | 17:15 |
| * dtantsur had a driving lesson in the morning, so staying a bit later | 17:16 | |
| kubajj | This is the particular test I am trying to fix: https://paste.opendev.org/show/blOXcn4lz7TatMAj5vFy/ | 17:17 |
| dtantsur | kubajj: it's hinting you that mock_gate_data.return_value is a Mock, not a dict | 17:17 |
| dtantsur | so you cannot use it as a dict | 17:18 |
| dtantsur | you only need to drop mock.Mock from line 8 and let it be a real dict | 17:18 |
| rpittau | good night! o/ | 17:18 |
| * dtantsur is trying to understand what mock.Mock{some dict}) actually does | 17:19 | |
| dtantsur | kubajj: aha. when you do mock.Mock({..}) you don't get what you think you do. what you do get is a completely mocked object that just happens to have the same methods as a dict. | 17:20 |
| dtantsur | at least that's what I can deduce from a short experiment | 17:21 |
| dtantsur | tl;dr just use a real dict for return_value | 17:21 |
| TheJulia | dtantsur: that matches my understanding, fwiw | 17:21 |
| kubajj | dtantsur: I see. Interesting | 17:21 |
| dtantsur | kubajj: generally, if you end up doing some_mock.return_value = mock.Mock(..), you may be doing it wrong | 17:21 |
| dtantsur | any Mock's return_value is a Mock by default, unless you set it to something else | 17:21 |
| dtantsur | hence this is absolutely valid code: | 17:22 |
| dtantsur | >>> mock.Mock()()()()()() | 17:22 |
| dtantsur | <Mock name='mock()()()()()' id='139807865347840'> | 17:22 |
| dtantsur | >>> mock.Mock()().banana()(answer=42)()().STOP_IT | 17:22 |
| dtantsur | <Mock name='mock().banana()()()().STOP_IT' id='139807865351200'> | 17:22 |
| dtantsur | you get the idea :) | 17:22 |
| dtantsur | once you pass something to Mock(), this something becomes a *spec*, i.e. the object that this Mock resembles | 17:23 |
| dtantsur | resembles == has the same method, but completely mocked | 17:23 |
| * dtantsur hopes he didn't scare kubajj away with his examples :) | 17:30 | |
| kubajj | dtantsur: definitely not, I am just trying to figure out another error 😀 | 17:31 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: WIP: Get inventory from Inspector https://review.opendev.org/c/openstack/ironic/+/864057 | 17:35 |
| kubajj | dtantsur: I think this line is causing an issue: https://review.opendev.org/c/openstack/ironic/+/864057/3/ironic/drivers/modules/inspector.py#370 | 17:36 |
| dtantsur | kubajj: it may be your testing data. in the paste above, inventory is a string "cpu" | 17:38 |
| dtantsur | you cannot serialize that to a JSON dict | 17:38 |
| dtantsur | probably a typo | 17:38 |
| kubajj | dtantsur: yes, that was the issue. Thanks | 17:40 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: WIP: Get inventory from Inspector https://review.opendev.org/c/openstack/ironic/+/864057 | 17:58 |
| kubajj | dtantsur: TheJulia: would something like this be enough for the testing of this change? | 17:59 |
| *** dmellado_ is now known as dmellado | 18:01 | |
| *** dmellado_ is now known as dmellado | 18:04 | |
| dtantsur | kubajj: you also need to load the created record from the database and check that it matches the fake data | 18:20 |
| * dtantsur is calling it a day, chat with you tomorrow | 18:20 | |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: Get inventory from Inspector https://review.opendev.org/c/openstack/ironic/+/864057 | 18:38 |
| stevebaker[m] | good morning | 19:34 |
| TheJulia | o/ | 20:22 |
| JayF | Hey all; I'm out in the next hour or two until next Monday (11/28). If you need me; say so quickly :D | 22:01 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!