*** Guest6022 is now known as rcastillo | 04:22 | |
opendevreview | Aija Jauntēva proposed openstack/sushy master: Add new Storage controllers https://review.opendev.org/c/openstack/sushy/+/850899 | 06:54 |
---|---|---|
rpittau | good morning ironic! o/ | 08:22 |
*** bodgix0 is now known as bodgix | 08:32 | |
opendevreview | Jakub Jelinek proposed openstack/ironic-python-agent master: WIP: Enable skipping disks for cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/850861 | 08:36 |
opendevreview | Bartosz Bezak proposed openstack/tenks master: [CI] Drop Python 3.7 job. Fix ansible-lint errors. https://review.opendev.org/c/openstack/tenks/+/850879 | 09:09 |
*** tosky_ is now known as tosky | 09:10 | |
opendevreview | Jakub Jelinek proposed openstack/ironic-python-agent master: WIP: Enable skipping disks for cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/850861 | 09:27 |
kubajj | dtantsur TheJulia in the proposed change above I create the helper function which lists block devices that are not on the devices_skip_list field in driver_info. Do you think that this is going in the right direction or do you have any suggestions on for changes? | 09:35 |
dtantsur | I have some reservations about driver_info given that root_device is part of properties | 09:36 |
kubajj | Should I just put it into properties then? | 09:36 |
dtantsur | ideally (only ideally!) we should stop shoving more stuff into free-form JSON fields and start using normal node-level fields | 09:38 |
dtantsur | but in the harsh reality we live in, properties seems the right place | 09:38 |
arne_wiebalck | Good morning, Ironic! | 10:10 |
iurygregory | good morning Ironic | 11:33 |
opendevreview | Dmitry Tantsur proposed openstack/sushy master: Better logging when registries are not available https://review.opendev.org/c/openstack/sushy/+/851023 | 11:53 |
opendevreview | Dmitry Tantsur proposed openstack/sushy master: Better logging when registries are not available https://review.opendev.org/c/openstack/sushy/+/851023 | 12:00 |
opendevreview | Dmitry Tantsur proposed openstack/sushy master: Better logging when registries are not available https://review.opendev.org/c/openstack/sushy/+/851023 | 12:09 |
opendevreview | Verification of a change to openstack/python-ironicclient stable/wallaby failed: Fix logging in the baremetal CLI https://review.opendev.org/c/openstack/python-ironicclient/+/850487 | 13:11 |
opendevreview | Merged openstack/tenks master: [CI] Drop Python 3.7 job. Fix ansible-lint errors. https://review.opendev.org/c/openstack/tenks/+/850879 | 13:25 |
opendevreview | Bartosz Bezak proposed openstack/tenks master: Add Ubuntu 22.04 Jammy support https://review.opendev.org/c/openstack/tenks/+/850860 | 13:32 |
* TheJulia is sooo tired | 13:52 | |
TheJulia | I guess properties does kind of also make sense. I could see positives and negatives in an RBAC enforce environment but at some point it all comes down to preferences/processes and not everyone's processes will ever be the same | 13:53 |
TheJulia | unless we create absolute perfection | 13:53 |
opendevreview | Jakub Jelinek proposed openstack/ironic-python-agent master: WIP: Enable skipping disks for cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/850861 | 14:13 |
opendevreview | Verification of a change to openstack/sushy-tools master failed: Fix per-request memoization https://review.opendev.org/c/openstack/sushy-tools/+/840780 | 14:15 |
opendevreview | Verification of a change to openstack/sushy-tools master failed: Document SUSHY_EMULATOR_ALLOWED_INSTANCES https://review.opendev.org/c/openstack/sushy-tools/+/840804 | 14:15 |
rpittau | interesting, more unit tests failing | 14:15 |
rpittau | in a patch where the unit tests are not touched at all | 14:16 |
rpittau | in a test that was last touched 9 months ago | 14:19 |
rpittau | wonderful | 14:19 |
dtantsur | magic \o/ | 14:23 |
opendevreview | Merged openstack/metalsmith stable/wallaby: Do a precise node lookup for unprovision https://review.opendev.org/c/openstack/metalsmith/+/849586 | 14:28 |
rpittau | <WrapperTestResponse streamed [500 INTERNAL SERVER ERROR]> | 14:30 |
rpittau | lol | 14:30 |
TheJulia | sweet | 14:32 |
iurygregory | rpittau, do you have a link? | 14:33 |
rpittau | iurygregory: any sushy-tools patch | 14:33 |
iurygregory | rpittau, ack | 14:33 |
rpittau | I'm starting to think somwthing wrong with Flask | 14:34 |
rpittau | ok I'm onto something, run tests with older uc and it works | 14:38 |
rpittau | yep, latest uc update broke sushy-tools unit tests, most likely werkzeug | 14:41 |
dtantsur | again :) | 14:42 |
rpittau | well so we stay alert :) | 14:42 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Stop documenting netboot and the boot_option capability https://review.opendev.org/c/openstack/ironic/+/851037 | 14:43 |
dtantsur | untangling netboot from the ramdisk boot is.. not trivial | 14:48 |
rpittau | yep, confirmed Werkzeug 2.2.0 broke something | 14:51 |
opendevreview | Julia Kreger proposed openstack/ironic master: Fix ilo boot interface order https://review.opendev.org/c/openstack/ironic/+/851039 | 14:56 |
opendevreview | Bartosz Bezak proposed openstack/tenks master: Add Ubuntu 22.04 Jammy support. https://review.opendev.org/c/openstack/tenks/+/850860 | 14:57 |
dtantsur | RFC: enable the ramdisk deploy by default? any caveats? | 14:59 |
TheJulia | no caveats that I can think of | 15:18 |
TheJulia | just not at the front of the list please :) | 15:19 |
dtantsur | heh, this is clear :) | 15:20 |
dtantsur | # NOTE(TheJulia): Remove elilo support after the deprecation period, | 15:20 |
dtantsur | # in the Queens release. | 15:21 |
dtantsur | a bit overdue :D | 15:21 |
TheJulia | bahahahaha | 15:21 |
TheJulia | I thought I did.... | 15:21 |
dtantsur | maybe it's only unit tests | 15:21 |
opendevreview | Merged openstack/metalsmith stable/yoga: Do a precise node lookup for unprovision https://review.opendev.org/c/openstack/metalsmith/+/849584 | 15:25 |
opendevreview | Verification of a change to openstack/metalsmith stable/xena failed: Do a precise node lookup for unprovision https://review.opendev.org/c/openstack/metalsmith/+/849585 | 15:25 |
TheJulia | There really wasn't much to it | 15:26 |
rpittau | mmm apparently latest Werkzeug doesn't really like how we implemented virtual_media and certificate_service in sushy-tools, still get to understand why | 15:29 |
dtantsur | something changed around blueprints handling? | 15:32 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: WIP finally remove netboot https://review.opendev.org/c/openstack/ironic/+/850240 | 15:32 |
rpittau | I'm trying to understand | 15:33 |
rpittau | Flask support for Werkzeug 2.2 becomes explicit 2 days ago | 15:34 |
TheJulia | file under "rutro" | 15:35 |
rpittau | it's not even getting here https://github.com/openstack/sushy-tools/blob/master/sushy_tools/emulator/controllers/virtual_media.py#L27 | 15:43 |
TheJulia | ugh | 15:47 |
dtantsur | another RFC: what if IPA could accept several Ironic URL to try? | 15:53 |
dtantsur | context: the Ironic pod moving between masters | 15:53 |
TheJulia | makes a lot of sense to me | 16:00 |
rpittau | mmm ok doesn't work without trailing slash at the end anymore | 16:15 |
rpittau | /VirtualMedia -> 404 ; /Virtualmedia/ -> 200 | 16:16 |
rpittau | awesome! | 16:16 |
dtantsur | lovely | 16:17 |
rpittau | so.... yeah, I just verified if we add a '/' after VirtualMedia and CertificateService the tests are ok | 16:24 |
rpittau | I'm not sure how do we want to handle that, I will just push a "fix" before leaving | 16:24 |
opendevreview | Riccardo Pittau proposed openstack/sushy-tools master: Fix unit tests for Werkzeug 2.2.0 https://review.opendev.org/c/openstack/sushy-tools/+/851070 | 16:24 |
rpittau | ^ the workaround | 16:25 |
rpittau | mmmm | 16:27 |
rpittau | I'll get another look tomorrow if noone else does before | 16:34 |
rpittau | good night! o/ | 16:34 |
dtantsur | rpittau: I think we need to fix the actual API, otherwise the consumers could get broken | 16:40 |
iurygregory | +1 ^ | 16:41 |
TheJulia | talking to people is mentally expensive | 17:00 |
TheJulia | so... technically any time you are accessing a directory resource, your supposed to have a trailing / | 17:01 |
TheJulia | any time you touch it without, it is supposed to redirect you | 17:01 |
TheJulia | but that might not be super true in resty things | 17:01 |
TheJulia | at least in file serving webservers is is | 17:01 |
opendevreview | Merged openstack/tenks master: Add Ubuntu 22.04 Jammy support. https://review.opendev.org/c/openstack/tenks/+/850860 | 17:22 |
TheJulia | Are sushy-tools issues why ironic-tempest-uefi-redfish-vmedia is not happy? | 17:51 |
iurygregory | TheJulia, can be (I haven't checked) but I know this job uses sushy-tools | 17:55 |
iurygregory | or it's other job that uses | 17:55 |
iurygregory | let me double check | 17:55 |
iurygregory | ok, at least based in the zuul config only ironic-tempest-bios-redfish-pxe requires sushy-tools | 17:57 |
iurygregory | https://opendev.org/openstack/ironic/src/branch/master/zuul.d/ironic-jobs.yaml#L220-L224 | 17:57 |
iurygregory | but from the job logs we do install sushy-tools in the vmedia job (not sure why it's not as required-project...) | 17:58 |
iurygregory | Successfully installed sushy-tools-0.19.0 | 17:58 |
opendevreview | Julia Kreger proposed openstack/sushy stable/yoga: Handle AccessError with Basic Auth instead of "reauth" https://review.opendev.org/c/openstack/sushy/+/851059 | 18:01 |
opendevreview | Julia Kreger proposed openstack/sushy stable/xena: Handle AccessError with Basic Auth instead of "reauth" https://review.opendev.org/c/openstack/sushy/+/851060 | 18:01 |
opendevreview | Julia Kreger proposed openstack/sushy stable/wallaby: Handle AccessError with Basic Auth instead of "reauth" https://review.opendev.org/c/openstack/sushy/+/851061 | 18:01 |
iurygregory | weird that we don't have any logs in the ironic-bm-logs folder O.o for the ironic-tempest-uefi-redfish-vmedia that failed | 19:08 |
stevebaker[m] | This gate fixer could do with some reviews https://review.opendev.org/c/openstack/sushy-tools/+/851070 | 21:50 |
TheJulia | stevebaker[m]: approved | 21:54 |
stevebaker[m] | ta | 21:56 |
opendevreview | Merged openstack/sushy-tools master: Fix unit tests for Werkzeug 2.2.0 https://review.opendev.org/c/openstack/sushy-tools/+/851070 | 22:03 |
janders | good morning Ironic o/ | 23:26 |
stevebaker[m] | good morning | 23:49 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!