| janders | context: I wanted to test a manual run of clear_job_queue/reset_idrac (e.g. https://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/drac/management.py#L597) | 00:00 |
|---|---|---|
| janders | but just baremetal node clean test01 --clean-steps '[{"interface": "management", "step": "clear_job_queue"}]' boots the node into ramdisk which is unnecessary | 00:00 |
| TheJulia | janders: I *believe* it is an argument | 00:31 |
| janders | TheJulia: to the CLI call? | 00:31 |
| TheJulia | to the step being passed in. My memory is a bit fuzzy | 00:31 |
| janders | OK! will look into this, thank you TheJulia | 00:32 |
| stevebaker | TheJulia: I did a grubby thing https://review.opendev.org/c/openstack/diskimage-builder/+/804002/1/diskimage_builder/elements/bootloader/finalise.d/50-bootloader | 00:47 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Allow initial versions to not be created yet https://review.opendev.org/c/openstack/ironic/+/804003 | 00:48 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Implements node history: database https://review.opendev.org/c/openstack/ironic/+/768009 | 00:48 |
| TheJulia | stevebaker: oooh ahhh | 00:50 |
| stevebaker | I should build some images locally | 00:50 |
| TheJulia | ++ | 00:51 |
| TheJulia | I think I'm going to go make a pizza | 00:51 |
| stevebaker | ++ | 00:58 |
| opendevreview | Merged openstack/ironic-python-agent-builder master: Revert "Allow configuration of paths to prune" https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/803967 | 01:32 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Add support for verify steps https://review.opendev.org/c/openstack/ironic/+/800001 | 01:36 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Add support for verify steps https://review.opendev.org/c/openstack/ironic/+/800001 | 01:46 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Make reset_idrac and clear_job_queue verify steps https://review.opendev.org/c/openstack/ironic/+/800001 | 02:29 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Add support for verify steps https://review.opendev.org/c/openstack/ironic/+/800001 | 02:39 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Make reset_idrac and clear_job_queue verify steps https://review.opendev.org/c/openstack/ironic/+/804032 | 02:41 |
| *** pmannidi is now known as pmannidi|Lunch | 03:52 | |
| opendevreview | Jacob Anders proposed openstack/ironic master: Make reset_idrac and clear_job_queue verify steps https://review.opendev.org/c/openstack/ironic/+/804032 | 04:11 |
| opendevreview | Jacob Anders proposed openstack/ironic master: [WIP] Add support for verify steps https://review.opendev.org/c/openstack/ironic/+/800001 | 04:32 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Add support for verify steps https://review.opendev.org/c/openstack/ironic/+/800001 | 04:53 |
| *** pmannidi|Lunch is now known as pmannidi | 04:54 | |
| iurygregory | good morning janders and Ironic o/ | 06:13 |
| janders | good morning iurygregory | 06:13 |
| *** rpittau|afk is now known as rpittau | 06:15 | |
| rpittau | good morning ironic! o/ | 06:16 |
| iurygregory | morning rpittau o/ | 06:17 |
| rpittau | hey iurygregory :) | 06:17 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Add support for verify steps https://review.opendev.org/c/openstack/ironic/+/800001 | 06:26 |
| rpittau | TheJulia, JayF, glad to see reverting the patch worked, the size is back to normal, weird enough I remember testing it before approving :/ | 06:33 |
| janders | good morning rpittau | 06:35 |
| iurygregory | rpittau, which patch we reverted? | 06:47 |
| arne_wiebalck | Good morning rpittau janders iurygregory and Ironic! | 06:55 |
| iurygregory | morning arne_wiebalck o/ | 06:56 |
| rpittau | hey janders, arne_wiebalck :) | 07:13 |
| rpittau | iurygregory: https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/803967 | 07:13 |
| iurygregory | rpittau, gotcha | 07:14 |
| opendevreview | Merged openstack/ironic-python-agent master: Add lower-constraints job to current development branch https://review.opendev.org/c/openstack/ironic-python-agent/+/803453 | 07:51 |
| cenne | Good morning Ironic! | 08:10 |
| opendevreview | Riccardo Pittau proposed openstack/networking-baremetal master: Add lower-constraints job to current development branch https://review.opendev.org/c/openstack/networking-baremetal/+/803933 | 08:14 |
| opendevreview | Riccardo Pittau proposed openstack/networking-generic-switch master: Add lower-constraints job to current development branch https://review.opendev.org/c/openstack/networking-generic-switch/+/803939 | 08:17 |
| opendevreview | Riccardo Pittau proposed openstack/networking-baremetal master: Add lower-constraints job to current development branch https://review.opendev.org/c/openstack/networking-baremetal/+/803933 | 08:17 |
| arne_wiebalck | Good morning, cenne o/ | 08:34 |
| iurygregory | morning cenne o/ | 08:36 |
| cenne | Hey arne_wiebalck | 08:36 |
| cenne | Hey iurygregory | 08:36 |
| arne_wiebalck | Anyone managing Arm servers with Ironic? | 08:37 |
| cenne | iurygregory: Do you want to shoo away Boo? Can they stay?? | 08:37 |
| iurygregory | arne_wiebalck, well I know that some people at RH were trying | 08:38 |
| iurygregory | cenne, well not the literal emoji I would say =) | 08:38 |
| arne_wiebalck | iurygregory: any idea if that worked? | 08:43 |
| arne_wiebalck | iurygregory: we are getting some arm servers and of course I would like to move them through the Ironic pipeline | 08:44 |
| iurygregory | arne_wiebalck, I don't remember but I can try to ask around in the afternoon (I think the people that want to try are US based) | 08:45 |
| arne_wiebalck | iurygregory: that would be great, thank you! | 08:46 |
| iurygregory | I do recall that we didn't have packages for arm, rpittau can you confirm? | 08:46 |
| arne_wiebalck | should I expect Zuul to work ok or do I need to go and get some cookies? | 08:50 |
| cenne | ooh. what are cookies? Second time I'm hearing that phrase | 08:59 |
| arne_wiebalck | :-D | 09:00 |
| arne_wiebalck | cookies are sweets to feed the beast | 09:00 |
| iurygregory | cenne, there is HTTP cookie and the special ones we give to zuul | 09:00 |
| iurygregory | for some reason arne_wiebalck is the only person who knows the recipe | 09:01 |
| iurygregory | at CERN they have some special machines to create the cookie we need to give to zuul :D | 09:01 |
| arne_wiebalck | ... and the legend says that Zuul will show mercy with your change when you offer cookies upfront | 09:02 |
| iurygregory | ^ correct | 09:02 |
| arne_wiebalck | *wonders if Zuul follows IRC* | 09:02 |
| * arne_wiebalck has to get used to IRC shortcuts again apparently | 09:03 | |
| iurygregory | the opendev bot's follows to provide information to zuul | 09:03 |
| rpittau | iurygregory: AFAIK there's no packages specifically for arm64 at the moment | 09:07 |
| rpittau | but I think we're talking about managing arm64 servers, not installing ironic on arm64 servers | 09:09 |
| rpittau | that should be possible, probably needs some config change, maybe a different ramdisk | 09:12 |
| rpittau | we do support EFI bootloaders for arm64 in ironic-python-agent | 09:12 |
| iurygregory | I remember people asking if something was required to have Ironic working for arm64, like some specific things in ipa | 09:12 |
| arne_wiebalck | rpittau: iurygregory: right, this is for managing arm servers with Ironic (not running Ironic on arm) | 09:42 |
| arne_wiebalck | I would think we would need a different ramdisk, and as we build the ramdisk ourselves I was wondering if someone has done this already | 09:43 |
| iurygregory | arne_wiebalck, probably =) | 09:44 |
| iurygregory | for building the ramdisk yourself =) | 09:44 |
| arne_wiebalck | cenne: please see https://review.opendev.org/c/openstack/ironic/+/801425 | 10:37 |
| arne_wiebalck | cenne: Zuul failed twice, then I offered cookies, and it succeeded | 10:37 |
| iurygregory | Zuul <3 cookies | 10:38 |
| cenne | arne_wiebalck: iurygregory: wow.. this is magik! | 10:42 |
| cenne | I'd have thought Zuul just randomly became happy. We don't even get to see the cookies. :) | 10:44 |
| opendevreview | Merged openstack/ironic-lib master: Add lower-constraints job to current development branch https://review.opendev.org/c/openstack/ironic-lib/+/803628 | 10:57 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Add support for verify steps https://review.opendev.org/c/openstack/ironic/+/800001 | 11:06 |
| rpittau | arne_wiebalck: I guess you can change the base arch in ipa-builder or dib and give it a try | 12:17 |
| arne_wiebalck | rpittau: thanks, will do ... once I get hold of the arm servers :) | 12:18 |
| opendevreview | Arne Wiebalck proposed openstack/ironic master: [Trivial] Fix typo in burn-in docs https://review.opendev.org/c/openstack/ironic/+/804074 | 12:23 |
| rpittau | arne_wiebalck: having the arm servers will definitely help :D | 12:37 |
| arne_wiebalck | In the context of https://review.opendev.org/c/openstack/ironic/+/801425, I had a look at how often Ironic fails to get the power state per attempt. With 8000 nodes and a 300s power sync interval, we get per 12 hours: ~10000 errors on the first attempt, ~200 on the second (~20 on the third ... ~1-2 on the ninth). Looking at how errors are bunched in time, I can see the 5min interval (which is surprising since we | 12:41 |
| arne_wiebalck | have conductor groups). Also, the errors are not equally distributed over controllers (controllers manage different deliveries and have different numbers of nodes to look after) ... it could be another thundering herd problem congesting the management network, but given the change above it looks more like some BMCs like a wake-up call before they agree to reveal the power state ... | 12:41 |
| arne_wiebalck | ... any insights would be more than welcome :) | 12:42 |
| opendevreview | Merged x/sushy-oem-idrac master: Increase version of hacking and pycodestyle https://review.opendev.org/c/x/sushy-oem-idrac/+/803428 | 13:07 |
| TheJulia | arne_wiebalck: arm folks have actually told me they use it, but had to build the binaries themselves | 13:13 |
| opendevreview | Merged x/sushy-oem-idrac master: Fix missing Target@Redfish.AllowableValues https://review.opendev.org/c/x/sushy-oem-idrac/+/800495 | 13:13 |
| arne_wiebalck | TheJulia: thanks, the binaries of ... ? | 13:16 |
| opendevreview | Julia Kreger proposed openstack/ironic-inspector master: Handle NodeLocked failures https://review.opendev.org/c/openstack/ironic-inspector/+/803935 | 13:18 |
| TheJulia | arne_wiebalck: things like ipxe | 13:32 |
| arne_wiebalck | TheJulia: this is to run the server on arm? | 13:32 |
| TheJulia | arne_wiebalck: yes | 13:33 |
| TheJulia | arne_wiebalck: of course, you can also use grub, but the key boot aspect is that the machines also need to have real network boot capability | 13:33 |
| arne_wiebalck | TheJulia: I was not planning to be that ambitious :) I only want to manage arm servers. | 13:33 |
| TheJulia | heh | 13:34 |
| arne_wiebalck | TheJulia: I have been pushing to move the whole life cycle to Ironic, would be great if we do not need to make an exception for arm. | 13:35 |
| opendevreview | Aija Jauntēva proposed x/sushy-oem-idrac stable/wallaby: Fix missing Target@Redfish.AllowableValues https://review.opendev.org/c/x/sushy-oem-idrac/+/804024 | 13:35 |
| arne_wiebalck | TheJulia: we do not have the servers yet, just wanted to check what to expect ... | 13:36 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Allow initial versions to not be created yet https://review.opendev.org/c/openstack/ironic/+/804003 | 13:36 |
| opendevreview | Bob Fournier proposed openstack/ironic master: [WIP] For particular vendors set the boot device prior to installing image https://review.opendev.org/c/openstack/ironic/+/802389 | 13:36 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Implements node history: database https://review.opendev.org/c/openstack/ironic/+/768009 | 13:37 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Record node history and manage events in db https://review.opendev.org/c/openstack/ironic/+/803292 | 13:37 |
| opendevreview | Aija Jauntēva proposed x/sushy-oem-idrac master: Add RAID mode conversion methods https://review.opendev.org/c/x/sushy-oem-idrac/+/799506 | 13:57 |
| *** pmannidi is now known as pmannidi|AFK | 14:07 | |
| opendevreview | Danni Shi proposed openstack/ironic-python-agent master: Add an attestation extension https://review.opendev.org/c/openstack/ironic-python-agent/+/803510 | 14:16 |
| opendevreview | Merged openstack/ironic-inspector master: Add lower-constraints job to current development branch https://review.opendev.org/c/openstack/ironic-inspector/+/803570 | 14:30 |
| opendevreview | Arne Wiebalck proposed openstack/ironic-python-agent master: Check the network burnin roles and partner https://review.opendev.org/c/openstack/ironic-python-agent/+/804092 | 14:39 |
| opendevreview | Verification of a change to openstack/ironic bugfix/18.1 failed: Fix subscription vendor passthru https://review.opendev.org/c/openstack/ironic/+/803678 | 14:43 |
| opendevreview | Leo McGann proposed openstack/ironic master: Adds Attestation Interface to Node https://review.opendev.org/c/openstack/ironic/+/755836 | 14:53 |
| opendevreview | Merged openstack/ironic master: [Trivial] Fix typo in burn-in docs https://review.opendev.org/c/openstack/ironic/+/804074 | 14:55 |
| opendevreview | Arne Wiebalck proposed openstack/ironic-python-agent stable/wallaby: Force immediate NTP time sync with chronyd at IPA startup https://review.opendev.org/c/openstack/ironic-python-agent/+/804096 | 14:55 |
| opendevreview | Arne Wiebalck proposed openstack/ironic-python-agent stable/victoria: Force immediate NTP time sync with chronyd at IPA startup https://review.opendev.org/c/openstack/ironic-python-agent/+/804097 | 14:58 |
| TheJulia | first meeting over | 15:05 |
| TheJulia | yay | 15:05 |
| TheJulia | \o/ https://review.opendev.org/c/openstack/ironic-inspector/+/803935 passed ci | 15:11 |
| arne_wiebalck | Bye everyone, see you tomorrow o/ | 15:30 |
| TheJulia | o/ arne_wiebalck | 15:30 |
| *** owalsh_ is now known as owalsh | 15:31 | |
| cenne | Thank you for the review iurygregory. I've added a comment there re secure_boot change with LEGACY_BIOS. | 15:59 |
| opendevreview | Aija Jauntēva proposed openstack/ironic master: Add RAID mode conversion for idrac-redfish https://review.opendev.org/c/openstack/ironic/+/804112 | 16:23 |
| rpittau | good night! o/ | 16:31 |
| *** rpittau is now known as rpittau|afk | 16:31 | |
| opendevreview | Merged openstack/ironic bugfix/18.1: Fix subscription vendor passthru https://review.opendev.org/c/openstack/ironic/+/803678 | 17:09 |
| opendevreview | Verification of a change to openstack/ironic-python-agent master failed: Output verbose info from efibootmgr https://review.opendev.org/c/openstack/ironic-python-agent/+/803331 | 19:19 |
| cenne | So I noticed a bunch of functions have :return: in the docstring, but no return statement in the [code][1]. | 19:36 |
| cenne | Is that some sort of python class magic going on or do those docstrings need to be updated? | 19:36 |
| cenne | [1]: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/baremetal/v1/node.py#L833 | 19:36 |
| cenne | I ask because I am adding a function, and am not sure if not returning anything explicitly | 19:36 |
| cenne | does actually return an updated node. | 19:36 |
| JayF | looking | 19:41 |
| JayF | Those docstrings are pretty wrong throughout | 19:41 |
| JayF | > :returns: The updated :class:`~openstack.baremetal.v1.node.Node` | 19:41 |
| JayF | > return True | 19:42 |
| JayF | in remove_trait | 19:42 |
| JayF | so I'm going to look at the history for this file, and see if it was committed broken or what | 19:42 |
| JayF | https://opendev.org/openstack/openstacksdk/commit/f162b71cb84439dfeef27f84afc79d1d34c38a9b it was committed that way | 19:43 |
| JayF | rpittau|afk: ^ if you're around, cenne had a question around some of your code; looks like the docstring and the code don't match up | 19:43 |
| JayF | cenne: I'm personally super unfamiliar with openstacksdk, so I don't have a good answer for you here. Maybe rpittau or someone more familiar can have the answer | 19:45 |
| cenne | Thanks. I'll ask them tomorrow. | 19:46 |
| cenne | So for history, you did git log right? | 19:47 |
| JayF | What I did specifically was | 19:47 |
| JayF | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/baremetal/v1/node.py#L833 opened this up, hit "blame" i nthe top right | 19:47 |
| JayF | found the commit to "blame" for the confusing code | 19:47 |
| JayF | and dug into it | 19:47 |
| cenne | Oh cool. That's very cool. | 19:48 |
| JayF | you can effectively do the same with `git blame [filename]` on the CLI | 19:52 |
| JayF | but I find digging through history/blame can sometimes be easier inside the web ui | 19:52 |
| cenne | Yeah, tried it in the cli, right after seeing the web version. :) It works. but the webui is better. | 19:57 |
| cenne | Thanks JayF. I had learnt earlier to use git log to see commit changes to file. But this is pretty useful too. | 19:57 |
| JayF | another nice tip with git log is `-p` | 19:58 |
| JayF | really git log has a plethora of options for sorting/display too | 19:58 |
| JayF | but for me I usually do `git log` or `git log -p` | 19:58 |
| cenne | Ah nice. | 20:01 |
| cenne | That'll come in handy. I usually find myself opening `git gui` just to see the diffs. This will me save a roundtrip in some cases. | 20:03 |
| cenne | *save me | 20:05 |
| * TheJulia walks in from a day of calls and falls over | 20:39 | |
| NobodyCam | Good afternoon Ironic Folks | 21:08 |
| opendevreview | Steve Baker proposed openstack/ironic-inspector master: Handle NodeLocked failures https://review.opendev.org/c/openstack/ironic-inspector/+/803935 | 21:16 |
| iurygregory | morning NobodyCam | 21:26 |
| NobodyCam | morning iurygregory | 21:35 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-prometheus-exporter master: Explicity set IPE job to ML2/OVS https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/804149 | 21:36 |
| janders | good morning Ironic o/ | 21:38 |
| iurygregory | morning janders o/ | 21:38 |
| NobodyCam | Good Morning janders !! | 21:38 |
| janders | thank you for reviewing step overrides iurygregory | 21:39 |
| iurygregory | janders, np! | 21:39 |
| janders | If anyone has time, I'm after the second +2 :) https://review.opendev.org/c/openstack/ironic/+/803887 (if it merges it would be one stacked patch less to deploy while testing this) | 21:40 |
| JayF | looking | 21:40 |
| janders | (it needs 3 at the moment) | 21:41 |
| JayF | janders: +2A | 21:45 |
| janders | Thank you JayF! | 21:45 |
| iurygregory | janders, now remember to backport after it merges :D hehe | 21:46 |
| janders | iurygregory good point will do! :) | 21:46 |
| janders | should be an easy one, no other changes in this part of code AFAIK | 21:46 |
| iurygregory | yeah | 21:46 |
| janders | this small change was killing me while testing iDRAC/LC reset patches yesterday | 21:47 |
| janders | I reinstalled bifrost to make sure I have everything I need in the gerrit change proposal, stacked the two "main" patches, forgot this one | 21:47 |
| janders | and then the bug with iDRAC resets happening multiple times came back due to lack of this, so 10 minute wait each time for the iDRAC to come back before figuring out where the problem was | 21:48 |
| janders | having this in master should fix this once and for this one :) | 21:48 |
| iurygregory | yeah, not having them in a chain of patches becomes a bit problematic hehehe | 21:50 |
| janders | yeah and when iDRAC gets hit with a couple resets Bad Things (TM) can happen | 21:51 |
| janders | looks like it's back while it's not and it may look like a sushy problem | 21:51 |
| janders | bbiab, coffee/breakfast time | 21:52 |
| janders | have a good rest iurygregory | 21:52 |
| iurygregory | tks janders o/ | 21:55 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Allow initial versions to not be created yet https://review.opendev.org/c/openstack/ironic/+/804003 | 22:54 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Implements node history: database https://review.opendev.org/c/openstack/ironic/+/768009 | 23:05 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Record node history and manage events in db https://review.opendev.org/c/openstack/ironic/+/803292 | 23:05 |
| *** pmannidi|AFK is now known as pmannidi | 23:41 | |
| opendevreview | Merged openstack/ironic master: Enable priority overrides to enable/disable steps https://review.opendev.org/c/openstack/ironic/+/803887 | 23:49 |
| janders | ^^ \o/ | 23:50 |
| janders | and with this, back to verify steps testing, now that I have one out-of-tree patch less to stack | 23:50 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!