Monday, 2021-08-09

*** pmannidi|AFK is now known as pmannidi00:00
*** pmannidi is now known as pmannidi|AFK04:42
iurygregorygood morning Ironic o/06:55
jandersIDENTIFY test06:55
janderswhoops :)06:55
janderswrong window06:55
arne_wiebalckGood morning janders iurygregory and Ironic!07:03
jandershey arne_wiebalck iurygregory and Ironic o/07:03
iurygregoryhehehe07:03
iurygregorymorning janders arne_wiebalck o/07:03
iurygregorywelcome back arne_wiebalck :D07:03
arne_wiebalckiurygregory: thanks! Back on IRC and back at CERN since 6+ months :)07:04
iurygregory\o/07:04
iurygregorynice07:04
arne_wiebalck8+ months according to my stale thunderbird :)07:04
iurygregoryhehehe I'm jealous :D (I can go back to the office but I'm still a bit afraid hehe)07:08
arne_wiebalckyeah, there are still rules in place, it is not the same yet07:11
*** rpittau|afk is now known as rpittau07:52
rpittaugood morning ironic! o/07:52
QianbiaoMorning rpittau o/07:55
rpittauhey Qianbiao :)07:55
Qianbiaoo/ happy new week07:55
iurygregorymorning Qianbiao rpittau o/07:58
rpittauhey iurygregory :)07:59
Qianbiaomorning iurygregory07:59
opendevreviewRiccardo Pittau proposed openstack/bifrost stable/wallaby: Improve main function  https://review.opendev.org/c/openstack/bifrost/+/80383308:06
jandersgood morning rpittau and Qianbiao08:26
rpittauhey janders :)08:26
Qianbiaohi janders, good morning.08:27
opendevreviewMerged openstack/bifrost master: Improve main function  https://review.opendev.org/c/openstack/bifrost/+/80379908:55
opendevreviewJacob Anders proposed openstack/ironic master: Enable priority overrides to enable/disable steps  https://review.opendev.org/c/openstack/ironic/+/80388709:02
iurygregoryjanders, I think you are adding things for verify steps in ^ O.o09:04
iurygregoryI would be explicit in the commit that this is Fix to override the steps (since it wasn't working before) =)09:05
jandersiurygregory: this came up in v-s work, however the bug is in the generic _get_steps() method used by clean, verify and deploy steps09:07
jandersonly clean steps use it at the moment, verify steps will use this, too09:07
jandersdoes this make sense, or should I still add an explicit comment related to verify steps?09:07
iurygregoryI would separate since we probably need to backport the fix (and we don't have v-s in stable branches =) )09:08
iurygregoryI would keep the fix for v-s in the patch that will introduce v-s =)09:08
jandersoops I see what happened there09:08
janderssome code got pulled into this that doesn't need to be there09:09
jandersthanks for pointing this out09:09
janderstoo many local outstanding changes09:09
iurygregoryhehehe09:09
iurygregoryyeah09:09
jandersonly _get_steps patch was meant to go into this change09:09
opendevreviewJacob Anders proposed openstack/ironic master: Enable priority overrides to enable/disable steps  https://review.opendev.org/c/openstack/ironic/+/80388709:11
jandersand tests are ever more mixed up...09:14
janders:/09:14
jandersfixing it now09:14
opendevreviewJacob Anders proposed openstack/ironic master: Enable priority overrides to enable/disable steps  https://review.opendev.org/c/openstack/ironic/+/80388709:20
jandersiurygregory ^^ should fix things up hopefully, sorry about the mess earlier, must have mixed up directories :/09:21
iurygregoryack, no worries09:21
opendevreviewVerification of a change to openstack/sushy master failed: Add lower-constraints job to current development branch  https://review.opendev.org/c/openstack/sushy/+/80360109:23
opendevreviewVerification of a change to openstack/ironic-lib master failed: Add lower-constraints job to current development branch  https://review.opendev.org/c/openstack/ironic-lib/+/80362809:37
opendevreviewRiccardo Pittau proposed openstack/ironic-prometheus-exporter master: Add lower-constraints job to current development branch  https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/80389309:41
cenneGood morning Ironic!09:44
cenneMornings iurygregory rpittau arne_wiebalck janders 09:45
rpittauhey cenne :)09:45
iurygregoryhey cenne o/09:45
cenneGood morning Qianbiao09:45
cenneHey o/ : )09:45
Qianbiaomorning cenne09:46
arne_wiebalckhey cenne o/09:48
cennehey : )09:52
opendevreviewNisha Agarwal proposed openstack/ironic master: Clean step to remove CA certificates from iLO  https://review.opendev.org/c/openstack/ironic/+/79956210:02
opendevreviewMerged openstack/networking-generic-switch master: Increase version of hacking and pycodestyle  https://review.opendev.org/c/openstack/networking-generic-switch/+/80321310:44
opendevreviewVerification of a change to openstack/ironic bugfix/18.1 failed: Fix subscription vendor passthru  https://review.opendev.org/c/openstack/ironic/+/80367810:57
iurygregoryyay for Kernel Panic in CI jobs \o/11:01
iurygregoryhttps://zuul.opendev.org/t/openstack/build/414078af24b6435fb2062f491f5eae14/log/controller/logs/ironic-bm-logs/node-0_console_2021-08-09-10:05:55_log.txt11:01
iurygregoryofc today is Monday <311:02
opendevreviewMerged openstack/sushy master: Add lower-constraints job to current development branch  https://review.opendev.org/c/openstack/sushy/+/80360111:22
opendevreviewJacob Anders proposed openstack/ironic master: Enable priority overrides to enable/disable steps  https://review.opendev.org/c/openstack/ironic/+/80388711:23
opendevreviewVerification of a change to openstack/ironic-inspector master failed: Add lower-constraints job to current development branch  https://review.opendev.org/c/openstack/ironic-inspector/+/80357011:26
opendevreviewVerification of a change to openstack/ironic-python-agent master failed: Add lower-constraints job to current development branch  https://review.opendev.org/c/openstack/ironic-python-agent/+/80345312:36
rpittaummm I think we have a problem12:48
rpittauiurygregory: the kernel panic seems hitting everywhere, let's see after one or two rechecks12:50
iurygregoryrpittau, yeah 12:50
iurygregoryif this happens again when Dmitry is on PTO we will have a pattern :D12:52
rpittaulol12:52
TheJuliagood morning13:17
rpittaugood morning TheJulia :)13:17
iurygregorygood morning TheJulia =)13:19
TheJulialovely13:19
TheJuliatry adding root=/dev/ram0 to the kernel command line arguments13:19
TheJuliadoes it use centos stream?13:25
*** pmannidi|AFK is now known as pmannidi13:27
rpittauTheJulia: it should not be stream13:30
TheJuliaseesms super weird13:49
TheJuliaWho is running the meeting today?13:57
*** pmannidi is now known as pmannidi|AFK14:05
TheJuliaSeems like reminders might be good14:08
TheJuliastevebaker: figured out why my node was failing... :\14:08
TheJuliaerr, tripleo change14:09
TheJuliaAt least, failing periodically and randomly14:09
iurygregoryTheJulia, I'14:17
iurygregoryI'm*14:17
iurygregorysorry I was in a downstream meeting hehe14:18
*** pmannidi|AFK is now known as pmannidi14:18
cenneGood morning TheJulia 14:20
TheJuliasoooo many places in inspector don't have retry logic or basic wrappers to handle it14:25
opendevreviewRiccardo Pittau proposed openstack/networking-baremetal master: Add lower-constraints job to current development branch  https://review.opendev.org/c/openstack/networking-baremetal/+/80393314:32
iurygregorysounds like some low-hanging fruit bugs we can add to a story so newcomers can work on it XD14:41
cenneYay! Sounds like a good plan : )14:50
*** pmannidi is now known as pmannidi|AFK14:52
TheJuliaunfortunately, it is breaking CI14:53
TheJuliaand likely has silently been doing so for a very long time14:53
iurygregoryoh 14:53
iurygregorywell, that's a different case :D14:53
iurygregory#startmeeting ironic15:00
opendevmeetMeeting started Mon Aug  9 15:00:00 2021 UTC and is due to finish in 60 minutes.  The chair is iurygregory. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
opendevmeetThe meeting name has been set to 'ironic'15:00
iurygregoryo/15:00
stendulkero/15:00
rpittauo/15:00
iurygregoryHello ironicers! welcome to our weekly meeting!15:00
rpioso\o15:00
ajyao/15:00
* iurygregory wondering if we have quorum...15:01
* iurygregory will give a few more minutes to see15:01
erbarro/15:02
JayFo/15:02
bfournieo/15:02
iurygregoryyay! we have quorum \o/15:02
iurygregoryOur agenda can be found in the wiki15:02
iurygregory#link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting15:03
iurygregory#topic Announcements / Reminder15:03
iurygregory#info Xena Midcycle - Please add ideas for the midcycle: https://etherpad.opendev.org/p/ironic-xena-midcycle till this Friday.15:03
iurygregory#info Yoga PTG (October 18-22, 2021) - Please add your ideas for the PTG: https://etherpad.opendev.org/p/ironic-yoga-ptg15:03
iurygregory#info All Red Hatters will be out this friday.15:04
TheJuliao/15:04
iurygregoryDoes anyone have anything else to add?15:04
TheJuliaiurygregory: when is the midcycle again?15:04
iurygregoryTheJulia, 23 24 25 (depending on how many topics we have)15:05
iurygregoryon 16th we will have the topics for each day-15:05
TheJuliaack15:06
iurygregory#info Midcycle August 23 (3-4PM UTC ), 24 (2-3PM UTC) and 25 (2-3PM)15:06
cenneo/15:06
iurygregorymoving to our next topic15:07
iurygregory#topic Review action items from previous meeting15:07
iurygregoryNo previous action items - skipping15:07
iurygregory#topic Review subteam status reports15:07
iurygregory#link https://etherpad.opendev.org/p/IronicWhiteBoard15:07
iurygregorystarting on L6015:08
iurygregoryTheJulia, tks for working on the node error history!15:09
TheJuliaNo problem, it is actually *way* easier since we limited scope heavily upfront15:12
TheJuliathere is an issue with the upgrade, but I'd like to get them on the review list this week15:12
iurygregory++15:13
iurygregoryI think we are good with the updates, moving on15:13
TheJuliaI've also got this inspector patch I'll put on the priority review list since it is a sporatic tripleo CI failure15:13
TheJuliait shoudl be posted in about 3 minutes15:14
iurygregoryack15:14
iurygregory#topic Deciding on priorities for the coming week15:14
iurygregory#link https://review.opendev.org/q/status:open+hashtag:ironic-week-prio15:14
iurygregoryrpittau, I'm wondering if you want to add some small things you have been working on like https://review.opendev.org/q/topic:%2522increase-hacking-pycodestyle%2522+status:open15:15
rpittauyeah, I'll add them15:16
rpittauI'm abit concerned about CI at the moment15:16
iurygregoryyeah15:16
iurygregoryCI on monday <315:16
iurygregoryif we try to approve things we are just wasting resources till we find the root cause15:16
rpittauyep15:17
iurygregoryhttps://review.opendev.org/c/openstack/ironic-python-agent/+/803710 sounds like something we can add to the list15:17
iurygregoryseems like*15:17
TheJuliais it just the virtual media jobs or is it more?15:18
iurygregoryI saw other jobs also15:19
rpittaulooks like ipmi is also failing somewhere, not sure if it's the same issue though15:19
iurygregory^ yeah15:20
iurygregorymaybe we can add https://review.opendev.org/c/openstack/python-ironicclient/+/803332  wdyt?15:20
opendevreviewJulia Kreger proposed openstack/ironic-inspector master: Handle NodeLocked failures  https://review.opendev.org/c/openstack/ironic-inspector/+/80393515:20
TheJuliaokay, I can look at CI failures after I get more coffee15:21
TheJuliaiurygregory: sounds good to me15:21
rpittauI had a quick look and the ipmi seems like a different problem15:22
iurygregorydifferent problem - not Kernel Panic? 15:23
rpittauyep15:23
TheJuliahopefully it is nothing major but I can dig into it after the meeting15:24
iurygregoryI saw KP in ironic-tempest-ipa-partition-pxe_ipmitool 15:24
iurygregorybut yeah we need to look at this to see =)15:24
iurygregoryI think we are good with priorities15:24
iurygregoryif you have patches feel free to add the hashtag later15:24
iurygregory#topic Discussion15:25
iurygregoryWe don't have any topics for discussion, but I will give a chance for people start one if they want =)15:26
TheJuliaso we're really in Open Discussion?15:26
iurygregorynot yet15:26
iurygregorywe have Baremetal SIG / RFE review15:27
TheJuliaOne thing worth bringing up, Friday's SPUC will be JayF's final spuc most likely15:27
TheJuliaHe would <3 for people to join in15:27
JayF;(15:27
iurygregory#info  Friday's SPUC will be JayF's final spuc most likely, he would <3 for people to join in15:27
cenne:(-15:27
TheJuliaSo since we can't bake him a cake on video, lets at least wish him a good send off :)15:28
iurygregorywhile we are drinking :D15:28
iurygregory\o/15:28
iurygregorymoving to our next topic15:29
iurygregory#topic Baremetal SIG15:29
TheJuliaI don't think there is anything SIG related, lots of folks on vacation15:30
iurygregoryyeah15:30
iurygregoryArne is back :D (but he can't join today)15:31
iurygregory#topic RFE review15:31
iurygregoryno items for RFE review on the agenda, does anyone have something?15:31
TheJuliaNothing right now15:32
TheJuliaSpeaking of which, we likely should consider reviewing sdanni and lmcgann's attestation patches15:32
iurygregoryI saw a patch to IPA I think15:32
iurygregoryhttps://review.opendev.org/c/openstack/ironic-python-agent/+/80351015:33
lmcgannwe actually have a demo video to share, but i was waiting until the open discussion part of the meeting15:33
TheJuliasdanni: lmcgann: can you guys add an entry to the whiteboard and let us know the required merge/review order?15:33
iurygregory#topic Open discussion15:34
iurygregorylmcgann, go ahead =)15:34
sdannicould you link us the whiteboard?15:34
TheJuliahttps://etherpad.opendev.org/p/IronicWhiteBoard15:34
lmcgannPerfect, so I put together a video for Keylime Ironic integration. I go over the workflow, current limitations, and a demo. https://www.youtube.com/watch?v=o7eL95BUGLA15:35
iurygregory#info Keylime Ironic integration demo https://www.youtube.com/watch?v=o7eL95BUGLA15:35
sdanniShould we add our patches in Code Review Dashboards?15:36
iurygregorysdanni, you can add the hashtag ironic-week-prio in the patches15:36
iurygregoryand probably add a section to Subteam status reports15:37
sdanniokay!15:37
iurygregoryfor the keylime and list the order of the patches and current status15:37
cenneWhat happens in midcycle meeting?15:37
iurygregorycenne, we will discuss about some topics 15:38
TheJuliacenne: we discuss current or emergent topics in a higher bandwidth medium, say video/audio calls15:38
TheJuliacenne: and then try to find a forward direction, often it is intended to help us wrap up work in progress15:39
cenneoh..15:39
iurygregoryTheJulia types very fast :D15:39
iurygregorywell, I think that's all for today, should we move to the last topic?15:41
cennethanks. 15:41
iurygregorycenne, feel free to participate in the midcycle and the PTG in Oct =) they are both free :D15:41
cennealright! I'll try to attend the midcycle. :)15:42
TheJuliaI also type with lots of energy15:42
* TheJulia has been told that my use of the enter key should break keyboards15:42
iurygregoryTheJulia, you should buy the big Enter :D15:43
rpittaubig enter red button15:44
cennehaha. my friends would often be worried when I used their laptop's keyboards too. :p15:44
TheJulialol15:44
iurygregoryhehehe :D15:44
iurygregory#topic Who is going to run the next meeting?15:45
iurygregoryany volunteers?15:45
TheJuliaWell15:45
TheJuliayou said we're having Midcycle session on the 16th?15:45
rpittauno, week after :)15:45
iurygregorywe will have the topics for each day15:46
iurygregoryon 16th15:46
TheJuliaoh, okay15:46
TheJuliaahh, okay15:46
TheJuliaSo I could take next week off or something crazy15:46
iurygregoryI can run the meeting without problems on 16th =)15:46
rpittauTheJulia: you should, it doesn't sound crazy at all15:46
rpittauI will be out the 16th too15:46
* iurygregory is having the feeling everyone will be out :D15:47
rpittaulots15:47
TheJuliaiurygregory: just means the meeting will be quick15:47
iurygregoryyeah15:47
iurygregoryI will run the meeting on 16th =)15:47
iurygregoryThanks everyone!15:47
iurygregory#endmeeting15:48
opendevmeetMeeting ended Mon Aug  9 15:48:02 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:48
opendevmeetMinutes:        https://meetings.opendev.org/meetings/ironic/2021/ironic.2021-08-09-15.00.html15:48
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/ironic/2021/ironic.2021-08-09-15.00.txt15:48
opendevmeetLog:            https://meetings.opendev.org/meetings/ironic/2021/ironic.2021-08-09-15.00.log.html15:48
rpittauthanks iurygregory :)15:48
opendevreviewRiccardo Pittau proposed openstack/networking-generic-switch master: Add lower-constraints job to current development branch  https://review.opendev.org/c/openstack/networking-generic-switch/+/80393915:48
TheJuliaanyone have some good exempliarly failures?15:48
iurygregoryhttps://review.opendev.org/c/openstack/ironic/+/803678 has some jobs with the failures15:49
TheJuliaso it is centos stream 8.416:02
TheJuliaor well, to be more precise, centos 8.4 with same version packages as stream16:03
TheJuliaYeahhhhh16:07
TheJuliait is stream alright16:07
TheJuliafound it16:09
TheJulia"ipa-centos8-master.tar.gz2021-08-08 17:36710M "16:09
rpittaummm ok weird, we're using release 8 to build the image, not 8-stream16:09
opendevreviewDanni Shi proposed openstack/ironic-python-agent master: Add an attestation extension  https://review.opendev.org/c/openstack/ironic-python-agent/+/80351016:09
TheJuliawell, it might not matter since they are shoving stuff in it seems16:09
TheJuliaAnyway, I've started a download and I start taking it apart16:09
TheJuliait is like 2.25 times our prior image size, which is why things are failing like they are16:10
rpittauheh ok, ninja-updates are lethal16:10
* TheJulia gets out the list of mythbusters one-liners https://www.youtube.com/watch?v=LxhF7iBueeE16:12
rpittauTheJulia: if you look here https://tarballs.opendev.org/openstack/ironic-python-agent/dib/files/ipa-centos8-master.d/dib-manifests/dib_environment the DIB_RELEASE is correctly set to 816:13
rpittauI wonder if they switched to centos-stream repos by default16:13
TheJuliamaybe16:13
TheJuliadownload is going slow... I miss my mesh wifi16:13
TheJuliarpittau: it could also be that something we clean up got moved around16:14
TheJuliaThe size also makes me think none of the cleanup works16:15
rpittauyep, it's way too big anyway16:15
* TheJulia goes and checks the mesh wifi basestation replacement order status16:16
TheJuliastill not shipped :(16:16
rpittauthe last commit to ipa-builder seems suspicious :)16:23
rpittauhttps://opendev.org/openstack/ironic-python-agent-builder/commit/68989576e3663cdc5a7182eea14d2ed6206d61e016:23
rpittauneed to go, have a nice rest of the day everyone! o/16:26
*** rpittau is now known as rpittau|afk16:26
TheJulia3gb uncompressed16:29
TheJuliayup16:32
TheJuliayeah, its not pruning a thing16:39
NobodyCamGood Mornings Ironic folks.. Happy Monday16:39
opendevreviewVerification of a change to openstack/ironic-python-agent master failed: Add lower-constraints job to current development branch  https://review.opendev.org/c/openstack/ironic-python-agent/+/80345316:40
TheJuliagood morning NobodyCam 16:42
TheJuliaWell, this is freaky16:42
TheJuliaif I let it manually generate the command.... it doesn't work16:43
TheJuliaerr16:43
NobodyCamo/ TheJulia Morning 16:43
TheJuliaif I print the command, it works as expected16:43
TheJuliaif I let the script do it, kaboom16:43
NobodyCam"'" + `echo "' Could it be a \"Quoting\" Issue'` + "'"16:44
NobodyCamawe ate the ` chr16:45
TheJuliaI'm not sure :\16:53
TheJuliahmmmmmmmm17:04
NobodyCamhttps://learningenglish.voanews.com/a/nasa-spacecraft-detects-a-hum-in-interstellar-space/5889608.html17:18
opendevreviewcenne proposed openstack/python-ironicclient master: [WIP] Add support for changing 'boot_mode' and 'secure_boot' states  https://review.opendev.org/c/openstack/python-ironicclient/+/80397017:36
lmcgannIs there a reason ironic doesnt have the ability to get and object in swift, the way the ironic-inspector can? The reason I ask is because I may have to retrieve a file from swift for use in the interface Im writing and Im wondering what the recommended way to do this would be17:42
TheJulialmcgann: there is no reason, we store files in swift quite a bit, just never needed to really directly get one17:46
TheJuliaJayF: so... any ideas why your script change for ipa-b doesn't work if run in the script?17:46
JayFI don't have context on that statement, what's the problem?17:47
lmcgannTheJulia so it would be ok if I extended the swift module to add a get_object method then?17:48
TheJuliatl;dr, the find command is behaving differently when run from inside a script as opposed to the output you get if you just echo, copy, and paste it17:48
TheJuliaJayF: basically, the gate is broken because it is resulting in 700+ MB images because nothing is getting pruned :\17:48
TheJulialmcgann: yup, that should be fine17:49
lmcgannPerfect17:49
TheJulialmcgann: just be careful with who/how that information gets supplied and what account is used and whatnot17:50
TheJulialmcgann: Also, if you end user context is passed in, it would be best, but if it has to run later, that may require some discussion17:50
TheJuliaand by later, I mean as a result of a heartbeat operation or after deployment17:51
TheJuliahttps://paste.opendev.org/show/807963/17:53
TheJuliaJayF: ^^^17:53
lmcgannIm trying to use it to pass the allowlist and excludelist files to Ironic. My thought is that it just grabs based on a url or container/object pair passed into driver_info. The files themselves would be retrieved by a method inside of the interface17:54
JayFTheJulia: I don't know why it's failing, it appeared to work properly when I was using it after writing it17:55
JayFTheJulia: I can't dig deep right now I'm in a knowledge transfer meeting downstream :| 17:55
lmcgannId never worked with swift up to this point so I am not sure exactly how horribly wrong this could go17:55
TheJuliaJayF: were you always overriding the value?17:55
JayFTheJulia: yes17:55
TheJuliahmmmmm17:55
TheJuliaJayF: okay, thanks17:55
JayFbut I also haven't checked my initramfs for any pruned files...17:55
JayFone sec17:56
JayFexplicitly checking our downstream image here to validate that17:57
JayFTheJulia: I can confirm my downstream images are not pruned :| I do not know what changed between the copy of code I tested and what got committed17:58
TheJuliaJayF: ack, thanks, that at least is a datapoint for me, I'll keep hunting17:59
JayFI'm very sorry :( if you need to revert please give me a heads up so I can just patch out the prune downstream for now17:59
TheJuliaJayF: k, trying to prune down possibilities now18:01
JayFpun intended?18:01
TheJuliaJayF: absolutely18:49
opendevreviewcenne proposed openstack/python-ironicclient master: Add support for changing 'boot_mode' and 'secure_boot' states  https://review.opendev.org/c/openstack/python-ironicclient/+/80397019:00
opendevreviewcenne proposed openstack/python-ironicclient master: Add support for changing 'boot_mode' and 'secure_boot' states  https://review.opendev.org/c/openstack/python-ironicclient/+/80397019:06
opendevreviewcenne proposed openstack/python-ironicclient master: Add support for changing 'boot_mode' and 'secure_boot' states  https://review.opendev.org/c/openstack/python-ironicclient/+/80397019:15
TheJuliaJayF: doesn't seem to be anything with string expansion and if I force string expansion by passing through echo, same thing occurs19:17
JayFTheJulia: 'same thing occurs' meaning what? You see the command line created as you expect?20:11
JayFHmm. I bet the single quotes are somehow messing things up20:39
JayFBecause even though they exist in the older version, I'm not convinced they weren't interpreted by the outer bash20:39
JayF(vs these which exist inside a variable)20:39
JayFTheJulia: the problem becomes apparent if you toss a `shopt -s failglob` in there. At some point, bash is trying to glob 21:02
TheJuliaJayF: so regardless it is trying to run the expansion of the fields21:13
TheJulialovely21:13
JayFYeah, I'm honestly at a bit of a loss as to how to fix this.21:14
TheJuliaThe only way I think we could is to change the IFS21:14
TheJuliaand make it something like colon delimited21:14
JayFIt seems like fixing it may be impossible inside the limits of posix sh21:14
TheJuliaquite possibly21:14
JayFyou know, I bet that's why it's structured how it is now21:16
JayFs/now/was before my change/21:16
JayFthat looks almost intentionally like trying to avoid bash quoting BS21:16
TheJuliaI was actually starting to think that as well21:16
JayFSo I can patch downstream and revert if we need, or remove /var/log from that list of stuff to prune21:17
JayFhmm, how about this... how about I write a *separate* find which will delete all **files** in /var/log/ but not nuke the path21:17
JayFthen leave /var/log out of the find command afterwards21:17
TheJuliaJayF: ++21:17
JayFso I'm going to put a pure revert up, and do that as a separate commit21:18
TheJuliaJayF: sounds good to me21:18
TheJuliaJayF: I was thinking that as a possible path forward earlier, but didn't know the extent in which your stuff needed to preserve $things21:18
JayFWell, TBH, the way it's structured now is just *asking* for this kinda problem in the future21:19
JayFbecause we just delete entire paths without configuration or consideration as to what is needed21:19
JayFe.g. if I write an RPM and install it that *has to read* out of /usr/share/doc/ for some reason (who knows?) it's impossible to make it work in an IPA ramdisk21:19
TheJuliaIt is, however that was also after an insane amount of time spent taking apart things and double checking at least from an upstream standpoint21:19
TheJuliayup21:20
JayFthe only other option I see is making that completely opt-outable21:20
JayFsince for most use cases, with ipxe+http, having a larger image won't be a major impact21:20
opendevreviewJay Faulkner proposed openstack/ironic-python-agent-builder master: Revert "Allow configuration of paths to prune"  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/80396721:24
TheJuliaWell, testing would require more memory and that is a resource allocation change like an act of congress :(21:28
JayFWell I'm saying, an operator could set that to skip the pruning and probably be fine21:30
JayFbut not so much in CI :D 21:30
JayFTheJulia: ^ is that a correct statement? Have we seen operator failures due to ramdisk-too-large or is the optimization mostly for ci-use?21:30
TheJuliaJayF: CI + QE21:31
TheJuliaso like humans doing basic testing needing >4GB of ram is bad21:31
JayFso that sounds mostly like a concern an operator could reasonably opt out of21:32
JayFI think I'm going to go that route, to avoid the prune. I think it's the more correct universal fix.21:32
JayFOr at least, we should do *both things* and not just fix var/log because it scratches my current itch21:33
* TheJulia shrugs in the "as long as we're able to merge patches" way21:33
opendevreviewJay Faulkner proposed openstack/ironic-python-agent-builder master: Allow opt-out of ramdisk pruning  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/80399421:53
JayFgoing to say ^^ this + the revert is enough for now. If I can find the time this week, I'll implement the "prune all files, but not all folders, from /var/log" logic, too, so I can still get my ramdisks pruned :D21:54
TheJuliaJayF: looks like your missing "fi"22:17
opendevreviewJay Faulkner proposed openstack/ironic-python-agent-builder master: Allow opt-out of ramdisk pruning  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/80399422:18
JayFTheJulia: what missing fi <.< >.> 22:18
JayFthanks22:18
TheJuliaI know nothing! ;)22:20
jandersgood morning Ironic o/23:40
TheJuliagood morning janders 23:42
jandershey TheJulia23:43
opendevreviewJacob Anders proposed openstack/ironic master: Enable priority overrides to enable/disable steps  https://review.opendev.org/c/openstack/ironic/+/80388723:45
janderswhat determines whether a clean step is treated as in-band or out-of-band?23:57

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!