| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic-inspector stable/ocata: grenade: Only 'enable_plugin ironic-inspector' if not already in conf https://review.openstack.org/476725 | 00:06 |
|---|---|---|
| *** ijw has quit IRC | 00:06 | |
| *** weshay has quit IRC | 00:10 | |
| *** rama_y has quit IRC | 00:11 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs master: Adds PCI device inspection to ironic https://review.openstack.org/475648 | 00:11 |
| *** openstackstatus has quit IRC | 00:13 | |
| *** weshay has joined #openstack-ironic | 00:13 | |
| *** openstackstatus has joined #openstack-ironic | 00:14 | |
| *** ChanServ sets mode: +v openstackstatus | 00:14 | |
| *** jrcloud has joined #openstack-ironic | 00:17 | |
| *** weshay has quit IRC | 00:18 | |
| *** jrcloud has quit IRC | 00:22 | |
| *** weshay has joined #openstack-ironic | 00:24 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Tempest scenario test for boot-from-volume https://review.openstack.org/472740 | 00:29 |
| *** Goneri has quit IRC | 00:35 | |
| *** dmellado has joined #openstack-ironic | 00:37 | |
| openstackgerrit | huayue proposed openstack/pyghmi master: Pyghmi does not follow the pep8 standard https://review.openstack.org/476444 | 00:37 |
| *** zhugaoxiao has quit IRC | 00:39 | |
| *** Administrator__ has quit IRC | 00:39 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Add a guide for Devstack configuration for boot-from-volume https://review.openstack.org/466568 | 00:44 |
| *** hel0tsp has joined #openstack-ironic | 00:46 | |
| *** cdearborn has joined #openstack-ironic | 00:52 | |
| *** SerenaFeng has joined #openstack-ironic | 01:05 | |
| *** phuongnh has joined #openstack-ironic | 01:05 | |
| *** weshay has quit IRC | 01:05 | |
| *** dmellado has quit IRC | 01:06 | |
| *** weshay has joined #openstack-ironic | 01:07 | |
| *** hel0tsp has quit IRC | 01:09 | |
| *** hel0tsp has joined #openstack-ironic | 01:11 | |
| *** weshay has quit IRC | 01:14 | |
| *** SerenaFeng has quit IRC | 01:19 | |
| *** ijw has joined #openstack-ironic | 01:22 | |
| *** ijw has quit IRC | 01:30 | |
| *** hoonetorg has quit IRC | 01:35 | |
| *** hel0tsp has quit IRC | 01:42 | |
| *** weshay has joined #openstack-ironic | 01:42 | |
| *** hel0tsp has joined #openstack-ironic | 01:42 | |
| *** SerenaFeng has joined #openstack-ironic | 01:48 | |
| *** weshay has quit IRC | 01:51 | |
| *** hoonetorg has joined #openstack-ironic | 01:52 | |
| *** rloo has quit IRC | 02:04 | |
| *** shuyingya has joined #openstack-ironic | 02:06 | |
| *** shuyingya has joined #openstack-ironic | 02:06 | |
| *** shuyingya has joined #openstack-ironic | 02:07 | |
| *** zhurong has joined #openstack-ironic | 02:08 | |
| *** shuyingya has quit IRC | 02:13 | |
| *** shuyingya has joined #openstack-ironic | 02:13 | |
| *** tuanluong has joined #openstack-ironic | 02:14 | |
| *** cdearborn has quit IRC | 02:20 | |
| *** mtanino__ has joined #openstack-ironic | 02:42 | |
| *** zhurong has quit IRC | 02:58 | |
| *** zhurong has joined #openstack-ironic | 03:00 | |
| *** mtanino__ has quit IRC | 03:09 | |
| *** mtanino__ has joined #openstack-ironic | 03:23 | |
| *** aparnav has joined #openstack-ironic | 03:26 | |
| *** ijw has joined #openstack-ironic | 03:27 | |
| *** udesale has joined #openstack-ironic | 03:30 | |
| *** SerenaFeng has quit IRC | 03:32 | |
| *** SerenaFeng has joined #openstack-ironic | 03:33 | |
| *** ijw has quit IRC | 03:33 | |
| *** SerenaFeng has quit IRC | 03:49 | |
| *** zhurong has quit IRC | 04:02 | |
| *** links has joined #openstack-ironic | 04:16 | |
| *** kiseok7 has joined #openstack-ironic | 04:17 | |
| *** mtanino__ has quit IRC | 04:22 | |
| *** amotoki_away is now known as amotoki | 04:24 | |
| *** mjura has joined #openstack-ironic | 04:27 | |
| *** ijw has joined #openstack-ironic | 04:29 | |
| *** karthiks has joined #openstack-ironic | 04:30 | |
| *** ijw has quit IRC | 04:33 | |
| *** jrcloud has joined #openstack-ironic | 04:34 | |
| *** zhurong has joined #openstack-ironic | 04:35 | |
| *** jrcloud has quit IRC | 04:38 | |
| *** adisky__ has joined #openstack-ironic | 04:41 | |
| *** amotoki is now known as amotoki_away | 04:59 | |
| *** jaganathan has joined #openstack-ironic | 05:01 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Modifications for rolling upgrades https://review.openstack.org/476779 | 05:02 |
| *** jaganathan_ has joined #openstack-ironic | 05:03 | |
| *** jaganathan has quit IRC | 05:07 | |
| *** jaganathan_ has quit IRC | 05:10 | |
| *** ChubYann has quit IRC | 05:19 | |
| openstackgerrit | Anshul Jain proposed openstack/ironic master: Add manual clean step ironic standalone test https://review.openstack.org/429770 | 05:21 |
| *** jaganathan_ has joined #openstack-ironic | 05:23 | |
| *** mvpnitesh has joined #openstack-ironic | 05:29 | |
| *** SerenaFeng has joined #openstack-ironic | 05:33 | |
| *** SerenaFeng has quit IRC | 05:56 | |
| *** SerenaFeng has joined #openstack-ironic | 05:56 | |
| *** SerenaFeng has quit IRC | 05:56 | |
| *** SerenaFeng has joined #openstack-ironic | 05:57 | |
| -openstackstatus- NOTICE: unknown issue with the git farm, everything broken - we're investigating | 06:02 | |
| *** ChanServ changes topic to "unknown issue with the git farm, everything broken - we're investigating" | 06:02 | |
| *** hel0tsp has quit IRC | 06:17 | |
| *** hel0tsp has joined #openstack-ironic | 06:18 | |
| *** marios has joined #openstack-ironic | 06:18 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 06:18 | |
| Nisha_Agarwal | morning Ironic!!! | 06:18 |
| openstackgerrit | Vu Cong Tuan proposed openstack/ironic master: Replace the usage of 'manager' with 'os_primary' https://review.openstack.org/475996 | 06:23 |
| *** phuongnh has quit IRC | 06:29 | |
| *** phuongnh has joined #openstack-ironic | 06:30 | |
| *** rcernin_ has joined #openstack-ironic | 06:32 | |
| *** arnewiebalck has quit IRC | 06:41 | |
| pas-ha | morning ironic :) TGIF! | 06:45 |
| * pas-ha sees lots of mentions, reads scrollback | 06:46 | |
| pas-ha | TheJulia: rloo: jlvillal: if you wondered how my first patch got past CI when the devstack revert was not merged yet - latest patch-set has a Depends-On on revert patch :) | 06:47 |
| pas-ha | morning Nisha_Agarwal | 06:47 |
| *** mvpnitesh has quit IRC | 06:49 | |
| *** SerenaFeng has quit IRC | 06:50 | |
| *** ccamacho has joined #openstack-ironic | 07:05 | |
| *** mvpnitesh has joined #openstack-ironic | 07:08 | |
| *** phuongnh has quit IRC | 07:09 | |
| *** phuongnh has joined #openstack-ironic | 07:09 | |
| Nisha_Agarwal | pas-ha, o/ | 07:11 |
| tuanluong | Morning Nisha_Agarwal pas-ha | 07:13 |
| pas-ha | morning tuanluong | 07:13 |
| *** pcaruana has joined #openstack-ironic | 07:18 | |
| *** e0ne has joined #openstack-ironic | 07:19 | |
| *** SerenaFeng has joined #openstack-ironic | 07:20 | |
| *** tesseract has joined #openstack-ironic | 07:45 | |
| *** junbo has joined #openstack-ironic | 07:48 | |
| *** amotoki_away is now known as amotoki | 07:51 | |
| *** SerenaFeng has quit IRC | 07:52 | |
| *** mgoddard has joined #openstack-ironic | 07:57 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-ironic | 08:00 | |
| *** fragatina has joined #openstack-ironic | 08:01 | |
| -openstackstatus- NOTICE: ok git.openstack.org is working again, you can recheck failed jobs | 08:02 | |
| *** ChanServ changes topic to "ok git.openstack.org is working again, you can recheck failed jobs" | 08:02 | |
| *** SerenaFeng has joined #openstack-ironic | 08:07 | |
| *** Nisha_ has joined #openstack-ironic | 08:16 | |
| *** bcornec1 has joined #openstack-ironic | 08:17 | |
| *** Nisha_Agarwal has quit IRC | 08:19 | |
| *** Nisha_ has quit IRC | 08:21 | |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: bindep.txt: Add MariaDB dependencies https://review.openstack.org/476833 | 08:24 |
| *** mvpnitesh has quit IRC | 08:24 | |
| *** gcb has quit IRC | 08:30 | |
| *** shuyingya has quit IRC | 08:33 | |
| *** derekh has joined #openstack-ironic | 08:35 | |
| *** hshiina has joined #openstack-ironic | 08:42 | |
| *** SerenaFeng has quit IRC | 08:45 | |
| *** SerenaFeng has joined #openstack-ironic | 08:47 | |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-inspector master: Use new RPC model https://review.openstack.org/462862 | 08:51 |
| *** aarefiev_afk is now known as aarefiev | 08:52 | |
| aarefiev | morning all! | 08:52 |
| *** ijw has joined #openstack-ironic | 08:57 | |
| *** ijw has quit IRC | 09:02 | |
| *** shuyingya has joined #openstack-ironic | 09:05 | |
| *** amotoki is now known as amotoki_away | 09:05 | |
| *** priteau has joined #openstack-ironic | 09:06 | |
| *** dtantsur|afk is now known as dtantsur | 09:06 | |
| dtantsur | morning ironic | 09:06 |
| *** jrcloud has joined #openstack-ironic | 09:07 | |
| *** ChanServ changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/developer/ironic/ | Bugs: https://bugs.launchpad.net/ironic" | 09:10 | |
| *** lucas-afk is now known as lucasagomes | 09:11 | |
| lucasagomes | dtantsur, morning | 09:11 |
| lucasagomes | morning all :-) | 09:11 |
| *** jrcloud has quit IRC | 09:11 | |
| *** skazi has quit IRC | 09:12 | |
| *** skazi has joined #openstack-ironic | 09:12 | |
| dtantsur | o/ | 09:12 |
| dtantsur | lucasagomes: happy Friday! how's networking life? | 09:12 |
| lucasagomes | dtantsur, TGIF! Doing well, there's a meeting (in person) next week for the team so I will finally get to see some of the folks that I'm now working with | 09:14 |
| dtantsur | ah, yeah, I've heard about it. our team is meeting in mid-July | 09:14 |
| dtantsur | so sorry to not have you there ;) come for Žebra one day | 09:15 |
| lucasagomes | >.< ikr ? Yeah, def need to catch up with ya folks another time for some beer and zebra :-) | 09:16 |
| *** athomas has joined #openstack-ironic | 09:16 | |
| openstackgerrit | Debayan Ray proposed openstack/proliantutils master: [WIP] Redfish: Add secure boot API support https://review.openstack.org/472244 | 09:20 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Changes log level of a message https://review.openstack.org/476847 | 09:22 |
| *** b00tcat has quit IRC | 09:23 | |
| *** b00tcat has joined #openstack-ironic | 09:24 | |
| *** mvpnitesh has joined #openstack-ironic | 09:25 | |
| *** sambetts_ is now known as sambetts | 09:27 | |
| sambetts | Morning all | 09:27 |
| dtantsur | hi sambetts | 09:28 |
| openstackgerrit | Dao Cong Tien proposed openstack/ironic master: WIP/DNM:Temp patch to test boot-from-volume job https://review.openstack.org/476854 | 09:30 |
| *** skazi has quit IRC | 09:36 | |
| sambetts | hey dtantsur | 09:36 |
| *** zhurong has quit IRC | 09:37 | |
| *** ricardoas1 has joined #openstack-ironic | 09:37 | |
| *** ricardoas has quit IRC | 09:38 | |
| mgoddard | g'day ironic | 09:47 |
| sambetts | hey mgoddard | 09:47 |
| lucasagomes | sambetts, mgoddard o/ morning | 09:48 |
| mgoddard | hey sambetts: did you see my message & comment yesterday? | 09:48 |
| sambetts | mgoddard: about the non-neutron case? | 09:48 |
| mgoddard | sambetts: right | 09:48 |
| *** gcb has joined #openstack-ironic | 09:49 | |
| mgoddard | sambetts: do we still need to support that case or are we safe to assume neutron exists? | 09:50 |
| *** udesale__ has joined #openstack-ironic | 09:50 | |
| sambetts | mgoddard: yeah... I think all that code needs to be refactored sooner rather than later what I really want to see is two things, 1 a generic vif_port_id mixin, that literally just does the I have been given an ID and I'm going to write it into internal_info['vif_port_id'], and then also a Neutron specific vif port id mixin, that will extend the generic one to had the code to call neutron to | 09:50 |
| sambetts | update the mac addresses and check the physnets etc | 09:51 |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: bindep.txt: Add explicit dependencies https://review.openstack.org/476833 | 09:51 |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: bindep.txt: Add explicit MariaDB dependency https://review.openstack.org/476868 | 09:51 |
| mgoddard | sambetts: so you'd expect non-neutron net interfaces to use the former? | 09:53 |
| *** udesale has quit IRC | 09:53 | |
| sambetts | mgoddard: exactly, the only reason the current mixin has code to support both was because there was a weird transition period, during which out of tree network interface might not have implemented vif_attach/detech etc themselves so we needed a gneric one that could support eveyrone | 09:54 |
| sambetts | mgoddard: not the network interfaces themselves have to support it they can make the decision I'm neutron driver so I'll use the neutron specific mixin | 09:54 |
| openstackgerrit | Nguyen Hung Phuong proposed openstack/ironic master: Add functional API tests for volume connector and volume target https://review.openstack.org/473717 | 09:55 |
| *** mrchao has joined #openstack-ironic | 09:55 | |
| sambetts | or I'm not a neutron driver therefore I'll use the generic mixin | 09:55 |
| *** amotoki_away is now known as amotoki | 09:55 | |
| sambetts | mgoddard: IMO that refactor was supposed to happen when this patch landed https://github.com/openstack/ironic/commit/06e8930727caf7c14e99864e8911a35bd0fa8510 | 09:55 |
| sambetts | as part of that patch | 09:56 |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: bindep.txt: Add explicit dependencies https://review.openstack.org/476833 | 09:56 |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: bindep.txt: Add explicit MariaDB dependency https://review.openstack.org/476868 | 09:56 |
| sambetts | mgoddard: some how I missed that patch so didn't get to comment at the time | 09:57 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Fetch Glance endpoint from Keystone if it's not provided in the configuration https://review.openstack.org/476498 | 09:58 |
| dtantsur | ok, this should be it finally ^^^ | 09:58 |
| *** dtantsur is now known as dtantsur|lunch | 09:58 | |
| mgoddard | sambetts: so, sounds like there are 3 related items here. 1- existing VIF mixin does not currently need to support neutron. 2- a new minimal VIF mixin should be extracted which has no neutron deps. 3- we need to support physnets during VIF attach | 09:59 |
| mgoddard | sambetts: my physnet VIF attach patch is currently complicated by the non-neutron assumptions, so would it make sense to insert a patch before it to remove non-neutron support? | 10:00 |
| mgoddard | sambetts: given that physnet VIF attach is a priority this week, it would be a shame to block it on the VIF mixin refactoring or make it more complicated than it needs to be | 10:01 |
| sambetts | mgoddard: yeah, that why I suggested it might be worth just cleaning it all up in a follow up | 10:02 |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-inspector master: Functional tests: clean up test config file https://review.openstack.org/476877 | 10:02 |
| *** chlong has quit IRC | 10:03 | |
| sambetts | mgoddard: from my perspective your patch is really close to landing as it is, so we could do that then follow up with a clean cleanup patch | 10:03 |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-inspector master: Functional tests: clean up test config file https://review.openstack.org/476877 | 10:05 |
| mgoddard | sambetts: ok, it just seemed to me there was still some contention around some pieces that will be cleaned | 10:05 |
| mgoddard | sambetts: maybe you're right. I'll go through again and weigh it all up | 10:07 |
| openstackgerrit | Dao Cong Tien proposed openstack/ironic master: WIP/DNM:Temp patch to test boot-from-volume job https://review.openstack.org/476854 | 10:10 |
| sambetts | mgoddard: IMO the refactor needs to be more than just spliting the mixin class, I think that common class has become hugely bloated as we crammed to get all the neutron support in | 10:10 |
| *** junbo has quit IRC | 10:10 | |
| *** mvpnitesh has quit IRC | 10:10 | |
| *** tuanluong has quit IRC | 10:10 | |
| *** amotoki is now known as amotoki_away | 10:12 | |
| *** junbo has joined #openstack-ironic | 10:13 | |
| *** stendulker has joined #openstack-ironic | 10:18 | |
| *** jaganathan_ has quit IRC | 10:23 | |
| *** phuongnh has quit IRC | 10:26 | |
| *** ppiela has quit IRC | 10:27 | |
| *** udesale has joined #openstack-ironic | 10:27 | |
| *** ppiela has joined #openstack-ironic | 10:27 | |
| *** vmud213 has joined #openstack-ironic | 10:28 | |
| pas-ha | dtantsur|lunch: lucasagomes: a quick approve to fix unit tests on ironic-staging-drivers stable/ocata | 10:28 |
| pas-ha | https://review.openstack.org/#/c/476859/ | 10:28 |
| patchbot | patch 476859 - ironic-staging-drivers (stable/ocata) - Fix unit tests for stable/ocata | 10:28 |
| *** udesale__ has quit IRC | 10:28 | |
| lucasagomes | pas-ha, boom done! :D | 10:29 |
| pas-ha | thanks! :) | 10:29 |
| *** lucasagomes has quit IRC | 10:34 | |
| *** sai has quit IRC | 10:35 | |
| *** rook has quit IRC | 10:35 | |
| *** ijw has joined #openstack-ironic | 10:36 | |
| *** jaganathan_ has joined #openstack-ironic | 10:36 | |
| *** rook has joined #openstack-ironic | 10:37 | |
| *** rook is now known as Guest16704 | 10:37 | |
| *** sai has joined #openstack-ironic | 10:38 | |
| *** jkilpatr has quit IRC | 10:38 | |
| *** ijw has quit IRC | 10:40 | |
| *** lucasagomes has joined #openstack-ironic | 10:40 | |
| *** jaypipes has quit IRC | 10:45 | |
| *** SerenaFeng has quit IRC | 10:57 | |
| *** dtantsur|lunch is now known as dtantsur | 11:00 | |
| *** udesale has quit IRC | 11:02 | |
| TheJulia | Good morning everyone | 11:03 |
| dtantsur | morning TheJulia | 11:03 |
| TheJulia | pas-ha: heh, I remember seeing that now. :) | 11:03 |
| pas-ha | TheJulia: :) and good morning | 11:04 |
| openstackgerrit | Debayan Ray proposed openstack/proliantutils master: [WIP] Redfish: Add secure boot API support https://review.openstack.org/472244 | 11:04 |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: bindep.txt: Add explicit and missing dependencies https://review.openstack.org/476833 | 11:05 |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: scripts: install-deps: Enable the EPEL repo when running in OpenStack CI https://review.openstack.org/476868 | 11:05 |
| *** jaganathan_ has quit IRC | 11:07 | |
| *** shuyingya has quit IRC | 11:09 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Documetation for 'ilo' hardware type https://review.openstack.org/476895 | 11:09 |
| *** shuyingy_ has joined #openstack-ironic | 11:09 | |
| *** jkilpatr has joined #openstack-ironic | 11:10 | |
| *** amarao has joined #openstack-ironic | 11:10 | |
| *** vmud213 has quit IRC | 11:12 | |
| *** aparnav has quit IRC | 11:14 | |
| *** dmellado_ has joined #openstack-ironic | 11:17 | |
| *** weshay has joined #openstack-ironic | 11:18 | |
| *** dmellado_ is now known as dmellado | 11:19 | |
| *** jaganathan_ has joined #openstack-ironic | 11:20 | |
| *** marios has quit IRC | 11:22 | |
| *** lucasagomes is now known as lucas-hungry | 11:22 | |
| dtantsur | sambetts: what happened with that patch to consolidate power retries? I can't find it in my gertty | 11:22 |
| *** amotoki_away is now known as amotoki | 11:23 | |
| sambetts | dtantsur: https://review.openstack.org/#/c/449454/ | 11:25 |
| patchbot | patch 449454 - ironic - Don't retry power status if power action fails | 11:25 |
| sambetts | dtantsur: unfortunatly I've been distracted by downstream a lot recently, so not really had a chance to update it | 11:25 |
| *** skazi has joined #openstack-ironic | 11:26 | |
| sambetts | dtantsur: was trying to work out if we docuemnet any where that if you want to perform a power action you have to use the conductor utils function to do it | 11:26 |
| sambetts | dtantsur: because if we make all the retries happen in that function, then all interfaces that need to call the power driver should go through that | 11:27 |
| *** jaganathan_ has quit IRC | 11:29 | |
| *** openstackgerrit has quit IRC | 11:33 | |
| *** stendulker_ has joined #openstack-ironic | 11:35 | |
| *** mtanino_ has joined #openstack-ironic | 11:35 | |
| *** stendulker has quit IRC | 11:38 | |
| *** jaganathan has joined #openstack-ironic | 11:39 | |
| *** stendulker_ has quit IRC | 11:40 | |
| *** vmud213 has joined #openstack-ironic | 11:41 | |
| dtantsur | sambetts: good question. I wonder if it's easy to just provide an utility function for driver interfaces to call.. | 11:43 |
| dtantsur | sambetts: do you think we could take this direction for now? https://review.openstack.org/#/c/467247/ | 11:45 |
| patchbot | patch 467247 - ironic - [WIP] Move power state wait loop to utils and use ... (ABANDONED) | 11:45 |
| dtantsur | I'm worried that the redfish driver still does not wait for power state.. | 11:45 |
| *** vmud213 has quit IRC | 11:46 | |
| sambetts | dtantsur: my patch does add the utility function too, I could just remove the call to it at L193 in conductor/utils.py and readd it in the ipmi driver | 11:49 |
| dtantsur | sambetts: I'd do it for now, and then consider moving it to conductor in a separate patch | 11:49 |
| dtantsur | wdyt? | 11:49 |
| sambetts | yeah sounds like a good idea | 11:50 |
| dtantsur | sambetts: do you have time for it or should take it from here? | 11:51 |
| dtantsur | also, folks, https://review.openstack.org/#/c/476498/ finally passed the CI :) | 11:51 |
| patchbot | patch 476498 - ironic - Fetch Glance endpoint from Keystone if it's not pr... | 11:51 |
| sambetts | dtantsur: I can get it done :) | 11:52 |
| dtantsur | sambetts: thanks! | 11:52 |
| *** rnoriega has joined #openstack-ironic | 11:52 | |
| *** lhinds|out has joined #openstack-ironic | 11:55 | |
| *** shuyingy_ has quit IRC | 11:58 | |
| *** vmud213 has joined #openstack-ironic | 11:59 | |
| *** jistr is now known as jistr|errand | 12:00 | |
| *** thaj has quit IRC | 12:07 | |
| *** marlinc has quit IRC | 12:08 | |
| *** lucas-hungry is now known as lucasagomes | 12:10 | |
| *** marios has joined #openstack-ironic | 12:12 | |
| *** dprince has joined #openstack-ironic | 12:17 | |
| *** openstackgerrit has joined #openstack-ironic | 12:19 | |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: DNM - scripts: install-deps: Enable the EPEL repo when running in OpenStack CI https://review.openstack.org/476868 | 12:19 |
| *** jaganathan has quit IRC | 12:24 | |
| *** cdearborn has joined #openstack-ironic | 12:26 | |
| *** kiseok7 has quit IRC | 12:27 | |
| *** jcoufal has joined #openstack-ironic | 12:28 | |
| *** mtanino_ has quit IRC | 12:32 | |
| *** openstackgerrit has quit IRC | 12:33 | |
| *** trown|outtypewww is now known as trown | 12:36 | |
| *** SerenaFeng has joined #openstack-ironic | 12:36 | |
| *** ijw has joined #openstack-ironic | 12:37 | |
| *** SerenaFeng has quit IRC | 12:38 | |
| *** baoli has joined #openstack-ironic | 12:39 | |
| *** vmud213 has quit IRC | 12:39 | |
| *** vmud213 has joined #openstack-ironic | 12:39 | |
| *** ijw has quit IRC | 12:41 | |
| *** lucasagomes is now known as lucas-brb | 12:44 | |
| *** cdearborn has quit IRC | 12:45 | |
| *** jcoufal has quit IRC | 12:46 | |
| *** jcoufal has joined #openstack-ironic | 12:46 | |
| *** vmud213 has quit IRC | 12:48 | |
| *** vmud213 has joined #openstack-ironic | 12:49 | |
| *** vmud213 has quit IRC | 12:54 | |
| *** vmud213 has joined #openstack-ironic | 12:55 | |
| *** openstackgerrit has joined #openstack-ironic | 12:56 | |
| openstackgerrit | Merged openstack/pyghmi master: Pyghmi does not follow the pep8 standard https://review.openstack.org/476444 | 12:56 |
| *** marios has quit IRC | 12:57 | |
| *** hshiina has quit IRC | 12:58 | |
| *** skazi has quit IRC | 12:59 | |
| *** sasha2 has joined #openstack-ironic | 13:00 | |
| b00tcat | Hi all, I have some nodes stuck in "active" provisioning state - How can I force them to be available? | 13:02 |
| b00tcat | they're no longer linked to any instance uuid | 13:02 |
| *** jaypipes has joined #openstack-ironic | 13:05 | |
| *** gcb has quit IRC | 13:08 | |
| *** Dinesh_Bhor has quit IRC | 13:10 | |
| *** jaganathan has joined #openstack-ironic | 13:10 | |
| *** vmud213 has quit IRC | 13:12 | |
| *** bfournie has quit IRC | 13:12 | |
| *** vmud213 has joined #openstack-ironic | 13:13 | |
| *** Goneri has joined #openstack-ironic | 13:17 | |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: DNM - scripts: install-deps: Enable the EPEL repo when running in OpenStack CI https://review.openstack.org/476868 | 13:20 |
| *** vmud213 has quit IRC | 13:21 | |
| *** lhinds|out is now known as lhinds | 13:21 | |
| *** vmud213 has joined #openstack-ironic | 13:21 | |
| *** jaganathan has quit IRC | 13:21 | |
| *** jaganathan has joined #openstack-ironic | 13:23 | |
| sambetts | b00tcat: ironic node-set-provision-state <node> deleted | 13:25 |
| *** jaypipes is now known as leakypipes | 13:25 | |
| *** jistr|errand is now known as jistr | 13:25 | |
| ricardoas1 | morning, ironic! | 13:26 |
| *** ricardoas1 is now known as ricardoas | 13:26 | |
| *** marios has joined #openstack-ironic | 13:27 | |
| b00tcat | gonna try, thanks sambetts | 13:29 |
| *** jaganathan has quit IRC | 13:30 | |
| *** vmud213 has quit IRC | 13:31 | |
| *** jcoufal has quit IRC | 13:31 | |
| *** dansmith is now known as superdan | 13:32 | |
| ricardoas | Ironic´ers... OneView does not allow to change boot device of a powered on server... is it ok to store the ¨next boot device¨ at driver_internal_info and perform the operation as a side effect after the next power off?? | 13:35 |
| dtantsur | ricardoas: probably before the next power on. but yeah, seems fine. | 13:35 |
| *** mgoddard has quit IRC | 13:35 | |
| ricardoas | dtantsur: you mean as a side effect before powering on, right? | 13:37 |
| ricardoas | any special reason? | 13:37 |
| dtantsur | ricardoas: just feel more logical to do right before it's going to be in effect | 13:38 |
| dtantsur | right | 13:38 |
| ricardoas | dtantsur: this solves that problem with agent_pxe_oneview... :) | 13:38 |
| mjturek | gm ironic | 13:39 |
| *** jcoufal has joined #openstack-ironic | 13:39 | |
| ricardoas | dtantsur: thanks! | 13:40 |
| *** marlinc_ has joined #openstack-ironic | 13:42 | |
| *** lucas-brb is now known as lucasagomes | 13:44 | |
| *** shuyingya has joined #openstack-ironic | 13:47 | |
| *** crushil has joined #openstack-ironic | 13:47 | |
| *** mtanino_ has joined #openstack-ironic | 13:51 | |
| *** shuyingya has quit IRC | 13:51 | |
| mjturek | vsaienk0: just wanna confirm - on https://review.openstack.org/#/c/413324/40/ you want some unit tests ensuring rendering failure when we're missing params? | 13:53 |
| patchbot | patch 413324 - ironic - iPXE template support for iSCSI | 13:53 |
| *** SerenaFeng has joined #openstack-ironic | 13:54 | |
| *** bfournie has joined #openstack-ironic | 13:55 | |
| *** chlong has joined #openstack-ironic | 13:56 | |
| vsaienk0 | mjturek: construction in python jinja2 {if map.key } is valid while for ansible you have to use {if map.key is defined} I was confused by this | 13:56 |
| *** SerenaFeng has quit IRC | 13:56 | |
| mjturek | ahhhhh - understood | 13:57 |
| mjturek | thanks vsaienk0 | 13:57 |
| *** hel0tsp has quit IRC | 13:57 | |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: DNM - scripts: install-deps: Enable the EPEL repo when running in OpenStack CI https://review.openstack.org/476868 | 13:58 |
| *** trown is now known as trown|brb | 14:01 | |
| *** litao__ has joined #openstack-ironic | 14:03 | |
| *** mrchao has quit IRC | 14:06 | |
| openstackgerrit | Rushil Chugh proposed openstack/ironic-specs master: Add spec for XClarity Driver https://review.openstack.org/476922 | 14:12 |
| *** trown|brb is now known as trown | 14:12 | |
| litao__ | hi guys, I summited a bp about service management for ironic conductor, please help to review it | 14:13 |
| litao__ | https://review.openstack.org/#/c/471217/ | 14:13 |
| patchbot | patch 471217 - ironic-specs - Add service management API for ironic | 14:13 |
| *** bcornec1 has quit IRC | 14:14 | |
| *** rama_y has joined #openstack-ironic | 14:17 | |
| *** jaganathan has joined #openstack-ironic | 14:20 | |
| *** dyasny has quit IRC | 14:26 | |
| *** dyasny has joined #openstack-ironic | 14:26 | |
| *** rama_y has quit IRC | 14:29 | |
| *** ijw has joined #openstack-ironic | 14:32 | |
| *** bcornec1 has joined #openstack-ironic | 14:32 | |
| *** jaganathan has quit IRC | 14:34 | |
| *** mgoddard has joined #openstack-ironic | 14:36 | |
| *** udesale has joined #openstack-ironic | 14:36 | |
| openstackgerrit | Mark Goddard proposed openstack/ironic master: Physical network aware VIF attachment https://review.openstack.org/470406 | 14:36 |
| *** rpioso has joined #openstack-ironic | 14:41 | |
| vdrok | dtantsur: tiny nit in that glance patch, but iiuc it may bring some confusion :) | 14:42 |
| dtantsur | yeah, on it now | 14:42 |
| mgoddard | sambetts: in the end I decided to remove non-neutron interface support in the above patch as I think it's the right thing to do, even if it takes a little longer to land that patch. If you'd rather the non-neutron support removal was explicit and in a separate patch, I've got a patch ready to go which does that - let me know what you'd prefer | 14:42 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Fetch Glance endpoint from Keystone if it's not provided in the configuration https://review.openstack.org/476498 | 14:43 |
| dtantsur | vdrok: ^^^ | 14:43 |
| vdrok | thx! | 14:43 |
| dtantsur | ouch | 14:45 |
| dtantsur | ah, hmm, no, it's ok | 14:45 |
| *** milan has joined #openstack-ironic | 14:45 | |
| milan | morning Ironic! :) | 14:46 |
| dtantsur | good early morning milan :D | 14:46 |
| dtantsur | and | 14:46 |
| dtantsur | T | 14:46 |
| dtantsur | G | 14:46 |
| dtantsur | I | 14:46 |
| dtantsur | F | 14:46 |
| dtantsur | !! | 14:46 |
| openstack | dtantsur: Error: "!" is not a valid command. | 14:46 |
| milan | lol :D | 14:46 |
| milan | TGIF! :D | 14:46 |
| milan | how's the gate? | 14:48 |
| dtantsur | golden apparently | 14:49 |
| milan | nice! :D | 14:49 |
| * milan just opened the whiteboard | 14:49 | |
| *** krtaylor has joined #openstack-ironic | 14:51 | |
| milan | http://logs.openstack.org/03/439603/25/check/gate-grenade-dsvm-ironic-inspector-ubuntu-xenial/996178a/logs/grenade.sh.txt.gz#_2017-06-23_06_49_47_774 | 14:54 |
| milan | inspector having some installation issues? | 14:54 |
| *** jistr is now known as jistr|mtg | 14:54 | |
| *** fragatina has quit IRC | 14:56 | |
| *** fragatina has joined #openstack-ironic | 14:56 | |
| derekh | I've just tried out the most recent BFV patches and booting fails as boot.ipxe doesn't exist in /httpboot , when I manually put it there the instance boots | 14:58 |
| derekh | looks like deploy_ramdisk should be creating the file, is that not getting called any longer? | 14:58 |
| *** e0ne has quit IRC | 15:00 | |
| *** mjura has quit IRC | 15:01 | |
| *** rcernin_ has quit IRC | 15:01 | |
| *** rama_y has joined #openstack-ironic | 15:05 | |
| NobodyCam | Good Morning Ironic'ers.. and ....... | 15:06 |
| NobodyCam | TGIF! | 15:06 |
| NobodyCam | :):P | 15:06 |
| mjturek | gm NobodyCam! TGIF | 15:06 |
| NobodyCam | good morning mjturek :) | 15:07 |
| dtantsur | morning NobodyCam and mjturek :) | 15:07 |
| mjturek | derekh: when you say deploy_ramdisk isn't getting called, you mean it's not booting into the deploy_ramdisk | 15:07 |
| NobodyCam | Morning dtantsur :) | 15:07 |
| mjturek | ? | 15:07 |
| mjturek | morning dtantsur :) | 15:07 |
| TheJulia | so, I think the standard workflow, i.e. sending a machine through cleaning would cover it, but I guess the first deploy does make sense to put the file in place | 15:08 |
| sambetts | mgoddard: wow that makes that patch a lot cleaner | 15:09 |
| derekh | mjturek: sorry, I meant to say "prepare_ramdisk" | 15:10 |
| derekh | mjturek: I mean, as far as I can see this function is suppose to create boot.ipxe https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L369 | 15:11 |
| derekh | mjturek: but I have no boot.ipxe so I assume that the function isn't being called | 15:11 |
| *** rpioso has quit IRC | 15:12 | |
| mjturek | derekh: lookin around | 15:13 |
| anupn | Good Morning Ironic'ers, it's Fri-Yay! | 15:13 |
| TheJulia | I kind of feel like the conductor should put boot.ipxe in place upon start-up if ipxe is enabled... | 15:14 |
| anupn | Hi milan: Inspector CLI made the magic | 15:14 |
| TheJulia | since it is a general helper | 15:14 |
| sambetts | mgoddard: I would be happy with that patch, but it might actually be easier to review for others if it was explict, also I would still like to see the split of that class happen into standard stuff and standard stuff + neutrony extras, but that could be a follow up to your current one or rolled up into the explict on if you want to push that | 15:14 |
| milan | anupn, hey! glad to hear! :) | 15:14 |
| anupn | milan, I did not noticed that inspector CLI do not affect the Ironic states | 15:14 |
| derekh | yup, there is nothing specific to the instance in boot.ipxe so startup would make sense | 15:14 |
| * TheJulia feels like we did this at one point in time | 15:15 | |
| anupn | milan :) | 15:15 |
| *** links has quit IRC | 15:16 | |
| milan | morning derekh mgoddard mjturek NobodyCam sambetts TheJulia! :) TGIF! :) | 15:16 |
| jlvillal | pas-ha, Makes sense then why your patch passed :) | 15:16 |
| * anupn feels i can submit a patch to improve docs for discovery | 15:16 | |
| NobodyCam | Morning milan :) | 15:16 |
| jlvillal | anupn, Please do :) | 15:16 |
| milan | and morning jlvillal and pas-ha and all! ;) | 15:16 |
| jlvillal | :) | 15:17 |
| mgoddard | sambetts: cool. I'll split out the non-neutron change then, like you say it should only help reviewers | 15:17 |
| TheJulia | anupn: seconding the please! :) | 15:17 |
| sambetts | mgoddard: thanks, sorry for the extra work | 15:17 |
| mgoddard | sambetts: as for the refactor, I'm happy to do it but I'd rather keep it separate | 15:17 |
| sambetts | +1 | 15:17 |
| mgoddard | sambetts: no problem, the patch is already done so VIF attach will just need a rebase | 15:18 |
| sambetts | awesome :D | 15:18 |
| anupn | Good morning jlvillal TheJulia NobodyCam | 15:18 |
| anupn | jlvillal, TheJulia: and yes will do it :) | 15:19 |
| anupn | wow it's Fir-Yay! | 15:19 |
| NobodyCam | morning anupn :) | 15:19 |
| openstackgerrit | Mark Goddard proposed openstack/ironic master: Assume neutron port exists in VIF attach https://review.openstack.org/476949 | 15:21 |
| *** jistr|mtg is now known as jistr | 15:30 | |
| mjturek | morning milan :) | 15:30 |
| *** amotoki is now known as amotoki_away | 15:30 | |
| mjturek | derekh: what driver are you using? agent_ipmitool? | 15:31 |
| derekh | mjturek: yup agent_ipmitool , its setup using the devstack patch, iirc all I changed did was disabled auto cleaning and restarted the conductor | 15:33 |
| *** ijw has quit IRC | 15:34 | |
| openstackgerrit | Mark Goddard proposed openstack/ironic master: Assume neutron port exists in VIF attach https://review.openstack.org/476949 | 15:35 |
| *** ijw has joined #openstack-ironic | 15:39 | |
| *** ijw_ has joined #openstack-ironic | 15:41 | |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: scripts: install-deps: Enable the EPEL repo when running in OpenStack CI https://review.openstack.org/476868 | 15:42 |
| NobodyCam | really seems the gate-grenade-dsvm-ironic-inspector-ubuntu-xenial is quite unstable | 15:43 |
| *** ijw has quit IRC | 15:44 | |
| openstackgerrit | Mark Goddard proposed openstack/ironic master: Physical network aware VIF attachment https://review.openstack.org/470406 | 15:44 |
| mjturek | derekh: yeah it should be getting called here https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L442 | 15:45 |
| mjturek | I haven't seen anything in the BFV patches stopping that.. hm | 15:45 |
| dtantsur | NobodyCam: unstable grenade, what a surprise :D | 15:45 |
| *** ijw_ has quit IRC | 15:45 | |
| NobodyCam | three recheck three different errors :p | 15:45 |
| *** bcornec1 has quit IRC | 15:46 | |
| NobodyCam | *rechecks | 15:46 |
| dtantsur | sambetts: FYI https://review.openstack.org/476900 | 15:46 |
| patchbot | patch 476900 - governance - New repository request: ironic-python-agent-builder | 15:46 |
| *** aarefiev is now known as aarefiev_afk | 15:46 | |
| openstackgerrit | Mark Goddard proposed openstack/ironic master: Physical network aware VIF attachment https://review.openstack.org/470406 | 15:46 |
| dtantsur | milan: invalid requirements error was caused by git.openstack.org being down today. should be ok now. | 15:46 |
| sambetts | dtantsur: yeah I saw on the mailer, awesome :D! I'll have to see about moving the other build processes into that repo too | 15:46 |
| sambetts | dtantsur: also I really still want to look into the buildroot method | 15:47 |
| dtantsur | cool. I'll take the DIB element. | 15:47 |
| milan | dtantsur, thx! I just rechecked it; couldn't it trace to anything I'm doing in the patch | 15:47 |
| dtantsur | NobodyCam: 2 grenade failures for me in https://review.openstack.org/#/c/476498/ :( | 15:48 |
| patchbot | patch 476498 - ironic - Fetch Glance endpoint from Keystone if it's not pr... | 15:48 |
| derekh | mjturek: ok, I'll see if I can find out | 15:48 |
| dtantsur | No sql_connection parameter is established WUT? | 15:48 |
| NobodyCam | ugh :p | 15:49 |
| *** mtanin___ has joined #openstack-ironic | 16:00 | |
| *** mtanin___ has quit IRC | 16:00 | |
| *** mtanino_ has quit IRC | 16:01 | |
| jlvillal | milan: dtantsur: I thought the plan was to go with pas-ha's patch? | 16:03 |
| derekh | mjturek: think I found it https://review.openstack.org/#/c/454243/17 | 16:04 |
| patchbot | patch 454243 - ironic - Logic for skipping deployment with BFV | 16:04 |
| milan | jlvillal, I might have missed the context (sloppy internet connection) | 16:04 |
| jlvillal | milan: I saw dtantsur post about patch: https://review.openstack.org/#/c/476498/ | 16:05 |
| patchbot | patch 476498 - ironic - Fetch Glance endpoint from Keystone if it's not pr... | 16:05 |
| * milan checks | 16:05 | |
| jlvillal | milan: But now I see dtantsur was talking to NobodyCam | 16:05 |
| mjturek | derekh: not sure what's stopping it in that patch | 16:06 |
| NobodyCam | hehehe | 16:06 |
| mjturek | but looking! | 16:06 |
| jlvillal | NobodyCam: I thought we were trying to do: https://review.openstack.org/469627 and https://review.openstack.org/467728 | 16:06 |
| patchbot | patch 469627 - ironic - Introduce keystoneauth adapters for clients | 16:06 |
| patchbot | patch 467728 - ironic - Rework keystone auth for glance | 16:06 |
| *** ijw has joined #openstack-ironic | 16:06 | |
| mjturek | ah | 16:06 |
| milan | jlvillal, ah, cool :) | 16:06 |
| mjturek | I see your comment now, cool! | 16:06 |
| mjturek | awesome catch | 16:06 |
| NobodyCam | nope its https://review.openstack.org/#/c/471156 for me | 16:07 |
| patchbot | patch 471156 - ironic-inspector - add disabled option to VALID_ADD_PORTS_VALUES | 16:07 |
| NobodyCam | :) | 16:07 |
| dtantsur | jlvillal: pas-ha's patches may take a lot of time to land | 16:08 |
| jlvillal | dtantsur: Oh :( | 16:09 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Use resource classes in the CI https://review.openstack.org/476968 | 16:10 |
| *** pcaruana has quit IRC | 16:18 | |
| *** links has joined #openstack-ironic | 16:18 | |
| dtantsur | jlvillal: so I think it's useful to fix the immediate problem (I'm pretty sure the glance change will come back soon) to not have to rush that big changes in. wdyt? | 16:19 |
| jlvillal | dtantsur: Sounds reasonable. I'm not sure how quickly the glance devstack change will come in. It broke other things too. Not just Ironic. | 16:20 |
| dtantsur | switching to wsgi is a goal of this cycle, so dunno | 16:20 |
| dtantsur | I don't think my patch is horrible anyway :) | 16:21 |
| jlvillal | dtantsur: :) Me either | 16:21 |
| *** bfournie1 has joined #openstack-ironic | 16:22 | |
| dtantsur | finally, end of Friday! see you next week, have a nice weekend :) | 16:23 |
| sambetts | cya dtantsur | 16:24 |
| *** dtantsur is now known as dtantsur|afk | 16:24 | |
| jlvillal | dtantsur|afk: Ciao | 16:25 |
| *** lucasagomes is now known as lucas-afk | 16:25 | |
| *** bfournie has quit IRC | 16:25 | |
| *** dprince has quit IRC | 16:30 | |
| openstackgerrit | Merged openstack/bifrost master: bindep.txt: Add explicit and missing dependencies https://review.openstack.org/476833 | 16:33 |
| *** trown is now known as trown|lunch | 16:35 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Use adapters for cinderclient https://review.openstack.org/476171 | 16:36 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Use adapters for neutronclient https://review.openstack.org/476170 | 16:36 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Rework keystone auth for glance https://review.openstack.org/467728 | 16:36 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Fix swiftclient creation https://review.openstack.org/476173 | 16:36 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Use adapters for inspectorclient https://review.openstack.org/476172 | 16:36 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Introduce keystoneauth adapters for clients https://review.openstack.org/469627 | 16:36 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Refactor common keystone methods https://review.openstack.org/476974 | 16:36 |
| *** exodusftw has quit IRC | 16:37 | |
| *** marios has quit IRC | 16:38 | |
| *** exodusftw has joined #openstack-ironic | 16:42 | |
| *** ccamacho is now known as ccamacho|out | 16:47 | |
| rama_y | hi mjturek, TheJulia, derekh, I would like to test the 'boot from volume' patches. Any pointers on how to get started? | 16:47 |
| TheJulia | rama_y: perhaps start with https://review.openstack.org/#/c/466568/10 and then walk through the steps that https://review.openstack.org/#/c/472740/7 uses? | 16:51 |
| patchbot | patch 466568 - ironic - Add a guide for Devstack configuration for boot-fr... | 16:51 |
| patchbot | patch 472740 - ironic - Tempest scenario test for boot-from-volume | 16:51 |
| *** yee379 has quit IRC | 16:52 | |
| *** yee379 has joined #openstack-ironic | 16:52 | |
| rama_y | hi TheJulia, I went looking for the doc patch; thanks for the links. | 16:52 |
| derekh | rama_y: This is what I've been doing on a Fedora 25 host http://paste.openstack.org/show/613527/ | 16:53 |
| *** udesale has quit IRC | 16:53 | |
| TheJulia | derekh: Thanks! | 16:54 |
| rama_y | derekh, thanks! | 16:54 |
| derekh | np | 16:55 |
| *** derekh has quit IRC | 16:56 | |
| milan | NobodyCam, hey, I wanted to check with you https://review.openstack.org/#/c/471156/6..7/ironic_inspector/test/unit/test_plugins_standard.py@193 isn't the check redundant? | 16:59 |
| patchbot | patch 471156 - ironic-inspector - add disabled option to VALID_ADD_PORTS_VALUES | 16:59 |
| NobodyCam | I didn't think so. but happy to remove it. Sorry if I miss understood the comment | 17:01 |
| milan | NobodyCam, I think it is redundant: self.active_interfaces isn't "linked" to self.data | 17:01 |
| milan | so that list never changes | 17:01 |
| milan | on the other hand, self.data does | 17:02 |
| NobodyCam | ack ... let me remove that guy | 17:02 |
| milan | NobodyCam, thx | 17:02 |
| milan | NobodyCam, gonna be 2lines shorter ;) | 17:02 |
| *** mgoddard has quit IRC | 17:03 | |
| milan | NobodyCam, just FYI: https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/test/base.py#L156 but it's not obvious those two things are not connected directly | 17:04 |
| NobodyCam | ahh :) Thank you ... great catch.. | 17:05 |
| NobodyCam | gah have to reboot my vm every time I drop the vpn | 17:05 |
| NobodyCam | one day I'll look in to why | 17:06 |
| NobodyCam | :p | 17:06 |
| milan | lol :D | 17:06 |
| openstackgerrit | Chris Krelle proposed openstack/ironic-inspector master: add disabled option to VALID_ADD_PORTS_VALUES https://review.openstack.org/471156 | 17:06 |
| NobodyCam | :) | 17:06 |
| milan | NobodyCam, I don't want to be a pain in the ass but I guess https://review.openstack.org/#/c/471156/7..8/ironic_inspector/test/unit/test_plugins_standard.py@190 is redundant now O:-) | 17:08 |
| patchbot | patch 471156 - ironic-inspector - add disabled option to VALID_ADD_PORTS_VALUES | 17:08 |
| NobodyCam | now its just getting the grenade | 17:08 |
| NobodyCam | lol | 17:08 |
| milan | yeah grenade has been a lottery recently | 17:09 |
| NobodyCam | nope totally missed that... I blame 'not enough coffee' | 17:09 |
| milan | no worries :) | 17:09 |
| *** tesseract has quit IRC | 17:11 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic-inspector master: add disabled option to VALID_ADD_PORTS_VALUES https://review.openstack.org/471156 | 17:11 |
| NobodyCam | :) | 17:11 |
| milan | NobodyCam, +2 thx! :) | 17:14 |
| NobodyCam | w00t :) | 17:14 |
| NobodyCam | thank you for the reviews | 17:14 |
| * sambetts ---> home | 17:15 | |
| *** sambetts is now known as sambetts|afk | 17:15 | |
| NobodyCam | have a good weekend sambetts|afk | 17:15 |
| sambetts|afk | Night all! cya Monday | 17:15 |
| *** links has quit IRC | 17:15 | |
| milan | NobodyCam np! :) | 17:16 |
| * milan calling it a day too! | 17:16 | |
| milan | Night Ironic! :) | 17:16 |
| NobodyCam | night milan | 17:17 |
| NobodyCam | have a good weekend | 17:17 |
| milan | o/ :) | 17:17 |
| milan | thanks same to you! :) | 17:17 |
| *** milan has quit IRC | 17:17 | |
| *** livelace has joined #openstack-ironic | 17:20 | |
| *** amarao has quit IRC | 17:27 | |
| *** fragatina has quit IRC | 17:27 | |
| *** ChubYann has joined #openstack-ironic | 17:27 | |
| *** hel0tsp has joined #openstack-ironic | 17:43 | |
| *** trown|lunch is now known as trown | 17:52 | |
| *** dprince has joined #openstack-ironic | 18:01 | |
| *** ijw has quit IRC | 18:08 | |
| openstackgerrit | Rodrigo Farias de Macedo proposed openstack/ironic master: [WIP] Migrate oneview driver to use python-hpOneView https://review.openstack.org/466872 | 18:17 |
| *** hel0tsp has quit IRC | 18:19 | |
| *** hel0tsp has joined #openstack-ironic | 18:21 | |
| *** hel0tsp has quit IRC | 18:22 | |
| *** hel0tsp has joined #openstack-ironic | 18:22 | |
| *** ricardoas has quit IRC | 18:34 | |
| *** ijw_ has joined #openstack-ironic | 18:36 | |
| *** ijw_ has quit IRC | 18:41 | |
| *** exodusftw has quit IRC | 19:03 | |
| *** exodusftw has joined #openstack-ironic | 19:10 | |
| *** yusef has quit IRC | 19:20 | |
| *** marlinc_ has quit IRC | 19:20 | |
| *** marlinc_ has joined #openstack-ironic | 19:32 | |
| *** e0ne has joined #openstack-ironic | 19:36 | |
| *** livelace has quit IRC | 19:37 | |
| *** exodusftw has quit IRC | 19:47 | |
| *** e0ne has quit IRC | 19:47 | |
| *** livelace has joined #openstack-ironic | 19:49 | |
| *** bfournie1 has quit IRC | 19:50 | |
| *** karthiks has quit IRC | 19:50 | |
| *** exodusftw has joined #openstack-ironic | 19:52 | |
| *** adisky__ has quit IRC | 19:54 | |
| *** Goneri has quit IRC | 20:13 | |
| *** silvrax has quit IRC | 20:23 | |
| *** livelace has quit IRC | 20:31 | |
| *** marlinc_ has quit IRC | 20:32 | |
| *** trown is now known as trown|outtypewww | 20:57 | |
| *** jcoufal has quit IRC | 21:05 | |
| *** Goneri has joined #openstack-ironic | 21:17 | |
| *** fragatina has joined #openstack-ironic | 21:18 | |
| *** ijw has joined #openstack-ironic | 21:19 | |
| *** dprince has quit IRC | 21:36 | |
| *** hel0tsp1 has joined #openstack-ironic | 21:38 | |
| *** hel0tsp has quit IRC | 21:38 | |
| *** shobhar_ has joined #openstack-ironic | 21:39 | |
| *** priteau has quit IRC | 21:54 | |
| *** priteau has joined #openstack-ironic | 21:55 | |
| *** priteau has quit IRC | 22:00 | |
| *** shobhar__ has joined #openstack-ironic | 22:00 | |
| *** shobhar_ has quit IRC | 22:03 | |
| *** jkilpatr has quit IRC | 22:05 | |
| *** baoli has quit IRC | 22:06 | |
| *** paramite_ has quit IRC | 22:07 | |
| *** MattMan_1 has quit IRC | 22:16 | |
| *** MattMan_1 has joined #openstack-ironic | 22:17 | |
| *** jkilpatr has joined #openstack-ironic | 22:20 | |
| *** ijw has quit IRC | 22:30 | |
| *** ijw has joined #openstack-ironic | 22:31 | |
| *** hel0tsp has joined #openstack-ironic | 22:41 | |
| *** hel0tsp1 has quit IRC | 22:41 | |
| *** rbudden has quit IRC | 22:43 | |
| *** fragatina has quit IRC | 22:43 | |
| *** chlong has quit IRC | 22:45 | |
| jlvillal | Any chance that the gate is broken in regards to Grenade? | 22:46 |
| *** Goneri has quit IRC | 22:46 | |
| *** leakypipes has quit IRC | 22:48 | |
| *** shobhar__ has quit IRC | 22:48 | |
| *** shobhar has joined #openstack-ironic | 22:48 | |
| rama_y | jlvillal, it appears so. | 22:53 |
| *** shobhar_ has joined #openstack-ironic | 22:53 | |
| *** shobhar has quit IRC | 22:53 | |
| NobodyCam | Man I can not get grenade job to pass :( | 22:54 |
| jlvillal | NobodyCam: That is what I'm saying. I updated the Whiteboard | 22:54 |
| jlvillal | rama_y: Thanks | 22:54 |
| NobodyCam | !!!! :) thank you jlvillal | 22:54 |
| openstack | NobodyCam: Error: "!!!" is not a valid command. | 22:54 |
| NobodyCam | :) thank you jlvillal | 22:55 |
| jlvillal | NobodyCam: If you have been investigating the details maybe you can add them to the Whiteboard? | 22:55 |
| NobodyCam | I have not! sorry | 22:55 |
| jlvillal | I just noticed multiple jobs failing | 22:55 |
| jlvillal | NobodyCam: Well it is getting late on a Friday :) | 22:55 |
| NobodyCam | yea | 22:55 |
| *** ijw has quit IRC | 23:06 | |
| *** ijw has joined #openstack-ironic | 23:07 | |
| rama_y | jlvillal, it appears to be this patch merge: https://github.com/openstack-dev/devstack/commit/a02b9ba1b195e3ca407cdc657f71b17d706144b6#diff-665a24457e945ac31372cf63d00a4080R636 | 23:13 |
| jlvillal | rama_y: Awesome for researching that. | 23:13 |
| jlvillal | rama_y: Can you test out that assumption by doing a "null" patch that depends on reverting that devstack patch? | 23:14 |
| rama_y | jlvillal, I will try | 23:15 |
| jlvillal | rama_y: Thanks! | 23:15 |
| *** jralph has quit IRC | 23:16 | |
| *** ijw has quit IRC | 23:16 | |
| *** ijw has joined #openstack-ironic | 23:17 | |
| *** shobhar_ has quit IRC | 23:29 | |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic master: [WIP][DNM] Testing if reverting devstack patch will fix grenade https://review.openstack.org/477043 | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!