| *** rama_y_ has quit IRC | 00:10 | |
| *** goldyfruit has quit IRC | 00:10 | |
| *** ijw has quit IRC | 00:11 | |
| *** ijw has joined #openstack-ironic | 00:19 | |
| openstackgerrit | Hironori Shiina proposed openstack/ironic master: Add REST API for volume connector and volume target operation https://review.openstack.org/214586 | 00:24 |
|---|---|---|
| *** Sukhdev has quit IRC | 00:27 | |
| *** rpioso has quit IRC | 00:40 | |
| *** shuyingya has joined #openstack-ironic | 00:46 | |
| *** tuanluong has joined #openstack-ironic | 00:50 | |
| *** makowals has quit IRC | 00:56 | |
| *** ijw has quit IRC | 01:00 | |
| *** ijw has joined #openstack-ironic | 01:02 | |
| *** phuongnh has joined #openstack-ironic | 01:03 | |
| *** SerenaFeng has joined #openstack-ironic | 01:05 | |
| *** ijw has quit IRC | 01:06 | |
| *** ijw has joined #openstack-ironic | 01:12 | |
| *** ijw has quit IRC | 01:14 | |
| *** baoli has joined #openstack-ironic | 01:15 | |
| *** baoli has quit IRC | 01:16 | |
| *** baoli has joined #openstack-ironic | 01:17 | |
| *** ijw has joined #openstack-ironic | 01:19 | |
| *** baoli has quit IRC | 01:23 | |
| *** ijw has quit IRC | 01:24 | |
| *** baoli has joined #openstack-ironic | 01:28 | |
| openstackgerrit | Hironori Shiina proposed openstack/ironic master: Enable cinder storage interface for generic hardware https://review.openstack.org/463908 | 01:28 |
| openstackgerrit | Hironori Shiina proposed openstack/ironic master: Add storage interface field to node-related notifications https://review.openstack.org/463972 | 01:29 |
| openstackgerrit | Hironori Shiina proposed openstack/ironic master: DevStack: Add configuration for boot-from-volume https://review.openstack.org/466333 | 01:29 |
| *** chlong has joined #openstack-ironic | 01:44 | |
| *** rloo has quit IRC | 01:45 | |
| *** lhinds has quit IRC | 01:47 | |
| *** rnoriega has quit IRC | 01:47 | |
| *** marios has quit IRC | 01:49 | |
| *** phuongnh has quit IRC | 01:49 | |
| *** phuongnh has joined #openstack-ironic | 01:51 | |
| *** zhurong has joined #openstack-ironic | 01:52 | |
| *** baoli has quit IRC | 01:55 | |
| *** makowals has joined #openstack-ironic | 01:58 | |
| *** yee379 has quit IRC | 02:00 | |
| *** yee379 has joined #openstack-ironic | 02:01 | |
| openstackgerrit | D G Lee proposed openstack/ironic master: ironic-conductor can't report heartbeat to database https://review.openstack.org/475210 | 02:02 |
| *** chlong has quit IRC | 02:04 | |
| *** rama_y has joined #openstack-ironic | 02:05 | |
| *** baoli has joined #openstack-ironic | 02:07 | |
| *** rama_y has quit IRC | 02:10 | |
| openstackgerrit | Hironori Shiina proposed openstack/ironic master: Add REST API for volume connector and volume target operation https://review.openstack.org/214586 | 02:14 |
| *** namnh has joined #openstack-ironic | 02:27 | |
| *** Sukhdev has joined #openstack-ironic | 02:31 | |
| *** chlong has joined #openstack-ironic | 02:37 | |
| *** Sukhdev has quit IRC | 02:43 | |
| *** baoli has quit IRC | 02:45 | |
| *** phuongnh has quit IRC | 02:58 | |
| *** phuongnh has joined #openstack-ironic | 02:59 | |
| *** rbudden has quit IRC | 03:03 | |
| *** phuongnh has quit IRC | 03:04 | |
| *** phuongnh has joined #openstack-ironic | 03:05 | |
| *** xiefp has joined #openstack-ironic | 03:05 | |
| *** amotoki_away is now known as amotoki | 03:06 | |
| *** crushil has quit IRC | 03:11 | |
| *** makowals has quit IRC | 03:23 | |
| *** udesale has joined #openstack-ironic | 03:33 | |
| *** lennyb has quit IRC | 03:40 | |
| *** namnh_ has joined #openstack-ironic | 03:45 | |
| *** namnh has quit IRC | 03:48 | |
| *** zhurong has quit IRC | 03:49 | |
| *** lennyb has joined #openstack-ironic | 03:52 | |
| *** phuongnh has quit IRC | 03:53 | |
| *** phuongnh has joined #openstack-ironic | 03:54 | |
| *** makowals has joined #openstack-ironic | 03:55 | |
| openstackgerrit | Aparna proposed openstack/proliantutils master: Change Logs for proliantutils 2.3.0 release https://review.openstack.org/476066 | 03:56 |
| *** SerenaFeng has quit IRC | 04:02 | |
| *** chlong has quit IRC | 04:02 | |
| openstackgerrit | paresh sao proposed openstack/proliantutils master: Redfish: Adding the ability to get one time boot https://review.openstack.org/474093 | 04:10 |
| *** vmud213 has joined #openstack-ironic | 04:15 | |
| *** chlong has joined #openstack-ironic | 04:16 | |
| *** links has joined #openstack-ironic | 04:21 | |
| *** adisky__ has joined #openstack-ironic | 04:31 | |
| *** makowals has quit IRC | 04:39 | |
| *** makowals has joined #openstack-ironic | 04:52 | |
| *** makowals has quit IRC | 04:57 | |
| *** yuanying_ has joined #openstack-ironic | 05:03 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 05:03 | |
| Nisha_Agarwal | vsaienk0, hi | 05:05 |
| *** yuanying has quit IRC | 05:05 | |
| *** jaganathan has quit IRC | 05:10 | |
| *** jaganathan has joined #openstack-ironic | 05:10 | |
| *** mvpnitesh has joined #openstack-ironic | 05:11 | |
| *** vmud213 has quit IRC | 05:12 | |
| *** vmud213 has joined #openstack-ironic | 05:13 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic master: Add RedfishInspect Interface https://review.openstack.org/449425 | 05:13 |
| openstackgerrit | Aparna proposed openstack/proliantutils master: Change Logs for proliantutils 2.3.0 release https://review.openstack.org/476066 | 05:14 |
| *** exoduswtf has joined #openstack-ironic | 05:20 | |
| *** jaganathan has quit IRC | 05:21 | |
| *** marios has joined #openstack-ironic | 05:26 | |
| *** e0ne has joined #openstack-ironic | 05:29 | |
| openstackgerrit | Aparna proposed openstack/ironic-python-agent master: Rescue extension for CoreOS with DHCP tenant networks https://review.openstack.org/423521 | 05:37 |
| *** SerenaFeng has joined #openstack-ironic | 05:43 | |
| *** ChubYann has quit IRC | 05:44 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic master: Fixes hashing issues for py3.5 https://review.openstack.org/473888 | 05:44 |
| openstackgerrit | paresh sao proposed openstack/proliantutils master: Redfish: Adding the ability to get pending boot mode https://review.openstack.org/467982 | 05:53 |
| *** mjura has joined #openstack-ironic | 05:53 | |
| *** mjura has quit IRC | 05:54 | |
| *** mjura has joined #openstack-ironic | 05:54 | |
| *** makowals has joined #openstack-ironic | 05:56 | |
| *** ccamacho has quit IRC | 05:56 | |
| *** Dinesh_Bhor has quit IRC | 05:57 | |
| *** e0ne has quit IRC | 06:06 | |
| *** Dinesh_Bhor has joined #openstack-ironic | 06:06 | |
| openstackgerrit | paresh sao proposed openstack/proliantutils master: Redfish: Adding the ability to get pending boot mode https://review.openstack.org/467982 | 06:08 |
| *** ijw has joined #openstack-ironic | 06:09 | |
| *** aparnav has joined #openstack-ironic | 06:12 | |
| *** ijw has quit IRC | 06:14 | |
| openstackgerrit | Aparna proposed openstack/ironic master: Add manual clean step ironic standalone test https://review.openstack.org/429770 | 06:17 |
| *** yuanying_ has quit IRC | 06:19 | |
| *** yuanying has joined #openstack-ironic | 06:20 | |
| openstackgerrit | paresh sao proposed openstack/proliantutils master: Redfish: Adding the ability to get current boot mode https://review.openstack.org/466697 | 06:22 |
| openstackgerrit | paresh sao proposed openstack/proliantutils master: Redfish: Adding the ability to get current boot mode https://review.openstack.org/466697 | 06:24 |
| *** e0ne has joined #openstack-ironic | 06:26 | |
| *** hshiina has joined #openstack-ironic | 06:26 | |
| *** rcernin has joined #openstack-ironic | 06:30 | |
| *** phuongnh has quit IRC | 06:32 | |
| *** phuongnh has joined #openstack-ironic | 06:32 | |
| *** rcernin has quit IRC | 06:37 | |
| *** marios has quit IRC | 06:42 | |
| *** e0ne has quit IRC | 06:42 | |
| *** marios has joined #openstack-ironic | 06:42 | |
| *** marios has quit IRC | 06:43 | |
| *** marios has joined #openstack-ironic | 06:44 | |
| *** jaganathan has joined #openstack-ironic | 06:46 | |
| *** ijw has joined #openstack-ironic | 06:47 | |
| *** rcernin has joined #openstack-ironic | 06:50 | |
| *** ijw has quit IRC | 06:52 | |
| *** jaganathan has quit IRC | 06:57 | |
| *** jaganathan has joined #openstack-ironic | 06:57 | |
| *** tesseract has joined #openstack-ironic | 07:02 | |
| *** pcaruana has joined #openstack-ironic | 07:05 | |
| *** mvpnitesh has quit IRC | 07:06 | |
| *** igordcard has quit IRC | 07:09 | |
| *** mjura has quit IRC | 07:11 | |
| *** igordcard has joined #openstack-ironic | 07:11 | |
| *** mjura has joined #openstack-ironic | 07:11 | |
| *** ralonsoh has joined #openstack-ironic | 07:13 | |
| *** mjura has quit IRC | 07:16 | |
| *** mjura has joined #openstack-ironic | 07:16 | |
| *** igordcard has quit IRC | 07:19 | |
| *** igordcard has joined #openstack-ironic | 07:20 | |
| openstackgerrit | Aparna proposed openstack/proliantutils master: Change Logs for proliantutils 2.3.0 release https://review.openstack.org/476066 | 07:24 |
| *** ccamacho has joined #openstack-ironic | 07:28 | |
| openstackgerrit | Aparna proposed openstack/ironic master: Adds functionality test for erase_devices https://review.openstack.org/472558 | 07:32 |
| *** mrchao has joined #openstack-ironic | 07:33 | |
| *** dtantsur|afk is now known as dtantsur | 07:35 | |
| *** priteau has joined #openstack-ironic | 07:51 | |
| *** bnemec has quit IRC | 07:52 | |
| dtantsur | Nisha_Agarwal: vsaienk0 is in EU time, he may be online now | 07:53 |
| dtantsur | s/EU/eastern Europe/ | 07:53 |
| vsaienk0 | morning dtantsur, Nisha_Agarwal, vdrok, pas-ha and all ironic'ers! | 07:56 |
| vdrok | morning dtantsur , vsaienk0 | 07:58 |
| dtantsur | o/ | 07:58 |
| vdrok | and good morning ironic | 07:58 |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-ironic | 08:00 | |
| *** xiefp has quit IRC | 08:03 | |
| *** bnemec has joined #openstack-ironic | 08:08 | |
| *** yuanying_ has joined #openstack-ironic | 08:09 | |
| *** SerenaFeng has quit IRC | 08:10 | |
| tuanluong | morning ironic | 08:12 |
| *** yuanying has quit IRC | 08:13 | |
| *** vmud213 has quit IRC | 08:13 | |
| Nisha_Agarwal | dtantsur, :) | 08:13 |
| Nisha_Agarwal | morning dtantsur vsaienk0 vdrok pas-ha and ironic!!! | 08:13 |
| tuanluong | morning vdrok, dtantsur vsaienk0 pas-ha Nisha_Agarwal | 08:14 |
| *** vmud213 has joined #openstack-ironic | 08:14 | |
| Nisha_Agarwal | tuanluong, o/ | 08:15 |
| *** e0ne has joined #openstack-ironic | 08:20 | |
| *** SerenaFeng has joined #openstack-ironic | 08:23 | |
| openstackgerrit | huayue proposed openstack/pyghmi master: Pyghmi does not follow the pep8 standard https://review.openstack.org/476405 | 08:25 |
| *** mgoddard has joined #openstack-ironic | 08:25 | |
| openstackgerrit | huayue proposed openstack/pyghmi master: Pyghmi does not follow the pep8 standard https://review.openstack.org/476405 | 08:27 |
| *** zhurong has joined #openstack-ironic | 08:29 | |
| *** lucas-afk is now known as lucasagomes | 08:33 | |
| *** b00tcat has joined #openstack-ironic | 08:34 | |
| *** b00tcat_ has quit IRC | 08:34 | |
| *** ijw has joined #openstack-ironic | 08:36 | |
| *** ijw has quit IRC | 08:37 | |
| *** derekh has joined #openstack-ironic | 08:38 | |
| *** ijw has joined #openstack-ironic | 08:38 | |
| *** dmk0202 has joined #openstack-ironic | 08:40 | |
| *** ijw has quit IRC | 08:42 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Refactoring the firewall https://review.openstack.org/471831 | 08:42 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: PXE boot filtering drivers https://review.openstack.org/439603 | 08:42 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Introducing a dnsmasq PXE filter driver https://review.openstack.org/466448 | 08:42 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: TEST check dnsmasq PXE filter in devstack https://review.openstack.org/468712 | 08:42 |
| *** fxpester has joined #openstack-ironic | 08:43 | |
| *** aarefiev_afk is now known as aarefiev | 08:43 | |
| aarefiev | morning all! | 08:43 |
| *** marios has quit IRC | 08:44 | |
| *** marios has joined #openstack-ironic | 08:45 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Refactoring the firewall https://review.openstack.org/471831 | 08:48 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: PXE boot filtering drivers https://review.openstack.org/439603 | 08:48 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Introducing a dnsmasq PXE filter driver https://review.openstack.org/466448 | 08:48 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: TEST check dnsmasq PXE filter in devstack https://review.openstack.org/468712 | 08:48 |
| *** milan has joined #openstack-ironic | 08:52 | |
| milan | morning Ironic! :) | 08:53 |
| *** shuyingya has quit IRC | 08:57 | |
| *** racedo has joined #openstack-ironic | 09:01 | |
| dtantsur | morning milan | 09:02 |
| milan | morning dtantsur! :) | 09:03 |
| * milan was a bit messy w/ the filter patch update | 09:03 | |
| *** hshiina has quit IRC | 09:06 | |
| *** athomas has joined #openstack-ironic | 09:10 | |
| openstackgerrit | Nguyen Hung Phuong proposed openstack/ironic master: Add functional API tests for volume connector and volume target https://review.openstack.org/473717 | 09:13 |
| dtantsur | milan: the gate is down, so take your time.. | 09:14 |
| *** zhurong has quit IRC | 09:16 | |
| *** b00tcat has quit IRC | 09:17 | |
| *** b00tcat has joined #openstack-ironic | 09:17 | |
| *** Nisha_Agarwal has quit IRC | 09:19 | |
| milan | oh | 09:24 |
| * dtantsur -> office | 09:24 | |
| *** dtantsur is now known as dtantsur|bbl | 09:25 | |
| *** athomas has quit IRC | 09:25 | |
| openstackgerrit | paresh sao proposed openstack/proliantutils master: Add support to get iscsi initiator iqn capability https://review.openstack.org/474178 | 09:29 |
| *** mjura has quit IRC | 09:31 | |
| *** amarao has joined #openstack-ironic | 09:34 | |
| openstackgerrit | Merged openstack/proliantutils master: Redfish: Adding the ability to get one time boot https://review.openstack.org/474093 | 09:37 |
| *** Administrator__ has joined #openstack-ironic | 09:37 | |
| *** Administrator_ has quit IRC | 09:40 | |
| *** dmk0202 has quit IRC | 09:40 | |
| *** mjura has joined #openstack-ironic | 09:46 | |
| openstackgerrit | huayue proposed openstack/pyghmi master: Pyghmi does not follow the pep8 standard https://review.openstack.org/476444 | 09:53 |
| *** milan has quit IRC | 10:04 | |
| openstackgerrit | huayue proposed openstack/pyghmi master: Pyghmi does not follow the pep8 standard https://review.openstack.org/476444 | 10:08 |
| *** aparnav has quit IRC | 10:11 | |
| *** aparnav has joined #openstack-ironic | 10:11 | |
| *** sai has quit IRC | 10:18 | |
| *** rook has quit IRC | 10:18 | |
| openstackgerrit | paresh sao proposed openstack/proliantutils master: Redfish: Adding the ability to get pending boot mode https://review.openstack.org/467982 | 10:18 |
| *** sai has joined #openstack-ironic | 10:23 | |
| *** rook has joined #openstack-ironic | 10:27 | |
| *** rook is now known as Guest250 | 10:28 | |
| *** zhurong has joined #openstack-ironic | 10:32 | |
| *** dtantsur|bbl is now known as dtantsur | 10:34 | |
| *** baoli has joined #openstack-ironic | 10:46 | |
| *** milan has joined #openstack-ironic | 10:49 | |
| aarefiev | dtantsur: hey, mind to add to your list https://review.openstack.org/#/c/463768/3 | 10:50 |
| patchbot | patch 463768 - ironic-inspector - Use declarative reader/writer separation | 10:50 |
| aarefiev | so we could agree on direction | 10:50 |
| *** baoli has quit IRC | 10:51 | |
| dtantsur | sure, will try | 10:52 |
| dtantsur | pas-ha: morning! do you think it's possible to have a quick-and-dirty fix for glance in our case? | 10:52 |
| dtantsur | I believe we could do it, unbreak the gate, then proceed with your patch chain asap | 10:52 |
| *** mat128 has joined #openstack-ironic | 10:53 | |
| milan | hey aarefiev! :) | 10:54 |
| milan | and pas-ha! :) | 10:54 |
| dtantsur | like hack generate_glance_url in https://review.openstack.org/#/c/467728/14/ironic/common/glance_service/service_utils.py to try keystone.. | 10:54 |
| patchbot | patch 467728 - ironic - Rework keystone auth for glance | 10:54 |
| aarefiev | morning milan :) | 10:54 |
| *** sambetts|afk has quit IRC | 10:56 | |
| *** phuongnh has quit IRC | 11:01 | |
| *** sambetts_ has joined #openstack-ironic | 11:02 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-ui master: Imported Translations from Zanata https://review.openstack.org/476463 | 11:03 |
| *** jkilpatr has joined #openstack-ironic | 11:05 | |
| *** SerenaFeng has quit IRC | 11:08 | |
| *** fellypefca has joined #openstack-ironic | 11:08 | |
| *** lucasagomes is now known as lucas-hungry | 11:10 | |
| *** ijw has joined #openstack-ironic | 11:20 | |
| *** ijw has quit IRC | 11:25 | |
| *** amarao has quit IRC | 11:30 | |
| mgoddard | morning ironic | 11:30 |
| mgoddard | sambetts: hey. about your comments on the physnet VIF attach review: sounds like it's safe to stop caring about the non-neutron case? | 11:31 |
| mgoddard | sambetts_: ^^ | 11:32 |
| *** amarao has joined #openstack-ironic | 11:39 | |
| *** udesale has quit IRC | 11:52 | |
| *** litao__ has quit IRC | 11:54 | |
| *** zhurong has quit IRC | 12:01 | |
| *** aarefiev has quit IRC | 12:04 | |
| *** tuanluong has quit IRC | 12:06 | |
| *** namnh_ has quit IRC | 12:07 | |
| *** aarefiev has joined #openstack-ironic | 12:10 | |
| *** dprince has joined #openstack-ironic | 12:12 | |
| openstackgerrit | Aparna proposed openstack/proliantutils master: Change Logs for proliantutils 2.3.0 release https://review.openstack.org/476066 | 12:13 |
| *** trown|outtypewww is now known as trown | 12:13 | |
| *** zhurong has joined #openstack-ironic | 12:16 | |
| *** lucas-hungry is now known as lucasagomes | 12:16 | |
| *** rbudden has joined #openstack-ironic | 12:16 | |
| *** zhurong has quit IRC | 12:18 | |
| *** aparnav has quit IRC | 12:19 | |
| *** gcb has joined #openstack-ironic | 12:20 | |
| *** chlong has quit IRC | 12:26 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Introduce keystoneauth adapters for clients https://review.openstack.org/469627 | 12:27 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Introduce keystoneauth adapters for clients https://review.openstack.org/469627 | 12:30 |
| *** vmud213 has quit IRC | 12:31 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Quick hack to fetch Glance endpoint from Keystone https://review.openstack.org/476498 | 12:35 |
| dtantsur | pas-ha, TheJulia, wdyt about quick hack ^^^ | 12:35 |
| TheJulia | dtantsur: resistance to reverting still? | 12:37 |
| pas-ha | dtantsur: looks ok-ish to solve the immediate problem of blocked gate. if it passes Jenkins I'd vote to merge it (but some tweaks to unit tests might be needed first..) then we might continue with my patches, especially as otherwise I'd need that revert or make a big squashed change... | 12:40 |
| *** mat128 has quit IRC | 12:45 | |
| TheJulia | ugh, no movement on the revert and the fixed another thing instead :( | 12:45 |
| *** rbudden has quit IRC | 12:46 | |
| *** mat128 has joined #openstack-ironic | 12:47 | |
| TheJulia | dtantsur: Looks okay to un-wedge the gate | 12:49 |
| *** hwoarang has quit IRC | 12:56 | |
| *** hwoarang has joined #openstack-ironic | 12:56 | |
| dtantsur | TheJulia: dunno about revert, no progress so far | 12:58 |
| * TheJulia ponders cancelling this week's BFV meeting because of the gate | 12:58 | |
| dtantsur | TheJulia: I may not be able to show up anyway | 12:58 |
| *** sasha2 has joined #openstack-ironic | 12:58 | |
| TheJulia | I mean, cancelling the meeting might raise enough eyebrows and people might go "why is the gate broken".... | 12:59 |
| TheJulia | and maybe then traction, but I don't know | 12:59 |
| TheJulia | dtantsur: I think your hack is going to be the best hope to unwedge us at this point | 13:00 |
| TheJulia | I'm all for following up with pas-ha's revs afterwards once the resulting merge conflict is resolved. | 13:01 |
| *** hwoarang_ has joined #openstack-ironic | 13:02 | |
| dtantsur | yeah, pas-ha's patches are needed for sure | 13:02 |
| dtantsur | they're just big, and I don't want to rush them in just to unblock the CI | 13:02 |
| *** hwoarang has quit IRC | 13:04 | |
| *** ceelogreenthehit has joined #openstack-ironic | 13:05 | |
| TheJulia | Agreed, I'm not super worried about rushing on the first two, but the first two set a stage that we should rapidly review/land all of the related changes, which means we do need a couple days to at least do a quick review of the child patches | 13:06 |
| *** Guest250 is now known as rook | 13:06 | |
| openstackgerrit | Hironori Shiina proposed openstack/ironic master: iRMC: Support volume boot for iRMC virtual media boot interface https://review.openstack.org/467911 | 13:07 |
| *** exoduswtf has quit IRC | 13:08 | |
| TheJulia | Where is Hironori when I need to ask him a question :( | 13:09 |
| *** rloo has joined #openstack-ironic | 13:09 | |
| TheJulia | good morning rloo | 13:09 |
| rloo | Morning TheJulia and everyone else! | 13:09 |
| TheJulia | rloo: dtantsur has proposed a possible quick hack to un-wedge the gate to allow us to fix things properly. It might be good to review. https://review.openstack.org/476498 | 13:10 |
| patchbot | patch 476498 - ironic - [WIP] Quick hack to fetch Glance endpoint from Key... | 13:10 |
| rloo | TheJulia: thx, am still trying to figure out what the state of things are :-) | 13:10 |
| rloo | TheJulia: should probably remove the WIP, but can edit if it is ready to go | 13:11 |
| *** igordcard has quit IRC | 13:11 | |
| TheJulia | no movement on the revert, and another patch landed fixing something else that was broken, so the odds of getting the revert kind of look like they are not in our favor | 13:11 |
| *** igordcard has joined #openstack-ironic | 13:12 | |
| TheJulia | rloo: I was thinking the same, but I also want to see test results before touching that patch :) | 13:12 |
| rloo | TheJulia: i am somewhat surprised that they didn't revert but whatever | 13:12 |
| *** athomas has joined #openstack-ironic | 13:13 | |
| *** goldyfruit has joined #openstack-ironic | 13:13 | |
| *** bfournie has joined #openstack-ironic | 13:15 | |
| *** ceelogreenthehit has quit IRC | 13:16 | |
| *** baoli has joined #openstack-ironic | 13:16 | |
| milan | morning rloo, TheJulia! :) | 13:17 |
| rloo | hi milan! | 13:17 |
| *** exoduswtf has joined #openstack-ironic | 13:24 | |
| *** Goneri has joined #openstack-ironic | 13:32 | |
| dtantsur | rloo: it's WIP because unit tests will need an update | 13:32 |
| dtantsur | I wanna see if it actually fixes the gate. I'm particularly concerned by the grenade.. | 13:33 |
| *** ceelogreenthehit has joined #openstack-ironic | 13:33 | |
| rloo | dtantsur: i was just thinking that it also needs a release note maybe. i don't know if it deprecates or just ignores some glance configs? | 13:33 |
| dtantsur | rloo: neither. it just uses keystone, when no config is provided | 13:34 |
| *** karthiks has quit IRC | 13:34 | |
| rloo | dtantsur, TheJulia: I guess the question is should we focus on the WIP, or pas-ha's patches, or both (which i don't like) | 13:34 |
| rloo | dtantsur: ah, ok, i wasn't sure, i hadn't finished reviewing | 13:34 |
| dtantsur | if we believe we can quickly land pas-ha's both patches - I'm all for it | 13:35 |
| TheJulia | except the first two would need to be squashed together | 13:35 |
| pas-ha | The problem is the first patch needs that devstack revert | 13:35 |
| pas-ha | Yep | 13:35 |
| rloo | dtantsur: we can quickly land anything if we all focus ;) but we can't land pas-ha's first patch cuz of the gate failure. i was thinking maybe we can take bits of his first patch and glom to the second patch though. | 13:36 |
| *** exoduswtf has quit IRC | 13:36 | |
| pas-ha | Which I personally would like to avoid | 13:36 |
| rloo | pas-ha: wdyt it seems like the first patch does more than we need for the second patch, can we just pull the stuff needed to address glance only, then add support for other services later? | 13:36 |
| *** ceelogreenthehit has quit IRC | 13:37 | |
| *** exoduswtf has joined #openstack-ironic | 13:37 | |
| rloo | pas-ha: or do you think we should focus on dtantsur's patch for now, then yours later? | 13:39 |
| *** tuanla__ has joined #openstack-ironic | 13:39 | |
| *** tuanla_fujitsu has joined #openstack-ironic | 13:39 | |
| *** chlong has joined #openstack-ironic | 13:39 | |
| milan | so w/r the gate down, the https://review.openstack.org/#/c/476498/1/ironic/common/glance_service/service_utils.py@122 is the essence, right? | 13:41 |
| patchbot | patch 476498 - ironic - [WIP] Quick hack to fetch Glance endpoint from Key... | 13:41 |
| *** rbudden has joined #openstack-ironic | 13:42 | |
| TheJulia | milan: well, that combined with not taking input from our config file | 13:45 |
| milan | TheJulia, k, thx | 13:45 |
| *** mrchao has quit IRC | 13:48 | |
| pas-ha | rloo: yes, I'd actually prefer that - fix the gate to unblock all other people, "make it right" later | 13:50 |
| *** karthiks has joined #openstack-ironic | 13:50 | |
| rloo | pas-ha: ok | 13:50 |
| pas-ha | as my patches do have some controversial points as I see, so I kind of expecting a not-so-short discussion and do not want to have advantage of pressing gate issues to persuade people :) | 13:51 |
| dtantsur | ++ | 13:51 |
| rloo | pas-ha: wrt your first patch, am i correct that you are only adding configs for [service_catalog] and deprecating [conductor]/api_url? | 13:56 |
| *** mjura has quit IRC | 13:56 | |
| rloo | pas-ha: if so, then some of the code doesn't make sense, like setting default service_type config for some sections | 13:57 |
| *** jcoufal has joined #openstack-ironic | 13:58 | |
| pas-ha | well, I add those options everywhere, just do not add them so config sample. | 13:59 |
| pas-ha | rloo: as I need another patchset anyway to fix reno (and remove Depends-On on devstack revert) I'll try to think of proper way of doing this, but I'd probably need your help as this is kind of chicken-and-egg procedural thing.. | 14:01 |
| rloo | pas-ha: but then it makes no sense to log that we are changing the default value. the user doesn't know about those configs. | 14:01 |
| *** mjura has joined #openstack-ironic | 14:01 | |
| openstackgerrit | Peter Piela proposed openstack/ironic-ui master: Set current boot device on a node https://review.openstack.org/473926 | 14:01 |
| *** crushil has joined #openstack-ironic | 14:02 | |
| pas-ha | rloo: exactly. that's why one of the options is indeed to register those opts in a config section per patch (will be a bit ugly duplication..) and in the last patch move all to a common place and officially deprecate the [keystone]region_name. WDYT? | 14:03 |
| rloo | pas-ha: yeah, i like that option. which i commented on but haven't pushed up cuz i haven't finished reviewing. cuz i got a bit confused. | 14:04 |
| pas-ha | ok, accepted. although being a bit more tedious, this does look procedurally more correct | 14:05 |
| *** skazi_ has joined #openstack-ironic | 14:05 | |
| pas-ha | I'll start reworking the whole patch chain to this regard | 14:05 |
| openstackgerrit | Hironori Shiina proposed openstack/ironic master: Add functional API tests for volume connector and volume target https://review.openstack.org/473717 | 14:09 |
| rloo | pas-ha: thx, i think i got most of my thoughts in the comments i just pushed up. | 14:10 |
| *** athomas has quit IRC | 14:10 | |
| *** livelace has joined #openstack-ironic | 14:11 | |
| * pas-ha reading up | 14:11 | |
| rloo | pas-ha: my thinking was that if you reworked the patch chain, the first patch may actually be quite small and be easier to combine with 2nd patch. | 14:11 |
| pas-ha | nah, still lots of work and we have a dead gate.. I'd go with dtantsur 'hack' first | 14:12 |
| rloo | pas-ha: fine with me :-) | 14:12 |
| *** crushil has quit IRC | 14:14 | |
| *** karthiks has quit IRC | 14:16 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Fetch Glance endpoint from Keystone if it's not provided in the configuration https://review.openstack.org/476498 | 14:21 |
| dtantsur | next attempt, unit tests still to go ^^^ | 14:21 |
| rloo | hi mgoddard, wrt https://review.openstack.org/#/c/470406/, are you going to push up another patch set soon? | 14:27 |
| patchbot | patch 470406 - ironic - Physical network aware VIF attachment | 14:27 |
| NobodyCam | Good Morning Ironic'ers | 14:33 |
| milan | morning NobodyCam! :) | 14:33 |
| NobodyCam | :) morning milan :) | 14:34 |
| dtantsur | morning NobodyCam | 14:39 |
| NobodyCam | Morning dtantsur :) | 14:39 |
| *** dprince has quit IRC | 14:43 | |
| openstackgerrit | Xavier proposed openstack/ironic master: Introduce hpOneView and ilorest to OneView https://review.openstack.org/468129 | 14:44 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Fetch Glance endpoint from Keystone if it's not provided in the configuration https://review.openstack.org/476498 | 14:45 |
| *** links has quit IRC | 14:45 | |
| *** fragatina has joined #openstack-ironic | 14:49 | |
| *** fragatina has quit IRC | 14:50 | |
| *** marios has quit IRC | 14:56 | |
| *** mgoddard has quit IRC | 14:57 | |
| *** aarefiev is now known as aarefiev_afk | 15:02 | |
| *** rama_y has joined #openstack-ironic | 15:04 | |
| *** hwoarang_ is now known as hwoarang | 15:04 | |
| *** racedo has quit IRC | 15:06 | |
| *** racedo has joined #openstack-ironic | 15:06 | |
| *** racedo has quit IRC | 15:06 | |
| *** rcernin has quit IRC | 15:09 | |
| *** yee379 has quit IRC | 15:10 | |
| *** yee379 has joined #openstack-ironic | 15:10 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Fetch Glance endpoint from Keystone if it's not provided in the configuration https://review.openstack.org/476498 | 15:15 |
| dtantsur | rloo, TheJulia, pas-ha, let's see if this passes CI ^^^ | 15:15 |
| openstackgerrit | Merged openstack/ironic-ui master: Refactor BasePortController https://review.openstack.org/474741 | 15:16 |
| * rloo crosses fingers... | 15:16 | |
| *** tuanla__ has quit IRC | 15:16 | |
| *** tuanla_fujitsu has quit IRC | 15:16 | |
| * dtantsur forgot to update the example configuration.. | 15:16 | |
| openstackgerrit | Merged openstack/bifrost master: Add bindep.txt file https://review.openstack.org/475397 | 15:17 |
| openstackgerrit | Merged openstack/ironic-ui master: Imported Translations from Zanata https://review.openstack.org/476463 | 15:18 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Fetch Glance endpoint from Keystone if it's not provided in the configuration https://review.openstack.org/476498 | 15:18 |
| dtantsur | now with ironic.conf.sample ^^^ | 15:18 |
| TheJulia | Awesome | 15:18 |
| anupn | Good morning Ironic'ers | 15:19 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Refactoring the firewall https://review.openstack.org/471831 | 15:19 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: PXE boot filtering drivers https://review.openstack.org/439603 | 15:19 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Introducing a dnsmasq PXE filter driver https://review.openstack.org/466448 | 15:19 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: TEST check dnsmasq PXE filter in devstack https://review.openstack.org/468712 | 15:19 |
| *** mgoddard has joined #openstack-ironic | 15:21 | |
| milan | morning anupn! :) | 15:21 |
| anupn | Hi milan, aarefiev_afk: I tried to delete the existing ironic node when power on, but as it is in 'inspecting' state it is unable to delete. And without putting in inspect state if I power on and delete it the node does not get enrolled | 15:21 |
| anupn | Good morning milan | 15:21 |
| anupn | milan, i created a rule like this http://paste.openstack.org/show/613407/ | 15:22 |
| milan | anupn, how can it be in any state if you delete it from ironic? maybe I don't follow | 15:22 |
| mgoddard | rloo: hi. I don't have a new iteration yet. I was planning on working on it tomorrow but also have a couple of unanswered questions from my most recent comments | 15:22 |
| mgoddard | rloo: sambetts commented that the common network mixin no longer needs to support non-neutron interfaces. do you know whether that is the case? | 15:23 |
| anupn | milan, i mean it should get enrolled with auto_discovery after deleting right? | 15:23 |
| openstackgerrit | Merged openstack/bifrost master: scripts: install-deps.sh: Use --no-recommends on zypper https://review.openstack.org/475398 | 15:23 |
| rloo | mgoddard: no, i don't know off the top of my head. i was asking cuz you had put 'done' on some of the comments, so i didn't want to review an outdated patch set. i'll continue reviewing that later today then. | 15:23 |
| NobodyCam | morning anupn :) | 15:23 |
| milan | anupn, correct, but that shouldn't require any state setting beforehand | 15:24 |
| anupn | milan: i think that's what we talked yesterday would be good to carry out | 15:24 |
| milan | anupn, yup | 15:24 |
| openstackgerrit | Merged openstack/bifrost master: bindep.txt: Install the epel-release repo on CentOS https://review.openstack.org/475446 | 15:24 |
| anupn | milan: yes, so i tried two cases 1. put node into inspect, wait for it to power on and then delete as did it in test case https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/test/inspector_tempest_plugin/tests/test_discovery.py#L134. 2. delete the node and check if inspector enrolls it | 15:25 |
| *** fellypefca has quit IRC | 15:26 | |
| anupn | milan: in the second case i had powered on because i thought otherwise how will introspection ramdisk be booted | 15:26 |
| jlvillal | dtantsur, Do you know if they are going to revert the devstack patch which broke our gate? | 15:26 |
| anupn | NobodyCam: good morning :) | 15:26 |
| dtantsur | jlvillal: morning, no idea so far | 15:27 |
| jlvillal | dtantsur, Maybe you can use your special PTL powers to motivate them ;) | 15:27 |
| dtantsur | jlvillal: I'm hoping to Just Fix It, and stop caring, to be honest | 15:27 |
| dtantsur | there was some resistance already | 15:27 |
| milan | anupn, hmmmm, so if you do ironic node_delete <node> the state is still inspecting afterwards? | 15:28 |
| jlvillal | dtantsur, Oh good if we can. Yesterday it appeared to need two patches to fix and the first patch won't merge since it doesn't fix it | 15:28 |
| dtantsur | jlvillal: I'm waiting for CI results on https://review.openstack.org/476498 | 15:28 |
| patchbot | patch 476498 - ironic - Fetch Glance endpoint from Keystone if it's not pr... | 15:28 |
| anupn | milan: no | 15:28 |
| dtantsur | it may be a cheap-and-easy way to proceed with pas-ha's patches | 15:28 |
| NobodyCam | :) | 15:28 |
| jlvillal | dtantsur, Great. Thanks. | 15:28 |
| openstackgerrit | Michael Turek proposed openstack/ironic master: [WIP] Make storage calls agnostic to deploy method. https://review.openstack.org/476601 | 15:28 |
| anupn | milan: but when i did that, i kind of wondered if I delete how will the introspect ramdisk be booted | 15:28 |
| milan | anupn, through devstack@ironic-inspector-dhcp service | 15:29 |
| anupn | milan: hmm, i saw there is dhcp-boot option in ironic-inspector-dhcp.conf, but so every node that is created will call this? | 15:30 |
| milan | anupn, inspector protects the dhcp service through iptables so only a) nodes that were explicitly asked to inspect and b) unknown nodes performing the discovery will be able to pxe boot the introspection ramdisk | 15:31 |
| TheJulia | mjturek: awesome, I left a comment/question for consideration | 15:32 |
| mjturek | record time TheJulia :) | 15:32 |
| mjturek | looking | 15:32 |
| TheJulia | It is review code, or I go curl up in a dark room until my doctor's appointment later today | 15:32 |
| *** ccamacho has quit IRC | 15:33 | |
| dtantsur | :( | 15:36 |
| anupn | milan: hmm got you. But i need to power the VMs on before they pxe boot is that correct? | 15:37 |
| dtantsur | folks, due to errands I have to leave the air-conditioned office and jump on the frying pan which is called "outside world" today :) | 15:37 |
| TheJulia | dtantsur: no worries. Stay cool! | 15:38 |
| dtantsur | can someone (rloo, pas-ha?) please take care of my gate-fixing patch? it should work, may need slight tweaks depending on CI results. | 15:38 |
| TheJulia | dtantsur: I can later as well | 15:38 |
| dtantsur | thanks! | 15:38 |
| TheJulia | We should check all of the third party ci jobs too | 15:38 |
| milan | anupn, yeah, power on the node through ironic and delete it immediately. Also the test case sets the state to manage before | 15:38 |
| TheJulia | like, their logs, just to be on the safe side | 15:39 |
| rloo | dtantsur: yes, i can too if TheJulia or pas-ha doesn't :-) | 15:39 |
| dtantsur | cool | 15:39 |
| rloo | dtantsur: it "should" work ;) | 15:39 |
| dtantsur | have a nice evening (I nearly wrote 'weekend', sigh) | 15:39 |
| milan | dtantsur, lol | 15:39 |
| milan | :D | 15:39 |
| rloo | dtantsur: thx, it is/will be weekend for me :-) | 15:39 |
| milan | dtantsur +1, TGIF | 15:39 |
| openstackgerrit | Merged openstack/bifrost master: scripts: test-bifrost: Start MySQL service before configuring the DB https://review.openstack.org/475306 | 15:40 |
| *** dtantsur is now known as dtantsur|afk | 15:40 | |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: Test OPNFV CI verify job. Please ignore. https://review.openstack.org/367608 | 15:40 |
| *** mtanino_ has joined #openstack-ironic | 15:40 | |
| rloo | ideally, pas-ha fix it, so TheJulia and I can +2 it, but we have other ways... ;) | 15:40 |
| anupn | milan: hmm i did exactly like that but node seem to not been enrolled. :( | 15:41 |
| anupn | milan: yeah test case puts the node into manage->inspect and then delete | 15:41 |
| anupn | milan: but I don't know how the node gets deleted when put in inspect | 15:42 |
| *** pcaruana has quit IRC | 15:42 | |
| anupn | milan: i did not try creating with virsh because I am not sure whether that node will boot introspect ramdisk | 15:42 |
| anupn | *that VM | 15:43 |
| TheJulia | rloo: :) | 15:43 |
| milan | anupn, I see, so maybe step by step, does the devstack@ironic-inspector-dhcp have any PXE boot entries for your node? | 15:44 |
| anupn | milan, you mean in inspector-dhcp.conf? | 15:45 |
| milan | anupn, rather journactl -u devstack@ironic-inspector-dhcp | 15:46 |
| milan | anupn, but you're right; the test case does indeed call openstack baremetal introspection start <node-id> and then delete | 15:47 |
| milan | * ironic node_delete (or so) | 15:48 |
| anupn | milan, hmm, i did not check devstack@ironic-inspector-dhcp for PXE boot entries | 15:49 |
| milan | anupn, I'm wonder how far did the inspection get | 15:49 |
| *** stendulker has joined #openstack-ironic | 15:49 | |
| anupn | milan: good point, I did not checked inspector-dhcp.service because my normal introspection worked | 15:50 |
| anupn | by normal i mean just put the node into manage and then inspect | 15:50 |
| anupn | not discovery | 15:51 |
| anupn | milan, where should PXE boot entries for node be added? | 15:51 |
| milan | anupn, so the process is the same, just the inspector, upon receiving the call back from the ramdisk checks whether a matching node exists in ironic | 15:51 |
| milan | anupn, that should work out of the box | 15:52 |
| milan | * should | 15:52 |
| milan | anupn, as you said it worked in the "normal" case | 15:52 |
| anupn | milan, yup | 15:52 |
| anupn | i am wondering about the point you pointed to check if PXE boot entries are added | 15:52 |
| milan | anupn, so as I said, the process is the same, just the node doesn't exist (anymore) upon the call back from the ramdisk | 15:53 |
| milan | anupn, I meant whether the dhcp service gave out a lease to the node | 15:53 |
| *** stendulker has quit IRC | 15:54 | |
| *** jaganathan has quit IRC | 15:54 | |
| *** dprince has joined #openstack-ironic | 15:54 | |
| anupn | milan: ok. After deleting the node, i did not see DHCP service gave out the lease even though i deleted after powering it on | 15:55 |
| *** hshiina has joined #openstack-ironic | 15:55 | |
| openstackgerrit | Michael Turek proposed openstack/ironic master: Fail if boot_from_volume enabled but not ipxe https://review.openstack.org/472856 | 15:55 |
| milan | anupn, OK so let's try again with the other node? (I guess our local.conf arranges for 2 "BM" nodes) | 15:56 |
| anupn | anupn: i have it 3 in my local.conf that's good :) | 15:57 |
| milan | anupn, ideally check the inspector service logs, once you spot state change for the node starting -> waiting you can delete the node through ironic | 15:57 |
| milan | anupn, but this all is workarounds to make the VMs work | 15:58 |
| milan | anupn, with real nodes it will be different (as in dtantsur|afk 's video) | 15:58 |
| anupn | milan: yes in video is very clear , great one | 15:59 |
| *** stendulker has joined #openstack-ironic | 15:59 | |
| anupn | milan: starting -> waiting? | 15:59 |
| anupn | did you mean power state change? | 15:59 |
| milan | in journalctl -fu devstack@ironic-inspector | 15:59 |
| *** mtanin___ has joined #openstack-ironic | 16:00 | |
| anupn | yes will watch the devstack@ironic-inspector logs | 16:00 |
| anupn | milan: so shall i again do like 1. Put node in manage state, 2. put in inspect state 3. wait to power it on 4. delete ? | 16:01 |
| *** mtanino_ has quit IRC | 16:01 | |
| milan | anupn, yeah, preferably you use inspector cli for the step 2. to be as close to the test case as possible | 16:02 |
| milan | * openstack baremetal introspection start <node_id> | 16:02 |
| anupn | milan, ok, but i am pretty sure it will complain because you cannot delete node in inspect https://github.com/openstack/ironic/blob/cb7ec631f0fc6937eb05ab304f6444d6aad81102/ironic/common/states.py#L192 | 16:03 |
| anupn | "inspect" state is not present in DELETE_ALLOWED_STATES at line ^ | 16:04 |
| milan | anupn, so the test case does it somehow, let's give it a try through the inspector cli? | 16:04 |
| milan | anupn, as you mentioned you've still got 2 nodes to delete ;) | 16:04 |
| anupn | milan, haha yeah i have | 16:05 |
| anupn | milan, unfortunately i realized i cannot connect to lab via VPN so experiment has to wait until i go to office today | 16:05 |
| anupn | :( | 16:06 |
| milan | anupn, I see | 16:06 |
| anupn | milan: how long are you around? | 16:06 |
| milan | not much longer honestly (EU based) | 16:07 |
| milan | 30min top ;) | 16:07 |
| anupn | milan, oh yes. Will experiment it and will see | 16:07 |
| hwoarang | TheJulia: do you have a sec? | 16:07 |
| anupn | milan: thanks a ton! | 16:07 |
| milan | anupn, no prob! :) | 16:08 |
| anupn | milan, have a good evening | 16:08 |
| milan | anupn, thanks! fingers crossed for the experiment! :) | 16:08 |
| TheJulia | hwoarang: presently running the boot from volume meeting, whats up? | 16:09 |
| anupn | milan: yup i wish inspector CLI makes a magic | 16:09 |
| milan | honestly, same here :D | 16:09 |
| jlvillal | dtantsur|afk: You may have already noticed but the patch doesn't fix the gate issue: https://review.openstack.org/476498 | 16:09 |
| patchbot | patch 476498 - ironic - Fetch Glance endpoint from Keystone if it's not pr... | 16:09 |
| jlvillal | I'm looking at Zuul status page | 16:10 |
| hwoarang | TheJulia: ok I will just leave it here as I had to run in a bit: could you by any chance look at why this http://logs.openstack.org/08/367608/10/experimental/gate-bifrost-integration-tinyipa-centos-7/514c860/console.html fails even though bifrost now has a bindep.txt file in the root of the repo? seems like the [ -e bindep.txt ] in the job doesn't work. This is one of the experimental jobs from https://review.openstack.org/#/c/367608 | 16:10 |
| hwoarang | / which is fully rebased. TIA! | 16:10 |
| patchbot | patch 367608 - bifrost - Test OPNFV CI verify job. Please ignore. | 16:10 |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic-ui master: Set current boot device on a node https://review.openstack.org/473926 | 16:10 |
| hwoarang | or I can ask yolanda to help me have a look at the node itself... | 16:10 |
| jlvillal | rloo: FYI: The gate fixing patch doesn't seem to work. I haven't investigated it, but see a lot of failures in Zuul | 16:11 |
| rloo | jlvillal: oh geez, and dt said it was supposed to work. | 16:12 |
| jlvillal | rloo: One of the failures: http://logs.openstack.org/98/476498/5/check/gate-tempest-dsvm-ironic-ipa-partition-redfish-tinyipa-ubuntu-xenial/43be6e7/ | 16:12 |
| rloo | jlvillal: i'm in the middle of something and don't have a clean env where i can test that patch. | 16:12 |
| jlvillal | http://status.openstack.org/zuul/ is where I looked | 16:12 |
| jlvillal | rloo: I'll take a peek. Maybe pas-ha has ideas? | 16:13 |
| milan | jlvillal, rloo http://logs.openstack.org/98/476498/5/check/gate-tempest-dsvm-ironic-inspector-ubuntu-xenial-nv/e7a6cce/logs/screen-ir-cond.txt.gz?level=ERROR#_Jun_22_15_40_25_256152 < 'image' service not in catalog | 16:13 |
| rloo | jlvillal: i'm guessing pas-ha has the most experience with this. certainly more than me! | 16:13 |
| rloo | thx milan. I *thought* that was what monty's patch was fixing but i could be wrong... | 16:14 |
| jlvillal | milan: thanks | 16:14 |
| milan | no prob, just dunno how to fix it | 16:14 |
| rloo | and do we want internal or public endpoint for the services? | 16:14 |
| * milan can update the patch w/ some guidance so you guys can review | 16:15 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic master: Fixes hashing issues for py3.5 https://review.openstack.org/473888 | 16:15 |
| *** amotoki is now known as amotoki_away | 16:15 | |
| *** e0ne has quit IRC | 16:15 | |
| rloo | jlvillal: do you have it? i'm really in the middle of something, maybe take me 10-15 min to get my head out of that... | 16:15 |
| jlvillal | rloo: No worries. I'll look. Maybe milan and I can figure it out :) | 16:16 |
| rloo | ok thx. pas-ha, if you are around, i think you can figure this out quickly: ^^ http://logs.openstack.org/98/476498/5/check/gate-tempest-dsvm-ironic-inspector-ubuntu-xenial-nv/e7a6cce/logs/screen-ir-cond.txt.gz?level=ERROR#_Jun_22_15_40_25_256152 | 16:17 |
| openstackgerrit | Merged openstack/proliantutils master: Change Logs for proliantutils 2.3.0 release https://review.openstack.org/476066 | 16:19 |
| *** fellypefca has joined #openstack-ironic | 16:22 | |
| * jlvillal grumbles that they changed the logfile format since the last time he ran his logfile parsing script | 16:22 | |
| hwoarang | TheJulia: nm i sent a new patch for project-config | 16:25 |
| *** makowals has quit IRC | 16:27 | |
| TheJulia | hwoarang: that -e on binder.txt is before zuul-cloner runs so it is not on disk yet | 16:28 |
| TheJulia | bindep.txt | 16:28 |
| rloo | TheJulia: do you know if infra is too busy to revert, or that they have an issue with the revert patch? | 16:28 |
| *** ralonsoh has quit IRC | 16:29 | |
| *** jrcloud has joined #openstack-ironic | 16:29 | |
| TheJulia | I suspect both, but I've not asked. | 16:29 |
| jlvillal | milan: I think it is this: https://review.openstack.org/#/c/476498/5/ironic/common/glance_service/service_utils.py@112 | 16:30 |
| patchbot | patch 476498 - ironic - Fetch Glance endpoint from Keystone if it's not pr... | 16:30 |
| jlvillal | But I'm not sure what the 'service_type' should be | 16:30 |
| milan | jlvillal, seems image is wrong service name | 16:30 |
| jlvillal | milan: Right, not sure what the correct name is :( | 16:31 |
| milan | jlvillal, ++ that's my take on it too | 16:31 |
| *** dprince has quit IRC | 16:31 | |
| jlvillal | milan: I'll peek at pas-ha's patches | 16:31 |
| milan | jlvillal, to make it even worse: http://logs.openstack.org/51/459451/18/gate/gate-tempest-dsvm-py35-ubuntu-xenial/e629b22/logs/screen-keystone.txt.gz#_Jun_21_07_15_59_660167 | 16:31 |
| milan | that's the original devstack patch lgos from keystone complaining no image service | 16:31 |
| milan | or maybe I don't follow | 16:32 |
| milan | but then http://logs.openstack.org/51/459451/18/gate/gate-tempest-dsvm-py35-ubuntu-xenial/e629b22/logs/screen-keystone.txt.gz#_Jun_21_07_16_02_189748 | 16:33 |
| TheJulia | interesting | 16:34 |
| milan | so stupid question: how does keystone work? | 16:37 |
| milan | each service registers itself, then it's available in the keystone registry? | 16:37 |
| TheJulia | http://logs.openstack.org/98/476498/5/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial/acf00e8/logs/devstacklog.txt.gz#_2017-06-22_15_28_51_139 | 16:38 |
| TheJulia | basically, only a public endpoint is getting registered | 16:38 |
| TheJulia | if the paste that milan found where it was complaining about not finding the internal endpoint is correct, then it is | 16:38 |
| milan | TheJulia, the paste is from the devstack patch; I wanted to track what the image type service is/ whether it exists at all | 16:39 |
| TheJulia | oh | 16:40 |
| TheJulia | hmm | 16:40 |
| * jlvillal hasn't figured out much yet :( | 16:41 | |
| jlvillal | TheJulia: That looks interesting about the registering | 16:41 |
| TheJulia | http://logs.openstack.org/98/476498/5/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial/acf00e8/logs/screen-ir-cond.txt.gz#_Jun_22_15_38_29_381006 | 16:41 |
| TheJulia | we explicitly need to look for the public endpoint type, or there need to be a private endpoint | 16:42 |
| rloo | i think that the service-type is 'image', but that we need to explicitly say the endpoint-type='public' | 16:42 |
| rloo | cuz i don't know if there is an internal endpoint for glance. but just guessing here. | 16:43 |
| TheJulia | From the devstack log, there is not | 16:43 |
| *** jrcloud has quit IRC | 16:44 | |
| *** jrcloud has joined #openstack-ironic | 16:44 | |
| rloo | TheJulia, jlvillal, milan: so if we change https://review.openstack.org/#/c/476498/5/ironic/common/glance_service/service_utils.py@112 | 16:44 |
| patchbot | patch 476498 - ironic - Fetch Glance endpoint from Keystone if it's not pr... | 16:44 |
| rloo | add endpoint_type='public' | 16:44 |
| TheJulia | https://github.com/openstack/ironic/blob/master/ironic/common/keystone.py#L69 | 16:45 |
| *** fellypefca has quit IRC | 16:45 | |
| TheJulia | what rloo is saying | 16:45 |
| milan | rloo, TheJulia jlvillal ack, makes sense | 16:46 |
| rloo | milan: you want to make the change? | 16:46 |
| rloo | (i'm saving cores to +2, heh) | 16:46 |
| milan | rloo, yeah I can update the patch :D | 16:46 |
| milan | btw | 16:46 |
| TheJulia | since we default to internal endpoints... which makes sense for ironic :\ | 16:46 |
| TheJulia | milan: thank you | 16:46 |
| milan | http://logs.openstack.org/98/476498/5/check/gate-tempest-dsvm-ironic-inspector-ubuntu-xenial-nv/e7a6cce/logs/screen-keystone.txt.gz#_Jun_22_15_40_25_215043 | 16:46 |
| milan | cross-checking the hotfix logs from keystone | 16:46 |
| milan | I can't see the error from ir-conductor | 16:47 |
| milan | that happened at Jun_22_15_40_25 | 16:47 |
| TheJulia | milan: looks like it is checking it's self | 16:47 |
| TheJulia | I _think_ keystone does that by default | 16:47 |
| milan | TheJulia, you mean the library part in the ironic conductor? | 16:48 |
| * milan briefly scans through /opt/stack/new/ironic/ironic/common/keystone.py to avoid facepalms | 16:49 | |
| TheJulia | get_session perhaps? | 16:49 |
| *** lucasagomes is now known as lucas-afk | 16:49 | |
| *** jrcloud has quit IRC | 16:50 | |
| TheJulia | milan: I was thinking keystone startup for | 16:51 |
| TheJulia | that first one, cross-checking conductor log | 16:51 |
| * milan might not exactly be following what TheJulia means O:-) | 16:52 | |
| rloo | milan: just make that change while you continue to look... | 16:53 |
| milan | rloo :D yup | 16:53 |
| * milan hacks | 16:53 | |
| TheJulia | http://logs.openstack.org/98/476498/5/check/gate-tempest-dsvm-ironic-inspector-ubuntu-xenial-nv/e7a6cce/logs/screen-ir-cond.txt.gz#_Jun_22_15_40_25_249840 <-- only public endpoint for service_type of image | 16:54 |
| *** ceelogreenthehit has joined #openstack-ironic | 16:55 | |
| *** rbudden has quit IRC | 16:57 | |
| *** jrcloud has joined #openstack-ironic | 16:58 | |
| *** exoduswtf has quit IRC | 16:59 | |
| *** ceelogreenthehit has quit IRC | 16:59 | |
| TheJulia | so, if memory serves, plugin loading in keystoneauth can get a validity check to keystone, I'm wondering if that is what your seeing as the stray call to keystone | 16:59 |
| jlvillal | I wonder why 'network' service works | 16:59 |
| rloo | jlvillal: i'm guessing cuz we aren't using the same way of authenticating as we are for glance. that's what pas-ha's patches are about; unifying/consistent way. | 17:01 |
| *** fellypefca has joined #openstack-ironic | 17:01 | |
| TheJulia | that is a really good question... | 17:01 |
| TheJulia | I need to step away to go to the doctor, bbl | 17:01 |
| jlvillal | https://github.com/openstack/ironic/blob/master/ironic/common/neutron.py#L33 | 17:01 |
| *** jrcloud has quit IRC | 17:03 | |
| TheJulia | yeah, and dimity's patch is using the service catalog and looking it up | 17:03 |
| * TheJulia kicks autocorrect | 17:04 | |
| TheJulia | dmitry | 17:04 |
| *** mjura has quit IRC | 17:04 | |
| *** hshiina has quit IRC | 17:04 | |
| *** derekh has quit IRC | 17:05 | |
| *** jrcloud has joined #openstack-ironic | 17:05 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic-inspector master: add disabled option to VALID_ADD_PORTS_VALUES https://review.openstack.org/471156 | 17:05 |
| *** trown is now known as trown|lunch | 17:06 | |
| rloo | jlvillal: and pas-ha's change makes it similar for glance: https://review.openstack.org/#/c/467728/14/ironic/common/glance_service/base_image_service.py | 17:06 |
| patchbot | patch 467728 - ironic - Rework keystone auth for glance | 17:06 |
| rloo | jlvillal: something to look forward to... | 17:06 |
| rloo | milan: how is it going? i can just edit that file if you want... | 17:07 |
| milan | rloo, just about to post | 17:07 |
| rloo | milan: :) | 17:08 |
| jlvillal | milan: You have a fix? | 17:08 |
| *** spartacloud has joined #openstack-ironic | 17:08 | |
| jlvillal | rloo: Could point on pas-ha change | 17:09 |
| jlvillal | s/Could/Good/ | 17:09 |
| rloo | jlvillal: :) | 17:09 |
| milan | jlvillal, just what rloo suggested | 17:09 |
| jlvillal | milan: Awesome :) | 17:09 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic master: Fetch Glance endpoint from Keystone if it's not provided in the configuration https://review.openstack.org/476498 | 17:09 |
| rloo | meanwhile the revert patch has one +2! | 17:10 |
| milan | I hope I didn't screw up | 17:10 |
| milan | nice | 17:10 |
| milan | so maybe this won't be necessary | 17:10 |
| *** jrcloud has quit IRC | 17:10 | |
| jlvillal | rloo: Woot on one +1 :) | 17:11 |
| rloo | milan: it might not be, but just in case... i mean, it hasn't been approved yet | 17:11 |
| milan | ack | 17:11 |
| jlvillal | s/+1/+2/ | 17:12 |
| milan | rloo I'll be commuting in 5min so I can re-update later | 17:12 |
| rloo | milan: no worries, we can get someone else to update too. thx! | 17:12 |
| milan | cool :) | 17:12 |
| *** spartacloud has quit IRC | 17:12 | |
| milan | CU guys! | 17:12 |
| * milan be gone | 17:13 | |
| *** rbudden has joined #openstack-ironic | 17:13 | |
| *** milan has quit IRC | 17:13 | |
| NobodyCam | night milan | 17:13 |
| jlvillal | Woot! Revert patch has been approved :) | 17:17 |
| jlvillal | rloo: TheJulia dtantsur|afk ^^^ | 17:17 |
| rloo | yay! jlvillal, you beat me to it! Now i can go have lunch ;) | 17:17 |
| *** stendulker has quit IRC | 17:18 | |
| jlvillal | :) | 17:18 |
| *** jrcloud has joined #openstack-ironic | 17:24 | |
| *** jaganathan has joined #openstack-ironic | 17:25 | |
| openstackgerrit | huayue proposed openstack/pyghmi master: Pyghmi does not follow the pep8 standard https://review.openstack.org/476444 | 17:27 |
| *** jrcloud has quit IRC | 17:28 | |
| *** livelace has quit IRC | 17:37 | |
| *** ijw has joined #openstack-ironic | 17:37 | |
| *** ijw has quit IRC | 17:44 | |
| *** ijw has joined #openstack-ironic | 17:45 | |
| *** ijw has quit IRC | 17:46 | |
| *** jaganathan has quit IRC | 17:49 | |
| *** ijw has joined #openstack-ironic | 17:55 | |
| *** amarao has quit IRC | 17:56 | |
| *** rbudden has quit IRC | 17:57 | |
| *** ijw has quit IRC | 17:58 | |
| openstackgerrit | huayue proposed openstack/pyghmi master: Pyghmi does not follow the pep8 standard https://review.openstack.org/476444 | 17:58 |
| *** dprince has joined #openstack-ironic | 17:59 | |
| *** tesseract has quit IRC | 17:59 | |
| *** ijw has joined #openstack-ironic | 18:00 | |
| *** baoli has quit IRC | 18:03 | |
| *** baoli has joined #openstack-ironic | 18:04 | |
| *** rbudden has joined #openstack-ironic | 18:04 | |
| *** priteau has quit IRC | 18:04 | |
| *** ijw has quit IRC | 18:05 | |
| *** ijw has joined #openstack-ironic | 18:07 | |
| *** jrcloud has joined #openstack-ironic | 18:13 | |
| openstackgerrit | huayue proposed openstack/pyghmi master: Pyghmi does not follow the pep8 standard https://review.openstack.org/476444 | 18:14 |
| *** jrcloud has quit IRC | 18:18 | |
| *** ijw has quit IRC | 18:21 | |
| *** jrcloud has joined #openstack-ironic | 18:23 | |
| *** makowals has joined #openstack-ironic | 18:23 | |
| *** ijw has joined #openstack-ironic | 18:28 | |
| *** jrcloud has quit IRC | 18:28 | |
| *** aimeeu has joined #openstack-ironic | 18:29 | |
| *** paramite has quit IRC | 18:31 | |
| *** ijw has quit IRC | 18:32 | |
| *** jrcloud has joined #openstack-ironic | 18:32 | |
| *** ChubYann has joined #openstack-ironic | 18:35 | |
| *** jrcloud has quit IRC | 18:36 | |
| *** trown|lunch is now known as trown | 18:45 | |
| *** fellypefca has quit IRC | 18:48 | |
| *** skazi_ has quit IRC | 18:58 | |
| *** e0ne has joined #openstack-ironic | 19:06 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Logic for skipping deployment with BFV https://review.openstack.org/454243 | 19:11 |
| TheJulia | rloo: jlvillal: devstack revert merged, I guess we just get to wait and see now. | 19:13 |
| TheJulia | three jobs are running at present, two of them were passing previously as far as I'm aware :) | 19:14 |
| rloo | TheJulia: yeah. I'd rather we focus on pas-ha's patches now. having said that, dtantsur|afk's patch passed the questionable-tests. | 19:14 |
| rloo | TheJulia: but unless we want to get something in quickly, i'd rather we save some minutes and not spend time on the quick fix. | 19:15 |
| TheJulia | I agree focus wise, but we have a number of things sitting out there that will receive 0 reviews with verfied-1 when they are perfectly fine, so we need to do the needful for some of the things so we can resume all the other work and not block progress. I last saw dtantsur|afk's patch with verified-1 on it, at least I think thats what it was. The list was rather long of failed patches. | 19:17 |
| TheJulia | I totally agree on merging the right fix as well, not the quick fix | 19:18 |
| rloo | TheJulia: I don't understand your big comment about things sitting out there... | 19:18 |
| rloo | TheJulia: do you mean do a 'recheck' on patches that had failed recently? | 19:19 |
| TheJulia | yes, I initiated a recheck and a rebase | 19:19 |
| TheJulia | which should *crossing fingers* pass CI | 19:20 |
| rloo | yeah, all the patches that failed in the past day due to the glance/devstack issue should just need rechecks to advance to the next issues... | 19:20 |
| TheJulia | heh, unit test failure on dtantsur|afk's patch | 19:21 |
| rloo | TheJulia: am just waiting for confirmation of a rechecked patch that passes... | 19:21 |
| TheJulia | rloo: hence why I ran a recheck and a rebase (since the revision needed it anyway) :) | 19:21 |
| rloo | TheJulia: :) | 19:22 |
| TheJulia | now we get to wait :) | 19:23 |
| *** e0ne has quit IRC | 19:25 | |
| *** dprince has quit IRC | 19:25 | |
| *** dprince has joined #openstack-ironic | 19:26 | |
| *** trown is now known as trown|brb | 19:28 | |
| *** trown|brb is now known as trown | 19:35 | |
| *** makowals has quit IRC | 19:35 | |
| *** krtaylor has quit IRC | 19:52 | |
| *** jcoufal has quit IRC | 19:53 | |
| *** mgoddard has quit IRC | 19:56 | |
| *** baoli has quit IRC | 19:58 | |
| *** baoli has joined #openstack-ironic | 19:58 | |
| *** baoli has quit IRC | 19:58 | |
| *** baoli has joined #openstack-ironic | 20:00 | |
| jlvillal | rloo: TheJulia: What is status on pas-ha patches? | 20:00 |
| jlvillal | I just did a recheck on: https://review.openstack.org/#/c/469627/ | 20:01 |
| patchbot | patch 469627 - ironic - Introduce keystoneauth adapters for clients | 20:01 |
| *** goldyfruit has quit IRC | 20:01 | |
| rloo | jlvillal: pas-ha is going to rework the first patch; move some of that stuff to patches later in the chain | 20:01 |
| jlvillal | Oh, that needs the release notes fixed. /me goes and looks | 20:01 |
| jlvillal | rloo: Oh so we can't get it in today? | 20:02 |
| rloo | jlvillal: no | 20:02 |
| TheJulia | jlvillal: nope | 20:02 |
| jlvillal | rloo: TheJulia: Okay thanks! | 20:02 |
| rloo | jlvillal: is there a time frame in which the revert is reverted? | 20:02 |
| jlvillal | rloo: I don't know. Probably a question for mtreinish | 20:02 |
| rloo | jlvillal: i think the only thing of contention (sp?) so far in pas-ha's patch, is whether to deprecate [conductor]/api_url config or not. | 20:03 |
| rloo | jlvillal: although i only reviewed pas-ha's first patch, i think after his second patch, the rest are a lot easier. the second patch are changes to glance. | 20:03 |
| rloo | jlvillal: maybe i mean 'straightforward' patches :) I hope anyway. | 20:04 |
| jlvillal | rloo: Thanks | 20:04 |
| rloo | jlvillal: i won't be here tomorrow but hoping the rest of you can help move those patches along; i think i was pretty thorough in reviewing his first patch (except for tests) | 20:05 |
| *** ram5391 has joined #openstack-ironic | 20:05 | |
| rloo | jlvillal: the interesting thing about pas-ha's first patch is that it passed those tests that had been failing, even though the revert hadn't happened yet. | 20:06 |
| *** dprince has quit IRC | 20:07 | |
| jlvillal | rloo: Yeah, I noticed that! | 20:07 |
| *** jrist has quit IRC | 20:09 | |
| *** ram5391 has quit IRC | 20:12 | |
| * TheJulia raises an eyebrow | 20:13 | |
| TheJulia | I thought it had failed, but I don't remember if I dug into the logs on that one | 20:13 |
| *** dkehn has quit IRC | 20:14 | |
| TheJulia | Looks like we are down to the grenade jobs | 20:14 |
| *** jrist has joined #openstack-ironic | 20:17 | |
| *** jkilpatr has quit IRC | 20:20 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic master: Fetch Glance endpoint from Keystone if it's not provided in the configuration https://review.openstack.org/476498 | 20:31 |
| *** paramite has joined #openstack-ironic | 20:33 | |
| *** jrcloud has joined #openstack-ironic | 20:34 | |
| *** krtaylor has joined #openstack-ironic | 20:37 | |
| *** jrcloud has quit IRC | 20:38 | |
| *** jkilpatr has joined #openstack-ironic | 20:40 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic master: Fetch Glance endpoint from Keystone if it's not provided in the configuration https://review.openstack.org/476498 | 20:40 |
| *** mat128 has quit IRC | 20:42 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Add CRUD notification objects for volume connector and volume target https://review.openstack.org/463930 | 20:47 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Add REST API for volume connector and volume target operation https://review.openstack.org/214586 | 20:48 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Add functional API tests for volume connector and volume target https://review.openstack.org/473717 | 20:49 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Enable cinder storage interface for generic hardware https://review.openstack.org/463908 | 20:49 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Add storage interface field to node-related notifications https://review.openstack.org/463972 | 20:49 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: DevStack: Add configuration for boot-from-volume https://review.openstack.org/466333 | 20:49 |
| *** jrcloud has joined #openstack-ironic | 20:50 | |
| *** baoli has quit IRC | 20:50 | |
| *** baoli has joined #openstack-ironic | 20:51 | |
| TheJulia | I do believe our CI is looking to be good, hence pushing some rebase buttons | 20:52 |
| rloo | TheJulia: yup, eg: https://review.openstack.org/#/c/454243/17 | 20:53 |
| patchbot | patch 454243 - ironic - Logic for skipping deployment with BFV | 20:53 |
| rloo | TheJulia: I will update our etherpad. again :-) | 20:53 |
| *** jrcloud has quit IRC | 20:55 | |
| *** jrcloud has joined #openstack-ironic | 20:55 | |
| TheJulia | awesome | 20:57 |
| *** dmellado has quit IRC | 21:00 | |
| *** jrcloud has quit IRC | 21:00 | |
| *** dmellado has joined #openstack-ironic | 21:03 | |
| TheJulia | I'm stepping away for dinner | 21:03 |
| paramite | hey guys, what should I do with nodes ended up in provisioning state "error"? I'd like to have them in "available" again | 21:07 |
| rajinir | Any help, our CI is failing with error. /opt/stack/new/ironic/devstack/lib/ironic:1545 Timed out waiting for Nova hypervisor-stats vcpus >= 4, mjturek,krtaylor | 21:16 |
| anupn | paramite: you can only do is rebuild it. Here is state machine https://docs.openstack.org/developer/ironic/_images/states.svg | 21:18 |
| paramite | anupn, thanks | 21:18 |
| *** fragatina has joined #openstack-ironic | 21:20 | |
| *** trown is now known as trown|outtypewww | 21:21 | |
| *** baoli has quit IRC | 21:28 | |
| *** [1]rpioso has joined #openstack-ironic | 21:29 | |
| *** cdearborn has joined #openstack-ironic | 21:29 | |
| *** fragatina has quit IRC | 21:47 | |
| *** fragatina has joined #openstack-ironic | 21:52 | |
| *** rbudden has quit IRC | 21:52 | |
| *** chlong has quit IRC | 21:57 | |
| *** jrcloud has joined #openstack-ironic | 22:05 | |
| *** baoli has joined #openstack-ironic | 22:06 | |
| *** cdearborn has quit IRC | 22:08 | |
| *** jrcloud has quit IRC | 22:10 | |
| *** baoli has quit IRC | 22:10 | |
| *** MattMan_1 has quit IRC | 22:15 | |
| *** MattMan_1 has joined #openstack-ironic | 22:15 | |
| *** fragatina has quit IRC | 22:19 | |
| *** jcoufal has joined #openstack-ironic | 22:20 | |
| *** weshay has quit IRC | 22:29 | |
| openstackgerrit | Merged openstack/ironic-inspector master: grenade: Only 'enable_plugin ironic-inspector' if not already in conf https://review.openstack.org/474344 | 22:32 |
| *** weshay has joined #openstack-ironic | 22:33 | |
| *** dmellado has quit IRC | 22:33 | |
| [1]rpioso | I have questions about the workflow for a bug fix that is split into a few separate patches in the same repository. Is anyone available to assist? | 22:34 |
| *** [1]rpioso is now known as rpioso | 22:34 | |
| *** dmellado has joined #openstack-ironic | 22:37 | |
| *** weshay has quit IRC | 22:39 | |
| *** weshay has joined #openstack-ironic | 22:42 | |
| TheJulia | [1]rpioso: partial-bug tag? | 22:43 |
| TheJulia | I'm in a restaurant, but I can try to answer questions | 22:44 |
| rpioso | TheJulia: Thank you so much for offering, but I don't want to interrupt your meal for this. It can wait if necessary. | 22:45 |
| TheJulia | rpioso: ask! :). We are basically waiting for the check at this point | 22:46 |
| *** jcoufal has quit IRC | 22:46 | |
| rpioso | TheJulia: Yes to the partial-bug tag. | 22:46 |
| rpioso | TheJulia: So, may the patches be on the same local repo topic branch? | 22:46 |
| TheJulia | Yes, we can also change the topic after they are pushed into gerrit | 22:47 |
| rpioso | TheJulia: The commits build on one another, so a commit depends on the previous ones. Does the depends-on tag apply to dependencies within a single repo? | 22:48 |
| rpioso | TheJulia: Or is that for CRD only? | 22:48 |
| TheJulia | So you would have parent/child relationships, so depends-on would not be needed | 22:49 |
| rpioso | TheJulia: Thank you. That's what I thought. I just wasn't sure. | 22:49 |
| TheJulia | Depends-on is mainly for cross-pollination, but you can use it in the same repo | 22:49 |
| rpioso | TheJulia: Cool! Sounds like the parent/child relationships will cover it, though. | 22:50 |
| TheJulia | In your case, it shouldn't be needed. I suggest just using the -t option when you upload to gerrit so the topic is set correctly | 22:50 |
| *** adisky__ has quit IRC | 22:50 | |
| TheJulia | If you've never used that option, it is covered in the man page | 22:50 |
| rpioso | TheJulia: I'll read some more about that option. Thanks for the pointer. | 22:51 |
| *** weshay has quit IRC | 22:51 | |
| rpioso | TheJulia: Do I need to concern myself with the git-review flow described at https://docs.openstack.org/infra/manual/developers.html#adding-a-dependency? | 22:52 |
| *** weshay has joined #openstack-ironic | 22:52 | |
| rpioso | TheJulia: That seems like it would be more applicable to a dependency on someone else's commit. | 22:52 |
| rpioso | TheJulia: Perhaps a differnent bug or feature. | 22:53 |
| rpioso | TheJulia: The updated portion of that discussion sounds scary. | 22:53 |
| TheJulia | Yeah, you have to be careful with that stuff, it is easy to squash others work | 22:54 |
| TheJulia | Basically, as long as a unique change-id header is in the commit message of each patchset, partial-bug in all the patches until the final which would be the closes-bug tag, you should be golden. Topic really helps us find/reassemble things in review | 22:55 |
| rpioso | TheJulia: What happens if the review of a parent affects the child? How is that handled? | 22:57 |
| *** rbudden has joined #openstack-ironic | 22:58 | |
| *** weshay has quit IRC | 23:00 | |
| TheJulia | rpioso: with the parent/child relationships there is an implied dependency. They will just have to land in order. Each can be edited independently with git review | 23:02 |
| *** weshay has joined #openstack-ironic | 23:03 | |
| *** dmellado has quit IRC | 23:03 | |
| rpioso | TheJulia: It's not clear to me how that works when the parent hash is changed by an amended commit. | 23:04 |
| TheJulia | That is where the change-id in the commit message comes in. Gerrit uses that to assemble and track the map | 23:05 |
| TheJulia | Err, mapping | 23:05 |
| *** dmellado has joined #openstack-ironic | 23:06 | |
| rpioso | TheJulia: Is the initiali relationship seeded by the git parent hash and then subsequently tracked by change-id? | 23:07 |
| TheJulia | rpioso: hopefully that helps? | 23:07 |
| TheJulia | Yes, it is | 23:07 |
| rpioso | Also, how can it be organized locally to facilitate unit testing of the child. Cherry picking or merging the most recent parent commit? | 23:07 |
| TheJulia | If you edit individual patches after upload into gerrit, the children will need to be rebased | 23:08 |
| TheJulia | If they touch common lines of code, it will need to be done by hand, but that is easy to do after you get the hang of it | 23:10 |
| rpioso | TheJulia: I believe I conceptually understand. For rebasing use "git review -x $CHILD_CHANGE_NUMBER"? | 23:10 |
| TheJulia | Yup | 23:10 |
| *** chlong has joined #openstack-ironic | 23:10 | |
| TheJulia | Git will tell you if the cherry-pick failed. If it doesn't, typically you could have hit the rebase button in gerrit | 23:11 |
| rpioso | TheJulia: It Sounds like it would be best to have separate local topic branches for each commit. Do you agree? | 23:12 |
| TheJulia | The cherry-pick failing just means that the conflict needs to be resolved, git add filename; git cherry-pick --continue ; git review | 23:12 |
| rpioso | TheJulia: Thank you for describing the cherry-pick flow. | 23:13 |
| TheJulia | rpioso: not really, only it your trying to keep your local repo as the source of truth. Once loaded in gerrit, gerrit needs to be there source of truth, hence downloading the change to work on it more is generally best practice | 23:13 |
| *** dmellado has quit IRC | 23:15 | |
| TheJulia | (this also helps this of us who do lots of reviews, in case we need to rebase something) | 23:15 |
| rpioso | TheJulia: It helps to understand the source of truth :) | 23:16 |
| TheJulia | rpioso: any more questions? | 23:17 |
| *** dmellado has joined #openstack-ironic | 23:18 | |
| rpioso | TheJulia: Is it possible for those few commits to be staged on a local topic branch, so that they can be submitted for review one after the other as fast as one can type succession? | 23:18 |
| openstackgerrit | Peter Piela proposed openstack/ironic-ui master: Extend backend mock with port operations https://review.openstack.org/473539 | 23:19 |
| rpioso | TheJulia: git checkout hash, git review ...; git checkout hash, git review ...; etc.? | 23:19 |
| *** paramite has quit IRC | 23:20 | |
| TheJulia | rpioso: you can stack them in a local topic branch and submit them at one time all together, only true gerrit requirement is the change-id in the commit messages | 23:20 |
| TheJulia | If you do the git review -s step prior to committing the changes, you should be good. If not... You'll need to one the chain one patch at a time and amend the commit messages. Been there, done that... It is not fun. | 23:21 |
| TheJulia | Although I think I got through fourty patches or something crazy in about an hour and a half | 23:22 |
| TheJulia | Git cherry-pick hash; git commit --amend might work to help stack them in a new branch, never tried it that way | 23:23 |
| TheJulia | Explicitly checking out the hash brings with it the prior history before that hash | 23:24 |
| rpioso | TheJulia: Ahhhhh, so 1) git checkout -b $DEV_TOPIC_BRANCH, 2) git review -s, 3) hack, hack, hack, 4) git add, 5) git commit | 23:25 |
| rpioso | TheJulia: Then rinse and repeat steps 2-5 | 23:26 |
| TheJulia | Exactly! | 23:26 |
| rpioso | TheJulia: And finally submit them all at once via 6) git review -t | 23:26 |
| TheJulia | It gets more complex if you already have the commits, say downstream without the change-ids and need to fork lift them upstream | 23:27 |
| TheJulia | Git review -t bug/idnumber | 23:27 |
| rpioso | TheJulia: Thankfully, that complication doesn't apply, yet. This discussion will help me avoid it :) | 23:28 |
| TheJulia | You likely want to do git review -s first, but the file telling git review what to do should be off of master branch | 23:28 |
| TheJulia | Awesome! Enjoy! | 23:29 |
| rpioso | TheJulia: Oh, right regarding the first git review -s. I missed that one. ty | 23:29 |
| rpioso | TheJulia: "the file telling git review what to do"? | 23:30 |
| TheJulia | .gitreview | 23:30 |
| *** ijw has joined #openstack-ironic | 23:30 | |
| *** sasha2 has quit IRC | 23:31 | |
| rpioso | TheJulia: Got it. | 23:31 |
| rpioso | TheJulia: I believe I'm all set. | 23:31 |
| *** dmellado has quit IRC | 23:31 | |
| rpioso | TheJulia: Thank you so very much. I hope this didn't cause you any indigestion ;-) | 23:32 |
| TheJulia | Most excellent! Enjoy taking over the world! | 23:32 |
| rpioso | TheJulia: lol | 23:32 |
| *** paramite has joined #openstack-ironic | 23:33 | |
| *** paramite_ has joined #openstack-ironic | 23:37 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic master: py3.5:Workaround fix for forcing virtualbmc installation with pip2 https://review.openstack.org/473913 | 23:37 |
| *** paramite has quit IRC | 23:40 | |
| *** aignatov has quit IRC | 23:41 | |
| *** aignatov has joined #openstack-ironic | 23:43 | |
| *** rpioso has quit IRC | 23:50 | |
| *** krtaylor has quit IRC | 23:50 | |
| *** dmellado has joined #openstack-ironic | 23:51 | |
| *** mtanin___ has quit IRC | 23:52 | |
| *** dmellado has quit IRC | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
