Friday, 2016-11-04

*** rama_y has quit IRC00:01
*** Nisha1 has joined #openstack-ironic00:02
*** causten has joined #openstack-ironic00:04
*** aNuposic has quit IRC00:04
*** Nisha1 has quit IRC00:06
*** harlowja has joined #openstack-ironic00:11
*** rpioso has quit IRC00:12
*** shobhar__ has quit IRC00:14
*** Sukhdev has quit IRC00:24
*** links has joined #openstack-ironic00:27
*** hamzy has joined #openstack-ironic00:30
*** zhugaoxiao has quit IRC00:30
*** zhugaoxiao has joined #openstack-ironic00:30
*** amotoki has joined #openstack-ironic00:41
*** hoangcx has joined #openstack-ironic00:44
*** hoangcx_ has joined #openstack-ironic00:45
*** hoangcx_ has quit IRC00:45
*** hoangcx has quit IRC00:45
*** hoangcx has joined #openstack-ironic00:46
*** causten has quit IRC00:51
*** cdearborn has quit IRC01:00
*** phuongnh has joined #openstack-ironic01:03
*** jkilpatr has quit IRC01:07
*** tuanluong has joined #openstack-ironic01:10
*** moshele has joined #openstack-ironic01:13
*** moshele has quit IRC01:23
*** jerrygb has joined #openstack-ironic01:26
*** jerrygb_ has quit IRC01:27
*** jerrygb_ has joined #openstack-ironic01:32
*** jerrygb has quit IRC01:35
*** jerrygb_ has quit IRC01:39
*** jerrygb has joined #openstack-ironic01:41
*** syed_ has quit IRC01:45
*** jerrygb has quit IRC01:49
*** baoli has joined #openstack-ironic01:49
*** jerrygb has joined #openstack-ironic01:50
*** yibo has joined #openstack-ironic01:58
*** baoli has quit IRC02:05
*** chlong has joined #openstack-ironic02:06
*** jerrygb has quit IRC02:12
*** jerrygb has joined #openstack-ironic02:13
*** shuquan has joined #openstack-ironic02:17
*** jerrygb has quit IRC02:29
*** jerrygb has joined #openstack-ironic02:30
*** jerrygb_ has joined #openstack-ironic02:42
*** jerrygb has quit IRC02:44
gcbdtantsur, please revisit https://review.openstack.org/#/c/389513/  when you're free :-)02:44
patchbotpatch 389513 - ironic - Use function is_valid_mac from oslo.utils02:44
*** jerrygb has joined #openstack-ironic02:47
*** jerrygb_ has quit IRC02:50
*** rbudden has joined #openstack-ironic02:52
*** Sukhdev has joined #openstack-ironic02:57
*** khamtamtun has joined #openstack-ironic02:59
*** rbudden_ has joined #openstack-ironic03:10
*** rbudden has quit IRC03:10
*** rbudden_ is now known as rbudden03:10
*** shuquan has quit IRC03:19
*** aparnav has joined #openstack-ironic03:21
*** shuquan has joined #openstack-ironic03:31
*** Nisha_away has joined #openstack-ironic03:51
*** khamtamtun has quit IRC03:58
*** rbudden has quit IRC03:58
*** khamtamtun has joined #openstack-ironic03:59
*** shuquan has quit IRC04:00
*** khamtamtun has quit IRC04:00
*** shuquan has joined #openstack-ironic04:02
*** vinsh has quit IRC04:09
*** baoli has joined #openstack-ironic04:17
*** shobhar has joined #openstack-ironic04:20
*** baoli has quit IRC04:22
*** rbrud has quit IRC04:24
*** jerrygb has quit IRC04:24
*** shuquan has quit IRC04:27
*** khamtamtun has joined #openstack-ironic04:36
*** khamtamtun has quit IRC04:45
*** khamtamtun has joined #openstack-ironic04:50
*** livelace has joined #openstack-ironic04:57
*** Sukhdev has quit IRC05:00
*** khamtam25 has joined #openstack-ironic05:14
*** khamtamtun has quit IRC05:14
*** hshiina has joined #openstack-ironic05:18
hshiinamorning ironic05:18
*** shuquan has joined #openstack-ironic05:23
*** g3ek has quit IRC05:35
*** khamtam25 has quit IRC05:40
*** g3ek has joined #openstack-ironic05:42
*** shobhar has quit IRC05:46
*** khamtamtun has joined #openstack-ironic05:52
*** shuquan has quit IRC05:53
openstackgerritOpenStack Proposal Bot proposed openstack/bifrost: Updated from global requirements  https://review.openstack.org/38987605:53
*** shuquan has joined #openstack-ironic05:54
*** rcernin has joined #openstack-ironic05:55
*** khamtamtun has quit IRC06:00
*** khamtamtun has joined #openstack-ironic06:05
*** vinsh has joined #openstack-ironic06:09
*** khamtamtun has quit IRC06:12
*** vinsh has quit IRC06:14
*** phuongnh has quit IRC06:25
*** phuongnh has joined #openstack-ironic06:26
*** ChubYann has quit IRC06:27
*** baoli has joined #openstack-ironic06:30
*** sabeen has quit IRC06:31
*** baoli has quit IRC06:34
*** fxpester has joined #openstack-ironic06:56
*** tesseract has joined #openstack-ironic07:04
*** tesseract is now known as Guest1319407:04
*** mjura has joined #openstack-ironic07:06
Nisha_awaymorning Ironic!!!07:08
Nisha_awayhshiina, morning07:11
hshiinaNisha_away, morning07:12
*** phuongnh has quit IRC07:14
*** mjura has quit IRC07:15
*** mjura has joined #openstack-ironic07:15
pas-hamorning Ironic. TGIF :)07:24
*** shuquan has quit IRC07:27
tuanluongmorning ironic07:27
*** shuquan has joined #openstack-ironic07:28
*** pcaruana has joined #openstack-ironic07:33
*** chlong has quit IRC07:33
*** shuquan has quit IRC07:34
*** shuquan has joined #openstack-ironic07:34
*** khamtamtun has joined #openstack-ironic07:41
*** khamtamtun has quit IRC07:43
*** raghusab has quit IRC07:50
*** ccamacho has quit IRC07:53
*** ohamada has joined #openstack-ironic07:59
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-ironic08:00
*** ccamacho has joined #openstack-ironic08:05
*** livelace has quit IRC08:07
*** d0ugal has joined #openstack-ironic08:07
*** jaosorior has joined #openstack-ironic08:07
*** fragatina has joined #openstack-ironic08:09
*** shuquan_ has joined #openstack-ironic08:09
*** fragatina has quit IRC08:10
*** raghusab has joined #openstack-ironic08:10
*** fragatina has joined #openstack-ironic08:10
*** shuquan has quit IRC08:11
*** Nisha_away has quit IRC08:16
*** khamtamtun has joined #openstack-ironic08:17
*** athomas has joined #openstack-ironic08:19
*** aarefiev_afk is now known as aarefiev08:21
aarefievmorning!08:21
*** khamtamtun has quit IRC08:21
*** d0ugal has quit IRC08:28
*** d0ugal has joined #openstack-ironic08:32
*** d0ugal has quit IRC08:32
*** khamtamtun has joined #openstack-ironic08:33
*** vsaienk0 has quit IRC08:35
*** khamtamtun has quit IRC08:35
*** khamtamtun has joined #openstack-ironic08:37
*** xek has joined #openstack-ironic08:38
xekmorning ironic :)08:39
*** vsaienk0 has joined #openstack-ironic08:41
*** khamtamtun has quit IRC08:44
*** d0ugal has joined #openstack-ironic08:55
*** d0ugal_ has joined #openstack-ironic08:57
*** sborkows has joined #openstack-ironic08:58
sborkowsmorning, all08:58
*** d0ugal has quit IRC08:59
*** jpich has joined #openstack-ironic08:59
*** strigazi_AFK is now known as strigazi09:04
*** hshiina has quit IRC09:04
*** lucas-afk is now known as lucasagomes09:12
lucasagomesmorning all09:15
*** e0ne has joined #openstack-ironic09:19
*** dtantsur|afk is now known as dtantsur09:32
dtantsurMorning Ironic09:32
sborkowsmorning lucasagomes, dtantsur09:33
*** Nisha_away has joined #openstack-ironic09:34
openstackgerritVasyl Saienko proposed openstack/ironic-specs: Update ironic-ml2-integration spec  https://review.openstack.org/39366009:34
vsaienk0morning lucasagomes, dtantsur, sborkows and All!09:35
openstackgerritYuriy Zveryanskyy proposed openstack/ironic: Add node provision state change notification  https://review.openstack.org/34843709:36
*** e0ne has quit IRC09:38
tuanluongmorning ironic09:38
*** milan has joined #openstack-ironic09:44
milanmorning Ironic! :)09:44
sborkowsdtantsur: I have a question about custom hardware managers - in my patch https://review.openstack.org/#/c/391836/ I added such manager to hardware.py file. However, I got an idea from Joanna, that the better solution will be to move it to separate file in separate 'hardware_managers' directory. What do you think about it?09:44
patchbotpatch 391836 - ironic-python-agent - Add a new Hardware Manager for X710 network card09:44
lucasagomesfolks, I've just opened a RFE ( https://bugs.launchpad.net/ironic/+bug/1639187 ) for the petitboot change ( https://review.openstack.org/#/c/185987 ) as requested in the comments. Someone mind taking a look and approving if it's good ? (It's tiny)09:46
openstackLaunchpad bug 1639187 in Ironic "[RFE] Extend PXE to support petitboot" [Wishlist,New]09:46
patchbotpatch 185987 - ironic - Enable PXE for systems using petitboot09:46
dtantsursborkows, ++ for a separate file, makes sense09:46
sborkowsdtantsur, what about a separate directory for future hardware managers?09:47
dtantsursborkows, yeah, why not09:48
sborkowsdtantsur, ok, so 1 more thing - what about the hardware.py file? Should we leave it untouched or move along with the other hardware managers?09:48
dtantsursborkows, please leave it as it is, as it contains generic code09:49
sborkowsdtantsur, ok thanks for advice.09:50
*** d0ugal_ is now known as d0ugal09:51
*** d0ugal has joined #openstack-ironic09:51
openstackgerritTuan Luong-Anh proposed openstack/ironic: Fix setting persistent boot device does not work  https://review.openstack.org/37632209:53
openstackgerritTuan Luong-Anh proposed openstack/ironic: Fix setting persistent boot device does not work  https://review.openstack.org/37632209:54
*** karthi has joined #openstack-ironic09:56
*** shuquan_ has quit IRC09:57
*** shuquan has joined #openstack-ironic09:58
*** shuquan has quit IRC10:03
openstackgerritTuan Luong-Anh proposed openstack/ironic: Fix setting persistent boot device does not work  https://review.openstack.org/37632210:06
*** yufei_ has quit IRC10:09
*** yufei_ has joined #openstack-ironic10:11
*** vinsh has joined #openstack-ironic10:11
*** yufei_ has quit IRC10:13
jrolllucasagomes: does this RFE not cover it? https://bugs.launchpad.net/ironic/+bug/152626510:13
openstackLaunchpad bug 1526265 in Ironic "[RFE] OpenPower Petitboot Boot Driver" [Wishlist,Triaged] - Assigned to chenglch (chenglch)10:13
*** yufei_ has joined #openstack-ironic10:13
jrolllucasagomes: which had a spec: http://specs.openstack.org/openstack/ironic-specs/specs/approved/petitboot-boot-driver.html10:13
*** yufei_ has quit IRC10:13
lucasagomesjroll, hi there, lemme see10:13
jrolloh, and good morning everybody :)10:14
jrolllucasagomes: it's a bit odd because the spec proposes new drivers, which mostly just add that pxe option10:14
lucasagomesjroll, it looks like different work. What I get from turkes' patch is that you don't need a new driver10:14
*** yufei_ has joined #openstack-ironic10:15
lucasagomesyou just need a DHCP option10:15
lucasagomesright10:15
*** athomas has quit IRC10:15
*** yufei_ has quit IRC10:15
jrolllucasagomes: right, so we can get rid of the existing rfe/spec, yeah?10:15
lucasagomesI will ask in the review, I believe we could get rid of the spec (and it's RFE) yes10:15
jrollyeah, cool10:16
jrollapproving your new RFE now10:16
*** vinsh has quit IRC10:16
*** ppiela has quit IRC10:16
jrollI think I'm finally feeling good enough to actually work today \o/10:17
*** ppiela has joined #openstack-ironic10:17
lucasagomesjroll, thanks, I left a comment in the review about the spec too10:17
*** yufei_ has joined #openstack-ironic10:17
lucasagomesjroll, o/ good10:17
jroll:)10:18
*** kamtamtun has joined #openstack-ironic10:18
*** e0ne has joined #openstack-ironic10:19
dtantsurmorning jroll10:19
dtantsurgood to hear you feel better!10:19
jrollmorning dtantsur :)10:19
jrollnot 100% but I think I have a brain now10:20
dtantsurjroll, let's celebrate that with approving a backport :) https://review.openstack.org/39318810:20
patchbotpatch 393188 - ironic (stable/newton) - API: lookup() ignore malformed MAC addresses10:20
jrollah, fun10:20
jrolldtantsur: done10:21
dtantsurthnx10:21
*** athomas has joined #openstack-ironic10:21
*** sambetts|afk is now known as sambetts10:25
sambettsMorning all10:25
sambettso/ jroll, dtantsur10:25
jrollmorning sambetts :)10:25
dtantsurhey sambetts10:26
milanmorning jroll, sambetts! :)10:30
jrollmorning milan10:30
*** yufei_ has quit IRC10:34
*** tuanluong has quit IRC10:34
*** hoangcx has quit IRC10:35
*** yufei_ has joined #openstack-ironic10:38
yufei_test ping10:39
*** NobodyCam has quit IRC10:42
*** evgenyl has quit IRC10:42
*** Ng has quit IRC10:42
*** betherly has quit IRC10:42
jrollhi yufei_10:42
*** romcheg_ has quit IRC10:43
*** sergek_ has quit IRC10:43
*** ildikov has quit IRC10:43
*** kun_huang has quit IRC10:43
*** izaakk has quit IRC10:43
*** vdrok has quit IRC10:44
*** fungi has quit IRC10:44
*** zhenguo has quit IRC10:44
*** mgould|afk is now known as mgould10:44
mgouldmorning all10:45
mgouldmorning lucasagomes jroll milan yufei_ sambetts dtantsur10:45
milanmorning mgould! :)10:45
*** sergek_ has joined #openstack-ironic10:45
mgouldmorning milan :-)10:45
dtantsurhey mgould, milan10:45
*** Ng has joined #openstack-ironic10:45
*** ildikov has joined #openstack-ironic10:46
milanmorning dtantsur! :)10:46
*** betherly has joined #openstack-ironic10:46
*** kun_huang has joined #openstack-ironic10:46
*** vdrok has joined #openstack-ironic10:47
*** zhenguo has joined #openstack-ironic10:47
*** openstackgerrit has quit IRC10:47
*** openstackgerrit has joined #openstack-ironic10:48
Nisha_awaymorning jroll, dtantsur milan mgould lucasagomes sambetts n all others10:51
milanmorning Nisha_away! :)10:51
jrollmorning Nisha_away, mgould :)10:51
*** Nisha_away is now known as Nisha110:51
Nisha1jroll, do we have the priority list for Octata captured somewhere? I am still catching up with the mails10:54
jrollNisha1: not in git yet (I've been sick this week) but the list from the summit is at the bottom of https://etherpad.openstack.org/p/ironic-ocata-summit-priorities10:54
Nisha1jroll, thanks...i also just joined back from my long leave yesterday only10:55
jrollwelcome back :)10:55
*** NobodyCam has joined #openstack-ironic10:56
*** romcheg_ has joined #openstack-ironic10:56
Nisha1thank you10:56
*** fungi has joined #openstack-ironic10:58
*** ralonsoh has joined #openstack-ironic10:59
*** evgenyl has joined #openstack-ironic10:59
*** izaakk has joined #openstack-ironic10:59
Nisha1jroll, what is the likeliness of the specs and code patches related to inspection to be merged in Octata11:04
Nisha1they are already in review from 2 releases11:04
jrollNisha1: remind me which patches?11:05
Nisha1jroll,the spec patches https://review.openstack.org/305864, https://review.openstack.org/201904, https://review.openstack.org/33813811:06
patchbotpatch 305864 - ironic-specs - Boot management for in-band inspection11:06
patchbotpatch 201904 - ironic-specs - Enhance ilo drivers to do inband inspection11:06
patchbotpatch 338138 - ironic-specs - Add new out-of-band properties to ilo drivers11:06
Nisha1there are 2 more small RFE proposed related to inspection last release11:07
Nisha1https://bugs.launchpad.net/ironic/+bug/1623769-, https://bugs.launchpad.net/ironic/+bug/160962211:07
openstackLaunchpad bug 1623769 in Ironic "[RFE] Allow iLO drivers to add new capabilities that are to be used by Nova scheduler without any changes to Ironic" [Wishlist,In progress] - Assigned to Shivanand Tendulker (stendulker)11:07
openstackLaunchpad bug 1609622 in Ironic "[RFE] Enhance iLO drivers to use snmp to do OOB inspection for local_gb" [Wishlist,In progress] - Assigned to Nisha Agarwal (agarwalnisha1980)11:07
*** jkilpatr has joined #openstack-ironic11:07
Nisha1since i dont see them in priority list at all, would like to know the likeliness for Octata release for them11:08
jrollNisha1: well, single-vendor work is never on the priority list - I'd like to say we can make progress but I need to get more organized before I can promise anything11:10
jrollI haven't had a full day back from summit yet, still need to catch up on everything11:10
jrolldtantsur: ^^ any thoughts?11:10
milansambetts, dtantsur let's merge https://review.openstack.org/#/c/392943/ ?11:11
patchbotpatch 392943 - ironic-inspector - Allow to configure cache clean up period11:11
milanthe infra patch was merged already11:11
dtantsurjroll, Nisha1, "add new capabilities" I want a generic spec on capabilities we expose. otherwise we end up with all drivers incompatible with each other and ironic-inspector11:11
dtantsurmilan, will do11:11
jrolldtantsur: ++11:12
dtantsurjroll, Nisha1, otherwise I agree, we do take vendor work, but it rarely gets on the priority list. it does not mean we won't land it.11:12
jrollI also find it hard to believe we should be scheduling based on firmware versions and such11:12
dtantsuras to "Boot management for in-band inspection", it is my RFE, so I won't comment on its prioritization :)11:13
jrolldtantsur: oh, I'm asking for comments on 'can we get it done', not prioritization :)11:13
milandtantsur, thx11:13
dtantsur"Boot management for in-band inspection" is a small thing, partly contained in ironic-inspector. I'd love to get it done any time, as soon as the spec gets more attention.11:14
dtantsurbut it's also not as urgent as other things I've committed to11:14
sambettsjroll: do we have a template for RFEs?11:16
jrollsambetts: don't think so11:16
openstackgerritMerged openstack/ironic: API: lookup() ignore malformed MAC addresses  https://review.openstack.org/39318811:16
* dtantsur lols at https://bugs.launchpad.net/cirros/+bug/163880711:20
openstackLaunchpad bug 1638807 in CirrOS "Improper password to root user" [Undecided,New]11:20
Nisha1jroll, dtantsur i agree11:23
*** vinsh has joined #openstack-ironic11:23
mat128good morning11:23
dtantsurmorning mat12811:24
Nisha1the spec is already there for new capabilities11:26
Nisha1dtantsur, jroll https://review.openstack.org/33813811:26
patchbotpatch 338138 - ironic-specs - Add new out-of-band properties to ilo drivers11:26
*** aparnav has quit IRC11:27
*** karthi has quit IRC11:27
mgouldmorning Nisha1 mat12811:29
dtantsurNisha1, if you remove "ilo" from it, add reasoning behind every of them (preferably with examples) and how to detect them in-band (if possible), then it will be the spec I'm looking for11:29
*** hw_wutianwei has quit IRC11:29
cdanielmorning all11:30
dtantsurmorning cdaniel11:30
Nisha1dtantsur, i can remove ilo, but i havent explored all thru inband11:30
Nisha1i know hw to get them oob11:31
dtantsurI understand, but need to agree on common direction for capabilities11:31
Nisha1dtantsur, we can have the implementation oob and inband both11:31
dtantsurthe ilo driver is unique enough already. we have to make sure we converge more drivers to exposing the same capabilities11:31
Nisha1oob - for ilo drivers11:31
dtantsurin particular, I'm leaned towards being able to get the majority of the things in-band11:32
Nisha1inband- for inpector11:32
Nisha1dtantsur, OOB is always faster11:32
dtantsurI understand, I don't see how it's related to the discussion11:33
dtantsurdoes you spec have enough information for non-ILO drivers to implement it?11:33
Nisha1dtantsur, no i havent explored much how to get those info inband11:34
dtantsurwell, so now you see the problem. I don't want the ilo driver to diverge even more feature-wise.11:35
dtantsur(boot_mode situation is more than enough)11:35
*** dprince has joined #openstack-ironic11:36
*** d0ugal has quit IRC11:40
jrolldtantsur: that cirros bug is already fixed :D https://git.launchpad.net/cirros/commit/?id=9a7c371ef329cf78f256d0a5a8f475d9c57f547711:41
aarefievwe are still broken :(11:43
*** d0ugal has joined #openstack-ironic11:44
dtantsurjroll, lol11:44
dtantsuraarefiev, ugh :(11:44
aarefievlooks like same bug was in ironic,  changing configuration option doesn't have affect11:45
aarefievyeah11:45
Nisha1dtantsur, if the spec covers the way how to discover inband, will ilo drivers be allowed to implement oob without specifically doing for refernce drivers.11:45
Nisha1?11:45
*** portdirect_away is now known as portdirect11:46
dtantsurNisha1, as soon as we agree on which capabilities we discover and why, I'm fine with ilo being the first to implement them11:46
dtantsurjroll, ^^^ agree?11:46
jrolldtantsur: yeah, sure, as long as someone is going to work on the in-band implementation11:47
jrolldtantsur: what can I do today to best help cores out - priorities in spec repo + trello setup?11:48
dtantsurjroll, yes, these two11:48
Nisha1dtantsur,so ilo oob implementation can land first n doesnt has to wait fr reference implementation to land?11:48
jrolldtantsur: thanks, I'll get those done today11:48
dtantsurjroll, and then form the subteams the same way we did for newton11:48
jrollyep11:48
dtantsurNisha1, for me it's fine, other folks may have different opinion11:49
*** ralonsoh_ has joined #openstack-ironic11:49
*** ralonsoh has quit IRC11:53
Nisha1jroll ^^^11:53
*** bfournie has quit IRC11:55
dtantsurfolks, do we have a CI with plain PXE? I'm afraid to +2 https://review.openstack.org/185987 without it..11:56
patchbotpatch 185987 - ironic - Enable PXE for systems using petitboot11:56
dtantsurlucasagomes, ^^^?11:56
jrollNisha1: like I said a few minutes ago, "as long as someone is going to work on the in-band implementation"11:56
jrolldtantsur: I believe so, let me check11:56
lucasagomesdtantsur, I think IBM does use it for powerpc11:56
* lucasagomes checks11:56
lucasagomeswe probably should mention it in the RFE if that's the case tho11:57
jrolldtantsur: pxe_ssh11:57
dtantsurjroll, which of them? I see ipxe_enabled=True http://logs.openstack.org/87/185987/12/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa/b848902/logs/screen-ir-cond.txt.gz#_2016-11-03_14_20_32_28211:57
dtantsurlucasagomes, 3rd party CI usually use plain PXE for some reason. but they're so unstable...11:58
jrolldtantsur: this one https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/ironic.yaml#L54911:58
dtantsurjroll, I'm not sure if we run this job any more.. maybe on some stable branches11:58
dtantsurjroll, this is for old DIB ramdisk, no?11:59
*** Nisha1 has quit IRC11:59
lucasagomesjroll, that runs standard pxe but not necessarily pettitboot right ?11:59
lucasagomes(btw, it's broken on xenial, I put a patch up yesterday fixing it)11:59
dtantsurlucasagomes, ignore petitboot for now, I want to make sure we don't break PXE at all11:59
lucasagomesoh right11:59
dtantsuroh so it IS broken?11:59
lucasagomesyes11:59
jrolldtantsur: yeah, you might be right12:00
lucasagomeson xenial12:00
dtantsurlucasagomes, do we have a single job on master running plain PXE?12:00
lucasagomesdtantsur, https://review.openstack.org/#/c/393353/12:00
patchbotpatch 393353 - ironic - DevStack: Fix standard PXE on Ubuntu Xenial12:00
dtantsurI suspect the answer is "no", which makes uncomfortable both generally and with approving this patch12:00
lucasagomesdtantsur, I think no at the moment12:00
aarefievlooks like pas-ha didn't find pxe job https://etherpad.openstack.org/p/ironic-gate-jobs-described12:01
*** baoli has joined #openstack-ironic12:01
lucasagomesdtantsur, maybe we should add a experimental job in the gate for it ?12:01
lucasagomesthen, we flip the trusty to xenial once pxe is fixed12:01
lucasagomesor we just flip and fix it12:01
dtantsurlucasagomes, we used to run the postgres job with plain PXE. I suggest we do it again.12:02
dtantsurit's non-voting, so we won't be affected by PXE instability too much12:02
dtantsur(i.e. we can ignore it for patches not touching PXE code)12:02
*** ralonsoh__ has joined #openstack-ironic12:03
lucasagomesdtantsur, heh fair, it consolidates too not-very-used technologies (in openstack realms) in one job :-)12:03
dtantsurwanna propose a patch?12:04
lucasagomesI guess, project-config here I go again12:04
dtantsurit's fun, isn't it? ;)12:05
lucasagomesyeah, I feel like I'm paying for my sis12:05
lucasagomeswin-win12:05
*** baoli has quit IRC12:05
lucasagomessins*12:05
*** ralonsoh_ has quit IRC12:06
openstackgerritStig Telfer proposed openstack/ironic-specs: Torrent-based provisioning  https://review.openstack.org/31109112:07
nicodemosmorning.12:08
*** baoli has joined #openstack-ironic12:11
*** baoli_ has joined #openstack-ironic12:12
*** chlong has joined #openstack-ironic12:13
*** baoli has quit IRC12:16
*** xek has quit IRC12:17
*** cdearborn has joined #openstack-ironic12:21
*** jerrygb has joined #openstack-ironic12:23
openstackgerrityolanda.robla proposed openstack/bifrost: Allow nginx port on selinux  https://review.openstack.org/39374512:24
openstackgerritDmitry Tantsur proposed openstack/ironic: IPMI command should depend on console type  https://review.openstack.org/39374612:26
dtantsurlooks like a reasonable backport too ^^^12:27
*** bfournie has joined #openstack-ironic12:29
*** betherly has quit IRC12:31
*** jerrygb has quit IRC12:31
*** e0ne has quit IRC12:33
openstackgerritJim Rollenhagen proposed openstack/ironic-specs: Add ocata priorities  https://review.openstack.org/39375312:38
jrollwheeeeeeeeeeeee12:38
jrollcores please review ^^12:39
*** jerrygb has joined #openstack-ironic12:42
*** rbrud has joined #openstack-ironic12:44
*** vinsh has quit IRC12:45
*** chlong has quit IRC12:46
openstackgerritMerged openstack/ironic: Ignore required_services for multinode topology  https://review.openstack.org/35279312:51
openstackgerritMerged openstack/ironic: Skip db configuration on subnodes  https://review.openstack.org/35330312:51
*** lucasagomes is now known as lucas-hungry12:52
*** gcb has quit IRC12:52
*** rbudden has joined #openstack-ironic12:53
TheJuliajroll: comments posted, generally looks good to me, although the CI refactoring bit likely needs to be a higher priority :\12:55
*** jheroux has joined #openstack-ironic12:55
openstackgerrityolanda.robla proposed openstack/bifrost: Allow nginx port on selinux  https://review.openstack.org/39374512:58
*** jcoufal has joined #openstack-ironic12:58
*** shuquan has joined #openstack-ironic12:59
jrollTheJulia: yeah, agree, thanks12:59
*** ralonsoh_ has joined #openstack-ironic13:01
*** jerrygb has quit IRC13:01
*** betherly has joined #openstack-ironic13:03
*** shuquan has quit IRC13:04
*** ralonsoh__ has quit IRC13:04
mgoulddoes anyone here understand magnet links? I'm trying to understand L115 of https://review.openstack.org/#/c/311091/4..5/specs/approved/torrent-provisioning.rst13:09
patchbotpatch 311091 - ironic-specs - Torrent-based provisioning13:09
aarefievmgould: just ask13:10
openstackgerrityolanda.robla proposed openstack/bifrost: Allow nginx port on selinux  https://review.openstack.org/39374513:11
jrollmgould: magnet links are a way to join a swarm without a central tracker13:11
mgouldaarefiev: I'm trying to form a good questiojn :-)13:11
mgouldyep13:11
jrollused in combination with DHT13:11
aarefievjroll: it could be used with tracker too13:11
jrollaarefiev: oh, yeah, you're right13:11
*** d0ugal has quit IRC13:12
mgouldso, the magnet link contains a hash of the .torrent file, and optionally a URL to the .torrent file?13:12
jrollmgould: seen http://www.bittorrent.org/beps/bep_0009.html ?13:13
mgouldthen the client fetches the .torrent from the DHT or from the URL, then downloads the files of interest using the information in the .torrent?13:13
mgouldjroll: aha, thanks13:13
jrollhope it helps :)13:13
* jroll also reads it13:13
*** links has quit IRC13:13
*** mgoddard_ has joined #openstack-ironic13:14
aarefievyeah and all other stuff  ^13:14
aarefiev you need to get .torrent somehow first and then download file if  seeds available13:16
mgouldyep13:16
mariojvit looks like optionally you can still use a tracker? instead of DHT13:17
aarefievyes13:17
mgouldand we're seeding the image file from Glance, and the question is where we seed the .torrent file from?13:17
openstackgerrityolanda.robla proposed openstack/bifrost: Allow nginx port on selinux  https://review.openstack.org/39374513:17
*** mgoddard has quit IRC13:17
aarefievproblem, how to get this torrent file,  actually glance doesn't seed image13:18
aarefievwe should get it via http first and then deployed nodes will seed it13:19
mgouldsure13:19
*** d0ugal has joined #openstack-ironic13:20
mgouldbut to get an HTTP URL of an image in Glance we need to use Glare?13:21
aarefievjroll, when you will finish reading torrent specification, maybe you could take a look on ironic spec :)13:22
jrollaarefiev: I'm trying to catch up on post-summit stuff today, sorry13:22
*** mgoddard has joined #openstack-ironic13:22
aarefievnp13:22
jrollalso, isn't glare work stopping?13:22
*** mgoddard_ has quit IRC13:22
aarefievnope13:23
jrollhm13:23
aarefievmgould: Glare is artifact repository , it was part of Glance13:23
aarefievand now separate service13:24
aarefievjroll: I've disscused Glare with mfedosin on summit13:25
*** [1]cdearborn has joined #openstack-ironic13:25
jrollaarefiev: ok13:25
aarefievcommunity will support it13:25
openstackgerrityolanda.robla proposed openstack/bifrost: Allow nginx port on selinux  https://review.openstack.org/39374513:26
mariojvone alternative would be to use swift right?13:26
mgouldaarefiev: so Glare solves the problem "here is a file; please give me a URL where other clients can download that file"?13:26
openstackgerrityolanda.robla proposed openstack/bifrost: Allow nginx port on selinux  https://review.openstack.org/39374513:27
* mgould thought that was what Swift did :-(13:27
aarefievmgould: we will add new file type torrent, and there are would be no needs in storing torrent for example in glance as "image"13:29
aarefievswift could be backend to glare13:30
mgouldah, OK13:30
aarefievit uses same glance_store13:30
*** daemontool has joined #openstack-ironic13:32
*** ccamacho is now known as ccamacho|lunch13:32
*** dansmith is now known as superdan13:34
*** d0ugal has quit IRC13:35
*** d0ugal has joined #openstack-ironic13:37
*** jerrygb has joined #openstack-ironic13:39
*** jerrygb has quit IRC13:39
*** cdearborn has quit IRC13:40
*** jroll is now known as jrollinhatin13:40
*** jerrygb has joined #openstack-ironic13:46
openstackgerritJarrod Johnson proposed openstack/pyghmi: Ignore KeyError on delete of missing sensor  https://review.openstack.org/39377813:46
mgouldaarefiev: left some comments/questions, hopefully not too stupid13:48
*** jerrygb has quit IRC13:48
aarefievmgould: thanks, I'll take a look13:48
*** causten has joined #openstack-ironic13:49
mgouldnp13:50
*** e0ne has joined #openstack-ironic13:50
*** d0ugal_ has joined #openstack-ironic13:51
milanaarefiev, seems the patch to update the cleanup in inspector  fails to update the config file :-/ http://logs.openstack.org/43/392943/6/check/gate-tempest-dsvm-ironic-inspector-discovery/eb78693/logs/etc/ironic-inspector/inspector.conf.txt.gz although the var is present in reproduce: http://logs.openstack.org/43/392943/6/check/gate-tempest-dsvm-ironic-inspector-discovery/eb78693/logs/reproduce.sh13:53
*** d0ugal has quit IRC13:53
* milan wonders what to do about it :-/13:53
*** kamtamtun has quit IRC13:54
dtantsurmilan, check devstack logs, maybe just some typo?13:54
aarefievmilan: yeah, we are initialize  that value before read config file13:55
aarefievit uses default13:55
aarefievI'm trying to figure out how  to fix better13:56
*** lucas-hungry is now known as lucasagomes13:56
aarefiev2 fixes  in 1 patch (13:57
* milan reads devstacklog13:57
mgouldbrb13:57
*** Guest13194 has quit IRC13:58
dtantsuraarefiev, oh, this is a bug for sure13:58
aarefievdtantsur: are you fine if we will declare periodic task  in init method for now13:59
milanaarefiev, you think it's because the plugin is downloaded from http and somehow overrides the job template?13:59
aarefievinspector starts with config value 5, so devstack part is fine13:59
dtantsuraarefiev, I don't think we should move the task itself, rather the default value13:59
* dtantsur looks at the code14:00
*** khamtamtun has joined #openstack-ironic14:00
*** yibo has quit IRC14:00
aarefievit goes to futurist14:00
milanaarefiev, /me rechecks etc14:00
*** anush has joined #openstack-ironic14:00
dtantsurwait, I think I'm confused14:00
dtantsurdo we set configuration value after starting inspector? this is doomed to failure14:01
milanaarefiev, ack, the value is DEFAULT.clean_up_period = 514:01
milanin etc/inspector.conf14:01
dtantsurah, I think I get it14:01
milandtantsur, share please, I'm still figuring out :)14:02
aarefievno we set value from config before start14:02
dtantsurmilan, we use CONF values before we load ironic.conf14:02
aarefievand this is default one14:02
milandtantsur, in the code you mean?14:02
dtantsurmilan, yep14:02
milanOops! :D14:02
dtantsuraarefiev, yeah, I get we have to move periodic tasks to run().. which is bad, but not as bad as what we've got14:03
aarefievhere https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/main.py#L33614:03
aarefievdtantsur: I guess if we split services we could refactor this14:03
aarefievalso 2 fixes in one patch, I don't like this (14:04
* dtantsur too14:04
dtantsurbut I guess it can't be helped14:04
*** ralonsoh_ has quit IRC14:04
*** ralonsoh_ has joined #openstack-ironic14:04
milanaarefiev, +1 the decorator indeed is "compile-time" :-/14:06
milanwhat about if we load the config compile time too?14:06
dtantsurdunno what you're referring to as "compile time".. it just executes earlier14:08
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements  https://review.openstack.org/39379114:08
milandtantsur, outside of the service initialisation; btw where exactly is the conf loaded?14:09
jrollinhatin"import time" :)14:09
*** Goneri has joined #openstack-ironic14:09
jrollinhatinthis is where oslo.config gets painful14:09
dtantsurmilan, so, the default value is calculated at function definition (a weird part of Python), but we load CONF in main()14:10
dtantsurjrollinhatin++ (also cool nick)14:10
jrollinhatinheh, casual nick friday \o/14:10
milandtantsur, yeah, is it this line?14:10
milanhttps://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/main.py#L39014:11
*** baoli_ has quit IRC14:11
*** baoli has joined #openstack-ironic14:11
dtantsurmilan, yep14:11
dtantsuroh, casual nick friday!14:11
*** dtantsur is now known as creepy_owlet14:11
*** khamtamtun has quit IRC14:12
aarefievyeah, we could try to load config in conf.py and import it in main14:12
milanaarefiev, creepy_owlet :) how about we bump the call outside of the service?14:12
milanaarefiev, exactly14:12
*** khamtamtun has joined #openstack-ironic14:12
creepy_owletmilan, then you'll have to move it to the top of the file, which is ugly as well14:12
milancreepy_owlet, would you -2 it right away? :D14:12
milanyeah but might help :D14:12
creepy_owletwell... I don't like code which depends on the order of execution14:12
aarefievhow many new people here :)14:13
creepy_owletimagine someone wants to refator it later14:13
*** e0ne has quit IRC14:13
creepy_owlethaha, new people and animals14:13
milanI'd also prefer Haskell :D14:13
aarefiev:)14:13
lucasagomeshah14:13
*** e0ne has joined #openstack-ironic14:13
*** Guest13194 has joined #openstack-ironic14:13
milanso what to do?14:13
milanI'm +2 on bumping it out of main 0:-)14:14
milansambetts, ^ ?14:14
aarefievmove decorator  to init ?14:14
milanhttps://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/main.py#L390 to conf.py14:14
milanaarefiev, not sure I get you14:14
aarefievhere https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/main.py#L44114:15
sambettsmilan: sorry, i've been focused on a different window, can you TL;DR?14:15
aarefievcall periodic.periiodic14:15
milansambetts, TL;DR we decorate periodics with conf which isn't parsed until service.run in main.py14:15
milansambetts, the reason why the gate is still broken14:15
aarefievsambetts: same issue like in ironic was, maybe you remember14:16
*** mtanino has joined #openstack-ironic14:16
sambettsmilan: ah sigh... this is the same thing we had in ironic too with one of the decorator variables, lucasagomes helped fix it14:16
aarefievyep14:16
milanaarefiev, so you suggest to remove the decorator and configure in init?14:17
openstackgerritMerged openstack/pyghmi: Ignore KeyError on delete of missing sensor  https://review.openstack.org/39377814:17
* milan feels that's too pretty&normal to do ;)14:17
* lucasagomes which we could pass a callback to the decorator14:17
creepy_owletlucasagomes++ we need to fix futurist to allow that14:17
lucasagomesbut yeah, you have to make sure the imports are in a certain order so the methods doesn't get built prior to the config options being evaluated14:18
*** khamtamtun has quit IRC14:18
lucasagomescreepy_owlet, yeah14:18
aarefievcreepy_owlet doesn't like to rely on import order14:18
milanlucasagomes, creepy_owlet that's more obfuscated imo than calling the CONF() explicitly in conf.py14:19
jrollinhatinwhat if (both here and in ironic) we just read config files before even importing things14:19
lucasagomesthat's what we try to do actually, in the service module14:19
creepy_owlethaving code before imports is kind of non-pep814:19
lucasagomesoh14:19
jrollinhatinI care more about working code than pep814:20
creepy_owletI mean, flake8 doesn't fail on it, but still14:20
lucasagomesnow I understand, right, yeah... could work but looks odd14:20
milanjrollinhatin, I'd prefer that, if it's after the conf.py registering of opts etc14:20
jrollinhatinwe have comments for a reason :)14:20
lucasagomesmilan, you can reload() a module too14:20
milanlucasagomes, that's superobfuscated :D14:20
lucasagomeslol14:20
creepy_owletno reload() please >_< I may be fine with running CONF at the very top in the end14:20
jrollinhatincreepy_owlet: +114:20
milanyou can reload even upon periodics execution and rebuild the func on demand with fresh conf every time I guess :D14:21
aarefievmy idea was do this in conf.py , it one of the first import14:21
*** causten has quit IRC14:22
aarefievand leave comment14:22
milanaarefiev, +1 on that, same jrollinhatin suggests14:22
milanI'd vote for that too14:22
lucasagomesyeah I think that would be the nicer way for now14:23
*** causten has joined #openstack-ironic14:23
milanhttps://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/conf.py#L27 seems a cosy place for that CONF call ;)14:23
*** shobhar has joined #openstack-ironic14:24
milanor does it have to be after all the registering?14:24
creepy_owletmilan, rather https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/conf.py#L225 then14:24
aarefievit should be after14:24
milancreepy_owlet, yeah14:24
milanOK14:24
creepy_owletmilan, I wonder how it's going to work with passing args to main() though14:25
aarefievcreepy_owlet: +114:25
milanouch14:25
aarefievyeah14:25
milansys.args? O:-)14:26
*** rajinir has quit IRC14:26
sambettscan we add our own decorator that wraps the futurist one and can wait until the config is parsed?14:26
creepy_owletmilan, I think we use it in functional tests14:26
* milan imagines the cycle of dependencies 14:27
creepy_owletsambetts, ... or just take the value every time the periodic is invoked14:27
*** amotoki has quit IRC14:27
creepy_owletyeah, makes sense14:27
milanbuild the function each time?14:27
*** khamtamtun has joined #openstack-ironic14:27
*** vinsh has joined #openstack-ironic14:27
creepy_owlethmm, yeah, too tricky..14:28
sambettsare we talking about variables pushed into the periodic function or passed into the futurist decorator?14:28
*** khamtamtun has quit IRC14:28
*** ccamacho|lunch is now known as ccamacho14:28
*** jistr is now known as jistr|call14:29
*** jaosorior is now known as jaosorior_mtg14:29
aarefievto futurist  decorator14:29
* milan needs to check futurist decorator14:29
aarefievhttps://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/main.py#L33614:29
*** khamtamtun has joined #openstack-ironic14:29
sambettscreepy_owlet: can we do something like this http://paste.openstack.org/show/587902/14:31
*** jaosorior_mtg has quit IRC14:31
sambettscreepy_owlet: obviously that is very psudo code, but I'm better at python than english ;)14:32
creepy_owletsambetts, this will run once and do nothing14:32
*** jaosorior_mtg has joined #openstack-ironic14:32
creepy_owletotherwise it's nice to somehow delay registration..14:32
creepy_owletsambetts, oh wait!14:32
*** mjura has quit IRC14:32
creepy_owletI think futurist allows adding periodics later on14:32
creepy_owletmmm, but they probably still have to be decorated, hmm14:32
sambettscreepy_owlet: a decorator is just a function, so you can call the futurist decorator like a function, which is what the futurist.periodic_function line is supposed to represent14:33
creepy_owletsambetts, yeah, but you snipped will not run twice..14:34
sambettswhy do we need it to run twice?14:34
sambettsI might have missed something14:34
milansambetts, first, you need to return the decorated func14:35
creepy_owletsambetts, ah, I've confused "while" with "if"14:35
milansecond, that would block the interpreter trying to "compile" the code14:35
sambettsmilan: oh, thats my bad for not adding a return14:35
* creepy_owlet should probably get rid of StackPlague first...14:35
*** khamtamtun has quit IRC14:36
sambettsmilan: the futurist.periodic_function line should have a return14:36
milanyeah but how a decorator can be kept running while you're loading a module that it's generating function in?14:37
milans/while/after14:37
milanand not blocking everything else14:37
* milan tries14:37
milan:D14:37
sambettsmilan: yeah, that I'm not sure about14:37
creepy_owletnote: we're not using real threading, so we need eventlet.sleep at best14:37
sambettscreepy_owlet: yeah14:38
milanone can yield then14:38
milanbut14:38
milanwe need to yield with a tmp function or what14:38
milanand then monkey-patch the module later14:38
creepy_owletanyway, the code which will call that will block14:38
milanhow about the monkey patch?14:38
milanwe could return a dummy14:39
milanand after the thing is configured, monkey patch the dummy14:39
milan?14:39
milancrazy?14:39
* milan feels that way... lack of coffee :P14:39
*** d0ugal_ has quit IRC14:39
*** d0ugal has joined #openstack-ironic14:39
*** d0ugal has quit IRC14:39
*** d0ugal has joined #openstack-ironic14:39
jrollinhatinany time you say monkey patch, trust it is crazy :)14:39
milanjrollinhatin, heh :D14:40
milanjrollinhatin, imho rebuilding the function every time is actually a sort of a hidden monkey patch :D14:40
milanso that should be crazier ;)14:41
jrollinhatinheh14:41
* milan coffee 14:41
aarefievwow, just went out for a moment :)14:41
* creepy_owlet is already fine with moving periodic task creation wherever is needd14:41
milanneed to break the train of crazy ideas in my head :D14:41
aarefievheh14:41
*** rama_y has joined #openstack-ironic14:42
*** fragatina has quit IRC14:42
*** fragatina has joined #openstack-ironic14:42
aarefievcreepy_owlet : and what about dtantsur14:42
sambettshow about something like this http://paste.openstack.org/show/587903/14:43
*** rajinir has joined #openstack-ironic14:43
creepy_owletaarefiev, he's picky, but he seems offline now, so let's quickly approve that14:43
aarefievheh14:44
milanlol14:44
creepy_owletsambetts, not so bad, we can try it14:44
milansambetts, where would the config be read?14:45
sambettsmilan: the config should be passed in the __new__14:46
sambettsmilan: when the futurist decorator is called14:46
*** mgoddard_ has joined #openstack-ironic14:47
milan__new__ is called once ThingWithPeriodics is subclassed?14:47
milanah sry14:47
sambettsmilan: no, __new__ is called before __init__14:47
milannew is there to  manipulate the instantiation, so basically hack the __dict__14:48
milanright?14:48
* lucasagomes thinks the patch switching the ipmitool jobs to xenial is fine now, https://review.openstack.org/392890 (if someone wants to take a peek)14:48
patchbotpatch 392890 - openstack-infra/project-config - Switch some ironic-ipa jobs to Ubuntu Xenial14:48
sambettsbasically, we should probably have a flag in there to ensure that we only create the periodics the first time the class is used14:49
sambettsmilan: ^14:49
aarefievcould we just create wrapped methods before creating PeriodicWorker14:49
*** mgoddard has quit IRC14:50
openstackgerritBob Fournier proposed openstack/ironic-inspector-specs: Add LLDP processing hook and new CLI commands  https://review.openstack.org/37438114:50
milansambetts, and the class would be used as the decorator?14:51
* milan lost14:51
milanor the class is the service in this case?14:52
*** jerrygb_ has joined #openstack-ironic14:52
*** wajdi has joined #openstack-ironic14:54
sambettsmilan: the class is the thing that current has the decorators on its methods14:55
milanI just can't see how it helps :-/14:55
sambettsmilan: it means the functions are only decorating on the first use of the class, not module load14:56
*** mgoddard_ has quit IRC14:56
*** mgoddard has joined #openstack-ironic14:56
sambettsmilan: which we can gurantee is after the config file is loaded14:56
milansambetts, so Service would instantiate that before registering with the worker?14:57
sambettsit will run at the first time someone does Service()14:58
sambettsso we want to load the config file before then14:58
*** jerrygb has joined #openstack-ironic15:01
*** rbrud has quit IRC15:02
*** betherly has quit IRC15:03
*** jistr|call is now known as jistr15:03
*** jerrygb_ has quit IRC15:04
milansambetts, sounds like a self-monkeypatching class but why not15:05
* milan still thinks about it15:05
*** sandriichenko has quit IRC15:05
*** ralonsoh_ is now known as ralonsoh15:09
sambettsmilan: its essentially creating a python metaclass, which is a "normal" thing in python15:10
*** jistr is now known as jistr|biab15:10
milanbut you need the funcs in advance15:10
milanand somehow you need to stetattr with some reasonable name15:10
*** causten has quit IRC15:11
openstackgerritGalyna Zholtkevych proposed openstack/ironic: Migrate to keystone session glance and swift  https://review.openstack.org/35228915:11
sambettsthe subclass of the metaclass that supports periodics just overrides the list_of_periodics, or we can do autodiscovery of the functions to turn into periodics using a decorator similar to the way we use the decorators for vendor_passthru in ironic15:12
* mgould reads the last hour of scrollback15:13
mgouldI am now very confused15:13
NobodyCamGood Morning Ironic'ers15:13
sambettso/ NobodyCam TGIF15:13
mgouldalso, is creepy_owlet the Mr Hyde to dtantsur's Dr Jekyll?15:13
NobodyCamAnd ofc.15:13
mgouldmorning NobodyCam15:13
NobodyCam:)15:13
milansambetts, but the pastebin wasn't a metaclass15:13
NobodyCamLOL ... Morning sambetts mgould milan15:13
milansambetts, it's exactly what I'm thinking about --- how to discover the func15:13
creepy_owletmorning NobodyCam15:13
milanmorning NobodyCam! :)15:14
NobodyCammorning creepy_owlet :)15:14
* creepy_owlet puts what mgould said to google translate15:14
NobodyCamlol :)15:14
openstackgerritMario Villaplana proposed openstack/ironic: Update description of stable states and fix state machine diagram  https://review.openstack.org/39066615:14
creepy_owletdouble translations gives me "Owlet is a terrible Mr. Hyde to dtantsur in Dr. Jekyll"15:14
*** jistr|biab is now known as jistr15:14
sambettsmilan: https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py#L72915:15
creepy_owletnow it has a part I understand: Owlet is a terrible (true, I am)15:15
* milan feels like we're complicating it but unsure how to make it simple15:15
*** wajdi_ has joined #openstack-ironic15:15
openstackgerritHironori Shiina proposed openstack/ironic: Introduce VolumeConnector object  https://review.openstack.org/21458415:15
openstackgerritHironori Shiina proposed openstack/ironic: Introduce new RPCs to support volume connector operation  https://review.openstack.org/21458515:15
openstackgerritHironori Shiina proposed openstack/ironic: [WIP]Add REST API for volume connector and volume target operation  https://review.openstack.org/21458615:15
openstackgerritHironori Shiina proposed openstack/ironic: Introduce new RPCs to support volume target operations  https://review.openstack.org/28522015:15
openstackgerritHironori Shiina proposed openstack/ironic: Introduce VolumeTarget object  https://review.openstack.org/28521915:15
openstackgerritHironori Shiina proposed openstack/ironic: Add volume_targets table to save target information  https://review.openstack.org/28521815:15
openstackgerritHironori Shiina proposed openstack/ironic: Add volume_connector table to save connector information  https://review.openstack.org/20098315:15
sambettscreepy_owlet: dr jekyll and my hyde is a novel about a scientist that has a split personality, one dr jekyll is a good guy, and mr hyde is evil15:16
JayFdidn't he cause his own split with science?15:16
creepy_owlethah, makes sense now!15:16
JayFwouldn't that mean Dr Jekyll wasn't a nice guy at all?!15:17
*** wajdi__ has joined #openstack-ironic15:17
JayFlol15:17
sambettsJayF: yup something like that )15:17
creepy_owletalso morning JayF15:17
sambetts;)15:17
JayFo/15:17
creepy_owletJayF, we might need your hw manager vision on https://review.openstack.org/39183615:17
patchbotpatch 391836 - ironic-python-agent - Add a new Hardware Manager for X710 network card15:17
JayFfun15:17
openstackgerritSergii Nozhka proposed openstack/ironic-inspector: Add a test for introspection abort action verification.  https://review.openstack.org/39382415:18
*** causten has joined #openstack-ironic15:18
*** wajdi has quit IRC15:18
*** wajdi_ has quit IRC15:20
milansambetts, but we don't need that15:21
milanwe could register the funcs while decorating them in the service after having read the conf15:22
*** causten has quit IRC15:22
JayFcreepy_owlet: I reviewed it, pretty good first shot :D15:22
milani.e moving the decorator away from the module15:22
creepy_owletcool! I recommended this direction, wanted to make sure it's not in vain :)15:22
sambettsmilan: thats what my paste does15:22
milanhttps://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/main.py#L44215:23
JayFcreepy_owlet: this is like the A+++ example for an in-tree specific hardware manager15:23
creepy_owletcool!15:23
milansambetts, your paste does more :)15:24
sambettsmilan: does it? do mean just do it in the __init__ instead?15:24
sambettsdo you mean *15:24
openstackgerritVasyl Saienko proposed openstack/ironic-specs: Update ironic-ml2-integration spec  https://review.openstack.org/39366015:24
milansambetts, lemme pastebin15:25
*** rcernin has quit IRC15:25
*** betherly has joined #openstack-ironic15:25
mgouldmilan, sambetts: what problem are you trying to solve? Decorating a function, but only once CONF has been read?15:25
*** rcernin has joined #openstack-ironic15:27
milanmgould, ack15:28
milansambetts, since the service doesn't do any magic w/ discovery of functions but instead keeps hardwired "links" we could just postpone the decoration to that moment: http://paste.openstack.org/show/587907/15:29
mgouldmilan: could you always decorate it, check the CONF value in the decorator, error out if it's not set, and suck up the tiny runtime performance hit?15:29
milanmgould, it's rather default vs conf value15:30
mgouldaaah15:30
milanbut yeah we could do that15:30
milantoo15:30
mgouldso it might be legitimately called in a situation where that conf value isn't set?15:30
sambettsmgould: decorators are processed on module load, so the config file might not be read yet15:31
milannot really, so it's decorated nicely in the module while still being able to change the parameter of the decoration via conf file or sys.argv15:31
mgouldOK15:31
*** absubram has joined #openstack-ironic15:32
mgould"decorate anyway, check the parameter in the body of the decorator" sounds more robust than careful fiddling with evaluation order, but I could be wrong15:32
*** causten has joined #openstack-ironic15:32
milanaarefiev, I think you suggested to kill the decorator in the module and decorate in the service in the very beginning of this discussion, correct?15:33
milanaarefiev, http://paste.openstack.org/show/587907/ < is that similar to what you suggested?15:33
*** Nisha1 has joined #openstack-ironic15:35
*** khamtamtun has joined #openstack-ironic15:35
*** sabeen has joined #openstack-ironic15:36
*** wajdi__ has quit IRC15:36
*** wajdi has joined #openstack-ironic15:37
aarefievmilan: something like that, but you need to make 2 call decorator(a=2)(method)15:38
*** Guest13194 is now known as tesseract-15:38
*** khamtamtun has quit IRC15:38
milanyeah15:39
milanbut that call is up to the worker to perform15:39
milanbut I  might have missed some parts :)15:39
milansambetts, creepy_owlet went guys?15:39
milan*wdyt15:40
* creepy_owlet is out of context, sorry15:40
mgouldcreepy_owlet: I think milan is trying to write Haskell in Python :-)15:40
creepy_owletah, cool15:40
milancreepy_owlet, http://paste.openstack.org/show/587907/ instead of registering the funcs before decorating them in a metaclass15:41
milanmgould, yeah, better 2 lines of Haskell than 50 of a metaclass :P15:41
mgouldlooks relatively sane to me...15:41
creepy_owletmilan, you don't need self.CONF, everything else looks ok15:41
milancreepy_owlet, yeah true15:41
sambettsI say lets give it a go and see how the patch looks, are there any other places in inspector where we decorate periodics15:42
milanwould kill the decorators though in the place of those functions definition15:42
*** wajdi_ has joined #openstack-ironic15:42
milansambetts, ack15:42
mgould+115:43
aarefievsambetts: looks like 2 periodic tasks only15:45
*** wajdi has quit IRC15:45
aarefievmilan: decorator returns new wrapped method, which accept method, we are trying to decorate, as argument15:47
aarefievor I'm missing something15:47
milanaarefiev, yeah, to call a decorated would be decorator(decorated, 1, 2, 3)(*decorated_args, **decorated_kwargs)15:48
milanbut to have the worker process the decorated function the second call is omitted; just the worker might need to pass the *decorated_args, **decorated_kwargs15:49
aarefievmilan: periodics.periodic(spacing=CONF.clean_up_period)(periodic_clean_up)15:50
milanbut as sambetts says, let's review it in a patch15:50
milanaarefiev, aaah15:50
milanaarefiev, yeah15:50
milanaarefiev, +100015:50
milan:D15:50
* milan files a bug15:50
*** athomas has quit IRC15:55
*** rcernin has quit IRC15:56
*** dprince has quit IRC15:58
*** pcaruana has quit IRC15:58
*** tesseract- has quit IRC15:59
*** athomas has joined #openstack-ironic16:01
mgouldaarefiev: hurrah for currying16:01
openstackgerritVasyl Saienko proposed openstack/ironic: Add portgroup to api-ref  https://review.openstack.org/39383416:04
milanaarefiev, creepy_owlet, mgould, sambetts: https://bugs.launchpad.net/ironic-inspector/+bug/163928616:04
openstackLaunchpad bug 1639286 in Ironic Inspector "Periodic tasks configuration not propagated from inspector.conf" [Undecided,New]16:04
aarefievmgould: curry? :)16:05
sambettsaarefiev: https://en.wikipedia.org/wiki/Currying16:06
*** 18VAABSMN has quit IRC16:06
aarefievsambetts: aha, thanks, I didn't know this term16:07
* milan forgotten it already now he has nightmares coming back :P16:07
milanthank you mgould :P16:07
aarefievlearn something new16:07
aarefievmilan: will you fix it ?16:08
milanaarefiev, ack16:08
vsaienk0folks, ironic-multinode stuff is no longer blocked by devstack-gate (yesterday 3 devstack-gate patches were merged). Bash experts please help to review ironic part (6 patches ) https://review.openstack.org/#/q/topic:bug/162265316:08
*** krtaylor has quit IRC16:08
milanI'll try to have it ready till EOD16:08
*** raginbaj- has joined #openstack-ironic16:09
TheJuliavsaienk0: awesome, thank you for the update!16:10
aarefievmilan: thanks, note: gate is still broken, you need my patch :)16:11
*** jaosorior_mtg is now known as jaosorior16:11
aarefievawesome vsaienk016:11
milanaarefiev, so I should rebase it on top of yours?16:11
aarefievmilan: it should be one patch16:12
milanaarefiev, OK16:12
milanaarefiev, so that one wasn't merged yet so I can just post new revision, right?16:13
*** mjturek has quit IRC16:14
aarefievmilan: yeah, we can't land it due this bug16:15
milanaarefiev, ack16:15
* milan hacks16:15
*** dprince has joined #openstack-ironic16:21
aslezilsambetts: as I am trying to write a spec for adding collector for ironic-inspector. The idea is to collect the data from biosdename utility, but biosdevname doesn't have the package for tiny core OS. Is it a good idea to create a package for biosdevname in tiny core OS16:21
openstackgerritVasyl Saienko proposed openstack/ironic: Add portgroup to api-ref  https://review.openstack.org/39383416:22
sambettsaslezil: there are a couple of packages missing from the tinycore linux repo, its quite difficult to get them added too, so for the missing ones we build them from source as part of the tinyIPA build script16:23
JayFsambetts: You are OK with the utility being added though if the build can get done?16:24
JayFI suggested Annie ask you before she went through all the effort to get it built :)16:24
*** sabeen has quit IRC16:25
aslezilsambetts: yeah I saw that few there in build-tinyipa.sh as JayF said is it ok to add there16:25
sambettsJayF: I'd be interested to see how big it is, a few months back someone else tried to add a new utility and it included some v.large lookup tables for vendor IDs to vendor names and products, which added ~20mb to tinyipa, which is currently only ~38mb16:27
creepy_owletpci_devices, I guess?16:27
sambettsyeah16:27
sambettsso we worked around it by moving the ID processing to server side in inspector16:27
JayFI'm seeing how large it is installed on fedora16:28
JayFthat should give some kind of idea I'd hope16:28
*** bnemec is now known as beekneemech16:28
JayF58k for biosdevname, 72k for the lib it installed16:28
JayFso unless there's some giant dependency my fedora already had installed, that seems pretty small16:29
sambettsJayF: sounds reasonable then16:29
*** jcoufal has quit IRC16:29
aslezilSambetts and Jay in that case can I give a try.16:30
*** jcoufal has joined #openstack-ironic16:30
JayFawesome :)16:30
sambettsgreat :D16:30
JayFwill this be the first time you've installed any software from source?16:30
JayFthat was an "oh wow" moment for me back in the day when I started working on linux :P16:30
aslezilyeah JayF: I know I will face lot of issues16:31
JayFI think you'll find it's easier than you expect16:31
aslezilDo you want to report a bug and work on it or try locally first16:31
JayFI mean, this work will all fall under the spec you're writing for the new collector16:32
sambettshehe, the most confusing part of the build is likely to be building it into tinycore linux package, hopefully the examples of how to do it in the build-tinyipa script will help16:32
JayFso I'd still draft that spec first, and while waiting for review, you can science on the building of the package16:32
aslezilJayF: done and sambetts: thank you :)16:33
sambetts:)16:33
* mgould checks the biosdevname build process16:34
mgouldlooks like a standard "./configure; make; make install"16:34
sambettsthe weird bit comes when you are having to do it in a chroot for building the ramdisk16:35
mgouldyeah16:35
JayFthat's what cheating is for16:35
mgouldyou might need to pass some flags to ./configure, maybe?16:35
JayF^c^v the existing code, poke it with a stick until it works for biosdevname16:35
JayFlol16:36
sambettshahaha yup, best way16:36
aslezilhe he16:36
mgouldhttps://www.gitbook.com/book/tra38/essential-copying-and-pasting-from-stack-overflow/details16:36
JayFI only steal code from known trusted developers16:36
JayFlol16:36
*** pester has joined #openstack-ironic16:37
*** shobhar has quit IRC16:37
*** aNuposic has joined #openstack-ironic16:37
sambetts;)16:38
*** pester has quit IRC16:39
*** fxpester has quit IRC16:40
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: Allow to configure cache clean up period  https://review.openstack.org/39294316:41
openstackgerritLucas Alvares Gomes proposed openstack/python-ironicclient: Avoid string interpolation in logging calls  https://review.openstack.org/37634316:41
* lucasagomes just updated the commit message16:42
milanaarefiev, sambetts ^^16:42
milanlet's see what jenkins thinks about it16:43
*** jaosorior has quit IRC16:43
aarefievyeah, do we want to keep decorators ?16:45
milanaarefiev, Oops16:45
* milan removes16:45
aarefievmaybe move to Service16:46
milanthe funcs?16:46
aarefievyep16:46
milanhmmm... but those functions don't require any "state" managed by Service, or?16:47
*** sborkows has quit IRC16:48
aarefievThis is just a thought aloud on Fr evening16:48
aarefiev:)16:48
openstackgerritDmitry Tantsur proposed openstack/ironic: Simplify base interfaces in ironic.drivers.base  https://review.openstack.org/39384816:49
milanaarefiev, :)16:49
creepy_owletfirst weird patch of the driver comp ^^^16:49
mgouldnumber 3 will astound us?16:49
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: Allow to configure cache clean up period  https://review.openstack.org/39294316:49
openstackgerritSergii Nozhka proposed openstack/ironic-inspector: Add a test for introspection abort action verification.  https://review.openstack.org/39382416:50
milanmgould, heh, yeah, I'm worried creepy_owlet taking over the world, initiated by that patch ;)16:51
creepy_owlet\o/16:51
creepy_owletpower to owls!16:51
milan:D16:51
*** mjturek has joined #openstack-ironic16:51
JayFwho? power to who? who?16:52
*** krtaylor has joined #openstack-ironic16:53
mgouldgroan16:53
creepy_owlet:D17:02
openstackgerritDmitry Tantsur proposed openstack/ironic: [WIP] Create noop interfaces for use with hardware types  https://review.openstack.org/39386717:02
*** ralonsoh has quit IRC17:04
*** e0ne has quit IRC17:07
*** e0ne_ has joined #openstack-ironic17:07
*** e0ne_ has quit IRC17:11
*** fragatina has quit IRC17:11
*** jpich has quit IRC17:13
jcookjrollinhatin how do I bump microversion: https://review.openstack.org/#/c/350831/3/ironic/api/controllers/v1/node.py ?17:17
patchbotpatch 350831 - ironic - Add API and conductor methods for [un]rescue17:17
jcookapi version here: https://review.openstack.org/#/c/350831/3/ironic/conductor/manager.py17:17
patchbotpatch 350831 - ironic - Add API and conductor methods for [un]rescue17:17
sambettshaha I like "unrescue" I have visions of people breaking instance deliberately using openstack server unrescue :-P17:19
JayFjcook: there's a good patch up doing it now17:19
JayFjcook: lemme find it17:19
*** e0ne has joined #openstack-ironic17:19
jcookJayF thanks17:19
*** ipukha has quit IRC17:20
JayFactually pretty sure that patch is doing it wrong, so going to find another patch17:20
openstackgerritDmitry Tantsur proposed openstack/ironic: Simplify base interfaces in ironic.drivers.base  https://review.openstack.org/39384817:20
JayFlol17:20
JayFjcook: https://github.com/openstack/ironic/commit/a7310377e27bbce454b8a7a6b943cc5b7a45bbad17:21
*** ChubYann has joined #openstack-ironic17:21
*** ohamada has quit IRC17:23
jcookJayF so it's just a rst update?17:23
*** e0ne has quit IRC17:23
JayFjcook: https://github.com/openstack/ironic/commit/a7310377e27bbce454b8a7a6b943cc5b7a45bbad#diff-fcb18843d1a9ec5117a71319e3d89151R30617:24
JayFsee those guard methods? making sure if you're not a new enough microversion you can't see the new api endpoint17:24
jcookah17:25
JayFhttps://github.com/openstack/ironic/commit/a7310377e27bbce454b8a7a6b943cc5b7a45bbad#diff-c8b579c95b86075825625f02118fe4d0R416 being the guard method itself17:25
jcookcool thanks17:26
JayFno problem, helped me to find an issue in the other review that also is adding a microversion17:29
lucasagomesfolks, calling it a day!17:31
lucasagomeshave a great evening all, enjoy the weekend17:31
sambettso/ lucasagomes17:32
*** lucasagomes is now known as lucas-afk17:32
lucas-afko/17:32
JayFo/17:35
openstackgerritDmitry Tantsur proposed openstack/ironic: [WIP] Create noop interfaces for use with hardware types  https://review.openstack.org/39386717:36
*** d0ugal has quit IRC17:39
openstackgerritSam Betts proposed openstack/ironic: Rework Ironic devstack baremetal network simulation  https://review.openstack.org/39295917:39
JayFsambetts: that patch sounds interesting17:40
JayFsambetts: I suspect you have something in mind though, like what's the next step?17:40
sambettsJayF: basically it remodels the way we simulate the network with the BM/VMs so that it mimics and interactes with neutron like more a real world physical network17:42
JayFsambetts: I'm just saying, this is something that enables folks to do cool things17:42
JayFsambetts: which made me assume you had a cool thing in mind :D17:42
*** jkilpatr has quit IRC17:42
*** jkilpatr has joined #openstack-ironic17:43
sambettsJayF: ;) right now we're working pretty hard to get the rest of the multitenancy stuff done like bonding and trunks etc so it makes it much nicer to work with17:44
openstackgerritDmitry Tantsur proposed openstack/ironic: [WIP] Support defining and loading hardware types  https://review.openstack.org/33662617:44
creepy_owletok, enough for today, see you on Monday :)17:44
JayFah17:44
sambettsJayF: also it should reduce the hackyness of our grenade plugin too17:44
JayFso like actaully being able to bond interfaces in vms17:44
JayFfor instance17:44
JayFbecause it's just a linux bridge you could emulate stuff like that17:44
JayF(maybe? Can you? I'm now curious...)17:44
*** creepy_owlet is now known as dtantsur|afk17:44
sambettsJayF: OVS lets to do it so we'll be using that for the virtual switch, but we'll be using a separate OVS bridge from the ones given to neutron to prevent stomping on toes17:45
JayFah, okay17:45
JayFI might take reviewing that patch as an opportunity to understand how that works better17:46
*** mjturek has quit IRC17:46
JayFright now I treat it mostly as magic which is a copout given I actually know a lot about linux networking17:46
*** srobert has joined #openstack-ironic17:46
openstackgerritMerged openstack/python-ironicclient: Avoid string interpolation in logging calls  https://review.openstack.org/37634317:46
sambettsits a little bit of a mad patch because its replacing a bunch of hacky stuff :) but I personally hope it actually results in a simpler devstack script and a less hacky simulation17:47
sambettsI also hope to make it easier for people like myself to hook up real hardware networks so we don't have to do too much extra plumbing in our third party CI job scripts17:48
mgouldsambetts: sounds cool17:50
mgouldhaving read the commit message, I'd like to double down on that statement :-)17:56
*** Sukhdev has joined #openstack-ironic17:58
sambettsmgould: thanks :) I hope it lives up to expectations ;)17:59
*** harlowja has quit IRC18:00
*** Nisha1 has quit IRC18:01
sambettsmgould: I've tested it locally but I'm waiting to see what jenkins says ;)18:02
*** mjturek has joined #openstack-ironic18:03
mgouldI have an ironic node, with values set in properties/cpus, properties/local_gb and properties/memory_mb18:03
*** harlowja has joined #openstack-ironic18:03
mgouldhowever, nova hypervisor-show [uuid] thinks it has 0 cpus, 0 ram and 0 disk18:04
mgouldhow can I fix that?18:04
sambettsmgould: it can take a couple of minutes for that information to sync18:04
mgouldah, OK18:04
* mgould cracks another beer while he's waiting18:04
sambettsmgould: how long has it been sync you setup the ironic node?18:04
sambettss/sync/since*18:05
mgouldnot sure, but several minutes18:05
*** dougs1 has quit IRC18:05
sambettsmgould: hmm ok, normal time to sync is ~2mins, the other thing to check for is if the node validates, you can check by doing ironic node-validate <uuid/name>18:06
mgouldah, lots of validation failures18:06
mgouldmissing ramdisk, kernel and image_source parameters in instance_info18:07
sambettsthats expected, becuase nova will add those18:07
mgouldOK18:07
sambettsyou'll looking for things like missing credentialls or ramdisk kernel/ramdisk etc18:07
sambettsyour*18:07
mgouldhttp://paste.openstack.org/show/587922/18:08
openstackgerritVasyl Saienko proposed openstack/ironic: Add portgroup to api-ref  https://review.openstack.org/39383418:08
sambettsI was about to say, and your paste has just confirm this for me, the next thing to check is the nodes state, it needs to be in avaiable, and not in maintenance to advertise resources to nova, your node is in managable18:09
*** links has joined #openstack-ironic18:10
mgouldaaargh18:10
mgouldthanks!18:10
sambetts:D18:10
*** links has quit IRC18:10
mgouldOK, so now I wait a couple of minutes for the info to propagate to nova, and then I can nova boot?18:11
sambettsyup18:11
mgouldcool18:11
openstackgerritSukhdev Kapur proposed openstack/ironic: Add support for Security Groups for baremetal servers  https://review.openstack.org/36145118:11
sambettsknowing the steps to work through all comes with experience debugging :) thats why we've started writing some of them up in the docs18:11
mgouldah, I see that's point #3 in http://docs.openstack.org/developer/ironic/deploy/troubleshooting.html, which my eyes had skipped over :-/18:12
sambetts:-P18:12
* mgould runs "nova boot"18:13
sambettsSukhdev: QQ, on the security groups patch, what happens if a user sets port_security_enabled=False on the provisioning network, but still configures a security group in the config file??18:14
sambettsSukhdev: I hadn't had a chance to reply yet, but thats what I meant by my question on the patch18:14
Sukhdevsambetts : where is port_security_enabled set?18:16
jcookJayF stupid question, how do I run the Ironic unit tests. I know I've ran them local before but either something in the tree changed or I'm have a neural failure and it's not popping out at me18:16
sambettsSukhdev: on the neutron network, its one of its properties18:17
JayFjcook: tox -epy2718:17
jcookJayF that should totes be in the README18:17
jcookJayF thanks18:17
Sukhdevsambetts : oh I see - now I understand the question.18:17
Sukhdevsambetts : that flag supercedes18:18
*** harlowja has quit IRC18:18
sambettsSukhdev: if that is set to false, and we try to set a security group on it, will it error?18:18
sambettsSukhdev: do we need to catch that in ironic?18:19
Sukhdevsambetts : hang on there are two flags - we are talking about two flags18:19
*** daemontool has quit IRC18:19
Sukhdevsambetts : I check for one flag in the ML2 and that superceeds - I think you are talking about yet another flag18:20
sambettsYes there is a flag on the network: https://wiki.openstack.org/wiki/Neutron/ML2PortSecurityExtensionDriver18:20
sambettsand there is a flag on the port18:20
sambettsI was wondering if we need to check for the flag on the network in Ironic, and if it'll error if we try to use a security group when security groups are disabled18:22
sambettsI think it might error, because it used to be a bug in Nova, that even if security groups were disabled it would try to force one on, resulting in a failure to create an instance18:23
Sukhdevsambetts : In ML2 driver, if the vnic_type is baremetal, I ignore this flag18:23
sambettsSukhdev: its not at that stage that it needs the check, its at the port update/create18:24
Sukhdevsambetts : right - if one disables that flag and then specifies --security-group as a parameter to nova boot - it will error out -18:25
sambettsSukhdev: and i think the same thing will happen in ironic, if the flag is disabled, but secuirty groups are configured in ironic18:26
sambettsdo we treat that as a configuration error and error out all the deployments, or check the flag and throw a warning instead18:26
Sukhdevsambetts : so, there are two things here -18:27
Sukhdevsambetts : 1) security groups for tenant networks and18:27
Sukhdev2) for admin networks (provisioning and cleaning) -18:28
sambettsright, I'm talking about provisioning and cleaning networks18:28
Sukhdevfor 1) we are good - and do not need to anything additional18:28
*** betherly has quit IRC18:28
*** johnthetubaguy has quit IRC18:28
openstackgerritMerged openstack/ironic-python-agent: Updated from global requirements  https://review.openstack.org/39379118:28
*** johnthetubaguy_ has joined #openstack-ironic18:28
Sukhdevfor 2, the network as well as security groups are created by the admin -18:29
Sukhdevwhy would they create security groups and then set them to disable -18:29
*** johnthetubaguy_ is now known as johnthetubaguy18:30
Sukhdevhowever, if they do, in my present implementation, I honor the configured security groups (if they are configured)18:30
sambettsSukhdev: 2 different operators that don't talk to each other/disables it at a later date but doesn't want to shutdown ironic to remove the configured security groups18:30
Sukhdevsambetts: I see your point18:30
*** harlowja has joined #openstack-ironic18:30
sambettsSukhdev: neutron won't let the port create happen if that flag is disabled and security groups is in the port body18:31
sambettsSukhdev: thats the error we need to catch or avoid18:31
sambettsso it'll error in the configure_provision_network function18:31
Sukhdevsambetts: right18:32
milansambetts, mind a second w+2+ https://review.openstack.org/#/c/392943/18:32
patchbotpatch 392943 - ironic-inspector - Allow to configure cache clean up period18:32
milan?18:32
milanseems we might have a fix for Inspector gate :D18:32
sambettsmilan: :D18:32
milanthaks to dtantsur|afk18:32
milanfor first +218:32
mgould\o/18:33
milanaarefiev, \o/ :)18:33
sambettsSukhdev: /me -> home now, but we should continue this conversion on Monday in the meeting18:33
sambettsGood night all18:34
Sukhdevsambetts : wait a minute - Is this flag available to operators to set?18:34
mgouldsambetts: good night, have a good weekend!18:34
Sukhdevsambetts : good night18:34
milannight sambetts! :)18:34
sambettsSukhdev: hmm I think so18:34
sambettsSukhdev: I have set it before for stuff I think18:34
*** sambetts is now known as sambetts|afk18:35
sambetts|afko/ Sukhdev, milan, mgould18:35
Sukhdevsambetts|afk : I will check - you have a good night18:35
* mgould gets another No Valid Host error, but I'm pretty sure this one's legit and means "you need to write some code now" :-)18:36
mgouldgnite all, have a good weekend!18:37
*** mgould is now known as mgould|afk18:37
milangood night mgould|afk! :)18:37
* milan out too18:37
milangood night Ironic! :)18:37
*** milan has quit IRC18:38
*** sabeen has joined #openstack-ironic18:42
*** jerrygb has quit IRC18:45
*** jerrygb has joined #openstack-ironic18:45
*** jkilpatr has quit IRC18:50
*** causten has quit IRC18:59
jcookhmm, ironic.tests.unit.api.v1.test_nodes is using the latest microversion19:01
rajinirNeed help with using non-default image for the thirdparty builds, other than cirros. Any idea what the variables ?     Any help or pointers? krtaylor: Sambetts:19:01
rajinirI have these set but they didn't quiet work as I expected19:02
rajinirhttps://www.irccloud.com/pastebin/9xFK1zCr/ironic-image19:02
jrollinhatinjcook: you can pass different versions e.g. https://github.com/openstack/ironic/blob/master/ironic/tests/unit/api/v1/test_nodes.py#L15019:03
*** marlinc has quit IRC19:03
*** jkilpatr has joined #openstack-ironic19:04
jcookjrollinhatin oh, IC. I was confused by RPC version be 1.35 and api version being 2419:06
jrollinhatinmmm19:06
jcookso I should just have to pass 1.2419:06
jrollinhatinyep19:07
jcookjrollinhatin the same test file is passing versions of 1.4 and such, but max version is 1.2419:08
jrollinhatinjcook: yes, we test various versions here19:09
jrollinhatinfor various reasons19:09
JayFfor instance you might wanna add a test confirming that resceu *doesn't* work for an older microversion19:10
JayFright?19:10
jcookbut 1.4 is > 1.24 the max version19:10
jrollinhatinis it?19:10
JayFnot 1.2.419:10
JayF1.419:10
jrollinhatinis 4 > 24?19:10
JayF4 < 2419:11
jrollinhatin1.4 != 1.40 :)19:11
jcookoh...thanks lol19:11
jrollinhatinjcook: think of it as (1, 4) < (1, 24)19:11
jrollinhatinthat's the actual comparison we use in python19:11
jcookyeah, I got it heh19:11
jcook(-‸ლ)19:12
jrollinhatin:D19:12
jrollinhatinthat's interesting though, I wonder how many people hit that wall19:12
jcookcounting is hard19:12
jcookso yay, that fixed it19:13
*** jerrygb has quit IRC19:14
*** jerrygb has joined #openstack-ironic19:16
*** shobhar has joined #openstack-ironic19:19
openstackgerritJesse J. Cook proposed openstack/ironic: Add API and conductor methods for [un]rescue  https://review.openstack.org/35083119:20
*** jvgrant__ has joined #openstack-ironic19:24
jrollinhatinokay, I think I mostly have trello sorted: https://trello.com/b/ROTxmGIc/ironic-newton-priorities19:26
jrollinhatinrather, https://trello.com/b/ROTxmGIc/ironic-ocata-priorities19:27
jrollinhatin(both links will work)19:27
*** jvgrant_ has quit IRC19:27
jrollinhatinneeds some assignees, tags, etc, but everything should be there and most should be up to date19:27
*** jcoufal has quit IRC19:28
openstackgerritMerged openstack/ironic-inspector: Allow to configure cache clean up period  https://review.openstack.org/39294319:30
*** fragatina has joined #openstack-ironic19:44
*** marlinc has joined #openstack-ironic19:45
openstackgerritOleksandr Berezovskyi proposed openstack/ironic-python-agent: Add possibility to inspect systems with multiple CPUs  https://review.openstack.org/39129019:52
*** srobert_ has joined #openstack-ironic20:00
*** srobert has quit IRC20:01
*** jerrygb_ has joined #openstack-ironic20:01
*** fragatina has quit IRC20:03
*** jerrygb has quit IRC20:05
*** e0ne has joined #openstack-ironic20:05
*** jerrygb_ has quit IRC20:06
*** vinsh has quit IRC20:06
*** vinsh has joined #openstack-ironic20:06
*** dprince has quit IRC20:12
*** rbudden_ has joined #openstack-ironic20:22
*** kvcobb has joined #openstack-ironic20:22
*** rbudden has quit IRC20:23
*** rbudden_ is now known as rbudden20:23
*** jkilpatr has quit IRC20:25
*** athomas has quit IRC20:25
*** krtaylor has quit IRC20:27
kvcobbGood afternoon, Folks. I'm having an issue with spinning up an Ironic instance. Wondering if someone has seen this before, so I spin up an instance with my BM flavor selected. The server powers down, gets set for PXE, powers back up, sees PXE and gets the deploy image and ramdisk, shortly after it fails with these errors in the conductor logs: http://paste.openstack.org/show/587940/ Anybody see that before? This a problem with the20:27
kvcobbimages I created (I build my image with the partition image instructions rather than whole disk))?20:27
*** derekh has joined #openstack-ironic20:27
*** shobhar has quit IRC20:28
*** shobhar has joined #openstack-ironic20:28
*** oberezovskyi has joined #openstack-ironic20:33
*** jjohnson2 has quit IRC20:36
*** oberezovskyi has quit IRC20:42
*** zzzeek_ has joined #openstack-ironic20:46
*** jkilpatr has joined #openstack-ironic20:46
*** zzzeek has quit IRC20:48
*** jheroux has quit IRC20:57
*** ijw has joined #openstack-ironic21:01
*** srobert_ has quit IRC21:04
*** sabeen has quit IRC21:11
*** absubram has quit IRC21:13
*** shuquan has joined #openstack-ironic21:18
*** shuquan has quit IRC21:23
*** mattcburns has joined #openstack-ironic21:24
*** jrollinhatin is now known as jroll21:36
*** snozhka has quit IRC21:39
*** sdake has joined #openstack-ironic21:42
*** jerrygb has joined #openstack-ironic21:51
*** mxburns has joined #openstack-ironic21:52
*** jerrygb has quit IRC21:56
*** wajdi has joined #openstack-ironic21:57
*** derekh has quit IRC21:58
*** wajdi_ has quit IRC22:00
*** wajdi has quit IRC22:01
*** derekh has joined #openstack-ironic22:09
*** snozhka has joined #openstack-ironic22:11
openstackgerritFélix Bouliane proposed openstack/ironic: WIP- Add virtualpdu to ironic devstack plugin  https://review.openstack.org/38815422:14
*** e0ne_ has joined #openstack-ironic22:17
*** e0ne has quit IRC22:21
*** bfournie has quit IRC22:29
*** rajinir has quit IRC22:36
*** sdake has quit IRC22:37
*** sdake has joined #openstack-ironic22:40
*** aNuposic has quit IRC22:50
*** jerrygb has joined #openstack-ironic22:52
*** jerrygb has quit IRC22:58
*** ppiela has quit IRC23:06
*** bfournie has joined #openstack-ironic23:29
*** mattcburns has quit IRC23:30
*** rama_y has quit IRC23:35
*** mtanino has quit IRC23:35
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-inspector: Updated from global requirements  https://review.openstack.org/39273123:50
*** sabeen has joined #openstack-ironic23:56
*** Nisha1 has joined #openstack-ironic23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!