Thursday, 2016-11-03

*** hw_wutianwei has joined #openstack-ironic00:02
*** bfournie has joined #openstack-ironic00:53
*** phuongnh has joined #openstack-ironic00:59
*** vinsh has quit IRC01:02
*** jkilpatr has quit IRC01:04
*** [1]cdearborn has quit IRC01:05
*** hoangcx has joined #openstack-ironic01:06
*** rloo has quit IRC01:06
*** tuanluong has joined #openstack-ironic01:19
*** maratoid_ has quit IRC01:24
*** jerrygb_ has joined #openstack-ironic01:30
*** vinsh has joined #openstack-ironic01:30
*** jerrygb has quit IRC01:31
*** jerrygb has joined #openstack-ironic01:45
*** jerrygb_ has quit IRC01:45
*** zhangyufei has joined #openstack-ironic01:51
*** jerrygb has quit IRC01:59
*** jerrygb has joined #openstack-ironic01:59
*** shobhar has quit IRC02:00
*** zhangyufei has quit IRC02:01
*** Sukhdev has quit IRC02:15
*** jerrygb has quit IRC02:17
*** jralph_ has quit IRC02:17
*** jerrygb has joined #openstack-ironic02:18
*** shobhar has joined #openstack-ironic02:21
*** jerrygb has quit IRC02:22
*** jralph has joined #openstack-ironic02:23
*** chihhsin has quit IRC02:29
*** vinsh has quit IRC02:51
*** awiddersheim has quit IRC02:51
*** awiddersheim has joined #openstack-ironic02:53
*** rbudden has joined #openstack-ironic02:58
*** jerrygb has joined #openstack-ironic02:59
*** vinsh has joined #openstack-ironic03:04
*** sabeen has joined #openstack-ironic03:11
*** shobhar has quit IRC03:15
*** baoli has quit IRC03:17
*** rbudden has quit IRC03:18
*** vikrant has joined #openstack-ironic03:25
*** g3ek has quit IRC03:27
*** g3ek has joined #openstack-ironic03:29
*** shobhar has joined #openstack-ironic03:46
*** shobhar__ has joined #openstack-ironic03:49
*** shobhar has quit IRC03:49
*** jerrygb has quit IRC03:59
*** jerrygb has joined #openstack-ironic04:01
*** Nisha has joined #openstack-ironic04:01
*** links has joined #openstack-ironic04:01
*** Nisha is now known as Guest1085904:01
*** sabeen has quit IRC04:01
*** sabeen has joined #openstack-ironic04:05
*** yogi has joined #openstack-ironic04:18
*** syed_ has joined #openstack-ironic04:22
*** absubram has joined #openstack-ironic04:23
*** absubram_ has joined #openstack-ironic04:24
*** Guest10859 is now known as Nisha104:26
*** vinsh has quit IRC04:27
*** jerrygb_ has joined #openstack-ironic04:28
*** absubram has quit IRC04:28
*** absubram_ is now known as absubram04:28
*** jerrygb has quit IRC04:29
*** shobhar__ has quit IRC04:34
*** jerrygb has joined #openstack-ironic04:44
*** jerrygb_ has quit IRC04:45
*** absubram has quit IRC04:46
*** jerrygb_ has joined #openstack-ironic04:59
*** jerrygb has quit IRC04:59
*** rama_y has quit IRC04:59
*** rama_y has joined #openstack-ironic05:00
*** sabeen has quit IRC05:11
*** jerrygb_ has quit IRC05:15
*** jerrygb has joined #openstack-ironic05:15
*** jerrygb has quit IRC05:33
*** jerrygb has joined #openstack-ironic05:33
*** jerrygb has quit IRC05:33
*** openstackgerrit has quit IRC05:48
*** openstackgerrit has joined #openstack-ironic05:48
*** shuquan has joined #openstack-ironic05:50
*** shuquan has quit IRC06:05
*** shuquan has joined #openstack-ironic06:07
*** vinsh has joined #openstack-ironic06:27
*** vinsh has quit IRC06:33
*** mgoddard has quit IRC06:40
*** yolanda has joined #openstack-ironic06:51
*** yolanda_ has joined #openstack-ironic06:51
*** yolanda_ has quit IRC06:52
*** rbartal has joined #openstack-ironic06:55
*** fxpester has joined #openstack-ironic06:58
*** jtomasek has joined #openstack-ironic07:01
*** syed_ has quit IRC07:05
*** Nisha1 has quit IRC07:07
*** Nisha1 has joined #openstack-ironic07:07
*** pester has joined #openstack-ironic07:09
*** fxpester has quit IRC07:12
*** shuquan has quit IRC07:14
*** tesseract has joined #openstack-ironic07:14
*** tesseract is now known as Guest2520907:14
*** milan has joined #openstack-ironic07:28
*** jaosorior has joined #openstack-ironic07:28
milanmorning Ironic! :)07:29
*** shuquan has joined #openstack-ironic07:30
*** jerrygb has joined #openstack-ironic07:34
*** rcernin has joined #openstack-ironic07:34
*** jerrygb has quit IRC07:39
*** jtomasek_ has joined #openstack-ironic07:41
*** jtomasek has quit IRC07:41
*** moshele has joined #openstack-ironic07:42
*** milan has quit IRC07:43
*** openstackgerrit has quit IRC07:48
*** shuquan has quit IRC07:48
*** openstackgerrit has joined #openstack-ironic07:48
*** g3ek has quit IRC07:52
*** fragatina has joined #openstack-ironic07:53
*** fragatina has quit IRC07:53
*** fragatina has joined #openstack-ironic07:53
*** ccamacho has joined #openstack-ironic07:54
*** shuquan has joined #openstack-ironic07:58
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-ironic08:00
*** g3ek has joined #openstack-ironic08:00
*** penick has joined #openstack-ironic08:01
*** penick has quit IRC08:04
*** milan has joined #openstack-ironic08:05
*** Nisha1 has quit IRC08:17
*** vsaienk0 has quit IRC08:18
milanaarefiev, morning! I'm staring into the discovery logs, wondering what's going on... do you already have some theory?08:21
*** shuquan has quit IRC08:21
*** athomas has joined #openstack-ironic08:22
*** shuquan has joined #openstack-ironic08:23
*** gcb has quit IRC08:27
*** gcb has joined #openstack-ironic08:28
*** vsaienk0 has joined #openstack-ironic08:29
*** ralonsoh has joined #openstack-ironic08:37
*** Nisha1 has joined #openstack-ironic08:37
*** ralonsoh has quit IRC08:38
*** ralonsoh has joined #openstack-ironic08:38
*** rama_y has quit IRC08:41
*** rama_y has joined #openstack-ironic08:41
*** ohamada has joined #openstack-ironic08:51
*** jpich has joined #openstack-ironic08:54
*** aparnav has joined #openstack-ironic08:56
*** shuquan has quit IRC08:58
*** jtomasek_ is now known as jtomasek09:02
*** _milan_ has joined #openstack-ironic09:04
*** milan has quit IRC09:04
*** amotoki has quit IRC09:04
aarefievmorning!09:05
*** mjura_ has joined #openstack-ironic09:06
aarefievmilan: hey, yeah I have09:06
*** shuquan has joined #openstack-ironic09:06
aarefievour infra became pretty fast09:06
_milan_aarefiev, hey09:07
_milan_yup09:07
_milan_so seems the ramdisk is faster than the sync :-/09:07
*** ChubYann has quit IRC09:07
_milan_aarefiev, ^ correct?09:07
aarefievyep09:07
* _milan_ got disconnected a bit here09:07
aarefievhttps://review.openstack.org/#/c/392943/09:07
patchbotpatch 392943 - ironic-inspector - Allow to configure cache clean up period09:07
_milan_aarefiev, ack09:08
aarefievpropose new option09:08
* _milan_ would +2 it already09:08
_milan_but wanted to test in devstack09:08
_milan_which is failing for me09:08
_milan_*local devstack :-/09:08
* _milan_ 's OS fault09:08
aarefievwe need project config patch is merged first09:08
_milan_aarefiev, patch link handy?09:09
aarefievI think about 15 sec period09:09
_milan_aarefiev, I'd make it less09:09
aarefievpatch is on way09:09
_milan_the diff is 30s09:09
*** chihhsin has joined #openstack-ironic09:09
aarefievthere was default 60 sec09:09
aarefievand it works09:09
aarefievworked09:09
aarefievheh09:09
aarefievmaybe 10 sec09:09
_milan_http://logs.openstack.org/43/392943/4/check/gate-tempest-dsvm-ironic-inspector-discovery/3705288/logs/screen-ironic-inspector.txt.gz#_2016-11-02_21_17_18_44209:10
_milan_not even 30 in my case09:10
_milan_not even 20 :D09:10
_milan_hell09:10
_milan_16 if I'm counting OK?09:10
_milan_I'd vote for a sync of 5s :D09:10
*** gcb has quit IRC09:11
_milan_aarefiev, ^09:11
aarefievI'm fine with 5 sec too09:11
_milan_ack09:11
aarefievdoesn't matter here, it's hacky test09:12
_milan_yeah09:12
*** gcb has joined #openstack-ironic09:13
* _milan_ worried about our logic though --- if it's missing in ironic but present in inspector we blow it up :-/09:13
_milan_not 100% sure it's correct09:13
_milan_aarefiev, went?09:13
_milan_*wdyt09:13
aarefievit was in ironic and we deleted it09:14
aarefievit found it first and then it's missing09:14
aarefievmany it09:14
aarefievinspector09:14
_milan_aarefiev, so test deletes the node from Ironic, correct?09:15
aarefievyeah09:15
_milan_but the sync doesn't propagate the change to inspector in time, correct?09:15
aarefievit is before yesterday :)09:16
_milan_yeah :) so inspector still tracks stale record that is missing in ironic already when the introspection data arrives, correct?09:16
*** portdirect_away is now known as portdirect09:19
aarefievso inspector receives introspected data, it's looking for node, found it09:19
aarefievthen sync delete node from cache09:19
* _milan_ checks logs09:19
aarefievand inspector has split brain09:20
_milan_aarefiev, the sync didn't even run in my case http://logs.openstack.org/43/392943/4/check/gate-tempest-dsvm-ironic-inspector-discovery/3705288/logs/screen-ironic-inspector.txt.gz#_2016-11-02_21_17_34_33209:21
_milan_sync in my case is 15 sec later from ^09:22
*** lucas-afk is now known as lucasagomes09:22
lucasagomesmorning all09:22
_milan_morning lucasagomes! :)09:22
aarefievmorning lucasagomes09:22
aarefiev_milan_: yeah, so whats here09:23
aarefievinspector found node http://logs.openstack.org/43/392943/4/check/gate-tempest-dsvm-ironic-inspector-discovery/3705288/logs/screen-ironic-inspector.txt.gz#_2016-11-02_21_17_34_31809:23
aarefievbefore error09:23
_milan_aarefiev, so in my case it seems 1) node deleted in Ironic 2) data arrives to inspector  3) inspector finds the node in cache 4) inspector fails to match cache with ironic and blows up the introspection09:23
_milan_* discovery09:24
aarefievso, yeah, same races09:24
_milan_yup race09:24
*** xek has quit IRC09:24
* _milan_ worried that it is a bug actually09:25
_milan_aarefiev, do you think we should blow up in case of the inconsistency if we're discovering?09:25
_milan_shouldn't inspector push the data to ironic?09:25
*** roeyc has joined #openstack-ironic09:26
aarefiev_milan_: it's how our test works, it was expected09:26
aarefievthat it will fail one day09:26
* _milan_ reminds himself of the IT joke: there are just 2 big challenges: naming, cache consistency and off by 1 errors ;) 09:26
aarefievyeah :)09:27
* _milan_ checks processing.py09:27
aarefievif we will add some notifications to ironic, we can notify inspector about deleted node and don't rely on sync09:29
_milan_aarefiev, so in my case, since https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/process.py#L96 isn't manifested in the log, the plugin isn't triggered at all, yeah, not sure what to do besides bumping up the sync frequency... not a bug09:29
_milan_aarefiev, notification +109:29
_milan_but that's racy anyway as there might be other issues :D09:30
aarefievyeah, we are running inspection on node and then delete it and assume it's new node09:30
*** dtantsur|afk is now known as dtantsur09:30
dtantsurMorning Ironic09:30
aarefievmorning dtantsur09:30
_milan_morning dtantsur! :)09:30
*** derekh has joined #openstack-ironic09:31
openstackgerritDmitry Tantsur proposed openstack/ironic: API: lookup() ignore malformed MAC addresses  https://review.openstack.org/39318809:33
dtantsurlucasagomes, cherry-picked ^^^09:33
*** jerrygb has joined #openstack-ironic09:35
lucasagomesdtantsur, thanks09:36
*** jerrygb has quit IRC09:41
*** jaosorior is now known as jaosorior_lunch09:41
pas-hamorning Ironic09:43
aarefievmorning pas-ha09:44
*** jpich has quit IRC09:45
aarefiev_milan_ : https://review.openstack.org/#/c/393193/109:45
patchbotpatch 393193 - openstack-infra/project-config - Decrease cache sync time in inspector discovery job09:45
aarefievif dtantsur agree ^09:45
dtantsuraarefiev, I can't find the variable you're referencing in this patch09:46
aarefievdtantsur: sorry, it's new https://review.openstack.org/#/c/392943/409:47
patchbotpatch 392943 - ironic-inspector - Allow to configure cache clean up period09:47
* _milan_ checks09:47
dtantsuraarefiev, ok, please use depends-on to indicate relationship09:47
dtantsuroh, I see, there's chicken-and-egg problem here...09:48
aarefievyeah09:48
_milan_dtantsur, exactly :D09:48
aarefievwe need infra patch first09:48
*** jpich has joined #openstack-ironic09:49
aarefievwhat happen with infra09:50
* _milan_ +1 09:50
aarefievwhy it's so fast09:50
_milan_yeah, good question :D09:51
pas-hakvm?09:51
_milan_dtantsur, fyi in my case introspection took 16s :D09:51
aarefievha, was that patch merged?09:51
* _milan_ didn't follow kvm stuff for infra09:51
pas-harecently merged to ironic to use nested kvm where available09:52
pas-haafaik yes09:52
_milan_and hi pas-ha! :)09:52
aarefievI see now :)09:52
pas-hahi _milan_09:52
*** shuquan has quit IRC09:52
_milan_oh ya! nested kvm \o/ :D09:52
pas-habut 16s is still suspiciously low as to me09:52
*** shuquan has joined #openstack-ironic09:53
_milan_pas-ha, I'm fine with that, otherwise we'd have to have a sync of 1s for our discovery test to run09:57
pas-haotoh, just rebuilt devstack, and virtual bm node just booted super-fast :-O09:58
*** jerrygb has joined #openstack-ironic09:58
*** shuquan has quit IRC09:59
*** jerrygb has quit IRC10:03
*** shuquan has joined #openstack-ironic10:05
*** [1]cdearborn has joined #openstack-ironic10:13
*** mgoddard has joined #openstack-ironic10:14
TheJuliaGood morning everyone10:17
lucasagomesTheJulia, hi there10:18
_milan_morning TheJulia! :)10:18
_milan_TheJulia, what time is it for you atm?10:18
TheJulia6:18 AM10:19
_milan_wow10:19
_milan_11:19 here and I could sleep  ;)10:19
TheJuliaI've actually been up for about two hours, remnants of stackplague :(10:20
*** hoangcx has quit IRC10:20
dtantsurmorning pas-ha, aarefiev, TheJulia10:20
lucasagomesoh, that sucks :-/10:20
_milan_oh, sorry TheJulia10:20
dtantsuryeah...10:21
TheJuliaBut I actually feel moderately human so far today10:21
dtantsurcool! I felt better yesterday :(10:22
_milan_TheJulia, get better soon!10:22
* _milan_ wonders what the stackpleague might actually be, seems it's not flu, that would be faster 10:23
sambetts|afkMorning all10:23
*** sambetts|afk is now known as sambetts10:23
_milan_morning sambetts! :)10:23
sambettshey milan10:23
*** _milan_ is now known as milan10:23
TheJulia_milan_: many people I know who got sick had gotten their yearly flu vaccine in the last couple months.  I suspect it is just a run of the mill headcold that is able to take hold due to stress and the airplane travel.10:24
*** shuquan has quit IRC10:24
*** roeyc has quit IRC10:25
openstackgerritMerged openstack/bifrost: Enable upper requirements on bifrost  https://review.openstack.org/39182810:25
* milan wishes there was a vaccine for that10:25
* milan opens http://www.commoncold.org/understand.htm10:26
dtantsurmorning sambetts10:27
*** Nisha1 has quit IRC10:27
dtantsurTheJulia++ that's what I assume too10:27
sambettso/ dtantsur, TheJulia10:27
*** mgould|afk is now known as mgould10:29
TheJuliatl;dr I think we need to move gatherings to nice tropical beaches where we can all have extended stays10:29
*** vinsh has joined #openstack-ironic10:29
milanTheJulia, +100010:29
* milan loves pina colada :D10:29
openstackgerritGalyna Zholtkevych proposed openstack/ironic: ETAG supporting to enhance API evolution  https://review.openstack.org/39221310:29
mgouldTheJulia: AIUI flu vaccines only protect against whichever strains are predicted to be nastiest that winter, but there are lots of others10:30
TheJuliaI would <3 a pina colada right now10:30
mgouldbut yeah, probably just a nasty cold :-(10:30
TheJuliamgould: that is my understanding as well10:30
*** moshele has quit IRC10:32
*** vinsh has quit IRC10:34
sambettsI think its what we call in the UK "Freshers Flu" which is the cold/flu/illness that everyone gets during the first week of university because your suddenly thrown into a pool of people from all over the place with all their alien germs10:34
lucasagomesdtantsur, quick q: In project config those excludes do not accept a regex/wildcard right ? Like, we have agent_ssh and pxe_ssh I think we probably need to exclude both from xenial. It would be nice to be able to do "driver: '*_ssh;"10:36
* lucasagomes might be asking too much10:36
* milan freaks out: alien germs taking over this planet ;)10:36
dtantsurlucasagomes, I think they don't10:36
lucasagomesyeah I couldn't find any example10:36
sambettslucasagomes: I have found that in project config it only realises its a regex if it begins with ^ and ends with $10:37
sambettslucasagomes: maybe give that a go10:37
lucasagomessambetts, oh, lemme check10:37
mgouldsambetts: I think that's what happened to me on the way back from Kyrgyzstan10:39
mgouldtravelled through Istanbul airport, full of people from all over the world travelling to or from the Hajj, when I was already tired10:40
*** links has quit IRC10:40
mgouldhence my somewhat delayed return to work :-(10:41
sambetts:(10:42
* milan 's devstack got sick too10:43
*** moshele has joined #openstack-ironic10:43
milananyone successfully running devstack on a Fedora host?10:43
*** tuanluong has quit IRC10:43
lucasagomesmilan, I did it before the summit I think, on f2410:44
sambettsmilan: nope ubuntu 16 here10:44
* milan git pulled and now cries10:44
milanfor some reason, /etc/ dirs get created with myself as the owner instead of stack10:45
sambetts:/10:45
milancp: cannot create regular file '/etc/keystone/policy.json': Permission denied10:45
milanyeah10:45
milandevstack influenza10:45
sambettsI always use a ubuntu vm with the main user called stack so I don't think i'd see that anyway10:46
milan sudo install -d -o mkovacik /etc/keystone10:46
milanthat's what the log says10:46
milansambetts, so you sudo stack then ./stack.sh?10:46
sambettsmilan: no, I just create the VM with the main user as stack10:47
milansambetts, ah ok10:47
TheJuliabcornec: I took a look at 391593, I think you just need to nuke the explicit gate definition, but I'm by no means an expert on it10:48
* milan will try w/ stack user; -> lunch ->10:49
mgouldmilan: I tend to run devstack on centos10:49
sambettsmilan: doing sudo su stack would probably work too, but I don't think you should need to do it :/10:49
milansambetts, that was my understanding too10:49
milanmgould, I suppose all is well there ;)10:49
milanmgould, you run as you or as stack?10:49
mat128good morning guys10:50
milanmorning mat128! :)10:50
TheJuliaI need to fire up a fresh devstack10:50
dtantsurmorning mat12810:50
lucasagomesmilan, you are following: http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack ?10:50
lucasagomesright ?10:50
milanlucasagomes, heh, so I have to sudo -u stack it10:52
milanmust be the hunger!10:52
* milan runs away before lucasagomes finds more issues :P10:53
milanthanks lucasagomes :)10:53
* milan gone food10:54
*** milan has quit IRC10:54
*** phuongnh has quit IRC11:02
TheJuliadtantsur: I may have proposed something a little crazy on https://review.openstack.org/#/c/184653/15/specs/approved/ironic-redfish.rst@92 :)11:02
patchbotpatch 184653 - ironic-specs - Propose Redfish support into Ironic11:02
* dtantsur likes crazy proposals11:02
mat128TheJulia: not sure I like having validate modify driver_info, but we'll see how others react11:03
TheJuliaI'm not exactly a fan of it either11:03
mgouldmilan: as stack11:04
mgouldand yeah, it seems to work fine11:04
mat128TheJulia: maybe there cant be any default for this value?11:04
TheJuliabut if it is a single node, recording it would kind of make sense.  driver_internal_info is another possibility, but users can't change that11:04
TheJuliamat128: I think that would make dtantsur and myself sad. :)11:04
mgouldI thought we were holding off supporting redfish until it's feature-complete?11:05
dtantsurTheJulia, we can cache it locally in a conductor even11:05
TheJuliaWell, they released 1.011:05
*** Nisha1 has joined #openstack-ironic11:05
dtantsurTheJulia, the only thing I don't like it using validate() for that, as it's always synchronous11:05
mat128TheJulia: maybe we can default to "the" system if we find only and exactly 1 entry?11:05
mgouldTheJulia: right, but bcornec was saying that it's still missing stuff we need and hence encouraging incompatible vendor extensions to breed11:05
dtantsurmgould, well, we can't support inspection and raid11:06
TheJuliamgould: what dtantsur said11:06
mgouldOK, cool11:06
dtantsurbut it seems like we can support power and management without vendor extensions11:06
mat128mgould: tbh I dont even think redfish will solve that vendor extensions problem11:06
* dtantsur neither11:06
TheJuliamgould: possibly, but I would hate to see multiple api exchanges to take any action.11:06
TheJuliaany single action that is11:06
mat128TheJulia: there is no way around it, unless you can tell redfish "operate on the default system"11:07
mgouldmat128: so I was arguing with bcornec about this at the summit11:07
TheJuliaI don't think it will solve it, as vendors are vendors, but this actually fits in as base interfaces for driver composition later :)11:07
mgouldI'd be happy-ish with a default way of asking "which set of vendor extensions do you support?"11:07
TheJuliamat128: Well, if we can do it once and store it somehow, and validation seems to be the logical place as that would provide a nice error back to the user enrolling the node11:08
mat128mgould: but then you'd get "hp-ilo-kvm-console", "dell-idrac-console"11:08
mat128all different :(11:08
mgouldthe nightmare I want to avoid is http://esr.ibiblio.org/?p=80111:08
TheJuliadtantsur: your right though, it is synchronous.... :\11:08
dtantsurTheJulia, well, we can just do it on every request, but with local caching, I guess11:08
mat128TheJulia: so validate() should ensure the thing works, but we cant rely on validate having run to cache the value11:08
mgould"I need to use vendor extensions, and I don't know which ones are available, so I have to cleverly infer what I'm dealing with"11:08
TheJuliadtantsur: Do we really really want to add caching layer?11:09
*** mmedvede has quit IRC11:09
TheJuliamat128: well, most validate calls actually just check that the values are present, because it is a synchronous call11:09
dtantsurTheJulia, well, I don't see anything particularly bad in caching the URL for a few minutes. I don't see anything too bad in NOT caching either.11:09
sambettsso we went through a similar discuss to this with the oneview guys11:10
mat128dtantsur, TheJulia: caching and the caching ttl can be configureable I guess11:10
sambettsbasically we decided to add a periodic task that cached the information, then validation only ever read the cached information11:10
TheJuliamat128: I guess I'm hoping to avoid things like cache invalidation issues :)11:10
TheJuliasambetts: I thought they were storing all of the data, interesting.11:11
*** mjturek has quit IRC11:11
mat128sambetts: so validate fails until the task runs?11:12
mat128not sure I'd like to have more of those "add node to ironic, wait for nova's tasks to run, then boot"11:12
*** absubram has joined #openstack-ironic11:13
TheJuliavalidate would be a nice way to force it, then again power validation could just do the same thing, and the power state checking is a periodic task in ironic.11:13
TheJuliamat128: That makes sense, so then your waiting twice :\11:13
sambettsTheJulia: they wanted the validation for the "is this node used by someone outside of Ironic?" use case, but that meant making a external call on validation, so adding a pretty regular periodic tasks that populated a internel field on the node that was like "used=True/False" then validation look at that11:14
*** absubram_ has joined #openstack-ironic11:14
TheJuliasambetts: ahh, yes!11:14
mat128mgould: omg that GPS link... never knew it was such a nightmare11:14
TheJuliasambetts: I was thinking purely in memory, not driver_internal_info11:14
dtantsurTheJulia, mat128, I see it more like the URL is not mandatory during validation, but if it's not provided, then on every power operation we fetch the first system URL and use it (with optional caching)11:15
mgouldmat128: ikr?11:15
mat128mgould: all I knew was "oh, simple NMEA strings, text protocol -- I've seen worse"11:15
mat128but when you dig into it.. omg11:15
mgouldmat128: yeah11:16
mgouldI think they started with a protocol designed for a very different use-case, and extended it in multiple, incompatible, stupid ways11:16
*** dprince has joined #openstack-ironic11:16
mat128mgould: "That is, unless you buffer, in which case the altitude you see could be up to one second stale and associated with a previous fix."11:17
sambettsits similar to the LLDP type 127 for vendor extensions, basically every vendor value is 127, then they use vendor specifc sub-types and sub-sub-types to indicate what they actually mean11:17
mat128mgould: that explains why altitude displayed on my car's GPS is always late by a second or two11:17
mgouldmat128: aaaargh11:17
mat128TIL I guess11:17
*** absubram has quit IRC11:17
*** absubram_ is now known as absubram11:17
mat128dtantsur: I like your idea11:18
mat128dtantsur: calls that need it will go fetch it11:18
mat128and we can tackle on caching if reqd11:18
mgouldmat128: and why I've had to spend time on cold mountain summits waiting for the altitude reading to settle :-)11:18
TheJuliadtantsur: I think that would work stored in an internal field, I just worry that someone might break something by changing settings in the controller, but if they do that, there is really not much we can do.11:18
mat128mgould: :P11:18
dtantsuryep..11:18
mat128TheJulia: if they know they're going to do this often, they can lower the TTL and/or disable caching11:19
mat128wdyt?11:19
sambettsthe devstack plugin's are branched right??11:19
TheJuliaI guess the other thing is if it multiple systems behind the redfish url, power sync check could fail fast11:19
mat128sambetts: they're in-tree, so yeah11:19
mat128TheJulia: what will "systems" look like irl?11:20
mat128like subsystems within the machine?11:20
sambettsmat128: so's the tempest plugin, but we always run the plugin from master against all versions of Ironic @_@11:20
mat128hmm11:20
TheJuliamat128: each system is a distinct path in systeminventory, which is /redfish/v1/Systems/11:20
mat128TheJulia: what I mean is, in a typical machines what will /Systems look like11:20
mgouldsambetts, mat128: the tempest folks want us to move the tempest plugin out into a new branchless ironic-tempest-plugin repo11:20
TheJuliaso actions upon it would be /redfish/v1/Systems/firstandonlysystem11:21
sambettsmgould: yeah, didn't know if the same thing for devstack or not, I assume no?11:21
mgouldbecause tempest is really a cloud-smoketester that does CI as a hobby11:21
vdrokgood morning everyone! dtantsur lucasagomes mgould sambetts TheJulia mat12811:21
mat128sambetts, mgould: I guess tempest has code to discover features and fail gracefully if they're not present?11:21
mgouldsambetts: dunno about devstack, sorry11:21
mat128o/ vdrok11:21
TheJuliamat128: I believe it is an object that is returned listing the inventory of machines known to the controller11:21
lucasagomesvdrok, hi there!11:21
TheJuliagood morning vdrok11:21
mgouldmat128: that's the whole point of tempest :-)11:21
mat128TheJulia: Sorry I phrased it wrong, I got that11:22
dtantsurmorning vdrok11:22
mat128TheJulia: I mean, will I only see a single system in there for a typical 1U server?11:22
mgouldmorning vdrok11:22
TheJuliamat128: I believe so yes11:22
mat128TheJulia: i.e. was this for chassis with blades?11:22
mat128ok11:22
TheJuliamat128: pulling up the spec for the protocol11:22
dtantsurmat128, "tempest has code to discover features and fail gracefully if they're not present" no. you have to set it in configuration and pray :/11:22
*** mmedvede has joined #openstack-ironic11:22
TheJuliamat128: basically, yes, it was built with carriages/blades in mind11:22
mat128dtantsur: ooh11:22
mat128TheJulia: ok, so we're more likely to see a single entry there11:23
mat128thats good11:23
mgoulddtantsur: AIUI, tempest is meant to perform tests according to reported API versions supported11:23
*** jkilpatr has joined #openstack-ironic11:24
dtantsurmgould, API versions is not everything. or rather: it's nearly nothing :)11:24
mgouldWIP summit notes, search for "Tempest": https://www.dropbox.com/home/lj?preview=ocata_summit.md11:24
mgoulddtantsur: OK, the tempest folks seem to have a higher opinion of API versions than you11:25
mat128mgould: not sure we can read this11:25
mat128mgould: I think you have to get a "share url"11:25
mgouldmat128: sorry, try https://www.dropbox.com/s/xwvk1g93s71ejys/ocata_summit.md?dl=011:25
sambettssigh... /me has just run into the symantics of "ironic network interface" vs "network interface used for ironic"11:25
mgoulddtantsur: seriously, I spent a lot of time talking to dmellado at the summit trying to make sure I had this straight11:26
dtantsurmgould, well, API versions don't tell us which nova backend supports what.. they're only discussion reporting such capabilities11:26
mat128mgould: and... no search in Dropbox ui :(11:26
mgouldmat128: gah! scroll down to "Thursday"11:26
*** jerrygb has joined #openstack-ironic11:26
mgoulddtantsur: can you talk me through a test you want to run?11:27
mgouldI think the answer is going to be "don't use tempest", but I think I need a concrete example to think about11:27
jrollsambetts: yes, devstack is branched thus devstack plugins are branched11:27
jrollmorning :)11:28
*** awiddersheim has quit IRC11:28
mgouldmorning jroll11:28
sambettsjroll: awesome, then I don't have to worry about certain API things not existing while I write the plugin right?11:28
mgouldbtw, what's the standard thing to do with summit notes? ML, blog post, /dev/null?11:28
dtantsurmgould, well, from tempest point of view we should be able to not use some features when it uses the ironic backend11:29
dtantsurmorning jroll! I plan on dracclient release pretty soon btw11:29
jrollsambetts: right11:29
sambetts\o/11:29
TheJuliamat128: https://www.dmtf.org/standards/redfish if you want to bulk load the data into your brain and then let a background process try and parse it :)11:29
jrolldtantsur: wanna race between that release and dropping it from governance? :)11:29
mgoulddtantsur: I +Wed a bunch of stuff in dracclient last night, but you probably saw that11:29
jrolldtantsur: (which means we can't use the releases repo (yet))11:29
TheJuliagood morning jroll11:29
jroll\o TheJulia11:30
mgoulddtantsur: riiiiiiight11:30
mat128TheJulia: I've seen that before when I wanted to write a simulator for it (not knowing it was already in the works) and it was way too abstract for me to even simulate a real machine11:30
mat128o/ jroll11:30
*** AlexeyAbashkin has quit IRC11:30
*** links has joined #openstack-ironic11:30
mgouldso this is a "can't use existing tempest tests against Ironic" problem, not a "can't test the Ironic API with Tempest" problem11:30
TheJuliamat128: Yeah, that. :(11:30
dtantsurjroll, right. I'd prefer to do it the easy way, as doing it manually is going to be fun with signing, etc11:30
jrollmorning mat128, mgould, sambetts, dtantsur, anyone else I didn't say hi to yet11:31
mat128mgould: I read through your notes and it was a great (short) read. I suggest you post it to the ML and ask others to do the same :)11:31
jrolldtantsur: yeah, you can go first :)11:31
mgouldmat128: thanks! I'll try to do that this afternoon :-)11:31
dtantsurcool11:31
openstackgerritAnton Arefiev proposed openstack/ironic-inspector: Allow to configure cache clean up period  https://review.openstack.org/39294311:32
*** roeyc has joined #openstack-ironic11:32
*** AlexeyAbashkin has joined #openstack-ironic11:35
openstackgerritJulia Kreger proposed openstack/ironic: Add volume_connector table to save connector information  https://review.openstack.org/20098311:35
openstackgerritAnton Arefiev proposed openstack/ironic-inspector: Allow to configure cache clean up period  https://review.openstack.org/39294311:35
openstackgerritVasyl Saienko proposed openstack/ironic: DNM: Test patch to verify bond  https://review.openstack.org/38866011:37
openstackgerritVasyl Saienko proposed openstack/ironic: Ironic devstack portgroup support  https://review.openstack.org/38174311:37
openstackgerritVasyl Saienko proposed openstack/ironic: Rely on portgroup standalone_ports_supported  https://review.openstack.org/36064711:37
openstackgerritVasyl Saienko proposed openstack/ironic: Tempest tests for portgroups  https://review.openstack.org/38247611:37
openstackgerritVasyl Saienko proposed openstack/ironic: Add PortGroups API  https://review.openstack.org/34754911:37
openstackgerritVasyl Saienko proposed openstack/ironic: Integrate portgroups with ports to support LAG  https://review.openstack.org/33217711:37
mgouldmat128: I'm having real difficulty finding actual routes in the Redfish API schema :-(11:40
bfourniemorning ironic11:40
dtantsurmorning bfournie11:41
TheJuliamgould: that was my complaint to bcornec11:42
bfourniemorning dtantsur11:42
mgouldTheJulia: is it input to some REST-API building tool?11:42
TheJuliaI think so yes :(11:42
mgouldbah11:43
mgouldstill useful if it can also generate some basic tests we can use, mind11:43
TheJuliaThere is XML structural representations out there as well for that purpose, I think what put some of it together for me mentally was the in-progress conversion stuff they are building11:43
TheJulias/conversion/translation/11:43
*** jaosorior_lunch is now known as jaosorior11:44
*** AlexeyAbashkin has quit IRC11:49
*** AlexeyAbashkin has joined #openstack-ironic11:50
openstackgerritLucas Alvares Gomes proposed openstack/ironic: DevStack: Support for creating UEFI VMs  https://review.openstack.org/37434611:55
openstackgerritLucas Alvares Gomes proposed openstack/ironic: DevStack: Configure nodes/environment to boot in UEFI mode  https://review.openstack.org/37498811:55
*** aparnav has quit IRC11:55
*** rbrud has joined #openstack-ironic12:00
*** bfournie has quit IRC12:00
openstackgerritMerged openstack/python-ironic-inspector-client: Updated from global requirements  https://review.openstack.org/38993812:00
*** bfournie1 has joined #openstack-ironic12:02
*** krypto has joined #openstack-ironic12:03
*** xavierr has joined #openstack-ironic12:04
openstackgerritMerged openstack/bifrost: playbooks: Do not serialize ironic deployment  https://review.openstack.org/38907912:04
*** Nisha1 has quit IRC12:04
openstackgerritMerged openstack/bifrost: Don't include openstack/common in flake8 exclude list  https://review.openstack.org/39170312:04
*** absubram has quit IRC12:06
dtantsurjroll, I still plan on applying http://governance.openstack.org/reference/tags/assert_supports-upgrade.html to ironic-inspector. What does Ironic have for "A procedure for general upgrades of the project is defined and does not change substantially from cycle to cycle."?12:09
jrolldtantsur: http://docs.openstack.org/developer/ironic/deploy/upgrade-guide.html12:09
dtantsuraha! I guess I'll cargo-cult it to inspector docs, and then apply for the tag12:10
jroll:)12:10
*** cdaniel has joined #openstack-ironic12:11
dtantsurjroll, btw it does not mention ordering with IPA12:13
dtantsurdo we expect IPA to usually be upgraded before or after ironic{,-inspector}?12:14
jrolldtantsur: we try to support both, we only test ironic upgrade first12:14
jrolls/first/before IPA/12:14
dtantsurinteresting, I guess that's what we should recommend then12:15
sambettsmy spec for IPA versioning should include testing n-1 and n+112:15
* dtantsur thinks what should be upgraded first: ironic or ironic-inspector12:16
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: Document upgrade procedure  https://review.openstack.org/39327512:18
dtantsursambetts, jroll, wdyt ^^^12:18
jrolluno momento12:19
sambettsdtantsur: looks good, we'll have to always make sure new ironic inspector interface works with old inspector though12:20
sambettsdtantsur: so we'll not be able to add a feature to ironic inspector interface for at least a cycle12:20
sambettsfor example the manage_boot API12:21
dtantsurmmmmmm12:21
*** yogi has quit IRC12:22
dtantsurwell, we should be careful to use API discovery or something similar. or just not enable new features by default12:22
sambettsyeah, we'll have to ping inspector API version in ironic or something12:22
sambettspin*12:22
dtantsurI think we do already12:23
sambettsor have a warning on a config option that like "don't turn this on unless your inspector is greater than this version"12:23
dtantsuryeah12:23
*** nicodemos has joined #openstack-ironic12:25
*** ralonsoh_ has joined #openstack-ironic12:30
*** jerrygb has quit IRC12:30
nicodemosgood morning, ironicers. =D12:30
sambettso/ nicodemos12:31
*** ralonsoh has quit IRC12:32
nicodemoshey, sambetts. \o12:32
*** lucasagomes is now known as lucas-hungry12:35
*** daemontool has joined #openstack-ironic12:37
*** hw_wutianwei has quit IRC12:41
*** dtantsur is now known as dtantsur|brb12:41
*** jheroux has joined #openstack-ironic12:43
openstackgerritSam Betts proposed openstack/ironic: Rework Ironic devstack baremetal network simulation  https://review.openstack.org/39295912:44
*** rbudden has joined #openstack-ironic12:48
*** syed_ has joined #openstack-ironic12:49
*** ccamacho is now known as ccamacho|lunch12:49
*** baoli has joined #openstack-ironic12:54
*** david-lyle has quit IRC12:55
*** baoli_ has joined #openstack-ironic12:56
*** baoli has quit IRC13:00
*** rbartal has quit IRC13:01
*** mjturek has joined #openstack-ironic13:04
*** jcoufal has joined #openstack-ironic13:04
*** mjturek has quit IRC13:08
*** rloo has joined #openstack-ironic13:09
*** jerrygb has joined #openstack-ironic13:10
*** rbartal has joined #openstack-ironic13:13
mgouldmat128: just posted my notes to the ML13:14
mgouldadded a sentence or two about each session, so they're no longer as short :-(13:14
*** vikrant has quit IRC13:15
*** ppiela has joined #openstack-ironic13:19
*** jerrygb_ has joined #openstack-ironic13:21
*** jerrygb has quit IRC13:22
*** milan has joined #openstack-ironic13:22
*** mjturek has joined #openstack-ironic13:22
*** Alexey_Abashkin has joined #openstack-ironic13:27
openstackgerritAline Bousquet proposed openstack/ironic: Add possibility to remove chassis_uuid from a node  https://review.openstack.org/39055813:28
*** Goneri has joined #openstack-ironic13:29
*** dtantsur|brb is now known as dtantsur13:30
*** AlexeyAbashkin has quit IRC13:30
rloohi and morning all ironic'ers. (that reminds me, have to give feedback on angry bear)13:31
nicodemosmorning, rloo.13:31
dtantsurmorning rloo13:32
rlooalineb: i saw you just updated 390558. I want to make sure you saw the comment i added just as you updated.13:32
rloohi nicodemos, dtantsur, mgould13:32
rlooalineb: thx for rebasing13:32
alinebrloo: yes, i just saw your comment: thanks for pointing that out, i will update the patch13:34
rloothx alineb!13:34
alinebrloo: regarding your question, the code does allow to change chassis_uuid and to create a node without one13:34
*** lucas-hungry is now known as lucasagomes13:35
rlooalineb: ok, i couldn't remember. so the version is just for removing/unsetting it - just need to document that. thx.13:35
openstackgerritVasyl Saienko proposed openstack/ironic: Cleanup hung iscsi session  https://review.openstack.org/38809213:35
alinebrloo: ok, thanks a lot for your comments!13:35
rlooalineb: yw :)13:36
rlooalineb: sorry we didn't see you in barcelona13:36
openstackgerritJulia Kreger proposed openstack/ironic: Introduce VolumeConnector object  https://review.openstack.org/21458413:36
openstackgerritJulia Kreger proposed openstack/ironic: Introduce new RPCs to support volume connector operation  https://review.openstack.org/21458513:37
openstackgerritJulia Kreger proposed openstack/ironic: Add volume_targets table to save target information  https://review.openstack.org/28521813:37
alinebrloo: yes, it would have been great to go, maybe next summit :)13:39
rlooalineb: yes!13:39
aarefievmorning rloo13:40
rloohi aarefiev!13:40
aarefievdtantsur: we can discover current  inspector api version, right?13:41
dtantsuraarefiev, we can, yes13:41
aarefievwhat if check it before calling inspector13:41
aarefievand rollback to previous one13:42
aarefievin case not supported13:42
milanmorning alineb, nicodemos, rloo! :)13:42
*** krtaylor has joined #openstack-ironic13:44
dtantsuraarefiev, that's what I call API discovery, yes13:45
rloohiya milan13:45
openstackgerritAline Bousquet proposed openstack/ironic: Add possibility to remove chassis_uuid from a node  https://review.openstack.org/39055813:45
milanguys, anyone seeing this in devstack:  cp: cannot stat '/opt/stack/nova/etc/nova/policy.json': No such file or directory13:49
* milan tries tox -egenpolicy with no luck13:49
*** amotoki has joined #openstack-ironic13:50
aarefievdtantsur: is there issues with it now?13:51
aarefievwhy not using it13:51
*** links has quit IRC13:52
*** shuquan has joined #openstack-ironic13:53
*** pcaruana has joined #openstack-ironic13:53
dtantsuraarefiev, we never had to yet13:53
dtantsurthe manage_boot case will be the first13:54
aarefievok, I think we need to do it before land manage_boot feature13:56
openstackgerritMichael Turek proposed openstack/ironic: Enable PXE for systems using petitboot  https://review.openstack.org/18598713:57
*** jerrygb has joined #openstack-ironic13:57
*** shuquan_ has joined #openstack-ironic13:58
*** shuquan has quit IRC13:59
openstackgerritVasyl Saienko proposed openstack/ironic: Cleanup hung iscsi session  https://review.openstack.org/38809213:59
mgouldmorning rloo14:00
sambettsTheJulia: when using ironic standalone how do you manage the DHCP configuration for PXE?14:00
*** anush has joined #openstack-ironic14:00
*** jerrygb_ has quit IRC14:00
TheJuliasambetts: we explicitly point all pxe booting clients to the initial pxe script which if memory serves upgrades them to ipxe, ipxe is replied to with the ipxe script14:01
dtantsursambetts, mind checking https://review.openstack.org/374381 again please when you have a minute?14:03
patchbotpatch 374381 - ironic-inspector-specs - Add LLDP processing hook and new CLI commands14:03
sambettsTheJulia: so you have a pxe all rule not per mac address, I guess you rely on the cleanup stage of the pxe boot interface to prevent the node re-pxeing into the ramdisk ?14:03
sambettsdtantsur: sure14:04
rloodtantsur (or anyone else that recalls microversions, i know dmitry loves them). don't we raise exception.NotAcceptable if a request is made with the 'wrong' microversion? https://review.openstack.org/#/c/347549/36..37/ironic/api/controllers/v1/portgroup.py14:05
patchbotpatch 347549 - ironic - Add PortGroups API14:05
mgouldrloo: yep14:06
jrollrloo: we raise what makes the most sense - e.g. here we do NotFound because in lower versions that's what you would get14:06
dtantsurrloo, usually. except for the case that confuses you: when a completely new endpoint is introduced14:06
dtantsurrloo, that was raised on the lookup API patches too: https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/ramdisk.py#L98-L9914:07
mgouldwe also raise NotAcceptable in a few other situations :-(14:07
dtantsurI can say a lot of nasty things about trying to fix all possible API errors in a very limited set of HTTP codes..14:07
rloojroll, dtantsur: oh, honestly, it doesn't make sense to me what we return. i just thought that we always returned NotAcceptable for mcroversion-related changes.14:08
mgouldah, wait, maybe not14:08
dtantsurrloo, I used to think the same :)14:08
rloodtantsur: it was so much easier to remember one rule. i wonder if we've messed things up now.14:08
mgouldthe thing I thought was a non-microversion use was actually checking microversions internally14:09
rloo(that's what we get for not documenting these things)14:09
jrollrloo: part of the point of microversions is to keep from changing behavior in a given version14:09
rloojroll: then why would we ever return NotAcceptable?14:09
dtantsurwelcome to the confused-by-microversions camp, rloo :)14:10
rloojroll: Bad Request would make more sense14:10
rloodtantsur: i was always in that camp; just wanted to be a team player though :)14:10
openstackgerritVasyl Saienko proposed openstack/ironic: DNM: Test patch to verify bond  https://review.openstack.org/38866014:10
openstackgerritVasyl Saienko proposed openstack/ironic: Ironic devstack portgroup support  https://review.openstack.org/38174314:10
openstackgerritVasyl Saienko proposed openstack/ironic: Rely on portgroup standalone_ports_supported  https://review.openstack.org/36064714:10
openstackgerritVasyl Saienko proposed openstack/ironic: Tempest tests for portgroups  https://review.openstack.org/38247614:10
jrollrloo: I really don't remember why we decided NotAcceptable was the best thing to do for many of the changes14:10
dtantsurjroll, well, what else?14:11
dtantsurBad Request is fine, but too broad14:11
jrolldtantsur: right, I don't disagree14:11
jrollrloo asked why NotAcceptable, I don't recall14:11
dtantsurin particular, returning a specific code for versioning issues allows for some heuristic on client side14:11
dtantsur... which we break by returning NotFound :(14:11
rloo^^ which is why i thought we were always using NotAcceptable14:12
jrollmmm.14:12
rloo(although we could be nice and add a message why something isn't acceptable... i think that is a TODO...)14:12
dtantsuryeah.. though ironicclient actually composes a nice message itself14:12
rlooi thought there was some xproject microversion spec but didn't find it. was wondering if it was mentioned elsewhere.14:13
dtantsurrloo, there used to be. I think only some smaller part was merged14:13
rlooanyway, jroll, dtantsur: you are good with NotFound in the portgroup case? i don't want to hold that patch up.14:13
TheJuliasambetts: Technically I guess we do, although any default failure with bifrost pxe boots the agent for inspector usage14:13
dtantsurrloo, unfortunately, this is consistent with the lookup and heartbeat, so yes. I am.14:13
jrollrloo: yes14:13
vsaienk0rloo, it was decided with devananda to return NotFound() when we perform call to endpoint that shouldn't exist in old version14:14
rloodtantsur: i think it is inconsistent with the RAID ones :-(14:14
TheJuliasambetts: sorry for the delay responding, on another computer working on expense report stuffs14:14
rloo vsaienk0: sigh. we should document these things.14:14
dtantsurwe've screwed up V1, let's drop it this cycle!!114:14
sambettsTheJulia: hehe same14:14
rloodtantsur: i'm on it!14:14
sambettskill it with fire14:14
*** shuquan_ has quit IRC14:15
vsaienk0rloo document where?14:15
TheJuliasambetts: I don't think I've ever been someplace that had such a desire for cash transactions14:15
*** mtanino has joined #openstack-ironic14:15
TheJuliavdrok: tribal-knowledge.rst?14:15
sambettsTheJulia: I know its crazy... so many reciepts to track14:15
TheJuliaerr14:15
TheJuliavsaienk0:14:15
rlooTheJulia: more like, we don't have dev docs on microversions :-(14:15
TheJuliarloo: hmmmmmm14:16
rlooTheJulia: eg, yesterday JayF was asking *when* something needed a version bump14:16
TheJuliacontextual documentation to communicate how/why we leverage ?14:16
*** jaosorior has quit IRC14:17
TheJuliayeah, that was tribal context at some point in the past, and has been debated many times here in IRC.  We should have documented it in something, anything even a manifesto if needed. :(14:17
* dtantsur would love to see a spec *before* jumping into implementing something like that14:17
* dtantsur is probably just too naive14:17
*** vinsh has joined #openstack-ironic14:18
*** shobhar_ has joined #openstack-ironic14:20
rloovsaienk0: I +2'd the portgroup patch but ... i think the release notes ought to be updated.14:22
*** yolanda has quit IRC14:22
*** yolanda has joined #openstack-ironic14:23
openstackgerritVasyl Saienko proposed openstack/ironic: DNM: Test patch to verify bond  https://review.openstack.org/38866014:27
openstackgerritVasyl Saienko proposed openstack/ironic: Ironic devstack portgroup support  https://review.openstack.org/38174314:27
openstackgerritVasyl Saienko proposed openstack/ironic: Rely on portgroup standalone_ports_supported  https://review.openstack.org/36064714:27
openstackgerritVasyl Saienko proposed openstack/ironic: Tempest tests for portgroups  https://review.openstack.org/38247614:27
openstackgerritVasyl Saienko proposed openstack/ironic: Add PortGroups API  https://review.openstack.org/34754914:27
openstackgerritVasyl Saienko proposed openstack/ironic: Integrate portgroups with ports to support LAG  https://review.openstack.org/33217714:27
*** absubram has joined #openstack-ironic14:28
vsaienk0rloo: just uploaded a new version14:30
*** sabeen has joined #openstack-ironic14:30
rloothx vsaienk0!14:32
*** krypto has quit IRC14:33
*** yolanda has quit IRC14:33
*** sabeen has quit IRC14:35
rlooyuriyz, JayF: if you have time to review 347549 today? maybe we can +A it.14:35
yuriyzhi rloo ironic will do today14:36
rlooyuriyz: thx. btw, wrt notifications, is the coding done?14:37
*** sabeen has joined #openstack-ironic14:37
yuriyzrloo only provision states, CRUD etc in progress14:37
* mariojv will re-review provision state today14:38
rlooyuriyz: oh. i think i meant, is the coding ready to be reviewed :)14:38
*** yolanda has joined #openstack-ironic14:38
rlooyuriyz: oh, wait, i am confused. got it now.14:38
*** athomas has quit IRC14:39
*** livelace has joined #openstack-ironic14:39
dtantsurjroll, have you seen anything like https://bugs.launchpad.net/ironic/+bug/1637210 ?14:40
openstackLaunchpad bug 1637210 in Ironic "Conductor's periodic tasks stops executing" [Undecided,New]14:40
openstackgerritFélix Bouliane proposed openstack/ironic: DONOTMERGE-change IRONIC_DEPLOY_DRIVER to pxe_snmp  https://review.openstack.org/38816814:41
*** ccamacho|lunch is now known as ccamacho14:42
*** athomas has joined #openstack-ironic14:46
*** shobhar_ has quit IRC14:47
jrolldtantsur: no, I have not O_o14:49
dtantsurstrange...14:50
jrollsambetts: hey, nova attach/detach BP is fine without a spec, they'd like the ironic spec merged before approving it, so let's get that done next week14:50
openstackgerritLucas Alvares Gomes proposed openstack/ironic: DevStack: Fix standard PXE on Ubuntu Xenial  https://review.openstack.org/39335314:50
sambettsjroll: oh awesome :D14:51
sambettsjroll: thanks for chasing that, if there was a nova meeting i totally missed it...14:51
jrollsambetts: no worries, I told you monday I'd attend :)14:52
*** amotoki has quit IRC14:53
*** hw_wutianwei has joined #openstack-ironic14:56
*** d0ugal has quit IRC14:57
jrollreminder that cirros is super relevant today:14:58
jrolllogin as 'cirros' user. default password: 'cubswin:)'. use 'sudo' for root.14:58
sambettsjroll: ;) that joke has literally just passed through our team too14:59
*** e0ne has joined #openstack-ironic14:59
openstackgerritVasyl Saienko proposed openstack/ironic: Update iptables rules and services IPs for multinode  https://review.openstack.org/36864814:59
openstackgerritVasyl Saienko proposed openstack/ironic: Add devstack setup_vxlan_network()  https://review.openstack.org/36864714:59
openstackgerritVasyl Saienko proposed openstack/ironic: Skip some steps for multinode case  https://review.openstack.org/36864614:59
openstackgerritVasyl Saienko proposed openstack/ironic: Update ironic node names for multinode case  https://review.openstack.org/36864514:59
openstackgerritVasyl Saienko proposed openstack/ironic: Update devstack provision net config for multihost  https://review.openstack.org/36864414:59
openstackgerritVasyl Saienko proposed openstack/ironic: Skip db configuration on subnodes  https://review.openstack.org/35330314:59
openstackgerritVasyl Saienko proposed openstack/ironic: Testing multinode stuff  https://review.openstack.org/36817314:59
openstackgerritVasyl Saienko proposed openstack/ironic: Ignore required_services for multinode topology  https://review.openstack.org/35279314:59
sambettsvsaienk0: this started off as a rework of your patch, but then its changed quite dramtically so I turned it into its own patch https://review.openstack.org/#/c/39295915:00
patchbotpatch 392959 - ironic - Rework Ironic devstack baremetal network simulation15:00
vsaienk0sorry for the spam, ironic-multinode related devstack-gate chain will be merged soon, so I decided to rebase multinode related patches :) bash experts reviews are welcome :)15:00
vsaienk0sambetts: I saw your patch, but didn't have time to dig enough15:01
vsaienk0sambetts: one thing I'm concerned, why not left ironic nodes connected to ovs? ovs is better emulation of hardware switch than linux bridges.15:02
sambettsvsaienk0: I'm planning on making it optional, so we can emulate with linux bridge or OVS, depending on what people have installed15:03
vsaienk0sambetts: we still may have ironic nodes connected to ovs event when we using Neutron+LB15:04
* rloo doesn't get the cirros joke15:04
sambettsvsaienk0: its possible yes but some people don't install OVS if they are using neutron+lb15:04
jrollrloo: "cubs win :)"15:05
sambettsvsaienk0: so I wanted to provide a no-OVS option15:05
vsaienk0sambetts: but they using hardware servers not VMs?15:05
jrollrloo: big news of the day, cubs won the world series for the first time in 108(?) years15:05
rloojroll: oh, chicago cubs. baseball. is it the *final* game today?15:05
jrollrloo: last night was the final game15:06
jrollwent into extra innings and everything, such excitement15:06
rloojroll: OH. so they won. even better! :D15:07
JayFcomeback from 3 games back, won in extra innings after a rain delay15:07
JayFa little bit of everything15:07
rloobet it was really exciting then!15:07
jrolltwas :)15:08
* rloo happy. cleveland beat toronto blue jays so i'm glad they lost.15:08
jrollheh15:08
*** krtaylor has quit IRC15:08
*** Nisha1 has joined #openstack-ironic15:09
sambettsvsaienk0: not nessesaraly, I think its possible that if you select neutron+lb it won't install ovs15:09
sambettsvsaienk0: but I havn't been able to confirm yet15:09
*** jerrygb_ has joined #openstack-ironic15:12
vsaienk0sambetts: openvswitch is a dependency for neutron-openvswitch-agent package http://packages.ubuntu.com/yakkety/neutron-openvswitch-agent so if it is not installed, ovs is not installed also15:12
*** jkilpatr_ has joined #openstack-ironic15:12
*** d0ugal has joined #openstack-ironic15:12
*** jkilpatr_ has quit IRC15:13
sambettsvsaienk0: so if you pick the neutron linux bridge agent then I'd expect that it won't install that package and therefore not install OVS15:13
sambettsvsaienk0: but we always have LB15:13
*** jerrygb has quit IRC15:13
vsaienk0sambetts: LB is bad emulation of real switch, so if we want to use VMs with Neutron+LB I prefer to left them connected via ovs15:14
*** jkilpatr has quit IRC15:14
NobodyCamGood Morning Ironic'ers15:14
vsaienk0sambetts: we can add requirement for ovs here: https://github.com/openstack/ironic/blob/master/devstack/files/debs/ironic15:15
sambettsvsaienk0: then we have a hard dependecy on OVS for testing even when we don't need it for flat network simulation?15:15
mgouldmorning NobodyCam15:16
NobodyCamGood Morning mgould :)15:16
*** jkilpatr has joined #openstack-ironic15:16
*** jaosorior has joined #openstack-ironic15:17
vsaienk0sambetts: technically it is possible to do not use ovs and plug VMs directly to linux bridge from flat network, but in real world hardware servers always plugged to switch, not matter it is flat network or not.15:19
*** rpioso has joined #openstack-ironic15:19
*** anush has quit IRC15:20
vsaienk0sambetts: so event with flat case, I think we should left simulation of hardware switch15:21
vsaienk0*even15:21
sambettsvsaienk0: the linux bridge emulates a dumb l2 switch and the vms are pluged into that, and then a virtual patch cable plugs the virtual switch into neutron15:22
vsaienk0sambetts: ovs is better emulation of the switch than linuxbridge15:23
*** KennethWilke has joined #openstack-ironic15:24
sambettsOVS has more switch features like built in vlan etc, but for flat networks I don't see much difference15:26
sambettsits even pretty easy to emulate staticly defined vlan networks using it15:27
vsaienk0sambetts: we should test both flat and vlan, might be vxlan in future, why not keep setup the same for all cases?15:27
*** anush has joined #openstack-ironic15:28
*** rbrud has quit IRC15:28
vsaienk0sambetts: linuxbridges doesn't support vlans natively, they way how neutron combines LB and tagged subinterfaces looks hacky15:29
sambettsvsaienk0: I use that method for doing vlans with lb in my patch15:30
*** e0ne has quit IRC15:30
vsaienk0sambetts: that is my concern, LB is bad emulation of the switch, because it doesn't support natively basic functions like vlans15:30
vsaienk0sambetts: I like the idea to be possible to use Neutron+LB, but I still think that ironic VMs should be connected via ovs.15:32
sambettsvsaienk0: makes sense, I'll edit my patch to use OVS as the default switch emulator and see if it all hooks up15:32
*** causten has joined #openstack-ironic15:36
*** hw_wutianwei has quit IRC15:37
*** hw_wutianwei has joined #openstack-ironic15:38
*** d0ugal has quit IRC15:39
*** hw_wutianwei has quit IRC15:41
*** hw_wutianwei has joined #openstack-ironic15:41
*** jtomasek has quit IRC15:44
*** rbudden has quit IRC15:46
*** jkilpatr has quit IRC15:47
*** krtaylor has joined #openstack-ironic15:48
*** krtaylor has quit IRC15:53
*** roeyc has quit IRC15:53
*** jaosorior has quit IRC15:54
*** harlowja_at_home has joined #openstack-ironic15:57
*** jkilpatr has joined #openstack-ironic16:00
openstackgerritLucas Alvares Gomes proposed openstack/ironic: DevStack: Fix standard PXE on Ubuntu Xenial  https://review.openstack.org/39335316:00
*** causten has quit IRC16:02
*** rcernin has quit IRC16:02
*** causten has joined #openstack-ironic16:03
*** causten_ has joined #openstack-ironic16:05
*** shobhar_ has joined #openstack-ironic16:06
*** causten has quit IRC16:07
*** jjohnson2 has quit IRC16:08
*** rajinir has joined #openstack-ironic16:12
*** pcaruana has quit IRC16:20
*** mjura_ has quit IRC16:21
*** rcernin has joined #openstack-ironic16:25
*** shobhar_ has quit IRC16:31
*** shobhar_ has joined #openstack-ironic16:34
*** aNuposic has joined #openstack-ironic16:38
*** aNuposic has quit IRC16:41
*** aNuposic has joined #openstack-ironic16:41
*** nicodemos has quit IRC16:42
*** sabeen has quit IRC16:49
*** moshele has quit IRC16:50
*** jtomasek has joined #openstack-ironic16:52
*** Alexey_Abashkin_ has joined #openstack-ironic16:56
*** ohamada has quit IRC16:57
*** pester has quit IRC16:57
*** Alexey_Abashkin has quit IRC16:59
*** harlowja_at_home has quit IRC17:00
*** hw_wutianwei has quit IRC17:00
*** g3ek has quit IRC17:01
*** rbudden has joined #openstack-ironic17:02
*** maratoid_ has joined #openstack-ironic17:03
*** rcernin has quit IRC17:03
*** rcernin has joined #openstack-ironic17:03
*** oberezovskyi has joined #openstack-ironic17:07
*** g3ek has joined #openstack-ironic17:07
*** rcernin has quit IRC17:08
*** nicodemos has joined #openstack-ironic17:08
*** strigazi is now known as strigazi_AFK17:16
milangood night Ironic! :)17:18
*** milan has quit IRC17:18
*** ralonsoh_ is now known as ralonsoh17:18
*** rcernin has joined #openstack-ironic17:19
openstackgerritLucas Alvares Gomes proposed openstack/ironic: DevStack: Fix standard PXE on Ubuntu Xenial  https://review.openstack.org/39335317:19
*** e0ne has joined #openstack-ironic17:20
*** rcernin has quit IRC17:24
*** anush has quit IRC17:24
*** daemontool has quit IRC17:28
*** mgould is now known as mgould|afk17:31
*** rbartal has quit IRC17:31
*** dtantsur is now known as dtantsur|afk17:32
*** aarefiev has quit IRC17:34
*** aarefiev has joined #openstack-ironic17:34
*** aarefiev_ has joined #openstack-ironic17:35
*** aarefiev has quit IRC17:35
*** aarefiev has joined #openstack-ironic17:35
*** aarefiev_ has quit IRC17:36
*** oberezovskyi has quit IRC17:36
*** aarefiev_ has joined #openstack-ironic17:38
*** fragatina has quit IRC17:39
*** aarefiev is now known as aarefiev_afk17:41
*** aarefiev_ has quit IRC17:42
*** harlowja has quit IRC17:43
*** harlowja has joined #openstack-ironic17:46
*** srobert has joined #openstack-ironic17:46
*** moshele has joined #openstack-ironic17:48
*** anush has joined #openstack-ironic17:52
*** derekh has quit IRC17:56
*** Guest25209 has quit IRC17:57
lucasagomescalling it a day, have a great evening all!17:59
*** lucasagomes is now known as lucas-afk17:59
JayFo/18:00
*** ralonsoh has quit IRC18:01
*** portdirect is now known as portdirect_away18:02
openstackgerritLucas Alvares Gomes proposed openstack/ironic: DevStack: Fix standard PXE on Ubuntu Xenial  https://review.openstack.org/39335318:03
lucas-afk(ok last patch-set, now tested (-: )18:03
* lucas-afk goes18:03
*** rcernin has joined #openstack-ironic18:05
*** sdake has joined #openstack-ironic18:05
*** athomas has quit IRC18:05
*** Nisha1 has quit IRC18:05
jcookJayF https://review.openstack.org/#/c/391415/18:12
patchbotpatch 391415 - nova - Fix hypervisor-stats show invalid information abou...18:13
*** dprince has quit IRC18:15
*** baoli_ has quit IRC18:15
*** rbudden has quit IRC18:19
*** rbudden has joined #openstack-ironic18:19
*** Sukhdev has joined #openstack-ironic18:20
*** cdearborn has joined #openstack-ironic18:22
*** sdake has quit IRC18:22
*** [1]cdearborn has quit IRC18:23
*** anush has quit IRC18:30
*** jpich has quit IRC18:37
*** dprince has joined #openstack-ironic18:41
*** sabeen has joined #openstack-ironic18:41
*** moshele has quit IRC18:41
*** jrcloud is now known as zackf18:46
openstackgerritJulia Kreger proposed openstack/ironic: Introduce VolumeTarget object  https://review.openstack.org/28521918:49
*** rama_y has quit IRC18:56
*** shobhar__ has joined #openstack-ironic18:58
*** shobhar_ has quit IRC19:01
*** strigazi_AFK is now known as strigazi19:02
*** ccamacho has quit IRC19:05
rlooJayF: what do you think of these new APIs? https://review.openstack.org/#/c/332177/19:07
patchbotpatch 332177 - ironic - Integrate portgroups with ports to support LAG19:07
JayFrloo: I'm in a meeting right now, I can look in around an hour19:07
rlooJayF: I was wondering why we want to add them19:07
rlooJayF: no worries.19:07
JayFah I think I nkow that answer without reading it, I think those are the pieces needed to virtually combine two physical interfaces into one virtual bonded interface19:07
rlooJayF: we can discuss when you have time. /v1/nodes/<node>/portgroups doesn't seem useful if we already have /v1/portgroups/ ?node_uuide=X19:08
JayFok; you may be right. I'll look at that patchset later if you want to put your concerns on it I can reply in patch19:09
rlooJayF: will do. am only asking you cuz you reviewed so maybe you know :)19:10
*** ChubYann has joined #openstack-ironic19:10
*** e0ne has quit IRC19:12
*** baoli_ has joined #openstack-ironic19:18
rloovsaienk0: your rebasing or something seems to mess up the topic. I manually changed it for https://review.openstack.org/#/c/33217719:18
patchbotpatch 332177 - ironic - Integrate portgroups with ports to support LAG19:18
*** shobhar__ has quit IRC19:19
*** shobhar__ has joined #openstack-ironic19:20
*** ccamacho has joined #openstack-ironic19:22
sambettsrloo: I think thats related to the question I brought up in the API session at the summit19:28
rloosambetts: remind me again19:29
*** mmedvede has quit IRC19:29
rloosambetts: or just reply to the patch :)19:30
sambettsrloo: right now we have both /nodes/<uuid>/ports and /ports?node=<uuid>, and /ports/<port_id>, and there is inconsistancy with what is possible with the different endpoints, e.g. you get get a port using /nodes/<node_id>/ports/<port_id> but not update it, where as /ports/<port_id> works for getting and putting19:32
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: WiP Serve iPXE configs from Ironic API  https://review.openstack.org/36943819:32
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: DNM test enabled dynamic iPXE  https://review.openstack.org/39194319:32
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: WiP Use Jinja2 for switched config as well  https://review.openstack.org/39346219:32
rloosambetts: right. so i am wondering why we'd want to make it more messy with a similar pattern with portgroups19:33
*** wajdi_ has joined #openstack-ironic19:33
*** jjohnson2 has joined #openstack-ironic19:33
*** strigazi is now known as strigazi_AFK19:33
openstackgerritJulia Kreger proposed openstack/ironic: Introduce new RPCs to support volume target operations  https://review.openstack.org/28522019:33
*** glonlas has joined #openstack-ironic19:34
sambettsrloo: ideally I would like ironic to use "resourceful" routing, and by that I refer to the fact that becausce ports are a sub-resource of a node, ports should always be retrieved and updated via a node19:34
TheJuliamariojv: I replied to your question on ^^^ on rev 30.19:34
mariojvthanks TheJulia, will take a look19:34
sambettsrloo: e.g. /ports doesn't exist, only /nodes/<node_id/ports exists19:34
rloosambetts: OHHH. I preferred the other way, but what you say makes sense.19:35
*** strigazi_AFK is now known as strigazi19:35
rloosambetts: oh. but how do you get a list of all ports, or does that not make any sense.19:35
*** livelace has quit IRC19:35
rlooif i hate API, does that mean i hate users? i hope not19:36
openstackgerritJulia Kreger proposed openstack/ironic: Add volume_connectors and volume_targets to task  https://review.openstack.org/36619619:37
*** causten_ has quit IRC19:38
sambettsI don't feel like /ports is particularly useful by itself, I would always point someone in the direction of doing GET /nodes, followed by for node in nodes: GET /node/<node_id>/ports, although I'm not sure how often you need to view all ports without kow what node your looking to find out the list of ports for19:39
*** glonlas has quit IRC19:40
rloosambetts: sigh. is this a similar thing for portgroups? I just approved the /v1/portgroups endpoint :-(19:41
rloosambetts: not too late to stop it i think...19:41
*** strigazi is now known as strigazi_AFK19:41
sambettsI think we need to address all the API stuff all at once, so being consistent with the existing API right now is probably more important19:41
*** causten has joined #openstack-ironic19:42
rloosambetts: hmm. i'd rather not add more mess to existing; it means more to deprecate if we ever do so.19:42
sambettsuntil the summit I wasn't sure redo the API to that level would be on the cards, so :/19:45
*** baoli_ has quit IRC19:45
*** rama_y has joined #openstack-ironic19:46
rloosambetts: sigh. and if we redo, lets do redo it all. so lets add more mess then.19:46
*** baoli has joined #openstack-ironic19:48
*** baoli_ has joined #openstack-ironic19:51
*** jerrygb has joined #openstack-ironic19:51
*** baoli has quit IRC19:51
*** maratoid_ has quit IRC19:51
*** jerrygb_ has quit IRC19:54
*** baoli__ has joined #openstack-ironic19:55
*** baoli_ has quit IRC19:55
sambettsrloo: yeah not ideal but we'll see what we discuss with devananda19:57
openstackgerritJulia Kreger proposed openstack/ironic: Add storage_interface DB field and object  https://review.openstack.org/34800519:57
* sambetts -> food then sleep 19:57
sambettsnight all19:57
rloosambetts: thx! have a great evening19:57
*** sambetts is now known as sambetts|afk19:58
sambetts|afko/ rloo19:58
*** fragatina has joined #openstack-ironic20:01
openstackgerritJulia Kreger proposed openstack/ironic: [WIP] Add storage_interface to base driver class  https://review.openstack.org/34800620:03
devanandasambetts|afk: some times, it's very useful to say GET /ports?address=aa.bb.cc20:04
*** srobert has quit IRC20:05
devanandaI suppose we could implement that on the /nodes resource instead, though20:06
TheJuliaAlso, to that point, last time I checked, the ports are not deleted along with a node, they have to be independently deleted with the current api, so until that were to change, we would need /ports to be able to clean up nodes so we can re-add them.20:06
devanandaTheJulia: oh really? I thought it cascaded :(20:06
TheJuliadevananda: I don't think it does, but that might have changed in the past year20:06
*** jkilpatr has quit IRC20:09
rlooTheJulia, devananda: I am thinking that maybe we just implement the portgroups API stuff similar to ports, and if/clean it all up later? wdyt?20:09
rlooTheJulia, devananda: I don't like it, but I don't think we have a good handle/plan on existing ports/nodes API.20:10
TheJuliaI kind of thought was always the plan for portgroups, mirror ports, and evolve later as necessary20:13
rlooTheJulia: Oh, I didn't know that was the plan. the spec is incomplete wrt portgroup APIs (i mean, between spec and the two patches i've looked at so far)20:14
rlooTheJulia: in that case, I'll just continue reviewing and approve the first patch for /v1/portgroups.20:15
TheJuliarloo: I could very well be offbase and have out of date context, but that is what I thought the plan was20:16
rlooTheJulia: what, i was just about to say that you said so! :) I don't see any other 'quick' choice besides that one right now.20:16
TheJulia\o/ consensus!20:17
rlooTheJulia: :D20:18
*** dprince has quit IRC20:26
*** khamtamtun has joined #openstack-ironic20:26
*** Goneri has quit IRC20:27
openstackgerritOleksandr Berezovskyi proposed openstack/ironic-python-agent: Add possibility to inspect systems with multiple CPUs  https://review.openstack.org/39129020:29
*** jkilpatr has joined #openstack-ironic20:33
*** krtaylor has joined #openstack-ironic20:34
openstackgerritFélix Bouliane proposed openstack/ironic: WIP- Add virtualpdu to ironic devstack plugin  https://review.openstack.org/38815420:35
openstackgerritFélix Bouliane proposed openstack/ironic: DONOTMERGE-change IRONIC_DEPLOY_DRIVER to pxe_snmp  https://review.openstack.org/38816820:35
*** hamzy has quit IRC20:35
openstackgerritOleksandr Berezovskyi proposed openstack/ironic-python-agent: Add possibility to inspect systems with multiple CPUs  https://review.openstack.org/39129020:42
*** baoli__ has quit IRC20:43
*** baoli has joined #openstack-ironic20:43
*** rama_y has quit IRC20:46
*** mmedvede has joined #openstack-ironic20:48
*** fragatina has quit IRC20:49
*** rbudden_ has joined #openstack-ironic20:53
*** rbudden has quit IRC20:54
*** rbudden_ is now known as rbudden20:54
mrdaMorning Ironic20:55
*** khamtamtun has quit IRC20:55
*** rcernin has quit IRC20:57
*** oberezovskyi has joined #openstack-ironic21:04
oberezovskyi2016-11-03 20:59:03.868 | [91mE: Failed to fetch http://http.us.debian.org/debian/pool/main/q/qemu/qemu-utils_2.7+dfsg-3~bpo8+1_amd64.deb  404  Not Found [IP: 64.50.236.52 80]21:04
patchbotError: Missing "]".  You may want to quote your arguments with double quotes in order to prevent extra brackets from being evaluated as nested commands.21:04
*** jheroux has quit IRC21:08
*** rama_y has joined #openstack-ironic21:18
*** jcoufal has quit IRC21:23
TheJuliaoberezovskyi: Sounds like the mirror you got directed to was missing that file, it downloaded for me21:23
*** khamtamtun has joined #openstack-ironic21:24
*** khamtamtun has quit IRC21:24
mariojvTheJulia: about the comment regarding VolumeTargetNotFound on https://review.openstack.org/#/c/285220/30/ironic/conductor/rpcapi.py - i agree it won't be raised for internal rpc usage unless there's a bug / race somewhere21:26
patchbotpatch 285220 - ironic - Introduce new RPCs to support volume target operat...21:26
mariojvTheJulia: but i'm curious about its behavior if an ironic user tries to delete the volume target via API, which hits that rpc call21:27
mariojvspecifically L412 here https://review.openstack.org/#/c/285221/9/ironic/api/controllers/v1/volume_target.py21:27
patchbotpatch 285221 - ironic - Add REST API for volume target operation21:27
mariojvwould that just give back a 5xx error?21:27
mariojvmainly i just wanted a docstring added to the rpc bit so we remember to return a helpful status code to the user if they're trying to delete a non-existent volume target21:28
TheJuliaI _think_ so, but the rpcapi interaction is not currently swapped into my brain on that level, as in the level between API service -> rpcapi to know for sure21:31
mariojvi guess that might be handled when you're retrieving the target, before that21:32
* TheJulia looks at api code21:32
TheJuliait _should_ be, but then you would have to have a race for it to occur21:32
mariojvright21:32
mariojvif there's something internal to ironic that would delete, at the same time a user tries to delete21:33
mariojvi haven't reviewed all the code for this yet so not sure if that's possible21:33
*** shobhar__ has quit IRC21:34
*** khamtamtun has joined #openstack-ironic21:34
TheJuliamariojv: the key would be to lock on the conductor :)21:34
mariojvah, then you couldn't even get the node, or conductor couldn't get the lock before trying to delete the volume21:35
mariojvso, this shouldn't be an issue21:35
TheJuliayou could get it, just not the lock21:35
mariojvright, so no destructive operations would be allowed21:35
TheJuliayup21:35
*** e0ne has joined #openstack-ironic21:35
mariojvassuming this works in the same order as the api code does (get volume target, get node, destroy volume target)21:36
* mariojv removes -121:36
mariojvthanks21:36
TheJuliaYeah, the API code needs work at this point21:38
TheJuliaBut we have a volunteer to work on that21:39
oberezovskyiTheJulia: the main problem that it error from gate job at IPA21:39
TheJuliaoberezovskyi: I hate to suggest this, but it is likely transitory21:39
TheJulia:(21:40
* TheJulia thought infra setup mirrors though21:40
JayFTheJulia: we don't utilize those mirrors for the IPA -src builds21:40
jrollwe don't use the mirrors for the docker build21:40
TheJuliaright :(21:40
JayFjroll: not just for the docker build; also for the tinyipa build21:40
oberezovskyiIt fails at devstack installation21:40
jrollwell, yeah21:40
jrollbut that was debian so I assumed docker :D21:40
*** baoli has quit IRC21:41
*** sabeen has quit IRC21:43
*** khamtamtun has quit IRC21:45
openstackgerritMerged openstack/ironic: Add PortGroups API  https://review.openstack.org/34754921:46
rlooyay, one done, more to review ^^. which reminds me, i forgot to review the next one.21:47
openstackgerritMerged openstack/python-ironicclient: Updated from global requirements  https://review.openstack.org/39282021:48
openstackgerritMerged openstack/python-ironicclient: Use function import_versioned_module from oslo.utils  https://review.openstack.org/39239521:54
openstackgerritMerged openstack/ironic-python-agent: Updated from global requirements  https://review.openstack.org/38989621:56
*** harlowja has quit IRC21:56
*** david-lyle has joined #openstack-ironic22:03
*** shobhar__ has joined #openstack-ironic22:07
*** absubram has quit IRC22:19
*** baoli has joined #openstack-ironic22:21
*** sabeen has joined #openstack-ironic22:27
*** jerrygb_ has joined #openstack-ironic22:29
*** causten has quit IRC22:30
*** rbudden has quit IRC22:31
*** wajdi_ has quit IRC22:31
*** jerrygb has quit IRC22:32
openstackgerritMerged openstack/ironic: Updated from global requirements  https://review.openstack.org/39273022:33
*** devananda is now known as devananda|away22:33
*** baoli has quit IRC22:38
*** baoli has joined #openstack-ironic22:41
*** rbrud has joined #openstack-ironic22:42
*** baoli_ has joined #openstack-ironic22:44
*** baoli has quit IRC22:46
*** baoli has joined #openstack-ironic22:51
*** baoli_ has quit IRC22:53
*** baoli has quit IRC22:57
*** bfournie1 has left #openstack-ironic23:02
*** rloo has quit IRC23:04
openstackgerritMerged openstack/ironic: Do not hide unexpected exceptions in inspection code  https://review.openstack.org/38551023:09
*** oberezovskyi has quit IRC23:11
*** awiddersheim has joined #openstack-ironic23:12
*** bfournie has joined #openstack-ironic23:33
*** e0ne has quit IRC23:33
*** mtanino has quit IRC23:39
*** yuanying has joined #openstack-ironic23:41
*** hw_wutianwei has joined #openstack-ironic23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!