*** baoli has joined #openstack-ironic | 00:04 | |
*** baoli_ has joined #openstack-ironic | 00:05 | |
*** wajdi has quit IRC | 00:08 | |
*** wajdi has joined #openstack-ironic | 00:08 | |
*** baoli has quit IRC | 00:09 | |
*** gfhellma has quit IRC | 00:11 | |
*** thrash is now known as thrash|g0ne | 00:13 | |
*** wajdi has quit IRC | 00:14 | |
*** chlong has quit IRC | 00:16 | |
*** sdake has joined #openstack-ironic | 00:16 | |
*** rbrud has joined #openstack-ironic | 00:19 | |
*** sdake has quit IRC | 00:21 | |
*** sdake has joined #openstack-ironic | 00:25 | |
*** mtanino has quit IRC | 00:34 | |
*** wajdi has joined #openstack-ironic | 00:36 | |
*** hoangcx has joined #openstack-ironic | 00:37 | |
openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-inspector: Python 3.x compatibility ConfigParser https://review.openstack.org/361869 | 00:47 |
---|---|---|
*** wajdi has quit IRC | 00:47 | |
*** Goneri has quit IRC | 00:56 | |
*** rbrud has quit IRC | 01:04 | |
*** phuongnh has joined #openstack-ironic | 01:04 | |
*** rbrud has joined #openstack-ironic | 01:11 | |
*** aNupoisc has joined #openstack-ironic | 01:21 | |
*** syed_ has quit IRC | 01:22 | |
*** wajdi has joined #openstack-ironic | 01:24 | |
*** baoli_ has quit IRC | 01:24 | |
*** wajdi_ has joined #openstack-ironic | 01:28 | |
*** tangchen has quit IRC | 01:29 | |
*** wajdi has quit IRC | 01:31 | |
openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Change asserts with more specific assert methods. https://review.openstack.org/362634 | 01:35 |
*** chlong has joined #openstack-ironic | 01:41 | |
*** tangchen has joined #openstack-ironic | 01:41 | |
*** yuanying has quit IRC | 01:45 | |
*** yuanying has joined #openstack-ironic | 01:46 | |
*** Goneri has joined #openstack-ironic | 01:46 | |
openstackgerrit | Merged openstack/bifrost: Update IPA info in troubleshooting.rst https://review.openstack.org/362428 | 01:55 |
*** vishwanathj has quit IRC | 01:59 | |
*** rbrud has quit IRC | 02:01 | |
*** aNupoisc has quit IRC | 02:02 | |
openstackgerrit | Merged openstack/bifrost: Split --syntax-check and --list-tasks steps in test-bifrost.sh https://review.openstack.org/358477 | 02:02 |
openstackgerrit | Merged openstack/bifrost: Allow to define vms with independent names https://review.openstack.org/354813 | 02:02 |
*** hoangcx has quit IRC | 02:05 | |
*** rbrud has joined #openstack-ironic | 02:06 | |
*** wlfightup has quit IRC | 02:06 | |
*** wlfightup has joined #openstack-ironic | 02:07 | |
openstackgerrit | Merged openstack/bifrost: Specify node_network_info is a dict https://review.openstack.org/356506 | 02:10 |
*** Goneri has quit IRC | 02:15 | |
*** sdake has quit IRC | 02:16 | |
*** sdake has joined #openstack-ironic | 02:17 | |
*** hoangcx has joined #openstack-ironic | 02:18 | |
*** Sukhdev has joined #openstack-ironic | 02:23 | |
*** baoli has joined #openstack-ironic | 02:34 | |
*** baoli has quit IRC | 02:40 | |
*** sabeen has joined #openstack-ironic | 02:40 | |
*** ChubYann has quit IRC | 02:42 | |
*** wajdi_ has quit IRC | 02:54 | |
*** ChubYann has joined #openstack-ironic | 02:56 | |
*** wajdi has joined #openstack-ironic | 03:07 | |
*** wajdi has quit IRC | 03:15 | |
*** sabeen has quit IRC | 03:17 | |
*** appu103_ has joined #openstack-ironic | 03:39 | |
*** appu103_ is now known as aparnav | 03:39 | |
*** vikrant has joined #openstack-ironic | 03:40 | |
openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Replace map(func, data) with [func(item) for item in data] https://review.openstack.org/363373 | 03:44 |
*** appu103_ has joined #openstack-ironic | 03:46 | |
*** aparnav has quit IRC | 03:46 | |
*** appu103_ is now known as aparnav | 03:46 | |
openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-python-agent: Replace map(func, data) with [func(item) for item in data] https://review.openstack.org/363375 | 03:48 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Support configdrive in iscsi deploy for whole disk images https://review.openstack.org/225115 | 03:51 |
openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-lib: Replace map(func, data) with [func(item) for item in data] https://review.openstack.org/363377 | 03:53 |
*** rbrud has quit IRC | 03:54 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic-python-agent: Use ironic-lib to create configdrive https://review.openstack.org/296466 | 04:04 |
*** ijw has quit IRC | 04:04 | |
openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-inspector: Replace map(func, data) with [func(item) for item in data] https://review.openstack.org/363383 | 04:06 |
*** ijw has joined #openstack-ironic | 04:08 | |
*** MattMan has quit IRC | 04:11 | |
*** MattMan has joined #openstack-ironic | 04:11 | |
openstackgerrit | Ha Van Tu proposed openstack/ironic: Config logABug feature for Ironic api-ref https://review.openstack.org/363385 | 04:12 |
*** crinkle_ has joined #openstack-ironic | 04:16 | |
*** crinkle has quit IRC | 04:17 | |
*** mpsairam has quit IRC | 04:18 | |
*** pmannidi has joined #openstack-ironic | 04:27 | |
*** ijw has quit IRC | 04:27 | |
*** ijw has joined #openstack-ironic | 04:28 | |
openstackgerrit | Merged openstack/ironic-inspector: Python 3.x compatibility ConfigParser https://review.openstack.org/361869 | 04:33 |
*** ijw has quit IRC | 04:33 | |
*** yuanying has quit IRC | 04:34 | |
*** yuanying has joined #openstack-ironic | 04:34 | |
*** dtantsur|afk has quit IRC | 04:36 | |
*** hoangcx has quit IRC | 04:36 | |
*** links has joined #openstack-ironic | 04:36 | |
*** chlong has quit IRC | 04:38 | |
*** hoangcx has joined #openstack-ironic | 04:39 | |
*** chlong has joined #openstack-ironic | 04:39 | |
*** chlong has quit IRC | 04:45 | |
*** ijw has joined #openstack-ironic | 04:55 | |
*** chlong has joined #openstack-ironic | 04:57 | |
*** anush__ has quit IRC | 04:58 | |
*** Fdaisuke has quit IRC | 04:59 | |
*** ijw has quit IRC | 05:00 | |
*** Fdaisuke has joined #openstack-ironic | 05:01 | |
openstackgerrit | Naohiro Tamura proposed openstack/python-ironicclient: Add a new command "ironic node-inject-nmi" https://review.openstack.org/247905 | 05:08 |
*** sdake has quit IRC | 05:10 | |
*** sdake_ has joined #openstack-ironic | 05:10 | |
openstackgerrit | Naohiro Tamura proposed openstack/python-ironicclient: Add a new OSC command for Inject NMI https://review.openstack.org/357661 | 05:19 |
*** fragatina has quit IRC | 05:19 | |
*** jaosorior has joined #openstack-ironic | 05:21 | |
*** yonglihe has joined #openstack-ironic | 05:22 | |
*** sdake_ has quit IRC | 05:26 | |
*** ChubYann has quit IRC | 05:32 | |
openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-inspector: Replace map(func, data) with [func(item) for item in data] https://review.openstack.org/363383 | 05:33 |
*** sdake has joined #openstack-ironic | 05:33 | |
openstackgerrit | Aparna proposed openstack/ironic-specs: Generic way to configure clean step priorites in Automated cleaning https://review.openstack.org/362615 | 05:33 |
openstackgerrit | Merged openstack/proliantutils: Raise exception when HPSSA controller not available https://review.openstack.org/347791 | 05:37 |
openstackgerrit | Merged openstack/proliantutils: Add hpssa support only in raid mode https://review.openstack.org/347978 | 05:39 |
*** mtanino has joined #openstack-ironic | 05:48 | |
*** ifarkas_afk has quit IRC | 05:50 | |
*** mjura has joined #openstack-ironic | 05:57 | |
openstackgerrit | Merged openstack/proliantutils: Fix log message for exception in Gen7 https://review.openstack.org/353860 | 05:59 |
*** fragatina has joined #openstack-ironic | 06:02 | |
*** mjura has quit IRC | 06:05 | |
*** mjura has joined #openstack-ironic | 06:05 | |
*** fragatina has quit IRC | 06:07 | |
*** pcaruana has joined #openstack-ironic | 06:15 | |
*** wajdi has joined #openstack-ironic | 06:16 | |
*** rcernin has joined #openstack-ironic | 06:21 | |
*** yogi has joined #openstack-ironic | 06:21 | |
*** sdake has quit IRC | 06:22 | |
*** ijw has joined #openstack-ironic | 06:28 | |
openstackgerrit | Jinxing Fang proposed openstack/ironic: Update the string format https://review.openstack.org/363421 | 06:28 |
*** amotoki has joined #openstack-ironic | 06:29 | |
*** mtanino has quit IRC | 06:32 | |
*** watanabe_isao has joined #openstack-ironic | 06:32 | |
*** moshele has joined #openstack-ironic | 06:47 | |
*** ijw has quit IRC | 06:53 | |
*** amotoki has quit IRC | 06:56 | |
*** tesseract- has joined #openstack-ironic | 07:08 | |
*** amotoki has joined #openstack-ironic | 07:16 | |
*** ifarkas has joined #openstack-ironic | 07:18 | |
openstackgerrit | Georgy Dyuldin proposed openstack/ironic: Add ironic multitenancy tests https://review.openstack.org/360465 | 07:23 |
openstackgerrit | Georgy Dyuldin proposed openstack/ironic: New test for check instances in shared network https://review.openstack.org/360573 | 07:25 |
*** ipukha has joined #openstack-ironic | 07:30 | |
*** jpich has joined #openstack-ironic | 07:37 | |
openstackgerrit | Markos Chandras proposed openstack/bifrost: Improve distribution detection in create_vm_nodes-for-role.sh https://review.openstack.org/363458 | 07:48 |
*** Sukhdev has quit IRC | 07:52 | |
*** priteau has joined #openstack-ironic | 07:57 | |
openstackgerrit | Sofiia Andriichenko proposed openstack/python-ironicclient: Negative tests for testing actions with node: test_node_show_states test_node_show test_node_validate test_node_set_boot_device test_node_set_power_state test_node_set_provision_state test_node_set_console_mode test_node_set_mainte https://review.openstack.org/361583 | 07:57 |
*** zhangjl has joined #openstack-ironic | 07:58 | |
*** mgoddard_ has joined #openstack-ironic | 07:58 | |
*** zzzeek has quit IRC | 08:00 | |
*** praneshp has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-ironic | 08:01 | |
*** ashestakov has joined #openstack-ironic | 08:04 | |
*** hoangcx has quit IRC | 08:04 | |
*** athomas has joined #openstack-ironic | 08:04 | |
*** hoangcx has joined #openstack-ironic | 08:05 | |
*** chlong has quit IRC | 08:06 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 08:10 |
openstackgerrit | Szymon Borkowski proposed openstack/ironic-inspector: Add PCI devices plugin to inspector https://review.openstack.org/352295 | 08:17 |
*** lucas-dinner is now known as lucasagomes | 08:20 | |
lucasagomes | JayF, morning, will take a look | 08:20 |
lucasagomes | morning all | 08:20 |
*** ohamada has joined #openstack-ironic | 08:23 | |
*** e0ne has joined #openstack-ironic | 08:24 | |
vsaienk0 | Morning JayF, dtantsur, lucasagomes, sambetts, vdrok, aarefiev and all Ironic'ers! | 08:24 |
ifarkas | morning all! | 08:27 |
*** milan has joined #openstack-ironic | 08:29 | |
*** derekh has joined #openstack-ironic | 08:31 | |
aarefiev | morning! | 08:32 |
aarefiev | morning vsaienk0, lucasagomes, ifarkas | 08:32 |
lucasagomes | vsaienk0, aarefiev ifarkas good morning :D | 08:32 |
*** chihhsin has quit IRC | 08:33 | |
aarefiev | milan: morning, sorry I didn't see your ping yesterday | 08:34 |
*** chihhsin has joined #openstack-ironic | 08:34 | |
lucasagomes | JayF, the design on comment #4 seems good and covers my previous questions. So I've approved the rfe | 08:35 |
lucasagomes | jjohnson2, opss... sorry for it underindenting, it was late at the day for me so I just changed the code quickly and reproposed the patch | 08:36 |
lucasagomes | glad it's merged now :D | 08:37 |
*** ashestakov has quit IRC | 08:38 | |
*** watanabe_isao has quit IRC | 08:51 | |
vdrok | morning lucasagomes vsaienk0 ifarkas and aarefiev | 08:57 |
lucasagomes | hi there | 08:57 |
aarefiev | hey vdrok | 08:57 |
*** moshele has quit IRC | 09:01 | |
*** moshele has joined #openstack-ironic | 09:02 | |
*** electrofelix has joined #openstack-ironic | 09:07 | |
*** dtantsur has joined #openstack-ironic | 09:13 | |
dtantsur | Morning folks. My IRC bouncer went down yesterday evening (as well as my lab environment, sigh), so please repeat any pings. | 09:13 |
milan | morning aarefiev :) | 09:16 |
milan | and morning Ironic! | 09:16 |
milan | aarefiev, sambetts, dtantsur I wanted to get some conclusion on the inspector state patch, should it be before FF or an FFE or bumped to Ocata, wdyt? | 09:17 |
dtantsur | milan, my problem is pretty simple: I don't have time to carefully review and play with this patch | 09:18 |
milan | dtantsur, I see, aarefiev sambetts what about you guys? | 09:18 |
aarefiev | I'll test it today and I hope on friday, but seems it's risky to merge in newton | 09:19 |
milan | aarefiev, OK, cool | 09:20 |
aarefiev | it's pretty significant changes | 09:21 |
milan | yeah, it's big | 09:21 |
milan | sambetts, you hiding! :P | 09:22 |
sambetts | Morning guys | 09:24 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Use assertIsInstance/assertNotIsInstance in tests https://review.openstack.org/363521 | 09:24 |
milan | morning sambetts :) | 09:24 |
dtantsur | morning sambetts, aarefiev | 09:24 |
aarefiev | morning dtantsur sambetts | 09:25 |
sambetts | milan: I still have some issues with it, I'm not totally happen with what we've go right now, if your around we can chat about it | 09:26 |
milan | sambetts, sure | 09:26 |
sambetts | milan: hangouts? | 09:26 |
milan | actually I'm glad to receive feed back on that | 09:26 |
milan | sambetts, yeah | 09:26 |
milan | I've got time even right now | 09:27 |
sambetts | milan: sure :) | 09:27 |
milan | so the conclusion would be Ocata I suppose | 09:27 |
* milan marks that for downstream planning | 09:27 | |
sambetts | unless we can get something really dialed in soon | 09:28 |
milan | sambetts, yeah | 09:28 |
vdrok | morning dtantsur milan and sambetts | 09:29 |
milan | morning vdrok! :) | 09:30 |
dtantsur | morning vdrok | 09:30 |
*** _milan_ has joined #openstack-ironic | 09:33 | |
*** milan has quit IRC | 09:35 | |
*** hoangcx has quit IRC | 09:47 | |
openstackgerrit | Merged openstack/ironic: Use assertIsInstance/assertNotIsInstance in tests https://review.openstack.org/363521 | 09:53 |
dtantsur | folks, could someone NOT from Red Hat please check the DRAC inspection patch? https://review.openstack.org/342915 | 09:55 |
openstackgerrit | Yibo Cai proposed openstack/ironic: Support multi arch deployment https://review.openstack.org/322632 | 09:58 |
vdrok | dtantsur: I can try today | 10:01 |
dtantsur | thanks | 10:02 |
*** ifarkas_ has joined #openstack-ironic | 10:05 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add standalone_ports_supported to portgroup - DB https://review.openstack.org/361053 | 10:07 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add PortGroups API https://review.openstack.org/347549 | 10:07 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Integrate portgroups with ports to support LAG https://review.openstack.org/332177 | 10:07 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 10:10 |
openstackgerrit | Merged openstack/python-ironicclient: Add --chassis to 'openstack baremetal node list' https://review.openstack.org/362515 | 10:14 |
*** anush__ has joined #openstack-ironic | 10:15 | |
*** zhangjl has quit IRC | 10:36 | |
*** sdake has joined #openstack-ironic | 10:49 | |
*** thrash|g0ne is now known as thrash | 10:54 | |
*** phuongnh has quit IRC | 11:00 | |
*** parlos has joined #openstack-ironic | 11:02 | |
*** amotoki has quit IRC | 11:09 | |
mat128 | good morning, group! | 11:11 |
dtantsur | morning mat128 | 11:12 |
lucasagomes | mat128, morning | 11:12 |
*** parlos has quit IRC | 11:12 | |
openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with node-port-list. https://review.openstack.org/360636 | 11:13 |
*** amotoki has joined #openstack-ironic | 11:14 | |
*** wznoinsk has quit IRC | 11:18 | |
*** parlos has joined #openstack-ironic | 11:19 | |
*** mkovacik__ has joined #openstack-ironic | 11:19 | |
*** _milan_ has quit IRC | 11:22 | |
vdrok | morning mat128 | 11:28 |
*** wznoinsk has joined #openstack-ironic | 11:33 | |
*** baoli has joined #openstack-ironic | 11:37 | |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add portgroup support to osc plugin https://review.openstack.org/362130 | 11:38 |
TheJulia | Good morning everyone | 11:38 |
dtantsur | morning TheJulia | 11:40 |
*** lucasagomes is now known as lucas-hungry | 11:43 | |
lucas-hungry | morning TheJulia | 11:43 |
vdrok | morning TheJulia | 11:44 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add portgroup support to osc plugin https://review.openstack.org/362130 | 11:44 |
*** vishwanathj has joined #openstack-ironic | 11:44 | |
openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-inspector: Change asserts with more specific assert methods. https://review.openstack.org/363601 | 11:46 |
*** baoli_ has joined #openstack-ironic | 11:46 | |
vdrok | the gate seems to be down - https://bugs.launchpad.net/ironic/+bug/1618853 | 11:47 |
openstack | Launchpad bug 1618853 in Ironic "Multitenancy job fails not being able to ping the booted instance" [Critical,New] | 11:47 |
sambetts | :'( | 11:48 |
*** baoli has quit IRC | 11:49 | |
openstackgerrit | Galyna Zholtkevych proposed openstack/python-ironicclient: refollowing-up this patch set. Resolving issue with rebasing https://review.openstack.org/363603 | 11:52 |
openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-inspector: Change asserts with more specific assert methods. https://review.openstack.org/363601 | 11:52 |
openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-python-agent: Replace json.dumps(obj) with oslo_serialization.jsonutils.dump_as_bytes(obj) https://review.openstack.org/363605 | 11:54 |
openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add CRUD notifications for ironic resources https://review.openstack.org/356541 | 11:56 |
openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add node provision state change notification https://review.openstack.org/348437 | 11:56 |
mkovacik__ | dtantsur, aarefiev I think this Inspector patch is OK to merge now (already had dtantsur's +2 before): https://review.openstack.org/#/c/352295/ | 12:01 |
*** mkovacik__ is now known as milan | 12:01 | |
milan | mkovacik__ -> milan | 12:01 |
aarefiev | milan: looking on it now :) | 12:02 |
milan | aarefiev, thx! | 12:02 |
*** jaosorior has quit IRC | 12:04 | |
aarefiev | milan: left comment about parse config | 12:05 |
ifarkas | lucas-hungry, yuriyz, re missing disks: can you please check my comment on https://review.openstack.org/#/c/342915/6/ironic/drivers/modules/drac/inspect.py ? | 12:06 |
*** jaosorior has joined #openstack-ironic | 12:06 | |
ifarkas | lucas-hungry, maybe I am missing something but the code is already raising an exception if no disk found | 12:06 |
yuriyz | hi ifarkas will look | 12:06 |
ifarkas | yuriyz, thanks | 12:07 |
* milan looks | 12:07 | |
openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add CRUD notifications for ironic resources https://review.openstack.org/356541 | 12:11 |
*** dtantsur is now known as dtantsur|bbl | 12:12 | |
*** dprince has joined #openstack-ironic | 12:13 | |
openstackgerrit | Merged openstack/ironic: Config logABug feature for Ironic api-ref https://review.openstack.org/363385 | 12:18 |
*** sborkows has joined #openstack-ironic | 12:18 | |
vdrok | sambetts: seems like this one broke us - https://github.com/openstack-dev/devstack/commit/434035e2846dc8ebcdadf7349897f8b0b29c3b74 | 12:20 |
vdrok | and we might have revert revert revert :) | 12:21 |
* sambetts vomits | 12:21 | |
sambetts | haha | 12:21 |
sambetts | vdrok: I think we just need to ensure we configure the right things in neutron, you can acheive what used to exist using parameters in the new code | 12:23 |
sambetts | vdrok: as far as I understand it | 12:23 |
sambetts | vdrok: switching to using flats properly might help too | 12:24 |
sborkows | jlvillal: Hi, would you mind looking at my patch about adding PCI_device processing hook to ironic inspector? https://review.openstack.org/#/c/352295 This completes the patch you reviewed 2 months ago on the IPA side. | 12:25 |
sambetts | vdrok: although its the multitenant one you say is broken right/ | 12:26 |
sambetts | ? | 12:26 |
vdrok | sambetts: yup. I'm out for lunch, vsaienk0 is looking into it too | 12:27 |
sambetts | cool, thanks guys, I'm not completely aware of the devstack code for multitenancy works so vsaienk0 will probably debug it faster than me | 12:28 |
*** trown|outtypewww is now known as trown | 12:29 | |
*** openstackgerrit has quit IRC | 12:34 | |
*** openstackgerrit has joined #openstack-ironic | 12:34 | |
* milan desperately needs coffee | 12:35 | |
openstackgerrit | Yibo Cai proposed openstack/ironic: Support multi arch deployment https://review.openstack.org/322632 | 12:37 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Testing revert of devstack patch. https://review.openstack.org/363625 | 12:39 |
*** lucas-hungry is now known as lucasagomes | 12:45 | |
openstackgerrit | Imre Farkas proposed openstack/ironic: DRAC OOB inspection https://review.openstack.org/342915 | 12:45 |
*** ifarkas has quit IRC | 12:46 | |
*** ifarkas_ is now known as ifarkas | 12:47 | |
lucasagomes | ifarkas, will do | 12:47 |
lucasagomes | ifarkas, I think the idea there is that, all the other essential values (memory, arch and cpu) will always be present, unless an exception is raised | 12:49 |
lucasagomes | only the disks might be None | 12:50 |
ifarkas | lucasagomes, yeah, that's true for now | 12:50 |
lucasagomes | so instead of having that condition checking the 4 properties, you can only assert if a disk have been found or not (then raise something) | 12:50 |
lucasagomes | ifarkas, in any case, it's not a big deal | 12:50 |
*** Fdaisuke has quit IRC | 12:51 | |
ifarkas | lucasagomes, I preferred having check all properties just in case but I can remove it | 12:51 |
*** Fdaisuke has joined #openstack-ironic | 12:51 | |
ifarkas | lucasagomes, current version is probably better against future code changes :-) | 12:52 |
*** ijw has joined #openstack-ironic | 12:52 | |
lucasagomes | ifarkas, yeah, commented on the new patch-set and +2'd | 12:52 |
ifarkas | lucasagomes, awesome, thanks! | 12:53 |
*** jcoufal has joined #openstack-ironic | 12:56 | |
*** wajdi has quit IRC | 12:56 | |
*** ijw has quit IRC | 12:57 | |
jroll | morning y'all | 12:59 |
*** parlos has quit IRC | 13:02 | |
*** vikrant has quit IRC | 13:05 | |
TheJulia | Good morning jroll | 13:06 |
mat128 | morning jroll | 13:08 |
openstackgerrit | Mathieu Mitchell proposed openstack/ironic: Add cookiecutter base for install guide https://review.openstack.org/363294 | 13:08 |
mat128 | JayF: ^ I updated your commit to fix the jenkins failures we were seeing. I also submitted changes to installguide-cookiecutter so other projects don't end up fixing the same errors | 13:09 |
*** parlos has joined #openstack-ironic | 13:11 | |
jroll | yay, more client code landed | 13:13 |
*** rloo has joined #openstack-ironic | 13:14 | |
*** mtanino has joined #openstack-ironic | 13:15 | |
*** anush__ has quit IRC | 13:15 | |
vsaienk0 | fyi: multitenant network job is failed due to https://github.com/openstack-dev/devstack/commit/434035e2846dc8ebcdadf7349897f8b0b29c3b74 | 13:15 |
openstackgerrit | Galyna Zholtkevych proposed openstack/python-ironicclient: Update openstack baremetal driver commands https://review.openstack.org/362047 | 13:15 |
*** sdake_ has joined #openstack-ironic | 13:16 | |
* milan relocates | 13:17 | |
*** milan has quit IRC | 13:17 | |
rloo | hi everyone | 13:17 |
TheJulia | good morning rloo | 13:17 |
rloo | vsaienk0: does that mean the gate is broken? | 13:17 |
rloo | morning TheJulia | 13:17 |
jroll | morning rloo | 13:18 |
jroll | rloo: it is, for ironic (only multitenant job) | 13:18 |
vsaienk0 | rloo: yes | 13:18 |
openstackgerrit | Galyna Zholtkevych proposed openstack/python-ironicclient: Update openstack baremetal driver commands https://review.openstack.org/362047 | 13:18 |
rloo | sigh. thx jroll, vsaienk0. (and I looked at etherpad *after* I asked you) | 13:18 |
vsaienk0 | I've did a revert https://review.openstack.org/#/c/363621/ and multitenant job passed | 13:18 |
jroll | vsaienk0: are you proposing a fix (or revert)? can we set one of those variables to fix it? | 13:18 |
jroll | e.g. I'm wondering if we just need to set Q_USE_PROVIDERNET_FOR_PUBLIC=False | 13:19 |
*** sdake has quit IRC | 13:19 | |
vsaienk0 | jroll: yes, we can update job variables to work with that change, but I want to revert it first, update job variables, only after that do revert of revert | 13:19 |
rloo | vsaienk0: that's a great revert, three reverts :) | 13:19 |
openstackgerrit | Andrey Shestakov proposed openstack/ironic: IPMI command should depends on console type https://review.openstack.org/363647 | 13:20 |
jroll | vsaienk0: why? seems like we can probably merge project-config changes as quick as devstack changes | 13:21 |
jroll | vsaienk0: or actually, we can set it in ironic/devstack/lib/settings, right? | 13:21 |
vsaienk0 | jroll: not so quick, because it takes some time to propagate project-config over the jenkins slaves | 13:21 |
*** sdake_ is now known as sdake | 13:22 | |
vsaienk0 | jroll: I didn't thought about ironic/devstack/lib/settings but it seems it may be done there | 13:22 |
jroll | vsaienk0: let's give that a shot | 13:24 |
vsaienk0 | jroll: setting them in ironic/settings may not help if neutron setup is launched before source ironic/settings | 13:25 |
jroll | vsaienk0: I believe plugin settings are sourced first | 13:25 |
*** sabeen has joined #openstack-ironic | 13:25 | |
*** Goneri has joined #openstack-ironic | 13:27 | |
jroll | vsaienk0: hard to tell though, do whatever you think is best | 13:28 |
jroll | oh yeah, they are early | 13:28 |
jroll | up to you, though, I guess | 13:28 |
*** aparnav has quit IRC | 13:33 | |
*** cdearborn has joined #openstack-ironic | 13:34 | |
*** causten has quit IRC | 13:36 | |
*** mtanino has quit IRC | 13:37 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Test fix multitenancy https://review.openstack.org/363666 | 13:42 |
openstackgerrit | Andrey Shestakov proposed openstack/ironic: IPMI command should depends on console type https://review.openstack.org/363647 | 13:42 |
lucasagomes | rloo, jroll vsaienk0 morning | 13:43 |
rloo | hi lucasagomes! | 13:43 |
thiagop | Good morning, Ironicers | 13:43 |
*** wajdi has joined #openstack-ironic | 13:44 | |
lucasagomes | is the tempest test_baremetal_multitenancy() broken or flaky ? | 13:44 |
lucasagomes | IIRC i've seem it timing out on multiple patches now | 13:44 |
thiagop | it's being broken since yesterday | 13:45 |
*** amotoki has quit IRC | 13:46 | |
TheJulia | jroll: re: bifrost release: https://review.openstack.org/#/c/363610/ | 13:48 |
rloo | lucasagomes: see whiteboard re multitenancy job failing | 13:50 |
lucasagomes | rloo, gotcha thanks | 13:50 |
lucasagomes | rloo, btw, re https://review.openstack.org/#/c/358000/16/ironic_lib/utils.py | 13:50 |
lucasagomes | rloo, what-if we use the strutils lib to convert the device's value to boolean? Just like we do when we parse the root device hints | 13:51 |
*** dtantsur|bbl is now known as dtantsur | 13:51 | |
lucasagomes | independent from that, it would be good to document the expected fields anyway | 13:51 |
rloo | lucasagomes: yes, that would make more sense to me. i like the symmetry :) | 13:51 |
rloo | lucasagomes: yup | 13:52 |
dtantsur | morning jroll, rloo, thiagop | 13:52 |
rloo | hi dtantsur | 13:52 |
thiagop | dtantsur: hiya | 13:52 |
*** amotoki has joined #openstack-ironic | 13:53 | |
thiagop | vsaienk0: I don't know if it helps, but yesterday when I was trying to track the multitenant problem, I found it awkward that all jobs failing had the version of neutron-openvswitch-agent 9.0.0.0b3.dev599, while non-failing jobs were dev593 | 13:54 |
*** milan has joined #openstack-ironic | 13:55 | |
sborkows | jlvillal: Hi, would you mind looking at my patch about adding PCI_device processing hook to ironic inspector? https://review.openstack.org/#/c/352295 This completes the patch you reviewed 2 months ago on the IPA side. | 13:58 |
*** anush__ has joined #openstack-ironic | 14:00 | |
*** links has quit IRC | 14:00 | |
jroll | TheJulia: thanks! | 14:01 |
rloo | hi, does anyone know if Kyrylo Romanenko is back from vacation? or is Rodion P around. wrt OSC patch https://review.openstack.org/#/c/350050/ | 14:02 |
rloo | vdrok, vsaienk0: ^^ do you know? | 14:02 |
vdrok | morning rloo jroll thiagop | 14:03 |
vdrok | rloo: yes he is | 14:03 |
thiagop | vdrok: o/ | 14:03 |
rloo | vdrok: could you ask him if he is going to update that soon, like in the next few hours? otherwise, i'll work on it. want to get it into the client this week | 14:03 |
*** Romanenko_K has joined #openstack-ironic | 14:04 | |
vdrok | rloo: ^^ :) | 14:04 |
rloo | thx vdrok! | 14:04 |
Romanenko_K | hello! | 14:04 |
rloo | hi Romanenko_K! | 14:04 |
rloo | Romanenko_K: were you planning on working on https://review.openstack.org/#/c/350050/ soon? | 14:05 |
rloo | Romanenko_K: want to get it into the client release which might happen tomorrow | 14:05 |
rloo | Romanenko_K: if you aren't, I can | 14:05 |
rloo | Romanenko_K: (hope you had a great vacation) | 14:06 |
*** sdake_ has joined #openstack-ironic | 14:06 | |
Romanenko_K | Rodion Promyshlennikov was going to do his final change on my patch today. I will contact him now | 14:07 |
Romanenko_K | Thanks, vacation was great :) | 14:07 |
rloo | Romanenko_K: thx | 14:07 |
*** sdake has quit IRC | 14:07 | |
Romanenko_K | rloo, i will be glad if you would finish this patch because you can do it much faster and fit it into release :) | 14:14 |
rloo | Romanenko_K: okey dokey :) | 14:14 |
*** amotoki has quit IRC | 14:16 | |
*** sborkows has quit IRC | 14:16 | |
*** michauds has joined #openstack-ironic | 14:20 | |
*** joprovost has joined #openstack-ironic | 14:20 | |
*** mtanino has joined #openstack-ironic | 14:20 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Test fix multitenancy https://review.openstack.org/363666 | 14:21 |
*** joprovost has quit IRC | 14:21 | |
*** joprovost has joined #openstack-ironic | 14:23 | |
*** _mbelanger has joined #openstack-ironic | 14:26 | |
*** amotoki has joined #openstack-ironic | 14:26 | |
*** rajinir has joined #openstack-ironic | 14:28 | |
*** rbrud has joined #openstack-ironic | 14:29 | |
openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Switch to admin_token auth for standalone mode https://review.openstack.org/359061 | 14:31 |
*** amotoki has quit IRC | 14:35 | |
*** syed_ has joined #openstack-ironic | 14:44 | |
*** joprovost has quit IRC | 14:44 | |
*** amotoki has joined #openstack-ironic | 14:48 | |
*** ChubYann has joined #openstack-ironic | 14:51 | |
*** fragatina has joined #openstack-ironic | 14:53 | |
*** fragatina has quit IRC | 14:53 | |
*** fragatina has joined #openstack-ironic | 14:54 | |
*** fragatin_ has joined #openstack-ironic | 14:58 | |
JayF | Has anyone dug into the multitenant network job failures? | 14:59 |
mat128 | Vasyl | 14:59 |
*** milan has quit IRC | 14:59 | |
mat128 | it's on the whiteboard | 14:59 |
JayF | ah, should've checked there | 15:00 |
mat128 | JayF: did you see my update on your install guide stuff? | 15:00 |
vdrok | if you have a bit of time for client, https://review.openstack.org/359061, complete switch to keystoneauth | 15:00 |
JayF | mat128: yep, and ty :) | 15:00 |
*** ijw has joined #openstack-ironic | 15:00 | |
mat128 | hope you dont mind, I have had the install guide in my todo list for a few days now | 15:00 |
JayF | mat128: My thought was: try to get our existing admin guide more or less ported over, then work to improve it during O | 15:00 |
*** rpioso has joined #openstack-ironic | 15:00 | |
*** bcornec1 has quit IRC | 15:00 | |
JayF | mat128: no problem at all, it was on my todo list this week, so I tackled it too. Two folks > one | 15:00 |
mat128 | JayF: I share your vision | 15:01 |
mat128 | :D | 15:01 |
dtantsur | vdrok, will try to get to it today | 15:01 |
*** mgoddard__ has joined #openstack-ironic | 15:01 | |
vdrok | thx! | 15:01 |
*** fragatina has quit IRC | 15:02 | |
*** milan has joined #openstack-ironic | 15:02 | |
*** mgoddard_ has quit IRC | 15:04 | |
*** mari0jv has joined #openstack-ironic | 15:04 | |
*** jaosorior has quit IRC | 15:08 | |
*** ijw has quit IRC | 15:09 | |
*** dprince has quit IRC | 15:13 | |
jlvillal | Good morning vdrok dtantsur mat128 JayF rloo thiagop lucasagomes TheJulia jroll and anyone else I missed :) | 15:21 |
dtantsur | morning jlvillal | 15:21 |
lucasagomes | jlvillal, good morning :D | 15:21 |
thiagop | morning jlvillal | 15:21 |
JayF | o/ | 15:21 |
*** pcaruana has quit IRC | 15:22 | |
*** rcernin has quit IRC | 15:22 | |
rloo | mornin' jlvillal | 15:22 |
TheJulia | good morning jlvillal | 15:22 |
jlvillal | :D | 15:22 |
*** mjura has quit IRC | 15:23 | |
vdrok | morning jlvillal | 15:24 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update test_update_portgroup_address_no_vif_id test https://review.openstack.org/363747 | 15:25 |
JayF | mat128: can you commit to spending some time on install guide next week (tues/weds/thurs)? If so I'll try to commit to it as well, and we could even have a short chat to split up the work | 15:26 |
JayF | mat128: two folks working on it could make it be done in a hurry | 15:27 |
* jlvillal was happy to learn yesterday that he was approved to go the summit. Looking forward to seeing people again :) | 15:27 | |
*** moshele has quit IRC | 15:27 | |
mat128 | JayF: sure, let me check my agenda | 15:27 |
sambetts | \o/ | 15:27 |
* JayF is not likely to be at the summit this year | 15:27 | |
sambetts | :( | 15:27 |
jlvillal | :( | 15:27 |
JayF | erm, cycle | 15:27 |
JayF | things can always change, maybe someone will find a few pennies and a plane ticket in a couch cushion | 15:27 |
mat128 | JayF: mostly free next week, besides wednesday PM edt | 15:28 |
JayF | mat128: I'm PDT, fwiw | 15:28 |
mat128 | I know :) | 15:29 |
*** causten has joined #openstack-ironic | 15:29 | |
mat128 | JayF: send me an invite for what works best for you | 15:29 |
JayF | mat128: lets chat Tues early? like 8am PT / 11am ET? | 15:29 |
JayF | mat128: timeboxed to 30m | 15:29 |
mat128 | ok sure | 15:29 |
mat128 | Let's see if this technology works as intended :) | 15:30 |
*** sabeen has quit IRC | 15:30 | |
*** causten has quit IRC | 15:31 | |
*** sabeen has joined #openstack-ironic | 15:33 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Fix ironic-multitenant-network job https://review.openstack.org/363666 | 15:34 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add unit tests for OSC plugin https://review.openstack.org/363752 | 15:34 |
JayF | vsaienk0: looking | 15:34 |
vsaienk0 | jroll https://review.openstack.org/#/c/363666/ patch to fix multinode-job | 15:34 |
vsaienk0 | I meant multitenancy | 15:35 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Fix ironic-multitenant-network job https://review.openstack.org/363666 | 15:36 |
*** tesseract- has quit IRC | 15:36 | |
jroll | vsaienk0: did that end up working? | 15:37 |
jroll | anyway, +2 | 15:38 |
jlvillal | lucasagomes: random question. Do you think the api code could use some refactoring? I notice a lot of cut-n-paste on the portgroups patch. Not anything I want to tackle now. But maybe in the future. | 15:38 |
vsaienk0 | jroll: yes http://logs.openstack.org/66/363666/2/check/gate-tempest-dsvm-ironic-multitenant-network/b8d93d2/console.html | 15:39 |
jlvillal | vsaienk0: Great work! You rock :) | 15:39 |
jroll | vsaienk0: \o/ | 15:39 |
jroll | someone else pls review 363666 | 15:39 |
mat128 | on it | 15:39 |
jroll | jlvillal: it totally could | 15:39 |
lucasagomes | jlvillal, hi there. I think so, even before the portgroups | 15:39 |
JayF | I was going to wait for ci but | 15:40 |
JayF | shrug | 15:40 |
jroll | jlvillal: I started down the path fo refactoring a ton of stuff one day in december when I was bored... but decided to wait and not conflict with multitenant work | 15:40 |
jroll | now it's 8 months old, need to re-do it all | 15:40 |
jlvillal | heh | 15:40 |
*** sdake_ is now known as sdake | 15:40 | |
openstackgerrit | Merged openstack/ironic-inspector: Change asserts with more specific assert methods. https://review.openstack.org/363601 | 15:40 |
jlvillal | Yeah, while reviewing the portgroup stuff I notice a lot of it is just copied with little changes. | 15:41 |
jroll | jlvillal: I think we can do better than just making some of it common, feels like a lot of that doesn't belong in the api layer | 15:41 |
jroll | like, we could move some things into the object layer | 15:42 |
jlvillal | Ah | 15:42 |
mat128 | JayF: I think it won't merge without a Verified +1 | 15:43 |
mat128 | even with workflow +1 | 15:43 |
JayF | mat128: Actually, not without a V+2 | 15:43 |
mat128 | at least it doesnt merge downstream on those cases | 15:43 |
mat128 | True :) | 15:43 |
JayF | mat128: when you approve a patch like that before even check has run, it runs the check, V+1, then it runs the gate, V+2 | 15:44 |
mat128 | yeah, what I meant was | 15:44 |
*** mgoddard has joined #openstack-ironic | 15:44 | |
JayF | mat128: but generally when a patch is "fixes the gate" I usually base my vote 80% on "is the gate fixed?" lol | 15:44 |
mat128 | no need to wait for verified before voting | 15:44 |
mat128 | true :P | 15:44 |
jroll | unless you want to pay attention to non-voting things :) | 15:44 |
openstackgerrit | Andrey Shestakov proposed openstack/ironic: IPMI command should depends on console type https://review.openstack.org/363647 | 15:44 |
*** mgoddard__ has quit IRC | 15:45 | |
*** ashestakov has joined #openstack-ironic | 15:46 | |
ashestakov | hi all | 15:46 |
openstackgerrit | Sofiia Andriichenko proposed openstack/python-ironicclient: Negative tests for testing actions with node: https://review.openstack.org/361583 | 15:46 |
ashestakov | could you review please review fix for Socat console https://review.openstack.org/#/c/363647/ | 15:47 |
*** ashestakov has quit IRC | 15:48 | |
JayF | dive bomb review request | 15:49 |
dtantsur | lol | 15:50 |
*** michauds has quit IRC | 15:51 | |
*** praneshp has joined #openstack-ironic | 15:53 | |
*** rcernin has joined #openstack-ironic | 15:54 | |
openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Negative tests for testing actions with node: https://review.openstack.org/361583 | 15:57 |
lucasagomes | apparently seeting CONF.pecan_debug=True does nothing... | 15:59 |
lucasagomes | *sigh* | 15:59 |
*** ElCoyote_ has quit IRC | 15:59 | |
jlvillal | lucasagomes: :( | 15:59 |
*** ElCoyote_ has joined #openstack-ironic | 16:00 | |
jlvillal | lucasagomes: You could try to debug that issue. :P | 16:00 |
JayF | pecan_debug_debug=True might help | 16:00 |
lucasagomes | jlvillal, lol yeah checking it now | 16:00 |
lucasagomes | but urgh so annoying heh cause I wnated to check another problem by enabling that debug level | 16:00 |
jroll | friendly reminder to review https://review.openstack.org/#/q/status:open+project:openstack/python-ironicclient+branch:master+topic:bug/1526479 today | 16:00 |
jroll | lucasagomes: it doesn't ?! | 16:00 |
jlvillal | lucasagomes: Sounds like you will go do some yak-shaving :( | 16:01 |
lucasagomes | jroll, so I've enabled it "2016-08-29 23:42:58.153 DEBUG oslo_service.service [-] pecan_debug = True" | 16:01 |
lucasagomes | and all I see are INFO logs from the wsgi services | 16:01 |
lucasagomes | I was expecting to see some headers there | 16:01 |
dtantsur | jroll, nothing of this can land right now... | 16:01 |
jroll | lucasagomes: er, what are you trying to get out of that, it just puts pecan in debug mode, which afaik just means you get a python shell if you get a 500 in a browser | 16:01 |
jroll | dtantsur: why not? | 16:02 |
dtantsur | jroll, 2 have -1's, the third depends on -1'ed one | 16:02 |
jroll | dtantsur: this doesn't depend on anything https://review.openstack.org/#/c/359322/ | 16:02 |
jroll | also, the one I -1'd I'd like more feedback | 16:02 |
jroll | I -1'd for the command | 16:02 |
dtantsur | jroll, ah hmm, I got confused by the shiny gerrit UI (again) | 16:03 |
dtantsur | will review now | 16:03 |
JayF | just landed 359322 | 16:03 |
lucasagomes | jroll, hmm I was trying to get more info about the requests... but if that means just given a shell in the browser it kinda sucks... perhaps we need to have a better help message for it | 16:03 |
jroll | dtantsur: thanks | 16:03 |
*** trown is now known as trown|brb | 16:03 | |
dtantsur | gah, too late, moving to the next :D | 16:03 |
jroll | lucasagomes: let me look at the docs and see what it does | 16:03 |
jroll | lucasagomes: "Enables the ability to display tracebacks in the browser and interactively debug during development" https://pecan.readthedocs.io/en/latest/configuration.html#application-configuration | 16:04 |
*** michauds has joined #openstack-ironic | 16:04 | |
lucasagomes | jroll, :-( | 16:05 |
lucasagomes | not that useful for me then | 16:05 |
*** mkam has joined #openstack-ironic | 16:05 | |
*** devananda|MOVING is now known as devananda | 16:05 | |
lucasagomes | well maybe... | 16:05 |
jroll | lucasagomes: debug=True should get you what you need I think? | 16:05 |
jroll | idk what you're looking for | 16:05 |
lucasagomes | jroll, it's already in debug=True, I will dig into it... Nothing specific I'm looking at an unrelated problem and just wanted to have more information about the request in the API | 16:06 |
*** ildikov has quit IRC | 16:06 | |
lucasagomes | like what (micro)version was requested etc | 16:06 |
lucasagomes | basically the headers if possible | 16:06 |
jroll | lucasagomes: ah, I see | 16:06 |
jroll | https://github.com/pecan/pecan/blob/30765981e18543bdcc7e11b4df546055ae93defd/pecan/middleware/debug.py | 16:07 |
lucasagomes | (I can get it from the client in debug mode, but I wish I could see in the server) | 16:07 |
dtantsur | jroll, commented on 362047 | 16:07 |
jroll | is what it does, just different exception handling | 16:07 |
xavierr | random question: do we will someday migrate from pecan to flask or something like? | 16:07 |
lucasagomes | jroll, saw this too https://github.com/pecan/pecan/blob/30765981e18543bdcc7e11b4df546055ae93defd/pecan/__init__.py#L54-L55 | 16:07 |
jroll | dtantsur: thanks | 16:07 |
jroll | xavierr: I would like to, yes | 16:08 |
jroll | lucasagomes: this makes me think, it'd be easy to write a little middleware to log headers | 16:08 |
*** trown|brb is now known as trown | 16:08 | |
lucasagomes | yeah possibly | 16:08 |
lucasagomes | that would be useful and would help me with the OOO CI problem I'm investigating | 16:09 |
lucasagomes | anyway... thanks for clarifying the pecan_debug jroll | 16:09 |
jroll | yeah, no problem :) | 16:09 |
xavierr | jroll: what is need to the migration? just a rfe? | 16:10 |
jroll | xavierr: not sure, might be worth a spec | 16:10 |
dtantsur | I would say, we need a complete test suite covering all the small behaviors in our API | 16:10 |
jroll | yeah | 16:11 |
dtantsur | so that we can check we don't break someone using it in an unusual way | 16:11 |
jroll | it will be a not small effort | 16:11 |
*** links has joined #openstack-ironic | 16:11 | |
xavierr | ok jroll | 16:11 |
*** Sukhdev has joined #openstack-ironic | 16:11 | |
openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Add openstack baremetal driver commands https://review.openstack.org/350050 | 16:12 |
*** linuxgeek has quit IRC | 16:12 | |
*** ianw has quit IRC | 16:13 | |
*** fragatin_ has quit IRC | 16:14 | |
rloo | dtantsur, jroll: wrt osc driver commands, i just updated one of the patches, https://review.openstack.org/#/c/350050/ | 16:16 |
jroll | rloo: yep, looking now | 16:16 |
*** Sukhdev has quit IRC | 16:17 | |
rloo | dtantsur, jroll: might be useful to look at that, to prepare for our RAID-properties discussion :) | 16:17 |
rloo | dtantsur, jroll: let me know what you think of 'openstack baremetal driver show --properties' | 16:17 |
*** fragatina has joined #openstack-ironic | 16:18 | |
jroll | rloo: any reason why not 'openstack baremetal driver properties show"? (was this one in the spec? raid thing was nto) | 16:18 |
rloo | jroll: yeah, the properties was in the spec, in the updated version last? week. | 16:18 |
rloo | jroll: the raid one, was something i was thinking about on monday | 16:18 |
jroll | ah | 16:18 |
rloo | jroll: the reason is cuz of osc 'philosophy' and how to fit our stuff into it | 16:19 |
jroll | rloo: I mean I'm fine with either, just curious | 16:19 |
*** ksumit has joined #openstack-ironic | 16:19 | |
rloo | jroll: i mean, wouldn't you think 'openstack baremetal driver show' would also show the properties and RAID stuff? why a separate command to just 'see' that info | 16:20 |
*** ksumit has quit IRC | 16:20 | |
jroll | rloo: sure | 16:20 |
rloo | jroll: they aren't 'objects' that we can do anything to | 16:20 |
*** ijw has joined #openstack-ironic | 16:20 | |
jroll | yeah, that's fair | 16:20 |
*** ksumit has joined #openstack-ironic | 16:20 | |
rloo | jroll: but honestly, it is somewhat fuzzy to me. osc seems to want to pin down the openstack 'objects' blah blah. | 16:21 |
jroll | rloo: yeah, it's weird. I'm good with what we have there | 16:21 |
*** ksumit has quit IRC | 16:21 | |
rloo | jroll: hence, even my question about separate cmds for maintenance | 16:21 |
jroll | mhm | 16:21 |
*** fragatina has quit IRC | 16:22 | |
dtantsur | my problem is largely with the same command outputting completely different things based on flags | 16:22 |
*** moshele has joined #openstack-ironic | 16:22 | |
rloo | jroll: i also didn't put an osc command for ironic node-show-states | 16:22 |
*** fragatina has joined #openstack-ironic | 16:22 | |
dtantsur | if we talk about objects, "openstack baremetal driver show" acts on "openstack baremetal driver" object | 16:22 |
dtantsur | so any kinds of "show" commands on it must display this object | 16:22 |
dtantsur | this is my take on it, but I may be wrong | 16:23 |
dtantsur | rloo, ^^ | 16:23 |
dtantsur | imagine in Python: driver.show() shows a driver, but driver.show(raid=True) returns something completely different | 16:23 |
rloo | dtantsur: yeah, i agree with that too. 'properties' is part of the driver object though. | 16:23 |
*** gzholtkevych has joined #openstack-ironic | 16:24 | |
rloo | dtantsur, jroll: maybe we can take out properties/raid stuff and deal with it later then. | 16:24 |
dtantsur | I don't quite remember our drivers having properties.. but anyway, if we append anything to a driver object, I'm fine with it | 16:24 |
dtantsur | I'm only not fine with just outputting a different thing with different columns, etc | 16:24 |
*** ijw has quit IRC | 16:24 | |
rloo | dtantsur: the 'properties' is driver_info stuff | 16:25 |
rloo | dtantsur: what can be in driver_info, and description | 16:25 |
dtantsur | aha | 16:25 |
rloo | dtantsur: i was tempted to put '(driver_info)' in the help | 16:25 |
dtantsur | so, if "openstack baremetal driver show --properties" shows both regular driver fields and these properties, that sounds fine | 16:25 |
dtantsur | but such output will be inconvenient, I'm afraid | 16:25 |
*** moshele has quit IRC | 16:26 | |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Update release note formatting and change 'P' to 'Pike' https://review.openstack.org/363790 | 16:26 |
dtantsur | that's why I vote for "openstack baremetal driver properties show": it's relatively clean and it seems practical to me | 16:26 |
rloo | dtantsur: i could do that too but it could get messy. the property descriptions can be very long, and i'm not sure how to separate those from the normal driver info, if they are all in the same table | 16:26 |
jlvillal | rloo: You might like or hate the patch I just proposed ^^^ :) | 16:26 |
rloo | dtantsur: are you OK if I just remove properties from the patch. I'm fine dealing with it after this release. i think we need to talk to osc folks or someone needs to think more about it. | 16:27 |
dtantsur | rloo, totally fine | 16:27 |
rloo | dtantsur: i'd rather postpone, than do a command that we will deprecate | 16:27 |
dtantsur | better less but better :) | 16:27 |
rloo | dtantsur: yeah. | 16:27 |
jroll | jlvillal: I'd rather you update https://review.openstack.org/#/c/362870/3 | 16:28 |
rloo | jlvillal: if it is release notes, jroll has a patch to update release notes | 16:28 |
jroll | :) | 16:28 |
rloo | jlvillal: ^^ that :) | 16:28 |
jlvillal | Ah! | 16:28 |
NobodyCam | Good Morning Ironic'ers :) | 16:28 |
dtantsur | morning NobodyCam | 16:28 |
gzholtkevych | SoI wrote also the patch for this action https://review.openstack.org/#/c/362047/ , will rebase it soon, please, notify me, if you need sth specific ^) | 16:28 |
NobodyCam | morning dtantsur :) | 16:28 |
*** jpich has quit IRC | 16:29 | |
jroll | gzholtkevych: there's some comments there | 16:29 |
NobodyCam | morning jroll :) | 16:29 |
jroll | hey NobodyCam :) | 16:29 |
*** dprince has joined #openstack-ironic | 16:30 | |
jroll | jlvillal: I'm not sure those need inline literals though | 16:30 |
NobodyCam | got a off the wall question... what are your thoughts on adding building config drives in to something like ironic-lib | 16:30 |
jlvillal | jroll: They might not. I think they look better. | 16:31 |
dtantsur | NobodyCam, haven't we done it already? | 16:31 |
jroll | jlvillal: if it's in a paragraph, I agree, where they are now, not so much | 16:31 |
NobodyCam | lol I must have totally missed that.. /me goes to tool | 16:31 |
NobodyCam | look even | 16:31 |
jlvillal | jroll: Since they are commands that would be typed on the command line. So I thought they would look better as inline literals | 16:31 |
NobodyCam | morning jlvillal :) | 16:31 |
jlvillal | Hey NobodyCam | 16:32 |
NobodyCam | :) | 16:32 |
jroll | jlvillal: meh | 16:33 |
jroll | NobodyCam: python-ironicclient/ironicclient/common/utils.py def make_configdrive() | 16:33 |
*** linuxgeek has joined #openstack-ironic | 16:34 | |
NobodyCam | doh :p | 16:34 |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Clean up release notes for 1.7 https://review.openstack.org/362870 | 16:34 |
NobodyCam | TY jroll | 16:34 |
NobodyCam | and dtantsur | 16:34 |
jlvillal | jroll: Minor change ^^ | 16:34 |
jroll | np | 16:34 |
*** gfhellma has joined #openstack-ironic | 16:34 | |
jroll | jlvillal: ++ | 16:34 |
vdrok | good morning NobodyCam | 16:37 |
NobodyCam | morning vdrok :) | 16:38 |
*** gfhellma has quit IRC | 16:38 | |
jlvillal | jroll: As an FYI, how it looks with the inline literals: http://docs-draft.openstack.org/90/363790/1/check/gate-python-ironicclient-releasenotes/93b9a4b//releasenotes/build/html/current-series.html | 16:39 |
*** aswadr_ has joined #openstack-ironic | 16:39 | |
openstackgerrit | Merged openstack/python-ironicclient: Add node validate OSC command https://review.openstack.org/359322 | 16:42 |
*** ianw has joined #openstack-ironic | 16:43 | |
*** Romanenko_K has quit IRC | 16:43 | |
*** lucasagomes has quit IRC | 16:44 | |
jroll | jlvillal: right, I'm aware, I don't think it's hugely important | 16:45 |
*** lucasagomes has joined #openstack-ironic | 16:46 | |
*** daemontool has joined #openstack-ironic | 16:50 | |
jlvillal | jroll: Okay. I agree, not that important | 16:51 |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Change 'P' to 'Pike' when refering to a release https://review.openstack.org/363808 | 16:55 |
jroll | jlvillal: seems like you dropped --chassis there: https://review.openstack.org/#/c/363808/1/ironicclient/osc/v1/baremetal_node.py | 16:56 |
jlvillal | jroll: Strange? | 16:57 |
jlvillal | jroll: Oh, I know. Foolishly copied stuff around... Thanks! | 16:57 |
* jlvillal grumbles at himself | 16:57 | |
*** trown is now known as trown|lunch | 16:58 | |
derekh | what the best way to "nova boot .. <id>...." where <id> is a specific baremetal node? | 16:59 |
*** joprovost has joined #openstack-ironic | 16:59 | |
jroll | derekh: that isn't a supported thing, you could hack nova to add a node scheduler hint, or make a flavor that only matches one node | 16:59 |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Don't write python bytecode while testing https://review.openstack.org/363813 | 16:59 |
jroll | derekh: why'd you want to do that, just curious | 16:59 |
*** mgoddard_ has joined #openstack-ironic | 17:00 | |
jroll | jlvillal: qa meeting this week or nah? | 17:00 |
* jroll would almost prefer not | 17:00 | |
jlvillal | jroll: Okay. I can do not. | 17:01 |
jlvillal | jroll: Not much to add | 17:01 |
derekh | jroll: I'm trying to boot a each node with a specific IP address, to do that I've precreated a neutron port with the MAC of the node | 17:01 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Introducing node introspection state management https://review.openstack.org/348943 | 17:01 |
derekh | jroll: now I need to nova boot using a specific port and baremetal node | 17:01 |
jroll | derekh: ah :/ | 17:02 |
*** ohamada has quit IRC | 17:03 | |
*** mgoddard has quit IRC | 17:03 | |
vdrok | derekh: I've seen this one in nova code https://github.com/openstack/nova/blob/faeede29795d1eeee241d50f8521431e30ed540f/nova/objects/request_spec.py#L56 but don't really know how to use it | 17:03 |
vdrok | that's only for specifying a node tho | 17:04 |
derekh | vdrok: thanks, will take a look at it | 17:05 |
openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Add openstack baremetal driver commands https://review.openstack.org/350050 | 17:05 |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Change 'P' to 'Pike' when refering to a release https://review.openstack.org/363808 | 17:05 |
JayF | jroll: is our downstream code to do that too obtuse to share with derekh? | 17:07 |
openstackgerrit | Merged openstack/ironic-python-agent: Use namedtuple to improve code readability https://review.openstack.org/361788 | 17:07 |
jroll | JayF: it's probably fine, if he wants to hack nova | 17:08 |
derekh | JayF: jroll am interested, gotta catch a train now, so just link it here and I'll see it in the logs or send it on if you can | 17:08 |
*** derekh has quit IRC | 17:09 | |
sambetts | jroll: do you know if there is a way to retroactivly add a reno release note? | 17:10 |
rloo | hi lucasagomes: wrt https://review.openstack.org/#/c/350050/13/ironicclient/osc/v1/baremetal_driver.py, ._info is used elsewhere so i wanted to clean that all up in a separate path. the .to_dict() makes a copy of the dict which I'm not happy with | 17:10 |
vdrok | sambetts: if the release happened already I think no | 17:10 |
jroll | sambetts: to a previous tag? probably not, but could try asking #openstack-release | 17:10 |
lucasagomes | rloo, oh right, yeah that should be fine | 17:10 |
sambetts | jroll, vdrok: Ah cool thanks :) | 17:11 |
rloo | lucasagomes: ok thx. i'll add a comment about that. thx for reviewing | 17:11 |
lucasagomes | it just looks like a layer violation at the moment to use a private method outside | 17:11 |
lucasagomes | rloo, FIXME | 17:11 |
openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Add openstack baremetal driver commands https://review.openstack.org/350050 | 17:11 |
rloo | lucasagomes: OH, i just pushed up a patch. I'll add a fixme... | 17:12 |
lucasagomes | rloo, heh no bothers | 17:12 |
rloo | lucasagomes: ok. i'm going to open a bug about it one of these today/tomorrow :) | 17:12 |
lucasagomes | rloo, thanks for the new test as well | 17:12 |
* lucasagomes +2'd | 17:13 | |
*** e0ne has quit IRC | 17:16 | |
rloo | lucasagomes: you are fast! thx! | 17:16 |
lucasagomes | rloo, just reviewer the diff 13..15 | 17:16 |
lucasagomes | reviewed* | 17:17 |
* jroll is reviewing now as well | 17:17 | |
lucasagomes | and I will call it a day here | 17:18 |
lucasagomes | have a great evening all | 17:18 |
rloo | thx lucasagomes, have a good evening! | 17:18 |
lucasagomes | ty, you too | 17:19 |
*** lucasagomes is now known as lucas-dinner | 17:19 | |
*** rama_y has joined #openstack-ironic | 17:19 | |
jlvillal | lucas-dinner: Ciao | 17:20 |
jroll | rloo: +W | 17:23 |
jroll | rloo: anything else we want in besides that one and reno cleanup? | 17:24 |
jroll | jlvillal: +W on pike release | 17:24 |
jroll | pike release thing* | 17:24 |
jlvillal | jroll: thanks | 17:24 |
jroll | np, thanks for doing that | 17:25 |
jlvillal | My pleasure | 17:25 |
rloo | jroll: personally no. there are a lot of test patches. | 17:26 |
jroll | yeah, I see those. not worried about it. | 17:27 |
jroll | would be nice to do the release today | 17:27 |
* jroll updates the reno update | 17:27 | |
dtantsur | jroll, could you please also release the inspector client? | 17:27 |
jroll | dtantsur: yeah, ready to go now? | 17:28 |
jroll | and mind if I wait and do both at once? | 17:28 |
dtantsur | jroll, also note, both clients have an update proposed for their constraints scripts | 17:28 |
jroll | oh, blah | 17:28 |
*** ksumit has joined #openstack-ironic | 17:28 | |
rloo | jroll: there is the 'switch to admin_token auth'.. https://review.openstack.org/#/c/359061/ | 17:28 |
dtantsur | jroll, whenever it's convenient for you. we're ready modulo this tox_install.sh thingy | 17:28 |
jroll | dtantsur: got links to those? | 17:29 |
rloo | vdrok: is https://review.openstack.org/#/c/359061/ something that you think is important for this week's client release? | 17:29 |
dtantsur | jroll, inspector: https://review.openstack.org/363071 | 17:29 |
dtantsur | jroll, ironic: https://review.openstack.org/363069 | 17:29 |
vdrok | rloo: that would be nice to have, tho not that critical | 17:29 |
jroll | thanks | 17:29 |
* jroll +2 on both | 17:30 | |
rloo | btw jroll, jlvillal: wrt https://review.openstack.org/#/c/363808/, we can't delete those commands in Pike | 17:31 |
jroll | rloo: weren't those deprecated in mitaka? | 17:31 |
jroll | ugh, no, they weren't | 17:32 |
rloo | jroll: i need to check. i thought they were deprecated in n. but maybe the osc stuff has taken longer than i remember. | 17:32 |
jroll | rloo: you're right | 17:32 |
rloo | jroll: then i need to do the numbers, 1 year blah blah. have to read what dean troyer said again. | 17:32 |
jroll | rloo: yeah, so it was wrong in the first place, we should update it but not a blocker imo | 17:33 |
*** AJaeger has joined #openstack-ironic | 17:33 | |
rloo | jroll: yeah, not a blocker. although.. can we still update that release note? the one in that patch? | 17:33 |
*** mariojv has joined #openstack-ironic | 17:33 | |
AJaeger | jroll, dtantsur : You both gave a +2 at the same time on https://review.openstack.org/#/c/363069/ - thanks. Could either of you +A as well, please? | 17:33 |
*** mari0jv has quit IRC | 17:34 | |
jroll | AJaeger: I will, yes, don't worry | 17:34 |
jroll | AJaeger: working on coordinating client releases now, will make sure that gets in | 17:34 |
dtantsur | AJaeger, already | 17:34 |
AJaeger | jroll: ah ;) | 17:34 |
AJaeger | thanks | 17:34 |
dtantsur | just decided to double-check everything locally :) | 17:34 |
dtantsur | now both approved | 17:34 |
AJaeger | sure! | 17:34 |
jroll | woot | 17:34 |
* vdrok leaves | 17:35 | |
dtantsur | jroll, when it merges, ironic-inspector-client is ready for release | 17:35 |
vdrok | good night everyone! | 17:35 |
dtantsur | g'night vdrok | 17:35 |
dtantsur | and I'm also calling it a day now | 17:36 |
jlvillal | dtantsur: Good night | 17:36 |
vdrok | night dtantsur :) | 17:36 |
jroll | dtantsur: excellent, thank you and good night :) | 17:36 |
AJaeger | night, dtantsur | 17:36 |
rloo | good night vdrok, dtantsur | 17:36 |
dtantsur | g'night! | 17:36 |
* AJaeger waves good-bye as well... | 17:36 | |
*** dtantsur is now known as dtantsur|afk | 17:36 | |
*** AJaeger has left #openstack-ironic | 17:36 | |
*** bradjones has quit IRC | 17:38 | |
*** bradjones has joined #openstack-ironic | 17:38 | |
*** pcaruana has joined #openstack-ironic | 17:39 | |
*** bradjones is now known as Guest30374 | 17:39 | |
*** athomas has quit IRC | 17:39 | |
*** rpioso has quit IRC | 17:39 | |
*** mgoddard_ has quit IRC | 17:42 | |
rloo | jroll: those deprecated OSC commands were merged June 2 2016. | 17:42 |
rloo | jroll: osc guidelines: a minimum of one year (two major releases for the current schedules) following the first release of deprecation | 17:42 |
jroll | rloo: fun | 17:42 |
*** electrofelix has quit IRC | 17:42 | |
* sambetts -> home | 17:42 | |
sambetts | Night everyone! | 17:43 |
*** sambetts is now known as sambetts|afk | 17:43 | |
rloo | night sambetts|afk | 17:43 |
rloo | jroll: we released 1.4.0 on July 11, with those deprecated osc commands. So no sooner than July 11, 2017. | 17:45 |
*** yogi has quit IRC | 17:46 | |
jroll | rloo: okay | 17:46 |
rloo | jroll: maybe we should update that patch from jlvillal to that effect... | 17:46 |
rloo | jroll: although it seems to me that it is too late to update the reno anyway, even though jlvillal's patch updated it | 17:47 |
jroll | rloo: sure, or another patch, I'm not opinionated | 17:47 |
jroll | rloo: I think you can update renos, just not add | 17:47 |
rloo | jroll: oh, in that case, we should update the reno. | 17:47 |
rloo | jlvillal: you want to submit another patch ^^ ? :) | 17:48 |
jroll | rloo: sure, agree, should also update code | 17:48 |
jlvillal | rloo: Sure. but which patch do you want me to update? | 17:48 |
rloo | jlvillal: your p->pike patch. | 17:49 |
* jlvillal wanders in from a conference call | 17:49 | |
rloo | jlvillal: has to be changed cuz it isn't pike. it is something after july 11, 2017. | 17:49 |
jlvillal | Would that be Queens? | 17:49 |
rloo | jlvillal: i dunno, can't think that far | 17:49 |
jlvillal | Or Reginald? | 17:49 |
* jlvillal makes up future release names | 17:50 | |
jlvillal | rloo: All of them? Or some of them? | 17:50 |
JayF | why not just put in the date? | 17:50 |
JayF | The date is the real knowledge | 17:50 |
rloo | jlvillal: maybe it is pike. trying to do the math here. newton -> oct; ocata -> apr?, p -> oct 2017 | 17:50 |
rloo | JayF: yup, the date + the algorithm. | 17:51 |
jroll | +1 for a date | 17:51 |
jlvillal | JayF: Well grepping for the code name is easier to look for things to work on. | 17:51 |
jroll | the cycle doesn't matter, though, the date does | 17:51 |
jroll | you can do both if you like, but the date should be there | 17:51 |
rloo | we can do both. does pike look about right though? | 17:51 |
jlvillal | Okay | 17:52 |
jlvillal | I like both. | 17:52 |
jroll | nope, pike is done way before july | 17:52 |
jroll | should be Q | 17:52 |
jlvillal | Okay Queens | 17:52 |
rloo | jroll: so much for my math | 17:52 |
jlvillal | jroll: I -2 my patch. Hopefully that will make zuul stop | 17:53 |
jroll | jlvillal: it will | 17:53 |
*** rpioso has joined #openstack-ironic | 17:55 | |
openstackgerrit | Merged openstack/python-ironic-inspector-client: Sync tools/tox_install.sh https://review.openstack.org/363071 | 17:57 |
*** e0ne has joined #openstack-ironic | 17:59 | |
openstackgerrit | Merged openstack/python-ironicclient: Sync tools/tox_install.sh https://review.openstack.org/363069 | 17:59 |
*** sabeen has quit IRC | 18:00 | |
*** causten has joined #openstack-ironic | 18:00 | |
*** trown|lunch is now known as trown | 18:02 | |
*** ksumit has quit IRC | 18:02 | |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Change 'P' to 'Queens' and add deprecation date https://review.openstack.org/363808 | 18:04 |
jlvillal | rloo: jroll ^^^^ | 18:04 |
*** ksumit has joined #openstack-ironic | 18:04 | |
jlvillal | nevermind! | 18:05 |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Change 'P' to 'Queens' and add deprecation date https://review.openstack.org/363808 | 18:06 |
jlvillal | jroll: rloo Okay I think it looks good to me ^^ | 18:08 |
*** srobert has joined #openstack-ironic | 18:11 | |
*** ksumit has quit IRC | 18:13 | |
*** rbrud has quit IRC | 18:13 | |
*** e0ne has quit IRC | 18:21 | |
*** e0ne has joined #openstack-ironic | 18:22 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/bifrost: Updated from global requirements https://review.openstack.org/363859 | 18:23 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/363863 | 18:25 |
openstackgerrit | Merged openstack/ironic: Fix ironic-multitenant-network job https://review.openstack.org/363666 | 18:25 |
*** sabeen has joined #openstack-ironic | 18:26 | |
*** Sukhdev has joined #openstack-ironic | 18:27 | |
jlvillal | Woo hoo, working gate! :) | 18:29 |
*** causten_ has joined #openstack-ironic | 18:29 | |
thiagop | o/ | 18:29 |
*** causten__ has joined #openstack-ironic | 18:30 | |
jroll | nice | 18:30 |
jroll | vsaienk0: thanks for that \o/ | 18:30 |
*** amotoki has quit IRC | 18:31 | |
jroll | jlvillal: +2 | 18:31 |
jroll | thanks | 18:31 |
jlvillal | jroll: You're welcome. Glad to help | 18:32 |
*** causten has quit IRC | 18:33 | |
openstackgerrit | Merged openstack/python-ironicclient: Add openstack baremetal driver commands https://review.openstack.org/350050 | 18:33 |
jroll | sweeeeet | 18:34 |
*** causten_ has quit IRC | 18:34 | |
*** dprince has quit IRC | 18:36 | |
*** ksumit has joined #openstack-ironic | 18:37 | |
*** moshele has joined #openstack-ironic | 18:40 | |
*** _milan_ has joined #openstack-ironic | 18:42 | |
*** milan has quit IRC | 18:43 | |
*** Sukhdev has quit IRC | 18:43 | |
*** aNupoisc has joined #openstack-ironic | 18:45 | |
*** adnavare has joined #openstack-ironic | 18:46 | |
*** sabeen has quit IRC | 18:49 | |
rloo | :D | 18:50 |
*** ijw has joined #openstack-ironic | 18:57 | |
*** moshele has quit IRC | 18:59 | |
*** dprince has joined #openstack-ironic | 18:59 | |
*** causten__ has quit IRC | 19:00 | |
*** ildikov has joined #openstack-ironic | 19:01 | |
rloo | jroll: is it fair (or reasonable) to consider the OSC work/spec as done https://bugs.launchpad.net/ironic/+bug/1526479, and for me to open separate rfe's/bugs for outstanding stuff? (After I update the spec to reflect what was merged in client) | 19:02 |
openstack | Launchpad bug 1526479 in python-ironicclient "[RFE] Implementation of ironic commands as an OSC plugin" [Wishlist,In progress] - Assigned to Ruby Loo (rloo) | 19:02 |
jroll | rloo: yes, I think so | 19:03 |
JayF | \o/ | 19:03 |
rloo | jroll: ok, i'll do that tidying up then :) | 19:03 |
jroll | awesome, thanks! | 19:03 |
jroll | I'm finishing up renos but keep getting distracted | 19:03 |
rloo | jroll: oh, ping me when you have the next patch set and i'll look at it | 19:04 |
jroll | sure thing | 19:04 |
*** ifarkas is now known as ifarkas_afk | 19:11 | |
*** links has quit IRC | 19:13 | |
openstackgerrit | Fatih Degirmenci proposed openstack/bifrost: Fix log collection when VMs are created with non-default names https://review.openstack.org/363896 | 19:14 |
openstackgerrit | Merged openstack/python-ironicclient: Change 'P' to 'Queens' and add deprecation date https://review.openstack.org/363808 | 19:15 |
openstackgerrit | Jim Rollenhagen proposed openstack/python-ironicclient: Clean up release notes for 1.7 https://review.openstack.org/362870 | 19:16 |
*** mkam has quit IRC | 19:16 | |
jroll | rloo: ^ | 19:16 |
JayF | I'm looking too | 19:17 |
jroll | jlvillal: ^ also I decided you were right about the literals thing, sorry for fighting you on that | 19:17 |
rloo | jroll: looking... | 19:17 |
openstackgerrit | Pierre Riteau proposed openstack/ironic: Replace DOS line endings with UNIX https://review.openstack.org/363900 | 19:18 |
*** fragatin_ has joined #openstack-ironic | 19:18 | |
jroll | thanks | 19:19 |
rloo | ^^ no way. Who put DOS stuff? | 19:19 |
jroll | lol | 19:20 |
jroll | does gerrit not show that? | 19:20 |
*** e0ne has quit IRC | 19:20 | |
JayF | I was more wondering if gerrit inline editing was what /did/ that | 19:20 |
* jroll confirmed, that was dos | 19:20 | |
rloo | no idea, but clearly someone detected it! | 19:20 |
rloo | JayF: that would be horrible | 19:20 |
jroll | JayF: I'd hope not | 19:20 |
jlvillal | jroll, Thanks for the update | 19:20 |
openstackgerrit | Pierre Riteau proposed openstack/ironic: Replace DOS line endings with Unix https://review.openstack.org/363900 | 19:21 |
*** fragatina has quit IRC | 19:22 | |
*** daemontool has quit IRC | 19:23 | |
priteau | Thanks jroll for the quick review! | 19:24 |
jroll | priteau: np, I couldn't resist :) | 19:24 |
*** jvgrant_ has quit IRC | 19:25 | |
jroll | stepping away for a bit | 19:26 |
*** ksumit has quit IRC | 19:27 | |
*** mkam has joined #openstack-ironic | 19:27 | |
*** jvgrant has joined #openstack-ironic | 19:28 | |
*** ksumit has joined #openstack-ironic | 19:28 | |
*** aswadr_ has quit IRC | 19:31 | |
*** sdake_ has joined #openstack-ironic | 19:32 | |
*** ksumit has quit IRC | 19:32 | |
*** sdake has quit IRC | 19:33 | |
*** sdake has joined #openstack-ironic | 19:35 | |
*** bfournie has left #openstack-ironic | 19:36 | |
*** sdake_ has quit IRC | 19:36 | |
*** moshele has joined #openstack-ironic | 19:42 | |
*** bfournie has joined #openstack-ironic | 19:42 | |
*** fragatin_ has quit IRC | 19:45 | |
*** fragatina has joined #openstack-ironic | 19:45 | |
*** aNupoisc has quit IRC | 19:49 | |
*** adnavare has quit IRC | 19:49 | |
*** causten has joined #openstack-ironic | 19:50 | |
*** praneshp has quit IRC | 19:56 | |
openstackgerrit | Pierre Riteau proposed openstack/ironic: Add a newline at the end of release note files https://review.openstack.org/363919 | 19:59 |
*** moshele has quit IRC | 20:00 | |
*** causten has quit IRC | 20:05 | |
*** moshele has joined #openstack-ironic | 20:11 | |
*** joprovost has quit IRC | 20:13 | |
openstackgerrit | Ruby Loo proposed openstack/ironic-specs: Update openstackclient commands https://review.openstack.org/363921 | 20:17 |
*** ksumit has joined #openstack-ironic | 20:25 | |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Clean up release notes for 1.7 https://review.openstack.org/362870 | 20:26 |
jlvillal | JayF: rloo: ^^^^ I pushed an updated patch. Updated based on Ruby's comment on my comment :) | 20:26 |
*** sabeen has joined #openstack-ironic | 20:27 | |
rloo | jlvillal: ok, looking | 20:27 |
JayF | +2, thanks! | 20:27 |
jlvillal | Thanks JayF | 20:27 |
* jlvillal wonders if Gerrit is slow for anyone else or does he need to restart Firefox | 20:28 | |
*** Goneri has quit IRC | 20:30 | |
*** ksumit has quit IRC | 20:30 | |
openstackgerrit | Oleksandr Berezovskyi proposed openstack/bifrost: Add possibility to set source branch for ironic-inspector https://review.openstack.org/363300 | 20:30 |
*** moshele has quit IRC | 20:31 | |
openstackgerrit | Oleksandr Berezovskyi proposed openstack/bifrost: Add possibility to set source branch for ironic-inspector https://review.openstack.org/363300 | 20:39 |
*** aNupoisc has joined #openstack-ironic | 20:40 | |
*** adnavare has joined #openstack-ironic | 20:40 | |
openstackgerrit | Oleksandr Berezovskyi proposed openstack/bifrost: Add possibility to set source branch for ironic-inspector https://review.openstack.org/363300 | 20:40 |
*** praneshp has joined #openstack-ironic | 20:46 | |
*** _milan_ has quit IRC | 20:49 | |
*** ksumit has joined #openstack-ironic | 20:52 | |
*** e0ne has joined #openstack-ironic | 20:56 | |
*** _mbelanger has quit IRC | 20:56 | |
jroll | wow, we're actually pretty close to done with feature work for the cycle | 20:57 |
thiagop | w00t | 20:57 |
jroll | bumped boot-from-volume, driver comp, rescue mode, root device hints, rolling upgrades to ocata | 20:57 |
jroll | and the nova part of serial console | 20:57 |
jroll | only portgroups/security groups have real code left | 20:57 |
jroll | oh and a notifications patch | 20:57 |
jroll | the rest is follow-up work, optimization/bug fixes, testing stuff | 20:57 |
JayF | I think notifications went through another round of design | 20:58 |
jroll | and we need to do the third party CI thing | 20:58 |
JayF | mariojv: ^ said he was going to update spec for next week | 20:58 |
jroll | ? | 20:58 |
jroll | -.- | 20:58 |
mariojv | it's not really a new design | 20:58 |
jroll | can we get that done this week? | 20:58 |
mariojv | just requiring a particular event_type and adding docs for each notification | 20:59 |
mariojv | jroll: yes | 20:59 |
jroll | awesome, ty | 20:59 |
mariojv | np | 20:59 |
jroll | I like the look of the trello board right now https://trello.com/b/ROTxmGIc/ironic-newton-priorities | 21:00 |
*** xavierr is now known as xavier_afk | 21:00 | |
*** baoli_ has quit IRC | 21:02 | |
*** baoli has joined #openstack-ironic | 21:03 | |
*** ksumit has quit IRC | 21:06 | |
*** mkam has quit IRC | 21:09 | |
*** priteau has quit IRC | 21:11 | |
*** jcoufal has quit IRC | 21:12 | |
JayF | jroll: I think we can mark keystone policy as done | 21:12 |
JayF | jroll: only outstanding thing is the test to enforce all new api endpoints get a policy | 21:12 |
JayF | jroll: which afaict is still pretty deep in dev | 21:12 |
*** jralph has quit IRC | 21:17 | |
jroll | JayF: there's the unit test thing I really want to get in | 21:18 |
*** e0ne has quit IRC | 21:18 | |
jroll | oh yeah, that thing you mentioned | 21:18 |
*** dprince has quit IRC | 21:19 | |
*** e0ne has joined #openstack-ironic | 21:19 | |
*** jralph has joined #openstack-ironic | 21:20 | |
*** e0ne has quit IRC | 21:20 | |
*** mkam has joined #openstack-ironic | 21:22 | |
*** joprovost has joined #openstack-ironic | 21:23 | |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic-python-agent: Add NTP configuration for the CoreOS image https://review.openstack.org/361146 | 21:27 |
jroll | JayF: ^ curious what you think about that one | 21:27 |
*** joprovost has quit IRC | 21:27 | |
*** praneshp has quit IRC | 21:28 | |
JayF | jroll: I think I'm -1 to it unless support it added to tinyipa as well :) | 21:28 |
jroll | :( | 21:29 |
* jroll wonders if ntp is even built in to tinyipa | 21:29 | |
JayF | it's probably not. | 21:30 |
jroll | yeah, that's going to rot for a while then | 21:30 |
JayF | I mean, I don't think we should add ntp to tinyipa either | 21:30 |
JayF | I kinda think if we need to do that upstream, we should get all builds gonig via dib to add/remove bits | 21:30 |
JayF | if that makes sense | 21:30 |
jroll | totally agree, I said tinyipa should be via dib from the start :P | 21:31 |
JayF | I mean, I'm not throwing anyone under that bus | 21:31 |
JayF | just saying if you want more than the basics, you should have to go to custom builds, if that makes sense | 21:31 |
openstackgerrit | Merged openstack/ironic: OneView test nodes to use dynamic allocation https://review.openstack.org/359990 | 21:31 |
openstackgerrit | Merged openstack/ironic: Allow suppressing ramdisk logs collection https://review.openstack.org/359381 | 21:32 |
JayF | if it was just "drop in a config" I'd feel different, but you have to use that awful bash script I wrote for downstream | 21:32 |
jroll | sure | 21:32 |
jroll | JayF: so per your comment... what do you think is the right path forward for this? | 21:33 |
jroll | comment sounds like "let's not do this" | 21:33 |
JayF | I think you file an RFE bug | 21:33 |
JayF | see if I'm the only person who feels that way | 21:33 |
JayF | if so, then jfdi and I'll review it | 21:33 |
JayF | if not, then it gets tabled | 21:33 |
jroll | until... ? | 21:33 |
JayF | I don't like being able to nuke a whole thing with a single comment | 21:34 |
JayF | until ever | 21:34 |
jroll | eh? | 21:34 |
JayF | meh | 21:35 |
JayF | I wonder what mat128 or wajdi thinks | 21:35 |
jroll | mat128 seemed excited about it and reviewed PS1 | 21:35 |
JayF | so maybe I'm in the minority then? | 21:35 |
jroll | idk | 21:35 |
jroll | I put this up because TheJulia had a node way out of whack | 21:35 |
jroll | and asked if we do anything | 21:35 |
jroll | figured I'd finish it | 21:35 |
JayF | can she file a bug about it? If we had an actual bug it was fixing I think I'd feel less gross about it | 21:36 |
jroll | I mean, it was the same bug we saw when we did this downstream | 21:36 |
jroll | SSL failure | 21:36 |
JayF | then we could file a bug to add time sync support (of some kind) to tinyipa as well at a later date/ | 21:36 |
jroll | I filed https://bugs.launchpad.net/ironic-python-agent/+bug/1619054 btw | 21:37 |
openstack | Launchpad bug 1619054 in ironic-python-agent "IPA images should use NTP to make sure the system clock is accurate" [Undecided,New] | 21:37 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic-python-agent: Add NTP configuration for the CoreOS image https://review.openstack.org/361146 | 21:38 |
*** cdearborn has quit IRC | 21:38 | |
wajdi | hey. Just saw the ping. Reading through. | 21:38 |
mat128 | same, was going for dinner | 21:39 |
mat128 | yeah NTP | 21:39 |
mat128 | I feel tinycore could benefit from a similar patch | 21:39 |
mat128 | JayF: I was recently exposed to diskimage-builder (because of the constraints thing) and there's no reason it can't work for us to build CoreOS/TinyCore images | 21:40 |
mat128 | and standardize what options are applied | 21:40 |
JayF | jroll: -1'd for technical reasons, but I feel like I'm in the minority so w/e IDC that much about doing it just for coreos for starters | 21:40 |
mat128 | the thing that made me decide it was useful, is for machine that dont even have time configured at all | 21:40 |
mat128 | lets say you receive a machine with time completely wrong | 21:41 |
mat128 | you aren't going to deliver it that way to a customer | 21:41 |
JayF | mat128: this is almost a straight copy from downstream, we had a whole cab of machines delivered with date set to epoch | 21:41 |
JayF | mat128: and it started failing ssl validation to our swift clutser | 21:41 |
mat128 | exactly my point | 21:41 |
mat128 | or | 21:41 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic-python-agent: Add NTP configuration for the CoreOS image https://review.openstack.org/361146 | 21:41 |
mat128 | previous customer changed hardware time | 21:41 |
jroll | JayF: fixed | 21:41 |
wajdi | If it is a concern about the code itself, maybe we can go through to see what improvements can be made in the code. Feature wise, I see good benefit in this. | 21:41 |
mat128 | maybe we can do it as a cleaning step? | 21:42 |
mat128 | idk | 21:42 |
jroll | not if you're talking to ironic over ssl to start up :) | 21:42 |
mat128 | ahh | 21:42 |
mat128 | right | 21:42 |
JayF | yeah; I just +1'd it | 21:42 |
mat128 | meh | 21:42 |
JayF | no +2 because it's mostly my code, lol | 21:42 |
rloo | jroll: what do you think? i'm on the fence about it -- should we mention in the client release notes, that we have OSC commands to support (almost) all something... | 21:42 |
mat128 | I'm fine with it but would like a bug to track feature parity with other oses | 21:43 |
wajdi | hehhe JayF implicit self-merge :P | 21:43 |
mat128 | honoring the same contract (cmdline "ntpservers=") | 21:43 |
jroll | rloo: what do you mean, like "this brings feature parity between 'ironic' and 'openstack baremetal' | 21:43 |
jroll | ? | 21:43 |
rloo | jroll: yeah, something like that. | 21:43 |
rloo | jroll: except it isn't quite there. dunno. | 21:43 |
jroll | rloo: idk, I'm fine either way | 21:43 |
rloo | jroll: forget it, i'd want it to say 'almost' feature parity... | 21:44 |
* mat128 signs off, mention me and I will see your messages tomorrow | 21:44 | |
jroll | yeah | 21:44 |
rloo | jroll: probably good enough for most people, but ... | 21:44 |
jroll | night mat128 \o | 21:44 |
rloo | bye mat128 | 21:44 |
*** praneshp has joined #openstack-ironic | 21:44 | |
wajdi | take care mat128 | 21:44 |
openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: [WIP]Reusing oneview_client when possible https://review.openstack.org/358041 | 21:44 |
*** thiagop has quit IRC | 21:46 | |
*** causten has joined #openstack-ironic | 21:46 | |
* TheJulia reads backscroll | 21:50 | |
jroll | still waiting for jenkins on my reno patch :( | 21:50 |
jroll | oh wow it's 6pm already | 21:50 |
wajdi | ^^yup....just had the same reaction a few minutes ago | 21:50 |
TheJulia | jroll: to be fair, it was more of a "Hey, anyone run into this before?" :) | 21:51 |
jroll | TheJulia: with my memory, seems like close enough | 21:51 |
JayF | mat128: jroll: Another reason, I just remembered, to not do it in a cleaning step: IPA very much dislikes when time is jumped while it's running | 21:53 |
jroll | ah yes | 21:55 |
wajdi | question from mat128 is whether DHCP option 42 was tested as a solution? | 21:55 |
JayF | yes, coreos doesn't respect it | 21:56 |
JayF | at least whatever old-ass version we were running then, lol | 21:56 |
wajdi | what version where you running with? | 21:56 |
JayF | That code jroll posted is years old | 21:56 |
TheJulia | JayF: jroll: w/r/t dib + ntp, I _think_ we may see a patch from one of our downstream folks be proposed upstream soon. Personally I kind of see it as an issue outside of IPA but something that operators should already be cognizant of with TLS in use on-prem, but that is just my $0.02. :) | 21:56 |
openstackgerrit | Nate House proposed openstack/ironic-python-agent: Implements: ironic_lib.metrics w/ old metrics sigs. https://review.openstack.org/363959 | 21:57 |
TheJulia | Wow, a cab of machines set to epoch... eek | 21:57 |
* natorious looks to see if anyone noticed | 21:57 | |
* JayF out for the day, be back tomorrow :) | 21:57 | |
JayF | natorious: starred for tomorrow ;) | 21:57 |
wajdi | take care JayF | 21:57 |
TheJulia | goodnight JayF | 21:57 |
*** anush__ has quit IRC | 21:58 | |
*** mkam has quit IRC | 22:11 | |
mrda | Morning Ironic | 22:14 |
TheJulia | good morning mrda | 22:14 |
mrda | o/ | 22:15 |
TheJulia | jroll: commented on 361146, one concern, and it is largely just to a lack of coreos understanding on my part. | 22:15 |
*** srobert has quit IRC | 22:20 | |
*** praneshp has quit IRC | 22:23 | |
*** Sukhdev has joined #openstack-ironic | 22:28 | |
*** Sukhdev has quit IRC | 22:34 | |
*** Sukhdev has joined #openstack-ironic | 22:45 | |
*** praneshp has joined #openstack-ironic | 22:52 | |
*** Sukhdev has quit IRC | 22:55 | |
*** causten has quit IRC | 22:56 | |
jlvillal | JayF: Regarding maybe ntpdate not in tinyipa. A pure python version http://code.activestate.com/recipes/117211-simple-very-sntp-client/ | 22:57 |
jlvillal | :) | 23:02 |
*** michauds has quit IRC | 23:11 | |
openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Enable OSProfiler support in Ironic https://review.openstack.org/358142 | 23:14 |
jroll | TheJulia: ooo, good point. I honestly don't know the answer to that | 23:18 |
TheJulia | jlvillal: nice, I actually think that would kind of work, conceptually at least as long as the software clock gets reset prior to ipa initiating a tls connection, but that would also be hard to do inside a container... and the hardware clock would need to be reset too :\ | 23:21 |
jlvillal | TheJulia: It looked interesting :) | 23:21 |
*** krtaylor has quit IRC | 23:22 | |
*** rpioso has quit IRC | 23:23 | |
openstackgerrit | Merged openstack/ironic: Metrics for ConductorManager https://review.openstack.org/352648 | 23:32 |
NobodyCam | morning mrda | 23:33 |
*** krtaylor has joined #openstack-ironic | 23:35 | |
mrda | hey NobodyCam | 23:35 |
NobodyCam | :) | 23:36 |
*** Sukhdev has joined #openstack-ironic | 23:41 | |
*** Sukhdev has quit IRC | 23:43 | |
*** yuanying has quit IRC | 23:43 | |
*** yuanying has joined #openstack-ironic | 23:44 | |
*** rama_y has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!