| *** sabeen has quit IRC | 00:03 | |
| *** sabeen has joined #openstack-ironic | 00:10 | |
| *** hoangcx has joined #openstack-ironic | 00:13 | |
| *** sdake has joined #openstack-ironic | 00:14 | |
| *** wajdi has joined #openstack-ironic | 00:14 | |
| *** mtanino has quit IRC | 00:16 | |
| *** gfhellma has quit IRC | 00:18 | |
| *** thrash is now known as thrash|g0ne | 00:26 | |
| *** fragatin_ has quit IRC | 00:27 | |
| *** fragatina has joined #openstack-ironic | 00:28 | |
| *** rloo has quit IRC | 00:33 | |
| *** sabeen has quit IRC | 00:33 | |
| *** ijw has joined #openstack-ironic | 00:46 | |
| *** ijw has joined #openstack-ironic | 00:46 | |
| *** syed_ has quit IRC | 00:52 | |
| *** vishwanathj has quit IRC | 01:02 | |
| *** vishwanathj has joined #openstack-ironic | 01:02 | |
| *** adu has quit IRC | 01:06 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-inspector: Changed an assert to more specific assert method https://review.openstack.org/362511 | 01:08 |
|---|---|---|
| *** xuao has joined #openstack-ironic | 01:09 | |
| *** maurosr has quit IRC | 01:12 | |
| *** sdake has quit IRC | 01:14 | |
| *** patchbot has quit IRC | 01:19 | |
| *** patchbot has joined #openstack-ironic | 01:20 | |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Add --chassis to 'openstack baremetal node list' https://review.openstack.org/362515 | 01:20 |
| *** sdake has joined #openstack-ironic | 01:21 | |
| *** xuao has quit IRC | 01:23 | |
| *** fragatina has quit IRC | 01:30 | |
| *** hoangcx has quit IRC | 01:31 | |
| *** amotoki has joined #openstack-ironic | 01:42 | |
| *** sabeen has joined #openstack-ironic | 01:43 | |
| *** amotoki has quit IRC | 01:46 | |
| *** Sukhdev has joined #openstack-ironic | 01:48 | |
| *** ChrisAusten has joined #openstack-ironic | 01:50 | |
| *** sabeen has quit IRC | 01:54 | |
| *** sabeen has joined #openstack-ironic | 01:57 | |
| *** aNupoisc has quit IRC | 02:01 | |
| *** hoangcx has joined #openstack-ironic | 02:02 | |
| *** vishwanathj has quit IRC | 02:03 | |
| *** vishwanathj has joined #openstack-ironic | 02:03 | |
| *** jcoufal has quit IRC | 02:04 | |
| *** ijw has quit IRC | 02:14 | |
| *** ijw has joined #openstack-ironic | 02:14 | |
| *** ijw has quit IRC | 02:16 | |
| *** sabeen has quit IRC | 02:26 | |
| *** sabeen has joined #openstack-ironic | 02:29 | |
| *** sabeen has quit IRC | 02:31 | |
| *** amotoki has joined #openstack-ironic | 02:31 | |
| *** Sukhdev has quit IRC | 02:32 | |
| *** hoangcx has quit IRC | 02:34 | |
| *** Sukhdev has joined #openstack-ironic | 02:37 | |
| *** bdeschenes has quit IRC | 02:39 | |
| *** Sukhdev has quit IRC | 02:42 | |
| *** hoangcx has joined #openstack-ironic | 02:44 | |
| *** jcoufal has joined #openstack-ironic | 02:45 | |
| *** vishwanathj has quit IRC | 02:55 | |
| *** vishwanathj has joined #openstack-ironic | 02:55 | |
| *** amotoki has quit IRC | 02:58 | |
| *** amotoki has joined #openstack-ironic | 03:00 | |
| *** vishwanathj has quit IRC | 03:04 | |
| *** vishwanathj has joined #openstack-ironic | 03:04 | |
| *** daemontool has quit IRC | 03:07 | |
| *** vishwanathj has quit IRC | 03:08 | |
| *** vishwanathj has joined #openstack-ironic | 03:08 | |
| *** amotoki has quit IRC | 03:09 | |
| *** daemontool has joined #openstack-ironic | 03:11 | |
| *** ijw has joined #openstack-ironic | 03:11 | |
| *** ijw has quit IRC | 03:15 | |
| *** baoli_ has quit IRC | 03:19 | |
| *** vishwanathj is now known as vishwanathj_zzz | 03:19 | |
| *** baoli has joined #openstack-ironic | 03:19 | |
| *** notmyname has left #openstack-ironic | 03:23 | |
| *** vishwanathj_zzz has quit IRC | 03:29 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 03:29 | |
| *** vikrant has joined #openstack-ironic | 03:40 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-lib: Using assertIsNone() is preferred over assertEqual() Following OpenStack Style Guidelines: http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises https://review.openstack.org/362587 | 03:40 |
| *** jcoufal has quit IRC | 03:41 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Using assertIsNone() is preferred over assertEqual() https://review.openstack.org/362589 | 03:43 |
| *** appu103_ has joined #openstack-ironic | 03:44 | |
| *** vishwanathj_zzz has quit IRC | 03:44 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/python-ironicclient: Using assertIsNone() is preferred over assertEqual() https://review.openstack.org/362590 | 03:44 |
| *** vishwanathj_zzz has joined #openstack-ironic | 03:44 | |
| *** appu103_ is now known as aparnav | 03:45 | |
| *** baoli has quit IRC | 03:48 | |
| *** links has joined #openstack-ironic | 03:51 | |
| *** vishwanathj_zzz has quit IRC | 03:53 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 03:53 | |
| *** vishwanathj_zzz has quit IRC | 03:55 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 03:55 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/python-ironic-inspector-client: Using assertIsNone() is preferred over assertIs(None,..) https://review.openstack.org/362598 | 03:58 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/python-ironic-inspector-client: Using assertIsNone() is preferred over assertIs(None,..) https://review.openstack.org/362599 | 03:59 |
| *** fragatina has joined #openstack-ironic | 04:02 | |
| *** MattMan has quit IRC | 04:04 | |
| *** fragatina has quit IRC | 04:07 | |
| *** hoangcx has quit IRC | 04:10 | |
| *** MattMan has joined #openstack-ironic | 04:11 | |
| *** amotoki has joined #openstack-ironic | 04:12 | |
| *** yogi has joined #openstack-ironic | 04:24 | |
| *** rama_y has joined #openstack-ironic | 04:25 | |
| *** hoangcx has joined #openstack-ironic | 04:25 | |
| *** jrist has quit IRC | 04:33 | |
| *** jrist has joined #openstack-ironic | 04:34 | |
| *** vishwanathj_zzz has quit IRC | 04:38 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 04:38 | |
| *** vishwanathj_zzz has quit IRC | 04:47 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 04:47 | |
| *** vishwanathj_zzz has quit IRC | 04:50 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 04:50 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Timing metrics: iLO drivers https://review.openstack.org/352745 | 04:51 |
| *** vishwanathj_zzz has quit IRC | 05:06 | |
| *** Sukhdev has joined #openstack-ironic | 05:06 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 05:07 | |
| *** jaosorior has joined #openstack-ironic | 05:10 | |
| *** vishwanathj_zzz has quit IRC | 05:11 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 05:11 | |
| *** Sukhdev has quit IRC | 05:12 | |
| *** vishwanathj_zzz has quit IRC | 05:15 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 05:15 | |
| *** lifeless_ is now known as lifeless | 05:15 | |
| *** ChrisAusten has quit IRC | 05:16 | |
| *** vishwanathj_zzz has quit IRC | 05:17 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 05:17 | |
| *** vishwanathj_zzz has quit IRC | 05:26 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 05:26 | |
| openstackgerrit | Aparna proposed openstack/ironic-specs: Generic way to configure clean step priorites in Automated cleaning https://review.openstack.org/362615 | 05:30 |
| *** vishwanathj_zzz has quit IRC | 05:38 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 05:38 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-lib: Using assertIsNone() is preferred over assertEqual() https://review.openstack.org/362587 | 05:39 |
| *** vishwanathj_zzz has quit IRC | 05:40 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 05:40 | |
| *** sdake has quit IRC | 05:47 | |
| *** milan has joined #openstack-ironic | 05:50 | |
| *** sdake has joined #openstack-ironic | 05:50 | |
| *** milan has quit IRC | 05:59 | |
| *** ChubYann has quit IRC | 06:00 | |
| *** milan has joined #openstack-ironic | 06:04 | |
| *** Sukhdev has joined #openstack-ironic | 06:06 | |
| *** bfournie has quit IRC | 06:11 | |
| *** bfournie has joined #openstack-ironic | 06:12 | |
| *** mjura_ has joined #openstack-ironic | 06:17 | |
| *** mjura has joined #openstack-ironic | 06:17 | |
| *** rcernin has joined #openstack-ironic | 06:19 | |
| *** ijw has joined #openstack-ironic | 06:20 | |
| *** mjura has quit IRC | 06:21 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Change asserts with more specific assert methods. https://review.openstack.org/362633 | 06:22 |
| *** amotoki has quit IRC | 06:22 | |
| *** ijw has quit IRC | 06:25 | |
| *** pcaruana has joined #openstack-ironic | 06:26 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Change asserts with more specific assert methods. https://review.openstack.org/362634 | 06:28 |
| *** praneshp has quit IRC | 06:32 | |
| *** ashestakov has joined #openstack-ironic | 06:38 | |
| *** ashestakov has quit IRC | 06:38 | |
| *** moshele has joined #openstack-ironic | 06:42 | |
| *** sdake has quit IRC | 06:44 | |
| *** jjohnson2 has quit IRC | 06:44 | |
| *** jjohnson2 has joined #openstack-ironic | 06:45 | |
| *** amotoki has joined #openstack-ironic | 06:46 | |
| *** Sukhdev has quit IRC | 06:51 | |
| *** amotoki has quit IRC | 06:56 | |
| *** rama_y has quit IRC | 06:57 | |
| *** tesseract- has joined #openstack-ironic | 07:07 | |
| *** dtantsur|afk is now known as dtantsur | 07:13 | |
| dtantsur | Morning Ironic | 07:13 |
| milan | morning dtantsur :) | 07:19 |
| milan | and morning Ironic! | 07:19 |
| *** ifarkas_afk is now known as ifarkas | 07:22 | |
| *** milan has quit IRC | 07:22 | |
| *** milan has joined #openstack-ironic | 07:24 | |
| *** skazi has joined #openstack-ironic | 07:24 | |
| openstackgerrit | Georgy Dyuldin proposed openstack/ironic: Add ironic multitenancy tests https://review.openstack.org/360465 | 07:24 |
| * milan has some connectivity issues this morning | 07:25 | |
| openstackgerrit | Georgy Dyuldin proposed openstack/ironic: New test for check instances in shared network https://review.openstack.org/360573 | 07:26 |
| openstackgerrit | Ha Van Tu proposed openstack/ironic: Fix using filter() to meet python2,3 https://review.openstack.org/362664 | 07:29 |
| *** zhangjl has joined #openstack-ironic | 07:29 | |
| *** jpich has joined #openstack-ironic | 07:40 | |
| dtantsur | morning vsaienk0 :) It's not that I'm so fast, I've just found the same missing test coverage simultaneously :) | 07:41 |
| *** ohamada has joined #openstack-ironic | 07:46 | |
| pas-ha | morning dtantsur milan vsaienk0 and others :) | 07:46 |
| dtantsur | morning pas-ha and milan | 07:47 |
| *** maurosr has joined #openstack-ironic | 07:53 | |
| openstackgerrit | gengchc2 proposed openstack/ironic: Change assertTrue(isinstance()) with optimal assert for ironic https://review.openstack.org/362684 | 07:59 |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-ironic | 08:02 | |
| lucasagomes | morning all | 08:04 |
| pas-ha | morning lucasagomes | 08:04 |
| dtantsur | morning lucasagomes | 08:05 |
| *** derekh has joined #openstack-ironic | 08:07 | |
| openstackgerrit | Merged openstack/python-ironicclient: Set/unset node's target RAID config via OSC command https://review.openstack.org/360787 | 08:09 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 08:10 |
| ifarkas | morning all! | 08:12 |
| lucasagomes | ifarkas, morning | 08:14 |
| *** phuongnh has joined #openstack-ironic | 08:19 | |
| milan | morning ifarkas lucasagomes pas-ha! :) | 08:23 |
| openstackgerrit | Imre Farkas proposed openstack/ironic: DRAC RAID configuration https://review.openstack.org/176319 | 08:25 |
| dtantsur | morning ifarkas | 08:28 |
| * milan relocates | 08:28 | |
| *** milan has quit IRC | 08:29 | |
| lucasagomes | strange, I've released a version of virtualbmc yesterday but it's not on pypi | 08:34 |
| lucasagomes | https://review.openstack.org/#/c/362143/ | 08:34 |
| patchbot | patch 362143 - releases - Release virtualbmc 0.1.0 (MERGED) | 08:35 |
| lucasagomes | jroll, ^ any ideas ? | 08:35 |
| dtantsur | lucasagomes, ask #openstack-release better | 08:35 |
| lucasagomes | dtantsur, ++ | 08:35 |
| lucasagomes | the ironic-staging-drivers worked | 08:35 |
| *** electrofelix has joined #openstack-ironic | 08:35 | |
| *** sborkows has joined #openstack-ironic | 08:41 | |
| *** moshele has quit IRC | 08:41 | |
| *** moshele has joined #openstack-ironic | 08:42 | |
| *** daemontool has quit IRC | 08:46 | |
| *** daemontool has joined #openstack-ironic | 08:49 | |
| *** links has quit IRC | 09:00 | |
| *** tuanla_ has joined #openstack-ironic | 09:05 | |
| *** jaosorior is now known as jaosorior_lunch | 09:08 | |
| *** hamzy has quit IRC | 09:11 | |
| *** hamzy has joined #openstack-ironic | 09:11 | |
| *** bdeschenes has joined #openstack-ironic | 09:14 | |
| *** links has joined #openstack-ironic | 09:16 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add individual_mode_supported to portgroup - DB https://review.openstack.org/361053 | 09:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Rely on portgroup individual_mode_supported https://review.openstack.org/360647 | 09:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add classes for Portgroups API enablement https://review.openstack.org/347549 | 09:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add portgroups to support LAG interfaces - API https://review.openstack.org/332177 | 09:19 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-lib: Add match_root_device_hints() to the utils.py module https://review.openstack.org/358000 | 09:22 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-lib: Extend parse_root_device_hints to support operators https://review.openstack.org/348953 | 09:22 |
| *** jaosorior_lunch is now known as jaosorior | 09:42 | |
| lucasagomes | folks, what you think about setting Ironic to always collect the logs from the deployment ramdisk in devstack ? (see JayF comment here https://review.openstack.org/#/c/360658/) | 09:43 |
| patchbot | patch 360658 - ironic - DevStack: Configure retrieving logs from the deplo... | 09:43 |
| *** e0ne has joined #openstack-ironic | 09:47 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Remove unused requirements https://review.openstack.org/362742 | 09:47 |
| dtantsur | lucasagomes, I'm +1 to always collecting logs | 09:48 |
| dtantsur | at least we'll be sure it does work | 09:49 |
| lucasagomes | yeah | 09:50 |
| * lucasagomes changes it | 09:50 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Remove unused requirements https://review.openstack.org/362748 | 09:53 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-python-agent: Remove unused requirements https://review.openstack.org/362752 | 09:55 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: DevStack: Configure retrieving logs from the deploy ramdisk https://review.openstack.org/360658 | 09:57 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: DevStack: Configure retrieving logs from the deploy ramdisk https://review.openstack.org/360658 | 09:59 |
| *** amotoki_ has joined #openstack-ironic | 10:03 | |
| *** gabor_antal has joined #openstack-ironic | 10:05 | |
| *** daemontool has quit IRC | 10:09 | |
| *** daemontool has joined #openstack-ironic | 10:09 | |
| *** sambetts|afk is now known as sambeets | 10:11 | |
| *** sambeets is now known as sambetts | 10:11 | |
| sambetts | Morning all | 10:11 |
| tangchen | morning all | 10:12 |
| dtantsur | morning sambetts, tangchen | 10:14 |
| cmyster | lucasagomes: I read up and +1 for logs as well all the time (QE love) | 10:16 |
| lucasagomes | cmyster, thanks :D | 10:17 |
| lucasagomes | I've changed the patch to always collect it | 10:17 |
| vdrok | morning dtantsur lucasagomes pas-ha ifarkas sambetts tangchen | 10:17 |
| lucasagomes | vdrok, hi there | 10:17 |
| dtantsur | hi vdrok | 10:17 |
| lucasagomes | sambetts, tangchen morning | 10:17 |
| sambetts | hey lucasagomes | 10:17 |
| vdrok | lucasagomes: dtantsur btw the ansible deploy driver seems to be ready for review, after all the release stuff of course | 10:18 |
| dtantsur | cool! | 10:18 |
| lucasagomes | vdrok, o/ will take a look, it's in staging right? | 10:18 |
| vdrok | yup | 10:19 |
| *** hoangcx has quit IRC | 10:19 | |
| *** amotoki has joined #openstack-ironic | 10:23 | |
| *** amotoki_ has quit IRC | 10:25 | |
| sambetts | milan: you got a few minutes to chat about the state machine stuff? I've got a few suggestions that I'd like to get your thoughts on | 10:26 |
| TheJulia | Good morning everyone | 10:26 |
| sambetts | Morning TheJulia | 10:27 |
| vdrok | morning TheJulia | 10:27 |
| *** amotoki_ has joined #openstack-ironic | 10:33 | |
| dtantsur | morning TheJulia | 10:34 |
| *** amotoki has quit IRC | 10:36 | |
| *** phuongnh has quit IRC | 10:39 | |
| *** bdeschenes has quit IRC | 10:39 | |
| openstackgerrit | Sam Betts proposed openstack/ironic: [WIP] Add Network Interface Attach and Detach APIs https://review.openstack.org/327046 | 10:41 |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Add possibility to work with portgroups https://review.openstack.org/335964 | 10:48 |
| *** aparnav has quit IRC | 10:48 | |
| openstackgerrit | Sam Betts proposed openstack/ironic: Add Network Interface Attach and Detach APIs https://review.openstack.org/327046 | 10:57 |
| openstackgerrit | Sam Betts proposed openstack/ironic: Fix invalid chassis/nodes/chassis_uuid API url https://review.openstack.org/316149 | 10:59 |
| openstackgerrit | Sam Betts proposed openstack/ironic: Fix all possible node subresources routing collisions https://review.openstack.org/315766 | 10:59 |
| *** wznoinsk has quit IRC | 11:10 | |
| *** hoangcx has joined #openstack-ironic | 11:11 | |
| jroll | morning everyone | 11:13 |
| sambetts | Morning jroll | 11:13 |
| dtantsur | morning jroll! when do you plan on clients releases? | 11:15 |
| jroll | dtantsur: dunno, by thursday, the sooner the better :) | 11:15 |
| dtantsur | heh, I see :) | 11:15 |
| *** hoangcx2 has joined #openstack-ironic | 11:15 | |
| jroll | dtantsur: why'd you ask :) | 11:16 |
| dtantsur | trying to wrap my head around ironicclient changes (ironic-inspector-client seems fine) | 11:17 |
| *** hoangcx has quit IRC | 11:17 | |
| *** milan has joined #openstack-ironic | 11:18 | |
| mat128 | morning everyone | 11:20 |
| jroll | ah, ok | 11:21 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic-python-agent: Enforce upper-constraints when building ramdisks https://review.openstack.org/360793 | 11:22 |
| lucasagomes | dtantsur, https://bugs.launchpad.net/ironic/+bug/1618419 | 11:24 |
| openstack | Launchpad bug 1618419 in Ironic "Document the available (by default) cleaning steps" [Medium,New] | 11:24 |
| lucasagomes | marked the RFE itself as fix released | 11:24 |
| lucasagomes | TheJulia, jroll morning | 11:24 |
| milan | morning jroll, mat128, sambetts! | 11:24 |
| milan | morning TheJulia | 11:25 |
| jroll | \o | 11:25 |
| lucasagomes | mat128, milan morning too :D | 11:25 |
| milan | :D | 11:25 |
| * milan reappearing after a lunch&coffee break | 11:25 | |
| tangchen | Hi milan, about this comment, what do you suggest ? https://review.openstack.org/#/c/349421/13/ironic/tests/functional/api/base.py | 11:27 |
| patchbot | patch 349421 - ironic - Prepare for functional tests | 11:27 |
| milan | tangchen, hi | 11:27 |
| * milan looks | 11:27 | |
| milan | ah | 11:28 |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Update IPA info in troubleshooting.rst https://review.openstack.org/362428 | 11:28 |
| tangchen | milan: If we wrap the functions with json_response(), lots of tests need to be fixed. | 11:28 |
| milan | tangchen, I think if the server response to a json query isn't json encoded, it most likely is a bug | 11:28 |
| milan | but I'm fine without | 11:28 |
| *** wznoinsk has joined #openstack-ironic | 11:28 | |
| milan | it was just a suggestion | 11:29 |
| tangchen | milan: Oh, OK. I'd like to keep it this way for now because most of the related work recently will be just split unit and functional tests, not do a big change to them. | 11:30 |
| tangchen | milan: let's put it in a todo list, OK ? | 11:30 |
| tangchen | milan: I can try to fix it when the split work is done | 11:31 |
| milan | tangchen, sure, no prob | 11:31 |
| tangchen | milan: Thank you very much. :) | 11:31 |
| milan | tangchen, no prob :) | 11:31 |
| *** amotoki_ has quit IRC | 11:33 | |
| *** amotoki has joined #openstack-ironic | 11:36 | |
| *** thrash|g0ne is now known as thrash | 11:38 | |
| dtantsur | lucasagomes, thanks | 11:44 |
| TheJulia | good morning jroll mat128 milan lucasagomes | 11:45 |
| milan | o/ :) | 11:45 |
| dtantsur | sambetts, re https://review.openstack.org/352295: do you think we should have milan's comments fixed right there, or should we follow up? | 11:45 |
| patchbot | patch 352295 - ironic-inspector - Add PCI devices plugin to inspector | 11:45 |
| sambetts | dtantsur: I'll take a look in a minute I'm neck deep in another patch atm | 11:47 |
| dtantsur | sure, no hurry | 11:47 |
| dtantsur | I think we can land it this cycle either way | 11:47 |
| *** lucasagomes is now known as lucas-hungry | 11:47 | |
| milan | dtantsur, shouldn't be that difficult to refactor (matter of another jenkins run) | 11:48 |
| dtantsur | true | 11:49 |
| jroll | dtantsur: when you have a moment, this could use a review: https://review.openstack.org/#/c/360793/5 | 11:49 |
| patchbot | patch 360793 - ironic-python-agent (stable/liberty) - Enforce upper-constraints when building ramdisks | 11:50 |
| vdrok | morning jroll mat128 and milan | 11:50 |
| milan | morning vdrok! :) | 11:50 |
| dtantsur | sure, lemme get some tea | 11:51 |
| *** ashestakov has joined #openstack-ironic | 11:53 | |
| mat128 | dtantsur: I think milan's comments are right and would rather see them fixed now | 11:56 |
| mat128 | morning vdrok | 11:57 |
| *** zhangjl has left #openstack-ironic | 12:01 | |
| *** trown|outtypewww is now known as trown | 12:02 | |
| dtantsur | okie, +1 | 12:02 |
| *** jaosorior has quit IRC | 12:04 | |
| *** jaosorior has joined #openstack-ironic | 12:04 | |
| *** jaosorior has quit IRC | 12:11 | |
| *** jaosorior has joined #openstack-ironic | 12:12 | |
| *** iurygregory has quit IRC | 12:15 | |
| *** clenimar has quit IRC | 12:15 | |
| *** xavierr has quit IRC | 12:15 | |
| *** ricardoas has quit IRC | 12:15 | |
| *** mrtenio has quit IRC | 12:15 | |
| *** nicodemos has quit IRC | 12:16 | |
| dtantsur | anyone want to check the DRAC RAID patch before we W+1 it? https://review.openstack.org/#/c/176319/ | 12:18 |
| patchbot | patch 176319 - ironic - DRAC RAID configuration | 12:18 |
| ashestakov | hi all | 12:19 |
| ashestakov | I have question about serial over lan implementation using Socat, can anyone help me? | 12:19 |
| mat128 | ashestakov: authors arent present at this time in the channel, but we sure can help | 12:20 |
| mat128 | ashestakov: what is your question? | 12:20 |
| ashestakov | i found issue, and filed bug https://bugs.launchpad.net/ironic/+bug/1611285 | 12:21 |
| openstack | Launchpad bug 1611285 in Ironic "_start_console provides wrong ipmi command for socat console" [Undecided,New] | 12:21 |
| ashestakov | can you confirm it? | 12:21 |
| mat128 | let me check | 12:22 |
| patchbot | (let <variable> = <value> in <command>) -- Defines <variable> to be equal to <value> in the <command> and runs the <command>. '=' and 'in' can be omitted. | 12:22 |
| mat128 | ^eh? | 12:22 |
| mat128 | ashestakov: was that on master? | 12:22 |
| ashestakov | yes | 12:22 |
| ashestakov | but i not sure on which commit exactly | 12:23 |
| mat128 | ashestakov: https://github.com/openstack/ironic/blob/4f0eef646dd2c21cc325d0c23f1750df9bcecaf2/ironic/drivers/modules/console_utils.py#L284 | 12:23 |
| mat128 | this seems to indicate proper arguments, is this not what you are seeing? | 12:23 |
| *** dprince has joined #openstack-ironic | 12:26 | |
| ashestakov | args is good, but it using console_cmd provided by _start_console | 12:26 |
| ashestakov | https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L1192 | 12:26 |
| ashestakov | which includes some arguments for shellinabox | 12:26 |
| mat128 | ashestakov: I take it you're using pxe_ipmitool_socat or agent_ipmitool_socat ? | 12:27 |
| ashestakov | with agent | 12:28 |
| mat128 | ashestakov: there are 2 things, we need to enable sol with ipmitool, then enable socat | 12:30 |
| mat128 | I'm unsure why arguments to ipmitool are being fed to socat, but nothing is impossible as this does not have (IIRC) functional testing | 12:30 |
| ashestakov | when i remove "/:%(uid)s:%(gid)s:HOME:" it works ok | 12:31 |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with node-get command https://review.openstack.org/342060 | 12:32 |
| mat128 | ashestakov: ok can you provide (preferably in the bug report) the exact version of socat and ipmitool binaries? | 12:33 |
| mat128 | ashestakov: and the full command line being executed (if possible) | 12:33 |
| mat128 | ashestakov: the way I see it, either shellinabox or socat have to be fed the final command to run | 12:33 |
| mat128 | ashestakov: so it turns into something like socat TCP:something:something/EXEC:ipmitool sol activate | 12:34 |
| mat128 | so socat executes ipmitool itself, and does the plumbing to the TCP port | 12:34 |
| *** tuanla_ has quit IRC | 12:34 | |
| ashestakov | not just "ipmitool sol activate" at the end, but "/:103:107:HOME:ipmitool ..." | 12:35 |
| ashestakov | and socat expects just command | 12:36 |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Add possibility to work with portgroups https://review.openstack.org/335964 | 12:37 |
| ashestakov | i will update bug with more debug outputs | 12:38 |
| *** adu has joined #openstack-ironic | 12:38 | |
| mat128 | ashestakov: I just found the manpage for shellinaboxd and the "colon" notation is mentioned | 12:39 |
| mat128 | ashestakov: I think you just found a real bug :) | 12:40 |
| ashestakov | https://github.com/shellinabox/shellinabox/wiki/Shell-In-A-Box-manual supports expansion of variables | 12:40 |
| *** lucas-hungry is now known as lucasagomes | 12:41 | |
| ashestakov | mat128: so, can you confirm this issues? | 12:42 |
| mat128 | ashestakov: I can confirm the uid/gid part here (https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L1192) should go into the shellinabox method | 12:42 |
| mat128 | and I also confirm we need real functional testing on this feature | 12:42 |
| mat128 | lucasagomes: do you think it's feasible to add SoL in VirtualBMC? | 12:42 |
| lucasagomes | mat128, yes! We need to change pyghmi bmc.py module first | 12:43 |
| lucasagomes | so that it invokes a method upon receiving the ipmitool sol activate command | 12:43 |
| lucasagomes | should be easy tho | 12:44 |
| ashestakov | check also qemu, it will support ipmi device emulation in future, and now ipmi support available as patch for qemu | 12:44 |
| *** baoli has joined #openstack-ironic | 12:44 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Enforce upper-constraints when building ramdisks https://review.openstack.org/360793 | 12:45 |
| *** rloo has joined #openstack-ironic | 12:45 | |
| mat128 | lucasagomes: I don't know what the transport for SoL looks like (is it over the IPMI protocol? Guess so?) but yeah | 12:45 |
| mat128 | ashestakov: yes I have seen those, emulating an IPMI device both inside and outside the VM | 12:45 |
| mat128 | looks promising | 12:45 |
| lucasagomes | ashestakov, yeah, I think the base patch for ipmi is already merged in qemu | 12:46 |
| mat128 | we need it up at all times though (like a real BMC) | 12:46 |
| lucasagomes | mat128, I don't know off the top of my head | 12:46 |
| lucasagomes | gotta look into it | 12:46 |
| mat128 | lucasagomes: "SOL is implemented as a payload type under the RMCP+ protocol in IPMI." | 12:47 |
| mat128 | according to Wikipedia | 12:47 |
| ashestakov | and SOL has another issue when session interrupts, because UDP | 12:50 |
| vsaienk0 | sambetts: thanks for review https://review.openstack.org/#/c/360647 so based on your comments I realized that we should ignore updating dhcp options for non pxe_enabled ports https://github.com/openstack/ironic/blob/master/ironic/dhcp/neutron.py#L150 | 12:50 |
| patchbot | patch 360647 - ironic - Rely on portgroup individual_mode_supported | 12:50 |
| ashestakov | i filed another bug with description issues of socat https://bugs.launchpad.net/ironic/+bug/1611279 | 12:50 |
| openstack | Launchpad bug 1611279 in Ironic "Socat console de-activates without close active SOL connections" [Undecided,New] - Assigned to Andrey Shestakov (ashestakov) | 12:50 |
| lucasagomes | [off-topic] someone knows where the function to collect the logs in gate is located ? I've a patch enabling pulling the logs from the deploy ramdisk in Ironic (https://review.openstack.org/#/c/360658/) | 12:52 |
| patchbot | patch 360658 - ironic - DevStack: Configure retrieving logs from the deplo... | 12:52 |
| lucasagomes | and I see it worked in the logs, but it the file itself is not collected | 12:52 |
| lucasagomes | jroll, ^ you know off the top of your head? project-config maybe!? | 12:53 |
| mat128 | lucasagomes: yes project-config | 12:53 |
| mat128 | there's a pattern | 12:53 |
| sambetts | lucasagomes: didn't we do it for the BM VM logs? | 12:54 |
| lucasagomes | mat128, right, lemem try to find it | 12:54 |
| mat128 | lucasagomes: http://logs.openstack.org/58/360658/4/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa/fbc0e8b/_zuul_ansible/ansible_log.txt | 12:54 |
| mat128 | last ansible "command" is rsync | 12:54 |
| patchbot | (last [--{from,in,on,with,without,regexp} <value>] [--nolimit]) -- Returns the last message matching the given criteria. --from requires a nick from whom the message came; --in requires a channel the message was sent to; --on requires a network the message was sent on; --with requires some string that had to be in the message; --regexp requires a regular expression the message (1 more message) | 12:54 |
| lucasagomes | sambetts, we do save the console logs yes | 12:54 |
| jroll | lucasagomes: devstack-gate, grep ironic-bm I think | 12:55 |
| lucasagomes | mat128, jroll ty! will take a look | 12:56 |
| sambetts | vsaienk0: do we not do that already?! | 12:56 |
| mat128 | lucasagomes: "scp" publisher | 12:56 |
| mat128 | lucasagomes: implementation is here https://github.com/openstack-infra/zuul/blob/30f2b29874daea4852c924141b4c6033f3784d7a/zuul/launcher/ansiblelaunchserver.py#L955 | 12:56 |
| vsaienk0 | sambetts: I think that no | 12:56 |
| lucasagomes | mat128, https://github.com/openstack-infra/devstack-gate/blob/master/functions.sh#L844-L847 | 12:57 |
| mat128 | ah, your logs are not under logs so you need to move them | 12:58 |
| mat128 | makes sense | 12:58 |
| sambetts | vsaienk0: sigh... I can't wait for the deprecation of the DHCP provider thingys | 12:58 |
| lucasagomes | yeah it's filtering by *.log that's why the virtualbmc logs worked out of the box | 12:59 |
| lucasagomes | I thought it just copied all the logs from that folder | 12:59 |
| * lucasagomes puts a patch up | 12:59 | |
| *** mrtenio has joined #openstack-ironic | 12:59 | |
| *** nicodemos has joined #openstack-ironic | 12:59 | |
| *** clenimar has joined #openstack-ironic | 13:00 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/python-ironicclient: Update openstack baremetal driver commands https://review.openstack.org/362047 | 13:00 |
| *** iurygregory has joined #openstack-ironic | 13:00 | |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with Chassis. https://review.openstack.org/343796 | 13:01 |
| *** gabriel-bezerra has quit IRC | 13:02 | |
| vsaienk0 | sambetts: I'm a little bit confused by https://review.openstack.org/#/c/360647/5/ironic/api/controllers/v1/port.py@378 and https://review.openstack.org/#/c/360647/5/ironic/api/controllers/v1/port.py@607 | 13:03 |
| patchbot | patch 360647 - ironic - Rely on portgroup individual_mode_supported | 13:03 |
| patchbot | patch 360647 - ironic - Rely on portgroup individual_mode_supported | 13:03 |
| vsaienk0 | sambetts: according to l378 there might be case when we should update vif_port_id for ports with pxe_enabled=False | 13:04 |
| vsaienk0 | The example that you provided, when server has 2 nics, one slow we set pxe_enabled=Flase on it, and provisioning is happening via second nic which is pxe_enabled=True. In this case we should allow to set vif_port_id for both ports | 13:05 |
| sambetts | vsaienk0: yes | 13:05 |
| *** ricardoas has joined #openstack-ironic | 13:08 | |
| vsaienk0 | sambetts: so there is no need to check if port is pxe_enabled or not, we need to check only that portgroup is individual_mode_supported right? | 13:09 |
| *** david-lyle has quit IRC | 13:10 | |
| sambetts | vsaienk0: right, however it does make me think, what happens if a node has flat network enabled and 2 ports, 1 pxe_enabled and 1 isn't, and nova lands the tenants VIF on the non-pxe_enabled one, should we add a new neutron port for the pxe_enabled nic so that we can complete provisioning and then delete it, or when using a flat network driver, fail to validate the node if they have a | 13:11 |
| sambetts | non-pxe_enabled port | 13:11 |
| *** wajdi has quit IRC | 13:12 | |
| *** xavierr has joined #openstack-ironic | 13:13 | |
| *** gabriel-bezerra has joined #openstack-ironic | 13:15 | |
| *** vikrant has quit IRC | 13:16 | |
| *** david-lyle has joined #openstack-ironic | 13:18 | |
| openstackgerrit | Merged openstack/pyghmi: Fix BMC compatibility with Python 2.6 https://review.openstack.org/362396 | 13:20 |
| openstackgerrit | Szymon Borkowski proposed openstack/ironic-inspector: Add PCI devices plugin to inspector https://review.openstack.org/352295 | 13:20 |
| *** adu has quit IRC | 13:21 | |
| *** afaranha has joined #openstack-ironic | 13:21 | |
| *** cdearborn has joined #openstack-ironic | 13:22 | |
| *** bdeschenes has joined #openstack-ironic | 13:23 | |
| sborkows | milan: I just posted a new patchset about PCI devices plugin for inspector. Would you mind looking at it, if everything is ok now? | 13:24 |
| milan | sborkows, sure thing! Thanks! | 13:24 |
| *** daemontool has quit IRC | 13:25 | |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with node-list command https://review.openstack.org/360549 | 13:26 |
| vsaienk0 | sambetts: looks like that we should create a new port, but we don't know to which network it is plugged | 13:26 |
| sambetts | in the flat case it'll always be the same network as the provisioning network right/ | 13:26 |
| sambetts | ? | 13:26 |
| sambetts | and thats in the config file | 13:26 |
| sambetts | vsaienk0: ^ | 13:26 |
| *** daemontool has joined #openstack-ironic | 13:27 | |
| vsaienk0 | sambetts: we don't know how many flat networks exist right? | 13:27 |
| vsaienk0 | sambetts: the node may be connected to several flat networks | 13:27 |
| vsaienk0 | I propose to block setting vif_port id only on ports that are members of portgroups with individual_mode_supported false | 13:28 |
| vsaienk0 | sambetts: ^ else it should be allowed, what do you think? | 13:29 |
| *** mmedvede_ has joined #openstack-ironic | 13:30 | |
| sambetts | yup, but we also need to block setting pxe_enabled on ports that are members of portgroups with individual_mode_supported false, and adding ports with pxe_enabled True to portgroups with individual_mode_supported false | 13:30 |
| *** mmedvede has quit IRC | 13:30 | |
| *** mmedvede_ has quit IRC | 13:30 | |
| *** ashestakov has quit IRC | 13:31 | |
| sambetts | in regards to flat networks I think we have to assume there is only one, because the way nova places vifs on ports is non-deterministic so if there are multiple then you'll rarly end up with vifs on the right pifs for the network you've asked for | 13:32 |
| openstackgerrit | Jim Rollenhagen proposed openstack/python-ironicclient: Clean up release notes for 1.7 https://review.openstack.org/362870 | 13:33 |
| vsaienk0 | sambetts: it will cause reschedule, the same flow as we are going to implement with indvidual_mode_supported right? | 13:34 |
| vsaienk0 | sambetts: I mean until nova knows about portgroups | 13:34 |
| sambetts | vsaienk0: there is currently no implemented way to define which pifs are on which flat networks, so it doesn't fail it just assigns the wrong vifs to pifs and then continues with the deployment, there is no error | 13:37 |
| vsaienk0 | sambetts: there will be wait-call-back error, if nova didn't guess network correctly, and than reschedule | 13:37 |
| ifarkas | lucasagomes, what do you think about dtantsur's comment on https://review.openstack.org/#/c/342915/5/setup.cfg ? | 13:38 |
| patchbot | patch 342915 - ironic - DRAC OOB inspection | 13:38 |
| ifarkas | lucasagomes, I kinda like the idea - but otoh it's a breaking change... | 13:38 |
| sambetts | vsaienk0: right, it'd just take, provision wait call back timeout time to fail and retry | 13:38 |
| sambetts | its not great but it works I guess | 13:39 |
| vsaienk0 | sambetts: I think blocking setting pxe_enabled=True on individual_mode_supported should be done in separate patch | 13:39 |
| lucasagomes | ifarkas dtantsur ditto... I don't know how users of pxe_drac will react to it. We can include an upgrade release note saying that people using "pxe_drac" should replace their driver to "pxe_drac_inspector" of they want to continue to use ironic-inspector | 13:40 |
| sambetts | vsaienk0: why? all the logic is more or less the same and goes in the same place right? I personally thought you were going to include it all in the portgroups/ports integration patch | 13:40 |
| openstackgerrit | Jarrod Johnson proposed openstack/pyghmi: Fix errors in IPMI server https://review.openstack.org/362874 | 13:41 |
| *** mmedvede has joined #openstack-ironic | 13:41 | |
| dtantsur | lucasagomes, +1 to a note | 13:41 |
| vsaienk0 | sambetts: we decided to split that patch to smaller, because it is huge | 13:41 |
| sambetts | vsaienk0: sure, but unlike how we split the portgroups API out from the ports API enhancement, I don't know if it makes sense to merge the ports API part without this logic already in there | 13:43 |
| vsaienk0 | sambetts: so I'm going to update https://review.openstack.org/#/c/360647/ I will add: | 13:43 |
| vsaienk0 | - Block adding ports with pxe_enabled=True to portgroups with individual_mode_supported=False and vice verse | 13:43 |
| vsaienk0 | - blocking setting vif_port_id on ports that are members of portgroups with individual mode supported=False | 13:43 |
| patchbot | patch 360647 - ironic - Rely on portgroup individual_mode_supported | 13:43 |
| ifarkas | dtantsur, lucasagomes, ack, adding a note | 13:43 |
| sambetts | vsaienk0: yup those 2 cases makes sense to me | 13:43 |
| vsaienk0 | by adding this verification (when pxe_enabled relies on individual_mode_supported) we need to check only that port is pxe_enabled=True | 13:44 |
| lucasagomes | jjohnson2, hi there, around ? Not sure if you noticed, but using the IpmiServer from pyghmi sometimes I get a "unable to establish IPMI v2 ... session error" (http://paste.openstack.org/show/564834/) | 13:44 |
| *** mgoddard_ has joined #openstack-ironic | 13:45 | |
| lucasagomes | jjohnson2, have you noticed it > | 13:45 |
| lucasagomes | ?* | 13:45 |
| sambetts | vsaienk0: yup, once those checks are in place it shouldn't be possible to have a pxe_enabled port that you can't use by itself | 13:45 |
| lucasagomes | derekh, also found out that if you limited the tcp/udp port range it reproduces a lot faster (I can confirm by my local tests) | 13:45 |
| lucasagomes | echo "32768 32777" | sudo tee /proc/sys/net/ipv4/ip_local_port_range | 13:46 |
| patchbot | 32768 32777 | sudo tee /proc/sys/net/ipv4/ip_local_port_range | 13:46 |
| *** e0ne has quit IRC | 13:46 | |
| derekh | jjohnson2: The problem is triggered when the source UDP port is used for the second time | 13:47 |
| *** hoangcx2 has quit IRC | 13:47 | |
| *** afaranha has quit IRC | 13:47 | |
| *** e0ne has joined #openstack-ironic | 13:48 | |
| *** mgoddard has quit IRC | 13:48 | |
| *** daemontool has quit IRC | 13:49 | |
| derekh | lucasagomes: jjohnson2: the first time (and the correct path I think) a session from port X is started code it executed through the if statment on line 183 http://git.openstack.org/cgit/openstack/pyghmi/tree/pyghmi/ipmi/private/session.py#n183 | 13:49 |
| *** daemontool has joined #openstack-ironic | 13:50 | |
| derekh | lucasagomes: jjohnson2 the second time 179 is True, so the code takes a different path http://git.openstack.org/cgit/openstack/pyghmi/tree/pyghmi/ipmi/private/session.py#n179 | 13:50 |
| derekh | lucasagomes: jjohnson2 as if it thinks there is a session already open maybe? | 13:51 |
| xavierr | good morning Ironic | 13:53 |
| TheJulia | good morning xavierr | 13:54 |
| jlvillal | mat128, Nice. All the constraints stuff is in. Thanks for all the work on them :) | 13:54 |
| vdrok | morning xavierr and jlvillal | 13:55 |
| jlvillal | Hi vdrok | 13:56 |
| jlvillal | And welcome patchbot ;) | 13:56 |
| xavierr | hey TheJulia vdrok jlvillal o/ | 13:56 |
| *** anush__ has joined #openstack-ironic | 13:56 | |
| jlvillal | :) | 13:56 |
| dtantsur | morning xavierr, jlvillal | 13:57 |
| xavierr | morning dtantsur :) | 13:57 |
| jlvillal | dtantsur, :) | 13:57 |
| rloo | hi and good morning dtantsur, jlvillal, xavierr, TheJulia, vdrok, lucasagomes, derekh, vsaienk0, sambetts, patchbot :) | 13:58 |
| vsaienk0 | morning rloo | 13:58 |
| dtantsur | morning rloo | 13:58 |
| lucasagomes | rloo, hi there | 13:58 |
| sambetts | o/ rloo | 13:58 |
| *** joprovost has joined #openstack-ironic | 13:58 | |
| rloo | lucasagomes: did you see pavlo's comments wrt ipxe/swift temp urls? https://bugs.launchpad.net/ironic/+bug/1526404 | 13:58 |
| openstack | Launchpad bug 1526404 in Ironic "[RFE] iPXE to use Swift Temporary URLs" [Wishlist,In progress] - Assigned to Pavlo Shchelokovskyy (pshchelo) | 13:58 |
| xavierr | morning rloo o/ | 13:58 |
| jlvillal | rloo, :) | 13:59 |
| lucasagomes | rloo, I have not, lemme take a look | 13:59 |
| lucasagomes | just finishing something quick | 13:59 |
| rloo | thx lucasagomes. pavlo has a patch up, want to make sure before I look, that it is in sync with what you had intended in that spec | 14:00 |
| *** zzzeek has quit IRC | 14:00 | |
| rloo | sambetts: wanted to let you know i didn't forget about your request wrt 'openstack baremetal node maintenance set' | 14:02 |
| alaski | jroll: just added you to two nova reviews I'd like your opinion on. They make sense to me but want to make sure I'm not missing something. | 14:02 |
| jjohnson2 | lucasagomes, hello | 14:02 |
| rloo | sambetts: the problem is that the code has already merged so anything we do, we will have to deprecate. so not high priority right now. | 14:02 |
| xavierr | Ironicers, this documentation patch https://review.openstack.org/#/c/357454/ has it's first +2, when you have some time could you take a look? | 14:02 |
| patchbot | patch 357454 - ironic - Adds instructions to perform nodes migration | 14:02 |
| rloo | sambetts: also, there is 'openstack host set --enable-maintenance' so I wonder if we should do something similar... | 14:02 |
| xavierr | :) | 14:02 |
| *** joprovost1 has joined #openstack-ironic | 14:03 | |
| openstackgerrit | Merged openstack/ironic-inspector: Changed an assert to more specific assert method https://review.openstack.org/362511 | 14:03 |
| lucasagomes | jjohnson2, morning :-) | 14:03 |
| jroll | alaski: will look, thanks | 14:03 |
| *** zzzeek has joined #openstack-ironic | 14:03 | |
| jroll | alaski: the two by roman p? | 14:03 |
| alaski | yep | 14:03 |
| lucasagomes | jjohnson2, wondering if you've seem this http://paste.openstack.org/show/564834/ when using the IpmiServer from pyghmi | 14:04 |
| lucasagomes | (there's more info in the scrollback) | 14:04 |
| vdrok | morning rloo | 14:04 |
| *** zzzeek has quit IRC | 14:04 | |
| lucasagomes | jjohnson2, http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2016-08-30.log.html#t2016-08-30T13:44:58 | 14:04 |
| *** joprovost has quit IRC | 14:04 | |
| *** joprovost1 is now known as joprovost | 14:04 | |
| *** zzzeek has joined #openstack-ironic | 14:05 | |
| *** sabeen has joined #openstack-ironic | 14:05 | |
| sambetts | rloo: that makes perfect sense, deprecating a CLI instantly wouldn't be good, whats --enable-maintenance used for in a non-ironic use case? I've never used that before, also the host set --<option>, is away from style we've developed to make it more user freindly isn't it? | 14:06 |
| *** jcoufal has joined #openstack-ironic | 14:06 | |
| *** rama_y has joined #openstack-ironic | 14:08 | |
| rloo | sambetts: the description is 'Enable /Disable maintenance mode for the host. (There is an --enable-maintenance and a --disable-maintenance) | 14:08 |
| *** sdake has joined #openstack-ironic | 14:08 | |
| rloo | sambetts: the other two options for that 'host set' is --enable, --disable. so quite possible they wanted some consistency. | 14:08 |
| rloo | sambetts: 'enable/disable the host'. don't ask me what a 'host' is :) | 14:09 |
| jroll | compute host :) | 14:09 |
| sambetts | rloo: hmm I wonder if their maintenance and our maintenance are compatible in symatics, if they aren't it'll make me sad, because then we end up in another situation where you have 1 thing that means different things depending on context :P | 14:09 |
| sambetts | jroll: ^ | 14:10 |
| jroll | sambetts: no idea what the difference is between 'host in maintenance' and 'host disabled' for nova | 14:10 |
| jroll | alaski: today is super busy for me but I'll get to those this week | 14:11 |
| alaski | jroll: no worries, thanks | 14:11 |
| jroll | np | 14:11 |
| rloo | sambetts, jroll: I even wondered if we should have s/node/host/ but I didn't want to go there. we can discuss some other time/week. | 14:12 |
| *** sdake_ has joined #openstack-ironic | 14:12 | |
| jroll | O_o | 14:12 |
| jroll | rloo: yeah, let's not go there | 14:12 |
| rloo | jroll: when were you thinking of doing a client release? i know this week, but is thurs ok? | 14:12 |
| sambetts | haha | 14:12 |
| *** bdeschenes has quit IRC | 14:12 | |
| jroll | rloo: thursday is fine, the sooner the better | 14:12 |
| *** sdake has quit IRC | 14:13 | |
| jroll | rloo: I have https://review.openstack.org/362870 WIP to clean up release notes, I'll pull in anything else we land | 14:13 |
| patchbot | patch 362870 - python-ironicclient - Clean up release notes for 1.7 | 14:13 |
| rloo | jroll: ok. there are some bugs/discrepancies, but given the number of patches up there already, i'm not going to address any more. if we can get existing patches merged, i think it'll be good enough. osc would then provide everything that ironic cli does. (except for bugs and anything i missed) | 14:13 |
| *** thiagop has joined #openstack-ironic | 14:14 | |
| jroll | rloo: cool, that was my goal as well. going to try to review today | 14:14 |
| thiagop | Good morning all | 14:14 |
| openstackgerrit | Imre Farkas proposed openstack/ironic: DRAC OOB inspection https://review.openstack.org/342915 | 14:14 |
| *** syed_ has joined #openstack-ironic | 14:15 | |
| jjohnson2 | lucasagomes, ok, read, going to look at it (sorry for delay, got a visitor at my desk) | 14:16 |
| jjohnson2 | lot's of people playing with the ipmiserver more than I ever expected | 14:16 |
| openstackgerrit | Merged openstack/ironic: DRAC RAID configuration https://review.openstack.org/176319 | 14:16 |
| jjohnson2 | was always meant to be a puny attempt | 14:16 |
| lucasagomes | jjohnson2, no worries at all. Hah indeed, it's quite useful | 14:17 |
| *** wajdi has joined #openstack-ironic | 14:18 | |
| lucasagomes | rloo, pas-ha re: ipxe + swift tempurls. The idea was to use it on top of the dyanamic ipxe configuration to address that same problem you pointed out when deploying without local boot | 14:20 |
| lucasagomes | rloo, pas-ha we would re-generate the tempurls on the flight for the requests | 14:20 |
| mat128 | jjohnson2: to be honest, your implementation is probably the only one that is straight forward and works out of the box | 14:21 |
| lucasagomes | but yeah, I see it can be done separated. I just don't have an answer for the non-local boot deployments off the top of my head | 14:21 |
| lucasagomes | pas-ha, breaking if we reboot is kinda ugly :-/ | 14:21 |
| mat128 | jjohnson2: we used pyghmi's BMC internally before VirtualBMC existed, after trying other alternatives | 14:21 |
| rloo | lucasagomes: thx. Now I will look :) | 14:22 |
| mat128 | lucasagomes: does your spec require manually uploading kernel/ramdisks in swift? | 14:24 |
| lucasagomes | mat128, nop, dynamic iPXE ? | 14:24 |
| lucasagomes | mat128, no, ironic would do it for us | 14:24 |
| mat128 | lucasagomes: ah ok | 14:25 |
| * mat128 is concerned with huge data transit on management network, but I don't have any better suggestion | 14:25 | |
| lucasagomes | mat128, the idea is that the iPXE script will talk to the Ironic API directly and fetch an ipxe script to boot that instance | 14:25 |
| pas-ha | lucasagomes: for netboot the question is how compatible with Nova we want to be. AFAIU Nova caches those kernel/ramdisk you boot from them on compute, so a user can reboot the VM even when image is gone from Glance. the only way to achieve such with Ironic is to store those locally as well and continue to serve them over the local http server | 14:25 |
| lucasagomes | mat128, instead of having a static file under httpboot | 14:25 |
| mat128 | lucasagomes: yes, that's the other spec, right? | 14:25 |
| mat128 | dynamic iPXE | 14:25 |
| sambetts | dtantsur, milan: re: the PCI plugin patch, do we want pci-devices to become a default collector and processing hook? Its not required for the minimum level of nova schduling, but I don't know what the impact is performance wise of having it enabled | 14:26 |
| lucasagomes | mat128, yeah | 14:26 |
| dtantsur | sambetts, hook - why not. not sure about adding collectors to the default list though.. but I'm fine with it too | 14:26 |
| sambetts | dtantsur: is there anything on the IPA side that would break if your using an older IPA and ask it to load a collector it doesn't know about? | 14:27 |
| mat128 | lucasagomes: if Ironic uploads to swift, then gets tempURL and puts that in the dynamic iPXE config, it "simply" works | 14:27 |
| dtantsur | sambetts, yes, it will break. but anyway, the default collectors list exists on the IPA side, so it's not a problem :) | 14:27 |
| lucasagomes | yup | 14:27 |
| mat128 | lucasagomes: not sure how you could do it without the dynamic iPXE, besides knowing URLs in advance (and tempURLs are dynamic) | 14:27 |
| *** daemontool has quit IRC | 14:28 | |
| *** dtantsur is now known as dtantsur|mtg | 14:28 | |
| *** daemontool has joined #openstack-ironic | 14:28 | |
| pas-ha | mat128: that might be a way around this, without local HTTP server we seem desperate to get rid of, using only local image cache | 14:29 |
| sambetts | dtantsur: good point I was looking at the devstack plugin code | 14:29 |
| lucasagomes | pas-ha, I see, IMO it sounds like we should cache it. At the moment we will have a http server around when using iPXE anyway | 14:29 |
| dtantsur|mtg | devstack does not bother me too much :) | 14:29 |
| sambetts | dtantsur|mtg: yeah | 14:30 |
| lucasagomes | maybe optional idk | 14:30 |
| * lucasagomes has a meeting :-( | 14:30 | |
| lucasagomes | brb for lil while | 14:30 |
| openstackgerrit | Merged openstack/python-ironic-inspector-client: Using assertIsNone() is preferred over assertIs(None,..) https://review.openstack.org/362598 | 14:30 |
| pas-ha | lucasagomes: but now we will serve only a tiny ipxe script, and presumably Swift (or RadosGW) is much more scalable and performant than a single-instance HTTP server on conductor node | 14:31 |
| *** michauds has joined #openstack-ironic | 14:32 | |
| *** mgoddard_ has quit IRC | 14:32 | |
| *** mgoddard has joined #openstack-ironic | 14:32 | |
| *** e0ne has quit IRC | 14:32 | |
| *** e0ne has joined #openstack-ironic | 14:34 | |
| *** cdearborn has quit IRC | 14:40 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add standalone_ports_supported to portgroup - DB https://review.openstack.org/361053 | 14:41 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add PortGroups API https://review.openstack.org/347549 | 14:41 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Integrate portgroups with ports to support LAG https://review.openstack.org/332177 | 14:41 |
| *** cdearborn has joined #openstack-ironic | 14:41 | |
| *** daemontool has quit IRC | 14:42 | |
| *** david-lyle has quit IRC | 14:43 | |
| wznoinsk | hi all | 14:44 |
| wznoinsk | did anyone get an ironic instance's log into horizon? | 14:44 |
| sambetts | wznoinsk: as in console? | 14:45 |
| *** jaosorior is now known as jaosorior_away | 14:45 | |
| wznoinsk | sambetts: yes, console log in horizon under instance -> log | 14:45 |
| *** sdake_ has quit IRC | 14:47 | |
| wznoinsk | I guess this would be serial of the node seen in the horizon | 14:47 |
| sambetts | wznoinsk: I believe there is on going work to enable it so it'll work like any other instances console, https://bugs.launchpad.net/ironic/+bug/1553083 | 14:47 |
| openstack | Launchpad bug 1553083 in Ironic "[RFE] Nova serial console support for Ironic" [Wishlist,In progress] - Assigned to John L. Villalovos (happycamp) | 14:47 |
| mat128 | sambetts: unfortunately no :( | 14:47 |
| mat128 | sambetts, wznoinsk: nova only allows interactive serial console *OR* logs | 14:47 |
| mat128 | not both | 14:47 |
| mat128 | but yes it brings us closer | 14:47 |
| *** david-lyle has joined #openstack-ironic | 14:48 | |
| *** mari0jv has joined #openstack-ironic | 14:49 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Remove neutron client workarounds https://review.openstack.org/354588 | 14:51 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/362933 | 14:53 |
| jjohnson2 | lucasagomes, ok, going to do something unkind, but easy | 14:56 |
| lucasagomes | jjohnson2, hah ok, killing the caching ? | 14:56 |
| jjohnson2 | lucasagomes, going to detect sessionless data | 14:57 |
| jjohnson2 | lucasagomes, and if so, I will mercilessly kill the 'old' session and start over | 14:57 |
| jjohnson2 | lucasagomes, actually, now that I think on it, that's not unkind at all... | 14:58 |
| jjohnson2 | lucasagomes, since the peer address can *only* be for a new session if the old session is gone... | 14:58 |
| *** rajinir has joined #openstack-ironic | 14:58 | |
| jjohnson2 | lucasagomes, so deleting the ability to process old sequence can't have any effect... because old session cannot possible still exist on same source udp port... | 14:59 |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add portgroup support to osc plugin https://review.openstack.org/362130 | 14:59 |
| jjohnson2 | unless someone wrote an insane impractical thing to use the same socket to have multiple sessions to the same BMC at once on the same socket, which is too insane to contemplate | 14:59 |
| *** amotoki has quit IRC | 15:01 | |
| *** david-lyle has quit IRC | 15:02 | |
| *** moshele has quit IRC | 15:03 | |
| openstackgerrit | Jarrod Johnson proposed openstack/pyghmi: Tolerate client reuse of UDP ports https://review.openstack.org/362944 | 15:07 |
| jjohnson2 | lucasagomes, there | 15:07 |
| jjohnson2 | try that | 15:07 |
| *** mjura_ has quit IRC | 15:07 | |
| lucasagomes | jjohnson2, yay will try it out in few minutes | 15:07 |
| lucasagomes | (in a meeting at the moment) | 15:07 |
| lucasagomes | I let you know how it goes | 15:07 |
| jjohnson2 | people using it in centos6, people using it with FreeIPMI, and people using it *way* more than I expected to run into UDP port duplication ;) | 15:08 |
| *** sdake has joined #openstack-ironic | 15:09 | |
| *** praneshp has joined #openstack-ironic | 15:15 | |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic-specs: Add CRUD and node states notifications to ironic https://review.openstack.org/347242 | 15:15 |
| openstackgerrit | Merged openstack/ironic-inspector: Fix formatting strings in LOG.error https://review.openstack.org/361148 | 15:17 |
| *** rpioso has joined #openstack-ironic | 15:18 | |
| *** zzzeek has quit IRC | 15:19 | |
| *** ohamada has quit IRC | 15:20 | |
| jjohnson2 | woo, now I show up in eventlet git log as well | 15:20 |
| *** david-lyle has joined #openstack-ironic | 15:22 | |
| *** dtantsur|mtg is now known as dtantsur | 15:25 | |
| lucasagomes | jjohnson2, w00t that seems to work | 15:27 |
| lucasagomes | derekh, ^ | 15:27 |
| *** links has quit IRC | 15:28 | |
| *** sdake has quit IRC | 15:31 | |
| derekh | lucasagomes: jjohnson2 seems to work for me also | 15:32 |
| wznoinsk | sambetts: mat128 I'm on mitaka, trying to find the best and least intrusive way to expose the ironic node name to the user that launched the instance | 15:33 |
| *** jcoufal has quit IRC | 15:34 | |
| *** jcoufal has joined #openstack-ironic | 15:36 | |
| lucasagomes | jjohnson2, can we get a release on that ? If so I will update the g-r for virtualbmc after it lands | 15:36 |
| lucasagomes | seems more stable now (still testing locally) | 15:36 |
| lucasagomes | s/lands/released/g | 15:37 |
| *** rama_y has quit IRC | 15:38 | |
| openstackgerrit | Merged openstack/ironic-inspector: Fix tempest.conf generation https://review.openstack.org/359109 | 15:39 |
| *** zzzeek has joined #openstack-ironic | 15:40 | |
| *** david-lyle has quit IRC | 15:40 | |
| jjohnson2 | lucasagomes, will progress at speed of jenkins | 15:41 |
| *** zzzeek has quit IRC | 15:41 | |
| lucasagomes | jjohnson2, :D that's all good, thanks for looking into it btw | 15:41 |
| dtantsur | feeling pretty bad, will bail out for today | 15:41 |
| dtantsur | see you tomorrow | 15:41 |
| jjohnson2 | lucasagomes, my pride is on the line when there is a bug | 15:41 |
| lucasagomes | dtantsur, get better soon, g'night | 15:42 |
| *** dtantsur is now known as dtantsur|afk | 15:42 | |
| jjohnson2 | now to eat lunch, hard earned for fixing udp port reuse problem | 15:42 |
| jjohnson2 | if all goes well, will tag a minor version bump on return | 15:43 |
| *** zzzeek has joined #openstack-ironic | 15:43 | |
| openstackgerrit | Merged openstack/pyghmi: Fix errors in IPMI server https://review.openstack.org/362874 | 15:46 |
| mat128 | wznoinsk: expose the ironic node name to the user? how? | 15:46 |
| *** derekh has quit IRC | 15:46 | |
| mat128 | wznoinsk: where do you want this information to show up? | 15:46 |
| wznoinsk | mat128: that's what I'm trying to figure out, at the moment the user has to use jump-host (controller) to get to the launched node as neutron flatnet is different from users network | 15:47 |
| rcarrillocruz | hey folks, i have a server that is giving me grief on bifrost, cannot deploy it. It's not able to pull its pxelinux file from nginx | 15:48 |
| rcarrillocruz | for some reason, ironic prepends some garbage data before the mac of the server | 15:48 |
| rcarrillocruz | http://paste.openstack.org/show/564850/ | 15:48 |
| rcarrillocruz | any hint where I could look to fix this? | 15:48 |
| wznoinsk | mat128: console or log would be fine but I'm on mitaka only, my guess is to have novaclient in node's cloud-init to report it back (rename the instance name for example) | 15:48 |
| mat128 | wznoinsk: how would console or log help you find ironic node name? | 15:49 |
| mat128 | wznoinsk: or you mean instance hostname? | 15:49 |
| *** david-lyle has joined #openstack-ironic | 15:50 | |
| wznoinsk | mat128: we have neutron dhcp and our 'isp' dhcp - two different networks both connected to each physical server, user can access the physical servers using IPs provided by ISP without jump-host, isp's dhcp has ip/hostname for each physical server which would be seen once the machine booted up and dhclient/cloud-init finished | 15:51 |
| *** trown is now known as trown|lunch | 15:52 | |
| mat128 | wznoinsk: not sure i'm following you, does that mean the IP address nova has for that instance is invalid? | 15:52 |
| wznoinsk | it is valid, the user is on a different physical network than the neutron subnet | 15:53 |
| wznoinsk | though | 15:53 |
| rcarrillocruz | TheJulia: heya, ever encountered something similar to above paste? | 15:53 |
| lucasagomes | jjohnson2, enjoy lunch! | 15:55 |
| *** vishwanathj_zzz is now known as vishwanathj | 15:56 | |
| *** Sukhdev has joined #openstack-ironic | 15:58 | |
| *** sborkows has quit IRC | 15:58 | |
| *** dprince has quit IRC | 15:59 | |
| milan | sambetts, hey, well I don't have opinion about that as I don't know what it means O:-) | 15:59 |
| sambetts | milan: :-P | 16:00 |
| *** dprince has joined #openstack-ironic | 16:00 | |
| milan | :) | 16:00 |
| *** ifarkas is now known as ifarkas_afk | 16:01 | |
| TheJulia | rcarrillocruz: wow, no.. I'm really curious how that is getting generated :\ | 16:02 |
| lucasagomes | rcarrillocruz, TheJulia hmm inifiband maybe ? | 16:03 |
| * lucasagomes not sure | 16:03 | |
| TheJulia | lucasagomes: that is kind of what I'm suspecting | 16:03 |
| TheJulia | rcarrillocruz: is it falling back or is it stopping there? | 16:04 |
| TheJulia | falling back all the way to just the mac address that is | 16:04 |
| *** devananda is now known as devananda|MOVING | 16:04 | |
| devananda|MOVING | g'morning all! | 16:04 |
| lucasagomes | devananda|MOVING, good morning | 16:04 |
| TheJulia | Good morning deva | 16:04 |
| thiagop | morning devananda|MOVING | 16:04 |
| rcarrillocruz | falls back to pxelinux.cfg/default and as that is not there either , the deploy fails | 16:04 |
| *** moshele has joined #openstack-ironic | 16:05 | |
| wajdi | good luck with your move devananda|MOVING | 16:05 |
| thiagop | rcarrillocruz: have you checked if the actual mac of the server has something unusual? | 16:05 |
| TheJulia | rcarrillocruz: something seems very off then :\ commit hash of ironic and bifrost? | 16:06 |
| TheJulia | or at least, the hash of what any local patches are off of :) | 16:06 |
| rcarrillocruz | bifrost : 2e5faee9807436eb1ed2060e272f4d0391987422 | 16:06 |
| rcarrillocruz | thiagop: the mac of the server is 78-e7-d1-03-00-23-44-15 | 16:07 |
| lucasagomes | rcarrillocruz, just for curiosity, you don't have any key called "client-id" in the "extra" attribute of the port do you ? | 16:07 |
| rcarrillocruz | well | 16:07 |
| rcarrillocruz | there you go | 16:07 |
| rcarrillocruz | more than 6 octets | 16:07 |
| patchbot | Error: I haven't seen than. | 16:07 |
| rcarrillocruz | haha | 16:07 |
| rcarrillocruz | that's bogus | 16:07 |
| rcarrillocruz | thiagop: :D | 16:08 |
| patchbot | You've given me 5 invalid commands within the last 60 seconds; I'm now ignoring you for 10 minutes. | 16:08 |
| thiagop | ^what? | 16:08 |
| rcarrillocruz | something off here... the baremetal.json contains the mac as 78:e7:d1:23:44:15 | 16:08 |
| rcarrillocruz | but then | 16:08 |
| rcarrillocruz | ironic injects for pxelinux something like | 16:09 |
| mari0jv | rloo: hi, my bouncer stopped working, so i'm using this nick instead of mariojv temporarily. i saw that you may have had questions about the power state notifications patch | 16:09 |
| mari0jv | i haven't read the full comments there since the latest patch set, but i'm planning to respond today | 16:09 |
| rcarrillocruz | GET /pxelinux.cfg/00-00-00-00-fe-80-00-00-00-00-00-00-78-e7-d1-03-00-23-44-15 | 16:09 |
| lucasagomes | rcarrillocruz, https://github.com/openstack/ironic/blob/master/ironic/tests/unit/common/test_pxe_utils.py#L229 | 16:09 |
| rcarrillocruz | some stuff before the mac | 16:09 |
| rloo | mari0jv: hi. thx. | 16:09 |
| rcarrillocruz | and some other in the mac , intertwined | 16:09 |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add portgroup support to osc plugin https://review.openstack.org/362130 | 16:09 |
| lucasagomes | rcarrillocruz, please check if you have a "client-id" value in the extra attributes of the ports | 16:10 |
| lucasagomes | s/value/key | 16:10 |
| rcarrillocruz | sure gimme a sec | 16:10 |
| thiagop | jlvillal: is patchbot the patch bot we were talking about yesterday? | 16:10 |
| jlvillal | thiagop: Yep | 16:10 |
| thiagop | jlvillal: he seems a little angry... :D | 16:10 |
| jlvillal | thiagop: heh, I see. | 16:11 |
| thiagop | (or should I say it seems a little angry?!) | 16:11 |
| *** sabeen has quit IRC | 16:11 | |
| * thiagop bugs | 16:11 | |
| rcarrillocruz | lucasagomes: http://paste.openstack.org/show/564852/ | 16:11 |
| lucasagomes | thiagop, bugs everywhere T.T | 16:11 |
| lucasagomes | rcarrillocruz, ty... | 16:12 |
| * lucasagomes wonders how that was generated then | 16:12 | |
| openstackgerrit | Merged openstack/python-ironicclient: Add --node to 'openstack baremetal port list' https://review.openstack.org/362445 | 16:12 |
| rcarrillocruz | TheJulia, lucasagomes : btw , ironic==6.1.1.dev78 | 16:15 |
| rcarrillocruz | ironic-lib==2.0.0 | 16:15 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic-python-agent: (DO NOT MERGE) testing dib cross-repo deps https://review.openstack.org/363006 | 16:20 |
| lucasagomes | rcarrillocruz, ack, master basically | 16:20 |
| lucasagomes | rcarrillocruz, no changes ? | 16:20 |
| rcarrillocruz | nothing, we just run the install from bifrost | 16:21 |
| rcarrillocruz | so no changes in ironic | 16:21 |
| *** david-lyle has quit IRC | 16:21 | |
| thiagop | Folks, our ci is in need of this to run our tests with the dynamic allocation stuff (already has a +2 [thanks JayF]): https://review.openstack.org/#/c/359990/ | 16:22 |
| patchbot | patch 359990 - ironic - OneView test nodes to use dynamic allocation | 16:22 |
| thiagop | a +A would be awesome | 16:22 |
| thiagop | 9-lines, fairly simple | 16:22 |
| *** david-lyle has joined #openstack-ironic | 16:23 | |
| lucasagomes | thiagop, done | 16:24 |
| lucasagomes | rcarrillocruz, really strange, please open a bug about it :-( | 16:26 |
| *** patchbot has left #openstack-ironic | 16:27 | |
| rcarrillocruz | sure, thanks | 16:27 |
| lucasagomes | rcarrillocruz, I wonder if has something to do with the ipxe rom itself | 16:27 |
| lucasagomes | cause it's sending the request, but I'm not sure | 16:27 |
| openstackgerrit | Merged openstack/python-ironicclient: Using assertIsNone() is preferred over assertEqual() https://review.openstack.org/362590 | 16:27 |
| lucasagomes | rcarrillocruz, is the ipxe image coming from boot.ipxe.org, packaged or you are building one yourself ? | 16:28 |
| rcarrillocruz | hmm, let me check, cos i run the install playbook and i'm not sure if it builds it or just pulls it | 16:28 |
| NobodyCam | Good Morning Ironic'ers | 16:28 |
| *** moshele has quit IRC | 16:29 | |
| *** e0ne has quit IRC | 16:31 | |
| wajdi | o/ | 16:31 |
| TheJulia | rcarrillocruz: is your boot.ipxe in /httpboot stock from bifrost or different? | 16:32 |
| vdrok | morning NobodyCam and wajdi :) | 16:32 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/pyghmi: Tolerate client reuse of UDP ports https://review.openstack.org/362944 | 16:32 |
| NobodyCam | morning wajdi and vdrok | 16:32 |
| lucasagomes | jjohnson2, ^ there was a pep8 error in the patch, updated it | 16:32 |
| rcarrillocruz | from bifrost | 16:32 |
| rcarrillocruz | so i'm assuming pxelinux package | 16:32 |
| rcarrillocruz | right? | 16:32 |
| rcarrillocruz | from what i'm reading | 16:32 |
| TheJulia | rcarrillocruz: I think your pulling down the ipxe binary then | 16:32 |
| TheJulia | truthfully I should remember, but I didn't sleep last night, so my brain is not quite... awake | 16:33 |
| *** jpich has quit IRC | 16:35 | |
| TheJulia | rcarrillocruz: I guess that is the other question, is it going pxe -> ipxe or is it going directly to ipxe... | 16:35 |
| *** david-lyle_ has joined #openstack-ironic | 16:36 | |
| *** ChubYann has joined #openstack-ironic | 16:38 | |
| *** Sukhdev has quit IRC | 16:39 | |
| *** electrofelix has quit IRC | 16:39 | |
| * sambetts -> home | 16:39 | |
| *** david-lyle has quit IRC | 16:39 | |
| sambetts | have a good evening everyone | 16:39 |
| TheJulia | rcarrillocruz: system packages for ipxe as far as I can tell | 16:39 |
| rcarrillocruz | yup | 16:39 |
| TheJulia | rcarrillocruz: but the install has been changed quite a bit since I last modified it much | 16:40 |
| openstackgerrit | Hugo Nicodemos proposed openstack/python-oneviewclient: Add auditing instrumentation for python-oneviewclient https://review.openstack.org/337281 | 16:40 |
| rcarrillocruz | it's odd, i only hit this on this particular server | 16:40 |
| rcarrillocruz | out of 48 nodes | 16:40 |
| TheJulia | oO | 16:40 |
| rcarrillocruz | so it's not a systemic problem | 16:40 |
| mat128 | Hey group, this is the equivalent patch for the upper-constraints work we've completed in Ironic but on the diskimage-builder side: https://review.openstack.org/#/c/360547/ | 16:41 |
| TheJulia | mat128: thank you! | 16:41 |
| openstackgerrit | Stephanie Miller proposed openstack/bifrost: Update IPA info in troubleshooting.rst https://review.openstack.org/362428 | 16:42 |
| TheJulia | rcarrillocruz: is it identical hardware? | 16:42 |
| mat128 | I know some of us are core in diskimage-builder | 16:42 |
| mat128 | :) | 16:42 |
| TheJulia | cinerama: ^^^ | 16:42 |
| openstackgerrit | Merged openstack/ironic-lib: Using assertIsNone() is preferred over assertEqual() https://review.openstack.org/362587 | 16:44 |
| rcarrillocruz | TheJulia: mostly yeah, all of them have mellanox cards | 16:44 |
| *** joprovost has quit IRC | 16:44 | |
| *** joprovost has joined #openstack-ironic | 16:47 | |
| *** aNupoisc has joined #openstack-ironic | 16:47 | |
| TheJulia | rcarrillocruz: I wonder if that particular node has slightly different firmware and is going directly to ipxe instead of gpxe -> ipxe | 16:49 |
| *** thrash is now known as thrash|biab | 16:49 | |
| *** joprovost1 has joined #openstack-ironic | 16:49 | |
| *** fragatina has joined #openstack-ironic | 16:50 | |
| TheJulia | rcarrillocruz: actually, that seems like something that would happen... Any chance you could use tcpdump to capture the entire interaction with 10.10.16.14 and make it available? | 16:50 |
| *** yogi has quit IRC | 16:50 | |
| *** fragatin_ has joined #openstack-ironic | 16:51 | |
| *** jaosorior_away has quit IRC | 16:51 | |
| *** joprovost has quit IRC | 16:51 | |
| *** joprovost1 is now known as joprovost | 16:51 | |
| TheJulia | rcarrillocruz: if so, capturing entire packets would be a good idea and would save a step in troubleshooting if it is something along those lines | 16:51 |
| *** trown|lunch is now known as trown | 16:52 | |
| openstackgerrit | Merged openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/362933 | 16:52 |
| *** gfhellma has joined #openstack-ironic | 16:53 | |
| *** fragatina has quit IRC | 16:55 | |
| *** aNupoisc has quit IRC | 16:55 | |
| milan | aarefiev, hey, you here? | 16:55 |
| rcarrillocruz | TheJulia: that sounds like a plan | 16:56 |
| rcarrillocruz | i'll find some time this week to capture that and provide to the bug report | 16:56 |
| thiagop | lucasagomes: woot! | 16:56 |
| thiagop | lucasagomes: tyvm | 16:57 |
| lucasagomes | no worries | 16:57 |
| TheJulia | rcarrillocruz: Thank you, just ping me with the bug # when you have it posted and I'll take a look | 16:57 |
| lucasagomes | I'm calling it a day as well | 16:57 |
| TheJulia | goodnight lucasagomes | 16:57 |
| lucasagomes | have a great evening all | 16:57 |
| lucasagomes | rcarrillocruz, please ping me too | 16:57 |
| jlvillal | lucasagomes: Ciao! | 16:57 |
| thiagop | good night lucasagomes | 16:57 |
| lucasagomes | see ye :-) | 16:57 |
| jlvillal | sambetts: Good night. | 16:58 |
| *** lucasagomes is now known as lucas-dinner | 16:58 | |
| *** gfhellma1 has joined #openstack-ironic | 17:00 | |
| *** rama_y has joined #openstack-ironic | 17:01 | |
| *** praneshp has quit IRC | 17:03 | |
| *** gfhellma has quit IRC | 17:03 | |
| jjohnson2 | lucas-dinner, heh, and you under-indented it | 17:04 |
| openstackgerrit | Jarrod Johnson proposed openstack/pyghmi: Tolerate client reuse of UDP ports https://review.openstack.org/362944 | 17:04 |
| openstackgerrit | Merged openstack/ironic-python-agent: Remove unused requirements https://review.openstack.org/362752 | 17:05 |
| * milan gone, good night Ironic! :) | 17:05 | |
| NobodyCam | night lucas-dinner | 17:06 |
| NobodyCam | night sambetts | 17:06 |
| thiagop | night milan | 17:06 |
| NobodyCam | night milan | 17:06 |
| *** mgoddard_ has joined #openstack-ironic | 17:06 | |
| *** aNupoisc has joined #openstack-ironic | 17:06 | |
| thiagop | hiya NobodyCam ! | 17:06 |
| NobodyCam | morning thiagop | 17:07 |
| *** mgoddard has quit IRC | 17:09 | |
| xavierr | hey NobodyCam o/ | 17:10 |
| milan | night thiagop NobodyCam :) | 17:11 |
| NobodyCam | Morning xavierr | 17:11 |
| NobodyCam | :) | 17:11 |
| *** ijw has joined #openstack-ironic | 17:11 | |
| *** rcernin has quit IRC | 17:12 | |
| *** thrash|biab is now known as thrash | 17:13 | |
| *** tesseract- has quit IRC | 17:14 | |
| *** milan has quit IRC | 17:15 | |
| jroll | devananda|MOVING: rloo: feel like doing api v.next meeting today or nah? (I don't have anything) | 17:17 |
| rloo | jroll: oh, totally forgot about it. | 17:17 |
| rloo | i'm fine not doing it. unless i can ask osc-related questions. | 17:17 |
| *** rbrud has joined #openstack-ironic | 17:18 | |
| jroll | lol | 17:18 |
| jroll | rloo: not allowed! | 17:18 |
| rloo | jroll: drats | 17:18 |
| rloo | jroll: i know it is an API meeting not a CLI meeting :) | 17:18 |
| jroll | you can talk about them here but I can't promise I won't take a break instead :) | 17:18 |
| rloo | jroll: ha ha. or i can send an email to the ml and see if i get any responses. | 17:19 |
| jroll | rloo: haven't you sent enough osc questions to the ML this week? :) | 17:19 |
| rloo | jroll: it relates to maintenance (mode). is it set/unset, enable/disable, on/off. | 17:19 |
| jroll | didn't we do this once already :( | 17:19 |
| rloo | jroll: don't we have a client deadline this week? procrastination... | 17:19 |
| jroll | in the spec review or something? | 17:19 |
| rloo | jroll: the problem is 'openstack baremetal node list --maintenance' | 17:19 |
| rloo | jroll: it only filters for maintenance=true. | 17:19 |
| rloo | jroll: we don't have anything for maintenance=false | 17:20 |
| rloo | jroll: like we do with ironic node-list --maintenance <value> | 17:20 |
| jroll | rloo: ah, our API does have that right? | 17:20 |
| rloo | jroll: i *think* the osc way is to have something like --maintenance-on, --maintenance-off, instead of --maintenance <value> | 17:20 |
| jroll | I guess it does, if ironic does | 17:20 |
| jroll | hm | 17:20 |
| rloo | jroll: am not sure what the right wording is. | 17:21 |
| NobodyCam | morning jroll rloo :) | 17:21 |
| jroll | can we just punt that question to ocata? | 17:21 |
| rloo | jroll: esp since i saw that openstack host set --enable-maintenance | 17:21 |
| rloo | jroll: yea, i'm fine punting. that's one of the bugs i mentioned :) | 17:21 |
| jroll | heh, ok | 17:21 |
| rloo | jroll: i should open a bug for that though. one day... | 17:21 |
| jroll | rloo: one thing to note: if there's something that misses newton for osc stuff, not a big deal, since most people will just 'pip install' and won't care about stable/* | 17:22 |
| jroll | stable/* in clients is generally only used for library usage | 17:22 |
| rloo | jroll: yeah, just that i personally don't want to look into osc after that :) | 17:23 |
| *** ijw has quit IRC | 17:24 | |
| rloo | jroll: and having both cli and osc sync'd, makes it easier to review/make sure future things are in sync too. | 17:24 |
| rloo | jroll: but yeah, not going to kill myself over that :) | 17:24 |
| *** tesseract- has joined #openstack-ironic | 17:24 | |
| *** pcaruana has quit IRC | 17:25 | |
| *** ijw has joined #openstack-ironic | 17:25 | |
| jroll | rloo: right, totally agree, just saying let's not stay up until 10pm reviewing things wednesday night or whatever :) | 17:25 |
| rloo | jroll: gotcha! | 17:26 |
| jroll | clients will likely branch late this week / early next week, so we won't be waiting long | 17:26 |
| *** joprovost has quit IRC | 17:27 | |
| rloo | jroll: ok | 17:27 |
| *** sdake has joined #openstack-ironic | 17:27 | |
| *** tesseract- has quit IRC | 17:28 | |
| *** praneshp has joined #openstack-ironic | 17:28 | |
| JayF | https://review.openstack.org/#/c/356811/7 metrics documentation; I'd really love to get some reviews on this. It's been sitting for over three weeks | 17:29 |
| *** wajdi_ has joined #openstack-ironic | 17:34 | |
| rloo | JayF: review more of the osc-related patches, and i'll look at that doc later this week | 17:36 |
| JayF | I've been neck deep in OSC :) All these patches have my juices flowing | 17:37 |
| JayF | clouds.yaml is *great* | 17:38 |
| *** wajdi has quit IRC | 17:38 | |
| rloo | JayF: yeah, I know :-) and thx! I'll look at that patch this week. maybe today. or not. | 17:38 |
| JayF | I think doing code and docs together is good because 1) it guarantees the docs get written and 2) it blackmails reviewers into landing the docs too | 17:39 |
| JayF | lol | 17:39 |
| rloo | JayF: agree. in fact, i don't think we should say a feature is complete until the docs exist too | 17:40 |
| rloo | JayF: hmm, i have an idea. maybe the last code patch for a feature has to depend on the doc patch! | 17:40 |
| rloo | JayF: on the other hand, i don't want to penalize people cuz they can't write English. | 17:41 |
| mari0jv | then there's a risk that the docs will merge without the code merging, right? | 17:41 |
| thiagop | JayF: reviewing... not that familiar with the feature, but... | 17:41 |
| mari0jv | i like having them together. maybe if there are language barriers, someone can be listed as coauthor | 17:41 |
| openstackgerrit | Mario Villaplana proposed openstack/ironic: Add power state change notifications https://review.openstack.org/321865 | 17:42 |
| JayF | rloo: I mean, with some of the oneview stuff, I helped (in review) polish up some of the docs | 17:42 |
| rloo | mari0jv: we could do one of those -2 until the 'necessary' patches are all ok or something but that seems too heavy handed/admin-overhead-ish. | 17:43 |
| JayF | rloo: Maybe we need a more formal list of doc mentors? Folks willing to help improve docs if someone is willing to take a stab at them, even in broken english? | 17:43 |
| JayF | My point with what I said before was more: we say we like docs, we should prioritize landing docs | 17:43 |
| JayF | something something we need 30 hours in a day | 17:44 |
| rloo | JayF: I dunno. I mean, as long as I'm not expected to volunteer as a mentor, it is fine with me. | 17:44 |
| JayF | rloo: I volunteer o/ | 17:44 |
| JayF | rloo: was more the point :) | 17:44 |
| rloo | JayF: we do like docs, just like we do like code... or me anyway. And it would be awesome if you'd volunteer! | 17:44 |
| openstackgerrit | Andreas Jaeger proposed openstack/python-ironicclient: Sync tools/tox_install.sh https://review.openstack.org/363069 | 17:48 |
| openstackgerrit | Andreas Jaeger proposed openstack/python-ironic-inspector-client: Sync tools/tox_install.sh https://review.openstack.org/363071 | 17:48 |
| JayF | rloo: did you test https://review.openstack.org/#/c/362515/ locally? | 17:50 |
| rloo | JayF: yup. i think. can't keep track of everything. | 17:50 |
| JayF | rloo: I can't get it to work in my devstack -> Client-side error: Unknown argument: "chassis" from (pid=22355) format_exception /usr/local/lib/python2.7/dist-packages/wsme/api.py:221 | 17:50 |
| rloo | JayF: sec, let me try. | 17:50 |
| JayF | openstack baremetal node list --chassis 8b568c16-c411-4c65-822f-c19761bf7c6c \n Unknown argument: "chassis" (HTTP 400) | 17:50 |
| JayF | was what gave it to me | 17:51 |
| rloo | JayF: i may not have tried cuz i didn't create a chassis... | 17:51 |
| *** michauds has quit IRC | 17:52 | |
| rloo | JayF: oh, i must have forgotten to test that, i don't see it in my env. | 17:52 |
| rloo | JayF: yup, it is wrong. should be chassis_uuid i think. | 17:57 |
| JayF | I have those ^ comments and a -1 on the patch | 17:58 |
| JayF | I almost landed it without testing it in devstack :) | 17:58 |
| JayF | whee | 17:59 |
| *** baoli has quit IRC | 17:59 | |
| rloo | JayF: thx for testing. I have tested so many osc commands several times, that i must have forgotten to do this one, thinking i had done it already. | 17:59 |
| *** baoli has joined #openstack-ironic | 18:00 | |
| JayF | it's no big deal :) | 18:00 |
| *** Sukhdev has joined #openstack-ironic | 18:01 | |
| *** e0ne has joined #openstack-ironic | 18:01 | |
| rloo | JayF: while it is still fresh in your mind (I hope), wrt mrda's comment, any suggestions? (words are hard) | 18:02 |
| rloo | JayF: https://review.openstack.org/#/c/362515/1/ironicclient/osc/v1/baremetal_node.py | 18:02 |
| openstackgerrit | Andreas Jaeger proposed openstack/ironic-lib: Sync tools/tox_install.sh https://review.openstack.org/363086 | 18:03 |
| *** Sukhdev has quit IRC | 18:04 | |
| *** leitan has joined #openstack-ironic | 18:04 | |
| *** gfhellma1 has quit IRC | 18:05 | |
| leitan | Hi guys, quick question, does anybody has a config reference of ironic using Nuage as SDN provider ? | 18:05 |
| *** tesseract- has joined #openstack-ironic | 18:05 | |
| leitan | ref architecture / pdf, etc | 18:05 |
| *** tesseract- has quit IRC | 18:05 | |
| *** tesseract- has joined #openstack-ironic | 18:06 | |
| *** gfhellma has joined #openstack-ironic | 18:06 | |
| openstackgerrit | Merged openstack/ironic-lib: Extend parse_root_device_hints to support operators https://review.openstack.org/348953 | 18:06 |
| *** tesseract- has quit IRC | 18:08 | |
| *** michauds has joined #openstack-ironic | 18:09 | |
| *** tesseract- has joined #openstack-ironic | 18:10 | |
| *** joprovost has joined #openstack-ironic | 18:12 | |
| *** wajdi_ has quit IRC | 18:13 | |
| *** wajdi has joined #openstack-ironic | 18:14 | |
| greghaynes | TheJulia: Just accidentally pinged you in infra for this, but I'm hitting http://paste.ubuntu.com/23112910/ when using latest bifrost | 18:14 |
| greghaynes | cinerama: aha! https://review.openstack.org/#/c/354626/ does look promising | 18:15 |
| openstackgerrit | Merged openstack/python-ironicclient: Adds node boot device & passthru OSC commands https://review.openstack.org/357400 | 18:15 |
| *** joprovost has quit IRC | 18:16 | |
| *** joprovost has joined #openstack-ironic | 18:16 | |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Add --chassis to 'openstack baremetal node list' https://review.openstack.org/362515 | 18:18 |
| greghaynes | cinerama: hrm, doing a simlar fix in the role thats failing for me doesnt seem to work | 18:18 |
| *** aNupoisc has quit IRC | 18:27 | |
| *** tesseract- has quit IRC | 18:30 | |
| *** tesseract- has joined #openstack-ironic | 18:30 | |
| *** tesseract- has quit IRC | 18:30 | |
| *** tesseract- has joined #openstack-ironic | 18:31 | |
| *** mgoddard_ has quit IRC | 18:31 | |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Add node validate OSC command https://review.openstack.org/359322 | 18:31 |
| openstackgerrit | Merged openstack/pyghmi: Tolerate client reuse of UDP ports https://review.openstack.org/362944 | 18:33 |
| JayF | rloo: I'd leave it be, or remove the () around it | 18:37 |
| *** tesseract- has quit IRC | 18:37 | |
| *** fragatin_ has quit IRC | 18:38 | |
| JayF | rloo: what you put matches the way I thought about it, even though wording wasn't exact, +1 | 18:39 |
| rloo | JayF: too late. I modified it. | 18:41 |
| rloo | JayF: should be clearer now :) | 18:41 |
| *** mtanino has joined #openstack-ironic | 18:41 | |
| JayF | rloo: it still seems to be sending ?chassis= instead of ?chassis_uuid= in my devstack? | 18:43 |
| rloo | JayF: what? let me check | 18:43 |
| JayF | 2016-08-30 18:39:25.378 DEBUG wsme.api [req-0e5ea411-292a-43e4-8c68-289a50f6a221 admin admin] Client-side error: Unknown argument: "chassis" from (pid=22354) format_exception /usr/local/lib/python2.7/dist-packages/wsme/api.py:221 | 18:43 |
| JayF | 2016-08-30 18:39:25.380 INFO eventlet.wsgi.server [req-0e5ea411-292a-43e4-8c68-289a50f6a221 admin admin] 104.130.14.217 "GET /v1/nodes/?chassis=8b568c16-c411-4c65-822f-c19761bf7c6c HTTP/1.1" status: 400 len: 459 time: 0.0290940 | 18:43 |
| JayF | unless I comlpetely fail at changing the client I'm using, which is also possible, lol | 18:44 |
| JayF | --chassis <chassis> Limit list to nodes of this chassis (UUID) | 18:44 |
| JayF | I think I fail at changing the client I'm using | 18:44 |
| rloo | JayF: it should be ?chassis_uuid=... | 18:44 |
| rloo | JayF: I don't think you got the change | 18:44 |
| rloo | JayF: should be --chassis <chassis UUID> ... | 18:44 |
| JayF | ah, got it fixed, and it works | 18:46 |
| JayF | on the downside, I think I just hozed all the local python pacakges on my devstack vm | 18:46 |
| openstackgerrit | Fabio Dassan proposed openstack/pyghmi: Implement M4 and Kent support https://review.openstack.org/361457 | 18:49 |
| *** aignatov has quit IRC | 18:50 | |
| *** jtomasek has quit IRC | 18:51 | |
| *** ianw has quit IRC | 18:51 | |
| *** jrist has quit IRC | 18:52 | |
| *** NobodyCam has quit IRC | 18:52 | |
| *** cmyster has quit IRC | 18:52 | |
| *** hecliunyx has quit IRC | 18:52 | |
| *** cmyster has joined #openstack-ironic | 18:53 | |
| *** aNupoisc has joined #openstack-ironic | 18:53 | |
| *** NobodyCam has joined #openstack-ironic | 18:54 | |
| *** leitan has quit IRC | 18:55 | |
| *** aignatov has joined #openstack-ironic | 18:56 | |
| *** hecliunyx has joined #openstack-ironic | 18:58 | |
| *** intr1nsic has quit IRC | 18:58 | |
| *** causten has quit IRC | 18:59 | |
| *** intr1nsic has joined #openstack-ironic | 19:01 | |
| *** causten has joined #openstack-ironic | 19:03 | |
| *** causten_ has joined #openstack-ironic | 19:03 | |
| *** jtomasek has joined #openstack-ironic | 19:03 | |
| JayF | jroll: I think we'll need an IPA release this week, since client freeze for newton is coming up? | 19:04 |
| JayF | jroll: looks like we haven't released IPA since early July | 19:04 |
| *** david-lyle_ is now known as david-lyle | 19:05 | |
| *** jrist has joined #openstack-ironic | 19:07 | |
| *** causten has quit IRC | 19:08 | |
| *** baoli has quit IRC | 19:10 | |
| thiagop | Anyone from the multitenant work could help me debug https://review.openstack.org/#/c/359990/ ?? | 19:10 |
| thiagop | I'm a little lost... | 19:10 |
| *** ijw has quit IRC | 19:16 | |
| *** ianw_ has joined #openstack-ironic | 19:28 | |
| *** rama_y has quit IRC | 19:28 | |
| *** Sukhdev has joined #openstack-ironic | 19:28 | |
| *** baoli has joined #openstack-ironic | 19:28 | |
| *** dprince has quit IRC | 19:35 | |
| *** e0ne has quit IRC | 19:36 | |
| *** jcoufal has quit IRC | 19:38 | |
| *** rcernin has joined #openstack-ironic | 19:39 | |
| *** causten_ has quit IRC | 19:40 | |
| *** jcoufal has joined #openstack-ironic | 19:40 | |
| *** fragatina has joined #openstack-ironic | 19:43 | |
| *** causten has joined #openstack-ironic | 19:44 | |
| mari0jv | is the priorities trello down? https://trello.com/b/ROTxmGIc/ironic-newton-priorities i was looking for something of priority to review | 19:45 |
| rloo | mari0jv: trello works for me | 19:46 |
| rloo | mari0jv: maybe it is flaky? | 19:46 |
| mat128 | works here too | 19:46 |
| mari0jv | unclear, i use ublock, but turning it off doesn't seem to help | 19:46 |
| mari0jv | got it working in incognito, thanks | 19:47 |
| jjohnson2 | lucas-dinner, fyi, 1.0.9 I just pushed | 19:48 |
| rloo | mari0jv: looking at your power state patch | 19:49 |
| rloo | mari0jv: so what bothers me is wording-bikeshedding. | 19:49 |
| mari0jv | with .start and .end? | 19:49 |
| rloo | mari0jv: we have 'set_power_state.start', 'set_power_state.end', and 'provision_state_change.start' | 19:49 |
| rloo | mari0jv: yeah, are start, end, common terms/actions in the notification world? | 19:50 |
| *** dprince has joined #openstack-ironic | 19:50 | |
| rloo | mari0jv: i guess they aren't actions, they are events, start/stop | 19:50 |
| mari0jv | i think so. in nova, for instance, compute.instance.create.start occurs when the compute receives a build request | 19:50 |
| mari0jv | compute.instance.create.end occurs after the build finishes | 19:50 |
| rloo | mari0jv: the action is setting/changing power state. | 19:50 |
| mari0jv | there are .update events in between | 19:50 |
| mari0jv | exactly | 19:51 |
| rloo | mari0jv: so maybe we have to be careful about the wording (i've just been spending time looking at openstackclient so...) | 19:51 |
| mari0jv | rloo: i'd like to leave the power state notifications as-is, and i think the provision state changes should match that convention | 19:51 |
| *** rbrud has quit IRC | 19:51 | |
| rloo | mari0jv: power_set.start/end, provision_set.start/end? | 19:51 |
| mari0jv | so when you start a state transition and set target_provision_state, it's a .start. when it finishes and the node is saved with updated state info, it's a .end | 19:51 |
| mari0jv | yes | 19:52 |
| mari0jv | i had a comment about the notification levels on the provision state patch set, that's why i -1ed | 19:52 |
| JayF | mari0jv: what about provision state changes that don't have a start/end? | 19:52 |
| rloo | mari0jv: ok, the provision state is tricky with the fail stuff then. cuz *FAIL is a state | 19:52 |
| JayF | mari0jv: like when things to DEPLOYING -> DEPLOYWAIT -> DEPLOYING, the API call was set-prov-state ACTIVE | 19:52 |
| mari0jv | JayF: you can either a) send a .start and .end, or b) send an event without .start or .end | 19:52 |
| mari0jv | i prefer b) | 19:53 |
| mari0jv | JayF: oh, i understand | 19:53 |
| JayF | mari0jv: but if I call api saying 'set prov state to active' | 19:53 |
| JayF | you can't do "starting to make it active" | 19:53 |
| rloo | mari0jv: i was also wondering how the power notifications fit in with that new soft-power-spec-thingy | 19:53 |
| mari0jv | JayF: the way yuriyz wanted to deal with that is to define some "unstable states" for which the notification level would differ | 19:53 |
| JayF | it's really an implict set of transitions, AVAIL -> DEPLOYING -> DEPLOYWAIT -> DEPLOYING -> ACTIVE | 19:53 |
| mari0jv | rloo: do you have a link to the spec? | 19:53 |
| *** jcoufal has quit IRC | 19:54 | |
| JayF | even if the level differs, I think it makes the "start + end" bit different | 19:54 |
| mari0jv | JayF: i agree, i'd check out yuriy's spec | 19:54 |
| rloo | mari0jv: http://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/enhance-power-interface-for-soft-reboot-and-nmi.html | 19:54 |
| JayF | okie | 19:54 |
| mari0jv | thanks | 19:54 |
| mari0jv | rloo: looking | 19:54 |
| rloo | maybe .start/end should only reflect the requested state, not intermediate states | 19:54 |
| mari0jv | and maybe everything in between is a .update | 19:55 |
| mari0jv | rloo: ^ | 19:55 |
| JayF | I mean, we don't have any ironic states that take time to take effect | 19:55 |
| JayF | you send a verb, then the states start changing | 19:55 |
| rloo | mari0jv: I'm not sure the .update makes sense. | 19:56 |
| JayF | but there's no idea of a state change 'beginning' and 'ending' | 19:56 |
| JayF | in ironic it's atomic | 19:56 |
| rloo | mari0jv: have you looked at the nova's notifications? is that a good example to model? if so, i can take a look. | 19:56 |
| mari0jv | if we wanted to remove .start and .end, that's possible. the "phase" (last part of the event field) isn't required | 19:56 |
| JayF | rloo: mari0jv wrote a giant backend system at Rackspace that eats nova notifications for breakfast :) | 19:56 |
| mari0jv | rloo: a little, but not a lot since versioned notifications merged there | 19:56 |
| JayF | rloo: that's why he started on the ironic notifications stuff for us :D | 19:57 |
| rloo | JayF: I think we might be referring to when we set a target state, and when/if we actually get to that target state | 19:57 |
| mari0jv | JayF: I didn't write it, but i've used it extensively | 19:57 |
| *** aNupoisc has quit IRC | 19:57 | |
| *** harlowja has quit IRC | 19:58 | |
| JayF | I almost think that'd be a different type of notification; like maybe have there be a notification of "node changed provision state" | 19:58 |
| rloo | mari0jv: what I am looking for, is a guideline for how these notifications are 1. named; 2. when we should add notifications. cuz otherwise, it'll be a mess down the road when people want to add new notifications. | 19:58 |
| JayF | vs "provision state api hit" which could more reasonably be start/end/error as needed | 19:58 |
| mari0jv | rloo: with regards to the soft reboot spec; i think the only thing that would change in a power state notification is the target_power_state field sent with the notification | 19:58 |
| *** rama_y has joined #openstack-ironic | 19:58 | |
| *** jvgrant has joined #openstack-ironic | 19:59 | |
| rloo | mari0jv: and wrt notification level, that's the DEBUG/INFO/etc stuff. Not to specify types of, eg 'power', 'crud', 'provision' notifications? | 20:00 |
| mari0jv | rloo: https://github.com/openstack/ironic-specs/blob/master/specs/approved/notifications.rst see the "event_type" point under "proposed change" | 20:00 |
| mari0jv | rloo: correct | 20:00 |
| mari0jv | the spec has somewhat of a naming convention | 20:00 |
| *** Sukhdev has quit IRC | 20:00 | |
| rloo | mari0jv: and that's fine, operators don't care if they get new notifications? | 20:00 |
| mari0jv | as for "when to add notifications," that's a bit debatable | 20:00 |
| mari0jv | rloo: notifications only get sent when you enable them. you can set the level at which you receive them too | 20:01 |
| mari0jv | rloo: so if you specify notification_level="warning" in your ironic config, you'll only get warning and above | 20:01 |
| mari0jv | they're disabled by default | 20:02 |
| rloo | mari0jv: so the examples in the spec aren't that clear. eg, we don't have node_create.start/end, we have .created | 20:02 |
| rloo | mari0jv: or maybe the crud spec is wrong. | 20:02 |
| mari0jv | rloo: you're right, idk if that's considered a proper phase. the original spec doesn't mention it | 20:02 |
| mari0jv | actually | 20:03 |
| mari0jv | that's the descriptor | 20:03 |
| rloo | mari0jv: why is it set_power_state.start, but state_change.start? why isn't it power_change.start? | 20:03 |
| mari0jv | "event_type will be a short string describing the notification. Each string will start with "baremetal." to distinguish ironic notifications from other notifications on the message bus. | 20:03 |
| mari0jv | This will be followed by the object that's being acted on, optionally the field of the object being acted on, a descriptor of the action being taken, and the phase of the action ("start", "end", potentially "fail"), if applicable. " | 20:03 |
| mari0jv | rloo: there's a set power state and sync power state notification. i guess that's to distinguish them | 20:04 |
| *** sabeen has joined #openstack-ironic | 20:04 | |
| mari0jv | rloo: so going back to the crud spec, the .created in "baremetal.node.created" just specifies what's occurring | 20:05 |
| mari0jv | just like "baremetal.node.set_power_state" is specifying what's occurring | 20:05 |
| *** gfhellma has quit IRC | 20:05 | |
| mari0jv | with set_power_state, there are .start and .end events because ironic completes the task asynchronously | 20:05 |
| rloo | mari0jv: is the power* patch the first one that emits notifications? | 20:05 |
| mari0jv | rloo: yes | 20:05 |
| mari0jv | the framework for them is merged, but there are none emitting yet | 20:05 |
| rloo | and what notifications/ event_types are there? it isn't in the commit | 20:05 |
| TheJulia | greghaynes: Sorry, was away, I'm guessing that revision didn't help you, but I suspect 354620 would resolve the issue :) | 20:06 |
| mari0jv | baremetal.set_power_state.{start,end,fail} | 20:06 |
| *** gfhellma has joined #openstack-ironic | 20:06 | |
| *** rbrud has joined #openstack-ironic | 20:06 | |
| rloo | mari0jv: and the sync one? | 20:07 |
| mari0jv | and baremetal.node.sync_power_state, baremetal.node.sync_power_state.fail | 20:07 |
| rloo | mari0jv: there's a node there too, right? baremetal.node.set_power_state...? | 20:07 |
| mari0jv | rloo: baremetal.set_power_state.{start,end,fail} and baremetal.node.sync_power_state and baremetal.node.sync_power_state.fail | 20:08 |
| mari0jv | sync power state has no phases unless it fails | 20:08 |
| mari0jv | rloo: correct, there's a node | 20:08 |
| rloo | mari0jv: is the idea to be precise, that we're focused on the node's 'power_state' field? or can we just use 'power', eg baremetal.node.power_set.{start,end,fail} | 20:08 |
| mari0jv | rloo: maybe this patch should introduce documentation for all the potential types of notifications ironic may emit? | 20:08 |
| *** jcoufal has joined #openstack-ironic | 20:08 | |
| mari0jv | rloo: yes, it's just precision. i'm not opposed to just having power_set even though that's not in the original spec | 20:09 |
| rloo | mari0jv: would be good. is there already notification documentation (other than spec)? | 20:09 |
| mari0jv | we'd need power_sync too though | 20:09 |
| mari0jv | rloo: yes, 1 sec | 20:09 |
| mari0jv | rloo: http://docs.openstack.org/developer/ironic/dev/notifications.html | 20:09 |
| rloo | mari0jv: thx, i should have read that instead of the spec. | 20:10 |
| mari0jv | rloo: that's more of a "how to create notifications" doc though, doesn't really list them out | 20:10 |
| mari0jv | i could either add a section there, or create a separate page | 20:10 |
| mari0jv | np | 20:10 |
| rloo | mari0jv: we can enhance once we know... | 20:10 |
| mari0jv | sgtm | 20:10 |
| jroll | JayF: IPA isn't a client, it's a service, but yeah we should release it. I was waiting for something (don't remember what) and then I guess I never looped back to it | 20:11 |
| *** sdake has quit IRC | 20:11 | |
| *** sdake has joined #openstack-ironic | 20:12 | |
| mari0jv | rloo: i added a comment on the power notifications patch reflecting our discussion: https://review.openstack.org/#/c/321865/24 | 20:12 |
| mari0jv | thanks | 20:12 |
| rloo | mari0jv: thx. i'll think about it a bit more and in relationship to the crud spec. | 20:12 |
| *** jvgrant has quit IRC | 20:12 | |
| rloo | mari0jv: sorry, why can't power_sync have a .start/end/fail? | 20:14 |
| mari0jv | rloo: that's there from a discussion JayF and I had around a month ago i think. basically it's there so you can keep track of a node's power state history over time | 20:15 |
| mari0jv | rloo: the sync notification gets sent when ironic detects that a change has occurred in the power state | 20:15 |
| mari0jv | rloo: so it doesn't make sense for it to .start and .end, because it's not changing anything, just retrieving information | 20:15 |
| mari0jv | rloo: .fail can occur when the sync can't retrieve the power state | 20:16 |
| rloo | mari0jv: if it is just retrieving and no power change, why would you need it to keep track of the node's power state? | 20:16 |
| mari0jv | rloo: we don't notify if there's no power state change | 20:16 |
| rloo | mari0jv: you have the set_power notifications | 20:16 |
| mari0jv | imagine this scenario: 1. operator sets power state to power off, set_power .start and .end are sent | 20:17 |
| mari0jv | 2. another operator hits the BMC and manually powers on, outside of ironic | 20:17 |
| mari0jv | 3. the sync detects the change and switches power_state to reflect the fact that the node's power state is now on | 20:17 |
| mari0jv | 4. sync sends a notification indicating the change | 20:18 |
| mari0jv | without the sync notification, the change is invisible to the external service consuming notifications | 20:18 |
| rloo | mari0jv: this is bringing back memories of having discussions about the power state of the actual HW vs ironic node that represents that HW | 20:18 |
| mari0jv | another scenario having just step 1 and 3 with no change would only send the power_set notifications | 20:18 |
| mari0jv | at the moment, ironic updates itself to reflect reality | 20:19 |
| openstackgerrit | Merged openstack/bifrost: Remove 'auth' fact initialization from bifrost-deploy-nodes-dynamic https://review.openstack.org/354626 | 20:19 |
| rloo | mari0jv: if i recall, we have some funky alg wrt what 'sync'ing the power state means. | 20:19 |
| jroll | mari0jv: actually, it depends :D | 20:19 |
| jroll | we have a config | 20:19 |
| rloo | ^^ that | 20:19 |
| jroll | CONF.conductor.force_power_state_during_sync | 20:20 |
| mari0jv | jroll: rloo: i think where we send notifications is guarded by the correct if statements | 20:20 |
| jroll | I haven't followed enough of this conversation to know what you mean, sorry | 20:20 |
| rloo | mari0jv: I'm not worried about the coding. I'm trying to grok what information/notifications we want to emit, and how/if those event types are clear/consistent/blah blah. | 20:21 |
| mari0jv | ok, so force_power_state_during_sync means that you attempt to make the node reflect what power state ironic thinks it's in | 20:21 |
| jroll | right | 20:21 |
| mari0jv | so, that only affects the "set_power" notifications | 20:21 |
| rloo | mari0jv: in which case, there is a start/end/fail? | 20:21 |
| mari0jv | rloo: yes | 20:22 |
| mari0jv | but for set_power notifications | 20:22 |
| mari0jv | sync does not have start/end | 20:22 |
| rloo | mari0jv: i guess 'sync' depends on your definition. i think for you, it is .updated perhaps? | 20:22 |
| rloo | mari0jv: only cuz we use 'sync' to mean more than just updating node.power_state | 20:23 |
| mari0jv | rloo: yes, it's when ironic gets updated based on the power state of hardware | 20:23 |
| mari0jv | rloo: right, so maybe the naming isn't correct | 20:23 |
| rloo | mari0jv: sigh. even if we use .updated, the end user has to understand the context. that our db was updated, not the actual hw. | 20:23 |
| mari0jv | yeah, it's tricky | 20:24 |
| mari0jv | docs will help with this a lot i think | 20:24 |
| rloo | mari0jv: although .updated fits in with the crud i think. .created, .deleted, .updated if i recall correctly | 20:24 |
| mari0jv | rloo: i had this exact problem in semantics with nova, so i'm glad you're bringing this up | 20:24 |
| mari0jv | rloo: compute.instance.create.error does not always mean that a build fails | 20:24 |
| rloo | mari0jv: oh :-( | 20:25 |
| rloo | mari0jv: and why do they use .error, aren't we using .fail? | 20:25 |
| mari0jv | rloo: not exactly, because those are baremetal.node.{created,deleted,updated} | 20:25 |
| jroll | hm, the hw was updated at some point, though, just we send notification when we notice it | 20:25 |
| mari0jv | rloo: this would be baremetal.node.power_state.updated or something | 20:25 |
| mari0jv | rloo: it was to avoid that semantic issue :) | 20:25 |
| rloo | jroll: i see the .updated as when ironic updates its db | 20:25 |
| *** sabeen has quit IRC | 20:25 | |
| mari0jv | jroll: yes | 20:26 |
| jroll | hm | 20:26 |
| mari0jv | what about "baremetal.node.power_state_changed" | 20:27 |
| mari0jv | ? | 20:27 |
| mari0jv | for the current "sync" notification name | 20:27 |
| rloo | baremetal.node.power.changed? | 20:27 |
| rloo | baremetal.node.power.change-detected? | 20:28 |
| mari0jv | rloo: i prefer to keep that last thing after the . for start, end, or fail | 20:28 |
| rloo | mari0jv: oh. | 20:28 |
| mari0jv | although, there's nothing in the code explicitly requiring that https://github.com/openstack/ironic/blob/master/ironic/objects/notification.py#L47 | 20:29 |
| mari0jv | btw, for anyone actually using these, i've heard yagi is a really neat tool for that | 20:30 |
| mari0jv | it just takes notifications from any number of amqp queues and runs them through handlers | 20:31 |
| rloo | mari0jv: you're confusing me. the crud spec has .created/updated/deleted | 20:31 |
| mari0jv | i haven't deployed it myself, but it has some nice features like letting you persist events to elasticsearch | 20:31 |
| mari0jv | rloo: those are actions, not phases | 20:32 |
| *** aNupoisc has joined #openstack-ironic | 20:32 | |
| mari0jv | it's baremetal.<object>.<action>.<phase> | 20:32 |
| mari0jv | so baremetal.node.created fits into that ^ | 20:32 |
| *** rcernin has quit IRC | 20:33 | |
| rloo | mari0jv: the action is 'create'. 'created' indicates that the phase is 'finished' | 20:33 |
| *** rcernin has joined #openstack-ironic | 20:33 | |
| * rloo confused | 20:34 | |
| mari0jv | the spec just says "created" | 20:34 |
| rloo | mari0jv: if you want to go with that syntax, it would seem to me that it should be baremetal.node.create.end|fail|done|something | 20:35 |
| *** trown is now known as trown|outtypewww | 20:35 | |
| mari0jv | rloo: i'm fine with that. i kind of like what JayF was saying earlier though about something that says "provision state changed" vs. "provision state change initiated ... provision state change completed" | 20:37 |
| mari0jv | i think just having .created accomplishes that | 20:37 |
| mari0jv | i wonder what yuriyz thinks | 20:37 |
| JayF | for atomic actions, we shouldn't emit two notifications | 20:37 |
| JayF | just for parallelism purposes | 20:37 |
| mari0jv | ++ | 20:37 |
| JayF | creating a node is an atomic DB action | 20:38 |
| mari0jv | imbw but i think rloo was just saying call it "baremetal.node.create.end" | 20:38 |
| mari0jv | and have the 1 notification | 20:38 |
| mari0jv | i'm saying "baremetal.node.created" and 1 notification | 20:38 |
| JayF | Oh, I don't have a strong opinion on that | 20:38 |
| mari0jv | i don't really care that much either way | 20:38 |
| rloo | mari0jv: or use something else than 'end'. | 20:38 |
| JayF | You're more of a user of those notifications | 20:38 |
| JayF | than I have ever been | 20:38 |
| mari0jv | but that's the reason phases are optional | 20:38 |
| mari0jv | i'm going to update yuriy's spec with a link to this convo | 20:39 |
| mari0jv | in comments | 20:39 |
| rloo | poor yuriy | 20:39 |
| mari0jv | ^_^; | 20:39 |
| *** ianw_ is now known as ianw | 20:39 | |
| *** ijw has joined #openstack-ironic | 20:40 | |
| mari0jv | rloo: what's the reasoning behind having .end|fail|done|something? consistency? | 20:40 |
| rloo | mari0jv: consistency. based on your syntax. | 20:41 |
| mari0jv | ok | 20:41 |
| mari0jv | i added a comment there: https://review.openstack.org/#/c/347242 | 20:42 |
| rloo | mari0jv: if the phase part is meant to indicate what state the action is in, then it seems to make sense that every action has a phase associated with it? | 20:42 |
| rloo | mari0jv: otherwise, how eg would one indicate that a 'create' failed? | 20:43 |
| mari0jv | rloo: you would have baremetal.node.create.fail. that actually makes sense to me why that would be more consistent now | 20:43 |
| JayF | maybe for items without a start/end, we should just indicate success/fail? | 20:44 |
| JayF | baremetal.node.create.success | 20:44 |
| TheJulia | ^^^^ that | 20:44 |
| mari0jv | i'm fine with this, +1 | 20:44 |
| rloo | JayF has a way with words :) | 20:45 |
| rloo | mari0jv: that makes more sense to me. | 20:45 |
| mari0jv | should we still allow the code to accept notification event types without phases? | 20:45 |
| openstackgerrit | Oleksandr Berezovskyi proposed openstack/bifrost: Make bifrost on stable/mitaka branch deploy stable/mitaka ironic https://review.openstack.org/363195 | 20:45 |
| JayF | mari0jv: is success/fail a "phase"? | 20:45 |
| JayF | mari0jv: or is "phase" just jargon meaning that final field | 20:46 |
| mari0jv | JayF: jargon meaning final field | 20:46 |
| mari0jv | baremetal.<object>.<action>.<phase> | 20:46 |
| *** wajdi_ has joined #openstack-ironic | 20:47 | |
| JayF | maybe for purposes of clarity, picking a different word wouldn't be awful? | 20:48 |
| JayF | if we're going to enforce having that final field be in place | 20:48 |
| JayF | baremetal.<object>.<action>.<disposition> or something similar? | 20:48 |
| JayF | disposition is not a good word, but is more accurate after this discussion | 20:48 |
| openstackgerrit | Oleksandr Berezovskyi proposed openstack/bifrost: Make bifrost on stable/mitaka branch deploy stable/mitaka ironic https://review.openstack.org/363197 | 20:49 |
| mari0jv | baremetal.<object>.<action>.<status>? | 20:49 |
| JayF | status or state would potentially work | 20:49 |
| rloo | i prefer status, we use 'state' for other things | 20:49 |
| JayF | mari0jv: how about mood /s | 20:50 |
| JayF | +1 for status | 20:50 |
| mari0jv | sounds good to me | 20:50 |
| JayF | so you wanna push an update to the base spec | 20:50 |
| JayF | indicating these changed opinions | 20:50 |
| JayF | then we can vote/comment there? | 20:50 |
| mari0jv | sure | 20:50 |
| mari0jv | i might not have time until next weeks | 20:51 |
| mari0jv | thanks for all the discussion about this though | 20:51 |
| mari0jv | *week | 20:51 |
| *** wajdi has quit IRC | 20:51 | |
| rloo | mari0jv: thank you! | 20:51 |
| *** wajdi_ has quit IRC | 20:52 | |
| *** joprovost has quit IRC | 20:53 | |
| thiagop | Folks, I gotta go but just fyi: I'm a little suspicious that a change in neutron broke the multitenant job | 20:56 |
| thiagop | The only common thing that I found between the most recent fails on the job was the version of neutron-openvswitch-agent, which is 9.0.0.0b3.dev599 | 20:58 |
| *** e0ne has joined #openstack-ironic | 20:58 | |
| *** sabeen has joined #openstack-ironic | 20:58 | |
| thiagop | Passing patches are with 9.0.0.0b3.dev593 | 20:58 |
| thiagop | Will take a look deeply into it tomorrow... | 20:58 |
| thiagop | See ya | 20:58 |
| *** baoli has quit IRC | 21:00 | |
| *** e0ne has quit IRC | 21:03 | |
| *** rbrud has quit IRC | 21:05 | |
| *** e0ne has joined #openstack-ironic | 21:06 | |
| *** jcoufal has quit IRC | 21:08 | |
| *** dprince has quit IRC | 21:08 | |
| *** jcoufal has joined #openstack-ironic | 21:12 | |
| *** harlowja has joined #openstack-ironic | 21:17 | |
| *** e0ne has quit IRC | 21:23 | |
| *** joprovost has joined #openstack-ironic | 21:25 | |
| mrda | Morning Ironic | 21:25 |
| JayF | o/ | 21:26 |
| mari0jv | morning mrda | 21:26 |
| *** sdake has quit IRC | 21:26 | |
| mrda | hey mari0jv | 21:29 |
| mrda | and JayF | 21:30 |
| *** sdake has joined #openstack-ironic | 21:32 | |
| *** sabeen has quit IRC | 21:35 | |
| TheJulia | good morning mrda | 21:36 |
| *** joprovost has quit IRC | 21:40 | |
| *** aNupoisc has quit IRC | 21:43 | |
| *** jcoufal has quit IRC | 21:43 | |
| mrda | hi TheJulia :) | 21:44 |
| *** gfhellma1 has joined #openstack-ironic | 21:44 | |
| *** gfhellma has quit IRC | 21:44 | |
| *** jcoufal has joined #openstack-ironic | 21:46 | |
| jlvillal | Hey mrda | 21:47 |
| mrda | Hi jlvillal | 21:47 |
| NobodyCam | morning mrda | 21:48 |
| NobodyCam | good afternoon jlvillal | 21:48 |
| *** gfhellma has joined #openstack-ironic | 21:48 | |
| mrda | Hiya NobodyCam | 21:48 |
| jlvillal | Hey NobodyCam! | 21:48 |
| NobodyCam | :) | 21:49 |
| *** gfhellma1 has quit IRC | 21:50 | |
| * jlvillal thinks there is a lot of cargo-culting in our API code after reviewing the portgroups code | 21:50 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic: Add metrics to administrator guide https://review.openstack.org/356811 | 21:53 |
| JayF | thiagop: ^ answered your questions and updated, thank you very much for the review! | 21:53 |
| *** aNupoisc has joined #openstack-ironic | 21:54 | |
| *** jcoufal has quit IRC | 21:58 | |
| *** michauds has quit IRC | 22:03 | |
| *** jcoufal has joined #openstack-ironic | 22:04 | |
| *** rajinir has quit IRC | 22:05 | |
| JayF | mat128: I just stole 1612278 from you | 22:07 |
| JayF | mat128: actually about to push up a patch for it, but obviously would love help on it | 22:08 |
| JayF | mat128: (install-guide) | 22:08 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic: Add cookiecutter base for install guide https://review.openstack.org/363294 | 22:13 |
| *** cdearborn has quit IRC | 22:14 | |
| *** sabeen has joined #openstack-ironic | 22:22 | |
| *** ianw has quit IRC | 22:26 | |
| openstackgerrit | Oleksandr Berezovskyi proposed openstack/bifrost: Add possibility to set source branch for ironic-inspector https://review.openstack.org/363300 | 22:30 |
| *** jrist has quit IRC | 22:32 | |
| *** sdake has quit IRC | 22:36 | |
| *** gfhellma has quit IRC | 22:38 | |
| *** gfhellma has joined #openstack-ironic | 22:39 | |
| *** jrist has joined #openstack-ironic | 22:39 | |
| *** mpsairam has quit IRC | 22:54 | |
| *** mpsairam has joined #openstack-ironic | 22:55 | |
| *** ianw has joined #openstack-ironic | 22:57 | |
| *** rpioso has quit IRC | 23:00 | |
| *** sabeen has quit IRC | 23:08 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic: Using assertIsNone() is preferred over assertEqual() https://review.openstack.org/362589 | 23:08 |
| *** praneshp has quit IRC | 23:08 | |
| *** praneshp has joined #openstack-ironic | 23:13 | |
| *** praneshp has quit IRC | 23:19 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent: Use namedtuple to improve code readability https://review.openstack.org/361788 | 23:21 |
| openstackgerrit | Merged openstack/ironic: Adds instructions to perform nodes migration https://review.openstack.org/357454 | 23:25 |
| *** rcernin has quit IRC | 23:35 | |
| *** jcoufal has quit IRC | 23:35 | |
| *** mari0jv has quit IRC | 23:39 | |
| *** praneshp has joined #openstack-ironic | 23:42 | |
| *** rloo has quit IRC | 23:42 | |
| *** rama_y has quit IRC | 23:46 | |
| JayF | lucas-dinner: https://bugs.launchpad.net/ironic/+bug/1582964 you had design questions about this RFE, so I just -2'd the patch. Might wanna have anotehr look and see if you're on board now. If you approve it ping me and I'll lift my -2 | 23:47 |
| openstack | Launchpad bug 1582964 in Ironic "[RFE] Support multi arch deployments" [Wishlist,In progress] - Assigned to Yibo Cai (cyb70289) | 23:47 |
| *** wajdi has joined #openstack-ironic | 23:48 | |
| *** aNupoisc has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!