JayF | I'm fixing bare metal provisioning at the company right now, so not-it | 00:00 |
---|---|---|
jroll | heh | 00:00 |
jamielennox | haha | 00:00 |
jamielennox | jroll: the way i've done this for other services is if the url in conf is not None then use it as an override, otherwise let the catalog do its thing | 00:01 |
jroll | jamielennox: yeah, that's totally fine, I thought that's what we do everywhere | 00:01 |
jamielennox | before the end of kilo i hope to bump the minimum version of auth_token middleware which will make some of this easier so fixing all this might wait till liberty | 00:02 |
devananda | jroll: I, too, thought that's what we did | 00:03 |
devananda | however, we're definitely not caching the tokens (well, if at all) | 00:03 |
*** yuanying has quit IRC | 00:03 | |
*** Marga_ has joined #openstack-ironic | 00:04 | |
jamielennox | is ironic on eventlet? | 00:04 |
*** yuanying has joined #openstack-ironic | 00:05 | |
jamielennox | probably could just grep for that answer | 00:05 |
*** oomichi has quit IRC | 00:06 | |
jroll | yes | 00:07 |
*** penick has quit IRC | 00:09 | |
devananda | yes | 00:09 |
*** yuanying_ has joined #openstack-ironic | 00:10 | |
*** yuanying has quit IRC | 00:10 | |
devananda | jamielennox: note that ironic-conductor has two pools. one for RPC, one for workers | 00:11 |
JayF | devananda: curious how you'll use reviewstats to judge core from IPA -> Ironic, given it doesn't break out agent reviews. Just trying to figure out what metric I'd be gunning for if I wanted core on the whole shebang | 00:11 |
*** jmccrory has quit IRC | 00:11 | |
*** igordcard has quit IRC | 00:12 | |
jroll | JayF: the biggest metric is how awesome the reviews are IMO | 00:12 |
*** mtanino has quit IRC | 00:12 | |
*** penick has joined #openstack-ironic | 00:13 | |
devananda | JayF: metrics inform, they don't dictate. | 00:13 |
*** andreykurilin_ has quit IRC | 00:14 | |
devananda | JayF: do good reviews on it, to the point where the core team is like "hell yea he should join the team" | 00:14 |
jroll | or "deva pls add this person to core" | 00:15 |
JayF | I just think it's probably not awesome at this point for IPA and Ironic core to be separate | 00:16 |
JayF | but it'd be less awesome for me and JoshNang to lose core on IPA for that to happen | 00:17 |
JayF | so I'm working in the other direction | 00:17 |
JayF | lol | 00:17 |
devananda | JayF: fair point. also - possibly worth a longer discussion | 00:17 |
devananda | since we (ironic) now has 6 projects | 00:17 |
JayF | Well I always viewed it as a coupling thing | 00:17 |
JayF | When IPA was only used by a non-default driver, it seemed less coupled to Ironic to me | 00:18 |
devananda | ironic, python-ironicclient, ironic-python-agent, ironic-discoverd, lib-ironic | 00:18 |
JayF | now that IPA ramdisk will be utilized by all drivers, it seems like it's the same thing, just in a different repo for technical reasons | 00:18 |
JayF | if that makes senser | 00:18 |
JayF | yeah, libironic makes that case for me | 00:18 |
*** Marga_ has quit IRC | 00:23 | |
*** Marga_ has joined #openstack-ironic | 00:24 | |
devananda | yup | 00:27 |
devananda | but - for practical reasons, not everyone necessarily will be an expert on all of it | 00:28 |
devananda | I'm fine with having a single core team wherein we all trust each other to review/approve things in the areas where we actually know stuff | 00:29 |
devananda | but we might want to get more clear if the expectation is: only approve stuff you really actually know | 00:29 |
devananda | particularly around drivers, this might get weird. core team regularly trusts driver authors, since we hav eno way to verify it | 00:29 |
devananda | so it's a bit of a double standard, and i'd love suggestions on how to resolve it | 00:30 |
*** achanda has quit IRC | 00:30 | |
mrda | devananda: you can always go down the nova path where they have novaclient cores and nova cores (I know we have that for specs). I don't think there's any harm in codifying areas if we see the need to be explicit. | 00:34 |
devananda | mrda: that's what we have today for ironic-python-agent as well, which is where JayF started the discussion from | 00:34 |
mrda | ya, I guess I'm saying I think it's not a bad compromise - especially as the project increases in scope | 00:35 |
mrda | s/scope/sub-projects/ | 00:36 |
devananda | we're definitely increasing in the # of sub-projects we have commitments to | 00:36 |
devananda | I think the question before us is: formal structures and separation of the review teams [vs] common team with informal delegation of responsibility | 00:37 |
devananda | technically, we can do either one | 00:38 |
devananda | and there are pros and cons to each | 00:38 |
mrda | I guess whatever makes your job in managing the focus of the entire project easier :) | 00:39 |
*** ijw_ has joined #openstack-ironic | 00:42 | |
*** ChuckC has quit IRC | 00:42 | |
devananda | mrda: common communication and meeting spaces (irc, ml, rl, etc...) and common planning of features is the biggest thing right now. | 00:43 |
*** ijw has quit IRC | 00:45 | |
mrda | yeah, I think mailing list/etherpads are probably the best way going forward, but having them indexed off our whiteboard is the important thing so they can be found :) | 00:45 |
*** ChuckC has joined #openstack-ironic | 00:49 | |
*** r-daneel has quit IRC | 00:49 | |
*** ChuckC has quit IRC | 00:53 | |
*** ChuckC has joined #openstack-ironic | 00:53 | |
*** stendulker has joined #openstack-ironic | 00:55 | |
devananda | arg | 00:56 |
devananda | lintan's patch adding microversion support is, i think, actually broken | 00:56 |
devananda | ⟫ ironic --ironic-api-version 1.1 node-list | 00:56 |
devananda | No module named 1.shell | 00:56 |
devananda | ⟫ ironic --ironic-api-version 1.4 node-list | 00:56 |
devananda | No module named 4.shell | 00:56 |
mrda | rats | 00:57 |
devananda | rloo: why we need to test with version != None, too. ^ | 00:57 |
rloo | huh? | 00:58 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Enable agent_ilo for uefi-bios switching https://review.openstack.org/162043 | 00:59 |
rloo | devananda: didn't we test that? although our unit tests there are ... sub optimal | 00:59 |
devananda | rloo: there's no functional test of it | 00:59 |
*** yuanying_ has quit IRC | 00:59 | |
devananda | yes, it passes unit tests, but something's not right. I ran out of steam testing an issue I found on friday | 00:59 |
*** penick has quit IRC | 01:00 | |
devananda | thougt it was something odd in my environment -- turns out, it was. I had the IRONIC_API_VERSION env var set but forgot about it | 01:00 |
devananda | tried again just now iwthout it and saw ^^ | 01:00 |
devananda | the same command works fine if I don't pass any ironic api version | 01:00 |
mrda | you had an etherpad, didn't you devananda? /me looks | 01:00 |
mrda | (of scenarios you were concerned about) | 01:00 |
devananda | mrda: sort of yes | 01:00 |
*** yuanying has joined #openstack-ironic | 01:01 | |
devananda | well, more about how we should be testing in the gate | 01:01 |
devananda | rather than user-stories i'm concerned about | 01:01 |
devananda | mrda: https://etherpad.openstack.org/p/oHVxTVRFix | 01:01 |
mrda | ta | 01:01 |
devananda | wait ... | 01:02 |
* devananda kicks his env again | 01:02 | |
rloo | devananda: i have to take off, but i just tried with client, no ENV var, and with latest ironic server, it works for me. | 01:04 |
devananda | something just changed when I reinstalled | 01:04 |
devananda | rloo: yea. it's working for me now too. :-/ | 01:04 |
devananda | sorry for the false alarm -- seems it IS something odd with my env | 01:04 |
rloo | devananda: phew! | 01:04 |
*** rloo has quit IRC | 01:05 | |
devananda | now I wonder what code was installed... | 01:06 |
*** jxiaobin has quit IRC | 01:08 | |
devananda | OH | 01:08 |
devananda | we just broke backwards compat with the CLI | 01:08 |
devananda | the --ironic-api-version option previously only took a single integer | 01:09 |
devananda | trying to use "--ironic-api-version X.Y" on any prior release of our client breaks it | 01:09 |
devananda | well, i mean, that's a bug in the prior releases IMO | 01:09 |
devananda | it's the least helpful failure | 01:10 |
*** stendulker has quit IRC | 01:10 | |
devananda | phew :) | 01:10 |
devananda | now at least I know what was breaking | 01:10 |
mrda | hmmm | 01:11 |
devananda | I'm tempted to file a bug describing the old brokenness just to close it saying we already fixed it | 01:12 |
openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_log lib https://review.openstack.org/157602 | 01:35 |
openstackgerrit | Ghe Rivero proposed openstack/ironic: Sync from oslo.incubator https://review.openstack.org/162505 | 01:35 |
openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_policy package https://review.openstack.org/162501 | 01:35 |
openstackgerrit | Ghe Rivero proposed openstack/ironic: Use strutils from oslo_utils https://review.openstack.org/162497 | 01:35 |
openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_context package https://review.openstack.org/162499 | 01:35 |
*** ijw_ has quit IRC | 01:42 | |
*** rwsu has quit IRC | 01:47 | |
*** absubram has quit IRC | 01:48 | |
*** stendulker has joined #openstack-ironic | 01:49 | |
openstackgerrit | Devananda van der Veen proposed openstack/python-ironicclient: Add support for logical names https://review.openstack.org/158520 | 02:01 |
openstackgerrit | Devananda van der Veen proposed openstack/python-ironicclient: Hide resources missing from server responses - POC - DO NOT MERGE https://review.openstack.org/162834 | 02:01 |
*** stendulker_ has joined #openstack-ironic | 02:01 | |
*** stendulker has quit IRC | 02:03 | |
openstackgerrit | Tan Lin proposed openstack/ironic-specs: Bare Metal Trust Using Intel TXT https://review.openstack.org/162835 | 02:04 |
jamielennox | devananda: you said earlier that there is an ironic user that calls nova and other services on user behalf, where is that defined/configured? | 02:05 |
openstackgerrit | Tan Lin proposed openstack/ironic-specs: Bare Metal Trust Using Intel TXT https://review.openstack.org/133902 | 02:05 |
devananda | jamielennox: s/on user behalf// | 02:05 |
jamielennox | ok | 02:05 |
*** yog_ has joined #openstack-ironic | 02:07 | |
jamielennox | devananda: oh - it looks like they're doing keystone.get_admin_auth_token() | 02:07 |
devananda | so I see a parameter for swift_account | 02:07 |
jamielennox | i was thinking it'd be defined as like a service user somewhere | 02:08 |
jamielennox | because the common/keystone uses the [keystone_authtoken] user | 02:08 |
devananda | jamielennox: interesting. so, our docs at http://docs.openstack.org/developer/ironic/deploy/install-guide.html#configure-the-bare-metal-service | 02:11 |
devananda | say to put things like admin_user and auth_url in [keystone_authtoken] section of the conf file | 02:11 |
devananda | however I dont see those options in our sample file, which is autogenerated | 02:11 |
devananda | which leads me to ask: why not? | 02:12 |
jamielennox | devananda: well those admin_user and auth_url config options are defined by auth_token middleware | 02:13 |
jamielennox | at a guess there was a thing a while ago about how you had to put like a list_opts() or something in so that oslo.config knew all the modules it was supposed to load options for | 02:14 |
jamielennox | i can't remember the details on that | 02:14 |
devananda | so yea, that's completely lame IMO, and we have not switched ironic to doing that | 02:14 |
devananda | because that list is about 50 modules long or something insane and unmaintainable | 02:15 |
devananda | also, we're including that module when auto-generating | 02:17 |
jamielennox | so we have modified the structure of the auth_token module and there have been option changes but nothing that would not have them be imported | 02:18 |
jamielennox | i don't think... | 02:19 |
devananda | well, they're working when setting them | 02:21 |
devananda | but I can't find where they're defined in keystone right now | 02:21 |
jamielennox | https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/_auth.py#L133 | 02:22 |
devananda | hm. options.extend | 02:23 |
devananda | i'm unfamiliar with this | 02:23 |
jamielennox | it's an auth plugin thing | 02:23 |
jamielennox | devananda: ah ok, they're not being registered at import, but they're in https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/opts.py#L28 | 02:24 |
jamielennox | which is the olso.config options thing | 02:25 |
devananda | this seems needlessly convoluted | 02:25 |
* devananda files a bug and goes back to other things | 02:26 | |
devananda | https://bugs.launchpad.net/ironic/+bug/1430115 | 02:32 |
openstack | Launchpad bug 1430115 in Ironic "keystone_authtoken options not present in sample config file" [Low,Triaged] | 02:32 |
openstackgerrit | Devananda van der Veen proposed openstack/python-ironicclient: Add support for logical names https://review.openstack.org/158520 | 02:32 |
*** coolsvap has joined #openstack-ironic | 02:33 | |
*** chenglch has joined #openstack-ironic | 02:35 | |
*** anderbubble has joined #openstack-ironic | 02:37 | |
*** penick has joined #openstack-ironic | 02:38 | |
*** stendulker has joined #openstack-ironic | 02:38 | |
* devananda goes afk for the evening now | 02:39 | |
*** stendulker_ has quit IRC | 02:40 | |
*** penick_ has joined #openstack-ironic | 02:40 | |
*** stendulker has quit IRC | 02:42 | |
*** penick has quit IRC | 02:42 | |
*** penick_ is now known as penick | 02:42 | |
*** spandhe has quit IRC | 02:44 | |
*** spandhe has joined #openstack-ironic | 02:44 | |
*** coolsvap has quit IRC | 02:45 | |
*** coolsvap has joined #openstack-ironic | 02:46 | |
*** coolsvap has quit IRC | 02:46 | |
*** coolsvap has joined #openstack-ironic | 02:46 | |
*** yuanying has quit IRC | 02:46 | |
*** achanda has joined #openstack-ironic | 02:47 | |
*** spandhe has left #openstack-ironic | 02:47 | |
*** ramineni has joined #openstack-ironic | 02:48 | |
*** yuanying has joined #openstack-ironic | 03:01 | |
*** yuanying has quit IRC | 03:02 | |
*** yuanying has joined #openstack-ironic | 03:06 | |
*** jxiaobin_ has quit IRC | 03:11 | |
*** yuanying has quit IRC | 03:38 | |
*** stendulker has joined #openstack-ironic | 03:39 | |
*** achanda has quit IRC | 03:40 | |
*** yuanying has joined #openstack-ironic | 03:41 | |
*** Nisha has joined #openstack-ironic | 03:50 | |
*** yog_ has quit IRC | 04:06 | |
*** achanda has joined #openstack-ironic | 04:06 | |
*** absubram has joined #openstack-ironic | 04:10 | |
*** anderbubble has quit IRC | 04:11 | |
*** absubram has quit IRC | 04:14 | |
*** Haomeng has joined #openstack-ironic | 04:14 | |
*** absubram has joined #openstack-ironic | 04:15 | |
*** Haomeng|2 has quit IRC | 04:17 | |
*** yog_ has joined #openstack-ironic | 04:18 | |
*** yog_ has quit IRC | 04:20 | |
*** naohirot has joined #openstack-ironic | 04:20 | |
*** pradipta has joined #openstack-ironic | 04:26 | |
*** alexpilotti has joined #openstack-ironic | 04:48 | |
*** pradipta has quit IRC | 04:49 | |
*** BadCub has quit IRC | 04:52 | |
*** Nisha has quit IRC | 04:53 | |
*** Nisha has joined #openstack-ironic | 05:02 | |
*** pradipta has joined #openstack-ironic | 05:06 | |
openstackgerrit | Anusha Ramineni proposed stackforge/proliantutils: IPA_HW_MANAGER: Add support to get_clean_steps https://review.openstack.org/162870 | 05:42 |
*** achanda has quit IRC | 05:54 | |
*** achanda has joined #openstack-ironic | 05:55 | |
*** harlowja_ is now known as harlowja_away | 05:57 | |
*** achanda has quit IRC | 06:11 | |
*** achanda has joined #openstack-ironic | 06:11 | |
openstackgerrit | Anusha Ramineni proposed stackforge/proliantutils: IPA_HW_MANAGER: Add support to get_clean_steps https://review.openstack.org/162870 | 06:15 |
*** Haomeng has quit IRC | 06:18 | |
*** Haomeng has joined #openstack-ironic | 06:19 | |
*** ukalifon has joined #openstack-ironic | 06:22 | |
*** yog__ has joined #openstack-ironic | 06:27 | |
*** achanda has quit IRC | 06:28 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Enable uefi boot mode for agent_ilo driver https://review.openstack.org/162043 | 06:29 |
*** david-lyle has quit IRC | 06:30 | |
*** david-lyle has joined #openstack-ironic | 06:39 | |
*** dlpartain has joined #openstack-ironic | 06:45 | |
*** coolsvap is now known as coolsvap|afk | 06:47 | |
*** coolsvap|afk is now known as coolsvap | 06:58 | |
*** david-lyle is now known as david-lyle_afk | 07:11 | |
openstackgerrit | Michael Davies proposed openstack/ironic-specs: API Microversions https://review.openstack.org/161110 | 07:20 |
*** chlong has quit IRC | 07:21 | |
*** jcoufal has joined #openstack-ironic | 07:25 | |
*** killer_prince is now known as lazy_prince | 07:27 | |
*** jistr has joined #openstack-ironic | 07:31 | |
*** openstackgerrit has quit IRC | 07:35 | |
*** openstackgerrit has joined #openstack-ironic | 07:36 | |
*** gridinv has joined #openstack-ironic | 07:36 | |
*** gridinv has quit IRC | 07:41 | |
*** sandhya has joined #openstack-ironic | 07:48 | |
*** coolsvap is now known as coolsvap|afk | 07:53 | |
*** andreykurilin_ has joined #openstack-ironic | 07:57 | |
*** coolsvap|afk is now known as coolsvap | 08:00 | |
*** ukalifon has quit IRC | 08:13 | |
*** erwan_taf has joined #openstack-ironic | 08:15 | |
GheRivero | morning all | 08:22 |
*** gridinv has joined #openstack-ironic | 08:23 | |
*** dlpartain has left #openstack-ironic | 08:23 | |
*** gridinv_ has joined #openstack-ironic | 08:28 | |
*** gridinv has quit IRC | 08:28 | |
*** ukalifon1 has joined #openstack-ironic | 08:29 | |
*** andreykurilin_ has quit IRC | 08:29 | |
*** gridinv_ has quit IRC | 08:33 | |
*** ifarkas has joined #openstack-ironic | 08:41 | |
Nisha | GheRivero, morning | 08:43 |
*** alexpilotti_ has joined #openstack-ironic | 08:52 | |
*** jerryz has quit IRC | 08:52 | |
*** alexpilotti has quit IRC | 08:54 | |
*** alexpilotti_ is now known as alexpilotti | 08:54 | |
*** takadayuiko has joined #openstack-ironic | 08:55 | |
*** pradipta has quit IRC | 09:06 | |
openstackgerrit | Tan Lin proposed openstack/ironic: Generate keystone_authtoken options in sample config file https://review.openstack.org/162919 | 09:12 |
*** lucasagomes has joined #openstack-ironic | 09:18 | |
*** tiagogomes_ has joined #openstack-ironic | 09:20 | |
*** romcheg has joined #openstack-ironic | 09:21 | |
*** david-lyle_afk has quit IRC | 09:30 | |
*** david-lyle_afk has joined #openstack-ironic | 09:30 | |
naohirot | Hi vdrok | 09:32 |
*** jistr has quit IRC | 09:34 | |
vdrok | morning ironic | 09:38 |
vdrok | naohirot, hi | 09:38 |
naohirot | Hi good morning | 09:38 |
naohirot | vdrok: First of all, thanks for reviewing my code. | 09:38 |
*** stendulker has quit IRC | 09:39 | |
*** yuanying has quit IRC | 09:39 | |
naohirot | vdrok: I have a question about your comment regarding "use , instead of %, also brackets around string are not necessary" | 09:39 |
vdrok | naohirot, is it a patch about virtual media driver? | 09:40 |
naohirot | vdrok: Yes, the code you made the comment is here "to %(server)s:%(share)s for deployment.") %" | 09:40 |
naohirot | vdrok: what do you mean use ','? | 09:41 |
vdrok | naohirot, yes, it should be like LOG.debug("%s", msg) | 09:41 |
vdrok | naohirot, not LOG.debug("%s" % msg) | 09:41 |
vdrok | naohirot, it's a common guideline for log messages | 09:42 |
naohirot | vdrok: I see | 09:42 |
*** sandhya has quit IRC | 09:44 | |
naohirot | vdrok: but using bracket like %s(server) is more not error prone? | 09:44 |
naohirot | vdrok: because just "%s" is positional, but %s(server) is not positional. | 09:45 |
vdrok | naohirot, yes, it's better, that was just an example :) | 09:45 |
vdrok | naohirot, in comment about brackets, i meant that you have ("str" | 09:45 |
vdrok | naohirot, and then on next line "str") | 09:46 |
vdrok | these brackets are not necessary, you can omit them | 09:46 |
*** jistr has joined #openstack-ironic | 09:46 | |
naohirot | vdrok: sorry, i still didn't get your point. :) | 09:47 |
naohirot | vdrok: bracket you meant is '()'? | 09:48 |
vdrok | naohirot, i'll upload a paste :) wait a sec | 09:49 |
naohirot | vdrok: yes, please. it's much better way :) | 09:50 |
vdrok | naohirot, http://paste.openstack.org/show/191230/ | 09:50 |
naohirot | vdrok: Oh, I got it. I'm think to replace different %. | 09:52 |
naohirot | vdrok: Okay, I'll fix that. thanks! | 09:52 |
vdrok | naohirot, np :) | 09:52 |
naohirot | vdrok: there are many % in this context :) | 09:53 |
*** pelix has joined #openstack-ironic | 09:56 | |
*** bigjools has quit IRC | 10:04 | |
*** bigjools has joined #openstack-ironic | 10:05 | |
*** chlong has joined #openstack-ironic | 10:18 | |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: iLO implementation for hardware inspection https://review.openstack.org/151596 | 10:33 |
*** coolsvap is now known as coolsvap|afk | 10:33 | |
openstackgerrit | Nisha Agarwal proposed openstack/python-ironicclient: Add support for inspection to node-set-provision-state https://review.openstack.org/148804 | 10:36 |
*** Nisha has quit IRC | 10:41 | |
*** Haomeng|2 has joined #openstack-ironic | 10:43 | |
*** Haomeng has quit IRC | 10:46 | |
*** MattMan has quit IRC | 10:46 | |
*** ramineni has quit IRC | 10:46 | |
*** pradipta has joined #openstack-ironic | 10:48 | |
*** chlong has quit IRC | 10:51 | |
*** mgoddard has quit IRC | 10:53 | |
openstackgerrit | Sirushti Murugesan proposed openstack/ironic: Adds support for deploying whole disk images https://review.openstack.org/150142 | 10:54 |
*** mgoddard has joined #openstack-ironic | 10:55 | |
*** chenglch has quit IRC | 11:07 | |
*** Krast has quit IRC | 11:09 | |
*** alexpilotti has quit IRC | 11:10 | |
*** athomas has quit IRC | 11:22 | |
*** athomas has joined #openstack-ironic | 11:28 | |
*** pradipta has quit IRC | 11:29 | |
*** absubram has quit IRC | 11:34 | |
*** takadayuiko has quit IRC | 11:39 | |
*** Haomeng has joined #openstack-ironic | 11:42 | |
*** Haomeng|2 has quit IRC | 11:43 | |
*** romcheg has quit IRC | 11:52 | |
*** coolsvap|afk is now known as coolsvap | 11:54 | |
*** romcheg has joined #openstack-ironic | 11:56 | |
*** romcheg has quit IRC | 11:57 | |
*** igordcard_afk has joined #openstack-ironic | 12:11 | |
*** igordcard_afk has quit IRC | 12:11 | |
*** dprince has joined #openstack-ironic | 12:13 | |
*** igordcard has joined #openstack-ironic | 12:13 | |
*** igordcard has quit IRC | 12:15 | |
*** sambetts has quit IRC | 12:16 | |
*** igordcard has joined #openstack-ironic | 12:17 | |
*** gridinv_ has joined #openstack-ironic | 12:19 | |
*** lucasagomes is now known as lucas-hungry | 12:19 | |
*** sambetts has joined #openstack-ironic | 12:21 | |
*** gridinv_ has quit IRC | 12:23 | |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add iRMC Virtual Media Deploy module for iRMC Driver https://review.openstack.org/151958 | 12:33 |
*** jistr has quit IRC | 12:47 | |
*** jistr has joined #openstack-ironic | 12:48 | |
*** kozhukalov has joined #openstack-ironic | 12:55 | |
*** rloo has joined #openstack-ironic | 12:55 | |
*** jistr has quit IRC | 13:04 | |
*** jistr has joined #openstack-ironic | 13:05 | |
*** coolsvap is now known as coolsvap|afk | 13:06 | |
*** romcheg has joined #openstack-ironic | 13:12 | |
*** kkoski has joined #openstack-ironic | 13:19 | |
*** lucas-hungry is now known as lucasagomes | 13:21 | |
*** romcheg has quit IRC | 13:24 | |
*** romcheg has joined #openstack-ironic | 13:25 | |
openstackgerrit | Zhenguo Niu proposed openstack/ironic: Fix typo agaist->against https://review.openstack.org/162995 | 13:26 |
*** Nisha has joined #openstack-ironic | 13:29 | |
*** naohirot has quit IRC | 13:33 | |
victor_lowther | Good morning, Ironic | 13:47 |
TheJulia | win 9 | 13:48 |
TheJulia | doh | 13:49 |
openstackgerrit | Sirushti Murugesan proposed openstack/ironic: Adds support for deploying whole disk images https://review.openstack.org/150142 | 13:49 |
TheJulia | good morning | 13:50 |
*** jjohnson2 has joined #openstack-ironic | 13:51 | |
*** mtanino has joined #openstack-ironic | 13:54 | |
openstackgerrit | Ruby Loo proposed openstack/ironic: Update API doc to reflect node uuid or name https://review.openstack.org/163009 | 13:55 |
rloo | Morning victor_lowther, TheJulia, and everyone else lurking around ;) | 13:55 |
openstackgerrit | Sirushti Murugesan proposed openstack/ironic: Adds support for deploying whole disk images https://review.openstack.org/150142 | 13:57 |
*** r-daneel has joined #openstack-ironic | 13:58 | |
*** MattMan has joined #openstack-ironic | 13:58 | |
*** absubram has joined #openstack-ironic | 14:10 | |
jroll | morning all :) | 14:11 |
*** ChuckC has quit IRC | 14:23 | |
*** anderbubble has joined #openstack-ironic | 14:23 | |
*** ukalifon1 has quit IRC | 14:26 | |
NobodyCam | goood morning Ironic says the man in the new house | 14:26 |
*** Nisha has quit IRC | 14:29 | |
jroll | morning NobodyCam and congrats! | 14:31 |
NobodyCam | :) thank you :) | 14:31 |
NobodyCam | now if we could just gets some better internets we'd be set | 14:31 |
jroll | heh | 14:32 |
*** achanda has joined #openstack-ironic | 14:34 | |
*** zz_jgrimm is now known as jgrimm | 14:35 | |
*** absubram has quit IRC | 14:39 | |
*** BadCub has joined #openstack-ironic | 14:39 | |
BadCub | Morning Ironic | 14:39 |
NobodyCam | mornign BadCub | 14:40 |
pshige | morning BadCub | 14:42 |
*** achanda has quit IRC | 14:43 | |
*** rwsu has joined #openstack-ironic | 14:44 | |
BadCub | morning NobodyCam and pshige | 14:45 |
NobodyCam | morning pshige :) | 14:47 |
lucasagomes | morning jroll BadCub NobodyCam rloo victor_lowther TheJulia pshige etc | 14:47 |
NobodyCam | morning lucasagomes | 14:47 |
jroll | lol | 14:47 |
lucasagomes | jroll, :( lsblk on ubuntu 14 is pretty old man | 14:47 |
NobodyCam | :) | 14:47 |
jroll | morning to all the people that lucas pinged plus lucasagomes :) | 14:48 |
rloo | morning jroll, NobodyCam, BadCub, pshige, lucasagomes ;) | 14:48 |
lucasagomes | that's how I was thinking about to get the information I need for the root device hints | 14:48 |
NobodyCam | morning rloo :) | 14:48 |
BadCub | Morning lucasagomes and rloo | 14:48 |
jroll | lucasagomes: is it too old or? | 14:49 |
lucasagomes | jroll, yeah it's pretty out-of-date | 14:49 |
lucasagomes | you can't get things like | 14:49 |
lucasagomes | WWN, VENDOR, SERIAL | 14:49 |
jroll | mmm. | 14:49 |
jroll | that's fun. | 14:49 |
lucasagomes | yeah | 14:49 |
lucasagomes | I probably will use pyudisks for it then | 14:50 |
lucasagomes | other openstack projects seems to use it (it's on global-requirements) | 14:50 |
lucasagomes | pyudev sorry* | 14:50 |
jroll | right on | 14:51 |
jroll | whatever you've gotta do | 14:51 |
lucasagomes | (: working on i | 14:51 |
lucasagomes | it* | 14:51 |
NobodyCam | :) | 14:52 |
BadCub | morning TheJulia | 14:56 |
TheJulia | BadCub: good morning | 14:59 |
BadCub | brb | 15:01 |
*** achanda has joined #openstack-ironic | 15:03 | |
*** ChuckC has joined #openstack-ironic | 15:04 | |
*** achanda has quit IRC | 15:05 | |
* BadCub must go mov ethe rv from driveway so fridge and washer/dryer can be delivered | 15:10 | |
jroll | question for people deploying ironic (TheJulia maybe?): say your machines have "32 GB" root disks. this really means 29.802322388 GB. what would you put in your flavor? | 15:19 |
NobodyCam | jroll: I'd prob put 29 gb | 15:20 |
jroll | ok, thanks | 15:21 |
jroll | I'm looking at this change and trying to decide if the approximation would be fine for other deployments, or if it's rackspace-specific https://review.openstack.org/#/c/159491/5/cloudroast/compute/instance_actions/api/test_create_server.py | 15:22 |
*** jcoufal has quit IRC | 15:22 | |
Shrews | GheRivero: Do you need to update the commit msg for https://review.openstack.org/157602? It seems with the recent patch sets you ARE removing the incubator code | 15:22 |
*** david-lyle_afk is now known as david-lyle | 15:23 | |
*** rsFF has joined #openstack-ironic | 15:25 | |
*** purp_away is now known as purp | 15:27 | |
*** ChuckC has quit IRC | 15:30 | |
*** purp is now known as purp_away | 15:31 | |
*** yog__ has quit IRC | 15:31 | |
GheRivero | Shrews: true! Thanks | 15:33 |
*** stendulker has joined #openstack-ironic | 15:35 | |
*** dlpartain has joined #openstack-ironic | 15:36 | |
openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 15:39 |
devananda | g'morning, all | 15:39 |
jroll | morning devananda :) | 15:40 |
BadCub | morning devananda | 15:41 |
rloo | sirushti: wrt 150142, did my latest comment make sense? I'm worried you're going to go back and forth on this. | 15:42 |
*** vdrok is now known as vdrok_afk | 15:42 | |
rloo | morning devananda | 15:42 |
lucasagomes | devananda, morning | 15:43 |
*** absubram has joined #openstack-ironic | 15:43 | |
sirushti | rloo, Hi, I'm not sure if we can handle all exceptions in images.is_whole_disk_image without letting them percolate up. | 15:44 |
rloo | sirushti: why not? just put a try/ around the code | 15:44 |
lucasagomes | Haomeng, complete out-of-topic, but a friend of mine told me that in china you guys have yellow watermelons. I googled it and turns out it's real! How is that even possible?!? | 15:44 |
rloo | lucasagomes: I've seen/eaten yellow watermelon. Not sure where Canada imported them from or if it was grown in Canada ;) | 15:45 |
sirushti | rloo, so what do we do when the glance service is down? | 15:45 |
jroll | lol | 15:45 |
rloo | sirushti: return None | 15:45 |
lucasagomes | rloo, omg my mind how blew | 15:46 |
rloo | sirushti: what does that method care? it should be caught elsewhere anyway? | 15:46 |
lucasagomes | rloo, I can't even draw a watermelon anymore... I've never seem a yellow one in my whole life | 15:46 |
rloo | lucasagomes: focus on ironic, forget about the colour of food ;) | 15:46 |
lucasagomes | ack | 15:46 |
sirushti | rloo, that was only in the case if image_source wasn't set that the deploy drivers catch it during validate | 15:46 |
rloo | lucasagomes: have you seen square (cube or whatever) watermelon? maybe when you go to Japan... | 15:47 |
lucasagomes | rloo, yeah I've seem that. But they use something to make it that shape right? it's not natural | 15:47 |
rloo | sirushti: I suspect our code isn't robust against exceptions from Glance anyway. I'm trying to make it easier so your patch can get approved but it is up to you. | 15:48 |
sirushti | rloo, so say image_source exists and then we return None because glance just couldn't be reached, we'd then get a KeyError saying is_whole_disk_image can't be accessed | 15:48 |
rloo | sirushti: I'm not sure where that might happen but I'm only suggesting. Do what you think is right. | 15:49 |
*** dlpartain has left #openstack-ironic | 15:49 | |
*** pas-ha has joined #openstack-ironic | 15:53 | |
*** romcheg has quit IRC | 15:54 | |
*** penick has quit IRC | 15:54 | |
*** lazy_prince is now known as killer_prince | 15:56 | |
NobodyCam | morning devananda | 15:57 |
*** jcoufal has joined #openstack-ironic | 16:04 | |
jroll | clif_h: trying to figure out that exception from your super().validate() call and I have no idea :/ | 16:11 |
jroll | if anyone else could tell me what I'm missing... https://review.openstack.org/#/c/161832/3/ironic/drivers/modules/agent.py line 357 | 16:12 |
jroll | throws 2015-03-09 19:29:59.044 5441 ERROR oslo_messaging._drivers.common [-] Returning exception validate() takes exactly 3 arguments (6 given) to caller | 16:12 |
jroll | rather TypeError: validate() takes exactly 3 arguments (6 given) | 16:13 |
jroll | here's the superclass method: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent_base_vendor.py#L104 | 16:13 |
jroll | I don't get it | 16:13 |
clif_h | is this failing in tests? | 16:14 |
JoshNang | jroll: i stared at that for a good 5 mins | 16:14 |
JoshNang | yeah, in tempest | 16:15 |
*** jmccrory has joined #openstack-ironic | 16:15 | |
openstackgerrit | Merged openstack/python-ironicclient: Adds basic ironicclient functional testing https://review.openstack.org/161976 | 16:18 |
openstackgerrit | Merged openstack/ironic: Fix typo agaist->against https://review.openstack.org/162995 | 16:18 |
clif_h | ok I see it | 16:18 |
openstackgerrit | Imre Farkas proposed openstack/ironic: DRAC BIOS vendor_passthru: enable rebooting the node https://review.openstack.org/163071 | 16:18 |
openstackgerrit | Merged openstack/ironic: Use strutils from oslo_utils https://review.openstack.org/162497 | 16:18 |
jroll | clif_h: do you see the bug? | 16:19 |
jroll | because I would love for someone to explain it to me. | 16:19 |
clif_h | I see the error, I'm not sure what's causing it yet | 16:20 |
jroll | yeah | 16:21 |
jroll | it has to be method resolution order screwing us somehow, but unclear how | 16:21 |
openstackgerrit | Sirushti Murugesan proposed openstack/ironic: Adds support for deploying whole disk images https://review.openstack.org/150142 | 16:22 |
* clif_h tries to write a test for it | 16:25 | |
rloo | jroll: wrt that validate(), I'm not sure you should be passing in 'self' | 16:33 |
clif_h | aha | 16:33 |
clif_h | you're right | 16:33 |
lucasagomes | jroll, idk if you have seem this http://paste.openstack.org/show/191340/ | 16:34 |
clif_h | rloo: thanks | 16:34 |
lucasagomes | jroll, when I raise an exception (DeviceNotFound) on IPA | 16:34 |
lucasagomes | it seems it's not serializing it correctly | 16:34 |
rloo | clif_h: yw. i'm going to -1 it cuz of that ;) | 16:34 |
clif_h | understandable | 16:35 |
rloo | clif_h: although maybe that was a mistake cuz i might feel like i should review it all. but i'll try not to ;) | 16:35 |
clif_h | haha | 16:35 |
clif_h | I welcome any and all eyes | 16:36 |
jroll | rloo: oh, nice catch ha | 16:37 |
jroll | lucasagomes: does DeviceNotFound inherit from RestError? | 16:38 |
lucasagomes | jroll, yea, well it inherits from NotFound that inherit from RestError | 16:38 |
* lucasagomes rechecks | 16:38 | |
jroll | huh | 16:38 |
TheJulia | 9 | 16:42 |
TheJulia | doh | 16:42 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Move _get_agent_params() to a common place https://review.openstack.org/163078 | 16:42 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Add support for root device hints https://review.openstack.org/163079 | 16:42 |
jroll | lucasagomes: from ironic_python_agent.cmd import agent # noqa | 16:44 |
jroll | is that just to import config options? | 16:44 |
lucasagomes | jroll, I haven't looked much into it | 16:44 |
lucasagomes | I bet it's some log setup or config | 16:44 |
*** harlowja_away is now known as harlowja_ | 16:44 | |
lucasagomes | I just added that FIXME to not forget | 16:44 |
lucasagomes | it was just working before because we were importing agent.py on the other test file | 16:44 |
jroll | yeah, I'd bet it's configs, I'd try import_conf() or whatever | 16:45 |
lucasagomes | jroll, yeah | 16:45 |
lucasagomes | I will look into it, but since the problem wasn't related with the change | 16:45 |
lucasagomes | I just added a fixme for now | 16:45 |
jroll | ok cool | 16:46 |
*** andreykurilin_ has joined #openstack-ironic | 16:50 | |
NobodyCam | bandwidth soooo slow :( | 16:55 |
lucasagomes | Shrews, rloo about hiding the configdrive content | 16:56 |
lucasagomes | I will put another patch then removing the True | 16:56 |
Shrews | lucasagomes: okie dokie | 16:56 |
lucasagomes | rloo, Shrews but what you guys prefer | 16:56 |
lucasagomes | *** or <contents-not-shown> | 16:56 |
Shrews | lucasagomes: we use *'s for passwords already, don't we? | 16:57 |
lucasagomes | yesI'm ok with either, perhapas <contents-not-shown> is not explicit so | 16:57 |
lucasagomes | Shrews, yes ok | 16:57 |
Shrews | lucasagomes: just seems more consistent that way, but either seems fine really | 16:58 |
lucasagomes | s/is not explicit/is more explicit/ | 16:58 |
lucasagomes | Shrews, ack, will put *** then | 16:58 |
devananda | *** is better IMO | 16:58 |
lucasagomes | ack thanks, will put a new rev in a min | 16:58 |
*** jistr has quit IRC | 17:01 | |
rloo | lucasagomes: ***** ++ | 17:02 |
jroll | come to think about it, hiding that is a good idea, it's user data | 17:02 |
jroll | potentially they could be putting secrets in there | 17:02 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Make sure we don't log the full content of the config drive https://review.openstack.org/162252 | 17:02 |
lucasagomes | done :) | 17:02 |
*** sbadia has quit IRC | 17:04 | |
*** sbadia has joined #openstack-ironic | 17:05 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Enable agent_ilo for uefi-bios switching https://review.openstack.org/162043 | 17:08 |
NobodyCam | rloo: not waiting for test | 17:08 |
NobodyCam | :-p | 17:08 |
rloo | NobodyCam: here's my thinking. If I approve and Jenkins also likes it, then all is good. | 17:09 |
NobodyCam | sounds good tome | 17:09 |
rloo | NobodyCam: If I approve and Jenkins doesn't like it. So what? It doesn't get merged. | 17:09 |
NobodyCam | to me | 17:09 |
rloo | NobodyCam: and I don't have to sit and wait for Jenkins ;) | 17:09 |
Shrews | lol. this is why we have robotic overlords :) | 17:10 |
rloo | NobodyCam: ha ha. I see your comment now ;) | 17:10 |
NobodyCam | :-p | 17:11 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 17:12 |
*** erwan_taf has quit IRC | 17:13 | |
*** krtaylor has quit IRC | 17:14 | |
*** spandhe has joined #openstack-ironic | 17:15 | |
*** achanda has joined #openstack-ironic | 17:19 | |
*** achanda has quit IRC | 17:19 | |
*** achanda has joined #openstack-ironic | 17:19 | |
lucasagomes | jroll, yeah seems there's something wrong with the decoding :/ just tried to raise another exception | 17:20 |
lucasagomes | I will open a bug about it, and look at it soonish | 17:20 |
jroll | lucasagomes: hrm ok | 17:22 |
*** tiagogomes_ has quit IRC | 17:23 | |
jgrimm | hi there. trying to deploy via IPA for first time... running into error during prepare_image | 17:24 |
jgrimm | anyone seen this error before?->ConfigDriveWriteError', u'details': u'Writing configdrive to device /dev/sda failed with exit code 1. s\ | 17:24 |
jgrimm | tdout: copy_configdrive_to_disk.sh: Adding configdrive partition to /dev/sda\ncopy_configdrive_to_disk.sh: Error creating configdrive on /dev/sda\n. stderr: partx: /dev/sda: fail\ | 17:24 |
jgrimm | ed to read partition table\nparted: invalid token: primary\nError: Expecting a file system type. | 17:24 |
jroll | interesting | 17:24 |
jroll | TheJulia: didn't you hit the same thing? | 17:24 |
jgrimm | thanks jroll | 17:25 |
jroll | jgrimm: using the coreos image or? | 17:25 |
jroll | or DIB* | 17:25 |
jgrimm | built coreos and dib.. both behaved same | 17:25 |
jroll | huh | 17:25 |
jroll | I think this was an image issue... where does your image come from? | 17:25 |
jroll | and would you be willing to try with the cirros full disk image? | 17:26 |
jgrimm | i built with DIB first.. then i built with coreos imagebuild | 17:26 |
jroll | I mean the instance image | 17:26 |
jroll | the cirros image is here, and if this works than it's a problem with your instance image: http://download.cirros-cloud.net/0.3.3/cirros-0.3.3-x86_64-disk.img | 17:27 |
jgrimm | oh! sorry its a dib built image that i've successfully deployed vit pxe_ipmitool | 17:27 |
jroll | oh! | 17:27 |
jroll | so IPA uses full disk images | 17:27 |
*** krtaylor has joined #openstack-ironic | 17:27 | |
jroll | whereas the pxe driver uses partition images (kernel/ramdisk are separate) | 17:27 |
* jroll wonders if there's a way to inspect this so we can fail early | 17:28 | |
* jroll files a bug | 17:28 | |
jgrimm | jroll, doesn't ipa now support partition images (as of friday) | 17:28 |
lucasagomes | jroll, maybe glance metadata should indicate it | 17:28 |
jroll | thinking so | 17:28 |
jroll | jgrimm: ehh, kinda. | 17:28 |
jgrimm | heh.. ok, yeah, i was looking to test local boot too | 17:29 |
jroll | jgrimm: so there's another driver that uses the IPA image to deploy over iscsi | 17:29 |
jroll | so, basically the pxe driver but using the IPA ramdisk | 17:29 |
jgrimm | gotcha | 17:29 |
jroll | and I believe it works with local boot as well | 17:29 |
jroll | lucasagomes: ^ correct? | 17:29 |
openstackgerrit | Merged openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/161575 | 17:29 |
lucasagomes | jroll, correct :) | 17:29 |
* lucasagomes really need to work on documenting all this stuff | 17:30 | |
*** tiagogomes_ has joined #openstack-ironic | 17:30 | |
jgrimm | heh.. yeah, in generally there is big time lack of much written about IPA | 17:30 |
jgrimm | just an example of using it (beside lib\ironic) would've been handy. | 17:31 |
jroll | yeah :/ | 17:31 |
jroll | we're bad people | 17:31 |
jgrimm | it'll get there. ;) | 17:31 |
lucasagomes | jgrimm, yeah I hear you. It's all recently so on k-4 I will work on docs for it | 17:31 |
jgrimm | lucasagomes, i'd be happy to help | 17:31 |
jroll | https://bugs.launchpad.net/ironic/+bug/1430454 | 17:31 |
openstack | Launchpad bug 1430454 in Ironic "IPA deploy driver gives incomprehensible error message when using partition images" [Medium,Confirmed] | 17:31 |
lucasagomes | jgrimm, that would be awesome! | 17:31 |
lucasagomes | jgrimm, so yeah, try deplpying ur image with pxe_* drivers and IPA | 17:32 |
jgrimm | jroll, is there a pointer for whole disk image creation? that would make IPA happy | 17:32 |
jroll | lucasagomes: is there any particular config for using pxe/ipa stuff? | 17:32 |
*** spandhe has quit IRC | 17:32 | |
*** coolsvap|afk is now known as coolsvap | 17:32 | |
lucasagomes | jroll, no just drop in the ipa ramdisk | 17:32 |
lucasagomes | don't need any extra config | 17:32 |
jroll | jgrimm: I'm sure there's something, but I don't know where, sorry :/ maybe check DIB docs? I assume there's an element for it | 17:33 |
lucasagomes | you need to have a updated ironic and ipa image ofc | 17:33 |
jroll | lucasagomes: that's amazing, you just detect based on callback? | 17:33 |
jgrimm | jroll, ok, thanks i'll search | 17:33 |
lucasagomes | jroll, pretty much, if it starts getting the heartbeat from IPA | 17:33 |
lucasagomes | it will call continue_deploy from IPA | 17:33 |
jroll | jgrimm: might ask #tripleo too | 17:33 |
jroll | lucasagomes: yeah, cool | 17:33 |
jgrimm | jroll, thanks! | 17:33 |
lucasagomes | s/from IPA/for IPA | 17:34 |
jgrimm | jroll, lucasagomes thanks for the info/hints | 17:35 |
jroll | np :) | 17:35 |
*** achanda has quit IRC | 17:35 | |
lucasagomes | jgrimm, np | 17:36 |
*** achanda has joined #openstack-ironic | 17:37 | |
*** spandhe has joined #openstack-ironic | 17:41 | |
*** spandhe has quit IRC | 17:41 | |
*** spandhe has joined #openstack-ironic | 17:42 | |
stendulker | lucasgomes: Hi | 17:44 |
stendulker | lucasgomes: in pxe driver capability boot_option is checked in the properties/capabilities and in iscsi_deploy its done using instance_info | 17:46 |
stendulker | lucasgomes: though it mean same, wont it better to be uniform? | 17:47 |
*** dprince has quit IRC | 17:48 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 17:50 |
*** ChuckC has joined #openstack-ironic | 17:51 | |
stendulker | devananda: As requested during weekly meeting, can you please update the milestone to 'kilo-3' for ilo defects 1412559 and 1418327. | 17:53 |
stendulker | devananda: thanks | 17:53 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 17:55 |
*** andreykurilin_ has quit IRC | 17:58 | |
*** stendulker has quit IRC | 18:13 | |
*** MattMan has quit IRC | 18:13 | |
*** athomas has quit IRC | 18:14 | |
*** athomas has joined #openstack-ironic | 18:19 | |
*** tiagogomes_ has quit IRC | 18:20 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Add support for root device hints https://review.openstack.org/163079 | 18:24 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Move _get_agent_params() to a common place https://review.openstack.org/163078 | 18:24 |
lucasagomes | and with that, I will call it a day | 18:24 |
lucasagomes | have a good night everyone! | 18:24 |
jroll | night lucasagomes :) | 18:25 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Add support for root device hints https://review.openstack.org/163079 | 18:25 |
lucasagomes | forgot debug code :) | 18:25 |
*** lucasagomes is now known as lucas-dinner | 18:25 | |
lucas-dinner | jrist, night! | 18:26 |
openstackgerrit | John L. Villalovos proposed openstack/ironic: Update unittests for _make_password_file https://review.openstack.org/162672 | 18:29 |
* jlvillal Whew! Feels like it took too long to figure out how to mock the 'write' call from a mocked 'fdopen' call used in a with statement... | 18:31 | |
TheJulia | jgrimm: jroll I hit the same thing, turned out the image I was trying to roll out packed a MBR/Partition table | 18:32 |
*** jcoufal has quit IRC | 18:33 | |
*** rfchapman_ has joined #openstack-ironic | 18:34 | |
*** rfchapman has quit IRC | 18:34 | |
*** romcheg has joined #openstack-ironic | 18:34 | |
*** pelix has quit IRC | 18:42 | |
*** dprince has joined #openstack-ironic | 18:42 | |
*** pas-ha has quit IRC | 19:01 | |
*** Marga_ has quit IRC | 19:03 | |
*** jmccrory has quit IRC | 19:03 | |
jgrimm | TheJulia, ah, tx. btw, how are you building your instance images? how did you workaround this? | 19:03 |
TheJulia | jgrimm: I ended up taking the image and putting a bootloader/partition and partition table on the front of the file. | 19:08 |
TheJulia | jgrimm: but grub was already installed along with kernel and ramdisk inside of the image. | 19:09 |
jgrimm | k.tx | 19:09 |
jgrimm | i'm trying to just boot the cirros image for the moment | 19:10 |
TheJulia | jgrimm: there is also a vm DIB element that essentially does the same | 19:10 |
jgrimm | but eventually want to create my own instance images | 19:10 |
TheJulia | jgrimm: writing cirros out was the big "Oh... doh!" moment for me. | 19:11 |
jgrimm | ok, haven't looked at the vm element (except for noting it puts grub back into the image) | 19:11 |
jgrimm | heh | 19:11 |
TheJulia | jgrimm: from what I've been told (haven't looked at the file history at all), but it was intended for tripleo to make the seed which they boot locally via virsh. | 19:12 |
jgrimm | interesting | 19:12 |
*** ndipanov has quit IRC | 19:18 | |
*** coolsvap is now known as coolsvap|afk | 19:20 | |
*** jmccrory has joined #openstack-ironic | 19:27 | |
*** ifarkas has quit IRC | 19:48 | |
lifeless | yeah the names are a bit bong there, sorry. | 20:04 |
*** marios has quit IRC | 20:30 | |
*** Marga_ has joined #openstack-ironic | 20:35 | |
*** ijw has joined #openstack-ironic | 20:41 | |
mrda | Morning | 20:46 |
*** dprince has quit IRC | 20:49 | |
*** erwan_taf has joined #openstack-ironic | 20:49 | |
*** lucas-dinner has quit IRC | 20:50 | |
* devananda unburies himself from the TC meeting for 30 seconds | 20:53 | |
devananda | mrda: hi there! | 20:53 |
*** anderbubble has quit IRC | 21:13 | |
*** kkoski has quit IRC | 21:23 | |
mrda | hey devananda | 21:24 |
*** ijw has quit IRC | 21:26 | |
*** anderbubble has joined #openstack-ironic | 21:27 | |
*** anderbubble has quit IRC | 21:33 | |
*** andreykurilin_ has joined #openstack-ironic | 21:34 | |
*** anderbubble has joined #openstack-ironic | 21:34 | |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Fix the final PEP8 errors https://review.openstack.org/163202 | 21:39 |
openstackgerrit | Adam Gandelman proposed openstack/python-ironicclient: Testing functional tests (DO NOT MERGE) https://review.openstack.org/163203 | 21:39 |
*** chlong has joined #openstack-ironic | 21:40 | |
*** jjohnson2 has quit IRC | 21:50 | |
*** kkoski has joined #openstack-ironic | 21:55 | |
*** Haomeng|2 has joined #openstack-ironic | 22:01 | |
*** coolsvap|afk has quit IRC | 22:03 | |
*** Haomeng has quit IRC | 22:04 | |
*** kkoski has quit IRC | 22:06 | |
*** chlong has quit IRC | 22:07 | |
*** andreykurilin_ has quit IRC | 22:10 | |
*** kkoski has joined #openstack-ironic | 22:11 | |
*** kkoski has quit IRC | 22:12 | |
openstackgerrit | Clif Houck proposed openstack/ironic: Added support for image caching for the agent driver https://review.openstack.org/161832 | 22:15 |
*** absubram_ has joined #openstack-ironic | 22:19 | |
*** absubram has quit IRC | 22:21 | |
*** absubram_ is now known as absubram | 22:21 | |
*** kkoski has joined #openstack-ironic | 22:25 | |
*** kkoski has quit IRC | 22:27 | |
*** anderbubble has quit IRC | 22:29 | |
*** kkoski has joined #openstack-ironic | 22:41 | |
*** kkoski has quit IRC | 22:44 | |
*** kkoski has joined #openstack-ironic | 22:51 | |
*** Marga_ has quit IRC | 22:57 | |
*** Marga_ has joined #openstack-ironic | 22:57 | |
jlvillal | NobodyCam: Question for you. On https://review.openstack.org/#/c/161832/4/ironic/drivers/modules/agent_base_vendor.py | 23:00 |
jlvillal | When you have time :) | 23:01 |
*** erwan_taf has quit IRC | 23:03 | |
*** Marga_ has quit IRC | 23:06 | |
*** ijw has joined #openstack-ironic | 23:06 | |
*** Marga_ has joined #openstack-ironic | 23:06 | |
jlvillal | NobodyCam: I asked in my review. Thanks. | 23:08 |
*** Marga_ has quit IRC | 23:11 | |
*** Nisha has joined #openstack-ironic | 23:12 | |
jroll | jlvillal: that's clif_h's patch | 23:16 |
jroll | jfyi | 23:16 |
jlvillal | jroll: Oh, duh! | 23:17 |
*** Marga_ has joined #openstack-ironic | 23:17 | |
jlvillal | jroll: Thanks | 23:17 |
Nisha | BadCub, hi | 23:17 |
jroll | heh, np :) | 23:18 |
jlvillal | jroll: I'm conflating Chris and Cliff :( | 23:19 |
Nisha | devananda, BadCub I would like the patch to be marked for KIlo-3, https://review.openstack.org/#/c/161861 as the ilo inspection https://review.openstack.org/151596 is dependent on this patch. It was identified as part of the ilo inspection | 23:20 |
jlvillal | NobodyCam: Never mind. I got you confused with clif_h . | 23:20 |
devananda | Nisha: patches are not tagged or targeted to milestones, only bugs and blueprints are | 23:20 |
jroll | jlvillal: one of the hardest things in computer science is naming :) | 23:21 |
Nisha | devananda, sorry its a bug | 23:21 |
Nisha | https://bugs.launchpad.net/ironic/+bug/1427597 | 23:21 |
openstack | Launchpad bug 1427597 in Ironic "destroy_port fails to delete the port even if the node is locked by the same process. " [Medium,In progress] - Assigned to Nisha Agarwal (agarwalnisha1980) | 23:21 |
jlvillal | jroll: True :) | 23:21 |
devananda | Nisha: done | 23:22 |
Nisha | Thanks devananda | 23:22 |
devananda | any other bugs that need targeting? | 23:22 |
Nisha | No | 23:22 |
Nisha | Thank you | 23:22 |
*** absubram has quit IRC | 23:24 | |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: ironic port deletion fails even if node is locked by same process https://review.openstack.org/161861 | 23:25 |
devananda | jroll: regarding bug https://bugs.launchpad.net/ironic/+bug/1430454 | 23:26 |
openstack | Launchpad bug 1430454 in Ironic "IPA deploy driver gives incomprehensible error message when using partition images" [Medium,Confirmed] | 23:26 |
jroll | devananda: mhmmm | 23:26 |
devananda | jroll: I thought there as ongoing work to enable partition images with IPA ? | 23:26 |
jroll | there isd | 23:26 |
jroll | is | 23:26 |
jroll | didn't that get bumped to L? | 23:26 |
devananda | did it? | 23:27 |
devananda | oh right, yes | 23:27 |
jroll | idk, I thought it did | 23:27 |
jroll | at any rate, the error sucks | 23:27 |
jroll | and while it's an error, we should fix it | 23:28 |
devananda | oh, this is hte one that confuses me - https://blueprints.launchpad.net/ironic/+spec/local-boot-support-with-partition-images | 23:28 |
devananda | jroll: oh, totally. make errors better == always good | 23:28 |
jroll | :) | 23:29 |
devananda | but saying we support local boot with partition images, and IPA is the default deplly mechanism, but IPA does not support partition images .... | 23:29 |
devananda | that's ver yconfusing | 23:29 |
devananda | so I think that's why I keep thinking IPA does partition image deplloyment | 23:29 |
*** david-lyle is now known as david-lyle_afk | 23:33 | |
jroll | yeah | 23:34 |
jroll | can't blame our docs if even the PTL is confused :D | 23:34 |
devananda | jroll: I blame our contributors for not actually supporting the same feature set in both of our deploy drivers... it's driving me nuts ... | 23:35 |
devananda | jroll: but in the end, yes, my fault. | 23:36 |
devananda | so really I'm driving myself nuts :) | 23:36 |
devananda | also, blame is a horrible word | 23:36 |
*** kkoski has quit IRC | 23:38 | |
jroll | devananda: heh, I'm just messing with you | 23:43 |
jroll | but yeah, agree | 23:43 |
*** kkoski has joined #openstack-ironic | 23:51 | |
*** chlong has joined #openstack-ironic | 23:54 | |
*** jmccrory has quit IRC | 23:59 | |
*** rloo has quit IRC | 23:59 | |
openstackgerrit | Merged openstack/ironic: Make sure we don't log the full content of the config drive https://review.openstack.org/162252 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!