| *** igordcard has joined #openstack-ironic | 00:02 | |
| *** achanda has quit IRC | 00:04 | |
| *** romcheg has quit IRC | 00:07 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_context package https://review.openstack.org/162499 | 00:32 |
|---|---|---|
| *** achanda has joined #openstack-ironic | 00:39 | |
| *** igordcard has quit IRC | 00:41 | |
| *** naohirot has joined #openstack-ironic | 00:44 | |
| *** oomichi has joined #openstack-ironic | 00:47 | |
| *** anderbubble has quit IRC | 01:03 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_policy package https://review.openstack.org/162501 | 01:10 |
| *** achanda has quit IRC | 01:25 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_log lib https://review.openstack.org/157602 | 01:39 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_policy package https://review.openstack.org/162501 | 01:39 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use strutils from oslo_utils https://review.openstack.org/162497 | 01:39 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_context package https://review.openstack.org/162499 | 01:39 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Sync from oslo.incubator https://review.openstack.org/162505 | 01:39 |
| *** Haomeng|2 has joined #openstack-ironic | 01:40 | |
| *** Haomeng has quit IRC | 01:42 | |
| *** zer0c00l has joined #openstack-ironic | 01:46 | |
| *** krtaylor has quit IRC | 02:04 | |
| *** achanda has joined #openstack-ironic | 02:31 | |
| *** Krast has joined #openstack-ironic | 02:32 | |
| *** coolsvap has joined #openstack-ironic | 02:34 | |
| *** achanda has quit IRC | 02:38 | |
| *** achanda has joined #openstack-ironic | 02:38 | |
| *** achanda has quit IRC | 02:42 | |
| *** achanda has joined #openstack-ironic | 02:42 | |
| *** krtaylor has joined #openstack-ironic | 02:55 | |
| *** chenglch has joined #openstack-ironic | 03:07 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic-specs: Cinder integration https://review.openstack.org/149606 | 03:18 |
| openstackgerrit | Tan Lin proposed openstack/ironic: Tiny improvement of efficient https://review.openstack.org/162515 | 03:21 |
| *** achanda has quit IRC | 03:31 | |
| openstackgerrit | jiangfei proposed openstack/python-ironicclient: Log token with sha1 https://review.openstack.org/162517 | 03:40 |
| *** jerryz has joined #openstack-ironic | 03:53 | |
| *** jmccrory has joined #openstack-ironic | 03:59 | |
| *** achanda has joined #openstack-ironic | 04:04 | |
| *** achanda has quit IRC | 04:16 | |
| *** achanda has joined #openstack-ironic | 04:20 | |
| *** ramineni has joined #openstack-ironic | 04:27 | |
| *** kalpase has joined #openstack-ironic | 04:30 | |
| *** jmccrory has quit IRC | 04:30 | |
| *** chenglch has quit IRC | 04:31 | |
| *** chenglch has joined #openstack-ironic | 04:32 | |
| *** Haomeng has joined #openstack-ironic | 04:38 | |
| *** Haomeng|2 has quit IRC | 04:40 | |
| *** achanda has quit IRC | 04:46 | |
| *** achanda has joined #openstack-ironic | 04:48 | |
| *** achanda has quit IRC | 04:57 | |
| *** sandhya has joined #openstack-ironic | 04:59 | |
| *** Marga_ has quit IRC | 05:15 | |
| *** oomichi has quit IRC | 05:30 | |
| *** Marga_ has joined #openstack-ironic | 05:32 | |
| *** achanda has joined #openstack-ironic | 05:40 | |
| *** anderbubble has joined #openstack-ironic | 05:41 | |
| *** stendulker has joined #openstack-ironic | 05:57 | |
| *** pradipta has joined #openstack-ironic | 05:58 | |
| *** chenglch has quit IRC | 06:04 | |
| *** ParsectiX has quit IRC | 06:16 | |
| *** chenglch|2 has joined #openstack-ironic | 06:20 | |
| *** huangkai2 has joined #openstack-ironic | 06:21 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add label to virtual floppy image https://review.openstack.org/162387 | 06:28 |
| *** yog_ has joined #openstack-ironic | 06:30 | |
| *** achanda has quit IRC | 06:37 | |
| *** achanda has joined #openstack-ironic | 06:44 | |
| *** huangkai2 has quit IRC | 06:49 | |
| *** Nisha has joined #openstack-ironic | 06:50 | |
| *** chenglch|2 has quit IRC | 06:52 | |
| *** chenglch has joined #openstack-ironic | 06:53 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor agent iscsi deploy out of pxe driver https://review.openstack.org/162408 | 06:56 |
| *** huangkai2 has joined #openstack-ironic | 06:56 | |
| *** rwsu has joined #openstack-ironic | 06:57 | |
| *** rwsu is now known as rwsu-afk | 06:58 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor agent iscsi deploy out of pxe driver https://review.openstack.org/162408 | 06:59 |
| *** gridinv has quit IRC | 07:00 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: iscsi_ilo driver to support agent ramdisk https://review.openstack.org/162449 | 07:03 |
| *** Marga_ has quit IRC | 07:26 | |
| *** anderbubble has quit IRC | 07:37 | |
| *** achanda has quit IRC | 07:40 | |
| *** jcoufal has joined #openstack-ironic | 07:43 | |
| *** ukalifon1 has joined #openstack-ironic | 07:46 | |
| *** achanda has joined #openstack-ironic | 07:52 | |
| *** sandhya has quit IRC | 08:02 | |
| *** chlong has quit IRC | 08:07 | |
| *** achanda has quit IRC | 08:14 | |
| *** achanda has joined #openstack-ironic | 08:16 | |
| *** ifarkas has joined #openstack-ironic | 08:19 | |
| *** achanda has quit IRC | 08:28 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic: Fix wrong log output in ironic/ironic/conductor/manager.py https://review.openstack.org/162560 | 08:34 |
| *** enikanorov_ has joined #openstack-ironic | 08:35 | |
| *** andreykurilin_ has joined #openstack-ironic | 08:41 | |
| *** erwan_taf has joined #openstack-ironic | 08:51 | |
| *** bauwser is now known as bauzas | 08:53 | |
| GheRivero | morning all | 08:56 |
| Kinnison | Morning GheRivero | 08:57 |
| openstackgerrit | Anusha Ramineni proposed openstack/ironic: Add Cleaning Operations for iLO drivers https://review.openstack.org/157715 | 09:02 |
| *** early has quit IRC | 09:04 | |
| *** huangkai2 has quit IRC | 09:05 | |
| *** early has joined #openstack-ironic | 09:06 | |
| *** dlpartain has joined #openstack-ironic | 09:06 | |
| *** athomas has quit IRC | 09:11 | |
| *** athomas has joined #openstack-ironic | 09:11 | |
| *** lucasagomes has joined #openstack-ironic | 09:12 | |
| *** jistr has joined #openstack-ironic | 09:13 | |
| *** dlpartain has left #openstack-ironic | 09:14 | |
| *** mgoddard has joined #openstack-ironic | 09:15 | |
| *** andreykurilin_ has quit IRC | 09:21 | |
| *** MattMan has joined #openstack-ironic | 09:24 | |
| *** lynxman has quit IRC | 09:27 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic-specs: Fix a lot of typos in ironic-specs/specs/kilo/drac-bios-mgmt.rst https://review.openstack.org/162578 | 09:28 |
| *** lynxman has joined #openstack-ironic | 09:28 | |
| *** lynxman has quit IRC | 09:34 | |
| *** lynxman has joined #openstack-ironic | 09:40 | |
| *** romcheg has joined #openstack-ironic | 09:46 | |
| *** naohirot has quit IRC | 09:51 | |
| *** MattMan has left #openstack-ironic | 09:51 | |
| *** tiagogomes_ has joined #openstack-ironic | 09:52 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_log lib https://review.openstack.org/157602 | 09:57 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Sync from oslo.incubator https://review.openstack.org/162505 | 09:57 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_policy package https://review.openstack.org/162501 | 09:57 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use strutils from oslo_utils https://review.openstack.org/162497 | 09:57 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_context package https://review.openstack.org/162499 | 09:57 |
| *** pelix has joined #openstack-ironic | 10:02 | |
| *** dlpartain has joined #openstack-ironic | 10:04 | |
| *** dlpartain has left #openstack-ironic | 10:04 | |
| *** Nisha has quit IRC | 10:07 | |
| *** athomas has quit IRC | 10:10 | |
| *** athomas has joined #openstack-ironic | 10:15 | |
| *** coolsvap has quit IRC | 10:17 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic-specs: Fix typo in ironic-specs/specs/kilo/uefi-secure-boot.rst https://review.openstack.org/162590 | 10:19 |
| *** kalpase has quit IRC | 10:21 | |
| *** kalpase has joined #openstack-ironic | 10:22 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Make sure we don't log the full content of the config drive https://review.openstack.org/162252 | 10:26 |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic-specs: Fix typo in ironic-specs/specs/kilo/partition-image-support-for-agent-driver.rst https://review.openstack.org/162593 | 10:28 |
| openstackgerrit | Merged openstack/ironic: Fix wrong log output in ironic/ironic/conductor/manager.py https://review.openstack.org/162560 | 10:31 |
| *** erwan_taf has quit IRC | 10:36 | |
| *** MattMan has joined #openstack-ironic | 10:46 | |
| *** yog_ has quit IRC | 10:49 | |
| *** andreykurilin_ has joined #openstack-ironic | 10:53 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: WIP: oslo.log https://review.openstack.org/162600 | 10:55 |
| d0ugal | Is the next Ironic meeting today or tomorrow? | 10:58 |
| d0ugal | Oh, it's today, I think | 10:59 |
| d0ugal | Great :D | 10:59 |
| *** chlong has joined #openstack-ironic | 11:03 | |
| *** yog_ has joined #openstack-ironic | 11:05 | |
| *** yuanying has quit IRC | 11:08 | |
| *** ramineni has quit IRC | 11:08 | |
| lucasagomes | yup today :) 5pm utc | 11:12 |
| *** stendulker has quit IRC | 11:12 | |
| *** yog_ has quit IRC | 11:12 | |
| *** romcheg has quit IRC | 11:14 | |
| *** romcheg has joined #openstack-ironic | 11:23 | |
| *** yog_ has joined #openstack-ironic | 11:25 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic-specs: Fix typo in ironic-specs/specs/kilo/automate-uefi-bios-iso-creation.rst https://review.openstack.org/162605 | 11:28 |
| *** tiagogomes_ has quit IRC | 11:30 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic-specs: Fix typo in ironic-specs/specs/kilo/non-glance-image-refs.rst https://review.openstack.org/162606 | 11:32 |
| *** kejiahu has left #openstack-ironic | 11:34 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic-specs: Fix typo in ironic-specs/specs/kilo/new-ironic-state-machine.rst https://review.openstack.org/162607 | 11:37 |
| *** tiagogomes_ has joined #openstack-ironic | 11:38 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic-specs: Fix typo in ironic-specs/specs/kilo/local-boot-support-with-partition-images.rst https://review.openstack.org/162608 | 11:43 |
| *** huangkai2 has joined #openstack-ironic | 11:45 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic-specs: Fix typo in ironic-specs/specs/kilo/ironic-node-properties-discovery.rst https://review.openstack.org/162610 | 11:49 |
| *** jcoufal_ has joined #openstack-ironic | 11:52 | |
| *** jcoufal has quit IRC | 11:52 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic-specs: Fix typo in ironic-specs/specs/kilo/cisco-ucs-pxe-driver.rst https://review.openstack.org/162613 | 11:53 |
| *** romcheg has quit IRC | 11:54 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/python-ironicclient: Encode exception on cli for UnicodeDecodeError https://review.openstack.org/153155 | 11:55 |
| *** dprince has joined #openstack-ironic | 12:14 | |
| *** romcheg has joined #openstack-ironic | 12:18 | |
| *** lazy_prince is now known as killer_prince | 12:27 | |
| *** yog_ has quit IRC | 12:37 | |
| *** lucasagomes is now known as lucas-hungry | 12:44 | |
| *** andreykurilin_ has quit IRC | 12:48 | |
| *** romcheg has quit IRC | 12:49 | |
| *** yog_ has joined #openstack-ironic | 12:51 | |
| *** yog__ has joined #openstack-ironic | 12:52 | |
| *** ndipanov has joined #openstack-ironic | 12:53 | |
| *** ndipanov has quit IRC | 12:53 | |
| *** romcheg has joined #openstack-ironic | 12:56 | |
| jroll | morning all :) | 13:00 |
| *** yog__ has quit IRC | 13:01 | |
| jroll | that's a lot of specs typos, do we care about those? :/ | 13:01 |
| *** chlong has quit IRC | 13:04 | |
| *** rloo has joined #openstack-ironic | 13:13 | |
| *** chlong has joined #openstack-ironic | 13:17 | |
| *** mjturek1 has joined #openstack-ironic | 13:19 | |
| *** kkoski has joined #openstack-ironic | 13:20 | |
| Shrews | jroll: i feel like that was discussed on the ML recently... but i still have morning brain fog | 13:26 |
| Shrews | i think need to dedicate today to reviewing all the things. been too busy with other stuff lately :( | 13:28 |
| jroll | Shrews: it was. for code and stuff. to me specs are pretty meh for typos, though I guess they're kinda like release notes | 13:34 |
| *** romcheg1 has joined #openstack-ironic | 13:35 | |
| *** romcheg has quit IRC | 13:35 | |
| Shrews | jroll: my thought would be to go ahead and accept them, but redirect the author to something more helpful and a bit more challenging | 13:35 |
| *** stendulker has joined #openstack-ironic | 13:35 | |
| jroll | Shrews: easy review points then :) | 13:36 |
| Shrews | lhf bugs, etc | 13:36 |
| jroll | I'll look up to you for an example of a good comment to that effect then :P | 13:37 |
| rloo | wrt specs, I don't even bother with nits about grammatical stuff. Seems like specs are meant for developers. If the update helps to understand, then that is good. but otherwise. Anyway, I'm ignoring those. too many reviews too look at. | 13:37 |
| rloo | morning everyone ;) | 13:38 |
| TheJulia | Good morning | 13:38 |
| jroll | morning rloo and TheJulia :) | 13:38 |
| Shrews | jroll: i'm not core on specs, but i have total faith in you :-P | 13:38 |
| jroll | rloo: yeah, though I've heard PM types read them to see what's up with new big feature things | 13:39 |
| * rloo likes TheJulia. Maybe I'll change to TheRuby ;) | 13:39 | |
| jroll | Shrews: dang. | 13:39 |
| Shrews | hey rloo, TheJulia | 13:39 |
| jroll | TheJulia: have y'all thought about running ironic in containers at all? | 13:39 |
| rloo | jroll: if we want the specs to be grammatical etc, just let us know, and I'll nit. I stopped cuz I didn't think people wanted it and I didn't think it was something that was expected. | 13:40 |
| jroll | rloo: I personally don't care about it and don't think we should nit on it, my question is if we should bother with these changes | 13:41 |
| * Shrews gives a nod toward dockstack (https://github.com/Shrews/dockstack), designed to run ironic in containers | 13:41 | |
| jroll | at any rate, there's more important things to review, as you said | 13:41 |
| rloo | jroll: good question. I only asked wrt code. You core reviewers can decide for specs ;) | 13:41 |
| jroll | Shrews: ready for production? | 13:42 |
| jroll | or is it meant for dev stuff | 13:42 |
| Shrews | jroll: targeted toward dev | 13:43 |
| jroll | Shrews: right on, I want to do this in prod, and it's pretty dang simple | 13:43 |
| jroll | like a 10 line dockerfile, upload to swift, deploy is pull it down and run it | 13:44 |
| Shrews | jroll: may or may not ever be useful for people, but i had fun writing it | 13:44 |
| jroll | (and build a config file, I guess) | 13:44 |
| jroll | yeah, seems cool, I'd love to replace devstack with docker containers | 13:44 |
| jroll | mostly so I don't have to blow away an entire OS when things go bad | 13:44 |
| TheJulia | jroll: Honestly had not tought about it | 13:47 |
| jroll | TheJulia: ah, that's one of my goals right now, I'll let you know how it goes :) | 13:48 |
| TheJulia | rloo: I couldn't think of anything to use on freenode when some friends finally got me be on freenode all the time, and I was Julia on another network, so I figured why not. :) | 13:48 |
| rloo | TheJulia: I think it is an awesome nick :-) | 13:49 |
| jroll | not just a Julia, but *the* Julia. I like it too. | 13:49 |
| TheJulia | Hehe | 13:49 |
| * TheJulia is reminded of a side comment she overheard when a mental connection of stores was made to my name | 13:51 | |
| *** stendulker has quit IRC | 13:52 | |
| TheJulia | Shrews: I like the FAQ :) | 13:57 |
| *** stendulker has joined #openstack-ironic | 14:00 | |
| Shrews | :) | 14:00 |
| *** lucas-hungry is now known as lucasagomes | 14:01 | |
| *** stendulker_ has joined #openstack-ironic | 14:05 | |
| *** Nisha has joined #openstack-ironic | 14:06 | |
| *** chenglch has quit IRC | 14:06 | |
| trown | Shrews: thats pretty neat :), I had not heard of Fig either | 14:06 |
| *** stendulker has quit IRC | 14:07 | |
| lucasagomes | morning trown jroll TheJulia Shrews rloo :) | 14:09 |
| TheJulia | good morning lucasagomes | 14:09 |
| GheRivero | morning all | 14:09 |
| trown | morning lucasagomes | 14:09 |
| jroll | morning lucasagomes and GheRivero :) | 14:12 |
| rloo | hi lucasagomes, GheRivero | 14:13 |
| *** ChuckC_ has joined #openstack-ironic | 14:13 | |
| *** ChuckC has quit IRC | 14:14 | |
| *** ChuckC_ has quit IRC | 14:18 | |
| *** erwan_taf has joined #openstack-ironic | 14:25 | |
| *** stendulker_ has quit IRC | 14:26 | |
| *** huangkai2 has quit IRC | 14:28 | |
| *** r-daneel has joined #openstack-ironic | 14:28 | |
| openstackgerrit | Merged openstack/ironic: Tiny improvement of efficient https://review.openstack.org/162515 | 14:28 |
| *** kalpase has left #openstack-ironic | 14:31 | |
| *** achanda has joined #openstack-ironic | 14:33 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: ironic port deletion fails even if node is locked by same process https://review.openstack.org/161861 | 14:34 |
| NobodyCam | good morning Ironic | 14:36 |
| lucasagomes | pxe_ipa now running on gate \o/ | 14:40 |
| lucasagomes | NobodyCam, GheRivero morning | 14:40 |
| GheRivero | \o/ | 14:42 |
| jroll | morning NobodyCam :) | 14:42 |
| jroll | lucasagomes: nice! voting or no? | 14:42 |
| NobodyCam | morning lucasagomes GheRivero jroll :) | 14:42 |
| lucasagomes | jroll, not yet, we need data first | 14:42 |
| jroll | yeah | 14:42 |
| *** mtanino has joined #openstack-ironic | 14:42 | |
| jroll | still awesome, just curious :) | 14:42 |
| *** achanda has quit IRC | 14:42 | |
| NobodyCam | ya | 14:42 |
| NobodyCam | :) | 14:42 |
| lucasagomes | but still good, at least I don't have to keep posting "check experimental" on the patches | 14:42 |
| *** zz_jgrimm is now known as jgrimm | 14:43 | |
| jroll | heh, yeah | 14:44 |
| *** beekneemech is now known as bnemec | 14:49 | |
| *** erwan_taf has quit IRC | 14:53 | |
| *** ChuckC_ has joined #openstack-ironic | 14:54 | |
| *** ChuckC_ has quit IRC | 14:54 | |
| *** ChuckC_ has joined #openstack-ironic | 14:54 | |
| *** Nisha has quit IRC | 14:54 | |
| *** ndipanov has joined #openstack-ironic | 14:56 | |
| *** Nisha has joined #openstack-ironic | 14:59 | |
| *** mgoddard has quit IRC | 15:00 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: WIP: oslo.log https://review.openstack.org/162600 | 15:00 |
| *** mgoddard has joined #openstack-ironic | 15:02 | |
| *** ndipanov has quit IRC | 15:02 | |
| victor_lowther | hmmm... | 15:03 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/161811 | 15:04 |
| victor_lowther | so I am fixing up my DRAC bios config patch to be i18n compliant | 15:04 |
| victor_lowther | but the i18n module seems to assume ascii instead of utf-8 | 15:04 |
| *** ukalifon2 has joined #openstack-ironic | 15:04 | |
| *** achanda has joined #openstack-ironic | 15:04 | |
| NobodyCam | mornign victor_lowther :) | 15:05 |
| victor_lowther | Specifically, I get 'UnicodeDecodeError: 'ascii' codec can't decode byte 0x80 in position 0: ordinal not in range(128)' when running unit tests | 15:05 |
| victor_lowther | where I specifically want to test that the validators are rejecting invalid input correctly. | 15:06 |
| Shrews | jroll: 162408 looks like a nice refactor. would be good if you could take a look, particularly the agent stuff. | 15:06 |
| *** ukalifon1 has quit IRC | 15:07 | |
| MattMan | Probably a real noob question but... trying to enable console support using ipmitool.IPMIShellinaboxConsole() however from CLI trying to set driver_info/ipmi_terminal_port is always failing with a wsme type error... it won't let me set an integer value... | 15:08 |
| MattMan | e.g. Client-side error: Invalid input for field/attribute value. Value: '80'. Wrong type. Expected '<type 'unicode'>', got '<type 'int'>' | 15:08 |
| MattMan | Setting via command : ironic-client node-update $NODE add driver_info/ipmi_terminal_port=80 | 15:09 |
| *** achanda has quit IRC | 15:09 | |
| jroll | Shrews: sure thing | 15:09 |
| jroll | MattMan: have you tried with quotes? (I've never used that field so not sure if that's ever worked) | 15:10 |
| MattMan | quotes fail | 15:10 |
| jroll | ugh. | 15:10 |
| MattMan | in fact trying to set any driver_info property throws the same error, not just ipmi_terminal_port so it's not specific to property name, just don't like integers... which seems a bit cracked.. | 15:11 |
| jroll | yeah, I agree | 15:12 |
| jroll | devananda: ^^ more stupid things our client does | 15:12 |
| *** hj-hp has joined #openstack-ironic | 15:12 | |
| jroll | also true != True for cli things, which is bonkers | 15:13 |
| jroll | found that one the other day | 15:13 |
| *** yog_ has quit IRC | 15:13 | |
| MattMan | So any idea of a workaround ? | 15:13 |
| jroll | MattMan: it's a horrible answer, but use curl? | 15:14 |
| jroll | using the client with --debug will give you an approximate curl command, assuming validation passes and it actually makes a request | 15:14 |
| MattMan | nod... I was just about to say that.... but as you say not exactly ideal... didn't know about --debug... thanks | 15:15 |
| jroll | so you could do: ironic --debug node-update $uuid replace driver_info/ipmi_terminal_port=wat | 15:15 |
| jroll | and go from there | 15:15 |
| jroll | (replace wat with 80 in the curl command) | 15:15 |
| *** anderbubble has joined #openstack-ironic | 15:15 | |
| MattMan | yep will give that spin, thanks again | 15:15 |
| Shrews | sort of sounds like a server side bug | 15:15 |
| rloo | jroll: there's a bug for true !=True thingy. I was going to fix it but decided reviews were more important now; going to fix after k-3 | 15:15 |
| Shrews | not sure curl will work, but /me crosses fingers | 15:16 |
| jlvillal | MattMan: Can you http://paste.openstack.org/ the output from your run? Maybe we can use that info to fix it. | 15:16 |
| jlvillal | Or a bug report :) | 15:16 |
| jroll | rloo: ah, I see | 15:16 |
| jroll | Shrews: no, that's a client-side error | 15:16 |
| jroll | doing validation | 15:16 |
| *** stendulker has joined #openstack-ironic | 15:16 | |
| *** ndipanov has joined #openstack-ironic | 15:17 | |
| MattMan | Output from --debug : http://paste.openstack.org/show/190998/ | 15:18 |
| MattMan | Key portion is : -d '[{"path": "/driver_info/ipmi_terminal_port", "value": 80, "op": "add"}] | 15:19 |
| devananda | jroll: that sounds like a straight-up bug somewhere | 15:19 |
| jroll | oh, interesting. | 15:19 |
| jroll | that is a server side bug | 15:19 |
| MattMan | notice how value us 80, if I put quotes around 80 on CLI it still remains as 80 | 15:20 |
| *** dmellado has quit IRC | 15:20 | |
| devananda | well | 15:20 |
| jroll | devananda: sure, I think all stupid things our client does are bugs | 15:20 |
| devananda | that's a client bug, no? shouldn't all values in the JSON string be quoted? | 15:20 |
| MattMan | devananda: that's what I thought | 15:20 |
| jroll | idk, I tend to think integers in JSON is a sane thing | 15:20 |
| *** BadCub has joined #openstack-ironic | 15:20 | |
| *** dmellado has joined #openstack-ironic | 15:21 | |
| BadCub | Morning Ironic | 15:21 |
| jlvillal | devananda: jroll: The server should accept both in my opinion. Be tolerant in what you will accept. | 15:22 |
| jroll | and like. it's json. integers are a part of the json spec. | 15:22 |
| Shrews | devananda: at one point, you specifically pulled methods like _do_node_tear_down() out of the manager and made them module level methods, but i can't remember why. I see we're reversing that now? | 15:27 |
| jroll | I think we only did that because they no longer needed 'self'. and maybe now they do? I think cleaning needed that | 15:28 |
| MattMan | FYI: amending curl request s/80/"80"/ works... | 15:28 |
| *** hj-hp has quit IRC | 15:28 | |
| lucasagomes | MattMan, odd | 15:28 |
| Shrews | jroll: yeah, i was reviewing that merged change... not sure why we're doing that yet | 15:28 |
| *** dmellado has quit IRC | 15:28 | |
| * lucasagomes looks what's wrong | 15:28 | |
| lucasagomes | you should be able to input any json primitives to the driver_info | 15:29 |
| *** hj-hp has joined #openstack-ironic | 15:29 | |
| lucasagomes | int, bool, list, string etc | 15:29 |
| MattMan | lucasagomes: I'm running juno bits | 15:29 |
| lucasagomes | oh | 15:29 |
| jroll | ohhh. | 15:29 |
| lucasagomes | ok that explains a lot :) | 15:29 |
| jroll | I thought we had ints in juno but maybe not | 15:29 |
| MattMan | So juno only bug... apologies for lack of info | 15:30 |
| devananda | Shrews: reversing that where? | 15:30 |
| Shrews | devananda: https://review.openstack.org/#/c/153444/24/ironic/conductor/manager.py | 15:31 |
| *** dmellado has joined #openstack-ironic | 15:31 | |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed openstack/ironic: Add support for partition images in agent driver https://review.openstack.org/162008 | 15:31 |
| *** Nisha has quit IRC | 15:31 | |
| devananda | Shrews: so yea, I did that for two reasons. a) making them reusable, as some of them needed to be called from different places. b) making them more testable. c) making them invokable by callback from spawn_worker() | 15:31 |
| devananda | ok, three reasons | 15:31 |
| MattMan | lucasagomes / jroll : Is this something easily back ported perhaps ?.... | 15:31 |
| devananda | um | 15:32 |
| lucasagomes | MattMan, hmm /me thinking | 15:32 |
| jroll | my first instinct says no | 15:33 |
| rloo | hey, qq. If you have a config max_retries=2, would you think it meant do something 2 times max, or 3 times max? | 15:33 |
| jroll | rloo: I would read the help :) | 15:33 |
| lucasagomes | that's the patch adding json types | 15:34 |
| lucasagomes | https://review.openstack.org/#/c/137762/ | 15:34 |
| rloo | jroll: "Maximum number of times to retry an AMT operation, before failing" | 15:34 |
| lucasagomes | but I don't think we will port api changes like that | 15:34 |
| jroll | rloo: reading that probably 3 times max but idk | 15:34 |
| rloo | jroll: yeah, that's what I think too, but code does 2 times. | 15:34 |
| jroll | rloo: the word "retries" sucks, we should use "attempts" | 15:34 |
| jroll | sigh. | 15:34 |
| rloo | jroll: thx. either help changes or code changes. i don't want to go through all other 'retry' like configs to see what we do. | 15:35 |
| lucasagomes | MattMan, not sure, but if you do ironic-client node-update $NODE add driver_info/ipmi_terminal_port="80" does it works? | 15:35 |
| lucasagomes | with 80 quoted | 15:35 |
| jlvillal | jroll: rloo: +1 on 'attempts' vs 'retries' | 15:36 |
| MattMan | lucasagomes: afraid not, | 15:36 |
| rloo | jlvillal, jroll: thx. I'll mention that in my comment ;) | 15:36 |
| jroll | rloo: imo code should change | 15:37 |
| lucasagomes | :( | 15:37 |
| MattMan | It still get's passed to curl request as 80 | 15:37 |
| rloo | jroll: oh. I thought you didn't like 'retries'. but then, maybe the config should be max_attempts. Sigh. | 15:37 |
| lucasagomes | MattMan, not ideal, but you could do | 15:37 |
| lucasagomes | "\"80\"" | 15:37 |
| jroll | rloo: well, if we can change the config to attempts, that's the best imo | 15:38 |
| lucasagomes | .. add driver_info/ipmi_terminal_port="\"80\"" | 15:38 |
| rloo | jroll: you'll like this one 'node_locked_retry_attempts' | 15:38 |
| * lucasagomes we need a fix for that | 15:38 | |
| MattMan | escaping the quotes... now that does work... | 15:38 |
| jroll | :| | 15:38 |
| lucasagomes | MattMan, x.x yeah | 15:38 |
| *** david-lyle_afk is now known as david-lyle | 15:38 | |
| rloo | jroll: I'll suggest changing the config name then. | 15:38 |
| * MattMan somewhat happy now... thanks lucasagomes | 15:38 | |
| lucasagomes | MattMan, well it's not ideal at all | 15:38 |
| jlvillal | Any unittest gurus around? Curious the best way to test a context manager function? e.g. 'with some_context_manager_function():' Wanted to test how it handles exceptions. | 15:38 |
| MattMan | lucasagomes: better than running --debug to get curl and re-submitting the curl... | 15:39 |
| lucasagomes | true | 15:39 |
| lucasagomes | heh | 15:39 |
| jlvillal | I wanted to write a good test case for my patch: https://review.openstack.org/161803 | 15:39 |
| jroll | rloo: awesome | 15:40 |
| jroll | jlvillal: make a test function, decorate it, test? | 15:40 |
| *** stendulker has quit IRC | 15:41 | |
| *** rwsu-afk is now known as rwsu | 15:41 | |
| jlvillal | jroll: Okay. so make some helper function that will use the context manager function and do the exception. Call the helper function with a self.assertRaises(). | 15:42 |
| * jlvillal thinks that would work. Not as elegant as he hoped but workable :) | 15:42 | |
| jroll | jlvillal: yeah, I think so | 15:43 |
| jlvillal | jroll: Okay. And the helper function could be a closure function.... | 15:43 |
| jroll | jlvillal: idk why you would make it hard on yourself like that :P | 15:43 |
| * jlvillal has learned fancy new terms :) | 15:43 | |
| jlvillal | jroll: :D | 15:43 |
| *** romcheg1 has quit IRC | 15:44 | |
| * jlvillal hopes someday he will actually write the unittests first.... | 15:44 | |
| jroll | meh. | 15:45 |
| jroll | :) | 15:45 |
| *** BadCub02 has joined #openstack-ironic | 15:45 | |
| pshige | jroll, sorry for a lot of specs typos. I don't know how to report them in a better way. | 15:50 |
| *** rameshg87 has joined #openstack-ironic | 15:51 | |
| jroll | pshige: it's ok, I'd just rather dedicate efforts to things with more impact :) | 15:51 |
| devananda | reminder for US folks - we switched to DST yesterday, so our meeting is in one hour, not 10 minutes | 15:51 |
| *** Nisha has joined #openstack-ironic | 15:51 | |
| * jlvillal Finishes updating Outlook to use UTC time for calendar meeting :) Had already done that for Google Calendar reminder. | 15:53 | |
| *** BadCub02 has quit IRC | 15:53 | |
| openstackgerrit | Victor Lowther proposed openstack/ironic: Add DRAC BIOS config vendor passthru API https://review.openstack.org/150488 | 15:58 |
| *** romcheg has joined #openstack-ironic | 15:59 | |
| Shrews | devananda: doh! TZs suck | 15:59 |
| jroll | time zones are awesome, I get to put off being locked in a channel with y'all :P | 16:00 |
| clif_h | locked in channel | 16:03 |
| clif_h | hah | 16:03 |
| Shrews | wow. the operator meetup is quite large | 16:04 |
| Shrews | https://twitter.com/amitry/status/574942441373069312 | 16:04 |
| devananda | Shrews: .. damn. that is large | 16:07 |
| devananda | Shrews: are ya'll getting any work done? | 16:07 |
| Shrews | devananda: i'm not there | 16:07 |
| devananda | oh | 16:07 |
| devananda | TheJulia: ^ full house, eh? | 16:07 |
| *** stendulker has joined #openstack-ironic | 16:11 | |
| *** absubram has quit IRC | 16:11 | |
| *** Marga_ has joined #openstack-ironic | 16:12 | |
| *** stendulker has quit IRC | 16:13 | |
| *** stendulker has joined #openstack-ironic | 16:13 | |
| pshige | jroll; Ok. I am relatively new, so I am now checking specs, first. I am interested in network-provider and cinder-integration and so on, so I'd like to dive into them next. | 16:14 |
| *** stendulker has quit IRC | 16:17 | |
| *** stendulker has joined #openstack-ironic | 16:17 | |
| openstackgerrit | Tan Lin proposed openstack/ironic: Add AMT-PXE-Driver Power&Management&Vendor Interface https://review.openstack.org/152858 | 16:18 |
| jroll | pshige: great :) | 16:20 |
| jroll | Shrews: wow... /me wonders if the far right is jlk and notices much beard growth | 16:22 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Update unittests for _make_password_file https://review.openstack.org/162672 | 16:25 |
| *** _lintan has joined #openstack-ironic | 16:27 | |
| *** jmccrory has joined #openstack-ironic | 16:27 | |
| *** ukalifon2 has quit IRC | 16:28 | |
| *** ChuckC_ has quit IRC | 16:34 | |
| *** andreykurilin_ has joined #openstack-ironic | 16:35 | |
| *** krtaylor has quit IRC | 16:36 | |
| *** stendulker_ has joined #openstack-ironic | 16:39 | |
| *** stendulker has quit IRC | 16:41 | |
| *** Marga_ has quit IRC | 16:42 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Update unittests for _make_password_file https://review.openstack.org/162672 | 16:42 |
| *** Marga_ has joined #openstack-ironic | 16:43 | |
| *** dprince has quit IRC | 16:43 | |
| *** krtaylor has joined #openstack-ironic | 16:48 | |
| *** ramineni has joined #openstack-ironic | 16:52 | |
| *** Krast has quit IRC | 16:55 | |
| *** Krast has joined #openstack-ironic | 16:56 | |
| TheJulia | devananda: yes, very full | 16:56 |
| devananda | TheJulia: i dont see any tables or white boards. therefor I am dubious as to whether anywork will happen :) | 16:57 |
| devananda | also folks - reminder - meeting in 2 minutes | 16:57 |
| *** faizan has joined #openstack-ironic | 16:57 | |
| *** ijw has quit IRC | 16:58 | |
| TheJulia | devananda: There is a wall that will be going up any moment that becomes a giant whiteboard | 16:58 |
| devananda | oooh | 16:58 |
| *** ijw has joined #openstack-ironic | 16:58 | |
| *** absubram has joined #openstack-ironic | 17:01 | |
| *** _lintan is now known as lintan_ | 17:01 | |
| *** jerryz has quit IRC | 17:02 | |
| *** ramineni has quit IRC | 17:03 | |
| *** ramineni has joined #openstack-ironic | 17:04 | |
| *** Marga_ has quit IRC | 17:04 | |
| lucasagomes | BadCub, so I would change it now, because the spec says that the uefi bit is not included | 17:09 |
| lucasagomes | http://specs.openstack.org/openstack/ironic-specs/specs/kilo/local-boot-support-with-partition-images.html | 17:09 |
| BadCub | lucasagomes: will change it for you now :-) | 17:10 |
| lucasagomes | wany<tab> | 17:10 |
| lucasagomes | we do have a patch for the uefi and Im confident it will merge, but as it's not part of the spec I don't think we should block it because of it | 17:10 |
| lucasagomes | https://review.openstack.org/#/c/159855/ (uefi patch) | 17:11 |
| *** yog_ has joined #openstack-ironic | 17:11 | |
| lucasagomes | BadCub, thanks much! | 17:12 |
| BadCub | lucasagomes: you are most welcome! :-) | 17:12 |
| pshige | g'night! | 17:19 |
| NobodyCam | night pshige | 17:19 |
| *** dprince has joined #openstack-ironic | 17:21 | |
| *** anderbubble_ has joined #openstack-ironic | 17:25 | |
| *** anderbubble has quit IRC | 17:27 | |
| *** anderbubble_ is now known as anderbubble | 17:27 | |
| openstackgerrit | Merged openstack/ironic: Refactor agent iscsi deploy out of pxe driver https://review.openstack.org/162408 | 17:32 |
| *** Marga_ has joined #openstack-ironic | 17:36 | |
| *** harlowja has joined #openstack-ironic | 17:40 | |
| *** harlowja_ has joined #openstack-ironic | 17:43 | |
| *** stendulker_ has quit IRC | 17:44 | |
| *** stendulker_ has joined #openstack-ironic | 17:45 | |
| *** ndipanov has quit IRC | 17:45 | |
| *** harlowja has quit IRC | 17:45 | |
| *** tiagogomes_ has quit IRC | 17:53 | |
| *** ijw has quit IRC | 17:58 | |
| *** jistr has quit IRC | 17:59 | |
| * rameshg87 goes to sleep | 18:00 | |
| rameshg87 | good night ironic | 18:00 |
| jroll | night! | 18:00 |
| *** rameshg87 has quit IRC | 18:00 | |
| lucasagomes | right folks I have to go, have a good night everyone!! | 18:00 |
| jroll | devananda: did you see my conversation with jamielennox yesterday? if not, you should read it :) | 18:00 |
| BadCub | night lucasagomes | 18:00 |
| rloo | night lucasagomes | 18:00 |
| jroll | lucasagomes: have a good one :) | 18:00 |
| lintan_ | good night guys | 18:00 |
| devananda | jroll: nope. time? | 18:00 |
| jlvillal | lucasagomes: lintan: Good night | 18:00 |
| rloo | night lintan_ | 18:00 |
| jroll | devananda: dunno, 4-5pm our time? | 18:01 |
| * BadCub will be in and out today dealing with house things. | 18:01 | |
| *** lintan_ has quit IRC | 18:01 | |
| jroll | devananda: it's the only conversation in here yesterday | 18:01 |
| *** lucasagomes is now known as lucas-dinner | 18:01 | |
| *** ramineni has quit IRC | 18:01 | |
| *** comstud has joined #openstack-ironic | 18:01 | |
| *** Haomeng|2 has joined #openstack-ironic | 18:01 | |
| devananda | k | 18:02 |
| * devananda scrolls | 18:02 | |
| *** pradipta has quit IRC | 18:03 | |
| devananda | jroll: 5) passing token to deploy -- I saw a patch to remove this need. IIRC it made all the endpoints needed by IPA and DIB's ramdisk to be publicby-default | 18:04 |
| *** Haomeng has quit IRC | 18:04 | |
| jroll | yeah, yuriy did a thing | 18:04 |
| devananda | so in general i think jamielennox is on the right path. yes, we (like many other servives) abuse keystone tokens and generate far, far too many of them | 18:05 |
| *** chlong has quit IRC | 18:05 | |
| devananda | and yes, that's terrible and should be fixed | 18:05 |
| devananda | though I thought we already had a config option for keystone user stuff .... | 18:06 |
| jroll | yeah, I'm not up to speed on everything, were hoping you might know more :) | 18:06 |
| devananda | so I'm inclined to think that we dont need new options, but perhaps we aren't using them properly. or perhaps it's not documented properly | 18:06 |
| devananda | maybe our use of that option doesn't cache hte token and so we generate lots of them | 18:06 |
| jroll | well, I think the intention was to encourage having a different user to talk to each service | 18:07 |
| devananda | I'm referring to 2,3,4 in your list, btw | 18:07 |
| devananda | erm | 18:07 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node https://review.openstack.org/155731 | 18:07 |
| devananda | that's .... different | 18:07 |
| *** jcoufal_ has quit IRC | 18:07 | |
| jroll | right | 18:07 |
| jroll | ok | 18:07 |
| devananda | I didnt get that from skimming your conversation. so in THAT case, nope, we dont have anything like that today | 18:08 |
| devananda | jroll: fixed typos on that wiki, btw | 18:09 |
| jroll | thanks | 18:10 |
| faizan | devananda: BadCub: jroll: regarding partition image support for agent driver | 18:10 |
| faizan | ironic-lib project got submitted in openstack | 18:11 |
| devananda | faizan: yup. let the refactoring begin :) | 18:12 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 18:12 |
| faizan | I have missed to include pypi-jobs in the jenkins, I have raised a review for that - https://review.openstack.org/162010 | 18:12 |
| devananda | faizan: also, it's quite late in this cycle now, so I would not anticipate landing any big changes related to ironic-lib until Liberty opens | 18:12 |
| devananda | faizan: but any preliminary work is good, and once ironic-lib is set up, you can propose and W-1 a patch back to ironic and ipa to start using it | 18:13 |
| devananda | it just shouldn't land until after Kilo is released | 18:13 |
| faizan | Also need to add .getreivew to ironic-libc along with some minor changes - https://review.openstack.org/162162 | 18:13 |
| faizan | But we can still use it in IPA, I guess and make necessary changes to ipa driver to support partition images | 18:14 |
| * devananda breaks for breakfast | 18:15 | |
| faizan | we need not refactor ironic to use ironic-lib at this stage and can take up early in L | 18:15 |
| *** penick has joined #openstack-ironic | 18:15 | |
| *** ifarkas has quit IRC | 18:16 | |
| *** ChuckC has joined #openstack-ironic | 18:17 | |
| *** hj-hp has quit IRC | 18:18 | |
| *** achanda has joined #openstack-ironic | 18:18 | |
| *** achanda has quit IRC | 18:19 | |
| *** achanda has joined #openstack-ironic | 18:19 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 18:21 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 18:23 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 18:23 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Enable uefi boot mode for agent_ilo driver https://review.openstack.org/162043 | 18:24 |
| *** stendulker_ has quit IRC | 18:31 | |
| openstackgerrit | Clif Houck proposed openstack/ironic: Added support for image caching for the agent driver https://review.openstack.org/161832 | 18:31 |
| *** mgagne is now known as mgagne_PHL | 18:42 | |
| *** penick has quit IRC | 18:47 | |
| *** penick has joined #openstack-ironic | 18:48 | |
| *** pelix has quit IRC | 18:53 | |
| *** jrist has quit IRC | 19:01 | |
| *** spandhe has joined #openstack-ironic | 19:01 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: WIP: oslo.log https://review.openstack.org/162600 | 19:02 |
| *** ijw has joined #openstack-ironic | 19:11 | |
| *** jrist has joined #openstack-ironic | 19:14 | |
| *** jmccrory has quit IRC | 19:19 | |
| *** erwan_taf has joined #openstack-ironic | 19:42 | |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed openstack/ironic: Add support for partition images in agent driver https://review.openstack.org/162008 | 19:49 |
| *** achanda has quit IRC | 19:49 | |
| *** athomas has quit IRC | 19:50 | |
| *** jmccrory has joined #openstack-ironic | 19:56 | |
| *** kkoski has quit IRC | 19:58 | |
| *** athomas has joined #openstack-ironic | 19:59 | |
| *** athomas has quit IRC | 19:59 | |
| *** athomas has joined #openstack-ironic | 20:00 | |
| *** kkoski has joined #openstack-ironic | 20:01 | |
| *** achanda has joined #openstack-ironic | 20:01 | |
| *** kkoski1 has joined #openstack-ironic | 20:01 | |
| *** kkoski has quit IRC | 20:01 | |
| *** faizan has quit IRC | 20:04 | |
| *** ndipanov has joined #openstack-ironic | 20:08 | |
| *** erwan_taf has quit IRC | 20:10 | |
| *** achanda has quit IRC | 20:11 | |
| *** achanda has joined #openstack-ironic | 20:14 | |
| *** dprince has quit IRC | 20:15 | |
| *** penick has quit IRC | 20:15 | |
| *** andreykurilin_ has quit IRC | 20:16 | |
| *** andreykurilin_ has joined #openstack-ironic | 20:17 | |
| *** kkoski1 has quit IRC | 20:23 | |
| *** penick has joined #openstack-ironic | 20:24 | |
| *** kkoski has joined #openstack-ironic | 20:24 | |
| *** gridinv has joined #openstack-ironic | 20:27 | |
| *** achanda has quit IRC | 20:28 | |
| *** Nisha has quit IRC | 20:28 | |
| *** Nisha has joined #openstack-ironic | 20:31 | |
| *** igordcard has joined #openstack-ironic | 20:33 | |
| openstackgerrit | Adam Gandelman proposed openstack/python-ironicclient: Adds basic ironicclient functional testing https://review.openstack.org/161976 | 20:34 |
| *** achanda has joined #openstack-ironic | 20:38 | |
| openstackgerrit | Adam Gandelman proposed openstack/python-ironicclient: Adds basic ironicclient functional testing https://review.openstack.org/161976 | 20:44 |
| mrda | Morning Ironic | 20:45 |
| *** Nisha_away has joined #openstack-ironic | 20:48 | |
| devananda | g'morning, mrda | 20:49 |
| mrda | hey devananda - just reading backlog from the meeting today re: microversions. Thanks for bringing that up as discussion. | 20:49 |
| devananda | certainly | 20:50 |
| devananda | there's also a little chatter on the ML | 20:50 |
| * mrda goes looking | 20:50 | |
| mrda | I can see the nova discussion on microversions | 20:51 |
| mrda | oh, and python client ux discussion | 20:51 |
| *** Nisha has quit IRC | 20:52 | |
| *** gridinv has quit IRC | 20:52 | |
| devananda | yah | 20:52 |
| mrda | I'll spend some time going thorugh all that this morning | 20:55 |
| *** penick has quit IRC | 20:55 | |
| rloo | hi mrda. did you want me to add comments to the spec about me being ok with defaulting to some max version? | 20:56 |
| rloo | mrda: or just update it and my -1 will disappear | 20:56 |
| mrda | rloo: I don't mind, tbh. If you want to update.... feel free. | 20:56 |
| mrda | I've had a long weekend, so need to catch up with all that's going on (it was my birthday :) | 20:57 |
| rloo | mrda: i don't want to update although I feel like i ought to. i'll comment on your next version then ;) | 20:57 |
| mrda | ok | 20:57 |
| devananda | rloo: even a tiny note on the spec might be helpful for later referencing ? | 20:57 |
| mrda | rloo: even if you add what you want where as a comment | 20:57 |
| mrda | then I can update and reissue today | 20:58 |
| rloo | devananda, mrda: i'll add a comment. well, let me see where my comments are. give me 5. | 20:58 |
| mrda | So can I get a sense of a tl;dr for this? Do you want to land the spec and code for K? | 20:59 |
| mrda | Or is the proposed client work too expansive? | 21:00 |
| mrda | your thoughts devananda and rloo? | 21:00 |
| rloo | mrda: yes, we need to do something in K (I mean, in code) and so yes, we should land the spec if we can. | 21:00 |
| mrda | ok, thanks | 21:01 |
| *** ijw has quit IRC | 21:04 | |
| *** ijw has joined #openstack-ironic | 21:07 | |
| *** kkoski has quit IRC | 21:07 | |
| *** kkoski has joined #openstack-ironic | 21:09 | |
| *** kkoski has quit IRC | 21:10 | |
| *** kkoski has joined #openstack-ironic | 21:10 | |
| *** Nisha_away has quit IRC | 21:11 | |
| *** jcoufal has joined #openstack-ironic | 21:17 | |
| *** jxiaobin_ has joined #openstack-ironic | 21:18 | |
| *** yog_ has quit IRC | 21:24 | |
| jamielennox | devananda, jroll: i'm here if you have any ideas | 21:26 |
| *** penick has joined #openstack-ironic | 21:29 | |
| *** ChuckC has quit IRC | 21:31 | |
| *** chlong has joined #openstack-ironic | 21:45 | |
| *** achanda has quit IRC | 21:48 | |
| *** achanda has joined #openstack-ironic | 21:52 | |
| *** chlong has quit IRC | 21:57 | |
| *** chlong has joined #openstack-ironic | 21:57 | |
| *** kkoski has quit IRC | 21:59 | |
| *** ChuckC has joined #openstack-ironic | 22:02 | |
| *** ijw has quit IRC | 22:02 | |
| *** ijw has joined #openstack-ironic | 22:03 | |
| *** chlong has quit IRC | 22:04 | |
| *** jcoufal has quit IRC | 22:09 | |
| *** ijw has quit IRC | 22:11 | |
| *** andreykurilin_ has quit IRC | 22:11 | |
| *** andreykurilin_ has joined #openstack-ironic | 22:11 | |
| *** ijw has joined #openstack-ironic | 22:11 | |
| *** jgrimm is now known as zz_jgrimm | 22:15 | |
| *** ChuckC has quit IRC | 22:16 | |
| devananda | adam_g: so I didn't finish my POC yet for functional testing sans keystone | 22:22 |
| devananda | adam_g: is it clear how that'd be done // is it worthwhile for me to post it? | 22:23 |
| *** openstack has joined #openstack-ironic | 22:25 | |
| *** romcheg has quit IRC | 22:26 | |
| *** anderbubble has quit IRC | 22:26 | |
| *** romcheg has joined #openstack-ironic | 22:26 | |
| *** romcheg has quit IRC | 22:27 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_log lib https://review.openstack.org/157602 | 22:33 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Sync from oslo.incubator https://review.openstack.org/162505 | 22:33 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_policy package https://review.openstack.org/162501 | 22:33 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use strutils from oslo_utils https://review.openstack.org/162497 | 22:33 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_context package https://review.openstack.org/162499 | 22:33 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/161811 | 22:42 |
| *** lucas-dinner has quit IRC | 22:52 | |
| *** Marga_ has quit IRC | 23:01 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic-python-agent: Use oslo_log lib https://review.openstack.org/162790 | 23:02 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic-python-agent: Sync from oslo.incubator https://review.openstack.org/162791 | 23:02 |
| *** penick has quit IRC | 23:04 | |
| *** jerryz has joined #openstack-ironic | 23:04 | |
| *** penick has joined #openstack-ironic | 23:09 | |
| *** ChuckC has joined #openstack-ironic | 23:12 | |
| *** ijw has quit IRC | 23:12 | |
| pshige | good morning! | 23:12 |
| devananda | morning | 23:12 |
| devananda | jamielennox: hi there! I'm sorta here if you have thoughts to bounce off me | 23:12 |
| *** ijw has joined #openstack-ironic | 23:13 | |
| *** ijw has quit IRC | 23:14 | |
| jamielennox | devananda: so it feels to me like we should be using the user token catalog for this stuff rather than the auth_token catalog, do you know if there was a reason for this? | 23:14 |
| *** ijw has joined #openstack-ironic | 23:15 | |
| jamielennox | devananda: also i'm wondering how much i should look at changing - particularly given we're getting close to k3 | 23:15 |
| jamielennox | i can quickly add auth to the [keystone] section which solves the immediate problem, but leaves ironic with the same over generation of tokens | 23:15 |
| devananda | jamielennox: at the moment, i'm not recalling what the user_token catalog is | 23:16 |
| devananda | *is for, or how it would address this | 23:16 |
| jamielennox | devananda: so by that i mean the catalog that is attached to the token that the user is presenting | 23:16 |
| devananda | jamielennox: so there are many operations that occur where there is no user | 23:17 |
| jamielennox | at the moment ironic is taking authenticating (again) the auth_token user (the one that we use for token validation) and using that catalog | 23:17 |
| devananda | jamielennox: ie, ironic-conductor autonomously takes an action and requests another service t odo something | 23:17 |
| *** Marga_ has joined #openstack-ironic | 23:17 | |
| *** Marga_ has quit IRC | 23:18 | |
| devananda | jamielennox: ditto for nova -- it sometimes calls ironc on behalf of a user, and sometimes on behalf of a periodic task | 23:18 |
| *** yuanying has joined #openstack-ironic | 23:18 | |
| jroll | I don't believe nova ever calls ironic on behalf of a user | 23:19 |
| jroll | maybe as a result of a user request | 23:19 |
| jamielennox | right, i know nova has it's own user that it sometimes does things as | 23:19 |
| jroll | but it's always an admin token, never a user token | 23:19 |
| devananda | hm. that's what i mean | 23:19 |
| devananda | "in direct response to a user's request" | 23:19 |
| jamielennox | is there a permissions reason why this shouldn't use trusts? | 23:19 |
| jroll | k | 23:19 |
| devananda | jroll: the nova.virt.ironic driver uses this call: nova_context.get_admin_context() | 23:20 |
| devananda | jamielennox: trusts? | 23:20 |
| jamielennox | lol - i thought that might have been the answer there as well | 23:21 |
| devananda | jamielennox: is that a keystone v3 thing? (sorry, haven't followed v3 closely enough) | 23:21 |
| jroll | that's where a service gets a user token on behalf of the user, no? | 23:21 |
| jamielennox | essentially allow a user to delegate certain roles to another user, heat is the primary use where heat has to spin up vms and do things on behalf of a user long after the user left | 23:21 |
| jamielennox | jroll: more or less | 23:22 |
| devananda | ah. so aiui that, there's a really good reason for this | 23:22 |
| devananda | most users of a cloud should NOT have access to ironic | 23:22 |
| devananda | thus they can't delegate trust to Nova | 23:22 |
| jamielennox | the difference is the token is on behalf of the user and ownership of objects belongs, rather than the service user | 23:22 |
| jamielennox | ok | 23:22 |
| jroll | nor most of the things ironic does, e.g. configure dhcp | 23:23 |
| jroll | (I think) | 23:23 |
| devananda | jamielennox: so, ironic doesn't record tenant, owner, etc, of resources | 23:23 |
| devananda | all of thta is done by nova | 23:23 |
| *** openstack has joined #openstack-ironic | 23:25 | |
| *** oomichi has joined #openstack-ironic | 23:25 | |
| devananda | jamielennox: sorry, I'm still missing something. at what point does nova provide a catalog to ironic? | 23:25 |
| jamielennox | or even reuse the service catalog that the ironic user got? | 23:25 |
| jamielennox | so tokens should all come with a catalog, this is all handled by the auth_token middleware | 23:26 |
| devananda | ahhh | 23:26 |
| devananda | didn't know that | 23:26 |
| jamielennox | if you look at https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L63 | 23:26 |
| devananda | so - yes - and that'll help any calls that have the nova-supplied context | 23:27 |
| jamielennox | there is a whole list of things that auth_token middleware adds to each request | 23:27 |
| jamielennox | https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L128 is the catalog | 23:27 |
| jamielennox | but depending on the version there are other ways | 23:27 |
| jamielennox | https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L172 being preferred | 23:27 |
| jamielennox | because then you don't need to rebuild a plugin at all you just pass it to the next client you are going to call | 23:28 |
| *** igordcard has quit IRC | 23:29 | |
| *** igordcard has joined #openstack-ironic | 23:31 | |
| devananda | ok - so doing that in places where we can sounds good | 23:32 |
| jamielennox | i think so, it's a whole lot more work than the basic replace though :) | 23:35 |
| *** chlong has joined #openstack-ironic | 23:43 | |
| openstackgerrit | Ghe Rivero proposed openstack/python-ironicclient: Use oslo.i18n lib https://review.openstack.org/162797 | 23:44 |
| openstackgerrit | Ghe Rivero proposed openstack/python-ironicclient: Use oslo.i18n lib https://review.openstack.org/162797 | 23:47 |
| openstackgerrit | Ghe Rivero proposed openstack/python-ironicclient: Clean openstack-common module list https://review.openstack.org/162799 | 23:47 |
| devananda | jamielennox: in all the other places (ie, where periodic tasks, or service startup, are triggering ironic to call other services) how would we improve this? | 23:49 |
| *** igordcard has quit IRC | 23:49 | |
| devananda | jamielennox: generate the token, cache it $somewhere, and regenerate on demand? | 23:49 |
| jamielennox | devananda: essentially yes, just caching should speed things up | 23:49 |
| jamielennox | there's only two places i've come across so far where you do auth | 23:50 |
| jamielennox | talking to neutron, and i've got a patch up there: https://review.openstack.org/#/c/162037/ | 23:50 |
| jamielennox | and in the common/keystone stuff | 23:50 |
| devananda | fetching an image from glance | 23:51 |
| *** igordcard has joined #openstack-ironic | 23:52 | |
| jamielennox | in glance you are reusing the user (nova) token: https://github.com/openstack/ironic/blob/master/ironic/common/glance_service/base_image_service.py#L83 | 23:53 |
| jamielennox | you should probably use the catalog there as well rather than get a URL from the CONF file - but you're not the only service making that mistake | 23:53 |
| openstackgerrit | Ghe Rivero proposed openstack/python-ironicclient: Sync oslo.incubator https://review.openstack.org/162806 | 23:54 |
| jamielennox | devananda: i think even a good start (and what would fix my problem) is that we re-use the same 'ironic' user and authentication between the dhcp stuff and the keystone common | 23:55 |
| devananda | that usually has a nova context passed in (eg, from nova boot) but it can also be triggered from take_over | 23:56 |
| devananda | also - yes, we should not have URLs for that in the config file | 23:56 |
| devananda | if glance is present, one should assume keystone is present - and just get the catalog | 23:56 |
| jroll | devananda: I (unfortunately) don't trust my service catalog and would be -1 to that change | 23:58 |
| jroll | it's probably fine but I honestly have no idea | 23:59 |
| jroll | and I know that's not ironic's problem but... | 23:59 |
| devananda | jroll: your service catalog is lame | 23:59 |
| jroll | yes. | 23:59 |
| jroll | it is. | 23:59 |
| devananda | someone should fix it :( | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!