openstackgerrit | Roman Prykhodchenko proposed openstack/ironic: Refactoring for Ironic policy https://review.openstack.org/126265 | 00:02 |
---|---|---|
*** naohirot has joined #openstack-ironic | 00:02 | |
*** ChuckC has joined #openstack-ironic | 00:03 | |
JayF | JoshNang: AttributeError: 'FakeIPMIToolDriver' object has no attribute 'ipmi_vendor' | 00:09 |
JayF | JoshNang: I think I'll have to just factor out the vendor_passthru method to a private method, and call it from both places | 00:10 |
JoshNang | hmm | 00:12 |
JoshNang | that'd probably work | 00:12 |
JoshNang | hey ironic, how would you feel about a soft delete for nodes? so if, for example, someone was working late and confused "ironic node-delete" with "ironic node-set-provision-state deleted", they could just call "ironic node-undelete" instead of recreating the node? :) | 00:15 |
*** romcheg has joined #openstack-ironic | 00:21 | |
*** romcheg has left #openstack-ironic | 00:22 | |
*** Marga_ has quit IRC | 00:27 | |
NobodyCam | JoshNang: so some would then have to issue a now-really-delete the node I already ask you to delete? | 00:27 |
NobodyCam | s/some/someone/ | 00:28 |
JayF | NobodyCam: more like update nodes set deleted=sure_im_deleted; | 00:28 |
JayF | NobodyCam: and then an operator could undo it via the db (or via the API, if we chose to expose it) | 00:28 |
NobodyCam | but I can see by the why you asked the question it is comming from a RLC | 00:28 |
JayF | RLC? | 00:28 |
NobodyCam | real life case | 00:29 |
JayF | I don't think we said that, exactly ;) | 00:29 |
JayF | I will say it's a mistake I've almost-made a couple of times | 00:29 |
NobodyCam | lol | 00:29 |
JayF | delete is another overloaded word :/ | 00:29 |
NobodyCam | my concern is we could end up with a bounch of nodes that are deleted waiting to be removed. | 00:31 |
*** david-lyle is now known as david-lyle_afk | 00:31 | |
NobodyCam | but let me think on it. | 00:31 |
NobodyCam | brb | 00:31 |
JayF | NobodyCam: I think you misunderstand | 00:33 |
JayF | NobodyCam: soft delete as in what nova does with instances; just mark them as deleted but don't kill all the data | 00:33 |
JoshNang | ^ | 00:33 |
JayF | NobodyCam: so as far as ironic is concerned it'd already be "removed", just operators who have large quantites of nodes cycling in and out (unlikely; this is difficult logistically) might need to run a cleanup job to get rid of soft deleted entries | 00:34 |
JoshNang | JayF: do you know how the actual db rows get removed in nova's case? manual db query? | 00:35 |
JayF | Probably. | 00:35 |
JoshNang | which, like you said, shouldn't be a huge problem | 00:35 |
JoshNang | considering nova's creating/deleting a lot more nodes than we should be | 00:38 |
NobodyCam | back.. had to help bring stuff from the car | 00:39 |
JoshNang | no worries | 00:39 |
JayF | JoshNang: instances for nova | 00:40 |
JayF | gotta call instances instances and nodes nodes | 00:40 |
JayF | or else my head explodes with confusion | 00:40 |
JoshNang | heh good call | 00:41 |
NobodyCam | ++ | 00:41 |
openstackgerrit | Jay Faulkner proposed openstack/ironic: Disable IPMI timeout before setting boot device https://review.openstack.org/134413 | 00:45 |
JayF | JoshNang: ^ rfr? | 00:45 |
openstackgerrit | Roman Prykhodchenko proposed openstack/ironic: Reuse stuff from OSLO's RequestContext https://review.openstack.org/134414 | 00:47 |
JoshNang | JayF: done | 00:50 |
JoshNang | yay upstreaming! | 00:51 |
*** david-lyle_afk has quit IRC | 01:08 | |
*** achanda_ has quit IRC | 01:09 | |
*** Viswanath has joined #openstack-ironic | 01:09 | |
*** Viswanath has quit IRC | 01:12 | |
*** achanda has joined #openstack-ironic | 01:15 | |
*** rwsu has quit IRC | 01:18 | |
*** chenglch has joined #openstack-ironic | 01:25 | |
*** ChuckC has quit IRC | 01:33 | |
*** marcoemorais has quit IRC | 01:37 | |
*** marcoemorais has joined #openstack-ironic | 01:37 | |
*** nosnos has joined #openstack-ironic | 01:43 | |
*** krtaylor has quit IRC | 01:44 | |
*** chenglch has quit IRC | 01:47 | |
*** krtaylor has joined #openstack-ironic | 01:56 | |
*** ChuckC has joined #openstack-ironic | 02:01 | |
*** chenglch|2 has joined #openstack-ironic | 02:03 | |
*** dlaube has quit IRC | 02:03 | |
*** annegentle has quit IRC | 02:10 | |
*** aswadr has joined #openstack-ironic | 02:13 | |
*** marcoemorais has quit IRC | 02:16 | |
*** rloo has quit IRC | 02:19 | |
*** eglute_ has quit IRC | 02:48 | |
openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Improve docstrings for cmd/agent.py https://review.openstack.org/120662 | 03:13 |
*** achanda has quit IRC | 03:21 | |
openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Improve/add docstrings for CommandResult classes https://review.openstack.org/120663 | 03:24 |
openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Improve docstrings for cmd/agent.py https://review.openstack.org/120662 | 03:24 |
*** naohirot has quit IRC | 03:26 | |
*** nosnos has quit IRC | 03:30 | |
*** nosnos has joined #openstack-ironic | 03:30 | |
*** nosnos has quit IRC | 03:35 | |
*** coolsvap has quit IRC | 03:43 | |
*** wendar has quit IRC | 03:45 | |
*** d0ugal has quit IRC | 03:45 | |
*** wendar has joined #openstack-ironic | 03:45 | |
*** anteaya has quit IRC | 03:46 | |
*** dvorak has quit IRC | 03:46 | |
*** dvorak has joined #openstack-ironic | 03:47 | |
*** d0ugal has joined #openstack-ironic | 03:48 | |
*** d0ugal is now known as Guest32556 | 03:48 | |
*** anteaya has joined #openstack-ironic | 03:49 | |
*** coolsvap has joined #openstack-ironic | 03:49 | |
JayF | Just put this up, would like everyone's opinion on it: https://review.openstack.org/#/c/134436/ | 03:51 |
*** pcrews has quit IRC | 03:55 | |
*** naohirot has joined #openstack-ironic | 04:00 | |
*** pcrews has joined #openstack-ironic | 04:05 | |
*** ryanpetrello has joined #openstack-ironic | 04:06 | |
JayF | also https://review.openstack.org/#/c/134438/1 to try and get agent_ssh jobs passing against IPA builds | 04:06 |
*** ryanpetrello has quit IRC | 04:13 | |
*** pcrews has quit IRC | 04:16 | |
*** ryanpetrello has joined #openstack-ironic | 04:18 | |
*** achanda has joined #openstack-ironic | 04:21 | |
*** achanda_ has joined #openstack-ironic | 04:24 | |
*** achanda has quit IRC | 04:24 | |
*** nosnos has joined #openstack-ironic | 04:27 | |
*** ryanpetrello has quit IRC | 04:28 | |
*** lazy_prince is now known as killer_prince | 04:28 | |
openstackgerrit | Michael Davies proposed openstack/ironic-specs: Proposal to add logical names to Ironic nodes https://review.openstack.org/134439 | 04:29 |
*** Haomeng has quit IRC | 04:34 | |
*** yuanying has quit IRC | 04:43 | |
*** spandhe has quit IRC | 04:47 | |
*** krtaylor has quit IRC | 04:59 | |
*** rushiagr_away is now known as rushiagr | 05:07 | |
*** pensu has joined #openstack-ironic | 05:10 | |
*** krtaylor has joined #openstack-ironic | 05:13 | |
*** loki has joined #openstack-ironic | 05:15 | |
*** loki is now known as Guest60114 | 05:15 | |
*** killer_prince has quit IRC | 05:17 | |
*** lazy_prince has joined #openstack-ironic | 05:17 | |
*** rakesh_hs has joined #openstack-ironic | 05:27 | |
*** pradipta_away is now known as pradipta | 05:31 | |
*** achanda_ has quit IRC | 05:39 | |
*** Haomeng has joined #openstack-ironic | 05:47 | |
*** lazy_prince is now known as killer_prince | 05:51 | |
*** marcoemorais has joined #openstack-ironic | 06:04 | |
*** marcoemorais1 has joined #openstack-ironic | 06:05 | |
*** marcoemorais has quit IRC | 06:08 | |
openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Discover node properties using new CLI node-discover-properties https://review.openstack.org/100951 | 06:17 |
*** anderbubble has joined #openstack-ironic | 06:17 | |
*** killer_prince is now known as lazy_prince | 06:20 | |
openstackgerrit | Sirushti Murugesan proposed openstack/ironic-specs: Whole Disk Image Support for PXE Deploy Driver https://review.openstack.org/97150 | 06:26 |
*** mrda is now known as mrda_away | 06:34 | |
mrda_away | Night Ironic :) | 06:35 |
*** achanda has joined #openstack-ironic | 06:39 | |
Haomeng | mrda_away: night:) | 06:40 |
*** anderbubble has quit IRC | 06:41 | |
*** achanda has quit IRC | 06:45 | |
*** Haomeng has quit IRC | 06:51 | |
*** subscope has joined #openstack-ironic | 06:57 | |
*** Guest60114 has quit IRC | 07:03 | |
*** loki184 has joined #openstack-ironic | 07:03 | |
*** k4n0 has joined #openstack-ironic | 07:08 | |
*** Haomeng has joined #openstack-ironic | 07:28 | |
*** dlpartain has joined #openstack-ironic | 07:29 | |
*** aswadr has quit IRC | 07:30 | |
*** Haomeng has quit IRC | 07:34 | |
*** achanda has joined #openstack-ironic | 07:41 | |
*** achanda has quit IRC | 07:46 | |
*** Haomeng has joined #openstack-ironic | 08:00 | |
*** nosnos has quit IRC | 08:00 | |
*** nosnos has joined #openstack-ironic | 08:03 | |
*** dtantsur|afk is now known as dtantsur | 08:05 | |
dtantsur | Morning Ironic | 08:05 |
*** ifarkas has joined #openstack-ironic | 08:18 | |
*** jcoufal has joined #openstack-ironic | 08:22 | |
*** romcheg1 has joined #openstack-ironic | 08:38 | |
*** romcheg has joined #openstack-ironic | 08:38 | |
*** rakesh_hs2 has joined #openstack-ironic | 08:39 | |
*** rakesh_hs has quit IRC | 08:40 | |
yuriyz | morning all and Ironic | 08:41 |
*** achanda has joined #openstack-ironic | 08:42 | |
*** romcheg has quit IRC | 08:43 | |
*** romcheg1 has quit IRC | 08:43 | |
*** achanda has quit IRC | 08:47 | |
*** pradipta is now known as pradipta_away | 08:49 | |
*** ndipanov_gone is now known as ndipanov | 08:50 | |
*** dtantsur is now known as dtantsur|study | 08:52 | |
*** romcheg has joined #openstack-ironic | 08:54 | |
*** dlpartain has quit IRC | 08:55 | |
*** rakesh_hs2 has quit IRC | 08:56 | |
*** rakesh_hs has joined #openstack-ironic | 08:57 | |
*** achanda has joined #openstack-ironic | 08:58 | |
*** viktors|afk is now known as viktors | 09:08 | |
*** leopoldj has joined #openstack-ironic | 09:08 | |
*** achanda has quit IRC | 09:10 | |
*** chenglch|2 has quit IRC | 09:13 | |
*** chenglch has joined #openstack-ironic | 09:13 | |
*** jistr has joined #openstack-ironic | 09:19 | |
*** derekh has joined #openstack-ironic | 09:24 | |
*** lucasagomes has joined #openstack-ironic | 09:28 | |
*** aswadr has joined #openstack-ironic | 09:37 | |
*** lazy_prince is now known as killer_prince | 09:40 | |
*** MattMan has quit IRC | 09:41 | |
*** MattMan has joined #openstack-ironic | 09:42 | |
*** athomas has joined #openstack-ironic | 09:44 | |
Haomeng | one question, if we have chef cookbook for our ironic installation? | 09:51 |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Update iLO driver documentation https://review.openstack.org/134144 | 10:01 |
*** subscope has quit IRC | 10:02 | |
*** chenglch has quit IRC | 10:02 | |
openstackgerrit | Naohiro Tamura proposed openstack/ironic-specs: iRMC Power Driver for Ironic https://review.openstack.org/134486 | 10:03 |
openstackgerrit | Naohiro Tamura proposed openstack/ironic-specs: iRMC Power Driver for Ironic https://review.openstack.org/134487 | 10:03 |
naohirot | Haomeng: Hi | 10:05 |
naohirot | Haomeng: I made a mistake about branch name to submit the spec above. | 10:07 |
naohirot | Haomeng: Is it possible to cancel the above, and resubmit? | 10:08 |
naohirot | Haomeng: maybe you are busy. could anyone know how to do it? | 10:09 |
naohirot | lucasagomes: Hi | 10:11 |
lucasagomes | naohirot, good morning | 10:13 |
naohirot | lucasagomes: Oh hi, good morning | 10:13 |
*** Guest32556 is now known as d0ugal | 10:14 | |
Haomeng | naohirot: sure | 10:14 |
naohirot | lucasagomes: could you help me a little regarding the spec review request above? | 10:14 |
Haomeng | naohirot: which patch? | 10:14 |
lucasagomes | naohirot, sure... I see you submitted 2 patches :) | 10:14 |
*** d0ugal is now known as Guest92455 | 10:14 | |
lucasagomes | naohirot, you can abandon one of them | 10:14 |
Haomeng | naohirot: yes, just cancel one of them, dont worry | 10:14 |
lucasagomes | naohirot, when submitting another one, you should keep the "Change-Id" flag in the commit message intact | 10:15 |
lucasagomes | so it will just be another patch-set in gerrit | 10:15 |
lucasagomes | naohirot, here's a good guideline https://wiki.openstack.org/wiki/Gerrit_Workflow | 10:15 |
*** Guest92455 is now known as d0ugal | 10:16 | |
naohirot | lucasagomes: I didn't know that two review went to the server. I thought I could cancel the first one. | 10:16 |
*** d0ugal has quit IRC | 10:16 | |
*** d0ugal has joined #openstack-ironic | 10:16 | |
lucasagomes | naohirot, yeah you can abandon it | 10:16 |
naohirot | lucasagomes: But what I made mistake is that branch name. | 10:16 |
lucasagomes | naohirot, btw, on ur git log | 10:16 |
lucasagomes | does it show two reviews? | 10:17 |
lucasagomes | if so, you may want to squash them into one | 10:17 |
lucasagomes | (you can do it via git rebase) | 10:17 |
Haomeng | naohirot: your branch name is master, it should be ok I think | 10:17 |
naohirot | lucasagomes: Okay there are two review request, 134486 and 134487. | 10:19 |
naohirot | lucasagomes: I'd like to both cancel. | 10:20 |
lucasagomes | naohirot, right. So in the reviews you have a "abandon" button | 10:20 |
lucasagomes | you can click there to abandon the reviews | 10:20 |
Haomeng | naohirot: add the comments already:) | 10:21 |
naohirot | lucasagomes: Okay, I found the abandon button, so I'll do that. | 10:21 |
naohirot | Haomeng: really? | 10:22 |
Haomeng | naohirot: yes, only one with commit message, you can take care with next patch if more change is required | 10:23 |
*** sambetts has joined #openstack-ironic | 10:23 | |
Haomeng | lucasagomes: morning:) | 10:23 |
lucasagomes | Haomeng, good morning | 10:23 |
Haomeng | lucasagomes: do you know we have chef cookbook for our ironic installation? | 10:23 |
Haomeng | lucasagomes: I checked, looks like no ironic cookbook | 10:23 |
lucasagomes | Haomeng, not that I know... devananda was working on some ansible stuff for Ironic IIRC | 10:24 |
lucasagomes | and I know there's some puppet modules | 10:24 |
lucasagomes | Haomeng, but chef I've no idea :/ | 10:24 |
naohirot | Haomeng: I believe my branch bp/irmc-power-driver. | 10:25 |
Haomeng | lucasagomes: ok, thank you | 10:25 |
Haomeng | naohirot: looks like we can not change branch for existing changes I think | 10:26 |
Haomeng | naohirot: master should be ok, but can not commit more code with your master branch env if current patch is not merged | 10:26 |
Haomeng | lucasagomes: ok, will check with deva:) | 10:27 |
Haomeng | lucasagomes: nice day:) | 10:27 |
Haomeng | naohirot: so dont care about branch | 10:27 |
naohirot | Haomeng: Okay, so my branch is okay, I abandon the first one. | 10:27 |
Haomeng | naohirot: the action you need is as lucas guideline, just abandon one of them | 10:28 |
Haomeng | naohirot: ok | 10:28 |
naohirot | Haomeng: I have another question. | 10:28 |
naohirot | Haomeng: I submitted 4 blue prints. then all of 4 blue prints pint to the spec I just submitted. | 10:29 |
Haomeng | naohirot: welcome | 10:29 |
naohirot | Haomeng: As you can see https://review.openstack.org/#/c/134487/ | 10:29 |
Haomeng | naohirot: one spec? | 10:29 |
Haomeng | naohirot: in theory, one bp has one spec, and have multi patch | 10:30 |
naohirot | Haomeng: Commit message in the page, only the first blue print have hyper link. | 10:30 |
Haomeng | naohirot: but if your one spec can cover all 4 bps, it shoud be ok with me, but need more reviewer comments | 10:30 |
naohirot | Haomeng: The structure is like this: | 10:31 |
Haomeng | naohirot: if we put multi message with bp names with multi-lines, it just have link for firt one? | 10:31 |
naohirot | Haomeng: My blue prints are pxe_irmc, agent_irmc, nfs_irmc, cifs_irmc. | 10:32 |
Haomeng | naohirot: i think the *blueprint* is thekey word for render to set hyper link | 10:32 |
sambetts | Good morning lucasagomes | 10:32 |
*** foexle has joined #openstack-ironic | 10:32 | |
naohirot | Haomeng: all of 4 drivers refer to the same iRMC power module which I just submitted. | 10:33 |
Haomeng | naohirot: it should be ok with me, but need other comments | 10:33 |
Haomeng | naohirot: so dont worry about | 10:33 |
Haomeng | naohirot: more comments you will get | 10:33 |
lucasagomes | sambetts, yo morning | 10:34 |
Haomeng | naohirot: just take no action now, to see more comments and change them once time | 10:34 |
naohirot | Haomeng: Okay, I relieved :-) | 10:34 |
Haomeng | naohirot: :) | 10:34 |
Haomeng | naohirot: dont worry | 10:34 |
Haomeng | naohirot: the review process can help us to follow the correct direction | 10:35 |
Haomeng | naohirot: :) | 10:35 |
Haomeng | naohirot: good luck and nice day:) | 10:35 |
Haomeng | naohirot: I will go home:) | 10:35 |
naohirot | Haomeng: I just pushed the abandon button. | 10:35 |
Haomeng | nice Fri and enjoy weekend, ironic:) | 10:35 |
naohirot | Haomeng: thanks for your help, good night. | 10:36 |
Haomeng | naohirot: ok, it is abandoned? | 10:36 |
Haomeng | naohirot: welcome, anytime:) | 10:36 |
naohirot | Haomeng: Yes, my type miss :) | 10:36 |
naohirot | lucasagomes: thanks too. | 10:36 |
Haomeng | naohirot: dont worry, np, yw | 10:37 |
Haomeng | naohirot: :) | 10:37 |
lucasagomes | naohirot, yvw | 10:37 |
*** pelix has joined #openstack-ironic | 10:40 | |
*** nosnos has quit IRC | 10:43 | |
openstackgerrit | Roman Prykhodchenko proposed openstack/ironic: Reuse stuff from OSLO's RequestContext https://review.openstack.org/134414 | 10:45 |
*** nosnos has joined #openstack-ironic | 10:51 | |
*** marcoemorais1 has quit IRC | 11:01 | |
openstackgerrit | Harshada Mangesh Kakad proposed openstack/ironic: Add serial console feature to seamicro driver https://review.openstack.org/132628 | 11:07 |
*** loki184 has quit IRC | 11:10 | |
*** killer_prince is now known as lazy_prince | 11:15 | |
*** Madkiss has quit IRC | 11:21 | |
*** subscope has joined #openstack-ironic | 11:30 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Make vendor methods discoverable via the Ironic API https://review.openstack.org/133533 | 11:33 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Vendor endpoints to support different HTTP methods https://review.openstack.org/129942 | 11:33 |
*** pensu has quit IRC | 11:43 | |
*** lazy_prince is now known as killer_prince | 11:51 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/python-ironicclient: VendorPassthru commands to support different HTTP methods https://review.openstack.org/134253 | 11:56 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/python-ironicclient: Sane parameters for node and driver vendor_passthru() https://review.openstack.org/133780 | 11:56 |
*** naohirot has quit IRC | 11:58 | |
*** ndipanov_ has joined #openstack-ironic | 12:04 | |
*** ndipanov has quit IRC | 12:05 | |
*** achanda has joined #openstack-ironic | 12:11 | |
*** achanda has quit IRC | 12:16 | |
*** nosnos has quit IRC | 12:33 | |
*** dprince has joined #openstack-ironic | 12:41 | |
*** dtantsur|study is now known as dtantsur | 12:41 | |
*** lucasagomes is now known as lucas-hungry | 12:44 | |
* NobodyCam wishes he was sleeping.. but at least its Friday... TGIF | 12:58 | |
*** pensu has joined #openstack-ironic | 13:01 | |
*** russellb is now known as rustlebee | 13:02 | |
*** ndipanov_ has quit IRC | 13:02 | |
dtantsur | NobodyCam, TGIF and good.. hmm.. morning | 13:03 |
NobodyCam | lol .... good morning dtantsur :) | 13:04 |
*** rushiagr is now known as rushiagr_away | 13:08 | |
*** naohirot has joined #openstack-ironic | 13:14 | |
*** ndipanov_ has joined #openstack-ironic | 13:15 | |
*** killer_prince has quit IRC | 13:18 | |
*** ryanpetrello has joined #openstack-ironic | 13:20 | |
NobodyCam | lucas-hungry: ... 134066 landing | 13:26 |
*** killer_prince has joined #openstack-ironic | 13:27 | |
*** killer_prince is now known as lazy_prince | 13:27 | |
openstackgerrit | Merged openstack/ironic-specs: Adjust the extended-vendor-passthru spec https://review.openstack.org/134066 | 13:27 |
lucas-hungry | NobodyCam, morning \o/ yush thanksss | 13:28 |
*** lucas-hungry is now known as lucasagomes | 13:28 | |
lucasagomes | dtantsur, morning there to | 13:28 |
lucasagomes | too* | 13:28 |
lucasagomes | I mean afternoon :) | 13:28 |
dtantsur | lucasagomes, o/ | 13:28 |
NobodyCam | :) morning lucasagomes :) | 13:28 |
*** ryanpetrello has quit IRC | 13:30 | |
*** ryanpetrello has joined #openstack-ironic | 13:33 | |
*** jcoufal has quit IRC | 13:34 | |
*** aswadr has quit IRC | 13:40 | |
*** jcoufal has joined #openstack-ironic | 13:59 | |
*** naohirot has quit IRC | 14:06 | |
openstackgerrit | Chris Krelle proposed openstack/python-ironicclient: Update README https://review.openstack.org/134541 | 14:14 |
*** igordcard has joined #openstack-ironic | 14:29 | |
*** ronald has joined #openstack-ironic | 14:32 | |
openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/134383 | 14:39 |
openstackgerrit | Merged openstack/ironic: Disable IPMI timeout before setting boot device https://review.openstack.org/134413 | 14:39 |
openstackgerrit | Merged openstack/ironic-python-agent: Improve docstrings for cmd/agent.py https://review.openstack.org/120662 | 14:41 |
*** ryanpetrello has quit IRC | 14:49 | |
*** rakesh_hs has quit IRC | 14:54 | |
*** igordcard has quit IRC | 14:57 | |
*** subscope has quit IRC | 15:01 | |
NobodyCam | lol looks like we have two specs for iRMC Power Driver for Ironic | 15:04 |
Shrews | NobodyCam: yeah, i saw that too in the Inbox this morning. i thought maybe i was just lacking caffeine and didnt bother looking into it | 15:05 |
NobodyCam | hehehe | 15:05 |
NobodyCam | mornign Shrews :) | 15:05 |
Shrews | morning | 15:06 |
*** ryanpetrello has joined #openstack-ironic | 15:12 | |
*** ryanpetrello has quit IRC | 15:17 | |
*** leopoldj has quit IRC | 15:25 | |
*** anderbubble has joined #openstack-ironic | 15:26 | |
lucasagomes | NobodyCam, I think he got a bit confused playing with git :) | 15:27 |
lucasagomes | he was asking how to abandon one of the patches etc | 15:27 |
*** zz_jgrimm is now known as jgrimm | 15:29 | |
*** jcoufal has quit IRC | 15:31 | |
openstackgerrit | Merged openstack/ironic: Update iLO driver documentation https://review.openstack.org/134144 | 15:32 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Make vendor methods discoverable via the Ironic API https://review.openstack.org/133533 | 15:34 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add documentation about Vendor Methods https://review.openstack.org/134569 | 15:34 |
NobodyCam | ahh | 15:38 |
*** rushiagr_away is now known as rushiagr | 15:38 | |
* Shrews merges all the things | 15:42 | |
*** pcrews has joined #openstack-ironic | 15:44 | |
NobodyCam | woo hoo | 15:45 |
Shrews | NobodyCam: this may be a stupid question, but is the only place we can see the README.rst format output on github? It doesn't show up in our docs. | 15:45 |
NobodyCam | yea I was looking for that too | 15:46 |
NobodyCam | lol | 15:46 |
Shrews | hrm. must be a way we can generate that ourselves | 15:46 |
openstackgerrit | David Shrewsbury proposed openstack/python-ironicclient: Fix sphinx warnings https://review.openstack.org/134580 | 15:56 |
JayF | I totally just view them on github | 15:58 |
JayF | lol | 15:58 |
lucasagomes | Shrews, hah +1 to have it in our docs | 15:59 |
lucasagomes | wondering if a link would do the work | 15:59 |
lucasagomes | well or just pointing the index.rst to the README.rst at the root :) | 16:00 |
Shrews | NobodyCam: rst2html.py README.rst README.html | 16:00 |
Shrews | lucasagomes: README.rst would need to live in docs/source I think. But then Github wouldn't find it. | 16:00 |
NobodyCam | Shrews: I was looking at http://sourceforge.net/projects/retext | 16:01 |
openstackgerrit | Jay Faulkner proposed openstack/ironic: Add gettext to packages needed in dev quickstart https://review.openstack.org/134585 | 16:01 |
Shrews | i don't think it needs to be the docs, per se. if there is something in it that's really important, we should find the right place in our proper docs | 16:01 |
Shrews | NobodyCam: rst2html.py comes with sphinx | 16:02 |
JayF | Anyone think I need to file a bug for ^ that? | 16:02 |
JayF | Just something I found last night while getting tests to pass on my bugfix | 16:03 |
openstackgerrit | David Shrewsbury proposed openstack/python-ironicclient: Fix sphinx warnings https://review.openstack.org/134580 | 16:08 |
Shrews | JayF: that's a question i often have. is there any level of change that _doesn't_ require a bug? | 16:13 |
Shrews | usually easier to just open a bug rather than debate it (like i just did for my sphinx change) | 16:13 |
JayF | Shrews: I guess so, but a single package added onto the end of the doc seems like the absolutely least impactful change you could ever perform | 16:13 |
JayF | lol | 16:13 |
Shrews | maybe that's a good question for our next meeting | 16:14 |
lucasagomes | Shrews, :( I see | 16:16 |
lucasagomes | might have a way | 16:17 |
NobodyCam | Shrews: will that patch fix the errors in the readme patch I just put up? | 16:19 |
dtantsur | JayF, does it conflict with https://review.openstack.org/#/c/134216/ ? | 16:19 |
Shrews | NobodyCam: my patch? no. unrelated | 16:20 |
JayF | dtantsur: I didn't see that ... my change is essentially the cleaned up version of that | 16:20 |
Shrews | NobodyCam: i just pasted the errors from yours within your review, but it formatted horribly. | 16:20 |
NobodyCam | :) /me fixes | 16:20 |
JayF | dtantsur: don't wanna take a low hanging fruit away from a new person, but the docs caused me pain and I fixed them :) | 16:20 |
dtantsur | JayF, right, but I guess he has a priority :) | 16:21 |
JayF | I don't neccessarily agree with that perspective, but my code is up, merge or don't merge it :) | 16:23 |
JayF | I always consider it awesome when someone fixes a thing I was trying to fix | 16:23 |
*** anderbubble has quit IRC | 16:23 | |
*** foexle has quit IRC | 16:31 | |
lucasagomes | dtantsur, JayF I think #134216 code is going to converge more into removing py26 support on the tests (which makes sense since it's not tested in gate anymore) | 16:32 |
lucasagomes | and to be honest I wanna dict comprehension. damn py26 | 16:32 |
JayF | lucasagomes: I was about to push that change too :P | 16:32 |
JayF | I can forgo if desired | 16:32 |
lucasagomes | heh I see... well you can :) | 16:33 |
lucasagomes | but as it's his first patch I tihnk it would be cool to let him do it | 16:33 |
* lucasagomes is trying to be nice | 16:33 | |
JayF | fine by me :) | 16:34 |
lucasagomes | cool :D | 16:34 |
*** jgrimm is now known as zz_jgrimm | 16:36 | |
openstackgerrit | Chris Krelle proposed openstack/python-ironicclient: Update README https://review.openstack.org/134541 | 16:44 |
*** anderbubble has joined #openstack-ironic | 16:44 | |
NobodyCam | Shrews: missing one blank line :-p | 16:44 |
NobodyCam | that should look a bit better | 16:44 |
*** anderbubble_ has joined #openstack-ironic | 16:54 | |
*** anderbubble_ has quit IRC | 16:54 | |
*** anderbubble_ has joined #openstack-ironic | 16:55 | |
*** marcoemorais has joined #openstack-ironic | 16:55 | |
*** anderbubble has quit IRC | 16:55 | |
*** anderbubble_ is now known as anderbubble | 16:55 | |
*** ifarkas has quit IRC | 16:56 | |
*** comstud is now known as bearhands | 16:59 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add documentation about Vendor Methods https://review.openstack.org/134569 | 17:04 |
lucasagomes | yush :) | 17:04 |
*** david-lyle has joined #openstack-ironic | 17:12 | |
*** ndipanov_ has quit IRC | 17:14 | |
*** ryanpetrello has joined #openstack-ironic | 17:15 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add gendocs tox job for generating the documentation https://review.openstack.org/134604 | 17:20 |
*** lucasagomes is now known as lucas-brb | 17:20 | |
* lucas-brb brb | 17:20 | |
openstackgerrit | Merged openstack/python-ironicclient: Sane parameters for node and driver vendor_passthru() https://review.openstack.org/133780 | 17:25 |
*** dlaube has joined #openstack-ironic | 17:27 | |
NobodyCam | brb | 17:29 |
*** harlowja has joined #openstack-ironic | 17:35 | |
NobodyCam | back | 17:36 |
*** harlowja has quit IRC | 17:37 | |
*** harlowja has joined #openstack-ironic | 17:37 | |
*** rushiagr is now known as rushiagr_away | 17:38 | |
*** rwsu has joined #openstack-ironic | 17:38 | |
dlaube | g'morning | 17:40 |
*** pleia2 has quit IRC | 17:43 | |
*** viktors is now known as viktors|afk | 17:45 | |
NobodyCam | morning dlaube | 17:56 |
*** spandhe has joined #openstack-ironic | 17:58 | |
*** ryanpetrello has quit IRC | 17:59 | |
*** derekh has quit IRC | 18:03 | |
*** pleia2 has joined #openstack-ironic | 18:04 | |
*** marcoemorais has quit IRC | 18:04 | |
Shrews | jroll: JayF: JoshNang: any reason why you guys holding off on the requirements updates for IPA in https://review.openstack.org/114058 for so long? | 18:04 |
*** marcoemorais has joined #openstack-ironic | 18:05 | |
JoshNang | Shrews: i think we were hoping to get an agent gating job much quicker than we have | 18:05 |
Shrews | ah. well that makes sense | 18:05 |
*** marcoemorais has quit IRC | 18:05 | |
*** ryanpetrello has joined #openstack-ironic | 18:06 | |
JoshNang | but yeah, its been quite awhile.. | 18:06 |
*** marcoemorais has joined #openstack-ironic | 18:06 | |
*** achanda has joined #openstack-ironic | 18:06 | |
*** jistr has quit IRC | 18:07 | |
*** sambetts has quit IRC | 18:10 | |
*** dtantsur is now known as dtantsur|afk | 18:12 | |
dtantsur|afk | have a nice weekend, see you in Tue (or Mon evening if I remember it - we have a holiday)! | 18:12 |
Shrews | dtantsur|afk: so long | 18:13 |
NobodyCam | have a good weekend dtantsur|afk | 18:13 |
NobodyCam | walkies ... brb | 18:13 |
*** marcoemorais has quit IRC | 18:14 | |
*** achanda has quit IRC | 18:15 | |
*** achanda has joined #openstack-ironic | 18:17 | |
*** romcheg has quit IRC | 18:18 | |
*** athomas has quit IRC | 18:19 | |
JayF | Shrews: trying to get the IPA job to pass | 18:32 |
JayF | Shrews: the tempest one ... it works using prebuilt agents for ironic, but not for building your own agents | 18:32 |
JayF | Shrews: I have a this up: https://review.openstack.org/#/c/134438/ to try and fix it but I'm not sure it's the right approach | 18:33 |
*** marcoemorais has joined #openstack-ironic | 18:35 | |
Shrews | JayF: if that does what i imagine it does, you'll likely get pushback on that approach | 18:40 |
openstackgerrit | yunhong-jiang proposed openstack/ironic: Convert qcow2 image to raw format when deploy https://review.openstack.org/130881 | 18:41 |
NobodyCam | nice: https://3d-car-shows.com/los-angeles-auto-show-volkswagen-golf/ | 18:41 |
JayF | Shrews: please look over it and suggest a better way then... I felt like the solution might not be correct, but there was no obvious correct solution | 18:41 |
JayF | Shrews: kinda following my 'a bad PR is better than no PR' philosophy for fixing things :) | 18:42 |
Shrews | JayF: i would if i could think of one :( | 18:42 |
Shrews | i'd bet sdague or the other infra guys would have more insight | 18:42 |
* JayF finds that often when he asks questions to infra, he gets answers to 15 questions he didn't know existed and forgets his original question | 18:43 | |
Shrews | lol | 18:43 |
Shrews | b/c it's true | 18:44 |
lucas-brb | folks have a great weekend | 18:46 |
lucas-brb | and good night :) | 18:46 |
*** lucas-brb is now known as lucas-beer | 18:46 | |
*** yjiang5_away is now known as yjiang5 | 18:46 | |
*** ryanpetrello has quit IRC | 18:47 | |
NobodyCam | night lucas-beer | 18:48 |
*** pelix has quit IRC | 18:50 | |
*** ryanpetrello has joined #openstack-ironic | 18:52 | |
*** harlowja is now known as harlowja_away | 18:58 | |
*** achanda_ has joined #openstack-ironic | 19:01 | |
*** marcoemorais has quit IRC | 19:02 | |
*** marcoemorais has joined #openstack-ironic | 19:02 | |
*** marcoemorais has quit IRC | 19:03 | |
*** marcoemorais has joined #openstack-ironic | 19:04 | |
JayF | pretty sure once https://review.openstack.org/#/c/134438/2 gets in, IPA agent_ssh tempest jobs will start passing | 19:04 |
*** achanda has quit IRC | 19:05 | |
JoshNang | \o/ | 19:05 |
JayF | Shrews: good suggestion to ask, fungi helped me understand what was going on | 19:05 |
Shrews | JayF: awesome | 19:06 |
*** marcoemorais has quit IRC | 19:06 | |
*** marcoemorais has joined #openstack-ironic | 19:07 | |
*** marcoemorais has quit IRC | 19:07 | |
*** marcoemorais has joined #openstack-ironic | 19:07 | |
*** harlowja_away is now known as harlowja | 19:11 | |
*** ryanpetrello has quit IRC | 19:17 | |
*** lucas-beer has quit IRC | 19:21 | |
*** ryanpetrello has joined #openstack-ironic | 19:22 | |
*** achanda_ has quit IRC | 19:33 | |
*** achanda has joined #openstack-ironic | 19:36 | |
*** Guest33321 has joined #openstack-ironic | 19:45 | |
*** Guest33321 is now known as annegentle | 19:45 | |
*** jjohnson2 has joined #openstack-ironic | 19:52 | |
NobodyCam | question. kwargs.get('blah') would return none if blah was not a valid key? correct? | 19:52 |
NobodyCam | nm | 19:55 |
openstackgerrit | Jarrod Johnson proposed stackforge/pyghmi: Implement retrieval of uefi flag in boot devs https://review.openstack.org/134636 | 19:59 |
jjohnson2 | It took me this long to realise I hadn't done my update to lenovo email dance with launchpad | 20:00 |
NobodyCam | hey mornig jjohnson2 | 20:01 |
jjohnson2 | NobodyCam, afternoon | 20:01 |
NobodyCam | hey just checking to see if you'd have any chance to look at the ipmi to system command deamon listener thingy | 20:02 |
*** dprince has quit IRC | 20:05 | |
NobodyCam | humm.. /opt/stack/new/devstack-gate/devstack-vm-gate.sh: line 352: cd: /opt/stack/new/devstack: No such file or directory | 20:10 |
NobodyCam | anyone now if recheck trigers 3rd party jobs? | 20:10 |
NobodyCam | s/now/know/ | 20:10 |
openstackgerrit | Merged openstack/ironic: Add gettext to packages needed in dev quickstart https://review.openstack.org/134585 | 20:11 |
*** ryanpetrello has quit IRC | 20:18 | |
*** tatyana has joined #openstack-ironic | 20:23 | |
*** marcoemorais has quit IRC | 20:33 | |
*** marcoemorais has joined #openstack-ironic | 20:33 | |
*** achanda has quit IRC | 20:34 | |
*** foexle has joined #openstack-ironic | 20:35 | |
*** achanda_ has joined #openstack-ironic | 20:47 | |
NobodyCam | JoshNang: hey question.. I'm looking at the zapping spec.. how would a operator get a list of nodes in zapfail state? | 20:58 |
JoshNang | NobodyCam: hmmm. is there a way to filter the list of nodes on provision_state? | 20:59 |
JoshNang | NobodyCam: most of the time if i need a script to look for something like that, we get every node and run them through a client-side filter | 21:00 |
*** ryanpetrello has joined #openstack-ironic | 21:00 | |
NobodyCam | oh that just seems wrong | 21:00 |
NobodyCam | :-p | 21:00 |
JoshNang | :D well it's usually a slightly more complex filter than that | 21:01 |
NobodyCam | yea | 21:01 |
NobodyCam | for complex stuff I can agree | 21:01 |
JoshNang | maybe we should add simple filtering to the api/client? like "ironic node-list provision_state='zapfail'" | 21:02 |
*** rustlebee is now known as russellb | 21:03 | |
NobodyCam | yea because I don't see that we can do that now. https://github.com/openstack/python-ironicclient/blob/master/ironicclient/v1/node.py#L39-L66 | 21:04 |
NobodyCam | but i don't see it as part of that spec | 21:04 |
JoshNang | yeah i haven't considered it beyond doing a node-list and looking by manually. seems like adding that would be a separate spec? | 21:05 |
NobodyCam | if someone had oh say 10,000 nodes it could be a pain to find the one in zapfail | 21:06 |
NobodyCam | lol | 21:06 |
jjohnson2 | NobodyCam, I'm ominously quite | 21:08 |
jjohnson2 | quiet | 21:08 |
NobodyCam | lol | 21:08 |
NobodyCam | don't get me wrong awk is an awesome tool for just such tasks | 21:09 |
JoshNang | NobodyCam: huh, that would be a problem :P | 21:09 |
JoshNang | i sometimes forget how helpful our dashboard/tooling is for things like that | 21:09 |
NobodyCam | oh brb | 21:11 |
JoshNang | NobodyCam: it looks like it'd be relatively easy to add filtering by various fields https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L663 | 21:12 |
*** igordcard has joined #openstack-ironic | 21:15 | |
*** igordcard has quit IRC | 21:19 | |
NobodyCam | ahh :) | 21:21 |
*** ryanpetrello has quit IRC | 21:22 | |
*** ryanpetrello has joined #openstack-ironic | 21:25 | |
JoshNang | think adding that needs a spec? | 21:27 |
JoshNang | seems like a bug to me :P | 21:27 |
NobodyCam | i would vote bug | 21:28 |
NobodyCam | :-p | 21:28 |
*** tatyana has quit IRC | 21:31 | |
JayF | NobodyCam: I believe it doesn't; they're supposed to have their own veb iirc | 21:32 |
JayF | *verb | 21:32 |
*** igordcard has joined #openstack-ironic | 21:34 | |
*** marcoemorais has quit IRC | 21:34 | |
NobodyCam | JayF: so something like ironic node-list-filter-by-provision-state-zapfail | 21:37 |
openstackgerrit | Merged stackforge/pyghmi: Implement retrieval of uefi flag in boot devs https://review.openstack.org/134636 | 21:38 |
*** ryanpetrello has quit IRC | 21:42 | |
*** marcoemorais has joined #openstack-ironic | 21:46 | |
*** foexle has quit IRC | 21:56 | |
*** achanda_ has quit IRC | 21:57 | |
*** achanda has joined #openstack-ironic | 22:00 | |
*** jjohnson2 has quit IRC | 22:04 | |
*** marcoemorais has quit IRC | 22:05 | |
*** marcoemorais1 has joined #openstack-ironic | 22:05 | |
*** marcoemorais1 has quit IRC | 22:06 | |
*** marcoemorais has joined #openstack-ironic | 22:06 | |
*** igordcard has quit IRC | 22:09 | |
*** achanda has quit IRC | 22:17 | |
*** achanda has joined #openstack-ironic | 22:18 | |
*** pensu has quit IRC | 22:23 | |
*** spandhe has quit IRC | 22:30 | |
*** spandhe has joined #openstack-ironic | 22:31 | |
*** tatyana has joined #openstack-ironic | 22:34 | |
NobodyCam | brb | 22:37 |
*** Viswanath has joined #openstack-ironic | 22:42 | |
*** Viswanath has quit IRC | 22:45 | |
*** foexle has joined #openstack-ironic | 22:47 | |
*** marcoemorais1 has joined #openstack-ironic | 22:47 | |
*** marcoemorais has quit IRC | 22:51 | |
NobodyCam | back | 22:51 |
*** tatyana has quit IRC | 22:55 | |
*** foexle has quit IRC | 22:58 | |
*** achanda has quit IRC | 23:04 | |
openstackgerrit | Michael Davies proposed openstack/ironic-specs: Proposal to add logical names to Ironic nodes https://review.openstack.org/134439 | 23:15 |
*** achanda has joined #openstack-ironic | 23:37 | |
*** marcoemorais1 has quit IRC | 23:38 | |
*** marcoemorais has joined #openstack-ironic | 23:38 | |
*** spandhe has quit IRC | 23:46 | |
*** spandhe has joined #openstack-ironic | 23:47 | |
NobodyCam | ok question... is recording the data / time a node was last auto discovered in node.Extra's seem like something an operator would like to have.. | 23:48 |
NobodyCam | I would .. but I'm a lazy admin :-p | 23:49 |
*** anderbubble has quit IRC | 23:55 | |
*** foexle has joined #openstack-ironic | 23:56 | |
JayF | NobodyCam: probably so? | 23:56 |
JayF | NobodyCam: I honestly wish we had an audit log of every single action Ironic took | 23:56 |
JayF | in some magically fast search engine | 23:56 |
* JayF waits for the "why not logstash" question | 23:56 | |
JayF | (and whoever asks it is right) | 23:56 |
*** marcoemorais has quit IRC | 23:57 | |
*** marcoemorais has joined #openstack-ironic | 23:57 | |
dlaube | How is the postgresql support in ironic? as opposed to mysql? | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!