| NobodyCam | just did mordred helped me out | 00:00 |
|---|---|---|
| jroll | ah ok | 00:00 |
| jroll | oh huh, didn't know pip install wheel was a thing | 00:01 |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Add decommission to node provision_state API https://review.openstack.org/114086 | 00:10 |
| *** nosnos has joined #openstack-ironic | 00:11 | |
| *** BrownBear has quit IRC | 00:17 | |
| *** DCLacoste has joined #openstack-ironic | 00:18 | |
| *** DCLacoste has quit IRC | 00:22 | |
| *** eguz has joined #openstack-ironic | 00:24 | |
| *** eghobo has quit IRC | 00:28 | |
| *** penick has quit IRC | 00:30 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/ironic: Handle all exceptions from _exec_ipmitool https://review.openstack.org/114090 | 00:34 |
| *** rwsu has quit IRC | 00:42 | |
| *** nosnos has quit IRC | 00:46 | |
| *** rwsu has joined #openstack-ironic | 00:55 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Add decommission to node provision_state API https://review.openstack.org/114086 | 00:57 |
| *** rwsu has quit IRC | 00:57 | |
| *** rwsu has joined #openstack-ironic | 00:59 | |
| *** eghobo has joined #openstack-ironic | 01:02 | |
| *** eghobo has quit IRC | 01:07 | |
| *** Krast has quit IRC | 01:17 | |
| *** Krast has joined #openstack-ironic | 01:17 | |
| *** Haomeng has quit IRC | 01:31 | |
| *** krtaylor has joined #openstack-ironic | 01:34 | |
| *** nosnos has joined #openstack-ironic | 01:38 | |
| *** rloo_afk has quit IRC | 01:57 | |
| *** jdonalds has joined #openstack-ironic | 02:35 | |
| *** dlaube has joined #openstack-ironic | 02:40 | |
| *** dlaube has quit IRC | 02:40 | |
| *** Ng has quit IRC | 03:05 | |
| *** Ng has joined #openstack-ironic | 03:05 | |
| *** Haomeng has joined #openstack-ironic | 03:28 | |
| *** nosnos has quit IRC | 03:32 | |
| *** mkerrin has quit IRC | 03:43 | |
| *** wendar_ has joined #openstack-ironic | 03:49 | |
| JayF | NobodyCam: also look at default w/r/t using prerelease/dev packages. I think that ended up being a thing to | 03:50 |
| * JayF is going away on vacation for a while, will be back Tues/Weds | 03:50 | |
| *** mkerrin has joined #openstack-ironic | 03:50 | |
| *** jdonalds has quit IRC | 03:51 | |
| openstackgerrit | A change was merged to openstack/ironic: Remove objectify decorator from dbapi.update_* methods https://review.openstack.org/113968 | 03:51 |
| *** mikal_ has joined #openstack-ironic | 03:51 | |
| *** toabctl_ has joined #openstack-ironic | 03:52 | |
| *** keekz_ has joined #openstack-ironic | 03:52 | |
| *** dutsmoc has joined #openstack-ironic | 03:52 | |
| *** keekz has quit IRC | 03:52 | |
| *** toabctl has quit IRC | 03:52 | |
| *** coolsvap has quit IRC | 03:52 | |
| *** toabctl_ is now known as toabctl | 03:52 | |
| *** cinerama has quit IRC | 03:52 | |
| *** mgagne has quit IRC | 03:52 | |
| *** mikal has quit IRC | 03:52 | |
| *** mordred has quit IRC | 03:52 | |
| *** radsy has quit IRC | 03:52 | |
| *** jroll has quit IRC | 03:52 | |
| *** wendar has quit IRC | 03:52 | |
| *** comstud has quit IRC | 03:52 | |
| *** dguerri`afk has quit IRC | 03:52 | |
| *** dguerri has joined #openstack-ironic | 03:52 | |
| *** mgagne has joined #openstack-ironic | 03:53 | |
| *** mgagne is now known as Guest54676 | 03:53 | |
| *** jdonalds has joined #openstack-ironic | 03:53 | |
| *** radsy has joined #openstack-ironic | 03:53 | |
| *** radsy has quit IRC | 03:53 | |
| *** radsy has joined #openstack-ironic | 03:53 | |
| *** mordred has joined #openstack-ironic | 03:53 | |
| *** cinerama has joined #openstack-ironic | 03:54 | |
| *** jroll has joined #openstack-ironic | 03:54 | |
| *** pcrews has quit IRC | 03:54 | |
| *** mkerrin has quit IRC | 03:55 | |
| *** jdonalds has quit IRC | 03:59 | |
| *** nosnos has joined #openstack-ironic | 04:01 | |
| *** coolsvap has joined #openstack-ironic | 04:02 | |
| *** dguerri_ has joined #openstack-ironic | 04:06 | |
| *** dguerri has quit IRC | 04:07 | |
| *** radsy has quit IRC | 04:34 | |
| *** bmahalakshmi has joined #openstack-ironic | 04:40 | |
| *** teju has joined #openstack-ironic | 04:50 | |
| teju | can ironic packages be installed in RHEL? | 04:53 |
| Haomeng | teju: hi | 04:54 |
| Haomeng | teju: you can try with devstack | 04:54 |
| teju | i have installed icehouse packages in RHEL | 04:54 |
| teju | i would like to install ironic packages in my existing setup | 04:54 |
| teju | using standard yum repos | 04:55 |
| Haomeng | teju: not sure if RDO contains ironic rpm packages, maybe will be ready once ironic is graduated | 04:55 |
| *** pradipta_away is now known as pradipta | 04:55 | |
| Haomeng | teju: so, you can try with devstack or just install ironic by manually | 04:56 |
| teju | Haomeng : ok,..please let me know how to install ironic manually? | 04:56 |
| Haomeng | teju: follow this guide - http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html | 04:56 |
| Haomeng | teju: suggest to run devstack and enable ironic to install | 04:57 |
| *** mikal_ is now known as mikal | 04:58 | |
| teju | Haomeng: ok, i will give it a try. do I need neutron setup to make ironic work? | 04:58 |
| Haomeng | teju: and you can take the ironic devstack scripts as reference also | 04:58 |
| Haomeng | teju: https://github.com/openstack-dev/devstack/blob/master/lib/ironic | 04:58 |
| Haomeng | teju: yes, Ironic depeds on neutron | 04:59 |
| Haomeng | teju: this is good reference from devstack ironic support - https://github.com/openstack-dev/devstack/blob/master/lib/ironic | 04:59 |
| Haomeng | suggest to take a look | 04:59 |
| teju | Haomeng : thanks for ur time. I will give it a try | 05:01 |
| Haomeng | and this one - https://github.com/openstack-dev/devstack/blob/abfa32700dbabc438193214c223516b63931a703/extras.d/50-ironic.sh | 05:01 |
| Haomeng | welcome | 05:02 |
| *** jdonalds has joined #openstack-ironic | 05:05 | |
| *** jdonalds has quit IRC | 05:07 | |
| *** mkerrin has joined #openstack-ironic | 05:08 | |
| *** jdonalds has joined #openstack-ironic | 05:10 | |
| *** mkerrin has quit IRC | 05:13 | |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Take iSCSI deploy out of pxe driver https://review.openstack.org/111232 | 05:13 |
| *** toabctl has quit IRC | 05:20 | |
| *** toabctl has joined #openstack-ironic | 05:25 | |
| *** rameshg87 has joined #openstack-ironic | 05:37 | |
| *** mkerrin has joined #openstack-ironic | 05:50 | |
| *** SpamapS has quit IRC | 05:53 | |
| *** rushiagr has joined #openstack-ironic | 05:57 | |
| *** mkerrin has quit IRC | 06:02 | |
| *** rameshg87 has quit IRC | 06:03 | |
| *** bvivek has joined #openstack-ironic | 06:10 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/114135 | 06:11 |
| *** mkerrin has joined #openstack-ironic | 06:11 | |
| *** pradipta is now known as pradipta_away | 06:28 | |
| *** k4n0 has joined #openstack-ironic | 06:30 | |
| *** SpamapS has joined #openstack-ironic | 06:47 | |
| *** SpamapS has quit IRC | 06:47 | |
| *** SpamapS has joined #openstack-ironic | 06:47 | |
| *** jdonalds has quit IRC | 07:05 | |
| *** dtantsur|afk is now known as dtantsur | 07:06 | |
| dtantsur | Morning Ironic | 07:06 |
| Zerpex | Morning dtantsur | 07:07 |
| *** jdonalds has joined #openstack-ironic | 07:08 | |
| *** jdonalds has quit IRC | 07:08 | |
| *** jdonalds has joined #openstack-ironic | 07:08 | |
| *** jdonalds has quit IRC | 07:10 | |
| *** ndipanov has joined #openstack-ironic | 07:12 | |
| *** mkerrin has quit IRC | 07:22 | |
| *** jcoufal has joined #openstack-ironic | 07:28 | |
| *** mkerrin has joined #openstack-ironic | 07:30 | |
| Haomeng | morning dtantsur, | 07:31 |
| Haomeng | morning Zerpex | 07:31 |
| *** jistr has joined #openstack-ironic | 07:44 | |
| *** igordcard has joined #openstack-ironic | 07:46 | |
| *** mrda is now known as mrda-away | 07:46 | |
| mrda-away | Night Ironic, see you tomorrow... | 07:46 |
| dtantsur | g'night, mrda-away, g'morning Zerpex, Haomeng :) | 07:47 |
| yuriyz | morning/night Ironic | 08:03 |
| Zerpex | http://snaps.lucasrolff.com/nawj32g446mfsqn.png - does any know why the nova/service.py complains about unexpected keyword, when the nova manager base class surely has host defined? | 08:05 |
| dtantsur | yuriyz, morning (or is it evening for you?) | 08:09 |
| yuriyz | only morning :) | 08:09 |
| dtantsur | :) | 08:10 |
| dtantsur | Zerpex, my one guess is that it still uses new version of Ironic, i.e. something wrong with downgrade | 08:10 |
| dtantsur | maybe do full uninstall of Ironic, ensure nova can no longer find it and install the old version again? | 08:10 |
| yuriyz | dtantsur, about bug 1356362. We do not calculate space for conversion here https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/image_cache.py#L304 IMO should be 2*total_size >= free what you think? | 08:17 |
| dtantsur | yuriyz, well, maybe if we keep naive assumption that 2*total_size if enough. I suspect we need to do smarted things though, like lucas initially suggested (i.e. check that image required conversion) | 08:19 |
| dtantsur | yuriyz, but yes, the simplest fix would be to do total_size *= 2 in the beginning :) | 08:19 |
| Zerpex | dtantsur: I'll try indeed | 08:21 |
| *** foexle has joined #openstack-ironic | 08:22 | |
| *** bmahalakshmi2 has joined #openstack-ironic | 08:33 | |
| *** bmahalakshmi has quit IRC | 08:33 | |
| *** chenglch has joined #openstack-ironic | 08:35 | |
| *** derekh has joined #openstack-ironic | 08:42 | |
| chenglch | hello , I want to ask a question about ironic deployment, how to make dnsmasq use the remote tftp server? | 08:46 |
| *** leopoldj has joined #openstack-ironic | 08:48 | |
| Zerpex | dtantsur: did the reinstall (even rebooting the server inbetween) - ensures nova didn't know about ironic - and installed it from the stable/icehouse thing - and still gives same issue :/ | 08:48 |
| openstackgerrit | A change was merged to openstack/ironic: Use valid exception in start_shellinabox_console https://review.openstack.org/113939 | 08:49 |
| chenglch | The option in --dhcp-optsfile already use the remote tftp ip now, but the ip address of pxe next-server is still the network node | 08:56 |
| *** bmahalakshmi2 has quit IRC | 09:00 | |
| *** cian_ has quit IRC | 09:05 | |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add support for creating vfat disk images https://review.openstack.org/105413 | 09:07 |
| *** bmahalakshmi has joined #openstack-ironic | 09:08 | |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: WIP: Add send-data-to-ceilometer support for pxe_ipminative driver https://review.openstack.org/112486 | 09:10 |
| openstackgerrit | Imre Farkas proposed a change to openstack/ironic: Add DracDriver and its DracPower module https://review.openstack.org/104850 | 09:31 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add support for interacting with swift https://review.openstack.org/105795 | 09:39 |
| *** dtantsur is now known as dtantsur|lunch | 09:39 | |
| *** lucasagomes has joined #openstack-ironic | 10:02 | |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: IloVirtualMediaIscsi deploy driver https://review.openstack.org/113865 | 10:07 |
| *** chenglch has quit IRC | 10:16 | |
| *** nosnos has quit IRC | 10:16 | |
| *** pelix has joined #openstack-ironic | 10:29 | |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: WIP: Add send-data-to-ceilometer support for pxe_ipminative driver https://review.openstack.org/112486 | 10:43 |
| *** dtantsur|lunch is now known as dtantsur | 10:52 | |
| *** teju has quit IRC | 11:01 | |
| openstackgerrit | Imre Farkas proposed a change to openstack/ironic: Add DracDriver and its DracPower module https://review.openstack.org/104850 | 11:24 |
| *** leopoldj has quit IRC | 11:29 | |
| *** Krast has quit IRC | 11:31 | |
| *** lucasagomes is now known as lucas-hungry | 11:38 | |
| *** bmahalakshmi has quit IRC | 11:40 | |
| *** lucas-hungry is now known as lucasagomes | 11:53 | |
| *** Alexei_9871 has joined #openstack-ironic | 12:24 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/114057 | 12:34 |
| *** teju has joined #openstack-ironic | 12:53 | |
| *** linggao has joined #openstack-ironic | 12:56 | |
| *** rloo has joined #openstack-ironic | 13:19 | |
| *** jcoufal has quit IRC | 13:19 | |
| *** jcoufal has joined #openstack-ironic | 13:19 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove objectify decorator from dbapi's get_conductor and register_conductor https://review.openstack.org/114242 | 13:25 |
| *** jistr has quit IRC | 13:30 | |
| *** jistr has joined #openstack-ironic | 13:32 | |
| *** annegentle_ has joined #openstack-ironic | 13:35 | |
| *** annegentle has quit IRC | 13:35 | |
| *** rushiagr is now known as rushiagr_away | 13:39 | |
| rloo | lucasagomes: when you have a minute, would like to discuss 114046 with you | 13:41 |
| lucasagomes | rloo, hey, hmm can we do it in 10 min? I'm in a call | 13:42 |
| lucasagomes | rloo, and morning | 13:42 |
| rloo | lucasagomes: sure | 13:42 |
| rloo | lucasagomes: morning! | 13:42 |
| jroll | morning lucasagomes rloo and everyone else :) | 13:42 |
| rloo | lucasagomes: sorry, afternoon ;) | 13:42 |
| jroll | lucasagomes: I have news for you on that bug with the nova cache :| | 13:42 |
| rloo | jroll: early morning to you! | 13:42 |
| jroll | pshhh, this is late :) | 13:42 |
| dtantsur | jroll, rloo, morning! | 13:43 |
| rloo | hi dtantsur | 13:44 |
| lucasagomes | jroll, good news? | 13:44 |
| jroll | heya dtantsur :) | 13:44 |
| jroll | lucasagomes: I mean... I found the problem, but fixing it would be ignoring the refresh option :) | 13:45 |
| jroll | lucasagomes: tldr, the cache is populated while power_state is None for all the nodes, so they are seen as unavailable | 13:45 |
| *** pcrews has joined #openstack-ironic | 13:47 | |
| lucasagomes | jroll, yup, I put a comment this morning as well on that review | 13:47 |
| jroll | so | 13:48 |
| lucasagomes | I also have some concern about things changing in Ironic but the cache doesn't getting invalid/updated... e.g putting a node in maintenance in ironic | 13:48 |
| jroll | oh yeah I see that now, heh | 13:48 |
| jroll | yeah, about that | 13:48 |
| jroll | the original patch always refreshed the cache when get_available_nodes was called | 13:48 |
| jroll | because the resource tracker loop doesn't pass refresh=True | 13:49 |
| jroll | so patch set 1 did what we wanted... (and is what we're running downstream) | 13:49 |
| jroll | but it doesn't work if we respect the refresh param | 13:49 |
| jroll | so, wdyt about going back to that model? | 13:50 |
| lucasagomes | I see, well seems the way to go then, we just need to put some explanation about why we aren't using the refresh parameter so other people don't try to make use of it when they see that method | 13:50 |
| jroll | yeah indeed | 13:50 |
| lucasagomes | jroll, and aparently that refresh=True never gets called because | 13:50 |
| lucasagomes | I left my env for the whole night running and in the morning the available resources was 0 still :P | 13:51 |
| jroll | I guess it would be bad for the interface if we defaulted refresh to True? >:) | 13:51 |
| lucasagomes | idk when refresh get's called really | 13:51 |
| jroll | lucasagomes: right... there's a few points in nova/conductor/manager.py but they aren't periodic | 13:51 |
| lucasagomes | jroll, hah... hmmm we would be breaking the method signature by changing the default no? Or not... I mean... hmmmm /me thinking | 13:52 |
| lucasagomes | but sounds like a good idea ^... | 13:52 |
| lucasagomes | rloo, yo sorry, lemme see 114046 | 13:52 |
| rloo | lucasagomes: no worries. I added a comment to your comment ;) | 13:53 |
| jroll | lucasagomes: yeah, idk, nothing ever explicitly calls it with False, though, so might as well just ignore it | 13:53 |
| jroll | going to push up a new patch real quick | 13:53 |
| * jroll tests in devstack first | 13:55 | |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/python-ironicclient: Fix column headings regression due to switch to cliutils https://review.openstack.org/114252 | 13:57 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Query full node details and cache https://review.openstack.org/108545 | 13:59 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Use cache in node_is_available() https://review.openstack.org/113036 | 13:59 |
| jroll | lucasagomes: still running devstack but this should be good to go | 13:59 |
| lucasagomes | rloo, oh I see what you mean... hmm alright sounds fine | 14:05 |
| lucasagomes | rloo, tho reading that patch again, I see one thing about the new exception being added | 14:05 |
| rloo | lucasagomes: do you think I should add a comment somewhere to explain that? | 14:05 |
| lucasagomes | ConsoleError which sounds like a generic exception. On the other hand we have things like NoConsolePid which is very specific | 14:06 |
| lucasagomes | do you think we should replace NoConsolePid with ConsoleError OR make NoConsolePid to inherit from ConsoleError? | 14:06 |
| lucasagomes | rloo, hmm I think it's grand, it's not hard ot understand what's going there | 14:07 |
| *** coolsvap has quit IRC | 14:07 | |
| lucasagomes | I just thought that as before we had only 1 call that returned the pid + checked if the dir can be created | 14:07 |
| lucasagomes | was more convienent | 14:07 |
| rloo | lucasagomes: I wasn't sure how much I should modify the code, and I was lazy, figured a general console exception would suffice. It isn't consistent though. What do you suggest? | 14:08 |
| rloo | lucasagomes: wrt console exceptions, there are NodeConsoleNotEnabled, NoConsolePid, ConsoleSubprocessFailed, and the new ConsoleError | 14:10 |
| jroll | huh, never seen this before: 2014-08-14 14:06:02.398 TRACE nova.compute.manager [instance: 2093cb9a-766f-460c-ba70-90b18da329ad] InstanceDeployFailure: Failed to provision instance 2093cb9a-766f-460c-ba70-90b18da329ad: Failed to deploy. Error: Root partition is too small for requested image. Image size: 24 MB, Root size: 0 MB | 14:10 |
| lucasagomes | rloo, hmm I don't have a problem in having specific exception since we have a base custom exception that could be captured on a high level... It can be another patch but I think it would make sense to make the other console exceptions to inheret from the ConsoleError | 14:12 |
| *** jgrimm has joined #openstack-ironic | 14:12 | |
| rloo | lucasagomes: ok, I'll make that change. If I make it in the same patch is that OK or do you prefer a separate patch? | 14:12 |
| *** jasondotstar has joined #openstack-ironic | 14:13 | |
| *** coolsvap has joined #openstack-ironic | 14:14 | |
| lucasagomes | rloo, I'm ok with both :) I don't think it's complete unrelated since that console error requires a more generic console exception | 14:14 |
| lucasagomes | so in the same would make sense for me to | 14:14 |
| lucasagomes | too* | 14:14 |
| rloo | lucasagomes: ok thx. I'll do it all together then. Faster :-) | 14:14 |
| lucasagomes | ack, thank u! | 14:15 |
| lucasagomes | jroll, hah yeah, well the error is self explantory but yeah I haven't seem that as well | 14:15 |
| lucasagomes | I mean how it got scheduled on that machine (unless we lied about the root size on the properties) | 14:15 |
| jroll | right... just weird that it actually happened | 14:16 |
| lucasagomes | jroll, is root_gb 0 in nodes.properties? | 14:16 |
| lucasagomes | root_gb == 0 (or not specified) | 14:17 |
| jroll | no, even logs show 10g free | 14:18 |
| lucasagomes | ew | 14:19 |
| jroll | yeah, dunno | 14:19 |
| * jroll digs | 14:19 | |
| jroll | oh huh, root_gb is in instance_info? | 14:22 |
| NobodyCam | good morning, says the man waking up | 14:23 |
| lucasagomes | jroll, heh yup | 14:23 |
| jroll | morning NobodyCam :) | 14:23 |
| jroll | lucasagomes: yeah, so, not sure why nova is passing 0 there :| | 14:23 |
| lucasagomes | jroll, in nova root_gb is also part of the instance | 14:24 |
| lucasagomes | jroll, ouch | 14:24 |
| jroll | I'm just running tempest with stock devstack :( | 14:24 |
| dtantsur | NobodyCam, morning | 14:24 |
| jroll | yeah | 14:24 |
| lucasagomes | jroll, is nova and ironic up to date? | 14:25 |
| lucasagomes | NobodyCam, morning | 14:25 |
| * jroll runs all the things again | 14:25 | |
| jroll | lucasagomes: ironic is running this patch, nova is up to maybe a week old | 14:25 |
| jroll | idk, I'll update it | 14:25 |
| lucasagomes | yeah well shouldn't matter much cause we still using the nova driver in the ironic tree | 14:25 |
| lucasagomes | but yeah that's weird | 14:25 |
| jroll | idk | 14:26 |
| jroll | now I get to test with adam_g's devstack refactoring, too :P | 14:26 |
| NobodyCam | morning lucasagomes dtantsur jroll :) | 14:26 |
| jroll | lucasagomes: hmm, jenkins passed but I can't make it pass :P | 14:38 |
| jroll | something must be off in my environment | 14:38 |
| jroll | alright, let's +2 these so mrda doesn't want to stab me any more https://review.openstack.org/#/c/108545/ and https://review.openstack.org/#/c/113036/ | 14:39 |
| *** rushiagr_away is now known as rushiagr | 14:41 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/ironic: Improve exception handling in console code https://review.openstack.org/114046 | 14:43 |
| *** k4n0 has quit IRC | 14:45 | |
| *** foexle has quit IRC | 14:45 | |
| *** jcoufal has quit IRC | 15:06 | |
| *** jcoufal has joined #openstack-ironic | 15:06 | |
| *** jcoufal has quit IRC | 15:10 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove objectify decorator from dbapi's {get, register}_conductor() https://review.openstack.org/114242 | 15:12 |
| *** jistr has quit IRC | 15:12 | |
| *** jistr has joined #openstack-ironic | 15:13 | |
| devananda | morning, all | 15:14 |
| jroll | mornin devananda | 15:15 |
| NobodyCam | good morning devananda | 15:15 |
| rloo | hi devananda | 15:16 |
| lucasagomes | devananda, morning | 15:16 |
| lucasagomes | devananda, I know it's early there, but lemme ask you something about a dbapi (it's very old) https://review.openstack.org/#/c/30305/ | 15:17 |
| lucasagomes | devananda, the reserve/release_node() methods still pretty much the same. My concern is about the release_node() why it requires us to pass the tag again? | 15:18 |
| lucasagomes | I was thinking about changing that behavior since we can't add more than one tag per node | 15:18 |
| dtantsur | devananda, morning! | 15:18 |
| lucasagomes | so imo release_node only needs the node_id parameter | 15:19 |
| lucasagomes | devananda, jroll also it would be good to have ur opnion on the discussion going on here https://review.openstack.org/#/c/112351/ | 15:20 |
| *** dlaube has joined #openstack-ironic | 15:20 | |
| lucasagomes | ^ involves a accepted blueprint | 15:21 |
| *** Hefeweiz1n is now known as Hefeweizen | 15:21 | |
| NobodyCam | woohoo /me now has a working test env, again :-p | 15:21 |
| dlaube | g'morning | 15:22 |
| devananda | lucasagomes: to prevent another conductor from releasing a lock it didn't hold | 15:23 |
| jroll | lucasagomes: :| | 15:24 |
| lucasagomes | devananda, oh right, yeah | 15:24 |
| jroll | lucasagomes: lifeless and I chatted about that yesterday already, we still disagree | 15:24 |
| lucasagomes | jroll, right... so let's talk more about it, cause we have 3 weeks tops to get that merged or the blueprint will be dropped | 15:25 |
| jroll | lucasagomes: I'm with you on your last comment there | 15:25 |
| jroll | I want to land that patch today or tomorrow, fwiw :P | 15:26 |
| jroll | (as ellen's last day of her internship is tomorrow) | 15:26 |
| jroll | but I can take the patch over if we don't | 15:26 |
| *** teju has left #openstack-ironic | 15:27 | |
| lucasagomes | right, yeah... it would be good to have a consensus about it (I mean that should have happened at spec time, but I don't wanna step on others ppl toes) | 15:27 |
| *** dutsmoc is now known as comstud | 15:27 | |
| jroll | well, I know that you, devananda, and I are +1 on it | 15:27 |
| lucasagomes | ok let's ask other cores to comment on that then | 15:28 |
| jroll | ok, I can comment as well for the record | 15:29 |
| lucasagomes | NobodyCam, rloo, Haomeng, yuriyz if you guys can please jump in the discussion happen at https://review.openstack.org/#/c/112351/ it would be good to know what you think (that's priority because we have a spec approved for that) | 15:29 |
| lucasagomes | Shrews, ^ | 15:29 |
| lucasagomes | actually everyone interested should go there and comment about it ^ | 15:30 |
| * devananda just commented on it | 15:30 | |
| * NobodyCam refreshes | 15:31 | |
| dtantsur | What I really agree is that the very idea of the spec should be questioned while spec is under review, otherwise the whole spec process is ~useless | 15:33 |
| dtantsur | So unless we found a serious problem, we'd better continue landing what is planned to land | 15:34 |
| * jroll comments | 15:34 | |
| rloo | lucasagomes, etc. So the question is with the spec itself, ie, whether to have things pluggable? We need this if someone doesn't want to use neutron? (I haven't read the spec, just some comments here.) | 15:34 |
| *** jistr has quit IRC | 15:34 | |
| devananda | dtantsur: right. | 15:35 |
| devananda | rloo: yes | 15:35 |
| lucasagomes | rloo, ^ yeah | 15:35 |
| rloo | devananda: thx. Seems easy then. +1. | 15:35 |
| lucasagomes | yeah ok +1, indeed the dicsussion time is over | 15:35 |
| jroll | y'all should review that patch while you're in there :P | 15:35 |
| dtantsur | sorry tomorrow, have to run right now | 15:36 |
| dtantsur | see you | 15:36 |
| *** dtantsur is now known as dtantsur|afk | 15:36 | |
| jroll | devananda: these are now passing tempest and everything, want to get them through so mrda-away has reason to stab me? :) https://review.openstack.org/#/c/108545/ and https://review.openstack.org/#/c/113036/ | 15:36 |
| jroll | I can't get no! devstack reeeeviews! la la laaaaa | 15:45 |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Allow rebuild of node in ERROR state https://review.openstack.org/114281 | 15:56 |
| lucasagomes | NobodyCam, lol sorry I just reviewed that patch | 15:58 |
| lucasagomes | straight after ur comment | 15:58 |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Allow rebuild of node in ERROR state https://review.openstack.org/114281 | 16:04 |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Allow rebuild of node in ERROR state https://review.openstack.org/114281 | 16:05 |
| NobodyCam | lol its all good lucasagomes :) | 16:05 |
| Shrews | lucasagomes: sorry, was at the dentist. but, yeah, past discussion time on the dhcp thing (though I do agree with the change) | 16:05 |
| lucasagomes | Shrews, yeah, dtantsur|afk and deva just made a good point about that, discussion time is over :) | 16:06 |
| lucasagomes | but thanks | 16:06 |
| rloo | I do think it is healthy for people to bring up objections. Just wondering, how/when is it past discussion time? | 16:07 |
| NobodyCam | export DIB_REPOLOCATION_ironic=https://review.openstack.org/openstack/ironic | 16:07 |
| NobodyCam | doh ww | 16:08 |
| *** bvivek has quit IRC | 16:12 | |
| lucasagomes | rloo, spec time? | 16:12 |
| lucasagomes | rloo, or also, as deva pointed, mid-cycle, design session at summit? | 16:13 |
| rloo | lucasagomes: I think there should be an avenue for folks to disagree even after a spec has been approved. Ie, I don't think it is acceptable to have a 'the spec has been approved, so no more discussion'. | 16:13 |
| jroll | yeah, I think it's fine to disagree | 16:13 |
| jroll | at spec / summit / midcycle time would be best | 16:14 |
| jroll | but like, can't always make those | 16:14 |
| rloo | lucasagomes: in this case, wrt architecture -- that is different since it was an architecture thing. But anyway, I want to make sure we don't just ignore folks if they disagree. | 16:14 |
| jroll | what lifeless did there was fine | 16:14 |
| devananda | if someoen disagrees with whether a feature should ever be implemented | 16:14 |
| jroll | but clearly the other cores think it is a useful thing | 16:14 |
| jroll | and so we move ahead | 16:14 |
| devananda | but they don't participate in the process to review and approve features, and wait until after others have already approved it | 16:14 |
| devananda | to come to the table and say "wait! that feature should NEVER be done!" | 16:15 |
| devananda | I kinda don't feel like that's participation | 16:15 |
| devananda | (assuming that there was ample design time) | 16:15 |
| devananda | and, in this case, this feature has been discussed and proposed since the summit | 16:15 |
| jroll | yeah, maybe I'm wrong. idk. I don't ever think it's wrong to voice opinions, though.... just be prepared to get shut down | 16:16 |
| rloo | devananda: yeah, so that's the 'build karma' thing ;) | 16:16 |
| devananda | and lifeless and I have continually disagreed on it every time i've discussed it with him | 16:16 |
| devananda | to paraphrase, aiui, he would rather see all openstack projects so tightly coupled as to be monolithic -- all or nothing | 16:16 |
| devananda | I would rather see them loosely coupled | 16:16 |
| jroll | that's what I got out of the conversation last night | 16:17 |
| devananda | so he will always reject proposals to decouple ironic's dependence on other integrated projects | 16:17 |
| rloo | +1 for loosely coupled. Surprised at lifeless' viewpoint. | 16:17 |
| lucasagomes | yeah I like to be pluggable, I think it makes sense and is aligned with the OpenStack architeture in being a component based design | 16:17 |
| lucasagomes | so people choose what to deploy | 16:18 |
| devananda | exactly | 16:18 |
| devananda | empower users with choice | 16:18 |
| jroll | so, his viewpoint was that the pluggability should happen in neutron. if you don't want neutron managing dhcp, you should write a no-op dhcp provider for neutron and run with that. | 16:18 |
| devananda | his point is: neutron gives them that choice. | 16:18 |
| lucasagomes | yup, but that still require you to actually _deploy_ neutron | 16:19 |
| lucasagomes | even if it's in a non-op way | 16:19 |
| lucasagomes | I mean... neutron does more than DHCP | 16:19 |
| jroll | right. | 16:19 |
| lucasagomes | so, sounds wrong | 16:19 |
| russell_h | for what its worth, in a perfect world I think he's right | 16:19 |
| rloo | but if neutron doesn't have a no-op dhcp provider, it would be useful for it to have one. | 16:20 |
| jroll | russell_h: in the perfect world where "running software" == "push a button" ? :) | 16:20 |
| devananda | rloo: fwiw, if someone pointed out a serious architectural flaw in a spec after we had approved it, I would certainly welcome that and we'd need to re-evaluate the spec. that's still better than pointing it out after the code is landed. | 16:21 |
| russell_h | jroll: and building and maintaining it | 16:21 |
| rloo | seems like in a close-to-perfect-world, you'd have the choice to do either way ;) | 16:21 |
| jroll | russell_h: riiiight. sounds great. | 16:21 |
| devananda | russell_h: if all software was trivially simple to install, operate, and upgrade -- and infinitely scalable, sure. but it's not. | 16:21 |
| russell_h | exactly | 16:21 |
| lucasagomes | heh | 16:21 |
| * lucasagomes would like to have Ironic as a standalone tool :) we are outgrowing OpenStack | 16:22 | |
| devananda | russell_h: neutron is quite complex. some people may choose not to run it at all. | 16:22 |
| Shrews | devananda: ++. i'd gleefully welome someone pointing out a major flaw after a spec was approved | 16:22 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Take iSCSI deploy out of pxe driver https://review.openstack.org/111232 | 16:24 |
| *** ellenh1 has joined #openstack-ironic | 16:24 | |
| NobodyCam | lucasagomes: ++++++++++ | 16:29 |
| *** jcoufal has joined #openstack-ironic | 16:30 | |
| *** Guest54676 is now known as mgagne | 16:30 | |
| *** mgagne has joined #openstack-ironic | 16:30 | |
| devananda | lucasagomes: do you still have an etherpad walkthrough for using devstack + ironic w/ real hardware? | 16:40 |
| *** pelix has quit IRC | 16:40 | |
| *** pelix has joined #openstack-ironic | 16:41 | |
| lucasagomes | devananda, hmm I have that old one that had 4 guides on it | 16:41 |
| lucasagomes | needs update but, mostly info there should still be valid (warning on the instance_info stuff) | 16:41 |
| lucasagomes | https://etherpad.openstack.org/p/IronicDeployDevstack | 16:41 |
| *** ndipanov is now known as ndipanov_gone | 16:42 | |
| devananda | I'd realy like to see docs or a wiki showing folks how to configure devstack+ironic+neutron for physical hardware | 16:42 |
| devananda | thanks | 16:42 |
| lucasagomes | yeah, that would be quite useful indeed | 16:42 |
| devananda | lucasagomes: that is only for VMs :( | 16:44 |
| lucasagomes | oh, urgh... thought that some of the guides was to real bm | 16:45 |
| lucasagomes | hmm... /me tries to find something for real bm | 16:45 |
| devananda | i thought you had done one too | 16:45 |
| *** derekh has quit IRC | 16:45 | |
| lucasagomes | yeah, well danprice uses ironic with real baremetal and iboot (so should only be a question of changing the driver to ipmitool if need ipmi) | 16:46 |
| lucasagomes | I think I wrote some info somewhere long time ago about setting that up | 16:46 |
| lucasagomes | dunno where is it tho :/ | 16:46 |
| *** keekz_ is now known as keekz | 16:46 | |
| *** keekz is now known as keekz_ | 16:46 | |
| devananda | hm, k | 16:46 |
| lucasagomes | aight I ll call it a day, gotta take the train back home yet | 16:51 |
| lucasagomes | have a good night everybody | 16:51 |
| NobodyCam | have a good night lucasagomes | 16:51 |
| *** lucasagomes has quit IRC | 16:52 | |
| *** harlowja has joined #openstack-ironic | 16:56 | |
| *** penick has joined #openstack-ironic | 17:02 | |
| jroll | devananda: I could probably do a guide like that for real hardware with pxe_ipmitool and agent_ipmitool | 17:05 |
| devananda | jroll: please do | 17:06 |
| jroll | I'd like to get upstream master running in our lab | 17:06 |
| jroll | maybe both of those drivers side-by-side >:) | 17:06 |
| devananda | ++ | 17:06 |
| jroll | I'll do my best, things may come up | 17:06 |
| SpamapS | | 10f15629-b79a-41f9-8d85-70cf7a5cfb82 | overcloud-NovaCompute1-eab3goteleu4 | ERROR | rebuild_spawning | Running | ctlplane=192.0.2.30 | | 17:07 |
| SpamapS | third time in 3 days | 17:07 |
| jroll | but it's something I've wanted to do anyway | 17:07 |
| SpamapS | no idea why because the machine gets powered off | 17:07 |
| jroll | SpamapS: comment out the code that turns it off | 17:07 |
| *** krtaylor has quit IRC | 17:07 | |
| SpamapS | oy | 17:08 |
| NobodyCam | SpamapS: just fyi: https://review.openstack.org/#/c/114281/3 | 17:08 |
| * jroll be back in an hour or so | 17:08 | |
| SpamapS | oh my | 17:08 |
| SpamapS | NobodyCam: patches that simple scare me. ;) | 17:08 |
| SpamapS | "if it was that easy..." | 17:08 |
| NobodyCam | SpamapS: it need lots more work | 17:08 |
| NobodyCam | needs even | 17:08 |
| NobodyCam | I'm just doing poc testing now | 17:09 |
| SpamapS | NobodyCam: cool | 17:09 |
| NobodyCam | lol or lat least tring to | 17:09 |
| SpamapS | I actually think it may be a symptom of something really broken in tripleo devtest.. networking seems to grind to a halt after a while | 17:10 |
| *** ellenh1 has quit IRC | 17:17 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/ironic: Handle all exceptions from _exec_ipmitool https://review.openstack.org/114090 | 17:25 |
| *** penick has quit IRC | 17:27 | |
| *** penick has joined #openstack-ironic | 17:31 | |
| *** krtaylor has joined #openstack-ironic | 17:31 | |
| *** rloo has quit IRC | 17:32 | |
| *** Alexei_9871 has quit IRC | 17:44 | |
| *** ellenh1 has joined #openstack-ironic | 17:47 | |
| *** pelix has quit IRC | 17:52 | |
| jroll | devananda: friendly reminder to look at https://review.openstack.org/#/c/108545/ and https://review.openstack.org/#/c/113036/ | 18:36 |
| devananda | jroll: no fixes-bug tag ? | 18:37 |
| jroll | gah. | 18:37 |
| jroll | sec | 18:37 |
| *** chuckC has quit IRC | 18:38 | |
| jroll | huh, thought we had a bug for this. | 18:40 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Use cache in node_is_available() https://review.openstack.org/113036 | 18:41 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Query full node details and cache https://review.openstack.org/108545 | 18:42 |
| jroll | devananda: ^^ | 18:42 |
| openstackgerrit | Ellen Hui proposed a change to openstack/ironic: Make DHCP provider pluggable https://review.openstack.org/112351 | 18:43 |
| openstackgerrit | Ellen Hui proposed a change to openstack/ironic: Make DHCP provider pluggable https://review.openstack.org/112351 | 18:54 |
| *** rloo has joined #openstack-ironic | 18:55 | |
| linggao | Hi everyone, does anyone know how to add an additional conductor in the cloud? I added one, ironic puts sends the request to it. But dnsmasq failed to put the tftp files and images on it when node is booting. | 18:57 |
| devananda | linggao: are you running with neutron? | 18:57 |
| linggao | devananda, yes. | 18:57 |
| linggao | now the tftp files and images are always put on the neutron server. | 18:58 |
| devananda | "on the neutron server" huh? | 18:58 |
| devananda | they should be on the irnoic-conductor server | 18:59 |
| linggao | where the first conductor is. | 18:59 |
| linggao | and that is where dnsmasq is running. | 19:00 |
| devananda | linggao: make sure each conductor's config has correct [pxe] tftp_server address | 19:00 |
| devananda | that should be the IP of that conductor | 19:00 |
| devananda | if you are using pxe driver | 19:00 |
| linggao | yes, they are correct now. | 19:01 |
| devananda | check system logs for incoming tftp conenctions | 19:01 |
| NobodyCam | linggao: also would be supper helpful for other folks to maybe have a walk thru of issues you encounter attempting to add a conductor :) | 19:01 |
| NobodyCam | linggao: if you're up for wrighting such a doc | 19:02 |
| linggao | NobodyCam, yes, I am very glad to write a doc on it. | 19:02 |
| NobodyCam | :) awesome TY :) | 19:03 |
| linggao | as long as I can make it work :) | 19:03 |
| NobodyCam | hehehehe | 19:03 |
| NobodyCam | you will :) | 19:03 |
| dlaube | linggao: I'd be interested in seeing such a doc as well ;) | 19:03 |
| linggao | devananda, NobodyCam, so what neutron services should be turned on on this new conductor node? | 19:03 |
| linggao | dlaube, only if I can make it working :) | 19:04 |
| devananda | linggao: neutron does not need to run on the conductor itself | 19:04 |
| linggao | devananda, then how does dhcp know to send images and tftp conf files to that conductor? | 19:05 |
| linggao | is it done by Ironic? | 19:05 |
| * devananda has to join a meeting | 19:05 | |
| linggao | or by neutron, dnsmasq or someting else? | 19:06 |
| *** chuckC has joined #openstack-ironic | 19:10 | |
| NobodyCam | linggao: ironic conductor updates neutron with the info | 19:23 |
| *** ellenh1 has quit IRC | 19:23 | |
| linggao | NobodyCam, yes, I was wrong that the images are not on the new conductor. | 19:24 |
| NobodyCam | :) | 19:25 |
| linggao | In fact the images and the config file are on the correct conductor. | 19:25 |
| linggao | The problem is that it the node goes to the node where dnsmaq is for config file. | 19:28 |
| linggao | I'll look more into it... | 19:28 |
| lifeless | devananda: huh | 19:50 |
| lifeless | devananda: rloo: I'm a huge advocate of loosely coupled | 19:50 |
| lifeless | devananda: rloo: looselt coupled doesn't mean 'have many implemenations of abstraction points' | 19:50 |
| rloo | lifeless: yes, but 2 is not many? | 19:51 |
| lifeless | rloo: for this specific case - one implementation in neutron, one implementation in Ironic | 19:52 |
| openstackgerrit | Rakesh H S proposed a change to openstack/ironic: IPMI double bridging functionality https://review.openstack.org/95775 | 19:52 |
| lifeless | rloo: of an abstraction point that adds no value to Ironic since we can use the abstraction from Neutron | 19:53 |
| jroll | lifeless: it's absolutely silly to have an HTTP REST API for a noop | 19:53 |
| rloo | lifeless: true, if you use Neutron. But if you don't want to use Neutron? | 19:53 |
| lifeless | jroll: its also silly to implement an isc dhcp driver twice :) | 19:54 |
| jroll | I'm not implementing a driver | 19:54 |
| lifeless | I know | 19:54 |
| jroll | I'm not implementing dynamically configured isc | 19:54 |
| *** penick has quit IRC | 19:59 | |
| *** ellenh1 has joined #openstack-ironic | 20:02 | |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Allow rebuild of node in ERROR state https://review.openstack.org/114281 | 20:06 |
| *** jasondotstar has quit IRC | 20:19 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/114057 | 20:24 |
| lifeless | jroll: look,we had a fine conversation yesterday | 20:28 |
| lifeless | jroll: only reason I brought it up at all now was to say to devananda and rloo that devananda is not representing my opinion | 20:29 |
| *** igordcard has quit IRC | 20:29 | |
| jroll | lifeless: yeah, it's fine, I don't want to argue again either :) | 20:30 |
| lifeless | jroll: the technical merits of achieving your goals several different ways are whats in discussion, and thats all in the context of openstack as a project | 20:30 |
| lifeless | jroll: "your" goals - I recognise there are other folk wanting to vary things too | 20:30 |
| lifeless | jroll: so I'm not intending to make this personal | 20:30 |
| lifeless | just loose language | 20:30 |
| jroll | right, I understand | 20:30 |
| rloo | lifeless: I am glad you clarified things ;) | 20:34 |
| lifeless | devananda: for reference - loosely coupled refers to the ability to vary things independently, safely - and thats actually *why* I am advocating that we depend on the API, because then the entire implementation can be switched out behind the API and we don't need to know about it | 20:35 |
| devananda | lifeless: first, that means ironic is coupled to that API. second, you're suggesting that reimplementing neutron is preferrable to writing a small plugin in ironic that does Just One Thing. | 20:36 |
| lifeless | devananda: reimplementing just enough of neutron to do dhcp port updates | 20:38 |
| lifeless | devananda: I also argued that neutron should be a bunch of separate apis yesterday | 20:38 |
| lifeless | devananda: which you may have missed | 20:38 |
| devananda | yes | 20:38 |
| lifeless | and yes, I'm suggesting for a bunch of reasons that Ironic knowing what DHCP implementation its using is a mistake | 20:39 |
| lifeless | it increases test burden | 20:39 |
| lifeless | code size | 20:39 |
| lifeless | supported APIs that we have to carry going forward | 20:39 |
| lifeless | devananda: I would have commented on that spec, but I didn't see it go past - time is finite | 20:41 |
| lifeless | devananda: and I'm not blocking this, I -1, not -2'd it. | 20:41 |
| *** rushiagr is now known as rushiagr_away | 20:47 | |
| *** penick has joined #openstack-ironic | 20:50 | |
| *** linggao has quit IRC | 20:55 | |
| *** mrda-away is now known as mrda | 20:55 | |
| mrda | Morning Ironic! | 20:55 |
| NobodyCam | morning mrda \o/ | 20:56 |
| jroll | mrda! hi | 20:56 |
| NobodyCam | brb | 20:56 |
| mrda | jroll: You just have to ask re: those reviews :) | 20:56 |
| jroll | ask what? | 20:56 |
| mrda | about getting those reviews added to the review chain so I have a reason to stab you :) | 20:57 |
| * mrda just read my highlight in scrollback :) | 20:57 | |
| jroll | oh heh | 20:57 |
| jroll | I need them approved in ironic first :P | 20:57 |
| mrda | Right, so get on that :) | 20:58 |
| *** jcoufal has quit IRC | 20:58 | |
| jroll | I've been trying :/ | 20:58 |
| mrda | Once ironic's happy I'll happily get that appended to the Nova review train | 20:58 |
| jroll | yeah | 20:58 |
| jroll | just... make it clear to those folks that it's important :/ | 20:58 |
| mrda | sure | 20:58 |
| jroll | I wouldn't feel right releasing juno without those | 20:58 |
| mrda | you just need to use your core power for mind control | 20:59 |
| jroll | even though i think releases are weird | 20:59 |
| jroll | heh | 20:59 |
| * jroll just approves them :P | 20:59 | |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed a change to openstack/ironic: Add UEFI based deployment support in Ironic https://review.openstack.org/114357 | 21:00 |
| *** penick has quit IRC | 21:02 | |
| *** penick has joined #openstack-ironic | 21:07 | |
| jroll | ellenh1: you got one +2 :) https://review.openstack.org/#/c/112351/ | 21:09 |
| ellenh1 | jroll: yay! :D | 21:12 |
| ellenh1 | + thanks! | 21:13 |
| jroll | :) | 21:14 |
| *** tatyana has joined #openstack-ironic | 21:20 | |
| rloo | jroll: wrt 1084442, I think I am missing something. What does _parse_driver_info doing validation have to do with the change? | 21:30 |
| jroll | rloo: I agree that the d_info param should be removed from _destroy_images, I disagree that it solves this problem | 21:37 |
| jroll | rloo: we would still want to call _parse_deploy_info in clean_up | 21:38 |
| jroll | idk, maybe it could be just called in _get_image_info | 21:38 |
| jroll | I guess either way | 21:38 |
| rloo | jroll: yeah, that's what I was thinking. that it'd be called in _get_image_info, so no need to change that part (at least not for this particular case). | 21:39 |
| jroll | hmm, yeah | 21:40 |
| jroll | although | 21:40 |
| rloo | jroll: OTOH, if in the future _destroy_images actually needs the driver info, that'd be a different story, but I can't foresee the future. | 21:40 |
| jroll | yeah... you might be right | 21:40 |
| * jroll changes his vote | 21:40 | |
| rloo | jroll: it isn't that his change is wrong, I just wondered why he didn't address yuriy's comments. | 21:41 |
| rloo | jroll: ie, i could be convinced that his change is OK, but someone needs to convince me ;) | 21:41 |
| jroll | yeah | 21:41 |
| jroll | I think your way is better | 21:41 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add support for creating vfat disk images https://review.openstack.org/105413 | 21:42 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add support for interacting with swift https://review.openstack.org/105795 | 21:46 |
| *** openstackgerrit has quit IRC | 21:46 | |
| *** openstackgerrit has joined #openstack-ironic | 21:48 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Query full node details and cache https://review.openstack.org/108545 | 21:49 |
| jroll | uh | 21:49 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Use cache in node_is_available() https://review.openstack.org/113036 | 21:50 |
| jroll | ok | 21:50 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: IloVirtualMediaIscsi deploy driver https://review.openstack.org/113865 | 21:54 |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Allow rebuild of node in ERROR and DEPLOYFAIL state https://review.openstack.org/114281 | 21:55 |
| NobodyCam | lol +4 lines of code +75 lines of tests | 21:55 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Replace incomplete "ilo" driver with pxe_ilo and fake_ilo https://review.openstack.org/113346 | 22:02 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Replace incomplete "ilo" driver with pxe_ilo and fake_ilo https://review.openstack.org/113346 | 22:02 |
| *** ellenh2 has joined #openstack-ironic | 22:02 | |
| *** ellenh2 is now known as ellenh | 22:03 | |
| *** ellenh1 has quit IRC | 22:04 | |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Allow rebuild of node in ERROR and DEPLOYFAIL state https://review.openstack.org/114281 | 22:06 |
| *** dlaube has quit IRC | 22:07 | |
| *** rloo is now known as rloo_afk | 22:09 | |
| *** dlaube has joined #openstack-ironic | 22:12 | |
| * devananda wanders off in search of food | 22:12 | |
| *** tatyana has quit IRC | 22:17 | |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed a change to openstack/ironic: Add UEFI based deployment support in Ironic https://review.openstack.org/114357 | 22:20 |
| dlaube | coffee time | 22:22 |
| *** penick has quit IRC | 22:31 | |
| NobodyCam | ok I too will brb | 22:32 |
| *** penick has joined #openstack-ironic | 22:33 | |
| *** jgrimm has quit IRC | 22:37 | |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Allow rebuild of node in ERROR and DEPLOYFAIL state https://review.openstack.org/114281 | 22:46 |
| *** zer0c00l1 has joined #openstack-ironic | 22:56 | |
| *** penick has quit IRC | 23:03 | |
| *** krtaylor has quit IRC | 23:07 | |
| *** chuckC has quit IRC | 23:08 | |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Allow rebuild of node in ERROR and DEPLOYFAIL state https://review.openstack.org/114281 | 23:08 |
| *** penick has joined #openstack-ironic | 23:10 | |
| *** penick has quit IRC | 23:11 | |
| *** penick has joined #openstack-ironic | 23:12 | |
| *** keekz_ is now known as keekz | 23:16 | |
| jroll | ugh, my patches are all weird | 23:32 |
| mrda | jroll: you're telling me! :P | 23:33 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Use cache in node_is_available() https://review.openstack.org/113036 | 23:33 |
| jroll | no like | 23:33 |
| jroll | I submitted them together and one had an outdated dep :/ | 23:33 |
| mrda | jroll: yeah, I had some wiredness a couple of days ago that I can't explain. I just put it down to PEPKAC but I'm not sure what I did that was wrong. | 23:34 |
| jroll | Shrews: I still can't get any love from the devstack cores :( | 23:34 |
| jroll | mrda: I always blame git-review :P | 23:34 |
| mrda | yup :) | 23:35 |
| *** chuckC has joined #openstack-ironic | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
