| devananda | NobodyCam: back | 00:01 |
|---|---|---|
| *** datajerk has quit IRC | 00:01 | |
| NobodyCam | :) see om | 00:01 |
| NobodyCam | pm even | 00:01 |
| openstackgerrit | A change was merged to openstack/ironic: If no block devices abort deployment https://review.openstack.org/59493 | 00:01 |
| *** rongze has quit IRC | 00:04 | |
| *** hemna has quit IRC | 00:30 | |
| *** matsuhashi has joined #openstack-ironic | 00:31 | |
| *** lucas-dinner has quit IRC | 00:45 | |
| *** openstack has joined #openstack-ironic | 00:46 | |
| *** datajerk has joined #openstack-ironic | 00:50 | |
| *** yfujioka has quit IRC | 00:54 | |
| *** openstackgerrit has quit IRC | 00:56 | |
| *** openstackgerrit has joined #openstack-ironic | 00:56 | |
| *** kui has joined #openstack-ironic | 01:33 | |
| *** nosnos has joined #openstack-ironic | 01:35 | |
| *** nosnos_ has joined #openstack-ironic | 01:37 | |
| *** nosnos has quit IRC | 01:40 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add config option for # of conductor replicas https://review.openstack.org/59794 | 01:41 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: list_active_conductor_drivers returns dict of sets https://review.openstack.org/59795 | 01:41 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement sync_power_state periodic task https://review.openstack.org/56530 | 01:41 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add prepare and cleanup methods to deploy interface https://review.openstack.org/58894 | 01:41 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement consistent hashing of nodes <-> conductors https://review.openstack.org/58895 | 01:41 |
| devananda | afk a bit | 01:42 |
| *** epim has quit IRC | 01:44 | |
| *** rongze has joined #openstack-ironic | 02:01 | |
| *** rongze has quit IRC | 02:01 | |
| *** rongze has joined #openstack-ironic | 02:02 | |
| *** rwsu has quit IRC | 02:35 | |
| *** rwsu has joined #openstack-ironic | 02:39 | |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Expose created_at/updated_at properties in the REST API https://review.openstack.org/53627 | 02:44 |
| Haomeng | devananda: ping | 02:45 |
| *** yfujioka has joined #openstack-ironic | 03:01 | |
| *** vkozhukalov has joined #openstack-ironic | 03:09 | |
| *** shadower_ has joined #openstack-ironic | 03:16 | |
| *** shadower has quit IRC | 03:17 | |
| *** rainya has quit IRC | 03:17 | |
| *** sandeepr has quit IRC | 03:17 | |
| *** mugu has quit IRC | 03:17 | |
| *** sandeepr has joined #openstack-ironic | 03:18 | |
| *** harlowja has quit IRC | 03:19 | |
| *** rainya has joined #openstack-ironic | 03:19 | |
| *** mugu has joined #openstack-ironic | 03:20 | |
| *** rloo has quit IRC | 04:07 | |
| *** sandeepr has left #openstack-ironic | 04:24 | |
| *** datajerk has quit IRC | 04:32 | |
| *** nosnos has joined #openstack-ironic | 04:38 | |
| *** nosnos_ has quit IRC | 04:42 | |
| *** rongze has quit IRC | 04:45 | |
| *** prekarat has quit IRC | 05:01 | |
| *** datajerk has joined #openstack-ironic | 05:02 | |
| *** datajerk has quit IRC | 05:07 | |
| *** rongze has joined #openstack-ironic | 05:16 | |
| *** yjiang5_1 has joined #openstack-ironic | 05:17 | |
| *** rainya has quit IRC | 05:20 | |
| *** michchap_ has joined #openstack-ironic | 05:21 | |
| *** yjiang5 has quit IRC | 05:22 | |
| *** michchap has quit IRC | 05:22 | |
| *** mugu has quit IRC | 05:22 | |
| *** rainya has joined #openstack-ironic | 05:22 | |
| *** mugu has joined #openstack-ironic | 05:23 | |
| *** rongze has quit IRC | 05:28 | |
| *** yfujioka has quit IRC | 05:48 | |
| *** rongze has joined #openstack-ironic | 05:58 | |
| openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/59627 | 06:05 |
| *** kui has quit IRC | 06:21 | |
| *** rongze has quit IRC | 06:30 | |
| *** rongze has joined #openstack-ironic | 06:30 | |
| *** nosnos has quit IRC | 06:34 | |
| *** nosnos has joined #openstack-ironic | 06:35 | |
| *** prekarat has joined #openstack-ironic | 06:37 | |
| *** jcooley_ has joined #openstack-ironic | 06:41 | |
| *** jcooley_ has quit IRC | 06:51 | |
| *** vkozhukalov has quit IRC | 06:51 | |
| *** nosnos_ has joined #openstack-ironic | 07:05 | |
| *** nosnos has quit IRC | 07:08 | |
| *** rwsu has quit IRC | 07:24 | |
| *** urulama has joined #openstack-ironic | 07:28 | |
| *** datajerk has joined #openstack-ironic | 07:36 | |
| *** urulama_ has joined #openstack-ironic | 07:37 | |
| *** urulama has quit IRC | 07:40 | |
| *** datajerk has quit IRC | 07:40 | |
| *** rwsu has joined #openstack-ironic | 07:48 | |
| *** tatyana has joined #openstack-ironic | 07:52 | |
| *** datajerk has joined #openstack-ironic | 08:06 | |
| *** datajerk has quit IRC | 08:11 | |
| *** ndipanov has joined #openstack-ironic | 08:15 | |
| *** jistr has joined #openstack-ironic | 08:18 | |
| *** nosnos_ has quit IRC | 08:19 | |
| *** nosnos has joined #openstack-ironic | 08:19 | |
| *** GheRivero has quit IRC | 08:22 | |
| *** martyntaylor has joined #openstack-ironic | 08:28 | |
| *** vkozhukalov has joined #openstack-ironic | 08:30 | |
| *** matsuhashi has quit IRC | 08:35 | |
| *** matsuhashi has joined #openstack-ironic | 08:36 | |
| *** martyntaylor has quit IRC | 08:46 | |
| *** martyntaylor has joined #openstack-ironic | 09:00 | |
| *** zigo has joined #openstack-ironic | 09:05 | |
| *** retr0h_ has joined #openstack-ironic | 09:07 | |
| *** retr0h has quit IRC | 09:12 | |
| *** zigo_ has quit IRC | 09:12 | |
| *** derekh has joined #openstack-ironic | 09:15 | |
| *** max_lobur_afk is now known as max_lobur | 09:24 | |
| *** lucasagomes has joined #openstack-ironic | 09:31 | |
| *** romcheg has quit IRC | 09:32 | |
| *** nosnos_ has joined #openstack-ironic | 10:03 | |
| *** nosnos has quit IRC | 10:06 | |
| openstackgerrit | Max Lobur proposed a change to openstack/python-ironicclient: Let CLI print exception traceback from 'debuginfo' https://review.openstack.org/59038 | 10:11 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: API ports update for WSME 0.5b6 compliance https://review.openstack.org/56682 | 10:15 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Rework patch validation on Ports https://review.openstack.org/56984 | 10:16 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Node validations https://review.openstack.org/57495 | 10:20 |
| *** matsuhashi has quit IRC | 10:22 | |
| *** datajerk has joined #openstack-ironic | 10:41 | |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Save PKI token in a file for PXE deploy ramdisk https://review.openstack.org/59066 | 10:43 |
| *** matsuhashi has joined #openstack-ironic | 10:45 | |
| *** datajerk has quit IRC | 10:45 | |
| *** jistr has quit IRC | 10:46 | |
| *** rongze has quit IRC | 10:53 | |
| *** prekarat has quit IRC | 11:04 | |
| *** jistr has joined #openstack-ironic | 11:09 | |
| *** rongze has joined #openstack-ironic | 11:11 | |
| *** datajerk has joined #openstack-ironic | 11:12 | |
| *** datajerk has quit IRC | 11:16 | |
| max_lobur | morning lucasagomes, I've almost prepared stable/havana + latest Ironic env using devstack | 11:36 |
| max_lobur | https://gist.github.com/max-lobur/7786074 here are a few notes | 11:36 |
| max_lobur | you asked me to ping you when I have something | 11:36 |
| lucasagomes | max_lobur, w00ts! will take a look | 11:39 |
| lucasagomes | thank you | 11:39 |
| *** rongze has quit IRC | 11:45 | |
| *** rongze has joined #openstack-ironic | 11:51 | |
| *** max_lobur is now known as max_lobur_afk | 11:57 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Handle DBDuplicateEntry on Ports with same address https://review.openstack.org/59955 | 12:04 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Handle DBDuplicateEntry on Ports with same address https://review.openstack.org/59955 | 12:05 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Node validations https://review.openstack.org/57495 | 12:29 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Node validations https://review.openstack.org/57495 | 12:34 |
| *** shadower_ is now known as shadower | 12:43 | |
| *** max_lobur_afk is now known as max_lobur | 12:52 | |
| *** urulama_ has quit IRC | 12:53 | |
| *** lucasagomes is now known as lucas-hungry | 12:59 | |
| *** matsuhashi has quit IRC | 13:03 | |
| *** nosnos_ has quit IRC | 13:07 | |
| *** nosnos has joined #openstack-ironic | 13:08 | |
| *** datajerk has joined #openstack-ironic | 13:12 | |
| *** jdob has joined #openstack-ironic | 13:14 | |
| *** datajerk has quit IRC | 13:15 | |
| *** datajerk has joined #openstack-ironic | 13:18 | |
| *** matsuhashi has joined #openstack-ironic | 13:32 | |
| *** nosnos has quit IRC | 13:39 | |
| *** datajerk has quit IRC | 13:40 | |
| *** rloo has joined #openstack-ironic | 13:48 | |
| *** datajerk has joined #openstack-ironic | 13:50 | |
| *** datajerk has quit IRC | 13:56 | |
| *** lucas-hungry is now known as lucasagomes | 14:03 | |
| *** datajerk has joined #openstack-ironic | 14:13 | |
| *** rongze has quit IRC | 14:14 | |
| *** rongze has joined #openstack-ironic | 14:18 | |
| *** jbjohnso has joined #openstack-ironic | 14:21 | |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Add power control to PXE driver https://review.openstack.org/50409 | 14:22 |
| *** datajerk has quit IRC | 14:25 | |
| openstackgerrit | Sascha Peilicke proposed a change to openstack/python-ironicclient: Move six dependency to requirements.txt https://review.openstack.org/59988 | 14:32 |
| *** matty_dubs|gone is now known as matty_dubs | 14:44 | |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Save PKI token in a file for PXE deploy ramdisk https://review.openstack.org/59066 | 14:48 |
| *** jistr has quit IRC | 15:02 | |
| *** jistr has joined #openstack-ironic | 15:04 | |
| *** jistr is now known as jistr|mtg | 15:04 | |
| rloo | hi yuriyz | 15:08 |
| yuriyz | hi rloo | 15:08 |
| rloo | deva mentioned to me yest that you are working on https://review.openstack.org/#/c/55549/ | 15:08 |
| rloo | i'll take a look at it today. but there is this blueprint: https://blueprints.launchpad.net/ironic/+spec/breaking-resource-locks | 15:09 |
| rloo | and there is overlap. I was going to look into the blueprint, but wanted to check with you. | 15:09 |
| yuriyz | yes this partially implements bp | 15:09 |
| yuriyz | but there is my mistake in commit message | 15:10 |
| rloo | were you thinking of doing the bp? I don't want to duplicate your work, and you've started so wanted to see if you wanted to continue. | 15:10 |
| yuriyz | my patch only allows users to clear reservation manually | 15:11 |
| rloo | ok, so you weren't going to look into it any further? | 15:12 |
| yuriyz | maybe a periodic process for clean reservation by timeout reasonable | 15:12 |
| yuriyz | also | 15:12 |
| yuriyz | ask Devananda | 15:12 |
| rloo | he told me to go ahead and work on bp, but i wanted to make sure you weren't going to do it. | 15:13 |
| yuriyz | I work with bug 1250348, and resolved comment by Devananda https://bugs.launchpad.net/ironic/+bug/1250348 | 15:15 |
| rloo | ok thx. | 15:16 |
| yuriyz | this patch doesn't close the BP | 15:16 |
| *** neo_ has quit IRC | 15:16 | |
| rloo | so after the patch is done, you were not going to continue to do anything more related to the BP, right? | 15:18 |
| rloo | because if you wanted to, then I won't. | 15:18 |
| *** lucasagomes_ has joined #openstack-ironic | 15:22 | |
| *** matsuhashi has quit IRC | 15:23 | |
| *** lucasagomes has quit IRC | 15:24 | |
| *** lucasagomes_ is now known as lucasagomes | 15:26 | |
| *** jcooley_ has joined #openstack-ironic | 15:30 | |
| devananda | morning, all | 15:32 |
| rloo | hi devananda | 15:34 |
| *** mattymo has joined #openstack-ironic | 15:38 | |
| *** Maha has joined #openstack-ironic | 15:42 | |
| Maha | Hi | 15:42 |
| Maha | I'm Maha from CloudOS for Moonshot team | 15:43 |
| Maha | I have a question on the PXE setting used with baremetal provisioning | 15:43 |
| NobodyCam | good morning Ironic | 15:44 |
| NobodyCam | Hi Maha | 15:44 |
| Maha | Hi Good Morning | 15:44 |
| NobodyCam | I haven't yet had any coffee but would be happy to try and answer your question | 15:45 |
| *** rongze has quit IRC | 15:46 | |
| Maha | Oh Thanks for that... | 15:46 |
| dkehn | NobodyCam: so using devtest to build, and using your ironic-nova element, I'm seeing an issue when the the undercloud is trying to start:http://paste.openstack.org/show/54432/ | 15:47 |
| dkehn | NobodyCam: once you look at the log would it be wize to remove the ironic-nova from the elements? | 15:47 |
| Maha | In the havana ipmi.py, during reboot and activate node, i'm seeing that "the boot option is set to PXE with persistant option" | 15:48 |
| NobodyCam | Maha: yes the boot flag on the hard disk is not set. | 15:49 |
| NobodyCam | the baremeatal node needs to pxe boot its kernel | 15:49 |
| lucasagomes | hey morning all | 15:50 |
| NobodyCam | morning lucasagomes | 15:50 |
| Maha | So in that case, the node always boots to PXE and not from the hard disk always | 15:50 |
| devananda | g'morning rloo, lucasagomes, dkehn, NobodyCam, Maha! | 15:50 |
| NobodyCam | dkehn: has the node booted? ie do you have console access? | 15:51 |
| NobodyCam | morning devananda | 15:51 |
| NobodyCam | Maha: correct | 15:51 |
| Maha | g'morning devananda | 15:51 |
| devananda | Maha: correct. this is also done for security reasons -- alowing a node to boot from local disk could allow a tenant to "escape" from the control of the nova-baremetal hypervisor | 15:51 |
| devananda | if something were to cause the nova-baremetal process to crash | 15:51 |
| dkehn | NobodyCam: yes, I have console access | 15:51 |
| *** max_lobur is now known as max_lobur_afk | 15:51 | |
| dkehn | NobodyCam: as slow as it is | 15:52 |
| NobodyCam | dkehn: from the console is there a /etc/ironic/ironic.conf file? and if so what is in it? | 15:53 |
| *** jistr|mtg has quit IRC | 15:53 | |
| Maha | Devananda, NobodyCam: So do you advice not to set the boot option to local storage at all? | 15:53 |
| *** vkozhukalov has quit IRC | 15:53 | |
| Maha | for security reasons? | 15:53 |
| NobodyCam | Maha: yes | 15:53 |
| Maha | ok.. | 15:54 |
| Maha | that clarifies | 15:54 |
| Maha | Thanks for the answers | 15:54 |
| Maha | :) | 15:54 |
| devananda | Maha: the only situation we have encountered where it was viewed as necessary and positive is in a tripleo-type deployment | 15:55 |
| devananda | Maha: where the boot-from0local flag would be set on the undercloud nodes | 15:55 |
| devananda | those which are a trusted tenant, providing the services for the overcloud | 15:55 |
| Maha | ok | 15:55 |
| Maha | Devananda: We had a requirement on this. But i will take your inputs on the security issues and also try out local disk settings just t make sure it works in our environment | 15:57 |
| devananda | Maha: there may well be use cases that we had not considered yet, for which it applies | 15:58 |
| devananda | Maha: but keep in mind what happens if a tenant is able to remain on the provisioned node, without any openstack service running in the environment | 15:59 |
| *** jistr has joined #openstack-ironic | 15:59 | |
| *** jistr is now known as jistr|mtg | 16:00 | |
| Maha | Devananda: Yes right. I will gather the use cases that we are targetting and based on that i will come back for more advice suggestion | 16:00 |
| NobodyCam | Maha: I wouold be happy to help where I can | 16:01 |
| *** datajerk has joined #openstack-ironic | 16:02 | |
| *** rongze has joined #openstack-ironic | 16:02 | |
| Maha | devananda, NobodyCam: Thanks for your inputs. I will get back with more details | 16:06 |
| NobodyCam | Maha: please see the PM | 16:06 |
| *** tatyana has quit IRC | 16:07 | |
| dkehn | NobodyCam: no way to paste the ironic.conf from the console, so what are you looking for in the conf file? | 16:08 |
| NobodyCam | dkehn: is it there ? and are there any keys with out values? | 16:09 |
| dkehn | NobodyCam: yes its there, there are keys and sections (i.e. DEFAULT, database, glance), database.connection= blank?? | 16:10 |
| NobodyCam | dkehn: so there are blank values | 16:11 |
| NobodyCam | dkehn: do you have ssh access to the seed vm | 16:11 |
| dkehn | NobodyCam: the database.connection & keystone_authtoken.admin_password are the only blank ones | 16:12 |
| NobodyCam | need to look at /var/log/upstart/heat-* logs on the seed vm | 16:12 |
| dkehn | NobodyCam: any heat-* log ? | 16:13 |
| *** datajerk has quit IRC | 16:14 | |
| dkehn | NobodyCam: heat-api.log I see errors StackValidationFailed: Multiple physical resources were found with name (undercloud). | 16:16 |
| NobodyCam | dkehn: heat stack-list | 16:17 |
| NobodyCam | is there more then one undercloud? | 16:17 |
| dkehn | NobodyCam: only one entry stack_name:undercloud | 16:17 |
| dkehn | NobodyCam: CREATE_COMPLETE | 16:18 |
| dkehn | soory | 16:18 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Handle DBDuplicateEntry on Ports with same address https://review.openstack.org/59955 | 16:19 |
| NobodyCam | dkehn: can you paste the heat stack-create line | 16:22 |
| NobodyCam | you used | 16:22 |
| dkehn | NobodyCam: http://paste.openstack.org/show/54435/, used the devtest_undercloud.sh | 16:24 |
| NobodyCam | ahh | 16:25 |
| NobodyCam | dkehn: need to add ironic password to that | 16:27 |
| NobodyCam | see https://wiki.openstack.org/wiki/Ironic#Boot_the_Ironic_undercloud_image | 16:27 |
| NobodyCam | for ref | 16:27 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add config option for # of conductor replicas https://review.openstack.org/59794 | 16:29 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: list_active_conductor_drivers returns dict of sets https://review.openstack.org/59795 | 16:29 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement sync_power_state periodic task https://review.openstack.org/56530 | 16:29 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add prepare and cleanup methods to deploy interface https://review.openstack.org/58894 | 16:29 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement consistent hashing of nodes <-> conductors https://review.openstack.org/58895 | 16:29 |
| *** datajerk has joined #openstack-ironic | 16:36 | |
| devananda | fixed the -1 i introduced last night | 16:38 |
| devananda | lucasagomes: how much longer will you be around today? | 16:39 |
| devananda | lucasagomes: we were going to talk, i think | 16:39 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Set the provision_state to DEPLOYFAIL https://review.openstack.org/60024 | 16:39 |
| lucasagomes | devananda, hey :) I will stay around for more ~2 hours | 16:40 |
| lucasagomes | is that enough? I'm at home today so it's more flexible | 16:40 |
| devananda | lucasagomes: k. i'll be back in ~20m, and we can have a call then, if that works | 16:41 |
| lucasagomes | sure np :) | 16:41 |
| devananda | cool. bbiaf | 16:41 |
| *** jcooley_ has quit IRC | 16:43 | |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Rid of specific `dict` methods in object model https://review.openstack.org/60025 | 16:44 |
| *** datajerk has quit IRC | 16:46 | |
| *** datajerk has joined #openstack-ironic | 16:47 | |
| *** michchap_ has quit IRC | 16:48 | |
| *** jistr|mtg is now known as jistr | 16:54 | |
| *** datajerk has quit IRC | 16:58 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Set the provision_state to DEPLOYFAIL https://review.openstack.org/60024 | 17:04 |
| *** datajerk has joined #openstack-ironic | 17:05 | |
| *** rongze has quit IRC | 17:05 | |
| *** rongze has joined #openstack-ironic | 17:07 | |
| *** jcooley_ has joined #openstack-ironic | 17:08 | |
| *** jcooley_ has quit IRC | 17:15 | |
| devananda | NobodyCam: got a few for a call? | 17:18 |
| NobodyCam | otp with dkehn now | 17:18 |
| NobodyCam | ok | 17:18 |
| NobodyCam | just off now | 17:19 |
| NobodyCam | g+ | 17:19 |
| devananda | NobodyCam: k. i'll bridge you in in a few min | 17:19 |
| NobodyCam | k | 17:19 |
| devananda | NobodyCam: phone. cause I need to close down my laptop | 17:19 |
| *** jistr has quit IRC | 17:19 | |
| devananda | bbiah | 17:20 |
| lucasagomes | NobodyCam, https://gist.github.com/max-lobur/7786074 :) | 17:22 |
| lucasagomes | NobodyCam, https://etherpad.openstack.org/p/IronicConsistentHashingForInstances | 17:24 |
| *** jdob_ has joined #openstack-ironic | 17:26 | |
| *** jdob has quit IRC | 17:27 | |
| *** datajerk has quit IRC | 17:31 | |
| *** martyntaylor has quit IRC | 17:36 | |
| *** jdob_ has quit IRC | 17:38 | |
| *** jdob has joined #openstack-ironic | 17:38 | |
| *** vkozhukalov has joined #openstack-ironic | 17:39 | |
| *** matty_dubs is now known as matty_dubs|lunch | 17:42 | |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Rid of specific `dict` methods in object model https://review.openstack.org/60025 | 17:44 |
| *** derekh has quit IRC | 17:50 | |
| *** michchap has joined #openstack-ironic | 17:56 | |
| *** martyntaylor has joined #openstack-ironic | 18:03 | |
| *** michchap has quit IRC | 18:03 | |
| *** Maha has quit IRC | 18:06 | |
| *** datajerk has joined #openstack-ironic | 18:17 | |
| *** lucasagomes has quit IRC | 18:25 | |
| *** matty_dubs|lunch is now known as matty_dubs | 18:31 | |
| *** harlowja has joined #openstack-ironic | 18:37 | |
| NobodyCam | quick walkies...brb | 18:44 |
| *** prekarat has joined #openstack-ironic | 18:52 | |
| *** michchap has joined #openstack-ironic | 18:56 | |
| devananda | back | 19:01 |
| *** michchap has quit IRC | 19:01 | |
| NobodyCam | :) wb | 19:04 |
| devananda | NobodyCam: did you see https://review.openstack.org/59770 ? | 19:05 |
| NobodyCam | oh neet | 19:06 |
| NobodyCam | no I had not | 19:07 |
| devananda | :) | 19:07 |
| openstackgerrit | A change was merged to openstack/ironic: API ports update for WSME 0.5b6 compliance https://review.openstack.org/56682 | 19:13 |
| devananda | woot | 19:14 |
| devananda | lucas: i think ^ also addressed bug https://bugs.launchpad.net/ironic/+bug/1223847 ? | 19:15 |
| openstackgerrit | A change was merged to openstack/python-ironicclient: Move six dependency to requirements.txt https://review.openstack.org/59988 | 19:26 |
| *** vkozhukalov has quit IRC | 19:26 | |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Rid of specific `dict` methods in object model https://review.openstack.org/60025 | 19:51 |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Rid of specific `dict` methods in object model https://review.openstack.org/60025 | 19:53 |
| *** prekarat has quit IRC | 19:53 | |
| *** michchap has joined #openstack-ironic | 19:57 | |
| *** jdob has quit IRC | 20:00 | |
| *** michchap has quit IRC | 20:02 | |
| *** jdob has joined #openstack-ironic | 20:03 | |
| *** tatyana has joined #openstack-ironic | 20:06 | |
| *** tatyana has quit IRC | 20:08 | |
| *** derekh has joined #openstack-ironic | 20:10 | |
| *** datajerk has quit IRC | 20:12 | |
| *** datajerk has joined #openstack-ironic | 20:13 | |
| *** datajerk has quit IRC | 20:19 | |
| *** datajerk has joined #openstack-ironic | 20:21 | |
| rloo | hi, if I -1 a review that already has one or two +2 or whatever, that won't prevent it from being approved if someone else approves it, right? Or should I just put no score? | 20:21 |
| NobodyCam | no please add your -1 | 20:25 |
| NobodyCam | if it has two +2 | 20:25 |
| NobodyCam | 's it may have landed | 20:25 |
| NobodyCam | what review | 20:25 |
| rloo | https://review.openstack.org/#/c/55549/ | 20:26 |
| NobodyCam | that has laned | 20:26 |
| NobodyCam | see the approved | 20:27 |
| NobodyCam | or I should say will land after gate tests | 20:27 |
| rloo | so once it is approved it has landed. I wondered about that. Why is deva's a checkmark, no +2. Does checkmark mean 'approved'? | 20:27 |
| NobodyCam | yes check is +2 | 20:28 |
| NobodyCam | is there something you see in that patch? | 20:28 |
| rloo | so it doesn't matter what I put, -1 or 0, it is approved. but even if it wasn't approved, it would not have stopped someone else from approving, right? | 20:28 |
| rloo | i'll just do a -1 and you'll see :-) | 20:28 |
| NobodyCam | correct | 20:28 |
| NobodyCam | only a -2 would "STOP" it | 20:29 |
| rloo | i actually hate putting in -1. i prefer just putting no score. | 20:29 |
| NobodyCam | no please put -1's so others can see it at a glance | 20:29 |
| rloo | hmm. ok, i'll try to use -1 then. thx. | 20:30 |
| NobodyCam | if you feel there is something not correct ofc | 20:30 |
| NobodyCam | :) -1 is not bad thing. it is just a thing. neither good nor bad | 20:30 |
| NobodyCam | :) | 20:30 |
| rloo | ha ha, I'll keep that in mind. -1 "just is"! | 20:31 |
| NobodyCam | :) | 20:31 |
| devananda | rloo: -1 means you think something should be improved before it lands | 20:34 |
| devananda | rloo: if you just have a question, it's fine to not vote, but keep in mind that non-voting comments don't appear on the review board | 20:34 |
| rloo | devananda: review board == ? | 20:35 |
| devananda | rloo: as far as blocking a change, only -core members can do that with a -2 vote. AFAIK, no one can unblock someone else's -2. | 20:35 |
| devananda | rloo: https://review.openstack.org/#/q/status:open+project:openstack/ironic,n,z | 20:35 |
| rloo | devananda: the V/R/A columns to the right? | 20:36 |
| devananda | correct | 20:37 |
| NobodyCam | brb.. looking for food stuffs | 20:39 |
| rloo | devananda: so if a patch has a +1 and a -1, is the review board set up to show the -1? Is there docn somewhere about what it is showing? | 20:40 |
| devananda | rloo: i'm not aware of a doc about it -- it's gerrit + some modifications from infra. | 20:40 |
| devananda | rloo: basically, vote +1/-1 if you feel the patch should / shouldn't land. your vote counts. | 20:41 |
| rloo | devananda: ok, that's fine. I'll assume people look at that to get a sense of the state of things. | 20:41 |
| devananda | rloo: when I am deciding what patches to review, I look at the votes by all of you | 20:42 |
| rloo | devananda: I don't mind giving feedback, but I prefer to give feedback, and let the other person make changes if they agree. Although I guess with a -1, we can still have a discussion about it. Guess it'll take me some time to 'get used to it'. | 20:43 |
| devananda | rloo: -1 *IS* feedback. it is your vote that "this isn't good enough". | 20:43 |
| devananda | rloo: presumably, you also include some suggestion about how to resolve what you see as a defect :) | 20:44 |
| rloo | devananda: I think I include suggestions. But there isn't only one way to do something. 0 score is feedback too. The comments are the important part, not the number ;) | 20:45 |
| devananda | rloo: comments are very important. a -1 with no comments is useless. BUT. the numbers are important too | 20:46 |
| devananda | rloo: see http://russellbryant.net/openstack-stats/ironic-reviewers-30.txt | 20:46 |
| *** derekh has quit IRC | 20:46 | |
| devananda | you may thnk this is a bug in russellb 's reviewstats, but it doesn't have a column for non-voting-reviews | 20:47 |
| rloo | devananda: ok, so as far as the number-crunchers are concerned, my 0's are invisible. sigh. And does russellb's stats include more than one score per review, given that a lot seem to have several patches before landing? | 20:48 |
| rloo | devananda: i see that you are a meanie, 4 -2's :-) | 20:49 |
| devananda | rloo: I believe it counts the # of times that we post reviews, not the # of patches which are reviewed | 20:49 |
| russellb | correct, 0 not included, because gerrit doesn't even report it as a vote | 20:50 |
| rloo | ok, one last question devananda, since I have your ear. I sometimes look at reviews where there are a bunch of +1s already, so I don't even bother +1'ing it. Should I? | 20:51 |
| russellb | and yes, it counts multiple votes against the same review, across multiple patch sets | 20:51 |
| rloo | thank you russellb, for clarifying! | 20:51 |
| devananda | rloo: yes. if you review a patchset, please +1/-1 as you see fit. that lets us know that you're actively reviewing code | 20:51 |
| rloo | devananda. Good to know. thx. | 20:52 |
| russellb | np | 20:52 |
| devananda | rloo: fwiw, having a lot of +1's (or a lot of -1's) on a patch is a good indication that it's important to a lot of reviewers. it helps to get the attention of core folks | 20:55 |
| devananda | not to say, go put votes arbitrarily on things to get our attention... but it's interesting to see a patch where nearly everyone voted and another patch with no votes. | 20:56 |
| rloo | devananda: if it helps get the attention of core folks, then I guess that's a good thing. (Although you can't see that via the review board, you have to look at the review itself, right?) | 20:56 |
| devananda | rloo: also, I just pushed up a patch to add ironic to reviewday, which is this neat board that prioritizes reviews based on activity, linked bugs or blueprints, etc: http://status.openstack.org/reviews/ | 20:56 |
| devananda | rloo: reviewday actually gives a score and sorts reviews based on things like # of +1/-1, importance of the referenced bug, targeted milestone, etc | 20:57 |
| rloo | devananda: will be interesting to see ironic bugs there, and how it differs from review board. | 20:59 |
| devananda | indeed | 21:00 |
| *** datajerk has quit IRC | 21:01 | |
| devananda | bbiaf | 21:02 |
| NobodyCam | rloo: ok | 21:02 |
| NobodyCam | gah | 21:02 |
| NobodyCam | devananda: ok | 21:02 |
| NobodyCam | :) | 21:02 |
| rloo | NobodyCam: ok :D | 21:02 |
| NobodyCam | hehehe | 21:02 |
| *** harlowja has quit IRC | 21:09 | |
| *** mattymo has quit IRC | 21:09 | |
| *** mattymo has joined #openstack-ironic | 21:09 | |
| *** harlowja has joined #openstack-ironic | 21:09 | |
| devananda | grabbing some food. bbiaw | 21:10 |
| NobodyCam | enjoy | 21:12 |
| *** retr0h_ is now known as retr0h | 21:19 | |
| *** epim has joined #openstack-ironic | 21:20 | |
| jbjohnso | well, see everyone next year, have a good few weeks | 21:29 |
| NobodyCam | you too jbjohnso :) | 21:29 |
| NobodyCam | enjoy the vaca | 21:29 |
| *** rongze has quit IRC | 21:49 | |
| *** jbjohnso has quit IRC | 22:02 | |
| *** harlowja has quit IRC | 22:02 | |
| devananda | back | 22:12 |
| NobodyCam | wb | 22:12 |
| *** jdob has quit IRC | 22:16 | |
| *** rongze has joined #openstack-ironic | 22:19 | |
| *** datajerk has joined #openstack-ironic | 22:22 | |
| *** datajerk has quit IRC | 22:26 | |
| *** harlowja has joined #openstack-ironic | 22:27 | |
| *** rongze has quit IRC | 22:28 | |
| *** datajerk has joined #openstack-ironic | 22:28 | |
| NobodyCam | brb | 22:45 |
| *** yjiang5_1 has quit IRC | 22:53 | |
| *** rongze has joined #openstack-ironic | 22:55 | |
| *** rongze has quit IRC | 23:00 | |
| *** datajerk has quit IRC | 23:00 | |
| NobodyCam | gah something broke :( AttributeError: 'module' object has no attribute 'node' | 23:02 |
| *** matty_dubs is now known as matty_dubs|gone | 23:18 | |
| *** michchap has joined #openstack-ironic | 23:24 | |
| NobodyCam | devananda: you around?? | 23:25 |
| NobodyCam | have you seen this with latest build? http://paste.openstack.org/show/1SggFF1yXbzUm7Vm05qW/ | 23:25 |
| devananda | NobodyCam: looking | 23:27 |
| NobodyCam | :-p | 23:28 |
| NobodyCam | just build the image I'm testing with | 23:28 |
| devananda | testing now | 23:28 |
| devananda | that worked in the devstack image i built 2 hours ago | 23:29 |
| NobodyCam | ok | 23:29 |
| NobodyCam | see what I broke | 23:29 |
| devananda | ahh | 23:29 |
| NobodyCam | :-p | 23:29 |
| devananda | it may not have the wsme patch that just merged | 23:29 |
| devananda | lemme check | 23:29 |
| devananda | no. it does | 23:30 |
| NobodyCam | ok let me see what I did :-p | 23:30 |
| NobodyCam | humm ProgrammingError: (ProgrammingError) (1146, "Table 'ironic.conductors' doesn't exist") | 23:33 |
| NobodyCam | starts over as some thing didn't work | 23:34 |
| devananda | :p | 23:36 |
| devananda | rebasing my patch series, -again- | 23:49 |
| devananda | (thanks rloo!) | 23:49 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add config option for # of conductor replicas https://review.openstack.org/59794 | 23:49 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: list_active_conductor_drivers returns dict of sets https://review.openstack.org/59795 | 23:49 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement sync_power_state periodic task https://review.openstack.org/56530 | 23:49 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add prepare and cleanup methods to deploy interface https://review.openstack.org/58894 | 23:49 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement consistent hashing of nodes <-> conductors https://review.openstack.org/58895 | 23:49 |
| devananda | afk a few | 23:50 |
| *** rongze has joined #openstack-ironic | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!