Tuesday, 2013-12-03

*** rongze has quit IRC00:00
*** NobodyCam_afk is now known as NobodyCam00:04
NobodyCamand back00:04
NobodyCamthis is cool stuff just not sure I like it. http://www.boston.com/business/technology/2013/12/02/amazon-com-developing-delivery-drones/0AhjTYBG83ZEnDb4uA50DN/story.html00:09
*** datajerk has quit IRC00:12
NobodyCamgreat meeting guys :)00:21
*** matsuhashi has joined #openstack-ironic00:29
*** datajerk has joined #openstack-ironic00:32
*** kui has quit IRC00:47
*** matsuhashi has quit IRC00:50
*** matsuhashi has joined #openstack-ironic00:50
*** michchap_ has quit IRC00:53
*** matsuhas_ has joined #openstack-ironic00:53
*** michchap has joined #openstack-ironic00:53
*** matsuhashi has quit IRC00:54
*** datajerk has quit IRC01:06
*** nosnos has joined #openstack-ironic01:26
*** rongze has joined #openstack-ironic01:27
*** rongze has quit IRC01:31
*** jcooley_ has joined #openstack-ironic01:37
*** sjing has joined #openstack-ironic01:39
*** kui has joined #openstack-ironic01:43
*** jcooley_ has quit IRC01:45
*** datajerk has joined #openstack-ironic01:49
*** arata has joined #openstack-ironic01:54
*** datajerk has quit IRC01:57
*** jcooley_ has joined #openstack-ironic02:01
*** jcooley_ has quit IRC02:02
*** rongze has joined #openstack-ironic02:06
*** vkozhukalov has joined #openstack-ironic02:19
*** datajerk has joined #openstack-ironic02:25
*** datajerk has quit IRC02:29
*** matsuhas_ has quit IRC02:31
*** matsuhashi has joined #openstack-ironic02:31
*** datajerk has joined #openstack-ironic02:56
Haomengdevananda: ping02:56
devanandaHaomeng: pong02:57
*** nosnos has quit IRC02:58
Haomengdevananda: just see yesterday's IRC chat history, found you ping me at my local time around 1:30am:)02:58
devanandaHaomeng: regarding https://review.openstack.org/#/c/53627/02:58
devanandaHaomeng: are you going to continue working on this patch?02:58
*** nosnos has joined #openstack-ironic02:59
*** ndipanov has quit IRC02:59
Haomengdevananda: ok, let me check first02:59
Haomengdevananda: yes, I try debug this issue, but still can not find the root cause why the  node.patch_json() isn't populating node.updated_at, but for other object such as port and chasiss can work for patch_json to update updated_at field value03:00
Haomengdevananda: I think maybe it will be our conductor issue with unittest03:00
Haomengdevananda: node update will call conductor code, this is difference with other objects03:01
*** datajerk has quit IRC03:01
Haomengdevananda: I think for unittest, our conductor is disabled, and we have no such node update validation case in our existing unittest code03:02
devanandaHaomeng: afaik, the API unit tests are not using a conductor service, RPC layer, or database03:03
Haomengdevananda: yes, I think so, so for such case, I dont know how to handle03:04
Haomengdevananda: if we just mock the update result, it just tests mocking03:04
Haomengdevananda: so can we restore it and add my comments to take next round review?03:04
devanandaHaomeng: I -1'd because the patch is not comparing time validly, not because of whether the time is real or not :)03:05
devanandait is mocking many things so taht we can test the API code paths independently from other components03:05
devanandathat is the nature of a unit test -- test only one component at a time, and mock everything else03:05
Haomengdevananda: yes03:06
Haomengdevananda: let me try to modify the unittest code to test our api only03:06
devanandathanks :)03:06
Haomengdevananda: any time:)03:06
Haomengdevananda: will contiue to work on this issue today:) thank for your reminder:)03:07
Haomengdevananda: one more question, how do you think if I need to mock our conductor for node update unittest case?03:18
devanandaHaomeng: mock the rpcapi layer03:18
Haomengdevananda: ok03:18
Haomengdevananda: thank you:)03:18
devanandaHaomeng: so that you can fake what the conductor would return, if there were an RPC service running03:18
devanandawelcome :)03:18
Haomengdevananda: got it03:19
Haomengdevananda: enjoy your night:)03:19
*** datajerk has joined #openstack-ironic03:26
*** jcooley_ has joined #openstack-ironic03:29
*** datajerk has quit IRC03:31
openstackgerritA change was merged to openstack/ironic: Apply comments to 58558/4 post-landing  https://review.openstack.org/5935703:33
openstackgerritA change was merged to openstack/ironic: Allow Pecan to use 'debuginfo' response field  https://review.openstack.org/5880703:33
openstackgerritA change was merged to openstack/ironic: Replace removed xrange in Python3  https://review.openstack.org/5911403:36
*** matsuhashi has quit IRC03:42
*** arata has left #openstack-ironic03:55
*** datajerk has joined #openstack-ironic03:57
*** rloo has quit IRC04:01
*** datajerk has quit IRC04:01
*** michchap has quit IRC04:21
*** michchap has joined #openstack-ironic04:21
*** matsuhashi has joined #openstack-ironic04:25
*** datajerk has joined #openstack-ironic04:27
*** rongze has quit IRC04:31
*** datajerk has quit IRC04:32
*** datajerk has joined #openstack-ironic04:58
*** matsuhashi has quit IRC05:00
*** datajerk has quit IRC05:03
*** matsuhashi has joined #openstack-ironic05:08
*** matsuhashi has quit IRC05:27
*** datajerk has joined #openstack-ironic05:29
*** datajerk has quit IRC05:33
*** matsuhashi has joined #openstack-ironic05:59
openstackgerritJenkins proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/5962706:00
*** prekarat has quit IRC06:08
*** retr0h has quit IRC06:14
*** retr0h has joined #openstack-ironic06:14
*** arata has joined #openstack-ironic06:15
*** datajerk has joined #openstack-ironic06:30
*** yfujioka has joined #openstack-ironic06:31
*** datajerk has quit IRC06:35
*** vkozhukalov has quit IRC06:47
*** datajerk has joined #openstack-ironic07:01
*** datajerk has quit IRC07:07
*** datajerk has joined #openstack-ironic07:32
*** jcooley_ has quit IRC07:35
*** jcooley_ has joined #openstack-ironic07:36
*** datajerk has quit IRC07:37
GheRiveromorning Ironic!07:54
*** datajerk has joined #openstack-ironic08:03
Haomengmorning:)08:06
*** datajerk has quit IRC08:08
GheRiveromorning Haomeng08:13
HaomengGheRivero: :)08:13
*** vkozhukalov has joined #openstack-ironic08:27
*** datajerk has joined #openstack-ironic08:34
*** jcooley_ has quit IRC08:36
*** jcooley_ has joined #openstack-ironic08:38
*** datajerk has quit IRC08:38
*** jistr has joined #openstack-ironic08:48
*** sjing has quit IRC08:49
*** derekh has joined #openstack-ironic08:57
*** romcheg has joined #openstack-ironic09:00
*** lynxman has quit IRC09:02
*** datajerk has joined #openstack-ironic09:05
*** romcheg has quit IRC09:05
*** ndipanov has joined #openstack-ironic09:08
*** datajerk has quit IRC09:10
*** romcheg has joined #openstack-ironic09:12
*** max_lobur_afk is now known as max_lobur09:14
*** martyntaylor has joined #openstack-ironic09:19
openstackgerritMax Lobur proposed a change to openstack/ironic: Add missing link for drivers resource  https://review.openstack.org/5908109:24
*** lucasagomes has joined #openstack-ironic09:32
*** jcooley_ has quit IRC09:34
*** datajerk has joined #openstack-ironic09:36
*** agordeev has joined #openstack-ironic09:38
*** datajerk has quit IRC09:40
*** lynxman has joined #openstack-ironic09:43
*** kushi_ has joined #openstack-ironic09:50
*** matsuhashi has quit IRC09:51
*** martyntaylor1 has joined #openstack-ironic09:52
*** kui has quit IRC09:52
*** martyntaylor has quit IRC09:53
*** matsuhashi has joined #openstack-ironic09:54
*** kushi_ has quit IRC09:55
*** jcooley_ has joined #openstack-ironic10:05
*** datajerk has joined #openstack-ironic10:06
*** datajerk has quit IRC10:11
*** jcooley_ has quit IRC10:12
*** yfujioka has quit IRC10:18
openstackgerritDmitry Shulyak proposed a change to openstack/ironic: [PROOF OF CONCEPT]Allow usage of alembic tool for migrations  https://review.openstack.org/5966810:25
*** rongze has joined #openstack-ironic10:28
openstackgerritDmitry Shulyak proposed a change to openstack/ironic: [PROOF OF CONCEPT]Allow usage of alembic tool for migrations  https://review.openstack.org/5920610:32
openstackgerritDmitry Shulyak proposed a change to openstack/ironic: Usefull tools for alembic usage  https://review.openstack.org/5967210:42
*** rongze has quit IRC10:46
*** prekarat has joined #openstack-ironic10:46
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: If no block devices abort deployment  https://review.openstack.org/5949311:02
*** rongze has joined #openstack-ironic11:03
*** jcooley_ has joined #openstack-ironic11:05
*** jcooley_ has quit IRC11:10
*** kui has joined #openstack-ironic11:17
*** prekarat has quit IRC11:22
*** rongze has quit IRC11:39
*** arata has left #openstack-ironic11:44
*** jcooley_ has joined #openstack-ironic11:51
*** rongze_ has joined #openstack-ironic11:56
*** romcheg has quit IRC12:03
openstackgerritDmitry Shulyak proposed a change to openstack/ironic: Usefull tools for alembic usage  https://review.openstack.org/5967212:03
*** romcheg has joined #openstack-ironic12:04
*** max_lobur has quit IRC12:05
*** max_lobur has joined #openstack-ironic12:05
openstackgerritDmitry Shulyak proposed a change to openstack/ironic: Useful tools for alembic usage  https://review.openstack.org/5967212:10
*** jcooley_ has quit IRC12:25
Haomenggood morning/evening Ironic:)12:26
*** datajerk has joined #openstack-ironic12:41
*** lucasagomes is now known as lucas-hungry12:44
*** datajerk has quit IRC12:46
*** prekarat has joined #openstack-ironic12:57
*** SpamapS has quit IRC12:59
*** jcooley_ has joined #openstack-ironic13:08
openstackgerritMax Lobur proposed a change to openstack/python-ironicclient: Let CLI print exception traceback from 'debuginfo'  https://review.openstack.org/5903813:09
*** datajerk has joined #openstack-ironic13:12
*** jcooley_ has quit IRC13:13
*** datajerk has quit IRC13:17
*** jdob has joined #openstack-ironic13:23
*** jcooley_ has joined #openstack-ironic13:23
openstackgerritMax Lobur proposed a change to openstack/python-ironicclient: Let CLI print exception traceback from 'debuginfo'  https://review.openstack.org/5903813:26
*** jcooley_ has quit IRC13:28
*** jdob has quit IRC13:35
*** datajerk has joined #openstack-ironic13:36
*** jdob has joined #openstack-ironic13:37
*** kui has quit IRC13:37
*** matsuhashi has quit IRC13:40
*** jdob has quit IRC13:51
*** jdob has joined #openstack-ironic13:52
*** yuriyz has joined #openstack-ironic14:00
*** lucas-hungry is now known as lucasagomes14:04
*** jcooley_ has joined #openstack-ironic14:17
*** nosnos has quit IRC14:20
*** matty_dubs|gone is now known as matty_dubs14:21
*** jcooley_ has quit IRC14:21
*** rloo has joined #openstack-ironic14:25
*** rongze_ has quit IRC14:27
*** linggao has joined #openstack-ironic14:29
*** linggao has quit IRC14:34
*** linggao has joined #openstack-ironic14:34
*** jbjohnso has joined #openstack-ironic14:35
*** rongze has joined #openstack-ironic14:38
*** romcheg has quit IRC14:44
*** romcheg has joined #openstack-ironic14:46
*** linggao_ has joined #openstack-ironic14:47
*** linggao_ has quit IRC14:47
*** datajerk has quit IRC14:56
*** romcheg has quit IRC15:06
*** jbjohnso has quit IRC15:06
*** romcheg has joined #openstack-ironic15:13
*** agordeev has quit IRC15:16
*** datajerk has joined #openstack-ironic15:16
*** jcooley_ has joined #openstack-ironic15:17
*** jbjohnso has joined #openstack-ironic15:20
*** jcooley_ has quit IRC15:21
*** viktors has joined #openstack-ironic15:23
NobodyCamGood Morning iRonic, says the man waiting for coffee15:24
GheRiverouhm... coffee, I need it. Morning NobodyCam15:25
NobodyCamMorning GheRivero :)15:25
yuriyzMorning Ironic15:25
NobodyCammorning yuriyz15:25
*** datajerk1 has joined #openstack-ironic15:26
romchegMorning all!15:27
NobodyCammorning romcheg :)15:27
*** datajerk has quit IRC15:29
lucasagomesmorning NobodyCam15:30
lucasagomesromcheg yuriyz and GheRivero15:30
NobodyCamhey hey good afternoon lucasagomes  :-p15:30
lucasagomesNobodyCam, hey ya15:30
lucasagomesgotta talk to u15:31
NobodyCamsure15:31
NobodyCamgtalk15:31
lucasagomescool15:31
NobodyCamI have no coffee yet15:31
lucasagomesnp go grab it :)15:32
*** romcheg has quit IRC15:33
*** romcheg has joined #openstack-ironic15:34
NobodyCam:) ok got some coffee15:35
*** romcheg has quit IRC15:43
*** vkozhukalov has quit IRC15:45
*** SpamapS has joined #openstack-ironic15:51
NobodyCamlucasagomes: I think you may be right, Pxe deploy should prob be doing the power control15:52
NobodyCamGheRivero: ^^^ do you have any thoughts on ^^^15:52
lucasagomesNobodyCam, yup, def there's a mismatch between that diagram and the current code15:52
NobodyCamGheRivero: diagram is ( https://docs.google.com/drawings/d/1azAWh0ZfhDqEUsC14ZEBawbnAmdQ2_yl3CfOdDbPvOk )15:53
* GheRivero looking at the diagram15:56
GheRiverowhere does this diagram come from?15:58
NobodyCamdeva15:58
GheRiveroyeah, the pxe driver doesn-t do the power control phase now16:00
*** romcheg has joined #openstack-ironic16:00
GheRiverobut it's easy to adpat to the diagram16:02
GheRiverodo we have an idea about how to cancel deploys?16:02
devanandamornin, all16:03
*** jcooley_ has joined #openstack-ironic16:04
*** tatyana has joined #openstack-ironic16:05
lucasagomesGheRivero, not yet16:07
lucasagomesdevananda, morning16:07
max_loburmorning Ironic16:11
NobodyCammorning max_lobur and devananda16:12
lucasagomeshey max_lobur16:12
NobodyCamI need to update the dib walk thru today16:16
NobodyCam:-p16:16
dkehnNobodyCam: in the merge.py portion of the wike its referencing a $TRIPLEO_ROOT/tripleo-heat-templates/undercloud-vm.yaml should that be a /tripleo-heat-templates/undercloud-bm-source.yaml16:18
NobodyCamare you using real hardware?16:19
*** jcooley_ has quit IRC16:19
*** jcooley_ has joined #openstack-ironic16:19
*** jcooley_ has quit IRC16:20
romchegFinally I rebased the changes to infra config.16:20
NobodyCamromcheg: w00t16:20
romchegNow I think they can be merged16:20
yuriyzpeople, workinprogress patch for Ironic deploy ramdisk https://review.openstack.org/5977016:21
dkehnNobodyCam: got it16:21
dkehnNobodyCam: nope should layout into VMNs16:21
dkehnVMs16:21
NobodyCamromcheg: yuriyz how is the revolution going?16:22
NobodyCamso undercloud-vm.yaml :)16:22
romchegNobodyCam: not as good as we want :)16:22
NobodyCam:(16:22
romchegToday there was a chance to overthrow the government peacefully but that didn't work16:22
* romcheg gets hit crowbar ready16:23
NobodyCamlol16:23
* NobodyCam makes note not ot upset romcheg 16:24
*** tatyana has quit IRC16:24
dkehnNobodyCam: undercloud-vm.yaml == undercloud-vm-source.yaml?16:26
NobodyCamya looks like it was renamed16:26
lucasagomesdevananda, ping16:29
devanandalucasagomes: pong16:29
NobodyCammorning devananda :)16:29
lucasagomesdevananda, I saw that u've a patch that implements a periodic task to check the power state of the nodes and update the db16:30
lucasagomesright now we have something like GET /nodes/<uuid>/state/ that would issue an RPC call and get the state16:30
lucasagomesbut as we already have this periodic task makes it make more sense to just return what is in the db16:31
lucasagomeswhat u think?16:31
devanandalucasagomes: i think there will be some optimization we can do :)16:32
lucasagomesright16:32
devanandalucasagomes: i'm nearly done refactoring that patch chain16:32
devanandashould be able to push once i finish a few unit tests16:32
lucasagomesbecause I our current states are kinda over engineered16:32
lucasagomesdevananda, ok16:32
lucasagomesfor e.g... right now we have:16:33
lucasagomesGET /nodes/<uuid>/state => show both power and provision current states16:33
lucasagomesGET /nodes/<uuid>/state/power => show the current and target power state16:33
lucasagomesGET /nodes/<uuid>state/provision => show the current and target provision state16:33
lucasagomeswhy not just have /nodes/<uuid>/state to show all the current and target states + last_error16:34
devanandalucasagomes: because we need POST for state/power and state/provision ? *shrug*16:34
*** jcooley_ has joined #openstack-ironic16:35
lucasagomeswe still can do that16:35
lucasagomesbut not having all GETs separated16:35
*** datajerk1 has quit IRC16:35
devanandai see your point16:35
*** datajerk has joined #openstack-ironic16:43
*** datajerk1 has joined #openstack-ironic16:45
*** datajerk has quit IRC16:47
*** jcooley_ has quit IRC16:47
*** datajerk1 has quit IRC16:51
*** SpamapS has quit IRC16:52
*** datajerk has joined #openstack-ironic16:52
*** hemna has joined #openstack-ironic16:54
NobodyCammorning walkies time... brb17:00
*** SpamapS has joined #openstack-ironic17:05
*** SpamapS has quit IRC17:05
*** SpamapS has joined #openstack-ironic17:05
*** jistr has quit IRC17:10
*** jcooley_ has joined #openstack-ironic17:12
*** jbjohnso has quit IRC17:15
*** jcooley_ has quit IRC17:15
*** jcooley_ has joined #openstack-ironic17:16
*** jcooley_ has quit IRC17:20
dkehnNobodyCam: post merge.py runing into an error were the AdminPassword is not defined in template, I see it in the ripleo-heat-templates/undercloud-source.yaml, but I don't think its in the undercloud-vm-source.yaml, thoughts17:22
*** jcooley_ has joined #openstack-ironic17:23
NobodyCamdkehn: I'm going thru and updating the walk thru now. Let me see what has changed in the past week or so17:23
dkehnNobodyCam: k17:23
NobodyCamahh ok17:26
*** ndipanov has quit IRC17:26
NobodyCamdkehn: yes things have changed a bit17:26
NobodyCambut looks like I got the ironic yaml creation in the make file17:27
NobodyCamhttps://github.com/openstack/tripleo-heat-templates/blob/master/Makefile17:27
NobodyCamso17:27
*** ndipanov has joined #openstack-ironic17:27
NobodyCamthe dev test walk thru does make -C $TRIPLEO_ROOT/tripleo-heat-templates undercloud-vm.yaml17:27
NobodyCamwhich should also creat the ironic yaml17:28
*** ndipanov has quit IRC17:28
NobodyCam*create even17:28
dkehnNobodyCam: so would it be better to do the devtest.sh than the route I'm going?17:28
*** ndipanov has joined #openstack-ironic17:28
dkehnNobodyCam: and just use the underclound for dev purposes,?17:29
*** datajerk has quit IRC17:29
*** jbjohnso has joined #openstack-ironic17:32
*** datajerk has joined #openstack-ironic17:32
*** viktors has left #openstack-ironic17:32
*** matty_dubs is now known as matty_dubs|lunch17:35
*** datajerk has quit IRC17:36
devanandalucasagomes: patches INC. should be easier to review in small bites, I hope :)17:37
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add missing hash_partition_exponent config option  https://review.openstack.org/5979317:37
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add config option for # of conductor replicas  https://review.openstack.org/5979417:37
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: list_active_conductor_drivers returns dict of sets  https://review.openstack.org/5979517:37
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add heartbeat_interval to new 'conductor' cfg group  https://review.openstack.org/5885117:37
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Implement sync_power_state periodic task  https://review.openstack.org/5653017:37
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add prepare and cleanup methods to deploy interface  https://review.openstack.org/5889417:37
lucasagomesdevananda, wow great17:37
NobodyCamdkehn: I have run the devtest script. I have been doing the steps manually. I do that because I do not need the over cloud17:37
*** max_lobur is now known as max_lobur_afk17:37
*** derekh has quit IRC17:41
NobodyCamdoh... I have "NOT" run the devtest script it self.....17:42
*** tatyana has joined #openstack-ironic17:43
*** datajerk has joined #openstack-ironic17:45
*** martyntaylor1 has quit IRC17:52
*** datajerk has quit IRC17:55
*** vkozhukalov has joined #openstack-ironic17:55
*** rongze has quit IRC17:58
dkehnNobodyCam: the question is should I be running the devtest.sh, I can always put an exit in before the overcloud part starts17:59
dkehnNobodyCam: for me de3vtest.sh works18:00
dkehnNobodyCam: hmm, the 3 key no where near the v key, how did that happen18:00
*** tatyana has quit IRC18:01
*** datajerk has joined #openstack-ironic18:05
NobodyCam:)18:09
*** datajerk has quit IRC18:09
NobodyCamI just submitted https://review.openstack.org/5980018:10
NobodyCamdkehn: ^^18:10
dkehnNobodyCam: saw that18:10
NobodyCamI am going to try and get things to a point that you can run the devtest script.18:10
dkehnNobodyCam: ^^^^ should I just run devtest.sh and kill before undercloud to get where I want to go?18:11
NobodyCamI have not done that yet. so I not sure what your outcome will be.18:11
NobodyCamI do it manually following http://docs.openstack.org/developer/tripleo-incubator/devtest.html18:11
dkehnNobodyCam: in othereword will it have the ironic stuf in it18:12
NobodyCamya.18:13
dkehnNobodyCam: I've built tripleo many time doing the devtest.sh route, with sucess, just wondering is it a suitable dev env for ironic18:13
NobodyCamyes it is18:13
dkehnNobodyCam: ok, then thats the plan, thx18:14
jbjohnsohello all18:15
jbjohnsojust fyi, I'll be vanishing from the internet after tomorrow til next year... vacation time18:16
dkehnnow thats a VAC18:16
NobodyCamwow jbjohnso18:17
NobodyCamthats awesome18:17
devanandajbjohnso: enjoy!18:18
jbjohnsoLove some long vacation... spending at least some of it being something of a luddite18:21
*** rloo has quit IRC18:21
devanandaNobodyCam: not sure if you saw -- i posted a whole bunch of patches ^^ for the hash ring work.18:29
*** matty_dubs|lunch is now known as matty_dubs18:30
NobodyCamI did see. have not look at them yet. try go go thru the dib walk thru so I can update it to actually work :-p18:30
devanandaNobodyCam: awesome :)18:30
*** openstackgerrit has quit IRC18:33
*** openstackgerrit has joined #openstack-ironic18:33
devanandalucasagomes: i think i did not explain what replicas means in this context18:44
lucasagomesdevananda, oh18:45
lucasagomesis not the same as the replicas on the other consistent hashing algorithms?18:45
devanandalucasagomes: you may be thinking of buckets18:47
devanandawhere # of buckets affects the smoothness of distribution of keys across the ring18:48
devanandahere taht is the hash_partition_exponent18:48
devananda# of buckets == 2 ** hash_part_exponent18:48
devanandareplicas == # of conductors which prepare  the deployment environment for each node18:49
devanandareplicas=1  --> no backup.18:49
lucasagomesahhh18:49
lucasagomesrighttt18:49
*** rongze has joined #openstack-ironic18:49
devanandareplicas=2  --> one backup. any conductor goes down, all the nodes which were mapped to it can be serviced by other conductors (without downloading new images from glance)18:49
* devananda needs to write docs :)18:49
lucasagomesgot it18:50
NobodyCamdevananda: if replicas is == 2 will one of the nodes always be primary and the other always secondary?18:50
lucasagomesyea it's hard to think about a name for it18:50
lucasagomesso replicas == 2 is like having a standby node18:51
devanandayep18:51
devanandaand yep18:51
lucasagomesif one goes down the other one will take over18:51
devanandai've been fighting with names18:51
lucasagomesgot18:51
NobodyCam:)18:51
lucasagomesyea, its confusing and yet more confusing when mixed with consistent hashing because people use replicas as bucket18:51
devanandathere will be a periodic task that does something like this18:51
*** hemna has quit IRC18:52
devanandafor node in all_associated_nodes:18:52
devananda  if self.host == ring.get_host(node):18:52
lucasagomesmaybe replication would be a better name for that?18:52
devananda    driver.deploy.prepare()18:52
devanandagah. need etherpad.18:53
devanandalucasagomes: that's why i used "replicas"18:53
devanandalucasagomes: maybe if the help text says more?18:53
lucasagomesdevananda, that would help18:54
lucasagomesI also spotted a nit right now18:54
lucasagomesin the DocString it says "Default: 1"18:54
lucasagomesbut the default is actually the CONF option18:54
lucasagomesso it would be 218:54
devanandaoh! yep18:54
*** rongze has quit IRC18:54
lucasagomesdevananda, but yea if the help text says more that would be much better18:55
*** hemna has joined #openstack-ironic18:55
devanandaNumber of conductors which will be prepared for ...18:56
devanandagah. i'm having a hard time explaining this in one or two sentences18:56
devanandalucasagomes: have you seen https://etherpad.openstack.org/p/IronicConsistentHashingForInstances18:57
lucasagomesmaybe if we have a concept of active/standby18:57
lucasagomesnumber of standby conductors18:57
devanandathat explains the logic behind this18:57
lucasagomesno it's even worst18:57
devanandayea18:57
devanandait's not a standby conductor at all18:57
lucasagomesyea all them are active18:58
devanandathis is also why i split out deploy.prepare() from deploy.deploy()18:58
devanandaso all ?mapped? conductors can call prepare() but only one calls deploy()18:58
devanandai was chatting with NobodyCam yesterday about how we might coordinate such preparation18:59
devanandaright now i can do it asycn // via periodic task18:59
lucasagomesdevananda, I've seem the diagram today18:59
devanandathis handles the case of a running instance with the PXE driver, where the conductor which set it up died, and another has already prepared the PXE environment (for user-image)18:59
lucasagomesthere's one missing part there, because it's assuming that the PXE driver will control the power18:59
devanandait just needs to update neutron19:00
devanandaahh19:00
devanandathat diagram doesn't explain any of the hash ring things19:00
devanandamy brain melted when i got to trying to draw that19:00
*** jistr has joined #openstack-ironic19:00
lucasagomeshaha I can imagine19:00
devanandaif i cant explain it, it means i dont fully undertand it yet19:00
devananda:(19:00
lucasagomes:)19:00
jbjohnsobroader question, I know I rattled off a few theoretical approaches to secure credential exchange in bare metal deploy19:02
*** datajerk has joined #openstack-ironic19:02
*** datajerk has quit IRC19:02
lucasagomesdevananda, maybe we could always replicate the configs across all conductors19:02
jbjohnsodid people decide what to do/not do on the front of that?19:02
devanandajbjohnso: no. there are still seeral critical pieces that we are working on just to make Ironic function19:02
jbjohnsook19:03
lucasagomesbut we use the hashring to determine what conductor will be responsable for that deploy at that time19:03
devanandalucasagomes: if you set # replicas > # conductors, you'll get that behavior19:03
lucasagomesso every conductor could potentially take care of every node (this implies that conductors my have the same drivers)19:03
devanandaactually it doesn't imply that :)19:03
devanandathere are discrete hash rings for each driver19:04
devananda(again, i really need to doc what i'm coding ...)19:04
lucasagomeshehe right I will read that etherpad19:04
lucasagomesmy brain is also not fully working now it's late here19:04
devanandalucasagomes: np. have a good night!19:05
lucasagomesdevananda, so just consider that -1 to fix that nit and (if you can) improve that help text19:05
devanandaack19:05
NobodyCamhave a good night lucasagomes19:05
lucasagomesdevananda, thanks g'night!19:05
devanandai also realized that the current approach to list active conductors doesn't mesh well with the intent of the hash ring19:05
lucasagomesNobodyCam, good night sir!19:05
devananda:-/19:05
lucasagomesdevananda, hmm19:06
lucasagomeswhat about a hangout tomorrow?19:06
lucasagomesI mean google hangout19:06
devanandasounds good19:06
NobodyCam:)19:06
lucasagomesso I can read the etherpad and then we can discuss the ideas19:06
lucasagomesNobodyCam, u too19:06
lucasagomescool so we talk more about it tomorrow, g'night19:07
*** lucasagomes is now known as lucas-dinner19:07
*** Haomeng has quit IRC19:08
*** Haomeng has joined #openstack-ironic19:09
devanandaright, wifi is beign flaky. I'm goign to step away for a few anyway... bbiab19:19
NobodyCamok :)19:21
*** rloo_ has joined #openstack-ironic19:23
*** rloo_ has quit IRC19:26
*** datajerk has joined #openstack-ironic19:26
*** rloo has joined #openstack-ironic19:26
*** Haomeng has quit IRC19:26
*** Haomeng has joined #openstack-ironic19:29
*** rloo has quit IRC19:34
*** rloo has joined #openstack-ironic19:35
*** jcooley_ has quit IRC19:37
*** jcooley_ has joined #openstack-ironic19:37
*** jcooley_ has quit IRC19:41
*** jcooley_ has joined #openstack-ironic19:42
*** datajerk has quit IRC19:46
*** jcooley_ has quit IRC19:47
*** jcooley_ has joined #openstack-ironic19:47
NobodyCambrb19:48
*** rongze has joined #openstack-ironic19:51
*** jcooley_ has quit IRC19:51
*** jcooley_ has joined #openstack-ironic19:52
*** rongze has quit IRC19:56
*** lynxman has quit IRC19:58
*** lynxman has joined #openstack-ironic19:59
*** datajerk has joined #openstack-ironic20:01
*** epim has joined #openstack-ironic20:03
devanandaback20:04
devanandaand about to patch bomb again20:04
NobodyCamlol20:05
* NobodyCam ducks20:05
* devananda waits for unit tests20:06
*** jcooley_ has quit IRC20:06
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add config option for # of conductor replicas  https://review.openstack.org/5979420:06
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: list_active_conductor_drivers returns dict of sets  https://review.openstack.org/5979520:06
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add heartbeat_interval to new 'conductor' cfg group  https://review.openstack.org/5885120:06
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Implement sync_power_state periodic task  https://review.openstack.org/5653020:06
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add prepare and cleanup methods to deploy interface  https://review.openstack.org/5889420:06
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Implement consistent hashing of nodes <-> conductors  https://review.openstack.org/5889520:06
devanandaaaaaand again. this time, just rebasing them all20:08
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add missing hash_partition_exponent config option  https://review.openstack.org/5979320:09
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add config option for # of conductor replicas  https://review.openstack.org/5979420:09
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: list_active_conductor_drivers returns dict of sets  https://review.openstack.org/5979520:09
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add heartbeat_interval to new 'conductor' cfg group  https://review.openstack.org/5885120:09
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Implement sync_power_state periodic task  https://review.openstack.org/5653020:09
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add prepare and cleanup methods to deploy interface  https://review.openstack.org/5889420:09
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Implement consistent hashing of nodes <-> conductors  https://review.openstack.org/5889520:09
devanandadone :)20:09
NobodyCam:)20:09
* devananda makes tea20:13
*** vkozhukalov has quit IRC20:19
NobodyCamdevananda: can you restore https://review.openstack.org/#/c/51328/20:24
NobodyCamand keep it wip?20:24
*** datajerk has quit IRC20:27
devanandasure20:33
NobodyCamTY20:34
NobodyCam:-)20:34
devanandarestored20:34
devanandaare you posting an update?20:34
NobodyCamI'll get a cleaned up version up later. one that will pass mr J's eye20:34
devananda:)20:34
devanandaalso, it looks like https://review.openstack.org/#/c/51328/3/nova/scheduler/filters/compute_capabilities_filter.py doesn't need to be in the patch20:35
devanandauseful for your debugging as it surely is :)20:35
NobodyCamhehehe ya I'll pull it out20:35
devanandaNobodyCam: you should probably also add yourself as a co-author in the commit message, and stuff like that20:36
NobodyCam:) humm ok :)20:37
*** kui has joined #openstack-ironic20:39
*** datajerk has joined #openstack-ironic20:40
*** jistr has quit IRC20:48
NobodyCambrb20:50
*** jcooley_ has joined #openstack-ironic20:51
*** jcooley_ has quit IRC20:53
*** rongze has joined #openstack-ironic20:53
NobodyCamflake8 nova/virt/ironic/driver.py20:55
*** datajerk has quit IRC20:55
NobodyCamdoh20:55
NobodyCamww20:55
*** rongze has quit IRC20:58
*** datajerk has joined #openstack-ironic20:59
*** datajerk has quit IRC21:03
*** jcooley_ has joined #openstack-ironic21:24
*** jdob has quit IRC21:41
*** ndipanov has quit IRC21:43
NobodyCambrb making toast21:45
*** rloo has quit IRC21:48
*** rloo has joined #openstack-ironic21:49
devanandammm, toast21:54
*** rongze has joined #openstack-ironic21:55
NobodyCam:) cinnamon raisin toast21:55
devanandaNobodyCam: when you get to a point where you think it's ready for review, let me know. We can trade. I'd like your eyes on some of my patches too :)21:55
NobodyCam:) will start look at them :) (while I eat the toast) lol21:56
devanandaNobodyCam: first patch in the series is https://review.openstack.org/#/c/59793/21:57
devanandait's a fairly long series .... but hopefully each patch is small21:57
devananda*enough to be quick21:57
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add config option for # of conductor replicas  https://review.openstack.org/5979422:00
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: list_active_conductor_drivers returns dict of sets  https://review.openstack.org/5979522:00
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Implement consistent hashing of nodes <-> conductors  https://review.openstack.org/5889522:00
NobodyCamdevananda: are landing these or just +2 for now?.. ie. until others also have eyes on them22:00
*** rongze has quit IRC22:00
NobodyCamie 5979322:00
NobodyCamis good to land22:01
devanandaat your discretion. some are probably good to land22:03
devanandai marked https://review.openstack.org/#/c/58895/ as WIP just now -- it is not finished.22:03
devanandathe others are probably OK to land22:03
*** jbjohnso has quit IRC22:04
*** linggao has quit IRC22:04
devanandahttps://review.openstack.org/#/c/56682/ is also blocking several changes to the API. I've already +2'd22:06
NobodyCam59794 looks like it should also depend on 5979322:09
NobodyCambut we'll land 93 now22:10
NobodyCam93 +a'd22:11
NobodyCambrb..22:13
*** datajerk has joined #openstack-ironic22:18
openstackgerritA change was merged to openstack/ironic: Add missing hash_partition_exponent config option  https://review.openstack.org/5979322:20
*** datajerk has quit IRC22:24
*** datajerk has joined #openstack-ironic22:28
rloodevananda, yt? have a few minutes?22:37
NobodyCamdevananda: you still here?22:38
devanandarloo: hi!22:38
devanandaNobodyCam: yes22:38
rlooNobodyCam - get in line ;)22:38
NobodyCamjust a quick question22:38
NobodyCamlol22:38
rloook, NobodyCam, go ahead :-)22:38
NobodyCamlol TY rloo :)22:38
devanandahehe22:39
NobodyCamdevananda: on @periodic_task.periodic_task(spacing=CONF.conductor.heartbeat_interval) why spacing vs something like interval22:39
*** epim has quit IRC22:39
devanandaNobodyCam: that parameter name is part of the definition of periodic_task decorator,w hich is coming from Oslo22:40
devanandaNobodyCam: I didn't choose to name it "spacing" :)22:40
NobodyCam:)22:40
NobodyCamack22:40
NobodyCamsee rloo was quick22:40
NobodyCamlol22:40
NobodyCam:-p22:40
rlooNobodyCam. ha ha, yup, you're quick!22:40
rlooso devananda, wrt IcehouseIronicNextSteps -- "API to break a task_manager lock".22:41
devanandaya?22:41
rloodevananda, does that have anything to do with this blueprint: https://blueprints.launchpad.net/ironic/+spec/breaking-resource-locks22:41
devanandayes22:42
devanandaone and the same22:42
rloook good. that's what I thought.22:42
rloodo you think things/code/etc are in a state where it might be worth starting on this, or to wait a bit?22:43
devanandarloo: well....22:46
rloodevananda: ok, I'll wait a bit then :-)22:47
devanandarloo: jsuta  second22:47
devanandarloo: see https://review.openstack.org/#/c/55549/22:49
devanandait looks like yuriyz already started22:49
devanandarloo: so please feel free to work on it22:49
devanandabrb22:49
rloodevananda: if yuriyz already started, shouldn't he just finish?22:49
devanandarloo: his patch was to fix this bug: https://bugs.launchpad.net/ironic/+bug/125034822:51
devanandarloo: which overlaps with the BP22:51
*** epim has joined #openstack-ironic22:52
rloodevananda: ok, i'll ping yuriyz tomorrow to make sure he wasn't going to do more.22:53
devanandarloo: great, thanks :)22:53
rloojust call me tom sawyer... ;)22:53
*** michchap has quit IRC22:56
*** rongze has joined #openstack-ironic22:57
NobodyCamdevananda: on line 392 of manger.py in patch 56530 you use log.warning any thought on using audit like https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L411-L41223:00
NobodyCamthats info I would like to always see? but I'm strange23:01
*** michchap has joined #openstack-ironic23:02
*** rongze has quit IRC23:02
NobodyCamquick walkies.. brb23:15
*** jcooley_ has quit IRC23:18
NobodyCamback23:21
*** matty_dubs is now known as matty_dubs|gone23:30
*** yfujioka has joined #openstack-ironic23:43
NobodyCamdeva you here?23:43
NobodyCam:-p23:43
*** hemna has quit IRC23:50
*** datajerk has quit IRC23:53
*** hemna has joined #openstack-ironic23:54
openstackgerritA change was merged to openstack/ironic: Add heartbeat_interval to new 'conductor' cfg group  https://review.openstack.org/5885123:55
openstackgerritA change was merged to openstack/ironic: Add missing link for drivers resource  https://review.openstack.org/5908123:55
*** openstackgerrit has quit IRC23:56
*** openstackgerrit has joined #openstack-ironic23:56
*** kui has quit IRC23:56
*** datajerk has joined #openstack-ironic23:56
*** rongze has joined #openstack-ironic23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!