*** oanson has joined #openstack-dev | 00:01 | |
*** lihi has joined #openstack-dev | 00:01 | |
*** mkolesni has joined #openstack-dev | 00:01 | |
*** jessegler has quit IRC | 00:04 | |
*** penick has joined #openstack-dev | 00:08 | |
*** gmann has quit IRC | 00:11 | |
*** gmann has joined #openstack-dev | 00:11 | |
*** jkilpatr has quit IRC | 00:11 | |
*** penick has quit IRC | 00:13 | |
*** makowals has quit IRC | 00:15 | |
*** gongysh has quit IRC | 00:17 | |
*** annegentle has joined #openstack-dev | 00:28 | |
*** makowals has joined #openstack-dev | 00:30 | |
*** makowals has quit IRC | 00:39 | |
*** itzikb has joined #openstack-dev | 00:40 | |
*** thorst has quit IRC | 00:45 | |
*** limao has joined #openstack-dev | 00:48 | |
*** edmondsw has joined #openstack-dev | 00:49 | |
*** lihi has quit IRC | 00:52 | |
*** dimak has quit IRC | 00:52 | |
*** mkolesni has quit IRC | 00:53 | |
*** edmondsw has quit IRC | 00:53 | |
*** mkolesni has joined #openstack-dev | 00:54 | |
*** oanson has quit IRC | 00:54 | |
*** ekuris has quit IRC | 00:54 | |
*** priteau has joined #openstack-dev | 00:54 | |
*** dimak has joined #openstack-dev | 00:55 | |
*** ekuris has joined #openstack-dev | 00:55 | |
*** lihi has joined #openstack-dev | 00:55 | |
*** oanson has joined #openstack-dev | 00:56 | |
*** priteau has quit IRC | 00:59 | |
*** baoli has quit IRC | 01:08 | |
*** zzzeek_ has quit IRC | 01:09 | |
*** vhosakot has quit IRC | 01:10 | |
*** tovin07_ has joined #openstack-dev | 01:10 | |
*** zzzeek_ has joined #openstack-dev | 01:11 | |
*** bobh has quit IRC | 01:12 | |
*** galstrom_zzz is now known as galstrom | 01:12 | |
*** makowals has joined #openstack-dev | 01:16 | |
*** sdague has quit IRC | 01:17 | |
*** annegentle has quit IRC | 01:19 | |
*** achampion has joined #openstack-dev | 01:21 | |
*** jathan_ has quit IRC | 01:23 | |
*** achampion has quit IRC | 01:25 | |
*** achampion has joined #openstack-dev | 01:26 | |
*** ansmith_ has joined #openstack-dev | 01:26 | |
*** ansmith has joined #openstack-dev | 01:26 | |
*** thorst has joined #openstack-dev | 01:28 | |
*** thorst has quit IRC | 01:28 | |
*** vhosakot has joined #openstack-dev | 01:28 | |
*** baoli has joined #openstack-dev | 01:32 | |
*** zzzeek_ has quit IRC | 01:33 | |
*** zzzeek_ has joined #openstack-dev | 01:34 | |
*** zzzeek_ has quit IRC | 01:36 | |
*** annegentle has joined #openstack-dev | 01:38 | |
*** charcol has quit IRC | 01:38 | |
*** annegentle has quit IRC | 01:39 | |
*** charcol has joined #openstack-dev | 01:39 | |
*** ansmith_ has quit IRC | 01:40 | |
*** ansmith has quit IRC | 01:40 | |
*** dixiaoli has joined #openstack-dev | 01:46 | |
*** zzzeek_ has joined #openstack-dev | 01:47 | |
*** gkadam has joined #openstack-dev | 01:49 | |
*** tonytan_brb has joined #openstack-dev | 01:49 | |
*** yamahata has quit IRC | 01:50 | |
*** tonytan4ever has quit IRC | 01:52 | |
*** iyamahat has quit IRC | 01:52 | |
*** nplanel has joined #openstack-dev | 01:54 | |
*** zhurong has joined #openstack-dev | 02:03 | |
*** dixiaoli_ has joined #openstack-dev | 02:04 | |
*** itzikb has quit IRC | 02:07 | |
*** dixiaoli has quit IRC | 02:07 | |
*** mikeoutland has quit IRC | 02:08 | |
*** galstrom is now known as galstrom_zzz | 02:11 | |
*** limao has quit IRC | 02:12 | |
*** limao has joined #openstack-dev | 02:12 | |
*** ikhan has joined #openstack-dev | 02:16 | |
*** bobh has joined #openstack-dev | 02:26 | |
*** brault has quit IRC | 02:27 | |
*** sshnaidm has quit IRC | 02:28 | |
*** ikhan_ has joined #openstack-dev | 02:28 | |
*** ikhan has quit IRC | 02:28 | |
*** bobh has quit IRC | 02:29 | |
*** hongbin_ has joined #openstack-dev | 02:30 | |
*** mikeoutland has joined #openstack-dev | 02:31 | |
*** hongbin_ has quit IRC | 02:31 | |
*** hongbin has joined #openstack-dev | 02:32 | |
*** achampion has quit IRC | 02:33 | |
*** ikhan has joined #openstack-dev | 02:33 | |
*** ikhan_ has quit IRC | 02:34 | |
*** makowals has quit IRC | 02:36 | |
*** galstrom_zzz is now known as galstrom | 02:37 | |
*** edmondsw has joined #openstack-dev | 02:37 | |
*** makowals has joined #openstack-dev | 02:39 | |
*** sshnaidm has joined #openstack-dev | 02:41 | |
*** edmondsw has quit IRC | 02:42 | |
*** makowals has quit IRC | 02:54 | |
*** priteau has joined #openstack-dev | 02:55 | |
*** tonytan_brb has quit IRC | 02:58 | |
*** yamamoto has joined #openstack-dev | 02:58 | |
*** priteau has quit IRC | 03:00 | |
*** achampion has joined #openstack-dev | 03:06 | |
*** dsariel has quit IRC | 03:09 | |
*** jamesbenson has joined #openstack-dev | 03:10 | |
*** jamesbenson has quit IRC | 03:15 | |
*** mikeoutland has quit IRC | 03:18 | |
*** gyee has quit IRC | 03:23 | |
*** makowals has joined #openstack-dev | 03:23 | |
*** diablo_rojo has quit IRC | 03:25 | |
*** tonytan4ever has joined #openstack-dev | 03:28 | |
*** thorst has joined #openstack-dev | 03:29 | |
*** juvenal has joined #openstack-dev | 03:32 | |
*** vhosakot has quit IRC | 03:33 | |
*** limao has quit IRC | 03:34 | |
*** thorst has quit IRC | 03:34 | |
*** dixiaoli has joined #openstack-dev | 03:38 | |
*** dixiaoli_ has quit IRC | 03:39 | |
*** juvenal has quit IRC | 03:44 | |
*** juvenal has joined #openstack-dev | 03:48 | |
*** dixiaoli has quit IRC | 03:49 | |
*** fragatin_ has joined #openstack-dev | 03:51 | |
*** fragatin_ has quit IRC | 03:52 | |
*** fragatin_ has joined #openstack-dev | 03:52 | |
*** sshnaidm has quit IRC | 03:53 | |
*** jamesmcarthur has joined #openstack-dev | 03:54 | |
*** fragatina has quit IRC | 03:54 | |
*** makowals has quit IRC | 03:56 | |
*** tonytan4ever has quit IRC | 03:57 | |
*** fragatin_ has quit IRC | 03:57 | |
*** juvenal has quit IRC | 03:57 | |
*** jamesmcarthur has quit IRC | 03:58 | |
*** psachin has joined #openstack-dev | 04:00 | |
*** galstrom is now known as galstrom_zzz | 04:00 | |
*** fragatina has joined #openstack-dev | 04:05 | |
*** makowals has joined #openstack-dev | 04:05 | |
*** ikhan has quit IRC | 04:07 | |
*** ikhan has joined #openstack-dev | 04:08 | |
*** sshnaidm has joined #openstack-dev | 04:09 | |
*** fragatina has quit IRC | 04:09 | |
*** baoli has quit IRC | 04:10 | |
*** adreznec has quit IRC | 04:13 | |
*** adreznec has joined #openstack-dev | 04:14 | |
*** hongbin has quit IRC | 04:16 | |
*** makowals has quit IRC | 04:18 | |
*** makowals has joined #openstack-dev | 04:25 | |
*** edmondsw has joined #openstack-dev | 04:25 | |
*** mwarad has quit IRC | 04:26 | |
*** limao has joined #openstack-dev | 04:28 | |
*** edmondsw has quit IRC | 04:30 | |
*** jrist has quit IRC | 04:33 | |
*** ikhan has quit IRC | 04:34 | |
*** slaweq has joined #openstack-dev | 04:34 | |
*** slaweq has quit IRC | 04:39 | |
*** ikhan has joined #openstack-dev | 04:40 | |
*** makowals has quit IRC | 04:41 | |
*** juvenal has joined #openstack-dev | 04:42 | |
*** juvenal has quit IRC | 04:44 | |
*** nplanel has quit IRC | 04:44 | |
*** nplanel has joined #openstack-dev | 04:46 | |
*** itzikb has joined #openstack-dev | 04:53 | |
*** itzikb has quit IRC | 04:54 | |
*** noslzzp has quit IRC | 04:54 | |
*** priteau has joined #openstack-dev | 04:56 | |
*** jprovazn has joined #openstack-dev | 04:57 | |
*** makowals has joined #openstack-dev | 05:00 | |
*** priteau has quit IRC | 05:00 | |
*** marios has joined #openstack-dev | 05:06 | |
*** ikhan has quit IRC | 05:07 | |
*** sree has joined #openstack-dev | 05:09 | |
*** ikhan has joined #openstack-dev | 05:12 | |
*** dixiaoli has joined #openstack-dev | 05:17 | |
*** d0ugal has joined #openstack-dev | 05:22 | |
*** zaneb has quit IRC | 05:29 | |
*** zaneb has joined #openstack-dev | 05:30 | |
*** thorst has joined #openstack-dev | 05:30 | |
*** dsariel has joined #openstack-dev | 05:33 | |
*** thorst has quit IRC | 05:34 | |
*** amotoki_away is now known as amotoki | 05:35 | |
*** slaweq has joined #openstack-dev | 05:35 | |
*** anilvenkata has joined #openstack-dev | 05:35 | |
*** limao has quit IRC | 05:36 | |
*** limao has joined #openstack-dev | 05:36 | |
*** ikhan has quit IRC | 05:36 | |
*** gamado has joined #openstack-dev | 05:38 | |
*** jprovazn has quit IRC | 05:39 | |
*** armax has quit IRC | 05:39 | |
*** ianychoi has joined #openstack-dev | 05:40 | |
*** slaweq has quit IRC | 05:41 | |
*** rcernin has joined #openstack-dev | 05:41 | |
*** lpetrut has joined #openstack-dev | 05:41 | |
*** dhajare has joined #openstack-dev | 05:43 | |
*** ikhan has joined #openstack-dev | 05:44 | |
*** mwarad has joined #openstack-dev | 05:47 | |
*** sridharg has joined #openstack-dev | 05:48 | |
*** d0ugal has quit IRC | 05:52 | |
*** mfranc213 has quit IRC | 05:53 | |
*** nicolasbock has joined #openstack-dev | 05:55 | |
*** dsariel has quit IRC | 05:56 | |
*** gkadam has quit IRC | 05:56 | |
*** jamesbenson has joined #openstack-dev | 05:57 | |
*** gkadam has joined #openstack-dev | 05:58 | |
*** mfranc213 has joined #openstack-dev | 05:59 | |
*** jamesbenson has quit IRC | 06:01 | |
*** pcaruana has joined #openstack-dev | 06:04 | |
*** dsariel has joined #openstack-dev | 06:06 | |
*** jprovazn has joined #openstack-dev | 06:08 | |
*** jamesmcarthur has joined #openstack-dev | 06:10 | |
*** dhajare has quit IRC | 06:13 | |
*** edmondsw has joined #openstack-dev | 06:14 | |
*** jamesmcarthur has quit IRC | 06:14 | |
*** ikhan has quit IRC | 06:15 | |
*** claudiub has joined #openstack-dev | 06:16 | |
*** gkadam has quit IRC | 06:17 | |
*** gkadam has joined #openstack-dev | 06:17 | |
*** edmondsw has quit IRC | 06:18 | |
*** gkadam has quit IRC | 06:18 | |
*** gkadam has joined #openstack-dev | 06:19 | |
*** ikhan has joined #openstack-dev | 06:19 | |
*** itzikb has joined #openstack-dev | 06:19 | |
*** gkadam has quit IRC | 06:21 | |
*** basilAB has quit IRC | 06:23 | |
*** vaishali has quit IRC | 06:24 | |
*** basilAB has joined #openstack-dev | 06:28 | |
*** slaweq has joined #openstack-dev | 06:29 | |
*** vaishali has joined #openstack-dev | 06:29 | |
*** dsariel has quit IRC | 06:30 | |
*** paramite has joined #openstack-dev | 06:30 | |
*** dhajare has joined #openstack-dev | 06:31 | |
*** dkushwaha has quit IRC | 06:35 | |
*** dkushwaha has joined #openstack-dev | 06:35 | |
*** slaweq_ has joined #openstack-dev | 06:36 | |
*** lpetrut has quit IRC | 06:39 | |
*** zhurong has quit IRC | 06:40 | |
*** kobis has joined #openstack-dev | 06:40 | |
*** slaweq_ has quit IRC | 06:41 | |
*** gkadam has joined #openstack-dev | 06:44 | |
*** zhurong has joined #openstack-dev | 06:45 | |
*** gkadam has quit IRC | 06:46 | |
*** Poornima has joined #openstack-dev | 06:47 | |
*** ikhan has quit IRC | 06:48 | |
*** Poornima has quit IRC | 06:49 | |
*** egallen has joined #openstack-dev | 06:49 | |
*** kobis has quit IRC | 06:51 | |
*** vvidic has quit IRC | 06:52 | |
*** tovin07_ has quit IRC | 06:52 | |
*** tobberydberg has joined #openstack-dev | 06:53 | |
*** ikhan has joined #openstack-dev | 06:53 | |
*** tobberyd_ has joined #openstack-dev | 06:55 | |
*** priteau has joined #openstack-dev | 06:57 | |
*** tobberydberg has quit IRC | 06:58 | |
*** jamesbenson has joined #openstack-dev | 06:59 | |
*** tovin07_ has joined #openstack-dev | 07:01 | |
*** priteau has quit IRC | 07:01 | |
*** tesseract has joined #openstack-dev | 07:02 | |
*** jamesbenson has quit IRC | 07:03 | |
*** gfidente has joined #openstack-dev | 07:06 | |
*** gfidente has quit IRC | 07:06 | |
*** gfidente has joined #openstack-dev | 07:06 | |
*** vishwana_ has joined #openstack-dev | 07:06 | |
*** vishwanathj has quit IRC | 07:06 | |
*** limao_ has joined #openstack-dev | 07:09 | |
*** ishakhat has joined #openstack-dev | 07:09 | |
*** shardy has joined #openstack-dev | 07:11 | |
*** limao has quit IRC | 07:12 | |
*** epopt has quit IRC | 07:15 | |
*** BLZbubba has quit IRC | 07:24 | |
*** kobis has joined #openstack-dev | 07:26 | |
*** fragatina has joined #openstack-dev | 07:27 | |
*** ikhan has quit IRC | 07:27 | |
*** athomas has joined #openstack-dev | 07:28 | |
*** zhurong has quit IRC | 07:30 | |
*** mriedem has quit IRC | 07:30 | |
*** thorst has joined #openstack-dev | 07:31 | |
*** tovin07__ has joined #openstack-dev | 07:31 | |
*** egallen has quit IRC | 07:32 | |
*** fragatina has quit IRC | 07:32 | |
*** openstackgerrit has quit IRC | 07:33 | |
*** tovin07_ has quit IRC | 07:33 | |
*** thorst has quit IRC | 07:36 | |
*** zaneb has quit IRC | 07:36 | |
*** ikhan has joined #openstack-dev | 07:36 | |
*** slaweq_ has joined #openstack-dev | 07:37 | |
*** slaweq_ has quit IRC | 07:42 | |
*** openstackgerrit has joined #openstack-dev | 07:43 | |
openstackgerrit | Merged openstack/governance master: Create tripleo-upgrade project https://review.openstack.org/459993 | 07:43 |
---|---|---|
openstackgerrit | Merged openstack/governance master: New project for Castellan UI plugin https://review.openstack.org/475836 | 07:44 |
*** aarefiev_pto is now known as aarefiev | 07:44 | |
*** tovin07__ has quit IRC | 07:45 | |
*** markvoelker_ has quit IRC | 07:47 | |
*** jpich has joined #openstack-dev | 07:47 | |
*** dhajare has quit IRC | 07:48 | |
*** zaneb has joined #openstack-dev | 07:48 | |
*** dizquierdo has joined #openstack-dev | 07:49 | |
*** snica_away is now known as snica | 07:52 | |
openstackgerrit | Merged openstack/governance master: Remove remaining 'big tent' references https://review.openstack.org/480500 | 07:54 |
*** etingof has quit IRC | 07:54 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-dev | 08:00 | |
*** dhajare has joined #openstack-dev | 08:02 | |
*** openstackgerrit has quit IRC | 08:03 | |
*** ikhan has quit IRC | 08:05 | |
*** egallen has joined #openstack-dev | 08:07 | |
*** tovin07_ has joined #openstack-dev | 08:10 | |
*** etingof has joined #openstack-dev | 08:12 | |
*** etingof has quit IRC | 08:12 | |
*** vnogin has joined #openstack-dev | 08:13 | |
*** etingof has joined #openstack-dev | 08:13 | |
*** etingof has quit IRC | 08:15 | |
*** etingof has joined #openstack-dev | 08:15 | |
*** e0ne has joined #openstack-dev | 08:19 | |
*** ikhan has joined #openstack-dev | 08:23 | |
*** gkadam has joined #openstack-dev | 08:25 | |
*** mvk has quit IRC | 08:26 | |
*** gkadam is now known as gkadam-afk | 08:26 | |
*** gkadam-afk has quit IRC | 08:26 | |
*** zhurong has joined #openstack-dev | 08:27 | |
*** lucas-afk is now known as lucasagomes | 08:32 | |
*** dtantsur|afk is now known as dtantsur | 08:35 | |
*** priteau has joined #openstack-dev | 08:36 | |
*** ikhan has quit IRC | 08:37 | |
*** slaweq_ has joined #openstack-dev | 08:38 | |
*** sree has quit IRC | 08:43 | |
*** jamesbenson has joined #openstack-dev | 08:43 | |
*** slaweq_ has quit IRC | 08:43 | |
*** mgoddard_ has joined #openstack-dev | 08:43 | |
*** ikhan has joined #openstack-dev | 08:44 | |
*** sree has joined #openstack-dev | 08:46 | |
*** vtapia has quit IRC | 08:47 | |
*** ioggstream has joined #openstack-dev | 08:47 | |
*** jamesbenson has quit IRC | 08:48 | |
*** dizquierdo has quit IRC | 08:50 | |
*** mvk has joined #openstack-dev | 08:55 | |
*** cdent has joined #openstack-dev | 08:58 | |
*** jamesbenson has joined #openstack-dev | 09:04 | |
*** lpetrut has joined #openstack-dev | 09:04 | |
*** jamesbenson has quit IRC | 09:08 | |
*** mwarad has quit IRC | 09:09 | |
*** baoli has joined #openstack-dev | 09:14 | |
*** electrofelix has joined #openstack-dev | 09:15 | |
*** takamatsu has joined #openstack-dev | 09:19 | |
*** ikhan has quit IRC | 09:19 | |
*** baoli has quit IRC | 09:19 | |
*** takamatsu has quit IRC | 09:20 | |
*** takamatsu has joined #openstack-dev | 09:20 | |
*** limao_ has quit IRC | 09:22 | |
*** limao has joined #openstack-dev | 09:22 | |
*** jtomasek_ has joined #openstack-dev | 09:23 | |
*** ikhan has joined #openstack-dev | 09:24 | |
*** jamesbenson has joined #openstack-dev | 09:25 | |
*** vtapia has joined #openstack-dev | 09:26 | |
*** limao has quit IRC | 09:27 | |
*** zhurong has quit IRC | 09:27 | |
*** jamesbenson has quit IRC | 09:29 | |
*** e0ne has quit IRC | 09:31 | |
*** thorst has joined #openstack-dev | 09:32 | |
*** e0ne has joined #openstack-dev | 09:34 | |
*** nplanel has quit IRC | 09:34 | |
*** mvk has quit IRC | 09:37 | |
*** thorst has quit IRC | 09:37 | |
*** slaweq_ has joined #openstack-dev | 09:39 | |
*** dizquierdo has joined #openstack-dev | 09:43 | |
*** slaweq_ has quit IRC | 09:45 | |
*** jtomasek_ has quit IRC | 09:46 | |
*** dalgaaf has quit IRC | 09:47 | |
*** dalgaaf has joined #openstack-dev | 09:47 | |
*** markvoelker has joined #openstack-dev | 09:48 | |
*** sridharg has quit IRC | 09:48 | |
*** anilvenkata has quit IRC | 09:49 | |
*** edmondsw has joined #openstack-dev | 09:50 | |
*** mvk has joined #openstack-dev | 09:51 | |
*** d0ugal has joined #openstack-dev | 09:52 | |
*** sridharg has joined #openstack-dev | 09:54 | |
*** edmondsw has quit IRC | 09:54 | |
*** anilvenkata has joined #openstack-dev | 09:54 | |
*** ikhan has quit IRC | 09:59 | |
*** d0ugal has quit IRC | 09:59 | |
*** dixiaoli has quit IRC | 10:00 | |
*** iyamahat has joined #openstack-dev | 10:01 | |
*** priteau has quit IRC | 10:03 | |
*** yamamoto has quit IRC | 10:03 | |
*** sdague has joined #openstack-dev | 10:05 | |
*** ikhan has joined #openstack-dev | 10:08 | |
*** tovin07_ has quit IRC | 10:08 | |
*** jamesmcarthur has joined #openstack-dev | 10:11 | |
*** MattMan_1 has quit IRC | 10:11 | |
*** MattMan_1 has joined #openstack-dev | 10:11 | |
*** openstackgerrit has joined #openstack-dev | 10:13 | |
openstackgerrit | John Garbutt proposed openstack/governance master: Describe what upstream support means https://review.openstack.org/440601 | 10:13 |
openstackgerrit | John Garbutt proposed openstack/governance master: Describe what upstream support means https://review.openstack.org/440601 | 10:14 |
*** jamesmcarthur has quit IRC | 10:15 | |
*** baoli has joined #openstack-dev | 10:16 | |
*** iyamahat has quit IRC | 10:17 | |
*** lucasagomes has quit IRC | 10:20 | |
*** gszasz has quit IRC | 10:20 | |
*** baoli has quit IRC | 10:20 | |
*** markvoelker has quit IRC | 10:22 | |
*** markmc has joined #openstack-dev | 10:22 | |
*** lucasagomes has joined #openstack-dev | 10:23 | |
openstackgerrit | John Garbutt proposed openstack/governance master: Decisions should be globally inclusive https://review.openstack.org/460946 | 10:28 |
*** yolanda has quit IRC | 10:32 | |
*** gouthamr has quit IRC | 10:33 | |
*** yolanda has joined #openstack-dev | 10:33 | |
*** yolanda_ has joined #openstack-dev | 10:33 | |
*** anilvenkata has quit IRC | 10:33 | |
*** yolanda_ has quit IRC | 10:33 | |
*** felixsch___ has quit IRC | 10:35 | |
*** stefannica has joined #openstack-dev | 10:35 | |
*** snica has quit IRC | 10:35 | |
*** anilvenkata has joined #openstack-dev | 10:36 | |
*** sree has quit IRC | 10:36 | |
*** ikhan has quit IRC | 10:36 | |
*** felixsch___ has joined #openstack-dev | 10:36 | |
*** slaweq_ has joined #openstack-dev | 10:40 | |
*** gouthamr has joined #openstack-dev | 10:41 | |
*** ikhan has joined #openstack-dev | 10:42 | |
*** egallen has quit IRC | 10:44 | |
*** egallen has joined #openstack-dev | 10:44 | |
*** egallen has quit IRC | 10:44 | |
*** rarcea has joined #openstack-dev | 10:45 | |
*** egallen has joined #openstack-dev | 10:45 | |
*** egallen has quit IRC | 10:45 | |
*** slaweq_ has quit IRC | 10:46 | |
*** egallen has joined #openstack-dev | 10:46 | |
*** egallen has quit IRC | 10:46 | |
*** egallen has joined #openstack-dev | 10:46 | |
*** egallen has quit IRC | 10:47 | |
*** egallen has joined #openstack-dev | 10:47 | |
*** ioggstream has quit IRC | 10:48 | |
*** egallen has quit IRC | 10:48 | |
*** slaweq_ has joined #openstack-dev | 10:48 | |
*** slaweq has quit IRC | 10:48 | |
*** thorst has joined #openstack-dev | 10:50 | |
*** slaweq_ has quit IRC | 10:55 | |
*** nplanel has joined #openstack-dev | 10:56 | |
*** jprovazn has quit IRC | 10:56 | |
*** ikhan has quit IRC | 10:57 | |
*** noslzzp has joined #openstack-dev | 11:00 | |
*** gkadam has joined #openstack-dev | 11:00 | |
*** dsariel has joined #openstack-dev | 11:03 | |
*** yamamoto has joined #openstack-dev | 11:04 | |
*** morazi has quit IRC | 11:08 | |
*** slaweq has joined #openstack-dev | 11:08 | |
*** rraja has joined #openstack-dev | 11:09 | |
*** yamamoto has quit IRC | 11:11 | |
*** baoli has joined #openstack-dev | 11:16 | |
*** jprovazn has joined #openstack-dev | 11:17 | |
*** jprovazn has quit IRC | 11:18 | |
*** jprovazn has joined #openstack-dev | 11:18 | |
*** jprovazn has quit IRC | 11:18 | |
*** jprovazn has joined #openstack-dev | 11:18 | |
*** nplanel has quit IRC | 11:20 | |
*** markvoelker has joined #openstack-dev | 11:20 | |
*** baoli has quit IRC | 11:20 | |
*** kashyap is now known as kashyap_afk | 11:24 | |
*** kashyap_afk is now known as kashyap | 11:24 | |
*** gkadam has quit IRC | 11:24 | |
*** yamamoto has joined #openstack-dev | 11:30 | |
*** egallen has joined #openstack-dev | 11:32 | |
*** ikhan has joined #openstack-dev | 11:34 | |
*** edmondsw has joined #openstack-dev | 11:38 | |
*** gszasz has joined #openstack-dev | 11:39 | |
*** slaweq_ has joined #openstack-dev | 11:41 | |
*** edmondsw has quit IRC | 11:42 | |
*** lucasagomes is now known as lucas-hungry | 11:45 | |
*** jkilpatr has joined #openstack-dev | 11:45 | |
*** slaweq_ has quit IRC | 11:46 | |
*** ikhan has quit IRC | 11:47 | |
*** cablekev1n has joined #openstack-dev | 11:47 | |
*** ikhan has joined #openstack-dev | 11:51 | |
*** markvoelker has quit IRC | 11:53 | |
*** ioggstream has joined #openstack-dev | 11:56 | |
*** akrivoka has joined #openstack-dev | 12:01 | |
*** gkadam has joined #openstack-dev | 12:05 | |
*** ikhan has quit IRC | 12:07 | |
*** felipemonteiro_ has joined #openstack-dev | 12:08 | |
*** felipemonteiro__ has joined #openstack-dev | 12:09 | |
*** ansmith_ has joined #openstack-dev | 12:10 | |
*** ansmith has joined #openstack-dev | 12:11 | |
*** brault has joined #openstack-dev | 12:11 | |
*** felipemonteiro_ has quit IRC | 12:12 | |
*** mwarad has joined #openstack-dev | 12:14 | |
*** marios has quit IRC | 12:14 | |
*** markvoelker has joined #openstack-dev | 12:19 | |
*** morazi has joined #openstack-dev | 12:21 | |
*** AnilV4 has quit IRC | 12:29 | |
*** marios has joined #openstack-dev | 12:31 | |
*** ekuris has quit IRC | 12:34 | |
*** Poornima has joined #openstack-dev | 12:35 | |
*** gamado has quit IRC | 12:37 | |
*** kylek3h has joined #openstack-dev | 12:38 | |
*** yamamoto has quit IRC | 12:38 | |
*** marios has quit IRC | 12:42 | |
*** slaweq_ has joined #openstack-dev | 12:42 | |
*** marios has joined #openstack-dev | 12:42 | |
*** marios has quit IRC | 12:43 | |
*** marios has joined #openstack-dev | 12:43 | |
*** ekuris has joined #openstack-dev | 12:46 | |
*** edmondsw has joined #openstack-dev | 12:46 | |
*** gordc has joined #openstack-dev | 12:46 | |
*** slaweq_ has quit IRC | 12:47 | |
*** openstackgerrit has quit IRC | 12:47 | |
*** sree has joined #openstack-dev | 12:48 | |
*** gkadam_ has joined #openstack-dev | 12:51 | |
*** ansmith has quit IRC | 12:52 | |
*** ansmith_ has quit IRC | 12:52 | |
*** stefannica is now known as snica_away | 12:53 | |
*** gkadam has quit IRC | 12:54 | |
*** dizquierdo has quit IRC | 12:56 | |
*** galstrom_zzz is now known as galstrom | 12:59 | |
*** charcol has quit IRC | 12:59 | |
*** charcol has joined #openstack-dev | 12:59 | |
*** esberglu has joined #openstack-dev | 13:00 | |
*** lucas-hungry is now known as lucasagomes | 13:02 | |
*** matjazp has joined #openstack-dev | 13:02 | |
*** gkadam__ has joined #openstack-dev | 13:04 | |
*** gkadam_ has quit IRC | 13:06 | |
*** ansmith has joined #openstack-dev | 13:11 | |
*** ansmith_ has joined #openstack-dev | 13:11 | |
*** gkadam__ has quit IRC | 13:11 | |
*** baoli has joined #openstack-dev | 13:13 | |
*** ioggstream has quit IRC | 13:14 | |
*** dhajare has quit IRC | 13:15 | |
*** jathan_ has joined #openstack-dev | 13:16 | |
*** snica_away is now known as stefannica | 13:17 | |
*** juvenal has joined #openstack-dev | 13:23 | |
*** yamamoto has joined #openstack-dev | 13:25 | |
*** baoli has quit IRC | 13:26 | |
*** sridharg has quit IRC | 13:26 | |
*** baoli has joined #openstack-dev | 13:27 | |
*** fragatina has joined #openstack-dev | 13:28 | |
*** ekuris has quit IRC | 13:28 | |
*** bobh has joined #openstack-dev | 13:28 | |
*** sridharg has joined #openstack-dev | 13:29 | |
*** fragatina has quit IRC | 13:33 | |
*** Poornima has quit IRC | 13:34 | |
*** fragatina has joined #openstack-dev | 13:36 | |
*** fragatina has quit IRC | 13:36 | |
*** fragatina has joined #openstack-dev | 13:36 | |
*** sridharg has quit IRC | 13:39 | |
*** dhajare has joined #openstack-dev | 13:39 | |
*** bknudson has joined #openstack-dev | 13:42 | |
*** ekuris has joined #openstack-dev | 13:42 | |
*** slaweq_ has joined #openstack-dev | 13:43 | |
*** ioggstream has joined #openstack-dev | 13:44 | |
*** egallen has quit IRC | 13:47 | |
*** egallen has joined #openstack-dev | 13:47 | |
*** egallen has quit IRC | 13:48 | |
*** egallen has joined #openstack-dev | 13:48 | |
*** awaugama has joined #openstack-dev | 13:48 | |
*** slaweq_ has quit IRC | 13:48 | |
*** anilvenkata has quit IRC | 13:48 | |
*** egallen has quit IRC | 13:48 | |
*** eharney has joined #openstack-dev | 13:48 | |
*** egallen has joined #openstack-dev | 13:49 | |
*** egallen has quit IRC | 13:49 | |
*** egallen has joined #openstack-dev | 13:50 | |
*** egallen has quit IRC | 13:50 | |
*** ekuris has quit IRC | 13:50 | |
*** egallen has joined #openstack-dev | 13:50 | |
*** egallen has quit IRC | 13:51 | |
*** egallen has joined #openstack-dev | 13:51 | |
*** anilvenkata has joined #openstack-dev | 13:51 | |
*** egallen has quit IRC | 13:52 | |
*** egallen has joined #openstack-dev | 13:52 | |
*** baoli has quit IRC | 13:52 | |
*** egallen has quit IRC | 13:52 | |
*** baoli has joined #openstack-dev | 13:53 | |
*** egallen has joined #openstack-dev | 13:53 | |
*** egallen has quit IRC | 13:53 | |
*** d0ugal has joined #openstack-dev | 13:54 | |
*** egallen has joined #openstack-dev | 13:54 | |
*** egallen has quit IRC | 13:54 | |
*** kobis has quit IRC | 13:54 | |
*** dklyle has quit IRC | 13:55 | |
*** david-lyle has joined #openstack-dev | 13:55 | |
*** vishwana_ has quit IRC | 13:56 | |
*** vishwanathj has joined #openstack-dev | 13:57 | |
*** jistr is now known as jistr|call | 13:58 | |
*** d0ugal has quit IRC | 14:00 | |
*** ekuris has joined #openstack-dev | 14:03 | |
*** baoli has quit IRC | 14:03 | |
*** baoli has joined #openstack-dev | 14:04 | |
*** ikhan has joined #openstack-dev | 14:08 | |
*** ihrachys has joined #openstack-dev | 14:10 | |
*** baoli has quit IRC | 14:10 | |
*** baoli has joined #openstack-dev | 14:14 | |
*** viniciusarcanjo has joined #openstack-dev | 14:18 | |
*** zzzeek_ has quit IRC | 14:18 | |
*** zzzeek_ has joined #openstack-dev | 14:21 | |
*** akrivoka has quit IRC | 14:22 | |
*** cablekev1n has quit IRC | 14:24 | |
*** yamamoto has quit IRC | 14:24 | |
*** d0ugal has joined #openstack-dev | 14:25 | |
*** akrivoka has joined #openstack-dev | 14:25 | |
*** viniciusarcanjo has quit IRC | 14:27 | |
*** spzala has joined #openstack-dev | 14:27 | |
*** viniciusarcanjo has joined #openstack-dev | 14:27 | |
*** viniciusarcanjo has quit IRC | 14:27 | |
*** xyang1 has joined #openstack-dev | 14:27 | |
*** gyee has joined #openstack-dev | 14:27 | |
*** jamesbenson has joined #openstack-dev | 14:28 | |
*** arjov has joined #openstack-dev | 14:29 | |
*** d0ugal has quit IRC | 14:31 | |
*** ekuris has quit IRC | 14:31 | |
*** cablekev1n has joined #openstack-dev | 14:31 | |
*** marst has joined #openstack-dev | 14:31 | |
*** dizquierdo has joined #openstack-dev | 14:31 | |
*** armax has joined #openstack-dev | 14:33 | |
*** klipka has quit IRC | 14:36 | |
*** armax has quit IRC | 14:37 | |
*** rcernin has quit IRC | 14:38 | |
*** yamamoto has joined #openstack-dev | 14:40 | |
*** rcernin has joined #openstack-dev | 14:40 | |
*** slaweq_ has joined #openstack-dev | 14:45 | |
*** armax has joined #openstack-dev | 14:45 | |
*** epopt has joined #openstack-dev | 14:46 | |
*** xarses has joined #openstack-dev | 14:47 | |
*** jtomasek_ has joined #openstack-dev | 14:49 | |
*** slaweq_ has quit IRC | 14:49 | |
*** ioggstream has quit IRC | 14:51 | |
*** slaweq has quit IRC | 14:53 | |
*** READ10 has joined #openstack-dev | 14:54 | |
*** vhosakot has joined #openstack-dev | 14:56 | |
*** jamesmcarthur has joined #openstack-dev | 14:56 | |
*** ishakhat has quit IRC | 14:59 | |
*** mattmceuen has joined #openstack-dev | 15:00 | |
*** renmak_ has joined #openstack-dev | 15:00 | |
*** renmak__ has joined #openstack-dev | 15:00 | |
*** ilyashakhat has joined #openstack-dev | 15:03 | |
*** iyamahat has joined #openstack-dev | 15:03 | |
*** diablo_rojo has joined #openstack-dev | 15:08 | |
*** dklyle has joined #openstack-dev | 15:11 | |
*** david-lyle has quit IRC | 15:11 | |
*** xemdetia has joined #openstack-dev | 15:12 | |
*** xemdetia_ has joined #openstack-dev | 15:12 | |
*** zzzeek_ has quit IRC | 15:12 | |
*** xemdetia has quit IRC | 15:12 | |
*** xemdetia_ is now known as xemdetia | 15:12 | |
*** baoli has quit IRC | 15:13 | |
*** dhajare has quit IRC | 15:13 | |
*** gamado has joined #openstack-dev | 15:13 | |
*** dklyle is now known as david-lyle | 15:15 | |
*** psachin has quit IRC | 15:18 | |
*** rcernin has quit IRC | 15:18 | |
*** baoli has joined #openstack-dev | 15:18 | |
*** renmak_ has quit IRC | 15:18 | |
*** renmak__ has quit IRC | 15:18 | |
*** paramite has quit IRC | 15:20 | |
*** jamesmcarthur has quit IRC | 15:20 | |
*** sree has quit IRC | 15:21 | |
*** jistr|call is now known as jistr | 15:22 | |
*** sree has joined #openstack-dev | 15:22 | |
*** jtomasek_ has quit IRC | 15:24 | |
*** renmak__ has joined #openstack-dev | 15:24 | |
*** renmak_ has joined #openstack-dev | 15:24 | |
*** annegentle has joined #openstack-dev | 15:25 | |
*** sree has quit IRC | 15:26 | |
*** zzzeek_ has joined #openstack-dev | 15:30 | |
*** e0ne has quit IRC | 15:34 | |
*** tobberydberg has joined #openstack-dev | 15:35 | |
*** jcoufal has joined #openstack-dev | 15:37 | |
*** tobberyd_ has quit IRC | 15:38 | |
*** tobberydberg has quit IRC | 15:39 | |
*** slaweq has joined #openstack-dev | 15:45 | |
*** mhayden has quit IRC | 15:48 | |
*** mhayden has joined #openstack-dev | 15:48 | |
*** limao has joined #openstack-dev | 15:49 | |
*** slaweq has quit IRC | 15:50 | |
*** lpetrut has quit IRC | 15:56 | |
*** tobberydberg has joined #openstack-dev | 15:56 | |
*** vnogin has quit IRC | 15:56 | |
*** aarefiev is now known as aarefiev_afk | 15:56 | |
*** cdent has quit IRC | 15:56 | |
*** ikhan_ has joined #openstack-dev | 15:57 | |
*** cdent has joined #openstack-dev | 15:58 | |
*** yamamoto has quit IRC | 15:58 | |
*** kobis has joined #openstack-dev | 15:59 | |
*** ikhan has quit IRC | 15:59 | |
*** dizquierdo has quit IRC | 16:00 | |
*** eharney has quit IRC | 16:00 | |
*** tobberydberg has quit IRC | 16:00 | |
*** krtaylor_ has quit IRC | 16:00 | |
*** krtaylor has joined #openstack-dev | 16:01 | |
*** dizquierdo has joined #openstack-dev | 16:01 | |
*** slaweq has joined #openstack-dev | 16:03 | |
*** jamesmcarthur has joined #openstack-dev | 16:06 | |
*** limao has quit IRC | 16:06 | |
*** jamesmcarthur has quit IRC | 16:06 | |
*** jamesmcarthur has joined #openstack-dev | 16:07 | |
*** limao has joined #openstack-dev | 16:09 | |
*** mriedem has joined #openstack-dev | 16:11 | |
*** slaweq has quit IRC | 16:13 | |
*** annegentle has quit IRC | 16:13 | |
*** gamado has quit IRC | 16:13 | |
*** amotoki is now known as amotoki_away | 16:14 | |
*** limao has quit IRC | 16:15 | |
*** dhajare has joined #openstack-dev | 16:15 | |
*** annegentle has joined #openstack-dev | 16:17 | |
*** edmondsw has quit IRC | 16:17 | |
*** armax has quit IRC | 16:17 | |
*** edmondsw_ has joined #openstack-dev | 16:19 | |
*** sshnaidm is now known as sshnaidm|afk | 16:21 | |
*** edmondsw_ has quit IRC | 16:23 | |
*** athomas has quit IRC | 16:24 | |
*** jpich has quit IRC | 16:25 | |
*** spzala has quit IRC | 16:37 | |
*** itzikb has quit IRC | 16:41 | |
*** baoli has quit IRC | 16:43 | |
*** BLZbubba has joined #openstack-dev | 16:43 | |
*** baoli has joined #openstack-dev | 16:43 | |
morgan | efried: some of your ksa changes are gating. | 16:44 |
morgan | efried: added a couple comments to 2 of them (the misc-cleanup one and one of the discover ones) that need answers before i'll change from a -1 to something else | 16:45 |
efried | morgan Thanks! | 16:45 |
morgan | efried: the critical "must land before the next release" one notably is one that is gating | 16:45 |
morgan | so we can be sure it is in before we cut a release | 16:45 |
efried | morgan Perfect | 16:45 |
efried | morgan I think I agree with you on https://review.openstack.org/#/c/482250/ -- mordred should weigh in. | 16:46 |
*** marios has quit IRC | 16:46 | |
efried | morgan See specifically mordred's comment at https://review.openstack.org/#/c/481309/3//COMMIT_MSG@13 | 16:46 |
morgan | my point is | 16:47 |
morgan | a null "min" or "max" version may be considered broken | 16:47 |
morgan | is it really valid that we need to handle it | 16:47 |
morgan | or would it make more sense to raise a massive exception? | 16:47 |
morgan | I err to the latter option | 16:47 |
morgan | mordred: ^ re discovery | 16:48 |
mordred | it's really valid | 16:48 |
morgan | If we don't actually have a documented case of a broken document, i don't want to land that | 16:48 |
morgan | i get "missing" | 16:48 |
morgan | i get may-or-may not provide | 16:48 |
morgan | but providing explicitly broken data? | 16:48 |
morgan | and null is explicitly broken | 16:48 |
mordred | there are documents taht explicitly provide '' | 16:48 |
mordred | I do not know that I have seen documents that explicitly provide json null | 16:49 |
morgan | can we comment which one(s) do, that is all I want for the record | 16:49 |
morgan | before we accept it | 16:49 |
mordred | ++ | 16:49 |
efried | "" is explicitly supported | 16:49 |
*** shardy has quit IRC | 16:49 | |
morgan | this is one of those cases where i want documented "this is why this broken behavior is supported" | 16:49 |
*** dsariel has quit IRC | 16:49 | |
morgan | and i want it in a comment in the code | 16:49 |
efried | The issue here is whether we can have max_version="" *and* version="something sane" | 16:49 |
morgan | "aka glance does X in release Y" | 16:49 |
morgan | (not to pick on glance) | 16:49 |
morgan | it is important so we a) maintain it, b) don't regress, and c) know why it was added in the first place | 16:50 |
morgan | as it stands, it looks like "we're hedging bets on someone may make a broken document" | 16:50 |
morgan | i don't like that. | 16:50 |
efried | morgan Agree. | 16:50 |
efried | But have to defer to mordred to say whether there really is a busted doc out there. | 16:51 |
efried | Although I'm not sure I would go so far as to say this would be a *broken* doc. | 16:51 |
morgan | i would. | 16:51 |
efried | Since "" is a supported thing by itself. | 16:51 |
morgan | it is saying "maxversion is <invalid data>" | 16:51 |
morgan | that to me is broken. | 16:51 |
*** brault has quit IRC | 16:52 | |
efried | No, max_version="something that doesn't translate to a version tuple" would be broken. | 16:52 |
*** lucasagomes is now known as lucas-afk | 16:52 | |
morgan | a non-string, non-version-like-data-in-string-form, non-version-like-data (and "" is not version data), is broken | 16:52 |
morgan | i guess, int/float is ok | 16:52 |
efried | morgan Well, if we make that assertion, then we need a bigger change. | 16:52 |
*** jamesmcarthur has quit IRC | 16:52 | |
efried | Because today it definitely supports empty string and maps it to None | 16:53 |
*** jamesmcarthur has joined #openstack-dev | 16:53 | |
morgan | basically, i want clear documentation in the code of why we're supporting weird/non-version-like-data behaviors in a doc. | 16:53 |
morgan | and that is probably wrong. | 16:53 |
morgan | but, if we document where that is happening and in what release(s). | 16:53 |
morgan | i'm happy to accept the code. | 16:53 |
*** dizquierdo has quit IRC | 16:54 | |
efried | Okay; I'll surely follow y'all's guidance on this. | 16:54 |
morgan | i would classify None, "", "MyVersion", "IWroteThisWhenIWasSleepDeprived2" all to be invalid | 16:54 |
mordred | yah - I think documenting is a great plan | 16:54 |
morgan | 1, 1.1, 1.1.1, 1.1.1.1 [ugh, don't get me started], "1", "1.1", "1.1.1" ... all to be valiud | 16:54 |
mordred | yup | 16:54 |
efried | And "v1", "v1.2", etc. | 16:55 |
mordred | and I think we should document that we treat '' as if the key wasn't provided, but we expect to error on MyVersion | 16:55 |
morgan | its just one of those cases where i err to the stricter side unless we can point and say "here is why we do it" | 16:55 |
mordred | yah? | 16:55 |
morgan | mordred: i actually disagree | 16:55 |
morgan | i think '' should also be invalid. | 16:55 |
*** slaweq has joined #openstack-dev | 16:55 | |
mordred | morgan: we have to accept '' - it's widely used | 16:55 |
mordred | keystoneauth will not work with openstack clouds if we do not accept it as data in the discovery document | 16:56 |
morgan | so lets point at a couple places and say "this is not ideal and should be invalid, but is widely used by X,y,z and we must support it" | 16:56 |
efried | And if that's the case, then IMO we should truly treat "" the same as not-included | 16:56 |
morgan | that's all i'm asking for if we treat "" as not-included | 16:56 |
mordred | ya - sorry - that's what I was trying to say - we should document it as bong but accepted because of cases | 16:56 |
morgan | because historically broken is fine, we maintain it as much as i don't want to | 16:56 |
efried | Which means that (other than adding some comments) the code fix is valid as proposed. | 16:57 |
morgan | but new broken is ugh | 16:57 |
morgan | efried: correct. | 16:57 |
morgan | needs code-doc and i can reverse the -1 to a +2 | 16:57 |
morgan | *or* it needs to raise an exception/error because we don't have to support "" ;) | 16:57 |
efried | ...even if we can't point to a specific case of max_version="", version="1.2" | 16:57 |
morgan | i want a real case pointed to, mordred please help us dig one up | 16:57 |
mordred | one sec | 16:57 |
morgan | i am sure you know of one | 16:57 |
efried | :) | 16:58 |
efried | I'll be back to check on this in a bit, will catch up in backscroll. Thanks guys. | 16:58 |
* morgan will then go eat breakfast, walk the dog, send emails, and then write up a deprecation patch for keystone template-catalog [shudder] | 16:58 | |
*** efried is now known as efried_lunch | 16:58 | |
*** sshnaidm|afk has quit IRC | 16:58 | |
*** yamamoto has joined #openstack-dev | 16:59 | |
*** juvenal has quit IRC | 17:00 | |
mordred | morgan, efried_lunch: http://paste.openstack.org/show/615050/ | 17:00 |
mordred | morgan, efried_lunch: tl;dr "nova" | 17:01 |
morgan | mordred: perfect. | 17:01 |
* mordred knew it was important fora reason ;) | 17:01 | |
morgan | efried_lunch: ^ just add a comment that nova infact does this as of ... whatever release that is :P | 17:01 |
morgan | and we're good | 17:01 |
efried_lunch | morgan Roger wilco. | 17:02 |
morgan | i still assert that is a broken document... but *shrug* | 17:02 |
*** spzala has joined #openstack-dev | 17:02 | |
efried_lunch | mordred What version is that? | 17:02 |
*** baoli has quit IRC | 17:02 | |
*** spzala has quit IRC | 17:03 | |
*** spzala has joined #openstack-dev | 17:03 | |
efried_lunch | I guess 2.0, microversion 2.38? | 17:03 |
*** mgoddard_ has quit IRC | 17:04 | |
*** yamamoto has quit IRC | 17:04 | |
*** baoli has joined #openstack-dev | 17:04 | |
*** mdorman has quit IRC | 17:04 | |
*** slaweq has quit IRC | 17:05 | |
mordred | efried_lunch: that's whatever vexxhost is running | 17:09 |
mordred | efried_lunch: but pretty much any nova version that has microversion support is going to return that for the 2.0 version | 17:09 |
*** jcoufal has quit IRC | 17:12 | |
*** iyamahat has quit IRC | 17:15 | |
*** armax has joined #openstack-dev | 17:17 | |
*** esberglu has quit IRC | 17:19 | |
*** lpetrut has joined #openstack-dev | 17:19 | |
*** stefannica is now known as snica_away | 17:24 | |
*** baoli has quit IRC | 17:27 | |
*** krtaylor has quit IRC | 17:30 | |
*** iyamahat has joined #openstack-dev | 17:31 | |
*** slaweq has joined #openstack-dev | 17:31 | |
*** baoli has joined #openstack-dev | 17:33 | |
*** baoli has quit IRC | 17:33 | |
*** jcoufal has joined #openstack-dev | 17:34 | |
*** edmondsw has joined #openstack-dev | 17:35 | |
*** wootehfoot has joined #openstack-dev | 17:36 | |
*** baoli has joined #openstack-dev | 17:39 | |
*** matjazp has quit IRC | 17:39 | |
*** jamesmcarthur has quit IRC | 17:40 | |
*** eharney has joined #openstack-dev | 17:40 | |
*** mgoddard_ has joined #openstack-dev | 17:41 | |
*** zzzeek_ has quit IRC | 17:46 | |
*** yamahata has joined #openstack-dev | 17:48 | |
*** zzzeek_ has joined #openstack-dev | 17:49 | |
*** slaweq has quit IRC | 17:49 | |
*** lpetrut has quit IRC | 17:51 | |
*** brault has joined #openstack-dev | 17:56 | |
*** annegentle has quit IRC | 17:58 | |
*** annegentle has joined #openstack-dev | 17:59 | |
*** baoli has quit IRC | 18:00 | |
*** baoli has joined #openstack-dev | 18:01 | |
*** jamesmcarthur has joined #openstack-dev | 18:01 | |
*** yamamoto has joined #openstack-dev | 18:02 | |
*** electrofelix has quit IRC | 18:02 | |
*** esberglu has joined #openstack-dev | 18:02 | |
*** tobberydberg has joined #openstack-dev | 18:04 | |
*** esberglu has quit IRC | 18:04 | |
*** esberglu has joined #openstack-dev | 18:05 | |
*** eharney has quit IRC | 18:05 | |
*** diablo_rojo has quit IRC | 18:06 | |
*** yamamoto has quit IRC | 18:07 | |
*** kobis has quit IRC | 18:10 | |
*** etingof has quit IRC | 18:11 | |
*** jamesmcarthur has quit IRC | 18:12 | |
*** lpetrut has joined #openstack-dev | 18:13 | |
*** spzala has quit IRC | 18:14 | |
*** yamahata has quit IRC | 18:14 | |
*** yamahata has joined #openstack-dev | 18:15 | |
*** krtaylor has joined #openstack-dev | 18:16 | |
*** spzala has joined #openstack-dev | 18:16 | |
*** eharney has joined #openstack-dev | 18:18 | |
*** rraja has quit IRC | 18:18 | |
*** spzala has quit IRC | 18:21 | |
*** edmondsw_ has joined #openstack-dev | 18:23 | |
*** spzala has joined #openstack-dev | 18:24 | |
*** tesseract has quit IRC | 18:25 | |
*** edmondsw has quit IRC | 18:25 | |
*** jamesmcarthur has joined #openstack-dev | 18:26 | |
*** spzala_ has joined #openstack-dev | 18:26 | |
*** spzala has quit IRC | 18:27 | |
*** takamatsu has quit IRC | 18:34 | |
*** yusef has joined #openstack-dev | 18:35 | |
*** jcoufal has quit IRC | 18:35 | |
*** lathiat_ has quit IRC | 18:36 | |
*** annegentle has quit IRC | 18:39 | |
*** lathiat has joined #openstack-dev | 18:41 | |
*** makowals has quit IRC | 18:44 | |
*** esberglu_ has joined #openstack-dev | 18:44 | |
*** esberglu has quit IRC | 18:47 | |
*** dtroyer has quit IRC | 18:47 | |
*** lpetrut has quit IRC | 18:47 | |
*** krtaylor has quit IRC | 18:48 | |
*** doglike has joined #openstack-dev | 18:49 | |
*** varesa has quit IRC | 18:49 | |
*** godlike has quit IRC | 18:49 | |
*** doglike has quit IRC | 18:49 | |
*** doglike has joined #openstack-dev | 18:49 | |
*** dtroyer has joined #openstack-dev | 18:49 | |
*** nicolasbock has quit IRC | 18:50 | |
*** mgoddard_ has quit IRC | 18:50 | |
*** jcoufal has joined #openstack-dev | 18:53 | |
*** jamesmcarthur has quit IRC | 18:54 | |
*** krtaylor has joined #openstack-dev | 18:56 | |
*** efried_lunch is now known as efried | 18:56 | |
*** akrivoka has quit IRC | 18:57 | |
*** sdague has quit IRC | 19:00 | |
*** tobberydberg has quit IRC | 19:02 | |
*** tobberydberg has joined #openstack-dev | 19:02 | |
*** cdent has quit IRC | 19:02 | |
*** baoli has quit IRC | 19:02 | |
*** varesa has joined #openstack-dev | 19:02 | |
*** baoli has joined #openstack-dev | 19:02 | |
*** rockyg has joined #openstack-dev | 19:03 | |
*** tobberydberg has quit IRC | 19:06 | |
*** tobberydberg has joined #openstack-dev | 19:06 | |
*** cdent has joined #openstack-dev | 19:06 | |
*** spzala_ has quit IRC | 19:06 | |
*** matjazp has joined #openstack-dev | 19:07 | |
efried | mordred morgan Okay, I don't quiiite understand. We want this comment to say that at least nova at <some version> has empty version strings in its discovery document. Do we want <some version> to be like, "pike"? Or like "v2.0"? Or like "microversion 2.46"? | 19:08 |
morgan | efried: you could say "nova api v2.0 as of <release>" | 19:09 |
morgan | or whatever | 19:09 |
morgan | just some indicator of why it was like this | 19:10 |
efried | morgan Where <release> is like... "pike"? | 19:10 |
*** annegentle has joined #openstack-dev | 19:10 | |
morgan | yeah | 19:10 |
efried | okay, on it. Thanks. | 19:10 |
morgan | or mitaka, or whatever | 19:10 |
morgan | you could just say nova v2.0 api presents this way | 19:10 |
morgan | and that is sufficient | 19:10 |
*** tobberydberg has quit IRC | 19:10 | |
morgan | but if you can put in an actual release in the comment, that would be even better | 19:11 |
*** mvk has quit IRC | 19:11 | |
*** makowals has joined #openstack-dev | 19:11 | |
*** fragatina has quit IRC | 19:11 | |
mordred | the release is 'starting with whatever release first added microversions' | 19:12 |
mordred | so I think I agree with "morgan | you could just say nova v2.0 api presents this way" | 19:13 |
*** gfidente has quit IRC | 19:13 | |
*** annegentle has quit IRC | 19:13 | |
*** jamesmcarthur has joined #openstack-dev | 19:14 | |
*** annegentle has joined #openstack-dev | 19:14 | |
efried | morgan mordred Ah, rats, pushed it up before I saw those last couple notes. | 19:15 |
efried | Let me know if/how you want it tweaked: https://review.openstack.org/#/c/482250/ | 19:15 |
morgan | wfm | 19:15 |
morgan | +2 | 19:16 |
morgan | thanks for the note | 19:16 |
efried | Thanks! | 19:16 |
mordred | ++ | 19:16 |
efried | Dropped in an eavesdrop link in case future us wants more detail on wtf this was about :) | 19:18 |
*** mgoddard_ has joined #openstack-dev | 19:18 | |
*** tobberydberg has joined #openstack-dev | 19:18 | |
morgan | wfm | 19:18 |
*** kobis has joined #openstack-dev | 19:20 | |
*** rocky_g has joined #openstack-dev | 19:22 | |
*** rockyg has quit IRC | 19:23 | |
efried | mordred Want me to have a crack at updating https://review.openstack.org/#/c/477566/ ? | 19:25 |
*** gszasz has quit IRC | 19:26 | |
*** rockyg has joined #openstack-dev | 19:31 | |
*** rocky_g has quit IRC | 19:32 | |
*** renmak_ has quit IRC | 19:35 | |
*** renmak__ has quit IRC | 19:35 | |
*** paramite has joined #openstack-dev | 19:36 | |
mordred | efried: yes please! | 19:36 |
efried | ight | 19:36 |
*** armax has quit IRC | 19:38 | |
*** awaugama has quit IRC | 19:40 | |
*** slaweq has joined #openstack-dev | 19:40 | |
*** makowals has quit IRC | 19:41 | |
*** jamesmcarthur has quit IRC | 19:43 | |
*** tobberydberg has quit IRC | 19:44 | |
*** tobberydberg has joined #openstack-dev | 19:44 | |
*** kobis has quit IRC | 19:45 | |
*** makowals has joined #openstack-dev | 19:45 | |
*** tobberydberg has quit IRC | 19:46 | |
*** tobberydberg has joined #openstack-dev | 19:46 | |
*** esberglu_ is now known as esberglu | 19:53 | |
*** diablo_rojo has joined #openstack-dev | 19:56 | |
*** rarcea has quit IRC | 19:56 | |
efried | cmurphy https://review.openstack.org/#/c/477566/4/doc/source/using-sessions.rst@171 -- I think min_version and version actually *do* mean the same thing in this context. | 19:56 |
efried | But I think I need mordred to clarify a little. | 19:57 |
mordred | efried: looking | 19:57 |
efried | oh, never mind, they don't mean the same thing at all. | 19:57 |
efried | I think I get it. | 19:57 |
mordred | efried, cmurphy: yes - they mean the same thing | 19:57 |
*** jamesmcarthur has joined #openstack-dev | 19:58 | |
mordred | efried, cmurphy: the only difference between version and min_version is whether or not max_version is also given | 19:58 |
efried | mordred Butbutbut... version=2.0 will not match 3.0; whereas min_version=2.0,max_version=latest will | 19:58 |
mordred | basically, having min_version, max_version parameters for rangers and a version parameter for exact matches | 19:58 |
mordred | oh 0 yes | 19:58 |
mordred | efried: you are very correct - thank you | 19:58 |
mordred | efried: there is indeed an actual semantic difference | 19:59 |
efried | version=2.0 will match 2.anything | 19:59 |
efried | But nothing else | 19:59 |
mordred | efried: yup. version=2.0 is like min_version=2.0 max_version=2.latest (I don't think _that_ syntax actually works) | 19:59 |
*** jamesmcarthur has quit IRC | 20:00 | |
*** renmak_ has joined #openstack-dev | 20:00 | |
*** renmak__ has joined #openstack-dev | 20:00 | |
cmurphy | thanks for clarifying - i still think the wording could be touched up to make it clearer | 20:00 |
efried | cmurphy Agree, working on it. Thanks. | 20:01 |
efried | mordred It actually appears as though anything after the first '.' in `version` is ignored (well, as long as it's validly numeric) | 20:04 |
efried | mordred Cancel that. | 20:04 |
efried | I am wrong | 20:04 |
mordred | efried: really? I think it's _supposed_ to at least express a min- so if you had a cloud that only had v2.0 and you requested version=2.0 it _should_ fail? | 20:05 |
mordred | ok. good | 20:05 |
*** diablo_rojo has quit IRC | 20:05 | |
efried | yahyah. If you say version=2.2, you don't get 2.1, but you get 2.3. (And you don't get 1.anything or 3.anything) | 20:05 |
*** xarses has quit IRC | 20:05 | |
*** diablo_rojo has joined #openstack-dev | 20:05 | |
*** edmondsw_ is now known as edmondsw | 20:07 | |
*** marst has quit IRC | 20:08 | |
*** jkilpatr has quit IRC | 20:11 | |
*** slaweq has quit IRC | 20:12 | |
*** annegentle has quit IRC | 20:12 | |
*** slaweq has joined #openstack-dev | 20:13 | |
*** armax has joined #openstack-dev | 20:13 | |
*** makowals has quit IRC | 20:17 | |
*** openstackgerrit has joined #openstack-dev | 20:18 | |
openstackgerrit | Doug Hellmann proposed openstack/governance master: move the vision from reference to resolution https://review.openstack.org/482686 | 20:18 |
*** fragatina has joined #openstack-dev | 20:21 | |
openstackgerrit | Doug Hellmann proposed openstack/governance master: move the vision from reference to resolution https://review.openstack.org/482686 | 20:21 |
*** sree has joined #openstack-dev | 20:23 | |
*** annegentle has joined #openstack-dev | 20:24 | |
*** sree has quit IRC | 20:27 | |
*** mgoddard_ has quit IRC | 20:32 | |
*** jkilpatr has joined #openstack-dev | 20:32 | |
*** annegentle has quit IRC | 20:33 | |
efried | cmurphy mordred Okay, done, see what you think. | 20:34 |
efried | https://review.openstack.org/#/c/477566/ | 20:34 |
efried | and morgan ^^ | 20:34 |
*** thorst has quit IRC | 20:35 | |
mordred | efried: looking really good | 20:38 |
mordred | efried, cmurphy: I wonder if we should add a note that these version, min_version and max_verison only apply to major api version and not to microversions | 20:39 |
cmurphy | mordred: please do | 20:39 |
cmurphy | that difference is super confusing | 20:39 |
efried | I'm super confused by it too. | 20:39 |
efried | I don't understand the difference between '2.4' and '2.4'. | 20:40 |
mordred | ok. maybe I need to write a short narrative on the differences | 20:41 |
mordred | cmurphy, efried I lke that patch - left three notes in it | 20:42 |
*** ansmith_ has quit IRC | 20:43 | |
*** ansmith has quit IRC | 20:43 | |
*** yusef has quit IRC | 20:44 | |
*** krtaylor has quit IRC | 20:46 | |
*** zzzeek_ has quit IRC | 20:49 | |
efried | mordred I think I'm going to have to get a better understanding about major versions and microversions before I try to wordsmith anything. | 20:53 |
mordred | efried: ok. I'll write a paragraph | 20:54 |
efried | Perhaps in the context of an example on something I've at least seen, if not necessarily understand. | 20:54 |
mordred | efried: the major distinction is that major versions define an endpoint - so nova major version v2.1 is at https://compute.example.com/v2.1 | 20:54 |
mordred | whereas microversions are a property of a given major version | 20:55 |
efried | So, like, in nova, we're in like the 2.40s or .50s in microversions. | 20:55 |
mordred | so the compute endpoint at https://compute.example.com/v2.1 declares a min and max microversion it supports | 20:55 |
mordred | and then theclient can request a given microversion on a PER REST CALL basis | 20:55 |
mordred | so a microversion is not a property of a connection | 20:55 |
mordred | it is a property of an individual request | 20:55 |
efried | Ayee, is there any requirement of numeric agreement between the major version and the microversions? | 20:56 |
mordred | so you say "openstack-compute-api-version: 2.38 GET /servers" | 20:56 |
mordred | no | 20:56 |
mordred | altohugh in common practice there is | 20:56 |
efried | So theoretically myservice v2.3 could support microversions 5.10-5.33 | 20:56 |
mordred | the min microversoin for nova 2.1 is ... 2.1 | 20:56 |
mordred | it could - but in openstack land that service would be mocked by its friends | 20:56 |
efried | okay, that's good to know. | 20:57 |
efried | But following the nova example... | 20:57 |
mordred | but in general, you find the major version you want | 20:57 |
mordred | then you find out what microversions it supports | 20:57 |
mordred | then you request or don't reuqest those microversoins when you make rest calls | 20:57 |
*** tobberydberg has quit IRC | 20:57 | |
mordred | if you don't request one, it'll default to min_microversion | 20:57 |
efried | Let's say we're up to microversion 2.55 on major version 2.1... If they wanted to release a new major version, would it have to be called 2.56? | 20:57 |
mordred | which SO FAR is the same as the major version for all of our services, but I believe ironic is going to do a bump in theirs | 20:57 |
*** tobberydberg has joined #openstack-dev | 20:57 | |
efried | Cause it would be real confusing if it was called v2.2 | 20:58 |
mordred | efried: if nova wanted to release a new major version, it would be called "v3" | 20:58 |
efried | So what's the point in having the .1 in the major version? | 20:58 |
efried | so to speak | 20:58 |
mordred | the 2.0 / 2.1 is a way to deal with the fact that nova didn't provide microversion information in its version discovery document for 2.0 | 20:58 |
mordred | so having a 2.1 endpoint tat is identical except that it provides a different version discovery doc | 20:59 |
mordred | was the way around 'breaking' the api compat | 20:59 |
*** Pharaoh_Atem has quit IRC | 20:59 | |
mordred | efried: this whole thing is made more complex because python*client do not present microversions to their users on a per-call basis | 20:59 |
efried | Ah, so in a more normal case, where everyone's following the rules, a major version would only have (or at least, need) one digit. | 20:59 |
mordred | efried: yup | 20:59 |
efried | which makes it more confusing that we normalize 'em all to two. | 21:00 |
mordred | yah - well - there are many things up in here where I'd make changes if I could travel back in time | 21:00 |
mordred | but for now, just understanding it all is a great step forward | 21:00 |
* morgan still greatly dislikes microversions., | 21:00 | |
efried | So where do >2-part version numbers come into play? | 21:01 |
efried | (Oh, I may have just awakened morgan's bugbear too) | 21:01 |
rockyg | mordred, quickie -- InteropWG has 2 full days scheduled at PTG -- Monday and Tuesday. In case I don't get the info to the rest of the TC in office hours | 21:01 |
*** priteau has joined #openstack-dev | 21:01 | |
*** tobberydberg has quit IRC | 21:01 | |
morgan | nope, i just pretend they don't exist and let other people write code around them | 21:01 |
morgan | *cough* like mordred *cough* | 21:02 |
mordred | :) | 21:03 |
cmurphy | i've only recently started engaging with microversions and all of a sudden mordred's schemes started making sense | 21:03 |
mordred | morgan: I have come to like them a lot - but the way they are presented in the python-*client libraries removes all usefulness they have | 21:03 |
cmurphy | ya :( | 21:03 |
mordred | morgan: if you actually interact with them as they exist at the REST layer, they're GREAT | 21:03 |
mordred | but that is not how anyone is seeing them right now - so people say things like "I want the endpoint for microversion 2.38" | 21:04 |
mordred | which is just flat wrong | 21:04 |
mordred | but - I will now write a paragraph about that real quick | 21:04 |
cmurphy | mordred: are you good with https://review.openstack.org/#/c/481309/5 ? i think it looks right | 21:05 |
mordred | cmurphy: yes - I just +2d but didn't +A in case you wanted to | 21:06 |
cmurphy | done | 21:06 |
*** Pharaoh_Atem has joined #openstack-dev | 21:06 | |
*** zzzeek_ has joined #openstack-dev | 21:11 | |
*** dhajare has quit IRC | 21:11 | |
morgan | mordred: i actually dont like microversions from a rest interaction either (not openstack's model of "microversions" that is) | 21:12 |
morgan | if it was more like libtool's versioning... i'd be happier | 21:12 |
mordred | morgan: I originally thought so too - but libtool's versionining is about declaring what API contracts an overall api can support | 21:13 |
mordred | morgan: whereas microversions says you can pick on an invocation by invocation basis which contract you want to use for a given function | 21:13 |
morgan | i think it's a bad bad design for lazy api development | 21:14 |
mordred | there isn't really a good equivilent in c linking | 21:14 |
morgan | *shrug* we wont ever agree on this | 21:14 |
morgan | fwiw | 21:14 |
*** etingof has joined #openstack-dev | 21:14 | |
morgan | so, i'll stick with "i wont deal with microversions" and focus on the stuff I can get behind. | 21:15 |
morgan | it's not an argument i can win nor really shift the direction of openstack with | 21:15 |
mordred | indeed - and fair | 21:15 |
morgan | i dislike rapid iteration on *any* api. | 21:16 |
mordred | I think I've been swayed beause the previous approach with major versions sucked so much worse | 21:16 |
*** vnogin has joined #openstack-dev | 21:16 | |
mordred | so if this prevents people from doing more major version changes - I'm all in :) | 21:16 |
morgan | i would rather do major api changes and have a well thought out target for the API. but it's that last part that we missed on so very much | 21:16 |
morgan | i would rather see keystone v4, than microversions in keystone ftr. (and NO not for auth, god no more auth tied to CRUD) | 21:17 |
morgan | anyway... going back to other things than talking about API design principles for the sake of talking about api design principles | 21:18 |
morgan | :P | 21:18 |
*** kylek3h has quit IRC | 21:19 | |
*** makowals has joined #openstack-dev | 21:20 | |
*** pcaruana has quit IRC | 21:23 | |
cdent | I’m almost relieved I missed that ^ conversation | 21:24 |
mordred | cdent: hey - don't go anywhere - I'm writing a paragraph for keystoneauth's docs about major and microversions | 21:25 |
mordred | it would be good to get a quick eyeball on it | 21:25 |
*** etingof has quit IRC | 21:25 | |
*** ihrachys has quit IRC | 21:25 | |
cdent | mordred, sure, i’m still typing away on my tc report, so I should be around for a while longer | 21:25 |
morgan | mordred: ugh, i want the new X1C... i can't justify spending $2k atm for a smaller laptop (bezel cut down) when my current one works fine. | 21:26 |
mordred | cdent, efried: https://review.openstack.org/482710 | 21:26 |
mordred | cmurphy: ^^ | 21:26 |
mtreinish | morgan: would you get it in silver? :p | 21:26 |
mordred | morgan: :) | 21:27 |
morgan | mtreinish: can't w/ discounts atm | 21:27 |
mordred | morgan: I'm excited that the retro thinkpad may actually be coming out soon | 21:27 |
morgan | mtreinish: but honestly, yes. i would in silver if i could. | 21:27 |
*** vnogin has quit IRC | 21:27 | |
morgan | mordred: it is reported it is this year (from official lenovo sources) | 21:27 |
morgan | mordred: but i am not holding my breath for a laptop I actually want from it | 21:27 |
mordred | morgan: I'm cautiously optimistic - since the only purpose of doing such a thing woudl be to appeal to the people who desire it to be similar to what I want, and otherwise literally no humans would buy it | 21:28 |
mordred | morgan: but - I agree | 21:28 |
mordred | morgan: I'm definitely not holding my breath | 21:28 |
*** wootehfoot has quit IRC | 21:30 | |
*** vnogin has joined #openstack-dev | 21:30 | |
rockyg | hey, morgan, just wanna say I whole heartedly agree with you on API versioning, thoughtful design and long life...but this statement is a footnote. I'm not holding myu breath for Thinkpad classic, either | 21:32 |
*** rockyg has quit IRC | 21:34 | |
*** thorst has joined #openstack-dev | 21:35 | |
*** ansmith_ has joined #openstack-dev | 21:39 | |
*** ansmith has joined #openstack-dev | 21:39 | |
mordred | cdent: "OpenStack-API-Version: compute 2.22" does everyone support that now? or is there an old form that sometimes needs to be sent too? | 21:39 |
cdent | mordred: I’m not certain that everyone is new way yet. | 21:40 |
cdent | I made the change in nova, and did it that way in placement from the start, but don’t know about anything else | 21:40 |
*** slaweq has quit IRC | 21:40 | |
cdent | (nova supports both, of course, because it has too) | 21:40 |
mordred | cdent: the old version is "X-OpenStack-Nova-API-Version: 2.114" right? | 21:40 |
cdent | let me just confirm | 21:41 |
cdent | my brain is weak | 21:41 |
mordred | blerg. that's going to be exceptionally ugly to support :( | 21:41 |
mordred | as the string "nova" isn't actually part of anything that exists anywhere | 21:41 |
cdent | X-OpenStack-Nova-API-Version | 21:41 |
mordred | cdent: thank you for making the new thing a thing that is tractable | 21:41 |
cdent | yeah, I bought into the idea of service types whole hog and once I did that, I was like “private info in the left hand side of a header pair is bogus” | 21:42 |
*** thorst has quit IRC | 21:42 | |
*** jprovazn has quit IRC | 21:43 | |
*** etingof has joined #openstack-dev | 21:44 | |
*** makowals has quit IRC | 21:45 | |
cdent | good doc changes on the keystone stuff mordred, had several suggestins, but overall nice | 21:47 |
*** eharney has quit IRC | 21:47 | |
cdent | oh, my stats, I have disagreed with cmurphy’s +2. heaven forfend! | 21:49 |
cdent | efried: I may need to make this my new sig: “Something something Big Tent something Governance something something Official.” | 21:50 |
efried | cdent I will sue for copyright infringement. Cause that's open. | 21:50 |
cdent | something something fair use something something parody something | 21:51 |
efried | :D | 21:52 |
mordred | cdent: I meant it can be confusing in a keystoneauth context as one starts to use keystoneauth to do version discovery for you | 21:52 |
mordred | cdent: where the previous typical use of keystoneauth did not have keystoneauth be the one handling version discovery | 21:52 |
* mordred is talking out loud to try to figure out a good rewording | 21:52 | |
cdent | quack | 21:53 |
*** systems-sk has quit IRC | 21:55 | |
efried | mordred I believe pursuit of https://review.openstack.org/#/c/477566/5/doc/source/using-sessions.rst@268 has uncovered a bug. | 21:57 |
*** gordc has quit IRC | 21:57 | |
efried | mordred I think it goes like this: If I init an Adapter(..., version='v1.2', ...) and then call that guy's get_endpoint_data(..., min/max_version=whatever, ...), I'll get spanked for "specifying" mutually exclusive version + min/max_version. | 21:59 |
*** jamesbenson has quit IRC | 21:59 | |
*** yassine has quit IRC | 22:00 | |
efried | mordred Which, granted, I *sorta* did. But I'm not sure if that's really the expected behavior. Like I'm thinking, if min/max_version is given to Adapter.get_endpoint_data, perhaps we should *not* add Adapter.version into the kwargs. | 22:00 |
efried | mordred Though perhaps we *also* make sure that the specified min/max_version is compatible with the Adapter's `version`. | 22:02 |
*** yassine has joined #openstack-dev | 22:03 | |
*** felipemonteiro__ has quit IRC | 22:04 | |
*** vnogin has quit IRC | 22:05 | |
mordred | cmurphy, efried, cdent: https://review.openstack.org/482710 may be better now? | 22:06 |
*** morazi has quit IRC | 22:06 | |
mordred | efried: hrm. good clarification - I _think_ my personal intent originally is that the purpose of get_endpoint_data on an adapter is to get the endpoint data associated with the given adapter | 22:07 |
mordred | efried: using an adapter to get arbitrary endpoint data for a different versioned endpoint seems ... weird | 22:07 |
mordred | efried: maybe we should not accept arguments on adapter's get_endpoint_data? | 22:08 |
efried | mordred So perhaps it shouldn't accept arbirtary kwargs to pass through. Perhaps it should *just* construct kwargs via ... | 22:08 |
efried | yeah, what you said. | 22:08 |
mordred | efried: if a person really wants an arbitrary discovery result, they can always do adapter.session.get_endpoint_data | 22:08 |
efried | gross | 22:08 |
efried | I think that's arguably even more confusing. | 22:09 |
efried | It may be technically possible to do, but I certainly wouldn't recommend it in a doc or anything. | 22:09 |
efried | If you want an arbitrary discovery result not related to an Adapter you already built, you should build a new Adapter, or a new Session, or use an auth you've got lying around, or something. | 22:10 |
*** baoli has quit IRC | 22:10 | |
efried | mordred This also made me wonder whether it makes any sense for Adapter.__init__ to accept min/max_version (as mutually exclusive with the existing `version`). | 22:10 |
*** baoli has joined #openstack-dev | 22:11 | |
*** baoli has quit IRC | 22:11 | |
mordred | efried: yes | 22:11 |
mordred | efried: does it not? I think adapter has to accept the whole gamut | 22:12 |
mordred | if it doesn't accept min/max that was an oversight not an intent | 22:12 |
efried | def __init__(self, session, service_type=None, service_name=None, | 22:12 |
efried | interface=None, region_name=None, endpoint_override=None, | 22:12 |
efried | version=None, auth=None, user_agent=None, | 22:12 |
efried | connect_retries=None, logger=None, allow={}, | 22:12 |
efried | additional_headers=None, client_name=None, | 22:12 |
efried | client_version=None, allow_version_hack=None, | 22:12 |
efried | global_request_id=None): | 22:12 |
efried | I'm on the branch with that rst we're reviewing, which may be based on a backlevel master commit. | 22:12 |
efried | Lemme look on github... | 22:13 |
efried | mordred Nope: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/adapter.py#L73-L79 | 22:13 |
efried | Unless that change hasn't landed yet. | 22:13 |
efried | nope. | 22:14 |
*** priteau has quit IRC | 22:15 | |
efried | So. | 22:15 |
mordred | efried: neat! good find - we should add | 22:15 |
efried | mordred Sounds like we want to put up a patch to make 1) Adapter.__init__ accept min/max_version; and 2) Adapter.get_endpoint_data not accept arbitrary kwargs. And then delta https://review.openstack.org/#/c/477566/ to reflect same. | 22:16 |
*** markvoelker has quit IRC | 22:16 | |
*** markvoelker has joined #openstack-dev | 22:17 | |
efried | mordred You going to do that patch or want me to have a crack at it? (I wouldn't get to it til tomorrow.) | 22:17 |
*** gmoro has quit IRC | 22:17 | |
efried | Since it's mucking with public APIs, I guess it also needs to be done before we release. | 22:17 |
*** gmoro has joined #openstack-dev | 22:17 | |
mordred | efried: I can do it on top of this patchset I've got going | 22:17 |
efried | ight | 22:17 |
efried | Hasta mañana, y'all | 22:18 |
*** efried is now known as efried_zzz | 22:19 | |
*** jathan_ has quit IRC | 22:20 | |
*** ikhan_ has quit IRC | 22:20 | |
*** ikhan has joined #openstack-dev | 22:20 | |
*** bnemec has quit IRC | 22:24 | |
*** jcoufal has quit IRC | 22:24 | |
*** bnemec has joined #openstack-dev | 22:25 | |
*** ikhan has quit IRC | 22:25 | |
*** edmondsw has quit IRC | 22:26 | |
*** bknudson has quit IRC | 22:28 | |
*** jbadiapa_ has joined #openstack-dev | 22:29 | |
*** jbadiapa has quit IRC | 22:31 | |
*** bobh has quit IRC | 22:34 | |
*** galstrom is now known as galstrom_zzz | 22:38 | |
*** slaweq has joined #openstack-dev | 22:41 | |
*** xemdetia has quit IRC | 22:42 | |
cdent | mordred: 🚢 | 22:45 |
*** slaweq has quit IRC | 22:46 | |
*** juvenal has joined #openstack-dev | 22:47 | |
mordred | cdent: you are more skilled with typing than I | 22:52 |
cdent | i think not sir, I think I can paste | 22:52 |
* cdent waves goodnight | 22:56 | |
*** cdent has quit IRC | 22:56 | |
*** claudiub has quit IRC | 22:58 | |
*** charcol has quit IRC | 22:58 | |
*** jaypipes has quit IRC | 23:00 | |
*** nplanel has joined #openstack-dev | 23:02 | |
*** renmak_ has quit IRC | 23:04 | |
*** renmak__ has quit IRC | 23:04 | |
*** juvenal has quit IRC | 23:09 | |
mordred | edleafe: I just remembered I need to add support for your next_min_version | 23:23 |
*** ihrachys has joined #openstack-dev | 23:25 | |
*** makowals has joined #openstack-dev | 23:27 | |
*** juvenal has joined #openstack-dev | 23:30 | |
*** matjazp has quit IRC | 23:34 | |
*** d0ugal has joined #openstack-dev | 23:36 | |
*** slaweq has joined #openstack-dev | 23:43 | |
*** sridharg has joined #openstack-dev | 23:45 | |
*** diablo_rojo has quit IRC | 23:46 | |
*** thorst has joined #openstack-dev | 23:47 | |
*** slaweq has quit IRC | 23:47 | |
*** krtaylor has joined #openstack-dev | 23:50 | |
*** juvenal has quit IRC | 23:54 | |
*** awaugama has joined #openstack-dev | 23:56 | |
*** mattmceuen has quit IRC | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!