Tuesday, 2014-02-04

bknudsonwe really should get away from eventlet and use something sane like twisted or asycio00:01
dstanekbknudson: i think that would be a pretty big rewrite00:02
*** ijw has quit IRC00:03
lifelessbknudson: we used to use twisted.00:03
*** boris-42_ has quit IRC00:03
*** ijw has joined #openstack-dev00:04
*** ekarlso- has joined #openstack-dev00:04
*** kenperkins has quit IRC00:06
*** Mandell has quit IRC00:06
*** markwash has joined #openstack-dev00:06
bknudsonlifeless: what caused the switch? something wrong with it?00:06
bknudsonI haven't used either but have used async libraries for c++ and javascript... seemed to make more sense.00:06
*** boris-4__ has quit IRC00:07
*** jckasper has joined #openstack-dev00:07
dstanekbknudson: eventlet is one of our Python3 problems00:07
lifelessbknudson: too many developers with not enough experience, twisted is super powerful but beginners often find it intimidating00:07
bknudsonI'm guessing we'd still have the problem with db queries blocking.00:08
bknudsondstanek: and WebOb!00:08
*** ijw has quit IRC00:08
*** gokrokve has joined #openstack-dev00:09
*** yamahata has joined #openstack-dev00:10
*** marun has joined #openstack-dev00:10
*** sweston has quit IRC00:10
dstanekbknudson: are db queries blocking right now?00:10
bknudsondstanek: I assume so... since I assume they're calling c code?00:11
dstanekbknudson: that would be an interesting test00:12
bknudsondstanek: as far as I can tell keystone can only handle one request at a time.00:12
*** matsuhashi has joined #openstack-dev00:12
*** doug_shelley66 has quit IRC00:12
*** zyluo has joined #openstack-dev00:13
*** zyluo has quit IRC00:13
*** zyluo has joined #openstack-dev00:14
dstanekbknudson: what was the setup you were testing? under apache?00:14
*** marun has quit IRC00:15
bknudsondstanek: to see if keystone handles more than one request at a time?00:15
*** zzelle has quit IRC00:15
*** alexpilotti has quit IRC00:15
dstanekbknudson: yeah00:15
*** pmathews has quit IRC00:15
bknudsondstanek: this was some time ago... we had a scaling/stability test that created millions of tokens00:16
*** IanGovett has quit IRC00:16
bknudsonthen keystone ops started to fail due to timeouts00:16
*** david-lyle has quit IRC00:16
bknudsonbecause auth_token middleware was getting revoken token list (trying to every second but it took several seconds)00:16
bknudsonand since all the requests were essentially signle-threaded it wound up taking several minutes for each service to get the list00:17
dstanekbknudson: was it because request were serial or that you just reached the per process limit?00:17
*** clayb has quit IRC00:17
bknudsondstanek: I'll have to try to do some more tests. We solved the revoked list with an index.00:18
*** thuc has quit IRC00:18
bknudsonsince there weren't actually any revoked tokens.00:18
*** thuc has joined #openstack-dev00:19
*** david-lyle has joined #openstack-dev00:20
*** eharney has quit IRC00:20
*** mriedem has joined #openstack-dev00:20
*** JStoker has quit IRC00:20
*** Mandell has joined #openstack-dev00:20
*** cdub has joined #openstack-dev00:22
*** zyluo has quit IRC00:22
*** zyluo has joined #openstack-dev00:23
*** byeager has quit IRC00:23
*** thuc has quit IRC00:23
*** JStoker has joined #openstack-dev00:24
*** faramir1 has joined #openstack-dev00:24
*** jaypipes has quit IRC00:27
*** achampion has joined #openstack-dev00:29
*** yamahata has quit IRC00:29
*** mikal_ is now known as mikal00:29
*** rowleyaj has quit IRC00:30
*** carl_baldwin has quit IRC00:31
*** jaypipes has joined #openstack-dev00:32
*** nosnos has joined #openstack-dev00:33
*** yamahata has joined #openstack-dev00:33
*** tserong has joined #openstack-dev00:33
*** sweston has joined #openstack-dev00:35
*** tjones has joined #openstack-dev00:38
*** terriyu has joined #openstack-dev00:39
*** terriyu has quit IRC00:39
*** thuc has joined #openstack-dev00:39
*** armax has joined #openstack-dev00:40
*** yamahata has quit IRC00:43
*** nosnos_ has joined #openstack-dev00:44
*** nosnos has quit IRC00:47
*** alexpilotti has joined #openstack-dev00:47
*** kgriffs is now known as kgriffs_afk00:48
*** asalkeld has quit IRC00:48
*** yamahata has joined #openstack-dev00:48
*** ekarlso has quit IRC00:50
*** alexpilotti has quit IRC00:51
*** Tross has quit IRC00:53
*** nosnos_ has quit IRC00:54
*** nosnos has joined #openstack-dev00:54
*** gordc has quit IRC00:54
*** gokrokve has quit IRC00:55
*** david_lyle_ has joined #openstack-dev00:55
*** Tross has joined #openstack-dev00:55
*** sjmc7 has quit IRC00:56
*** CaptTofu has joined #openstack-dev00:56
*** gyee has quit IRC00:59
*** david-lyle has quit IRC00:59
*** galstrom_zzz is now known as galstrom01:00
*** mrodden has quit IRC01:00
*** galstrom is now known as galstrom_zzz01:00
*** JStoker has quit IRC01:01
*** atiwari has quit IRC01:03
*** JStoker has joined #openstack-dev01:05
*** JStoker has quit IRC01:07
*** asalkeld has joined #openstack-dev01:08
*** JStoker has joined #openstack-dev01:08
*** Steap has joined #openstack-dev01:09
*** thuc has quit IRC01:10
*** thuc has joined #openstack-dev01:10
*** ijw has joined #openstack-dev01:10
*** Mandell has quit IRC01:11
*** otherwiseguy has joined #openstack-dev01:12
*** Mandell has joined #openstack-dev01:12
*** colinmcnamara has quit IRC01:13
*** asalkeld has quit IRC01:14
*** asalkeld has joined #openstack-dev01:14
*** thuc has quit IRC01:14
*** mrodden has joined #openstack-dev01:15
*** tdruiva has joined #openstack-dev01:17
*** tdruiva has joined #openstack-dev01:17
*** ijw has quit IRC01:18
*** comay has joined #openstack-dev01:24
*** amcrn has quit IRC01:24
*** mestery has joined #openstack-dev01:25
*** colinmcnamara has joined #openstack-dev01:25
*** mestery has quit IRC01:26
*** sarob has quit IRC01:26
*** mestery has joined #openstack-dev01:26
*** devoid has quit IRC01:27
*** jmching has joined #openstack-dev01:28
*** marun has joined #openstack-dev01:28
*** jmching has quit IRC01:28
*** nrs_ has joined #openstack-dev01:30
*** asalkeld has quit IRC01:31
*** marun has quit IRC01:33
*** godara has quit IRC01:34
*** browne has quit IRC01:35
*** tjones has left #openstack-dev01:37
*** peoplemerge has quit IRC01:37
*** marcoemorais1 has quit IRC01:38
*** david-lyle has joined #openstack-dev01:40
*** colinmcnamara has quit IRC01:43
*** pixelb has quit IRC01:43
*** david_lyle_ has quit IRC01:44
*** asalkeld has joined #openstack-dev01:45
*** mikeoutland has quit IRC01:46
*** mestery has quit IRC01:47
*** gokrokve has joined #openstack-dev01:47
stevemar2bknudson, if we had utility_v3, then restfultest case would have to extend that too?01:48
stevemar2bknudson, unless you want to import it as it's needed... which would be painful to change :P01:48
bknudsonstevemar2: there's no need to extend anything, just call the function in utility_v3.01:48
*** kenperkins has joined #openstack-dev01:48
bknudsonstevemar2: yes, we've built up a lot of crufty technical debt.01:49
stevemar2bknudson, that's a lot of line change01:49
bknudsonshould just be a search/replace.01:49
*** MaxV has joined #openstack-dev01:49
*** doug_shelley66 has joined #openstack-dev01:49
stevemar2bknudson, grumble grumble01:49
bknudsonwould be nice if the review queue wasn't so long because the change will wind up conflicting all over the place.01:49
stevemar2yeah01:49
*** sandywalsh_ has quit IRC01:50
stevemar2maybe i'll hold off on it?01:50
stevemar2til after feb 18?01:50
*** jecarey has joined #openstack-dev01:50
bknudsonstevemar2: ok... not sure why this was being done in the first place?01:50
*** tjones has joined #openstack-dev01:50
bknudsonstevemar2: a smaller change would be to create the new file and then essentially import them into restfultestcase (or whatever it is).01:51
bknudsonthen use the new file wherever you can.01:51
stevemar2bknudson, could do that01:51
stevemar2bknudson, i guess still keep the functions in restfultestcase, but have act as a wrapper and call the new file?01:52
*** stevemar2 is now known as stevemar01:52
*** ann has joined #openstack-dev01:53
bknudsonstevemar: right, should be able to do new_user_ref = utility_v3.new_user_ref01:53
*** MaxV has quit IRC01:54
ayoungbknudson, stevemar ...so YorikSar takes my code, and rewrites into a much cleaner, cooler, and more pythonic than I could ever do...I don't even feel competent enough to review it.01:54
*** xarses has quit IRC01:54
*** markmcclain1 has joined #openstack-dev01:54
*** tsekiyama has quit IRC01:54
annon ubuntu 12.04 lts apt-get install git - errors "package not found" and apt-get install git-core errors "'git-core' has no installation candidate"....01:54
*** markmcclain has quit IRC01:54
annany ideas?01:55
ayoungann maybe your apt repos are not showing up01:55
ayoungapt-get update01:55
bknudsonayoung: make sure you're left on there as a co-authored-by to take some of the credit.01:56
stevemarayoung, been there, done that01:56
ayoungWTF  does this do01:56
ayoungbundle = filter(None, bundle)01:56
jamielennoxayoung: removes None/FAlse values01:56
*** markmcclain1 has quit IRC01:56
ayounghave you seen this?01:57
ayounghttps://review.openstack.org/#/c/69531/8/keystone/contrib/revoke/model.py01:57
bknudsonhttp://docs.python.org/2/library/functions.html#filter01:57
ayoungcomment at the bottom01:57
ayoungbknudson, I read it three times01:57
bknudsonit says in the docs that None is a special case.01:57
ayoung"If function is None, the identity function is assumed, that is, all elements of iterable that are false are removed."01:58
ayoungand None is falsey01:58
*** nati_uen_ has joined #openstack-dev01:59
ayoungI love that he used faggot in its original meaning:  a bundle of sticks.01:59
*** nati_uen_ has quit IRC01:59
bknudsonayoung: you might want to pick a different variable name.01:59
ayoungyeah01:59
ayoungI'm going Roman on that one01:59
ayoungFascii01:59
*** sweston has quit IRC02:00
*** gokrokve has quit IRC02:00
annstarted apt-get update.... but seems very slow... only3% in last few min02:00
*** nati_uen_ has joined #openstack-dev02:00
annon an average, how long does it take to do apt-get update?02:00
ayoungann usually not long02:00
ayoungit is just downloading the package names and some data about them02:00
bknudsonann: you running in a vm?02:01
ayoungMetadata to use an overused term02:01
annyes vm02:01
bknudsonann: on my system I have to set the mtu on the vm to get through the vpn.02:01
*** markmcclain has joined #openstack-dev02:01
*** baoli has joined #openstack-dev02:01
*** CaptTofu has quit IRC02:02
*** nati_ueno has quit IRC02:02
ayoungah, ok. I butchered his code moving it into my repo...he is resetting the erm...bundle object  and I was not02:02
*** russellb has joined #openstack-dev02:02
*** CaptTofu has joined #openstack-dev02:03
*** gokrokve has joined #openstack-dev02:03
ayoungoh, no wait, I am...this is so flipping cool02:03
bknudsonyou can do else on a for?02:03
ayoungbknudson, yes you can02:03
ayoungI learned that on this review too02:04
bknudsonah, when there's no break.02:04
*** kenperkins has quit IRC02:04
ayoungthis is the most fun I've had coding in years02:04
*** sarob has joined #openstack-dev02:04
ayounghe makes use of Map, too02:04
ayoungand setdefault02:04
ayoungits poetry02:04
*** tjones has left #openstack-dev02:04
*** sandywalsh_ has joined #openstack-dev02:06
ayoungI'm totally making him co-author on this02:07
*** tdruiva has quit IRC02:10
*** Mandell has quit IRC02:10
*** bswartz has joined #openstack-dev02:11
*** crank has quit IRC02:14
*** crank has joined #openstack-dev02:14
ayoungjamielennox, so, what if a function takes two parameters, and I want to use filter  to check a list against a single value?  can I do that somehow?02:15
*** sgordon has joined #openstack-dev02:16
jamielennoxfilter(lambda x,y: x is True, list)02:16
bknudsonayoung: functools.partial02:16
jamielennoxor that02:16
jamielennoxdepends on whether the first is static02:17
ayoungI have a token data and a list of events I want to call matches(event, token_data)  for one token_data and every element of events02:17
ayoungso02:17
ayoungI want map02:17
*** epim has quit IRC02:17
ayoungsince that returns the true values, and something like02:18
jamielennoxayoung: i don't think you should ever need map in python02:18
*** byeager has joined #openstack-dev02:18
ayoungmap(events, [token_data])02:18
jamielennoxyou should be able to use list comprehension for most everything map does02:18
*** melwitt has quit IRC02:18
ayounger02:18
ayoungI mean filter02:18
ayoungfilter(_matches, events, [token_data])02:18
*** kenperkins has joined #openstack-dev02:19
jamielennoxayoung i'm not sure what you're attempting02:19
ayoungf = [_matches(e, token_data) for e in events]02:20
ayoungprobably what I want  ^^02:20
jamielennoxyea02:20
ayoungthen I can check len(f) > 002:21
bknudsonayoung: ahhh!02:21
jamielennoxwhat does _matches return?02:21
ayoungbknudson, its my backup check02:21
bknudsonayoung: can just check if f -- no len reqd.02:21
ayoungjamielennox, True if the event matches the token_data02:21
ayoungotherwise False02:21
ayoungbknudson, ++02:21
jamielennoxso [ e for e in events if _matches(e, token_data) ]02:22
jamielennoxthere is also a built-in called any() that sounds very much like this02:22
ayoungah, yip02:22
ayoungany( e for e in events if _matches(e, token_data) ]02:22
*** hartsocks has left #openstack-dev02:22
jamielennoxthe problem with all of these is that you have to evaluate every event before you can tell if any match02:23
jamielennoxi think you're just better of with a for/else02:23
ayoungjamielennox, its ok, this is the second, slow, implementation, just to check the logic of the fast one02:23
ayoungthe real deal is the algorithm that YorikSar rewrote02:24
*** kenperkins_ has joined #openstack-dev02:24
*** sarob has quit IRC02:25
*** sarob has joined #openstack-dev02:25
*** tdruiva has joined #openstack-dev02:26
bknudsonwhat do you think about setting fatal_deprecations for the tests... require marking tests that use deprecated function with a decorator.02:27
bknudsonmaybe that will convince us to stop using deprecated function02:27
jamielennoxbknudson: i think that should be something we do with the warnings module02:27
jamielennoxyou can have that trigger a deprecation fail02:27
bknudsonjamielennox: for some reason oslo-incubator logging doesn't use the warnings module.02:28
*** colinmcnamara has joined #openstack-dev02:28
*** kenperkins has quit IRC02:28
bknudsonjamielennox: there's a config setting: http://git.openstack.org/cgit/openstack/oslo-incubator/tree/openstack/common/log.py#n31402:28
*** galstrom_zzz is now known as galstrom02:28
jamielennoxi remember seeing that - i wonder if someone just didn't know it existed02:28
jamielennoxbesides we don't use that for deprecation logging do we?02:29
bknudsonjamielennox: we do use that02:29
*** david-lyle has quit IRC02:29
jamielennoxok02:29
bknudsonthe @deprecated decorator winds up calling LOG.deprecated.02:30
*** sarob has quit IRC02:30
*** kenperkins has joined #openstack-dev02:30
jamielennoxthen i guess it makes sense to put fatal_deprecated in the tests02:30
bknudsonI think about half the tests fail.02:30
jamielennoxbknudson: so blueprint time02:31
bknudsonRan 2374 (+1) tests in 500.339s (-221.704s)02:31
bknudsonFAILED (id=1577, failures=995 (+995), skips=211)02:31
ayoungjamielennox, did you see that people are agreeing with me about the need for an Ugly hack to deal with versions....I didn't realize how bad the Nova folks made it for themselves02:31
jamielennoxayoung: i saw other people starting to take interest and no other good ideas02:31
bknudsonwe skip almost 10% of tests.02:31
jamielennoxthat's almost agreeing02:31
ayoungjamielennox, I would love it if we didn't have to do it.02:31
ayoungBut we have to02:32
jamielennoxayoung: i prototyped it the other day about how i could make it work with auth_plugins02:32
ayoungwe've painted ourselves into the corner.  Lets walk across the paint, clean out shoes and be smarter next time02:32
ayoungjamielennox, with *existing* clients?02:32
ayoungthat is the rub.02:32
jamielennoxayoung: with any client that uses the session object02:32
ayoungYou can do all sorts of smarts with new clients02:32
ayounggreat, lets do it02:32
*** kenperkins_ has quit IRC02:33
ayoungmeanwhile, the old client still need urls that end with /v2.002:33
bknudsonnova is different because not only do they have the version in the endpoint they also have the tenant02:33
*** cdub has quit IRC02:33
ayoungbknudson, what does one of their URLs look like?02:33
jamielennoxbknudson: yuk forgot about that02:33
jamielennoxthat's completely wrong02:33
*** galstrom is now known as galstrom_zzz02:34
bknudsonhttp://git.openstack.org/cgit/openstack-dev/devstack/tree/files/default_catalog.templates#n902:34
bknudsonhttp://%SERVICE_HOST%:8774/v2/$(tenant_id)s02:34
jamielennoxbknudson: how did that ever work with multiple tenants?02:34
bknudsonlooks like heat went the same route http://%SERVICE_HOST%:8004/v1/$(tenant_id)s02:34
*** erkules_ has joined #openstack-dev02:35
bknudsonjamielennox: you get a token scoped to a tenant.02:35
*** pablosan has quit IRC02:35
ayoungSo..we need to chop both the /v1 and the /$(tenant_id)s  portion to get to a generic, versionless url?02:35
jamielennoxbut you don't get an endpoint scoped to a tenant02:35
bknudsonjamielennox: you get an endpoint with the tenant ID.02:35
ayoungnah, they just pass it as a n URL, and then their client fills it in, I bet02:35
*** kenperkins_ has joined #openstack-dev02:35
*** kenperkins_ has quit IRC02:36
bknudsonnow I have to try it.02:36
jamielennoxbknudson: i mean that when you get a token scoped tenant it won't check the tenant_id - so you can easily get an endpoint for an incorrect tenant02:36
jamielennoxbknudson: actually no, that's the string substitution happens late02:37
jamielennoxnevermind me02:37
*** pablosan has joined #openstack-dev02:37
*** erkules has quit IRC02:37
ayoung"The most merciful thing in the world, I think, is the inability of the human mind to correlate all its contents."  HP Lovecraft02:37
*** kenperkins has quit IRC02:38
*** xarses has joined #openstack-dev02:38
jamielennoxayoung: so start checking auth plugin patches because i want to have this as my reason to make clients use session objects02:39
jamielennoxi can just start telling clients to adopt it and they won't have to worry02:39
*** Gordonz has joined #openstack-dev02:39
ayoungjamielennox, you are in serious denial02:40
ayoungyou can't fix this02:40
ayoungyou could write the most elegant code in the world02:40
ayoungwon02:40
ayoung't matter02:40
ayoungCUZ of the FLIPPING existing clients we need to support02:41
jamielennoxayoung: oh yea, i know but i'd prefer this hack to get implemented once02:41
ayoungjamielennox, ++02:41
*** Gordonz has quit IRC02:42
ayoungI promise to review any and all session related client  patches02:42
bknudsonkeystone ec2-credentials-create --user-id 722d573ad57b4a72a328dfcdc7f233fc --tenant-id 98538edbdadd4d149bc8cae93a80d718 --02:42
bknudson|  trust_id |                                  |02:42
jamielennoxayoung: otherwise we end up with somebody else implementing service catalog parsing02:42
bknudsonis it weird the v2 ec2-credentials-create returns trust_id?02:42
ayoungnope02:42
ayoungit is an optional field bknudson02:42
bknudsonuser-create doesn't return a domain ID?02:42
ayoungV202:43
ayoungV3 should02:43
*** Gordonz has joined #openstack-dev02:44
bknudsonwhen you get your token the tenant is filled into the endpoints -- http://192.168.122.176:8774/v2/f173773d9b3c4dd6be95ffc31852370002:45
jamielennoxjaypipes: ping02:45
bknudsonjamielennox: other client libs have service catalog parsing.02:46
jamielennoxbknudson: yea, there is a weird substitution thing that takes data from config and your current auth and build the service catalog late02:46
bknudsoncinder does... http://git.openstack.org/cgit/openstack/python-cinderclient/tree/cinderclient/service_catalog.py02:47
jamielennoxbknudson: yea, my point02:47
jamielennoxneed to prevent this replication02:47
*** nati_ueno has joined #openstack-dev02:48
*** buzztroll has quit IRC02:48
*** nati_ueno has quit IRC02:49
*** _cjones_ has quit IRC02:49
*** nati_ueno has joined #openstack-dev02:50
*** MaxV has joined #openstack-dev02:50
ayoungtis late here jamielennox even on the West Coast02:51
*** nati_uen_ has quit IRC02:51
jamielennoxyea didn't expect that02:51
*** buzztroll has joined #openstack-dev02:52
jamielennoxwas worth a try though02:52
*** colinmcnamara has quit IRC02:52
jamielennoxhe left some comments on https://review.openstack.org/#/c/70663 and i'm not sure of a different approach02:53
*** fandi has joined #openstack-dev02:53
*** MaxV has quit IRC02:54
*** arnaud__ has quit IRC02:56
*** markmcclain has quit IRC02:56
*** arnaud has quit IRC02:56
*** aveiga has quit IRC02:56
*** byeager has quit IRC02:56
*** zyluo has quit IRC02:56
*** byeager has joined #openstack-dev02:57
*** pradeep has joined #openstack-dev02:57
*** novas0x2a|laptop has quit IRC02:58
*** markwash has quit IRC02:59
*** baoli has quit IRC03:01
*** mikeoutland has joined #openstack-dev03:02
*** mikeoutland has quit IRC03:03
*** dkehn_ has joined #openstack-dev03:04
*** buzztroll has quit IRC03:05
*** lbragstad has joined #openstack-dev03:05
*** spzala has quit IRC03:05
*** mikeoutland has joined #openstack-dev03:05
*** armax has left #openstack-dev03:07
*** otherwiseguy has quit IRC03:07
*** matiu has joined #openstack-dev03:07
*** matiu has quit IRC03:07
*** matiu has joined #openstack-dev03:07
*** alop has quit IRC03:08
*** mikeoutland has quit IRC03:10
*** nati_ueno has quit IRC03:11
*** russellb has quit IRC03:12
*** boris-42_ has joined #openstack-dev03:12
*** nati_ueno has joined #openstack-dev03:12
*** nati_ueno has quit IRC03:13
*** nati_ueno has joined #openstack-dev03:13
*** Tross has quit IRC03:15
*** faramir1 has quit IRC03:15
*** paragan has joined #openstack-dev03:18
jog0SpamapS: to unwedge heat https://review.openstack.org/7089403:19
jog0devananda: to unwedge ironic https://review.openstack.org/7089603:20
*** rraja_ has joined #openstack-dev03:20
*** krotscheck has quit IRC03:21
*** gokrokve has quit IRC03:26
*** sarob has joined #openstack-dev03:26
*** gokrokve has joined #openstack-dev03:26
*** baoli has joined #openstack-dev03:28
*** gokrokve has quit IRC03:30
*** gokrokve has joined #openstack-dev03:32
*** carl_baldwin has joined #openstack-dev03:32
*** sarob has quit IRC03:32
*** doug_shelley66 has quit IRC03:34
*** buzztroll has joined #openstack-dev03:35
*** ann has quit IRC03:36
*** buzztroll has quit IRC03:37
*** buzztroll has joined #openstack-dev03:37
*** emagana has quit IRC03:39
*** gokrokve has quit IRC03:40
*** jecarey has quit IRC03:41
*** jckasper has quit IRC03:43
*** jckasper has joined #openstack-dev03:43
*** neelashah has joined #openstack-dev03:47
*** jckasper has quit IRC03:48
*** jckasper has joined #openstack-dev03:49
*** jpomero has quit IRC03:49
*** byeager_ has joined #openstack-dev03:50
*** coasterz has quit IRC03:50
*** MaxV has joined #openstack-dev03:51
*** baoli has quit IRC03:53
*** buzztroll has quit IRC03:53
*** buzztrol_ has joined #openstack-dev03:53
*** byeager has quit IRC03:53
*** rraja_ has quit IRC03:55
*** MaxV has quit IRC03:55
*** buzztrol_ has quit IRC03:56
*** david-lyle has joined #openstack-dev03:57
*** buzztroll has joined #openstack-dev03:57
*** carl_baldwin has quit IRC03:58
*** otherwiseguy has joined #openstack-dev03:59
*** byeager_ has quit IRC03:59
*** Mandell has joined #openstack-dev04:01
*** byeager has joined #openstack-dev04:02
*** sandywalsh_ has quit IRC04:02
*** troytoman is now known as troytoman-away04:03
*** byeager has quit IRC04:06
*** buzztroll has quit IRC04:07
ayoungjamielennox, https://review.openstack.org/#/c/61247/  a month later and it still looks good04:09
jamielennoxayoung: still awake04:09
ayoungAbout to crash04:09
jamielennoxayoung: yea, that was supposed to go in prior to 0.4.7 or whatever but missed it04:09
ayoungfeh04:09
ayoungDeadlines shmeadlines04:10
jamielennoxAPI compatibility schemadability?04:10
ayoungThat too04:10
*** carl_baldwin has joined #openstack-dev04:10
ayoungWe need a settle in time....this "commit to master means GA" crap is crazy04:11
*** gokrokve has joined #openstack-dev04:11
ayoungBut I digest...04:11
jamielennoxayoung: dolph sent out an email this time before relasing client04:11
jamielennoxthat was useful04:11
ayoungare we OK with these changes still?04:12
jamielennoxwhich ones?04:12
ayounghttps://review.openstack.org/#/c/60751/1004:12
ayoungand the rest of the auth plugin stack04:12
*** gokrokve_ has joined #openstack-dev04:13
jamielennoxthe authenticate() call was useful - but if this makes it easier for people then i don't think it matters04:13
*** harlowja is now known as harlowja_away04:13
ayoungI'll ignore the fact that we change the order of parameters for the long kv param lists...anyone calling those by order deserves to have their code broken04:14
jamielennoxi did?04:14
*** carl_baldwin has quit IRC04:15
ayoungauth went in the front of the list04:15
*** harlowja_away is now known as harlowja04:15
jamielennoxoh i removed some and made them kwargs04:15
jamielennox.. no different review then04:15
jamielennoxwhat are you looking at?04:15
*** joearnold has quit IRC04:16
*** amandap has quit IRC04:16
*** hugokuo has quit IRC04:16
*** koolhead17 has quit IRC04:16
*** anderstj has quit IRC04:16
ayoungone sec, I clicked past it04:16
ayounghttps://review.openstack.org/#/c/60751/10/keystoneclient/session.py04:16
*** gokrokve has quit IRC04:16
jamielennoxoh right04:16
jamielennoxyea, i think it's important to have auth as the first param04:17
jamielennoxdamn04:17
ayoungthink its a problem?  Would someone really call it with session as the first param>04:17
ayoungI think you are afine04:17
jamielennoxtheres still a reauth=True in there04:17
*** carl_baldwin has joined #openstack-dev04:17
*** sandywalsh_ has joined #openstack-dev04:17
jamielennoxthat's not used anywhere or useful04:17
ayoungsession.session...reuse an old session?04:18
jamielennoxayoung: requests have a session as well04:19
ayoungSo...would it make sense to add things on to the requests session?04:19
ayoungI'm guessin that would be ugly04:19
*** gokrokve_ has quit IRC04:19
jamielennoxpassing session= is for requests sessions04:19
ayoungyeah, Looked at this code before.  I had all these questions answered back then04:19
ayoungthat should be in the arg docstring though04:20
ayoungactually, you are missing a few args there04:20
ayoungparams04:20
jamielennoxjust that one04:20
jamielennoxas i said reauth shouldn't be there04:21
*** sarob has joined #openstack-dev04:21
ayoungjamielennox, I'm referring to the docstring04:22
jamielennoxyea - i htink it's just session= that is missing04:22
ayoungreauth shouldn't be thjere?04:22
ayoungor it should?04:23
ayoungyou aren';t using it...04:23
ayoungso you mean you are kiling it from the param list?04:23
jamielennoxjust reuploaded04:23
jamielennoxexactly the same but with no reauth= in the param list04:24
jamielennoxthat was a left over from an old review04:24
*** Gordonz has quit IRC04:24
*** hugokuo has joined #openstack-dev04:24
*** jgriffith has quit IRC04:24
*** mriedem has quit IRC04:24
ayoungstill missing session04:24
jamielennoxi'll add the session doc string as another review but i really don't want to put another patch in front of all these - i need to pass the thing04:24
*** jgriffith has joined #openstack-dev04:24
jamielennoxput it in this review?04:24
*** joearnold has joined #openstack-dev04:25
ayoungyou sureyou want auth at the front of the list?04:25
ayoungthese are going to be kwargs anyway, lets not break order, even if its stupid04:25
*** AlexF has joined #openstack-dev04:26
*** kolesovdv has quit IRC04:26
*** kolesovdv1 has joined #openstack-dev04:26
*** jgriffith has quit IRC04:26
jamielennoxyou think?04:26
ayoungyeah04:26
jamielennoxSession(AuthPlugin()) is fairly useful04:26
*** mikeoutland has joined #openstack-dev04:26
jamielennoxit's really the main one fo those i think someone would use04:26
ayoungyour call04:26
ayoungI won't cry04:27
jamielennoxno one will use the session parameter04:27
ayoungSession(auth=AuthPlugin())04:27
*** alpha_ori has joined #openstack-dev04:27
ayoungor even default to04:27
ayoungSession()04:27
ayoungwith auth=AuthPlugin?04:27
ayoungas the default param?04:28
jamielennoxno doesn't work that way04:28
ayoungAnyway, bed.  I'll look again in the morn04:28
jamielennoxit'd be Session(keystoneclient.auth.identity.V2())04:28
*** ayoung is now known as ayoung-zZzZzZ04:28
*** jgriffith has joined #openstack-dev04:29
*** amandap has joined #openstack-dev04:30
*** anderstj has joined #openstack-dev04:30
*** koolhead17 has joined #openstack-dev04:31
*** CaptTofu has quit IRC04:32
*** gokrokve has joined #openstack-dev04:32
*** AlexF has quit IRC04:37
*** achampion has quit IRC04:38
*** mikeoutland has quit IRC04:38
*** angdraug has quit IRC04:39
*** sweston has joined #openstack-dev04:39
*** asalkeld has quit IRC04:41
*** nati_ueno has quit IRC04:44
*** topol has joined #openstack-dev04:44
*** stevemar has quit IRC04:49
*** emagana has joined #openstack-dev04:49
*** MaxV has joined #openstack-dev04:51
*** kolesovdv1 has quit IRC04:53
*** kolesovdv has joined #openstack-dev04:53
*** sgordon has quit IRC04:54
*** sumanthns has joined #openstack-dev04:54
*** emagana has quit IRC04:55
*** MaxV has quit IRC04:56
*** rraja has joined #openstack-dev04:56
*** cagrev has joined #openstack-dev04:56
*** thuc has joined #openstack-dev04:58
*** amcrn has joined #openstack-dev05:02
*** rdas has joined #openstack-dev05:03
*** sarob has quit IRC05:04
*** DinaBelova_ is now known as DinaBelova05:04
*** sarob has joined #openstack-dev05:04
*** tjones has joined #openstack-dev05:07
*** sarob_ has joined #openstack-dev05:07
*** kolesovdv has quit IRC05:07
*** rraja_ has joined #openstack-dev05:09
*** sarob has quit IRC05:09
*** doug_shelley66 has joined #openstack-dev05:09
*** tjones has quit IRC05:11
*** cagrev has quit IRC05:11
*** dims has quit IRC05:11
*** haomaiwang has quit IRC05:12
*** kgriffs_afk has quit IRC05:12
*** haomaiwang has joined #openstack-dev05:12
*** sarob has joined #openstack-dev05:13
*** dims has joined #openstack-dev05:13
*** kgriffs_afk has joined #openstack-dev05:13
*** kgriffs_afk is now known as kgriffs05:14
*** sarob_ has quit IRC05:16
*** buzztroll has joined #openstack-dev05:18
*** erkules_ is now known as erkules05:18
*** thuc has quit IRC05:19
*** thuc has joined #openstack-dev05:19
*** coolsvap has joined #openstack-dev05:21
*** buzztroll has quit IRC05:22
*** amotoki has joined #openstack-dev05:22
*** nshaikh has joined #openstack-dev05:23
*** thuc has quit IRC05:23
*** gokrokve has quit IRC05:24
*** Ryan_Lane has joined #openstack-dev05:24
*** mkollaro has joined #openstack-dev05:28
*** markmcclain has joined #openstack-dev05:28
*** achampion has joined #openstack-dev05:28
*** irenab has joined #openstack-dev05:30
*** sarob has quit IRC05:32
*** sarob has joined #openstack-dev05:32
*** pradeep1 has joined #openstack-dev05:33
*** gokrokve has joined #openstack-dev05:33
*** pradeep has quit IRC05:35
*** sarob has quit IRC05:37
*** gokrokve has quit IRC05:38
*** markwash has joined #openstack-dev05:40
*** rwsu has quit IRC05:41
*** AMike has joined #openstack-dev05:42
*** AMike has quit IRC05:42
*** AMike has joined #openstack-dev05:42
*** carl_baldwin has quit IRC05:42
*** asalkeld has joined #openstack-dev05:42
*** carlp_ has quit IRC05:45
*** achampion has quit IRC05:46
*** Tross has joined #openstack-dev05:46
*** killer_prince has joined #openstack-dev05:51
*** mohits has joined #openstack-dev05:52
*** rohitk has joined #openstack-dev05:53
*** AlexF has joined #openstack-dev05:54
*** AlexF has quit IRC05:59
*** AlexF has joined #openstack-dev05:59
*** rohitk has quit IRC05:59
*** nosnos_ has joined #openstack-dev06:00
*** neeti has joined #openstack-dev06:00
*** markwash has quit IRC06:02
*** nosnos has quit IRC06:03
*** sarob has joined #openstack-dev06:03
*** jcoufal has joined #openstack-dev06:04
*** AlexF has quit IRC06:04
*** otherwiseguy has quit IRC06:05
*** buzztroll has joined #openstack-dev06:06
*** AlexF has joined #openstack-dev06:08
*** hdd has quit IRC06:10
*** achampion has joined #openstack-dev06:11
*** buzztroll has quit IRC06:11
*** buzztroll has joined #openstack-dev06:11
*** colinmcnamara has joined #openstack-dev06:12
*** yeylon__ has joined #openstack-dev06:13
*** marcoemorais has joined #openstack-dev06:14
*** colinmcnamara has quit IRC06:16
*** marcoemorais1 has joined #openstack-dev06:16
*** bashok has joined #openstack-dev06:19
*** marcoemorais has quit IRC06:20
*** rohitk has joined #openstack-dev06:21
*** buzztroll has quit IRC06:22
*** e0ne has joined #openstack-dev06:23
*** AlexF has quit IRC06:24
*** buzztroll has joined #openstack-dev06:25
*** jcooley_ has joined #openstack-dev06:26
*** zaitcev has quit IRC06:26
*** vartom1111111114 has joined #openstack-dev06:26
*** e0ne has quit IRC06:27
*** buzztroll has quit IRC06:27
*** buzztroll has joined #openstack-dev06:27
*** otherwiseguy has joined #openstack-dev06:28
*** xazel has joined #openstack-dev06:29
*** tdruiva_ has joined #openstack-dev06:30
*** neelashah1 has joined #openstack-dev06:30
*** topol_ has joined #openstack-dev06:30
*** Mandell_ has joined #openstack-dev06:30
*** Ryan_Lane1 has joined #openstack-dev06:30
*** buzztrol_ has joined #openstack-dev06:30
*** colinmcnamara has joined #openstack-dev06:31
*** vartom1111111114 has quit IRC06:31
*** sarob has quit IRC06:31
*** hashfail has joined #openstack-dev06:31
*** Tross1 has joined #openstack-dev06:31
*** apmelton1 has joined #openstack-dev06:32
*** rohitk has quit IRC06:32
*** mohits_ has joined #openstack-dev06:32
*** coolsvap_away has joined #openstack-dev06:32
*** matsuhashi has quit IRC06:33
*** rraja has quit IRC06:33
*** gokrokve has joined #openstack-dev06:33
*** matsuhashi has joined #openstack-dev06:33
*** branen_ has joined #openstack-dev06:33
*** vuntz has joined #openstack-dev06:33
*** SpamapS_ has joined #openstack-dev06:33
*** grapsus has joined #openstack-dev06:33
*** Steap___ has joined #openstack-dev06:34
*** soren has joined #openstack-dev06:34
*** soren has quit IRC06:34
*** soren has joined #openstack-dev06:34
*** sweston_ has joined #openstack-dev06:34
*** yeylon__ has quit IRC06:34
*** shadower_ has joined #openstack-dev06:34
*** flaper87l has joined #openstack-dev06:35
*** alex_klimov has joined #openstack-dev06:35
*** colinmcnamara has quit IRC06:35
*** flaper87l is now known as flaper8706:35
*** jd__` has joined #openstack-dev06:37
*** gmurphy_ has joined #openstack-dev06:37
*** s0nea_ has joined #openstack-dev06:37
*** jayg|g0n` has joined #openstack-dev06:38
*** gokrokve has quit IRC06:38
*** buzztroll has quit IRC06:38
*** mohits has quit IRC06:38
*** Tross has quit IRC06:38
*** asalkeld has quit IRC06:38
*** Ryan_Lane has quit IRC06:38
*** nshaikh has quit IRC06:38
*** coolsvap has quit IRC06:38
*** dims has quit IRC06:38
*** rraja_ has quit IRC06:38
*** topol has quit IRC06:38
*** sweston has quit IRC06:38
*** alpha_ori has quit IRC06:38
*** joearnold has quit IRC06:38
*** Mandell has quit IRC06:38
*** neelashah has quit IRC06:38
*** paragan has quit IRC06:38
*** fandi has quit IRC06:38
*** tdruiva has quit IRC06:38
*** tserong has quit IRC06:38
*** gmurphy has quit IRC06:38
*** zaneb has quit IRC06:38
*** jhesketh__ has quit IRC06:38
*** gimps has quit IRC06:38
*** primeministerp has quit IRC06:38
*** marios has quit IRC06:38
*** s0nea has quit IRC06:38
*** SpamapS has quit IRC06:38
*** soren_ has quit IRC06:38
*** grapsus__ has quit IRC06:38
*** d0ugal has quit IRC06:38
*** n0ano has quit IRC06:38
*** branen has quit IRC06:38
*** zul has quit IRC06:38
*** apmelton has quit IRC06:38
*** avishay has quit IRC06:38
*** benonsoftware has quit IRC06:38
*** med_ has quit IRC06:38
*** flaper87|afk has quit IRC06:38
*** jd__ has quit IRC06:38
*** jayg|g0n3 has quit IRC06:38
*** enykeev has quit IRC06:38
*** shadower has quit IRC06:38
*** krtaylor has quit IRC06:38
*** Steap has quit IRC06:38
*** vuntz_ has quit IRC06:38
*** mordred has quit IRC06:38
*** fc__ has quit IRC06:38
*** matrohon has quit IRC06:38
*** jd__` is now known as jd__06:38
*** s0nea_ is now known as s0nea06:39
*** alpha_ori has joined #openstack-dev06:39
*** sweston_ is now known as sweston06:40
*** primeministerp has joined #openstack-dev06:40
*** sweston is now known as sweston_06:40
*** joearnold has joined #openstack-dev06:41
*** Tross1 has quit IRC06:42
*** mrda is now known as mrda_away06:43
*** Tross has joined #openstack-dev06:43
*** benonsoftware has joined #openstack-dev06:43
*** benonsoftware has quit IRC06:44
*** benonsoftware has joined #openstack-dev06:44
*** topol_ has quit IRC06:44
*** harlowja is now known as harlowja_away06:44
*** fandi has joined #openstack-dev06:44
*** asalkeld has joined #openstack-dev06:45
*** n0ano has joined #openstack-dev06:45
*** d0ugal has joined #openstack-dev06:45
*** d0ugal has joined #openstack-dev06:45
*** tserong has joined #openstack-dev06:45
*** denis_makogon_ has joined #openstack-dev06:45
*** zaneb has joined #openstack-dev06:45
*** paragan has joined #openstack-dev06:45
*** paragan has quit IRC06:45
*** paragan has joined #openstack-dev06:45
*** zul has joined #openstack-dev06:46
*** avishay has joined #openstack-dev06:46
*** rraja_ has joined #openstack-dev06:46
*** nshaikh has joined #openstack-dev06:47
*** rraja has joined #openstack-dev06:48
*** skraynev_ is now known as skraynev06:50
*** bhuvan has joined #openstack-dev06:51
*** mordred has joined #openstack-dev06:54
*** jhesketh_ has joined #openstack-dev06:55
*** mikeoutland has joined #openstack-dev06:58
*** krtaylor has joined #openstack-dev06:59
*** mikeoutland has quit IRC06:59
*** marios has joined #openstack-dev07:00
*** haomaiwa_ has joined #openstack-dev07:02
*** bhuvan has quit IRC07:02
*** haomaiwang has quit IRC07:04
*** coolsvap_away has quit IRC07:04
*** bhuvan has joined #openstack-dev07:04
*** dims has joined #openstack-dev07:08
*** zoresvit has joined #openstack-dev07:08
*** odyssey4me has joined #openstack-dev07:08
*** achampion has quit IRC07:08
*** markmcclain has quit IRC07:10
*** pradeep1 has quit IRC07:10
*** jcooley_ has quit IRC07:12
*** saju_m has joined #openstack-dev07:12
*** vartom1111111114 has joined #openstack-dev07:14
*** pradeep has joined #openstack-dev07:15
*** bhuvan has quit IRC07:15
*** asalkeld has quit IRC07:16
*** Drankis has joined #openstack-dev07:16
*** lcheng_ has joined #openstack-dev07:16
*** buzztrol_ has quit IRC07:21
*** flaper87 has quit IRC07:21
*** flaper87 has joined #openstack-dev07:21
*** yamahata has quit IRC07:23
*** coolsvap has joined #openstack-dev07:26
*** dstufft is now known as dstufft-gone07:26
*** yolanda has joined #openstack-dev07:28
*** bcrochet has joined #openstack-dev07:29
*** zoresvit has quit IRC07:30
*** nkinder has joined #openstack-dev07:31
*** zoresvit has joined #openstack-dev07:31
*** mrunge has joined #openstack-dev07:31
*** otherwiseguy has quit IRC07:32
*** zoresvit has quit IRC07:32
*** AlexF has joined #openstack-dev07:32
*** achampion has joined #openstack-dev07:32
*** zoresvit has joined #openstack-dev07:32
*** asalkeld has joined #openstack-dev07:33
*** gokrokve has joined #openstack-dev07:33
*** zoresvit has quit IRC07:33
*** zoresvit has joined #openstack-dev07:33
*** obondarev has joined #openstack-dev07:34
*** fc__ has joined #openstack-dev07:34
*** rmk has joined #openstack-dev07:34
*** aditirav has joined #openstack-dev07:37
*** gokrokve has quit IRC07:38
*** MaxV has joined #openstack-dev07:41
*** AlexF has quit IRC07:41
*** rwsu has joined #openstack-dev07:42
*** sarob has joined #openstack-dev07:43
*** lcheng_ has quit IRC07:47
*** amcrn has quit IRC07:47
*** sarob has quit IRC07:48
*** jcooley_ has joined #openstack-dev07:48
*** MaxV has quit IRC07:50
*** rwsu has quit IRC07:51
*** buzztroll has joined #openstack-dev07:52
*** tkammer has joined #openstack-dev07:52
*** rwsu has joined #openstack-dev07:53
*** omachace has joined #openstack-dev07:54
*** jcooley_ has quit IRC07:56
*** pschaef has joined #openstack-dev07:57
*** vartom1111111115 has joined #openstack-dev07:57
*** vartom1111111114 has quit IRC07:58
*** e0ne has joined #openstack-dev07:59
*** afazekas has joined #openstack-dev08:01
*** bauzas has joined #openstack-dev08:04
*** oro has joined #openstack-dev08:04
*** bvandenh has joined #openstack-dev08:04
*** buzztroll has quit IRC08:07
*** afazekas has quit IRC08:07
*** jprovazn has joined #openstack-dev08:07
*** killer_prince is now known as lazy_prince08:08
*** denis_makogon_ has quit IRC08:09
*** xga has joined #openstack-dev08:11
*** rraja has quit IRC08:11
*** jistr has joined #openstack-dev08:11
*** pasquier-s has joined #openstack-dev08:12
*** rraja_ has quit IRC08:12
*** wfoster has joined #openstack-dev08:12
*** viktors_away is now known as viktors08:12
*** sundjango has joined #openstack-dev08:12
*** sundjango_ has joined #openstack-dev08:13
*** sarob has joined #openstack-dev08:13
*** sundjango_ has quit IRC08:13
*** guardianx has joined #openstack-dev08:14
*** buzztroll has joined #openstack-dev08:17
*** sarob has quit IRC08:18
*** buzztroll has quit IRC08:19
sundjangohey, I am an OpenStack newbie and trying to set it up on an Ubuntu Server. I was configuring the networking interface card but if I do it like here http://docs.openstack.org/trunk/install-guide/install/apt/content/basics-networking.html, then I lose my Internet connection. What is the idea behind this configuration? So, that I can apply without changing my08:20
sundjangoprimary interface card?08:20
*** asalkeld has quit IRC08:20
*** jtomasek has joined #openstack-dev08:22
*** colinmcnamara has joined #openstack-dev08:23
*** afazekas has joined #openstack-dev08:23
*** mindpixel has joined #openstack-dev08:23
*** nmagnezi has joined #openstack-dev08:24
*** thouveng has joined #openstack-dev08:26
*** cnesa has quit IRC08:26
*** colinmcnamara has quit IRC08:27
*** yeylon__ has joined #openstack-dev08:28
*** comay has quit IRC08:29
*** marcoemorais1 has quit IRC08:29
*** rohitk has joined #openstack-dev08:32
*** gokrokve has joined #openstack-dev08:33
*** coolsvap has quit IRC08:36
*** florentflament_ has joined #openstack-dev08:37
*** avishayb has joined #openstack-dev08:37
*** gokrokve has quit IRC08:37
*** sushils has joined #openstack-dev08:40
*** ifarkas has joined #openstack-dev08:41
*** amuller has joined #openstack-dev08:42
*** I159 has joined #openstack-dev08:42
*** ogelbukh1 is now known as ogelbukh08:42
*** yamahata has joined #openstack-dev08:43
*** JordanP has joined #openstack-dev08:44
*** romcheg has joined #openstack-dev08:45
*** jgallard has joined #openstack-dev08:46
*** cschwede has joined #openstack-dev08:49
*** sahid has joined #openstack-dev08:50
*** colinmcnamara has joined #openstack-dev08:50
*** MaxV has joined #openstack-dev08:52
*** pradeep1 has joined #openstack-dev08:52
*** belmoreira has joined #openstack-dev08:53
*** pradeep has quit IRC08:54
*** colinmcnamara has quit IRC08:55
*** ilyashakhat has joined #openstack-dev08:55
*** ygbo has joined #openstack-dev08:56
*** jpich has joined #openstack-dev08:56
*** corXi has joined #openstack-dev08:56
*** lsmola has joined #openstack-dev08:57
*** xqueralt has joined #openstack-dev08:57
*** gcha has joined #openstack-dev08:57
*** athomas has joined #openstack-dev09:00
*** safchain has joined #openstack-dev09:01
*** ndipanov has joined #openstack-dev09:02
*** jhesketh_ has quit IRC09:02
*** jhesketh has quit IRC09:02
*** bhuvan has joined #openstack-dev09:03
*** pixelb has joined #openstack-dev09:03
*** xga has quit IRC09:07
*** colinmcnamara has joined #openstack-dev09:08
*** colinmcnamara has quit IRC09:12
*** markmc has joined #openstack-dev09:13
*** sarob has joined #openstack-dev09:13
*** safchain has quit IRC09:14
*** tdruiva_ has quit IRC09:14
*** jhesketh has joined #openstack-dev09:14
*** jhesketh_ has joined #openstack-dev09:15
*** dtantsur has joined #openstack-dev09:16
*** aditirav has quit IRC09:17
*** rraja_ has joined #openstack-dev09:17
*** aditirav has joined #openstack-dev09:17
*** rraja has joined #openstack-dev09:18
*** sarob has quit IRC09:18
*** dtantsur has left #openstack-dev09:19
*** xga has joined #openstack-dev09:20
*** coolsvap has joined #openstack-dev09:23
*** johnthetubaguy has joined #openstack-dev09:24
*** mmagr has joined #openstack-dev09:24
*** marcoemorais has joined #openstack-dev09:26
*** jamespage has joined #openstack-dev09:27
*** pradeep has joined #openstack-dev09:28
*** pradeep1 has quit IRC09:29
*** eglynn has joined #openstack-dev09:29
*** nshaikh has left #openstack-dev09:29
*** nshaikh has quit IRC09:29
*** buzztroll has joined #openstack-dev09:30
*** MaxV has quit IRC09:30
*** johnthetubaguy has quit IRC09:31
*** MaxV has joined #openstack-dev09:31
*** johnthetubaguy has joined #openstack-dev09:32
*** gokrokve has joined #openstack-dev09:33
*** avishayb has quit IRC09:33
*** rdas has quit IRC09:34
*** buzztroll has quit IRC09:34
*** lucasagomes has joined #openstack-dev09:34
*** colinmcnamara has joined #openstack-dev09:35
*** marcoemorais has quit IRC09:35
*** danpb has joined #openstack-dev09:35
*** Ryan_Lane1 has quit IRC09:36
*** gokrokve has quit IRC09:38
*** kashyap is now known as kashyap_bbiab09:38
*** colinmcnamara has quit IRC09:39
*** safchain has joined #openstack-dev09:41
*** dtantsur has joined #openstack-dev09:43
*** giulivo has joined #openstack-dev09:44
*** e0ne has quit IRC09:46
*** e0ne has joined #openstack-dev09:46
*** tdruiva has joined #openstack-dev09:46
*** zoresvit has quit IRC09:47
viktorsflaper87: hi09:49
flaper87viktors: hey09:49
*** reed has joined #openstack-dev09:50
*** e0ne_ has joined #openstack-dev09:50
*** e0ne has quit IRC09:50
viktorsflaper87: when you'll have a few minutes, could you please look at patch https://review.openstack.org/#/c/57689/ (Drop dependency on log from oslo db code).09:50
viktorsflaper87: You -1'ed it some time ago )09:50
*** matrohon has joined #openstack-dev09:51
*** romcheg has left #openstack-dev09:52
*** ala has quit IRC09:52
*** corXi has quit IRC09:52
*** BobBallAway is now known as BobBall09:52
flaper87viktors: LGTM! Thanks!09:52
viktorsflaper87: Thank  you!09:53
*** corXi has joined #openstack-dev09:54
*** sweston_ has quit IRC09:54
*** tdruiva has quit IRC09:54
*** JordanP has quit IRC09:55
*** Alexei_987 has joined #openstack-dev09:56
*** zoresvit has joined #openstack-dev10:00
*** oro has quit IRC10:01
*** e0ne_ has quit IRC10:02
*** e0ne has joined #openstack-dev10:02
*** kashyap_bbiab is now known as kashyap10:02
*** colinmcnamara has joined #openstack-dev10:02
*** sergmelikyan has joined #openstack-dev10:04
*** colinmcnamara has quit IRC10:06
*** e0ne has quit IRC10:06
*** e0ne has joined #openstack-dev10:07
*** xga has quit IRC10:08
*** jamespage_ has joined #openstack-dev10:09
*** e0ne has quit IRC10:10
*** e0ne has joined #openstack-dev10:10
*** sarob has joined #openstack-dev10:13
*** oro has joined #openstack-dev10:14
*** martyntaylor has joined #openstack-dev10:14
*** jcooley_ has joined #openstack-dev10:17
*** zzelle has joined #openstack-dev10:17
*** sarob has quit IRC10:18
*** xga has joined #openstack-dev10:19
*** gszasz has joined #openstack-dev10:20
*** Adri2000_ is now known as Adri200010:21
*** metabro has quit IRC10:22
*** xga_ has joined #openstack-dev10:23
*** jcooley_ has quit IRC10:23
*** xga has quit IRC10:24
*** sergmelikyan has quit IRC10:24
*** bada has joined #openstack-dev10:26
*** jistr has quit IRC10:27
*** rohitk has quit IRC10:28
*** d0ugal has quit IRC10:29
*** colinmcnamara has joined #openstack-dev10:29
*** paragan has quit IRC10:30
*** coolsvap has quit IRC10:30
*** marcoemorais has joined #openstack-dev10:31
*** d0ugal has joined #openstack-dev10:32
*** d0ugal has quit IRC10:32
*** d0ugal has joined #openstack-dev10:32
*** oro has quit IRC10:32
*** gokrokve has joined #openstack-dev10:33
*** colinmcnamara has quit IRC10:34
*** marcoemorais has quit IRC10:36
*** xgsa has joined #openstack-dev10:36
*** jamespage_ has quit IRC10:37
*** gokrokve has quit IRC10:37
*** nimi has joined #openstack-dev10:39
*** mkollaro has quit IRC10:42
*** zoresvit has quit IRC10:43
*** boris-42_ has quit IRC10:43
*** zoresvit has joined #openstack-dev10:43
*** lazy_prince has quit IRC10:46
*** jistr has joined #openstack-dev10:50
*** e0ne has quit IRC10:50
*** e0ne has joined #openstack-dev10:50
*** vartom1111111115 has quit IRC10:50
*** nimi has quit IRC10:53
*** colinmcnamara has joined #openstack-dev10:56
jamielennoxlifeless: dont suppose youre still here?10:58
*** mmagr has quit IRC10:58
*** russellb has joined #openstack-dev11:00
*** colinmcnamara has quit IRC11:01
*** DinaBelova is now known as DinaBelova_11:01
*** CaptTofu has joined #openstack-dev11:02
*** DinaBelova_ is now known as DinaBelova11:02
*** asalkeld has joined #openstack-dev11:02
*** rohitk has joined #openstack-dev11:04
*** CaptTofu has quit IRC11:07
*** zoresvit has quit IRC11:08
*** zoresvit1 has joined #openstack-dev11:08
*** DinaBelova is now known as DinaBelova_11:10
*** e0ne has quit IRC11:10
*** MaxV has quit IRC11:10
*** jcooley_ has joined #openstack-dev11:13
*** pradeep has quit IRC11:13
*** smcavoy has left #openstack-dev11:13
*** sarob has joined #openstack-dev11:13
*** pradeep has joined #openstack-dev11:13
*** sushils has quit IRC11:14
marekd|awayjamielennox: hi.11:14
*** marekd|away is now known as marekd11:14
jamielennoxmarekd: hey11:15
marekdjamielennox: what happens when a keystoneclient receives an unscoped token as a auth response?11:15
marekdjamielennox: will it automatically query for a scoped token, by sending a project_id it's going to use?11:16
jamielennoxmarekd: essentially it's going to fail11:16
*** sarob_ has joined #openstack-dev11:16
marekdjamielennox: oh dear...11:16
marekdjamielennox: so, what's the purpose for unscoped tokens :-)11:16
jamielennoxi think it'll try to get a management_url from the service catalog, fail and crash11:16
jamielennoxin theory they work11:17
marekdin theory...11:17
jamielennoxthe problem is we don't have a good way to rescope it11:17
*** mmagr has joined #openstack-dev11:17
marekdjamielennox: here is the problem. i am starting with a list of keystone groups a federated user can access. I can than get a list of roles tied to those groups.11:17
jamielennoxwhat you might be able to do is take the unscoped token and use auth_url=, token=, and project_id= to create a new client11:17
*** sarob has quit IRC11:18
jamielennoxlist of groups?11:18
marekdjamielennox: but...i still know NOTHING about a project id that use will want to use.11:18
marekdjamielennox: yes, the mapping engine returns a list of local keystone groups...11:18
jamielennoxa group is a collection of users - why is that available/11:18
jamielennoxyou're not really ever supposed to be able to resolve that i don't think11:19
*** jcooley_ has quit IRC11:19
marekdresolve what?11:19
marekdit's easier to make rules for groups rather every single federated user.11:20
jamielennoxhmm, so you are supposed to be able to list the projects a user is in right/11:20
*** sarob_ has quit IRC11:20
marekdwell, by looking in the code i see most of the logic depends on the user/project...i must depend on roles...11:21
*** rraja has quit IRC11:21
marekdthere will be no local user, no entity in the DB>11:21
*** vartom1111111115 has joined #openstack-dev11:22
*** rraja_ has quit IRC11:22
marekdit should be 'something', a set of roles that actually define what and how can be accessed.11:22
jamielennoxi can't remember if it's possible to list the associated projects for a user - i guess it mustbe11:22
*** akrivoka has joined #openstack-dev11:22
marekdeventually it's roles that grant/deny access to the projects, right?11:22
jamielennoxa role is only defined on either a project or a domain11:22
jamielennoxthere is no such thing as an unsoped token with roles11:23
*** gszasz is now known as gszasz_lunch11:23
*** MaxV has joined #openstack-dev11:23
jamielennox(i don't know much about what federation is returning here)11:23
marekdok, a role is only defined on a project/domain - so by having set of roles i am able to decide whether the project can be accessed.11:24
*** nshaikh has joined #openstack-dev11:24
*** ppetit has joined #openstack-dev11:24
*** xga_ has quit IRC11:24
marekdargs, super easy in theory, slightly more difficult in reality.11:25
*** sergmelikyan has joined #openstack-dev11:25
jamielennoxwhat are you working with? how do you know what roles you have if the token is unscoped?11:26
*** jcoufal has quit IRC11:26
marekdi am starting with a list of keystone group ids. This will be provided by mapping rule engine.11:27
marekdit parses saml assertion and returns list of matching group ids.11:27
marekdI can assume a federated user is a member of those groups. By having that I can list all the roles that are attached to those groups.11:27
marekdso i now have a list of roles my user has.11:27
marekdthe problem is: this is faked user, so no real entry in the DB 2) I cannot check what project he's going use, not after the first call..11:28
jamielennoxwhat API version are you using - again roles shouldn't exist without being scoped somewhere11:28
marekdgonna be v311:28
jamielennoxyea, has to be11:28
marekdthere are tables:11:29
*** jgallard has quit IRC11:29
*** david-lyle has quit IRC11:29
marekdhttps://github.com/openstack/keystone/blob/master/keystone/assignment/backends/sql.py#L75211:30
*** nosnos_ has quit IRC11:30
marekdi think you are asking about that...11:30
marekdhttps://github.com/openstack/keystone/blob/master/keystone/assignment/backends/sql.py#L70311:30
marekdgrom GroupDomainGrant and GroupProjectGrant I am able to get roles assigned to the groups.11:31
marekds/grom/from/11:31
*** marcoemorais has joined #openstack-dev11:31
jamielennoxright11:32
*** CaptTofu has joined #openstack-dev11:32
*** denis_makogon has joined #openstack-dev11:33
*** gokrokve has joined #openstack-dev11:33
jamielennoxbut you're trying to access that via the API - you should be starting from the project or domain11:33
*** rohitk has quit IRC11:33
*** rohitk has joined #openstack-dev11:34
marekdit will not be POST auth/token with {auth: {}} request body...11:35
marekdit will be more like GET /token/OS-FEDERATION/{idp}/protocol/{proto}11:35
marekdand I have nothing in the req body.11:36
*** marcoemorais has quit IRC11:36
jamielennoxmarekd: hmm, this is really not my area - i haven't had all that much to do with federation11:37
marekdjamielennox: ok, no problem.11:37
marekdjamielennox: thanks, anyway.11:37
jamielennoxfrom my thinking you should never have been able to find a group and roles without knowing the project11:37
jamielennoxi *guess* that as a group only exists on a domain then the roles you are seeing are on the domain11:37
*** gokrokve has quit IRC11:38
marekdyes11:38
*** amotoki has quit IRC11:38
jamielennoxbut again this would tell me that the token is already scoped to the domain so i still don't know why you'd be seeing roles and have an unscoped token11:38
*** amotoki has joined #openstack-dev11:38
*** gcha has quit IRC11:39
jamielennoxanyway - i'd suggest trying out stevemar in the US morning11:40
jamielennoxor dolph or adam i guess11:40
jamielennoxsorry about that11:40
marekdcan a normal token be scoped to multiple projects/domains?11:40
marekdjamielennox: no problem.11:40
jamielennoxmarekd: no11:40
jamielennoxvery strictly one or the other11:40
marekdyou got me wrong....11:41
marekdcan a token be scoped to multiple projects?11:41
jamielennoxmarekd: no11:41
marekd(i am not mixing project w/ domains)11:41
marekdjamielennox: ok11:41
*** jamespage_ has joined #openstack-dev11:43
*** Nikolay_1t has quit IRC11:44
marekdjamielennox: is the horizon not working in a "unscoped/later scoped" token way?11:45
jamielennoxmarekd: it should be11:45
jamielennoxget an unscoped token - list projects that user has access to11:46
jamielennoxthat's how it offers you a list of projects11:46
jamielennoxthere is also a defalut_project_id that can be used11:46
marekdwell, so maybe that's the solution!11:46
*** pcm has joined #openstack-dev11:46
jamielennoxthat's what i was going for earlier11:46
jamielennoxbut you seem to have the roles already - and you still need to have a user not a group11:47
jamielennoxhmm, maybe you can get group projects - i'm not sure on that11:47
marekdok i will investigate that.11:47
*** pcm has quit IRC11:48
*** csaba|afk has joined #openstack-dev11:48
*** rfolco has joined #openstack-dev11:48
*** pcm has joined #openstack-dev11:48
jamielennoxdo you have the return dump from GET /token/OS-FEDERATION/{idp}/protocol/{proto} ?11:49
marekddump?11:49
jamielennoxlike the json from the token11:49
marekdsomething like that.11:50
*** asalkeld has quit IRC11:50
jamielennoxcan you paste it somewhere for me11:50
marekdthe code or what?11:50
jamielennoxthe json11:50
marekdi didn't create any yet, but I assume this would be like a normal json sent upon auth request..11:51
marekdthe effect the client should get is a token that can be later used in a classy way...11:51
jamielennoxok - well there are certain calls that can be made to the auth_url so that you don't have to use the service catalog11:51
jamielennoxyou can find them because they set management=False in the request call11:52
*** colinmcnamara has joined #openstack-dev11:52
jamielennoxthat token should get you an unscoped token11:52
jamielennoxthen you can list projects and then get a token per project11:52
jamielennoxthat's the only way i can see this would work11:52
marekdi think so too.11:53
jamielennoxmarekd: anyway it's later here - i'm heading out11:53
marekdok, thanks a lot.11:53
marekdcheers.11:53
jamielennoxnp11:53
*** paragan has joined #openstack-dev11:54
*** paragan has quit IRC11:54
*** paragan has joined #openstack-dev11:54
*** colinmcnamara has quit IRC11:56
*** asalkeld has joined #openstack-dev11:57
*** L33 has joined #openstack-dev12:00
*** DuncanT- is now known as DuncanT12:02
*** yamahata has quit IRC12:04
*** sgordon has joined #openstack-dev12:06
*** yamahata has joined #openstack-dev12:09
*** drewlander has joined #openstack-dev12:09
*** vkmc has joined #openstack-dev12:10
*** rkukura has quit IRC12:10
*** sarob has joined #openstack-dev12:13
*** sergmelikyan has quit IRC12:14
*** sergmelikyan has joined #openstack-dev12:14
*** sandywalsh_ has quit IRC12:15
*** neelashah1 has quit IRC12:16
*** e0ne has joined #openstack-dev12:17
*** sarob has quit IRC12:18
*** yassine has joined #openstack-dev12:20
*** FunnyLookinHat has joined #openstack-dev12:21
*** bada_ has joined #openstack-dev12:21
*** CaptTofu has quit IRC12:22
*** eglynn is now known as eglynn-lunch12:23
*** e0ne_ has joined #openstack-dev12:24
*** e0ne has quit IRC12:24
*** bada has quit IRC12:25
*** xga has joined #openstack-dev12:26
*** bhuvan has quit IRC12:28
*** sandywalsh_ has joined #openstack-dev12:28
*** e0ne has joined #openstack-dev12:29
*** zoresvit1 has quit IRC12:29
marekddolphm: ping.12:30
*** e0ne__ has joined #openstack-dev12:30
*** aditirav has quit IRC12:30
*** e0ne___ has joined #openstack-dev12:31
*** e0ne__ has quit IRC12:31
*** asalkeld has quit IRC12:31
*** boris-42_ has joined #openstack-dev12:32
*** e0ne_ has quit IRC12:32
*** e0ne___ has quit IRC12:32
*** IanGovett has joined #openstack-dev12:32
*** e0ne_ has joined #openstack-dev12:32
*** gszasz_lunch is now known as gszasz12:33
*** gokrokve has joined #openstack-dev12:33
*** e0ne has quit IRC12:34
*** rohitk has quit IRC12:34
*** rohitk has joined #openstack-dev12:34
*** vartom1111111115 has quit IRC12:35
*** matsuhashi has quit IRC12:36
*** matsuhashi has joined #openstack-dev12:36
*** yamahata has quit IRC12:37
*** gokrokve has quit IRC12:37
*** DinaBelova_ is now known as DinaBelova12:38
*** mohits_ has quit IRC12:41
*** matsuhashi has quit IRC12:41
*** sgordon has quit IRC12:42
*** bhuvan has joined #openstack-dev12:46
*** pschaef has quit IRC12:47
*** sushils has joined #openstack-dev12:50
*** gszasz has quit IRC12:50
*** yamahata has joined #openstack-dev12:51
*** byeager has joined #openstack-dev12:51
*** DinaBelova is now known as DinaBelova_12:52
*** gszasz has joined #openstack-dev12:53
*** artom has joined #openstack-dev12:53
*** DinaBelova_ is now known as DinaBelova12:55
*** DinaBelova is now known as DinaBelova_12:55
*** nmagnezi has quit IRC12:55
*** baoli has joined #openstack-dev12:56
*** tkammer has quit IRC12:57
*** jgallard has joined #openstack-dev12:58
*** markmcclain has joined #openstack-dev12:59
*** gcha has joined #openstack-dev13:00
*** neeti has quit IRC13:00
*** DinaBelova_ is now known as DinaBelova13:01
*** yamahata has quit IRC13:03
*** gcha has quit IRC13:03
*** nmagnezi has joined #openstack-dev13:04
*** rohitk has quit IRC13:04
*** e0ne has joined #openstack-dev13:05
dolphmmarekd: pong13:05
*** danielbruno has joined #openstack-dev13:05
*** vartom1111111115 has joined #openstack-dev13:06
*** russellb_ has joined #openstack-dev13:06
*** gcha has joined #openstack-dev13:06
*** russellb_ has quit IRC13:07
*** yamahata has joined #openstack-dev13:07
*** jhesketh_ has quit IRC13:07
*** jhesketh has quit IRC13:08
*** AlexF has joined #openstack-dev13:08
*** e0ne_ has quit IRC13:08
marekdglad you are here.13:09
marekdi spoke with jammielennox earlier today.13:09
*** sumanthns has quit IRC13:10
marekdcause i got to the point in a federated token generation where we should actually first return a non scoped token, that can be later used to  request a scoped token..?13:10
*** DinaBelova is now known as DinaBelova_13:10
marekdafter the rule mapping i end up with set of groups, i can then get roles tied to the groups (domain and project grants) but...i still don't know WHAT project a user will want to access...13:11
*** tkammer has joined #openstack-dev13:11
*** neeti has joined #openstack-dev13:12
*** e0ne_ has joined #openstack-dev13:13
*** sarob has joined #openstack-dev13:13
*** michchap has quit IRC13:14
marekdby default creating a service_catalog also depend on both user_id and project_id -> whoa, both are missing :-)13:14
*** neeti has quit IRC13:14
*** bhuvan has quit IRC13:14
*** neeti has joined #openstack-dev13:15
*** neeti has quit IRC13:16
*** e0ne has quit IRC13:16
*** sgordon has joined #openstack-dev13:16
*** sarob has quit IRC13:17
*** neeti has joined #openstack-dev13:17
*** alexpilotti has joined #openstack-dev13:18
*** jroll has joined #openstack-dev13:18
*** tdruiva has joined #openstack-dev13:18
*** bhuvan has joined #openstack-dev13:18
*** byeager has quit IRC13:19
dolphmmarekd: good questions...13:19
dolphmmarekd: on user_id being required for the service catalog -- sounds like we need a refactor to remove that dependency13:20
*** jprovazn has quit IRC13:20
*** fandi has quit IRC13:20
*** rohitk has joined #openstack-dev13:20
marekddolphm: i think missing project_id is a bigger problem...13:21
dolphmmarekd: +++13:21
*** aveiga has joined #openstack-dev13:21
*** jcoufal has joined #openstack-dev13:21
marekddolphm: no chance to get a project_id.... and we can always fake user_id...13:21
dolphmmarekd: thinking through it -- you'd have to put groups into the unscoped token, right?13:21
dolphmmarekd: or persist something13:21
*** CaptTofu has joined #openstack-dev13:22
*** rohitk has quit IRC13:22
marekddolphm: i'd leave groups - i can get roles which already define what and how i can access, right? So I would issue an unscoped token, just a PKI/UUID and make a client to request for a certain project. Now, depending on the roles behind that token I would either grant a valid scoped token for a project or reject the access...13:23
marekddolphm: but i still think i need somehow generate a list of projects available to the user so a client can choose one..13:23
dolphmmarekd: in the non-federated case, that's GET /users/{user_id}/projects or GET /users/{user_id}/domains -- do we need equivalent calls for ephemeral users?13:24
dolphmmarekd: ... based on groups?13:24
marekddolphm: quick hint how to list projects accessible from groups? that could actually help.13:25
dolphmmarekd: from managers or what?13:25
marekddolphm: ok, i will grep the basecode.13:25
*** yamahata has quit IRC13:26
marekdbut. what's the non-federated workflow when a user gets an unscoped token?13:27
marekdthere is a token id and what else?13:27
*** metral has joined #openstack-dev13:27
*** rainya has joined #openstack-dev13:27
*** annegentle has joined #openstack-dev13:27
*** 64MAAAAAS has joined #openstack-dev13:27
*** shanturoy has joined #openstack-dev13:27
*** pvo has joined #openstack-dev13:27
*** jbryce has joined #openstack-dev13:27
dolphmmarekd: i don't think there's a driver method to expose that alone13:27
*** dcmorton has joined #openstack-dev13:27
dolphmmarekd: list_projects_for_user() is as close as we get13:27
*** cagrev has joined #openstack-dev13:28
dolphmmarekd: in the non-federated case, a user gets an unscoped token, calls GET /v3/users/{user_id}/projects, selects a project on the client side, and re-scopes with POST /v3/auth/tokens w/ unscoped token + project selection13:28
*** jdob has joined #openstack-dev13:30
marekdand providing he knows the project_id apriori he will send the id in the first auth request and get a scoped token, right?13:30
dolphmmarekd: yes, that's the second flow of three possibilities :)13:31
marekdwhat's the 3rd one?13:31
*** jckasper has quit IRC13:31
dolphmmarekd: the third is that the user has a default_project_id attribute set, and instead of being able to get an unscoped token at all, they automatically get back a scoped token to that project13:31
*** achampion has quit IRC13:31
marekddolphm: i doubt this can be reused in a federation use-case.13:32
marekddolphm: possible the unscoped/scoped looks most promising.13:32
*** yamahata has joined #openstack-dev13:32
*** marcoemorais has joined #openstack-dev13:32
*** rkukura has joined #openstack-dev13:33
*** rkukura is now known as rkukura_13:33
*** gokrokve has joined #openstack-dev13:33
marekdbut we cannot extend the API with something like /v3/groups/{group}/projects ...13:33
*** athomas has quit IRC13:33
marekddolphm: rather /v3/OS-FEDERATION/token/{token_id}/projects13:34
dolphmmarekd: but don't put the token in the URL!13:34
marekddolphm: yes, you are right!13:34
dolphmmarekd: the problem with /v3/groups/{group}/projects is that you'd be forcing the client to iterate over all their groups13:35
marekddolphm: nope, the client doesn't know it's groups at all!13:35
dolphmmarekd: that's why i was suggesting the groups should be added to the token :-/13:35
marekddolphm: he starts with nothing, and the data that's flowing around is at most saml assertion.13:35
dolphmmarekd: but saml assertions can be "reduced" to just a set of groups13:36
marekddolphm: ok, now i see your point. i thought a roles can be used to list accessible projects.13:36
*** marcoemorais has quit IRC13:36
dolphmmarekd: but you don't "have" any roles until you've selected a project/domain to scope to13:36
marekddolphm: yes, but internally, in the keystone, so the client cannot hit /v3/groups/{group_id}/projects ...unless he really gets a list of groups in a response.13:36
dolphmmarekd: right13:37
dolphmmarekd: if groups are in the token, the call could be as simple as GET /v3/OS-FEDERATION/projects and GET /v3/OS-FEDERATION/domains13:38
*** gordc has joined #openstack-dev13:38
*** vladikr has joined #openstack-dev13:38
dolphmmarekd: on the service side, you'd only have to pull the list of groups out of the unscoped X-Auth-Token, and return a set of projects / domains those groups have access to13:38
*** gokrokve has quit IRC13:38
marekddolphm: and later 'scoping' the token follows the stardard way, right?13:40
*** bswartz has quit IRC13:40
*** athomas has joined #openstack-dev13:41
*** saju_m has quit IRC13:41
dolphmmarekd: i believe so13:41
*** tdruiva has quit IRC13:43
*** tdruiva has joined #openstack-dev13:43
*** jprovazn has joined #openstack-dev13:44
*** nacim has quit IRC13:44
*** ekarlso- has quit IRC13:45
marekdso a response could be like this: https://gist.github.com/zaccone/8803808 ?13:45
*** ekarlso has joined #openstack-dev13:45
*** yamahata has quit IRC13:46
dolphmmarekd: https://gist.github.com/dolph/5cfa70c02f5b141060c5#token-as-a-result-of-federation13:46
marekdbecause it has nothing in common with the token structure you showed me yesterday13:46
marekddolphm: allright, i still have no idea how to fill the 'user' dictionary...13:47
dolphmmarekd: i think steve was working on making that part of the mapping engine output13:47
*** tdruiva has quit IRC13:47
marekddolphm: he was, but i believe mapping to the specific user is just one of the use-case.13:48
dolphmmarekd: the mapping engine could literally output an ephemeral user object that could be stuck straight into a token13:48
marekddolphm: and the other one, and very likely more common is just a set of group_ids.13:48
dolphmmarekd: and i'm suggesting that be the same thing (the group id's are part of the user)13:48
dolphman attribute* of the user13:48
*** mburned_out has joined #openstack-dev13:49
*** mburned_out is now known as mburned13:49
*** yamahata has joined #openstack-dev13:50
*** nacim has joined #openstack-dev13:50
*** ifarkas has quit IRC13:51
*** pasquier-s_ has joined #openstack-dev13:51
*** ifarkas has joined #openstack-dev13:52
marekdhttps://review.openstack.org/#/c/67645/10/keystone/contrib/federation/utils.py - i can get this: [{'group': {'id': '0cd5e9'}, 'user': {'email': 'bob@example.com'}}] or this:  [{'group': {'id': '123'}}, {'group': {'id': 'xyz'}}]13:52
marekdin the latter there is no user...:(13:53
marekdthat's what i was asking yesterday.13:53
*** Steap___ is now known as Steap13:53
marekddolphm: ^^^13:54
dolphmmarekd: looking13:54
dolphmmarekd: skimming the code -- but why one or the other?13:54
marekddolphm: for 'simplicity'.13:55
dolphmmarekd: ?13:55
*** yamahata has quit IRC13:55
*** prad_ has joined #openstack-dev13:55
*** doug_shelley66 has quit IRC13:56
marekddolphm: you can make rule: "if the guys department is IT put him in the keystone group IT' you can make a general rule, and don't need to bother making lots of direct mappings.13:56
dolphmmarekd: oh this is only handling one assertion at a time...13:56
*** rossella_s has joined #openstack-dev13:56
*** thomasem has joined #openstack-dev13:56
marekdwell yest, but it doesn't matter - you can make one generic rule and handle many users with that.13:57
dolphmmarekd: the class construction seems backwards to me, fwiw -- it seems like you should __init__(mapping_ref), and then .process(assertion)13:57
dolphmor assertions13:57
marekddolphm: THAT WAS MY COMMENT last friday!13:57
dolphmhaha13:57
*** arges has quit IRC13:57
marekddstanek: liked that but eventually steve didn't decide to change it. its kinda illogical, but doesn't break anything so i gave up.13:58
*** yamahata has joined #openstack-dev13:59
marekdanyway, i can't assume that mapping engine always produces a 'user' entity.14:00
dolphmmarekd: well, it breaks intuitiveness lol14:00
*** jckasper has joined #openstack-dev14:00
dolphmmarekd: i think you *should* be able to safely make that assumption14:00
marekddolphm: go ahead and support me by leaving some comments :-)14:00
dolphmmarekd: i might even propose the refactor!14:00
dstanekdolphm, marekd: the class is a little wierd :)14:01
*** hnarkaytis has joined #openstack-dev14:01
*** glenng has joined #openstack-dev14:01
marekddstanek: hey there.14:02
marekddolphm: https://review.openstack.org/#/c/67645/10/keystone/tests/mapping_fixtures.py -> take a look at MAPPING_SMALL14:02
marekdproduces list of groups.14:02
marekdi mean local entities are groups and this is what i am starting with.14:02
*** dims has quit IRC14:03
marekdthat's my point and i think during the summit sessions we were talking mostly about the list of groups.14:03
*** xga has quit IRC14:03
*** tkammer has quit IRC14:04
marekddstanek: wanna save the world and join the discussion?:-)14:04
*** sgordon has quit IRC14:04
*** dkranz has quit IRC14:05
*** sgordon has joined #openstack-dev14:05
dolphmmarekd: dstanek: commented14:05
*** xga has joined #openstack-dev14:05
*** dprince has joined #openstack-dev14:05
*** lsmola has quit IRC14:05
*** beagles is now known as beagles_brb14:06
*** glenng has quit IRC14:07
*** tongli has joined #openstack-dev14:07
dstanekmarekd: i put away my cape already14:07
dolphmdstanek: i recall having a discussion with morganfainberg_Z about putting groups into tokens to solve some problem ayoung-zZzZzZ was having with revocation events (consequences of deleting a group?) -- were you involved in that discussion?14:07
*** ayoung-zZzZzZ has quit IRC14:08
marekddolphm: hmmmm, and what about generating a uuid-like username if there is no direct mapping?14:08
dolphmi got the impression from morganfainberg_Z that i missed the party on that one14:08
dstanekdolphm: not that i can recall14:08
dolphmmarekd: from what i've gathered from david chadwick, a username should be guaranteed / required14:09
dstanekdolphm: what problem is he having with revocation events?14:09
dolphmdstanek: i think it was just that the cost of generating revocation events from deleting a group -- there's no way for auth_token to handle a revocation event that looks like group_id=123414:09
marekddolphm: i am not 100% sure, but I might be wrong. so for now I will assume the username is presnet after the mapping is done.14:10
dolphmdstanek: because groups aren't in the token... so instead, he was having to generate revocation events for all the assignments to the group14:10
dolphmdstanek: marekd: point is, i think we have two solid use cases for adding group IDs to tokens14:11
dstanekdolphm: do you know which review that is in?14:11
*** JordanP has joined #openstack-dev14:12
dolphmdstanek: i suppose https://review.openstack.org/#/c/55908/ -- but the conversation between ayoung and morganfainberg_Z may have been in irc14:12
*** tdruiva has joined #openstack-dev14:12
*** nmagnezi_ has joined #openstack-dev14:13
*** sarob has joined #openstack-dev14:13
*** mriedem has joined #openstack-dev14:14
*** Jabadia has joined #openstack-dev14:14
*** markmcclain has quit IRC14:15
Jabadiaanyone know how can i extract the 'cpu_allocation_ratio' using API ?14:15
Jabadia ( and not by reading nova.conf.. )14:15
*** sweston has joined #openstack-dev14:16
*** nmagnezi has quit IRC14:16
*** tkammer has joined #openstack-dev14:17
*** mindpixel has quit IRC14:17
*** sarob has quit IRC14:18
*** yamahata has quit IRC14:18
*** mkollaro has joined #openstack-dev14:18
*** rektide_ is now known as rektide14:19
*** yamahata has joined #openstack-dev14:19
*** thuc has joined #openstack-dev14:20
*** jayg|g0n` is now known as jayg14:22
*** achampion has joined #openstack-dev14:22
*** lsmola has joined #openstack-dev14:22
*** changbl has quit IRC14:23
*** lbragstad has quit IRC14:23
*** prad_ has quit IRC14:24
*** nmagnezi_ is now known as nmagnezi14:24
*** btorch has joined #openstack-dev14:25
*** lbragstad has joined #openstack-dev14:25
*** browne has joined #openstack-dev14:26
marekddolphm: one more thing. let's assume we have a list of mapped groups. We generate a token, store it in the database and return it. This is an unscoped token. So now, the client wants to get a list of projects / domains he can access and according to your suggestion does GET /v3/OS-FEDERATION/projects and/or GET /v3/OS-FEDERATION/domains . The Keystone reads X-Auth-Token and returns appropriate list. If so, is it really required to return a list of group14:27
dolphmmarekd: do you have an alternative suggestion to compute the list of available projects?14:28
*** andreaf has joined #openstack-dev14:29
dolphmmarekd: the list of groups has to either be persisted or recomputed from assertions (so the assertions would have to be persisted somewhere)14:29
*** lbragstad has quit IRC14:31
dolphmmarekd: persisting groups in the token buys you the data you need, with the advantage that it's possible won't have to store them to a db at all (with ephemeral PKI tokens + revocation events)14:31
*** ala has joined #openstack-dev14:32
marekddolphm: i am not following....so you don't want to store the group_ids in a token backend at all and always recompute them when the user does GET /v3/OS-FEDERATION/projects ?14:32
dolphmmarekd: sort of...14:33
dolphmmarekd: store them in the token14:33
*** gokrokve has joined #openstack-dev14:33
dolphmmarekd: for the moment, we're writing those tokens to the database14:33
marekddolphm: because from what you proposed the list of groups is returned, but client doesn't use it AT ALL. he asks for matching projects basing on the token_id he received.14:33
*** dvarga has joined #openstack-dev14:33
dolphmmarekd: but with ayoung's revocation events work, we won't have a reason to write PKI tokens to the db anymore14:33
dolphmmarekd: right, the client has zero reason to care about their own groups14:34
*** spzala has joined #openstack-dev14:34
marekddolphm: ++ so my question is what's the reason for returning that group list in a unscoped token reponse - is it related to revocations/whatever? If so I will just do whatever you tell me. Otherwise I'd like to understand :-)14:35
*** amotoki has quit IRC14:35
dolphmmarekd: a couple reasons in my mind... but i completely share your hesitation!14:35
marekddolphm: ok, if that's related to some future ideas and not only the federated token generation i am cool with that.14:36
dolphmmarekd: A) ayoung wants to be able to issue revocation events when a group is deleted, and just emit the group id, rather than events for every role assignment on that group - it's just a performance improvement14:36
*** vijendar has joined #openstack-dev14:36
dolphmmarekd: B) the output of mapping is effectively groups, so it's useful to persist that output somehow14:37
*** gordc has quit IRC14:37
marekddolphm: i still elieve we must put it in the db. We cannot trust any client...14:37
marekddolphm: I wouldn't...14:38
*** IanGovett has quit IRC14:38
marekddolphm: i mean, store a list of group_ids in a token backend.14:38
*** gokrokve has quit IRC14:38
dolphmmarekd: C) an ephemeral user could take advantage of a role assignment to a group without generating a new token (so, ephemeral user authenticates, receives an unscoped token with groups, admin assigns a role to one of those groups, ephemeral user can scope to new project without repeating a bunch of auth work)14:38
*** joesavak has joined #openstack-dev14:39
dolphmmarekd: for UUID tokens, they MUST be in the db14:39
*** tdruiva_ has joined #openstack-dev14:39
dolphmmarekd: for PKI tokens, the list of groups is effectively signed by keystone14:39
dolphmmarekd: so the end user can't inject groups or anything14:39
*** thuc has quit IRC14:39
dolphm(they could try, but the signature would then fail)14:39
marekddolphm: ah, right!14:40
*** btorch has quit IRC14:40
*** thuc has joined #openstack-dev14:40
*** tdruiva has quit IRC14:40
*** medberry has joined #openstack-dev14:40
*** medberry has quit IRC14:40
*** medberry has joined #openstack-dev14:40
*** lsmola has quit IRC14:41
marekdhmm, this might even work...14:41
marekdBRB14:41
*** dbalog has joined #openstack-dev14:42
*** coolsvap has joined #openstack-dev14:42
*** doug_shelley66 has joined #openstack-dev14:44
*** peristeri has joined #openstack-dev14:44
*** thuc has quit IRC14:44
*** tdruiva_ has quit IRC14:45
*** irenab has quit IRC14:47
*** jmckind has joined #openstack-dev14:47
marekdRE14:47
*** wchrisj_ has quit IRC14:48
*** hnarkaytis has quit IRC14:48
*** bswartz has joined #openstack-dev14:49
*** jdob_ has joined #openstack-dev14:49
*** jdob has quit IRC14:49
*** clayb has joined #openstack-dev14:50
*** armax has joined #openstack-dev14:50
*** neeti has quit IRC14:50
*** adreznec has joined #openstack-dev14:51
*** angdraug has joined #openstack-dev14:51
*** jcooley_ has joined #openstack-dev14:51
*** morazi has joined #openstack-dev14:52
*** lbragstad has joined #openstack-dev14:52
*** mflobo_ has quit IRC14:52
*** jecarey has joined #openstack-dev14:53
*** lsmola has joined #openstack-dev14:53
*** DinaBelova_ is now known as DinaBelova14:54
*** boris-42_ has quit IRC14:54
*** Jabadia has quit IRC14:57
*** jcooley_ has quit IRC14:57
*** sgordon has quit IRC14:58
*** radez_g0n3 is now known as radez14:59
*** aveiga has quit IRC14:59
marekddolphm: i am rereading our discussion one more time, and I might be getting into a vicious circle but...if the unscoped token returns a list of user grups, and doesn't store them in the backend a client cannot simply issue GET /v3/OS-FEDERATION/projects - assertion is already gone, a list of groups is not stored at the server side. So, rather POST with the list of groups rather than GET.14:59
*** tmclaugh[work] has joined #openstack-dev14:59
*** mfer has joined #openstack-dev15:00
dolphmmarekd: if the list of groups is in the user's token, then GET /v3/OS-FEDERATION/projects has to be an authenticated call with X-Auth-Token: <unscoped token containing groups>15:00
*** kevinconway has joined #openstack-dev15:00
marekddolphm: ok, makes sense!15:01
marekddolphm: thanks15:01
*** devoid has joined #openstack-dev15:01
*** READ10 has joined #openstack-dev15:01
*** dvarga is now known as dvarga|away15:03
*** dvarga|away is now known as dvarga15:03
*** MaxV has quit IRC15:03
*** devoid has quit IRC15:03
*** nshaikh has left #openstack-dev15:03
marekddolphm: but...no, wait. If we use uuid tokens then it's already stored in the db, so is a list of groups, and if it's the PKI token, the token from X-Auth-Token already has a list of groups, and these can be used. Am I right?15:04
*** jasondotstar has joined #openstack-dev15:04
*** sahid has quit IRC15:04
*** matrohon has quit IRC15:05
*** lsmola has quit IRC15:05
*** jobewan has joined #openstack-dev15:06
*** tdruiva has joined #openstack-dev15:09
*** sweston has quit IRC15:10
*** paragan has quit IRC15:10
*** pmathews has joined #openstack-dev15:10
*** sgordon has joined #openstack-dev15:10
dolphmmarekd: correct15:11
marekddolphm: uff15:12
*** krotscheck has joined #openstack-dev15:12
*** jobewan has quit IRC15:12
dolphmmarekd: either way you could implement something like self.token_api.list_groups_for_token(token_id) -- which may or may not hit the database15:12
*** jdob has joined #openstack-dev15:13
dolphmmarekd: or have groups available in context, based on gyee's work15:13
dolphmmarekd: context['groups']15:13
marekddolphm: already available or somewhere on the review.openstack.org?15:13
*** sarob has joined #openstack-dev15:13
dolphmmarekd: it's in review15:13
*** FunnyLookinHat has quit IRC15:13
marekdlink?15:14
dolphmmarekd: obviously it doesn't support groups yet, but...15:14
dolphmmarekd: finding it15:14
dolphmmarekd: actually, it looks to be merged https://review.openstack.org/#/c/56333/15:15
*** MaxV has joined #openstack-dev15:16
*** stevemar has joined #openstack-dev15:16
*** stevemar has quit IRC15:16
*** dkranz has joined #openstack-dev15:16
*** stevemar has joined #openstack-dev15:16
*** tjones has joined #openstack-dev15:17
*** nelsnelson has quit IRC15:17
dstanekdolphm: migrations should still be sqlalchemy-migrate right?15:17
*** AlexF has quit IRC15:17
*** galstrom_zzz is now known as galstrom15:17
*** nelsnelson has joined #openstack-dev15:17
*** sarob has quit IRC15:18
*** lsmola has joined #openstack-dev15:18
*** IanGovett has joined #openstack-dev15:18
*** jdob_ has quit IRC15:19
*** gszasz_ has joined #openstack-dev15:20
Alexei_987sdague: Hi could you please take a look at https://review.openstack.org/#/c/65863/ ?15:20
*** IanGovett1 has joined #openstack-dev15:20
*** tjones has quit IRC15:21
*** jnoller has joined #openstack-dev15:22
*** MaxV has quit IRC15:22
*** jistr has quit IRC15:23
*** IanGovett has quit IRC15:23
*** jistr has joined #openstack-dev15:23
*** MaxV has joined #openstack-dev15:23
*** eharney has joined #openstack-dev15:23
*** gszasz has quit IRC15:24
*** gordc has joined #openstack-dev15:24
*** sushils has quit IRC15:24
bugsdugg1nHas anyone else had issues installing devstack (from the current HEAD of master)? Looks like a Keystone issue15:25
*** carlp has joined #openstack-dev15:27
dolphmdstanek: unless you want to switch us over to alembic15:27
*** jobewan has joined #openstack-dev15:27
dolphmbugsdugg1n: what is the issue(s)?15:27
dstanekdolphm: at this point i'll pass :-)15:28
*** corXi has quit IRC15:28
*** guardianx has quit IRC15:28
*** ayoung-zZzZzZ has joined #openstack-dev15:29
*** gokrokve has joined #openstack-dev15:29
bugsdugg1ndolphm: keystone can't find user glance-swift, which makes me think I've missed a configuration step15:29
dolphmbugsdugg1n: yeah, that doesn't sound like keystone's fault :P15:30
*** bhuvan has quit IRC15:30
*** gokrokve_ has joined #openstack-dev15:30
bugsdugg1ndolphm: agreed.15:30
*** bugsdugg1n is now known as bugsduggan15:30
YorikSardolphm: I wonder if there are any plans to switch to alembic15:30
dolphmYorikSar: ayoung was going to switch us over during havana, but got distracted15:31
*** aditirav has joined #openstack-dev15:31
*** bhuvan has joined #openstack-dev15:31
bugsduggandolphm: fyi, looks like I hit this: https://bugs.launchpad.net/devstack/+bug/127602915:32
YorikSardolphm: Looks like we should do it in early Juno,15:33
*** gokrokve has quit IRC15:33
*** drewlander has quit IRC15:33
*** doug-fish2 has joined #openstack-dev15:33
*** doug-fish has quit IRC15:33
dolphmbugsduggan: bug description makes sense -- let me know if you find a link to the patch15:33
bugsduggandolphm: will do15:34
dstanekdolphm, YorikSar: does a switch over mean a rewrite of existing migrations?15:34
*** david-lyle has joined #openstack-dev15:34
*** jruzicka has joined #openstack-dev15:34
dolphmdstanek: not the way ceilometer did it15:35
YorikSardstanek: Having sqla-migrate migration stop at some point (release is a good point for this) and alembic migrations run after that should be good enough.15:35
*** vartom1111111115 has quit IRC15:35
*** terriyu has joined #openstack-dev15:35
*** jgrimm_ has joined #openstack-dev15:35
dolphmdstanek: they just changed db_sync to first run sqlalchemy-migrate upgrade, then run alembic upgrade, for example15:35
*** kenperkins has joined #openstack-dev15:36
dolphmdstanek: i don't know if/how they support downgrade or migrating to specific versions15:36
dstanekdolphm: now you have me interested15:37
*** zzelle has quit IRC15:40
*** zzelle has joined #openstack-dev15:40
*** troytoman-away is now known as troytoman15:41
*** troytoman is now known as troytoman-away15:41
*** troytoman-away is now known as troytoman15:42
*** troytoman is now known as troytoman-away15:43
*** otherwiseguy has joined #openstack-dev15:44
*** pradeep has quit IRC15:45
*** jcooley_ has joined #openstack-dev15:46
*** byeager has joined #openstack-dev15:47
*** tsekiyama has joined #openstack-dev15:47
*** amuller has quit IRC15:47
*** tjones has joined #openstack-dev15:49
*** gszasz_ has quit IRC15:49
*** JordanP has quit IRC15:49
shardydolphm: hi, quick question if you have a moment?15:49
*** krotscheck has quit IRC15:50
shardydolphm: Is it expected that the v2 tenant list contains projects from all domains, not just the default?15:50
*** krotscheck has joined #openstack-dev15:50
*** jprovazn is now known as jprovazn_afk15:51
*** DinaBelova is now known as DinaBelova_15:51
bknudsonrequest for keystone -- clear out keystone/tests/tmp/* and run tests15:51
bknudsondoes it work for you?15:51
*** beagles_brb is now known as beagles15:51
*** jcooley_ has quit IRC15:51
dolphmshardy: just hte default -- the entire v2 api is effectively "scoped" to a single domain, since it has no domain awareness15:52
dolphmshardy: that's the only purpose for the default domain, actually (it determines what's exposed by v2)15:52
*** amotoki has joined #openstack-dev15:53
*** DinaBelova_ is now known as DinaBelova15:53
shardydolphm: Hmm, that's what I thought, but I'm creating projects in a "heat" domain and they show up with "keystone tenant-list"15:53
*** alex_klimov has quit IRC15:53
shardymaybe something weird in my environment, but I've tried two openstack installs and they both do the same15:53
dolphmshardy: and default_domain_id != heat ?15:54
shardydolphm: Yeah default_domain_id is not set in keystone.conf15:54
dolphm:(15:54
shardymaybe I'm doing something dumb, will keep digging15:55
dolphmshardy: it's probably a valid bug -- our v2 / v3 interop tests are basically non existent outside of auth, and i don't think i've even tested that behavior myself15:55
stevemarbknudson, are you done with the doc changes? When I ran tox -e docs, I noticed a few more related to .rst files, but don't want to start fixing it, if you were planning on it15:56
bknudsonstevemar: I've submitted several separate changes to fix different doc generation problems.15:57
*** CaptTofu has quit IRC15:57
bknudsonstevemar: I believe I'm done with it... what warnings are you seeing?15:57
*** jpomero has joined #openstack-dev15:58
stevemarbknudson, i noticed, 1 that i approved, and 1 related to kds, the ones i'm seeing are related to doc/source/extension_development.rst15:58
*** mhagedorn_ has joined #openstack-dev15:58
stevemarbknudson, just wondering if i missed a patch that you uploaded15:58
shardydolphm: In that case, it's unfortunate the keystone CLI isn't being migrated to v3, we'll end up hitting loads of weird bugs when users continue to use it :(15:58
bknudsonstevemar: I don't think I have a fix for that one15:59
mhagedorn_Kind of a newbie question, Vanilla install of devstack, checked the identity service(Keystone) address.  Noticed that in order to get it to work, I had to append "/tokens" to the end of the URL.  Is this a mistake in the registration code in devstack for Keystone?16:00
dolphmshardy: we need to push harder for python-openstackclient16:00
dolphmmhagedorn_: change the address where?16:01
stevemarbknudson, http://paste.openstack.org/show/62449/16:01
*** giroro_ has quit IRC16:01
*** tanisdl has joined #openstack-dev16:01
*** sweston has joined #openstack-dev16:01
*** atiwari has joined #openstack-dev16:01
stevemarbknudson, i can fix em up16:01
bknudsonstevemar: I saw the extension_development.rst failure once but then it went away somehow.16:01
mhagedorn_the registered address for the Keystone service, in my vanilla devstack install, comes up with an inappropriate address16:01
dolphmstevemar: if we can clean up 100% of those warnings, i'd love to gate against them16:01
bknudsonor maybe I stopped noticing it.16:01
stevemardolphm, +++++16:01
dolphmstevemar: i'm really tired of having to point crap like that out in code review16:02
mhagedorn_i.e. I had to append "/tokens" to the address to get it to work16:02
*** xazel is now known as enykeev16:02
bknudsonI don't know how to fix the prob with "WARNING: missing attribute mentioned in :members: or __all__"16:02
stevemardolphm, there are some, unfortunately coming from oslo16:02
*** changlp has quit IRC16:02
*** changlp has joined #openstack-dev16:02
bknudsonstevemar: I proposed fixes to oslo.16:02
mhagedorn_dolphm.. does that make sense?16:02
stevemarbknudson, yay!16:02
*** iamben_tw is now known as chang1p16:02
*** adreznec has quit IRC16:02
bknudsonlike these other changes they are slow to be accepted16:02
mhagedorn_its like horizon is displaying bad info16:02
*** CaptTofu has joined #openstack-dev16:02
*** Drankis has quit IRC16:03
*** mrodden has quit IRC16:03
dolphmmhagedorn_: what's the specific change you're making? i'm not sure what you mean by "the address"16:03
*** chang1p has quit IRC16:03
*** Ruetobas has joined #openstack-dev16:03
viktorsdhellmann: hello16:03
dolphmmhagedorn_: can you post a diff?16:03
*** iamben_tw has joined #openstack-dev16:03
dhellmannviktors: hi16:03
dolphmmhagedorn_: http://paste.openstack.org16:03
*** carl_baldwin has joined #openstack-dev16:03
viktorsdhellmann: a few  questions to you.16:04
*** hk_peter has joined #openstack-dev16:04
*** JordanP has joined #openstack-dev16:04
hk_peterHey guy, do you want to join the project Titan team, to develop a mature management tool for openstack? http://peter.kingofcoders.com16:04
*** drewlander has joined #openstack-dev16:04
viktorsdhellmann: patch https://review.openstack.org/#/c/68684 (Don't store engine instances in oslo.db). How do you suppose use Model save() method?16:05
mhagedorn_dolphm please see http://paste.openstack.org/show/62450/16:05
viktorsdhellmann: I think, we can fix it's usage in projects16:05
dhellmannviktors: I'm worried about projects delaying adoption of oslo.db as a library because of having to make significant code changes16:06
dhellmannviktors: I'm also worried it means syncing from the incubator into projects takes more time and effort16:06
*** pablosan has quit IRC16:06
*** kenperkins has quit IRC16:06
*** kenperkins has joined #openstack-dev16:07
*** krotscheck is now known as krotscheck_sick16:07
*** pablosan has joined #openstack-dev16:08
*** Ruetobas has quit IRC16:08
viktorsdhellmann: anyway we will do the biggest change is - fix engine usage (because we remove global engine from Oslo).16:08
*** bhuvan has quit IRC16:09
*** jcooley_ has joined #openstack-dev16:09
*** SumitNaiksatam has quit IRC16:09
*** bhuvan has joined #openstack-dev16:10
viktorsdhellmann: so, IMO, the minor change of save() method signature is not a big deal after it16:10
*** angdraug has quit IRC16:11
dhellmannviktors: I just left a more detailed message on the changeset16:11
viktorsdhellmann: ok, will look16:11
*** emagana has joined #openstack-dev16:13
*** mikeoutland has joined #openstack-dev16:13
*** Ruetobas has joined #openstack-dev16:13
*** Guest64422 is now known as mfisch16:14
*** doude has joined #openstack-dev16:14
*** doude has quit IRC16:14
*** mfisch is now known as Guest1977316:15
*** doude has joined #openstack-dev16:16
*** aeperezt has joined #openstack-dev16:16
*** mrodden has joined #openstack-dev16:16
*** mdomsch has joined #openstack-dev16:17
*** thouveng has quit IRC16:17
*** bhuvan has quit IRC16:17
*** bashok has quit IRC16:18
*** tjones has quit IRC16:18
*** adreznec has joined #openstack-dev16:18
*** FunnyLookinHat has joined #openstack-dev16:19
*** sweston has quit IRC16:19
*** artom has quit IRC16:20
*** dtantsur has quit IRC16:20
*** terriyu has quit IRC16:20
*** prad_ has joined #openstack-dev16:20
*** xga has quit IRC16:20
*** byeager has quit IRC16:20
*** buzztroll has joined #openstack-dev16:22
*** hemna has joined #openstack-dev16:23
*** xarses has quit IRC16:24
*** yeylon__ has quit IRC16:24
*** rkukura_ has quit IRC16:24
*** rkukura has joined #openstack-dev16:25
*** xqueralt has quit IRC16:25
*** jobewan has quit IRC16:25
*** emagana has quit IRC16:26
*** hk_peter has quit IRC16:27
*** pablosan has quit IRC16:27
*** mikeoutland has quit IRC16:28
*** baoli has quit IRC16:28
*** kbrierly has quit IRC16:28
*** Shaan7 has joined #openstack-dev16:29
*** Shaan7 has quit IRC16:29
*** Shaan7 has joined #openstack-dev16:29
*** emagana has joined #openstack-dev16:31
*** ala has quit IRC16:31
*** pablosan has joined #openstack-dev16:31
dhellmannviktors: I would feel more comfortable if I understood the upgrade path better16:31
viktorsdhellmann: something like proof-of-concept to Nova?16:32
*** max_lobur has quit IRC16:33
*** topol has joined #openstack-dev16:34
*** matrohon has joined #openstack-dev16:34
dhellmannviktors: that would help, sure16:34
*** hemna has quit IRC16:34
*** michchap has joined #openstack-dev16:34
*** max_lobur has joined #openstack-dev16:35
pcmCan anyone help me with an issue I'm having trying to push some WIP code to Gerrit?16:35
*** FunnyLookinHat has quit IRC16:36
viktorsdhellmann: ok, will do it, but I'm not sure about today16:36
*** drewlander has quit IRC16:37
*** SumitNaiksatam has joined #openstack-dev16:37
*** tkammer has quit IRC16:37
dhellmannviktors: no problem16:37
*** kgriffs is now known as kgriffs_afk16:37
viktorsdhellmann: one more question16:38
viktorspatch https://review.openstack.org/#/c/68693 (Don't use cfg.CONF in oslo.db), patch-set 5, file options.py16:38
viktorsdhellmann:  you told, that we need a discovery function registered for bp improve-config-discovery-for-docs to work with the new lib16:38
dhellmannviktors: yes, that can come later16:38
viktorsdhellmann: can you please provide more information about it? Or an example of such function16:38
*** michchap has quit IRC16:38
*** thuc has joined #openstack-dev16:39
viktorsdhellmann: oh, later16:39
*** lsmola has quit IRC16:39
dhellmannviktors: http://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo/messaging/opts.py#n5616:39
*** zaitcev has joined #openstack-dev16:39
viktorsdhellmann: thanks16:39
dhellmannviktors: registered like http://git.openstack.org/cgit/openstack/oslo.messaging/tree/setup.cfg#n5316:39
*** belmoreira has quit IRC16:39
*** thuc_ has joined #openstack-dev16:40
viktorsdhellmann: will look at it16:40
dhellmannviktors: let me know if you run into issues16:40
*** jcooley_ has quit IRC16:40
viktorsdhellmann: will do16:41
*** ayoung-zZzZzZ is now known as ayoung16:41
*** baoli has joined #openstack-dev16:41
*** aditirav has quit IRC16:41
*** emagana has quit IRC16:41
*** markwash has joined #openstack-dev16:41
*** markmcclain has joined #openstack-dev16:42
*** thuc has quit IRC16:43
*** tjones has joined #openstack-dev16:44
*** mlavalle has joined #openstack-dev16:44
ayoungbknudson, dstanek https://review.openstack.org/#/c/68548/  please when you get a chance.  I want to start moving along the pre-reqs for revocation ahead of the I3 crush16:45
*** drewlander has joined #openstack-dev16:45
*** aditirav has joined #openstack-dev16:45
*** devoid has joined #openstack-dev16:45
*** dvarga is now known as dvarga|away16:45
*** dvarga|away is now known as dvarga16:45
*** tjones has quit IRC16:46
*** SergeyLukjanov is now known as SergeyLukjanov_a16:46
bknudsonayoung: all that stuff is ready to go?16:47
*** feleouet has joined #openstack-dev16:47
ayoungbknudson, that one is16:47
bknudsonok16:47
*** ijw has joined #openstack-dev16:47
ayoungand if there are going to be more changes along the notifications front, I need to shave that Yak early16:47
*** jistr has quit IRC16:47
*** JordanP has quit IRC16:48
marekddolphm: can we basically assume that the federated unscoped  token, apart from the 'user'  will have just 'expires_at', 'issued_at' and probably 'methods' in a response json? Just like in here: https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3.md#authentication-responses16:48
*** pablosan has quit IRC16:49
*** bhuvan has joined #openstack-dev16:49
bknudsonayoung: ok, so here's a concern... in _disable_project we delete_tokens_for users... then invalidate_projects...16:49
bknudsonan exception occurs in invalidate_projects16:49
bknudsonso the notification of disabled project doesn't get sent?16:49
*** pablosan has joined #openstack-dev16:49
ayoungactually, it would16:49
*** edmund has joined #openstack-dev16:49
*** angdraug has joined #openstack-dev16:50
ayoungif it doesn't it is a failure of the notifications system16:50
ayoungwould->should16:50
bknudsonayoung: well, normally if the operation fails (e.g., update user) the user wouldn't be updated so there's no notification16:50
*** marun has joined #openstack-dev16:50
ayoungbknudson, well, the logic on that has not changed, just the notification that is sent16:50
ayoungupdate user would have been sent on a disable in the past16:51
*** tjones has joined #openstack-dev16:51
ayoungnow a more explicit notification is sent, but the rules for sending it have not changed16:51
*** mestery has joined #openstack-dev16:51
*** mestery has quit IRC16:51
*** AlexF has joined #openstack-dev16:51
*** lsmola has joined #openstack-dev16:51
ayoungis this a problem?16:51
bknudsonayoung: updating a user is a multi-part process... part of it is revoking the tokens... I thought we wanted to be notified when the tokens are revoked16:52
*** FunnyLookinHat has joined #openstack-dev16:52
bknudsonayoung: I'm not sure if it's a problem or not... you'd have tokens that are revoked according to revocation list but not according to events.16:52
*** dprince has quit IRC16:52
*** rcleere has joined #openstack-dev16:52
bknudsonalthough maybe the tokens shouldn't have been revoked.16:52
*** mestery has joined #openstack-dev16:53
ayoungbknudson, so a catch block around the delete tokens call?16:53
*** ijw has quit IRC16:53
*** CaptTofu has quit IRC16:53
*** xqueralt has joined #openstack-dev16:53
*** ijw has joined #openstack-dev16:54
bknudsonayoung: I guess this isn't really related to disabling projects... more about how I thought it was going to be used for revocations.16:54
*** ijw has quit IRC16:54
*** thedodd has joined #openstack-dev16:54
*** pcm has quit IRC16:55
*** Ryan_Lane has joined #openstack-dev16:55
*** afazekas has quit IRC16:55
*** pcm_ has joined #openstack-dev16:55
*** smurugesan has joined #openstack-dev16:56
*** carlp has quit IRC16:57
*** boris-42_ has joined #openstack-dev16:57
*** xmltok has joined #openstack-dev16:57
*** galstrom is now known as galstrom_zzz16:59
*** e0ne_ has quit IRC16:59
shardydolphm: I raised https://bugs.launchpad.net/keystone/+bug/1276244, but I'm not sure if it's a bug or just a property of v2 admin-ness I didn't expect17:00
*** sweston has joined #openstack-dev17:00
*** AlexF has quit IRC17:00
*** boris-42_ is now known as boris-4217:00
*** kbrierly has joined #openstack-dev17:01
*** CaptTofu has joined #openstack-dev17:01
*** jcoufal_ has joined #openstack-dev17:02
*** jcoufal has quit IRC17:02
*** pmathews has quit IRC17:02
*** mestery has quit IRC17:02
*** pmathews has joined #openstack-dev17:03
*** I159 has quit IRC17:03
*** FunnyLookinHat has quit IRC17:03
*** mestery has joined #openstack-dev17:03
*** boris-42 is now known as boris-42_17:04
*** mestery has quit IRC17:05
*** markmc has quit IRC17:05
*** mestery has joined #openstack-dev17:06
*** Mandell_ has quit IRC17:06
*** bvandenh has quit IRC17:06
*** tdruiva_ has joined #openstack-dev17:07
*** terriyu has joined #openstack-dev17:07
*** hcc is now known as hdd17:07
*** _cjones_ has joined #openstack-dev17:07
*** xarses has joined #openstack-dev17:07
*** tdruiva has quit IRC17:08
*** galstrom_zzz is now known as galstrom17:09
mriedemhas anyone thought about hooking something into our tox runs where if -r is used, we automatically delete all pyc's?17:09
*** tdruiva_ has quit IRC17:09
*** ppetit has quit IRC17:09
mriedema few people hit some duplicate opt errors from oslo.config with the oslo.messaging change in nova last week - deleting pyc's fixed it17:10
mriedemseems we could make that automatic with tox -r17:10
*** gyee has joined #openstack-dev17:10
*** mestery_ has joined #openstack-dev17:10
*** kdbrierly has joined #openstack-dev17:10
*** tdruiva has joined #openstack-dev17:10
*** AlanClark has joined #openstack-dev17:10
*** gyee has quit IRC17:11
*** mestery_ has quit IRC17:11
*** digambar has joined #openstack-dev17:11
*** mestery has quit IRC17:11
*** kbrierly has quit IRC17:11
*** mestery has joined #openstack-dev17:12
*** neelashah has joined #openstack-dev17:12
*** JonnyNomad has joined #openstack-dev17:12
*** ifarkas has quit IRC17:12
*** marcoemorais has joined #openstack-dev17:13
*** gyee has joined #openstack-dev17:13
*** sarob has joined #openstack-dev17:13
*** sweston has quit IRC17:14
*** slagle has quit IRC17:15
ekarlsosandywalsh_: around ?17:16
ekarlsoyou tried to ping me on irc earlier.17:16
*** peoplemerge has joined #openstack-dev17:17
*** omachace has quit IRC17:18
*** sarob has quit IRC17:20
*** AlexF has joined #openstack-dev17:21
*** mrunge has quit IRC17:21
*** drewlander has quit IRC17:22
*** salv-orlando has quit IRC17:23
*** bauzas has quit IRC17:24
*** sweston has joined #openstack-dev17:24
*** tdruiva_ has joined #openstack-dev17:24
tjonesmriedem: i'm hitting that error now - delete the pyc in /opt/stack/…??17:25
*** jasondotstar has quit IRC17:25
*** salv-orlando has joined #openstack-dev17:26
*** nkinder has quit IRC17:26
*** tdruiva has quit IRC17:27
*** vartom1111111115 has joined #openstack-dev17:27
marekdstevemar: ping.17:29
*** tdruiva_ has quit IRC17:29
*** omachace has joined #openstack-dev17:30
*** tdruiva has joined #openstack-dev17:30
*** omachace has left #openstack-dev17:31
*** AlexF has quit IRC17:31
*** galstrom is now known as galstrom_zzz17:31
tellesnobregaanyone from oslo here?17:32
dhellmanntellesnobrega: hi17:32
*** Gaston_Severina has joined #openstack-dev17:33
*** godara has joined #openstack-dev17:33
*** mestery_ has joined #openstack-dev17:34
*** amotoki has quit IRC17:34
*** jcooley_ has joined #openstack-dev17:34
*** vartom1111111115 has quit IRC17:35
*** marcoemorais has quit IRC17:35
gordctjones: delete /opt/stack/nova/openstack/common/notifier folder. that worked for me (there's probably a few more folders with just .pyc files in it which you can also delete)17:35
lifelessjamielennox: I wasn't, I am.17:36
*** AlexF has joined #openstack-dev17:36
tjonesgordc: thanks17:36
*** athomas has quit IRC17:37
*** Sumeniac2 has quit IRC17:37
*** mestery has quit IRC17:38
*** Sumeniac has joined #openstack-dev17:38
mriedemtjones: in /opt/stack/nova17:38
mriedemyeah17:38
*** moted has joined #openstack-dev17:38
mriedemtjones: gordc: point is, deleting pyc's is usually an afterthought, would be nice if we could automatically delete pyc's when rebuilding the venv17:39
mriedemwasn't sure if someone else has tried that before though17:39
mriedemrussellb: ^?17:39
tjonesmriedem: im having a whole bunch of env issues (been on vacation for 2 weeks).  If you want me to try something im happy to do it17:39
*** bdpayne has joined #openstack-dev17:40
gordcmriedem:  agreed. especially for those not working on project and blindly pulling in patches like me. i have no idea what was dropped and needs to be cleaned up.17:40
*** sarob has joined #openstack-dev17:41
*** adreznec has quit IRC17:42
*** sandywalsh_ has quit IRC17:42
*** Sumeniac has quit IRC17:42
*** hemna has joined #openstack-dev17:43
*** sandywalsh has joined #openstack-dev17:43
ayoungmorganfainberg_Z,  let me know when you are awake17:43
*** SpamapS_ is now known as SpamapS17:43
*** jasondotstar has joined #openstack-dev17:44
*** jcooley_ has quit IRC17:44
*** AlexF has quit IRC17:44
*** tshirtma1 has joined #openstack-dev17:45
*** sgran has quit IRC17:46
*** tshirtman has quit IRC17:46
*** julienvey has quit IRC17:46
*** ctlaugh_ has quit IRC17:46
*** creiht has quit IRC17:46
*** BStokes has quit IRC17:46
*** stannie has quit IRC17:46
*** ctlaugh has joined #openstack-dev17:46
*** sarob has quit IRC17:46
*** BStokes has joined #openstack-dev17:46
*** creiht has joined #openstack-dev17:47
*** apevec has joined #openstack-dev17:47
*** MaxV has quit IRC17:47
apevecdolphm, ayoung - I'd appreciate few Keystone Core eye on this stable/havana only patch: https://review.openstack.org/6614917:48
apevecit's discussed as an exception for 2013.2.2 on stable-maint list17:48
dolphmbknudson, dstanek, jamielennox, stevemar, gyee, henrynash ^17:48
*** Gordonz has joined #openstack-dev17:48
*** stannie has joined #openstack-dev17:48
*** sgran has joined #openstack-dev17:48
*** burt1 has joined #openstack-dev17:49
*** julienvey has joined #openstack-dev17:49
*** otherwiseguy has quit IRC17:49
*** aditirav has quit IRC17:49
dolphmmorganfainberg_Z: needs a recheck ^ looks to be a transient against pip17:49
bknudsonwhy not a cherry-pick?17:49
*** sarob has joined #openstack-dev17:49
tellesnobregadhellmann: hi, i was looking into some of the service, nova, cinder, neutron, they all have similar context code, do you know why they don't use oslo context?17:49
apevecbknudson, there's nothing cherry-pickable afaict17:50
*** Sumeniac has joined #openstack-dev17:50
apevecfix in icehouse is the whole new feature, isn't it?17:50
apevecrevocation events or something?17:50
dhellmanntellesnobrega: the context class in oslo probably came from one of those services, and the services haven't been updated to use the common version yet17:50
*** sweston has quit IRC17:50
*** eglynn-lunch has quit IRC17:50
tellesnobregadhellmann: i see, do you have any ideas when (if) they are going to be updated?17:51
*** sweston has joined #openstack-dev17:51
bknudsonI believe this kind of thing is going to continue to be in keystone in icehouse.17:51
ayoungrevocation events addresses this somewhat, but the old mechanism will be left in place dfor a while apevec17:51
apevecayoung, bknudson, hmm, then we really need this on master first17:51
*** AlexF has joined #openstack-dev17:51
apevecplease add review comments!17:51
dhellmanntellesnobrega: someone just needs to do that work, I don't think there's any reason *not* to17:51
dolphmapevec: that last run failed with "pkg_resources.DistributionNotFound: SQLAlchemy>=0.7.3,<=0.7.9" -- that's not a known issue against stable requirements is it?17:52
dolphmsource- http://logs.openstack.org/49/66149/2/check/check-grenade-dsvm/50595f9/logs/old/screen-c-vol.txt.gz17:52
*** tsekiyama has quit IRC17:53
tellesnobregadhellmann: i see. a coworker had a code rejected because no one is using the context yet, it may come in handy to put some services to use it, so oslo com improve17:53
ayoungit might be different in Icehouse due to the KVS Dogpile implementation17:53
tellesnobregadhellmann: thanks for your help17:53
*** drewlander has joined #openstack-dev17:53
*** tsekiyama has joined #openstack-dev17:53
ayoungSomeone in southern Cali go wake up morganfainberg_Z17:53
*** Oneiroi has quit IRC17:53
*** Gordonz has quit IRC17:53
*** amcrn has joined #openstack-dev17:53
*** xqueralt has quit IRC17:53
apevecdolphm, ugh, not that's "old" so Grizzly, lemme look what happened17:54
*** adreznec has joined #openstack-dev17:54
dhellmanntellesnobrega: patch rejected where?17:54
*** florentflament_ has quit IRC17:54
*** salv-orlando_ has joined #openstack-dev17:54
apevecah nice SQLAlchemy==0.7.10 in pip-freeze17:54
tellesnobregadhellmann: yes, a while back. it included domain_id in context17:54
*** dprince has joined #openstack-dev17:54
*** jgallard has quit IRC17:54
*** gokrokve_ has quit IRC17:54
* apevec sighs17:54
*** jkyle has joined #openstack-dev17:55
*** nmagnezi has quit IRC17:55
apevecdolphm, so we need to fix Grizzly to pass havana17:55
dhellmanntellesnobrega: which project rejected it?17:55
*** sweston has quit IRC17:55
*** lucasagomes has quit IRC17:55
*** gokrokve_ has joined #openstack-dev17:55
*** alop has joined #openstack-dev17:55
*** kgriffs_afk is now known as kgriffs17:56
tellesnobregadhellmann: i will find the patch to link it to you17:56
dhellmanntellesnobrega: ok17:56
*** salv-orlando_ has quit IRC17:56
*** sgordon has quit IRC17:57
jaypipesjamielennox: https://review.openstack.org/#/c/71044/17:57
*** dvarga is now known as dvarga|away17:57
*** dvarga|away is now known as dvarga17:57
*** salv-orlando_ has joined #openstack-dev17:57
*** salv-orlando has quit IRC17:57
*** salv-orlando_ is now known as salv-orlando17:57
dolphmbknudson: looking at the meeting agenda and your patch -- are you just trying to support role assignments on ephemeral users?17:57
*** byeager has joined #openstack-dev17:58
tellesnobregadhellmann: sorry, i made a mistake, it was in nova17:58
tellesnobregaoslo accepted it17:58
dhellmanntellesnobrega: ok, if nova is not using the oslo context yet that's something separate to work on17:58
bknudsondolphm: get_project_users returns the users for the project... but the user might not exist due to federation.17:58
*** harlowja_away is now known as harlowja17:59
tellesnobregadhellmann: i see17:59
dolphmbknudson: i don't think the initial conditions make sense17:59
bknudsondolphm: maybe federation doesn't go through this code?17:59
*** comay has joined #openstack-dev17:59
dolphmbknudson: ++ this should be unsupported for ephemeral users17:59
*** mmagr has quit IRC17:59
topoldolphm., ping (meeting time)17:59
*** gordc1 has joined #openstack-dev17:59
*** AlexF has quit IRC17:59
*** alop_ has joined #openstack-dev17:59
bknudsondolphm: so just don't return the users? return 404 Not Found?17:59
dolphmtopol: ping our room is occupied lol18:00
dolphmbknudson: i think there's a problem before you ever get to this code18:00
*** KurtMartin is now known as kmartin18:00
topolayoung kicked them out18:00
bknudsondolphm: well, it used to be that we couldn't add role refs for users that don't exist, and now we can.18:00
*** alop has quit IRC18:01
*** alop_ is now known as alop18:01
*** amuller has joined #openstack-dev18:01
*** morganfainberg_Z is now known as morganfainberg18:01
*** gcha has quit IRC18:01
morganfainbergdolphm o/18:02
*** gordc has quit IRC18:02
*** marcoemorais has joined #openstack-dev18:02
*** kushal has joined #openstack-dev18:02
*** buzztroll has quit IRC18:03
*** buzztroll has joined #openstack-dev18:03
*** marcoemorais has quit IRC18:04
*** nati_ueno has joined #openstack-dev18:04
*** max_lobur is now known as max_lobur_afk18:05
*** FunnyLookinHat has joined #openstack-dev18:05
*** otherwiseguy has joined #openstack-dev18:05
*** SergeyLukjanov_a is now known as SergeyLukjanov18:05
*** galstrom_zzz is now known as galstrom18:05
*** rraja_ has joined #openstack-dev18:06
*** nacim has quit IRC18:06
*** rraja has joined #openstack-dev18:07
*** e0ne has joined #openstack-dev18:08
*** byeager has quit IRC18:12
*** FunnyLookinHat has quit IRC18:13
*** marcoemorais has joined #openstack-dev18:13
*** sarob has quit IRC18:14
*** FunnyLookinHat has joined #openstack-dev18:14
*** sarob has joined #openstack-dev18:15
*** coolsvap is now known as coolsvap_away18:16
*** neelashah has quit IRC18:17
*** neelashah has joined #openstack-dev18:18
*** pberis has joined #openstack-dev18:18
dolphmluisg: can you step into #openstack-meeting please?18:19
jamielennox*luisg: step into my office*18:20
*** kenperkins_ has joined #openstack-dev18:20
YorikSarayoung: Hello. Around?18:22
ayoungYorikSar, yeah...in the Keystone meeting ATM18:22
*** neelashah has quit IRC18:22
*** AlexF has joined #openstack-dev18:22
ayoungYorikSar, I'm going to guess your question is about expires_at?18:22
YorikSarayoung: Yes, exactly :)18:22
YorikSarayoung: It can wait till after the meeting18:23
ayoungYorikSar, OK, so only user tokens are ever going to use that18:23
ayoungif I use a token to get antoher token, they both have the same expires_at18:23
*** kenperkins has quit IRC18:23
ayoungthis way, if I want to revoke a token AND all of the tokens it created, I revoke  userid=<me> and expires_at = <expiresat of first token>18:23
*** michchap has joined #openstack-dev18:24
jamielennoxjaypipes: ok, that patch is cool - it might be easiest if i just rebase the others on top of that as there isn't any real ordering requirement on the others18:24
ayoungwe are a little brutal, in that if I revoke the last token of the list created via 25 tokens prior, all 26 tokens get revoked18:24
*** jcooley_ has joined #openstack-dev18:24
jamielennoxjaypipes: might be useful to tag it with the bp18:24
ayoungYorikSar, so only a small subset of revocation events  will have "expires_at" set18:24
ayoungYorikSar, we are ordering the events on "revoked_at" not for lifespan, but to be able to continually query the server18:25
jaypipesjamielennox: sure, go for it.18:25
ayoungand get only events we haven't seen in the past, hence "last_fetched"18:25
*** jcooley_ has quit IRC18:26
*** hartsocks has joined #openstack-dev18:26
YorikSarayoung: Oh, wait. Looks like I've mixed up expries_at and issued_at.18:27
*** dkehn has quit IRC18:27
*** danpb has quit IRC18:27
*** martyntaylor has left #openstack-dev18:28
ayoungYorikSar, yeah,  and issued_at is only used in a > comparison with idssued_before18:28
*** thuc_ has quit IRC18:28
*** michchap has quit IRC18:28
*** thuc has joined #openstack-dev18:29
*** safchain has quit IRC18:30
YorikSarayoung: So... We have 3 timestaps there: revoke_at, expires_at and issued_at.18:31
YorikSarayoung: I get that expires_at is like a birthmark on all tokens that are generated from one ancestor.18:31
YorikSarayoung: (we can probably use some more explicit mark though)18:32
ayoungYorikSar, yeah.  But only issued_at is guaranteed to be there, and revoke_at is not part of the public API, just used for internal ordering18:32
ayoungYorikSar, userid + expires at is good enough18:32
*** ijw has joined #openstack-dev18:32
ayoungfarily common solution to this problem, I've been informed.18:33
*** ijw has quit IRC18:33
*** e0ne_ has joined #openstack-dev18:33
YorikSarayoung: Can't I generate a token from another token with different expiration time?18:33
*** thuc has quit IRC18:33
YorikSarLike subtract a second18:33
*** changbl has joined #openstack-dev18:34
YorikSariirc I can provide extiration time in token request.18:34
ayoungnope18:34
*** sgordon has joined #openstack-dev18:35
ayoungpretty certain we made that illegal.  If not...well it is a bug18:35
*** e0ne has quit IRC18:35
*** gokrokve_ has quit IRC18:35
*** gokrokve has joined #openstack-dev18:36
*** thuc has joined #openstack-dev18:36
*** ijw_ has joined #openstack-dev18:37
YorikSarayoung: I'll check it. But from code it looks like we set expires to the default value only if it's not set already.18:38
*** mestery_ has quit IRC18:38
*** zzelle_ has joined #openstack-dev18:38
*** dprince has quit IRC18:39
*** yassine has quit IRC18:39
ayoungYorikSar, if it comes in the existing token, they cannot extend it.  If they can, it is a bug18:39
*** neelashah has joined #openstack-dev18:40
*** ijw_ has quit IRC18:40
*** jpich has quit IRC18:40
*** cagrev_ has joined #openstack-dev18:40
*** arnaud___ has joined #openstack-dev18:40
*** arnaud__ has joined #openstack-dev18:40
*** markmcclain has quit IRC18:40
*** gokrokve has quit IRC18:41
YorikSarayoung: Ok, I believe you and will check it tomorrow just to learn more about auth process.18:41
ayoungYorikSar, look here:18:41
ayounghttps://github.com/openstack/keystone/blob/master/keystone/token/providers/common.py18:41
*** sdake has quit IRC18:42
YorikSarayoung: Yeah, I'm looking at it :)18:42
*** jistr has joined #openstack-dev18:42
*** ijw_ has joined #openstack-dev18:43
*** sdake has joined #openstack-dev18:43
*** sdake has quit IRC18:43
*** sdake has joined #openstack-dev18:43
*** byeager has joined #openstack-dev18:43
ayoungYorikSar, it is possible something sneaks in from either the auth controller, the token controller, or one of the auth plugins, but fairly certain we test against that.  It would be a secureity hole if a user could etend their token lifespan.  But it may be that we don't check to see if they can shorten it...pretty sure we don't let the user touch it, though.18:44
*** dims has joined #openstack-dev18:44
*** Gordonz has joined #openstack-dev18:45
YorikSarayoung: Yeah... Let's get back to revokation. I don't get the meaning of revoke_at, actually.18:47
*** slagle has joined #openstack-dev18:47
ayoungYorikSar, it means "when the revocation event was recorded"18:48
*** Gordonz has quit IRC18:49
*** jprovazn_afk is now known as jprovazn18:50
YorikSarayoung: Yes, but why do we forget about revocations that happened before default token expiration time + 30m?18:50
ayoungYorikSar, to clean out the database.  Otherwise it will keep growing and fill all available space.  We have that problem with the token database today.18:50
*** byeager has quit IRC18:51
*** thedodd has quit IRC18:51
devanandamikal: iirc, you had some tools for reviewing reviewers? was there anything that aggregated someone's review feedback, like if i want to see all the comments left by user 123418:51
YorikSarayoung: But what if the user generated a token for a day and then got fired, waited for an hour and came back with this token? It won't be revoked anymore.18:52
ayoungrevocation is one hour, and you can't make a token for longer than that18:53
ayoungYorikSar, we can make the window longer, but we need to make sure people can't issue tokens longer than the window18:54
*** jcooley_ has joined #openstack-dev18:55
*** gokrokve has joined #openstack-dev18:55
YorikSarayoung: How do we limit token lifetime?18:55
*** andreaf has quit IRC18:55
*** sdake has quit IRC18:55
ayoungexpires_at cannot be set by the user18:55
*** aveiga has joined #openstack-dev18:56
*** melwitt has joined #openstack-dev18:56
YorikSarayoung: Oh, ok.18:57
ayoungYorikSar, the idea is that tokens really are not for authentication.  They are short lived authorization documents, kindof like "visitors must check in at the window and get a guest pass"18:58
YorikSarayoung: But still what if I want the user to never get a new token since midight for example? I add a revocation with user_id and issued_at=midnight.18:58
ayoungdisable the user account18:59
ayoungrevocations are not for that18:59
ayoungthey are for already issued tokens18:59
marekdfederation.19:00
ayoungbknudson, we need a default approach19:00
dolphmayoung, bknudson, dstanek, jamielennox, morganfainberg, stevemar, gyee, henrynash, topol, marekd, lbragstad, joesavak, shardy, fabiog: picking up where we left off19:00
*** gokrokve has quit IRC19:00
* morganfainberg is listening here now19:00
ayoungbut I don;t think we can rely on the IdP to provide the user id without something from Keystone mixed in.19:00
*** fabiog has joined #openstack-dev19:00
ayoungOtherwise, they will be able to step on each other19:00
dstanekdolphm: that won't work with ephemeral tokens though - someone is always going to want to know that user X did these things to my cloud19:00
YorikSarayoung: Ok, looks like I get it now...19:00
*** Gordonz has joined #openstack-dev19:00
*** markmcclain1 has joined #openstack-dev19:00
ayoungYorikSar, ++19:00
bknudsonayoung: I guess keystone could append/prefix the idp ID19:00
* stevemar afk for 5 mins... then back to listening about federation19:01
ayoungYorikSar, BTW, I am going to update both the SQL and the KVS backends in other patches19:01
YorikSarayoung: Thanks a lot for clarifications :)19:01
*** Gordonz has quit IRC19:01
ayoungbut include the comments you made in the Tree patch.19:01
bknudsonayoung: after it gets some user_id attribute from federation mapping.19:01
stevemarmarekd, i'm ok with assuming there will always be a user entity19:01
dolphmwith the exception of the "groups" attribute which I added this morning, this was the example federated token we produced at the hackathon https://gist.github.com/dolph/5cfa70c02f5b141060c5#token-as-a-result-of-federation19:01
ayoungbknudson, domain id, lets keep it separate from IdP id19:01
ayoungone IdP can have one or more Domains19:01
*** Gordonz has joined #openstack-dev19:01
*** markmcclain1 has quit IRC19:01
*** byeager has joined #openstack-dev19:02
ayoungThen, an IdP registers its domain with Keystone19:02
bknudsonayoung: where do you define the IdP -> domain mapping?19:02
*** bhuvan has quit IRC19:02
*** bhuvan_ has joined #openstack-dev19:02
*** rodrigods has joined #openstack-dev19:02
*** hugokuo has quit IRC19:02
dolphmayoung: what do idp's have to do with domains?19:03
ayoung"I provide 3 domains:  Harvard School of Policy,  Harvard Extension, and Harvard Medical School"19:03
bknudsonhttps://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3-os-federation-ext.md -- no mention of domains19:03
*** jnoller has quit IRC19:03
ayoungdolphm, IdP is a service.  Domain is a top level naming scope.19:03
dolphmthat doesn't answer my question19:03
*** amandap has quit IRC19:03
*** mestery has joined #openstack-dev19:04
ayoungdolphm, Hosting company like Rackspace:  you have employees and customers.  Both come out of the same IdP.  Each customer (company) gets its own domain.19:04
ayoungemployees go into one domain19:04
dolphmayoung: in the federated case, they're not users and don't have domains19:05
bknudsonayoung: so federation mapping generates a domain_id and user_id ?19:05
dolphmayoung: they're ephemeral users from federated identity providers19:05
ayoungbknudson, "mapping" does not generate the domain id.  It needs to be controlled by Keystone19:05
*** jcoufal_ is now known as jcoufal19:06
*** markmcclain has joined #openstack-dev19:06
bknudsonayoung: mappings are controlled by keystone -- https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3-os-federation-ext.md#create-a-mapping-put-os-federationmappingsmapping_id19:06
*** hugokuo has joined #openstack-dev19:06
*** gokrokve has joined #openstack-dev19:06
*** dprince has joined #openstack-dev19:06
*** kushal has quit IRC19:07
*** amandap has joined #openstack-dev19:07
ayoungbknudson, yes, but assignment of domain ID needs to be a constrained list. It is OK for the IdP to assign it however they like, so long as it is one of the legal domain ids they are apportioned19:07
*** tanisdl has quit IRC19:07
*** eglynn-lunch has joined #openstack-dev19:08
ayoungdomain is the top level "group"  and it is the "we own the users" abstraction.  Try and break that, and you are once again trying to change the language that people use to talk about Keystone.  We did that with tenants and projects and we are going to be years sorting that one out.19:08
*** e0ne_ has quit IRC19:09
ayoungBecause we need to make Federation work along side the SQL identity backend, and the LDAP backend19:09
*** AlexF has quit IRC19:09
*** amuller has quit IRC19:10
*** zzelle has quit IRC19:10
*** gokrokve has quit IRC19:11
*** Mandell has joined #openstack-dev19:12
dolphmayoung: you're trying really hard to conflate local users with federated users, and i thought we decided at the summit to avoid that19:12
*** rossella_s has quit IRC19:13
bknudsonI really would like if federation didn't require local users/groups if we can avoid it.19:13
* ayoung processing19:13
jamielennoxgyee: are you here - you've been quiet19:13
bknudsonlet's just drop the identity backend.19:13
dolphmbknudson: if we jump straight to ABAC, then yes19:13
bknudsondeprecate it19:13
*** salv-orlando has quit IRC19:13
marekdbknudson: in 14 days...19:13
dolphmmarekd: lol19:13
*** gokrokve has joined #openstack-dev19:14
*** salv-orlando has joined #openstack-dev19:14
*** akrivoka has quit IRC19:14
*** baoli has quit IRC19:15
*** mikeoutland has joined #openstack-dev19:15
ayoungor we can do it my way and everything works19:15
bknudsonI wonder if we could use the mapping feature with general external users (REMOTE_USER)19:15
bknudsonmaybe httpd doesn't provide enough info19:15
dolphmbknudson: it only provides a name, really19:16
ayoungbknudson, depends on what it is given, but yes we can and will19:16
marekdhttps://gist.github.com/zaccone/914822d37ac2eea420ce provides e.g this (ADFS_*)19:16
ayoungWe could, in fact, extract out the LDAP backedn and do it all with mod_auth_somethingthatcantalkldap19:16
dolphmbknudson: you need some set of attributes as an input to mapping, and it outputs another set of attributes19:16
bknudsonmaybe could use some other middleware to get the user info ... from ldap or something19:16
*** mikeoutland has quit IRC19:16
dolphmayoung: do it19:17
*** dvarga is now known as dvarga|away19:17
*** dvarga|away is now known as dvarga19:17
*** jcooley_ has quit IRC19:17
ayoungdolphm, need to write it first. mod_authn_ldap is as hard coded as the other apache authns....we'll probably do soemthing on top of SAML and mod_mellon19:18
marekdi don't understand the LDAP talk.....can anybody explain it more?19:18
*** reed has quit IRC19:18
*** shadower_ is now known as shadower19:18
ayoungmarekd, I can, but it is a bit beyond the scope here19:18
*** reed has joined #openstack-dev19:19
marekdayoung: ok19:19
ayoungthe short of it is that we have mechanisms for SQL, LDAP, and now federation, that all should be able to co-exist in one Keystone deployment19:19
*** sdake has joined #openstack-dev19:19
*** sdake has quit IRC19:19
*** sdake has joined #openstack-dev19:19
ayoungit means that we need to have a unified way to work with them.   Really, it means that we ened to be able to distinguish between users stored in one backend from another19:19
*** mriedem has quit IRC19:19
dolphmmarekd: even shorter version- as federation becomes the first class deployment approach, we'll likely see the rest of keystone simplified19:19
*** sushils has joined #openstack-dev19:20
ayoungFederated users won't worl with the identity API calls, but SQL and LDAP need to19:20
marekdokay, so you are talking about long-term plans. I'd love to talk about short-term ones :-)19:20
*** rtheis has joined #openstack-dev19:21
dolphmmarekd: +++++19:21
ayoungshort term:  we make the userid be one part mapped attribute out of SAML (or LDAP)  and one part domain id19:22
ayoungthe domain table will state what backend a domain comes out of:  sql, LDAP, federated IDP19:22
marekdi was really really convinced that we would be mapping saml assertion to the groups that already have roles assigned and exist, befoe any mapping is done. Can we easily change this assumption NOW? Federation setup is not something you do twice a day.19:23
topolmarekd+++ crawl walk run...19:23
ayoungdirect role assignments for Icehouse19:23
dolphmmarekd: i don't think that has changed19:23
*** xgsa has quit IRC19:23
marekddolphm: +19:23
dolphmayoung: wtf19:23
ayoungsomething to pull groups out of identity for Juno19:23
* dolphm facepalm19:24
ayounger...allow groups to be pulled out of identiyt...or something19:24
dolphmayoung: that's called mapping19:24
ayoungdolphm, I'm being consistent.19:24
ayoungdolphm, groups,  not mapping auser to a group, the grouping itself19:24
ayoungdolphm, we've discussed this before.  And stop hitting yourself19:24
dolphmayoung: yes we have, and we've decided to move towards something much less complicated than what you're suggesting now19:25
*** eglynn-lunch has quit IRC19:25
ayoungdolphm, mapping can only handle the data that comes out of the assertion.  We can allow them to make a different mapping from userid to group, but as marekd said "its not something you do twice a day"19:25
ayoungdolphm, that is fine, and I am OK with us not doing it if we can avoid it.  If mapping deals with "groups outside of identity"  great19:26
ayoungI'm just  saying "Juno"  but if it is "never" I'm ok with that19:26
dolphmayoung: i don't think "groups outside of identity" has been conceived before today19:26
*** mriedem has joined #openstack-dev19:26
ayoungdolphm, I've had multiple requests for it over time. I've been talking about it, but putting it off19:27
*** jasondotstar has quit IRC19:27
dolphmayoung: multiple requests for non-existent groups?19:27
ayoungmapping will, I hope, be sufficient.19:27
ayoungdolphm, multiple requests for a way to manage users inside of keystone when the Identity backend is read only19:28
dolphmayoung: that doesn't make sense, tell those people to go away19:28
ayoungLDAP has that characteristic, as does Federation with limited attributes.19:28
*** kenperkins has joined #openstack-dev19:30
marekddoes it all mean we ALL should put off federation and wait for Juno/whatever and new super identities?19:31
*** kenperkins_ has quit IRC19:31
*** vijendar has quit IRC19:31
*** ayoung is now known as ayoung-afk19:32
*** diakunchikov has quit IRC19:32
*** jamezpolley_ is now known as jamezpolley19:32
*** diakunchikov has joined #openstack-dev19:33
*** AlexF has joined #openstack-dev19:33
*** jamezpolley is now known as tchaypo19:34
marekddolphm: ayoung-afk ^^^^ ?19:34
*** johnthetubaguy has quit IRC19:34
*** jcooley_ has joined #openstack-dev19:36
*** AlexF has quit IRC19:36
zzelle_clarkb, hi19:37
clarkbzzelle_: hello19:38
*** kgriffs is now known as kgriffs_afk19:38
dolphmmarekd: i don't see a use case for non-ephemeral federated identities, so i'd say no19:38
dolphmactually, when i put it that way it just reads like an oxymoron to me19:38
zzelle_as you said (iirc), it seems there are troubles with git-review tests19:39
clarkbzzelle_: yes, the gerrit masters do not start and stop reliably for each test19:39
zzelle_do i need to do something to trace it ?19:39
*** novas0x2a|laptop has joined #openstack-dev19:39
clarkbzzelle_: you shouldn't, if you run the tests enough you should find that occasionally gerrits do not start or stop19:40
*** galstrom is now known as galstrom_zzz19:40
zzelle_clarkb, that was also my opinion19:40
marekddolphm: okay, so....I am assuming that automagically rules engine will always issue a user, not only list of local groups. The user is ephmeral, but his id will be stored in the token token['user_id']. That's for auditibility. Now, can we assume that communication unscoped token with list of groups -> fetching list of available domains/projects based on group memberships -> scoping the token is still valid?19:41
clarkbzzelle_: I think the best way to handle it would be to start one gerrit before the unittests run and setup different projects per test for test isolation19:41
*** tjones has quit IRC19:41
clarkbzzelle_: then we don't have a bunch of jvms fighting for cpu time19:41
zzelle_clarkb, i was thinking of this solution but perhaps complicated for a so "small" component19:42
dolphmmarekd: as confusing as the meeting was, i didn't take away any reason to change any of that approach. all that sounds valid to me19:42
*** sdake has quit IRC19:42
marekddolphm: well, i got *really* confused :-)19:43
marekddolphm: especially since we started discussing ephemeral groups etc.19:43
*** sdake has joined #openstack-dev19:43
*** sdake has quit IRC19:44
*** sdake has joined #openstack-dev19:44
*** sdake has quit IRC19:44
dolphmmarekd: me too.19:44
jamielennoxdhellmann: ping19:44
*** sdake has joined #openstack-dev19:44
*** sdake has quit IRC19:44
*** sdake has joined #openstack-dev19:44
*** jcooley_ has quit IRC19:44
marekddolphm: taking advantage you are still here i will repeat my previous question: apart from what's listed in the https://gist.github.com/dolph/5cfa70c02f5b141060c5#file-notes-md other attributes that must be present are: issued_at, expires_at and methods. That's all for an unscoped token?19:45
dolphmmarekd: the split between identity and assignment drivers shouldn't have any bearing federation, i don't think (bknudson: -2'd the last patch in that series accordingly)19:45
*** galstrom_zzz is now known as galstrom19:46
dolphmmarekd: that sounds right!19:46
*** AlexF has joined #openstack-dev19:46
marekddolphm: need a hint on 'methods' stuffing :-)19:46
dolphmmarekd: ha-- good question, again19:47
*** AlexF has quit IRC19:47
marekdi am good in asking good questions, i'd rather prefer to be good in answering them :(19:47
dolphmmarekd: so the story behind "methods" is that it's really just intended to reflect multifactor authentication19:47
dolphmmarekd: so if the protocol is SAML 2, you could definitely stick "saml2" or something into "methods"19:48
dolphmmarekd: unless SAML is capable of exposing similar information (?), in which case, you could basically just pass it through19:48
jamielennoxlifeless: ping19:48
marekddolphm: i doubt it.19:49
dolphmmarekd: "federation" would quite vague but acceptable as well19:49
*** salv-orlando has quit IRC19:49
marekddolphm: 'vague but interesting...' :D19:49
*** jcooley_ has joined #openstack-dev19:49
*** salv-orlando has joined #openstack-dev19:49
dolphmmarekd: a more realistic (and useful) example would be a multifactor token reflected as "methods": ["password", "rsa-token"]19:50
marekdrsa-token reflects to federated authn, right?19:50
dolphmmarekd: yes, you could say that19:50
dolphmi've never thought of it that way!19:50
marekddolphm: uhm....OK i will put something there, just for now.19:51
marekdthis is probably not the biggest issue for now.19:51
dolphmmarekd: clients would really only care if the token is multifactor or not, so it should really be "factors": 2 in that case19:51
marekd2?19:52
dolphmbut i gave up arguing against gyee on that topic long ago :)19:52
dolphmmarekd: 2 factors in ["password", "rsa-token"]19:52
lifelessjamielennox: ongp19:52
dolphmsomething you know + something you have19:52
marekddolphm: yees, but i don't see any relation with federated authn?19:52
dolphmmarekd: whereas "methods": ["password", "mothers-maiden-name"] is factors: 1 (both are just something you know)19:53
dolphmmarekd: i'm just trying to give some perspective to the attribute :)19:53
marekddolphm: ok19:53
dolphmmarekd: sticking the protocol ID in there sounds sufficient to me19:53
*** sweston has joined #openstack-dev19:53
dolphmor even just "federation"19:53
marekdif i recall correctly somebody got a -2 from ayoung for using federation as a authn method :P19:54
*** dvarga is now known as dvarga|away19:54
*** dvarga|away is now known as dvarga19:54
jamielennoxlifeless: i am having a weird issue where testr is cutting out early and the ./run_test.sh script returns with a _StringException error with no details19:54
marekddolphm: so i'd be reluctant to use 'federation' as a method name :-)19:54
jamielennox(and i've completely killed my environment now trying to debug the thing)19:55
lifelessjamielennox: testr is dying? thats unusual. Can you point me at a failed job ?19:55
jamielennoxlifeless it's on my local machine but it seems consistant19:56
lifelessjamielennox: are you sure its testr thats dying and not the test backend ?19:56
lifelessjamielennox: anyhow, I'm happy to help you debug; remote hands / shared session whatever19:56
lifelessjamielennox: tell me where you're up to, and we can go from there.19:57
*** cagrev_ has quit IRC19:57
jamielennoxlifeless: it's not printing an exception like there is a test failure just exiting19:57
lifelessjamielennox: warning - this morning is my 4 hours of meeting penance for being, well, me.19:57
lifelessjamielennox: so there will be periods of quiet :(19:57
*** cagrev has quit IRC19:57
dolphmmarekd: lol can you use the protocol ID?19:57
jamielennoxlifeless: that's ok you're usually around in my TZ anyway19:57
*** jpomero has quit IRC19:57
marekddolphm: i will, no worries :-)19:57
*** cagrev has joined #openstack-dev19:57
*** julienvey_ has joined #openstack-dev19:58
lifelessjamielennox: anyhow first thing is - get me a pastebin of what you do see19:58
dolphmmarekd: if so, you've taken away another one of my shakey use cases for having a "user" ref in tokens at all!19:58
lifelessjamielennox: and tell me what project so I can eyball run_tests therein19:58
jamielennoxlifeless: bah, after all that i've killed my venv with all the debugging stuff i had - sorry give me a few minutes and i'll get some stuff up19:58
*** bauzas has joined #openstack-dev19:58
*** sweston has quit IRC19:58
*** thuc has quit IRC19:59
*** thuc has joined #openstack-dev19:59
marekddolphm: please rephrase, cause i might misunderstanding something..i still must use user in a token...19:59
*** jtomasek has quit IRC20:00
marekddolphm: user_id20:00
dolphmmarekd: continue to plan on having the user reference in the token20:00
*** markmc has joined #openstack-dev20:00
*** bhuvan_ has quit IRC20:01
*** emagana has joined #openstack-dev20:01
*** jckasper_ has joined #openstack-dev20:01
*** adreznec has quit IRC20:02
*** dot has joined #openstack-dev20:02
dothello is it possible to disable csrf token on login page?20:03
dotj #django20:03
*** cagrev_ has joined #openstack-dev20:03
*** neelashah1 has joined #openstack-dev20:03
*** jistr has quit IRC20:03
*** jcooley_ has quit IRC20:03
*** thuc has quit IRC20:03
*** cagrev has quit IRC20:03
*** neelashah1 has left #openstack-dev20:04
dolphmdot: probably just remove the csrf middleware from the horizon config? (i haven't done it before, i'm just guessing)20:04
*** jckasper has quit IRC20:04
*** sgordon has quit IRC20:04
*** eglynn-lunch has joined #openstack-dev20:04
*** neelashah has quit IRC20:05
*** troytoman-away is now known as troytoman20:05
*** sushils has quit IRC20:05
dotdolphm: i've tried that but did not work :S20:06
*** CaptTofu has quit IRC20:06
*** jcooley_ has joined #openstack-dev20:07
jamielennoxlifeless: ok this is the branch: https://github.com/jamielennox/keystone/tree/pecan1 it's really ugly as i've been trying to isolate the error20:07
jamielennoxrun_tests output: http://paste.openstack.org/show/62470/20:07
jamielennoxtesttools.run discover output: http://paste.openstack.org/show/62471/20:07
gyeejamielennox, dolphm, sorry I got stuck in an internal meeting this morning20:08
dolphmgyee: no worries20:08
jamielennoxlifeless: if i comment out this line (which essentially undoes the change) https://github.com/jamielennox/keystone/blob/pecan1/keystone/service.py#L130 then i get the expected test run20:09
*** yeylon__ has joined #openstack-dev20:09
*** brianr has joined #openstack-dev20:09
jamielennoxgyee: was going to bug you about auth_plugins20:09
*** jasondotstar has joined #openstack-dev20:09
gyeejamielennox, I was reading it last night, have been thinking about it20:09
jamielennoxgyee: figure out what we can do to get it +2ed20:09
gyeeI will comment on it later today20:09
gyeejamielennox, I am OK with it, there will be more changes later to get it right anyway. But no reason to hold it up.20:10
*** ijw_ has quit IRC20:10
jamielennoxgyee: cool - yea there are additions later but i just want to advance past the framework20:10
jamielennoxthe idea hasn't changed much since the last summit and i really want to get some progress20:11
gyeeI was thinking how do it work with multifactor auths20:11
gyeebut I don't have a good alternative in mind20:11
jamielennoxgyee: so i'm not sure why MFA changes the plugins20:11
*** rfolco has quit IRC20:11
gyeejamielennox, probably not, I just can't wrap my head around it yet20:11
gyeelets merge what you have and enhance it later if needed20:11
*** tjones has joined #openstack-dev20:12
dothello is it possible to disable csrf token on login page? anyone pls?20:12
jamielennoxgyee: so i think where the disconnect is what an auth_plugin does20:12
jamielennoxgyee: really it's a backing to an auth provider20:12
jamielennoxso for keystone v3 we only have 1 auth plugin20:13
jamielennoxnot 1 for user/pass, 1 for user/token20:13
gyeejamielennox, I was coming from an angle of custom plugins :)20:13
jamielennoxso MFA is a feature of a specific provider eg keystone v320:13
morganfainbergjamielennox, external, and oauth20:13
morganfainberg>.>20:13
morganfainbergjamielennox, ok i'm going to lunch :P20:13
morganfainbergsorry20:13
jamielennoxso if the auth_plugin handles MFA then thats fine20:13
jamielennoxmorganfainberg: external and oauth maybe20:14
jamielennoxmorganfainberg: they are still methods of keystone auth20:14
*** thedodd has joined #openstack-dev20:14
jamielennoxoauth i'm a little unsure of20:14
jamielennoxbecause it's keystone but it's not20:15
*** AlexF has joined #openstack-dev20:15
*** troytoman is now known as troytoman-away20:15
jamielennoxgyee: so custom plugins are the same concept though at some point they will get a get_token() call and they will have to determine how to do that20:15
*** tanisdl has joined #openstack-dev20:15
*** gcha has joined #openstack-dev20:15
jamielennoxif they require MFA then they have to prompt for input or something20:16
jamielennoxit's a pity we had to ditch authenticate as a seperate call - but there is no reason that your custom plugin can't have an authetnicate call on it20:16
jamielennox(maybe that's even better)20:16
*** ameade has joined #openstack-dev20:17
*** tdruiva_ has joined #openstack-dev20:18
stevemarjeez, i almost have to scroll down to see the second bug on http://status.openstack.org/rechecks/20:18
gyeejamielennox, I agree, we may be OK20:18
*** adreznec has joined #openstack-dev20:18
*** odyssey4me has quit IRC20:18
*** tjones has quit IRC20:18
gyeejamielennox, it would be awesome if we can abstract the notion of token, but that can be done in a separate patch20:19
*** fabiog has quit IRC20:19
jamielennoxgyee: so as far as i'm concerned we have abstracted a token to a blob20:20
jamielennoxbecause get_token() will return a string that goes into a header20:20
jamielennox(it turned out to be non-trivial to put the header setting on the auth plugin but we can fix that later)20:20
*** tdruiva has quit IRC20:20
*** emagana has quit IRC20:20
jamielennoxthere is nothing about session that requires any knowledge about a token other than to just get one from a plugin20:21
jamielennoxif you need to find out information about the token then you should talk to the auth plugin because that is what knows how to interpret it20:21
jamielennoxso if you are doing your own auth plugin then you are free to define the interaction with your token any way you please20:22
gyeethat's correct, auth plugin return token data20:22
*** troytoman-away is now known as troytoman20:22
*** vijendar has joined #openstack-dev20:22
*** shalini has quit IRC20:22
*** vijendar has joined #openstack-dev20:22
*** shalini has joined #openstack-dev20:23
*** ayoung-afk is now known as ayoung20:23
*** mestery has quit IRC20:23
jamielennoxgyee: yes the string20:24
*** kragniz has quit IRC20:24
ayoungmarekd, to answer your Question....we push it as far as we can.  I don't thik we will have a 100% Federation solution this release, but that doens' mean that we won't have something usable by someone20:25
gyeejamielennox, no, the auth context20:25
jamielennoxthe identity plugins return a auth_ref which is just a way of abstracting behaviour between the v2 and v3 ref20:25
jamielennoxand other plugin that wants to use an auth_ref can also inherit BaseIdentityPlugin20:25
jamielennoxand that means that get_token() etc are handled for it20:25
jamielennoxbut you don't have to20:25
gyeeauth plugin maintains auth context20:25
gyeeauth context tells you things like user_id, username, roles, project, etc20:26
*** emagana has joined #openstack-dev20:27
jamielennoxgyee: right but you can ask the auth plugin for that20:28
*** jckasper_ has quit IRC20:28
jamielennoxthe session doesn't care20:28
*** rkukura has quit IRC20:28
marekdayoung: that's my impression too.20:28
*** e0ne has joined #openstack-dev20:28
gyeejamielennox, how? the base auth plugin class only have get_token() which returns a string20:29
*** cnesa has joined #openstack-dev20:29
marekdayoung: given the fact that actually nothing has been done on a client side i thnk it will be usable at all.20:29
*** kgriffs_afk is now known as kgriffs20:29
marekdor maybe it will, but around april/may.20:29
jamielennoxgyee: that's the interface that session requires to talk to a plugin - if you want to talk to the plugin you can define whatever methods you like20:29
*** n9111 has joined #openstack-dev20:29
n9111How are you n9111 ?20:30
bknudsondolphm: how do I close this? https://blueprints.launchpad.net/python-keystoneclient/+spec/s3-token-to-keystoneclient20:31
*** n9111 has quit IRC20:31
bknudsondolphm: never mind, got it20:32
*** shalini has quit IRC20:32
*** shalini has joined #openstack-dev20:33
jamielennoxgyee: take as an example the ADMIN_TOKEN method of authenticating, all that plugin is going to know is where to talk to and what token to use20:33
jamielennoxthere is no auth_ref that can be returned there20:33
*** julienvey_ has quit IRC20:34
*** troytoman is now known as troytoman-away20:34
*** thuc has joined #openstack-dev20:35
gyeejamielennox, how does session interact with auth plugin to get the token data?20:35
*** atiwari has quit IRC20:35
jamielennoxessentially headers['X-Auth-Token'] = auth_plugin.get_token()20:36
gyeebut get_token() returns a string20:36
jamielennox... right20:36
*** FunnyLookinHat has quit IRC20:36
ayoungmarekd, hell, it was 2 release before anyone could use trusts,  and PKI tokens were not the default for two releases, I am guessing Federation will go into use in the K timeframe20:36
gyeehow does it turned into roles, user_id, username, project, etc?20:36
jamielennoxgyee: why does session need to do that/20:37
dstanekwhat are credentials currently used for in Keystone?20:37
*** troytoman-away is now known as troytoman20:37
ayoungdstanek, storing ec2 keypairs20:37
*** gokrokve has quit IRC20:37
*** cnesa has quit IRC20:38
*** FunnyLookinHat has joined #openstack-dev20:38
*** gokrokve has joined #openstack-dev20:38
*** markmcclain has quit IRC20:38
ayoungmorganfainberg, when you get back, I would love some guidance on redoing the KVS backend for revocation events20:38
dstanekayoung: i'm working on my rotating-passwords blueprint now. i'm reusing credentials to store passwords, but i'm not sure is that's correct20:39
*** kgriffs is now known as kgriffs_afk20:39
dolphmayoung: i'd use a new sql table, and keep it as a sql-dependent feature20:39
ayoungum...probably not, but, hell, the whole idea of passwords is broken anyway20:40
dolphmdstanek: ^ (ayoung- my bad)20:40
ayoungdolphm, yep20:40
ayoungagree20:40
ayoungLDAP has its own PW mechanism, no reason to support or implement there20:41
gyeejamielennox, who does validate token and get the token data? session?20:41
*** denis_makogon_ has joined #openstack-dev20:41
ayounggyee, on the client side?20:41
gyeeayoung, right20:41
jamielennoxgyee: validate? who validates a token now? we send it to the server20:41
ayounggyee, tokens were not validatable on the client side prior to revocation events.20:41
jamielennoxgyee: we can refresh a token if it's about to expire20:41
ayoungIt just got tokens from the keystone erver and used them20:41
dstanekdolphm: the reason i didn't so that initially is that i changed things like /auth/tokens to pull from credentials; since the extension is optional i didn't want to have core code depend on an extension table20:41
jamielennoxthat's the plugin's job if it wants to do that20:42
gyeewhat is auth_ref for then?20:42
jamielennoxgyee: users really20:42
jamielennoxgyee: we can't do anything about validating roles etc because we have no idea how a server is configured20:42
gyeejamielennox, that's what I was getting into20:42
gyeethe data itself20:42
ayoungdstanek, password rotation should be a SQL identity specific feature.  THe KVS ones can support it if you insist, but don't scope beyond that20:43
*** gokrokve has quit IRC20:43
gyeeso auth plugin would have to give you those data or you are doing another call to Keystone to validate the token20:43
*** denis_makogon has quit IRC20:44
*** denis_makogon_ is now known as denis_makogon20:44
*** salv-orlando has quit IRC20:44
jamielennoxgyee: but completely looking at the session - what do you need that data for? why are you trying to validate the token?20:44
*** dmakogon_ has joined #openstack-dev20:44
jamielennoxgyee: if the token is invalid it will be rejected just like now20:44
*** salv-orlando has joined #openstack-dev20:44
morganfainbergayoung, surte20:45
morganfainbergayoung, back20:45
*** markmcclain has joined #openstack-dev20:45
ayoungmorganfainberg, OK,  so  can I list all keys?20:46
jamielennoxgyee: so for people who want that data the auth_plugin is not a mystery - if you need it then you ask for it from the auth plugin but if you want to do that then you have to know what sort of auth plugin you've got20:46
*** iccha has joined #openstack-dev20:46
morganfainbergayoung, no20:46
gyeejamielennox, what is a token and how do you determine its about to expired?20:46
ayoungI need to get all events...I need a key for the events20:46
dstanekayoung: yes, i agree; i modified the identity sql driver to use the credentials table20:46
jamielennoxgyee: session doesn't, get_token() has that power20:46
morganfainbergayoung, correct you'll need an index20:46
ayoungI really don't want to maintain an index table20:46
ayoungNOOOOOOOOOOOOOO20:46
morganfainbergayoung, and updating that index is where you'd use the lock mechanism20:47
ayoungI might as well have one page with all revocation evetns20:47
*** sgrasley has joined #openstack-dev20:47
morganfainbergayoung, except that pages (in memcached) are limited in size20:47
morganfainbergayoung, if you don't exceed that limit, it's great20:47
ayoungargle fargle garbel20:47
ayoungis there any query mechanism I can count on to get more than one key?20:47
morganfainbergayoung, there is .get_multi20:48
*** tdruiva_ is now known as tdruiva20:48
morganfainbergyou pass it a list of keys, returns all of them at once20:48
ayoungbut I need to know all of them...and what if one expired or summat20:48
ayoungand was no longer in the store20:48
*** sdake has quit IRC20:48
morganfainbergayoung, ... hm, let me check20:48
dolphmzaneb: cc- https://review.openstack.org/#/c/64738/ i was referring to linking on launchpad, not within the gerrit UI... is this patch still related in that regard?20:49
morganfainbergmemcache would just omit the valie20:49
morganfainbergayoung, ^ s/valie/value20:49
morganfainbergayoung, i might have done something less friendly20:49
*** slagle has quit IRC20:49
gyeejamielennox, so session does not do token management, the auth_plugin does20:49
jamielennoxgyee: yes20:49
morganfainbergayoung, blech, i raise an explicit exception20:49
zanebdolphm: oh, then no. didn't realise there was an issue going in the other direction too20:49
morganfainberg*doh*20:49
ayoungmorganfainberg, I probable could do something bad like  record the lowest and highest event sequence numbers, then the keys would be  event-1, event-2....20:50
ayoungbut...bleh20:50
*** sdake has joined #openstack-dev20:50
*** sdake has quit IRC20:50
*** sdake has joined #openstack-dev20:50
dolphmzaneb: might just be a keystone issue that i'm seeing; i'll ask in -infra20:50
gyeejamielennox, session will call auth_plugin everytime its about to make a call to the service and auth_plugin determine whether to renew or reuse20:50
ayoungmorganfainberg, ok,  lets dream for a bit20:50
morganfainbergayoung, sure.20:51
jamielennoxgyee: correct20:51
ayoungwhat if there were a preset number of buckets20:51
ayoungand one bucket was used for appending new events20:51
gyeejamielennox, alrighty then, we on the same page :)20:51
ayoungand the buckets were like a linked list20:51
*** drewlander has quit IRC20:51
morganfainbergayoung, sure.20:51
jamielennoxgyee: excellent!20:51
morganfainbergayoung, nothing unreasonable yet20:51
*** mat-lowery has joined #openstack-dev20:52
ayoungso  keystone only needs to know one bucket, and uses that for new revocations, and when that gets full...start a new bucket20:52
ayoungit can keep record of older buckets in memory20:52
morganfainbergayoung, sure.  that is doable.20:52
ayoungor rebuild them from the "good" bucket20:52
morganfainbergayoung, or keep a single index record.20:52
morganfainbergayoung, for "buckets"20:52
ayounggood bucket always has the same name20:52
ayoungwhat if we have multiple Keystone servers...can we make this approach scale to N-active buckets?20:53
jamielennoxgyee: so what is there is fairly minimal, we will later need to mark a bunch of methods as deprecated and handle some interactions that are not supported between the old and new methods but i think that is ok for a new review as i wanted to keep this patch really obvious to what was happennig20:53
*** thuc has quit IRC20:53
ayoungmorganfainberg, do we havea way to query page size?20:53
morganfainbergayoung, you wont know because each backend has different limitations20:53
*** thuc has joined #openstack-dev20:53
*** asalkeld has joined #openstack-dev20:53
morganfainbergayoung, memcache could be configured for 1MB, or 1000MB.  Redis is different, etc20:53
ayoungI know, but once I fire up a backend, can I ask it "how much fits in a bucket"20:54
ayoungOr do we make it a config param?20:54
morganfainbergayoung, you could if the backend knows how to communicate that20:54
morganfainbergayoung, i'd make it a config param20:54
morganfainbergayoung, it's an operator choice, and i'd make the default 1MB20:54
gyeejamielennox, agreed20:54
lifelessjamielennox: so, pastebin of the symptoms ?20:54
ayoungOK,  so one page is the "register a keystone server" page20:54
morganfainbergayoung, yes.20:54
ayoungthen each keystone server gets a bucket20:55
morganfainbergayoung, sure.20:55
ayoungif the server fills the bucket, it clones it20:55
jamielennoxgyee: cool, so i'd love it if you can take another look over those and +2 if you are happy - i want to get these actually moving through20:55
*** aveiga has quit IRC20:55
ayoungnot clones20:55
ayoungjust renames it20:55
morganfainbergayoung, reconstructs it?20:55
ayoungand makes a new, empty buck that just points to the last full bucket20:55
morganfainbergayoung, yah.20:55
jamielennoxlifeless: yep20:55
*** tjones has joined #openstack-dev20:55
ayoungbucket being a page20:55
morganfainbergayoung, just make sure the "index" is updated with the locking mechanism20:55
dstanekayoung: clones the bucket?20:56
jamielennoxlifeless: run_tests: http://paste.openstack.org/show/62470/20:56
morganfainberg.set(<key>, <value>, lock_from_lock_context)20:56
jamielennoxlifeless: testtools.run discover: http://paste.openstack.org/show/62471/20:56
gyeejamielennox, ayoung already have a green check on it, I can just push the button, unless others disagree20:56
ayoungmorganfainberg, so I am thinking we only lock on write20:56
morganfainbergayoung, correct20:56
*** ekhugen has joined #openstack-dev20:56
jamielennoxgyee: there is one dep but it's a fairly easy one20:56
ayounggyee, which review?20:56
dstanekayoung, morganfainberg: if you fill up all of the 1m buckets then what do you do?20:56
gyeeayoung, https://review.openstack.org/#/c/60751/20:56
jamielennoxgyee: there were +1s from dtroyer and others that were interested - i think anyone else who wanted to has seen it, it's been up long enough20:57
morganfainbergdstanek, 1MB of uuids? that would be ~64k buckets i think20:57
*** AlexF has quit IRC20:57
ayounggyee, that is what I thought.  Good by me20:57
lifelessjamielennox: ok, *testr* is not aborting20:57
morganfainbergdstanek, i really really hope we never have that many20:57
lifelessjamielennox: its reporting a failure from your backend20:57
ayoungmorganfainberg, more than UUIDs, but not by much20:57
*** kgriffs_afk is now known as kgriffs20:57
morganfainbergayoung, i meant the keys of the buckets20:57
ayoungeach revocation event should be roughly ...3 UUIDs worth?20:57
*** Ajaeger has joined #openstack-dev20:57
lifelessjamielennox: specifically from keystone.tests.test_associate_project_endpoint_extension.AssociateEndpointProjectFilterCRUDTestCase.test_check_endpoint_project_assoc20:57
morganfainbergayoung, e.g. each bucket would be bucket_uuid20:57
jamielennoxlifeless: oh, i assume that i have an error somewhere - but the fact that the discover run is exiting early with no error message is wrong20:58
dstanekmorganfainberg: above you were talking about configurable page size20:58
lifelessjamielennox: the lack of exception means that the test that failed didn't show an exception20:58
*** rraja has quit IRC20:58
ayoungmorganfainberg, oh, yeah, that is not a problem.  Revocation events are not going to live much longer than tokens20:58
gyeejamielennox, ayoung, +2ed20:58
ayoungI'm guessing the norm ill be one active bucket20:58
morganfainbergayoung, ++ yes20:58
*** thuc has quit IRC20:58
*** rraja_ has quit IRC20:58
gyeeauth plugin FTW!20:58
morganfainbergdstanek, youd say i want a max bucket size of X20:58
ayoungreading buckets will be lockless,  writing to them will require a lock20:58
*** atiwari has joined #openstack-dev20:58
jamielennoxgyee: have a look at the dep as well https://review.openstack.org/#/c/61247/920:58
morganfainbergdstanek, if keystone tried to store more than X data, it'd overflow to the new buckets20:58
morganfainbergayoung, ++ correct20:59
*** nati_ueno has quit IRC20:59
morganfainbergayoung, there is the <region>.get_lock(<key>) context manager20:59
morganfainbergayoung, you'll see i use that in the kvs token backend20:59
*** asalkeld has quit IRC20:59
ayoungmorganfainberg, the trick is to get the "add a bucket" logic such that it can safely be done with out a lock20:59
ayounga read lock that is20:59
ayoungsomething like:20:59
lbragstadjamielennox: just wondering if we should document your change https://review.openstack.org/#/c/71098/ in the event_notifications.rst20:59
gyeejamielennox, sure, looking20:59
dstanekmorganfainberg: i thought you were tring to store 1m of data in a single key and the overflow into other potentially 1m keys21:00
ayoungwe have the same page in memory with two names.  One is "active"   and the other is the "date based"  key.21:00
morganfainbergdstanek, no no, we make keystone manage the data being stored21:00
*** nati_ueno has joined #openstack-dev21:00
morganfainbergdstanek, so if you were to exceed 1M, youd make a new bucket21:01
ayoungso long as active always points to the last full page, we are OK21:01
jamielennoxlifeless: that doesn't explain the testtools.run issue though21:01
*** yeylon__ has quit IRC21:01
dstanekmorganfainberg: what is a bucket?21:01
ayoungI'll try to write it up more clearly.21:01
morganfainbergdstanek, memcache page in this case21:01
morganfainbergdstanek, conceptually21:01
ayoungdstanek, instead of a distributed hash table, we make it a distributed linked list implemented as a distributed hashtable21:01
jamielennoxlifeless: also that ./run_tests.sh script should not fail after one test failure - it will normally run the whole suite and then print, it stops after 1521:02
morganfainbergdstanek, with an opaque kvs (not a dict i can inspect) you need to do it as a LL -> hash table21:02
morganfainbergbasically21:02
dstanekmorganfainberg, ayoung: i was just worried that you'd fill up the 1m keyspace too quickly21:02
*** sdake has quit IRC21:02
jamielennoxlifeless: i realize i have a mistake somewhere, my problems is i have no traceback or any information to figure out what went wrong and i can't pdb it because testtools.run doesn't run the whole suite21:02
*** kragniz has joined #openstack-dev21:02
gyeejamielennox, I need to jump back into the meeting, will review it later today21:03
jamielennoxgyee: np21:03
morganfainbergdstanek, nah, shouldn't be too much of an issue, and keystone will manage the data size (operator configured) rather than trying to ask memcache to store and fail and then try again21:03
jamielennoxgyee: thanks21:03
*** yeylon__ has joined #openstack-dev21:03
ayoungdstanek, assuming 1K per revoke event,  a 1 M page would hold 100K Events21:03
gyeejamielennox, np, thanks for the auth plugin patch, good stuff!21:03
mat-lowerySorry to interrupt. Keystone question: Are service catalog entries filtered at all or simply formatted (with tenant IDs)? In other words, is it possible that two different non-admin users see a different number of endpoints (provided they do no filtering)?21:03
morganfainbergdstanek, yeah events are smallish21:03
ayoungshould only be one key per 100K events21:03
morganfainbergayoung, by defaulty21:03
jamielennoxmat-lowery: they are just formatted21:03
*** nmagnezi has joined #openstack-dev21:04
mat-loweryjamielennox: Thank you!21:04
*** cgoncalves has joined #openstack-dev21:04
*** Gordonz has quit IRC21:04
ayoungmorganfainberg, so...I can probable remove the logic that drops the old events from KVS (Prune) so long as I know that the oldest pages will get cleaned up eventually21:04
morganfainbergayoung, sure, remember the KVS system raises NotFound if an item doesn't exist on get21:05
morganfainbergayoung, you might need to override that behavior21:05
ayoungnope21:05
morganfainbergayoung, ok.21:06
*** MaxV has joined #openstack-dev21:06
*** NearlyFunctional has quit IRC21:06
morganfainbergayoung, this is very similar to how user-tokens are managed in kvs btw21:06
ayoungwe catch it and say "oldest data is last successfully retrieved page"21:06
morganfainbergayoung, except each user gets "one" bucket no overflow21:06
jamielennoxlifeless: also if i do python -m testtools.run discover --list > all_tests; then delete the first 10 (up to the one thats failing) and then do; python -m testtools.run discover --load-list all_tests it will do a full run21:06
ayoungyeah...we could fix that if we weren't going ephemeral21:06
jamielennoxlifeless: again i'm sure it's my fault, i'm just stumped on how to debug it21:06
*** michchap has joined #openstack-dev21:06
morganfainbergayoung, ++ I almost did write that logic21:07
*** kgriffs is now known as kgriffs_afk21:07
morganfainbergayoung, but we decided emphmeral instead21:07
ayoungmorganfainberg, we still may need to21:07
dstanekayoung: how many total would we need to store?21:07
morganfainbergayoung, i actually have that code laying about somewhere.21:07
ayoungdstanek, revocation events?  I have no clue as to how many we will see in reality21:07
morganfainbergayoung, but eh. it's from like grizzly era.. was uuuugly21:07
ayoungmuch fewer than tokens21:07
morganfainbergdstanek, likely in the thousands would be an active cloud imo21:08
*** gokrokve has joined #openstack-dev21:08
ayoungmorganfainberg, if we dropped UUID tokens, we could just have the User pages21:08
ayoungput all of their tokens into their page.21:08
ayounghell...lets not go there and just get to ephemeral21:08
*** mrda_away is now known as mrda21:09
ayoungrevoke events would come from password changes and deleting of role assignments.  one per21:09
morganfainbergayoung, yeah ephemeral instead plz.  in J we can make events the default21:09
ayoung++21:09
morganfainbergand... in theory make uuid tokens go bye bye in ... L?21:09
ayoungOK,  let me write this up.  This revocation code has been the most fun I've had coding in a while21:09
*** gokrokve_ has joined #openstack-dev21:10
*** aveiga has joined #openstack-dev21:10
morganfainbergayoung, ok i'm going to aim to start wokring on ephemeral token stuff in... a day or so.21:10
jamielennoxlbragstad: sorry, just realized i didn't respond to your message - i'm happy to document that, i don't think it should be up to a config file to set the priority level anyway that seems like something that should depend on the type of message21:10
lbragstadjamielennox: no worries, you were in the middle of something : https://review.openstack.org/#/c/71098/121:10
morganfainbergayoung, and it'll be rooted on your revocation code (plus likely a devstack change to enable it, unless you already did that)21:10
morganfainbergs/enable/toggle21:11
*** kgriffs_afk is now known as kgriffs21:11
lifelessjamielennox: sorry, multiplexing 4 discussions21:11
jamielennoxlifeless: me too21:11
*** radez is now known as radez_g0n321:11
*** michchap has quit IRC21:11
lbragstadjamielennox: just thinking if there are people who 'expecting' to set that in Keystone and can't21:11
jamielennoxlbragstad: yea, that seems correct for now - i'm not sure what our long term plans for notification levels are21:11
lifelessjamielennox: python -m testtools.run discover isn't how discove ris used by .testr.conf21:11
*** dvarga has quit IRC21:11
lbragstadjamielennox: me either21:11
lifelessjamielennox: you need python -m testtools.run discover -t ./ ./keystone/tests21:12
*** asalkeld has joined #openstack-dev21:12
dolphmbknudson: luisg: tune into #openstack-meeting21:12
dolphmbknudson: luisg: concerning log translations21:12
*** yeylon__ has quit IRC21:13
lifelessjamielennox: so do that (or just get the list via 'testr list-tests > list)21:13
lifelessjamielennox: next step - it sounds like you've isolated 10 or so tests that include the problem - just bisect down to it21:13
*** gokrokve has quit IRC21:13
jamielennoxso a diff of the two discover --list shows them the same21:14
jamielennoxso list-tests is correct21:14
jamielennoxlifeless: i can isolate it down to more or less a single line21:14
*** gokrokve_ has quit IRC21:14
jamielennox(not true because that line kicks off new functionality)21:15
*** bswartz has quit IRC21:15
jamielennoxbut if i remove it then it runs through like normal21:15
lifelessjamielennox: a line in the *test list*21:15
lifelessjamielennox: or a line of code21:15
jamielennoxcode21:15
*** bswartz has joined #openstack-dev21:15
lifelessjamielennox: so no, we need a test list line21:15
lifelessjamielennox: you said if you delete the head of the list you can run through fully by hand ?21:15
*** mhagedorn_ has quit IRC21:15
*** termie has joined #openstack-dev21:15
*** mat-lowery has left #openstack-dev21:16
*** mdomsch has quit IRC21:16
jamielennoxlifeless: so test list: http://paste.openstack.org/show/62481/21:16
*** mdomsch has joined #openstack-dev21:17
*** sdake has joined #openstack-dev21:17
*** sdake has joined #openstack-dev21:17
jamielennoxif i remove the first 14 entries keystone.tests.contrib.kds.* it seems to run through21:17
lifelessjamielennox: ok21:17
ayoungmorganfainberg, I'm getting: RuntimeError: KVS region revoke-driver is already configured. Cannot reconfigure.21:17
lifelessjamielennox: so, bisect - keep those 14 entries, delete the rest.21:17
ayoungonce I added in the KVS code21:17
lifelessjamielennox: then split the list in two, run each half separately21:17
lifelessjamielennox: if it runs all the tests in that half, the half is clean - discard; otherwise, split in half again and recurse.21:18
*** glenng has joined #openstack-dev21:18
morganfainbergayoung, you're doing a .get_key_value_stote('revoke-driver') ?21:18
morganfainbergayoung, then .configure on that?21:18
ayoungmorganfainberg, um21:18
ayoungself._store.configure(backing_store=self.kvs_backend, **kwargs)21:18
ayoungits in the test startup21:19
*** sdake has quit IRC21:19
ayoungI just copied from the token code21:19
morganfainbergthis in a review?21:19
morganfainbergoh oh21:19
*** sushils has joined #openstack-dev21:19
*** sdake has joined #openstack-dev21:19
*** sdake has quit IRC21:19
*** sdake has joined #openstack-dev21:19
morganfainbergyou need an explicit cleanup21:19
ayounghttp://paste.openstack.org/show/62482/21:19
*** Ajaeger has left #openstack-dev21:20
jamielennoxlifeless: sure but even then i'm not going to see an actual error, when i run the whole thing via testtools.run it just stops after 14 tests with an OK21:20
*** emagana has quit IRC21:20
ayoungmorganfainberg, where is that for the token code?21:20
morganfainbergayoung, sec looking for that line21:20
jamielennoxif i remove the first 14 entries keystone.tests.contrib.kds.* it seems to run through21:20
*** NearlyFunctional has joined #openstack-dev21:20
jamielennoxsry, up+enter21:20
ayoungmorganfainberg, its getting called twice, I think. once by the test code, and the second time by the manager21:21
morganfainbergayoung, ah21:21
ayoungactually, once by load backends21:21
lifelessjamielennox: so if you run those 14 they succeed21:21
jamielennoxhuh, it's the first one21:21
morganfainbergayoung, load_backends should clear out all kvs backends21:21
lifelessjamielennox: but if you run those 14 *and* others, it exits?21:21
ayoungthen my test calls21:22
ayoung self.revoke_api = revoke.Manager()21:22
ayoungright afterwards21:22
morganfainbergayoung, https://github.com/openstack/keystone/blob/master/keystone/tests/core.py#L37221:22
*** sarob has quit IRC21:22
morganfainbergayoung, ah, i only handled the case of load-backends doing this21:22
*** alexpilotti has quit IRC21:22
*** CaptTofu has joined #openstack-dev21:22
morganfainbergayoung, not instantiating multiples of the same name21:22
*** baoli has joined #openstack-dev21:22
ayoungbut calling maanger()  should get me the already existing instance21:22
jamielennoxlifeless: so if i remove the very first entry /*keystone.tests.contrib.kds.api.test.SimpleTest.test_simple*/ then i (seem to be so far) get a full run21:23
morganfainbergayoung, your manager is trying to do configure21:23
morganfainbergayoung, the manager should check to see if it's configured21:23
*** baoli has quit IRC21:23
lifelessjamielennox: and it runs on it's own successfully?21:23
*** hartsocks has quit IRC21:23
*** ijw has joined #openstack-dev21:23
*** galstrom is now known as galstrom_zzz21:23
morganfainbergayoung, https://github.com/openstack/keystone/blob/master/keystone/common/kvs/core.py#L138 likely it should be an @property on kvs regions21:23
*** baoli has joined #openstack-dev21:23
morganfainbergayoung, .is_configured21:23
jamielennoxlifeless: i don't think it will be successful, i've hacked it up too much for that but at least it's running more than 14 tests21:24
morganfainbergayoung, you can do this exact logic to see if you need to configure: https://github.com/openstack/keystone/blob/master/keystone/common/kvs/core.py#L10021:24
lifelessjamielennox: now, do you know the test it dies on ?21:24
lifelessjamielennox: (do you see a test starting message and no finish)21:24
morganfainbergbut like i said, likely an @property is the right way21:24
*** mikeoutland has joined #openstack-dev21:25
jamielennoxlifeless: i get swamped with output21:25
jamielennoxbut it's doing a full run if i comment out: /*keystone.tests.contrib.kds.api.test.SimpleTest.test_simple*/21:25
*** thuc has joined #openstack-dev21:25
lifelessjamielennox: at the end of the run21:25
jamielennoxlifeless: going to take a while longer21:26
lifelessoh21:26
lifelessso we should really be using subunit here21:26
morganfainbergayoung, in Juno i'll bumpt the dogpile version in global reqs, which gives us a simple .is_configurred property on the actual dogpile region21:26
jamielennoxi can switch it to testr21:26
jamielennoxor at least ./run_test.sh21:26
lifelessjamielennox: no nneed for run_test21:26
lifelessyou're running with -N21:27
ayoungmorganfainberg, does the otken manager check if it has been configured already21:27
lifelessso just 'testr run --subunit > testlog'21:27
ayoungtoken21:27
morganfainbergayoung, no.21:27
morganfainbergayoung, it should21:27
lifelessjamielennox: ^ which will get us a binary log we can consult21:27
jamielennoxyea i used -N but i can't use the list that way21:27
ayoungmorganfainberg, then why doesn't it blow up21:27
morganfainbergayoung, because it only gets loaded from load_backends21:27
morganfainbergayoung, and applied to the test_case as .token_api21:27
lifelessjamielennox: you can - run_tests.sh -- --load-list foo.list (but we need to disable the colorizer because reasons)21:28
lifelessjamielennox: so - 'testr run --subunit > testlog'21:28
morganfainbergayoung, https://github.com/openstack/keystone/blob/master/keystone/tests/core.py#L38721:28
morganfainbergayoung, we don't set the manager on the test_case itself anywhere.  we do similar to dependency injection in tests21:28
*** emagana has joined #openstack-dev21:28
ayoungmorganfainberg, OK, I can work around it for now21:29
ayoung if 'backend' not in  self._store._region.__dict__:21:29
ayoung            self._store.configure(backing_store=self.kvs_backend, **kwargs)21:29
jamielennoxlifeless: but will this tell us why the test run would have been exiting early? if i've removed the offending test the expected output will be that everything passes21:29
*** amcrn has quit IRC21:30
ayoungmorganfainberg, soooooo  how do we uniquely identify a keystone server from inside that keystone server?21:30
*** cdub has joined #openstack-dev21:30
*** sarob has joined #openstack-dev21:30
*** bswartz has quit IRC21:30
morganfainbergayoung, hm?21:30
morganfainbergayoung, oh, uhmmmmmmmmmm21:30
*** tjones1 has joined #openstack-dev21:30
ayoungmorganfainberg, so, say I am load balancing21:30
morganfainbergayoung, uhhhh i don't think do21:30
*** changbl has quit IRC21:31
morganfainbergayoung, keystone is pretty stateless across the board21:31
jamielennoxlifeless: ok i have a testlog binary which happened too quickly to have been a test run21:31
ayoungand I want each instance to have its own "active page"21:31
*** jcooley_ has quit IRC21:31
ayounghostname?21:31
lifelessjamielennox: so I wanted a baseline21:31
morganfainbergayoung, hostname-pid21:31
lifelessjamielennox: subunit-ls < testlog21:31
jamielennoxlifeless: oh, ok21:31
dolphmayoung: keystone.conf [DEFAULT] public_endpoint21:31
morganfainbergayoung, might run multiple keystones on a server21:31
ayoungbut pid gets recycled21:31
morganfainbergayoung, right, thats why you need 2 items e.g. host and pid21:31
ayoungmorganfainberg, nope, pid is not the right abstraction21:32
morganfainbergayoung, listen-addr-port-pid?21:32
*** mikeoutland has quit IRC21:32
*** tjones has quit IRC21:32
ayoungcuz if a server gets recycled you just lost the old ones...or keep them around as Zombies21:32
*** DinaBelova is now known as DinaBelova_21:32
morganfainbergayoung, uuid generated on startup21:32
ayoungpublic_endpoint is better21:32
morganfainbergayoung, ah ok21:32
morganfainbergayoung, how does that solve the load-balanced issue?21:33
ayoungpublic_endpoint = http://127.0.0.1:%(public_port)s/21:33
morganfainbergyou could have 10 separate keystones behind a single lb?21:33
ayoungmorganfainberg, so...I'd need to expand that out21:33
morganfainbergeach trying to modify the same pages.  or you'll do just page-locking for all updates?21:33
ayoungruh21:33
ayoungwhat do we use that value for21:34
morganfainbergthe endpoint?21:34
morganfainbergwhere clients talk to.  it would be the LB if you're using like HA Proxy or a f5 or something21:34
morganfainbergi think?21:34
*** emagana has quit IRC21:34
jamielennoxlifeless: i ran the wrong list which is why it was short so: http://paste.openstack.org/show/62488/ is the case where it only runs the 14 tests, running the baseline now21:34
lifelessjamielennox: thats the output from subunit-ls ?21:35
*** neelashah has joined #openstack-dev21:36
*** neelashah has quit IRC21:36
jamielennoxyes21:36
morganfainbergayoung, if you're looking at a "I'm a specific keystone process" (e.g. WSGI has multiple keystones that could update the same page?) I'm not sure on the best choice.  - depends on what you consider a single keystone instance21:36
ayoungmorganfainberg, yep....21:36
ayoungand for Apache, it is going to be a separate process each time21:37
*** mst89 has joined #openstack-dev21:37
*** rkukura has joined #openstack-dev21:39
*** mestery has joined #openstack-dev21:39
*** mestery has quit IRC21:40
*** mestery has joined #openstack-dev21:40
*** galstrom_zzz is now known as galstrom21:41
*** kenperkins_ has joined #openstack-dev21:42
dolphmmorganfainberg: ayoung: checking back in; i had no idea what ya'll were talking about a minute ago and i still don't; why are you trying to identify an instance of keystone?21:43
*** dot has quit IRC21:43
ayoungdolphm, multiple reader/writer thing with a KVS backend for Revocation events21:44
morganfainbergdolphm, fewer pages that need explicit locking = less serialization across the multi-reader/writer scenarios21:44
*** armax has left #openstack-dev21:45
*** Gaston_Severina has quit IRC21:45
morganfainbergdolphm, if each keystone only ever needs to do a index page lock in the case it stored a ton of data in it's bucket, (reads w/o write is lockless) less contention21:45
*** dprince has quit IRC21:45
*** sarob has quit IRC21:45
*** kenperkins has quit IRC21:46
*** READ10 has quit IRC21:46
*** peristeri has quit IRC21:48
*** troytoman is now known as troytoman-away21:49
*** gyee has quit IRC21:50
*** doug_shelley66 has quit IRC21:51
*** tjones1 has quit IRC21:51
*** xqueralt has joined #openstack-dev21:51
*** IanGovett1 has quit IRC21:51
*** tjones has joined #openstack-dev21:53
*** jdob has quit IRC21:53
*** jhesketh has joined #openstack-dev21:54
*** tshirtma1 is now known as tshirtman21:54
*** tmclaugh[work] has quit IRC21:54
*** apevec has quit IRC21:54
*** sdake has quit IRC21:55
*** buzztroll has quit IRC21:57
*** sushils has quit IRC21:57
*** buzztroll has joined #openstack-dev21:58
*** rtheis has quit IRC21:58
ayoungdstanek, dolphm, if I were to try and compress the token before signing it,  do we have a preferred mechanism to use?21:58
jamielennoxlifeless: baseline for when you get back: http://paste.openstack.org/show/62492/21:58
*** buzztroll has quit IRC21:59
dolphmayoung: zlib and api change?21:59
*** jprovazn has quit IRC21:59
lifelessjamielennox: ok, so thats truncated vs the full test list right ?22:00
ayoungdolphm, shouldn't bne an API change22:00
*** buzztroll has joined #openstack-dev22:00
ayoungdolphm, it would be an optional token provider and additional logic in ATmiddleware22:00
morganfainbergayoung, LZMA! i mean.. zlib22:00
dolphmayoung: ah, it only affects the X-Subject-Token value, correct?22:00
morganfainbergdolphm, correct, it should only affect that22:01
*** tjones1 has joined #openstack-dev22:01
morganfainbergand... in theory we could use magic number information to detect if it's compressed,22:01
morganfainbergif we wanted to22:01
dolphmi feel like we should have a separate spec for PKI tokens themselves, but it's not an HTTP API22:01
*** godara has quit IRC22:01
*** markmc has quit IRC22:01
ayoungdolphm, yeah22:02
morganfainbergdolphm, a separate spec for all things token22:02
morganfainbergdolphm, not even just PKI22:02
dolphmanyway, i vote stdlib22:02
morganfainbergdolphm, *cough* Juno22:02
ayoungI'm going to 1. compresss, 2 prepend the compresssion algorithm, and then sign it22:02
morganfainbergayoung, sounds reasonable22:02
*** kenperkins_ has quit IRC22:03
*** MaxV has quit IRC22:03
*** neelashah has joined #openstack-dev22:03
ayoungzlib.compress(token_data,0)   I think22:03
*** MaxV has joined #openstack-dev22:03
dolphmayoung: i wouldn't bother making it optional, just do it?22:03
*** tjones has quit IRC22:03
*** kenperkins has joined #openstack-dev22:03
*** godara has joined #openstack-dev22:03
dolphmayoung: why 0?22:03
ayoungdolphm, let me make sure it works, and we can decide22:03
morganfainbergdolphm, i could see a benefit for debugging to not compress22:03
dolphmayoung: actually, you could make the compression level configurable22:03
*** e0ne has quit IRC22:04
ayoungdolphm, yes I could22:04
dolphmayoung: i'd go for like 6-822:04
dolphmpersonally22:04
morganfainbergdolphm, i'd default it to "on" just make it togglable22:04
jamielennoxlifeless: yes so second link is full list, first was truncated22:04
*** david-lyle has quit IRC22:04
ayoungdolphm, I figure speed is far more important, but I'll see what the range is22:04
morganfainbergayoung, 6 for zlib in my experience is a solid place to live for speed/cpu requirements22:04
morganfainbergayoung, 7+ tends to be slower.22:04
dolphmayoung: default it to 9, and let deployments tweak it for speed22:04
ayoungif 0 is much faster than 9, and the size is roughly the same, good enough22:04
dolphmayoung: make users happier in the short term22:04
morganfainbergayoung, likely 3-6 will be close to same size imo22:04
lifelessjamielennox: uhm no, not what I meant22:05
lifelessjamielennox: http://paste.openstack.org/show/62492/ <- does that stop early.22:05
dolphmayoung: go try it and give us results of 0-9 :)22:05
*** jasondotstar has quit IRC22:05
jamielennoxlifeless: no that appears to be a full run22:05
*** sushils has joined #openstack-dev22:05
lifelessjamielennox: so the problem of exiting early didn't occur ?22:05
morganfainbergdolphm, a few years back did a test of gizp, bzip, and lzma, came out to lzma 3 was roughy equiv in speed to i think gzip 8 (way faster than even bzip3) and better compression than bzip 622:05
morganfainbergdolphm, but thats random useless information for this convo :P22:06
jamielennoxlifeless: it occurred in paste.openstack.org/show/62488/22:06
* morganfainberg stops pulling useless trivia out of the air22:06
jamielennoxit 62492 i removed the first test22:06
*** neelashah has quit IRC22:07
ayoungmorganfainberg, so my one req here is that I am going  to use a standard python library if it exists.  I don't want to chase something through requirements22:07
ayounghttp://docs.python.org/2/library/archiving.html22:07
ayoungzlib, gzip, and bzip222:07
morganfainbergayoung, zlib would be my choice22:08
*** cagrev__ has joined #openstack-dev22:08
ayoungthere is a lzma module, but I think it is 3rd party22:08
ayoungthat is what I am planning.  I'll put the algorithm in the front of the token22:08
*** nmagnezi has quit IRC22:08
morganfainbergyeah don't use that22:08
ayoungso once you do the cms verifuy, you can looks to see if the token starts wirh "zlib"  and decompress22:08
*** michchap has joined #openstack-dev22:09
ayoungso if we want lzma in the future, that would go in there, too22:09
dolphmayoung: you might also have to encode utf-8 with zlib; not sure about the others22:09
*** jcooley_ has joined #openstack-dev22:10
dolphmayoung: zlib.compress(json.dumps(token_ref).encode('utf-8'), 6)22:10
ayoungdolphm, thanks22:11
ayoungtrying it now22:11
*** bswartz has joined #openstack-dev22:11
stevemardolphm, ping22:11
dolphmstevemar: pong22:11
*** cagrev_ has quit IRC22:11
dolphmstevemar: it's not time for nachos?22:12
stevemardolphm, so, about that rule mapping, how do you want it used... initialize it with a mapping_ref, call process with an assertion, but what does process return?22:12
*** SumitNaiksatam_ has joined #openstack-dev22:12
stevemardolphm, cause in your example, you were just picking user out as a property22:12
stevemardolphm, no nachos :(22:12
*** danielbruno has quit IRC22:12
*** SumitNaiksatam has quit IRC22:13
*** SumitNaiksatam_ is now known as SumitNaiksatam22:13
dolphmstevemar: so, i was talking to marekd about that this morning, and you weren't online so sadness22:14
dolphmstevemar: this is the notes from the hackathon https://gist.github.com/dolph/5cfa70c02f5b141060c5#token-as-a-result-of-federation22:14
dolphmstevemar: with the exception of "groups" -- i added that this morning22:14
dolphmstevemar: (ignore everything but the JSON example)22:15
dolphmstevemar: and ignore "id"22:15
dolphmstevemar: if mapping returns a dict of user attributes that can be dropped directly into a token, that'd be dandy22:15
*** sdake has joined #openstack-dev22:16
*** marekd is now known as marekd|away22:16
*** jcooley_ has quit IRC22:16
*** jcooley_ has joined #openstack-dev22:17
dolphmstevemar: revised the gist with a specific example!22:17
ttxannegentle: I confirm jeblair's interpretation on the openstack telemetry usage. Sorry -- just read the log again for stuff I missed duringthe heated discussion22:18
stevemardolphm, reading, got bombarded with pings22:18
stevemardolphm, okay, so you want something like... attributes = assertion_processor.process(assertion)22:19
annegentlettx: drafting an email now, and I guess what I have permission to use is "ceilometer module of OpenStack Compute"?22:19
*** doug_shelley66 has joined #openstack-dev22:19
annegentlettx: or probably just "ceilometer module"22:19
annegentlettx: honestly I'm guessing ceilometer and heat aren't well-covered in the docs anyway22:19
stevemardolphm, i'm really confused about how i'm supposed to determine the user and such, from the local objects, without making some assumptions22:20
*** julienvey_ has joined #openstack-dev22:21
*** neelashah has joined #openstack-dev22:21
dstanekayoung: yay! compression22:21
annegentlettx: also trove for icehouse release22:21
annegentlettx: trove module?22:21
dolphmstevemar: ?22:22
ayoungdstanek, yeah, now if I can just figure out where to get zlib from...22:22
ayoung    data = "zlib:"+ zlib.compress(json.dumps(token_data).encode('utf-8'), 6)22:22
ayoungAttributeError: 'module' object has no attribute 'compress'22:22
dolphmayoung: oh also, zlib compression level 0 does not compress anything, it'll make the token bigger :)22:22
ayoungheh22:22
stevemardolphm, right now i just keep track of the local objects, i don't actually look at whats in them22:22
*** CaptTofu has quit IRC22:23
*** mestery has quit IRC22:24
dolphmayoung: dstanek: morganfainberg: compressed lengths for unsigned tokens http://pasteraw.com/4m2l5hsfr656k004sfwmfcujhw4ki9w22:24
*** ijw_ has joined #openstack-dev22:25
ayoung6 it is22:25
dolphmayoung: ++ reasonable default22:25
*** amcrn has joined #openstack-dev22:25
ayoungdolphm, do I need to somehow add zlib to my venv?22:26
*** markmcclain has quit IRC22:26
ayoungIts base python, and it should inherit the native libs from the base install right?22:26
*** eglynn-lunch has quit IRC22:26
ayoungI can do it from a command line python prompt, but not from the code in the test22:27
dolphmayoung: no, it's standard library http://docs.python.org/2/library/zlib.html22:27
*** Alexei_987 has quit IRC22:27
dolphmayoung: maybe something is overriding it's namespace?22:27
ayoungAttributeError: 'module' object has no attribute 'compress'22:27
ayoungprobably22:27
*** slagle has joined #openstack-dev22:28
ttxannegentle: "ceilometer component of openstack" is certainly ok. And according to section 4.1, it's also possible that "openstack X" would be fair use22:28
ayoungUnicodeDecodeError: 'utf8' codec can't decode byte 0x9c in position 6: invalid start byte22:28
ayoungOK, that is better22:28
*** ijw has quit IRC22:28
dolphmayoung: zlib.__file__ ?22:28
ttxannegentle: at least until proven otherwise22:28
annegentlettx: if "openstack X" is fair use then I don't wanna make all the changes :)22:28
ayoungdolphm, yeah, I had  created a zlib.py file in the same dir, as an alternitave provider, then abandonded, just needed to cleanup22:28
*** pcm_ has quit IRC22:28
dolphmayoung: lol22:29
*** gmurphy_ is now known as gmurphy22:30
dstanekayoung: that's why i like absolute_import22:30
*** tjones1 has quit IRC22:31
ayoungdstanek, yeah.22:31
*** IanGovett has joined #openstack-dev22:31
dstanekayoung: have you tried to see what the speed difference is for each compression level?22:32
*** michchap has quit IRC22:32
ayoungdstanek, nope. Don't care22:32
ayoungpremature optimization is the root of all evil  -- Knuth22:32
*** tjones has joined #openstack-dev22:32
trevorjdstanek: From NEO?22:32
dstanekayoung: :-) i think that's out of context22:32
ayoungdstanek, heh...right now I just need to make the tokens fit22:33
dstanekayoung: i'm not saying you should change, i'm just curious22:33
ttxannegentle: ianal, but you could ask the foundation lawyer to check with the CURRENT rules22:33
*** markmcclain has joined #openstack-dev22:33
ttxannegentle: rules that might just let us slap "openstack" labels to whatever we work on.22:34
*** tjones has quit IRC22:35
lifelessjamielennox: please try 'testr run --analyse-isolation 2>&1 > isolation.log'22:36
jamielennoxlifeless: on the short one or the full one?22:37
dstanektrevorj: why yes i am22:37
*** tjones has joined #openstack-dev22:38
lifelessjamielennox: do a full run to seed it (unless you just did one) then run the isolation analyser22:38
*** gcha has quit IRC22:39
*** dims has quit IRC22:39
*** cnesa has joined #openstack-dev22:40
*** dkranz has quit IRC22:41
*** mriedem has quit IRC22:42
*** sgordon has joined #openstack-dev22:43
jamielennoxlifeless: ok, just to show the issue though i pushed https://github.com/jamielennox/keystone/commit/c63505649814512501cf1d55a253320f1e33be1f22:44
jamielennoxin there i comment out keystone/tests/contrib/kds/api/test.py test_simple and i pass22:45
jamielennoxlifeless: if i uncomment it then i get a short run22:46
*** mfer has quit IRC22:46
*** cnesa has quit IRC22:46
*** eharney has quit IRC22:47
*** jhesketh__ has joined #openstack-dev22:47
*** joesavak has quit IRC22:48
*** michchap has joined #openstack-dev22:49
*** gokrokve has joined #openstack-dev22:49
*** cnesa has joined #openstack-dev22:50
*** dot has joined #openstack-dev22:51
*** sweston has joined #openstack-dev22:52
ayoungI need to create the sample data.  I assume I am ok with taking sample_token.json and doing gzip on it?22:53
*** xqueralt has quit IRC22:53
ayoungactually, let me see if I can shell out to python to ensure I am using the same zlib22:54
*** dot has quit IRC22:55
*** dims_ has joined #openstack-dev22:55
*** thuc has quit IRC22:55
*** thuc has joined #openstack-dev22:56
jamielennoxlifeless: isolation: http://paste.openstack.org/show/62496/22:56
*** mfer has joined #openstack-dev22:57
*** sweston has quit IRC22:57
*** mfer has quit IRC22:57
*** mikeoutland has joined #openstack-dev22:58
zanebdolphm: shardy pointed out that https://review.openstack.org/#/c/57481/ is only a docs change (even though it is marked as closing the bug)22:58
*** mikeoutland has quit IRC22:58
*** dbalog has left #openstack-dev22:59
zanebdolphm: the actual impelmentation is waiting on https://review.openstack.org/#/c/56243/22:59
*** godara has quit IRC22:59
zanebso that blueprint should be in Needs Code Review, not Implemented23:00
lifelessjamielennox: right, so running just those two tests together will fail23:00
*** thuc has quit IRC23:00
*** godara has joined #openstack-dev23:00
lifelessjamielennox: put both the names in a list file, and run that with pdb with testtools.run23:00
*** topol has quit IRC23:01
*** harlowja is now known as harlowja_away23:01
jamielennoxlifeless: Ran 2 tests in 0.193s - OK23:03
lifelessjamielennox: *blink*23:03
lifelessjamielennox: testr when it did that had the second fail23:03
*** burt1 has quit IRC23:04
*** jmckind has quit IRC23:04
*** AlanClark has quit IRC23:04
jamielennoxhmm, when i do it with  testr run --load-list all_tests2 it fails23:04
jamielennox(with no info)23:04
*** godara has quit IRC23:04
jamielennoxbut python -m testtools.run discover --load-list all_tests2 succeeds23:05
*** stevemar has quit IRC23:05
*** vkmc has quit IRC23:05
*** godara has joined #openstack-dev23:05
*** krotscheck_sick has quit IRC23:06
*** branen_ has quit IRC23:08
jamielennoxlifeless: also if i keep test_simple and start removing other tests further down the same thing happens - it will run one additional test and then fail23:09
*** mikeoutland has joined #openstack-dev23:09
*** mikeoutland has quit IRC23:09
jamielennoxie it will run all the keystone.tests.contrib.kds.* tests and then fail on whatever comes next23:10
*** jgrimm_ has quit IRC23:11
*** clayb has quit IRC23:11
lifelessjamielennox: so I think you have something exiting the process hard23:11
*** prad_ has quit IRC23:12
*** patelna has joined #openstack-dev23:12
*** Gordonz has joined #openstack-dev23:13
*** Gordonz has quit IRC23:13
*** Gordonz has joined #openstack-dev23:13
jamielennoxlifeless: ok, it's weird that that would come to the surface from what is a reasonably simple change, does pecan do an exit for any reason23:13
*** mdomsch has quit IRC23:13
*** harlowja_away is now known as harlowja23:13
jamielennox?23:13
lifelessjamielennox: if we can just get it down to a simple interaction you can debug23:13
lifelessjamielennox: so anyhow, if you have *any* test list that exits in a reasonable time23:14
*** FunnyLookinHat has quit IRC23:14
lifelessjamielennox: run the whole thing under pdb23:14
*** kolesovdv has joined #openstack-dev23:14
lifelesse.g. python -m pdb ...path-to-run.py and then run discover ...23:14
*** dstanek has quit IRC23:14
*** jecarey has quit IRC23:14
jamielennoxlifeless: so testtools.run doesn't show an error and my understanding was that testr and pdb was a bad mix23:15
jamielennoxobviously i'm debugging testr itself this time23:15
lifelessjamielennox: nope23:16
*** zzelle_ has quit IRC23:16
lifelessjamielennox: I thought you said testtools.run could show the error ?23:16
lifelessjamielennox: that you triggered errors by running python -m testtools.run discover ?23:16
jamielennoxlifeless: testtools.run will exit after only 14 tests - but it will show an OK at the end23:17
*** mestery has joined #openstack-dev23:17
*** mestery has quit IRC23:17
jamielennoxthough $? gives 123:17
jamielennoxRan 14 tests in 0.995s - OK23:17
*** mestery has joined #openstack-dev23:17
*** jayg is now known as jayg|g0n323:18
jamielennoxso something is making it quit but it prints a success message23:18
*** sarob has joined #openstack-dev23:18
lifelessjamielennox: yeouch, fun :/23:18
jamielennoxhmm, looking at that though 0.995s is way to fast - it should take about 30sec23:19
*** mikeoutland has joined #openstack-dev23:19
jamielennoxor that's what ./run_tests.sh shows23:19
lifelessjamielennox: I am thoroughly confused.23:19
*** pcm_ has joined #openstack-dev23:19
lifelessjamielennox: lets start from basics. Stop using run-tests.sh, its muddying things up.23:20
jamielennoxlifeless: imagine how i feel :) that's why i came to you23:20
*** neelashah has quit IRC23:20
*** mikeoutland has quit IRC23:20
jamielennoxlifeless: can you reproduce it?23:20
lifelessjamielennox: python -m testtools.run discover -t ./ ./keystone/tests23:20
lifelessjamielennox: no, and I have two criticals on my plate today already23:20
lifelesssorry23:20
jamielennoxok23:20
*** thuc_ has joined #openstack-dev23:21
lifelessjamielennox: one thing23:21
lifelessjamielennox: run_tests is running in parallel.23:21
lifelessjamielennox: that may be the distinguishing factor23:21
*** ijw has joined #openstack-dev23:21
*** kevinconway has quit IRC23:21
lifelessjamielennox: so another thing to try is testr run --parallel23:21
lifelessand see if that reproduces23:22
*** buzztroll has quit IRC23:22
jamielennoxlifeless: i don't think we have parallel tests but i'm not sure23:22
*** lbragstad has quit IRC23:22
*** buzztroll has joined #openstack-dev23:22
*** MaxV has quit IRC23:23
jamielennoxok discover: http://paste.openstack.org/show/62497/23:23
jamielennoxnote that it runs way to fast to be running those tests23:23
*** thomasem has quit IRC23:24
*** ijw_ has quit IRC23:24
*** markmcclain has quit IRC23:25
*** rcleere has quit IRC23:26
*** sushils has quit IRC23:26
*** sarob_ has joined #openstack-dev23:27
*** rfolco has joined #openstack-dev23:27
jamielennoxlifeless: did you try to reproduce and it didn't work or didn't try? i started with a new venv so i didn't think it was my machine, if it's just me i can try something else23:27
*** sarob has quit IRC23:28
*** mikeoutland has joined #openstack-dev23:28
*** sushils has joined #openstack-dev23:28
*** mriedem has joined #openstack-dev23:29
*** mriedem has quit IRC23:29
*** ekhugen has quit IRC23:29
*** devoid has quit IRC23:29
*** sheeprine has quit IRC23:29
lifelessjamielennox: I have not tried23:30
jamielennoxok23:30
*** Shaan7 has quit IRC23:30
*** tongli has quit IRC23:30
*** mriedem has joined #openstack-dev23:30
*** flaper87 is now known as flaper87|afk23:31
*** sgordon has quit IRC23:32
*** sgordon has joined #openstack-dev23:34
*** atiwari has quit IRC23:35
*** byeager has quit IRC23:35
*** tjones1 has joined #openstack-dev23:35
*** rfolco has quit IRC23:36
*** byeager has joined #openstack-dev23:36
*** tjones has quit IRC23:38
*** yamahata has quit IRC23:38
*** achampion has quit IRC23:38
*** thuc_ has quit IRC23:38
SpamapSsoren: i can haz uvirtbot plzzzzz23:39
*** yamahata has joined #openstack-dev23:40
*** tdruiva has quit IRC23:40
*** andreaf has joined #openstack-dev23:42
*** bauzas has quit IRC23:42
*** baoli has quit IRC23:42
*** andreaf has quit IRC23:43
*** mikeoutland has quit IRC23:44
*** godara has quit IRC23:44
*** jruzicka has quit IRC23:45
*** byeager has quit IRC23:45
*** godara has joined #openstack-dev23:45
*** thuc has joined #openstack-dev23:46
*** sgordon has quit IRC23:48
*** cnesa has quit IRC23:48
*** atiwari has joined #openstack-dev23:48
*** tdruiva has joined #openstack-dev23:48
*** tdruiva has quit IRC23:50
*** patelna has quit IRC23:51
kdbrierlyAre there any known bugs with neutron not updating security rules when new instances are added?23:52
*** datamatic has joined #openstack-dev23:52
*** thuc_ has joined #openstack-dev23:53
*** cnesa has joined #openstack-dev23:53
*** sweston has joined #openstack-dev23:53
*** MaxV has joined #openstack-dev23:53
*** dubsquared has joined #openstack-dev23:54
*** markmcclain has joined #openstack-dev23:54
*** yamahata has quit IRC23:54
*** patelna has joined #openstack-dev23:54
*** thuc has quit IRC23:56
*** kenperkins_ has joined #openstack-dev23:57
*** branen has joined #openstack-dev23:57
*** galstrom is now known as galstrom_zzz23:57
*** sweston has quit IRC23:57
*** sgordon has joined #openstack-dev23:58
*** vladikr has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!