Friday, 2013-09-20

*** gongysh has joined #openstack-dev00:00
lbragstadok, right.00:00
lbragstadwant me to add a comment to that?00:00
*** matsuhashi has joined #openstack-dev00:00
jamielennoxinterestingly you can patch MySQLdb and psycopg, i wonder why we aren't donig that00:00
lbragstadyeah, I saw that too, I didn't know that00:00
CaptainMorganjamielennox, because we didn't do it :P00:00
CaptainMorgani don't really know though00:01
jamielennoxCaptainMorgan: all the problems they have with mysqldb and eventlet - seems like that would have been a solution00:01
*** danwent has joined #openstack-dev00:01
CaptainMorganjamielennox, fair point. but it could introduce all sorts of other… fun00:01
CaptainMorganhm.00:02
CaptainMorganmaybe this test is going to work first try00:02
CaptainMorgan(haha yah, right)00:02
jamielennoxlbragstad: i would add MySQLdb and psycopg to the list you pass to monkey_patch with =false and say in a comment that this is the complete listing of what is supported by monkey_patch00:02
jamielennoxthat way default is irrelevant00:03
lbragstadjamielennox: ok, yeah I like that idea. I'll respin that.00:03
CaptainMorgandolphaaarrrggghh, that name is still awesome for today00:03
AyoungTheRedjamielennox, we can discuss here00:04
jamielennoxpshh, the pirate thing was so yesterday00:04
roaetCaptainMorgan: I think I may have got help from someone in neutron, if it turns out to be correct I will blog and link you. Thank you for the help you gave.00:04
*** herndon has joined #openstack-dev00:04
lbragstadjamielennox: I missed the whole pirate thing apparently :)00:05
*** reed has quit IRC00:05
*** reed has joined #openstack-dev00:06
*** senk has quit IRC00:06
jamielennoxit falls on my anniversary - unfortunately it's sometimes the pirate thing that reminds me of the anniversary rather than the other way around00:06
CaptainMorganroaet, nice00:06
*** michchap has quit IRC00:06
*** rwsu has quit IRC00:07
CaptainMorganlbragstad, i kind of missed it too, except when i saw AyoungTheRed earlier today00:07
AyoungTheRedAvast and Ahoy ye lubbers!00:07
jamielennoxAyoungTheRed: ok, so i take it you saw the fleshed out version of the blueprint?00:07
lbragstadjamielennox: well... a reminder is a reminder!00:07
AyoungTheRedjamielennox, nah, just coming back to work now...00:07
AyoungTheRedlet me look00:07
jamielennoxi haven't changed it since (my) yesterday00:07
jamielennoxif you saw the etherpad it hasn't changed00:08
AyoungTheRedhttps://blueprints.launchpad.net/devstack/+spec/devstack-https  ?00:08
jamielennoxyep, and the linked etherpad00:09
*** michchap has joined #openstack-dev00:09
*** thomasm has quit IRC00:09
AyoungTheRedjamielennox, ah, no, I didn't see the linked etherpad.00:09
jamielennoxok, so my first thing is for this blueprint i'm not talking about how to do certificate generation - all i want to do is seed certificates into there right place00:10
AyoungTheRedjamielennox, OK,  gave it a quick read...so I think that I would say:00:10
AyoungTheRed1.  SSL_ENABLED_SERVICES good00:11
AyoungTheRed2.  Use Cert monger to manage them instead of the envvars00:11
jamielennoxso the way i'm testing this currently is putting KEYSTONE_SSL_CA KEYSTONE_SSL_KEY KEYSTONE_SSL_CERT with files into localrc00:11
AyoungTheRedjamielennox, you think people want to manage them by hand?00:11
jamielennoxno, but i think that if we work with the ENV vars then generation just becomes a matter of assigning the right variables00:12
jamielennoxand i think there are situations where you want to have certain certificates used00:12
AyoungTheRedjamielennox, I have a feeling it is going to be duplicate work with Certmonger,00:12
jamielennoxso i did some reading on certmonger - to my understanding it's got not a lot to do with this other than generation00:13
AyoungTheRedjamielennox, I would think that the services should have a default location specified in their config files, and we should honor those00:13
AyoungTheRedand getting the certs into the right locations...00:13
AyoungTheRedso you think that this and certmonger are complementary?00:14
jamielennoxi think if we say that certmonger is the only way we do this it will get rejected00:14
jamielennoxi think they are complementary as to my understanding certmonger can still generate PEM certs00:14
AyoungTheRedwell, I would write it up in the blueprint, and have the discussion around that.00:14
jamielennoxor can still manage PEM certs00:14
AyoungTheRedYeah,00:14
AyoungTheRedso the question is if we need explicit variables saying where the certs go, and, if we have them, what do we do with them00:15
jamielennoxso whether the certs come from certmonger, the already in place cert generation stuff for tls-proxy or some outside source won't matter00:15
jamielennoxgo? currenlty i'm not putting them anywhere. The path in the variable should be server readable00:15
jamielennoxthat would be a seperate devstack setting00:16
jamielennoxso you say generate with certmonger, it creates a folder a new db and ca and generates some certs00:16
jamielennoxthose values seed the variables and the whole show carries on00:16
AyoungTheRedjamielennox, can we get it down to just SSL_ENABLED_SERVICES and then use the service config files to state where the files are?00:16
AyoungTheRedwe can potentially use the same certificates for multiple services, so having 3 variables per service seems like a lot to manage00:17
jamielennoxthat's down somewhere in future optimizations00:18
jamielennoxyes, i agree and i'm not worried about it right now00:18
*** hemanth has quit IRC00:18
jamielennoxwhat do you mean "use the service config files to state where the files are?" the service config file are always going to be where these variables end up, the ENV vars thing is just how you let devstack no what to put in them00:19
jamielennoxwow, just used no instead of know00:19
AyoungTheRedjamielennox, but they have default values already.  For example, keystone knows where to put its ssl certs00:19
AyoungTheRedhttps://github.com/openstack/keystone/blob/master/keystone/common/config.py#L9600:20
*** lucasagomes has quit IRC00:20
AyoungTheReddevstack should use those variables00:20
AyoungTheRedvalues00:20
*** 16WAA3R0O has joined #openstack-dev00:20
AyoungTheRedI'd just say have the SSL_ENABLED_SERVICES and then put the files where the the config files say they should go.00:21
*** sarob_ has joined #openstack-dev00:22
AyoungTheRedjamielennox, I'm envisioning this being something that is eventaully automated: a service has a standard way to tell certmonger:  put my files here:00:22
AyoungTheRedI think systemd already has an abstraction along those lines.  Ask nalin, though00:22
jamielennoxin the case of generating then you have to create a folder and ca, generate a bunch of certificates copy them into the place expected by the server and still enable the variables in the config file00:22
jamielennoxwhy not just point the service to where the certs were generated00:23
AyoungTheRedagain, all cermonger stuff.00:23
*** nosnos has joined #openstack-dev00:23
jamielennoxfor example in swift there is no ssl enable config - the presence of the cert_file and key_file variables says you should use ssl00:23
jamielennoxif i have to enable the cert_file and key_file variables with the default values - why not just point them at the place where the certificates actually live?00:23
*** esheffield has quit IRC00:24
lbragstadjamielennox: respun and comment added: https://review.openstack.org/#/c/47444/00:24
*** sarob has quit IRC00:24
AyoungTheRedjamielennox, tell you what, can you give certmonger a test run, and see if it changes how you would write the rest of the code?  If you find out that it really does make no difference, I'll approve your current approach.  Deal?00:25
jamielennoxlbragstad: +100:25
lbragstadjamielennox: thank you sir00:26
AyoungTheRedlbragstad, looking00:26
jamielennoxAyoungTheRed: that patch still needs some fixes but sure00:26
*** sarob_ has quit IRC00:26
AyoungTheRedlbragstad, so...what if they add an additional parameter to monkeypatch on us?00:26
lbragstadAyoungTheRed: looks like it00:26
lbragstadAyoungTheRed: https://bitbucket.org/eventlet/eventlet/src/57e2f608e0dd5988712c0fda50e865a4ff8f887a/eventlet/patcher.py?at=default#cl-19700:27
AyoungTheRedlbragstad, pretty sure the mysql and psycodb opnes weren't there when last I looked....00:27
jamielennoxAyoungTheRed: it will default to false00:27
lbragstadjamielennox: and I were discussing earlier00:27
AyoungTheRedare you sure all=false is no longer supported?00:27
lbragstadAyoungTheRed: here it is00:27
lbragstadhttp://eventlet.net/doc/basic_usage.html#patching-functions00:27
*** markmc has quit IRC00:27
AyoungTheRedlbragstad, I read it...but wasn't sure if you had definitively decided that.00:27
AyoungTheRedlbragstad, nah, don't trust the docs.  Read the code00:28
lbragstadAyoungTheRed: ok, yeah because another doc saying something different, or doens't list the all option00:29
jamielennoxAyoungTheRed: all is supported it acts as an explicit default value, if not provided the fact that you are saying to specifically patch certain modules means it will default to False00:29
lbragstadAyoungTheRed: figured being explicit offered better readability00:29
jamielennoxnot to mention if they were explicitly laid out like that before you'd think someone would notice 'why is select not patched?'00:30
lbragstadjamielennox: +100:31
AyoungTheRedlbragstad, I like the explicit list, just reading the code to see if we still want all=False to catch any others00:31
jamielennoxmind you it makes me wonder why MySQLdb is not patched - but i don't want to deal with the headache of figuring that out00:31
*** spzala has quit IRC00:31
lbragstad:)00:31
lbragstadI was unaware of psycopg and MySQLdb00:31
*** slagle has quit IRC00:31
lbragstaduntil jamielennox pointed them out00:31
AyoungTheRedhttp://fpaste.org/40882/13796371/00:32
jamielennoxi am gusessing that psycopg != psycopg2 because i understood pg and eventlet were ok00:32
AyoungTheRedactually, I cut off the interesting part00:32
jamielennoxAyoungTheRed: it's lined above already00:32
*** sthaha has joined #openstack-dev00:33
*** sthaha has quit IRC00:33
*** sthaha has joined #openstack-dev00:33
AyoungTheRedhttp://fpaste.org/40883/37195137/00:33
AyoungTheRedjamielennox, I thought we were behind the mainline on evetlet, though...I was looking at what is installed on F19.  Cuz I'm paranoid.  Especially since it looks like this code has changed since last I browsed it00:34
AyoungTheRedbut am I paranoid enough?00:34
jamielennoxlbragstad: now that i think about it, it might be worth checking out when psycopg and MySQLdb were add to the function if it's after our supported eventlet version you might need to do all=False and just comment those two00:35
*** senk has joined #openstack-dev00:36
AyoungTheRedlbragstad I think your code is ok...the F19 version is pretty conservative.  python-eventlet-0.12.0-1.fc19.noarch   upstream is a o.1500:36
jamielennoxlbragstad: global requirements are >= 0.13 which is this file: https://bitbucket.org/eventlet/eventlet/src/d358c9a8cbdbe7112651f072e0da259fd6c4b917/eventlet/patcher.py?at=0.13#cl-19700:37
jamielennoxso it's fine00:37
AyoungTheRedat least they got off of mercurial only....00:37
lbragstadAyoungTheRed: jamielennox ok sounds good00:37
AyoungTheRedI can ack00:37
lbragstadthanks for looking at that00:38
AyoungTheRedjamielennox, added you to https://review.openstack.org/#/c/33473/00:39
jamielennoxAyoungTheRed: will the certmonger selfsigned be enough to satisfy or do i need to do a full IPA linkup?00:39
AyoungTheRedselfsigned00:40
AyoungTheRedjamielennox, IPA would probably be an extension of the cermonger selfsigned approach00:40
jamielennoxthat was my thought - and i don't want to have to figure out how that works yet00:41
jamielennoxAyoungTheRed: ughh, they are doing this with httplib00:41
*** sdake_ has quit IRC00:42
jamielennoxand they have eventlet it the client00:42
AyoungTheRedjamielennox, yeah. I mentioned that in an earlier review.  But they have to00:42
AyoungTheRedeventlet in the client?  I missed that00:43
AyoungTheRedoh, yeah, that was pre-existing00:44
*** sdake_ has joined #openstack-dev00:44
AyoungTheRedanyway, the SSL compression thing is a pretty big deal.  They need to fix that in requests before swift can move over to it00:44
jamielennoxwhat is happening in requests?00:44
*** senk has quit IRC00:45
AyoungTheRedjamielennox, lookat my discussion earlier in the review...patch 9ish00:45
AyoungTheRedno way to turn off ssl compression.  I don;'t know if they submitted a fix for that upstream yet, but enabling ssl in httplib2 since they are already using it seems like a reasonable stopgap00:46
*** dolphaaarrrggghh has quit IRC00:47
CaptainMorgangarhyee, ping00:47
jamielennoxAyoungTheRed: hmm, i'll have a look into if that is correct (i assume they are correct)00:48
*** aeperezt has quit IRC00:48
*** patelna has quit IRC00:48
*** vipul is now known as vipul-away00:48
AyoungTheRedjamielennox, anyway, for certmonger, the intial allocation should be something like getcert-request  -F {name}_SSL_CERT  -k {name}_SSL_KEY  so maybe we do start with what you have, and then figure out how to populate those valus from the config files and options...it would be great if we could actually query the config exteranal to the service.00:50
*** faramir has joined #openstack-dev00:51
AyoungTheRedI am really wishing devstack were in Python...00:52
*** thomasm has joined #openstack-dev00:52
CaptainMorganAyoungTheRed, ++ i wish that quite often thesedays00:52
CaptainMorganAyoungTheRed, simply for internal use cases, not even for what you and jamielennox  are looking at00:53
*** vipul-away is now known as vipul00:53
*** Ryan_Lane has quit IRC00:54
*** dolphaaarrrggghh has joined #openstack-dev00:54
AyoungTheRedCaptainMorgan, the idea of slowly slipping python in there as helper functions is more and more tempting every day00:54
*** Ryan_Lane has joined #openstack-dev00:55
CaptainMorganAyoungTheRed, hehe00:55
CaptainMorgandolphaaarrrggghh, ping00:55
dolphaaarrrggghhCaptainMorgan: pong00:55
dolphaaarrrggghhCaptainMorgan: weren't we supposed to merge something today00:56
CaptainMorgandolphaaarrrggghh, when writing a SQL Migrate test, do i need to initialize a new metadata object before instantiating the table object with autoload if columns change?00:56
*** Ryan_Lane has quit IRC00:56
*** Ryan_Lane1 has joined #openstack-dev00:56
CaptainMorgandolphaaarrrggghh, i'm addressing the last of bknudson's comments00:56
CaptainMorganthe sql upgrade test keeps loading the wrong version of the table.00:56
CaptainMorganso, the test can't pass00:56
jamielennoxthey have a good point though, bash is supposed to be somewhat equivalent to what an admin would do and devstack is fairly heavily commented, python would just be another script that does some magic00:58
dolphaaarrrggghhCaptainMorgan: umm, i think i always instantiate it first, but it almost sounds like you're trying to do something implicitly that should be explicit?00:58
jamielennoxAyoungTheRed: regarding "getcert-request  -F {name}_SSL_CERT  -k {name}_SSL_KEY" i think you have it backwards, but i'll code it up and show you what i mean00:58
CaptainMorgandolphaaarrrggghh, well i'm doing self.updgrade(<version>) insert data self.upgrade(<next version>) and then instantiate the table object, when i do the query, the new column isn't present00:59
CaptainMorgandolphaaarrrggghh, this is in the context of the SqlMigrateBase tests00:59
*** danwent has quit IRC01:00
CaptainMorgandolphaaarrrggghh, and the converse (downgrade test) can't do the select because the old column is still showing up on the table object01:00
* CaptainMorgan curses ORM when it doesn't work intuitively.01:00
CaptainMorganI guess i could stop trying to use it as an ORM and just use it as direct SQL execute mechanism (since it's tests only)01:01
*** Ryan_Lane1 is now known as Ryan_Lane01:03
*** Ryan_Lane has joined #openstack-dev01:03
*** dvarga has joined #openstack-dev01:04
*** Ryan_Lane has quit IRC01:04
AyoungTheRedjamielennox, backwards?  I thought I was agreeing with you.  You need to know where they go, so you tell certmonger.  Certmonger will then create them if required.01:06
*** dvarga has quit IRC01:06
AyoungTheRedso devstack will have that set of variables, and will call certmonger to do the allocation01:06
jamielennoxno because they won't be supplied if they aren't available01:07
jamielennoxso if not (SSL_CERT and SSL_KEY ):01:07
garhyeeCapainMorgan, sorry, I was afk01:08
garhyeewhat's up01:08
jamielennoxgetcert-request -F keystone.cert -k keystone.key01:08
jamielennoxKEYSTONE_SSL_CERT = `pwd`/keystone.cert01:08
*** jab416171 has quit IRC01:09
jamielennoxanyway i'll write it and show you01:09
*** otherwiseguy has joined #openstack-dev01:09
CaptainMorgangarhyee, i think i figured it out01:09
CaptainMorgangarhyee, was struggling with a migrate test.01:09
garhyeeah ok01:10
garhyeejust blame AyoungTheRed, standard operating procedure :D01:10
CaptainMorgangarhyee, dolphaaarrrggghh, I should have another patchset to address bknudson's comments for the tenantId cleanup stuff in a couple minutes01:11
CaptainMorgani'll let you know when it01:11
CaptainMorgan's posted so i can get some eyes on it01:11
* garhyee is GTFBT code review01:11
CaptainMorganGTfBT? whats the BT standfor?01:12
garhyeeback to01:12
CaptainMorganahh.01:12
CaptainMorgani seeeeeee01:12
*** lcheng has quit IRC01:14
CaptainMorganugh.  i think i just realized i should have made something a class method instead of static.01:16
*** novas0x2a|laptop has quit IRC01:16
*** mestery has joined #openstack-dev01:18
*** stevemar has joined #openstack-dev01:22
*** sdake_ has quit IRC01:23
garhyeeCaptainMorgan, https://review.openstack.org/#/c/45903/01:25
garhyeenot sure if I understand your concern01:25
CaptainMorganlooking now01:25
garhyeewe don't reissue token on validation01:25
CaptainMorgangarhyee, isn't he asking for a mechanism to say "validate this token, but return the data w/o catalog"?01:26
garhyeeyes01:26
*** cthulhup has joined #openstack-dev01:26
CaptainMorganso, with a PKI token, you'd either have bogus data returned or need for a new token to be issued01:27
garhyeePKI tokens can be validated either locally or over the wire01:27
AyoungTheRedjamielennox, is the requests library going to let us use NSS for the certs, or is it openssl specific?  I think this is why the FreeIPA project ended up using libcurl01:27
CaptainMorgansince you're changing the content of the token01:27
jamielennoxAyoungTheRed: it requires a PEM cert01:27
CaptainMorganvalidate returns the content of the token in json01:27
garhyeeCaptainMorgan, token validation, over the wire, does not check for signature01:27
jamielennoxAyoungTheRed: oh underneath - i'm not sure i'm pretty sure it uses openssl01:28
*** dstanek has joined #openstack-dev01:28
garhyeewe merely doing a lookup of the hashed token ID01:28
CaptainMorgangarhyee, ok.01:28
CaptainMorgangarhyee, i was assuming this would be something like "Validate token" and take that info to consitute something that gets passed into auth-token01:29
AyoungTheRedjamielennox, OK,  I can get a PEM cert, but suspect that this will be an issue for the NSSification01:29
jamielennoxAyoungTheRed: it's not a requests thing, that would be a urllib3 thing01:29
CaptainMorgangarhyee, then i'll remove the -1 in a short bit here.01:29
garhyeeno, validate toke over the wire basically means 1) is the token still exist, and 2) return the token data01:29
*** adjohn has quit IRC01:30
*** dkranz has joined #openstack-dev01:30
garhyeeCaptainMorgan, cool, thanks01:30
CaptainMorgangarhyee, right.  i'm curious the point of not passing the catalog along in that case. short of just a little less data on the wire.01:30
CaptainMorgangarhyee, but i could see people asking for that.01:30
*** cthulhup has quit IRC01:30
garhyeebecause a large service catalog will push PKI tokens over the limit01:31
CaptainMorganlimit of?01:31
garhyeemost servers have a limit on 8K header01:31
garhyeelimit of01:31
*** mestery has quit IRC01:31
CaptainMorganbut, we already passed the token via header in.01:31
CaptainMorganand the data comes back json?01:32
garhyeecorrect01:32
CaptainMorganso. how is that affecting the 8k header on validate?01:32
garhyeebut we are setting the service catalog in the header in auth_token middleware01:32
*** sarob has joined #openstack-dev01:32
CaptainMorganwe are?01:33
garhyeeyes :)01:33
CaptainMorganbut authtoken doesn't wire validate pki tokens…01:33
jamielennoxAyoungTheRed: it's more than that really the whole python ssl stack is set up to emulate openssl, not even httplib or inbuilt ssl will let you do nss01:33
CaptainMorganugh, i'm just confused here.01:33
*** networkstatic_ has joined #openstack-dev01:33
*** networkstatic_ has quit IRC01:33
garhyeehttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L90301:34
AyoungTheRedjamielennox, I know they used libcurl in freeipa. I just haven't looked that deeply yet01:34
AyoungTheRedjamielennox, but, so far, so goo01:34
AyoungTheRedd01:34
CaptainMorgangarhyee, i'll look in a sec, trying to debug sqlalchemy bug in my code ;)01:34
*** networkstatic has quit IRC01:34
garhyeeCaptainMorgan, we need to make both middleware and API changes to optionally opt-out of service catalog01:34
*** rnirmal has joined #openstack-dev01:35
garhyeeAyoungTheRed, are you making Keystone a CA service? :)01:36
*** thomasm has quit IRC01:36
*** sarob has quit IRC01:37
*** jhesketh has quit IRC01:40
*** 16WAA3R0O is now known as jhesketh01:40
*** jhesketh__ has joined #openstack-dev01:40
*** stevemar has quit IRC01:40
*** senk has joined #openstack-dev01:41
*** reed has quit IRC01:42
*** erkules_ has joined #openstack-dev01:42
*** angdraug has quit IRC01:44
*** erkules has quit IRC01:45
CaptainMorgangarhyee, ok. so the goal with this change is to just not pass the catalog along so we don't set a header.01:45
*** senk has quit IRC01:45
CaptainMorgangarhyee, i think my eyes are going cross-eyed :P but you've convinced me there is a reason for the change.01:46
*** stevemar has joined #openstack-dev01:46
*** dsirrine has joined #openstack-dev01:46
CaptainMorgangarhyee, -1 removed.01:46
garhyeeCaptainMorgan, thanks01:48
*** hemanth has joined #openstack-dev01:48
*** hemanth has quit IRC01:49
*** neelashah has joined #openstack-dev01:50
*** Tross has joined #openstack-dev01:51
CaptainMorgangarhyee / dolphaaarrrggghh, https://review.openstack.org/#/c/46207/01:52
CaptainMorgani _think_ i've covered everything now.01:52
garhyeelooking01:52
*** hemanth has joined #openstack-dev01:52
CaptainMorganthis one has made my head hurt a couple times :P01:53
*** herndon has quit IRC01:53
AyoungTheRedgarhyee, no, I am not making Keystone a CA service.  We are going to make Keystone and all the other services consume a real CA01:55
garhyeeAyoungTheRed, with OCSP support and everything?01:55
CaptainMorganAyoungTheRed, that could be quite useful01:56
AyoungTheRedgarhyee, Dogtag...by way of FreeIPA01:56
garhyeenice!01:56
AyoungTheRedhttp://pki.fedoraproject.org/wiki/PKI_Main_Page01:56
AyoungTheRedgarhyee, right now I am redoing this in Python http://adam.younglogic.com/2013/09/register-vm-freeipa/01:57
AyoungTheRedgarhyee, but jamielennox is looking into setting up SSL for all services in devstack.01:57
AyoungTheRedgarhyee, and we'll use certmonger as the allocation scheme for them.  Should have used that for Keystone in the first place01:58
*** Mandell has quit IRC01:58
*** thomasm has joined #openstack-dev01:59
*** thomasm has quit IRC01:59
*** egallen has quit IRC01:59
dolphaaarrrggghhCaptainMorgan: cool, i like the explicit v3_to_v2_user()02:00
*** sarob has joined #openstack-dev02:01
CaptainMorgandolphaaarrrggghh, yeah bknuson recommended that, i think it is a lot cleaner.02:01
garhyeeAyoungTheRed, how does FreeIPA working Neutron, in terms of floating IP, DNS, etc02:02
CaptainMorgandolphaaarrrggghh, i just realized something….02:05
CaptainMorgandolphaaarrrggghh, i think this patchset violates string freeze02:05
*** herndon has joined #openstack-dev02:05
dolphaaarrrggghhCaptainMorgan: where?02:05
CaptainMorgandolphaaarrrggghh, config option name changes02:05
CaptainMorganhttps://wiki.openstack.org/wiki/StringFreeze02:06
CaptainMorganremoving an option and adding another one.02:06
CaptainMorganbut i mean, you're the PTL you can give an exception here.02:06
dolphaaarrrggghhCaptainMorgan: it's two different options though? you're not changing one02:07
CaptainMorganremoving an option, adding a new one02:07
dolphaaarrrggghhCaptainMorgan: just happens to be in the same patch and looks very suspicious!02:07
CaptainMorganhehe02:07
CaptainMorganok02:07
CaptainMorganjust didn't want to run afoul of the SF w/o proper documentation02:07
* CaptainMorgan tries to think of a pirate way to phrase "ignore the string freeze" but just can't atm.02:08
dolphaaarrrggghhlet me look into it a bit more before we approve02:08
dolphaaarrrggghhbut i don't *think* it's really a violation02:08
CaptainMorgandolphaaarrrggghh, nod.  i mean, it might just be a case of toss up a comment in the commit02:08
dolphaaarrrggghhagree02:08
*** jasdeepH has quit IRC02:09
dolphaaarrrggghhCaptainMorgan: would it be viable to split some amount of the domain-removal stuff into it's own commit?02:10
dolphaaarrrggghhCaptainMorgan: maybe even just that one line delete02:11
CaptainMorgandolphaaarrrggghh, sure. i could split that out.02:12
garhyeewow, I didn't now we never had default_project_id in the user table02:12
garhyees/now/know/02:12
dolphaaarrrggghhgarhyee: yeah :(02:12
dolphaaarrrggghhCaptainMorgan: that would at least better illustrate that user_domain_id_attribute is being cleanly removed, not changed02:12
CaptainMorgangarhyee, yeah and it's made it a little messy to cleanup02:13
CaptainMorgansure.  i'll go ahead and make a new commit for that and rebase this one onto that one.02:13
dolphaaarrrggghhCaptainMorgan: other than that, you're changing the *default value* of an option, and adding a new option02:13
garhyeeI agree with dolphaaarrrggghh, better to split up the review02:13
CaptainMorganor.. vice-versa02:13
garhyeemake it easier02:13
CaptainMorgangarhyee, trying to think if there is another section i can split like that easily02:13
CaptainMorganmake it 3 changes vs. 102:14
garhyeedata migration can be its own02:14
CaptainMorgangarhyee, actually it can't. it needs to be tied to the normalize (v3->v2 user)02:14
dolphaaarrrggghhCaptainMorgan: 'suspenders and a belt check'02:15
garhyeeha02:15
dolphaaarrrggghhAyoungTheRed: are you moonlighting as CaptainMorgan?02:15
CaptainMorgandolphaaarrrggghh, yep. there should never be a case you get there.02:15
CaptainMorganlol02:15
*** santosh has joined #openstack-dev02:16
CaptainMorgansince i'm splitting this… should v3 update/create/etc explicitly remove tenantId if it's passed in?02:16
*** santosh is now known as Guest2750502:16
CaptainMorganbasically say "uh, no, don't give me tenantId as a attribute for the user on v3"02:16
garhyeeCaptainMorgan, can the translation be done in middleware02:16
CaptainMorgangarhyee, i don't think so easily.  since a number of things embed user_refs in them (not a large number)02:17
CaptainMorganand i don't want to have to guess at what is a user_ref outside anywhere before it hits / after returned from the controller02:18
CaptainMorgangarhyee, i might be over thinking that though.02:18
CaptainMorgangarhyee, honestly, i think most of V2 semantics could be made middleware with enough time.02:19
CaptainMorgangarhyee maybe that is the path of deprecation?02:19
CaptainMorganfor v2.0 that is02:19
garhyeeCaptainMorgan, yeah02:19
garhyeeI was experimenting with v3 to v2 token data translation in middleware02:20
garhyeetill I ran into PKI tokens02:20
CaptainMorgangarhyee, hehe.02:20
dolphaaarrrggghhCaptainMorgan: i wouldn't be opposed to that02:21
dolphaaarrrggghhCaptainMorgan: if you think that will help prevent regression02:21
dolphaaarrrggghhCaptainMorgan: i am a bit paranoid of stomping on attribute names that people could be legitimately/intentionally writing to extra... but i don't think that would be a legitimate one02:22
dolphaaarrrggghhthat would just be an accident02:22
AyoungTheRedgarhyee, I haven't gottne the Neutron thing working yet.  Bascially, I am allocating a floation ip first, telling FreeIPA about it, and then using that to set DNS/IPA02:23
CaptainMorgandolphaaarrrggghh, actually, i don't think it will matter.  it'll only prevent regression in truely 3rd party apps if they assume "tenantId" is handled specially inside keystone02:23
CaptainMorgandolphaaarrrggghh, i think it's fine to just leave it as is.  the V2.0 will just override it with the default_project_id.02:24
dolphaaarrrggghhCaptainMorgan: exactly :)02:24
*** cdub_ has joined #openstack-dev02:24
AyoungTheRedKeystone has become the midnight crew.02:24
CaptainMorgandolphaaarrrggghh, though i am not removing "tenantId" if it exists and default_project_id is None02:25
*** dims has quit IRC02:25
CaptainMorganmaybe i should add the pop back in if tenantId is there and default_project_id is None in the DB?02:25
CaptainMorgans/None/Null02:25
CaptainMorgans/pop/del02:25
dolphaaarrrggghhAyoungTheRed: ++02:26
dolphaaarrrggghhCaptainMorgan: you mean if tenantId is in the request, pop it off?02:26
dolphaaarrrggghhCaptainMorgan: in an update, or what?02:26
CaptainMorganhttps://review.openstack.org/#/c/46207/18/keystone/common/controller.py line 26102:27
CaptainMorganif default_tenant_id is Null in the DB (None here)02:27
CaptainMorganand the user has something in tenantId in the extra feild02:27
CaptainMorgantenantId would still be populated02:27
CaptainMorganpossibly with bogus data.02:27
CaptainMorganthat could confuse things.02:28
*** Tross has quit IRC02:28
CaptainMorgansolution would be to elif 'tenantId' in ref: del ref['tenantId']02:28
CaptainMorgancreate/update/etc shouldn't care.02:29
CaptainMorganthis is called everywhere important.02:29
garhyeeCaptainMorgan, I'll finish up the review  later tonight, need to be offline for a couple of hours, sorry02:31
*** rnirmal has quit IRC02:31
*** garhyee has quit IRC02:31
CaptainMorgangarhyee, no worries going to split the domain_id config option out into a separate patch, but should be very similar.02:31
dolphaaarrrggghhhmmmmmm02:32
*** thomasm has joined #openstack-dev02:34
*** paragan has joined #openstack-dev02:34
*** paragan has joined #openstack-dev02:34
*** Ryan_Lane has joined #openstack-dev02:35
*** edmund1 has joined #openstack-dev02:35
CaptainMorgandolphaaarrrggghh, yeah, i think that eliminates some extra logic in removing/adding a user if someone changes tenantId in an update.02:39
CaptainMorgandolphaaarrrggghh, going with that. next patchset will also split the config.py and sample.conf removal of the user_domain_id attribute.02:40
CaptainMorganconfig option that is02:41
*** herndon has quit IRC02:47
*** stevemar has quit IRC02:51
*** xjiujiu has joined #openstack-dev02:54
*** michchap_ has joined #openstack-dev02:55
*** reed has joined #openstack-dev02:57
dolphaaarrrggghhCaptainMorgan: alrighty02:58
CaptainMorgandolphaaarrrggghh, ok https://review.openstack.org/#/c/46207/ and https://review.openstack.org/#/c/47514/02:58
dolphaaarrrggghhCaptainMorgan: that was fast02:58
*** michchap has quit IRC02:58
*** danwent has joined #openstack-dev02:59
CaptainMorgandolphaaarrrggghh, i was just waiting on tests :P02:59
CaptainMorganalready had it staged up.02:59
* CaptainMorgan blames his IDE for being able to do that relatively quickly02:59
dolphaaarrrggghhCaptainMorgan: conf and domain-related changes look good, where else should i look?03:00
CaptainMorgancommon controller03:00
*** Tross has joined #openstack-dev03:01
CaptainMorganadded the del in the v3-v2 user03:01
*** dsirrine has quit IRC03:02
*** dstanek has quit IRC03:03
*** sandywalsh_ has quit IRC03:03
*** thomasm has quit IRC03:03
*** AyoungTheRed is now known as ayoung-ZzZzZz03:05
*** matiu has quit IRC03:06
dolphaaarrrggghhCaptainMorgan: took me a minute to digest it, but +2'd both03:07
*** Dr_Who has joined #openstack-dev03:07
dolphaaarrrggghhCaptainMorgan: hopefully garhyee comes back and this can merge overnight :)03:08
*** jasdeepH has joined #openstack-dev03:08
CaptainMorgandolphaaarrrggghh, cool. I'm looking forward to these being done.  they've been full of rabbitholes.03:08
dolphaaarrrggghhme too!03:08
CaptainMorganafter this, maybe i can finish up the domain_scope cleanup to expirimental level.03:08
CaptainMorganand then we will be close to being able to stick a fork in RC1 :)03:09
dolphaaarrrggghhhttp://old-wiki.openstack.org/rc/03:09
CaptainMorgan(closer)03:09
dolphaaarrrggghhCaptainMorgan: if you changes merge, we might be *closest*03:09
CaptainMorgandolphaaarrrggghh, nice!03:09
*** Guest27505 has quit IRC03:10
CaptainMorgandolphaaarrrggghh, and henry's belongsTo patch looks close.03:10
dolphaaarrrggghhooh yeah, i wanted to take another pass at that tonight03:11
CaptainMorganat a cursory glance, it looks pretty good.03:11
CaptainMorganbut i've not done a full deep dive on it yet03:11
*** xjiujiu has quit IRC03:11
*** morazi has joined #openstack-dev03:11
dolphaaarrrggghhi wanted to run his tests *with* the line of code that is conspicuously missing03:12
CaptainMorgandolphaaarrrggghh, for what it's worth, i'm super pleased at where keystone has come to for havana… I want to run it in production (as is, let alone RC point).. so much improvement03:12
*** Tross has quit IRC03:12
dolphaaarrrggghhCaptainMorgan: good to hear :)03:13
CaptainMorganI'm going to chase down a tempest core tomorrow.03:13
CaptainMorgani want to get atiwari's token fix in.03:14
*** kuuudos has joined #openstack-dev03:14
*** jab416171 has joined #openstack-dev03:18
*** Tross has joined #openstack-dev03:19
*** sandywalsh has joined #openstack-dev03:23
dolphaaarrrggghhCaptainMorgan: gating henry's change now03:24
CaptainMorgandolphaaarrrggghh, cool.03:24
*** jab416171 has quit IRC03:25
*** MarkAtwood has quit IRC03:25
*** tgall_foo has joined #openstack-dev03:27
dolphaaarrrggghhCaptainMorgan: https://review.openstack.org/#/c/47516/03:28
dolphaaarrrggghhCaptainMorgan: that was my one line concern03:28
CaptainMorgandolphaaarrrggghh, looking03:29
*** esheffield has joined #openstack-dev03:29
*** Dr_Who has quit IRC03:29
CaptainMorganyep. worth doing that03:29
CaptainMorgani mean. it's just ensures we didn't invalidate some random token by accident03:29
*** jhesketh has quit IRC03:32
*** Shaan7 has quit IRC03:33
*** jhesketh__ has quit IRC03:33
*** michchap has joined #openstack-dev03:33
*** michchap has quit IRC03:34
dolphaaarrrggghhCaptainMorgan: yeah... i just wanted to make sure it wasn't missing for a reason :)03:35
*** stevemar has joined #openstack-dev03:35
*** michchap has joined #openstack-dev03:36
*** michchap has quit IRC03:36
*** michchap_ has quit IRC03:36
*** michchap has joined #openstack-dev03:37
*** michchap_ has joined #openstack-dev03:39
*** michchap_ has quit IRC03:40
dolphaaarrrggghhCaptainMorgan: thanks for the readme review03:40
*** michchap has quit IRC03:40
CaptainMorgandolphaaarrrggghh, np!03:40
*** senk has joined #openstack-dev03:43
*** shinylasers has joined #openstack-dev03:45
*** shinylasers has quit IRC03:46
*** senk has quit IRC03:48
*** Tross has quit IRC03:49
*** jay-lau-513 has joined #openstack-dev03:49
*** imsurit has joined #openstack-dev03:50
*** hemanth has quit IRC03:50
*** carl_baldwin has joined #openstack-dev03:54
*** sandeepr_ltp has quit IRC03:55
*** Shaan7 has joined #openstack-dev03:57
*** sandeepr_ltp has joined #openstack-dev03:58
*** dolphaaarrrggghh has quit IRC03:58
CaptainMorganstevemar, how goes?04:01
stevemarCaptainMorgan - man you got an awesome pirate name04:01
CaptainMorganstevemar, hehe04:01
stevemarCaptainMorgan - i just remembered at 5pm that it was talk like a pirate day, i thought ayoung was just going bonkers04:02
CaptainMorganboth dolph and ayoung had awesome names too.04:02
stevemarwhat was dolphs?04:02
CaptainMorgandolphaaarrrggghh04:02
stevemarhahaha04:02
CaptainMorganexactly04:03
*** neelashah has quit IRC04:03
stevemarhmmm, next year i'll go with ShiverMeStevemar04:03
*** jab416171 has joined #openstack-dev04:03
CaptainMorganstevemar, lucky you, that is the limit on characters for the irc nick :P04:03
stevemarsweet04:04
stevemarso, CaptainMorgan, whats goin on sir04:04
CaptainMorganstevemar, hoping my rabbithole of a patchset gets merged soon04:05
CaptainMorganstevemar, and chasing down the last of the RC1 stuff04:05
stevemarthis guy? https://review.openstack.org/#/c/46207/1604:05
CaptainMorganstevemar, ype, but patchset 19 of it :P04:05
CaptainMorganstevemar, http://old-wiki.openstack.org/rc/04:05
CaptainMorganwe're doing well :)04:06
stevemaryeah, the 16th was the patch set i told myself to review in the morning04:06
*** sridevi has joined #openstack-dev04:06
stevemarnova and heat are not fairing so well04:06
stevemarhorizon had a nice jump too04:06
CaptainMorgannova is a big project, lots of things to worry about.04:07
stevemaryup04:07
CaptainMorganheat also had a huge drop a little earlier.04:07
*** jbresnah has quit IRC04:07
stevemarkudos on taking on that bug btw04:08
*** rcrit has quit IRC04:08
stevemarthe tenantId vs tenant_id one..04:08
*** faramir has quit IRC04:08
CaptainMorganstevemar, that one was a brutal one.04:09
stevemari noticed it while doing some openstackclient work, and just worked around it04:09
CaptainMorgani figured it would be… easy, you know "oh just a little code to fix the stuff"04:09
stevemarnopeee04:09
stevemarit was deeply ingrained04:10
CaptainMorganstevemar, yep it was04:10
stevemarCaptainMorgan - things are too calm, though i suppose that is good...04:11
CaptainMorganstevemar, don't jinx it!!04:11
stevemar:|04:11
stevemari should really split this out into 2 patches: https://review.openstack.org/#/c/46085/04:12
CaptainMorganstevemar, perhaps.04:12
stevemar1 for test code and another to add more instructions on adding oauth method to auth04:12
CaptainMorganstevemar, probably a good idea.04:12
CaptainMorganstevemar, plus, it'll get your commit count up :P04:13
CaptainMorgan>.>04:13
stevemar:P04:13
stevemargotta pad my stats04:13
CaptainMorganhehe04:13
CaptainMorganstevemar, http://stackalytics.com/?release=havana&metric=commits&project_type=openstack&module=&company=&user_id=stevemar04:13
stevemarfrom now i'm just gonna commit stuff one function at a time04:13
*** prekarat has joined #openstack-dev04:14
stevemarCaptainMorgan hmm, needs more04:14
*** Mandell has joined #openstack-dev04:15
*** prekarat has quit IRC04:15
*** rcrit has joined #openstack-dev04:15
*** prekarat has joined #openstack-dev04:15
stevemarthough if you change the metric to LOC, over 50% went into keystone04:16
CaptainMorganstevemar, you have more than I do :P04:16
CaptainMorganand 73% of my code went into keystone :P04:16
stevemarwhat?04:16
stevemarno way04:16
stevemaryou do such much more than i do04:16
CaptainMorganeh, look at the review count i have04:16
CaptainMorganif you want to see where i've spent my time.04:17
stevemarhttp://stackalytics.com/?release=havana&metric=marks&project_type=openstack&module=&company=&user_id=stevemar04:17
CaptainMorganbut numbers don't really mean much besides "yep, you contributed"04:17
stevemarhehe04:17
*** carl_baldwin has quit IRC04:18
CaptainMorganat least thats my opinion.  it's important to contribute, but more importantly, contribute quality vs quantity04:18
stevemarto be fair, i only started to review in the last two months04:18
CaptainMorganhehe.04:18
*** morazi has quit IRC04:19
*** imsurit has quit IRC04:19
*** matiu has joined #openstack-dev04:24
*** pmathews has joined #openstack-dev04:30
*** cdub_ has quit IRC04:34
*** basha has joined #openstack-dev04:37
*** cdub_ has joined #openstack-dev04:37
*** chandankumar has joined #openstack-dev04:42
*** senk has joined #openstack-dev04:44
*** edmund1 has quit IRC04:44
*** gongysh has quit IRC04:45
*** gongysh_ has joined #openstack-dev04:45
*** radsy has quit IRC04:48
*** senk has quit IRC04:48
*** Ryan_Lane has quit IRC04:51
*** Ryan_Lane1 has joined #openstack-dev04:51
*** nshaikh has joined #openstack-dev04:53
*** pmathews has quit IRC04:54
*** jasdeepH has quit IRC04:54
*** krtaylor has joined #openstack-dev04:55
*** cdub_ has quit IRC04:58
*** prekarat has quit IRC05:00
*** networkstatic has joined #openstack-dev05:00
*** prekarat has joined #openstack-dev05:02
*** kushal has joined #openstack-dev05:07
*** pmathews has joined #openstack-dev05:08
*** slagle has joined #openstack-dev05:08
*** danwent has quit IRC05:10
*** reed has quit IRC05:11
*** Farooque has joined #openstack-dev05:12
*** slagle has quit IRC05:13
*** Farooque1 has joined #openstack-dev05:14
*** Tross has joined #openstack-dev05:16
*** Farooque has quit IRC05:17
*** CaptTofu has joined #openstack-dev05:17
*** hemna has quit IRC05:17
*** stevemar has quit IRC05:18
*** Farooque1 has left #openstack-dev05:19
*** sarob has quit IRC05:19
*** sarob has joined #openstack-dev05:19
*** jasdeepH has joined #openstack-dev05:20
*** erkules_ is now known as erkules05:21
*** jwcroppe has joined #openstack-dev05:22
*** xqueralt-afk is now known as xqueralt05:24
*** kuuudos has quit IRC05:28
*** sarob has quit IRC05:31
*** sarob has joined #openstack-dev05:32
*** jwcroppe has quit IRC05:33
*** sarob has quit IRC05:36
*** zaitcev has quit IRC05:39
*** otherwiseguy has quit IRC05:43
*** senk has joined #openstack-dev05:45
*** pmathews has quit IRC05:45
*** ondergetekende_ has joined #openstack-dev05:48
*** senk has quit IRC05:49
*** jasdeepH has quit IRC05:50
*** gongysh has joined #openstack-dev05:54
*** rektide has joined #openstack-dev05:54
*** pmathews has joined #openstack-dev05:58
*** tgall_foo has quit IRC06:00
*** senk has joined #openstack-dev06:02
*** michchap has joined #openstack-dev06:04
*** yolanda has joined #openstack-dev06:04
*** garyk has joined #openstack-dev06:04
*** pmathews has quit IRC06:06
*** prekarat has quit IRC06:07
*** prekarat has joined #openstack-dev06:07
*** kuuudos has joined #openstack-dev06:07
*** terriyu has quit IRC06:10
*** SkyRocknRoll has joined #openstack-dev06:11
*** SkyRocknRoll has joined #openstack-dev06:11
*** matiu has quit IRC06:13
*** senk has quit IRC06:13
*** vartom16 has joined #openstack-dev06:21
*** sandeepr has quit IRC06:25
*** matsuhashi has quit IRC06:27
*** matsuhashi has joined #openstack-dev06:28
*** Dr_Who has joined #openstack-dev06:29
*** shang has quit IRC06:31
*** wfoster_away is now known as wfoster06:31
*** MaxV has joined #openstack-dev06:32
*** jbresnah has joined #openstack-dev06:36
*** Dr_Who has quit IRC06:43
*** MaxV has quit IRC06:46
*** xqueralt is now known as xqueralt-afk06:50
*** mrunge has joined #openstack-dev06:51
*** cthulhup has joined #openstack-dev06:51
*** comay has quit IRC06:51
*** rdopieralski has joined #openstack-dev06:52
*** ifarkas has joined #openstack-dev06:54
*** cthulhup has quit IRC06:55
*** rdopieralski has quit IRC06:55
*** jtomasek has joined #openstack-dev06:56
*** zul has quit IRC06:56
*** zul has joined #openstack-dev06:57
*** comay has joined #openstack-dev06:58
*** AnilV4 has quit IRC07:00
*** rdopieralski has joined #openstack-dev07:01
*** MaxV has joined #openstack-dev07:02
*** xga has joined #openstack-dev07:02
*** odyssey4me has joined #openstack-dev07:04
*** AnilV4 has joined #openstack-dev07:05
*** jbresnah has quit IRC07:09
*** Dr_Who has joined #openstack-dev07:09
*** marrrrios is now known as marios07:11
*** jasdeepH has joined #openstack-dev07:15
*** egallen has joined #openstack-dev07:17
*** CaptTofu has quit IRC07:17
*** basha has quit IRC07:18
*** CaptainMorgan is now known as morganfainberg07:19
*** jasdeepH has quit IRC07:19
*** athomas has joined #openstack-dev07:21
*** Ruetobas has quit IRC07:21
*** ondergetekende_ has quit IRC07:25
*** o_petit has joined #openstack-dev07:25
*** jistr has joined #openstack-dev07:25
*** o_petit has quit IRC07:27
*** basha has joined #openstack-dev07:27
*** o_petit has joined #openstack-dev07:27
*** DinaBelova has joined #openstack-dev07:27
*** Dr_Who has quit IRC07:32
*** flaper87|afk is now known as flaper8707:34
*** giulivo has joined #openstack-dev07:37
*** Ruetobas has joined #openstack-dev07:38
*** jaimegil has joined #openstack-dev07:39
*** sheeprine has quit IRC07:40
*** sheeprine has joined #openstack-dev07:41
*** JordanP has joined #openstack-dev07:41
*** eglynn has quit IRC07:42
*** Ruetobas has quit IRC07:43
*** basha has quit IRC07:47
*** gargya has joined #openstack-dev07:48
*** donaldh has joined #openstack-dev07:48
*** Ruetobas has joined #openstack-dev07:48
*** pschaef has joined #openstack-dev07:49
*** ifarkas has quit IRC07:50
*** jdurgin has quit IRC07:51
*** kaushikc has joined #openstack-dev07:51
*** ifarkas has joined #openstack-dev07:53
*** jamielennox is now known as jamielennox|away07:55
*** romcheg has joined #openstack-dev07:55
*** yassine has joined #openstack-dev07:56
*** freedomhui has joined #openstack-dev07:57
*** safchain has joined #openstack-dev08:00
*** boris-42 has joined #openstack-dev08:00
*** shang has joined #openstack-dev08:01
*** xga_ has joined #openstack-dev08:01
*** Mandell has quit IRC08:01
*** matsuhas_ has joined #openstack-dev08:03
*** matsuhashi has quit IRC08:03
*** xga has quit IRC08:04
*** kpavel has joined #openstack-dev08:05
*** boden has joined #openstack-dev08:05
*** jruzicka has joined #openstack-dev08:06
*** johnthetubaguy has joined #openstack-dev08:06
*** jdurgin has joined #openstack-dev08:09
*** xga has joined #openstack-dev08:09
*** eglynn has joined #openstack-dev08:10
*** xga_ has quit IRC08:12
*** senk has joined #openstack-dev08:14
*** mestery has joined #openstack-dev08:15
*** corXi has joined #openstack-dev08:16
*** rossella_s has joined #openstack-dev08:16
*** Ryan_Lane1 has quit IRC08:16
*** fbo_away is now known as fbo08:18
*** senk has quit IRC08:19
*** mmagr has joined #openstack-dev08:19
*** corXi has quit IRC08:22
*** bashok has joined #openstack-dev08:25
*** kpavel has quit IRC08:26
*** DinaBelova has quit IRC08:27
*** kuuudos has quit IRC08:29
*** xga has quit IRC08:29
*** xga has joined #openstack-dev08:29
*** o_petit_ has joined #openstack-dev08:31
*** ygbo has joined #openstack-dev08:34
*** o_petit has quit IRC08:34
*** DinaBelova has joined #openstack-dev08:36
*** Ruetobas has quit IRC08:36
*** matsuhas_ has quit IRC08:39
*** mestery has quit IRC08:41
*** matsuhashi has joined #openstack-dev08:47
*** matsuhashi has quit IRC08:49
*** matsuhashi has joined #openstack-dev08:50
*** imsurit has joined #openstack-dev08:51
*** matsuhas_ has joined #openstack-dev08:51
*** iartarisi has joined #openstack-dev08:54
*** matsuhashi has quit IRC08:55
*** torgomatic has quit IRC08:55
*** torgomatic has joined #openstack-dev08:55
*** danpb has joined #openstack-dev08:57
*** wfoster is now known as wfoster_away08:57
*** kaushikc has quit IRC09:00
*** johnthetubaguy1 has joined #openstack-dev09:00
*** kaushikc has joined #openstack-dev09:00
*** johnthetubaguy has quit IRC09:02
*** imsurit has quit IRC09:02
*** neoXsys has quit IRC09:04
*** imsurit has joined #openstack-dev09:06
*** imsurit is now known as Guest7964809:07
*** mkollaro has joined #openstack-dev09:07
*** mkollaro has quit IRC09:12
*** Ruetobas has joined #openstack-dev09:13
*** mkollaro has joined #openstack-dev09:13
*** senk has joined #openstack-dev09:15
*** neoXsys has joined #openstack-dev09:16
*** basha has joined #openstack-dev09:17
*** mkollaro has quit IRC09:18
*** Ruetobas has quit IRC09:18
*** senk has quit IRC09:19
*** mkollaro has joined #openstack-dev09:20
*** Guest79648 has quit IRC09:21
*** wfoster_away is now known as wfoster09:24
*** Ruetobas has joined #openstack-dev09:24
*** adjohn has joined #openstack-dev09:24
*** o_petit_ has quit IRC09:25
*** o_petit has joined #openstack-dev09:25
*** mkollaro has quit IRC09:28
*** abk has joined #openstack-dev09:29
*** pixelb has joined #openstack-dev09:29
*** leizhang has joined #openstack-dev09:31
*** mkollaro has joined #openstack-dev09:31
*** vartom17 has joined #openstack-dev09:35
*** vartom16 has quit IRC09:35
*** corXi has joined #openstack-dev09:36
*** mkollaro1 has joined #openstack-dev09:37
*** mkollaro has quit IRC09:37
*** o_petit has quit IRC09:37
*** mkollaro1 has quit IRC09:42
*** matsuhas_ has quit IRC09:43
*** vartom18 has joined #openstack-dev09:43
*** mkollaro1 has joined #openstack-dev09:43
*** mkollaro1 has quit IRC09:43
*** vartom17 has quit IRC09:43
*** mkollaro has joined #openstack-dev09:45
*** mkollaro has quit IRC09:45
*** xqueralt-afk is now known as xqueralt09:47
*** mkollaro has joined #openstack-dev09:47
*** xjiujiu has joined #openstack-dev09:51
*** athomas has quit IRC09:54
*** leizhang has quit IRC09:56
*** dripton has quit IRC09:56
*** leizhang has joined #openstack-dev09:56
*** beagles has joined #openstack-dev09:59
*** dripton has joined #openstack-dev09:59
*** jcoufal has joined #openstack-dev10:04
*** DinaBelova has quit IRC10:05
*** vartom19 has joined #openstack-dev10:06
*** pcm_ has joined #openstack-dev10:06
*** pcm_ has quit IRC10:07
*** pcm_ has joined #openstack-dev10:07
*** vartom18 has quit IRC10:09
*** SkyRocknRoll has quit IRC10:09
*** jcoufal has quit IRC10:11
*** Oneiroi has joined #openstack-dev10:13
*** ema has joined #openstack-dev10:13
*** athomas has joined #openstack-dev10:13
*** rushiagr has joined #openstack-dev10:16
*** o_petit has joined #openstack-dev10:17
*** o_petit has quit IRC10:17
*** nosnos has quit IRC10:17
*** gargya has quit IRC10:19
*** iartarisi has quit IRC10:22
*** fbo is now known as fbo_away10:24
*** fbo_away is now known as fbo10:24
*** adjohn has quit IRC10:26
*** safchain has quit IRC10:31
*** egallen has quit IRC10:31
*** DinaBelova has joined #openstack-dev10:32
*** rossella_s has left #openstack-dev10:36
*** abk has quit IRC10:36
*** rossella_s has joined #openstack-dev10:36
*** freedomhui has quit IRC10:36
*** gargya has joined #openstack-dev10:38
*** AnilV4 has quit IRC10:38
*** odyssey4me has quit IRC10:41
*** dstanek has joined #openstack-dev10:44
*** sumanthns has joined #openstack-dev10:46
*** o_petit has joined #openstack-dev10:48
*** freedomhui has joined #openstack-dev10:49
*** mjbright1 has left #openstack-dev10:49
*** odyssey4me has joined #openstack-dev10:50
*** vartom110 has joined #openstack-dev10:51
*** AnilV4 has joined #openstack-dev10:51
*** mjbright has joined #openstack-dev10:54
*** vartom19 has quit IRC10:54
*** odyssey4me has quit IRC10:54
*** o_petit has quit IRC10:55
*** donaldh has quit IRC10:55
*** freedomhui has quit IRC10:56
*** pschaef has quit IRC10:57
*** dims has joined #openstack-dev11:00
*** mjb_ has joined #openstack-dev11:00
*** odyssey4me has joined #openstack-dev11:03
*** yolanda has quit IRC11:03
*** rushiagr has quit IRC11:04
*** jtomasek has quit IRC11:07
*** o_petit has joined #openstack-dev11:07
*** DinaBelova has quit IRC11:12
*** senk has joined #openstack-dev11:17
*** rushiagr has joined #openstack-dev11:18
*** yolanda has joined #openstack-dev11:18
*** senk has quit IRC11:21
bashaI'm trying to add a patch as a deendency on a patch on another repo. one of them is a bug and the other a bp. Will modifying the commit msg help?11:24
*** adjohn has joined #openstack-dev11:27
*** vartom110 has quit IRC11:27
*** jruzicka has quit IRC11:32
*** safchain has joined #openstack-dev11:32
*** jruzicka has joined #openstack-dev11:32
*** rushiagr has quit IRC11:33
*** safchain has quit IRC11:34
*** freedomhui has joined #openstack-dev11:35
*** adjohn has quit IRC11:35
*** safchain has joined #openstack-dev11:35
*** egallen has joined #openstack-dev11:36
*** alexpilotti has quit IRC11:38
*** jtomasek has joined #openstack-dev11:41
*** rushiagr has joined #openstack-dev11:43
*** tmclaugh[work] has joined #openstack-dev11:43
*** FunnyLookinHat has joined #openstack-dev11:43
*** eglynn is now known as eglynn-lunch11:47
*** Dr_Who has joined #openstack-dev11:50
*** xchu has joined #openstack-dev11:52
*** Dr_Who has quit IRC11:53
*** rushiagr has quit IRC11:55
*** tmckay has quit IRC11:56
*** mrunge has quit IRC11:58
*** o_petit has quit IRC11:58
*** kaushikc has quit IRC12:00
*** sumansn_ has joined #openstack-dev12:05
*** rushiagr has joined #openstack-dev12:06
*** sumanthns has quit IRC12:07
*** o_petit has joined #openstack-dev12:07
*** sridevi has quit IRC12:10
*** sandywalsh has quit IRC12:11
*** thomasm has joined #openstack-dev12:11
*** paragan has quit IRC12:14
*** kushal has quit IRC12:14
*** freedomhui has quit IRC12:15
*** cthulhup has joined #openstack-dev12:16
*** gargya has quit IRC12:17
*** gargya has joined #openstack-dev12:18
*** xjiujiu has quit IRC12:18
*** cthulhup has quit IRC12:20
*** kpavel has joined #openstack-dev12:21
*** freedomhui has joined #openstack-dev12:21
*** xjiujiu has joined #openstack-dev12:24
*** gargya has quit IRC12:24
*** sandywalsh has joined #openstack-dev12:26
*** rushiagr has left #openstack-dev12:26
*** xjiujiu has quit IRC12:27
*** dstanek has quit IRC12:28
*** basha has quit IRC12:29
*** xjiujiu has joined #openstack-dev12:30
*** Dr_Who has joined #openstack-dev12:32
*** Dr_Who has joined #openstack-dev12:32
*** riskable has joined #openstack-dev12:33
*** gordc has joined #openstack-dev12:33
*** lbragstad has quit IRC12:33
*** pamacii has joined #openstack-dev12:35
*** sgordon has joined #openstack-dev12:36
*** jaimegil has quit IRC12:41
*** ondergetekende_ has joined #openstack-dev12:43
*** paragan has joined #openstack-dev12:45
*** paragan has joined #openstack-dev12:45
*** dsirrine has joined #openstack-dev12:46
*** chandankumar has quit IRC12:46
*** xjiujiu has quit IRC12:47
*** xjiujiu has joined #openstack-dev12:47
*** eglynn-lunch is now known as eglynn12:47
*** dstanek has joined #openstack-dev12:47
*** sthaha has quit IRC12:48
*** athomas has quit IRC12:49
*** terryh has joined #openstack-dev12:50
*** medberry_ has joined #openstack-dev12:51
*** medberry_ is now known as med12:52
*** kyleh1 has joined #openstack-dev12:52
*** med is now known as med_12:52
*** med_ has quit IRC12:52
*** med_ has joined #openstack-dev12:52
*** kbringard has joined #openstack-dev12:53
*** basha has joined #openstack-dev12:53
*** adalbas has joined #openstack-dev12:53
*** med_ is now known as med12:54
*** med is now known as med_12:54
*** o_petit has quit IRC12:54
*** athomas has joined #openstack-dev12:55
*** AnilV4 has quit IRC12:55
*** radez_g0n3 is now known as radez12:58
*** edmund has joined #openstack-dev13:00
*** venkatesh_ has joined #openstack-dev13:01
*** venkatesh_ has quit IRC13:02
*** dolphaaarrrggghh has joined #openstack-dev13:02
*** dolphaaarrrggghh has quit IRC13:02
ekarlsois there any presentation on the ML2 stuff ?13:03
*** CaptTofu has joined #openstack-dev13:03
*** dvarga has joined #openstack-dev13:04
*** venkatesh has joined #openstack-dev13:04
*** bfschott has joined #openstack-dev13:04
*** xjiujiu has quit IRC13:07
*** xjiujiu has joined #openstack-dev13:07
*** jergerber has joined #openstack-dev13:09
*** tmclaugh[work] has quit IRC13:11
*** lbragstad has joined #openstack-dev13:12
*** xjiujiu has quit IRC13:12
*** xjiujiu has joined #openstack-dev13:12
*** jcoufal has joined #openstack-dev13:13
*** DinaBelova has joined #openstack-dev13:13
*** enikanorov has joined #openstack-dev13:13
*** senk has joined #openstack-dev13:14
*** Dr_Who has quit IRC13:15
*** enikanorov_ has quit IRC13:16
*** herndon has joined #openstack-dev13:17
*** neeti has joined #openstack-dev13:17
*** fbo has quit IRC13:18
*** neelashah has joined #openstack-dev13:18
*** Oneiroi has quit IRC13:19
*** fbo has joined #openstack-dev13:19
*** xjiujiu has quit IRC13:20
*** maheshp has joined #openstack-dev13:20
*** xjiujiu has joined #openstack-dev13:21
*** Dr_Who has joined #openstack-dev13:21
*** Dr_Who has joined #openstack-dev13:21
*** xchu has quit IRC13:23
*** DinaBelova has quit IRC13:23
*** AnilV4 has joined #openstack-dev13:23
*** blamar has joined #openstack-dev13:24
*** venkatesh has quit IRC13:24
*** jayg|g0n3 is now known as jayg13:24
*** DinaBelova has joined #openstack-dev13:25
*** jasondotstar has joined #openstack-dev13:28
*** prad has joined #openstack-dev13:32
*** jecarey has joined #openstack-dev13:34
*** senk has quit IRC13:37
*** alexpilotti has joined #openstack-dev13:37
*** sumansn_ has quit IRC13:38
*** CaptTofu has quit IRC13:39
*** dstanek has quit IRC13:39
*** senk has joined #openstack-dev13:39
*** noslzzp has joined #openstack-dev13:40
*** rcrit has quit IRC13:40
*** bnemec is now known as beekneemec13:42
*** dansmith is now known as Steely_Dan13:43
*** nshaikh has left #openstack-dev13:44
*** maheshp has quit IRC13:45
*** kpepple has quit IRC13:45
*** maheshp has joined #openstack-dev13:45
*** kpepple has joined #openstack-dev13:45
*** rcrit has joined #openstack-dev13:46
*** tmmt_ has joined #openstack-dev13:46
*** jpeeler1 has joined #openstack-dev13:46
*** prad has quit IRC13:46
*** DinaBelova has quit IRC13:46
*** tmmt has quit IRC13:47
*** jpeeler has quit IRC13:47
*** cburgess has quit IRC13:47
*** jpeeler1 is now known as jpeeler13:47
*** jpeeler has quit IRC13:48
*** jpeeler has joined #openstack-dev13:48
*** cburgess has joined #openstack-dev13:48
*** russellb is now known as rustlebee13:48
*** beagles is now known as seagulls13:48
*** jcoufal has quit IRC13:50
*** ruhe has joined #openstack-dev13:51
*** prad has joined #openstack-dev13:52
*** xjiujiu has quit IRC13:52
*** xjiujiu has joined #openstack-dev13:53
*** terriyu has joined #openstack-dev13:53
*** stevemar has joined #openstack-dev13:55
*** jcoufal has joined #openstack-dev13:55
*** prad has quit IRC13:56
*** FunnyLookinHat has quit IRC13:56
*** eharney has joined #openstack-dev13:57
*** seagulls is now known as beagles13:59
*** beagles is now known as seagulls13:59
*** blues-man has joined #openstack-dev14:02
*** xjiujiu has quit IRC14:03
*** tmclaugh[work] has joined #openstack-dev14:04
*** xjiujiu has joined #openstack-dev14:04
*** networkstatic has quit IRC14:04
*** networkstatic has joined #openstack-dev14:04
*** jcoufal has quit IRC14:05
*** basha has quit IRC14:08
*** Dr_Who has quit IRC14:09
*** jmontemayor has joined #openstack-dev14:09
*** o_petit_ has joined #openstack-dev14:09
*** thomasm has quit IRC14:09
*** tstevenson__ has joined #openstack-dev14:09
*** rwsu has joined #openstack-dev14:10
*** prekarat has quit IRC14:11
*** herndon has quit IRC14:11
*** edmund has quit IRC14:11
*** kushal has joined #openstack-dev14:11
*** edmund has joined #openstack-dev14:12
*** datsun180b has joined #openstack-dev14:12
*** dstanek has joined #openstack-dev14:13
*** dhellmann is now known as dhellmann_14:16
*** xjiujiu has quit IRC14:16
*** litong has joined #openstack-dev14:17
*** gimps_ has joined #openstack-dev14:19
*** DinaBelova has joined #openstack-dev14:20
*** ayoung-ZzZzZz is now known as ayoung14:21
*** ayoung has quit IRC14:21
*** [wchrisj_ has joined #openstack-dev14:23
*** [wchrisj_ is now known as wchrisj14:23
*** dolphaaarrrggghh has joined #openstack-dev14:28
*** aeperezt has joined #openstack-dev14:28
*** dolphaaarrrggghh has joined #openstack-dev14:28
*** dolphaaarrrggghh is now known as dolphm14:28
*** rnirmal has joined #openstack-dev14:28
*** Ruetobas has quit IRC14:29
*** MaxV has quit IRC14:29
*** henrynash has joined #openstack-dev14:29
*** giulivo has quit IRC14:30
*** giulivo has joined #openstack-dev14:31
*** DinaBelova has quit IRC14:32
*** yamahata has quit IRC14:33
*** FunnyLookinHat has joined #openstack-dev14:34
*** yamahata has joined #openstack-dev14:36
*** Ruetobas has joined #openstack-dev14:36
*** gfidente has joined #openstack-dev14:36
*** thomasm has joined #openstack-dev14:37
*** giulivo has quit IRC14:38
*** vlakarados|2 has joined #openstack-dev14:42
*** vlakarados has quit IRC14:42
*** xga_ has joined #openstack-dev14:42
*** krphop has quit IRC14:43
*** xga has quit IRC14:43
*** utlemming has quit IRC14:43
*** utlemming has joined #openstack-dev14:44
*** herndon has joined #openstack-dev14:46
*** krphop has joined #openstack-dev14:47
*** ruhe has quit IRC14:54
*** DinaBelova has joined #openstack-dev14:55
*** matiu has joined #openstack-dev14:57
*** ruhe has joined #openstack-dev14:57
dolphmmorganfainberg: henrynash: o/15:01
henrynashdolphm: hi15:01
*** bknudson has joined #openstack-dev15:01
dolphmhenrynash: i'm looking into one of your comments on morgan's tenantId/tenant_id/default_project_id fix...15:01
henrynashdolphm: yes, saw your reply15:02
dolphmhenrynash: regarding remove_user_from_project() -- do you know when/why the behavior of that function changed?15:02
dolphmhenrynash: i don't see any reason in tests to explain it's current behavior15:02
*** danwent has joined #openstack-dev15:02
henrynashdolphm: no I don't….I suspect during Grizzly, but that's a guess15:02
*** mrunge has joined #openstack-dev15:03
*** carl_baldwin has joined #openstack-dev15:04
*** ayoung has joined #openstack-dev15:04
*** o_petit_ has quit IRC15:04
*** CaptTofu has joined #openstack-dev15:05
*** jasdeepH has joined #openstack-dev15:05
*** DinaBelova has quit IRC15:06
*** alop has joined #openstack-dev15:07
*** Tross has quit IRC15:08
*** ifarkas has quit IRC15:08
*** Tross has joined #openstack-dev15:08
*** mrodden has quit IRC15:08
*** ericw has joined #openstack-dev15:09
*** roaet has quit IRC15:11
*** roaet has joined #openstack-dev15:12
*** epim has joined #openstack-dev15:12
*** Ruetobas has quit IRC15:12
*** reed has joined #openstack-dev15:17
*** kushal has quit IRC15:20
*** kuuudos has joined #openstack-dev15:21
*** prad has joined #openstack-dev15:22
*** devoid has joined #openstack-dev15:23
*** mmagr has quit IRC15:23
*** devoid has left #openstack-dev15:24
*** kuuudos has left #openstack-dev15:25
*** jvrbanac has joined #openstack-dev15:25
*** paragan has quit IRC15:28
*** mmagr has joined #openstack-dev15:29
*** mkollaro has quit IRC15:30
*** Mandell has joined #openstack-dev15:31
*** Ruetobas has joined #openstack-dev15:33
*** safchain has quit IRC15:33
*** markmcclain has joined #openstack-dev15:35
*** yassine has quit IRC15:35
*** otherwiseguy has joined #openstack-dev15:41
*** otherwiseguy has quit IRC15:42
*** safchain has joined #openstack-dev15:43
*** otherwiseguy has joined #openstack-dev15:43
*** safchain has quit IRC15:43
*** otherwiseguy has quit IRC15:43
*** otherwiseguy has joined #openstack-dev15:43
*** hashfail_ has joined #openstack-dev15:45
*** paragan has joined #openstack-dev15:45
*** paragan has quit IRC15:45
*** paragan has joined #openstack-dev15:45
*** mrodden has joined #openstack-dev15:46
*** seagulls has quit IRC15:46
*** beagles has joined #openstack-dev15:46
*** gongysh has quit IRC15:47
*** gongysh_ has quit IRC15:47
*** sumanthns has joined #openstack-dev15:47
*** gimps_ has quit IRC15:47
*** beagles is now known as seagulls15:47
*** hashfail_ has quit IRC15:49
*** sergmelikyan has quit IRC15:49
*** mkollaro has joined #openstack-dev15:49
*** mkollaro has quit IRC15:49
*** wchrisj is now known as help15:53
*** help is now known as wchrisj15:53
*** jeblair is now known as corvus15:53
*** jtomasek has quit IRC15:54
*** bashok has left #openstack-dev15:54
*** xga has joined #openstack-dev15:54
*** noslzzp has quit IRC15:55
*** wchrisj has quit IRC15:55
*** wchrisj has joined #openstack-dev15:56
*** pmathews has joined #openstack-dev15:56
*** xga_ has quit IRC15:57
*** paragan has quit IRC15:57
*** noslzzp has joined #openstack-dev15:57
*** corvus is now known as jeblair16:00
*** herndon has quit IRC16:00
*** venkatesh has joined #openstack-dev16:00
*** Ruetobas has quit IRC16:01
*** CaptTofu has quit IRC16:01
*** rdopieralski has quit IRC16:01
*** jistr has quit IRC16:02
*** dolphm has quit IRC16:02
*** DinaBelova has joined #openstack-dev16:02
*** shang has quit IRC16:03
*** bdpayne has joined #openstack-dev16:03
*** Ruetobas has joined #openstack-dev16:03
*** mmagr has quit IRC16:03
*** kgriffs has joined #openstack-dev16:03
kgriffskeystone question for you guys16:04
kgriffsin practice, is anything other than an integer used for Project ID (AKA Tenant ID)16:04
kgriffs?16:04
*** herndon has joined #openstack-dev16:04
*** swills has quit IRC16:06
*** andymccr has quit IRC16:06
*** SumitNaiksatam has quit IRC16:06
*** dhellmann_ is now known as dhellmann16:08
*** Ruetobas has quit IRC16:08
*** swills has joined #openstack-dev16:08
*** swills has quit IRC16:09
*** swills has joined #openstack-dev16:09
*** andymccr has joined #openstack-dev16:09
*** shinylasers has joined #openstack-dev16:10
*** bknudson has left #openstack-dev16:11
*** neeti has quit IRC16:11
*** terriyu has quit IRC16:11
*** neeti has joined #openstack-dev16:11
*** Ruetobas has joined #openstack-dev16:14
*** o_petit has joined #openstack-dev16:15
*** tmmt_ is now known as tmmt16:15
*** freedomhui has quit IRC16:15
*** mrunge has quit IRC16:16
*** CaptTofu has joined #openstack-dev16:17
*** sdake_ has joined #openstack-dev16:19
*** o_petit has quit IRC16:20
*** jruzicka has quit IRC16:21
*** noslzzp has quit IRC16:23
*** michchap has quit IRC16:23
*** mrodden has quit IRC16:23
*** michchap has joined #openstack-dev16:23
*** gordc has quit IRC16:24
*** comstud is now known as bearhands16:24
*** gordc has joined #openstack-dev16:25
*** kushal has joined #openstack-dev16:26
*** SumitNaiksatam has joined #openstack-dev16:26
*** pasquier-s has quit IRC16:28
*** lbragstad has quit IRC16:29
*** blues-man has quit IRC16:31
*** Guangya has joined #openstack-dev16:32
*** eglynn has quit IRC16:33
*** JordanP has quit IRC16:34
*** noslzzp has joined #openstack-dev16:35
*** xga_ has joined #openstack-dev16:35
*** grapsus has quit IRC16:35
*** jay-lau-513 has quit IRC16:35
*** grapsus has joined #openstack-dev16:35
*** kushal has quit IRC16:37
*** xga has quit IRC16:37
*** ygbo has quit IRC16:38
*** jbresnah has joined #openstack-dev16:39
*** grapsus has quit IRC16:40
*** angdraug has joined #openstack-dev16:41
*** venkatesh has quit IRC16:42
*** CaptTofu has quit IRC16:43
*** CaptTofu has joined #openstack-dev16:43
*** xga_ has quit IRC16:44
*** terriyu has joined #openstack-dev16:44
*** maheshp has quit IRC16:44
*** comay_ has joined #openstack-dev16:45
*** grapsus has joined #openstack-dev16:46
*** rnirmal has quit IRC16:47
*** alop has quit IRC16:48
*** zaitcev has joined #openstack-dev16:48
*** CaptTofu has quit IRC16:48
*** CaptTofu has joined #openstack-dev16:49
*** shardy is now known as shardy_afk16:50
*** dolphm has joined #openstack-dev16:50
*** kbrierly has joined #openstack-dev16:51
*** alop has joined #openstack-dev16:52
*** eglynn has joined #openstack-dev16:55
*** mrodden has joined #openstack-dev16:55
*** hemnafk is now known as hemna16:57
*** alop has quit IRC16:57
*** msmedved has quit IRC16:57
mroddenbeekneemec: nice catch on test on that py3 patch16:57
mroddenthe test*16:57
kgriffsreposting my earlier question:16:58
*** alop has joined #openstack-dev16:58
kgriffsn practice, is anything other than an integer used for Project ID (AKA Tenant ID)?16:58
beekneemecmrodden: Yeah, I'm generally opposed to removing test cases for non-duplicate cases, so I didn't like that. :-)16:58
*** kdbrierly has joined #openstack-dev16:58
*** egallen has quit IRC16:58
*** CaptTofu has quit IRC16:58
*** CaptTofu has joined #openstack-dev16:59
mroddenbeekneemec: i always get tunnel version on making sure what is being added looks ok, that i didn't realize they were removing a test case entirely16:59
mroddentunnel vision16:59
mroddenapparently i can't type today either16:59
*** kbrierly has quit IRC16:59
beekneemecmrodden: Meh, it's Friday. :-)16:59
mroddentrue that17:00
beekneemecmrodden: And that sort of thing is why we approve after two +2's in most projects.17:00
beekneemecOne person isn't going to catch everything.17:00
mroddenyeah17:01
*** msmedved has joined #openstack-dev17:02
*** fbo is now known as fbo_away17:04
*** gyee has joined #openstack-dev17:05
*** grapsus has quit IRC17:06
*** DinaBelova has quit IRC17:07
*** sumansn_ has joined #openstack-dev17:07
mroddenbeekneemec: could i get your opinion on something quick? https://review.openstack.org/#/c/45120/17:08
*** grapsus has joined #openstack-dev17:08
*** sumanthns has quit IRC17:08
*** ruhe has quit IRC17:08
beekneemecmrodden: Ah, I think I saw that yesterday17:09
mroddenyeah i dont really care what the default is17:09
*** msmedved has quit IRC17:09
mroddenits just there is a bug open for nova and it was changed in all the other projects already17:09
*** kushal has joined #openstack-dev17:10
beekneemecmrodden: So this is just making it behave the way it did before the delayed translation change?17:10
mroddenyeah17:10
mroddenwhich, I considered a bug in the original design and fixed...17:10
mroddenbut i guess that was bad?17:10
*** kgriffs has left #openstack-dev17:10
beekneemecHmm17:11
*** dlstacy has joined #openstack-dev17:11
beekneemecI vaguely recall a similar discussion to this.17:11
*** spzala has joined #openstack-dev17:12
mroddenyeah i'm guessing its time to bring it to the ML17:12
beekneemecYeah, probably.17:12
beekneemecI guess I'm inclined to give the server administrator control over the default, which is what your change would do.17:12
mroddenyeah17:12
mroddenthat was luis' argument that swayed me to fix it17:13
*** grapsus has quit IRC17:13
*** kushal has quit IRC17:13
*** danpb has quit IRC17:14
beekneemecAnd if the user doesn't like that default, they can always pass the header to override it.17:14
*** grapsus has joined #openstack-dev17:14
luis+117:14
*** sandywalsh_ has joined #openstack-dev17:14
*** odyssey4me has quit IRC17:15
* beekneemec tries to ignore the fact that he's about 600 e-mails behind on the -dev ML.17:18
*** arezmerita has quit IRC17:18
morganfainberghenrynash, dolphm , hi17:18
*** sandywalsh has quit IRC17:18
morganfainberghenrynash / dolphm, regarding the behavior, i think some of the backends did it others didn't.  checking now17:18
morganfainbergfor that comment that is17:18
morganfainbergi just lifted the logic up to the controller so i could move forward with the fixes.17:19
*** ruhe has joined #openstack-dev17:19
*** CaptTofu has quit IRC17:20
*** CaptTofu has joined #openstack-dev17:20
*** lcheng has joined #openstack-dev17:21
*** msmedved has joined #openstack-dev17:22
morganfainberghenrynash / dolphm, https://github.com/openstack/keystone/blob/master/keystone/identity/backends/ldap.py#L10817:24
*** corXi has quit IRC17:25
*** comay has quit IRC17:26
*** herndon has quit IRC17:27
*** maheshp has joined #openstack-dev17:28
*** comay has joined #openstack-dev17:28
*** seagulls is now known as beagles17:29
*** beagles is now known as seagulls17:29
*** wfoster is now known as wfoster_away17:30
*** johnthetubaguy1 has quit IRC17:31
*** sumansn_ has quit IRC17:31
*** Farooque has joined #openstack-dev17:32
*** Ryan_Lane has joined #openstack-dev17:32
*** johnthetubaguy has joined #openstack-dev17:33
*** operrin has quit IRC17:35
*** AnilV4 has quit IRC17:37
*** amcrn has joined #openstack-dev17:37
*** spzala has quit IRC17:38
*** spzala has joined #openstack-dev17:38
*** shakayumi has joined #openstack-dev17:41
*** ruhe has quit IRC17:42
*** johnthetubaguy has quit IRC17:43
*** anteaya has joined #openstack-dev17:43
*** johnthetubaguy has joined #openstack-dev17:43
*** lbragstad has joined #openstack-dev17:44
*** johnthetubaguy has quit IRC17:44
*** jasondotstar has quit IRC17:44
*** galstrom_zzz is now known as galstrom17:44
*** ruhe has joined #openstack-dev17:44
*** galstrom is now known as galstrom_zzz17:46
*** CaptTofu has quit IRC17:49
*** vuil has joined #openstack-dev17:49
*** CaptTofu has joined #openstack-dev17:50
morganfainberghenrynash / dolphm, almost done rolling another patchset.  do you want me to rebase upon the other fix for the remove based upon tenantId changing?17:50
morganfainbergi can do that if needed.17:50
*** ruhe has quit IRC17:51
morganfainbergor we can have the cleanup be applied on top of my changeset.17:51
*** dlstacy has left #openstack-dev17:51
morganfainbergbe back in a few.17:51
*** cthulhup has joined #openstack-dev17:51
*** cthulhup has quit IRC17:51
*** cthulhup has joined #openstack-dev17:52
*** terryh has quit IRC17:55
*** eharney has quit IRC17:55
*** venkatesh has joined #openstack-dev17:55
*** dstanek has quit IRC17:56
*** xqueralt is now known as xqueralt-afk17:56
*** reed has quit IRC17:56
*** CaptTofu has quit IRC17:57
*** neeti has quit IRC17:58
*** cthulhup has quit IRC17:58
*** eharney has joined #openstack-dev17:59
*** dstanek has joined #openstack-dev18:00
*** dkranz has quit IRC18:00
*** ruhe has joined #openstack-dev18:03
*** ruhe has quit IRC18:07
dolphmmorganfainberg: catching up...18:07
dolphmmorganfainberg: i'm looking into the remove_user_from_project() stuff myself... i have a patch against master that's passing tests to apply your remove_user_membership_from_project() logic to the existing remove_user_from_project()18:12
dolphmmorganfainberg: but now i'd like to go judge impact on your patch and the other related one18:12
morganfainbergdolphm, exactly18:13
morganfainbergdolphm, my patch needed to lift stuff up to the controller, ldap already had this logic.  i could rebase mine on the other one and incorporate that instead.18:14
morganfainbergdolphm, let me know, i'm writing a couple tests and will be ready for a patch that addresses the comments.18:14
*** david-lyle is now known as david-lyle_away18:14
dolphmmorganfainberg: let me know what you think of this first - remove_user_membership_from_project()18:16
dolphmmorganfainberg: as far as i can see, this method isn't currently called by any HTTP API, so changing it's behavior only impacts tests?18:16
dolphmand that other patch in review (or yours) should be consuming it18:16
dolphmmorganfainberg: bad paste above... http://pasteraw.com/odjhmem4i526mpka7l453216f1rixrn18:17
morganfainberglooking18:17
*** adjohn has joined #openstack-dev18:18
jgriffithsdague: Lemme know if you still disagree on my comments WRT https://review.openstack.org/#/c/47460/18:18
*** radix has quit IRC18:19
*** radix has joined #openstack-dev18:19
*** venkatesh has quit IRC18:20
morganfainbergdolphm, that impact should be minimal since we are just consuming it18:20
morganfainbergdolphm, it does seem like only tests should be affected18:21
*** carl_baldwin has quit IRC18:21
morganfainbergwith this change.18:21
*** adjohn has quit IRC18:25
*** adjohn has joined #openstack-dev18:27
sdaguejgriffith: just reading, I'm ok with that.18:30
*** alexpilotti has quit IRC18:31
*** senk has quit IRC18:32
*** adjohn has quit IRC18:33
*** amohn9 has joined #openstack-dev18:34
*** sushils has joined #openstack-dev18:34
*** thomasm has quit IRC18:35
*** adjohn has joined #openstack-dev18:35
*** adjohn has quit IRC18:37
*** seagulls is now known as beagles18:38
*** beagles is now known as seagulls18:38
*** adjohn has joined #openstack-dev18:40
*** troytoman-away is now known as troytoman18:40
*** jasondotstar has joined #openstack-dev18:40
*** anteaya has quit IRC18:40
*** xga has joined #openstack-dev18:41
*** ema has quit IRC18:43
*** melwitt has joined #openstack-dev18:43
*** terryh has joined #openstack-dev18:44
jgriffithsdague: great, thanks... I'll submit and updated after the cinder change merges18:45
sdaguegreat18:45
*** xga has quit IRC18:45
*** riskable has quit IRC18:45
*** terryh has quit IRC18:47
*** vipul is now known as vipul-away18:47
*** vipul-away is now known as vipul18:47
*** terryh has joined #openstack-dev18:47
*** terryh has quit IRC18:48
*** comay has quit IRC18:50
*** venkatesh has joined #openstack-dev18:52
*** anteaya has joined #openstack-dev18:53
*** rnirmal has joined #openstack-dev18:54
*** thomasm has joined #openstack-dev18:54
*** leizhang has quit IRC18:55
*** thomasm has quit IRC18:55
*** thomasm has joined #openstack-dev18:55
*** sushils has quit IRC18:57
*** adjohn has quit IRC18:58
*** adjohn has joined #openstack-dev18:59
*** venkatesh has quit IRC19:00
*** venkatesh has joined #openstack-dev19:00
*** novas0x2a|laptop has joined #openstack-dev19:01
*** gyee has quit IRC19:01
*** adjohn has quit IRC19:03
*** adjohn has joined #openstack-dev19:04
*** rossella_s has quit IRC19:04
*** adjohn has quit IRC19:07
*** vartom110 has joined #openstack-dev19:07
*** carl_baldwin has joined #openstack-dev19:08
*** venkatesh has quit IRC19:09
*** the_real_kp has left #openstack-dev19:09
*** venkatesh has joined #openstack-dev19:09
*** venkatesh has quit IRC19:09
*** venkatesh has joined #openstack-dev19:10
*** maheshp has quit IRC19:11
*** adjohn has joined #openstack-dev19:11
*** amohn9 has quit IRC19:12
*** CaptTofu has joined #openstack-dev19:12
*** adjohn has quit IRC19:15
*** adjohn has joined #openstack-dev19:17
*** dvarga has quit IRC19:17
*** the_real_kp has joined #openstack-dev19:19
*** adjohn has quit IRC19:22
*** tstevenson__ has quit IRC19:22
*** datsun180b has quit IRC19:22
*** rnirmal has quit IRC19:22
*** noorul has quit IRC19:23
*** noorul` has joined #openstack-dev19:23
*** kevinconway has quit IRC19:23
*** jvrbanac has quit IRC19:24
*** vipul is now known as vipul-away19:24
*** adjohn has joined #openstack-dev19:28
*** CaptTofu has quit IRC19:29
*** amohn9 has joined #openstack-dev19:30
*** davi6723 has joined #openstack-dev19:34
*** jecarey has quit IRC19:35
*** adjohn has quit IRC19:36
*** pmathews has quit IRC19:36
*** dstanek has quit IRC19:36
*** maheshp has joined #openstack-dev19:37
*** thomasm has quit IRC19:38
*** athomas has quit IRC19:39
*** thomasm has joined #openstack-dev19:39
*** rnirmal has joined #openstack-dev19:39
*** jvrbanac has joined #openstack-dev19:40
*** pmathews has joined #openstack-dev19:40
*** mriedem has joined #openstack-dev19:40
mriedemis anyone aware of known issues trying to build docs for ceilometer with sphinx?19:41
*** dolphm_ has joined #openstack-dev19:42
mriedemdhellmann: ping19:42
thomasmmriedem, I'm not aware of any, some folks in #openstack-metering might, though.19:43
mriedemmetering, ah, was looking for openstack-ceilometer, thanks19:43
thomasmmriedem, Anytime =]19:43
dhellmannmriedem: pong19:43
morganfainbergdolphm, https://review.openstack.org/#/c/46207/ updated with now with more testing.19:43
*** zeriouz has joined #openstack-dev19:43
mriedemdhellmann: yeah, i see you on sphinxcontrib-pecanwsme19:43
morganfainbergdolphm, and a little cleanup as requested by bknudson.19:43
*** zeriouz has quit IRC19:43
mriedemdhellmann: i'm trying to build docs for ceilometer with sphinx and am hitting this: Could not import extension sphinxcontrib.pecanwsme.rest (exception: No module named pecanwsme.rest)19:44
mriedemdhellmann: but i can import that module from my python shell19:44
mriedemdhellmann: just wondering if you've heard about it?19:44
dhellmannmriedem: is it installed, or just importable?19:44
mriedemdhellmann: installed via pip, 0.419:44
dhellmanndo you have other sphinxcontrib modules installed as well?19:44
mriedemdhellmann: yeah, httpdomain19:45
*** otherwiseguy has quit IRC19:45
dhellmanndo you have a relatively new version of pbr installed?19:45
*** jvrbanac has quit IRC19:45
mriedem0.5.2119:45
mriedemlatest19:45
* dhellmann thinks19:45
dhellmannhow are you running the doc build?19:45
*** dolphm has quit IRC19:45
*** dolphm_ has joined #openstack-dev19:45
mriedemdhellmann: i've tried calling sphinx-build directly and going through the makefile in the ceilometer source19:46
mriedemboth fail with the same thing19:46
dhellmanntry "tox -e docs"19:46
*** rnirmal has quit IRC19:46
*** rnirmal_ has joined #openstack-dev19:46
dhellmannor "python setup.py build_sphinx"19:46
mriedemdhellmann: ok, sec19:46
*** Ryan_Lane has quit IRC19:47
*** yolanda has quit IRC19:47
*** Ryan_Lane has joined #openstack-dev19:47
mriedemdhellmann: python setup.py build_sphinx got further, failed on missing flask, installing that now19:47
dhellmannmriedem: using tox should install all of the dependencies for you automatically19:47
mriedemdhellmann: yeah, trying to build an rpm here19:47
*** spzala has quit IRC19:47
*** dvarga has joined #openstack-dev19:48
dhellmannmriedem: I guess you need system packages of the deps for that?19:48
mriedemi don't necessarily need rpms, but yeah, they should be called out as build deps in the spec ultimately - anyway, got past flask, hit keystoneclient, so i'm moving with setup.py sphinx_build, thanks19:49
*** gordc has quit IRC19:49
dhellmannmriedem: good, ping us in #openstack-metering if you run into more issues19:49
mriedemdhellmann: will do, thanks19:49
dolphm_mriedem: you can use setup.py build_sphinx in combination with tox to have it build the venv for you19:49
*** xqueralt-afk is now known as xqueralt19:50
mriedemdolphm_: yeah, tox would be magical, but not using it in the rpm spec19:50
dolphm_mriedem: might just me "tox -epy27 python setup.py build_sphinx"19:50
dolphm_mriedem: ah19:50
mriedemdistro packaging, yay!19:50
*** jvrbanac has joined #openstack-dev19:51
*** mestery has joined #openstack-dev19:51
*** david-lyle_away is now known as david-lyle19:53
*** gyee has joined #openstack-dev19:55
*** dvarga has quit IRC19:56
*** alop has quit IRC19:56
*** datsun180b has joined #openstack-dev19:57
*** otherwiseguy has joined #openstack-dev19:59
*** radez is now known as radez_g0n319:59
*** openfly has joined #openstack-dev20:01
openflyhrmm anyone know if jenkins + jclouds works backended to openstack?20:01
clarkbopenfly: it does20:01
openflystellar.20:01
clarkbcompute and object storage should work20:01
clarkbI have used both but it has been a while20:02
openflyany nasty caveats?20:02
morganfainberglbragstad, fast on the +1 there ;)20:02
clarkbopenfly: not really, I patched the object storage stuff and it seems to work alot better now20:02
*** amerine has quit IRC20:02
clarkbopenfly: debuggign why compute nodes fail is sometimes difficult and jclouds + jenkins doesn't seem to always clean up nodes properly20:02
lbragstadmorganfainberg: quick!20:03
openflyhrmm20:03
openflyokay20:03
clarkbbut those problems exist with the alternatives20:03
openflywell that's easy enough to watchdog20:03
*** amerine has joined #openstack-dev20:03
lbragstadmorganfainberg: I saw your 'no functional change' comment and that concluded my review20:03
clarkbopenfly: check out http://git.openstack.org/cgit/openstack-infra/nodepool20:03
morganfainberglbragstad, hehe.20:03
clarkbopenfly: ^ is our answer for single use slaves provided by nova, but it isn't well documented yet and is semi specific to our jenkins20:04
morganfainberglbragstad, not like that changeset has any massive ramifications in either case.20:04
lbragstadmorganfainberg: I'm still going through https://review.openstack.org/#/c/46207/20:04
lbragstadhaven't made it all the way through that one20:04
openflyawesome will look through it.20:05
morganfainberglbragstad, yeah that one has been a beast.20:05
morganfainberglbragstad thanks for looking through them.  more eyes on changes like that = better20:06
*** venkatesh has quit IRC20:06
lbragstadmorganfainberg: not a problem and I completely agree20:07
*** herndon has joined #openstack-dev20:08
*** davi6723 has quit IRC20:09
*** dolphm has joined #openstack-dev20:10
*** dolphm_ has quit IRC20:10
*** vartom110 has quit IRC20:11
*** anteaya has quit IRC20:12
*** Dr_Who has joined #openstack-dev20:13
*** Ryan_Lane has quit IRC20:17
*** Ryan_Lane1 has joined #openstack-dev20:17
*** Dr_Who has quit IRC20:18
*** datsun180b has quit IRC20:18
*** vipul-away is now known as vipul20:20
*** rnirmal_ has quit IRC20:20
morganfainberglbragstad, fyi, another patchset is incoming to try and address the tempest failure(s), it's a 1-line fix and some test massaging20:20
*** jvrbanac has quit IRC20:21
*** boden has quit IRC20:21
*** dims has quit IRC20:21
*** davi6723 has joined #openstack-dev20:23
lbragstadmorganfainberg: gotcha, so that is why 46207 was failing Jenkins?20:23
morganfainbergi think it's that i removed a ref.copy()20:23
*** davi6723 is now known as dstanek20:23
morganfainbergin the v3_to_v2 static method20:24
lbragstadahh o k20:24
morganfainbergbecause between the two patchsets, that was the only non-test non-rename-of-function-that-would-prevent-py26/py27-from-passing change20:24
morganfainberglbragstad, https://review.openstack.org/#/c/46207/19..20/keystone/contrib/ec2/controllers.py20:24
morganfainbergerm20:24
morganfainberghttps://review.openstack.org/#/c/46207/19..20/keystone/common/controller.py20:25
morganfainbergalmost no changes other than that.20:25
morganfainbergwhich also might mean that tempest has made some bad assumptions20:25
*** dims has joined #openstack-dev20:25
morganfainbergand this might require a fix to tempest's code.20:25
lbragstadyeah, there is no functional change there20:25
morganfainberglbragstad, i love when we have tests that verify things are broken :P (not really anyone's fault, just… a headache)20:26
*** anteaya has joined #openstack-dev20:26
lbragstadmorganfainberg: :) so are you going to rebase https://review.openstack.org/#/c/46207/ on the one-liner?20:27
morganfainberglbragstad, hrm? no. the ref.copy() was added in a previous patchset, that was the diff between 19 and 20.20:29
morganfainberglbragstad, i just uploaded a new patchset with that fixed.20:29
lbragstadmorganfainberg: ahh, yep... following now20:29
*** jasdeepH has quit IRC20:33
*** sgordon has quit IRC20:33
*** alop has joined #openstack-dev20:33
*** sarob has joined #openstack-dev20:34
*** sarob has quit IRC20:34
*** sarob has joined #openstack-dev20:35
*** networkstatic has quit IRC20:35
*** shakayumi has quit IRC20:36
*** alop_ has joined #openstack-dev20:38
*** alop has quit IRC20:38
*** alop_ is now known as alop20:38
*** kevinconway has joined #openstack-dev20:40
*** amerine has quit IRC20:41
*** pamacii is now known as BLOODBATH20:41
*** networkstatic has joined #openstack-dev20:42
*** eharney has quit IRC20:42
*** jasdeepH has joined #openstack-dev20:44
*** BLOODBATH is now known as pamacii20:45
*** tmclaugh[work] has quit IRC20:46
*** anteaya has quit IRC20:47
*** sarob has quit IRC20:48
*** sarob has joined #openstack-dev20:49
*** Ryan_Lane1 has quit IRC20:49
*** Ryan_Lane has joined #openstack-dev20:49
*** sarob has quit IRC20:54
*** jvrbanac has joined #openstack-dev20:56
*** otherwiseguy has quit IRC20:57
morganfainbergdolphm, ping20:59
*** shinylasers has quit IRC21:04
*** sarob has joined #openstack-dev21:05
*** bfschott has quit IRC21:05
*** otherwiseguy has joined #openstack-dev21:06
*** Farooque has left #openstack-dev21:06
*** thomasm has quit IRC21:07
*** sarob has quit IRC21:07
*** sarob has joined #openstack-dev21:08
*** sarob_ has joined #openstack-dev21:09
*** sarob has quit IRC21:09
*** pamacii has quit IRC21:10
*** thomasm has joined #openstack-dev21:11
*** mriedem has left #openstack-dev21:14
*** rfolco has quit IRC21:16
*** Ryan_Lane has quit IRC21:17
*** Ryan_Lane has joined #openstack-dev21:17
*** networkstatic has quit IRC21:18
*** ericw has quit IRC21:18
*** thomasm has quit IRC21:18
*** anniec has joined #openstack-dev21:19
*** EmilienM has quit IRC21:22
*** litong has quit IRC21:23
*** dolphm has quit IRC21:23
*** EmilienM has joined #openstack-dev21:23
*** adjohn has joined #openstack-dev21:24
*** dsirrine has quit IRC21:26
*** jecarey has joined #openstack-dev21:30
*** ericw has joined #openstack-dev21:33
*** adjohn has quit IRC21:34
*** ericw has quit IRC21:34
*** jvrbanac has quit IRC21:35
*** sandywalsh_ has quit IRC21:37
*** adjohn has joined #openstack-dev21:37
*** xqueralt has quit IRC21:41
*** amohn9 has quit IRC21:42
*** adjohn has quit IRC21:44
*** flaper87 is now known as flaper87|afk21:44
*** adjohn has joined #openstack-dev21:44
*** xqueralt-afk has joined #openstack-dev21:45
*** xqueralt-afk is now known as xqueralt21:45
*** SumitNaiksatam has quit IRC21:50
*** stevemar has quit IRC21:53
*** maheshp has quit IRC21:53
*** sandywalsh_ has joined #openstack-dev21:54
*** adalbas has quit IRC21:54
*** SumitNaiksatam has joined #openstack-dev21:55
*** kpavel has quit IRC21:57
*** davidhadas has quit IRC21:58
*** neelashah has quit IRC21:58
*** davidhadas has joined #openstack-dev21:59
*** jasdeepH has quit IRC22:00
*** bdpayne has quit IRC22:00
*** neelashah has joined #openstack-dev22:01
*** bdpayne has joined #openstack-dev22:02
*** carl_baldwin has quit IRC22:03
*** jasdeepH has joined #openstack-dev22:03
*** anniec has quit IRC22:03
*** alop has quit IRC22:04
*** alop has joined #openstack-dev22:04
*** amohn9 has joined #openstack-dev22:07
*** neelashah has quit IRC22:09
*** neelashah has joined #openstack-dev22:09
*** rnirmal has joined #openstack-dev22:11
*** rnirmal has quit IRC22:11
*** gfidente has quit IRC22:11
*** sarob_ has quit IRC22:11
*** sarob has joined #openstack-dev22:11
*** troytoman is now known as troytoman-away22:11
*** dims has quit IRC22:16
*** sarob has quit IRC22:16
*** neelashah has quit IRC22:17
*** noslzzp has quit IRC22:21
*** noslzzp has joined #openstack-dev22:22
*** kbringard has quit IRC22:23
*** jmontemayor has quit IRC22:24
*** prad has quit IRC22:24
*** alop has quit IRC22:26
*** dims has joined #openstack-dev22:31
*** openstack has quit IRC22:35
*** openstack has joined #openstack-dev22:35
*** dstufft has quit IRC22:36
*** davidhadas_ has joined #openstack-dev22:36
*** noslzzp has quit IRC22:36
*** jecarey has quit IRC22:37
*** noslzzp has joined #openstack-dev22:37
*** davidhadas has quit IRC22:37
*** pcm_ has quit IRC22:38
*** xqueralt is now known as xqueralt-afk22:39
*** amohn9 has quit IRC22:41
*** sarob has joined #openstack-dev22:42
*** beekneemec has quit IRC22:43
*** yuan has quit IRC22:45
*** noslzzp has quit IRC22:45
*** pmathews has quit IRC22:46
*** sarob has quit IRC22:47
*** slagle has joined #openstack-dev22:52
*** kdbrierly has quit IRC22:53
*** ericw has joined #openstack-dev22:55
*** noslzzp has joined #openstack-dev22:57
*** amohn9 has joined #openstack-dev22:57
*** davidhadas_ has quit IRC22:58
*** davidhadas has joined #openstack-dev23:00
morganfainberglbragstad, ping23:00
*** otherwiseguy has quit IRC23:01
morganfainberghenrynash / ayoung, ping23:01
*** dstufft has joined #openstack-dev23:03
*** branen has quit IRC23:03
*** noslzzp has quit IRC23:03
*** herndon has quit IRC23:04
*** ericw has quit IRC23:05
*** anniec has joined #openstack-dev23:05
*** noslzzp has joined #openstack-dev23:06
*** sarob has joined #openstack-dev23:10
*** FunnyLookinHat has quit IRC23:11
*** med_ has quit IRC23:13
*** kyleh1 has quit IRC23:13
*** adalbas has joined #openstack-dev23:15
*** sarob_ has joined #openstack-dev23:20
*** sarob has quit IRC23:23
*** sarob_ has quit IRC23:24
*** sarob has joined #openstack-dev23:25
*** hemna is now known as hemnafk23:27
notmynamedhellmann: it was the pbr version. I thought I had already updated that. I must have updated on my VM, not the host. thanks for the help23:30
*** vuil has quit IRC23:32
*** michchap has quit IRC23:32
*** gyee has quit IRC23:33
*** michchap has joined #openstack-dev23:34
*** rwsu has quit IRC23:38
*** edmund has quit IRC23:38
*** Ryan_Lane has quit IRC23:40
*** Ryan_Lane has joined #openstack-dev23:40
*** gyee has joined #openstack-dev23:41
*** herndon has joined #openstack-dev23:50
*** ericw has joined #openstack-dev23:52
morganfainberggyee, you here (I saw ya in infra asking about stuff)23:53
morganfainberggyee, was just wanting a 2nd opinion on something if you are23:53
gyeemorganfainberg, yeah, my corporate proxy is messing me up23:53
morganfainberggyee, boo23:53
morganfainberggyee, corporate proxy ick23:53
gyeeI had to use corkscrew to tunnel ssh through23:53
morganfainbergouch23:53
gyeeyeah, I was going to murder somebody at IT23:54
gyeebut thought better of it :)23:54
morganfainberggyee, hehe23:54
*** maheshp has joined #openstack-dev23:54
morganfainberggyee, really quick: https://review.openstack.org/#/c/46207/22/keystone/common/controller.py line 270.  i removed a ref.copy(), i am thinking it isn't important to isolate the data w/ an explicit copy at this point23:54
morganfainbergsince it's the same as the domain_id filter23:55
morganfainberggyee, just wanted to get a quick 2nd opinion on that23:55
gyeelooking23:55
*** medberry has joined #openstack-dev23:55
*** medberry has quit IRC23:55
*** medberry has joined #openstack-dev23:55
*** adjohn has quit IRC23:56
*** amerine has joined #openstack-dev23:56
gyeemorganfainberg, no need to return ref23:58
gyeeyou are already modifying ref23:58
morganfainberghrm.23:58
gyeeso it already have the changes23:58
morganfainbergfor the implicit list comprehension it would bve needed23:58
*** davidhadas has quit IRC23:59
*** dims has quit IRC23:59
morganfainbergin a number of places we did return self._filter_domain(ref)23:59
morganfainbergand i replaced those with this where appropriate23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!