*** gongysh has joined #openstack-dev | 00:00 | |
lbragstad | ok, right. | 00:00 |
---|---|---|
lbragstad | want me to add a comment to that? | 00:00 |
*** matsuhashi has joined #openstack-dev | 00:00 | |
jamielennox | interestingly you can patch MySQLdb and psycopg, i wonder why we aren't donig that | 00:00 |
lbragstad | yeah, I saw that too, I didn't know that | 00:00 |
CaptainMorgan | jamielennox, because we didn't do it :P | 00:00 |
CaptainMorgan | i don't really know though | 00:01 |
jamielennox | CaptainMorgan: all the problems they have with mysqldb and eventlet - seems like that would have been a solution | 00:01 |
*** danwent has joined #openstack-dev | 00:01 | |
CaptainMorgan | jamielennox, fair point. but it could introduce all sorts of other… fun | 00:01 |
CaptainMorgan | hm. | 00:02 |
CaptainMorgan | maybe this test is going to work first try | 00:02 |
CaptainMorgan | (haha yah, right) | 00:02 |
jamielennox | lbragstad: i would add MySQLdb and psycopg to the list you pass to monkey_patch with =false and say in a comment that this is the complete listing of what is supported by monkey_patch | 00:02 |
jamielennox | that way default is irrelevant | 00:03 |
lbragstad | jamielennox: ok, yeah I like that idea. I'll respin that. | 00:03 |
CaptainMorgan | dolphaaarrrggghh, that name is still awesome for today | 00:03 |
AyoungTheRed | jamielennox, we can discuss here | 00:04 |
jamielennox | pshh, the pirate thing was so yesterday | 00:04 |
roaet | CaptainMorgan: I think I may have got help from someone in neutron, if it turns out to be correct I will blog and link you. Thank you for the help you gave. | 00:04 |
*** herndon has joined #openstack-dev | 00:04 | |
lbragstad | jamielennox: I missed the whole pirate thing apparently :) | 00:05 |
*** reed has quit IRC | 00:05 | |
*** reed has joined #openstack-dev | 00:06 | |
*** senk has quit IRC | 00:06 | |
jamielennox | it falls on my anniversary - unfortunately it's sometimes the pirate thing that reminds me of the anniversary rather than the other way around | 00:06 |
CaptainMorgan | roaet, nice | 00:06 |
*** michchap has quit IRC | 00:06 | |
*** rwsu has quit IRC | 00:07 | |
CaptainMorgan | lbragstad, i kind of missed it too, except when i saw AyoungTheRed earlier today | 00:07 |
AyoungTheRed | Avast and Ahoy ye lubbers! | 00:07 |
jamielennox | AyoungTheRed: ok, so i take it you saw the fleshed out version of the blueprint? | 00:07 |
lbragstad | jamielennox: well... a reminder is a reminder! | 00:07 |
AyoungTheRed | jamielennox, nah, just coming back to work now... | 00:07 |
AyoungTheRed | let me look | 00:07 |
jamielennox | i haven't changed it since (my) yesterday | 00:07 |
jamielennox | if you saw the etherpad it hasn't changed | 00:08 |
AyoungTheRed | https://blueprints.launchpad.net/devstack/+spec/devstack-https ? | 00:08 |
jamielennox | yep, and the linked etherpad | 00:09 |
*** michchap has joined #openstack-dev | 00:09 | |
*** thomasm has quit IRC | 00:09 | |
AyoungTheRed | jamielennox, ah, no, I didn't see the linked etherpad. | 00:09 |
jamielennox | ok, so my first thing is for this blueprint i'm not talking about how to do certificate generation - all i want to do is seed certificates into there right place | 00:10 |
AyoungTheRed | jamielennox, OK, gave it a quick read...so I think that I would say: | 00:10 |
AyoungTheRed | 1. SSL_ENABLED_SERVICES good | 00:11 |
AyoungTheRed | 2. Use Cert monger to manage them instead of the envvars | 00:11 |
jamielennox | so the way i'm testing this currently is putting KEYSTONE_SSL_CA KEYSTONE_SSL_KEY KEYSTONE_SSL_CERT with files into localrc | 00:11 |
AyoungTheRed | jamielennox, you think people want to manage them by hand? | 00:11 |
jamielennox | no, but i think that if we work with the ENV vars then generation just becomes a matter of assigning the right variables | 00:12 |
jamielennox | and i think there are situations where you want to have certain certificates used | 00:12 |
AyoungTheRed | jamielennox, I have a feeling it is going to be duplicate work with Certmonger, | 00:12 |
jamielennox | so i did some reading on certmonger - to my understanding it's got not a lot to do with this other than generation | 00:13 |
AyoungTheRed | jamielennox, I would think that the services should have a default location specified in their config files, and we should honor those | 00:13 |
AyoungTheRed | and getting the certs into the right locations... | 00:13 |
AyoungTheRed | so you think that this and certmonger are complementary? | 00:14 |
jamielennox | i think if we say that certmonger is the only way we do this it will get rejected | 00:14 |
jamielennox | i think they are complementary as to my understanding certmonger can still generate PEM certs | 00:14 |
AyoungTheRed | well, I would write it up in the blueprint, and have the discussion around that. | 00:14 |
jamielennox | or can still manage PEM certs | 00:14 |
AyoungTheRed | Yeah, | 00:14 |
AyoungTheRed | so the question is if we need explicit variables saying where the certs go, and, if we have them, what do we do with them | 00:15 |
jamielennox | so whether the certs come from certmonger, the already in place cert generation stuff for tls-proxy or some outside source won't matter | 00:15 |
jamielennox | go? currenlty i'm not putting them anywhere. The path in the variable should be server readable | 00:15 |
jamielennox | that would be a seperate devstack setting | 00:16 |
jamielennox | so you say generate with certmonger, it creates a folder a new db and ca and generates some certs | 00:16 |
jamielennox | those values seed the variables and the whole show carries on | 00:16 |
AyoungTheRed | jamielennox, can we get it down to just SSL_ENABLED_SERVICES and then use the service config files to state where the files are? | 00:16 |
AyoungTheRed | we can potentially use the same certificates for multiple services, so having 3 variables per service seems like a lot to manage | 00:17 |
jamielennox | that's down somewhere in future optimizations | 00:18 |
jamielennox | yes, i agree and i'm not worried about it right now | 00:18 |
*** hemanth has quit IRC | 00:18 | |
jamielennox | what do you mean "use the service config files to state where the files are?" the service config file are always going to be where these variables end up, the ENV vars thing is just how you let devstack no what to put in them | 00:19 |
jamielennox | wow, just used no instead of know | 00:19 |
AyoungTheRed | jamielennox, but they have default values already. For example, keystone knows where to put its ssl certs | 00:19 |
AyoungTheRed | https://github.com/openstack/keystone/blob/master/keystone/common/config.py#L96 | 00:20 |
*** lucasagomes has quit IRC | 00:20 | |
AyoungTheRed | devstack should use those variables | 00:20 |
AyoungTheRed | values | 00:20 |
*** 16WAA3R0O has joined #openstack-dev | 00:20 | |
AyoungTheRed | I'd just say have the SSL_ENABLED_SERVICES and then put the files where the the config files say they should go. | 00:21 |
*** sarob_ has joined #openstack-dev | 00:22 | |
AyoungTheRed | jamielennox, I'm envisioning this being something that is eventaully automated: a service has a standard way to tell certmonger: put my files here: | 00:22 |
AyoungTheRed | I think systemd already has an abstraction along those lines. Ask nalin, though | 00:22 |
jamielennox | in the case of generating then you have to create a folder and ca, generate a bunch of certificates copy them into the place expected by the server and still enable the variables in the config file | 00:22 |
jamielennox | why not just point the service to where the certs were generated | 00:23 |
AyoungTheRed | again, all cermonger stuff. | 00:23 |
*** nosnos has joined #openstack-dev | 00:23 | |
jamielennox | for example in swift there is no ssl enable config - the presence of the cert_file and key_file variables says you should use ssl | 00:23 |
jamielennox | if i have to enable the cert_file and key_file variables with the default values - why not just point them at the place where the certificates actually live? | 00:23 |
*** esheffield has quit IRC | 00:24 | |
lbragstad | jamielennox: respun and comment added: https://review.openstack.org/#/c/47444/ | 00:24 |
*** sarob has quit IRC | 00:24 | |
AyoungTheRed | jamielennox, tell you what, can you give certmonger a test run, and see if it changes how you would write the rest of the code? If you find out that it really does make no difference, I'll approve your current approach. Deal? | 00:25 |
jamielennox | lbragstad: +1 | 00:25 |
lbragstad | jamielennox: thank you sir | 00:26 |
AyoungTheRed | lbragstad, looking | 00:26 |
jamielennox | AyoungTheRed: that patch still needs some fixes but sure | 00:26 |
*** sarob_ has quit IRC | 00:26 | |
AyoungTheRed | lbragstad, so...what if they add an additional parameter to monkeypatch on us? | 00:26 |
lbragstad | AyoungTheRed: looks like it | 00:26 |
lbragstad | AyoungTheRed: https://bitbucket.org/eventlet/eventlet/src/57e2f608e0dd5988712c0fda50e865a4ff8f887a/eventlet/patcher.py?at=default#cl-197 | 00:27 |
AyoungTheRed | lbragstad, pretty sure the mysql and psycodb opnes weren't there when last I looked.... | 00:27 |
jamielennox | AyoungTheRed: it will default to false | 00:27 |
lbragstad | jamielennox: and I were discussing earlier | 00:27 |
AyoungTheRed | are you sure all=false is no longer supported? | 00:27 |
lbragstad | AyoungTheRed: here it is | 00:27 |
lbragstad | http://eventlet.net/doc/basic_usage.html#patching-functions | 00:27 |
*** markmc has quit IRC | 00:27 | |
AyoungTheRed | lbragstad, I read it...but wasn't sure if you had definitively decided that. | 00:27 |
AyoungTheRed | lbragstad, nah, don't trust the docs. Read the code | 00:28 |
lbragstad | AyoungTheRed: ok, yeah because another doc saying something different, or doens't list the all option | 00:29 |
jamielennox | AyoungTheRed: all is supported it acts as an explicit default value, if not provided the fact that you are saying to specifically patch certain modules means it will default to False | 00:29 |
lbragstad | AyoungTheRed: figured being explicit offered better readability | 00:29 |
jamielennox | not to mention if they were explicitly laid out like that before you'd think someone would notice 'why is select not patched?' | 00:30 |
lbragstad | jamielennox: +1 | 00:31 |
AyoungTheRed | lbragstad, I like the explicit list, just reading the code to see if we still want all=False to catch any others | 00:31 |
jamielennox | mind you it makes me wonder why MySQLdb is not patched - but i don't want to deal with the headache of figuring that out | 00:31 |
*** spzala has quit IRC | 00:31 | |
lbragstad | :) | 00:31 |
lbragstad | I was unaware of psycopg and MySQLdb | 00:31 |
*** slagle has quit IRC | 00:31 | |
lbragstad | until jamielennox pointed them out | 00:31 |
AyoungTheRed | http://fpaste.org/40882/13796371/ | 00:32 |
jamielennox | i am gusessing that psycopg != psycopg2 because i understood pg and eventlet were ok | 00:32 |
AyoungTheRed | actually, I cut off the interesting part | 00:32 |
jamielennox | AyoungTheRed: it's lined above already | 00:32 |
*** sthaha has joined #openstack-dev | 00:33 | |
*** sthaha has quit IRC | 00:33 | |
*** sthaha has joined #openstack-dev | 00:33 | |
AyoungTheRed | http://fpaste.org/40883/37195137/ | 00:33 |
AyoungTheRed | jamielennox, I thought we were behind the mainline on evetlet, though...I was looking at what is installed on F19. Cuz I'm paranoid. Especially since it looks like this code has changed since last I browsed it | 00:34 |
AyoungTheRed | but am I paranoid enough? | 00:34 |
jamielennox | lbragstad: now that i think about it, it might be worth checking out when psycopg and MySQLdb were add to the function if it's after our supported eventlet version you might need to do all=False and just comment those two | 00:35 |
*** senk has joined #openstack-dev | 00:36 | |
AyoungTheRed | lbragstad I think your code is ok...the F19 version is pretty conservative. python-eventlet-0.12.0-1.fc19.noarch upstream is a o.15 | 00:36 |
jamielennox | lbragstad: global requirements are >= 0.13 which is this file: https://bitbucket.org/eventlet/eventlet/src/d358c9a8cbdbe7112651f072e0da259fd6c4b917/eventlet/patcher.py?at=0.13#cl-197 | 00:37 |
jamielennox | so it's fine | 00:37 |
AyoungTheRed | at least they got off of mercurial only.... | 00:37 |
lbragstad | AyoungTheRed: jamielennox ok sounds good | 00:37 |
AyoungTheRed | I can ack | 00:37 |
lbragstad | thanks for looking at that | 00:38 |
AyoungTheRed | jamielennox, added you to https://review.openstack.org/#/c/33473/ | 00:39 |
jamielennox | AyoungTheRed: will the certmonger selfsigned be enough to satisfy or do i need to do a full IPA linkup? | 00:39 |
AyoungTheRed | selfsigned | 00:40 |
AyoungTheRed | jamielennox, IPA would probably be an extension of the cermonger selfsigned approach | 00:40 |
jamielennox | that was my thought - and i don't want to have to figure out how that works yet | 00:41 |
jamielennox | AyoungTheRed: ughh, they are doing this with httplib | 00:41 |
*** sdake_ has quit IRC | 00:42 | |
jamielennox | and they have eventlet it the client | 00:42 |
AyoungTheRed | jamielennox, yeah. I mentioned that in an earlier review. But they have to | 00:42 |
AyoungTheRed | eventlet in the client? I missed that | 00:43 |
AyoungTheRed | oh, yeah, that was pre-existing | 00:44 |
*** sdake_ has joined #openstack-dev | 00:44 | |
AyoungTheRed | anyway, the SSL compression thing is a pretty big deal. They need to fix that in requests before swift can move over to it | 00:44 |
jamielennox | what is happening in requests? | 00:44 |
*** senk has quit IRC | 00:45 | |
AyoungTheRed | jamielennox, lookat my discussion earlier in the review...patch 9ish | 00:45 |
AyoungTheRed | no way to turn off ssl compression. I don;'t know if they submitted a fix for that upstream yet, but enabling ssl in httplib2 since they are already using it seems like a reasonable stopgap | 00:46 |
*** dolphaaarrrggghh has quit IRC | 00:47 | |
CaptainMorgan | garhyee, ping | 00:47 |
jamielennox | AyoungTheRed: hmm, i'll have a look into if that is correct (i assume they are correct) | 00:48 |
*** aeperezt has quit IRC | 00:48 | |
*** patelna has quit IRC | 00:48 | |
*** vipul is now known as vipul-away | 00:48 | |
AyoungTheRed | jamielennox, anyway, for certmonger, the intial allocation should be something like getcert-request -F {name}_SSL_CERT -k {name}_SSL_KEY so maybe we do start with what you have, and then figure out how to populate those valus from the config files and options...it would be great if we could actually query the config exteranal to the service. | 00:50 |
*** faramir has joined #openstack-dev | 00:51 | |
AyoungTheRed | I am really wishing devstack were in Python... | 00:52 |
*** thomasm has joined #openstack-dev | 00:52 | |
CaptainMorgan | AyoungTheRed, ++ i wish that quite often thesedays | 00:52 |
CaptainMorgan | AyoungTheRed, simply for internal use cases, not even for what you and jamielennox are looking at | 00:53 |
*** vipul-away is now known as vipul | 00:53 | |
*** Ryan_Lane has quit IRC | 00:54 | |
*** dolphaaarrrggghh has joined #openstack-dev | 00:54 | |
AyoungTheRed | CaptainMorgan, the idea of slowly slipping python in there as helper functions is more and more tempting every day | 00:54 |
*** Ryan_Lane has joined #openstack-dev | 00:55 | |
CaptainMorgan | AyoungTheRed, hehe | 00:55 |
CaptainMorgan | dolphaaarrrggghh, ping | 00:55 |
dolphaaarrrggghh | CaptainMorgan: pong | 00:55 |
dolphaaarrrggghh | CaptainMorgan: weren't we supposed to merge something today | 00:56 |
CaptainMorgan | dolphaaarrrggghh, when writing a SQL Migrate test, do i need to initialize a new metadata object before instantiating the table object with autoload if columns change? | 00:56 |
*** Ryan_Lane has quit IRC | 00:56 | |
*** Ryan_Lane1 has joined #openstack-dev | 00:56 | |
CaptainMorgan | dolphaaarrrggghh, i'm addressing the last of bknudson's comments | 00:56 |
CaptainMorgan | the sql upgrade test keeps loading the wrong version of the table. | 00:56 |
CaptainMorgan | so, the test can't pass | 00:56 |
jamielennox | they have a good point though, bash is supposed to be somewhat equivalent to what an admin would do and devstack is fairly heavily commented, python would just be another script that does some magic | 00:58 |
dolphaaarrrggghh | CaptainMorgan: umm, i think i always instantiate it first, but it almost sounds like you're trying to do something implicitly that should be explicit? | 00:58 |
jamielennox | AyoungTheRed: regarding "getcert-request -F {name}_SSL_CERT -k {name}_SSL_KEY" i think you have it backwards, but i'll code it up and show you what i mean | 00:58 |
CaptainMorgan | dolphaaarrrggghh, well i'm doing self.updgrade(<version>) insert data self.upgrade(<next version>) and then instantiate the table object, when i do the query, the new column isn't present | 00:59 |
CaptainMorgan | dolphaaarrrggghh, this is in the context of the SqlMigrateBase tests | 00:59 |
*** danwent has quit IRC | 01:00 | |
CaptainMorgan | dolphaaarrrggghh, and the converse (downgrade test) can't do the select because the old column is still showing up on the table object | 01:00 |
* CaptainMorgan curses ORM when it doesn't work intuitively. | 01:00 | |
CaptainMorgan | I guess i could stop trying to use it as an ORM and just use it as direct SQL execute mechanism (since it's tests only) | 01:01 |
*** Ryan_Lane1 is now known as Ryan_Lane | 01:03 | |
*** Ryan_Lane has joined #openstack-dev | 01:03 | |
*** dvarga has joined #openstack-dev | 01:04 | |
*** Ryan_Lane has quit IRC | 01:04 | |
AyoungTheRed | jamielennox, backwards? I thought I was agreeing with you. You need to know where they go, so you tell certmonger. Certmonger will then create them if required. | 01:06 |
*** dvarga has quit IRC | 01:06 | |
AyoungTheRed | so devstack will have that set of variables, and will call certmonger to do the allocation | 01:06 |
jamielennox | no because they won't be supplied if they aren't available | 01:07 |
jamielennox | so if not (SSL_CERT and SSL_KEY ): | 01:07 |
garhyee | CapainMorgan, sorry, I was afk | 01:08 |
garhyee | what's up | 01:08 |
jamielennox | getcert-request -F keystone.cert -k keystone.key | 01:08 |
jamielennox | KEYSTONE_SSL_CERT = `pwd`/keystone.cert | 01:08 |
*** jab416171 has quit IRC | 01:09 | |
jamielennox | anyway i'll write it and show you | 01:09 |
*** otherwiseguy has joined #openstack-dev | 01:09 | |
CaptainMorgan | garhyee, i think i figured it out | 01:09 |
CaptainMorgan | garhyee, was struggling with a migrate test. | 01:09 |
garhyee | ah ok | 01:10 |
garhyee | just blame AyoungTheRed, standard operating procedure :D | 01:10 |
CaptainMorgan | garhyee, dolphaaarrrggghh, I should have another patchset to address bknudson's comments for the tenantId cleanup stuff in a couple minutes | 01:11 |
CaptainMorgan | i'll let you know when it | 01:11 |
CaptainMorgan | 's posted so i can get some eyes on it | 01:11 |
* garhyee is GTFBT code review | 01:11 | |
CaptainMorgan | GTfBT? whats the BT standfor? | 01:12 |
garhyee | back to | 01:12 |
CaptainMorgan | ahh. | 01:12 |
CaptainMorgan | i seeeeeee | 01:12 |
*** lcheng has quit IRC | 01:14 | |
CaptainMorgan | ugh. i think i just realized i should have made something a class method instead of static. | 01:16 |
*** novas0x2a|laptop has quit IRC | 01:16 | |
*** mestery has joined #openstack-dev | 01:18 | |
*** stevemar has joined #openstack-dev | 01:22 | |
*** sdake_ has quit IRC | 01:23 | |
garhyee | CaptainMorgan, https://review.openstack.org/#/c/45903/ | 01:25 |
garhyee | not sure if I understand your concern | 01:25 |
CaptainMorgan | looking now | 01:25 |
garhyee | we don't reissue token on validation | 01:25 |
CaptainMorgan | garhyee, isn't he asking for a mechanism to say "validate this token, but return the data w/o catalog"? | 01:26 |
garhyee | yes | 01:26 |
*** cthulhup has joined #openstack-dev | 01:26 | |
CaptainMorgan | so, with a PKI token, you'd either have bogus data returned or need for a new token to be issued | 01:27 |
garhyee | PKI tokens can be validated either locally or over the wire | 01:27 |
AyoungTheRed | jamielennox, is the requests library going to let us use NSS for the certs, or is it openssl specific? I think this is why the FreeIPA project ended up using libcurl | 01:27 |
CaptainMorgan | since you're changing the content of the token | 01:27 |
jamielennox | AyoungTheRed: it requires a PEM cert | 01:27 |
CaptainMorgan | validate returns the content of the token in json | 01:27 |
garhyee | CaptainMorgan, token validation, over the wire, does not check for signature | 01:27 |
jamielennox | AyoungTheRed: oh underneath - i'm not sure i'm pretty sure it uses openssl | 01:28 |
*** dstanek has joined #openstack-dev | 01:28 | |
garhyee | we merely doing a lookup of the hashed token ID | 01:28 |
CaptainMorgan | garhyee, ok. | 01:28 |
CaptainMorgan | garhyee, i was assuming this would be something like "Validate token" and take that info to consitute something that gets passed into auth-token | 01:29 |
AyoungTheRed | jamielennox, OK, I can get a PEM cert, but suspect that this will be an issue for the NSSification | 01:29 |
jamielennox | AyoungTheRed: it's not a requests thing, that would be a urllib3 thing | 01:29 |
CaptainMorgan | garhyee, then i'll remove the -1 in a short bit here. | 01:29 |
garhyee | no, validate toke over the wire basically means 1) is the token still exist, and 2) return the token data | 01:29 |
*** adjohn has quit IRC | 01:30 | |
*** dkranz has joined #openstack-dev | 01:30 | |
garhyee | CaptainMorgan, cool, thanks | 01:30 |
CaptainMorgan | garhyee, right. i'm curious the point of not passing the catalog along in that case. short of just a little less data on the wire. | 01:30 |
CaptainMorgan | garhyee, but i could see people asking for that. | 01:30 |
*** cthulhup has quit IRC | 01:30 | |
garhyee | because a large service catalog will push PKI tokens over the limit | 01:31 |
CaptainMorgan | limit of? | 01:31 |
garhyee | most servers have a limit on 8K header | 01:31 |
garhyee | limit of | 01:31 |
*** mestery has quit IRC | 01:31 | |
CaptainMorgan | but, we already passed the token via header in. | 01:31 |
CaptainMorgan | and the data comes back json? | 01:32 |
garhyee | correct | 01:32 |
CaptainMorgan | so. how is that affecting the 8k header on validate? | 01:32 |
garhyee | but we are setting the service catalog in the header in auth_token middleware | 01:32 |
*** sarob has joined #openstack-dev | 01:32 | |
CaptainMorgan | we are? | 01:33 |
garhyee | yes :) | 01:33 |
CaptainMorgan | but authtoken doesn't wire validate pki tokens… | 01:33 |
jamielennox | AyoungTheRed: it's more than that really the whole python ssl stack is set up to emulate openssl, not even httplib or inbuilt ssl will let you do nss | 01:33 |
CaptainMorgan | ugh, i'm just confused here. | 01:33 |
*** networkstatic_ has joined #openstack-dev | 01:33 | |
*** networkstatic_ has quit IRC | 01:33 | |
garhyee | https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L903 | 01:34 |
AyoungTheRed | jamielennox, I know they used libcurl in freeipa. I just haven't looked that deeply yet | 01:34 |
AyoungTheRed | jamielennox, but, so far, so goo | 01:34 |
AyoungTheRed | d | 01:34 |
CaptainMorgan | garhyee, i'll look in a sec, trying to debug sqlalchemy bug in my code ;) | 01:34 |
*** networkstatic has quit IRC | 01:34 | |
garhyee | CaptainMorgan, we need to make both middleware and API changes to optionally opt-out of service catalog | 01:34 |
*** rnirmal has joined #openstack-dev | 01:35 | |
garhyee | AyoungTheRed, are you making Keystone a CA service? :) | 01:36 |
*** thomasm has quit IRC | 01:36 | |
*** sarob has quit IRC | 01:37 | |
*** jhesketh has quit IRC | 01:40 | |
*** 16WAA3R0O is now known as jhesketh | 01:40 | |
*** jhesketh__ has joined #openstack-dev | 01:40 | |
*** stevemar has quit IRC | 01:40 | |
*** senk has joined #openstack-dev | 01:41 | |
*** reed has quit IRC | 01:42 | |
*** erkules_ has joined #openstack-dev | 01:42 | |
*** angdraug has quit IRC | 01:44 | |
*** erkules has quit IRC | 01:45 | |
CaptainMorgan | garhyee, ok. so the goal with this change is to just not pass the catalog along so we don't set a header. | 01:45 |
*** senk has quit IRC | 01:45 | |
CaptainMorgan | garhyee, i think my eyes are going cross-eyed :P but you've convinced me there is a reason for the change. | 01:46 |
*** stevemar has joined #openstack-dev | 01:46 | |
*** dsirrine has joined #openstack-dev | 01:46 | |
CaptainMorgan | garhyee, -1 removed. | 01:46 |
garhyee | CaptainMorgan, thanks | 01:48 |
*** hemanth has joined #openstack-dev | 01:48 | |
*** hemanth has quit IRC | 01:49 | |
*** neelashah has joined #openstack-dev | 01:50 | |
*** Tross has joined #openstack-dev | 01:51 | |
CaptainMorgan | garhyee / dolphaaarrrggghh, https://review.openstack.org/#/c/46207/ | 01:52 |
CaptainMorgan | i _think_ i've covered everything now. | 01:52 |
garhyee | looking | 01:52 |
*** hemanth has joined #openstack-dev | 01:52 | |
CaptainMorgan | this one has made my head hurt a couple times :P | 01:53 |
*** herndon has quit IRC | 01:53 | |
AyoungTheRed | garhyee, no, I am not making Keystone a CA service. We are going to make Keystone and all the other services consume a real CA | 01:55 |
garhyee | AyoungTheRed, with OCSP support and everything? | 01:55 |
CaptainMorgan | AyoungTheRed, that could be quite useful | 01:56 |
AyoungTheRed | garhyee, Dogtag...by way of FreeIPA | 01:56 |
garhyee | nice! | 01:56 |
AyoungTheRed | http://pki.fedoraproject.org/wiki/PKI_Main_Page | 01:56 |
AyoungTheRed | garhyee, right now I am redoing this in Python http://adam.younglogic.com/2013/09/register-vm-freeipa/ | 01:57 |
AyoungTheRed | garhyee, but jamielennox is looking into setting up SSL for all services in devstack. | 01:57 |
AyoungTheRed | garhyee, and we'll use certmonger as the allocation scheme for them. Should have used that for Keystone in the first place | 01:58 |
*** Mandell has quit IRC | 01:58 | |
*** thomasm has joined #openstack-dev | 01:59 | |
*** thomasm has quit IRC | 01:59 | |
*** egallen has quit IRC | 01:59 | |
dolphaaarrrggghh | CaptainMorgan: cool, i like the explicit v3_to_v2_user() | 02:00 |
*** sarob has joined #openstack-dev | 02:01 | |
CaptainMorgan | dolphaaarrrggghh, yeah bknuson recommended that, i think it is a lot cleaner. | 02:01 |
garhyee | AyoungTheRed, how does FreeIPA working Neutron, in terms of floating IP, DNS, etc | 02:02 |
CaptainMorgan | dolphaaarrrggghh, i just realized something…. | 02:05 |
CaptainMorgan | dolphaaarrrggghh, i think this patchset violates string freeze | 02:05 |
*** herndon has joined #openstack-dev | 02:05 | |
dolphaaarrrggghh | CaptainMorgan: where? | 02:05 |
CaptainMorgan | dolphaaarrrggghh, config option name changes | 02:05 |
CaptainMorgan | https://wiki.openstack.org/wiki/StringFreeze | 02:06 |
CaptainMorgan | removing an option and adding another one. | 02:06 |
CaptainMorgan | but i mean, you're the PTL you can give an exception here. | 02:06 |
dolphaaarrrggghh | CaptainMorgan: it's two different options though? you're not changing one | 02:07 |
CaptainMorgan | removing an option, adding a new one | 02:07 |
dolphaaarrrggghh | CaptainMorgan: just happens to be in the same patch and looks very suspicious! | 02:07 |
CaptainMorgan | hehe | 02:07 |
CaptainMorgan | ok | 02:07 |
CaptainMorgan | just didn't want to run afoul of the SF w/o proper documentation | 02:07 |
* CaptainMorgan tries to think of a pirate way to phrase "ignore the string freeze" but just can't atm. | 02:08 | |
dolphaaarrrggghh | let me look into it a bit more before we approve | 02:08 |
dolphaaarrrggghh | but i don't *think* it's really a violation | 02:08 |
CaptainMorgan | dolphaaarrrggghh, nod. i mean, it might just be a case of toss up a comment in the commit | 02:08 |
dolphaaarrrggghh | agree | 02:08 |
*** jasdeepH has quit IRC | 02:09 | |
dolphaaarrrggghh | CaptainMorgan: would it be viable to split some amount of the domain-removal stuff into it's own commit? | 02:10 |
dolphaaarrrggghh | CaptainMorgan: maybe even just that one line delete | 02:11 |
CaptainMorgan | dolphaaarrrggghh, sure. i could split that out. | 02:12 |
garhyee | wow, I didn't now we never had default_project_id in the user table | 02:12 |
garhyee | s/now/know/ | 02:12 |
dolphaaarrrggghh | garhyee: yeah :( | 02:12 |
dolphaaarrrggghh | CaptainMorgan: that would at least better illustrate that user_domain_id_attribute is being cleanly removed, not changed | 02:12 |
CaptainMorgan | garhyee, yeah and it's made it a little messy to cleanup | 02:13 |
CaptainMorgan | sure. i'll go ahead and make a new commit for that and rebase this one onto that one. | 02:13 |
dolphaaarrrggghh | CaptainMorgan: other than that, you're changing the *default value* of an option, and adding a new option | 02:13 |
garhyee | I agree with dolphaaarrrggghh, better to split up the review | 02:13 |
CaptainMorgan | or.. vice-versa | 02:13 |
garhyee | make it easier | 02:13 |
CaptainMorgan | garhyee, trying to think if there is another section i can split like that easily | 02:13 |
CaptainMorgan | make it 3 changes vs. 1 | 02:14 |
garhyee | data migration can be its own | 02:14 |
CaptainMorgan | garhyee, actually it can't. it needs to be tied to the normalize (v3->v2 user) | 02:14 |
dolphaaarrrggghh | CaptainMorgan: 'suspenders and a belt check' | 02:15 |
garhyee | ha | 02:15 |
dolphaaarrrggghh | AyoungTheRed: are you moonlighting as CaptainMorgan? | 02:15 |
CaptainMorgan | dolphaaarrrggghh, yep. there should never be a case you get there. | 02:15 |
CaptainMorgan | lol | 02:15 |
*** santosh has joined #openstack-dev | 02:16 | |
CaptainMorgan | since i'm splitting this… should v3 update/create/etc explicitly remove tenantId if it's passed in? | 02:16 |
*** santosh is now known as Guest27505 | 02:16 | |
CaptainMorgan | basically say "uh, no, don't give me tenantId as a attribute for the user on v3" | 02:16 |
garhyee | CaptainMorgan, can the translation be done in middleware | 02:16 |
CaptainMorgan | garhyee, i don't think so easily. since a number of things embed user_refs in them (not a large number) | 02:17 |
CaptainMorgan | and i don't want to have to guess at what is a user_ref outside anywhere before it hits / after returned from the controller | 02:18 |
CaptainMorgan | garhyee, i might be over thinking that though. | 02:18 |
CaptainMorgan | garhyee, honestly, i think most of V2 semantics could be made middleware with enough time. | 02:19 |
CaptainMorgan | garhyee maybe that is the path of deprecation? | 02:19 |
CaptainMorgan | for v2.0 that is | 02:19 |
garhyee | CaptainMorgan, yeah | 02:19 |
garhyee | I was experimenting with v3 to v2 token data translation in middleware | 02:20 |
garhyee | till I ran into PKI tokens | 02:20 |
CaptainMorgan | garhyee, hehe. | 02:20 |
dolphaaarrrggghh | CaptainMorgan: i wouldn't be opposed to that | 02:21 |
dolphaaarrrggghh | CaptainMorgan: if you think that will help prevent regression | 02:21 |
dolphaaarrrggghh | CaptainMorgan: i am a bit paranoid of stomping on attribute names that people could be legitimately/intentionally writing to extra... but i don't think that would be a legitimate one | 02:22 |
dolphaaarrrggghh | that would just be an accident | 02:22 |
AyoungTheRed | garhyee, I haven't gottne the Neutron thing working yet. Bascially, I am allocating a floation ip first, telling FreeIPA about it, and then using that to set DNS/IPA | 02:23 |
CaptainMorgan | dolphaaarrrggghh, actually, i don't think it will matter. it'll only prevent regression in truely 3rd party apps if they assume "tenantId" is handled specially inside keystone | 02:23 |
CaptainMorgan | dolphaaarrrggghh, i think it's fine to just leave it as is. the V2.0 will just override it with the default_project_id. | 02:24 |
dolphaaarrrggghh | CaptainMorgan: exactly :) | 02:24 |
*** cdub_ has joined #openstack-dev | 02:24 | |
AyoungTheRed | Keystone has become the midnight crew. | 02:24 |
CaptainMorgan | dolphaaarrrggghh, though i am not removing "tenantId" if it exists and default_project_id is None | 02:25 |
*** dims has quit IRC | 02:25 | |
CaptainMorgan | maybe i should add the pop back in if tenantId is there and default_project_id is None in the DB? | 02:25 |
CaptainMorgan | s/None/Null | 02:25 |
CaptainMorgan | s/pop/del | 02:25 |
dolphaaarrrggghh | AyoungTheRed: ++ | 02:26 |
dolphaaarrrggghh | CaptainMorgan: you mean if tenantId is in the request, pop it off? | 02:26 |
dolphaaarrrggghh | CaptainMorgan: in an update, or what? | 02:26 |
CaptainMorgan | https://review.openstack.org/#/c/46207/18/keystone/common/controller.py line 261 | 02:27 |
CaptainMorgan | if default_tenant_id is Null in the DB (None here) | 02:27 |
CaptainMorgan | and the user has something in tenantId in the extra feild | 02:27 |
CaptainMorgan | tenantId would still be populated | 02:27 |
CaptainMorgan | possibly with bogus data. | 02:27 |
CaptainMorgan | that could confuse things. | 02:28 |
*** Tross has quit IRC | 02:28 | |
CaptainMorgan | solution would be to elif 'tenantId' in ref: del ref['tenantId'] | 02:28 |
CaptainMorgan | create/update/etc shouldn't care. | 02:29 |
CaptainMorgan | this is called everywhere important. | 02:29 |
garhyee | CaptainMorgan, I'll finish up the review later tonight, need to be offline for a couple of hours, sorry | 02:31 |
*** rnirmal has quit IRC | 02:31 | |
*** garhyee has quit IRC | 02:31 | |
CaptainMorgan | garhyee, no worries going to split the domain_id config option out into a separate patch, but should be very similar. | 02:31 |
dolphaaarrrggghh | hmmmmmm | 02:32 |
*** thomasm has joined #openstack-dev | 02:34 | |
*** paragan has joined #openstack-dev | 02:34 | |
*** paragan has joined #openstack-dev | 02:34 | |
*** Ryan_Lane has joined #openstack-dev | 02:35 | |
*** edmund1 has joined #openstack-dev | 02:35 | |
CaptainMorgan | dolphaaarrrggghh, yeah, i think that eliminates some extra logic in removing/adding a user if someone changes tenantId in an update. | 02:39 |
CaptainMorgan | dolphaaarrrggghh, going with that. next patchset will also split the config.py and sample.conf removal of the user_domain_id attribute. | 02:40 |
CaptainMorgan | config option that is | 02:41 |
*** herndon has quit IRC | 02:47 | |
*** stevemar has quit IRC | 02:51 | |
*** xjiujiu has joined #openstack-dev | 02:54 | |
*** michchap_ has joined #openstack-dev | 02:55 | |
*** reed has joined #openstack-dev | 02:57 | |
dolphaaarrrggghh | CaptainMorgan: alrighty | 02:58 |
CaptainMorgan | dolphaaarrrggghh, ok https://review.openstack.org/#/c/46207/ and https://review.openstack.org/#/c/47514/ | 02:58 |
dolphaaarrrggghh | CaptainMorgan: that was fast | 02:58 |
*** michchap has quit IRC | 02:58 | |
*** danwent has joined #openstack-dev | 02:59 | |
CaptainMorgan | dolphaaarrrggghh, i was just waiting on tests :P | 02:59 |
CaptainMorgan | already had it staged up. | 02:59 |
* CaptainMorgan blames his IDE for being able to do that relatively quickly | 02:59 | |
dolphaaarrrggghh | CaptainMorgan: conf and domain-related changes look good, where else should i look? | 03:00 |
CaptainMorgan | common controller | 03:00 |
*** Tross has joined #openstack-dev | 03:01 | |
CaptainMorgan | added the del in the v3-v2 user | 03:01 |
*** dsirrine has quit IRC | 03:02 | |
*** dstanek has quit IRC | 03:03 | |
*** sandywalsh_ has quit IRC | 03:03 | |
*** thomasm has quit IRC | 03:03 | |
*** AyoungTheRed is now known as ayoung-ZzZzZz | 03:05 | |
*** matiu has quit IRC | 03:06 | |
dolphaaarrrggghh | CaptainMorgan: took me a minute to digest it, but +2'd both | 03:07 |
*** Dr_Who has joined #openstack-dev | 03:07 | |
dolphaaarrrggghh | CaptainMorgan: hopefully garhyee comes back and this can merge overnight :) | 03:08 |
*** jasdeepH has joined #openstack-dev | 03:08 | |
CaptainMorgan | dolphaaarrrggghh, cool. I'm looking forward to these being done. they've been full of rabbitholes. | 03:08 |
dolphaaarrrggghh | me too! | 03:08 |
CaptainMorgan | after this, maybe i can finish up the domain_scope cleanup to expirimental level. | 03:08 |
CaptainMorgan | and then we will be close to being able to stick a fork in RC1 :) | 03:09 |
dolphaaarrrggghh | http://old-wiki.openstack.org/rc/ | 03:09 |
CaptainMorgan | (closer) | 03:09 |
dolphaaarrrggghh | CaptainMorgan: if you changes merge, we might be *closest* | 03:09 |
CaptainMorgan | dolphaaarrrggghh, nice! | 03:09 |
*** Guest27505 has quit IRC | 03:10 | |
CaptainMorgan | dolphaaarrrggghh, and henry's belongsTo patch looks close. | 03:10 |
dolphaaarrrggghh | ooh yeah, i wanted to take another pass at that tonight | 03:11 |
CaptainMorgan | at a cursory glance, it looks pretty good. | 03:11 |
CaptainMorgan | but i've not done a full deep dive on it yet | 03:11 |
*** xjiujiu has quit IRC | 03:11 | |
*** morazi has joined #openstack-dev | 03:11 | |
dolphaaarrrggghh | i wanted to run his tests *with* the line of code that is conspicuously missing | 03:12 |
CaptainMorgan | dolphaaarrrggghh, for what it's worth, i'm super pleased at where keystone has come to for havana… I want to run it in production (as is, let alone RC point).. so much improvement | 03:12 |
*** Tross has quit IRC | 03:12 | |
dolphaaarrrggghh | CaptainMorgan: good to hear :) | 03:13 |
CaptainMorgan | I'm going to chase down a tempest core tomorrow. | 03:13 |
CaptainMorgan | i want to get atiwari's token fix in. | 03:14 |
*** kuuudos has joined #openstack-dev | 03:14 | |
*** jab416171 has joined #openstack-dev | 03:18 | |
*** Tross has joined #openstack-dev | 03:19 | |
*** sandywalsh has joined #openstack-dev | 03:23 | |
dolphaaarrrggghh | CaptainMorgan: gating henry's change now | 03:24 |
CaptainMorgan | dolphaaarrrggghh, cool. | 03:24 |
*** jab416171 has quit IRC | 03:25 | |
*** MarkAtwood has quit IRC | 03:25 | |
*** tgall_foo has joined #openstack-dev | 03:27 | |
dolphaaarrrggghh | CaptainMorgan: https://review.openstack.org/#/c/47516/ | 03:28 |
dolphaaarrrggghh | CaptainMorgan: that was my one line concern | 03:28 |
CaptainMorgan | dolphaaarrrggghh, looking | 03:29 |
*** esheffield has joined #openstack-dev | 03:29 | |
*** Dr_Who has quit IRC | 03:29 | |
CaptainMorgan | yep. worth doing that | 03:29 |
CaptainMorgan | i mean. it's just ensures we didn't invalidate some random token by accident | 03:29 |
*** jhesketh has quit IRC | 03:32 | |
*** Shaan7 has quit IRC | 03:33 | |
*** jhesketh__ has quit IRC | 03:33 | |
*** michchap has joined #openstack-dev | 03:33 | |
*** michchap has quit IRC | 03:34 | |
dolphaaarrrggghh | CaptainMorgan: yeah... i just wanted to make sure it wasn't missing for a reason :) | 03:35 |
*** stevemar has joined #openstack-dev | 03:35 | |
*** michchap has joined #openstack-dev | 03:36 | |
*** michchap has quit IRC | 03:36 | |
*** michchap_ has quit IRC | 03:36 | |
*** michchap has joined #openstack-dev | 03:37 | |
*** michchap_ has joined #openstack-dev | 03:39 | |
*** michchap_ has quit IRC | 03:40 | |
dolphaaarrrggghh | CaptainMorgan: thanks for the readme review | 03:40 |
*** michchap has quit IRC | 03:40 | |
CaptainMorgan | dolphaaarrrggghh, np! | 03:40 |
*** senk has joined #openstack-dev | 03:43 | |
*** shinylasers has joined #openstack-dev | 03:45 | |
*** shinylasers has quit IRC | 03:46 | |
*** senk has quit IRC | 03:48 | |
*** Tross has quit IRC | 03:49 | |
*** jay-lau-513 has joined #openstack-dev | 03:49 | |
*** imsurit has joined #openstack-dev | 03:50 | |
*** hemanth has quit IRC | 03:50 | |
*** carl_baldwin has joined #openstack-dev | 03:54 | |
*** sandeepr_ltp has quit IRC | 03:55 | |
*** Shaan7 has joined #openstack-dev | 03:57 | |
*** sandeepr_ltp has joined #openstack-dev | 03:58 | |
*** dolphaaarrrggghh has quit IRC | 03:58 | |
CaptainMorgan | stevemar, how goes? | 04:01 |
stevemar | CaptainMorgan - man you got an awesome pirate name | 04:01 |
CaptainMorgan | stevemar, hehe | 04:01 |
stevemar | CaptainMorgan - i just remembered at 5pm that it was talk like a pirate day, i thought ayoung was just going bonkers | 04:02 |
CaptainMorgan | both dolph and ayoung had awesome names too. | 04:02 |
stevemar | what was dolphs? | 04:02 |
CaptainMorgan | dolphaaarrrggghh | 04:02 |
stevemar | hahaha | 04:02 |
CaptainMorgan | exactly | 04:03 |
*** neelashah has quit IRC | 04:03 | |
stevemar | hmmm, next year i'll go with ShiverMeStevemar | 04:03 |
*** jab416171 has joined #openstack-dev | 04:03 | |
CaptainMorgan | stevemar, lucky you, that is the limit on characters for the irc nick :P | 04:03 |
stevemar | sweet | 04:04 |
stevemar | so, CaptainMorgan, whats goin on sir | 04:04 |
CaptainMorgan | stevemar, hoping my rabbithole of a patchset gets merged soon | 04:05 |
CaptainMorgan | stevemar, and chasing down the last of the RC1 stuff | 04:05 |
stevemar | this guy? https://review.openstack.org/#/c/46207/16 | 04:05 |
CaptainMorgan | stevemar, ype, but patchset 19 of it :P | 04:05 |
CaptainMorgan | stevemar, http://old-wiki.openstack.org/rc/ | 04:05 |
CaptainMorgan | we're doing well :) | 04:06 |
stevemar | yeah, the 16th was the patch set i told myself to review in the morning | 04:06 |
*** sridevi has joined #openstack-dev | 04:06 | |
stevemar | nova and heat are not fairing so well | 04:06 |
stevemar | horizon had a nice jump too | 04:06 |
CaptainMorgan | nova is a big project, lots of things to worry about. | 04:07 |
stevemar | yup | 04:07 |
CaptainMorgan | heat also had a huge drop a little earlier. | 04:07 |
*** jbresnah has quit IRC | 04:07 | |
stevemar | kudos on taking on that bug btw | 04:08 |
*** rcrit has quit IRC | 04:08 | |
stevemar | the tenantId vs tenant_id one.. | 04:08 |
*** faramir has quit IRC | 04:08 | |
CaptainMorgan | stevemar, that one was a brutal one. | 04:09 |
stevemar | i noticed it while doing some openstackclient work, and just worked around it | 04:09 |
CaptainMorgan | i figured it would be… easy, you know "oh just a little code to fix the stuff" | 04:09 |
stevemar | nopeee | 04:09 |
stevemar | it was deeply ingrained | 04:10 |
CaptainMorgan | stevemar, yep it was | 04:10 |
stevemar | CaptainMorgan - things are too calm, though i suppose that is good... | 04:11 |
CaptainMorgan | stevemar, don't jinx it!! | 04:11 |
stevemar | :| | 04:11 |
stevemar | i should really split this out into 2 patches: https://review.openstack.org/#/c/46085/ | 04:12 |
CaptainMorgan | stevemar, perhaps. | 04:12 |
stevemar | 1 for test code and another to add more instructions on adding oauth method to auth | 04:12 |
CaptainMorgan | stevemar, probably a good idea. | 04:12 |
CaptainMorgan | stevemar, plus, it'll get your commit count up :P | 04:13 |
CaptainMorgan | >.> | 04:13 |
stevemar | :P | 04:13 |
stevemar | gotta pad my stats | 04:13 |
CaptainMorgan | hehe | 04:13 |
CaptainMorgan | stevemar, http://stackalytics.com/?release=havana&metric=commits&project_type=openstack&module=&company=&user_id=stevemar | 04:13 |
stevemar | from now i'm just gonna commit stuff one function at a time | 04:13 |
*** prekarat has joined #openstack-dev | 04:14 | |
stevemar | CaptainMorgan hmm, needs more | 04:14 |
*** Mandell has joined #openstack-dev | 04:15 | |
*** prekarat has quit IRC | 04:15 | |
*** rcrit has joined #openstack-dev | 04:15 | |
*** prekarat has joined #openstack-dev | 04:15 | |
stevemar | though if you change the metric to LOC, over 50% went into keystone | 04:16 |
CaptainMorgan | stevemar, you have more than I do :P | 04:16 |
CaptainMorgan | and 73% of my code went into keystone :P | 04:16 |
stevemar | what? | 04:16 |
stevemar | no way | 04:16 |
stevemar | you do such much more than i do | 04:16 |
CaptainMorgan | eh, look at the review count i have | 04:16 |
CaptainMorgan | if you want to see where i've spent my time. | 04:17 |
stevemar | http://stackalytics.com/?release=havana&metric=marks&project_type=openstack&module=&company=&user_id=stevemar | 04:17 |
CaptainMorgan | but numbers don't really mean much besides "yep, you contributed" | 04:17 |
stevemar | hehe | 04:17 |
*** carl_baldwin has quit IRC | 04:18 | |
CaptainMorgan | at least thats my opinion. it's important to contribute, but more importantly, contribute quality vs quantity | 04:18 |
stevemar | to be fair, i only started to review in the last two months | 04:18 |
CaptainMorgan | hehe. | 04:18 |
*** morazi has quit IRC | 04:19 | |
*** imsurit has quit IRC | 04:19 | |
*** matiu has joined #openstack-dev | 04:24 | |
*** pmathews has joined #openstack-dev | 04:30 | |
*** cdub_ has quit IRC | 04:34 | |
*** basha has joined #openstack-dev | 04:37 | |
*** cdub_ has joined #openstack-dev | 04:37 | |
*** chandankumar has joined #openstack-dev | 04:42 | |
*** senk has joined #openstack-dev | 04:44 | |
*** edmund1 has quit IRC | 04:44 | |
*** gongysh has quit IRC | 04:45 | |
*** gongysh_ has joined #openstack-dev | 04:45 | |
*** radsy has quit IRC | 04:48 | |
*** senk has quit IRC | 04:48 | |
*** Ryan_Lane has quit IRC | 04:51 | |
*** Ryan_Lane1 has joined #openstack-dev | 04:51 | |
*** nshaikh has joined #openstack-dev | 04:53 | |
*** pmathews has quit IRC | 04:54 | |
*** jasdeepH has quit IRC | 04:54 | |
*** krtaylor has joined #openstack-dev | 04:55 | |
*** cdub_ has quit IRC | 04:58 | |
*** prekarat has quit IRC | 05:00 | |
*** networkstatic has joined #openstack-dev | 05:00 | |
*** prekarat has joined #openstack-dev | 05:02 | |
*** kushal has joined #openstack-dev | 05:07 | |
*** pmathews has joined #openstack-dev | 05:08 | |
*** slagle has joined #openstack-dev | 05:08 | |
*** danwent has quit IRC | 05:10 | |
*** reed has quit IRC | 05:11 | |
*** Farooque has joined #openstack-dev | 05:12 | |
*** slagle has quit IRC | 05:13 | |
*** Farooque1 has joined #openstack-dev | 05:14 | |
*** Tross has joined #openstack-dev | 05:16 | |
*** Farooque has quit IRC | 05:17 | |
*** CaptTofu has joined #openstack-dev | 05:17 | |
*** hemna has quit IRC | 05:17 | |
*** stevemar has quit IRC | 05:18 | |
*** Farooque1 has left #openstack-dev | 05:19 | |
*** sarob has quit IRC | 05:19 | |
*** sarob has joined #openstack-dev | 05:19 | |
*** jasdeepH has joined #openstack-dev | 05:20 | |
*** erkules_ is now known as erkules | 05:21 | |
*** jwcroppe has joined #openstack-dev | 05:22 | |
*** xqueralt-afk is now known as xqueralt | 05:24 | |
*** kuuudos has quit IRC | 05:28 | |
*** sarob has quit IRC | 05:31 | |
*** sarob has joined #openstack-dev | 05:32 | |
*** jwcroppe has quit IRC | 05:33 | |
*** sarob has quit IRC | 05:36 | |
*** zaitcev has quit IRC | 05:39 | |
*** otherwiseguy has quit IRC | 05:43 | |
*** senk has joined #openstack-dev | 05:45 | |
*** pmathews has quit IRC | 05:45 | |
*** ondergetekende_ has joined #openstack-dev | 05:48 | |
*** senk has quit IRC | 05:49 | |
*** jasdeepH has quit IRC | 05:50 | |
*** gongysh has joined #openstack-dev | 05:54 | |
*** rektide has joined #openstack-dev | 05:54 | |
*** pmathews has joined #openstack-dev | 05:58 | |
*** tgall_foo has quit IRC | 06:00 | |
*** senk has joined #openstack-dev | 06:02 | |
*** michchap has joined #openstack-dev | 06:04 | |
*** yolanda has joined #openstack-dev | 06:04 | |
*** garyk has joined #openstack-dev | 06:04 | |
*** pmathews has quit IRC | 06:06 | |
*** prekarat has quit IRC | 06:07 | |
*** prekarat has joined #openstack-dev | 06:07 | |
*** kuuudos has joined #openstack-dev | 06:07 | |
*** terriyu has quit IRC | 06:10 | |
*** SkyRocknRoll has joined #openstack-dev | 06:11 | |
*** SkyRocknRoll has joined #openstack-dev | 06:11 | |
*** matiu has quit IRC | 06:13 | |
*** senk has quit IRC | 06:13 | |
*** vartom16 has joined #openstack-dev | 06:21 | |
*** sandeepr has quit IRC | 06:25 | |
*** matsuhashi has quit IRC | 06:27 | |
*** matsuhashi has joined #openstack-dev | 06:28 | |
*** Dr_Who has joined #openstack-dev | 06:29 | |
*** shang has quit IRC | 06:31 | |
*** wfoster_away is now known as wfoster | 06:31 | |
*** MaxV has joined #openstack-dev | 06:32 | |
*** jbresnah has joined #openstack-dev | 06:36 | |
*** Dr_Who has quit IRC | 06:43 | |
*** MaxV has quit IRC | 06:46 | |
*** xqueralt is now known as xqueralt-afk | 06:50 | |
*** mrunge has joined #openstack-dev | 06:51 | |
*** cthulhup has joined #openstack-dev | 06:51 | |
*** comay has quit IRC | 06:51 | |
*** rdopieralski has joined #openstack-dev | 06:52 | |
*** ifarkas has joined #openstack-dev | 06:54 | |
*** cthulhup has quit IRC | 06:55 | |
*** rdopieralski has quit IRC | 06:55 | |
*** jtomasek has joined #openstack-dev | 06:56 | |
*** zul has quit IRC | 06:56 | |
*** zul has joined #openstack-dev | 06:57 | |
*** comay has joined #openstack-dev | 06:58 | |
*** AnilV4 has quit IRC | 07:00 | |
*** rdopieralski has joined #openstack-dev | 07:01 | |
*** MaxV has joined #openstack-dev | 07:02 | |
*** xga has joined #openstack-dev | 07:02 | |
*** odyssey4me has joined #openstack-dev | 07:04 | |
*** AnilV4 has joined #openstack-dev | 07:05 | |
*** jbresnah has quit IRC | 07:09 | |
*** Dr_Who has joined #openstack-dev | 07:09 | |
*** marrrrios is now known as marios | 07:11 | |
*** jasdeepH has joined #openstack-dev | 07:15 | |
*** egallen has joined #openstack-dev | 07:17 | |
*** CaptTofu has quit IRC | 07:17 | |
*** basha has quit IRC | 07:18 | |
*** CaptainMorgan is now known as morganfainberg | 07:19 | |
*** jasdeepH has quit IRC | 07:19 | |
*** athomas has joined #openstack-dev | 07:21 | |
*** Ruetobas has quit IRC | 07:21 | |
*** ondergetekende_ has quit IRC | 07:25 | |
*** o_petit has joined #openstack-dev | 07:25 | |
*** jistr has joined #openstack-dev | 07:25 | |
*** o_petit has quit IRC | 07:27 | |
*** basha has joined #openstack-dev | 07:27 | |
*** o_petit has joined #openstack-dev | 07:27 | |
*** DinaBelova has joined #openstack-dev | 07:27 | |
*** Dr_Who has quit IRC | 07:32 | |
*** flaper87|afk is now known as flaper87 | 07:34 | |
*** giulivo has joined #openstack-dev | 07:37 | |
*** Ruetobas has joined #openstack-dev | 07:38 | |
*** jaimegil has joined #openstack-dev | 07:39 | |
*** sheeprine has quit IRC | 07:40 | |
*** sheeprine has joined #openstack-dev | 07:41 | |
*** JordanP has joined #openstack-dev | 07:41 | |
*** eglynn has quit IRC | 07:42 | |
*** Ruetobas has quit IRC | 07:43 | |
*** basha has quit IRC | 07:47 | |
*** gargya has joined #openstack-dev | 07:48 | |
*** donaldh has joined #openstack-dev | 07:48 | |
*** Ruetobas has joined #openstack-dev | 07:48 | |
*** pschaef has joined #openstack-dev | 07:49 | |
*** ifarkas has quit IRC | 07:50 | |
*** jdurgin has quit IRC | 07:51 | |
*** kaushikc has joined #openstack-dev | 07:51 | |
*** ifarkas has joined #openstack-dev | 07:53 | |
*** jamielennox is now known as jamielennox|away | 07:55 | |
*** romcheg has joined #openstack-dev | 07:55 | |
*** yassine has joined #openstack-dev | 07:56 | |
*** freedomhui has joined #openstack-dev | 07:57 | |
*** safchain has joined #openstack-dev | 08:00 | |
*** boris-42 has joined #openstack-dev | 08:00 | |
*** shang has joined #openstack-dev | 08:01 | |
*** xga_ has joined #openstack-dev | 08:01 | |
*** Mandell has quit IRC | 08:01 | |
*** matsuhas_ has joined #openstack-dev | 08:03 | |
*** matsuhashi has quit IRC | 08:03 | |
*** xga has quit IRC | 08:04 | |
*** kpavel has joined #openstack-dev | 08:05 | |
*** boden has joined #openstack-dev | 08:05 | |
*** jruzicka has joined #openstack-dev | 08:06 | |
*** johnthetubaguy has joined #openstack-dev | 08:06 | |
*** jdurgin has joined #openstack-dev | 08:09 | |
*** xga has joined #openstack-dev | 08:09 | |
*** eglynn has joined #openstack-dev | 08:10 | |
*** xga_ has quit IRC | 08:12 | |
*** senk has joined #openstack-dev | 08:14 | |
*** mestery has joined #openstack-dev | 08:15 | |
*** corXi has joined #openstack-dev | 08:16 | |
*** rossella_s has joined #openstack-dev | 08:16 | |
*** Ryan_Lane1 has quit IRC | 08:16 | |
*** fbo_away is now known as fbo | 08:18 | |
*** senk has quit IRC | 08:19 | |
*** mmagr has joined #openstack-dev | 08:19 | |
*** corXi has quit IRC | 08:22 | |
*** bashok has joined #openstack-dev | 08:25 | |
*** kpavel has quit IRC | 08:26 | |
*** DinaBelova has quit IRC | 08:27 | |
*** kuuudos has quit IRC | 08:29 | |
*** xga has quit IRC | 08:29 | |
*** xga has joined #openstack-dev | 08:29 | |
*** o_petit_ has joined #openstack-dev | 08:31 | |
*** ygbo has joined #openstack-dev | 08:34 | |
*** o_petit has quit IRC | 08:34 | |
*** DinaBelova has joined #openstack-dev | 08:36 | |
*** Ruetobas has quit IRC | 08:36 | |
*** matsuhas_ has quit IRC | 08:39 | |
*** mestery has quit IRC | 08:41 | |
*** matsuhashi has joined #openstack-dev | 08:47 | |
*** matsuhashi has quit IRC | 08:49 | |
*** matsuhashi has joined #openstack-dev | 08:50 | |
*** imsurit has joined #openstack-dev | 08:51 | |
*** matsuhas_ has joined #openstack-dev | 08:51 | |
*** iartarisi has joined #openstack-dev | 08:54 | |
*** matsuhashi has quit IRC | 08:55 | |
*** torgomatic has quit IRC | 08:55 | |
*** torgomatic has joined #openstack-dev | 08:55 | |
*** danpb has joined #openstack-dev | 08:57 | |
*** wfoster is now known as wfoster_away | 08:57 | |
*** kaushikc has quit IRC | 09:00 | |
*** johnthetubaguy1 has joined #openstack-dev | 09:00 | |
*** kaushikc has joined #openstack-dev | 09:00 | |
*** johnthetubaguy has quit IRC | 09:02 | |
*** imsurit has quit IRC | 09:02 | |
*** neoXsys has quit IRC | 09:04 | |
*** imsurit has joined #openstack-dev | 09:06 | |
*** imsurit is now known as Guest79648 | 09:07 | |
*** mkollaro has joined #openstack-dev | 09:07 | |
*** mkollaro has quit IRC | 09:12 | |
*** Ruetobas has joined #openstack-dev | 09:13 | |
*** mkollaro has joined #openstack-dev | 09:13 | |
*** senk has joined #openstack-dev | 09:15 | |
*** neoXsys has joined #openstack-dev | 09:16 | |
*** basha has joined #openstack-dev | 09:17 | |
*** mkollaro has quit IRC | 09:18 | |
*** Ruetobas has quit IRC | 09:18 | |
*** senk has quit IRC | 09:19 | |
*** mkollaro has joined #openstack-dev | 09:20 | |
*** Guest79648 has quit IRC | 09:21 | |
*** wfoster_away is now known as wfoster | 09:24 | |
*** Ruetobas has joined #openstack-dev | 09:24 | |
*** adjohn has joined #openstack-dev | 09:24 | |
*** o_petit_ has quit IRC | 09:25 | |
*** o_petit has joined #openstack-dev | 09:25 | |
*** mkollaro has quit IRC | 09:28 | |
*** abk has joined #openstack-dev | 09:29 | |
*** pixelb has joined #openstack-dev | 09:29 | |
*** leizhang has joined #openstack-dev | 09:31 | |
*** mkollaro has joined #openstack-dev | 09:31 | |
*** vartom17 has joined #openstack-dev | 09:35 | |
*** vartom16 has quit IRC | 09:35 | |
*** corXi has joined #openstack-dev | 09:36 | |
*** mkollaro1 has joined #openstack-dev | 09:37 | |
*** mkollaro has quit IRC | 09:37 | |
*** o_petit has quit IRC | 09:37 | |
*** mkollaro1 has quit IRC | 09:42 | |
*** matsuhas_ has quit IRC | 09:43 | |
*** vartom18 has joined #openstack-dev | 09:43 | |
*** mkollaro1 has joined #openstack-dev | 09:43 | |
*** mkollaro1 has quit IRC | 09:43 | |
*** vartom17 has quit IRC | 09:43 | |
*** mkollaro has joined #openstack-dev | 09:45 | |
*** mkollaro has quit IRC | 09:45 | |
*** xqueralt-afk is now known as xqueralt | 09:47 | |
*** mkollaro has joined #openstack-dev | 09:47 | |
*** xjiujiu has joined #openstack-dev | 09:51 | |
*** athomas has quit IRC | 09:54 | |
*** leizhang has quit IRC | 09:56 | |
*** dripton has quit IRC | 09:56 | |
*** leizhang has joined #openstack-dev | 09:56 | |
*** beagles has joined #openstack-dev | 09:59 | |
*** dripton has joined #openstack-dev | 09:59 | |
*** jcoufal has joined #openstack-dev | 10:04 | |
*** DinaBelova has quit IRC | 10:05 | |
*** vartom19 has joined #openstack-dev | 10:06 | |
*** pcm_ has joined #openstack-dev | 10:06 | |
*** pcm_ has quit IRC | 10:07 | |
*** pcm_ has joined #openstack-dev | 10:07 | |
*** vartom18 has quit IRC | 10:09 | |
*** SkyRocknRoll has quit IRC | 10:09 | |
*** jcoufal has quit IRC | 10:11 | |
*** Oneiroi has joined #openstack-dev | 10:13 | |
*** ema has joined #openstack-dev | 10:13 | |
*** athomas has joined #openstack-dev | 10:13 | |
*** rushiagr has joined #openstack-dev | 10:16 | |
*** o_petit has joined #openstack-dev | 10:17 | |
*** o_petit has quit IRC | 10:17 | |
*** nosnos has quit IRC | 10:17 | |
*** gargya has quit IRC | 10:19 | |
*** iartarisi has quit IRC | 10:22 | |
*** fbo is now known as fbo_away | 10:24 | |
*** fbo_away is now known as fbo | 10:24 | |
*** adjohn has quit IRC | 10:26 | |
*** safchain has quit IRC | 10:31 | |
*** egallen has quit IRC | 10:31 | |
*** DinaBelova has joined #openstack-dev | 10:32 | |
*** rossella_s has left #openstack-dev | 10:36 | |
*** abk has quit IRC | 10:36 | |
*** rossella_s has joined #openstack-dev | 10:36 | |
*** freedomhui has quit IRC | 10:36 | |
*** gargya has joined #openstack-dev | 10:38 | |
*** AnilV4 has quit IRC | 10:38 | |
*** odyssey4me has quit IRC | 10:41 | |
*** dstanek has joined #openstack-dev | 10:44 | |
*** sumanthns has joined #openstack-dev | 10:46 | |
*** o_petit has joined #openstack-dev | 10:48 | |
*** freedomhui has joined #openstack-dev | 10:49 | |
*** mjbright1 has left #openstack-dev | 10:49 | |
*** odyssey4me has joined #openstack-dev | 10:50 | |
*** vartom110 has joined #openstack-dev | 10:51 | |
*** AnilV4 has joined #openstack-dev | 10:51 | |
*** mjbright has joined #openstack-dev | 10:54 | |
*** vartom19 has quit IRC | 10:54 | |
*** odyssey4me has quit IRC | 10:54 | |
*** o_petit has quit IRC | 10:55 | |
*** donaldh has quit IRC | 10:55 | |
*** freedomhui has quit IRC | 10:56 | |
*** pschaef has quit IRC | 10:57 | |
*** dims has joined #openstack-dev | 11:00 | |
*** mjb_ has joined #openstack-dev | 11:00 | |
*** odyssey4me has joined #openstack-dev | 11:03 | |
*** yolanda has quit IRC | 11:03 | |
*** rushiagr has quit IRC | 11:04 | |
*** jtomasek has quit IRC | 11:07 | |
*** o_petit has joined #openstack-dev | 11:07 | |
*** DinaBelova has quit IRC | 11:12 | |
*** senk has joined #openstack-dev | 11:17 | |
*** rushiagr has joined #openstack-dev | 11:18 | |
*** yolanda has joined #openstack-dev | 11:18 | |
*** senk has quit IRC | 11:21 | |
basha | I'm trying to add a patch as a deendency on a patch on another repo. one of them is a bug and the other a bp. Will modifying the commit msg help? | 11:24 |
*** adjohn has joined #openstack-dev | 11:27 | |
*** vartom110 has quit IRC | 11:27 | |
*** jruzicka has quit IRC | 11:32 | |
*** safchain has joined #openstack-dev | 11:32 | |
*** jruzicka has joined #openstack-dev | 11:32 | |
*** rushiagr has quit IRC | 11:33 | |
*** safchain has quit IRC | 11:34 | |
*** freedomhui has joined #openstack-dev | 11:35 | |
*** adjohn has quit IRC | 11:35 | |
*** safchain has joined #openstack-dev | 11:35 | |
*** egallen has joined #openstack-dev | 11:36 | |
*** alexpilotti has quit IRC | 11:38 | |
*** jtomasek has joined #openstack-dev | 11:41 | |
*** rushiagr has joined #openstack-dev | 11:43 | |
*** tmclaugh[work] has joined #openstack-dev | 11:43 | |
*** FunnyLookinHat has joined #openstack-dev | 11:43 | |
*** eglynn is now known as eglynn-lunch | 11:47 | |
*** Dr_Who has joined #openstack-dev | 11:50 | |
*** xchu has joined #openstack-dev | 11:52 | |
*** Dr_Who has quit IRC | 11:53 | |
*** rushiagr has quit IRC | 11:55 | |
*** tmckay has quit IRC | 11:56 | |
*** mrunge has quit IRC | 11:58 | |
*** o_petit has quit IRC | 11:58 | |
*** kaushikc has quit IRC | 12:00 | |
*** sumansn_ has joined #openstack-dev | 12:05 | |
*** rushiagr has joined #openstack-dev | 12:06 | |
*** sumanthns has quit IRC | 12:07 | |
*** o_petit has joined #openstack-dev | 12:07 | |
*** sridevi has quit IRC | 12:10 | |
*** sandywalsh has quit IRC | 12:11 | |
*** thomasm has joined #openstack-dev | 12:11 | |
*** paragan has quit IRC | 12:14 | |
*** kushal has quit IRC | 12:14 | |
*** freedomhui has quit IRC | 12:15 | |
*** cthulhup has joined #openstack-dev | 12:16 | |
*** gargya has quit IRC | 12:17 | |
*** gargya has joined #openstack-dev | 12:18 | |
*** xjiujiu has quit IRC | 12:18 | |
*** cthulhup has quit IRC | 12:20 | |
*** kpavel has joined #openstack-dev | 12:21 | |
*** freedomhui has joined #openstack-dev | 12:21 | |
*** xjiujiu has joined #openstack-dev | 12:24 | |
*** gargya has quit IRC | 12:24 | |
*** sandywalsh has joined #openstack-dev | 12:26 | |
*** rushiagr has left #openstack-dev | 12:26 | |
*** xjiujiu has quit IRC | 12:27 | |
*** dstanek has quit IRC | 12:28 | |
*** basha has quit IRC | 12:29 | |
*** xjiujiu has joined #openstack-dev | 12:30 | |
*** Dr_Who has joined #openstack-dev | 12:32 | |
*** Dr_Who has joined #openstack-dev | 12:32 | |
*** riskable has joined #openstack-dev | 12:33 | |
*** gordc has joined #openstack-dev | 12:33 | |
*** lbragstad has quit IRC | 12:33 | |
*** pamacii has joined #openstack-dev | 12:35 | |
*** sgordon has joined #openstack-dev | 12:36 | |
*** jaimegil has quit IRC | 12:41 | |
*** ondergetekende_ has joined #openstack-dev | 12:43 | |
*** paragan has joined #openstack-dev | 12:45 | |
*** paragan has joined #openstack-dev | 12:45 | |
*** dsirrine has joined #openstack-dev | 12:46 | |
*** chandankumar has quit IRC | 12:46 | |
*** xjiujiu has quit IRC | 12:47 | |
*** xjiujiu has joined #openstack-dev | 12:47 | |
*** eglynn-lunch is now known as eglynn | 12:47 | |
*** dstanek has joined #openstack-dev | 12:47 | |
*** sthaha has quit IRC | 12:48 | |
*** athomas has quit IRC | 12:49 | |
*** terryh has joined #openstack-dev | 12:50 | |
*** medberry_ has joined #openstack-dev | 12:51 | |
*** medberry_ is now known as med | 12:52 | |
*** kyleh1 has joined #openstack-dev | 12:52 | |
*** med is now known as med_ | 12:52 | |
*** med_ has quit IRC | 12:52 | |
*** med_ has joined #openstack-dev | 12:52 | |
*** kbringard has joined #openstack-dev | 12:53 | |
*** basha has joined #openstack-dev | 12:53 | |
*** adalbas has joined #openstack-dev | 12:53 | |
*** med_ is now known as med | 12:54 | |
*** med is now known as med_ | 12:54 | |
*** o_petit has quit IRC | 12:54 | |
*** athomas has joined #openstack-dev | 12:55 | |
*** AnilV4 has quit IRC | 12:55 | |
*** radez_g0n3 is now known as radez | 12:58 | |
*** edmund has joined #openstack-dev | 13:00 | |
*** venkatesh_ has joined #openstack-dev | 13:01 | |
*** venkatesh_ has quit IRC | 13:02 | |
*** dolphaaarrrggghh has joined #openstack-dev | 13:02 | |
*** dolphaaarrrggghh has quit IRC | 13:02 | |
ekarlso | is there any presentation on the ML2 stuff ? | 13:03 |
*** CaptTofu has joined #openstack-dev | 13:03 | |
*** dvarga has joined #openstack-dev | 13:04 | |
*** venkatesh has joined #openstack-dev | 13:04 | |
*** bfschott has joined #openstack-dev | 13:04 | |
*** xjiujiu has quit IRC | 13:07 | |
*** xjiujiu has joined #openstack-dev | 13:07 | |
*** jergerber has joined #openstack-dev | 13:09 | |
*** tmclaugh[work] has quit IRC | 13:11 | |
*** lbragstad has joined #openstack-dev | 13:12 | |
*** xjiujiu has quit IRC | 13:12 | |
*** xjiujiu has joined #openstack-dev | 13:12 | |
*** jcoufal has joined #openstack-dev | 13:13 | |
*** DinaBelova has joined #openstack-dev | 13:13 | |
*** enikanorov has joined #openstack-dev | 13:13 | |
*** senk has joined #openstack-dev | 13:14 | |
*** Dr_Who has quit IRC | 13:15 | |
*** enikanorov_ has quit IRC | 13:16 | |
*** herndon has joined #openstack-dev | 13:17 | |
*** neeti has joined #openstack-dev | 13:17 | |
*** fbo has quit IRC | 13:18 | |
*** neelashah has joined #openstack-dev | 13:18 | |
*** Oneiroi has quit IRC | 13:19 | |
*** fbo has joined #openstack-dev | 13:19 | |
*** xjiujiu has quit IRC | 13:20 | |
*** maheshp has joined #openstack-dev | 13:20 | |
*** xjiujiu has joined #openstack-dev | 13:21 | |
*** Dr_Who has joined #openstack-dev | 13:21 | |
*** Dr_Who has joined #openstack-dev | 13:21 | |
*** xchu has quit IRC | 13:23 | |
*** DinaBelova has quit IRC | 13:23 | |
*** AnilV4 has joined #openstack-dev | 13:23 | |
*** blamar has joined #openstack-dev | 13:24 | |
*** venkatesh has quit IRC | 13:24 | |
*** jayg|g0n3 is now known as jayg | 13:24 | |
*** DinaBelova has joined #openstack-dev | 13:25 | |
*** jasondotstar has joined #openstack-dev | 13:28 | |
*** prad has joined #openstack-dev | 13:32 | |
*** jecarey has joined #openstack-dev | 13:34 | |
*** senk has quit IRC | 13:37 | |
*** alexpilotti has joined #openstack-dev | 13:37 | |
*** sumansn_ has quit IRC | 13:38 | |
*** CaptTofu has quit IRC | 13:39 | |
*** dstanek has quit IRC | 13:39 | |
*** senk has joined #openstack-dev | 13:39 | |
*** noslzzp has joined #openstack-dev | 13:40 | |
*** rcrit has quit IRC | 13:40 | |
*** bnemec is now known as beekneemec | 13:42 | |
*** dansmith is now known as Steely_Dan | 13:43 | |
*** nshaikh has left #openstack-dev | 13:44 | |
*** maheshp has quit IRC | 13:45 | |
*** kpepple has quit IRC | 13:45 | |
*** maheshp has joined #openstack-dev | 13:45 | |
*** kpepple has joined #openstack-dev | 13:45 | |
*** rcrit has joined #openstack-dev | 13:46 | |
*** tmmt_ has joined #openstack-dev | 13:46 | |
*** jpeeler1 has joined #openstack-dev | 13:46 | |
*** prad has quit IRC | 13:46 | |
*** DinaBelova has quit IRC | 13:46 | |
*** tmmt has quit IRC | 13:47 | |
*** jpeeler has quit IRC | 13:47 | |
*** cburgess has quit IRC | 13:47 | |
*** jpeeler1 is now known as jpeeler | 13:47 | |
*** jpeeler has quit IRC | 13:48 | |
*** jpeeler has joined #openstack-dev | 13:48 | |
*** cburgess has joined #openstack-dev | 13:48 | |
*** russellb is now known as rustlebee | 13:48 | |
*** beagles is now known as seagulls | 13:48 | |
*** jcoufal has quit IRC | 13:50 | |
*** ruhe has joined #openstack-dev | 13:51 | |
*** prad has joined #openstack-dev | 13:52 | |
*** xjiujiu has quit IRC | 13:52 | |
*** xjiujiu has joined #openstack-dev | 13:53 | |
*** terriyu has joined #openstack-dev | 13:53 | |
*** stevemar has joined #openstack-dev | 13:55 | |
*** jcoufal has joined #openstack-dev | 13:55 | |
*** prad has quit IRC | 13:56 | |
*** FunnyLookinHat has quit IRC | 13:56 | |
*** eharney has joined #openstack-dev | 13:57 | |
*** seagulls is now known as beagles | 13:59 | |
*** beagles is now known as seagulls | 13:59 | |
*** blues-man has joined #openstack-dev | 14:02 | |
*** xjiujiu has quit IRC | 14:03 | |
*** tmclaugh[work] has joined #openstack-dev | 14:04 | |
*** xjiujiu has joined #openstack-dev | 14:04 | |
*** networkstatic has quit IRC | 14:04 | |
*** networkstatic has joined #openstack-dev | 14:04 | |
*** jcoufal has quit IRC | 14:05 | |
*** basha has quit IRC | 14:08 | |
*** Dr_Who has quit IRC | 14:09 | |
*** jmontemayor has joined #openstack-dev | 14:09 | |
*** o_petit_ has joined #openstack-dev | 14:09 | |
*** thomasm has quit IRC | 14:09 | |
*** tstevenson__ has joined #openstack-dev | 14:09 | |
*** rwsu has joined #openstack-dev | 14:10 | |
*** prekarat has quit IRC | 14:11 | |
*** herndon has quit IRC | 14:11 | |
*** edmund has quit IRC | 14:11 | |
*** kushal has joined #openstack-dev | 14:11 | |
*** edmund has joined #openstack-dev | 14:12 | |
*** datsun180b has joined #openstack-dev | 14:12 | |
*** dstanek has joined #openstack-dev | 14:13 | |
*** dhellmann is now known as dhellmann_ | 14:16 | |
*** xjiujiu has quit IRC | 14:16 | |
*** litong has joined #openstack-dev | 14:17 | |
*** gimps_ has joined #openstack-dev | 14:19 | |
*** DinaBelova has joined #openstack-dev | 14:20 | |
*** ayoung-ZzZzZz is now known as ayoung | 14:21 | |
*** ayoung has quit IRC | 14:21 | |
*** [wchrisj_ has joined #openstack-dev | 14:23 | |
*** [wchrisj_ is now known as wchrisj | 14:23 | |
*** dolphaaarrrggghh has joined #openstack-dev | 14:28 | |
*** aeperezt has joined #openstack-dev | 14:28 | |
*** dolphaaarrrggghh has joined #openstack-dev | 14:28 | |
*** dolphaaarrrggghh is now known as dolphm | 14:28 | |
*** rnirmal has joined #openstack-dev | 14:28 | |
*** Ruetobas has quit IRC | 14:29 | |
*** MaxV has quit IRC | 14:29 | |
*** henrynash has joined #openstack-dev | 14:29 | |
*** giulivo has quit IRC | 14:30 | |
*** giulivo has joined #openstack-dev | 14:31 | |
*** DinaBelova has quit IRC | 14:32 | |
*** yamahata has quit IRC | 14:33 | |
*** FunnyLookinHat has joined #openstack-dev | 14:34 | |
*** yamahata has joined #openstack-dev | 14:36 | |
*** Ruetobas has joined #openstack-dev | 14:36 | |
*** gfidente has joined #openstack-dev | 14:36 | |
*** thomasm has joined #openstack-dev | 14:37 | |
*** giulivo has quit IRC | 14:38 | |
*** vlakarados|2 has joined #openstack-dev | 14:42 | |
*** vlakarados has quit IRC | 14:42 | |
*** xga_ has joined #openstack-dev | 14:42 | |
*** krphop has quit IRC | 14:43 | |
*** xga has quit IRC | 14:43 | |
*** utlemming has quit IRC | 14:43 | |
*** utlemming has joined #openstack-dev | 14:44 | |
*** herndon has joined #openstack-dev | 14:46 | |
*** krphop has joined #openstack-dev | 14:47 | |
*** ruhe has quit IRC | 14:54 | |
*** DinaBelova has joined #openstack-dev | 14:55 | |
*** matiu has joined #openstack-dev | 14:57 | |
*** ruhe has joined #openstack-dev | 14:57 | |
dolphm | morganfainberg: henrynash: o/ | 15:01 |
henrynash | dolphm: hi | 15:01 |
*** bknudson has joined #openstack-dev | 15:01 | |
dolphm | henrynash: i'm looking into one of your comments on morgan's tenantId/tenant_id/default_project_id fix... | 15:01 |
henrynash | dolphm: yes, saw your reply | 15:02 |
dolphm | henrynash: regarding remove_user_from_project() -- do you know when/why the behavior of that function changed? | 15:02 |
dolphm | henrynash: i don't see any reason in tests to explain it's current behavior | 15:02 |
*** danwent has joined #openstack-dev | 15:02 | |
henrynash | dolphm: no I don't….I suspect during Grizzly, but that's a guess | 15:02 |
*** mrunge has joined #openstack-dev | 15:03 | |
*** carl_baldwin has joined #openstack-dev | 15:04 | |
*** ayoung has joined #openstack-dev | 15:04 | |
*** o_petit_ has quit IRC | 15:04 | |
*** CaptTofu has joined #openstack-dev | 15:05 | |
*** jasdeepH has joined #openstack-dev | 15:05 | |
*** DinaBelova has quit IRC | 15:06 | |
*** alop has joined #openstack-dev | 15:07 | |
*** Tross has quit IRC | 15:08 | |
*** ifarkas has quit IRC | 15:08 | |
*** Tross has joined #openstack-dev | 15:08 | |
*** mrodden has quit IRC | 15:08 | |
*** ericw has joined #openstack-dev | 15:09 | |
*** roaet has quit IRC | 15:11 | |
*** roaet has joined #openstack-dev | 15:12 | |
*** epim has joined #openstack-dev | 15:12 | |
*** Ruetobas has quit IRC | 15:12 | |
*** reed has joined #openstack-dev | 15:17 | |
*** kushal has quit IRC | 15:20 | |
*** kuuudos has joined #openstack-dev | 15:21 | |
*** prad has joined #openstack-dev | 15:22 | |
*** devoid has joined #openstack-dev | 15:23 | |
*** mmagr has quit IRC | 15:23 | |
*** devoid has left #openstack-dev | 15:24 | |
*** kuuudos has left #openstack-dev | 15:25 | |
*** jvrbanac has joined #openstack-dev | 15:25 | |
*** paragan has quit IRC | 15:28 | |
*** mmagr has joined #openstack-dev | 15:29 | |
*** mkollaro has quit IRC | 15:30 | |
*** Mandell has joined #openstack-dev | 15:31 | |
*** Ruetobas has joined #openstack-dev | 15:33 | |
*** safchain has quit IRC | 15:33 | |
*** markmcclain has joined #openstack-dev | 15:35 | |
*** yassine has quit IRC | 15:35 | |
*** otherwiseguy has joined #openstack-dev | 15:41 | |
*** otherwiseguy has quit IRC | 15:42 | |
*** safchain has joined #openstack-dev | 15:43 | |
*** otherwiseguy has joined #openstack-dev | 15:43 | |
*** safchain has quit IRC | 15:43 | |
*** otherwiseguy has quit IRC | 15:43 | |
*** otherwiseguy has joined #openstack-dev | 15:43 | |
*** hashfail_ has joined #openstack-dev | 15:45 | |
*** paragan has joined #openstack-dev | 15:45 | |
*** paragan has quit IRC | 15:45 | |
*** paragan has joined #openstack-dev | 15:45 | |
*** mrodden has joined #openstack-dev | 15:46 | |
*** seagulls has quit IRC | 15:46 | |
*** beagles has joined #openstack-dev | 15:46 | |
*** gongysh has quit IRC | 15:47 | |
*** gongysh_ has quit IRC | 15:47 | |
*** sumanthns has joined #openstack-dev | 15:47 | |
*** gimps_ has quit IRC | 15:47 | |
*** beagles is now known as seagulls | 15:47 | |
*** hashfail_ has quit IRC | 15:49 | |
*** sergmelikyan has quit IRC | 15:49 | |
*** mkollaro has joined #openstack-dev | 15:49 | |
*** mkollaro has quit IRC | 15:49 | |
*** wchrisj is now known as help | 15:53 | |
*** help is now known as wchrisj | 15:53 | |
*** jeblair is now known as corvus | 15:53 | |
*** jtomasek has quit IRC | 15:54 | |
*** bashok has left #openstack-dev | 15:54 | |
*** xga has joined #openstack-dev | 15:54 | |
*** noslzzp has quit IRC | 15:55 | |
*** wchrisj has quit IRC | 15:55 | |
*** wchrisj has joined #openstack-dev | 15:56 | |
*** pmathews has joined #openstack-dev | 15:56 | |
*** xga_ has quit IRC | 15:57 | |
*** paragan has quit IRC | 15:57 | |
*** noslzzp has joined #openstack-dev | 15:57 | |
*** corvus is now known as jeblair | 16:00 | |
*** herndon has quit IRC | 16:00 | |
*** venkatesh has joined #openstack-dev | 16:00 | |
*** Ruetobas has quit IRC | 16:01 | |
*** CaptTofu has quit IRC | 16:01 | |
*** rdopieralski has quit IRC | 16:01 | |
*** jistr has quit IRC | 16:02 | |
*** dolphm has quit IRC | 16:02 | |
*** DinaBelova has joined #openstack-dev | 16:02 | |
*** shang has quit IRC | 16:03 | |
*** bdpayne has joined #openstack-dev | 16:03 | |
*** Ruetobas has joined #openstack-dev | 16:03 | |
*** mmagr has quit IRC | 16:03 | |
*** kgriffs has joined #openstack-dev | 16:03 | |
kgriffs | keystone question for you guys | 16:04 |
kgriffs | in practice, is anything other than an integer used for Project ID (AKA Tenant ID) | 16:04 |
kgriffs | ? | 16:04 |
*** herndon has joined #openstack-dev | 16:04 | |
*** swills has quit IRC | 16:06 | |
*** andymccr has quit IRC | 16:06 | |
*** SumitNaiksatam has quit IRC | 16:06 | |
*** dhellmann_ is now known as dhellmann | 16:08 | |
*** Ruetobas has quit IRC | 16:08 | |
*** swills has joined #openstack-dev | 16:08 | |
*** swills has quit IRC | 16:09 | |
*** swills has joined #openstack-dev | 16:09 | |
*** andymccr has joined #openstack-dev | 16:09 | |
*** shinylasers has joined #openstack-dev | 16:10 | |
*** bknudson has left #openstack-dev | 16:11 | |
*** neeti has quit IRC | 16:11 | |
*** terriyu has quit IRC | 16:11 | |
*** neeti has joined #openstack-dev | 16:11 | |
*** Ruetobas has joined #openstack-dev | 16:14 | |
*** o_petit has joined #openstack-dev | 16:15 | |
*** tmmt_ is now known as tmmt | 16:15 | |
*** freedomhui has quit IRC | 16:15 | |
*** mrunge has quit IRC | 16:16 | |
*** CaptTofu has joined #openstack-dev | 16:17 | |
*** sdake_ has joined #openstack-dev | 16:19 | |
*** o_petit has quit IRC | 16:20 | |
*** jruzicka has quit IRC | 16:21 | |
*** noslzzp has quit IRC | 16:23 | |
*** michchap has quit IRC | 16:23 | |
*** mrodden has quit IRC | 16:23 | |
*** michchap has joined #openstack-dev | 16:23 | |
*** gordc has quit IRC | 16:24 | |
*** comstud is now known as bearhands | 16:24 | |
*** gordc has joined #openstack-dev | 16:25 | |
*** kushal has joined #openstack-dev | 16:26 | |
*** SumitNaiksatam has joined #openstack-dev | 16:26 | |
*** pasquier-s has quit IRC | 16:28 | |
*** lbragstad has quit IRC | 16:29 | |
*** blues-man has quit IRC | 16:31 | |
*** Guangya has joined #openstack-dev | 16:32 | |
*** eglynn has quit IRC | 16:33 | |
*** JordanP has quit IRC | 16:34 | |
*** noslzzp has joined #openstack-dev | 16:35 | |
*** xga_ has joined #openstack-dev | 16:35 | |
*** grapsus has quit IRC | 16:35 | |
*** jay-lau-513 has quit IRC | 16:35 | |
*** grapsus has joined #openstack-dev | 16:35 | |
*** kushal has quit IRC | 16:37 | |
*** xga has quit IRC | 16:37 | |
*** ygbo has quit IRC | 16:38 | |
*** jbresnah has joined #openstack-dev | 16:39 | |
*** grapsus has quit IRC | 16:40 | |
*** angdraug has joined #openstack-dev | 16:41 | |
*** venkatesh has quit IRC | 16:42 | |
*** CaptTofu has quit IRC | 16:43 | |
*** CaptTofu has joined #openstack-dev | 16:43 | |
*** xga_ has quit IRC | 16:44 | |
*** terriyu has joined #openstack-dev | 16:44 | |
*** maheshp has quit IRC | 16:44 | |
*** comay_ has joined #openstack-dev | 16:45 | |
*** grapsus has joined #openstack-dev | 16:46 | |
*** rnirmal has quit IRC | 16:47 | |
*** alop has quit IRC | 16:48 | |
*** zaitcev has joined #openstack-dev | 16:48 | |
*** CaptTofu has quit IRC | 16:48 | |
*** CaptTofu has joined #openstack-dev | 16:49 | |
*** shardy is now known as shardy_afk | 16:50 | |
*** dolphm has joined #openstack-dev | 16:50 | |
*** kbrierly has joined #openstack-dev | 16:51 | |
*** alop has joined #openstack-dev | 16:52 | |
*** eglynn has joined #openstack-dev | 16:55 | |
*** mrodden has joined #openstack-dev | 16:55 | |
*** hemnafk is now known as hemna | 16:57 | |
*** alop has quit IRC | 16:57 | |
*** msmedved has quit IRC | 16:57 | |
mrodden | beekneemec: nice catch on test on that py3 patch | 16:57 |
mrodden | the test* | 16:57 |
kgriffs | reposting my earlier question: | 16:58 |
*** alop has joined #openstack-dev | 16:58 | |
kgriffs | n practice, is anything other than an integer used for Project ID (AKA Tenant ID)? | 16:58 |
beekneemec | mrodden: Yeah, I'm generally opposed to removing test cases for non-duplicate cases, so I didn't like that. :-) | 16:58 |
*** kdbrierly has joined #openstack-dev | 16:58 | |
*** egallen has quit IRC | 16:58 | |
*** CaptTofu has quit IRC | 16:58 | |
*** CaptTofu has joined #openstack-dev | 16:59 | |
mrodden | beekneemec: i always get tunnel version on making sure what is being added looks ok, that i didn't realize they were removing a test case entirely | 16:59 |
mrodden | tunnel vision | 16:59 |
mrodden | apparently i can't type today either | 16:59 |
*** kbrierly has quit IRC | 16:59 | |
beekneemec | mrodden: Meh, it's Friday. :-) | 16:59 |
mrodden | true that | 17:00 |
beekneemec | mrodden: And that sort of thing is why we approve after two +2's in most projects. | 17:00 |
beekneemec | One person isn't going to catch everything. | 17:00 |
mrodden | yeah | 17:01 |
*** msmedved has joined #openstack-dev | 17:02 | |
*** fbo is now known as fbo_away | 17:04 | |
*** gyee has joined #openstack-dev | 17:05 | |
*** grapsus has quit IRC | 17:06 | |
*** DinaBelova has quit IRC | 17:07 | |
*** sumansn_ has joined #openstack-dev | 17:07 | |
mrodden | beekneemec: could i get your opinion on something quick? https://review.openstack.org/#/c/45120/ | 17:08 |
*** grapsus has joined #openstack-dev | 17:08 | |
*** sumanthns has quit IRC | 17:08 | |
*** ruhe has quit IRC | 17:08 | |
beekneemec | mrodden: Ah, I think I saw that yesterday | 17:09 |
mrodden | yeah i dont really care what the default is | 17:09 |
*** msmedved has quit IRC | 17:09 | |
mrodden | its just there is a bug open for nova and it was changed in all the other projects already | 17:09 |
*** kushal has joined #openstack-dev | 17:10 | |
beekneemec | mrodden: So this is just making it behave the way it did before the delayed translation change? | 17:10 |
mrodden | yeah | 17:10 |
mrodden | which, I considered a bug in the original design and fixed... | 17:10 |
mrodden | but i guess that was bad? | 17:10 |
*** kgriffs has left #openstack-dev | 17:10 | |
beekneemec | Hmm | 17:11 |
*** dlstacy has joined #openstack-dev | 17:11 | |
beekneemec | I vaguely recall a similar discussion to this. | 17:11 |
*** spzala has joined #openstack-dev | 17:12 | |
mrodden | yeah i'm guessing its time to bring it to the ML | 17:12 |
beekneemec | Yeah, probably. | 17:12 |
beekneemec | I guess I'm inclined to give the server administrator control over the default, which is what your change would do. | 17:12 |
mrodden | yeah | 17:12 |
mrodden | that was luis' argument that swayed me to fix it | 17:13 |
*** grapsus has quit IRC | 17:13 | |
*** kushal has quit IRC | 17:13 | |
*** danpb has quit IRC | 17:14 | |
beekneemec | And if the user doesn't like that default, they can always pass the header to override it. | 17:14 |
*** grapsus has joined #openstack-dev | 17:14 | |
luis | +1 | 17:14 |
*** sandywalsh_ has joined #openstack-dev | 17:14 | |
*** odyssey4me has quit IRC | 17:15 | |
* beekneemec tries to ignore the fact that he's about 600 e-mails behind on the -dev ML. | 17:18 | |
*** arezmerita has quit IRC | 17:18 | |
morganfainberg | henrynash, dolphm , hi | 17:18 |
*** sandywalsh has quit IRC | 17:18 | |
morganfainberg | henrynash / dolphm, regarding the behavior, i think some of the backends did it others didn't. checking now | 17:18 |
morganfainberg | for that comment that is | 17:18 |
morganfainberg | i just lifted the logic up to the controller so i could move forward with the fixes. | 17:19 |
*** ruhe has joined #openstack-dev | 17:19 | |
*** CaptTofu has quit IRC | 17:20 | |
*** CaptTofu has joined #openstack-dev | 17:20 | |
*** lcheng has joined #openstack-dev | 17:21 | |
*** msmedved has joined #openstack-dev | 17:22 | |
morganfainberg | henrynash / dolphm, https://github.com/openstack/keystone/blob/master/keystone/identity/backends/ldap.py#L108 | 17:24 |
*** corXi has quit IRC | 17:25 | |
*** comay has quit IRC | 17:26 | |
*** herndon has quit IRC | 17:27 | |
*** maheshp has joined #openstack-dev | 17:28 | |
*** comay has joined #openstack-dev | 17:28 | |
*** seagulls is now known as beagles | 17:29 | |
*** beagles is now known as seagulls | 17:29 | |
*** wfoster is now known as wfoster_away | 17:30 | |
*** johnthetubaguy1 has quit IRC | 17:31 | |
*** sumansn_ has quit IRC | 17:31 | |
*** Farooque has joined #openstack-dev | 17:32 | |
*** Ryan_Lane has joined #openstack-dev | 17:32 | |
*** johnthetubaguy has joined #openstack-dev | 17:33 | |
*** operrin has quit IRC | 17:35 | |
*** AnilV4 has quit IRC | 17:37 | |
*** amcrn has joined #openstack-dev | 17:37 | |
*** spzala has quit IRC | 17:38 | |
*** spzala has joined #openstack-dev | 17:38 | |
*** shakayumi has joined #openstack-dev | 17:41 | |
*** ruhe has quit IRC | 17:42 | |
*** johnthetubaguy has quit IRC | 17:43 | |
*** anteaya has joined #openstack-dev | 17:43 | |
*** johnthetubaguy has joined #openstack-dev | 17:43 | |
*** lbragstad has joined #openstack-dev | 17:44 | |
*** johnthetubaguy has quit IRC | 17:44 | |
*** jasondotstar has quit IRC | 17:44 | |
*** galstrom_zzz is now known as galstrom | 17:44 | |
*** ruhe has joined #openstack-dev | 17:44 | |
*** galstrom is now known as galstrom_zzz | 17:46 | |
*** CaptTofu has quit IRC | 17:49 | |
*** vuil has joined #openstack-dev | 17:49 | |
*** CaptTofu has joined #openstack-dev | 17:50 | |
morganfainberg | henrynash / dolphm, almost done rolling another patchset. do you want me to rebase upon the other fix for the remove based upon tenantId changing? | 17:50 |
morganfainberg | i can do that if needed. | 17:50 |
*** ruhe has quit IRC | 17:51 | |
morganfainberg | or we can have the cleanup be applied on top of my changeset. | 17:51 |
*** dlstacy has left #openstack-dev | 17:51 | |
morganfainberg | be back in a few. | 17:51 |
*** cthulhup has joined #openstack-dev | 17:51 | |
*** cthulhup has quit IRC | 17:51 | |
*** cthulhup has joined #openstack-dev | 17:52 | |
*** terryh has quit IRC | 17:55 | |
*** eharney has quit IRC | 17:55 | |
*** venkatesh has joined #openstack-dev | 17:55 | |
*** dstanek has quit IRC | 17:56 | |
*** xqueralt is now known as xqueralt-afk | 17:56 | |
*** reed has quit IRC | 17:56 | |
*** CaptTofu has quit IRC | 17:57 | |
*** neeti has quit IRC | 17:58 | |
*** cthulhup has quit IRC | 17:58 | |
*** eharney has joined #openstack-dev | 17:59 | |
*** dstanek has joined #openstack-dev | 18:00 | |
*** dkranz has quit IRC | 18:00 | |
*** ruhe has joined #openstack-dev | 18:03 | |
*** ruhe has quit IRC | 18:07 | |
dolphm | morganfainberg: catching up... | 18:07 |
dolphm | morganfainberg: i'm looking into the remove_user_from_project() stuff myself... i have a patch against master that's passing tests to apply your remove_user_membership_from_project() logic to the existing remove_user_from_project() | 18:12 |
dolphm | morganfainberg: but now i'd like to go judge impact on your patch and the other related one | 18:12 |
morganfainberg | dolphm, exactly | 18:13 |
morganfainberg | dolphm, my patch needed to lift stuff up to the controller, ldap already had this logic. i could rebase mine on the other one and incorporate that instead. | 18:14 |
morganfainberg | dolphm, let me know, i'm writing a couple tests and will be ready for a patch that addresses the comments. | 18:14 |
*** david-lyle is now known as david-lyle_away | 18:14 | |
dolphm | morganfainberg: let me know what you think of this first - remove_user_membership_from_project() | 18:16 |
dolphm | morganfainberg: as far as i can see, this method isn't currently called by any HTTP API, so changing it's behavior only impacts tests? | 18:16 |
dolphm | and that other patch in review (or yours) should be consuming it | 18:16 |
dolphm | morganfainberg: bad paste above... http://pasteraw.com/odjhmem4i526mpka7l453216f1rixrn | 18:17 |
morganfainberg | looking | 18:17 |
*** adjohn has joined #openstack-dev | 18:18 | |
jgriffith | sdague: Lemme know if you still disagree on my comments WRT https://review.openstack.org/#/c/47460/ | 18:18 |
*** radix has quit IRC | 18:19 | |
*** radix has joined #openstack-dev | 18:19 | |
*** venkatesh has quit IRC | 18:20 | |
morganfainberg | dolphm, that impact should be minimal since we are just consuming it | 18:20 |
morganfainberg | dolphm, it does seem like only tests should be affected | 18:21 |
*** carl_baldwin has quit IRC | 18:21 | |
morganfainberg | with this change. | 18:21 |
*** adjohn has quit IRC | 18:25 | |
*** adjohn has joined #openstack-dev | 18:27 | |
sdague | jgriffith: just reading, I'm ok with that. | 18:30 |
*** alexpilotti has quit IRC | 18:31 | |
*** senk has quit IRC | 18:32 | |
*** adjohn has quit IRC | 18:33 | |
*** amohn9 has joined #openstack-dev | 18:34 | |
*** sushils has joined #openstack-dev | 18:34 | |
*** thomasm has quit IRC | 18:35 | |
*** adjohn has joined #openstack-dev | 18:35 | |
*** adjohn has quit IRC | 18:37 | |
*** seagulls is now known as beagles | 18:38 | |
*** beagles is now known as seagulls | 18:38 | |
*** adjohn has joined #openstack-dev | 18:40 | |
*** troytoman-away is now known as troytoman | 18:40 | |
*** jasondotstar has joined #openstack-dev | 18:40 | |
*** anteaya has quit IRC | 18:40 | |
*** xga has joined #openstack-dev | 18:41 | |
*** ema has quit IRC | 18:43 | |
*** melwitt has joined #openstack-dev | 18:43 | |
*** terryh has joined #openstack-dev | 18:44 | |
jgriffith | sdague: great, thanks... I'll submit and updated after the cinder change merges | 18:45 |
sdague | great | 18:45 |
*** xga has quit IRC | 18:45 | |
*** riskable has quit IRC | 18:45 | |
*** terryh has quit IRC | 18:47 | |
*** vipul is now known as vipul-away | 18:47 | |
*** vipul-away is now known as vipul | 18:47 | |
*** terryh has joined #openstack-dev | 18:47 | |
*** terryh has quit IRC | 18:48 | |
*** comay has quit IRC | 18:50 | |
*** venkatesh has joined #openstack-dev | 18:52 | |
*** anteaya has joined #openstack-dev | 18:53 | |
*** rnirmal has joined #openstack-dev | 18:54 | |
*** thomasm has joined #openstack-dev | 18:54 | |
*** leizhang has quit IRC | 18:55 | |
*** thomasm has quit IRC | 18:55 | |
*** thomasm has joined #openstack-dev | 18:55 | |
*** sushils has quit IRC | 18:57 | |
*** adjohn has quit IRC | 18:58 | |
*** adjohn has joined #openstack-dev | 18:59 | |
*** venkatesh has quit IRC | 19:00 | |
*** venkatesh has joined #openstack-dev | 19:00 | |
*** novas0x2a|laptop has joined #openstack-dev | 19:01 | |
*** gyee has quit IRC | 19:01 | |
*** adjohn has quit IRC | 19:03 | |
*** adjohn has joined #openstack-dev | 19:04 | |
*** rossella_s has quit IRC | 19:04 | |
*** adjohn has quit IRC | 19:07 | |
*** vartom110 has joined #openstack-dev | 19:07 | |
*** carl_baldwin has joined #openstack-dev | 19:08 | |
*** venkatesh has quit IRC | 19:09 | |
*** the_real_kp has left #openstack-dev | 19:09 | |
*** venkatesh has joined #openstack-dev | 19:09 | |
*** venkatesh has quit IRC | 19:09 | |
*** venkatesh has joined #openstack-dev | 19:10 | |
*** maheshp has quit IRC | 19:11 | |
*** adjohn has joined #openstack-dev | 19:11 | |
*** amohn9 has quit IRC | 19:12 | |
*** CaptTofu has joined #openstack-dev | 19:12 | |
*** adjohn has quit IRC | 19:15 | |
*** adjohn has joined #openstack-dev | 19:17 | |
*** dvarga has quit IRC | 19:17 | |
*** the_real_kp has joined #openstack-dev | 19:19 | |
*** adjohn has quit IRC | 19:22 | |
*** tstevenson__ has quit IRC | 19:22 | |
*** datsun180b has quit IRC | 19:22 | |
*** rnirmal has quit IRC | 19:22 | |
*** noorul has quit IRC | 19:23 | |
*** noorul` has joined #openstack-dev | 19:23 | |
*** kevinconway has quit IRC | 19:23 | |
*** jvrbanac has quit IRC | 19:24 | |
*** vipul is now known as vipul-away | 19:24 | |
*** adjohn has joined #openstack-dev | 19:28 | |
*** CaptTofu has quit IRC | 19:29 | |
*** amohn9 has joined #openstack-dev | 19:30 | |
*** davi6723 has joined #openstack-dev | 19:34 | |
*** jecarey has quit IRC | 19:35 | |
*** adjohn has quit IRC | 19:36 | |
*** pmathews has quit IRC | 19:36 | |
*** dstanek has quit IRC | 19:36 | |
*** maheshp has joined #openstack-dev | 19:37 | |
*** thomasm has quit IRC | 19:38 | |
*** athomas has quit IRC | 19:39 | |
*** thomasm has joined #openstack-dev | 19:39 | |
*** rnirmal has joined #openstack-dev | 19:39 | |
*** jvrbanac has joined #openstack-dev | 19:40 | |
*** pmathews has joined #openstack-dev | 19:40 | |
*** mriedem has joined #openstack-dev | 19:40 | |
mriedem | is anyone aware of known issues trying to build docs for ceilometer with sphinx? | 19:41 |
*** dolphm_ has joined #openstack-dev | 19:42 | |
mriedem | dhellmann: ping | 19:42 |
thomasm | mriedem, I'm not aware of any, some folks in #openstack-metering might, though. | 19:43 |
mriedem | metering, ah, was looking for openstack-ceilometer, thanks | 19:43 |
thomasm | mriedem, Anytime =] | 19:43 |
dhellmann | mriedem: pong | 19:43 |
morganfainberg | dolphm, https://review.openstack.org/#/c/46207/ updated with now with more testing. | 19:43 |
*** zeriouz has joined #openstack-dev | 19:43 | |
mriedem | dhellmann: yeah, i see you on sphinxcontrib-pecanwsme | 19:43 |
morganfainberg | dolphm, and a little cleanup as requested by bknudson. | 19:43 |
*** zeriouz has quit IRC | 19:43 | |
mriedem | dhellmann: i'm trying to build docs for ceilometer with sphinx and am hitting this: Could not import extension sphinxcontrib.pecanwsme.rest (exception: No module named pecanwsme.rest) | 19:44 |
mriedem | dhellmann: but i can import that module from my python shell | 19:44 |
mriedem | dhellmann: just wondering if you've heard about it? | 19:44 |
dhellmann | mriedem: is it installed, or just importable? | 19:44 |
mriedem | dhellmann: installed via pip, 0.4 | 19:44 |
dhellmann | do you have other sphinxcontrib modules installed as well? | 19:44 |
mriedem | dhellmann: yeah, httpdomain | 19:45 |
*** otherwiseguy has quit IRC | 19:45 | |
dhellmann | do you have a relatively new version of pbr installed? | 19:45 |
*** jvrbanac has quit IRC | 19:45 | |
mriedem | 0.5.21 | 19:45 |
mriedem | latest | 19:45 |
* dhellmann thinks | 19:45 | |
dhellmann | how are you running the doc build? | 19:45 |
*** dolphm has quit IRC | 19:45 | |
*** dolphm_ has joined #openstack-dev | 19:45 | |
mriedem | dhellmann: i've tried calling sphinx-build directly and going through the makefile in the ceilometer source | 19:46 |
mriedem | both fail with the same thing | 19:46 |
dhellmann | try "tox -e docs" | 19:46 |
*** rnirmal has quit IRC | 19:46 | |
*** rnirmal_ has joined #openstack-dev | 19:46 | |
dhellmann | or "python setup.py build_sphinx" | 19:46 |
mriedem | dhellmann: ok, sec | 19:46 |
*** Ryan_Lane has quit IRC | 19:47 | |
*** yolanda has quit IRC | 19:47 | |
*** Ryan_Lane has joined #openstack-dev | 19:47 | |
mriedem | dhellmann: python setup.py build_sphinx got further, failed on missing flask, installing that now | 19:47 |
dhellmann | mriedem: using tox should install all of the dependencies for you automatically | 19:47 |
mriedem | dhellmann: yeah, trying to build an rpm here | 19:47 |
*** spzala has quit IRC | 19:47 | |
*** dvarga has joined #openstack-dev | 19:48 | |
dhellmann | mriedem: I guess you need system packages of the deps for that? | 19:48 |
mriedem | i don't necessarily need rpms, but yeah, they should be called out as build deps in the spec ultimately - anyway, got past flask, hit keystoneclient, so i'm moving with setup.py sphinx_build, thanks | 19:49 |
*** gordc has quit IRC | 19:49 | |
dhellmann | mriedem: good, ping us in #openstack-metering if you run into more issues | 19:49 |
mriedem | dhellmann: will do, thanks | 19:49 |
dolphm_ | mriedem: you can use setup.py build_sphinx in combination with tox to have it build the venv for you | 19:49 |
*** xqueralt-afk is now known as xqueralt | 19:50 | |
mriedem | dolphm_: yeah, tox would be magical, but not using it in the rpm spec | 19:50 |
dolphm_ | mriedem: might just me "tox -epy27 python setup.py build_sphinx" | 19:50 |
dolphm_ | mriedem: ah | 19:50 |
mriedem | distro packaging, yay! | 19:50 |
*** jvrbanac has joined #openstack-dev | 19:51 | |
*** mestery has joined #openstack-dev | 19:51 | |
*** david-lyle_away is now known as david-lyle | 19:53 | |
*** gyee has joined #openstack-dev | 19:55 | |
*** dvarga has quit IRC | 19:56 | |
*** alop has quit IRC | 19:56 | |
*** datsun180b has joined #openstack-dev | 19:57 | |
*** otherwiseguy has joined #openstack-dev | 19:59 | |
*** radez is now known as radez_g0n3 | 19:59 | |
*** openfly has joined #openstack-dev | 20:01 | |
openfly | hrmm anyone know if jenkins + jclouds works backended to openstack? | 20:01 |
clarkb | openfly: it does | 20:01 |
openfly | stellar. | 20:01 |
clarkb | compute and object storage should work | 20:01 |
clarkb | I have used both but it has been a while | 20:02 |
openfly | any nasty caveats? | 20:02 |
morganfainberg | lbragstad, fast on the +1 there ;) | 20:02 |
clarkb | openfly: not really, I patched the object storage stuff and it seems to work alot better now | 20:02 |
*** amerine has quit IRC | 20:02 | |
clarkb | openfly: debuggign why compute nodes fail is sometimes difficult and jclouds + jenkins doesn't seem to always clean up nodes properly | 20:02 |
lbragstad | morganfainberg: quick! | 20:03 |
openfly | hrmm | 20:03 |
openfly | okay | 20:03 |
clarkb | but those problems exist with the alternatives | 20:03 |
openfly | well that's easy enough to watchdog | 20:03 |
*** amerine has joined #openstack-dev | 20:03 | |
lbragstad | morganfainberg: I saw your 'no functional change' comment and that concluded my review | 20:03 |
clarkb | openfly: check out http://git.openstack.org/cgit/openstack-infra/nodepool | 20:03 |
morganfainberg | lbragstad, hehe. | 20:03 |
clarkb | openfly: ^ is our answer for single use slaves provided by nova, but it isn't well documented yet and is semi specific to our jenkins | 20:04 |
morganfainberg | lbragstad, not like that changeset has any massive ramifications in either case. | 20:04 |
lbragstad | morganfainberg: I'm still going through https://review.openstack.org/#/c/46207/ | 20:04 |
lbragstad | haven't made it all the way through that one | 20:04 |
openfly | awesome will look through it. | 20:05 |
morganfainberg | lbragstad, yeah that one has been a beast. | 20:05 |
morganfainberg | lbragstad thanks for looking through them. more eyes on changes like that = better | 20:06 |
*** venkatesh has quit IRC | 20:06 | |
lbragstad | morganfainberg: not a problem and I completely agree | 20:07 |
*** herndon has joined #openstack-dev | 20:08 | |
*** davi6723 has quit IRC | 20:09 | |
*** dolphm has joined #openstack-dev | 20:10 | |
*** dolphm_ has quit IRC | 20:10 | |
*** vartom110 has quit IRC | 20:11 | |
*** anteaya has quit IRC | 20:12 | |
*** Dr_Who has joined #openstack-dev | 20:13 | |
*** Ryan_Lane has quit IRC | 20:17 | |
*** Ryan_Lane1 has joined #openstack-dev | 20:17 | |
*** Dr_Who has quit IRC | 20:18 | |
*** datsun180b has quit IRC | 20:18 | |
*** vipul-away is now known as vipul | 20:20 | |
*** rnirmal_ has quit IRC | 20:20 | |
morganfainberg | lbragstad, fyi, another patchset is incoming to try and address the tempest failure(s), it's a 1-line fix and some test massaging | 20:20 |
*** jvrbanac has quit IRC | 20:21 | |
*** boden has quit IRC | 20:21 | |
*** dims has quit IRC | 20:21 | |
*** davi6723 has joined #openstack-dev | 20:23 | |
lbragstad | morganfainberg: gotcha, so that is why 46207 was failing Jenkins? | 20:23 |
morganfainberg | i think it's that i removed a ref.copy() | 20:23 |
*** davi6723 is now known as dstanek | 20:23 | |
morganfainberg | in the v3_to_v2 static method | 20:24 |
lbragstad | ahh o k | 20:24 |
morganfainberg | because between the two patchsets, that was the only non-test non-rename-of-function-that-would-prevent-py26/py27-from-passing change | 20:24 |
morganfainberg | lbragstad, https://review.openstack.org/#/c/46207/19..20/keystone/contrib/ec2/controllers.py | 20:24 |
morganfainberg | erm | 20:24 |
morganfainberg | https://review.openstack.org/#/c/46207/19..20/keystone/common/controller.py | 20:25 |
morganfainberg | almost no changes other than that. | 20:25 |
morganfainberg | which also might mean that tempest has made some bad assumptions | 20:25 |
*** dims has joined #openstack-dev | 20:25 | |
morganfainberg | and this might require a fix to tempest's code. | 20:25 |
lbragstad | yeah, there is no functional change there | 20:25 |
morganfainberg | lbragstad, i love when we have tests that verify things are broken :P (not really anyone's fault, just… a headache) | 20:26 |
*** anteaya has joined #openstack-dev | 20:26 | |
lbragstad | morganfainberg: :) so are you going to rebase https://review.openstack.org/#/c/46207/ on the one-liner? | 20:27 |
morganfainberg | lbragstad, hrm? no. the ref.copy() was added in a previous patchset, that was the diff between 19 and 20. | 20:29 |
morganfainberg | lbragstad, i just uploaded a new patchset with that fixed. | 20:29 |
lbragstad | morganfainberg: ahh, yep... following now | 20:29 |
*** jasdeepH has quit IRC | 20:33 | |
*** sgordon has quit IRC | 20:33 | |
*** alop has joined #openstack-dev | 20:33 | |
*** sarob has joined #openstack-dev | 20:34 | |
*** sarob has quit IRC | 20:34 | |
*** sarob has joined #openstack-dev | 20:35 | |
*** networkstatic has quit IRC | 20:35 | |
*** shakayumi has quit IRC | 20:36 | |
*** alop_ has joined #openstack-dev | 20:38 | |
*** alop has quit IRC | 20:38 | |
*** alop_ is now known as alop | 20:38 | |
*** kevinconway has joined #openstack-dev | 20:40 | |
*** amerine has quit IRC | 20:41 | |
*** pamacii is now known as BLOODBATH | 20:41 | |
*** networkstatic has joined #openstack-dev | 20:42 | |
*** eharney has quit IRC | 20:42 | |
*** jasdeepH has joined #openstack-dev | 20:44 | |
*** BLOODBATH is now known as pamacii | 20:45 | |
*** tmclaugh[work] has quit IRC | 20:46 | |
*** anteaya has quit IRC | 20:47 | |
*** sarob has quit IRC | 20:48 | |
*** sarob has joined #openstack-dev | 20:49 | |
*** Ryan_Lane1 has quit IRC | 20:49 | |
*** Ryan_Lane has joined #openstack-dev | 20:49 | |
*** sarob has quit IRC | 20:54 | |
*** jvrbanac has joined #openstack-dev | 20:56 | |
*** otherwiseguy has quit IRC | 20:57 | |
morganfainberg | dolphm, ping | 20:59 |
*** shinylasers has quit IRC | 21:04 | |
*** sarob has joined #openstack-dev | 21:05 | |
*** bfschott has quit IRC | 21:05 | |
*** otherwiseguy has joined #openstack-dev | 21:06 | |
*** Farooque has left #openstack-dev | 21:06 | |
*** thomasm has quit IRC | 21:07 | |
*** sarob has quit IRC | 21:07 | |
*** sarob has joined #openstack-dev | 21:08 | |
*** sarob_ has joined #openstack-dev | 21:09 | |
*** sarob has quit IRC | 21:09 | |
*** pamacii has quit IRC | 21:10 | |
*** thomasm has joined #openstack-dev | 21:11 | |
*** mriedem has left #openstack-dev | 21:14 | |
*** rfolco has quit IRC | 21:16 | |
*** Ryan_Lane has quit IRC | 21:17 | |
*** Ryan_Lane has joined #openstack-dev | 21:17 | |
*** networkstatic has quit IRC | 21:18 | |
*** ericw has quit IRC | 21:18 | |
*** thomasm has quit IRC | 21:18 | |
*** anniec has joined #openstack-dev | 21:19 | |
*** EmilienM has quit IRC | 21:22 | |
*** litong has quit IRC | 21:23 | |
*** dolphm has quit IRC | 21:23 | |
*** EmilienM has joined #openstack-dev | 21:23 | |
*** adjohn has joined #openstack-dev | 21:24 | |
*** dsirrine has quit IRC | 21:26 | |
*** jecarey has joined #openstack-dev | 21:30 | |
*** ericw has joined #openstack-dev | 21:33 | |
*** adjohn has quit IRC | 21:34 | |
*** ericw has quit IRC | 21:34 | |
*** jvrbanac has quit IRC | 21:35 | |
*** sandywalsh_ has quit IRC | 21:37 | |
*** adjohn has joined #openstack-dev | 21:37 | |
*** xqueralt has quit IRC | 21:41 | |
*** amohn9 has quit IRC | 21:42 | |
*** adjohn has quit IRC | 21:44 | |
*** flaper87 is now known as flaper87|afk | 21:44 | |
*** adjohn has joined #openstack-dev | 21:44 | |
*** xqueralt-afk has joined #openstack-dev | 21:45 | |
*** xqueralt-afk is now known as xqueralt | 21:45 | |
*** SumitNaiksatam has quit IRC | 21:50 | |
*** stevemar has quit IRC | 21:53 | |
*** maheshp has quit IRC | 21:53 | |
*** sandywalsh_ has joined #openstack-dev | 21:54 | |
*** adalbas has quit IRC | 21:54 | |
*** SumitNaiksatam has joined #openstack-dev | 21:55 | |
*** kpavel has quit IRC | 21:57 | |
*** davidhadas has quit IRC | 21:58 | |
*** neelashah has quit IRC | 21:58 | |
*** davidhadas has joined #openstack-dev | 21:59 | |
*** jasdeepH has quit IRC | 22:00 | |
*** bdpayne has quit IRC | 22:00 | |
*** neelashah has joined #openstack-dev | 22:01 | |
*** bdpayne has joined #openstack-dev | 22:02 | |
*** carl_baldwin has quit IRC | 22:03 | |
*** jasdeepH has joined #openstack-dev | 22:03 | |
*** anniec has quit IRC | 22:03 | |
*** alop has quit IRC | 22:04 | |
*** alop has joined #openstack-dev | 22:04 | |
*** amohn9 has joined #openstack-dev | 22:07 | |
*** neelashah has quit IRC | 22:09 | |
*** neelashah has joined #openstack-dev | 22:09 | |
*** rnirmal has joined #openstack-dev | 22:11 | |
*** rnirmal has quit IRC | 22:11 | |
*** gfidente has quit IRC | 22:11 | |
*** sarob_ has quit IRC | 22:11 | |
*** sarob has joined #openstack-dev | 22:11 | |
*** troytoman is now known as troytoman-away | 22:11 | |
*** dims has quit IRC | 22:16 | |
*** sarob has quit IRC | 22:16 | |
*** neelashah has quit IRC | 22:17 | |
*** noslzzp has quit IRC | 22:21 | |
*** noslzzp has joined #openstack-dev | 22:22 | |
*** kbringard has quit IRC | 22:23 | |
*** jmontemayor has quit IRC | 22:24 | |
*** prad has quit IRC | 22:24 | |
*** alop has quit IRC | 22:26 | |
*** dims has joined #openstack-dev | 22:31 | |
*** openstack has quit IRC | 22:35 | |
*** openstack has joined #openstack-dev | 22:35 | |
*** dstufft has quit IRC | 22:36 | |
*** davidhadas_ has joined #openstack-dev | 22:36 | |
*** noslzzp has quit IRC | 22:36 | |
*** jecarey has quit IRC | 22:37 | |
*** noslzzp has joined #openstack-dev | 22:37 | |
*** davidhadas has quit IRC | 22:37 | |
*** pcm_ has quit IRC | 22:38 | |
*** xqueralt is now known as xqueralt-afk | 22:39 | |
*** amohn9 has quit IRC | 22:41 | |
*** sarob has joined #openstack-dev | 22:42 | |
*** beekneemec has quit IRC | 22:43 | |
*** yuan has quit IRC | 22:45 | |
*** noslzzp has quit IRC | 22:45 | |
*** pmathews has quit IRC | 22:46 | |
*** sarob has quit IRC | 22:47 | |
*** slagle has joined #openstack-dev | 22:52 | |
*** kdbrierly has quit IRC | 22:53 | |
*** ericw has joined #openstack-dev | 22:55 | |
*** noslzzp has joined #openstack-dev | 22:57 | |
*** amohn9 has joined #openstack-dev | 22:57 | |
*** davidhadas_ has quit IRC | 22:58 | |
*** davidhadas has joined #openstack-dev | 23:00 | |
morganfainberg | lbragstad, ping | 23:00 |
*** otherwiseguy has quit IRC | 23:01 | |
morganfainberg | henrynash / ayoung, ping | 23:01 |
*** dstufft has joined #openstack-dev | 23:03 | |
*** branen has quit IRC | 23:03 | |
*** noslzzp has quit IRC | 23:03 | |
*** herndon has quit IRC | 23:04 | |
*** ericw has quit IRC | 23:05 | |
*** anniec has joined #openstack-dev | 23:05 | |
*** noslzzp has joined #openstack-dev | 23:06 | |
*** sarob has joined #openstack-dev | 23:10 | |
*** FunnyLookinHat has quit IRC | 23:11 | |
*** med_ has quit IRC | 23:13 | |
*** kyleh1 has quit IRC | 23:13 | |
*** adalbas has joined #openstack-dev | 23:15 | |
*** sarob_ has joined #openstack-dev | 23:20 | |
*** sarob has quit IRC | 23:23 | |
*** sarob_ has quit IRC | 23:24 | |
*** sarob has joined #openstack-dev | 23:25 | |
*** hemna is now known as hemnafk | 23:27 | |
notmyname | dhellmann: it was the pbr version. I thought I had already updated that. I must have updated on my VM, not the host. thanks for the help | 23:30 |
*** vuil has quit IRC | 23:32 | |
*** michchap has quit IRC | 23:32 | |
*** gyee has quit IRC | 23:33 | |
*** michchap has joined #openstack-dev | 23:34 | |
*** rwsu has quit IRC | 23:38 | |
*** edmund has quit IRC | 23:38 | |
*** Ryan_Lane has quit IRC | 23:40 | |
*** Ryan_Lane has joined #openstack-dev | 23:40 | |
*** gyee has joined #openstack-dev | 23:41 | |
*** herndon has joined #openstack-dev | 23:50 | |
*** ericw has joined #openstack-dev | 23:52 | |
morganfainberg | gyee, you here (I saw ya in infra asking about stuff) | 23:53 |
morganfainberg | gyee, was just wanting a 2nd opinion on something if you are | 23:53 |
gyee | morganfainberg, yeah, my corporate proxy is messing me up | 23:53 |
morganfainberg | gyee, boo | 23:53 |
morganfainberg | gyee, corporate proxy ick | 23:53 |
gyee | I had to use corkscrew to tunnel ssh through | 23:53 |
morganfainberg | ouch | 23:53 |
gyee | yeah, I was going to murder somebody at IT | 23:54 |
gyee | but thought better of it :) | 23:54 |
morganfainberg | gyee, hehe | 23:54 |
*** maheshp has joined #openstack-dev | 23:54 | |
morganfainberg | gyee, really quick: https://review.openstack.org/#/c/46207/22/keystone/common/controller.py line 270. i removed a ref.copy(), i am thinking it isn't important to isolate the data w/ an explicit copy at this point | 23:54 |
morganfainberg | since it's the same as the domain_id filter | 23:55 |
morganfainberg | gyee, just wanted to get a quick 2nd opinion on that | 23:55 |
gyee | looking | 23:55 |
*** medberry has joined #openstack-dev | 23:55 | |
*** medberry has quit IRC | 23:55 | |
*** medberry has joined #openstack-dev | 23:55 | |
*** adjohn has quit IRC | 23:56 | |
*** amerine has joined #openstack-dev | 23:56 | |
gyee | morganfainberg, no need to return ref | 23:58 |
gyee | you are already modifying ref | 23:58 |
morganfainberg | hrm. | 23:58 |
gyee | so it already have the changes | 23:58 |
morganfainberg | for the implicit list comprehension it would bve needed | 23:58 |
*** davidhadas has quit IRC | 23:59 | |
*** dims has quit IRC | 23:59 | |
morganfainberg | in a number of places we did return self._filter_domain(ref) | 23:59 |
morganfainberg | and i replaced those with this where appropriate | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!