Thursday, 2013-08-29

*** dstanek has quit IRC00:03
*** dvarga has joined #openstack-dev00:07
*** dstanek has joined #openstack-dev00:07
*** hemna is now known as hemnafk00:08
*** danwent has joined #openstack-dev00:08
*** jasdeepH has quit IRC00:09
*** jamiem has quit IRC00:10
*** jecarey has quit IRC00:11
*** xBsd has quit IRC00:11
*** Ryan_Lane has quit IRC00:14
*** Ryan_Lane has joined #openstack-dev00:14
*** Ryan_Lane has quit IRC00:14
*** jamiem has joined #openstack-dev00:14
*** Ryan_Lane has joined #openstack-dev00:15
*** jamiem has quit IRC00:17
*** herndon has quit IRC00:20
*** jasdeepH has joined #openstack-dev00:22
*** jamiem has joined #openstack-dev00:24
*** krtaylor has quit IRC00:25
*** moted has quit IRC00:26
*** moted has joined #openstack-dev00:26
*** gmurphy has joined #openstack-dev00:26
*** sushils has quit IRC00:27
*** hailiang has quit IRC00:28
*** morganfainberg is now known as morganfainberg|a00:30
*** krtaylor has joined #openstack-dev00:33
*** sushils has joined #openstack-dev00:33
*** danwent has quit IRC00:34
*** gyee has quit IRC00:35
*** sungju has joined #openstack-dev00:35
*** danwent has joined #openstack-dev00:35
*** waa has joined #openstack-dev00:36
*** markwash has quit IRC00:37
*** hailiang has joined #openstack-dev00:38
*** sarob has quit IRC00:39
*** dvarga has quit IRC00:39
*** jamiem has quit IRC00:41
*** dvarga has joined #openstack-dev00:41
*** rcrit has quit IRC00:42
*** danwent has quit IRC00:45
*** nati_ueno has quit IRC00:47
*** sarob has joined #openstack-dev00:49
*** Tross has joined #openstack-dev00:49
*** rcrit has joined #openstack-dev00:55
*** Mandell has quit IRC00:55
*** sthaha has joined #openstack-dev00:57
*** sthaha has quit IRC00:57
*** sthaha has joined #openstack-dev00:57
*** sthaha has quit IRC00:58
*** maheshp has joined #openstack-dev00:58
*** joe-hernandez has joined #openstack-dev01:02
*** SumitNaiksatam has quit IRC01:05
*** topol has joined #openstack-dev01:08
*** shardy has quit IRC01:08
*** joe-hernandez has left #openstack-dev01:09
*** maheshp has quit IRC01:09
*** jasondotstar has joined #openstack-dev01:10
*** giulivo has quit IRC01:11
*** sthaha has joined #openstack-dev01:12
*** sthaha has quit IRC01:12
*** sthaha has joined #openstack-dev01:12
*** dstanek has quit IRC01:14
*** dstanek has joined #openstack-dev01:15
*** briancurtin has joined #openstack-dev01:18
*** jasdeepH has quit IRC01:19
*** hailiang has quit IRC01:20
*** erkules_ has joined #openstack-dev01:22
*** erkules has quit IRC01:25
*** lbragstad has joined #openstack-dev01:26
*** dvarga has quit IRC01:27
*** galstrom_zzz is now known as galstrom01:31
*** freedomhui has joined #openstack-dev01:33
*** lbragstad1 has joined #openstack-dev01:33
*** lbragstad has quit IRC01:34
*** jaypipes has joined #openstack-dev01:34
*** maheshp has joined #openstack-dev01:41
bknudsonseen this running keystone tests?01:41
bknudsonAssertionError: Environmental variable PATH_INFO is not a string: <type 'unicode'> (value: u'/v301:41
bknudsonFile "/opt/stack/keystone/.venv/local/lib/python2.7/site-packages/webtest/lint.py", line 332, in check_environ01:41
jamielennoxbknudson, no, but i do remember that there was some issues with unicode and webtest. for example i think if you put headers in as unicode then it failed01:43
jamielennoxi'm not sure if that's webtest not keeping up with the times or if it is a legitimate you can't have unicode in headers01:44
*** sushils has quit IRC01:46
*** zodiak has quit IRC01:46
*** maheshp has quit IRC01:46
*** nati_ueno has joined #openstack-dev01:46
*** cdub_ has quit IRC01:51
*** cbaesema has joined #openstack-dev01:51
*** galstrom is now known as galstrom_zzz01:52
*** jimjiang has quit IRC01:52
*** cdub_ has joined #openstack-dev01:53
*** neelashah has joined #openstack-dev01:54
*** cdub has quit IRC01:57
*** cdub has joined #openstack-dev01:59
*** d34dh0r53 has joined #openstack-dev01:59
*** gongysh has quit IRC01:59
*** SumitNaiksatam has joined #openstack-dev02:01
*** boden has joined #openstack-dev02:01
*** d34dh0r53 has quit IRC02:02
*** sthaha has quit IRC02:03
*** anteaya has quit IRC02:05
*** ljjjustin has joined #openstack-dev02:06
*** jasdeepH has joined #openstack-dev02:06
*** yaguang has joined #openstack-dev02:06
*** dvarga has joined #openstack-dev02:08
dstanekjamielennox: iirc there was some discussion about that on web-sig. some headers need to be bytes based on the HTTP spec02:10
*** adalbas has joined #openstack-dev02:10
*** sthaha has joined #openstack-dev02:11
*** sthaha has quit IRC02:11
*** sthaha has joined #openstack-dev02:11
jamielennoxdstanek, it's not something i know enough about - i would think as a python testing framework webtest should just let it through but possibly if you are going through httpd or something with unicode env variables they might really want to catch that02:11
*** Ryan_Lane has quit IRC02:12
dstanekjamielennox: your guess is as good as mine02:12
*** morganfainberg|a is now known as morganfainberg02:13
*** Tross has quit IRC02:13
*** sarob has quit IRC02:15
novas0x2a|laptopbknudson, dstanek, jamielennox: not sure if it's the problem here, but 1) webtest also wraps any wsgi app you're testing in a wsgi validator to (theoretically) make sure it's not breaking pep 3333 and 2) yes, PATH_INFO is supposed to be bytes and not unicode (see http://www.python.org/dev/peps/pep-3333/#a-note-on-string-types)02:17
novas0x2a|laptopbut it sounds like there might be a bug somewhere because i think PATH_INFO is supposed to be represented on the app side by a native string, not a bytestring.02:20
*** zul has quit IRC02:20
*** michchap has quit IRC02:20
*** michchap has joined #openstack-dev02:21
*** ljjjustin has quit IRC02:22
*** ljjjustin has joined #openstack-dev02:23
*** dvarga has quit IRC02:23
novas0x2a|laptopactually, yep, looks like webtest's check is correct. PATH_INFO should always be a str in python2 or python3. (webtest is actually less strict than it should be, looks like it would accept bytes() in python3, which isn't correct.02:24
*** d34dh0r53 has joined #openstack-dev02:28
*** erkules_ is now known as erkules02:32
*** d34dh0r53 has quit IRC02:33
*** boden has quit IRC02:35
jamielennoxnovas0x2a|laptop, i'm not sure if any of this answers bknudson's question but it is good to know, thans02:36
*** prad_ has quit IRC02:37
novas0x2a|laptopheh, well, it means that (most likely) one of the tests is building a path string to fetch with unicode() instead of str()02:38
*** prad_ has joined #openstack-dev02:39
*** dstanek has quit IRC02:39
*** Tross has joined #openstack-dev02:40
*** stevemar has joined #openstack-dev02:40
*** prad_ has left #openstack-dev02:42
morganfainbergnovas0x2a|laptop: oh interesting02:45
novas0x2a|laptopi think i ran into the same problem when i wrote an adapter that mocks the requests module and feeds it to the app via wsgi instead, because requests does an encode() and my mock did not02:46
novas0x2a|laptoper, s/via wsgi/via webtest/02:46
*** pixelbeat has quit IRC02:48
morganfainbergbknudson: ping (if you're here)02:48
*** SergeyLukjanov has joined #openstack-dev02:50
*** SumitNaiksatam has quit IRC02:50
*** SumitNaiksatam has joined #openstack-dev02:51
*** zaitcev has quit IRC02:53
*** sthaha has quit IRC02:55
*** comay has quit IRC02:59
*** rackerjoe has left #openstack-dev03:00
*** rackerjoe has joined #openstack-dev03:00
*** rackerjoe has left #openstack-dev03:00
*** neelashah has quit IRC03:00
*** melwitt has quit IRC03:01
*** rcleere has joined #openstack-dev03:01
*** nati_ueno has quit IRC03:03
*** novas0x2a|laptop has quit IRC03:04
*** dstanek has joined #openstack-dev03:05
*** shanewang_away is now known as shanewang03:05
*** rwsu has quit IRC03:05
*** sthaha has joined #openstack-dev03:08
*** stevemar has quit IRC03:08
*** Qu310 has joined #openstack-dev03:09
*** vkmc has quit IRC03:11
*** bknudson has left #openstack-dev03:11
*** stevemar has joined #openstack-dev03:12
*** dstanek has quit IRC03:14
*** briancurtin has quit IRC03:15
Qu310I'm trying to make a small change to horizon, I've applyed a patch "https://github.com/openstack/horizon/commit/3247e19ba86d3ee3f48a2c2769c94125871c2354" which allow users to create a volume from an Image, so i want to disable the "Instance Source" requirement for Image to be selected. I tried just adding a noop to the project/instances/workflows/create_instance.py as ('', _("Boot From03:16
Qu310volume.")), however the form submits with an error. I think its possibly something to do with maybe some kind of hard coded requirement for a image_source?03:16
*** Tross has quit IRC03:16
*** morazi has joined #openstack-dev03:18
*** comay has joined #openstack-dev03:18
*** briancurtin has joined #openstack-dev03:19
*** insanidade has joined #openstack-dev03:21
*** jfriedly has quit IRC03:22
*** martine has joined #openstack-dev03:22
*** martine is now known as Guest1330203:23
*** sthaha has quit IRC03:24
*** sthaha has joined #openstack-dev03:24
*** sthaha has quit IRC03:24
*** sthaha has joined #openstack-dev03:24
*** osier has joined #openstack-dev03:26
*** Tross has joined #openstack-dev03:30
*** X-Scale has joined #openstack-dev03:32
*** SergeyLukjanov has quit IRC03:34
*** Guest13302 has quit IRC03:35
*** zodiak has joined #openstack-dev03:37
*** morazi has quit IRC03:39
*** Ryan_Lane has joined #openstack-dev03:40
*** prekarat1 has joined #openstack-dev03:40
*** Tross has quit IRC03:43
*** gongysh has joined #openstack-dev03:45
*** gareth_kun has joined #openstack-dev03:45
*** Dr_Who has joined #openstack-dev03:48
*** jcoufal has joined #openstack-dev03:51
*** aditirav has joined #openstack-dev03:52
*** dina_belova has joined #openstack-dev03:54
*** dina_belova has quit IRC03:56
*** dina_belova has joined #openstack-dev03:57
*** dina_belova has quit IRC04:01
*** melwitt has joined #openstack-dev04:01
*** terryh has quit IRC04:04
*** HenryG has quit IRC04:07
*** jamespage has quit IRC04:08
*** jamespage has joined #openstack-dev04:09
*** jamespage has joined #openstack-dev04:09
*** gongysh has quit IRC04:09
*** vartom7 has joined #openstack-dev04:13
*** comay_ has joined #openstack-dev04:15
*** comay_ has quit IRC04:15
*** aditirav has quit IRC04:18
*** basha has joined #openstack-dev04:19
*** stevemar has quit IRC04:22
*** raies has joined #openstack-dev04:23
raiesffieldt: will you please check https://review.openstack.org/#/c/42624/04:24
*** vartom7 has quit IRC04:28
*** boris-42 has joined #openstack-dev04:30
*** arezadr has quit IRC04:31
*** nshaikh has joined #openstack-dev04:31
*** amotoki has joined #openstack-dev04:33
*** arezadr has joined #openstack-dev04:33
*** Dr_Who is now known as tgall_foo04:35
*** arezadr has quit IRC04:36
*** stevemar has joined #openstack-dev04:37
*** vartom7 has joined #openstack-dev04:37
*** arezadr has joined #openstack-dev04:37
*** reed has quit IRC04:37
*** sandywalsh has quit IRC04:37
*** Tross has joined #openstack-dev04:40
*** X-Scale has quit IRC04:49
*** sthaha has quit IRC04:50
*** sthaha has joined #openstack-dev04:50
*** sthaha has quit IRC04:50
*** sthaha has joined #openstack-dev04:50
*** vartom7 has quit IRC04:51
*** Mandell has joined #openstack-dev04:56
*** aeperezt has quit IRC04:56
*** jasdeepH has quit IRC04:56
*** jasdeepH has joined #openstack-dev04:58
*** prekarat has joined #openstack-dev04:59
*** prekarat1 has quit IRC05:00
*** CaptTofu has quit IRC05:03
*** CaptTofu has joined #openstack-dev05:03
*** avishay_afk is now known as avishay05:05
*** markwash has joined #openstack-dev05:07
*** eharney has quit IRC05:07
*** dina_belova has joined #openstack-dev05:07
*** sandywalsh has joined #openstack-dev05:07
*** CaptTofu has quit IRC05:08
*** rcleere has quit IRC05:11
*** SergeyLukjanov has joined #openstack-dev05:11
*** dina_belova has quit IRC05:12
*** SergeyLukjanov has quit IRC05:13
*** SergeyLukjanov has joined #openstack-dev05:16
*** eglynn has joined #openstack-dev05:16
*** radsy has quit IRC05:17
*** [wchrisj_ has joined #openstack-dev05:19
*** topol has quit IRC05:19
*** SergeyLukjanov has quit IRC05:21
*** SergeyLukjanov has joined #openstack-dev05:23
*** martyntaylor has quit IRC05:29
*** SkyRocknRoll has joined #openstack-dev05:31
*** SergeyLukjanov has quit IRC05:32
*** openfly has quit IRC05:33
*** vartom7 has joined #openstack-dev05:34
*** Mandell has quit IRC05:38
*** kushal has joined #openstack-dev05:39
*** bswartz has quit IRC05:40
*** [wchrisj_ has quit IRC05:44
*** SergeyLukjanov has joined #openstack-dev05:48
*** xqueralt-afk is now known as xqueralt05:48
*** henrynash has joined #openstack-dev05:49
*** mrunge has joined #openstack-dev05:50
*** SergeyLukjanov has quit IRC05:53
*** SergeyLukjanov has joined #openstack-dev05:56
*** Mandell has joined #openstack-dev06:00
*** SergeyLukjanov has quit IRC06:02
*** bswartz has joined #openstack-dev06:03
*** corXi has joined #openstack-dev06:03
*** tgall_foo has quit IRC06:12
*** eharney has joined #openstack-dev06:13
*** devvesa has joined #openstack-dev06:14
*** briancurtin has quit IRC06:15
*** doron_afk has joined #openstack-dev06:19
*** devvesa has quit IRC06:20
*** garyk has joined #openstack-dev06:20
*** marios has joined #openstack-dev06:23
*** bashok has joined #openstack-dev06:23
*** eharney has quit IRC06:25
*** MaxV has joined #openstack-dev06:26
*** jtomasek has joined #openstack-dev06:31
*** jcoufal has quit IRC06:32
*** sumanthns has joined #openstack-dev06:32
sumanthnsAll, I am facing a problem while running ./run_tests.sh in nova06:33
sumanthnsgetting this error "db type could not be determined06:34
sumanthnserror: testr failed (3)"06:34
*** xqueralt is now known as xqueralt-afk06:34
sumanthnsI recreated my virtual environment, but still facing the same problem06:34
sumanthnsany help would be very much appreciated06:34
*** MaxV has quit IRC06:35
*** amotoki has quit IRC06:38
*** amotoki has joined #openstack-dev06:39
*** networkstatic has quit IRC06:42
*** amotoki_ has joined #openstack-dev06:42
*** jpich has joined #openstack-dev06:43
*** devvesa has joined #openstack-dev06:45
*** Tross has quit IRC06:45
*** amotoki has quit IRC06:46
*** jtomasek has quit IRC06:47
*** jtomasek has joined #openstack-dev06:47
*** xga has joined #openstack-dev06:49
*** romcheg1 has joined #openstack-dev06:49
*** mrunge has quit IRC06:50
*** jcoufal has joined #openstack-dev06:52
*** mrunge has joined #openstack-dev06:54
*** pcm_ has quit IRC06:56
*** reidrac has joined #openstack-dev06:57
*** lbragstad has joined #openstack-dev06:58
*** romcheg1 has quit IRC06:58
*** lbragstad1 has quit IRC06:59
morganfainbergjamielennox: ping06:59
*** hailiang has joined #openstack-dev06:59
jamielennoxmorganfainberg, do you sleep?06:59
morganfainbergjamielennox: no.06:59
jamielennoxwhat can i do for you then?06:59
*** xga has quit IRC07:00
morganfainbergjamielennox: want a second brain on this one, aggressive caching (cache on create)07:00
morganfainbergjamielennox: there is an issue with doing this on tokens.  someone could request an expired token to be created.07:00
morganfainbergjamielennox: i think that is silly… but we allow it… in fact… we have a test to validate it works (in a round-about manner)07:00
morganfainbergjamielennox: if i do aggressive caching, i have to inspect every token for expiry on issuance07:01
jamielennoxreally? i didn't know that - i thought expiry was always time + some server set window07:01
morganfainbergjamielennox: you can request a token with expiry of <blah>07:01
jamielennoxseems like a bad idea but let that slide for now07:01
morganfainbergjamielennox: do i refactor the test and make issue_token tell the requestor "uh. no. stop being dumb"07:01
morganfainbergor, do i just not aggressively cache (i don't want to inspect every single token create for expiry)07:02
morganfainbergdownside is, we take an extra hit to the backend because the token isn't immidiately cached07:03
jamielennoxso i would figure out if that is a real policy or just something that's snuck in, because if i'm an admin i don't want people creating tokens with a year of expiry07:03
*** MaxV has joined #openstack-dev07:03
morganfainbergjamielennox: it's intended07:03
jamielennoxbut what i would think is can you flag it on the way into the system07:03
morganfainbergjamielennox: it's the issue with bearer tokens.07:03
jamielennoxi'm not sure that's any cheaper07:03
jamielennoxbut just don't cache any inbound request with an expiry in the payload07:03
morganfainbergjamielennox: it would be cheaper only insomuch as we only inspect if an expiry is passed in on the payload07:04
jamielennoxwell it would simply be a if 'expiry' in dict rather than an actual time decode and compare07:04
morganfainbergby the time we get to caching, i can't tell what the original payload was07:04
jamielennoxah07:04
*** michchap has quit IRC07:05
*** zodiak has quit IRC07:05
*** tkammer has joined #openstack-dev07:05
*** michchap has joined #openstack-dev07:05
morganfainbergi'm just concerned that aggressive caching will bite me down the line.07:05
morganfainbergbut this is the last hurdle for the outstanding caching reviews…(before it's just pending people marking them up) i had to punt on identity caching =/  no time to get a review up (was away from a computer almost all day)07:06
jamielennoxunfortunately with a UUID token, it's one of the main places where you actually want to do it07:06
morganfainbergjamielennox: yes.07:06
jamielennoxi think just cache everything07:07
morganfainbergjamielennox: like i said, i could refactor the issue token stuff to tell people to stop being dumb.07:07
morganfainbergactually sec.07:07
jamielennoxif the token is going to exist in the database anyway the fact that you're caching something expired is not that much excess07:08
*** bashok has quit IRC07:08
jamielennoxassuming people will move away from the expired tokens they will get flushed out07:08
jamielennoxcan you set a cache length?07:08
morganfainbergjamielennox: https://github.com/openstack/keystone/blob/master/keystone/tests/test_backend.py#L243307:08
morganfainbergthat is the test07:08
morganfainbergjamielennox: i can set cache length (in the current design) at the method level07:09
jamielennoxok, that's not letting a client specify an invalid token07:09
jamielennoxsorry expired toke07:09
jamielennoxn07:09
morganfainbergjamielennox: right i was wrong07:09
*** wfoster_away is now known as wfoster07:09
morganfainbergjamielennox: but i know you can request tokens valid for <insert time>.07:09
*** MaxV has quit IRC07:10
morganfainbergjamielennox: in anycase.07:10
jamielennoxi would suggest cache everythin07:10
jamielennoxif the API logic has let it passed then it's going to the db anyway07:10
morganfainbergand just make that test stop complaining?07:10
jamielennoxah right07:10
*** basha has quit IRC07:10
jamielennoxno, you will need to inspect the output of the cache07:11
jamielennoxthat's crap07:11
morganfainbergjamielennox: yeah the expectation of a lot of code is that the back-end will never return an expired token07:11
*** jhesketh has quit IRC07:11
*** jhesketh has joined #openstack-dev07:12
morganfainbergbecause of caching, i've had to work around that in some cases… and provide some heavy invalidation logic in a couple cases.07:12
morganfainbergheck.07:12
jamielennoxcan you refactor the token stuff and move the expiry check outside of the retrieval07:12
jamielennoxthe format should be standard there07:12
morganfainbergjamielennox: this review was all about that issue https://review.openstack.org/#/c/43608/07:12
*** flaper87|afk is now known as flaper8707:12
*** xqueralt-afk is now known as xqueralt07:12
morganfainberghrm.07:13
morganfainberggrr.  inspecting every token's cache is going to be expensive.07:14
morganfainbergwell in theory, everything should check the token is expired...07:14
alogajog0: ping07:14
jamielennoxit won't07:14
morganfainbergthis test is kind of spurious07:14
jamielennoxi think the auth path doesn't07:14
morganfainbergvalidate_X_token does now07:14
jamielennoxit relies on the token backend throwing a not auth07:15
*** amotoki_ is now known as amotoki07:15
morganfainbergauth uses provider.validate_token07:15
jamielennoxah, so it's changed since i looked recently then07:15
morganfainbergyeah like changed in the last uhmm. day?07:15
morganfainbergit was silly that token providers would merrily validate an expired token07:15
jamielennoxi've been client side for a couple of weeks and i feel like the whole code base has changed07:15
morganfainbergjamielennox: we've moved a TON in the last 2 weeks07:16
morganfainbergjamielennox: it's been a challenge to keep up even spending most of my time in the code base.07:16
morganfainberghrm.07:17
morganfainbergjamielennox: does auth_middleware check token expiry07:17
morganfainbergjamielennox: i am sure it does…but… it's late here :P07:17
jamielennoxclient side07:17
jamielennoxit relies on the server to tell it what's valid07:18
morganfainbergunless it's PKI i assume?07:18
morganfainbergor does it do a "check" on that as well?07:18
jamielennoxhmmm07:18
*** blentz has quit IRC07:19
jamielennoxmorganfainberg, yep, it validates expiry07:20
*** SkyRocknRoll has quit IRC07:20
*** SkyRocknRoll has joined #openstack-dev07:20
*** afazekas has joined #openstack-dev07:21
jamielennoxfor UUID and for PKI07:21
morganfainbergjamielennox: ok this test is def. spurious then07:21
morganfainbergjamielennox: well more like… superfluous07:21
morganfainbergugh. i really don't want to upload a test removal patchset… but it's good practice :P07:21
morganfainbergtest removal should not be mixed in with the main patchset.07:22
jamielennoxyea, and it's a tough one to justify because it really is changing the way it works, so you need to catch that everywhere07:23
*** Mandell has quit IRC07:24
morganfainbergjamielennox: yeah.07:24
morganfainbergjamielennox: but i think most everything that actually calls get_token is smart now.07:25
*** yolanda has joined #openstack-dev07:25
morganfainbergjamielennox: erk. looks like there are more places =/.07:27
jamielennoxthe auth path in keystone itself is tragic07:27
jamielennoxv2 is completely different to v3 and there are a lot of places that retrieve tokens from the backend07:27
jamielennoxi think i had a blueprint at one point to move all the token handling of keystone into a middleware component as well07:28
jamielennoxit never took off07:28
*** openfly has joined #openstack-dev07:28
morganfainbergjamielennox: well… if we are lucky v2 tokens can go bye-bye in the L release?07:29
morganfainbergjamielennox: assuming the api is deprecated in Icehouse07:30
*** dkehn has quit IRC07:31
*** mrunge is now known as mrunge_brb07:32
*** gmurphy has quit IRC07:32
*** SergeyLukjanov has joined #openstack-dev07:32
*** shardy has joined #openstack-dev07:33
*** SergeyLukjanov has quit IRC07:33
*** hailiang has quit IRC07:33
*** xga has joined #openstack-dev07:34
morganfainbergjamielennox: ok v2 tokens look safe to never _actually_ build an expired token. actually, it looks like you can't request a token for longer than the default expire time now (wonder when that changed)07:34
jamielennoxi'm still not certain you ever could07:35
jamielennoxthat's a really bad thing to have left up to the user to determine07:35
morganfainbergjamielennox: i'm fair certain you could.  like essex or diablo07:35
jamielennoxoh, that's before my time07:35
morganfainbergjamielennox: my company still deals with some essex stuff07:35
*** gongysh has joined #openstack-dev07:35
*** SergeyLukjanov has joined #openstack-dev07:36
morganfainbergjamielennox: so, sometimes i cross wires about versions07:36
*** ndipanov_gone is now known as ndipanov07:37
*** MaxV has joined #openstack-dev07:37
*** MaxV has joined #openstack-dev07:37
jamielennoxmorganfainberg, https://review.openstack.org/#/c/44014/07:39
jamielennox+870, -204107:39
morganfainbergjamielennox: w00t!07:39
morganfainbergjamielennox: i promise to look at it tomorrow? want to get token stuffs done.07:39
morganfainbergthen sleep07:39
jamielennoxthat's fine07:39
*** JordanP has joined #openstack-dev07:40
jamielennoxi'm just happy to get it out, i imagine it'll be a hard review07:40
morganfainbergs/sleep/something that i swear isn't really sleep/07:40
*** kushal has quit IRC07:40
*** gongysh has quit IRC07:40
jamielennoxmorganfainberg, no need to brag about your love life07:40
morganfainbergjamielennox: i did the last review on it.  it wasn't bad… just long.07:40
*** gongysh has joined #openstack-dev07:41
morganfainbergjamielennox: *sigh* i wish i could claim that.  i'll take a 2 doses of insomnia (or more like works better as a night owl) and see a doctor in the morning07:41
morganfainberg:P07:42
jamielennoxmorganfainberg, alright i'm out, going for a run or something before it get's too dark07:42
*** jgallard has joined #openstack-dev07:42
morganfainbergjamielennox: have a good one.07:42
jamielennoxthat's two working days you've got through :)07:42
morganfainbergLOL07:42
*** michchap has quit IRC07:43
*** doron_afk is now known as doron07:43
*** mrunge_brb is now known as mrunge07:45
*** jaimegil has joined #openstack-dev07:45
*** henrynash has quit IRC07:47
*** fbo_away is now known as fbo07:48
*** gongysh has quit IRC07:48
*** romcheg has joined #openstack-dev07:48
*** xga_ has joined #openstack-dev07:51
*** SergeyLukjanov has quit IRC07:51
*** jistr has joined #openstack-dev07:52
*** giulivo has joined #openstack-dev07:53
*** jcoufal has quit IRC07:54
*** jcoufal_ has joined #openstack-dev07:54
*** xga has quit IRC07:55
*** MaxV has quit IRC07:55
*** eglynn has quit IRC07:55
*** MaxV has joined #openstack-dev07:56
*** SergeyLukjanov has joined #openstack-dev07:58
*** romcheg has quit IRC07:58
*** sandeepr_ltp has quit IRC07:58
*** yassine has joined #openstack-dev07:59
*** SergeyLukjanov has quit IRC07:59
*** sandeepr_ltp has joined #openstack-dev07:59
*** corXi has quit IRC07:59
*** doron is now known as doron_afk07:59
*** tkammer has quit IRC08:01
*** gongysh has joined #openstack-dev08:02
*** boden has joined #openstack-dev08:03
*** michchap has joined #openstack-dev08:04
*** xga has joined #openstack-dev08:06
*** xga_ has quit IRC08:07
*** derekh has joined #openstack-dev08:10
*** safchain has joined #openstack-dev08:12
*** SkyRocknRoll has quit IRC08:14
*** vsergeyev has joined #openstack-dev08:16
*** freedomhui has quit IRC08:18
*** gongysh has quit IRC08:23
*** eglynn has joined #openstack-dev08:25
*** SergeyLukjanov has joined #openstack-dev08:27
*** lucasagomes has joined #openstack-dev08:28
*** henrynash has joined #openstack-dev08:32
bauzasmorning all08:36
bauzasI spotted an error when deploying devstack with baremetal and neutron08:36
bauzaswhen using both, we need to set OVS_PHYSICAL_BRIDGE08:36
bauzasas the default value is null, it will loose eth0 connectivity if not set08:37
bauzascommit 37a8d157a11abe55736707fdec2fc8a273027a2f08:37
bauzasAuthor: Devananda van der Veen <devananda.vdv@gmail.com>08:37
bauzasDate:   Tue Jan 15 17:27:34 2013 -080008:37
bauzasis devenanda there ?08:38
bauzas^devananda08:38
uvirtbotbauzas: Error: "devananda" is not a valid command.08:38
JordanP^lol08:38
uvirtbotJordanP: Error: "lol" is not a valid command.08:38
*** garyk has quit IRC08:41
*** garyk has joined #openstack-dev08:41
*** athomas has joined #openstack-dev08:41
*** romcheg has joined #openstack-dev08:42
*** basha has joined #openstack-dev08:44
*** melwitt has quit IRC08:46
*** basha has quit IRC08:46
*** prekarat has quit IRC08:48
*** reidrac has left #openstack-dev08:49
*** jbresnah has quit IRC08:50
*** sumansn_ has joined #openstack-dev08:51
morganfainberghenrynash: ping08:52
*** reidrac has joined #openstack-dev08:53
henrynashmorganfainberg: hi08:53
morganfainberghenrynash: you might want to toss DocImpact on your filtering patchset as well.08:53
*** freedomhui has joined #openstack-dev08:53
morganfainberghenrynash: i was about to log out and head to bed, but did one last pass on reviews ;)08:54
*** sumanthns has quit IRC08:54
morganfainberghenrynash: i don't think it'd be an issue w/o it, but you know… someone might say something08:54
henrynashmorganfainberg: although is there any doc impact?  Ahh, maybe for the limit?08:54
morganfainberghenrynash: yep.08:54
*** SergeyLukjanov has quit IRC08:54
henrynashmorganfainberg:  good point08:54
henrynashmorganfainberg: thx08:54
morganfainberghenrynash: of course! trying to save ya more patchsets when people comment about that stuff ;)08:55
henrynashmorganfainberg: :-)08:55
*** martyntaylor has joined #openstack-dev08:56
*** arezmerita has quit IRC08:56
*** pcm_ has joined #openstack-dev08:57
*** donaldh has joined #openstack-dev08:57
*** ruhe has joined #openstack-dev09:00
*** pcm_ has quit IRC09:01
*** johnthetubaguy has joined #openstack-dev09:02
*** stevemar has quit IRC09:02
morganfainberghenrynash: how often do we merge transifex stuff?  ours is only up to… uhm… 43k lines changeset now :P09:03
henrynashmorganfainberg: i don't actually know how/what triggers that...09:03
*** alexpilotti has joined #openstack-dev09:03
morganfainberghenrynash: anyways.. g'night and if you get a chance, https://review.openstack.org/#/c/43195/, https://review.openstack.org/#/c/44211/1, https://review.openstack.org/#/c/43609/ (though if you're busy, not a worry, I'm sure i'll have some people in the morning looking at it)09:04
henrynashmorganfainverg: will do09:04
morganfainberghenrynash: looks like i'm going to have to punt on identity caching.  was out all day today =/  didn't get a chance to write much code until it was almost midnight pacific time09:04
*** dstanek has joined #openstack-dev09:05
*** sushils has joined #openstack-dev09:05
*** corXi has joined #openstack-dev09:05
henrynashmorganfainberg: not necessarily, I think the freeze is only a proposal freeze…(i.e. from today nother newly proposed will get in), but the actual code freeze is sept 4th09:05
morganfainberghenrynash: my understanding is that all code for proposals had to be up for review.  iteration (bugs etc) was fine.09:06
morganfainberghenrynash: but it had to have reviews up.  i'll clarify tomorrow.09:07
*** dachary has quit IRC09:07
henrynashmorganfainberg: that's true…so if there are features missing, then yes, those features can't be added09:07
*** basha has joined #openstack-dev09:07
morganfainberghenrynash: yep.  aka caching identity ;)09:07
henrynashmorganfainberg: probably, yes :-(09:07
*** dachary has joined #openstack-dev09:07
morganfainberghenrynash: but i got assignment! and token_revocation! and likely tokens.09:08
morganfainbergwell, hopefully assignment caching goes in.09:08
morganfainberganyways.. g'night!09:08
henrynashmorganfainberg: which is a major step forward09:08
henrynashmorganfianberg: indeed, goodnight09:08
*** danpb has joined #openstack-dev09:09
*** danpb has left #openstack-dev09:09
*** rods1 has joined #openstack-dev09:11
psedlakcan anyone familiar with keystoneclient middleware please look at http://logs.openstack.org/23/43723/4/gate/gate-tempest-devstack-vm-full/3fefc90/logs/screen-c-api.txt.gz#_2013-08-28_06_24_24_814 ... what is the 'wrong' part there ... failing openssl cms verify - unable to get issuer ... or the probable retry - unable to find auth token in headers?09:14
*** mmagr has joined #openstack-dev09:15
*** bashok has joined #openstack-dev09:15
*** arezmerita has joined #openstack-dev09:16
*** morganfainberg is now known as morganfainberg|a09:17
*** prekarat has joined #openstack-dev09:18
*** henrynash has quit IRC09:18
*** doron_afk is now known as doron09:19
*** freedomhu has joined #openstack-dev09:19
*** freedomhui has quit IRC09:23
*** henrynash has joined #openstack-dev09:26
*** romcheg has quit IRC09:26
*** yongli has quit IRC09:32
*** henrynash has quit IRC09:32
*** doron is now known as doron_afk09:33
*** pixelbeat has joined #openstack-dev09:33
*** pcm_ has joined #openstack-dev09:34
*** apevec has joined #openstack-dev09:37
*** apevec has joined #openstack-dev09:37
*** tkammer has joined #openstack-dev09:37
*** apevec has left #openstack-dev09:37
*** doron_afk is now known as doron09:39
*** ljjjustin has quit IRC09:41
sgranany neutron devs around?09:41
*** romcheg has joined #openstack-dev09:42
sgranI'm chasing what seems to be a bug in the OVS agent, but I wanted to ask some questions about the test suite09:42
*** romcheg has quit IRC09:42
*** prekarat has quit IRC09:43
*** doron is now known as doron_afk09:44
*** romcheg has joined #openstack-dev09:47
*** markmc has joined #openstack-dev09:47
*** doron_afk is now known as doron09:47
*** romcheg has quit IRC09:49
*** romcheg has joined #openstack-dev09:49
sgranor is there a better channel to find neutron devs?09:50
*** dstanek has quit IRC09:51
*** romcheg1 has joined #openstack-dev09:53
*** romcheg has quit IRC09:56
*** senk has quit IRC09:57
ndipanov#openstack-neutron09:57
ndipanovsgran, ^ maybe?09:58
*** romcheg1 has quit IRC10:00
sgranbrilliant, thanks10:01
*** vartom7 has quit IRC10:03
*** romcheg has joined #openstack-dev10:04
*** prekarat has joined #openstack-dev10:04
*** SlickNik has quit IRC10:07
*** romcheg has quit IRC10:09
*** romcheg has joined #openstack-dev10:10
*** romcheg has quit IRC10:12
*** basha has quit IRC10:12
*** senk has joined #openstack-dev10:13
*** dkehn has joined #openstack-dev10:13
*** martyntaylor has quit IRC10:13
*** xga has quit IRC10:13
*** xga has joined #openstack-dev10:14
*** yassine has quit IRC10:14
*** yassine_ has joined #openstack-dev10:14
*** SlickNik has joined #openstack-dev10:15
*** xga_ has joined #openstack-dev10:17
*** ruhe has quit IRC10:18
*** tkammer has quit IRC10:18
*** vartom7 has joined #openstack-dev10:20
*** xga has quit IRC10:20
*** romcheg has joined #openstack-dev10:22
*** aditirav has joined #openstack-dev10:24
*** doron is now known as doron_afk10:27
*** fifieldt has quit IRC10:29
*** ema has joined #openstack-dev10:30
*** ema has joined #openstack-dev10:30
*** pcm_ has quit IRC10:31
*** gareth_kun has left #openstack-dev10:32
*** doron_afk has quit IRC10:32
*** garyk has quit IRC10:33
*** prekarat has quit IRC10:39
*** morazi has joined #openstack-dev10:42
*** martyntaylor has joined #openstack-dev10:44
*** basha has joined #openstack-dev10:45
*** romcheg has quit IRC10:46
*** ydacheville_ has quit IRC10:47
*** ydacheville has joined #openstack-dev10:47
*** wfoster is now known as wfoster_away10:53
*** sandeepr_ltp has quit IRC10:53
*** sandeepr_ltp has joined #openstack-dev10:53
*** ruhe has joined #openstack-dev10:53
*** sandeepr_ltp has quit IRC10:58
*** yaguang has quit IRC10:59
*** sandeepr_ltp has joined #openstack-dev10:59
*** dprince has joined #openstack-dev11:01
*** ruhe has quit IRC11:01
*** ruhe has joined #openstack-dev11:02
*** romcheg has joined #openstack-dev11:03
*** romcheg has left #openstack-dev11:04
*** clairence has joined #openstack-dev11:04
*** henrynash has joined #openstack-dev11:04
*** ruhe has quit IRC11:10
*** avishay has quit IRC11:10
*** ruhe has joined #openstack-dev11:10
*** SkyRocknRoll has joined #openstack-dev11:11
raieshi everybody :)      is there someone from neutron team ?11:11
*** SkyRocknRoll has quit IRC11:11
*** SkyRocknRoll has joined #openstack-dev11:11
*** clairence has quit IRC11:13
*** matiu has quit IRC11:15
*** aditirav has quit IRC11:16
*** aditirav has joined #openstack-dev11:16
*** dstanek has joined #openstack-dev11:18
*** ccorrigan has quit IRC11:19
*** jasondotstar has quit IRC11:20
*** wfoster_away is now known as wfoster11:21
*** dstanek has quit IRC11:23
*** egallen has joined #openstack-dev11:23
*** dstufft has quit IRC11:27
*** dstufft has joined #openstack-dev11:28
*** dstufft has quit IRC11:30
*** dstufft has joined #openstack-dev11:31
*** xga_ has quit IRC11:33
henrynashbdpayne: ping11:35
*** xga has joined #openstack-dev11:36
*** yolanda has quit IRC11:36
*** AndreyGrebenniko has joined #openstack-dev11:37
AndreyGrebenniko Hi there people, may anyone help me to switch domains support in keystone? I've already read a ton of info, but I didn't actually found how to operate with it11:37
*** yolanda has joined #openstack-dev11:38
*** tmclaugh[work] has joined #openstack-dev11:39
*** Guest83706 has joined #openstack-dev11:41
*** dprince has quit IRC11:42
*** FunnyLookinHat has joined #openstack-dev11:44
*** ema_ has joined #openstack-dev11:44
*** ema_ has joined #openstack-dev11:44
*** pcm_ has joined #openstack-dev11:44
*** martine has joined #openstack-dev11:45
*** martine is now known as Guest3945111:45
*** Guest39451 is now known as martine_11:45
*** HenryG has joined #openstack-dev11:46
*** ema has quit IRC11:47
*** lucasagomes is now known as lucas-hungry11:47
*** prad_ has joined #openstack-dev11:47
*** johnthetubaguy has quit IRC11:48
*** johnthetubaguy has joined #openstack-dev11:48
*** martyntaylor has quit IRC11:49
*** johnthetubaguy1 has joined #openstack-dev11:50
*** johnthetubaguy has quit IRC11:51
*** maheshp has joined #openstack-dev11:51
*** sthaha has quit IRC11:56
*** sthaha has joined #openstack-dev11:57
*** sthaha has quit IRC11:57
*** sthaha has joined #openstack-dev11:57
*** michchap has quit IRC11:58
*** jamielennox has quit IRC11:59
*** michchap has joined #openstack-dev11:59
*** jamielennox|away has joined #openstack-dev11:59
*** maheshp has quit IRC11:59
*** rfolco has joined #openstack-dev12:00
*** martyntaylor has joined #openstack-dev12:02
*** xga has quit IRC12:02
*** dolphm has joined #openstack-dev12:03
*** romcheg has joined #openstack-dev12:04
*** xga has joined #openstack-dev12:07
*** Tross has joined #openstack-dev12:07
*** dstufft has quit IRC12:08
*** lucas-hungry is now known as lucasagomes12:10
*** dvarga has joined #openstack-dev12:14
*** SergeyLukjanov has joined #openstack-dev12:15
*** dstufft has joined #openstack-dev12:16
*** Murali_Balcha has joined #openstack-dev12:17
*** SergeyLukjanov has quit IRC12:20
*** CaptTofu has joined #openstack-dev12:20
*** osier has quit IRC12:21
*** jamiem has joined #openstack-dev12:21
*** johnthetubaguy1 is now known as johnthetubaguy12:21
*** dkranz has quit IRC12:21
*** osier has joined #openstack-dev12:21
*** ruhe has quit IRC12:22
*** dstufft has quit IRC12:25
*** dstufft has joined #openstack-dev12:26
*** dims has joined #openstack-dev12:26
*** jaimegil has quit IRC12:26
*** henrynash has quit IRC12:27
*** Ruetobas has joined #openstack-dev12:29
*** pixelbeat has quit IRC12:29
*** jergerber has joined #openstack-dev12:30
*** nshaikh has left #openstack-dev12:33
*** dstanek_ has joined #openstack-dev12:41
*** Ruetobas has quit IRC12:42
*** romcheg has left #openstack-dev12:42
*** aloga has quit IRC12:44
*** terryh has joined #openstack-dev12:44
*** sandywalsh has quit IRC12:46
*** pixelbeat has joined #openstack-dev12:48
*** Ruetobas has joined #openstack-dev12:49
*** basha has quit IRC12:50
*** Dr_Who has joined #openstack-dev12:50
*** basha has joined #openstack-dev12:50
*** sandeepr_ltp has quit IRC12:50
*** shanewang is now known as shanewang_away12:51
*** anteaya has joined #openstack-dev12:51
*** dstanek_ has quit IRC12:51
*** sandeepr_ltp has joined #openstack-dev12:51
*** jasondotstar has joined #openstack-dev12:52
*** basha has quit IRC12:53
*** romcheg has joined #openstack-dev12:54
*** dstanek has joined #openstack-dev12:54
*** SkyRocknRoll has quit IRC12:56
*** kbringard has joined #openstack-dev12:56
*** afazekas has quit IRC12:57
*** blentz has joined #openstack-dev12:57
*** markmc has quit IRC12:59
*** radez_g0n3 is now known as radez13:00
*** blentz_ has joined #openstack-dev13:00
*** sandywalsh has joined #openstack-dev13:01
*** blentz_ has quit IRC13:01
*** Dr_Who is now known as tgall_foo13:01
*** blentz has quit IRC13:02
*** blentz has joined #openstack-dev13:02
*** sthaha has quit IRC13:03
*** jayg|g0n3 is now known as jayg13:07
*** basha has joined #openstack-dev13:08
*** ruhe has joined #openstack-dev13:08
*** hartsocks has joined #openstack-dev13:09
*** hartsocks has left #openstack-dev13:10
*** jimfehlig has joined #openstack-dev13:11
*** osier has quit IRC13:13
*** alunduil has quit IRC13:15
*** maheshp has joined #openstack-dev13:15
*** rcrit has quit IRC13:16
*** leif has joined #openstack-dev13:16
*** leif is now known as Guest7611813:17
*** stevemar has joined #openstack-dev13:18
*** eharney has joined #openstack-dev13:20
*** gordc has joined #openstack-dev13:21
*** aditirav has quit IRC13:22
*** ruhe has quit IRC13:25
*** [wchrisj_ has joined #openstack-dev13:25
*** jruzicka has joined #openstack-dev13:26
*** ruhe has joined #openstack-dev13:27
*** vartom7 has quit IRC13:28
*** tgall_foo has quit IRC13:30
*** rcrit has joined #openstack-dev13:31
*** afazekas has joined #openstack-dev13:33
*** ruhe_ has joined #openstack-dev13:34
*** xga_ has joined #openstack-dev13:34
*** sandeepr_ltp has quit IRC13:35
*** xga has quit IRC13:35
*** ruhe has quit IRC13:35
*** osier has joined #openstack-dev13:35
*** alunduil has joined #openstack-dev13:35
*** FunnyLookinHat has quit IRC13:36
*** basha has quit IRC13:37
*** marun has joined #openstack-dev13:37
*** dkehn_ has joined #openstack-dev13:38
*** dkehn has quit IRC13:40
*** xga_ has quit IRC13:42
*** xga has joined #openstack-dev13:43
*** changbl has quit IRC13:43
*** dkehn_ is now known as dkehn13:44
*** bswartz has quit IRC13:44
*** neelashah has joined #openstack-dev13:48
*** herndon has joined #openstack-dev13:49
*** jdennis1 has quit IRC13:49
*** lbragstad has quit IRC13:52
*** herndon has quit IRC13:52
*** jcoufal_ has quit IRC13:53
*** sumansn_ has quit IRC13:54
*** davidlanouette1 has joined #openstack-dev13:56
*** dkranz has joined #openstack-dev13:58
*** topol has joined #openstack-dev13:59
*** egallen has quit IRC14:00
*** henrynash has joined #openstack-dev14:00
*** jprovazn has joined #openstack-dev14:01
*** codenamekt has joined #openstack-dev14:02
*** prad has quit IRC14:02
*** stevemar has quit IRC14:04
*** egallen has joined #openstack-dev14:05
*** radez is now known as radez_g0n314:07
*** spzala has joined #openstack-dev14:07
*** jecarey has joined #openstack-dev14:08
*** davidlanouette1 has left #openstack-dev14:09
*** bswartz has joined #openstack-dev14:10
*** rwsu has joined #openstack-dev14:10
*** alexpilotti has quit IRC14:10
*** davidlanouette1 has joined #openstack-dev14:13
*** esheffield has joined #openstack-dev14:14
*** aeperezt has joined #openstack-dev14:14
*** michchap has quit IRC14:16
*** tgall_foo has joined #openstack-dev14:18
*** tgall_foo has quit IRC14:18
*** tgall_foo has joined #openstack-dev14:18
*** henrynash has quit IRC14:18
*** janisg has quit IRC14:19
*** alexpilotti has joined #openstack-dev14:20
*** networkstatic has joined #openstack-dev14:22
*** adalbas has quit IRC14:23
*** eharney has quit IRC14:24
*** basha has joined #openstack-dev14:24
*** alexpilotti has quit IRC14:25
*** basha has quit IRC14:25
*** herndon has joined #openstack-dev14:26
*** athomas has quit IRC14:26
*** eharney has joined #openstack-dev14:27
*** tserong_ has joined #openstack-dev14:27
*** tserong has quit IRC14:29
*** mlavalle has joined #openstack-dev14:29
*** herndon has quit IRC14:29
*** dhellmann_ is now known as dhellmann14:29
*** briancurtin has joined #openstack-dev14:30
*** janisg has joined #openstack-dev14:30
*** athomas has joined #openstack-dev14:31
*** rnirmal has joined #openstack-dev14:32
*** alexb_ has joined #openstack-dev14:32
*** jprovazn has quit IRC14:34
*** yaguang has joined #openstack-dev14:34
*** souvik has joined #openstack-dev14:35
*** alexb_ has quit IRC14:35
*** dkehn_ has joined #openstack-dev14:36
*** jdennis1 has joined #openstack-dev14:38
*** kbrierly has joined #openstack-dev14:38
*** dkehn has quit IRC14:38
*** stevemar has joined #openstack-dev14:39
*** stevemar has quit IRC14:39
*** ruhe_ has quit IRC14:39
*** jdennis1 has quit IRC14:39
*** ruhe has joined #openstack-dev14:40
*** alexb_ has joined #openstack-dev14:42
*** jvrbanac has joined #openstack-dev14:42
*** carl_baldwin has joined #openstack-dev14:43
*** dstanek has quit IRC14:43
*** davidlanouette1 has quit IRC14:43
*** adalbas has joined #openstack-dev14:44
*** alexb_ has quit IRC14:44
*** dkehn_ is now known as dkehn14:44
*** michchap has joined #openstack-dev14:47
*** changbl has joined #openstack-dev14:47
*** matiu has joined #openstack-dev14:47
*** matiu has quit IRC14:47
*** matiu has joined #openstack-dev14:47
*** jprovazn has joined #openstack-dev14:49
*** rcleere has joined #openstack-dev14:49
*** alexb_ has joined #openstack-dev14:49
*** davidlanouette1 has joined #openstack-dev14:50
*** datsun180b has joined #openstack-dev14:50
*** carl_baldwin has quit IRC14:52
*** carl_baldwin has joined #openstack-dev14:53
*** pmathews has joined #openstack-dev14:55
*** shakayumi has joined #openstack-dev14:55
*** michchap_ has joined #openstack-dev14:55
*** litong has joined #openstack-dev14:55
*** michchap has quit IRC14:55
*** yaguang has quit IRC14:56
*** michchap has joined #openstack-dev14:56
*** edmund has joined #openstack-dev14:58
*** michcha__ has joined #openstack-dev14:59
*** michchap_ has quit IRC14:59
*** davidlanouette1 has left #openstack-dev15:01
*** henrynash has joined #openstack-dev15:01
*** michchap has quit IRC15:01
*** souvik has quit IRC15:01
*** michchap has joined #openstack-dev15:01
*** rupakg has joined #openstack-dev15:02
*** Murali_Balcha has quit IRC15:03
*** michchap_ has joined #openstack-dev15:03
*** reidrac has quit IRC15:03
*** michcha__ has quit IRC15:03
*** dstanek has joined #openstack-dev15:03
*** jcoufal has joined #openstack-dev15:04
*** stevemar has joined #openstack-dev15:05
*** xmltok has quit IRC15:05
dolphmdstanek: git ready https://gist.github.com/dolph/636953815:05
*** marios has quit IRC15:05
*** michchap has quit IRC15:06
dstanekdolphm: thanks15:06
*** michchap_ has quit IRC15:08
*** pschaef has joined #openstack-dev15:08
*** hemna has joined #openstack-dev15:10
*** iartarisi has joined #openstack-dev15:10
*** jmontemayor has joined #openstack-dev15:13
*** Mandell has joined #openstack-dev15:13
*** Murali_Balcha has joined #openstack-dev15:15
*** egallen has quit IRC15:15
*** alexb_ has quit IRC15:18
*** amscanne has quit IRC15:18
*** egallen has joined #openstack-dev15:19
*** galstrom_zzz is now known as galstrom15:19
*** amscanne has joined #openstack-dev15:19
*** radez_g0n3 is now known as radez15:21
*** basha has joined #openstack-dev15:24
*** amscanne has quit IRC15:25
*** jprovazn has quit IRC15:26
*** gyee has joined #openstack-dev15:27
*** MaxV has quit IRC15:27
*** derekh has quit IRC15:29
*** ifarkas has quit IRC15:30
*** jpich has quit IRC15:30
*** bashok has quit IRC15:32
*** markwash has quit IRC15:33
*** alexpilotti has joined #openstack-dev15:34
*** networkstatic has quit IRC15:40
*** celor has joined #openstack-dev15:42
celorhi!15:43
*** souvik has joined #openstack-dev15:43
celorI have seen that Oauth1.0 will be in Havanna, Does anybody knows why they have implement the v1.0 and in instance of the v2.0?15:43
*** souvik1 has joined #openstack-dev15:43
*** freedomhu has quit IRC15:45
*** jfriedly has joined #openstack-dev15:47
*** souvik has quit IRC15:47
*** wfoster is now known as wfoster_away15:48
*** maheshp has quit IRC15:49
*** zodiak has joined #openstack-dev15:49
*** alop has joined #openstack-dev15:49
*** souvik1 has left #openstack-dev15:50
*** tgall_foo has quit IRC15:53
*** MaxV has joined #openstack-dev15:54
*** bugsduggan has quit IRC15:54
*** changbl has quit IRC15:55
*** maheshp has joined #openstack-dev15:55
*** jcoufal has quit IRC15:56
stevemarcelor: oauth 2.0 python libraries that had server side support were ... hard to find and incomplete to say the least15:57
*** pmathews1 has joined #openstack-dev15:57
*** pmathews has quit IRC15:58
*** xga has quit IRC15:59
*** celor1 has joined #openstack-dev16:00
*** xga has joined #openstack-dev16:01
*** stevemar is now known as stevemar|afk16:01
*** datsun180b has quit IRC16:01
*** mmagr has quit IRC16:01
*** celor has quit IRC16:01
*** roz_ has quit IRC16:02
*** jhesketh has quit IRC16:03
*** basha has quit IRC16:04
*** devoid has joined #openstack-dev16:04
*** MaxV has quit IRC16:05
*** alexpilotti has quit IRC16:06
*** bugsduggan has joined #openstack-dev16:06
*** alop_ has joined #openstack-dev16:07
*** alop has quit IRC16:08
*** alop_ is now known as alop16:08
*** rupakg has quit IRC16:08
*** radez is now known as radez_g0n316:09
*** freedomhui has joined #openstack-dev16:09
*** celor1 has quit IRC16:10
*** celor has joined #openstack-dev16:11
*** janisg has quit IRC16:11
*** romcheg has left #openstack-dev16:11
*** changbl has joined #openstack-dev16:13
*** zaneb has quit IRC16:13
*** celor has quit IRC16:14
*** celor has joined #openstack-dev16:14
*** alexpilotti has joined #openstack-dev16:14
*** wfoster_away is now known as wfoster16:16
*** danwent has joined #openstack-dev16:16
*** iartarisi has quit IRC16:18
claygclarkb: re https://bugs.launchpad.net/swift/+bug/1217288 - I'm not sure that it *is* new setuptools, it happened as soon as setuptools 1.1 was pushed to pypi, but I'm not sure on correlation vs. causation16:18
uvirtbotLaunchpad bug 1217288 in swift "Swift installation crashes" [High,Confirmed]16:18
*** celor has quit IRC16:19
*** FunnyLookinHat has joined #openstack-dev16:19
*** markwash has joined #openstack-dev16:19
*** amotoki has quit IRC16:19
*** arezadr has quit IRC16:19
*** wfoster is now known as wfoster_away16:19
*** danwent has quit IRC16:21
*** Ryan_Lane has quit IRC16:21
*** networkstatic has joined #openstack-dev16:21
*** dina_belova has joined #openstack-dev16:22
*** mkerrin has quit IRC16:23
*** jistr has quit IRC16:23
*** zaitcev has joined #openstack-dev16:24
*** jgallard has quit IRC16:24
clarkbclayg: ok. I ask because between 0.9 and 1.0 there were some backward incompatible changes in setuptools16:24
*** hemna has quit IRC16:25
clarkbclayg: but if 1.0 is ok then those changes are probably not at fault16:25
*** flaper87 is now known as flaper87|afk16:25
*** zaneb has joined #openstack-dev16:26
*** SergeyLukjanov has joined #openstack-dev16:26
*** flaper87|afk is now known as flaper8716:26
*** jtomasek has quit IRC16:29
*** JordanP has quit IRC16:29
claygclarkb: well... when did 1.0 come out?16:30
*** turduks has joined #openstack-dev16:30
clarkbclayg: 2013-08-1716:30
clarkbhttps://pypi.python.org/pypi/setuptools/1.016:31
*** ondergetekende_ has joined #openstack-dev16:31
*** ondergetekende_ has quit IRC16:31
*** reed has joined #openstack-dev16:32
*** adepti37 has quit IRC16:32
*** arezmerita has quit IRC16:32
*** jbresnah has joined #openstack-dev16:33
*** jtomasek has joined #openstack-dev16:34
claygit's just the xattr and python-swiftclient that have problems installing, one relationship there is that they both also have "setup_requires" directives16:34
*** xqueralt is now known as xqueralt-afk16:34
*** mestery has joined #openstack-dev16:35
*** adepti37 has joined #openstack-dev16:35
*** networkstatic has quit IRC16:35
*** herndon has joined #openstack-dev16:36
*** devoid has quit IRC16:37
*** networkstatic has joined #openstack-dev16:37
*** devoid1 has joined #openstack-dev16:37
clarkbclayg: do xattr and python-swfitclient install cleanly on their own?16:37
*** devoid1 has quit IRC16:37
*** devoid1 has joined #openstack-dev16:38
*** devoid1 has quit IRC16:38
clarkbclayg: xattr would be the more interesting one because it doesn't use our toolchain16:38
claygclarkb: hoooray!  works cleaning with 0.9.8 :)16:38
*** devoid1 has joined #openstack-dev16:38
clarkbinteresting, perhaps it is related to the incompatible changes16:38
claygclarkb: yeah they both install fine on their own (hence the pip install -r requirements.txt before setup.py develop is a workaround)16:39
clarkbdstufft: ^16:39
*** corXi has quit IRC16:39
*** devoid1 has quit IRC16:39
*** devoid1 has joined #openstack-dev16:39
dstufftwhats up?16:39
clarkbdstufft: if you could take a look at https://bugs.launchpad.net/swift/+bug/1217288 that would be awesome16:39
uvirtbotLaunchpad bug 1217288 in swift "Swift installation crashes" [High,Confirmed]16:39
clarkbdstufft: the tl;dr is swift cannot install with setuptools >= 1.016:40
*** turduks has quit IRC16:40
*** devoid1 has left #openstack-dev16:41
dstufftclarkb: looks like a setuptools bug16:42
clarkbdstufft: so this isn't pbr being aweful again? :)16:42
*** jdennis1 has joined #openstack-dev16:42
dstufftclarkb: I don't think so16:42
*** alop has quit IRC16:43
clarkbdstufft: I guess next steps may be filing an upstream bug and working around it until upstream fixes? Is there a sane way of requiring a specific version of setuptools? the distribute merger seemed to imply that we are at the hands of external forces there16:44
*** xqueralt-afk is now known as xqueralt16:44
*** radez_g0n3 is now known as radez16:44
dstufftThere's not a real good sane way to require a specific version16:44
dstufftyou could test it against a specific version by creating a venv16:45
dstufftsince venv's bundle a specific version16:45
*** shakayumi has quit IRC16:45
clarkbdstufft: I think that is why the gate isn't broken16:45
*** turduks has joined #openstack-dev16:45
*** alop has joined #openstack-dev16:46
*** ruhe has quit IRC16:48
*** turduks has quit IRC16:48
*** danwent has joined #openstack-dev16:48
*** flaper87 is now known as flaper87|afk16:49
*** romcheg has joined #openstack-dev16:50
*** ema_ has quit IRC16:50
*** romcheg has left #openstack-dev16:50
*** athomas has quit IRC16:51
*** networkstatic has quit IRC16:51
*** morganfainberg|a is now known as morganfainberg16:51
*** morganfainberg is now known as morganfainberg|a16:52
*** morganfainberg|a is now known as morganfainberg16:53
*** jecarey has quit IRC16:54
*** jecarey has joined #openstack-dev16:54
*** dina_belova has quit IRC16:54
*** dina_belova has joined #openstack-dev16:55
*** kushal has joined #openstack-dev16:57
*** lucasagomes has quit IRC16:58
*** dina_belova has quit IRC16:59
*** dachary has quit IRC16:59
*** alop_ has joined #openstack-dev17:00
*** alop has quit IRC17:00
*** alop_ is now known as alop17:00
clarkbclayg: in the launchpad bug you mention you have an idea for a setuptools patch. Will you be filing a bug upstream and potentially fixing it?17:00
*** xga has quit IRC17:01
clarkbclayg: dstufft: also is the bug in setuptools described at https://bugs.launchpad.net/swift/+bug/1217288/comments/12 ?17:01
uvirtbotLaunchpad bug 1217288 in swift "Swift installation crashes" [High,Confirmed]17:01
*** tkammer has joined #openstack-dev17:01
*** fbo is now known as fbo_away17:01
*** kushal has quit IRC17:04
*** athomas has joined #openstack-dev17:05
*** tkammer_ has joined #openstack-dev17:05
*** tkammer has quit IRC17:06
*** maheshp has quit IRC17:06
*** turduks has joined #openstack-dev17:07
*** danwent has quit IRC17:07
dstufftclarkb: tha' what it sounds like to me17:07
*** SumitNaiksatam has quit IRC17:09
*** danwent has joined #openstack-dev17:09
*** yassine_ has quit IRC17:14
claygclarkb: dstufft: yeah if either of you feels qualified to shepard my fix upstream it'd be nice for me to not have to try and muddle through it - I've already burned a whole day on that mess17:15
clarkbdstufft is definitely the person to help in that area :)17:15
clarkbclayg: probably would help to submit a bug with what you have in comment 12 on the lp bug17:15
* clayg mummbles something about hg branches17:15
*** safchain has quit IRC17:16
claygclarkb: you mean file a bug against setuptools on bitbucket?17:16
clarkbya17:16
*** Tross has quit IRC17:16
*** ydacheville has quit IRC17:16
*** ydacheville has joined #openstack-dev17:17
*** turduks has quit IRC17:18
harlowjasamalba thx for looking at the usage of undomanager :)17:18
harlowjasadly the error recovery is one of openstacks flaws right now17:19
harlowja*the general concept of error recovery17:19
*** danwent has quit IRC17:19
*** otherwiseguy has quit IRC17:22
*** freedomhui has quit IRC17:23
*** doude has quit IRC17:24
*** Tross has joined #openstack-dev17:24
*** pabelanger_ has joined #openstack-dev17:25
*** sandeepr_ltp has joined #openstack-dev17:25
*** pabelanger_ has quit IRC17:25
*** pabelanger_ has joined #openstack-dev17:25
claygclarkb: https://bitbucket.org/pypa/setuptools/issue/73/ (posted as anon, formatting all messed up - but, I tried)17:25
*** pabelanger has quit IRC17:25
samalbaharlowja: hey thanks to you17:26
*** pabelanger_ is now known as pabelanger17:26
harlowjanp17:26
samalbayou raised a good point17:26
*** pabelanger_ has joined #openstack-dev17:26
clarkbclayg: I am sure I would've done no better17:26
clarkbclayg: bitbucket and hg are not things that play nice17:26
*** HenryG has quit IRC17:27
*** nunosantos_ has quit IRC17:27
*** jruzicka has quit IRC17:27
*** nsantos has joined #openstack-dev17:27
*** nsantos is now known as nunofsantos17:27
*** nunofsantos is now known as nunosantos17:27
*** HenryG has joined #openstack-dev17:27
*** nunosantos has quit IRC17:27
*** nunosantos has joined #openstack-dev17:28
*** MaxV has joined #openstack-dev17:28
*** jtomasek has quit IRC17:28
*** pcm_ has quit IRC17:28
*** MaxV has quit IRC17:28
harlowjasamalba i put up a few responses, nothing major i think17:29
*** rackerjoe has joined #openstack-dev17:29
*** dstufft has quit IRC17:30
*** datsun180b has joined #openstack-dev17:30
*** dstufft has joined #openstack-dev17:30
*** dprince has joined #openstack-dev17:31
*** xqueralt is now known as xqueralt-afk17:32
*** pcm_ has joined #openstack-dev17:33
*** danwent has joined #openstack-dev17:33
*** Farooque has joined #openstack-dev17:33
*** amscanne has joined #openstack-dev17:33
*** jasondotstar has quit IRC17:33
*** donaldh has quit IRC17:34
*** jasdeepH has joined #openstack-dev17:34
*** SumitNaiksatam has joined #openstack-dev17:35
*** jasondotstar has joined #openstack-dev17:35
*** Farooque has left #openstack-dev17:35
*** dstufft has quit IRC17:35
*** eglynn has quit IRC17:35
*** thedodd has joined #openstack-dev17:36
*** dstufft has joined #openstack-dev17:36
*** danwent has quit IRC17:37
*** souvik has joined #openstack-dev17:38
*** dstufft has quit IRC17:38
*** hemnafk is now known as hemna17:39
*** dstufft has joined #openstack-dev17:39
*** dstufft has quit IRC17:40
*** dstufft has joined #openstack-dev17:40
*** jtomasek has joined #openstack-dev17:41
*** dstufft has quit IRC17:41
samalbaharlowja: ok17:41
*** dstufft has joined #openstack-dev17:41
*** dstanek has quit IRC17:42
*** dstufft has quit IRC17:43
*** dstufft has joined #openstack-dev17:43
*** networkstatic has joined #openstack-dev17:43
*** pabelanger has quit IRC17:44
*** pabelanger has joined #openstack-dev17:44
*** thedodd has quit IRC17:46
*** dstufft has quit IRC17:46
*** dstufft has joined #openstack-dev17:46
*** thedodd has joined #openstack-dev17:47
*** pschaef has quit IRC17:48
*** X-Scale has joined #openstack-dev17:51
*** alop has quit IRC17:52
*** SergeyLukjanov has quit IRC17:52
*** ndipanov has quit IRC17:52
*** shakayumi has joined #openstack-dev17:52
*** comay has quit IRC17:52
*** sballe has joined #openstack-dev17:52
*** SergeyLukjanov has joined #openstack-dev17:53
*** dina_belova has joined #openstack-dev17:53
*** stevemar|afk is now known as stevemar17:54
*** jasondotstar has quit IRC17:55
*** flaper87|afk is now known as flaper8717:56
*** codenamekt has quit IRC17:56
*** tstevenson has joined #openstack-dev17:56
*** egallen has quit IRC17:57
*** Ryan_Lane has joined #openstack-dev17:57
*** woodspa has joined #openstack-dev17:58
*** kevinconway has quit IRC17:59
*** rcleere_ has joined #openstack-dev17:59
*** jasondotstar has joined #openstack-dev17:59
*** insanida1e has joined #openstack-dev18:00
*** rcleere has quit IRC18:00
*** rcleere_ is now known as rcleere18:00
*** jmontemayor has quit IRC18:03
insanida1ewhat's the difference between a quantum agent and a quantum plugin ?18:03
*** dina_belova has quit IRC18:03
*** Tross has quit IRC18:03
*** dina_belova has joined #openstack-dev18:04
*** gyee has quit IRC18:04
*** alop has joined #openstack-dev18:06
*** kevinconway has joined #openstack-dev18:06
*** tkammer_ has quit IRC18:06
*** otherwiseguy has joined #openstack-dev18:07
*** jmontemayor has joined #openstack-dev18:07
*** amohn9 has joined #openstack-dev18:07
*** johnthetubaguy has quit IRC18:08
*** shakayumi has quit IRC18:08
*** dina_belova has quit IRC18:08
*** bknudson has joined #openstack-dev18:08
morganfainbergdolphm: ping18:09
*** ruhe_ has joined #openstack-dev18:10
*** mhu has quit IRC18:12
*** xqueralt-afk is now known as xqueralt18:12
*** jbresnah has quit IRC18:14
sc68calSmall openstack.org patch - noticed that there was no link to the dev doc for Nova18:14
sc68calhttps://review.openstack.org/#/c/44331/18:14
*** Ryan_Lane has quit IRC18:14
*** maheshp has joined #openstack-dev18:14
*** dstufft has quit IRC18:15
*** dstufft has joined #openstack-dev18:15
*** briancurtin has quit IRC18:16
*** X-Scale has quit IRC18:17
*** mhu has joined #openstack-dev18:18
*** Ryan_Lane has joined #openstack-dev18:18
*** insanida1e has quit IRC18:20
*** mmagr has joined #openstack-dev18:20
*** souvik has quit IRC18:22
*** aeperezt has quit IRC18:22
*** briancurtin has joined #openstack-dev18:23
*** Murali_Balcha has quit IRC18:23
*** dina_belova has joined #openstack-dev18:24
*** melwitt has joined #openstack-dev18:24
*** iambossjones has joined #openstack-dev18:24
*** dmakogon_ has joined #openstack-dev18:26
*** donaldh has joined #openstack-dev18:26
*** spzala has quit IRC18:28
*** iambossjones is now known as bossjones18:29
*** doude has joined #openstack-dev18:31
*** networkstatic has quit IRC18:32
*** X-Scale has joined #openstack-dev18:32
*** Guest76118 has quit IRC18:32
*** mhu has quit IRC18:33
insanidadeanyone alive ?18:33
*** devvesa has quit IRC18:34
*** mhu has joined #openstack-dev18:34
*** vipul is now known as vipul-away18:34
*** vipul-away is now known as vipul18:35
*** bossjones has left #openstack-dev18:35
*** sarob has joined #openstack-dev18:39
stevemari think a few people are alive18:39
*** MaxV has joined #openstack-dev18:39
morganfainbergstevemar: speak for yourself, i'm a zombie :P18:39
stevemarinsanidade^18:39
stevemarmorgan!18:39
stevemarmy favorite zombie18:39
insanidadestevemar: hey18:40
*** pabelanger has quit IRC18:40
stevemarmorganfainberg: i hear zombies like to review patches: https://review.openstack.org/#/c/43600/18:40
*** mattymo has quit IRC18:40
insanidadestevemar: what is the difference between an agent and a plugin ?18:41
*** mattymo has joined #openstack-dev18:41
insanidadefor isntance: a quantum agent and a quantum plugin.18:41
*** terryh has quit IRC18:42
*** rackerjoe has left #openstack-dev18:42
*** herndon has quit IRC18:43
*** pabelanger has joined #openstack-dev18:43
*** MaxV has quit IRC18:43
*** terryh has joined #openstack-dev18:43
*** donaldh has quit IRC18:46
*** ruhe_ has quit IRC18:46
stevemarinsanidade: no idea, but no one else was replying to you =\18:46
insanidadestevemar: yes :(18:47
insanidadestevemar: I'll keep researching.18:47
*** dstanek_ has joined #openstack-dev18:47
stevemarinsanidade: good luck!18:47
morganfainbergstevemar: yeah, i am doing reviews now.  but also meetings and stuff going on here :P18:48
stevemarmorganfainberg: excuses! jk. thanks for your suggestion btw for creating a get_consumer_with_secret18:49
morganfainbergyeah seems like a better approach18:49
morganfainbergnp!18:49
*** donaldh has joined #openstack-dev18:50
*** danwent has joined #openstack-dev18:50
dolphmmorganfainberg: moar decorators https://review.openstack.org/#/c/41970/18:51
dolphmmorganfainberg: also, pong18:51
*** danwent has quit IRC18:51
*** dina_belova has quit IRC18:51
morganfainbergdolphm: notifications? yeah was pinging you for that18:51
*** dina_belova has joined #openstack-dev18:52
dolphmmorganfainberg: yay18:52
morganfainbergdolphm: so i wanted to ask if you minded loosing the __module__ and __docstring__ information for the methods at runtime (e.g. from the methods calling the decorated methods)18:54
morganfainbergdolphm: most of our decorators don't use functools.wraps (which solves that) so it might not be terribly important18:54
*** maheshp has quit IRC18:54
morganfainbergdolphm: didn't see a need to mark up the gerrit review for something we may not be hung up on ;)18:54
dolphmmorganfainberg: i personally don't ... but i'd be happy to use functools (i just have more experience not using it, so i didn't)18:55
morganfainbergdolphm: the object setup you're using precludes it, so i think iteration on it in Icehouse ;)18:55
morganfainbergdolphm: it's not a huge deal.18:55
*** bswartz has quit IRC18:55
morganfainbergdolphm: functionality wont be changed by using functools in most cases.18:56
dolphmmorganfainberg: you can't use functools.wraps on my inner wrapper() to preserve the original docstr, etc?18:56
morganfainbergdolphm: you'd need to use it form the __init__ since __call__ needs to be updated.18:56
morganfainbergerm, self18:56
morganfainbergs/__call__/self18:56
morganfainbergand currently __init__ doesn't know the function, since f isn't passed in until __call__18:57
*** dina_belova has quit IRC18:57
morganfainberg(wow, that sounds like technobabble)18:57
dolphmmorganfainberg: ++18:57
*** jmontemayor has quit IRC18:57
morganfainbergdolphm: long and the short, time to review decorators!18:57
*** sushils has quit IRC18:58
*** novas0x2a|laptop has joined #openstack-dev18:58
*** yolanda has quit IRC18:58
*** jbresnah has joined #openstack-dev18:59
*** devoid1 has joined #openstack-dev18:59
*** maheshp has joined #openstack-dev18:59
*** maheshp1 has joined #openstack-dev18:59
*** devoid1 has left #openstack-dev18:59
dolphmmorganfainberg: since i didn't use functools.wraps, should i document that i used an abstract base class to implement concrete callable objects which accept arguments to return wrappers of functions which call the notification function based on the arguments to the wrapped function? :-/19:01
*** boris-42 has quit IRC19:03
*** jasondotstar has quit IRC19:03
*** briancurtin has quit IRC19:04
*** briancurtin has joined #openstack-dev19:04
*** sarob_ has joined #openstack-dev19:04
morganfainbergdolphm: I don't think documentation will hurt, but I don't think that is really required.  though if developing.rst doesn't make reference to the decorators for notifications19:04
morganfainbergdolphm: that should be added :)19:04
*** briancurtin has left #openstack-dev19:05
dolphmmorganfainberg: that might actually be in a different patch from the bp...19:05
*** alunduil has quit IRC19:05
morganfainbergdolphm: yeah, i haven't looked at the repo to verify that yet.19:05
dolphmmorganfainberg: this is the doc-only patch https://review.openstack.org/#/c/42205/19:06
*** jasondotstar has joined #openstack-dev19:06
morganfainbergaha19:06
morganfainbergnice19:06
morganfainbergand gyee aready hit the developing.rst front here19:06
morganfainbergthere*19:06
*** alexb_ has joined #openstack-dev19:07
*** jmontemayor has joined #openstack-dev19:07
*** sarob has quit IRC19:07
*** sarob has joined #openstack-dev19:07
*** dstanek_ is now known as dstanek19:07
*** ianw has quit IRC19:08
*** sarob_ has quit IRC19:08
*** sarob has quit IRC19:09
*** sarob has joined #openstack-dev19:09
*** ssurana has left #openstack-dev19:12
*** sarob_ has joined #openstack-dev19:12
*** sarob has quit IRC19:13
*** eglynn has joined #openstack-dev19:17
*** tmclaugh[work] has quit IRC19:18
dolphmbknudson: addressed all your comments except 'classes should be capitalized' (left an inline comment)19:19
bknudsondolphm: I'll look in a minute19:19
*** Ryan_Lane has quit IRC19:20
dolphmbknudson: i also missed your 'revert whitespace change' until just now ... i've got that ready locally pending more comments19:21
bknudsondolphm: I was wondering about that.19:22
*** athomas has quit IRC19:22
bknudsondolphm: and I have no other comments.19:22
bknudsonlooks good.19:22
morganfainbergdolphm: local module names bound to the classes is a good solution to the caps19:22
dolphmbknudson: let me post the whitespace cahnge then19:22
dolphmbknudson: ^ do you prefer that approach?19:22
morganfainbergdolphm: other than what bknudson pointed out, this looks good.19:23
*** leif has joined #openstack-dev19:23
*** leif is now known as Guest2227519:23
*** ecarlin has joined #openstack-dev19:24
morganfainbergdolphm: if anyone else points out lowercase names and you don't move to the module alias names, i'd toss a comment into the code (someone might try and "clean it up")19:25
dolphmmorganfainberg: writing that comment now!19:25
bknudsondolphm: I don't think adding a created = Created alias would be useful.19:25
dolphmmorganfainberg: bknudson: updated with Capitalized classes plus a # comment to explain wtf19:26
morganfainbergcool.19:26
*** sandeepr_ltp has quit IRC19:26
bknudsondolphm: could created/updated/deleted actually be functions and not classes?19:27
*** jecarey has quit IRC19:27
bknudsonI guess I could try it out myself.19:27
dolphmbknudson: if you can do that, i don't know how? i need the __init__ to capture the resource type in @created('user')19:28
morganfainbergbknudson: it's fairly easy to do, it's what i had henrynash do for @protected19:28
*** jecarey has joined #openstack-dev19:28
dolphmmorganfainberg: can what i did be simplified?19:28
bknudsonit's just a function that takes arguments and returns a function19:28
morganfainbergdolphm: yeah it could be made into a function19:29
*** rods1 has quit IRC19:30
morganfainbergdolphm: something like http://paste.openstack.org/show/45414/19:31
morganfainbergdolphm:  so.19:31
*** boris-42 has joined #openstack-dev19:32
*** SergeyLukjanov has quit IRC19:32
*** vipul is now known as vipul-away19:32
*** vipul-away is now known as vipul19:32
dolphmmorganfainberg: ah, okay... i've seen this before, but never thought much about it19:32
*** bswartz has joined #openstack-dev19:32
morganfainbergdolphm: now, it doesn't give you the resource id, you'd likely need to do some inspection to get that.19:34
morganfainbergdolphm: that is the biggest benefit to your implementation, self is a sideeffect.19:35
dolphmmorganfainberg: http://pasteraw.com/pal3h4xl1m6w3qx2xccrjigcha3ng5j :D19:35
morganfainbergdolphm: are these decorators only ever valid on bound methods?19:35
morganfainbergerm class/bound methods?19:36
dolphmmorganfainberg: yes19:36
morganfainbergthen no issue (though a comment would be good to that effect)19:36
dolphmmorganfainberg: ++19:36
*** egallen has joined #openstack-dev19:36
morganfainbergif you go with the function decorators you could do f.__self__.__class__.__name__.lower()19:37
morganfainberg:P19:37
morganfainbergif only bound methods,19:37
*** pabelanger has quit IRC19:37
*** alexb_ has quit IRC19:38
*** gyee has joined #openstack-dev19:39
*** alexb_ has joined #openstack-dev19:40
*** nati_ueno has joined #openstack-dev19:40
*** egallen has quit IRC19:41
*** tmclaugh[work] has joined #openstack-dev19:41
morganfainbergdolphm: http://paste.openstack.org/show/45418/ quick example more function-like19:41
*** SergeyLukjanov has joined #openstack-dev19:41
dolphmmorganfainberg: https://review.openstack.org/#/c/41970/24/keystone/notifications.py19:42
dolphmmorganfainberg: looking at rewriting as functions now...19:42
*** nati_ueno has quit IRC19:42
morganfainbergdolphm: nod.19:43
*** nati_ueno has joined #openstack-dev19:43
*** sushils has joined #openstack-dev19:43
morganfainbergdolphm: ah, mine had some copy-pasta errors :P19:43
dolphmmorganfainberg: i see :P19:44
dolphmmorganfainberg: i don't want to have 3 of these triple nested functions either..19:44
morganfainbergdolphm: fair enough19:46
morganfainbergdolphm: decorators with arguments tend to be a bit of namespace abuse :P19:46
*** vipul is now known as vipul-away19:47
morganfainbergusing the classes, like you are, isn't a bad option.19:47
*** egallen has joined #openstack-dev19:48
dolphmmorganfainberg: yeah, i'm going to be done with this for the moment... i think my brain is in a knot19:49
*** branen__ has joined #openstack-dev19:49
morganfainbergdolphm: i think making it functions isn't worth the headache, especially if you want to avoid 3x3nested functions19:49
morganfainbergme, i'm going to go get some lunch.  :)  bbib19:51
dolphmmorganfainberg: /salute19:51
*** egallen_ has joined #openstack-dev19:52
*** branen_ has quit IRC19:52
*** egallen has quit IRC19:53
*** egallen_ is now known as egallen19:53
bknudsondolphm: def created(resource_type, host=None): return BaseManagerNotificationWrapper('created', resource_type, host=host)19:53
*** prad has joined #openstack-dev19:54
bknudsondolphm: http://paste.openstack.org/show/45420/ -- the tests pass.19:55
*** briancurtin has joined #openstack-dev19:58
*** hartsocks has joined #openstack-dev19:58
*** martine_ has quit IRC19:59
*** SergeyLukjanov has quit IRC19:59
stevemarbknudson: i uploaded another patch of sql update for oauth: https://review.openstack.org/#/c/43600/19:59
*** egallen has quit IRC19:59
stevemarbknudson: you seem to be actively viewing it20:00
*** pixelbeat has quit IRC20:00
*** pcm_ has quit IRC20:00
*** fbo_away is now known as fbo20:00
dolphmbknudson: ++ i like that20:01
*** hartsocks has left #openstack-dev20:01
*** ecarlin has quit IRC20:01
dolphmbknudson: https://review.openstack.org/#/c/41970/26/keystone/notifications.py20:02
*** dina_belova has joined #openstack-dev20:02
*** egallen has joined #openstack-dev20:02
*** HenryG has quit IRC20:02
bknudsondolphm: do you want to remove Base from the class name since it's not a base class for anything?20:03
bknudsonBaseManagerNotificationWrapper20:03
dolphmbknudson: yeah, i guess that's true now20:05
*** jasdeepH has quit IRC20:06
*** mrunge has quit IRC20:07
dolphmbknudson: https://review.openstack.org/#/c/41970/27/keystone/notifications.py20:07
bknudsonstevemar: just a couple of comments to clean up the docstring. otherwise looks good to me.20:07
*** dina_belova has quit IRC20:07
stevemarbknudson: cool20:07
*** egallen has quit IRC20:07
*** ianw has joined #openstack-dev20:08
dolphmstevemar: make session the first argument, not last20:08
stevemardolphm: is that the usual? cool20:09
dolphmstevemar: all the other _get_whatever(self, session, whatever_id) follow that pattern20:09
*** boris-42 has quit IRC20:09
*** dprince has quit IRC20:11
*** doude has quit IRC20:11
*** briancurtin has quit IRC20:14
*** Guest22275 has quit IRC20:15
*** leif has joined #openstack-dev20:16
*** leif is now known as Guest467620:16
*** afazekas has quit IRC20:16
*** zodiak has quit IRC20:17
*** jbresnah has quit IRC20:18
*** doude has joined #openstack-dev20:18
stevemardolphm, bkundson: should be good20:19
bknudsondolphm: are there tests that identity create user, etc., sends notifications?20:21
*** NobodyCam_ has joined #openstack-dev20:23
*** sandywalsh has quit IRC20:23
*** NobodyCam_ has quit IRC20:23
*** doude has quit IRC20:23
*** donaldh has quit IRC20:24
*** moted has quit IRC20:24
*** jasdeepH has joined #openstack-dev20:24
*** doude has joined #openstack-dev20:25
gyeedolphm, need your opinion on this one, https://review.openstack.org/#/c/43257/24/keystone/tests/filter_pagination.py, line 420:25
*** dachary_ has joined #openstack-dev20:25
*** nati_ueno has quit IRC20:26
*** dstufft has quit IRC20:27
*** dstufft has joined #openstack-dev20:27
*** dstufft has quit IRC20:28
*** dstufft has joined #openstack-dev20:28
*** amerine has quit IRC20:28
*** maheshp1 has quit IRC20:30
ekarlso-Anyone ehre that knows what tool Horizon guys use for mockups ?20:30
dolphmbknudson: not at the moment20:31
*** romcheg has joined #openstack-dev20:32
*** vipul-away is now known as vipul20:32
dolphmgyee: replied, the copyright can stay / doesn't matter20:34
morganfainbergThe only nit is that the OpenStack LLC one should either be removed or… made to say OpenStack Foundation20:34
gyeedolphm, k, sounds good20:34
morganfainberglikley omitted20:34
morganfainbergbut in either case, Foundation is the right one:P not LLC20:35
dolphmand IBM doesn't matter20:35
morganfainbergwhat dolphm said :)20:35
*** sandywalsh has joined #openstack-dev20:35
dolphmgyee: you can add (c) Guang Yee to every file you touch if it makes you happy20:35
*** nati_ueno has joined #openstack-dev20:35
*** donaldh has joined #openstack-dev20:36
gyeedolphm, nah, don't want to leave any evident20:36
dolphmgyee: lol20:36
gyeeno evident, no crime20:36
*** vladimir3p has joined #openstack-dev20:36
morganfainberggyee: ooh, so i should start adding (c) Guang Yee to files you haven't touched? :P20:36
gyeedoh!20:36
*** dmakogon_ has quit IRC20:37
fabiomorganfainberg: maybe I will start to do that :-)20:37
morganfainbergfabio: i know we can count on you!20:37
dolphmgyee: i personally think they're super obnoxious as they pretty much just serve as advertising to other developers20:39
gyeedolphm, I only do that in my resume20:39
morganfainbergdolphm: except that it's my company's policy to add one (I said we shouldn't bother), I would just omit them at this point.20:40
dolphmgyee: plaster copyright notices everywhere?20:40
dolphmmorganfainberg: "Come work at Company X because we touch a lot of files!"20:40
gyeehaha20:40
morganfainbergdolphm: hehe20:40
dolphmgreat? ... as i have to scoll past the growing list of copyrights to get to work ...20:40
gyeedolphm not sure about you but I have fond memories with everything I touched :)20:41
bknudsondolphm: another suggestion for notifications wrappers: http://paste.openstack.org/show/45422/20:41
*** sarob has joined #openstack-dev20:41
bknudsonavoids duplicating the 'user' string when decorating the different methods.20:41
bknudsonnot totally tested.20:42
*** doude has quit IRC20:43
*** sarob has quit IRC20:43
*** sarob__ has joined #openstack-dev20:43
*** vladimir3p has quit IRC20:43
*** doude has joined #openstack-dev20:44
*** romcheg has quit IRC20:44
*** sarob_ has quit IRC20:45
*** martyntaylor has quit IRC20:47
*** tmclaugh[work] has quit IRC20:47
dolphmbknudson: that's a lot of not totally tested code to move a string argument 'user' to an object attribute .user.20:47
portantedmllr?20:48
*** eglynn has quit IRC20:48
morganfainbergbknudson: i think that might make it harder to read.  not saying it isn't an optimization to avoid some duplication20:48
dolphmbknudson: you could try and parse the wrapped function name to try and get them both for free? (operation, resource_type) = f.__name__.split('_', 1)20:49
*** alexpilotti has quit IRC20:49
dolphmbknudson: leaning towards magical though20:49
morganfainbergdolphm: I'm going to say I prefer a bit easier to read in this case, and both bknudson and the f.__name__.split is going to be a bit harder to read overall20:50
dolphmbknudson: particularly dangerous because it's producing an API behind the scenes that other projects will end consuming20:50
dolphmmorganfainberg: ++20:50
morganfainbergerm s/bknudson/bknudson's suggestion/20:50
insanidadehey, guys. quick question on the way things are developed in the openstack ecosystem: what happens to devstack when something is commited in the main openstack development branch? is it introduced in the latest devstack available for download ? How do I update my current devstack environmetn with that new code ?20:50
bknudsondolphm: morganfainberg: ok, it was an experiment to see if the repeated string could be not repeated20:50
morganfainbergbknudson: fun expiriment though :)20:51
bknudsonsince it's only repeated 3 times, not a big deal.20:51
bknudsonand it's generally a short string.20:51
dolphminsanidade: yes, devstack works with master branches by default20:52
insanidadedolphm: and how do update it? rerun stack.sh ?20:52
*** briancurtin has joined #openstack-dev20:54
*** dachary_ is now known as dachary20:54
dolphminsanidade: i think that should work... i honestly never work with a single devstack install long enough need updates from other projects20:54
morganfainberginsanidade: i believe devstack wont download/update code if the code is already cloned locally, you could either git pull in the specific clone, or delete the clone from /opt/stack, which case devstack will redownload.20:55
dolphminsanidade: you can also git pull the individual repos, and restart each service, etc20:55
*** ydacheville has quit IRC20:56
*** ydacheville_ has joined #openstack-dev20:56
insanidadedolphm, morganfainberg : hmm, ok. I'm setting up a dev environment for me. I'm trying to define how I'm going to work on code, update my local code, that sort of thing.20:56
insanidadedolphm , morganfainberg : the simple git way of updating your code, right ?20:57
insanidadethanks for the info.20:57
*** alunduil has joined #openstack-dev20:57
*** mhu has quit IRC20:57
*** briancurtin has left #openstack-dev20:57
dolphmis there a good 'typical developer workflow with devstack' article somewhere?20:58
*** johnthetubaguy has joined #openstack-dev20:58
clarkbanteaya: ^20:58
insanidadedolphm: not that I'm aware of.20:58
dolphmi found some slides...20:59
morganfainbergdolphm / insanidade: i think most people teardown/restack from scratch each time.20:59
*** mhu has joined #openstack-dev20:59
morganfainbergdolphm / insanidade: thats what i was doing w/ vagrant until my box files got a little out of date (need to dedicate some time to fix that)20:59
anteayadolphm: I have been working on bits and pieces towards a working with devstack post/article/page but right now it is kind of in bits21:00
*** sarob__ has quit IRC21:01
insanidademorganfainberg , dolphm : looks like my set up. vagrant + virtualbox (centos)21:01
dolphmanteaya: i'd love to have something to point people to, if it existed21:01
*** sarob has joined #openstack-dev21:01
anteayadolphm: here are my rough notes for standing up a devstack using vagrant: https://gist.github.com/anteaya/dedca991f761c48bb26221:01
anteayayou are right, time for a blog post or something on the topic, let me cobble something together that is more polished21:02
*** amohn9 has quit IRC21:02
anteayamight be a day or so before I have a url I can share21:02
*** eglynn has joined #openstack-dev21:02
morganfainberganteaya: that would be awesome!21:02
dolphmanteaya: this isn't bad, but it's a little heavy on the 'steps' and light on the explanation / overview http://docs.openstack.org/folsom/openstack-ops/content/customize.html21:02
anteayamorganfainberg: thanks, okay what kinds of details, questions do you want to see answered21:02
anteayadolphm: yes21:03
*** dina_belova has joined #openstack-dev21:03
anteayamostly my notes I use when I do it myself21:03
anteayait needs some expansion21:03
dolphmmorganfainberg: awaiting your gracious downvote https://review.openstack.org/#/c/41970/21:04
*** Guest4676 has quit IRC21:04
morganfainbergdolphm: lol, probably not going to get one today.  probably an upboat^Hupvote :P21:04
*** leif has joined #openstack-dev21:04
*** jmontemayor_ has joined #openstack-dev21:05
*** leif is now known as Guest2976721:05
dolphmmorganfainberg: i should do a keystoneclient release based on your hacking fixes21:05
morganfainbergdolphm: i'm going to have to see if i can wedge the update_wrapper stuff into this stype of decorator21:05
*** sarob has quit IRC21:05
dolphmmorganfainberg: Release Notes: THE CODE IS MUCH MORE SHINY WE SWEAR21:05
morganfainbergdolphm: in the future.21:05
morganfainbergdolphm: LOL.21:05
morganfainberg0.3.2.0.0.0.0.1 ?21:06
*** stevemar has quit IRC21:06
dolphmlol21:06
dolphmmorganfainberg: approved the first two... third needs a rebase21:07
*** boden has quit IRC21:07
morganfainbergdolphm: ah not surprised.21:07
*** mhu has quit IRC21:07
morganfainbergdolphm: funny, this notification code, i feel like i've reviewed it already :P21:07
*** nati_ueno has quit IRC21:07
*** dina_belova has quit IRC21:08
*** rfolco has quit IRC21:08
*** jmontemayor has quit IRC21:08
*** nati_ueno has joined #openstack-dev21:09
dstanekanteaya: dolphm: i just a shell script to bootstrap devstack on Rackspace - with small mods it could work for vagrant too21:09
dstanekhttps://gist.github.com/dstanek/638343621:09
*** dvarga has quit IRC21:10
*** mhu has joined #openstack-dev21:10
anteayadstanek: yes, the problem is that for newbies if the shell script doesn't give them an installation you spend the blog post trouble shooting the shell script rather than explaining the steps21:10
anteayafor new people, I err on the side of manual steps with explanation so they learn, so they understand, whether they use a script or recipe or not down the road21:11
anteayaand thanks for the link21:11
*** jamielennox|away is now known as jamielennox21:13
*** nati_ueno has quit IRC21:15
*** sarob has joined #openstack-dev21:15
*** sarob has quit IRC21:16
*** sarob has joined #openstack-dev21:16
*** Ryan_Lane has joined #openstack-dev21:16
dolphmgyee: henrynash: bknudson: this is rather simple, just for tests, and a blocker for the bp goal https://review.openstack.org/#/c/44211/21:20
*** jasondotstar has quit IRC21:20
morganfainbergyeah i split that out from the other one so it was easier to see and to fix both patchset's tests21:21
*** dachary has quit IRC21:22
*** doude has quit IRC21:22
bknudsonmorganfainberg: on https://review.openstack.org/#/c/44211/ -- is CacheIsolatingProxy only useful for testing?21:23
gyeedolphm, looking21:23
morganfainbergbknudson: if you're using the memory backend, for any reason21:23
bknudsonif so it should be in keystone.tests and not keystone.common21:23
morganfainbergit's useful21:23
morganfainbergnot that i recommend it.21:23
morganfainbergi could move it to tests if you think it's more appropriate21:24
morganfainberg(no big deal)21:24
bknudsonI don't want someone to think they should use it if it's not recommended.21:24
morganfainbergactually.  i am going to argue that it should probably be in core until i get a fix upstream to dogpile.cache21:24
morganfainbergif we want tempest or anything else to use the memory cache for testing21:25
dolphmmorganfainberg: i wonder if they avoid that in dogpile for performance?21:25
morganfainberghaving it in tests is sub-optimal21:25
dolphmmorganfainberg: would be an expensive default implementation21:25
morganfainbergdolphm: memory backend is really not meant for production use,21:25
morganfainbergdolphm: and since everything is a reference, if you don't copy the data structure, you end up with mutable cache21:26
dolphmmorganfainberg: not even for super light duty caching needs?21:26
morganfainbergdolphm: nope.  the _cache dict never is cleaned up21:26
*** xmltok has joined #openstack-dev21:26
morganfainbergdolphm: so unless you explicitly invalidate, invalid data builds up in there.21:26
morganfainbergeven if it's expired.21:26
gyeeouch21:26
morganfainbergyeah, thats why there is a massive warning everywhere in code and in docs against using the memory cacher by default, heck, it's why i made the no-op one that is configured as our default.  you have to go out of your way to shoot yourself in the foot in a real deployment21:27
bknudsonmorganfainberg: https://review.openstack.org/#/c/44211/ -- posted my comments... suggest reduce duplicated code.21:28
morganfainbergbknudson: cool! I'll get on it21:28
morganfainbergbknudson: thanks :)21:28
*** dachary has joined #openstack-dev21:29
morganfainbergdolphm / bknudson / gyee: so should the isolation proxy move to tests and we work w/ infra / devstack / whatever to use memcache when testing in tempest (eventually)?21:29
morganfainbergor leave as is?21:29
bknudsonmorganfainberg: I would prefer it's in tests if you don't recommend using it.21:29
morganfainbergbknudson:  done.21:29
gyeemorganfainberg, I am a big fan of testing reality21:29
gyeeso yeah21:29
bknudsonor maybe at least add a comment saying it's not recommended.21:29
dolphmmorganfainberg: happy to have it in tests, that would avoid the same complaints we've gotten about kvs drivers21:30
*** alexb_ has quit IRC21:31
morganfainbergbknudson: http://docs-draft.openstack.org/11/44211/1/check/gate-keystone-docs/4ec030d/doc/build/html/configuration.html#caching-layer21:31
morganfainbergbknudson: i'll add another warning aorund the proxy as well.21:32
*** johnthetubaguy has quit IRC21:32
*** xqueralt is now known as xqueralt-afk21:35
*** jasdeepH has quit IRC21:35
*** doude has joined #openstack-dev21:35
*** dkranz has quit IRC21:35
*** topol_ has joined #openstack-dev21:36
*** topol has quit IRC21:36
*** topol_ is now known as topol21:36
*** jimfehlig has quit IRC21:37
dstanekhmmm...is there a Keystone test that uses multiple domain backends already?21:38
dolphmdstanek: believe so...21:40
dolphmhenrynash: ^21:40
dolphmdstanek: keystone.domain1.conf and keystone.domain2.conf in test dir..21:41
*** litong has quit IRC21:41
*** kspear has quit IRC21:42
*** amerine has joined #openstack-dev21:43
*** mhu has quit IRC21:45
*** mhu has joined #openstack-dev21:45
dstanekdolphm: thanks21:47
*** datsun180b has quit IRC21:50
dolphmhenrynash: dstanek: looks like only ldap+ldap is tested?21:50
*** flaper87 is now known as flaper87|afk21:51
*** kspear has joined #openstack-dev21:55
*** henrynash has quit IRC21:56
*** networkstatic has joined #openstack-dev21:57
*** jtomasek has quit IRC21:57
*** jasdeepH has joined #openstack-dev21:58
*** jmontemayor_ has quit IRC22:00
*** ydacheville_ has quit IRC22:02
*** dstanek has quit IRC22:02
*** alop_ has joined #openstack-dev22:03
*** jvrbanac has quit IRC22:03
*** dina_belova has joined #openstack-dev22:03
*** mhu has quit IRC22:03
*** mhu has joined #openstack-dev22:05
*** alop has quit IRC22:05
*** alop_ is now known as alop22:05
*** dina_belova has quit IRC22:08
*** Ryan_Lane has quit IRC22:08
*** alexb_ has joined #openstack-dev22:10
*** tstevenson has quit IRC22:10
*** donaldh has quit IRC22:11
*** burt has quit IRC22:11
*** alop has quit IRC22:12
*** kbringard has quit IRC22:12
*** otherwiseguy has quit IRC22:14
*** alop has joined #openstack-dev22:14
*** Murali_Balcha has joined #openstack-dev22:14
*** mmagr has quit IRC22:15
*** prad has quit IRC22:17
*** jecarey has quit IRC22:17
*** portante is now known as portante|afk22:20
*** jhesketh has joined #openstack-dev22:21
*** jasdeepH has quit IRC22:21
*** rods1 has joined #openstack-dev22:21
*** jhesketh__ has quit IRC22:22
*** galstrom is now known as galstrom_zzz22:23
*** adalbas has quit IRC22:24
*** jmontemayor has joined #openstack-dev22:25
*** insanidade has quit IRC22:25
*** fbo is now known as fbo_away22:25
*** changbl has quit IRC22:26
*** leif has joined #openstack-dev22:28
*** leif is now known as Guest3067722:28
*** henrynash has joined #openstack-dev22:29
henrynashdophm: I thought I had a test that had ldap & sql…hold on22:29
*** nachi has joined #openstack-dev22:30
*** eglynn has quit IRC22:31
*** Guest29767 has quit IRC22:32
henrynashdolphm: yes, MultiLDAPandSQLIdentity in test_baclend_ldap has both sql and ldap domains22:32
*** rnirmal has quit IRC22:33
*** litong has joined #openstack-dev22:33
henrynashdstanek: ^22:34
morganfainbergbknudson: https://review.openstack.org/#/c/44211/ cleaned up and duplicated code reduced.  (when you have a moment)22:36
*** adalbas has joined #openstack-dev22:36
gyeemorganfainberg, I like the description22:36
*** kbrierly has quit IRC22:37
morganfainberggyee:  hehe, i tried to be descriptive22:37
*** alop has quit IRC22:40
morganfainberggyee: hopefully that gets the point across, and people don't try and use it.22:40
*** rcleere has quit IRC22:40
*** edmund has quit IRC22:41
*** thedodd has quit IRC22:41
gyeemorganfainberg, yeah, unless you can animate the warning in the rst file :)22:42
morganfainberggyee hmm, animated rst, we need this!22:42
*** FunnyLookinHat has quit IRC22:43
*** topol has quit IRC22:43
*** jbresnah has joined #openstack-dev22:44
*** gmurphy has joined #openstack-dev22:44
*** neelashah has quit IRC22:47
*** dstanek_ has joined #openstack-dev22:48
*** radsy has joined #openstack-dev22:50
*** pabelanger_ has quit IRC22:53
*** pabelanger has joined #openstack-dev22:53
*** gordc has quit IRC22:54
*** nati_ueno has joined #openstack-dev22:55
*** jdennis1 has quit IRC22:57
*** Ryan_Lane has joined #openstack-dev22:57
*** jmontemayor has quit IRC23:00
*** mlavalle has quit IRC23:01
*** dstanek_ is now known as dstanek23:01
*** Tross has joined #openstack-dev23:03
*** pmathews1 has quit IRC23:03
*** jhesketh has quit IRC23:03
*** dina_belova has joined #openstack-dev23:04
nachimorganfainberg:hey23:05
dolphmmorganfainberg: all 4 of those methods should be one liners now ;)23:08
*** henrynash_ has joined #openstack-dev23:09
*** dina_belova has quit IRC23:09
*** henrynash has quit IRC23:10
*** henrynash_ is now known as henrynash23:10
*** hemna is now known as hemnafk23:12
*** sarob has quit IRC23:14
*** sarob has joined #openstack-dev23:14
*** sarob has quit IRC23:18
*** nati_ueno has quit IRC23:19
*** dims has quit IRC23:19
*** carl_baldwin has quit IRC23:20
morganfainbergdolphm: all four what?23:23
morganfainbergnachi: hi23:23
morganfainbergdolphm: oh the cache methods on the proxy :P23:24
nachimorganfainberg: I had a question on one of your review comments. I replied on the review. https://review.openstack.org/#/c/40036/10/keystone/auth/plugins/signature.py23:24
nachisorry incorrect file23:24
morganfainbergdolphm: crud, you're right.23:24
morganfainbergdolphm: *facepalm* I should have seen that.23:25
nachimorganfainberg:https://review.openstack.org/#/c/40036/10/keystone/auth/utils.py23:25
*** Dr_Who has joined #openstack-dev23:25
*** Dr_Who has joined #openstack-dev23:25
morganfainbergnachi: well, ideally you shouldn't instantiate a new manager on every call23:26
morganfainbergnachi: the @dependency.requires takes care of providing the right manager on your local object.  so you can do self.token_api.<method> for example23:27
morganfainbergnachi: the way you'23:27
morganfainbergre structured now, every time you need to get the identity_api, you instantiate a manager.23:27
*** jhesketh_ has joined #openstack-dev23:27
morganfainbergnachi: you might be able to do this as a class and all @classmethod s23:28
nachiok.23:28
dolphmnachi: why does this start at patchset 5? where's 1-4?23:29
nachidolphm: i had in draft review23:29
*** otherwiseguy has joined #openstack-dev23:29
dolphmnachi: oh, interesting23:29
morganfainbergnachi: i just think you should avoid the overhead of instantiating the manager every time you do use these functions.  from what i've seen this would be a lot of new manager objects since the plugins use it.23:29
morganfainbergdolphm: draft reviews are strange :P  WIP is more friendly.23:30
morganfainbergdrafts are hiddent from anyone that isn't an explicit reviewer.23:30
dolphmmorganfainberg: ++23:30
*** huats has quit IRC23:30
morganfainbergs/plugins/auth plugins23:30
dolphmmorganfainberg: did some identity_api -> assignment_api refactoring for project crud methods, and applied @notifications to the result https://review.openstack.org/#/c/43340/23:31
nachimorganfainberg: i will update the review23:31
*** dims has joined #openstack-dev23:32
morganfainbergdolphm: ah yah some of that needed cleanup.23:33
morganfainbergdolphm: nice.23:33
dolphmmorganfainberg: a fraction of it23:33
morganfainbergdolphm: not adding to domains while you're in there?23:33
*** jamiem has quit IRC23:34
morganfainbergor going to have ldbragst do that23:34
*** nachi has left #openstack-dev23:34
*** sushils has quit IRC23:34
morganfainbergnotifier on domains that is.23:34
*** huats has joined #openstack-dev23:34
*** huats has joined #openstack-dev23:34
*** jamiem has joined #openstack-dev23:35
dstanekdolphm: there is a test class in test_backend.py that isn't picked up by tox because of the class name :-(23:37
dstanekerrrr....or maybe i'm reading it wrong23:37
morganfainbergdolphm: changes look good in that review.  that should be a win to get notifications that projects have gone bye-bye.23:38
*** ydacheville has joined #openstack-dev23:39
* rootard is trying really hard to find documentation about ceph+kvm interaction. AFAICT my instance is being trying to connect to ceph but has auth_supported=none when it should be auth_supported=cephx. No matter what I set in the virsh secret list, it seems to always use auth_supported=none. Any tips?23:42
dolphmmorganfainberg: yay!23:42
dolphmmorganfainberg: this will kill our last 6-digit bug :D23:42
morganfainbergdolphm: w00t!23:42
dolphmmorganfainberg: that's a complete lie *23:43
dolphmmorganfainberg: this will kill our last high priority 6-digit bug :D23:43
morganfainbergdolphm: hehe23:43
morganfainbergdolphm: still cause for celebration23:44
*** sarob has joined #openstack-dev23:45
*** jasdeepH has joined #openstack-dev23:47
*** jayg is now known as jayg|g0n323:47
*** sarob_ has joined #openstack-dev23:48
*** jamiem has quit IRC23:48
*** jbresnah has quit IRC23:49
*** jhesketh_ has quit IRC23:51
*** Dr_Who has quit IRC23:52
*** jhesketh_ has joined #openstack-dev23:52
dolphmgyee: bknudson: can we knock out another bp today? :D https://review.openstack.org/#/c/43340/23:52
dolphmhenrynash: ^23:52
*** sarob has quit IRC23:52
*** pixelbeat has joined #openstack-dev23:52
morganfainbergdolphm: i don't think there is much controversial about that one.  (was much easier to review)23:54
henrynashdolphm: will look in 15 mins or so…just getting rear to post another filtering patch, with changes in response to latest comments23:55
morganfainbergdolphm: kinda nice to have the gate less swamped than i'm sure next week is going to look.23:55
roaetIs it normal to put the bug fix # in the code as a comment or just leave it to the commit?23:55
*** markwash has quit IRC23:55
dolphmmorganfainberg: i think it's been swamped mostly because of transient failures + reverify :(23:56
morganfainbergdolphm: yeah, those have been rough.23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!