| *** gmurphy has joined #openstack-dev | 00:03 | |
| *** martine has joined #openstack-dev | 00:13 | |
| *** martine is now known as Guest62489 | 00:13 | |
| *** salv-orlando has quit IRC | 00:16 | |
| *** alexpilotti has quit IRC | 00:21 | |
| *** michchap has joined #openstack-dev | 00:24 | |
| *** changbl has joined #openstack-dev | 00:25 | |
| *** sdake_ has joined #openstack-dev | 00:28 | |
| *** michchap has quit IRC | 00:41 | |
| *** michchap has joined #openstack-dev | 00:41 | |
| *** sdake_ has quit IRC | 00:48 | |
| *** dina_belova has joined #openstack-dev | 00:49 | |
| *** dims has joined #openstack-dev | 00:53 | |
| *** dina_belova has quit IRC | 00:54 | |
| *** Farooque has joined #openstack-dev | 00:58 | |
| *** briancurtin has quit IRC | 01:00 | |
| *** maheshp has joined #openstack-dev | 01:02 | |
| *** Farooque has quit IRC | 01:02 | |
| *** Farooque has joined #openstack-dev | 01:03 | |
| *** freedomhui has joined #openstack-dev | 01:04 | |
| *** Farooque has quit IRC | 01:04 | |
| *** Farooque has joined #openstack-dev | 01:05 | |
| *** Farooque has quit IRC | 01:05 | |
| *** maheshp has quit IRC | 01:06 | |
| *** Guest62489 has quit IRC | 01:10 | |
| *** michchap_ has joined #openstack-dev | 01:11 | |
| *** jamiem has quit IRC | 01:12 | |
| *** jamiem has joined #openstack-dev | 01:14 | |
| *** michchap has quit IRC | 01:14 | |
| *** alexb_ has joined #openstack-dev | 01:16 | |
| *** martine has joined #openstack-dev | 01:26 | |
| *** martine is now known as Guest57248 | 01:26 | |
| *** erkules_ has joined #openstack-dev | 01:27 | |
| *** erkules has quit IRC | 01:29 | |
| *** shang has joined #openstack-dev | 01:30 | |
| *** Prince_Africanus has joined #openstack-dev | 01:33 | |
| *** yaguang has joined #openstack-dev | 01:36 | |
| *** stevemar has joined #openstack-dev | 01:39 | |
| *** Prince_Africanus has quit IRC | 01:41 | |
| *** dkehn has quit IRC | 01:46 | |
| *** dina_belova has joined #openstack-dev | 01:50 | |
| *** dina_belova has quit IRC | 01:55 | |
| *** dkehn has joined #openstack-dev | 01:57 | |
| *** d34dh0r53 has joined #openstack-dev | 01:59 | |
| *** utlemming has quit IRC | 01:59 | |
| *** freedomhui has quit IRC | 02:02 | |
| *** d34dh0r53 has quit IRC | 02:03 | |
| *** d34dh0r53 has joined #openstack-dev | 02:03 | |
| *** maheshp has joined #openstack-dev | 02:06 | |
| *** ljjjustin has joined #openstack-dev | 02:08 | |
| *** briancurtin has joined #openstack-dev | 02:08 | |
| *** maheshp has quit IRC | 02:11 | |
| *** stevemar has quit IRC | 02:16 | |
| *** stevemar has joined #openstack-dev | 02:17 | |
| *** sdake_ has joined #openstack-dev | 02:19 | |
| *** sdake_ has quit IRC | 02:19 | |
| *** sdake_ has joined #openstack-dev | 02:19 | |
| morganfainberg | stevemar: ping | 02:20 |
|---|---|---|
| stevemar | morganfainberg: ahoy | 02:20 |
| morganfainberg | got a question for you... | 02:20 |
| stevemar | shoot | 02:21 |
| morganfainberg | stevemar: making sure i have the info, one sec. | 02:22 |
| stevemar | morganfainberg: cool | 02:23 |
| morganfainberg | stevemar: https://review.openstack.org/#/c/43182, looks good, but… there is an edge case where a bad token dataset would raise an exception. | 02:25 |
| morganfainberg | stevemar: it likely should get the same treatment as SQL. but… kvs… so a restart solves the issue :P | 02:26 |
| *** erfanian has quit IRC | 02:26 | |
| morganfainberg | stevemar: in the kvs driver that is | 02:26 |
| morganfainberg | stevemar: sorry, first sentence missed that :P | 02:26 |
| morganfainberg | stevemar: it's not a huge deal, but. i figured you'd want to know. | 02:27 |
| morganfainberg | stevemar: it would occur because NoneType has no .get method, and you use .get to grab token out of token_data and then oauth = token.get … you see | 02:27 |
| stevemar | ahhhh | 02:28 |
| morganfainberg | stevemar: this is slightly out of scope for the bug, likely it should be fixed. but it could be addressed in a separate patchset. | 02:29 |
| stevemar | nah, i could fix it here too | 02:29 |
| morganfainberg | stevemar: thats why i said something here. it was slightly out of scope, so, i didn't see a need to bounce it. | 02:29 |
| morganfainberg | doing my sunday evening code reviews. :P trying to get the easy ones out of the way first. | 02:30 |
| stevemar | morganfainberg: alirght, i'll take a peek at it later | 02:31 |
| stevemar | see how i can proof it | 02:31 |
| morganfainberg | probably just use the same(ish) logic as you've decided on in the sql driver | 02:31 |
| morganfainberg | stevemar: also shameless plug for reviewing the other caching patchsets :P | 02:32 |
| morganfainberg | stevemar: when you get a chance of course. | 02:32 |
| stevemar | morganfainberg: no worry, they are 'starred' :) | 02:33 |
| morganfainberg | heh | 02:33 |
| morganfainberg | stevemar: i keep forgetting "starring" exists in gerrit until i look at the list and go "why did i star that" | 02:34 |
| * stevemar chuckles | 02:36 | |
| stevemar | morganfainberg: i'll review some stuff tonight, too tired to submit any fixes | 02:37 |
| morganfainberg | stevemar: yeah no rush on reviewing or submitting fixes. you were here, figured i'd poke at ya | 02:37 |
| stevemar | morganfainberg: pretty sure i know the answer, but after 28th (code freeze), it's just bug fixing right? | 02:38 |
| stevemar | morganfainberg: rgr that | 02:38 |
| morganfainberg | stevemar: welllll i'm in denial :P | 02:38 |
| stevemar | haha | 02:38 |
| stevemar | your stuff will go in | 02:38 |
| morganfainberg | i think there is one more patchset to build, but i need to hit up henrynash about it. identity needs some caching, but i need to be careful to not stomp on his filtering code. | 02:39 |
| *** rcleere has joined #openstack-dev | 02:40 | |
| stevemar | morganfainberg: but otherwise, it's just bug fixin' time! | 02:42 |
| stevemar | and no major BPs/features are supposed to go in? | 02:42 |
| morganfainberg | stevemar: i believe so. | 02:42 |
| stevemar | nothing that touches too much i guess? | 02:42 |
| morganfainberg | stevemar: there are a lot of bugs that need to be looked at. also, i'm fair certain that a good deal of the pending reviews will need to be rebased and pushed in once the BP additions are closed out (avoiding the massive rebase headache for the BPs at the last minute is good) | 02:43 |
| *** kushal has joined #openstack-dev | 02:44 | |
| stevemar | yeah, we can hold off on approving bugs, lets the BPs go in | 02:44 |
| morganfainberg | yep | 02:45 |
| stevemar | so wen dont clog up jenkins... i guess | 02:45 |
| morganfainberg | stevemar: well, less worried about that :P | 02:45 |
| stevemar | morganfainberg: can't fill up those internet tubes, ya know | 02:45 |
| morganfainberg | stevemar: ok, i think it's time for me to poke fabio's endpoint change. see if it looks good (don't think anything is missing at this point…but you know) | 02:46 |
| stevemar | morganfainberg: i'm looking at that one too, do you know if there is impl for store quota data? | 02:46 |
| stevemar | fabio is so close | 02:47 |
| morganfainberg | no impl on the store quota data, i think they were waiting on API approval | 02:47 |
| morganfainberg | i need to circle back on that api one. | 02:47 |
| stevemar | yeah, got an email from the dude on the weekend, asking to take another look | 02:48 |
| morganfainberg | I don't think use of the quota store in H is going to happen (even if impl gets in), if it hits early I, i think it'll be fine. | 02:48 |
| morganfainberg | but the api spec should get in soon (hopefully) | 02:48 |
| *** luis_ has quit IRC | 02:50 | |
| *** luisg has joined #openstack-dev | 02:50 | |
| morganfainberg | also, once my caching stuff gets in, i think i'm going to need to work w/ infra to get it into the tempest tests (how the devstacks get built) | 02:50 |
| *** dina_belova has joined #openstack-dev | 02:51 | |
| *** Mandell has joined #openstack-dev | 02:51 | |
| stevemar | morganfainberg: why do you want it in infra? | 02:53 |
| morganfainberg | i think they determine how devstacks for tempest are built. | 02:53 |
| morganfainberg | meaning, keystone config, etc. | 02:53 |
| morganfainberg | the vms that is. | 02:53 |
| morganfainberg | i'd like the caching to be used for running tempest tests eventually. | 02:54 |
| morganfainberg | stevemar: sorry if i wasn't clear :P | 02:54 |
| stevemar | morganfainberg: we took the scenic route, but we got there | 02:54 |
| morganfainberg | stevemar: yeah. | 02:55 |
| stevemar | :P | 02:55 |
| *** dina_belova has quit IRC | 02:55 | |
| stevemar | morganfainberg: shouldn't be that bad, just make some changes to keystone.conf no? | 02:55 |
| morganfainberg | stevemar: likely, might make sense to do cool stuff, like use memcached with it | 02:56 |
| stevemar | morganfainberg: heading home now, ttyl | 02:59 |
| morganfainberg | stevemar: have a good one. | 02:59 |
| *** Guest57248 has quit IRC | 03:01 | |
| *** martine has joined #openstack-dev | 03:01 | |
| *** martine is now known as Guest88403 | 03:02 | |
| *** stevemar has quit IRC | 03:03 | |
| *** xchu has joined #openstack-dev | 03:04 | |
| *** dims has quit IRC | 03:05 | |
| *** alexb_ has quit IRC | 03:16 | |
| *** SergeyLukjanov has joined #openstack-dev | 03:19 | |
| *** aloga has quit IRC | 03:19 | |
| *** kashyap is now known as reacher | 03:19 | |
| *** pixelbeat has quit IRC | 03:20 | |
| *** alexxu has joined #openstack-dev | 03:35 | |
| *** shang_ has joined #openstack-dev | 03:39 | |
| *** shang has quit IRC | 03:39 | |
| *** shang_ is now known as shang | 03:39 | |
| *** macjack has joined #openstack-dev | 03:40 | |
| *** markmcclain has quit IRC | 03:43 | |
| *** stevemar has joined #openstack-dev | 03:49 | |
| *** alexb_ has joined #openstack-dev | 03:51 | |
| *** dina_belova has joined #openstack-dev | 03:51 | |
| *** reacher is now known as kashyap | 03:52 | |
| *** dina_belova has quit IRC | 03:55 | |
| *** jimjiang has joined #openstack-dev | 03:59 | |
| *** jimjiang_ has joined #openstack-dev | 04:04 | |
| *** alexb_ has quit IRC | 04:06 | |
| *** afazekas has joined #openstack-dev | 04:10 | |
| *** prekarat has joined #openstack-dev | 04:14 | |
| *** dguitarbite has joined #openstack-dev | 04:18 | |
| *** utlemming has joined #openstack-dev | 04:24 | |
| *** alexb_ has joined #openstack-dev | 04:29 | |
| *** lexinator has quit IRC | 04:31 | |
| *** Guest88403 has quit IRC | 04:37 | |
| *** dina_belova has joined #openstack-dev | 04:52 | |
| *** dina_belova has quit IRC | 04:57 | |
| *** alexxu has quit IRC | 05:02 | |
| *** alexb_ has quit IRC | 05:06 | |
| *** chandankumar has joined #openstack-dev | 05:06 | |
| *** SergeyLukjanov has quit IRC | 05:13 | |
| *** henrynash has joined #openstack-dev | 05:18 | |
| *** alexxu has joined #openstack-dev | 05:20 | |
| *** gongysh has joined #openstack-dev | 05:24 | |
| *** mrunge has joined #openstack-dev | 05:32 | |
| *** briancurtin has quit IRC | 05:32 | |
| *** afazekas_ has joined #openstack-dev | 05:34 | |
| *** lexinator has joined #openstack-dev | 05:35 | |
| *** shang_ has joined #openstack-dev | 05:35 | |
| *** gongysh has quit IRC | 05:36 | |
| *** shang has quit IRC | 05:37 | |
| *** lexinator has quit IRC | 05:39 | |
| *** aeperezt has quit IRC | 05:42 | |
| *** zodiak has quit IRC | 05:44 | |
| *** radsy has quit IRC | 05:44 | |
| *** afazekas has quit IRC | 05:47 | |
| *** alexxu has quit IRC | 05:47 | |
| *** sdake_ has quit IRC | 05:51 | |
| *** dina_belova has joined #openstack-dev | 05:52 | |
| *** networkstatic has quit IRC | 05:52 | |
| *** afazekas_ has quit IRC | 05:55 | |
| *** erkules_ is now known as erkules | 05:56 | |
| *** dina_belova has quit IRC | 05:57 | |
| *** alexxu has joined #openstack-dev | 06:00 | |
| *** xchu has quit IRC | 06:02 | |
| *** jimjiang has quit IRC | 06:02 | |
| *** jimjiang_ has quit IRC | 06:02 | |
| *** jimjiang has joined #openstack-dev | 06:02 | |
| *** terriyu has quit IRC | 06:02 | |
| *** zyluo has joined #openstack-dev | 06:03 | |
| *** mikal has quit IRC | 06:11 | |
| *** mikal has joined #openstack-dev | 06:13 | |
| *** jfriedly has quit IRC | 06:13 | |
| *** freedomhui has joined #openstack-dev | 06:15 | |
| *** sumanthns has joined #openstack-dev | 06:17 | |
| *** xchu has joined #openstack-dev | 06:18 | |
| *** doron_afk has joined #openstack-dev | 06:19 | |
| *** sungju has quit IRC | 06:24 | |
| *** freedomhui has quit IRC | 06:28 | |
| *** basha has joined #openstack-dev | 06:32 | |
| *** dmakogon__ has joined #openstack-dev | 06:35 | |
| *** nayward has joined #openstack-dev | 06:36 | |
| *** freedomhui has joined #openstack-dev | 06:38 | |
| *** jpich has joined #openstack-dev | 06:39 | |
| *** tkammer has joined #openstack-dev | 06:39 | |
| *** basha has quit IRC | 06:47 | |
| *** amerine has quit IRC | 06:47 | |
| *** basha has joined #openstack-dev | 06:48 | |
| *** yolanda has joined #openstack-dev | 06:49 | |
| *** amerine has joined #openstack-dev | 06:49 | |
| *** sheeprine has quit IRC | 06:50 | |
| *** flaper87|afk is now known as flaper87 | 06:51 | |
| *** basha has quit IRC | 06:52 | |
| *** dina_belova has joined #openstack-dev | 06:53 | |
| *** jprovazn has joined #openstack-dev | 06:55 | |
| *** vartom7 has joined #openstack-dev | 06:55 | |
| *** xga has joined #openstack-dev | 06:55 | |
| *** dina_belova has quit IRC | 06:56 | |
| *** jcoufal has joined #openstack-dev | 06:56 | |
| *** jcoufal has quit IRC | 06:58 | |
| *** jcoufal has joined #openstack-dev | 07:01 | |
| *** aloga has joined #openstack-dev | 07:02 | |
| *** jhesketh has quit IRC | 07:06 | |
| *** jhesketh has joined #openstack-dev | 07:06 | |
| *** jhesketh__ has joined #openstack-dev | 07:06 | |
| *** basha has joined #openstack-dev | 07:07 | |
| *** rha has quit IRC | 07:08 | |
| morganfainberg | henrynash: if you want to discuss anything on the API protection review in more-real-time than via gerrit reviews, let me know. | 07:08 |
| henrynash | hi | 07:09 |
| *** marios has joined #openstack-dev | 07:09 | |
| *** jtomasek has joined #openstack-dev | 07:09 | |
| morganfainberg | henrynash: but long and the short, it's not a bad implementation as is. | 07:09 |
| henrynash | morganfainberg: so did I get the right idea as to what you were suggesting in my last comment | 07:09 |
| henrynash | morganfainberg: (trying to be impartial) I think I agree…it is reasonable obvious as to what is going on | 07:10 |
| morganfainberg | henrynash: i was thinking more of a direct pass of the helper method into the decorator: @protected(callback_helper_fn=callback_fn) | 07:10 |
| henrynash | morganfainberg: ah, right | 07:10 |
| morganfainberg | henrynash: using init to setup a dict would be too hard to maintain elegantly | 07:10 |
| *** egallen has joined #openstack-dev | 07:10 | |
| henrynash | morganfainberg: (agreed on init) | 07:11 |
| morganfainberg | henrynash: the second issue, being safe to run the funcition before anything else, i think is the bigger issue at hand | 07:11 |
| henrynash | morganfainberg: in the past I had problems with have option parameters to decorators... | 07:11 |
| henrynash | morganfainberg: (but that's probably my python-less-background :-) ) | 07:12 |
| morganfainberg | henrynash: i built a few things based upon optional decorators, sec i'll dig it up to show the implementation in a paste. | 07:12 |
| morganfainberg | erm | 07:12 |
| morganfainberg | decorators with optional args | 07:12 |
| henrynash | morganfainberg: thx | 07:12 |
| *** bashok has joined #openstack-dev | 07:14 | |
| morganfainberg | henrynash: eek, this will take me a few minutes, i forgot how complex this one ended up getting. I have to sanitize it for public consumption (has some proprietary work in it) | 07:14 |
| morganfainberg | henrynash: give me ~5 mins. | 07:14 |
| henrynash | morganfainberg: sure, thx | 07:15 |
| *** wfoster_away is now known as wfoster | 07:15 | |
| tace | Hi all. I'm working on Heat code and I need to get vm instance's compute node hostname. How to get it as from nova api only root has access to such data and Heat does not have access to nova database tables (wanted info is in instances.node)? | 07:16 |
| *** corXi has joined #openstack-dev | 07:18 | |
| *** jhesketh__ has quit IRC | 07:18 | |
| *** jhesketh_ has joined #openstack-dev | 07:18 | |
| *** mmagr has joined #openstack-dev | 07:18 | |
| *** freedomhui has quit IRC | 07:19 | |
| *** freedomhui has joined #openstack-dev | 07:20 | |
| *** ifarkas has joined #openstack-dev | 07:20 | |
| *** pasquier-s has joined #openstack-dev | 07:21 | |
| morganfainberg | henrynash: realized it was easier to make a contrived test: http://paste.openstack.org/show/45131/ | 07:23 |
| morganfainberg | henrynash: similar to how the dogpile.cache decorator works for accepting a "should_cache" function (should we cache the result, it passes the return value(s) to the helper callback, which returns True/False on if soemthing should be cached) | 07:24 |
| morganfainberg | henrynash: but, i'll take your judgement on value proposition here, if it is too much to get done in light of other high value things to work on, i'll happily +2 and make a note we can come back and iterate on this stuff in icehouse :) | 07:26 |
| morganfainberg | or i could propose a review with the decorator changes if it'll help you out. | 07:27 |
| *** JordanP has joined #openstack-dev | 07:28 | |
| *** freedomhui has quit IRC | 07:30 | |
| *** xga_ has joined #openstack-dev | 07:30 | |
| *** ndipanov has joined #openstack-dev | 07:30 | |
| *** AnilV4 has joined #openstack-dev | 07:30 | |
| *** xga has quit IRC | 07:33 | |
| *** safchain has joined #openstack-dev | 07:37 | |
| *** nayward has quit IRC | 07:38 | |
| *** rha has joined #openstack-dev | 07:39 | |
| *** xqueralt-afk is now known as xqueralt | 07:39 | |
| *** jaimegil has joined #openstack-dev | 07:44 | |
| henrynash | morganfainberg: thx, I'll take a look….large issue for me is I am racing to get the filtering and pagination stuff complete ahead of the freeze.. | 07:46 |
| morganfainberg | exactly. | 07:46 |
| henrynash | morganfainberg:…but certainly happy to come back to it.... | 07:46 |
| *** freedomhui has joined #openstack-dev | 07:47 | |
| morganfainberg | henrynash: same with what i've been trying to do with caching. btw, i need to sync up with you on filtering pagination, so i can toss some caching in on identity and assignment that will work with your filtering impl. i'll look over your WIPs and hit you up if i have any questions. | 07:48 |
| henrynash | morganfainberg: great | 07:49 |
| *** gongysh has joined #openstack-dev | 07:50 | |
| *** d34dh0r53 has quit IRC | 07:50 | |
| *** basha has quit IRC | 07:52 | |
| *** rha has quit IRC | 07:52 | |
| *** rha has joined #openstack-dev | 07:53 | |
| *** dina_belova has joined #openstack-dev | 07:53 | |
| *** ifarkas has quit IRC | 07:54 | |
| *** jistr has joined #openstack-dev | 07:55 | |
| *** sungju has joined #openstack-dev | 07:56 | |
| *** ifarkas has joined #openstack-dev | 07:56 | |
| *** ctlaugh has quit IRC | 07:57 | |
| *** basha has joined #openstack-dev | 07:57 | |
| *** xga has joined #openstack-dev | 07:57 | |
| *** basha has quit IRC | 07:58 | |
| *** dina_belova has quit IRC | 07:59 | |
| *** tkammer has quit IRC | 07:59 | |
| *** xga_ has quit IRC | 08:00 | |
| *** shang has joined #openstack-dev | 08:01 | |
| *** fbo_away is now known as fbo | 08:01 | |
| *** shardy is now known as shardy_afk | 08:02 | |
| *** d34dh0r53 has joined #openstack-dev | 08:02 | |
| *** boden has joined #openstack-dev | 08:03 | |
| *** afazekas has joined #openstack-dev | 08:04 | |
| *** MaxV has joined #openstack-dev | 08:08 | |
| *** ctlaugh has joined #openstack-dev | 08:10 | |
| *** lexinator has joined #openstack-dev | 08:11 | |
| *** dguitarbite has quit IRC | 08:13 | |
| *** Shaan7 has quit IRC | 08:14 | |
| *** tkammer has joined #openstack-dev | 08:15 | |
| *** ctlaugh has quit IRC | 08:17 | |
| *** ema has joined #openstack-dev | 08:18 | |
| *** lexinator has quit IRC | 08:19 | |
| *** zyluo has quit IRC | 08:20 | |
| *** ctlaugh has joined #openstack-dev | 08:22 | |
| *** eglynn has joined #openstack-dev | 08:24 | |
| *** derekh has joined #openstack-dev | 08:25 | |
| *** giulivo has joined #openstack-dev | 08:28 | |
| *** TheSheep has joined #openstack-dev | 08:30 | |
| *** yolanda has quit IRC | 08:32 | |
| *** lucasagomes has joined #openstack-dev | 08:35 | |
| *** alexxu has quit IRC | 08:37 | |
| enikanorov_ | arosen: Hi | 08:37 |
| *** shang has quit IRC | 08:39 | |
| *** shang has joined #openstack-dev | 08:41 | |
| *** doron_afk is now known as doron | 08:41 | |
| *** dguitarbite has joined #openstack-dev | 08:42 | |
| *** luisg has quit IRC | 08:45 | |
| *** luisg has joined #openstack-dev | 08:46 | |
| *** nshaikh has joined #openstack-dev | 08:50 | |
| *** dteselkin has joined #openstack-dev | 08:51 | |
| *** kushal has quit IRC | 08:51 | |
| *** romcheg has joined #openstack-dev | 08:51 | |
| *** xchu has quit IRC | 08:52 | |
| *** dina_belova has joined #openstack-dev | 08:54 | |
| *** donaldh has joined #openstack-dev | 08:56 | |
| *** MaxV has quit IRC | 08:58 | |
| *** dina_belova has quit IRC | 08:58 | |
| *** alexxu has joined #openstack-dev | 09:00 | |
| *** Shaan7 has joined #openstack-dev | 09:01 | |
| *** xchu has joined #openstack-dev | 09:04 | |
| *** MaxV has joined #openstack-dev | 09:06 | |
| *** radsy has joined #openstack-dev | 09:07 | |
| *** kushal has joined #openstack-dev | 09:08 | |
| *** basha has joined #openstack-dev | 09:11 | |
| *** stevemar has quit IRC | 09:13 | |
| giulivo | guys, a general question about gerrit: the dashboard is highlighting changes were I'm enlisted as reviewer and reviewed with a +1/-1 after the latest patchset. Unfortunately it also highlighting changes which have reviewed but refused to vote (voted 0); can that be changed somehow? | 09:16 |
| giulivo | *and haven't reviewed | 09:16 |
| giulivo | doh I think my wording was quite confusing, basically I'd like changes where I have added a comment but not a vote to not be highlighted (thanks!) | 09:17 |
| *** pixelbeat has joined #openstack-dev | 09:18 | |
| enikanorov_ | isn't 'Review Requests for ' what you're looking for? | 09:18 |
| *** radsy has quit IRC | 09:20 | |
| *** tkammer has quit IRC | 09:22 | |
| giulivo | enikanorov-w, thanks, indeed that is what I'm looking at but the problem is it keeps highlighting changes which don't have a +1/-1 from me even if I've commented those and voted 0 | 09:24 |
| giulivo | enikanorov_ ^ | 09:24 |
| *** alexpilotti has joined #openstack-dev | 09:25 | |
| enikanorov_ | i don't think it could be changed, but don't see issue in that. it directly does what it supposed to do: show review where you're a reviewr | 09:26 |
| enikanorov_ | regardless of your votes/comments | 09:26 |
| enikanorov_ | author may add you to reviewers and their review will show up in your dashboard | 09:26 |
| *** doron is now known as doron_afk | 09:27 | |
| *** alexxu has quit IRC | 09:28 | |
| *** ruhe has joined #openstack-dev | 09:29 | |
| giulivo | enikanorov_, it does what is intended too, the only problem I see is that it is assuming a "review" is done only if you've up/down voted it; if you just add a comment and review but don't vote, it will keep showing there as "in need of attention" | 09:30 |
| giulivo | basically my idea is that reviewing, even when non voting, should stop highlighting the submission | 09:32 |
| *** mikal has quit IRC | 09:32 | |
| *** tkammer has joined #openstack-dev | 09:34 | |
| *** zbitter is now known as zaneb | 09:36 | |
| *** jcoufal has quit IRC | 09:39 | |
| *** jhesketh has quit IRC | 09:41 | |
| *** sungju has quit IRC | 09:42 | |
| *** sungju has joined #openstack-dev | 09:44 | |
| *** noslzzp has quit IRC | 09:46 | |
| *** yolanda has joined #openstack-dev | 09:47 | |
| *** lexinator has joined #openstack-dev | 09:48 | |
| *** noslzzp has joined #openstack-dev | 09:49 | |
| *** lexinator has quit IRC | 09:53 | |
| *** dina_belova has joined #openstack-dev | 09:55 | |
| *** nshaikh has quit IRC | 09:55 | |
| *** dguitarbite has quit IRC | 09:55 | |
| *** rods1 has joined #openstack-dev | 09:58 | |
| *** tkammer has quit IRC | 09:58 | |
| *** dina_belova has quit IRC | 09:59 | |
| *** afazekas has quit IRC | 10:03 | |
| *** afazekas has joined #openstack-dev | 10:04 | |
| *** fbo is now known as fbo_away | 10:05 | |
| *** lsmola has joined #openstack-dev | 10:06 | |
| *** xchu has quit IRC | 10:07 | |
| *** ruhe has quit IRC | 10:08 | |
| *** nshaikh has joined #openstack-dev | 10:08 | |
| *** ruhe has joined #openstack-dev | 10:10 | |
| *** pcm_ has joined #openstack-dev | 10:11 | |
| *** pcm_ has quit IRC | 10:11 | |
| *** pcm_ has joined #openstack-dev | 10:11 | |
| *** ruhe has quit IRC | 10:12 | |
| *** tkammer has joined #openstack-dev | 10:15 | |
| *** yaguang has quit IRC | 10:22 | |
| *** mikal has joined #openstack-dev | 10:22 | |
| *** doron_afk is now known as doron | 10:23 | |
| *** morganfainberg is now known as morganfainberg|a | 10:25 | |
| *** afazekas_ has joined #openstack-dev | 10:27 | |
| *** afazekas has quit IRC | 10:28 | |
| *** egallen has quit IRC | 10:32 | |
| *** jhesketh has joined #openstack-dev | 10:34 | |
| *** donaldh has quit IRC | 10:36 | |
| *** donaldh has joined #openstack-dev | 10:36 | |
| *** dims has joined #openstack-dev | 10:40 | |
| *** basha has quit IRC | 10:42 | |
| *** chuckieb has joined #openstack-dev | 10:45 | |
| *** ffio has joined #openstack-dev | 10:47 | |
| *** ruhe has joined #openstack-dev | 10:48 | |
| *** macjack has quit IRC | 10:49 | |
| *** lexinator has joined #openstack-dev | 10:50 | |
| *** lexinator has quit IRC | 10:55 | |
| *** dina_belova has joined #openstack-dev | 10:55 | |
| *** dina_belova has quit IRC | 10:59 | |
| *** SkyRocknRoll has joined #openstack-dev | 11:00 | |
| *** SkyRocknRoll has quit IRC | 11:00 | |
| *** SkyRocknRoll has joined #openstack-dev | 11:00 | |
| *** nshaikh has left #openstack-dev | 11:03 | |
| *** nshaikh has joined #openstack-dev | 11:04 | |
| *** xga has quit IRC | 11:04 | |
| *** xga has joined #openstack-dev | 11:06 | |
| *** gmoro has quit IRC | 11:06 | |
| *** freedomhui has quit IRC | 11:07 | |
| *** ljjjustin has quit IRC | 11:08 | |
| *** donaldh has quit IRC | 11:08 | |
| *** gongysh has quit IRC | 11:09 | |
| *** dkranz has quit IRC | 11:10 | |
| *** xga_ has joined #openstack-dev | 11:13 | |
| *** xga has quit IRC | 11:15 | |
| *** fbo_away is now known as fbo | 11:16 | |
| *** prekarat has quit IRC | 11:17 | |
| *** gmoro has joined #openstack-dev | 11:18 | |
| *** maheshp has joined #openstack-dev | 11:19 | |
| *** adalbas has quit IRC | 11:21 | |
| *** basha has joined #openstack-dev | 11:25 | |
| *** tkammer has quit IRC | 11:27 | |
| *** MaxV has quit IRC | 11:28 | |
| *** MaxV has joined #openstack-dev | 11:28 | |
| *** iartarisi has joined #openstack-dev | 11:32 | |
| *** donaldh has joined #openstack-dev | 11:35 | |
| *** kushal has quit IRC | 11:37 | |
| *** rfolco has joined #openstack-dev | 11:39 | |
| *** feleouet has joined #openstack-dev | 11:43 | |
| *** adalbas has joined #openstack-dev | 11:44 | |
| *** tmclaugh[work] has joined #openstack-dev | 11:44 | |
| *** ema_ has joined #openstack-dev | 11:44 | |
| *** ema_ has joined #openstack-dev | 11:44 | |
| *** FunnyLookinHat has joined #openstack-dev | 11:47 | |
| *** ema has quit IRC | 11:47 | |
| *** martine has joined #openstack-dev | 11:48 | |
| *** martine is now known as Guest65981 | 11:49 | |
| *** basha has joined #openstack-dev | 11:49 | |
| *** lexinator has joined #openstack-dev | 11:51 | |
| *** maheshp has quit IRC | 11:53 | |
| *** lucasagomes is now known as lucas-hungry | 11:54 | |
| *** dina_belova has joined #openstack-dev | 11:56 | |
| *** lexinator has quit IRC | 11:56 | |
| *** dina_belova has quit IRC | 12:00 | |
| *** egallen has joined #openstack-dev | 12:00 | |
| *** MaxV has quit IRC | 12:00 | |
| *** dprince has joined #openstack-dev | 12:01 | |
| *** donaldh has quit IRC | 12:02 | |
| *** ndipanov has quit IRC | 12:03 | |
| *** dims has quit IRC | 12:03 | |
| *** ndipanov has joined #openstack-dev | 12:04 | |
| *** terryh has joined #openstack-dev | 12:04 | |
| *** jcoufal has joined #openstack-dev | 12:07 | |
| *** cbaesema has quit IRC | 12:10 | |
| *** basha has quit IRC | 12:10 | |
| *** xga_ has quit IRC | 12:11 | |
| *** dkranz has joined #openstack-dev | 12:13 | |
| *** dolphm has joined #openstack-dev | 12:13 | |
| *** prekarat has joined #openstack-dev | 12:14 | |
| *** msdubov has joined #openstack-dev | 12:15 | |
| *** ffio has quit IRC | 12:16 | |
| *** dvarga has joined #openstack-dev | 12:19 | |
| *** jjmb has joined #openstack-dev | 12:20 | |
| *** boris-42 has joined #openstack-dev | 12:20 | |
| *** basha has joined #openstack-dev | 12:22 | |
| *** sridevi has joined #openstack-dev | 12:26 | |
| *** basha has quit IRC | 12:29 | |
| *** xga has joined #openstack-dev | 12:30 | |
| *** sridevi has quit IRC | 12:32 | |
| *** sridevi has joined #openstack-dev | 12:32 | |
| *** mikal has quit IRC | 12:37 | |
| *** ffio has joined #openstack-dev | 12:37 | |
| *** jaimegil has quit IRC | 12:38 | |
| *** mikal has joined #openstack-dev | 12:38 | |
| *** flaper87 is now known as flaper87|afk | 12:38 | |
| *** sumanthns has quit IRC | 12:39 | |
| *** ilyashakhat has joined #openstack-dev | 12:43 | |
| *** prekarat has quit IRC | 12:43 | |
| *** jcoufal has quit IRC | 12:43 | |
| *** macjack has joined #openstack-dev | 12:43 | |
| *** lucas-hungry is now known as lucasagomes | 12:43 | |
| *** jcoufal has joined #openstack-dev | 12:43 | |
| *** mikal has quit IRC | 12:44 | |
| *** elmarco has quit IRC | 12:44 | |
| *** mikal has joined #openstack-dev | 12:45 | |
| *** woodspa has joined #openstack-dev | 12:46 | |
| *** jamiem has joined #openstack-dev | 12:47 | |
| *** prekarat has joined #openstack-dev | 12:48 | |
| *** flaper87|afk is now known as flaper87 | 12:48 | |
| *** elmarco has joined #openstack-dev | 12:51 | |
| *** sandywalsh has joined #openstack-dev | 12:52 | |
| *** jamiem has quit IRC | 12:54 | |
| *** lorin1 has joined #openstack-dev | 12:54 | |
| *** alunduil has quit IRC | 12:55 | |
| *** dina_belova has joined #openstack-dev | 12:56 | |
| *** doron is now known as doron_afk | 12:57 | |
| *** jayg|g0n3 is now known as jayg | 12:57 | |
| *** beagles has quit IRC | 12:57 | |
| *** beagles has joined #openstack-dev | 12:58 | |
| *** anteaya has joined #openstack-dev | 12:59 | |
| *** dina_belova has quit IRC | 12:59 | |
| *** jasondotstar has joined #openstack-dev | 12:59 | |
| *** prekarat has quit IRC | 12:59 | |
| *** prekarat has joined #openstack-dev | 13:00 | |
| *** chandankumar has quit IRC | 13:00 | |
| *** radez_g0n3 is now known as radez | 13:03 | |
| *** maheshp has joined #openstack-dev | 13:03 | |
| *** maheshp1 has joined #openstack-dev | 13:03 | |
| *** macjack has left #openstack-dev | 13:04 | |
| *** macjack has quit IRC | 13:04 | |
| *** ema_ has quit IRC | 13:04 | |
| *** eglynn is now known as eglynn-lunch | 13:04 | |
| *** jergerber has joined #openstack-dev | 13:06 | |
| *** jergerber has quit IRC | 13:06 | |
| *** msdubov has quit IRC | 13:07 | |
| *** CaptTofu has joined #openstack-dev | 13:07 | |
| *** jamiem has joined #openstack-dev | 13:07 | |
| *** jergerber has joined #openstack-dev | 13:09 | |
| *** sheeprine_ has joined #openstack-dev | 13:10 | |
| *** odyssey4me has quit IRC | 13:10 | |
| *** prekarat has quit IRC | 13:10 | |
| *** NimeshNeema has left #openstack-dev | 13:11 | |
| *** kbringard has joined #openstack-dev | 13:13 | |
| *** basha has joined #openstack-dev | 13:14 | |
| *** joesavak has joined #openstack-dev | 13:15 | |
| *** basha has quit IRC | 13:16 | |
| *** vartom7 has quit IRC | 13:17 | |
| *** jcoufal has quit IRC | 13:19 | |
| *** eharney has quit IRC | 13:20 | |
| *** egallen has quit IRC | 13:21 | |
| *** Guest65981 has quit IRC | 13:21 | |
| *** SkyRocknRoll has quit IRC | 13:21 | |
| *** gordc has joined #openstack-dev | 13:23 | |
| *** eglynn-lunch is now known as eglynn | 13:24 | |
| *** cppcabrera has joined #openstack-dev | 13:25 | |
| *** cppcabrera has left #openstack-dev | 13:25 | |
| *** Mandell has quit IRC | 13:26 | |
| *** mrunge has quit IRC | 13:26 | |
| *** drewland_ has joined #openstack-dev | 13:27 | |
| *** maheshp has joined #openstack-dev | 13:28 | |
| *** maheshp1 has quit IRC | 13:28 | |
| sandywalsh | harlowja, hey J, could use your feedback on http://markmail.org/message/5wfykgbapv7qywyx ... might be a good fit for state management | 13:29 |
| *** jog0-away is now known as jog0 | 13:30 | |
| *** dims has joined #openstack-dev | 13:31 | |
| *** zul has quit IRC | 13:32 | |
| *** yolanda has quit IRC | 13:32 | |
| *** brianr-gone is now known as brianr | 13:32 | |
| *** martine has joined #openstack-dev | 13:34 | |
| *** doron_afk is now known as doron | 13:34 | |
| *** wolfdreamer has joined #openstack-dev | 13:34 | |
| *** martine is now known as Guest92507 | 13:34 | |
| *** briancurtin has joined #openstack-dev | 13:35 | |
| *** blamar has joined #openstack-dev | 13:35 | |
| *** CaptTofu has quit IRC | 13:35 | |
| *** CaptTofu has joined #openstack-dev | 13:36 | |
| *** freedomhui has joined #openstack-dev | 13:36 | |
| *** bswartz has quit IRC | 13:37 | |
| *** neelashah has joined #openstack-dev | 13:37 | |
| *** dina_belova has joined #openstack-dev | 13:37 | |
| *** SergeyLukjanov has joined #openstack-dev | 13:38 | |
| *** jlabocki has joined #openstack-dev | 13:38 | |
| *** yolanda has joined #openstack-dev | 13:39 | |
| *** CaptTofu has quit IRC | 13:40 | |
| *** kevinconway has quit IRC | 13:40 | |
| *** jcoufal has joined #openstack-dev | 13:40 | |
| *** ruhe has quit IRC | 13:40 | |
| *** tkammer has joined #openstack-dev | 13:41 | |
| *** jhesketh has quit IRC | 13:41 | |
| *** otherwiseguy has joined #openstack-dev | 13:41 | |
| *** sheeprine_ has quit IRC | 13:42 | |
| *** burt has joined #openstack-dev | 13:42 | |
| *** dkehn is now known as dkehn_away | 13:43 | |
| *** datsun180b has joined #openstack-dev | 13:44 | |
| *** turduks has joined #openstack-dev | 13:45 | |
| *** yolanda has quit IRC | 13:46 | |
| *** sheeprine has joined #openstack-dev | 13:47 | |
| *** gongysh has joined #openstack-dev | 13:51 | |
| *** HenryG_ has quit IRC | 13:52 | |
| *** HenryG has joined #openstack-dev | 13:52 | |
| *** ruhe has joined #openstack-dev | 13:53 | |
| *** turduks has quit IRC | 13:53 | |
| *** lexinator has joined #openstack-dev | 13:54 | |
| *** eharney has joined #openstack-dev | 13:55 | |
| *** dina_belova has quit IRC | 13:56 | |
| *** rustlebee is now known as russellb | 13:56 | |
| *** michchap_ has quit IRC | 13:57 | |
| *** michchap has joined #openstack-dev | 13:58 | |
| *** jimfehlig has joined #openstack-dev | 13:58 | |
| *** rwsu has joined #openstack-dev | 13:58 | |
| *** jruzicka has joined #openstack-dev | 13:58 | |
| *** lexinator has quit IRC | 13:59 | |
| *** BLZbubba_ has joined #openstack-dev | 14:00 | |
| *** dims has quit IRC | 14:00 | |
| *** bswartz has joined #openstack-dev | 14:02 | |
| *** rcleere has quit IRC | 14:02 | |
| *** MaxV has joined #openstack-dev | 14:02 | |
| *** morazi has joined #openstack-dev | 14:03 | |
| *** stevemar has joined #openstack-dev | 14:03 | |
| *** venkatesh has joined #openstack-dev | 14:03 | |
| venkatesh | dprince: around? | 14:04 |
| *** yolanda has joined #openstack-dev | 14:04 | |
| dprince | venkatesh: hi | 14:05 |
| venkatesh | dprince: hi, i tested with Fedora 19 + mariadb. i couldn't reproduce the issue. its seems to be working fine. | 14:05 |
| dprince | venkatesh: what environment were you using (devstack)? I was using packages... | 14:06 |
| *** alunduil has joined #openstack-dev | 14:06 | |
| *** gongysh has quit IRC | 14:07 | |
| venkatesh | dprince: no i just setup only glance & python-glanceclient for testing. no devstack. | 14:07 |
| *** FunnyLookinHat has quit IRC | 14:08 | |
| *** MaxV has quit IRC | 14:08 | |
| *** litong has joined #openstack-dev | 14:08 | |
| dprince | venkatesh: I can give you access to one of my environments if you'de like. | 14:09 |
| dprince | venkatesh: essentially the same thing SmokeStack uses... | 14:09 |
| venkatesh | dprince: thanks. that will be great. | 14:10 |
| *** MaxV has joined #openstack-dev | 14:10 | |
| *** kbrierly has joined #openstack-dev | 14:10 | |
| *** MaxV has joined #openstack-dev | 14:10 | |
| *** alunduil has quit IRC | 14:15 | |
| venkatesh | dprince: can you please mail me the access details. | 14:15 |
| *** jecarey has joined #openstack-dev | 14:15 | |
| *** kenperkins has joined #openstack-dev | 14:16 | |
| *** spzala has joined #openstack-dev | 14:16 | |
| *** kevinconway has joined #openstack-dev | 14:17 | |
| *** donaldh has joined #openstack-dev | 14:18 | |
| *** yolanda has quit IRC | 14:19 | |
| *** doron is now known as doron_afk | 14:23 | |
| *** terryw has joined #openstack-dev | 14:25 | |
| *** rnirmal has joined #openstack-dev | 14:25 | |
| *** morazi has quit IRC | 14:25 | |
| *** otherwiseguy has quit IRC | 14:26 | |
| *** yannovitch has joined #openstack-dev | 14:26 | |
| *** mmagr has quit IRC | 14:26 | |
| jgriffith | jog0: ping | 14:27 |
| *** zul has joined #openstack-dev | 14:28 | |
| *** markwash has quit IRC | 14:28 | |
| *** jvrbanac has joined #openstack-dev | 14:29 | |
| *** xqueralt is now known as xqueralt-afk | 14:30 | |
| *** yannovitch has quit IRC | 14:30 | |
| *** vkmc has joined #openstack-dev | 14:31 | |
| *** vkmc has quit IRC | 14:31 | |
| *** vkmc has joined #openstack-dev | 14:31 | |
| *** Max_ has joined #openstack-dev | 14:31 | |
| *** michchap has quit IRC | 14:32 | |
| *** Max_ has quit IRC | 14:32 | |
| *** Max_ has joined #openstack-dev | 14:33 | |
| *** xqueralt-afk is now known as xqueralt | 14:33 | |
| *** jpeeler has quit IRC | 14:33 | |
| *** rcleere has joined #openstack-dev | 14:33 | |
| *** jpeeler has joined #openstack-dev | 14:33 | |
| *** utlemming has quit IRC | 14:33 | |
| jog0 | jgriffith: pong | 14:34 |
| *** zaitcev has joined #openstack-dev | 14:34 | |
| jgriffith | jog0: hey.. thanks for the input on https://review.openstack.org/#/c/43591/ | 14:34 |
| jgriffith | jog0: I totally agree with your points, however I think openstack/requirments is thereby broken | 14:35 |
| *** MaxV has quit IRC | 14:35 | |
| *** alunduil has joined #openstack-dev | 14:35 | |
| jgriffith | jog0: I've been trying to decide if I need/want to update requirements files or not | 14:35 |
| *** yolanda has joined #openstack-dev | 14:35 | |
| jog0 | jgriffith: yeah hacking makes things funny | 14:35 |
| jgriffith | jog0: indeed... and not funny "haha" | 14:36 |
| jgriffith | jog0: so I traced that down Friday as you pointed out | 14:36 |
| *** martines has quit IRC | 14:36 | |
| jgriffith | jog0: but like I said, if we're going back to individual edits what's the point | 14:36 |
| jog0 | jgriffith: because, we can't run trunk hacking unless we are willing to block all projects until updates are rolled out every time a new check is added. Which I don't think we want to do | 14:36 |
| *** utlemming has joined #openstack-dev | 14:37 | |
| jgriffith | jog0: yeah, that makes sense | 14:37 |
| jgriffith | jog0: although it kinda sucks | 14:37 |
| jgriffith | jog0: I'm a bit concerned what happens when we release with all of this | 14:37 |
| *** gimps_ has joined #openstack-dev | 14:38 | |
| jog0 | jgriffith: what do you mean? won't we just freeze deps when we release? | 14:38 |
| jgriffith | jog0: but it seems we'll have this exact problem of the projects not being in sync all over again | 14:38 |
| jgriffith | jog0: but now it will be an even harder problem due to hacking | 14:38 |
| *** salv-orlando has joined #openstack-dev | 14:38 | |
| jog0 | jgriffith: for hacking because of its nature we can't run on floating flake8, but pyflakes should be safe. | 14:39 |
| *** jpich has quit IRC | 14:39 | |
| jog0 | jgriffith: if you run update.py without pyflakes listed in this file will it just work? | 14:39 |
| *** lexinator has joined #openstack-dev | 14:39 | |
| jgriffith | jog0: You mean remove pyflakes in the dest so update doesn't fill it in? | 14:40 |
| jgriffith | jog0: I assume that yes it will | 14:40 |
| jog0 | jgriffith: yup | 14:40 |
| jog0 | its a indirect dep anyway | 14:40 |
| jgriffith | jog0: fair point | 14:40 |
| *** jpeeler has quit IRC | 14:40 | |
| jgriffith | jog0: I'll try it, that should take care of it assuming hacking gets updated | 14:40 |
| jog0 | jgriffith: I don't think we will have the issue if out of sync deps once released because devstack only uses the openstack/requirements versions | 14:40 |
| jgriffith | jog0: probably true, yes | 14:41 |
| *** doron_afk is now known as doron | 14:41 | |
| *** jpeeler has joined #openstack-dev | 14:41 | |
| jog0 | jgriffith: which gets funny with hacking ... because global reqs is bumped before local, so flake8 won't always be green in devstack | 14:41 |
| *** jpich has joined #openstack-dev | 14:41 | |
| jog0 | jgriffith: for hacking we can just bump deps in the soon to be made hacking 0.7 branch | 14:42 |
| jog0 | and just do a bunch of 0.7.x releases | 14:42 |
| jgriffith | jog0: yeah, I get ya. Just a bit of a pain right now | 14:42 |
| jgriffith | jog0: but I do think as you said it'll sort itself in the end | 14:42 |
| jog0 | jgriffith: yeah ... I hope they are just growing pains | 14:42 |
| jog0 | so if you drop the pep8, pyfalkes and flake8 test-reqs everything should magically work | 14:43 |
| *** danwent has joined #openstack-dev | 14:43 | |
| jgriffith | jog0: yeah, sounds good | 14:43 |
| jgriffith | jog0: thanks for the input | 14:43 |
| jog0 | jgriffith: if that does work, I can send something to the ML about it as I ahve seen a bunch of projects hit this | 14:44 |
| jog0 | we have over 50 repos in the openstack namespace now, so ML seems like the easies way to get it out there | 14:45 |
| jgriffith | jog0: sounds good, I'll push it up right now and we'll see. It should fix it based on the logs/error messages | 14:45 |
| *** utlemming has quit IRC | 14:45 | |
| jog0 | jgriffith: thanks | 14:45 |
| *** utlemming has joined #openstack-dev | 14:45 | |
| jog0 | tempest is trying it right now as well https://review.openstack.org/#/c/43168/5/test-requirements.txt | 14:46 |
| jog0 | jgriffith: ^ | 14:46 |
| jgriffith | jog0: ha! | 14:46 |
| *** utlemming has quit IRC | 14:46 | |
| jgriffith | jog0: ok then :) | 14:46 |
| *** gasanoff has joined #openstack-dev | 14:46 | |
| *** prad has joined #openstack-dev | 14:47 | |
| *** dmakogon__ has quit IRC | 14:47 | |
| *** prad has quit IRC | 14:48 | |
| *** prad has joined #openstack-dev | 14:48 | |
| *** utlemming has joined #openstack-dev | 14:49 | |
| *** vartom7 has joined #openstack-dev | 14:49 | |
| *** matiu has joined #openstack-dev | 14:50 | |
| *** matiu has quit IRC | 14:50 | |
| *** matiu has joined #openstack-dev | 14:50 | |
| *** dkehn_away is now known as dkehn | 14:51 | |
| *** FunnyLookinHat has joined #openstack-dev | 14:53 | |
| *** jpich has quit IRC | 14:53 | |
| *** sridevi has quit IRC | 14:54 | |
| *** vkmc_ has joined #openstack-dev | 14:54 | |
| *** jpich has joined #openstack-dev | 14:55 | |
| *** vkmc has quit IRC | 14:55 | |
| *** chandankumar has joined #openstack-dev | 14:56 | |
| *** krtaylor has joined #openstack-dev | 14:56 | |
| *** vkmc_ is now known as vkmc | 14:56 | |
| *** vkmc has joined #openstack-dev | 14:57 | |
| *** dina_belova has joined #openstack-dev | 14:57 | |
| *** dteselkin has left #openstack-dev | 14:57 | |
| *** boris-42 has quit IRC | 14:59 | |
| *** pmathews has joined #openstack-dev | 14:59 | |
| *** dguitarbite has joined #openstack-dev | 14:59 | |
| *** CaptTofu has joined #openstack-dev | 15:00 | |
| *** lexinator has quit IRC | 15:00 | |
| jd__ | jog0: do you have enough power to cut a branch on hacking? | 15:01 |
| *** dina_belova has quit IRC | 15:01 | |
| *** michchap has joined #openstack-dev | 15:02 | |
| *** morazi has joined #openstack-dev | 15:03 | |
| *** gasanoff has quit IRC | 15:03 | |
| *** pmathews1 has joined #openstack-dev | 15:04 | |
| *** jprovazn has quit IRC | 15:06 | |
| *** dina_belova has joined #openstack-dev | 15:07 | |
| *** networkstatic has joined #openstack-dev | 15:07 | |
| *** pmathews has quit IRC | 15:07 | |
| *** alop has joined #openstack-dev | 15:08 | |
| *** jmontemayor has joined #openstack-dev | 15:09 | |
| *** salv-orlando has quit IRC | 15:09 | |
| *** marios has quit IRC | 15:10 | |
| *** doron is now known as doron_afk | 15:10 | |
| *** egallen has joined #openstack-dev | 15:10 | |
| *** michchap has quit IRC | 15:10 | |
| *** dina_belova has quit IRC | 15:11 | |
| *** venkatesh has quit IRC | 15:12 | |
| *** nati_ueno has joined #openstack-dev | 15:12 | |
| jog0 | jd__: yup | 15:13 |
| jog0 | jd__: why? | 15:13 |
| jd__ | jog0: to have 0.7.x so I can propose the requirements update there :) | 15:14 |
| *** herndon has joined #openstack-dev | 15:14 | |
| jd__ | (I either don't have the power or don't know how to use it :) | 15:14 |
| *** nati_ueno has quit IRC | 15:14 | |
| jog0 | jd__: ahh right, that isn't needed to fix your problem btw | 15:15 |
| jog0 | see ^ | 15:15 |
| *** nati_ueno has joined #openstack-dev | 15:15 | |
| jog0 | although I do think we need a 0.7.x branch | 15:15 |
| *** jbresnah has joined #openstack-dev | 15:15 | |
| jd__ | well I need a release to fix my problem, I though you were talking about doing 0.7.x for that? | 15:16 |
| jog0 | https://review.openstack.org/#/c/43168/5 passed pep8 and reqs | 15:16 |
| jd__ | though I don't care if that's 0.8 | 15:16 |
| *** aeperezt has joined #openstack-dev | 15:16 | |
| *** briancurtin has quit IRC | 15:16 | |
| jog0 | jd__: just remove pep8, pyflakes and flake8 as oslo.config test-reqs | 15:16 |
| jd__ | ack | 15:17 |
| *** sthaha has quit IRC | 15:19 | |
| *** danwent has quit IRC | 15:20 | |
| *** doron_afk is now known as doron | 15:20 | |
| *** lexinator has joined #openstack-dev | 15:21 | |
| *** afazekas_ has quit IRC | 15:22 | |
| *** markmcclain has joined #openstack-dev | 15:24 | |
| *** briancurtin has joined #openstack-dev | 15:24 | |
| *** terryw has quit IRC | 15:26 | |
| *** bashok has quit IRC | 15:27 | |
| *** tkammer has quit IRC | 15:27 | |
| *** ifarkas has quit IRC | 15:27 | |
| *** CaptTofu has quit IRC | 15:28 | |
| *** CaptTofu has joined #openstack-dev | 15:29 | |
| *** kushal has joined #openstack-dev | 15:29 | |
| *** carl_baldwin has joined #openstack-dev | 15:29 | |
| *** rackerjoe has left #openstack-dev | 15:31 | |
| *** CaptTofu_ has joined #openstack-dev | 15:31 | |
| *** CaptTofu has quit IRC | 15:31 | |
| *** marun has joined #openstack-dev | 15:32 | |
| *** vartom7 has quit IRC | 15:33 | |
| *** salv-orlando has joined #openstack-dev | 15:34 | |
| *** basha has joined #openstack-dev | 15:34 | |
| *** fabio__ has joined #openstack-dev | 15:34 | |
| *** jpich has quit IRC | 15:34 | |
| *** lexinator has quit IRC | 15:35 | |
| *** alunduil has quit IRC | 15:36 | |
| *** _TheDodd_ has joined #openstack-dev | 15:36 | |
| *** doron is now known as doron_afk | 15:37 | |
| *** yaguang has joined #openstack-dev | 15:38 | |
| *** rnirmal has quit IRC | 15:39 | |
| *** hemna has joined #openstack-dev | 15:41 | |
| *** Ruetobas has joined #openstack-dev | 15:41 | |
| *** rnirmal has joined #openstack-dev | 15:41 | |
| *** jbresnah has quit IRC | 15:43 | |
| *** alop has quit IRC | 15:43 | |
| *** bcrochet has quit IRC | 15:44 | |
| *** giroro_ has joined #openstack-dev | 15:44 | |
| *** Ruetobas has quit IRC | 15:45 | |
| *** sandeepr_ltp has joined #openstack-dev | 15:46 | |
| *** shang has quit IRC | 15:47 | |
| *** jswarren has quit IRC | 15:48 | |
| *** shang_ has quit IRC | 15:48 | |
| *** jcoufal has quit IRC | 15:50 | |
| *** zul has quit IRC | 15:50 | |
| *** bcrochet has joined #openstack-dev | 15:52 | |
| *** sarob has joined #openstack-dev | 15:54 | |
| *** bdpayne has joined #openstack-dev | 15:54 | |
| *** salv-orlando has quit IRC | 15:54 | |
| *** tonix has joined #openstack-dev | 15:54 | |
| *** Guest92507 has quit IRC | 15:54 | |
| *** yaguang has quit IRC | 15:55 | |
| branen_ | Hi guys, I'm also trying to get this global requirement approved. https://review.openstack.org/#/c/42991/ Any help would be greatly appreciated. | 15:55 |
| *** sarob_ has joined #openstack-dev | 15:55 | |
| *** lexinator has joined #openstack-dev | 15:55 | |
| jaypipes | sandywalsh, jd__, dhellmann_: I think we need to have a chat about the marker/limit implementation in the MongoDB driver in Ceilo... see my latest comments on the patches from Fenqqian... | 15:55 |
| *** iartarisi has quit IRC | 15:56 | |
| sandywalsh | jaypipes, sure thing, how best? | 15:57 |
| sandywalsh | (reading) | 15:57 |
| *** sarob has quit IRC | 15:58 | |
| *** sarob_ has quit IRC | 15:59 | |
| sandywalsh | jaypipes, btw> my alembic tests fail in a similar way for a branch I'm working on | 15:59 |
| *** sarob has joined #openstack-dev | 15:59 | |
| jaypipes | sandywalsh: yeah, on alembic, I need to read up more on it... first time I've used it. | 15:59 |
| sandywalsh | me too | 15:59 |
| *** devoid has joined #openstack-dev | 16:00 | |
| sandywalsh | jaypipes, I don't see your comments anywhere? link? | 16:00 |
| jaypipes | sandywalsh: I have some calls to do this early afternoon. How about a hangout session late in the day? Maybe 4pm EST>? | 16:00 |
| jaypipes | sandywalsh: https://review.openstack.org/#/c/41869/ and https://review.openstack.org/#/c/42582/4 | 16:00 |
| *** xmltok has joined #openstack-dev | 16:00 | |
| jaypipes | sandywalsh: do you know Mehdi's IRC nick? | 16:01 |
| sandywalsh | jaypipes, works for me. Don't have mehdi's nick, sorry. | 16:02 |
| jaypipes | no worries. | 16:02 |
| *** alexb_ has joined #openstack-dev | 16:03 | |
| *** basha has quit IRC | 16:03 | |
| *** nati_ueno_2 has joined #openstack-dev | 16:03 | |
| gordc | jaypipes: sandywalsh: Mehdi's nick -> sileht | 16:03 |
| jaypipes | ah, thx! | 16:03 |
| jaypipes | sileht: hey :) | 16:03 |
| sileht | jaypipes, o/ | 16:03 |
| jaypipes | sileht: what's your time zone? eastern europe? | 16:04 |
| jaypipes | or western? | 16:04 |
| sileht | jaypipes, central :D | 16:05 |
| *** bmqq123 is now known as yjiang5 | 16:05 | |
| sileht | jaypipes, I live in france | 16:05 |
| jaypipes | sileht: k. GMT+1? | 16:05 |
| sileht | Western | 16:05 |
| sileht | jaypipes, yes | 16:05 |
| jaypipes | got it. | 16:05 |
| jaypipes | sileht: trying to figure out a time that works for a G+ hangout on the pagination stuff in CM | 16:06 |
| sileht | jaypipes, ok | 16:06 |
| *** nati_ueno has quit IRC | 16:06 | |
| *** jistr has quit IRC | 16:06 | |
| jaypipes | sileht: sandy and I are in east coast US and doug is in west coast US. you and Julien are GMT +1. | 16:06 |
| * jaypipes wonders what Fenqqian's TZ is... | 16:07 | |
| *** dina_belova has joined #openstack-dev | 16:08 | |
| *** insanidade has joined #openstack-dev | 16:08 | |
| *** zbitter has joined #openstack-dev | 16:09 | |
| *** wfoster is now known as wfoster_away | 16:12 | |
| *** xmltok has quit IRC | 16:12 | |
| *** zaneb has quit IRC | 16:12 | |
| *** xmltok has joined #openstack-dev | 16:12 | |
| *** colinmcnamara has joined #openstack-dev | 16:12 | |
| *** dina_belova has quit IRC | 16:13 | |
| *** terryw has joined #openstack-dev | 16:13 | |
| *** alop has joined #openstack-dev | 16:14 | |
| *** litong has quit IRC | 16:14 | |
| sandywalsh | jaypipes, this is why I thought the current approach was ok https://github.com/openstack/ceilometer/blob/master/ceilometer/openstack/common/db/sqlalchemy/utils.py#L54 | 16:15 |
| *** mikal has quit IRC | 16:17 | |
| sandywalsh | jaypipes, so now I'm second guessing why there is a query.limit(1) query being done on the markers in the first place ... still looking | 16:17 |
| sandywalsh | jaypipes, line 264 in the branch https://review.openstack.org/#/c/35454/30/ceilometer/storage/impl_sqlalchemy.py | 16:18 |
| *** zul has joined #openstack-dev | 16:18 | |
| * sandywalsh noms ... bbiab | 16:18 | |
| *** mikal has joined #openstack-dev | 16:18 | |
| *** giulivo has quit IRC | 16:19 | |
| *** ruhe has quit IRC | 16:20 | |
| *** jbresnah has joined #openstack-dev | 16:20 | |
| insanidade | hi, all. Is there some sort of "cookbook" for plugin development ? | 16:21 |
| *** hartsocks has joined #openstack-dev | 16:21 | |
| *** alexb_ has quit IRC | 16:22 | |
| *** JordanP has quit IRC | 16:23 | |
| *** mlavalle has joined #openstack-dev | 16:25 | |
| *** alop has quit IRC | 16:25 | |
| *** ruhe has joined #openstack-dev | 16:26 | |
| *** martine has joined #openstack-dev | 16:26 | |
| *** ruhe has quit IRC | 16:26 | |
| *** martine is now known as Guest67901 | 16:26 | |
| *** Dr_Who has joined #openstack-dev | 16:26 | |
| *** Max_ has quit IRC | 16:27 | |
| *** reed has joined #openstack-dev | 16:27 | |
| *** doron_afk has quit IRC | 16:27 | |
| *** corXi has quit IRC | 16:28 | |
| *** alop has joined #openstack-dev | 16:28 | |
| *** briancurtin has left #openstack-dev | 16:28 | |
| *** nati_ueno_2 has quit IRC | 16:29 | |
| *** markwash has joined #openstack-dev | 16:29 | |
| *** nati_ueno has joined #openstack-dev | 16:29 | |
| *** xga has quit IRC | 16:29 | |
| *** dolphm has quit IRC | 16:30 | |
| *** xqueralt is now known as xqueralt-afk | 16:31 | |
| *** zbitter is now known as zaneb | 16:31 | |
| *** moted has quit IRC | 16:32 | |
| *** moted has joined #openstack-dev | 16:33 | |
| *** ndipanov is now known as ndipanov_gone | 16:34 | |
| *** noslzzp is now known as noslzzp_lunch | 16:36 | |
| *** diogogmt has joined #openstack-dev | 16:36 | |
| *** nshaikh has left #openstack-dev | 16:38 | |
| *** kushal has quit IRC | 16:39 | |
| *** bill has joined #openstack-dev | 16:39 | |
| *** markmcclain has left #openstack-dev | 16:39 | |
| *** markmcclain has joined #openstack-dev | 16:39 | |
| *** bill is now known as Guest79474 | 16:40 | |
| *** SumitNaiksatam has quit IRC | 16:40 | |
| markwash | jeblair: mordred: what can I do to get http://docs.openstack.org/developer/python-glanceclient/ to reflect the latest release? | 16:40 |
| *** boris-42 has joined #openstack-dev | 16:41 | |
| *** sarob has quit IRC | 16:41 | |
| jeblair | annegentle: ^ | 16:41 |
| jeblair | markwash: looking | 16:41 |
| *** dina_belova has joined #openstack-dev | 16:42 | |
| *** venkatesh has joined #openstack-dev | 16:42 | |
| *** sarob has joined #openstack-dev | 16:42 | |
| *** SergeyLukjanov has quit IRC | 16:43 | |
| *** dina_belova has quit IRC | 16:43 | |
| jeblair | markwash: biab, sorry | 16:44 |
| *** feleouet has quit IRC | 16:44 | |
| jaypipes | insanidade: what kind of plugin? Neutron? Horizon? Nova? | 16:44 |
| markwash | jeblair: no worries | 16:44 |
| *** fabio has quit IRC | 16:44 | |
| insanidade | jaypipes: Neutron. I have Openstack installed through devstack and I just noticed it did not install neutron. Is that expected ? | 16:45 |
| *** SergeyLukjanov has joined #openstack-dev | 16:45 | |
| *** fabio has joined #openstack-dev | 16:45 | |
| jaypipes | insanidade: I am not sure, sorry... | 16:46 |
| jaypipes | dtroyer: is neutron installed by default with devstack now? | 16:46 |
| *** terriyu has joined #openstack-dev | 16:47 | |
| *** fbo is now known as fbo_away | 16:47 | |
| jaypipes | insanidade: as for Neutron plugin development, prolly good idea to email the openstack-dev mailing list with "[Neutron] Plugin developer resources needed" subject line. | 16:49 |
| *** sandeepr_ltp has quit IRC | 16:49 | |
| dtroyer | jaypipes: no | 16:49 |
| *** drewland_ is now known as drewlander_ | 16:52 | |
| *** SergeyLukjanov has quit IRC | 16:52 | |
| jaypipes | dtroyer: ok, thx. I presume added SERVICES+="neutron" will install then? | 16:52 |
| insanidade | jaypipes: hmmm. I'll try that. I'm still trying it on my own, based on the docs available. | 16:53 |
| dtroyer | jaypipes: no, you need the individual service names: | 16:53 |
| dtroyer | disable_service n-net | 16:53 |
| dtroyer | enable_service q-svc q-agt q-dhcp q-l3 q-meta | 16:53 |
| clarkb | markwash: jeblair: it should do the latest release automagically if the jenkins jobs are working properly | 16:53 |
| jaypipes | insanidade: ^^ | 16:53 |
| jaypipes | dtroyer: ty sir! | 16:53 |
| insanidade | jaypipes: hmm, that works for heat. Not sure aboute neutron. | 16:54 |
| jeblair | clarkb, markwash: yeah, i'm looking into why it's not working | 16:54 |
| jaypipes | insanidade: see what dtroyer just said. | 16:54 |
| *** markmcclain has quit IRC | 16:55 | |
| *** alexb_ has joined #openstack-dev | 16:55 | |
| insanidade | jaypipes: I saw :) Looks like I'll need the support from people more skilled in networking :) | 16:55 |
| clarkb | jeblair: I think the sort -n in the docs job is wrong | 16:56 |
| clarkb | we need a sort -semver | 16:56 |
| jeblair | clarkb: i agree | 16:57 |
| * lsmola is away: Away | 16:57 | |
| *** lexinator has quit IRC | 16:57 | |
| *** derekh has quit IRC | 16:57 | |
| insanidade | dtroyer: what are those names? Are those service names ? | 16:58 |
| *** freedomhui has quit IRC | 16:59 | |
| jeblair | clarkb: i think 'sort -V' may work | 16:59 |
| clarkb | jeblair: it does for this particular case at least | 17:00 |
| dtroyer | insanidade: they're actually the name of the screen window but in devstack that's how we refer to the individual services. look in lib/neutron and search for 'screen_it' to find the actual commands that run in each window | 17:00 |
| *** galstrom_zzz is now known as galstrom | 17:00 | |
| *** SumitNaiksatam has joined #openstack-dev | 17:00 | |
| jeblair | clarkb: it should work for this and the date-based versions | 17:01 |
| *** lexinator has joined #openstack-dev | 17:02 | |
| jeblair | clarkb: is there documentation on the alpha format mordred wants to move some things to? | 17:02 |
| jeblair | clarkb: i guess the zuul regex is a form of documentation | 17:02 |
| clarkb | jeblair: yeah | 17:02 |
| *** romcheg has left #openstack-dev | 17:03 | |
| *** alop_ has joined #openstack-dev | 17:03 | |
| *** sarob has quit IRC | 17:03 | |
| jeblair | clarkb: well, currently the release regex is only numeric, so i think we're actually good, but i'll look at the pre-release too because i'm curious | 17:03 |
| *** vkmc_ has joined #openstack-dev | 17:03 | |
| clarkb | sounds good | 17:03 |
| clarkb | at the very least this will make the clients happy again until mordred can sort out what he wants to do with the fancy versioning | 17:04 |
| *** markmcclain has joined #openstack-dev | 17:04 | |
| *** sarob has joined #openstack-dev | 17:04 | |
| *** alop has quit IRC | 17:05 | |
| *** alop_ has quit IRC | 17:05 | |
| insanidade | dtroyer: hmm. I unserstand the screen windows and the services I can monitor there. But the point is that looks like I don't have the lib/neutron folder. I think that I have to install neutron before anything. | 17:05 |
| *** neelashah has quit IRC | 17:05 | |
| dtroyer | insanidade: lib/neutron is part of DevStack. | 17:05 |
| dtroyer | it's the bit that does all of the neutron installation and configuration | 17:06 |
| *** vkmc has quit IRC | 17:06 | |
| *** sdake has joined #openstack-dev | 17:07 | |
| jeblair | clarkb: it's naive, so it will sort 1.0a after 1.0. so it won't work with pre-release version tags in the mix. | 17:07 |
| insanidade | dtroyer: ops. sorry. yeah, I found it. | 17:07 |
| jeblair | clarkb: however, for the purposes of this script a tag with a letter in it should never be regarded as LATEST | 17:07 |
| jeblair | clarkb: so we could filter those out | 17:07 |
| *** alop has joined #openstack-dev | 17:07 | |
| clarkb | jeblair: I believe they are already filtered out | 17:07 |
| *** alexb_ has quit IRC | 17:07 | |
| clarkb | jeblair: the sed before the sort is only looking for digits | 17:08 |
| *** Ryan_Lane has joined #openstack-dev | 17:08 | |
| jeblair | clarkb: you are correct | 17:08 |
| jeblair | clarkb: so i think we can s/sort -n/sort -V/ in the script and we should be ok | 17:08 |
| clarkb | ++ | 17:08 |
| jeblair | in progress | 17:08 |
| *** sarob_ has joined #openstack-dev | 17:09 | |
| *** maheshp has quit IRC | 17:10 | |
| *** lucasagomes has quit IRC | 17:10 | |
| insanidade | dtroyer: hmm. I see what you meant. the q-vpn service shall also be screened, according to lib/neutron. | 17:10 |
| *** dina_belova has joined #openstack-dev | 17:12 | |
| dtroyer | insanidade: only if it is enabled (ie, listed in $ENABLED_SERVICES). the screen_it() function also does the is_service_enabled check so there is some redundancy present too | 17:12 |
| jeblair | markwash: https://review.openstack.org/43739 we merge that and then we can retrigger that job manually and publish the correct version | 17:12 |
| jeblair | annegentle: ^ | 17:12 |
| clarkb | jeblair: it looks good to me. merge at will | 17:14 |
| *** sarob has quit IRC | 17:15 | |
| markwash | jeblair: thanks, works when I tried out the shell change | 17:16 |
| *** sandywalsh has quit IRC | 17:16 | |
| insanidade | dtroyer: is the .stackenv the right place to set the ENABLED_SERVICES variable? | 17:17 |
| dtroyer | insanidade: no, .stackenv that gets deleted and re-written every time stack.sh runs. localrc is where you want to put your configurations. See https://wiki.openstack.org/wiki/NeutronDevstack for specifics on Neutron. | 17:20 |
| dtroyer | except ading 'enable_service neutron' to locarc is unnecessary and perpetuates confusion... | 17:21 |
| *** SergeyLukjanov has joined #openstack-dev | 17:22 | |
| *** gimps_ has quit IRC | 17:22 | |
| *** colinmcnamara has quit IRC | 17:22 | |
| *** dolphm has joined #openstack-dev | 17:28 | |
| *** colinmcnamara has joined #openstack-dev | 17:30 | |
| *** sarob_ has quit IRC | 17:30 | |
| *** sarob has joined #openstack-dev | 17:31 | |
| *** jfriedly has joined #openstack-dev | 17:31 | |
| *** ruhe has joined #openstack-dev | 17:32 | |
| *** bashok has joined #openstack-dev | 17:32 | |
| *** mlavalle has quit IRC | 17:32 | |
| *** sandywalsh has joined #openstack-dev | 17:32 | |
| *** sarob_ has joined #openstack-dev | 17:34 | |
| *** rfolco has quit IRC | 17:34 | |
| *** fabio__ has quit IRC | 17:34 | |
| *** sarob has quit IRC | 17:35 | |
| *** comay has joined #openstack-dev | 17:37 | |
| *** sandywalsh has quit IRC | 17:38 | |
| harlowja | sandywalsh yt | 17:38 |
| *** tonix has quit IRC | 17:38 | |
| *** Dr_Who has quit IRC | 17:41 | |
| *** neelashah has joined #openstack-dev | 17:41 | |
| *** dprince has quit IRC | 17:45 | |
| dolphm | is voting on summit presentations closed? http://www.openstack.org/rate/ is 301'ing back to the homepage | 17:45 |
| *** vipul is now known as vipul-away | 17:46 | |
| dolphm | nvm, voting closed yesterday! | 17:46 |
| *** jsavak has joined #openstack-dev | 17:46 | |
| *** joesavak has quit IRC | 17:46 | |
| *** burt has quit IRC | 17:46 | |
| *** sarob_ has quit IRC | 17:47 | |
| *** sarob has joined #openstack-dev | 17:47 | |
| *** sdake_ has joined #openstack-dev | 17:47 | |
| *** sdake_ has quit IRC | 17:47 | |
| *** sdake_ has joined #openstack-dev | 17:47 | |
| *** hartsocks has left #openstack-dev | 17:47 | |
| *** sandywalsh has joined #openstack-dev | 17:51 | |
| *** Shaan7 has quit IRC | 17:52 | |
| *** lexinator1 has joined #openstack-dev | 17:54 | |
| *** colinmcnamara has quit IRC | 17:54 | |
| *** colinmcnamara has joined #openstack-dev | 17:55 | |
| *** lexinator has quit IRC | 17:55 | |
| *** maheshp has joined #openstack-dev | 17:56 | |
| *** dims has joined #openstack-dev | 17:58 | |
| *** jprovazn has joined #openstack-dev | 17:59 | |
| *** ffio has quit IRC | 18:01 | |
| *** sarob has quit IRC | 18:02 | |
| *** sarob has joined #openstack-dev | 18:03 | |
| *** nunosantos has quit IRC | 18:04 | |
| *** morganfainberg|a has quit IRC | 18:04 | |
| *** vipul-away is now known as vipul | 18:04 | |
| *** ssurana has joined #openstack-dev | 18:05 | |
| *** morganfainberg|a has joined #openstack-dev | 18:05 | |
| *** morganfainberg|a is now known as morganfainberg | 18:06 | |
| *** networkstatic_ has joined #openstack-dev | 18:06 | |
| fabio | morganfainberg, good mornin | 18:06 |
| fabio | morganfainberg, please have a look at the latest patch. it should address your concern | 18:07 |
| *** sarob has quit IRC | 18:07 | |
| fabio | morganfainberg, #link https://review.openstack.org/#/c/33118/30 | 18:07 |
| *** hartsocks has joined #openstack-dev | 18:09 | |
| *** ruhe has quit IRC | 18:10 | |
| *** networkstatic has quit IRC | 18:10 | |
| *** networkstatic_ is now known as networkstatic | 18:10 | |
| *** sdake_ has quit IRC | 18:10 | |
| *** melwitt has joined #openstack-dev | 18:13 | |
| *** basha has joined #openstack-dev | 18:14 | |
| *** litong has joined #openstack-dev | 18:16 | |
| *** jtomasek has quit IRC | 18:16 | |
| *** basha has quit IRC | 18:16 | |
| *** bknudson has joined #openstack-dev | 18:17 | |
| *** salv-orlando has joined #openstack-dev | 18:19 | |
| *** ffio has joined #openstack-dev | 18:19 | |
| *** openf|y is now known as openfly | 18:20 | |
| *** Mandell has joined #openstack-dev | 18:20 | |
| *** dkehn has quit IRC | 18:21 | |
| *** bknudson has quit IRC | 18:23 | |
| *** dkehn has joined #openstack-dev | 18:24 | |
| *** noslzzp_lunch is now known as noslzzp | 18:24 | |
| *** Dr_Who has joined #openstack-dev | 18:25 | |
| *** jasdeepH has joined #openstack-dev | 18:26 | |
| *** bknudson has joined #openstack-dev | 18:28 | |
| *** zul has quit IRC | 18:31 | |
| *** vkmc_ has quit IRC | 18:32 | |
| *** ffio has quit IRC | 18:34 | |
| *** colinmcnamara has quit IRC | 18:34 | |
| *** alexb_ has joined #openstack-dev | 18:36 | |
| jeblair | markwash: i don't think you tagged the right commit with 0.11.0 | 18:38 |
| jeblair | markwash: the tag is on a1c5305c6264105794b70b248fb87f8ac89ecb41 which is not in master | 18:39 |
| *** dprince has joined #openstack-dev | 18:39 | |
| *** Dr_Who has quit IRC | 18:39 | |
| jeblair | markwash: (i think the correct commit is b15c57c4a2cd7566072fcf8adb1422cb3e21b1de which is identical; i suspect you may have tagged something on a local branch) | 18:40 |
| *** jcoufal has joined #openstack-dev | 18:43 | |
| *** ondergetekende_ has joined #openstack-dev | 18:44 | |
| *** d34dh0r53 has quit IRC | 18:45 | |
| *** hartsocks has left #openstack-dev | 18:46 | |
| *** lucasagomes has joined #openstack-dev | 18:47 | |
| *** romcheg has joined #openstack-dev | 18:50 | |
| dragondm | Anyone on openstack/requirements mind taking a gander at: https://review.openstack.org/#/c/43503/ ? | 18:54 |
| *** edmund has joined #openstack-dev | 18:54 | |
| *** hartsocks has joined #openstack-dev | 18:54 | |
| *** terryw has quit IRC | 18:55 | |
| *** hartsocks has left #openstack-dev | 18:55 | |
| dragondm | (it was hung up on the testr/subunit bug shennanigans over the weekend.) | 18:55 |
| *** xBsd has joined #openstack-dev | 18:55 | |
| *** Guest67901 has quit IRC | 18:56 | |
| *** rfolco has joined #openstack-dev | 18:56 | |
| *** eglynn has quit IRC | 18:57 | |
| *** kbringard has quit IRC | 18:57 | |
| *** martine has joined #openstack-dev | 18:57 | |
| *** martine is now known as Guest27379 | 18:58 | |
| *** burt has joined #openstack-dev | 18:58 | |
| *** briancurtin has joined #openstack-dev | 18:58 | |
| *** egallen has quit IRC | 19:00 | |
| *** novas0x2a|laptop has joined #openstack-dev | 19:00 | |
| *** chandankumar has quit IRC | 19:02 | |
| *** vipul is now known as vipul-away | 19:02 | |
| *** nati_ueno has quit IRC | 19:09 | |
| *** nati_ueno has joined #openstack-dev | 19:09 | |
| *** terryw has joined #openstack-dev | 19:10 | |
| *** colinmcnamara has joined #openstack-dev | 19:11 | |
| *** sarob has joined #openstack-dev | 19:11 | |
| *** sarob has quit IRC | 19:12 | |
| *** sarob has joined #openstack-dev | 19:13 | |
| *** vipul-away is now known as vipul | 19:13 | |
| *** nati_ueno has quit IRC | 19:14 | |
| *** sarob has quit IRC | 19:17 | |
| *** flaper87 is now known as flaper87|afk | 19:17 | |
| *** openf|y has joined #openstack-dev | 19:18 | |
| *** nati_ueno has joined #openstack-dev | 19:19 | |
| *** iccha has quit IRC | 19:20 | |
| *** briancurtin has left #openstack-dev | 19:20 | |
| *** markmcclain has quit IRC | 19:21 | |
| *** sdake_ has joined #openstack-dev | 19:22 | |
| *** sdake_ has quit IRC | 19:22 | |
| *** sdake_ has joined #openstack-dev | 19:22 | |
| *** colinmcnamara has quit IRC | 19:22 | |
| *** hartsocks1 has joined #openstack-dev | 19:23 | |
| *** nati_ueno has quit IRC | 19:23 | |
| *** nati_ueno has joined #openstack-dev | 19:24 | |
| *** fbo_away is now known as fbo | 19:25 | |
| *** nati_ueno_2 has joined #openstack-dev | 19:26 | |
| *** nati_ueno has quit IRC | 19:27 | |
| *** kbringard has joined #openstack-dev | 19:27 | |
| *** sarob has joined #openstack-dev | 19:27 | |
| *** mrodden has quit IRC | 19:28 | |
| *** mrodden has joined #openstack-dev | 19:28 | |
| *** nati_ueno_2 has quit IRC | 19:31 | |
| *** nati_ueno has joined #openstack-dev | 19:31 | |
| *** iccha has joined #openstack-dev | 19:32 | |
| *** iccha has quit IRC | 19:32 | |
| *** iccha has joined #openstack-dev | 19:32 | |
| *** iccha has quit IRC | 19:34 | |
| *** iccha has joined #openstack-dev | 19:34 | |
| morganfainberg | fabio: Nice. | 19:34 |
| *** flaper87|afk is now known as flaper87 | 19:35 | |
| *** nachi has joined #openstack-dev | 19:35 | |
| *** nati_ueno has quit IRC | 19:35 | |
| *** hartsocks1 has quit IRC | 19:35 | |
| stevemar | morganfainberg: just looked over endpoints? | 19:36 |
| morganfainberg | stevemar: look over it yesterday, found a flaw in the catalog driver, fabio already fixed it. | 19:37 |
| morganfainberg | stevemar: s/look/looked | 19:37 |
| *** d34dh0r53 has joined #openstack-dev | 19:37 | |
| *** SergeyLukjanov has quit IRC | 19:38 | |
| *** afazekas has joined #openstack-dev | 19:39 | |
| *** vkmc has joined #openstack-dev | 19:39 | |
| *** vkmc has quit IRC | 19:39 | |
| *** vkmc has joined #openstack-dev | 19:39 | |
| *** d34dh0r53 has quit IRC | 19:39 | |
| *** esheffield has joined #openstack-dev | 19:39 | |
| fabio | morganfainberg, is the path good to go? | 19:39 |
| morganfainberg | fabio: looking now. | 19:40 |
| fabio | I think I need to get in by eod tomorrow | 19:40 |
| fabio | tanks | 19:40 |
| fabio | thanks | 19:40 |
| morganfainberg | fabio: i've been trying to be responsive to make sure you get feedback if needed since we're all racing to get things in. | 19:41 |
| *** danwent has joined #openstack-dev | 19:41 | |
| morganfainberg | fabio: do we have a test that verifies that a filtered catalog can be generated? | 19:41 |
| fabio | morganfainberg, yes, it checks there is only 1 endpoint | 19:42 |
| morganfainberg | fabio: hm. | 19:42 |
| *** colinmcnamara has joined #openstack-dev | 19:42 | |
| *** radez is now known as radez_g0n3 | 19:43 | |
| *** danwent has quit IRC | 19:43 | |
| morganfainberg | fabio: i think it's not working as expected. | 19:43 |
| fabio | morganfainberg, it associates 1 endpoint with the project and then requests the token | 19:43 |
| morganfainberg | fabio: "self.endpoint_filter_api.list_endpoints_in_project(project_id)" shouldn't that be using "list_endpoints_for_project"? | 19:43 |
| morganfainberg | in the catalog driver | 19:43 |
| morganfainberg | line 35 | 19:44 |
| openf|y | does anyone know if the docker driver is going to land for havana? | 19:44 |
| morganfainberg | fabio: it looks liek that should raise a NameError if that catalog driver was used. | 19:45 |
| *** nati_ueno has joined #openstack-dev | 19:46 | |
| fabio | morganfainberg, you are right | 19:47 |
| fabio | someone asked to change the name and I didn't propagate it .. | 19:47 |
| fabio | I'll fix it now | 19:47 |
| morganfainberg | fabio: i think that means we also need a test case to generate (at least once) a filtered and unfiltered catalog with that driver. | 19:47 |
| *** nati_ueno has quit IRC | 19:47 | |
| morganfainberg | fabio: thats the only thing that is standing out as an issue to my eyes atm (the name error, and missing test). | 19:48 |
| *** nati_ueno has joined #openstack-dev | 19:48 | |
| morganfainberg | fabio: but you've really hit everything else i've seen commented on. :) | 19:48 |
| fabio | morganfainberg, I have the tests in place | 19:48 |
| morganfainberg | fabio: using that driver? the test may not be working as expected then, because it shouldn't have passed. | 19:49 |
| fabio | please look at the test_associate_project_endpoints | 19:49 |
| morganfainberg | the catalog driver itself? | 19:49 |
| morganfainberg | looking | 19:49 |
| fabio | morganfainberg, probably there is something wrong in the test as well | 19:49 |
| morganfainberg | fabio: ah, yes i see the tests | 19:50 |
| *** salv-orlando_ has joined #openstack-dev | 19:51 | |
| fabio | morganfainberg, I even did the test to evaluate the case when an endpoint is deleted after the association has been made | 19:51 |
| morganfainberg | fabio: nice. | 19:51 |
| *** salv-orlando has quit IRC | 19:51 | |
| *** salv-orlando_ is now known as salv-orlando | 19:51 | |
| morganfainberg | fabio: yeah looking to see what might be causing your test to not use the right driver. | 19:51 |
| morganfainberg | fabio: ah, i think you're not loading an overrides config using your catalog driver. you're loading the correct paste ini, but not something that sets [catalog] driver= <your new driver> | 19:52 |
| *** nati_ueno has quit IRC | 19:52 | |
| fabio | morganfainberg, is there a reference impl. that I can look at to do that, please? | 19:54 |
| morganfainberg | fabio: looking for one right now for you | 19:55 |
| fabio | morganfainberg, I guess the IdentityInheritanceTestCase in test_v3_identity should do it | 19:56 |
| fabio | agree? | 19:56 |
| morganfainberg | fabio: https://github.com/openstack/keystone/blob/master/keystone/tests/test_v3_auth.py#L337 | 19:56 |
| morganfainberg | fabio: yes that one should work as well. | 19:56 |
| *** nunosantos has joined #openstack-dev | 19:57 | |
| fabio | morganfainberg, thanks a lot for your help, I'll ping it when the new patch is up | 19:57 |
| morganfainberg | fabio: no problem. glad to help. | 19:57 |
| *** armax has joined #openstack-dev | 19:57 | |
| *** mlavalle has joined #openstack-dev | 19:57 | |
| *** harlowja has quit IRC | 19:59 | |
| *** harlowja has joined #openstack-dev | 20:00 | |
| *** terryw has quit IRC | 20:03 | |
| *** xBsd has quit IRC | 20:04 | |
| *** maheshp has quit IRC | 20:05 | |
| *** egallen has joined #openstack-dev | 20:05 | |
| *** mgius has joined #openstack-dev | 20:06 | |
| *** vipul is now known as vipul-away | 20:06 | |
| *** mgius has left #openstack-dev | 20:06 | |
| insanidade | so...if I reboot my machine where devstack is running, I have to run stack.sh again, right ? | 20:07 |
| morganfainberg | insanidade: stack.sh if you want to rebuild everything (db etc) to a clean state, rejoin-stack.sh if you just want to restart the devstack | 20:09 |
| morganfainberg | in it's current state. | 20:09 |
| *** alop has quit IRC | 20:10 | |
| *** lucasagomes has quit IRC | 20:13 | |
| insanidade | nice, morganfainberg. thanks. | 20:13 |
| morganfainberg | insanidade: sure thing. | 20:13 |
| *** radez_g0n3 is now known as radez | 20:14 | |
| *** venkatesh has quit IRC | 20:17 | |
| henrynash | dolphm: ping | 20:18 |
| dolphm | henrynash: pong | 20:18 |
| henrynash | dolphm: regarding https://review.openstack.org/#/c/43257/ | 20:18 |
| *** cdub has quit IRC | 20:19 | |
| *** cdub has joined #openstack-dev | 20:19 | |
| henrynash | dolphm: suggestion from ayoung is that we should disable (until IceHouse) the inexact filter support (e.g. name__startswitch) due to the fact that this is an API change (which is absolutely true) | 20:19 |
| *** jprovazn has quit IRC | 20:20 | |
| henrynash | dolphm: do you agree, or when you suggested this, were you planning to push it into Havana? | 20:20 |
| dolphm | henrynash: erm, his suggestion is to 'remove' not to 'disable'... | 20:20 |
| henrynash | dolphm: so I wrote it so that it's a one line change to disable (in utils)…so rather not actually remove it unless absolutely necesary | 20:21 |
| *** radsy has joined #openstack-dev | 20:22 | |
| *** alop has joined #openstack-dev | 20:22 | |
| dolphm | henrynash: the API certainly needs to have time to bake | 20:23 |
| henrynash | dolphm: so I'm fine with disabling the inexact stuff, so it is just the regular filtering that will function in Havana | 20:23 |
| dolphm | henrynash: i'd split the review into inner workings and api exposure -- we can merge the api exposure in icehouse | 20:24 |
| *** salv-orlando has quit IRC | 20:24 | |
| henrynash | dolphm: ok, that's fine…I'll create an api p and target for icehouse | 20:24 |
| henrynash | (api bp) | 20:24 |
| *** pasquier-s has quit IRC | 20:24 | |
| morganfainberg | henrynash: since you're rolling a new change set on the filtering patchset, line 797 of keystone.identity.contnrollers looks like it still calls list_roles() unfiltered after the filtered call, saves you a patchset | 20:25 |
| morganfainberg | erm review changeset. | 20:25 |
| dolphm | henrynash: is there already an identity-api review up? | 20:25 |
| henrynash | morganfainberg: great, thx | 20:25 |
| henrynash | dolphm: no (and it would only be needed for the inexact stuff) | 20:25 |
| henrynash | dolphm: the rest is just allowing drivers to implement the filters that the controller already does | 20:26 |
| dolphm | henrynash: have you thought about client impl? | 20:26 |
| henrynash | dolphm: for the inexact? | 20:27 |
| *** romcheg has quit IRC | 20:27 | |
| dolphm | henrynash: yeah, supporting stuff like c.users.list(name__starts_with='Stev') | 20:27 |
| *** esheffield has quit IRC | 20:27 | |
| dolphm | name__startswith* | 20:27 |
| henrynash | dolphm: have to admit, I have not as yet | 20:28 |
| *** esheffield has joined #openstack-dev | 20:28 | |
| henrynash | dolphm: was doing server/REST first, then client | 20:28 |
| dolphm | henrynash: i was just curious | 20:29 |
| stevemar | glad my name is useful for your examples dolphm | 20:30 |
| *** nati_ueno has joined #openstack-dev | 20:30 | |
| dolphm | stevemar: it was the first one that came to mind as potentially ambiguous | 20:30 |
| stevemar | Henr...ietta | 20:30 |
| dolphm | stevemar: obviously* self-documenting as potentially ambiguous | 20:31 |
| stevemar | excellent | 20:31 |
| henrynash | morganfainberg: nice catch…I do call get_roles() with the right query info….but then call it again without it!!!! cut and paste error!! | 20:31 |
| morganfainberg | yep:) | 20:32 |
| morganfainberg | dolphm: do we care about python3k compatability stuff yet, or not really? | 20:32 |
| dolphm | morganfainberg: https://jenkins.openstack.org/view/All/job/gate-keystone-python33/ | 20:34 |
| ayoung | dolphm, I also suggested that henrynash split the SQL and the LDAP filtering. Different people are qualified to review SQL issues than LDAP issues... | 20:34 |
| henrynash | ayoung: and I'm totally happy with that | 20:34 |
| dolphm | morganfainberg: s/care/have a running gate job/ | 20:34 |
| morganfainberg | dolphm: thanks :) | 20:35 |
| *** nati_ueno has quit IRC | 20:35 | |
| dolphm | morganfainberg: i'd just say that we're on our way towards being gated by py33, so don't do anything to make that more difficult :P | 20:36 |
| morganfainberg | dolphm: i noticed something that was blatantly not py3k compativle in a review | 20:36 |
| *** pasquier-s has joined #openstack-dev | 20:37 | |
| *** vipul-away is now known as vipul | 20:37 | |
| dolphm | morganfainberg: never too soon to start edumacating people on python 3 compat | 20:37 |
| morganfainberg | dolphm: works for me. | 20:38 |
| dolphm | who wants to document policy.json? | 20:38 |
| dolphm | like for real inline docs | 20:38 |
| * stevemar watches tumbleweed go by | 20:38 | |
| morganfainberg | dolphm: can i voluntell stevemar? he commented first :P >.> | 20:39 |
| dolphm | lol | 20:39 |
| stevemar | but i'm all kinds of busy, with stuff | 20:40 |
| morganfainberg | dolphm: you are looking for docs on what actually happens in the policy.json? | 20:40 |
| morganfainberg | erm, as a result of each line? | 20:40 |
| dolphm | morganfainberg: several people have requested that we doc policy.json, but comments aren't really possible | 20:40 |
| dolphm | morganfainberg: and yes, line-by-line | 20:40 |
| *** bashok has quit IRC | 20:40 | |
| ayoung | dolphm, so...does the token revocation list belong as part of the core API, as part of the PKI extension, or is it its own beast? | 20:40 |
| *** bashok has joined #openstack-dev | 20:41 | |
| dolphm | ayoung: good question... is there a use case for the revocation list to return UUID tokens? | 20:41 |
| ayoung | cuz it seems like it should be its own backend...got a BP for that | 20:41 |
| ayoung | dolphm, I don't think so | 20:42 |
| ayoung | dolphm, a UUID token by itself needs to be passed to Keystone to validate | 20:42 |
| dolphm | ayoung: right | 20:42 |
| ayoung | I guess in theory you could use the revocation list with cached tokens | 20:42 |
| ayoung | dolphm, actually, that woiuld make a lot of sense | 20:42 |
| *** salv-orlando has joined #openstack-dev | 20:43 | |
| *** dvarga has quit IRC | 20:44 | |
| dolphm | ayoung: i'm leaning towards either core or it's own extension at the moment... what were you thinking? | 20:44 |
| ayoung | dolphm, cache the initial validation, but periodically fetch the revocation list. Means that we get more responsive to revocation events without losing caching | 20:44 |
| ayoung | dolphm, well, I can now see and argument for core | 20:44 |
| ayoung | since we could use it with UUID tokens | 20:44 |
| ayoung | you don't really need to the Certificate to validate the signature, that is just an forward looking feature | 20:45 |
| dolphm | ayoung: what if it only published hashes of tokens? PKI or not | 20:45 |
| *** utlemming has quit IRC | 20:45 | |
| *** romcheg has joined #openstack-dev | 20:45 | |
| ayoung | dolphm, that is the plan | 20:45 |
| ayoung | UUID tokens won' | 20:45 |
| ayoung | t be hashed, but PKI tokens would | 20:45 |
| dolphm | ayoung: no no, i mean hash them all | 20:46 |
| ayoung | so we define a "short token" | 20:46 |
| ayoung | no reason to | 20:46 |
| ayoung | instead we distinguish between PKI long id and short id | 20:46 |
| ayoung | UUID tokens are the ral tokens | 20:46 |
| ayoung | real | 20:46 |
| dolphm | ayoung: theoretically you could get ahold of the token revocation list and utilize a recently revoked token before a remote service gets the list and realizes it's revoked | 20:46 |
| ayoung | dolphm, pretty small window there, but I did think of that, | 20:47 |
| dolphm | ayoung: that 'small window' is configurable | 20:47 |
| ayoung | true | 20:47 |
| ayoung | that is why the TRL API was Admin only | 20:47 |
| dolphm | so, exploitability will vary | 20:47 |
| *** emagana has joined #openstack-dev | 20:48 | |
| *** litong has quit IRC | 20:48 | |
| dolphm | ayoung: that's another deployment option though | 20:48 |
| dolphm | ayoung: what does it cost to hash everything? why *not* hash everything? | 20:48 |
| ayoung | dolphm, it costs nothing, but it means that the memcached value for the UUID tokens are different than the revocation list | 20:49 |
| ayoung | dolphm, is your goal to prevent them from being replayed? | 20:50 |
| *** salv-orlando has quit IRC | 20:50 | |
| *** romcheg has quit IRC | 20:50 | |
| *** salv-orlando2 has joined #openstack-dev | 20:50 | |
| morganfainberg | ayoung: it would have that benefit. | 20:50 |
| *** yolanda has quit IRC | 20:50 | |
| ayoung | morganfainberg, only for UUID tokens. PKI tokens currently rely on the hash to be used fro database lookups | 20:51 |
| morganfainberg | ayoung: right. | 20:51 |
| ayoung | so you can pass the hash back to keystone to validate just like UUID tokens | 20:51 |
| *** boden has quit IRC | 20:51 | |
| ayoung | I guess it could be a double hash | 20:51 |
| ayoung | does hashing a 64 bit value have enough entropy to guarantee we'll be collision free | 20:52 |
| morganfainberg | ayoung: hmm. | 20:52 |
| *** salv-orlando2 has quit IRC | 20:53 | |
| *** amotoki has joined #openstack-dev | 20:55 | |
| morganfainberg | ayoung: you thinking sha1 or md5 hashing? | 20:56 |
| morganfainberg | or something else? | 20:56 |
| *** gongysh has joined #openstack-dev | 20:56 | |
| ayoung | morganfainberg, right now it is md5. IN the future I want an extensible scheme | 20:57 |
| ayoung | morganfainberg, I want somethibng like | 20:57 |
| ayoung | pki-MD5-AADD0FED | 20:57 |
| ayoung | or JSON | 20:57 |
| *** nati_ueno has joined #openstack-dev | 20:57 | |
| *** tmclaugh[work] has quit IRC | 20:57 | |
| ayoung | format indicator, algorithm used, data | 20:57 |
| ayoung | maybe even version | 20:57 |
| morganfainberg | ayoung: nod. | 20:58 |
| ayoung | 3.5 or later | 20:58 |
| *** terryw has joined #openstack-dev | 20:58 | |
| *** salv-orlando2 has joined #openstack-dev | 20:59 | |
| ayoung | morganfainberg, I want tokens to stop being stored in the Keystone database. I want us to get away from online token verification | 21:02 |
| ayoung | I want revocation lists to go way. | 21:02 |
| *** drewlander_ has quit IRC | 21:02 | |
| dolphm | ayoung: that would be backwards incompatible to introduce later -- do it now | 21:02 |
| morganfainberg | ayoung: i agree completly | 21:02 |
| *** markmcclain has joined #openstack-dev | 21:02 | |
| dolphm | ayoung: also, isn't there a standard format for that already? | 21:02 |
| ayoung | dolphm, standard format for what? | 21:02 |
| *** rfolco has quit IRC | 21:02 | |
| dolphm | ayoung: hash type | 21:02 |
| *** boris-42 has quit IRC | 21:03 | |
| *** dprince has quit IRC | 21:04 | |
| *** salv-orlando has joined #openstack-dev | 21:05 | |
| ayoung | dolphm, probably...the thing I was thinking about actually was a way to identify the token format without having to parse it. Actually, what we really need is an indicator of what Certificate was used to sign the PKI token...so a very different subject than Hashing....and, yes, too late for the current API, but not for an extension in the Icehouse timeframe | 21:05 |
| *** jcoufal has quit IRC | 21:05 | |
| *** salv-orlando2 has quit IRC | 21:06 | |
| ayoung | basically, V3 PKI tokens will start with MII, but the future extension type will be something like JSON | 21:06 |
| ayoung | {signer:xyzzy,id:MII001122..} | 21:06 |
| dolphm | ayoung: if you want revocation lists to go away, do NOT make them core | 21:07 |
| ayoung | dolphm, deal. | 21:07 |
| dolphm | ayoung: otherwise we have to support it until we rev the api :( | 21:07 |
| ayoung | dolphm, they go in their own extension, separate from PKI | 21:07 |
| ayoung | I'm OK with that | 21:07 |
| morganfainberg | that actually makes things a lot easier. | 21:07 |
| morganfainberg | future looking | 21:07 |
| dolphm | cool | 21:08 |
| *** insanidade has quit IRC | 21:08 | |
| jamielennox | ayoung, is it possible to simply pass the token type in a seperate header to the token - or is that too much work for clients? | 21:08 |
| dolphm | jamielennox: clients shouldn't care | 21:08 |
| jamielennox | so keep X-Auth-Token with the token value and have X-Auth-Type = PKI | 21:08 |
| dolphm | jamielennox: so yes, too much work | 21:09 |
| jamielennox | dolphm, yea i figured that | 21:09 |
| dolphm | jamielennox: plus they'll just get it wrong and file bugs | 21:09 |
| *** jcoufal has joined #openstack-dev | 21:09 | |
| morganfainberg | dolphm: ++ on that last statement | 21:09 |
| *** salv-orlando2 has joined #openstack-dev | 21:09 | |
| *** jcoufal has quit IRC | 21:10 | |
| *** salv-orlando has quit IRC | 21:12 | |
| morganfainberg | ayoung / dolphm: extension API support should always start with /OS-<extension-name>/ not modify things inline like /v3/users/{user_id}/OS-EXTENSION/ right? | 21:14 |
| ayoung | jamielennox, right now we test that the token starts with MII and, if so, treat is as a PKI token. If the token is a newer format, middleware will just fall back to online verification | 21:14 |
| henrynash | dolphm: what are we calling the next version of the api? 3.2? 3.5? | 21:15 |
| ayoung | morganfainberg, we have extensions that do both already | 21:15 |
| morganfainberg | ayoung: hm. i'm looking at the quota spec atm, wasn't sure if we wanted to start moving towards encapsulating everything within the extension prefix (REST wise) or not. | 21:15 |
| jamielennox | ayoung, yea i was just thinking if you were going to put it into a json dict then you could just put those elements directly into the headers, but there is a number of reasons that's a bad idea | 21:16 |
| *** utlemming has joined #openstack-dev | 21:16 | |
| jamielennox | morganfainberg, i don't think there is any rule. personally i'd prefer to see it completely rooted at /OS-EXTENSION/ | 21:17 |
| jamielennox | so /OS-EXTENSION/users/{user_id} could give that info | 21:17 |
| morganfainberg | jamielennox: thats my pref as well, but, i wasn't 100% sure. | 21:17 |
| morganfainberg | i'll bring it up tomorrow at the meeting so we can get some more input. | 21:17 |
| henrynash | dolphm, ayoung, morganfainberg: filtering patch back up, with inexact filters disabled (including a test to ensure they are). https://review.openstack.org/#/c/43257/ | 21:19 |
| ayoung | henrynash, cool, I'll look. | 21:20 |
| morganfainberg | henrynash: cool. | 21:20 |
| dolphm | henrynash: how is the feature 'disabled'? | 21:20 |
| *** dina_belova has quit IRC | 21:20 | |
| *** salv-orlando has joined #openstack-dev | 21:21 | |
| *** dina_belova has joined #openstack-dev | 21:21 | |
| henrynash | dolphm: in code, utils has an array of supported inexact filters that is references both by the controller v3 class and the drivers. it is set to an empty list now | 21:21 |
| ayoung | dolphm, BTW, morganfainberg and I decdied to file a couple BPs I think you will like; we are going to reimplement KVS as a cache backend. So no more different backend impls for KVS, Memcached, Cassandra etc | 21:21 |
| ayoung | instead, we'll put different cache impls in keystone/common | 21:21 |
| henrynash | dolphm: it is not designed to be run-time switchable | 21:21 |
| *** bswartz has quit IRC | 21:21 | |
| henrynash | dolphm: could do, if people wanted it. but not sure there is a need | 21:22 |
| morganfainberg | henrynash: what is your opinion of caching the filtered results. i see a way i could manage it, but, i'm concerned about cache invalidations etc. it likely would require tracking all the various filtered permutations (at the moment). | 21:23 |
| ayoung | henrynash, you really want to submit it with the inexact code in there? | 21:23 |
| dolphm | henrynash: cool, it'll be nice to have it ready to go at the beginning of icehouse | 21:23 |
| morganfainberg | ayoung: i dont see a problem with the scaffolding being there for that support. makes future development quick. | 21:24 |
| dolphm | henrynash: definitely get horizon guys on the api review :) | 21:24 |
| *** colinmcnamara has quit IRC | 21:24 | |
| henrynash | ayoung: so I guess I can rip the code out….but this was a hot topic for pagination/filtering and (as Dolphm just said), easy to re-enable | 21:24 |
| henrynash | dolphm: agreed | 21:24 |
| *** salv-orlando has quit IRC | 21:25 | |
| ayoung | I'll let it pass...ideally we would not check in code that is not used yet. Let to debug and maintain and review.... | 21:25 |
| henrynash | morganfainberg: thinking…. | 21:25 |
| *** alunduil has joined #openstack-dev | 21:25 | |
| *** dina_belova has quit IRC | 21:25 | |
| *** bashok has quit IRC | 21:26 | |
| *** cdub has quit IRC | 21:26 | |
| morganfainberg | henrynash: same question for pagination (of course) [esp. with the less deterministic results from say ldap when you say give me X number of results] | 21:27 |
| henrynash | morganfainberg: yes, both of those are …..interesting... | 21:27 |
| *** nati_ueno has quit IRC | 21:28 | |
| henrynash | morganfainberg: on filtering, I'd guess we'll see a step bell curve of typical filters used e.g filter on domain_id | 21:28 |
| *** nati_ueno has joined #openstack-dev | 21:28 | |
| *** dkranz has quit IRC | 21:28 | |
| *** nachi1 has joined #openstack-dev | 21:29 | |
| *** salv-orlando has joined #openstack-dev | 21:30 | |
| dolphm | henrynash: why is it called valid_filters all the way through? what's with the valid_ ? | 21:30 |
| *** nachi has quit IRC | 21:30 | |
| *** salv-orlando_ has joined #openstack-dev | 21:30 | |
| henrynash | dolphm: they are the filters we support (i.e. the attributes we allow filtering on) | 21:30 |
| dolphm | henrynash: i mean you're passing it all the way down to the driver | 21:30 |
| *** Guest27379 has quit IRC | 21:30 | |
| *** jasondotstar has quit IRC | 21:30 | |
| dolphm | henrynash: i would hope that at some point valid_ would be implied | 21:31 |
| *** colinmcnamara has joined #openstack-dev | 21:31 | |
| *** cdub has joined #openstack-dev | 21:32 | |
| *** utlemming has quit IRC | 21:32 | |
| *** utlemming has joined #openstack-dev | 21:32 | |
| *** salv-orlando2 has quit IRC | 21:32 | |
| *** salv-orlando2 has joined #openstack-dev | 21:32 | |
| *** salv-orlando2 is now known as salv3 | 21:33 | |
| *** lorin1 has left #openstack-dev | 21:33 | |
| henrynash | dolphm: it didn't' have valid_ on at the start - but some reviews found that confusing | 21:34 |
| *** salv-orlando has quit IRC | 21:34 | |
| *** doude has quit IRC | 21:34 | |
| *** salv-orlando_ has quit IRC | 21:34 | |
| dolphm | henrynash: i'll keep reading through it then | 21:35 |
| *** jayg is now known as jayg|g0n3 | 21:38 | |
| *** salv-orlando has joined #openstack-dev | 21:40 | |
| *** reed has quit IRC | 21:41 | |
| *** salv3 has quit IRC | 21:42 | |
| morganfainberg | henrynash: so, i think i could create a helper function (another decorator?) that could do the work of maintaining the list of filters used, since we would need to cache based upon explicit filtered results. the easiest option is to punt this down to icehouse (don't cache filtered/paginated results) | 21:42 |
| morganfainberg | henrynash: but the list methods tend to be the big bottle necks. the other question becomes, how long should we cache those by default. | 21:44 |
| *** nati_uen_ has joined #openstack-dev | 21:44 | |
| *** ryu_ has joined #openstack-dev | 21:45 | |
| *** nati_ueno has quit IRC | 21:46 | |
| *** ryu_ has quit IRC | 21:46 | |
| dolphm | morganfainberg: can you not punt to the cache backend for that last concern? | 21:46 |
| dolphm | morganfainberg: e.g. redis' max memory + least recently used algorithm | 21:46 |
| *** alop has quit IRC | 21:47 | |
| morganfainberg | dolphm: depends on the cache backend, but if we are using a read-only ldap for say ID, how long should we cache list_users()? | 21:47 |
| *** terryh has quit IRC | 21:47 | |
| dolphm | morganfainberg: depends on the deployment? | 21:47 |
| morganfainberg | dolphm: need to set a more finite limit, since we want to pickup added/removed users. | 21:47 |
| morganfainberg | dolphm: aye. the concern is setting the default. | 21:48 |
| dolphm | morganfainberg: 3 seconds? | 21:48 |
| *** salv-orlando has quit IRC | 21:48 | |
| *** salv-orlando_ has joined #openstack-dev | 21:48 | |
| *** martine_ has joined #openstack-dev | 21:48 | |
| *** nati_ueno has joined #openstack-dev | 21:48 | |
| *** nati_uen_ has quit IRC | 21:48 | |
| dolphm | morganfainberg: high enough to test with the benefits of caching, low enough to avoid confused users and bug reports | 21:48 |
| morganfainberg | dolphm: might be a good place to start, i'd almost think less than 30s is too short. | 21:49 |
| morganfainberg | should still be narrow enough to avoid too much confusion. | 21:49 |
| dolphm | morganfainberg: i really don't know what the 'right' number would be | 21:49 |
| *** pcm_ has quit IRC | 21:49 | |
| *** salv-orlando has joined #openstack-dev | 21:50 | |
| morganfainberg | dolphm: yeah, thats the problem. those list functions are heavy. regardless of filtered or not | 21:50 |
| dolphm | morganfainberg: we chose 1 second as a default for the token revocation list's cache... which seems too short in retrospect | 21:50 |
| dolphm | not that we can't change it... | 21:50 |
| dolphm | 15-60 seconds seems reasonable there, IMO | 21:50 |
| *** nati_uen_ has joined #openstack-dev | 21:50 | |
| morganfainberg | dolphm: nod. i was leaning towards 60s on the identity cache across the board. | 21:50 |
| *** nati_uen_ has quit IRC | 21:51 | |
| morganfainberg | dolphm: the bigger issue is tracking the filtered/paginated results. | 21:51 |
| *** bswartz has joined #openstack-dev | 21:51 | |
| dolphm | morganfainberg: long enough for users to get the benefit of caching, short enough to make them realize they were only looking at stale data before they run off to file a bug report | 21:51 |
| *** alop has joined #openstack-dev | 21:52 | |
| morganfainberg | dolphm: do we just not care about invalidating them since the window is kept short? or do we track each filter and do an explicit invalidate when needed? | 21:52 |
| *** nati_uen_ has joined #openstack-dev | 21:52 | |
| *** salv-orlando_ has quit IRC | 21:52 | |
| dolphm | morganfainberg: =( you're putting more thought into invalidation that i would have lol | 21:53 |
| dolphm | morganfainberg: which is to say, you're doing a better job implementing it then i would have :P | 21:53 |
| *** nati_ueno has quit IRC | 21:53 | |
| *** donaldh has quit IRC | 21:53 | |
| morganfainberg | dolphm: hehe, i took on this BP for a reason, i like thinking about this stuff. | 21:53 |
| dolphm | morganfainberg: "you deleted a domain? invalidate ALL the cache!" | 21:54 |
| dolphm | -me | 21:54 |
| *** salv-orlando has quit IRC | 21:54 | |
| morganfainberg | dolphm: thats fine and all, but if you're in HTTPD mode you'd need to know how to invalidate the cache and/or signal all the workers to invalidate their region (global invalidate doesn't delete from the backend, just sets that region instance magic variable to say older than _NOW_ is bad) | 21:55 |
| dolphm | morganfainberg: if you only worry about immediate cache invalidation in one or two spots... where would that be? just tokens? | 21:55 |
| *** nati_uen_ has quit IRC | 21:55 | |
| dolphm | morganfainberg: and token revocation list | 21:56 |
| dolphm | ? | 21:56 |
| morganfainberg | dolphm: get_* calls, mostly and the related update_* calls | 21:56 |
| morganfainberg | get_token, get_user, get_domain, get_project | 21:56 |
| *** kbringard has quit IRC | 21:56 | |
| *** nati_ueno has joined #openstack-dev | 21:56 | |
| morganfainberg | also in token validate_token/validate_v3/validate_v2 | 21:56 |
| dolphm | morganfainberg: but i mean, if get_project() returns stale data, that's probably not the end of the world | 21:57 |
| *** insanidade has joined #openstack-dev | 21:57 | |
| morganfainberg | dolphm: except a lot of things expect ProjectNotFound explicitly if the project isn't there anymore | 21:57 |
| morganfainberg | dolphm: but those things are easy and already handled in the code pending reviews. | 21:57 |
| morganfainberg | dolphm: it's specifically the list_* methods that are a challenge… and only when you layer in filters and pagination | 21:58 |
| *** sushils has quit IRC | 21:59 | |
| dolphm | morganfainberg: hmm, so maybe that's how you draw the line on what methods you care about stale data on... | 21:59 |
| dolphm | morganfainberg: list_* methods can return stale data, get_* methods can't | 22:00 |
| morganfainberg | dolphm: i'm fine with that. | 22:00 |
| dolphm | morganfainberg: will you document that somewhere? | 22:00 |
| morganfainberg | dolphm: i'll put that in the developing and configuration docs (as appropriate) | 22:00 |
| morganfainberg | developing as a recommendation for list_* methods, and configuration so anyone reading it is warned. | 22:01 |
| dolphm | morganfainberg: cool | 22:01 |
| *** johnpur has joined #openstack-dev | 22:01 | |
| insanidade | any neutron plugin developers around? I'm looking for the plugin base py file in neutron's source dir. Is it "neutron_plugin_base_v2.py" ? | 22:02 |
| morganfainberg | dolphm: that makes this a lot easier. do you see value in making the list_* methods have a separate cache_time configurable? or just make it the global for the subsystem (e.g. identity)? | 22:03 |
| *** martine_ has quit IRC | 22:03 | |
| *** salv3 has joined #openstack-dev | 22:03 | |
| *** salv3 has quit IRC | 22:03 | |
| *** safchain has quit IRC | 22:03 | |
| *** terryw is now known as otherwiseguy | 22:03 | |
| *** dolphm has quit IRC | 22:03 | |
| *** markmcclain has quit IRC | 22:04 | |
| *** morganfainberg has left #openstack-dev | 22:04 | |
| *** morganfainberg has joined #openstack-dev | 22:04 | |
| *** salv3 has joined #openstack-dev | 22:07 | |
| *** salv3 has quit IRC | 22:07 | |
| *** sergmelikyan has quit IRC | 22:07 | |
| *** woodspa has quit IRC | 22:08 | |
| *** armax has left #openstack-dev | 22:08 | |
| *** pmathews1 has quit IRC | 22:09 | |
| *** pmathews has joined #openstack-dev | 22:09 | |
| *** salv-orlando has joined #openstack-dev | 22:09 | |
| *** nati_uen_ has joined #openstack-dev | 22:11 | |
| *** nati_uen_ has quit IRC | 22:11 | |
| *** portante is now known as portante|afk | 22:11 | |
| *** nati_uen_ has joined #openstack-dev | 22:12 | |
| *** lexinator1 has quit IRC | 22:13 | |
| *** lexinator has joined #openstack-dev | 22:14 | |
| *** morazi has quit IRC | 22:14 | |
| *** giulivo has joined #openstack-dev | 22:14 | |
| *** nati_ueno has quit IRC | 22:14 | |
| *** burt has quit IRC | 22:14 | |
| *** datsun180b has quit IRC | 22:15 | |
| *** neelashah has quit IRC | 22:15 | |
| *** spzala has quit IRC | 22:17 | |
| *** fabio_ has joined #openstack-dev | 22:21 | |
| stevemar | morganfainberg: yo | 22:22 |
| *** kbrierly has quit IRC | 22:22 | |
| morganfainberg | stevemar: sup dude | 22:23 |
| stevemar | morganfainberg: whatcha mean by the comment here: https://review.openstack.org/#/c/30043/ | 22:23 |
| stevemar | better link: https://review.openstack.org/#/c/30043/30/keystoneclient/v3/client.py | 22:23 |
| stevemar | can i just prefix it with oauth_ | 22:23 |
| morganfainberg | yep | 22:23 |
| morganfainberg | that was my point | 22:23 |
| stevemar | just wanted to make sure | 22:23 |
| stevemar | ! | 22:23 |
| stevemar | thx | 22:23 |
| morganfainberg | it seems like consumers and tokens might be a little… non-descript | 22:24 |
| morganfainberg | especially the latter | 22:24 |
| *** eharney has quit IRC | 22:24 | |
| insanidade | any neutron plugin developers around? I'm looking for the plugin base py file in neutron's source dir. Is it "neutron_plugin_base_v2.py" ? | 22:25 |
| *** nati_ueno has joined #openstack-dev | 22:28 | |
| *** _TheDodd_ has quit IRC | 22:28 | |
| *** dina_belova has joined #openstack-dev | 22:31 | |
| *** henrynash has quit IRC | 22:32 | |
| *** nati_uen_ has quit IRC | 22:32 | |
| *** ydacheville has quit IRC | 22:32 | |
| *** jhesketh has joined #openstack-dev | 22:34 | |
| *** wolfdreamer has quit IRC | 22:34 | |
| *** nati_ueno has quit IRC | 22:34 | |
| *** ydacheville has joined #openstack-dev | 22:34 | |
| *** pmathews has quit IRC | 22:34 | |
| *** nati_ueno has joined #openstack-dev | 22:34 | |
| *** pmathews has joined #openstack-dev | 22:34 | |
| *** vipul has quit IRC | 22:35 | |
| *** vipul has joined #openstack-dev | 22:35 | |
| *** giulivo has quit IRC | 22:35 | |
| *** dina_belova has quit IRC | 22:36 | |
| *** salv3 has joined #openstack-dev | 22:37 | |
| *** salv3 has quit IRC | 22:37 | |
| *** yjiang5 is now known as yjiang5_away | 22:38 | |
| *** mlavalle has quit IRC | 22:44 | |
| *** fbo is now known as fbo_away | 22:47 | |
| *** galstrom is now known as galstrom_zzz | 22:47 | |
| *** jmontemayor has quit IRC | 22:49 | |
| *** gordc has quit IRC | 22:51 | |
| *** pixelbeat has quit IRC | 22:51 | |
| *** jimfehlig has quit IRC | 22:51 | |
| *** nati_ueno has quit IRC | 22:52 | |
| *** nati_ueno has joined #openstack-dev | 22:53 | |
| gongysh | stevemar: I mean in normal keystone op: I give username, passworkd, tenant to keystone for authn, and then get a keystone token. from the token, I can get the userid | 22:53 |
| gongysh | but on oauth, when I input the username to oauth API? | 22:53 |
| *** ydacheville has quit IRC | 22:54 | |
| *** bknudson has quit IRC | 22:55 | |
| gongysh | stevemar: ping | 22:57 |
| *** insanidade has quit IRC | 22:58 | |
| *** ydacheville has joined #openstack-dev | 22:59 | |
| *** dims has quit IRC | 23:00 | |
| *** colinmcnamara has quit IRC | 23:01 | |
| *** jvrbanac has quit IRC | 23:01 | |
| *** egallen has quit IRC | 23:02 | |
| *** maheshp has joined #openstack-dev | 23:02 | |
| *** salv-orlando has quit IRC | 23:02 | |
| *** maheshp1 has joined #openstack-dev | 23:02 | |
| *** Mandell has quit IRC | 23:02 | |
| *** jecarey has quit IRC | 23:03 | |
| *** dims has joined #openstack-dev | 23:04 | |
| *** ydacheville has quit IRC | 23:04 | |
| *** sthaha has joined #openstack-dev | 23:05 | |
| *** sthaha has quit IRC | 23:05 | |
| *** sthaha has joined #openstack-dev | 23:05 | |
| *** Mandell has joined #openstack-dev | 23:05 | |
| stevemar | gongysh: pong | 23:05 |
| gongysh | ping | 23:06 |
| stevemar | gongysh: once you have an access you, you can use access token + consumer token, and receive a keystone token | 23:06 |
| *** salv3 has joined #openstack-dev | 23:06 | |
| *** salv3 has quit IRC | 23:06 | |
| stevemar | that keystone token is scoped to project and roles | 23:07 |
| *** ydacheville has joined #openstack-dev | 23:08 | |
| *** dims has quit IRC | 23:08 | |
| *** markmcclain has joined #openstack-dev | 23:09 | |
| *** salv-orlando has joined #openstack-dev | 23:09 | |
| *** maheshp1 has quit IRC | 23:10 | |
| *** dolphm has joined #openstack-dev | 23:10 | |
| *** jhesketh_ has quit IRC | 23:10 | |
| *** salv-orlando has quit IRC | 23:12 | |
| *** salv-orlando has joined #openstack-dev | 23:13 | |
| *** herndon has quit IRC | 23:13 | |
| *** carl_baldwin has quit IRC | 23:14 | |
| *** dolphm has quit IRC | 23:14 | |
| *** pmathews has quit IRC | 23:14 | |
| *** nati_ueno has quit IRC | 23:15 | |
| *** edmund has quit IRC | 23:16 | |
| *** flaper87 is now known as flaper87|afk | 23:17 | |
| *** nachi1 has left #openstack-dev | 23:18 | |
| *** dims has joined #openstack-dev | 23:22 | |
| *** devoid has quit IRC | 23:23 | |
| *** sarob has quit IRC | 23:30 | |
| *** dstanek has joined #openstack-dev | 23:30 | |
| *** sarob has joined #openstack-dev | 23:31 | |
| *** markwash has quit IRC | 23:31 | |
| *** rnirmal has quit IRC | 23:31 | |
| *** dina_belova has joined #openstack-dev | 23:32 | |
| *** jimjiang has quit IRC | 23:34 | |
| *** jimjiang has joined #openstack-dev | 23:35 | |
| *** sarob has quit IRC | 23:35 | |
| *** salv3 has joined #openstack-dev | 23:36 | |
| *** salv3 has quit IRC | 23:36 | |
| *** boden has joined #openstack-dev | 23:37 | |
| *** sarob has joined #openstack-dev | 23:37 | |
| *** dina_belova has quit IRC | 23:37 | |
| *** zul has joined #openstack-dev | 23:47 | |
| *** otherwiseguy has quit IRC | 23:47 | |
| *** boden has quit IRC | 23:48 | |
| *** MaxV has joined #openstack-dev | 23:49 | |
| *** rods1 has quit IRC | 23:51 | |
| *** radez is now known as radez_g0n3 | 23:52 | |
| *** johnpur has left #openstack-dev | 23:53 | |
| *** dims has quit IRC | 23:53 | |
| *** dims has joined #openstack-dev | 23:56 | |
| *** gongysh has quit IRC | 23:58 | |
| *** networkstatic has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!