Monday, 2013-08-19

« Sunday, 2013-08-18 Index Tuesday, 2013-08-20 »
morganfainberglifeless: nice.00:03
morganfainberglifeless: yes, an @deprecated decorator would be good to00:03
morganfainbergjamielennox / lifeless: this sounds like something that could be useful across all projects… maybe targeted for oslo?00:04
morganfainbergwell, or after it's proven to work well for us if not immidiately?00:04
*** dina_belova has joined #openstack-dev00:11
*** flaper87 is now known as flaper87|afk00:12
*** dina_belova has quit IRC00:15
*** briancurtin has quit IRC00:16
lifelessmorganfainberg: the idioms are all obivous; I'd put the decorator in oslo from the start - but it doesn't really matter00:19
morganfainberglifeless: i agree with you on that, for sure.00:20
*** jecarey has joined #openstack-dev00:21
*** bdpayne has quit IRC00:22
*** briancurtin has joined #openstack-dev00:23
*** hailiang has joined #openstack-dev00:26
*** shang has joined #openstack-dev00:29
*** fabio has joined #openstack-dev00:44
*** briancurtin has quit IRC00:45
*** colinmcnamara1 has joined #openstack-dev00:48
*** colinmcnamara has quit IRC00:48
*** briancurtin has joined #openstack-dev00:49
*** erfanian has joined #openstack-dev00:50
*** dina_belova has joined #openstack-dev01:11
*** alunduil has joined #openstack-dev01:12
*** johnpur has left #openstack-dev01:13
*** CaptTofu has joined #openstack-dev01:14
*** dina_belova has quit IRC01:16
*** rods has quit IRC01:26
lifelesswhat uses the admin url from endpoints ?01:41
*** erkules has quit IRC01:44
*** lbragstad has joined #openstack-dev01:47
*** xchu has joined #openstack-dev01:48
*** utlemming has quit IRC01:48
*** utlemming has joined #openstack-dev01:48
*** matrice64 has quit IRC01:50
*** dstanek has joined #openstack-dev01:51
*** yaguang has joined #openstack-dev01:57
*** d34dh0r53 has joined #openstack-dev01:59
*** d34dh0r53 has quit IRC02:01
*** jimjiang has quit IRC02:02
*** jimjiang has joined #openstack-dev02:02
*** d34dh0r53 has joined #openstack-dev02:03
*** yaguang has quit IRC02:05
*** alunch has quit IRC02:11
*** dina_belova has joined #openstack-dev02:12
*** zul has quit IRC02:16
*** dina_belova has quit IRC02:16
*** yaguang has joined #openstack-dev02:19
*** zul has joined #openstack-dev02:20
*** alunch has joined #openstack-dev02:24
jaypipeslifeless: nothing except keystoneclient.middleware.auth_token (for Keystone itself)... it's kinda dumb if you ask me...02:24
lifelessjaypipes: so what, it's normally set to the same as internal_url ?02:25
*** kushal has joined #openstack-dev02:28
*** fabio has quit IRC02:33
*** zul has quit IRC02:34
*** CaptTofu has quit IRC02:35
*** shang has quit IRC02:36
*** CaptTofu has joined #openstack-dev02:36
*** zul has joined #openstack-dev02:42
*** cmark_ has joined #openstack-dev02:50
*** erfanian has quit IRC02:51
*** cmark has quit IRC02:51
jamielennoxlifeless, jaypipes actually auth_token should but doesn't look up endpoints at all02:51
jamielennoxso bsaically i've got no idea what uses it02:52
*** noslzzp has quit IRC02:56
lifelessjamielennox: heh02:59
*** yaguang has quit IRC03:03
morganfainbergjamielennox:  https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/access.py#L91 would win over https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/access.py#L64 correct?  the one later in class definition wins, right?03:07
morganfainbergjamielennox: doing the last of the flake8 cleanup commits in keystoneclient since i have a few minutes.03:07
*** dina_belova has joined #openstack-dev03:12
lifelessmorganfainberg: yes03:15
*** yaguang has joined #openstack-dev03:16
morganfainberglifeless: thanks, i was pretty sure of that, but wanted to 2x check03:16
*** colinmcnamara1 has quit IRC03:16
*** shang has joined #openstack-dev03:17
*** dina_belova has quit IRC03:17
jamielennoxmorganfainberg: yes, but both would be overridden by the v2 or v3 versions of the function03:17
morganfainbergjamielennox: thats fine (and the point).  I figure i had about 10 minutes to work on something so i did a couple flake8 cleanup commits.03:18
morganfainbergif all get in, we'll be down to the relative imports one and "undefined name" one03:19
jamielennoxundefined name?03:19
morganfainbergyeah, i think it triggers on stuff like03:20
morganfainberg./tests/test_shell.py:403:1: F821 undefined name 'shell'03:20
morganfainberg            shell('ec2-credentials-delete')03:20
jamielennoxis that coming from an import * ?03:20
morganfainbergmight be.03:20
morganfainbergi haven't gotten to look yet.03:20
morganfainberg;)03:20
morganfainbergactually.03:22
*** dstanek has quit IRC03:22
morganfainbergsome of these might be just namespace things.03:22
morganfainbergjamielennox: oh and it seems to trigger on docstrings.03:23
jamielennoxoh, right that'll be a bit annoying then03:24
jamielennoxthere's a bunch of example in client that will fail then03:24
morganfainbergjamielennox: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/generic/client.py#L38 for example claims KEYSTONE_URL is undefined03:25
jamielennoxyea, that's fair enough - it can be fixed but probably not a 10 minute job03:26
*** shang_ has joined #openstack-dev03:26
morganfainbergnow that being said, i've already found one or two legitimate issues, (getting a patchset in for them), e.g. https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/utils.py#L99 that will raise a NameError it looks like03:26
morganfainbergsince it should be exceptions.CommandError not exc.CommandError03:27
*** yaguang has quit IRC03:27
jamielennoxmorganfainberg: wow, yep03:28
morganfainbergfun times.03:28
*** bdpayne has joined #openstack-dev03:28
*** shang has quit IRC03:30
*** leif has joined #openstack-dev03:30
*** yuanz has quit IRC03:30
*** leif is now known as Guest997303:30
morganfainbergjamielennox: https://github.com/openstack/python-keystoneclient/blob/master/tests/test_shell.py#L59 is that one supposed to be openstack_shell or shell_v2_0 ?03:32
morganfainbergor self.shell?03:32
morganfainberglooks like self.shell.03:33
morganfainbergoh no03:33
morganfainbergit's just … wow setUp is just assigning shell to the namespace03:34
jamielennoxi can't tell03:34
jamielennoxshell is used a log though03:34
morganfainbergin globals03:34
jamielennoxoh wow03:34
jamielennoxwhy/03:34
morganfainbergjamielennox: it's a little sloppy.03:35
jamielennoxlol, git blame dates it back to "Initial Commit"03:35
morganfainbergyeah03:36
morganfainbergi see that03:36
*** yaguang has joined #openstack-dev03:36
morganfainbergok. i see some self.shell mixed in, shell global, hrmm.  ick.03:36
*** lbragstad has quit IRC03:37
morganfainbergjamielennox: any thoughts on the cleanest fix to this?  perhaps self._shell_wrapper self._fakeshell ?03:38
morganfainberg_shell and shell global respecitively03:38
jamielennoxi would assign _shell to self.shell (although there is a function called that so it would clash)03:39
morganfainbergyeah.03:39
lifelessowwww03:39
lifelesskeystone, stab03:39
*** adjohn has quit IRC03:39
lifeless "http://$CONTROLLER_PUBLIC_ADDRESS:\$(public_port)s/v2.0" ,  "http://$CONTROLLER_ADMIN_ADDRESS:\$(admin_port)s/v2.0"03:39
jamielennoxgit blame says rackspace03:39
*** adjohn has joined #openstack-dev03:40
jamielennoxah, your not looking at this03:40
morganfainberglifeless:  /comfort03:40
morganfainbergjamielennox: this one is making my head hurt a little.03:41
jamielennoxnot a 10 minute thing03:41
morganfainbergactually… it looks safe to just move the _shell and shell to the module level03:41
jamielennoxthey don't do anything stateful so maybe03:42
morganfainbergit's just tests.03:42
morganfainberglet me try it.03:42
jamielennoxso the global assert_called and assert_called_anythime don't seem to be used03:42
morganfainbergyeah03:43
morganfainberggoing to pull those out03:43
lifelessjamielennox: indeed; I'm trying to figure out why keystone knows about the compute port number, for instance.03:43
jamielennoxmorganfainberg: i'm not sure that will work because it is going to need the fake env fixtures03:43
jamielennoxlifeless: i've always wondered that03:43
morganfainbergjamielennox: oh bleh. you're right.03:44
morganfainbergwell, in theory we could assign shell and _shell to None and let setup muck them up03:44
jamielennoxlifeless: here are random things like a dependency on swiftclient that i assumed it was related to03:44
jamielennoxmorganfainberg: so what is self.shell doing that isn't being achieved by setup?03:45
jamielennoxother than stealing stdout? (why?)03:45
lifelessjamielennox: It doesn't make sense to me from a layering perspective03:45
morganfainbergjamielennox: i … i think thats it?03:46
jamielennoxlifeless: there have always been a few issues with layering that i assume happened because keystone is used as such a base of everything03:46
*** adjohn has quit IRC03:46
jamielennoxthere are plans to fix the swift dependency, but i've got nothing for compute port03:46
morganfainbergjamielennox: hrm. actually, it looks like this might be vestigial.  things didn't get swapped to self.shell03:47
morganfainbergwhich in itself relies on shell and _shell03:47
jamielennoxmorganfainberg: honestly i can't tell - it's doing a few things with keeping track of environment03:47
lifelessjamielennox: the only place it's used is in the endpoint templates03:47
lifelessjamielennox: what I'm hacking on is a script to make setting up keystone in new cloud easier03:48
lifelessjamielennox: without yet another copy of the smaple-data script from keystone03:48
jamielennoxlifeless: oh, ok. Yea it's dumb that it needs to be setup like that03:49
lifelessjamielennox: I mentioned this on the -dev list the other day; I'd be very happy for it to live in keystone-client or something03:49
*** dstanek has joined #openstack-dev03:49
*** rcleere has joined #openstack-dev03:49
lifelessjamielennox: so yeah, consider that most clouds will have a front end in front of the apis, having the actual listening port isn't all that useful.03:50
morganfainbergjamielennox: oh dear, it's all how mock is setup to work03:50
jamielennoxlifeless: you will still fequently be putting them on to some specific port03:51
morganfainbergjamielennox: oh yeah, this is going to be a lot of test refactoring i'm going to leave to another day.03:51
lifelessjamielennox: sure, but when you register the endpoint you can just put the port in.03:51
jamielennoxlifeless: oh right, sure03:51
lifelessjamielennox: it's just weird for the sql backend to have half-in-conf-file, half-in-the template you create.03:51
jamielennoxit's just not a useful replacement you mean - which is completely true because it's not a value that can change in the config file either, so i'm guessing it'd still be static03:52
lifelessjamielennox: and for the template backend, having data split between the file template and the config file.03:52
lifelessjamielennox: right. tenant_id is more useful I think.03:52
*** colinmcnamara has joined #openstack-dev03:53
jamielennoxlifeless: i agree, i've had this problem just today where i'm mixing the v2 and v3 identity api, however both endpoints can't co-exist in the list so i have to add the v2; do stuff; remove v2; add v3; do stuff03:53
lifelessjamielennox: thats a related thing and indeed annoying03:54
lifelessjamielennox: there was a good thread about that a month or so ago03:54
jamielennoxsorry reading your email trhead rather than what you are talking about right now :)03:54
lifelessjamielennox: LOL :P)03:54
*** colinmcnamara has quit IRC03:55
jamielennoxso i can see no reason that you can't simply ignore the compute_port in the conf file and just do it via endpoint03:56
lifelessjamielennox: yeah, I'm going to :).03:56
lifelessjamielennox: like I said, I was trying to figure out why :)03:56
lifelessjamielennox: all the reference stuff like devstack uses %(compute_port)s03:56
lifelessjamielennox: tis confusing03:56
jamielennoxlifeless: on the other hand if you were quite really into pain you could go and add all the storage_port etc into keystone03:57
*** dstanek has quit IRC03:57
lifelessjamielennox: That would be painful.03:57
jamielennoxjust for consistency03:57
lifelessjamielennox: since you'd need a raft of cross-service data injection.03:57
lifelessjamielennox: why would you say such a thing!03:58
jamielennoxi don't think that compute_port is actually found from nova though, it's just something in a config file03:58
*** Ryan_Lane has joined #openstack-dev03:58
lifelessjamielennox: indeed03:58
jamielennoxit would be almost useful otherwise03:59
*** erkules has joined #openstack-dev03:59
lifelessjamielennox: it's just a very strange thing to have in the config file for the end of the dependency chain03:59
*** gongysh has joined #openstack-dev04:01
*** Ryan_Lane has quit IRC04:03
*** Ryan_Lane has joined #openstack-dev04:04
*** Ryan_Lane has quit IRC04:04
*** Ryan_Lane has joined #openstack-dev04:04
*** adjohn has joined #openstack-dev04:10
*** adjohn has quit IRC04:11
*** jecarey has quit IRC04:12
*** dina_belova has joined #openstack-dev04:13
*** dina_belova has quit IRC04:17
*** jab416171 has quit IRC04:19
*** Alex_Gaynor has quit IRC04:19
*** neelashah has joined #openstack-dev04:19
*** mkoderer has quit IRC04:19
*** s2r2 has quit IRC04:20
*** mezzovide has joined #openstack-dev04:21
*** Alex_Gaynor has joined #openstack-dev04:23
*** mezzovide has quit IRC04:32
*** briancurtin has quit IRC04:34
*** nati_ueno has joined #openstack-dev04:36
*** Guest9973 has quit IRC04:37
*** anniec has quit IRC04:39
*** rcleere has quit IRC04:40
*** garyk has quit IRC04:41
*** mberwanger has joined #openstack-dev04:41
*** Shaan7 has quit IRC04:45
*** Shaan7 has joined #openstack-dev04:45
*** toabctl has quit IRC04:49
*** neoXsys has joined #openstack-dev04:52
*** Shaan7 has quit IRC04:53
*** boris-42 has joined #openstack-dev04:53
*** dstanek has joined #openstack-dev04:54
*** Shaan7 has joined #openstack-dev04:58
*** dstanek has quit IRC04:59
*** adjohn has joined #openstack-dev05:05
*** sushils has joined #openstack-dev05:08
*** mberwanger has quit IRC05:10
*** bdpayne has quit IRC05:10
*** eharney has quit IRC05:10
*** yjiang5 has joined #openstack-dev05:12
*** dina_belova has joined #openstack-dev05:13
*** yjiang5 has quit IRC05:14
*** nati_ueno has quit IRC05:15
*** bdpayne has joined #openstack-dev05:15
*** dina_belova has quit IRC05:18
*** fabio has joined #openstack-dev05:21
*** sridevi has joined #openstack-dev05:22
*** nati_ueno has joined #openstack-dev05:23
*** nati_ueno has quit IRC05:23
*** toabctl has joined #openstack-dev05:24
*** toabctl has joined #openstack-dev05:24
*** adjohn has quit IRC05:27
*** jcoufal has joined #openstack-dev05:28
*** adjohn has joined #openstack-dev05:29
*** terriyu has joined #openstack-dev05:29
*** anniec has joined #openstack-dev05:31
*** bdpayne has quit IRC05:32
*** anniec_ has joined #openstack-dev05:35
*** anniec has quit IRC05:37
*** anniec_ is now known as anniec05:37
*** SergeyLukjanov has joined #openstack-dev05:41
*** mrunge has joined #openstack-dev05:42
*** cmagina has quit IRC05:42
*** garyk has joined #openstack-dev05:44
*** dina_belova has joined #openstack-dev05:54
*** jimjiang has quit IRC05:56
*** misheska has joined #openstack-dev05:56
*** freedomhui has joined #openstack-dev06:01
*** cmagina has joined #openstack-dev06:01
*** ftcjeff has quit IRC06:03
*** ftcjeff has joined #openstack-dev06:04
*** misheska has quit IRC06:06
*** nayward has quit IRC06:06
*** neelashah has quit IRC06:07
*** jcoufal has quit IRC06:07
*** ftcjeff has quit IRC06:08
*** nshaikh has joined #openstack-dev06:13
*** arezmerita has joined #openstack-dev06:18
*** jab416171 has joined #openstack-dev06:20
*** Mandell has joined #openstack-dev06:20
*** mkoderer has joined #openstack-dev06:21
*** jjmb has quit IRC06:22
*** dina_belova has quit IRC06:24
*** SergeyLukjanov has quit IRC06:25
*** s2r2 has joined #openstack-dev06:28
*** SergeyLukjanov has joined #openstack-dev06:30
*** kspear has quit IRC06:30
*** kspear has joined #openstack-dev06:32
*** sthaha has quit IRC06:35
*** comay has joined #openstack-dev06:36
*** SergeyLukjanov has quit IRC06:38
*** safchain has joined #openstack-dev06:41
*** SergeyLukjanov has joined #openstack-dev06:42
*** vartom117 has joined #openstack-dev06:43
*** dina_belova has joined #openstack-dev06:43
*** yolanda has joined #openstack-dev06:45
*** vartom117 has quit IRC06:45
*** SergeyLukjanov has quit IRC06:48
*** vartom3 has joined #openstack-dev06:49
*** bashok has joined #openstack-dev06:50
*** xga has joined #openstack-dev06:57
*** dina_belova has quit IRC06:57
*** egallen has joined #openstack-dev07:03
*** pasquier-s has joined #openstack-dev07:04
*** gongysh has quit IRC07:05
*** avishay has joined #openstack-dev07:05
avishayHey, does anyone here know how to run gate-grenade-devstack-vm locally?07:07
*** jamielennox is now known as jamielennox|away07:08
*** flaper87|afk is now known as flaper8707:09
lifelessjaypipes: sorry for backing you into a support-ORM corner; didn't mean to.07:12
lifelessjaypipes: a more full reply is on the list07:12
jaypipeslifeless: cheers07:14
*** fbo_away is now known as fbo07:16
*** odyssey4me3 has joined #openstack-dev07:16
jaypipeslifeless: yeah, I actually agree with most of everything you and jog0 have been saying.07:17
jaypipeslifeless: and yes, you're proposed storage interface in the last reply is good, and in line with what I think is a good solution: decoupling the logic from the storage.07:19
jaypipess/you're/your...07:19
jaypipesugh, grammar gets bad at 3:15am07:19
*** aloga has joined #openstack-dev07:19
lifelessjaypipes: everything getes bad at 3:15am07:20
jaypipeslifeless: there was also I think a misunderstanding... when I was saying to continue to use SQLAlchemy ORM, I was referring to the Query and Session parts of the SA ORM *modules*... :) Not using join loading and things like that..07:20
jaypipeslifeless: it's a bit unfortunate that those parts of the SA ORM are still too coupled with the relational mapper part... but with prudent use, they can be used quite effectively.07:21
lifelesssure07:21
lifelessin fact I've no objection to the ORM itself being used, as long as it doesn't leak (which it does today)07:22
jaypipesabsoltuely.07:22
*** xchu has quit IRC07:22
lifelessthe query compiler facilities are a very valuable thing07:22
lifelesstossing those away would be daft07:23
*** jjmb has joined #openstack-dev07:23
lifelessAs a data point, Storm spends about 50% of it's time casting SQL query results into objects07:23
lifelessit's a huge overhead07:23
*** nsaje1 has joined #openstack-dev07:23
*** sridevi has quit IRC07:23
*** xBsd has joined #openstack-dev07:24
*** xqueralt-afk is now known as xqueralt07:26
jaypipeslifeless: see my latest reply to jog0... I'd be interested in seeing the performance comparison of using straight Python dicts and correlating the resultsets in a loop compared to the ORM's joinedload mess...07:26
*** akamyshnikova has quit IRC07:26
*** Ryan_Lane has quit IRC07:26
*** gongysh has joined #openstack-dev07:27
lifelessjaypipes: yeah. Better still not to bring back 10^5 rows anyhow07:27
jaypipeslol, yes...07:27
lifelesssorry, 10^6 rows07:27
lifelessyeah07:27
*** JordanP has joined #openstack-dev07:28
lifelessno, 10^5. <- tired.07:28
*** freedomhui has quit IRC07:29
*** sergmelikyan has joined #openstack-dev07:29
gongyshgaryk: ping07:30
*** freedomhui has joined #openstack-dev07:31
*** ifarkas has joined #openstack-dev07:31
*** ndipanov has joined #openstack-dev07:35
*** feleouet has joined #openstack-dev07:36
*** devvesa has joined #openstack-dev07:38
*** jistr has joined #openstack-dev07:39
*** xchu has joined #openstack-dev07:39
*** jtomasek has joined #openstack-dev07:42
*** jaimegil has joined #openstack-dev07:43
*** akamyshnikova has joined #openstack-dev07:43
*** jtomasek has quit IRC07:47
*** jtomasek has joined #openstack-dev07:47
*** jtomasek has quit IRC07:48
*** jtomasek has joined #openstack-dev07:48
*** fabio has quit IRC07:49
*** yolanda has quit IRC07:49
*** jprovazn has joined #openstack-dev07:50
*** matel has joined #openstack-dev07:51
*** jpich has joined #openstack-dev07:53
*** ema has joined #openstack-dev07:53
*** adjohn has quit IRC07:54
*** adjohn has joined #openstack-dev07:56
*** Ryan_Lane has joined #openstack-dev07:57
*** xga_ has joined #openstack-dev07:57
*** tkammer has joined #openstack-dev08:00
*** avishay has quit IRC08:00
*** xga has quit IRC08:01
*** jhesketh has quit IRC08:03
*** Ryan_Lane has quit IRC08:04
*** boden has joined #openstack-dev08:05
*** feleouet has quit IRC08:05
*** derekh has joined #openstack-dev08:05
*** dina_belova has joined #openstack-dev08:08
*** feleouet has joined #openstack-dev08:08
*** nayward has joined #openstack-dev08:11
*** dina_belova has quit IRC08:13
*** mmagr has joined #openstack-dev08:13
*** lucasagomes has joined #openstack-dev08:13
*** Shaan7 has quit IRC08:13
*** sthaha has joined #openstack-dev08:13
*** sthaha has quit IRC08:13
*** sthaha has joined #openstack-dev08:13
*** mkerrin has joined #openstack-dev08:13
*** giulivo has joined #openstack-dev08:15
*** valgrind has joined #openstack-dev08:17
*** doron_afk has joined #openstack-dev08:17
*** ifarkas has quit IRC08:19
*** boris-42 has quit IRC08:19
*** ifarkas has joined #openstack-dev08:19
*** psedlak has joined #openstack-dev08:21
*** reidrac has joined #openstack-dev08:24
*** ifarkas has quit IRC08:26
*** Shaan7 has joined #openstack-dev08:27
*** ifarkas has joined #openstack-dev08:27
*** adjohn has quit IRC08:28
*** AnilV4 has joined #openstack-dev08:29
*** lucasagomes has quit IRC08:29
*** adjohn has joined #openstack-dev08:30
*** adjohn has quit IRC08:30
*** ffio has joined #openstack-dev08:32
*** lucasagomes has joined #openstack-dev08:33
*** henrynash has joined #openstack-dev08:35
*** devvesa has quit IRC08:36
*** doron_afk is now known as doron08:36
*** anniec has quit IRC08:37
*** shardy_afk is now known as shardy08:39
*** adjohn has joined #openstack-dev08:39
*** adjohn has quit IRC08:39
*** doron is now known as doron_afk08:41
*** feleouet has quit IRC08:43
*** nshaikh has left #openstack-dev08:43
*** nshaikh has joined #openstack-dev08:44
*** sridevi has joined #openstack-dev08:46
*** feleouet has joined #openstack-dev08:47
*** kushal has quit IRC08:47
*** donaldh has joined #openstack-dev08:48
*** martyntaylor has joined #openstack-dev08:51
*** tkammer has quit IRC08:55
*** dstanek has joined #openstack-dev08:56
*** adjohn has joined #openstack-dev08:58
*** adjohn has quit IRC08:58
*** Shaan7 has quit IRC08:59
*** Shaan7 has joined #openstack-dev08:59
*** dstanek has quit IRC09:00
*** dina_belova has joined #openstack-dev09:09
*** sumanthns has joined #openstack-dev09:12
*** johnthetubaguy has joined #openstack-dev09:13
*** dina_belova has quit IRC09:13
*** ruhe has joined #openstack-dev09:14
*** feleouet has quit IRC09:16
*** MaxV has joined #openstack-dev09:19
*** reidrac has quit IRC09:21
*** ema has quit IRC09:22
*** hk_peter has joined #openstack-dev09:24
*** hk_peter has quit IRC09:24
*** tkammer has joined #openstack-dev09:25
*** morganfainberg is now known as morganfainberg|a09:27
*** vsergeyev has joined #openstack-dev09:27
*** feleouet has joined #openstack-dev09:29
*** adjohn has joined #openstack-dev09:29
*** moted has quit IRC09:30
*** boris-42 has joined #openstack-dev09:30
*** xBsd has quit IRC09:31
*** sridevi has quit IRC09:31
*** xBsd has joined #openstack-dev09:34
*** martyntaylor has quit IRC09:34
*** xchu has quit IRC09:34
*** martyntaylor has joined #openstack-dev09:35
*** feleouet has quit IRC09:36
*** reidrac has joined #openstack-dev09:37
*** feleouet has joined #openstack-dev09:38
*** yolanda has joined #openstack-dev09:38
*** sridevi has joined #openstack-dev09:41
*** doron_afk is now known as doron09:41
*** freedomhui has quit IRC09:44
*** kushal has joined #openstack-dev09:45
*** doron is now known as doron_afk09:45
*** Shaan7 has quit IRC09:45
*** yolanda has quit IRC09:46
*** adjohn has quit IRC09:46
*** xchu has joined #openstack-dev09:47
*** sridevi has quit IRC09:49
*** gongysh has quit IRC09:49
*** gongysh has joined #openstack-dev09:51
*** ema has joined #openstack-dev09:52
*** chuckieb|2 has quit IRC09:53
*** safchain has quit IRC09:56
*** gongysh has quit IRC09:57
*** tkammer has quit IRC09:58
*** safchain has joined #openstack-dev10:00
*** sthaha has quit IRC10:01
*** gongysh has joined #openstack-dev10:02
*** Ryan_Lane has joined #openstack-dev10:02
*** donaldh has quit IRC10:05
*** feleouet has quit IRC10:07
*** xchu has quit IRC10:09
*** dina_belova has joined #openstack-dev10:09
*** Ryan_Lane has quit IRC10:09
*** dstanek has joined #openstack-dev10:09
*** bashok_ has joined #openstack-dev10:09
*** rods has joined #openstack-dev10:10
*** feleouet has joined #openstack-dev10:11
*** nayward has quit IRC10:11
*** bashok has quit IRC10:11
*** dina_belova has quit IRC10:13
*** adjohn has joined #openstack-dev10:13
*** chandankumar has joined #openstack-dev10:14
*** moted has joined #openstack-dev10:15
*** mjfork has joined #openstack-dev10:16
*** ruhe has quit IRC10:16
*** ffio has quit IRC10:20
*** ffio_ has joined #openstack-dev10:20
*** Shaan7 has joined #openstack-dev10:21
*** yaguang has quit IRC10:24
*** shang_ has quit IRC10:24
*** JordanP has quit IRC10:24
*** dstanek has quit IRC10:26
*** donaldh has joined #openstack-dev10:26
*** ndipanov has quit IRC10:28
*** nayward has joined #openstack-dev10:30
*** egallen has quit IRC10:30
*** ndipanov has joined #openstack-dev10:31
*** k4n0 has joined #openstack-dev10:32
k4n0Hi, can the nova core reviewers plz review https://review.openstack.org/#/c/39441/10:33
*** fbo is now known as fbo_away10:34
*** MaxV has quit IRC10:35
*** JordanP has joined #openstack-dev10:37
*** nayward has quit IRC10:42
*** feleouet has quit IRC10:42
*** ruhe has joined #openstack-dev10:43
*** mikal has quit IRC10:45
*** feleouet has joined #openstack-dev10:46
*** MaxV has joined #openstack-dev10:46
*** mikal has joined #openstack-dev10:47
*** chuckieb has joined #openstack-dev10:49
*** gongysh has quit IRC10:53
*** avishay has joined #openstack-dev10:56
*** yolanda has joined #openstack-dev10:57
*** freedomhui has joined #openstack-dev10:58
*** iartarisi has joined #openstack-dev10:58
*** freedomhui has quit IRC11:02
*** k4n0 has left #openstack-dev11:02
*** psedlak_ has joined #openstack-dev11:03
*** doron_afk is now known as doron11:06
*** gmoro has quit IRC11:07
*** psedlak has quit IRC11:07
*** mjfork has quit IRC11:07
*** xBsd has quit IRC11:08
*** jaimegil has quit IRC11:08
*** xBsd has joined #openstack-dev11:09
*** jaimegil has joined #openstack-dev11:09
*** doron is now known as doron_afk11:13
*** ondergetekende_ has joined #openstack-dev11:15
*** Shaan7 has quit IRC11:16
*** feleouet has quit IRC11:19
*** Shaan7 has joined #openstack-dev11:20
*** gmoro has joined #openstack-dev11:20
*** devvesa has joined #openstack-dev11:23
*** doron_afk is now known as doron11:23
*** martyntaylor has quit IRC11:23
*** martyntaylor1 has joined #openstack-dev11:23
*** feleouet has joined #openstack-dev11:23
*** hailiang has quit IRC11:24
*** jprovazn has quit IRC11:25
*** martyntaylor1 has quit IRC11:25
*** dmakogon__ has joined #openstack-dev11:27
*** Ryan_Lane has joined #openstack-dev11:27
*** GheRivero_CH is now known as GheRivero11:27
*** xBsd has quit IRC11:28
*** adjohn has quit IRC11:30
*** dmakogon_ has quit IRC11:31
*** Ryan_Lane has quit IRC11:31
*** sshturm has joined #openstack-dev11:33
*** mjfork has joined #openstack-dev11:35
*** fbo_away is now known as fbo11:37
*** henrynash has quit IRC11:40
*** martyntaylor has joined #openstack-dev11:41
*** xga has joined #openstack-dev11:43
*** FunnyLookinHat has joined #openstack-dev11:45
*** xga_ has quit IRC11:46
*** drewlander has joined #openstack-dev11:50
*** feleouet has quit IRC11:56
boris-42markmc hi11:56
*** egallen has joined #openstack-dev11:57
*** adjohn has joined #openstack-dev11:57
*** dina_belova has joined #openstack-dev11:57
*** nsaje1 has quit IRC11:58
*** dina_belova has quit IRC11:58
*** rfolco has joined #openstack-dev11:58
*** doron is now known as doron_afk11:59
*** nayward has joined #openstack-dev11:59
*** feleouet has joined #openstack-dev12:01
*** CaptTofu has quit IRC12:05
*** pcm_ has joined #openstack-dev12:05
*** CaptTofu has joined #openstack-dev12:05
*** henrynash has joined #openstack-dev12:06
*** jjmb1 has joined #openstack-dev12:07
*** dina_belova has joined #openstack-dev12:07
*** mkollaro has joined #openstack-dev12:07
*** psedlak__ has joined #openstack-dev12:10
*** kushal has quit IRC12:10
*** dvarga has joined #openstack-dev12:10
*** jjmb has quit IRC12:10
*** donaldh has quit IRC12:10
*** dina_belova has quit IRC12:11
*** xBsd has joined #openstack-dev12:11
*** psedlak_ has quit IRC12:14
*** henrynash has quit IRC12:16
*** sandywalsh has quit IRC12:17
*** freedomhui has joined #openstack-dev12:20
*** woodspa has joined #openstack-dev12:21
*** alunch has quit IRC12:22
*** beagles has joined #openstack-dev12:24
*** vartom3 has quit IRC12:25
*** jruzicka has joined #openstack-dev12:26
*** dina_belova has joined #openstack-dev12:26
*** valgrind has quit IRC12:26
*** martine has joined #openstack-dev12:30
*** sandywalsh has joined #openstack-dev12:30
*** martine is now known as Guest3965312:30
*** Guest39653 is now known as martine_12:30
*** nayward has quit IRC12:31
*** gordc has joined #openstack-dev12:31
*** dina_belova has quit IRC12:32
*** bashok_ has quit IRC12:32
*** jaimegil has quit IRC12:33
*** terryh has joined #openstack-dev12:34
*** nayward has joined #openstack-dev12:35
*** feleouet has quit IRC12:37
*** donaldh has joined #openstack-dev12:39
*** feleouet has joined #openstack-dev12:41
*** doron_afk is now known as doron12:41
*** dprince has joined #openstack-dev12:46
*** jasondotstar has joined #openstack-dev12:47
*** nayward has quit IRC12:50
*** nayward has joined #openstack-dev12:50
*** ms_brown has joined #openstack-dev12:51
*** anteaya has joined #openstack-dev12:52
*** feleouet has quit IRC12:52
*** markmc has joined #openstack-dev12:55
*** adalbas has joined #openstack-dev12:55
*** xBsd has quit IRC12:55
*** doron is now known as doron_afk12:57
*** jprovazn has joined #openstack-dev12:57
*** doron_afk is now known as doron13:00
*** avishay has quit IRC13:02
*** tkammer has joined #openstack-dev13:03
*** erfanian has joined #openstack-dev13:04
*** xBsd has joined #openstack-dev13:05
*** ema_ has joined #openstack-dev13:06
*** avishay has joined #openstack-dev13:06
*** neelashah has joined #openstack-dev13:07
*** alexxu has joined #openstack-dev13:07
*** anniec has joined #openstack-dev13:07
*** gimps_ has joined #openstack-dev13:08
*** xga_ has joined #openstack-dev13:09
*** wolfdreamer has joined #openstack-dev13:09
*** doron is now known as doron_afk13:09
*** ema has quit IRC13:09
*** nayward has quit IRC13:10
*** anniec_ has joined #openstack-dev13:10
*** anniec has quit IRC13:12
*** anniec_ is now known as anniec13:12
*** xga has quit IRC13:12
*** kushal has joined #openstack-dev13:12
*** sc68cal_ has joined #openstack-dev13:14
*** bknudson has joined #openstack-dev13:14
*** jamey has joined #openstack-dev13:14
*** sthaha has joined #openstack-dev13:15
*** sc68cal_ has quit IRC13:15
*** kevinconway has quit IRC13:15
*** kbringard has joined #openstack-dev13:16
*** shadower_ has joined #openstack-dev13:16
*** villep_ has joined #openstack-dev13:17
*** creiht_ has joined #openstack-dev13:17
*** termie has joined #openstack-dev13:17
*** termie has quit IRC13:17
*** termie has joined #openstack-dev13:17
*** boris-42_ has joined #openstack-dev13:18
*** edleafe- has joined #openstack-dev13:20
*** boris-42 has quit IRC13:20
*** boris-42_ is now known as boris-4213:20
*** henrynash has joined #openstack-dev13:20
*** timello_ has joined #openstack-dev13:20
*** jayg|g0n3 is now known as jayg13:20
*** portante_ has joined #openstack-dev13:20
*** eharney has joined #openstack-dev13:21
*** jamespag` has joined #openstack-dev13:21
*** jamespag` has joined #openstack-dev13:21
*** CJM has joined #openstack-dev13:22
*** galstrom_zzz has quit IRC13:22
*** phschwartz has quit IRC13:22
*** hughsaunders has quit IRC13:22
*** shadower has quit IRC13:22
*** jamespage has quit IRC13:22
*** invsblduck has quit IRC13:22
*** CrackerJackMack has quit IRC13:22
*** edleafe has quit IRC13:22
*** sc68cal has quit IRC13:22
*** timello has quit IRC13:22
*** termie_ has quit IRC13:22
*** villep has quit IRC13:22
*** antonym has quit IRC13:22
*** creiht has quit IRC13:22
*** portante has quit IRC13:22
*** bcwaldon has quit IRC13:22
*** jmeredit has quit IRC13:22
*** oubiwann has quit IRC13:22
*** bcwaldon has joined #openstack-dev13:22
*** hughsaunders has joined #openstack-dev13:22
*** CJM is now known as Guest4727113:22
*** jamespag` has quit IRC13:22
*** invsblduck has joined #openstack-dev13:23
*** galstrom_zzz has joined #openstack-dev13:23
*** galstrom_zzz is now known as galstrom13:23
*** phschwartz has joined #openstack-dev13:25
*** burt has joined #openstack-dev13:26
*** jamespage has joined #openstack-dev13:26
*** avishay has quit IRC13:26
*** Steely_Dan is now known as dansmith13:27
*** antonym has joined #openstack-dev13:27
*** kevinconway has joined #openstack-dev13:27
*** erfanian has quit IRC13:29
*** lbragstad has joined #openstack-dev13:29
*** oubiwann has joined #openstack-dev13:30
*** feleouet has joined #openstack-dev13:32
*** eharney has quit IRC13:32
*** martyntaylor has quit IRC13:36
*** psedlak has joined #openstack-dev13:36
*** jecarey has joined #openstack-dev13:37
*** psedlak__ has quit IRC13:37
*** briancurtin has joined #openstack-dev13:37
*** alexxu has quit IRC13:38
*** martyntaylor has joined #openstack-dev13:39
*** xga has joined #openstack-dev13:40
*** adjohn has quit IRC13:41
*** xga_ has quit IRC13:43
*** briancurtin has quit IRC13:43
*** dina_belova has joined #openstack-dev13:43
*** pabelanger has quit IRC13:43
*** ema_ has quit IRC13:44
*** avishay has joined #openstack-dev13:45
*** tmclaugh[work] has joined #openstack-dev13:45
*** erfanian has joined #openstack-dev13:45
*** briancurtin has joined #openstack-dev13:46
*** eharney has joined #openstack-dev13:46
*** avishay has quit IRC13:47
*** dina_belova has quit IRC13:47
*** ruhe has quit IRC13:49
*** mdomsch has joined #openstack-dev13:49
*** doron_afk is now known as doron13:50
*** ruhe_ has joined #openstack-dev13:51
*** shadower_ is now known as shadower13:52
*** stevemar has joined #openstack-dev13:53
*** alunch has joined #openstack-dev13:53
*** rharwood has joined #openstack-dev13:53
*** alunduil has quit IRC13:56
*** sthaha has quit IRC13:57
*** jimfehlig has joined #openstack-dev13:57
*** jimfehlig has left #openstack-dev13:58
*** radez_g0n3 is now known as radez13:58
*** sumanthns has quit IRC13:58
*** FunnyLookinHat has quit IRC14:01
*** ruhe_ has quit IRC14:01
*** networkstatic has quit IRC14:02
*** networkstatic has joined #openstack-dev14:02
*** rwsu has joined #openstack-dev14:02
*** eharney has quit IRC14:04
*** litong has joined #openstack-dev14:05
*** xBsd has quit IRC14:05
*** psedlak_ has joined #openstack-dev14:05
*** cppcabrera has joined #openstack-dev14:06
*** JordanP has quit IRC14:07
*** adjohn has joined #openstack-dev14:08
*** jtomasek has quit IRC14:08
*** cppcabrera has left #openstack-dev14:08
*** vartom3 has joined #openstack-dev14:09
*** psedlak has quit IRC14:09
*** annegentle has joined #openstack-dev14:10
*** mikal has quit IRC14:11
*** otherwiseguy has quit IRC14:11
*** otherwiseguy has joined #openstack-dev14:11
*** ruhe has joined #openstack-dev14:11
*** mikal has joined #openstack-dev14:12
*** edmund has joined #openstack-dev14:12
*** rustlebee is now known as russellb14:13
*** drewlander has quit IRC14:15
*** tkammer has quit IRC14:16
*** blamar has joined #openstack-dev14:16
*** eharney has joined #openstack-dev14:17
*** tkammer has joined #openstack-dev14:18
*** vartom3 has quit IRC14:19
*** ajyounge has quit IRC14:20
*** rcleere has joined #openstack-dev14:20
*** ajyounge has joined #openstack-dev14:21
*** vartom3 has joined #openstack-dev14:21
*** changbl has quit IRC14:22
*** tkammer has quit IRC14:23
*** FunnyLookinHat has joined #openstack-dev14:25
*** yolanda has quit IRC14:25
*** markmcclain has joined #openstack-dev14:25
*** doron is now known as doron_afk14:26
*** mrunge has quit IRC14:27
*** markwash has quit IRC14:28
*** jruzicka has quit IRC14:28
*** xqueralt is now known as xqueralt-afk14:28
*** xqueralt-afk is now known as xqueralt14:28
*** rnirmal has joined #openstack-dev14:29
*** MaxV has quit IRC14:30
*** yolanda has joined #openstack-dev14:30
*** dolphm has joined #openstack-dev14:31
*** alunduil has joined #openstack-dev14:31
*** ftcjeff has joined #openstack-dev14:32
*** jruzicka has joined #openstack-dev14:33
*** fbo is now known as fbo_away14:33
*** chandankumar has quit IRC14:34
*** mmagr has quit IRC14:34
*** dkranz has joined #openstack-dev14:36
*** noslzzp has joined #openstack-dev14:37
dolphmlbragstad: fyi, i revised https://review.openstack.org/#/c/42224/14:37
roaetdolphm: that's my change!, what did you do to it again? I'm new here14:38
*** mdomsch has quit IRC14:39
dolphmroaet: what do you mean it's your change? it was authored by lbragstad (?)14:39
roaetthis one: https://review.openstack.org/#/c/42242/ ?14:39
dolphmroaet: no14:40
*** JordanP has joined #openstack-dev14:40
*** jvrbanac has joined #openstack-dev14:40
roaetOh i'm super confused14:40
roaetOHH14:40
*** datsun180b has joined #openstack-dev14:40
*** fbo_away is now known as fbo14:40
roaetholy crap.. That was weird.14:40
roaetMine is 42242, that is 4222414:41
roaetMy bad. Apologies.14:41
*** esheffield has joined #openstack-dev14:41
*** dmakogon has joined #openstack-dev14:41
*** MaxV has joined #openstack-dev14:43
lbragstaddolphm: awesome, thank you. I just caught up on the bug you subscribed me to.14:43
lbragstadTaking a look quick14:44
*** mlavalle has joined #openstack-dev14:44
*** matiu has joined #openstack-dev14:44
*** drewlander has joined #openstack-dev14:45
dolphmlbragstad: any chance you're going to tackle having keystone consume it's own notifications? i.e. revoking tokens asynchronously on tenant deletion? /me runs away14:45
dolphm(design summit session for icehouse!)14:46
*** creiht_ is now known as creiht14:46
*** JordanP has quit IRC14:46
lbragstaddolphm: I can look into that, I agree that would be a good topic for the summit14:47
dolphmlbragstad: it's not something i wanted to consider tackling during havana, but i think it's the next logical step, and will provide some pain relief!14:47
*** spzala has joined #openstack-dev14:49
*** mmagr has joined #openstack-dev14:49
lbragstaddolphm: right, I think we can manage getting the basic notification impl in to havana, and then use that to build on in Icehouse for keystone consuming it's own notifications. I am not sure if any other projects do that?14:49
*** nayward has joined #openstack-dev14:50
*** drewlander has quit IRC14:53
*** aeperezt has joined #openstack-dev14:53
*** iartarisi has quit IRC14:55
*** reidrac has quit IRC14:57
*** JordanP has joined #openstack-dev14:59
*** yjiang5 has joined #openstack-dev14:59
*** pabelanger has joined #openstack-dev14:59
*** freedomhu has joined #openstack-dev15:00
*** mmagr has quit IRC15:02
*** freedomhui has quit IRC15:03
*** freedomhui has joined #openstack-dev15:03
*** hartsocks has joined #openstack-dev15:03
*** jruzicka has quit IRC15:03
*** drewlander has joined #openstack-dev15:04
*** yaguang has joined #openstack-dev15:06
*** pmathews has joined #openstack-dev15:06
*** jruzicka has joined #openstack-dev15:06
*** leif has joined #openstack-dev15:07
*** prad_ has joined #openstack-dev15:07
*** leif is now known as Guest6917515:07
*** freedomhu has quit IRC15:07
*** MaxV has quit IRC15:07
*** JordanP has quit IRC15:08
*** ruhe has quit IRC15:09
*** alop has joined #openstack-dev15:09
*** jprovazn has quit IRC15:10
*** mars has joined #openstack-dev15:10
*** ruhe has joined #openstack-dev15:11
*** psedlak_ has quit IRC15:11
*** nayward has quit IRC15:13
*** nayward has joined #openstack-dev15:14
*** vartom4 has joined #openstack-dev15:14
*** sandeepr_ltp has joined #openstack-dev15:16
*** vartom3 has quit IRC15:16
*** jistr has quit IRC15:17
ayoungchmouel, so I am not sure if the REST endpoint to Our Gerrit is accessable15:18
chmouelayoung: i think fgerrit is using the ssh command, I don't think the REST was enabled  either (or at least last year when I checked)15:18
ayoungI'm running firebug, and the Javascript for, say posting a draft comment to a review goes to review.openstack.org/gerrit/rpc/PatchDetailService15:19
*** SergeyLukjanov has joined #openstack-dev15:19
*** changbl has joined #openstack-dev15:19
ayoungchmouel, it is json rpc:  {"jsonrpc":"2.0","method":"saveDraft","params":[{"author":{"id":2218},"key":{"patchKey":{"fileName":"keystoneclient/v2_0/tenants.py","patchSetId":{"changeId":{"id":28043},"patchSetId":22}}},"lineNbr":119,"message":"test","side":1,"status":"d","writtenOn":"2013-08-19 15:15:18.840000000"}],"id":4,"xsrfKey":"mHynRc-Hcr8FbQ-47X5FOUmqENi"}15:19
chmouelah nice15:20
chmouelayoung: i guess that's usable15:20
dolphmayoung: i use ssh15:20
ayoungchmouel, actually, that is pretty much what we used in FreeIPA.15:20
*** mrodden has quit IRC15:20
*** JordanP has joined #openstack-dev15:20
ayoungdolphm, to actually do a review?15:20
dolphmayoung: no, but i've done that too15:21
*** dina_belova has joined #openstack-dev15:21
chmoueli know some people is using fgerrit https://github.com/pandemicsyn/fgerrit with vim15:21
ayoungOK...gonna try it15:22
*** kbrierly has joined #openstack-dev15:23
ayoungchmouel, if this works, I might just have to package it for fedora...lets see if someone else has15:23
*** ruhe has quit IRC15:24
chmouelcool the author (pandemicsyn) is not on this chan but on #openstack-swift15:25
*** leif_ has joined #openstack-dev15:25
*** msdubov has joined #openstack-dev15:25
*** MaxV has joined #openstack-dev15:26
*** Guest69175 has quit IRC15:27
*** adjohn has quit IRC15:27
*** ruhe has joined #openstack-dev15:28
*** vartom4 has quit IRC15:28
*** bdpayne has joined #openstack-dev15:29
*** hartsocks has left #openstack-dev15:29
ayoungrcrit, you are going to like fgerrit, I think15:30
*** armax has joined #openstack-dev15:30
*** otherwiseguy has quit IRC15:31
ayoungchmouel, I have a new goal to go Mouse free.  Gerrit and Xchat are two of the biggest hurdles to overcome for that15:31
ayoungWell, web browser in general15:31
chmouelayoung: what about weechat for xchat?15:31
ayoungchmouel, maybe.  I am not sure I want to change clients yet15:32
ayoungI have to seeif I can fix xchat first15:32
lbragstadhey dolphm, looking at https://bugs.launchpad.net/keystone/+bug/1213284... in the bug report it says that it is because isEnabledFor wasn't introduced until python 2.7, but I found documentation for it in 2.6 http://docs.python.org/2.6/library/logging.html15:32
uvirtbotLaunchpad bug 1213284 in keystone "keystone's use of logging.isEnabledFor breaks python 2.6 compatibility" [Undecided,New]15:32
chmouelayoung: there is always the option to switch to everything emacs ;)15:32
dolphmlbragstad: hmm15:33
*** mrodden has joined #openstack-dev15:33
dolphmlbragstad: "Changed in version 2.7: The isEnabledFor() method was added to LoggerAdapter. This method delegates to the underlying logger."15:33
dolphmlbragstad: are we using it on a loggeradapter..?15:33
ayoungchmouel, always an option.  I am comfortable in both Emacs and Vi, but I am really more bash than emacs, and history in emacs often frustrates me.15:33
*** msdubov has quit IRC15:33
*** Tross has joined #openstack-dev15:35
chmouelayoung: history as redo/undo? or c-x c-f c-r ?15:35
ayoungchmouel, the latter15:35
lbragstaddolphm: I think this is using ContextAdapter... which now that makes sense15:35
lbragstaddolphm: https://github.com/openstack/keystone/blob/master/keystone/openstack/common/log.py#L23115:36
lbragstadand that inherits from logging.LoggerAdapter15:36
ayoungchmouel, so fgerrit seems OK as far as it goes, but it is just for the messaging side of the reviews.  git review shows the changes, but doesn't deal with making comments.  The two need to work toward the middle.15:37
*** sudorandom has joined #openstack-dev15:37
dolphmlbragstad: it looks like we have a couple uses of isEnabledFor, and at least one of them is absolutely, completely pointless15:37
*** boris-42 has quit IRC15:37
ayoungchmouel, fgerrit doesn't work on change id, just on the commit itself.  git review works on the change id.15:38
dolphmlbragstad: how big can ldap_attrs be in keystone.common.ldap.core.add_s()?15:38
dolphmlbragstad: same question for ldap_modlist in modify_s()15:38
*** JordanP has quit IRC15:39
*** boris-42 has joined #openstack-dev15:39
*** yjiang5 has left #openstack-dev15:39
*** martine_ has quit IRC15:40
lbragstaddolphm: hmm I am not sure.. looks like ayoung made a commit relating to that15:40
dolphmlbragstad: two approaches that come to mind for me, depending on the necessity of isEnabledFor... http://pasteraw.com/yc7tdez4snu5sqw68n7ap10rlql64r15:40
lbragstaddolphm: that makes sense15:41
dolphmlbragstad: it's pointless in search_s, but just a performance gain in wsgi.Debug15:41
*** drewlander has quit IRC15:42
*** reed has joined #openstack-dev15:44
*** tkammer has joined #openstack-dev15:45
*** blamar_ has joined #openstack-dev15:45
*** donaldh has quit IRC15:45
*** blamar has quit IRC15:45
*** blamar_ is now known as blamar15:45
*** radez is now known as radez_g0n315:50
*** JordanP has joined #openstack-dev15:51
bknudsonseems strange we'd be so concerned about the performance of some log statements but then not about the performance of doing a new connection and bind for every operation.15:51
*** drewlander has joined #openstack-dev15:52
*** jmontemayor has joined #openstack-dev15:52
*** vsergeyev has left #openstack-dev15:52
* lsmola is away: Away15:53
*** ruhe has quit IRC15:53
*** adjohn has joined #openstack-dev15:54
*** SergeyLu_ has joined #openstack-dev15:54
dolphmbknudson: ++15:55
dolphmi'd be fine with removing all the isEnabledFor, unless there's a crazy amount of data in one of those dicts (or lists, or whatever they were)15:56
dolphmlbragstad: ^15:56
bknudsondolphm: lbragstad: me too15:56
lbragstaddolphm: ok, yeah that happens a few times within keystone/common/ldap/core.py15:57
*** SergeyLukjanov has quit IRC15:57
*** sarob has joined #openstack-dev15:57
lbragstadhttps://github.com/openstack/keystone/blob/master/keystone/common/ldap/core.py#L521 https://github.com/openstack/keystone/blob/master/keystone/common/ldap/core.py#L511 https://github.com/openstack/keystone/blob/master/keystone/common/ldap/core.py#L58815:57
*** martyntaylor1 has joined #openstack-dev15:57
*** mmagr has joined #openstack-dev15:58
*** Tross has quit IRC15:58
lbragstadthose should be the three cases where it is used in keystone/common/ldap/core.py15:58
*** Tross has joined #openstack-dev15:58
dolphmlbragstad: yep15:58
bknudsonthose don't look expensive to me.15:58
lbragstaddolphm bknudson: sounds good, I'll remove those and then apply the fix that dolphm suggested in keystone/common/wsgi.py15:59
*** ruhe has joined #openstack-dev15:59
dolphmlbragstad: there's two in wsgi though- http://pasteraw.com/i5o7317320wv1i36wb44okyf1e0wrxk16:00
*** martyntaylor has quit IRC16:00
*** nayward has quit IRC16:01
lbragstaddolphm: ok16:01
ayoungbknudson, "the performance of doing a new connection and bind for every operation."  you are right.  For LDAP, we probably should do either connection pooling.  Or, even better, we use the connection from the simplebind and then LDAP operations are done using the ACLs of the user and not an admin16:02
ayounglbragstad, and I am totally fine with removing copious amounts of logging from ldap core.  \16:02
lbragstadayoung:  cool, that sounds like the plan then... I'll push something up shortly16:03
bknudsonayoung: the logs when running with debug are ridiculous... mostly because a) there's a lot of ops, and b) the log message is several lines.16:03
*** aelkikhia has joined #openstack-dev16:05
*** alexb_ has joined #openstack-dev16:05
*** tkammer has quit IRC16:07
*** henrynash has quit IRC16:08
*** zbitter has joined #openstack-dev16:09
*** drewlander has quit IRC16:09
*** otherwiseguy has joined #openstack-dev16:09
*** safchain has quit IRC16:10
*** ruhe has quit IRC16:12
*** alexb_ has quit IRC16:12
*** zaneb has quit IRC16:13
*** SergeyLu_ has quit IRC16:14
*** boris-42 has quit IRC16:16
*** aelkikhia1 has joined #openstack-dev16:18
*** MaxV has quit IRC16:19
lbragstadbknudson: dolphm ayoung thanks for the help guys, FYI https://review.openstack.org/#/c/42674/16:19
*** cthulhup has joined #openstack-dev16:20
bknudsonlbragstad: what did we do before the unified logging that worked with 2.6?16:20
*** jcoufal has joined #openstack-dev16:20
*** jcoufal has quit IRC16:21
*** matel has quit IRC16:21
*** n0ano has joined #openstack-dev16:21
*** tong|2 has joined #openstack-dev16:21
dolphmlbragstad: i'm not sure this was broken by unified logging (was it?)16:21
*** aelkikhia1 has quit IRC16:21
bknudsonthe bug report said it was broken by https://github.com/openstack/keystone/commit/0c2fc69ba15d8a0a0c045294495503e451501ac9#keystone/common/wsgi.py16:23
*** aelkikhia1 has joined #openstack-dev16:24
*** litong has quit IRC16:24
bknudsonok, it was using isEnabledFor before, and it still is.16:24
bknudsonbut switched from from keystone.common import logging to from "keystone.openstack.common import log as logging"16:25
*** aelkikhia1 has quit IRC16:25
*** aelkikhia has quit IRC16:25
*** BobBall is now known as BobBall_Away16:25
*** aelkikhia has joined #openstack-dev16:25
*** anniec has quit IRC16:25
*** pabelanger has quit IRC16:26
*** freedomhui has quit IRC16:26
*** xga_ has joined #openstack-dev16:28
dolphmlbragstad: making this change work https://review.openstack.org/#/c/42224/ required even more fixes, so i split them out into https://review.openstack.org/#/c/42676/16:29
dolphmbknudson: logging related stuff if you want to review ^16:30
*** sushils has quit IRC16:30
*** markmc has quit IRC16:30
dolphmayoung: bknudson: speaking of, here's two other easy reviews- https://review.openstack.org/#/c/40102/ https://review.openstack.org/#/c/41598/16:30
*** derekh has quit IRC16:31
*** SumitNaiksatam has quit IRC16:31
*** markwash has joined #openstack-dev16:31
*** xga has quit IRC16:31
*** drewlander has joined #openstack-dev16:31
*** rcrit has quit IRC16:31
lbragstaddolphm: bknudson I think it was broken by moving to a ContextAdapter in the unified logging change. Before that it was just using keystone/logging.py16:32
lbragstador.. keystone/common/logging.py16:32
*** tong|2 has quit IRC16:32
*** litong has joined #openstack-dev16:32
*** sarob has quit IRC16:33
lbragstaddolphm:  +1 and thanks https://review.openstack.org/#/c/42676/16:33
*** sarob has joined #openstack-dev16:33
*** sdake has joined #openstack-dev16:33
*** zbitter is now known as zaneb16:34
*** jpich has quit IRC16:34
*** Tross has quit IRC16:34
*** adjohn has quit IRC16:34
*** Tross has joined #openstack-dev16:34
*** rcrit has joined #openstack-dev16:36
*** xga_ has quit IRC16:36
lbragstadbknudson: dolphm I think another thing that broke this was the fact that everything in keystone was referencing log levels using logging.DEBUG... https://github.com/openstack/keystone/blob/master/keystone/common/logging.py#L30 which isn't something that exists in the oslo-implementation16:37
*** ajyounge has quit IRC16:38
*** ajyounge has joined #openstack-dev16:38
*** aelkikhia has left #openstack-dev16:39
*** nshaikh has left #openstack-dev16:40
*** ajyounge has quit IRC16:40
*** ajyounge has joined #openstack-dev16:41
*** cmark_ has quit IRC16:41
*** adjohn has joined #openstack-dev16:42
*** jfriedly has joined #openstack-dev16:44
*** jbresnah has joined #openstack-dev16:45
*** tjones has joined #openstack-dev16:46
*** wolfdreamer has quit IRC16:46
*** marun has joined #openstack-dev16:46
*** sarob has quit IRC16:47
*** ruhe has joined #openstack-dev16:48
dolphmlbragstad: can we use the ones from stdlib logging to do the same thing, or does oslo expose them somehow?16:49
dolphmlbragstad: or should we not be using them at all?16:50
*** afazekas_ has joined #openstack-dev16:51
*** zoresvit has quit IRC16:51
lbragstaddolphm: I'll have to check, I don't *think* the oslo implementation exposes them16:51
*** fbo is now known as fbo_away16:53
*** JordanP has quit IRC16:55
*** yaguang has quit IRC16:55
*** zoresvit has joined #openstack-dev16:55
*** adjohn has quit IRC16:57
*** cthulhup has quit IRC16:58
*** mmagr has quit IRC17:01
*** ruhe has quit IRC17:02
*** wolfdreamer has joined #openstack-dev17:02
*** pabelanger has joined #openstack-dev17:03
*** SumitNaiksatam has joined #openstack-dev17:04
*** jrgcombr has quit IRC17:06
*** anniec has joined #openstack-dev17:07
*** Ryan_Lane has joined #openstack-dev17:07
*** JordanP has joined #openstack-dev17:07
*** salv-orlando has joined #openstack-dev17:09
*** roampune has joined #openstack-dev17:11
*** nati_ueno has joined #openstack-dev17:11
*** doron_afk has quit IRC17:11
*** aelkikhia has joined #openstack-dev17:11
*** networkstatic has quit IRC17:12
*** networkstatic has joined #openstack-dev17:12
*** ruhe has joined #openstack-dev17:12
*** dims has joined #openstack-dev17:13
*** cmark has joined #openstack-dev17:13
*** networkstatic has quit IRC17:13
*** zoresvit has quit IRC17:15
*** xqueralt is now known as xqueralt-afk17:15
*** egallen has quit IRC17:16
*** JordanP has quit IRC17:16
*** colinmcnamara has joined #openstack-dev17:16
*** ndipanov is now known as ndipanov_gone17:16
*** zoresvit has joined #openstack-dev17:17
nati_uenopcm_: around?17:18
*** burt has quit IRC17:18
*** arosen has left #openstack-dev17:20
*** avishay has joined #openstack-dev17:20
*** arezadr has joined #openstack-dev17:20
*** arosen has joined #openstack-dev17:20
*** anfrolov has joined #openstack-dev17:22
*** jcoufal has joined #openstack-dev17:25
*** jcoufal has quit IRC17:26
*** egallen has joined #openstack-dev17:26
*** mlavalle has quit IRC17:26
stevemarayoung: ping17:27
ayoungstevemar, yep17:28
stevemarhttps://review.openstack.org/#/c/40283/3/keystone/tests/_ldap_livetest.py17:28
*** vaml has joined #openstack-dev17:28
ayoungdolphm, https://review.openstack.org/#/c/40102/  seems so right, I can't help but wonder how it is going to burn us.17:28
*** donaldh has joined #openstack-dev17:28
*** afazekas is now known as afazekas_zz17:28
stevemarayoung: line 186, what's goin on17:28
ayoungstevemar, that is where I steal money from your online banking17:29
ayoungstevemar, its in the API doc17:29
stevemarayoung: jokes on you! i ain't got any money17:29
*** ruhe has quit IRC17:29
*** MaxV has joined #openstack-dev17:29
ayoungstevemar, not anymore you don't. But you had $8.35 that is now mine17:29
*** cmark has quit IRC17:30
ayoungstevemar, I check that each user gets added, and the number of results coming back is the same as the number of users added17:30
stevemarayoung: how does are there users in groups at that point?17:30
ayoung test_groups.append(new_group)17:30
ayoung18317:30
ayoung184            group_refs = self.identity_api.list_groups_for_user(17:30
ayoung185                test_users[0]['id'])17:30
ayoung186            self.assertEquals(len(group_refs), x)17:30
*** briancurtin has quit IRC17:30
stevemarayoung: oh, jeez, nvm, i hadn't reached the end of the loop yet, didn't see the add17:30
ayoungstevemar, syntax error17:30
*** Tross has quit IRC17:30
ayoungin your question17:30
stevemarayoung: true17:31
ayoungstevemar, it isn't super obvious, but then again, neither is the whole zero versus one indexing of arrays17:31
stevemar>.<17:31
*** martyntaylor has joined #openstack-dev17:32
stevemarayoung: gotcha17:32
ayoungdolphm, you are certain that adding a version identifier to the v2 and v3 token APIs is kosher?17:32
*** donaldh has quit IRC17:32
dolphmayoung: it's already in the method signature, either way17:33
*** MaxV has quit IRC17:33
*** martyntaylor1 has quit IRC17:34
ayoungdolphm, yeah, I mean adding it to the data returned.  It would make a lot of code cleaner, and since tokens expire so quickly, seems like there should not be a problem.. What about differential deployments?17:34
*** amohn9 has joined #openstack-dev17:35
ayoungLike, if someone is still running Grizzly\17:35
ayoungDo we need to hold off on relying on this value in, say auth_token middle ware for a release or so?17:35
*** jcoufal has joined #openstack-dev17:35
*** martyntaylor has quit IRC17:36
bknudsonayoung: part of fix for problem lots of users are seeing -- https://review.openstack.org/#/c/42676/17:36
bknudsonayoung: oops, never mind, this is a different change.17:37
*** jcoufal has quit IRC17:40
*** SumitNaiksatam has quit IRC17:41
*** Farooque has joined #openstack-dev17:41
*** garyk has quit IRC17:42
*** moted has quit IRC17:43
*** moted has joined #openstack-dev17:43
*** mlavalle has joined #openstack-dev17:44
*** nayward has joined #openstack-dev17:44
*** comay has quit IRC17:45
*** neelashah has quit IRC17:46
*** aelkikhia has left #openstack-dev17:47
*** Farooque has left #openstack-dev17:47
*** melwitt has joined #openstack-dev17:47
*** nachi has joined #openstack-dev17:48
*** donaldh has joined #openstack-dev17:48
nachibknudson: I have implemented your comment. Please review https://review.openstack.org/#/c/31290/17:48
*** grv has joined #openstack-dev17:49
*** pabelanger has quit IRC17:50
*** dina_belova has quit IRC17:51
*** afazekas_ has quit IRC17:51
*** donaldh has quit IRC17:52
*** odyssey4me3 has quit IRC17:55
*** martyntaylor has joined #openstack-dev17:55
*** pabelanger has joined #openstack-dev17:56
*** lucasagomes is now known as lucas-hungry17:56
*** jmontemayor_ has joined #openstack-dev17:56
*** jmontemayor has quit IRC17:59
*** henrynash has joined #openstack-dev17:59
*** neelashah has joined #openstack-dev17:59
*** dina_belova has joined #openstack-dev18:00
*** colinmcnamara has quit IRC18:00
*** radez_g0n3 is now known as radez18:02
*** aelkikhia has joined #openstack-dev18:02
*** jvrbanac has quit IRC18:02
*** boris-42 has joined #openstack-dev18:02
*** morganfainberg|a is now known as morganfainberg18:04
*** aelkikhia1 has joined #openstack-dev18:06
*** aelkikhia1 has left #openstack-dev18:06
*** giulivo has quit IRC18:06
*** briancurtin has joined #openstack-dev18:07
morganfainbergayoung: yeah, you're right (the kwargs smash one), i should have split that into 2 patchsets.18:08
*** pabelanger has quit IRC18:08
jswarrenSeeing same Jenkins failure with gate-grenade-devstack-vm in several seemingly unrelated changes.  For instance https://review.openstack.org/#/c/41573/ and https://review.openstack.org/#/c/40232/  Something about the inability to find any typelib for GnomeKeyring and --public not being a valid option for glance.18:08
*** aelkikhia has quit IRC18:08
*** nachi has left #openstack-dev18:09
ayoungmorganfainberg, too late18:09
morganfainbergayoung: hehe, next time.18:09
ayoungmorganfainberg, its fine, as these all do sortof support the same functionality,18:10
ayoungand it is easy enough to review as is18:10
ayoungmorganfainberg, in general, the smaller the patch the easier it is to get people to review it18:10
jswarrenMaybe a problem with Jenkins?18:10
morganfainbergayoung: yeah, it's why i split the Flake8 ones out.18:10
morganfainbergfor keystoneclient18:10
* ayoung has a lot of review request 18:11
morganfainbergand why i'm limiting the scope of the caching one.18:11
morganfainbergayoung: busy busy busy18:11
*** drewlander has quit IRC18:11
*** Shaan7 has quit IRC18:11
*** Shaan7 has joined #openstack-dev18:11
*** briancurtin has quit IRC18:12
*** Yathi has joined #openstack-dev18:12
*** Yathi has quit IRC18:13
*** jvrbanac has joined #openstack-dev18:14
*** briancurtin has joined #openstack-dev18:15
*** jswarren has quit IRC18:15
*** jswarren has joined #openstack-dev18:16
*** SumitNaiksatam has joined #openstack-dev18:16
*** rihnapstor has joined #openstack-dev18:17
*** johnthetubaguy has quit IRC18:17
*** colinmcnamara has joined #openstack-dev18:18
*** colinmcnamara has quit IRC18:19
*** _ffio_ has joined #openstack-dev18:20
*** xqueralt-afk is now known as xqueralt18:20
*** vaml has quit IRC18:21
*** ffio_ has quit IRC18:21
lbragstadjswarren: I am seeing the same thing on my keystone patches...18:21
*** vipul is now known as vipul-away18:21
*** lexinator has joined #openstack-dev18:22
*** MaxV has joined #openstack-dev18:27
*** donaldh has joined #openstack-dev18:27
*** SergeyLukjanov has joined #openstack-dev18:28
jswarrenlbragstad: Is openstack-infra the right place to report such problems?18:29
lbragstadjswarren: yep18:30
*** xga has joined #openstack-dev18:33
ayoungchmouel, xkbset mousekeys18:34
*** xBsd has joined #openstack-dev18:36
*** burt has joined #openstack-dev18:37
*** xga has quit IRC18:37
*** yolanda has quit IRC18:38
*** vipul-away is now known as vipul18:39
*** kushal has quit IRC18:40
*** tjones has quit IRC18:40
*** jmontemayor_ has quit IRC18:41
*** anniec has quit IRC18:43
*** jmontemayor has joined #openstack-dev18:44
*** amerine has quit IRC18:45
*** MaxV has quit IRC18:46
*** amerine has joined #openstack-dev18:46
*** lucas-hungry is now known as lucasagomes18:46
*** MaxV has joined #openstack-dev18:47
*** grv has quit IRC18:47
*** d34dh0r53 has quit IRC18:49
*** novas0x2a|laptop has joined #openstack-dev18:50
*** nayward has quit IRC18:53
*** nachi has joined #openstack-dev18:55
*** Tross has joined #openstack-dev18:58
*** ruhe has joined #openstack-dev18:58
*** herndon has joined #openstack-dev19:00
*** bknudson has quit IRC19:02
*** anniec has joined #openstack-dev19:03
*** jecarey has quit IRC19:05
*** nati_uen_ has joined #openstack-dev19:06
*** jecarey has joined #openstack-dev19:06
*** jvrbanac has quit IRC19:06
*** _ffio_ has quit IRC19:08
*** nati_ueno has quit IRC19:08
*** alunduil has quit IRC19:08
*** ruhe has quit IRC19:09
*** vartom4 has joined #openstack-dev19:09
*** jvrbanac has joined #openstack-dev19:10
*** neelashah1 has joined #openstack-dev19:11
*** neelashah has quit IRC19:12
*** rihnapstor has quit IRC19:14
*** bknudson has joined #openstack-dev19:18
*** fbo_away is now known as fbo19:27
*** alexb_ has joined #openstack-dev19:27
*** MaxV has quit IRC19:29
*** hemna has joined #openstack-dev19:29
*** pabelanger has joined #openstack-dev19:30
*** aelkikhia has joined #openstack-dev19:31
*** hemna has quit IRC19:34
*** hemna has joined #openstack-dev19:34
*** aelkikhia has left #openstack-dev19:34
*** egallen has quit IRC19:35
*** xqueralt is now known as xqueralt-afk19:37
*** nati_uen_ has quit IRC19:41
*** tjones has joined #openstack-dev19:42
*** renier_ has joined #openstack-dev19:42
*** nati_ueno has joined #openstack-dev19:42
*** renier_ has left #openstack-dev19:42
vipulis this the right place to ask keystone questions?19:49
vipulwhy do we get different tokens when hitting /v2.0/tokens twice19:50
*** sandywalsh has quit IRC19:53
*** derekh has joined #openstack-dev19:54
lbragstadvipul: yes, this is the place. Most of the keystone cores hangout here.19:57
vipullbragstad: thanks!19:57
*** gimps_ has quit IRC19:57
*** SlickNik has joined #openstack-dev19:59
*** dolphm has quit IRC19:59
*** colinmcnamara has joined #openstack-dev20:00
*** lucasagomes has quit IRC20:02
ayoungvipul, tokens do not get reissued20:03
ayoungvipul, the two tokens have different expiration times20:03
*** avishay is now known as avishay_zzz20:03
*** otherwiseguy has quit IRC20:03
*** dolphm has joined #openstack-dev20:03
*** sarob has joined #openstack-dev20:05
vipulayoung: thanks, is there any way to force reuse?20:06
*** sandywalsh has joined #openstack-dev20:06
vipulayoung: doesn't work too well we're finding out with a sql backend20:06
*** mdomsch has joined #openstack-dev20:07
ayoungvipul, no20:07
ayoungvipul, and I would argue against it20:07
ayoungyou are looking for a solution, but that is not it20:07
ayoungOTOH I think that this is:20:07
ayoungeither schedule a cron job to clean up the tokens once every, oh, say minute20:08
ayoungkeystone-manage token_flush20:08
ayoungvipul, or we put something into the API to force a clean up.20:09
vipultoken_flush will remove the expired tokens?20:09
ayoungvipul, yep20:09
vipulayoung: Ok, we'll try that.  Thank for the pointer!20:10
*** alunduil has joined #openstack-dev20:10
ayoungvipul and thus we have not yet put anything into the code.20:10
vipulayoung: how about using memcached backedn is that recommended?20:11
*** shri has joined #openstack-dev20:12
*** jecarey has quit IRC20:17
*** jecarey_ has joined #openstack-dev20:17
*** dolphm_ has joined #openstack-dev20:18
*** dolphm has quit IRC20:18
*** xBsd has quit IRC20:19
*** bswartz has quit IRC20:19
*** amohn9 has quit IRC20:19
*** briancurtin has quit IRC20:21
*** boden has quit IRC20:21
*** neelashah1 has quit IRC20:22
*** bswartz has joined #openstack-dev20:22
*** vaml has joined #openstack-dev20:23
*** sandywalsh has quit IRC20:23
*** vipul is now known as vipul-away20:23
*** vipul-away is now known as vipul20:23
*** openstackstatus has joined #openstack-dev20:27
*** bknudson has quit IRC20:27
openstackstatusNOTICE: gate-grenade-devstack-vm is currently failing preventing merges. Proposed fix: https://review.openstack.org/#/c/42720/20:27
*** ChanServ changes topic to "gate-grenade-devstack-vm is currently failing preventing merges. Proposed fix: https://review.openstack.org/#/c/42720/"20:27
*** yjiang5_ is now known as yjiang520:29
morganfainbergvipul: the memcache backend has both benefits and downsides.  It really depends on how much token issuance/churn you are seeing (and if you're using master or stable/grizzly)20:30
*** wolfdreamer has quit IRC20:31
*** harlowja_ has quit IRC20:31
morganfainbergvipul: but the memcache backend doesn't suffer from the same types of performance issues (and lingering tokens) that SQL does.20:31
*** harlowja has joined #openstack-dev20:31
*** MaxV has joined #openstack-dev20:32
*** amohn9 has joined #openstack-dev20:33
marsHi all - do I have to take any action after the gate-grenade-devstack-vm tests are fixed in order for Jenkins to re-test my proposed changes?20:36
*** sandywalsh has joined #openstack-dev20:36
jswarrenmars, review your change with the comment "recheck no bug"20:37
jswarrenIf it's not done automatically.20:38
*** jruzicka has quit IRC20:38
marsjswarren, thanks20:38
*** vipul is now known as vipul-away20:38
chmouelreview request on that review please https://review.openstack.org/#/c/40448/20:40
*** martine has joined #openstack-dev20:44
*** martine is now known as Guest3620620:44
*** vipul-away is now known as vipul20:46
*** egallen has joined #openstack-dev20:46
*** dvarga has quit IRC20:46
*** henrynash has quit IRC20:47
*** networkstatic has joined #openstack-dev20:47
*** wolfdreamer has joined #openstack-dev20:48
dolphm_morganfainberg: there's a summit talk proposed about backing tokens to riak, but i haven't seen open source impl20:50
morganfainbergdolphm_: interesting. i think i saw that talk, can't remember how i voted on it.20:50
*** bknudson has joined #openstack-dev20:50
*** tmclaugh[work] has quit IRC20:51
morganfainbergdolphm_: I haven't looked at riak much, but the executive summary sounds pretty awesome.20:51
* chmouel was looking over riak source code the other time and the erlang burned my eyes20:52
*** dolphm_ has quit IRC20:53
*** sushils has joined #openstack-dev20:54
morganfainbergah crud.  i probably should have waited on the approval of that one chmouel, sorry.  gate is being tempermental till that glance fix gets in.20:54
chmouelmorganfainberg: oh yeah I forgot it was broken :)20:55
morganfainbergchmouel: it's all good, once it's fixed, i'll probably sweep through and get things back on track if someone doesn't beat me to it.20:56
ayoungmorganfainberg, we probably need a generic "persistant Key value store"  mechanism for Keystone that will talk to all of the various things people are proposing, with an insulation layer between, say tokens and the persistence layer.20:56
ayoungvipul, don't use memcached if you can avoid it.  Too many problems20:56
ayoungno persistance of revocation list is probably biggest downside20:57
*** garyk has joined #openstack-dev20:57
chmouelayoung: what would be different between a volatile and non volatile backend?20:58
chmoueli mean we just need to have memcache backend dropped and be used as a cache instead of backend20:58
morganfainbergayoung: it becomes a question of what "persistence" layer we should be looking at.  I mean, I could (with the new caching stuff) leverage the file-backed dogpile stuff, which at least prevents the need for a separate daemon.  but I'm not sure on performance there.20:58
morganfainbergchmouel: i'm of the opinion memcache token driver needs to be deprecated.20:59
morganfainbergchmouel: memcache is not really suitable for anything besides a cache that can be reconstituted.20:59
ayoungchmouel, I would say probably "nothing"20:59
chmouelmorganfainberg: agreed20:59
ayoungbut agree memcached is not supposed to be a persistance driver20:59
*** colinmcnamara has quit IRC21:00
ayoungit made sense in the days before token revocation, because if you restart keystone, it just means that no old tokens are valid21:00
*** amohn9 has quit IRC21:00
vipulso the issue is stable/grizzly afaict doens't support multi-process either.. and sql backed has proven to be too slow.. any other options?21:00
vipulis it still better to do something to uWSGI and continue to use sql backend?21:01
ayoungPersonally, I think that we need to just clean up tokens in SQL and be done with it.21:01
*** emagana has joined #openstack-dev21:01
*** anniec has quit IRC21:01
*** briancurtin has joined #openstack-dev21:01
morganfainbergvipul: stable/grizzly supports HTTPD implementation.21:01
ayoungAll this search for KVS persistence is misguided.21:01
*** lexinator1 has joined #openstack-dev21:01
morganfainbergayoung: with SQL cleaned up and the caching layer, it should be performant enough21:01
ayoungI've ranted this before, but the real solution is to not record tokens at all.  Delegations instead of long lived tokens21:01
*** jamielennox|away is now known as jamielennox21:01
vipulmorganfainberg: You are talkign abot running mod_wsgi in apache?21:02
*** sarob has quit IRC21:02
ayoungmorganfainberg, so longas you invalidate the cache on each revocation event, yes21:02
morganfainbergvipul: yes.  we use it at the company i work at.21:02
morganfainbergayoung: i am doing that.21:02
*** Guest36206 has quit IRC21:02
*** lexinator has quit IRC21:02
ayoungmorganfainberg, schaweeet!21:02
morganfainbergayoung: the caching layer code review (implements caching and token caching) is pending requirements getting dogpile.cache in21:02
morganfainbergmost the rest is done.21:03
ayoungmorganfainberg, link?21:03
morganfainbergayoung: https://review.openstack.org/#/c/41208/21:03
morganfainbergsubsequent changesets will do assignment caching, identity, policy, catalog, etc21:03
vipulmorganfainberg: this is valid for grizzly? http://keystone.readthedocs.org/en/latest/deploying-keystone.html21:03
morganfainbergvipul: i think this is the one i was using: http://docs.openstack.org/developer/keystone/apache-httpd.html21:04
morganfainbergayoung: of course, each subsystem will be evaluated before adding caching (benfit vs. overhead)21:05
vipulmorganfainberg: cool! thanks!21:05
morganfainbergvipul: of course!  I think ayoung also has a good blog post about it21:05
ayoungmorganfainberg, good stuff.  I'll let you clean that up a bit before reviewing21:06
ayoungvipul, all the cool kids are running in HTTPD21:06
ayounggets you Kerberos, real SSL, X509, better threading support....21:07
*** litong has quit IRC21:07
*** derekh has quit IRC21:07
morganfainbergayoung: yeah. it's close. once i'm done getting requirements in place that will be on the fast-track to cleanup.21:07
morganfainbergat the very least for H i want token caching, if not identity and assignment as well.21:07
*** carl_baldwin has joined #openstack-dev21:07
ayoungchmouel, I installed xkbset and ran xkset mousekeys.  I put my mouse out of reach and now I am all Keyboard.21:08
*** woodspa has quit IRC21:08
*** colinmcnamara has joined #openstack-dev21:08
chmouelayoung: really21:08
ayoungyep...21:08
* chmouel really should go back to using linux21:08
ayoungchmouel, shoulder has been bothering me, I think due to mouse use.  THis is an attempt to be a little more even handed21:08
ayoungchmouel, works for other OSes as well21:08
ayoungchmouel, look at wikipedia article21:09
chmoueli'm loooking on http://www.math.missouri.edu/~stephen/software/21:09
ayoungchmouel, https://en.wikipedia.org/wiki/Mouse_keys21:09
chmouelbut can't see how that works21:09
ayoungchmouel, does your Keyboard have a number pad?21:10
chmouelah ok i see, I mostly use a trackpad on a laptop and not much a mouse but I rem back in the days when using mouse was giving me bad shoulder21:10
chmouelayoung: no it's a standard laptop  keyboard21:11
chmouelbut i guess there is way to remap that with some tools21:11
clarkbwith vimperator and a tiling window manager you don't need a mouse for much21:11
*** terryh has quit IRC21:11
ayoungchmouel, at home and at work I use an external keyboard and monitor. I only use laptop in laptop mode when travelling21:11
chmouelayoung: you are a climber, right? shoulder bothering you may be coming from this?21:11
*** SergeyLukjanov has quit IRC21:11
*** hemna has quit IRC21:12
ayoungchmouel, origianlly from wrestling.  Strained the ligament at the match at Brockton High and it never was the same since21:12
*** gordc has quit IRC21:12
morganfainbergayoung: gym climbing or outdoors?21:12
ayoungchmouel, but, yes, I did a number on it climbing too21:12
ayoungmorganfainberg, both21:12
morganfainbergayoung: nice.  yeah, I feel spoiled here in SoCal, we have some good climbing (but i haven't been in years).21:13
*** pabelanger has quit IRC21:13
ayoungmorganfainberg, http://jessandadam.com/Pictures/2003/EichornPinnacle/21:13
morganfainbergNICE.21:13
ayoungmorganfainberg, "some"  might be the understatement of the day21:13
chmouelayoung: nice for the pics21:13
ayoungmorganfainberg, J-Tree. Needles.  East Side of the Sierras.21:14
chmouelinjury sucks21:14
morganfainbergayoung: pinacles, though j-tree and pinacles have quartz granite21:14
ayoungchmouel, I lost my best ones in a server mismanagement years ago. I did my hardest climing in 99-200021:14
ayoungspent many weekend in Yosemite.21:14
morganfainbergi prefere idyllwild21:14
ayoungNow I have kids21:14
chmouelheh21:14
morganfainbergah, yosemite.  ahhhhh21:15
ayoungyep21:15
morganfainbergreminds me i need to book a trip up there soon.21:15
morganfainberg(soon = within the next year)21:15
*** martyntaylor has quit IRC21:15
chmouelyou guys lucky, there is no many climbing around Paris21:15
morganfainbergand by book, i mean, take days off work and do a cathedral peak day.21:15
*** donaldh has quit IRC21:15
chmouel(or for what is worth mountains)21:16
ayounghttp://adam.younglogic.com/climbing/foot-in-crack/21:16
ayoungmorganfainberg, catherdral is a highway21:16
morganfainbergayoung: it is, but it's a good first day.21:17
ayoungDo the regular route of Daff21:17
morganfainberghmm. thats a good idea too21:17
ayoungfirst pitch i 5.9, but it is one mopve and you can cheat through it21:17
ayoungFantastic route21:17
ayoungwest crack21:17
ayoungPhobos and Deimos are phun21:17
morganfainbergnice.  i'll co-opt my brother to go w/ me.  go do a few days up there.21:18
*** boris-42 has quit IRC21:18
ayoungmorganfainberg, yeh.  Oh, also, the 5.0 up tenaya peak is supposed to be superb.  Long pseudo climbing route21:18
ayoungnever did it, but probably a lot fewer people than Cathedral21:18
morganfainbergayoung: i think my dad told me that one was awesome.21:19
ayoungmorganfainberg, getting late in the year, time to head back to Yose valley anyway, no need to beat the heat in Tuolomne in September/October21:19
ayoungmorganfainberg, ever do snake dike?21:19
morganfainbergi've spent more time up on tahquitz than up on the yosemite stuff21:19
morganfainbergand suicide rock.21:20
stevemarayoung: morganfainberg: y'all are crazy.21:20
morganfainbergthough suicide is a bit polished by the number of climbers.21:20
ayounghttp://jessandadam.com/Pictures/2001-2002/halfdome/tn/p1010006.jpg.html  all those dots are people.  Talk about highway21:20
ayoungstevemar, what is crazy is that I don't get out and climb more.21:20
morganfainbergstevemar: what adam said21:20
morganfainberghalfdome is insanely busy21:21
stevemarayoung: i been looking at those pics, i've been saying NOPE21:21
ayoungI have boudldering in the park 200 yards from my house and I haven't been all summer21:21
ayoungstevemar, crazy is wasting your life in front of a computer.21:21
ayoungClimbing is therapy21:21
morganfainbergayoung: i have been doing that through cycling last year i was up to ~100-150mi / week21:22
stevemarayoung: i sleep too, not always in front of a computer either21:22
*** rfolco has quit IRC21:22
ayoungmorganfainberg, it was that day, but some idiot near the top was climbing barefoot and holding up traffic.  Once he started climing again the jam cleared.21:22
morganfainbergriding PCH up from zuma to point magu and back.  all along the ocean21:22
*** otherwiseguy has joined #openstack-dev21:22
*** otherwiseguy has quit IRC21:22
*** rharwood has quit IRC21:22
*** vaml has quit IRC21:23
morganfainbergclimbing barefoot? ….21:23
*** alunch has quit IRC21:23
ayoungmorganfainberg, maybe if the follow on conf is in Cali again we'll do a climbers pre-trip to J-Tree or summat21:23
morganfainbergayoung: that would be fantastic21:23
morganfainbergayoung: i'll need to get back into shape for it :P but i'm in21:23
ayoungmy hands are sweating21:23
*** dina_belova has quit IRC21:23
ayoungnever been to tahquitz or suicide...looks like you will be our guide21:24
*** hemna has joined #openstack-dev21:25
morganfainbergayoung: some nice stuff up in there, but i'll need to spend some time on the rock, i think i haven't been in ~10 years.  no shape to lead atm21:25
morganfainbergbut once we're out of "why is it so hot" season, i'll get some time on the rocks again this year (hopefully)21:26
ayoungmorganfainberg, been a year or so since I was on the sharp end of the rope myself.21:27
ayoungTHere is a decent place up near my folks with a bunch of easy short trad routes.  5.6-5.8 good for remembering the basics21:27
ayoungAnd then there is Cannon21:27
*** jasondotstar has quit IRC21:28
*** lexinator1 has quit IRC21:31
*** noslzzp has quit IRC21:32
*** lexinator has joined #openstack-dev21:33
*** dkranz has quit IRC21:36
morganfainbergnice.  yeah i think i'll hit up the pinnacles out by my family's house21:37
*** briancurtin has quit IRC21:37
*** kui has joined #openstack-dev21:40
*** jayg is now known as jayg|g0n321:40
SlickNikayoung / morganfainberg: Do you guys recommend using memcached as a caching layer between the middleware and keystone?21:40
*** aelkikhia has joined #openstack-dev21:40
*** vartom4 has quit IRC21:41
morganfainbergSlickNik: I'll be honest, I haven't looked at that part of the code as much as I should have (yet).  I think ayoung or jamielennox would better be able to weigh in on that.21:41
*** briancurtin has joined #openstack-dev21:47
*** neelashah has joined #openstack-dev21:47
*** colinmcnamara has left #openstack-dev21:49
*** dprince has quit IRC21:49
*** colinmcnamara has joined #openstack-dev21:49
*** MaxV has quit IRC21:49
*** xBsd has joined #openstack-dev21:51
kuisome one to help review "https://review.openstack.org/#/c/41327/" ?21:51
*** egallen has quit IRC21:52
*** briancurtin has quit IRC21:53
*** rfolco has joined #openstack-dev21:53
*** hemna has quit IRC21:53
*** aelkikhia has left #openstack-dev21:53
*** hemna has joined #openstack-dev21:54
*** mrodden has quit IRC21:54
*** lbragstad has quit IRC21:55
*** dims has quit IRC21:56
*** lexinator has quit IRC21:57
*** ftcjeff has quit IRC21:58
*** rfolco has quit IRC22:00
*** aeperezt has quit IRC22:01
*** neelashah has quit IRC22:01
*** vaml has joined #openstack-dev22:03
*** dmakogon__ has quit IRC22:04
*** vaml has quit IRC22:04
*** kbringard has quit IRC22:05
*** aeperezt has joined #openstack-dev22:06
*** dolphm_ has joined #openstack-dev22:06
*** burt has quit IRC22:09
*** vaml has joined #openstack-dev22:09
*** wolfdreamer has quit IRC22:10
stevemardolphm_: ping22:10
dolphm_stevemar: pong22:10
stevemardolphm_: i was thinking, would it be worth adding "be sure to run `keystone-manage db_sync --extension oauth1`" to the oauth spec?22:11
dolphm_stevemar: not to the spec no, but to some docs somewhere: yes22:11
*** mkollaro has quit IRC22:11
*** dims has joined #openstack-dev22:11
stevemardolphm_: configuration.rst maybe?22:11
dolphm_stevemar: i will say that there is appropriately related content in doc/source/configuration.rst, but that all belongs in openstack-manuals22:12
dolphm_stevemar: either way, it's better to have docs than to not22:13
stevemardolphm_, alright, i'll take a look around and make sure it's properly doc'ed, definitely won't add it to spec though22:14
*** sarob has joined #openstack-dev22:16
*** qs201 has joined #openstack-dev22:16
*** wolfdreamer has joined #openstack-dev22:18
*** xBsd has quit IRC22:19
*** qs201 has quit IRC22:19
*** datsun180b has quit IRC22:20
*** salv-orlando has quit IRC22:21
*** wolfdreamer has quit IRC22:22
*** pabelanger has joined #openstack-dev22:23
*** dina_belova has joined #openstack-dev22:24
*** prad_ has quit IRC22:24
*** changbl has quit IRC22:24
*** jhesketh has joined #openstack-dev22:25
*** sarob has quit IRC22:25
*** FunnyLookinHat has quit IRC22:27
*** mdomsch has quit IRC22:27
*** sudorandom has quit IRC22:28
*** rcleere has quit IRC22:28
*** sergmelikyan has quit IRC22:28
*** dina_belova has quit IRC22:29
*** jecarey_ has quit IRC22:29
*** loteriety has joined #openstack-dev22:30
*** jmontemayor has quit IRC22:30
*** spzala has quit IRC22:30
*** eharney has quit IRC22:32
*** JordanRinke has quit IRC22:32
*** armax has left #openstack-dev22:34
*** dina_belova has joined #openstack-dev22:34
*** wolfdreamer has joined #openstack-dev22:36
*** fabio has joined #openstack-dev22:37
*** wolfdreamer has quit IRC22:39
*** chuckieb|2 has joined #openstack-dev22:39
*** dina_belova has quit IRC22:39
*** chuckieb has quit IRC22:42
*** troytoman-away is now known as troytoman22:42
*** pcm_ has quit IRC22:49
jamielennoxSlickNik, morganfainberg: not an area i'm familiar enough with on the server side. ayoung is your best bet, he's off but back in a couple of hours22:49
*** troytoman is now known as troytoman-away22:51
*** jamielennox is now known as jamielennox|away22:52
SlickNikthanks jamielennox|away/ morganfainberg! No hurry; will wait for ayoung to get back.22:53
*** rnirmal has quit IRC22:58
*** emagana has quit IRC22:59
*** nati_ueno has quit IRC22:59
*** nati_ueno has joined #openstack-dev23:00
*** tmclaugh[work] has joined #openstack-dev23:08
*** mlavalle has quit IRC23:09
*** vaml has quit IRC23:09
*** alop has quit IRC23:12
*** eharney has joined #openstack-dev23:12
*** sthaha has joined #openstack-dev23:13
*** sthaha has quit IRC23:13
*** sthaha has joined #openstack-dev23:13
*** sushils has quit IRC23:13
*** sudorandom has joined #openstack-dev23:13
*** lexinator has joined #openstack-dev23:14
*** sudorandom has quit IRC23:19
*** vaml has joined #openstack-dev23:20
*** vaml has quit IRC23:20
*** vaml has joined #openstack-dev23:20
*** vaml has quit IRC23:20
*** vaml has joined #openstack-dev23:21
*** vaml has quit IRC23:21
*** vaml has joined #openstack-dev23:21
*** vaml1 has joined #openstack-dev23:22
*** vaml has quit IRC23:22
*** vaml has joined #openstack-dev23:23
*** vaml1 has quit IRC23:23
*** vaml has quit IRC23:23
*** vaml has joined #openstack-dev23:23
*** markwash has quit IRC23:24
*** jvrbanac has quit IRC23:25
dolphm_annegentle: after a DocImpact-tagged change merges, is there any easy way to look up the resulting issue against openstack-manuals?23:25
*** vaml has quit IRC23:25
*** vaml has joined #openstack-dev23:26
*** vaml has quit IRC23:26
*** vaml has joined #openstack-dev23:26
*** vaml has quit IRC23:27
*** vaml1 has joined #openstack-dev23:27
*** vaml1 has quit IRC23:27
*** vaml has joined #openstack-dev23:27
*** vaml1 has joined #openstack-dev23:28
*** vaml has quit IRC23:28
*** pmathews has quit IRC23:29
dolphm_annegentle: nvm! searching for the Change-Id is easy enough :)23:29
*** sudorandom has joined #openstack-dev23:30
*** sudorandom has quit IRC23:32
*** sudorandom has joined #openstack-dev23:33
*** rods has quit IRC23:33
*** sandywalsh has quit IRC23:34
*** dina_belova has joined #openstack-dev23:35
*** carl_baldwin has quit IRC23:35
*** changbl has joined #openstack-dev23:36
*** alunch has joined #openstack-dev23:36
*** tjones has left #openstack-dev23:37
*** herndon has quit IRC23:38
*** dina_belova has quit IRC23:40
*** nachi has quit IRC23:41
*** eharney has quit IRC23:41
*** colinmcnamara has quit IRC23:46
*** shri has quit IRC23:46
*** shri has joined #openstack-dev23:46
*** sudorandom has quit IRC23:47
*** roampune has quit IRC23:48
stevemarbknudson: ping23:48
bknudsonstevemar: pong23:49
stevemarbknudson: couldn't tell from your comment on: https://review.openstack.org/#/c/40283/3/keystone/tests/test_backend.py23:49
stevemarbknudson: was it directed to me or adam?23:49
*** sandywalsh has joined #openstack-dev23:49
bknudsonstevemar: just a general comment that code should be as complicated as the problem.23:50
*** mrodden has joined #openstack-dev23:50
bknudsondoes keystone do anything particularly complicated? If not, the code shouldn't be complicated or confusing.23:50
stevemarbknudson, ah okay. i'll leave it to ayoung to follow up then23:51
*** topshare has joined #openstack-dev23:52
« Sunday, 2013-08-18 Index Tuesday, 2013-08-20 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!