Tuesday, 2013-08-13

*** eharney has quit IRC00:01
*** lifeless has joined #openstack-dev00:03
*** otherwiseguy has joined #openstack-dev00:03
*** mrdabot is now known as mrda00:06
*** yuan has joined #openstack-dev00:06
*** rods has quit IRC00:06
*** fbo is now known as fbo_away00:09
bknudsonmorganfainberg: you should be able to +2 this one now: https://review.openstack.org/#/c/39818/00:10
morganfainbergbknudson: i think we need to rebase it, haven't had a chance to try (local test shows git gets all sorts of confused)00:11
morganfainbergbknudson: i'll do the rebase tonight if needed or +200:12
bknudsonmorganfainberg: darn. that's what happens when they sit around for too long00:12
morganfainbergyeah00:12
morganfainbergi've been trying to get to the older ones as i can so they don00:12
*** sthaha has quit IRC00:12
*** sthaha has joined #openstack-dev00:12
morganfainberg't need it00:12
morganfainbergi think the other tox.ini update needs a rebase as well00:12
morganfainbergthe h404 one00:12
*** sarob_ has joined #openstack-dev00:13
morganfainbergbknudson: i'm still trying to understand some of the tempest output, is this a recheck or something a bit deeper: https://review.openstack.org/#/c/36326/00:13
*** SumitNaiksatam has quit IRC00:14
*** sthaha has quit IRC00:14
bknudsonmorganfainberg: I haven't been able to figure tempest test failures.00:15
bknudsonlook at all those logs!00:15
morganfainbergbknudson: ok, i don't feel so bad then00:15
morganfainbergbknudson: yeah.00:15
bknudsonmorganfainberg: just guessing, but it looks like a transient failure.00:17
morganfainbergbknudson: that was my guess00:17
*** sthaha has joined #openstack-dev00:17
*** sarob has quit IRC00:17
morganfainbergbut it's hard to decode some of those00:17
bknudsonmorganfainberg: error in http://logs.openstack.org/26/36326/3/check/gate-tempest-devstack-vm-cells-full/3a6ff48/console.html.gz seems to indicate euca test failed to terminate instance...00:17
bknudsonnot sure how that could be related to the change.00:17
morganfainbergexactly00:17
morganfainbergif it passes this time around i'll +2 it00:18
morganfainbergjust told it to recheck00:18
*** sarob_ has quit IRC00:18
morganfainbergi'll also get a rebase of the h404 one up if needed.00:20
morganfainbergor at least a note to the effect that it needs a rebase00:21
*** wolfdreamer has quit IRC00:22
*** gongysh has joined #openstack-dev00:23
*** emagana has quit IRC00:25
morganfainbergbknudson: https://review.openstack.org/#/c/39818/ if it looks good now (and jenkins likes it) we should be able to push that through00:26
morganfainbergjust rebased it00:26
bknudsonmorganfainberg: ok. need to wait for jenkins / smokestack. I got in trouble once for approving early.00:27
morganfainbergbknudson: oh i totally understand :)00:27
morganfainbergbknudson: i've had to play cleanup on my company's internal jenkins/gerrit setup because someone pushed something before it was validated00:28
morganfainbergi'm sure it's harder with the full openstack setup vs. the stripped down stuff I am using internally (and it was still a pain)00:28
*** dina_belova has joined #openstack-dev00:29
*** msmedved has joined #openstack-dev00:29
*** lexinator has quit IRC00:31
*** dina_belova has quit IRC00:31
*** jhesketh has quit IRC00:36
*** jhesketh has joined #openstack-dev00:36
*** nati_ueno has quit IRC00:37
*** edmund has quit IRC00:37
*** sudorandom has joined #openstack-dev00:37
morganfainberglbragstad_: just as an FYI, I've had git-review move the change-id on me in strange ways, maybe i'm doing something wrong (advice on why is of course welcome)?  But I just noticed your NIT here: https://review.openstack.org/#/c/41378/1//COMMIT_MSG00:37
*** lexinator has joined #openstack-dev00:38
bknudsonmorganfainberg: I thought we had a new process for global requirements...00:38
gongyshsalv-orlando: ping00:39
lbragstad_morganfainberg: ahh no worries, it was a small comment, just wanted to make sure you were aware of it00:39
morganfainbergbknudson: do we?00:39
morganfainberglbragstad_: it's not my fix, i just was commenting :)00:39
lbragstad_morganfainberg: ok00:39
morganfainbergbknudson: oh is that the needs to be in the global-reqs repo thing?00:39
*** zigo has quit IRC00:40
bknudsonmorganfainberg: https://review.openstack.org/#/c/40284/00:40
morganfainbergright00:40
*** nati_ueno has joined #openstack-dev00:40
*** pcm__ has quit IRC00:41
*** zigo has joined #openstack-dev00:42
*** rfolco has joined #openstack-dev00:42
morganfainbergbknudson: babel is in global requirements atm.  or are you referencing something else?00:44
*** rwsu is now known as rwsu-away00:45
bknudsonmorganfainberg: The question is was it updated using https://github.com/openstack/requirements/blob/master/README.rst00:45
morganfainbergoh that is a good question00:46
bknudsonor does that only remove old requirements?00:46
*** SumitNaiksatam has joined #openstack-dev00:46
*** sudorandom has quit IRC00:46
morganfainbergthat looks like it only removes requirements that aren't in global-reqs00:46
morganfainbergand updates versions to match00:46
*** sulrich has quit IRC00:46
*** sudorandom has joined #openstack-dev00:46
bknudsonI'll try it and see what it does with this change.00:47
*** crazed has quit IRC00:47
*** sulrich has joined #openstack-dev00:47
*** bdpayne has quit IRC00:48
*** nati_ueno has quit IRC00:48
*** nati_ueno has joined #openstack-dev00:49
bknudsonmorganfainberg: looks like keystone has never had requirements update.py done yet...00:50
morganfainbergoh dear00:50
morganfainbergthat sounds scary00:50
*** nati_uen_ has joined #openstack-dev00:51
bknudsonmorganfainberg: here it is: https://review.openstack.org/#/c/40756/00:51
ayoungjaypipes, so... 100K users .  How should we search through that list. Forget pagination.  What is the right solution?00:51
bknudsondidn't pass jenkins00:51
*** crazed has joined #openstack-dev00:51
morganfainbergbknudson: hm.00:52
jaypipesayoung: search != list...00:52
jaypipesayoung: just getting a list of users should be paged -- on the server side if the driver supports it. do you agree?00:52
ayoungjaypipes, no.  disagree00:52
ayoungvehemently00:52
jaypipesayoung: can you elaborate?00:53
ayoungjaypipes, think cloud scale00:53
ayoungwhat if there are billions of users00:53
jaypipesyes?00:53
ayoungpagination is dumb00:53
jaypipeswha?00:53
bknudsonif billions of users then can't get the whole list back ever.00:53
jamielennoxayoung: you can't paginate ldap without maintaining a cursor/00:53
bknudsonpaged or not00:53
ayoungbknudson, exatamundo00:53
jamielennox?00:53
ayoungjamielennox, also correct00:53
morganfainbergjamielennox: i think you're right.00:53
*** nati_ueno has quit IRC00:53
jamielennoxayoung: was a question?00:54
* jaypipes thinks we shouldn't hamstring deployments just because a particular driver doesn't support pagination.00:54
ayoungjaypipes, wrong00:54
jaypipesayoung: wroing00:54
ayoungjaypipes, we shouldn't build broken architectures00:54
ayoungseriosuly00:54
ayoungI am not trying to be a pain here00:54
bknudsonwe're already broken if you can get back all users00:54
ayoungit is an Identity antipattern00:54
morganfainbergbknudson:  +100:54
bknudson(attempt to get back all users)00:54
*** devoid has quit IRC00:55
jamielennox /users is a part of v3, we have to support it the best we can, if people want to iterate that then we should support pagination00:55
ayoungjaypipes, I did not organize the keystone core devs here, but you can see they are all kindof agreeing with me.  So, let me restart the question.  For the user admin  page, what are we trying to do?00:55
ayoungjamielennox, forget that for now00:55
jaypipesayoung: I don't disagree that returning a list of all users is a bad idea.00:55
*** gordc has joined #openstack-dev00:56
jamielennox:(00:56
ayounglets get to the right solution, and we can figure out how to fix a broken api afterwards00:56
jaypipesayoung: but it is what the current API supports.00:56
jaypipesayoung: if I do a search in users, and that search returns thousands of records, you still have the same issue of needing some sort of pagination to be a workable list operation00:57
* jamielennox likes having design discussions at a reasonable hour00:57
ayoungjaypipes, you need to winnow the search.  Next Next Next is a broken UI paradigm00:57
* ayoung likes having design discussions with beer. 00:57
jaypipesayoung: So I guess Google search is a broken design pattern.00:58
ayoungwin/win00:58
*** pmathews has joined #openstack-dev00:58
ayoungjaypipes, absolutely00:58
jaypipes*sigh*00:58
ayoungjaypipes, how often do you go to the second page?00:58
jaypipesvery often.00:58
bknudsonthird page?00:58
ayoungand the third?00:58
ayoungheh00:58
jaypipesquite often00:58
jaypipesdepends on the search00:59
morganfainbergjaypipes: i think you might be in the minority though.00:59
bknudson100,000th page?00:59
jaypipesclearly00:59
jaypipesbknudson: never.00:59
ayoungjaypipes, for users ,we have clear pattersn.  Search by first name, search by last name...there are 50 results returned, if there are more than that, refine your search00:59
jaypipesbknudson: but that's my point... the API should give some indication of the extent of the search results, and allow the user to requery with finer sargs00:59
ayoungjaypipes, agreed!01:00
jaypipesayoung: that does not happen currently.01:00
bknudsonI would prefer to get keystone out of the users game. leave the users in ldap or whatever.01:00
jaypipesbknudson: that ship has sailed.01:00
ayoungbknudson, keystone needs to be an IdP for the time being.  It is that side we are focused on.  LDAP is a different story.01:00
jamielennoxbknudson: i agree, but we've got no option now01:01
bknudsonreinventing the wheel01:01
ayoungbknudson, I am just trying to limit the common API such that it makes sense.  LDAP is the tool to understand the issues, but even in Pure SQL I would argue pagination is probably a mistake01:01
morganfainbergjaypipes: so if you were told 50 users shown, more than 50 results you'd be happy with that? [in some mechanism]?01:01
*** stevemar has joined #openstack-dev01:01
ayoungmorganfainberg, need a way to refine the search after that01:02
morganfainbergayoung: right.01:02
jaypipesmorganfainberg: absolutely.01:02
ayoungjaypipes, so a search API should allow a fragment of first, last, and username.01:03
ayounglist users should not return anything if given no filter01:03
jaypipesayoung: email too...01:03
ayoungjaypipes, yep01:03
morganfainbergjaypipes: regardless of search fields, partial01:03
morganfainbergfor each01:03
jaypipesayoung: and agreed on not returning anything without filter... absolutely.01:03
ayoungjaypipes, would that implementation work better for Horizon?01:04
ayoungAnything else it would need?01:04
ayoungthe ones I was wondering about were like list users for groups01:04
jaypipesayoung: no, that would be excellent -- same for tenants as well, of course...01:04
ayoungwhere thegroup was huge01:04
ayoungand for projects01:05
jaypipesmorganfainberg: sorry, what was that? not sure what you're getting at there... are you asking whether partial search should be available for any field of a user/tenant record? if so, yes, I agree.01:05
ayoungjaypipes, he was just generalizing what we were saying.01:05
jaypipesah, ok.01:06
morganfainbergjaypipes: i was just commenting that partial for the search fields, regardless of the ones we specify as "search fields"01:06
jaypipes++01:06
jaypipesayoung: are we discussing adding this functionality only to the v3 API and beyond?01:06
jaypipesfine if we are... just curuios01:06
ayoungjaypipes, I don't know.  I want to understand what we should be doing before we write the schedule01:07
jaypipesk01:07
*** Guest3077 has quit IRC01:07
ayoungjaypipes, obviosuly, this is a major change, and I don't think we can do it in the current API, but that still remains to be seen.  Maybe we could.01:08
bknudsonif it's optional query parameters then should be able to add it.01:08
*** jasondotstar has joined #openstack-dev01:08
*** yaguang has joined #openstack-dev01:08
ayoungjaypipes, I think that LDAP is going to be broken by large queries.  I am surprised, however, that LDAP servers are set up to respond with "all" users01:09
ayoungI thought it was fairly standard to have a query limit of a hundred or two01:09
jaypipeswell, I woudl support the following: 1) Changing the API to only return results if a search condition is supplied, 2) Using the same pagination parameters all the other projects currently use (limit + marker), 3) Partial search on all fields in the models, 4) allowing the search conditions to be pushed down to the drivers that support them, and 5) having a "~ X results found" part of the returned search result01:09
morganfainbergayoung: i think most servers have administrators that like to knock on people's doors to tell them they are doing bad things vs. limiting it internally01:09
jamielennoxthe not returning anything if no query is given is not compatible01:09
ayoungbknudson, and then a config option that says "return nothing if no filter"01:09
jamielennoxthe rest could be supported with optional params01:09
ayoungmorganfainberg, not in large organizations.  Too many doors01:10
bknudsonayoung: +1, was just going to say backwards compatible probably ok if there's a config option.01:10
morganfainbergayoung: yeah, sadly i've still seen it :(01:10
jaypipesjamielennox: agreed. it would have to be a major version bump, as it isn't back-compat01:10
ayounghttp://forums.penny-arcade.com/discussion/151331/trenches-comic-thursday-nov-10-2011-anguish01:10
*** Chaser has quit IRC01:10
morganfainbergconfig sounds reasonable.01:11
*** Chaser has joined #openstack-dev01:11
morganfainbergit feels like it's too early to push a major version bump, if it can be avoided.01:12
*** armax has left #openstack-dev01:12
ayoungNah, config option is valid there.01:12
ayoungBut we need the filter first01:12
jamielennoxwe should run it past horizon as well - does anyone know how they currently work with this?01:13
jaypipesmorganfainberg: can't really avoid it for backwards-incompatible changes.01:13
morganfainbergjaypipes: i know, but in this case, i think the configuration option is viable in this case.01:13
jaypipesjamielennox: sure, though horizon folks will use whatever the API provides... which , up until now, has been little or nothing01:14
ayounghttps://bugs.launchpad.net/keystone/+bug/121158201:14
uvirtbotLaunchpad bug 1211582 in keystone "Filter user list by partial attributes" [Wishlist,New]01:14
jaypipes++01:14
jamielennoxis there/there should be a mechanism to expose settings like these over api01:15
ayoungjamespage, query the config?01:15
bknudsonI think it will be obvious to clients if they get back no entries01:16
*** gordc has quit IRC01:16
bknudsonor a result code with message01:16
ayoungjamielennox, just don't put the SQL or LDAP urls in there01:16
jamielennoxbknudson: maybe, that or they think they have misconigured there identity backend and it found nothing01:16
morganfainbergbknudson: +1 on the specific code saying "filter required"01:16
morganfainbergreturning nothing is a bad idea.01:16
morganfainbergwhat if the search query returns legitimately nothing01:17
jamielennoxbut i'm good with the specific code01:17
bknudsonmorganfainberg: then the user can keep typing filters and they still won't get anything.01:17
ayoung413 Request Entity Too Large01:17
ayoung416 Requested Range Not Satisfiable01:17
bknudsonI think we return 413 for request entity too large already.01:17
morganfainberg416?01:17
jamielennox413 is better01:18
bknudson416 is used when range: header in request... which we could use for pagination.01:18
ayoung418 I'm a teapot (RFC 2324)01:18
bknudsonit's been used before.01:18
ayoungHad to be said.  Sorry01:18
ayoung425 Unordered Collection (Internet draft)01:18
bknudsonI'd probably go with 403 Forbidden.01:18
ayoungI like that01:18
morganfainbergayoung: 402 - pay us money to fix this bug01:18
morganfainberg:P01:18
bknudsonwe need a more expressive error document.01:19
jamielennoxmorganfainberg: probably a 5xx01:19
morganfainbergayoung: i think 425 would be nice.  i think 413 is the wrong side of the request to be throwing it for01:20
morganfainbergbknudson: 400 - bad request, filter required?01:20
bknudson400 typically means that the server couldn't understand the request01:20
bknudsonnot that it didn't want to do it.01:20
morganfainbergright01:21
morganfainbergmalformed syntax01:21
ayoungmaybe 412 Precondition Failed01:21
ayoungIE...no filter01:21
morganfainbergmaybe 417? Expectation Failed?01:21
morganfainbergbut that seems to be mroe proxy related01:21
ayoung Expect request-header field (see section 14.20)01:22
morganfainbergyeah01:22
bknudsonI'm worried about assigning a specific response code to a condition... since that would mean we couldn't use it in a new situation where it really fit.01:22
ayoung412 also says request headers, but it is more ambiguous01:22
morganfainberg(from 14.20):      expect-params =  ";" token [ "=" ( token | quoted-string ) ]01:22
morganfainbergas an example01:22
*** grepory has quit IRC01:22
morganfainbergi think 412 sounds most correct01:23
*** armax has joined #openstack-dev01:23
morganfainbergbut i think it doesn't matter what the code is as long as it's descriptive of why the request wasn't served01:23
ayounghttp://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html01:23
jamielennox412 sounds like the request wanted something the server couldn't deliver, but it's close01:23
jamielennoxwhat about just 410 Gone. This information is Gone01:24
bknudsonadd a new field to the error response, "reason" that we can fill in with a non-translated string.01:24
ayoung412 in this case, I think that the request wanted something the server couldn't deliver:  a query without a filter01:24
jaypipesyes, 412 is the most appropriate IMO01:24
bknudsonthen we could give it a nice name. "reason": "filter_required"01:25
jamielennoxagree 41201:25
ayoungthat should probably be a separate wishlist bug, huh?01:25
*** vipul is now known as vipul-away01:26
jaypipesyes01:26
jaypipesayoung: yes01:26
morganfainbergbknudson: https://review.openstack.org/#/c/39818/ jenkins seems happy with the rebase.01:27
bknudsonmorganfainberg: https://review.openstack.org/#/c/39818/ looks good to me.01:28
ayounghttps://bugs.launchpad.net/keystone/+bug/121158601:28
morganfainbergcool.01:28
uvirtbotLaunchpad bug 1211586 in keystone "Disable user lists without a filter" [Wishlist,New]01:28
*** armax has quit IRC01:29
morganfainbergbknudson: any issues if i approve that one, even though i did the rebase?  not sure on the general policy01:29
ayoungmorganfainberg, I'm ok with the change, but do we really want to skip :missing copyright header01:29
*** dina_belova has joined #openstack-dev01:29
morganfainbergayoung: that was already there.01:29
ayoungunderstood01:29
morganfainbergayoung: i think we shouldn't skip it, but it was added along the way.01:30
ayoungmorganfainberg, but I hadn't looked at the code critically in a while01:30
ayoungmorganfainberg, separate bug maybe?01:30
morganfainbergayoung: yeah i'll get it opened01:30
ayoungI am guessing that fixing that will require adding in a few headers01:30
*** lexinator has quit IRC01:30
morganfainbergprobably easy enough to do01:30
ayoungmorganfainberg, +2ed01:31
morganfainbergcool01:31
*** lexinator has joined #openstack-dev01:31
jaypipesayoung: from Mark Miller at HP... "Performing a “keystone user-list” command against the HP Enterprise Directory locks up keystone for about 1 ½ hours in that it will not perform any other commands until it is done"01:32
jaypipesayoung: ouch.01:32
ayoungjaypipes, I was aare of that, yes01:32
jaypipesayoung: heh, sounds like we need that 412 ASAP! :)01:32
ayoungjaypipes, I don;'t know if pagination will mitigate01:32
morganfainberghttps://bugs.launchpad.net/python-keystoneclient/+bug/121158701:32
uvirtbotLaunchpad bug 1211587 in python-keystoneclient "Enable gating on H102: missing copyright header" [Undecided,New]01:32
ayoungjaypipes, they need to fix their directory01:32
ayoungyou should not return all rows that way.01:33
ayoungrecords01:33
jaypipesayoung: agreed01:33
morganfainbergi wonder what that did to their poor directory server01:33
*** dina_belova has quit IRC01:34
bknudsonhopefully they have a cluster01:34
jaypipesmorganfainberg: put the work "Enterprise" in it? ;)01:34
jaypipess/work/word01:34
ayoung ldapsearch -x -H ldap://ldap.hp.com  -b ou=users,dc=hp,dc=com "(objectclass=*)"01:34
jaypipesheh01:34
morganfainbergjaypipes: hah!01:34
bknudsonsomebody probably came knocking on his door01:35
jaypipesmorganfainberg: I've found having the term "Enterprise" in any piece of software is the deathknell for both usability and sanity01:35
ayounghttp://trenchescomic.com/comic/post/recursion01:35
bknudsonEnterprise Keystone01:35
*** yaguang has quit IRC01:35
*** freedomhui has joined #openstack-dev01:35
*** gongysh has quit IRC01:36
morganfainbergbknudson: ™01:36
jaypipes:)01:36
*** kaushikc has joined #openstack-dev01:36
ayoungand, to cut to the closure http://trenchescomic.com/comic/post/neologism01:36
jaypipesbknudson: you KNOW some marketing geek somewhere is already working that into some company's product portfolio...01:36
ayoungjaypipes, like Red Hat Enterprise Linux?  Yeah,  seems to be sinking us....01:37
ayoungOh, wait.01:37
bknudsonjaypipes: I know that marketing geek.01:37
jaypipesayoung: :)01:37
morganfainbergayoung: but no one calls it that! it's just RHEL.01:38
jaypipesheh01:38
jaypipesayoung: something about exception not the rule... ;)01:38
morganfainbergjaypipes: only one marketing geek?01:38
jaypipesmorganfainberg: no, an entire team of course :)01:38
ayoungSo...the question is, for poor old HP Directory server, with no limits on returned queries, what should Keystone be asking by default?01:39
ayoungcan we add a --sizeLimit 200 in there somehow?01:40
*** kaushikc has quit IRC01:40
*** neelashah has joined #openstack-dev01:40
* ayoung needs to find his FreeIPA sample data file with 5000+ names01:40
bknudsonayoung: 5000? even hp is bigger than that.01:41
ayoungmorganfainberg, jamielennox bknudson BTW:  https://review.openstack.org/#/c/41578/01:41
*** vipul-away is now known as vipul01:41
ayoungbknudson, yeah, but it is large enough for load testing01:41
jamielennoxayoung: it doesn't break backward compat in oslo, just in keystone01:42
jamielennoxor more juts in the way he bought it into keystone, but yea it's going to be harder to work with whilst it's in oslo01:43
bknudsonayoung: that's a weird one. I don't watch oslo-incubator like I should.01:43
morganfainbergbknudson: same boat01:43
morganfainbergi should watch it more closely01:43
*** lexinator has quit IRC01:43
ayounganyway, I also sent him an email telling him we were going to work with him to get the code into Keystone client, but in a backwards compatible way.01:44
bknudsonyea, shouldn't need it in oslo-incubator since other projects can use keystoneclient.01:44
*** mjfork has quit IRC01:45
jamielennoxbknudson: he's done a few things other than just auth plugins that keystone can share with other projects - just completely in the wrong order01:45
morganfainbergso that affects: https://review.openstack.org/#/c/37233/ ?01:45
ayoungbknudson, and  I have an agreement from the PTOs that it is the right approach01:45
ayoungmorganfainberg, yeah.  Although exceptions should be a stand alone change.01:46
morganfainbergright01:46
ayoungI don;t want to kill this guys enthusiasm, just get him to work with us on this.01:47
*** markmcclain has quit IRC01:48
morganfainbergmakes sense.01:48
*** erkules_ has joined #openstack-dev01:50
*** jasondotstar has quit IRC01:52
*** erkules has quit IRC01:52
*** bknudson has quit IRC01:52
*** yaguang has joined #openstack-dev01:54
*** mrodden1 has quit IRC01:55
*** mrodden has joined #openstack-dev01:56
ayoungUgh, I am way behind on reviews...what is burning?01:57
*** changbl has joined #openstack-dev01:57
*** jasondotstar has joined #openstack-dev01:59
ayoungjamielennox, what happend to CertDownloadMiddlewareTest ?02:02
jamielennoxayoung: hmm?02:02
*** adalbas has quit IRC02:02
ayounghttps://review.openstack.org/#/c/41332/2/tests/test_auth_token_middleware.py02:02
ayoungline 122102:02
*** anteaya has quit IRC02:03
*** prekarat1 has quit IRC02:03
jamielennoxayoung: hmm, i know it was a problem when i changed how certificates were downloaded but it shouldn't be changed in that patch02:04
jamielennoxblaming that on the number of times i've rebased and sliced up those patches02:04
*** lexinator has joined #openstack-dev02:04
*** haleyb has quit IRC02:06
jamielennoxayoung: oh, right i remember, the test is basically wrong02:09
ayoung?02:09
jamielennoxit says that if you don't have the certs in place then the test should fail02:09
jamielennoxthat's not what happens02:09
ayoungI thought that was testing the fetch>02:09
ayoung>02:09
jamielennoxif you don't have the certs in place it should go and fetch them, i had added the cert paths to the fake http handler and so the certs were being fetched and so the test would pass02:09
* ayoung going to replace his > key with an extra?02:09
jamielennoxi'll remove it for this because i shouldn't be modifying test behaviour - but the test is essentially wrong later on02:10
*** nati_uen_ has quit IRC02:11
ayoungyeah.  It is not the greatest of tests, but it should still be there02:11
ayoungjamielennox, how about in the follow on review?02:11
jamielennoxyea, it can be changed there02:12
jamielennoxre-submitted02:13
*** gongysh has joined #openstack-dev02:13
jamielennoxso in the second one, i think that is correct02:15
jamielennoxthat test is testing the fake StackResponse thing, it's gone so no need of the test02:16
ayoungjamielennox, ok02:16
ayoungjamielennox, lost the link to it...02:16
jamielennoxhttps://review.openstack.org/#/c/4133302:17
*** haleyb has joined #openstack-dev02:17
jamielennoxayoung: i still need to rebase it anyway02:17
ayoungjamielennox, I still want that test or some variation02:17
ayoungtest_fetch_revocation_list_with_expire02:18
*** anniec has quit IRC02:18
jamielennoxshall do02:19
ayoungjamielennox, well...maybe I don't care.  I am starting to think that revocation list should not be a protected resource02:19
*** jerryz has joined #openstack-dev02:19
morganfainbergayoung: i think that would resolve a lot of headaches02:19
jamielennoxthe point of that patch is not to change tests though02:19
morganfainbergCRLs typically aren't protected iirc02:19
morganfainbergand the revocation-list is sortof CRLish02:20
ayoungmorganfainberg, file that as a bug and assign to me02:20
morganfainbergwill do02:20
ayoungjamielennox, I'm OK with dropping that particular test, though02:21
ayoungit really doesn't make sense to hardcode policy checks in unit tests anyway02:21
ayoungjamielennox,  assert_valid_last_url(self, token_id):  probably should still be there, though02:22
jamielennoxit is02:22
ayoungline 56502:22
jamielennoxso if you look down what i've done is changed it from a V3 test that overrides a V2 test into a common base with V3 and V2 overrides02:23
ayoungcool02:23
jamielennoxcause i really hate that02:23
ayoungline 789 see it02:23
*** carl_baldwin has quit IRC02:25
ayoungjamielennox, https://review.openstack.org/#/c/40176/4/keystoneclient/access.py  line 328 what is going on there?02:26
morganfainbergayoung: i can't seem to assign the bug to anyone but myself.02:27
morganfainberghttps://bugs.launchpad.net/keystone/+bug/121160202:27
uvirtbotLaunchpad bug 1211602 in keystone "revocation list should not be a protected resource" [Undecided,New]02:27
jamielennoxayoung: nothing i can see02:27
jamielennoxright review?02:27
ayoungjamielennox, # pre grizzly  ?02:28
jamielennoxayoung: so that i took out of auth_token middleware02:28
ayoungAh, OK02:28
ayoungjamielennox, shouldn't there be a corresponding edit in auth_token then?02:29
jamielennoxthe location of tenantName seems to have been moved around in previous releases02:29
jamielennoxayoung: i'm not removing it from auth_token yet02:30
*** dina_belova has joined #openstack-dev02:30
jamielennoxi'm just bringing the functionality over to accessinfo02:30
ayoungjamespage, OK....add a TODO then in auth_token to remove, or is that patch already in flight?02:30
jamielennoxayoung: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L81402:31
jamielennoxsorry again jamespage02:31
jamielennoxayoung: it'll be part of something bigger02:31
jamielennoxthis is one of the parts that has a standalone use02:32
ayoungOK...02:32
*** jerryz has quit IRC02:32
jamielennoxputting accessinfo into auth_token is definetly the plan and it will mean the functionality is the same02:33
jamielennoxif it's valid for a v2 token it really should be in accessinfo anyway so i don't think it's a problem for the patch to be standalone02:33
*** melwitt has quit IRC02:34
ayoungjamielennox, OK, I think I'm caught up on your reviews...02:34
jamielennoxayoung: have a look at https://review.openstack.org/#/c/34161/02:34
jamielennoxit's failing jenkins02:35
jamielennoxi put a comment at the bottom as to why: http://paste.openstack.org/show/43918/02:35
*** dina_belova has quit IRC02:35
jamielennoxthis is wrong configuration, but it obviously currently works - how do i support both?02:36
jamielennox / should i support both02:36
ayoungjamielennox, I added dkranz as a reviewer.  shardy can you comment on ^^02:36
*** yaguang has quit IRC02:40
ayoungjamielennox, we need to bring some HEAT on the HEAT team02:45
ayoungthey are in your time zone...who is still awake...02:46
*** rohitk has joined #openstack-dev02:46
*** alexxu has joined #openstack-dev02:46
jamielennoxi don't think it's a heat thing, i think it's a tempest or infra thing02:46
ayoungjamielennox, it is not specific to the heat test?02:47
jamielennoxyes, but it is because of how tempest configures heat02:47
jamielennoxdo you follow what i meant in the comment?02:47
ayoungah. jamielennox submit a patch to tempest?02:47
ayoungregardelss of whether we should support both, we can fix tempest, right?02:48
jamielennoxi think it's tempest but yes02:48
ayoungjamielennox, hmmm02:49
ayoungI think, actually, we will break a lot of things if we start enforcing that02:49
ayoungkeystone_authtoken.auth_uri = http://127.0.0.1:5000/v2.0  is probably everywhere.02:49
*** gordc has joined #openstack-dev02:49
jamielennoxayoung: right, so my point is it's wrong - but what do we do?02:49
ayoungjamielennox, is it really wrong? I is a way to state : use the v2 api instead of autonegotiate.  Not preferred, but not wrong, I think02:50
jamielennoxayoung: it's a hack around the fact that to use httplib you need a connection02:50
ayoungjamielennox, but still, tempest should not lock to 2.002:50
ayoungshudder02:50
jamielennoxso instead of specifying simply a url you have to specify a protocol, host, port etc02:50
*** lbragstad has joined #openstack-dev02:51
jamielennoxrequests you don't need that (actually you can't) so auth_host etc should be deprecated02:51
ayoungwell, that is a backwards compat thing we'll have to maintain for a while anyway02:51
jamielennoxafaik auth_uri should be the same as auth_host etc all written out, just used for different things02:51
ayoungagreed, but not all of the clients are aligned on using requests yet, either.  There is some resistance from swift02:51
jamielennoxbut that was never really written out anywhere02:52
ayoungagreed.  But lets allow the v2.0 in there, and deprecate it over time02:52
jamielennoxayoung: https://bugs.launchpad.net/python-keystoneclient/+bug/120751702:53
uvirtbotLaunchpad bug 1207517 in python-keystoneclient "auth_token defaults auth_uri config to point to admin endpoint if not set" [Medium,Confirmed]02:53
jamielennoxayoung: so i didn't realize, but the only place that auth_uri is used is https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L62102:54
jamielennoxso i guess they are slightly different02:54
jamielennoxor at least they can differ02:54
*** msmedved has quit IRC02:54
ayoungjamielennox, want to take it?02:54
ayoungactually ,confirm with dolphm first02:55
jamielennoxthat bug? i'm not sure on what to fix about it02:55
ayoungyeah, leave it to dolph.  He probably has an idea already02:55
jamielennoxpossibly then that heat config is correct, though useless02:55
*** gongysh_ has joined #openstack-dev02:56
*** freedomhu has joined #openstack-dev02:56
ayoungjamielennox, work around it for now, but you can submite the HEAT/Tempest change, too02:57
jamielennoxthat's ok, now i know that auth_uri is not supposed to be authoritative for where to submit requests to i can just ignore it02:58
*** freedomhui has quit IRC02:59
*** gongysh has quit IRC03:00
*** jimjiang has quit IRC03:00
*** egallen has joined #openstack-dev03:00
jamielennoxayoung: just filed: https://bugs.launchpad.net/python-keystoneclient/+bug/121161503:02
uvirtbotLaunchpad bug 1211615 in python-keystoneclient "auth_token middleware doesn't respect admin_prefix for downloading certificates" [Undecided,New]03:02
jamielennoxcan i fix that without breaking existing installs?03:02
ayoungwhat would it look like afterwards?03:03
ayoungwhere does path come from in that case>03:03
ayoung?03:03
jamielennoxso currently you specify your auth_host, port etc and an auth_prefix so that you can do all your calls against eg http://keystone.example.com:5000/prefix/v2.0/03:04
ayoungyep03:04
jamielennoxdownloading certificates simply ignores auth_prefix and so will download from  http://keystone.example.com:5000/v2.0/certificates/ca regardless of auth_prefix03:04
jamielennoxi cant imagine that if you are using auth_prefix that would work, but it's weird to have never come up before03:05
jamielennoxi guess it means that there are *no* deployments using PKI and a prefix03:05
ayoungI think that was something I put in there in support of https://wiki.openstack.org/wiki/URLs03:06
ayoungjamielennox, so, yes, please fix03:06
jamielennoxguess it never received much adoption :)03:06
ayoungnope03:08
ayoungOK,  bed for me03:08
*** jecarey has joined #openstack-dev03:10
*** jbresnah has quit IRC03:12
jamielennoxayoung: ok, talk to you later03:12
*** matiu has quit IRC03:24
*** ljjjustin has joined #openstack-dev03:24
*** yaguang has joined #openstack-dev03:25
*** bdpayne has joined #openstack-dev03:25
*** comay has quit IRC03:28
*** dina_belova has joined #openstack-dev03:30
*** sudorandom has quit IRC03:32
*** dina_belova has quit IRC03:35
*** gordc has quit IRC03:37
*** jfriedly has quit IRC03:42
*** otherwiseguy has quit IRC03:45
*** gordc has joined #openstack-dev03:48
*** gordc has quit IRC03:48
*** zaitcev has quit IRC03:52
*** martitia_ has joined #openstack-dev03:54
*** tiamar has quit IRC03:54
*** zaitcev has joined #openstack-dev03:56
*** noslzzp_ has joined #openstack-dev04:03
*** noslzzp has quit IRC04:03
*** noslzzp_ is now known as noslzzp04:03
*** SergeyLukjanov has joined #openstack-dev04:05
*** mberwanger has quit IRC04:05
*** zaneb has joined #openstack-dev04:05
*** changbl has quit IRC04:05
*** changbl has joined #openstack-dev04:06
*** zbitter has quit IRC04:08
*** jasondotstar has quit IRC04:09
*** bdpayne has quit IRC04:11
*** zaneb has quit IRC04:16
*** Mandell has joined #openstack-dev04:21
*** grepory has joined #openstack-dev04:28
*** locke105 has quit IRC04:29
*** dina_belova has joined #openstack-dev04:31
*** locke105 has joined #openstack-dev04:31
*** garyk has quit IRC04:31
*** kbringard has joined #openstack-dev04:32
*** dina_belova has quit IRC04:35
*** basha has joined #openstack-dev04:40
*** rohitk_alt has joined #openstack-dev04:42
*** dina_belova has joined #openstack-dev04:42
*** neelashah has quit IRC04:43
*** rohitk has quit IRC04:43
*** bdpayne has joined #openstack-dev04:45
*** dina_belova has quit IRC04:48
*** nati_ueno has joined #openstack-dev04:52
*** rohitk_alt has quit IRC04:55
*** egallen has quit IRC04:56
*** zaitcev has quit IRC04:56
*** basha has quit IRC04:58
*** egallen has joined #openstack-dev04:59
*** alexxu has quit IRC05:01
*** egallen has quit IRC05:02
*** nati_ueno has quit IRC05:02
*** kbringard has quit IRC05:02
*** nati_ueno has joined #openstack-dev05:02
*** jecarey_ has joined #openstack-dev05:03
*** sumanthns has joined #openstack-dev05:04
*** berendt has joined #openstack-dev05:06
*** jecarey has quit IRC05:06
*** ruhe has joined #openstack-dev05:08
*** basha has joined #openstack-dev05:09
*** gsilvis has quit IRC05:11
*** adjohn has joined #openstack-dev05:16
*** rohitk has joined #openstack-dev05:16
*** briancurtin has quit IRC05:16
*** alexxu has joined #openstack-dev05:18
*** SergeyLukjanov has quit IRC05:18
*** jbresnah has joined #openstack-dev05:20
*** nayward has joined #openstack-dev05:21
*** gsilvis has joined #openstack-dev05:23
*** jerryz has joined #openstack-dev05:25
*** bdpayne has quit IRC05:27
jerryzhi everyone, when i ran coverage test of cinder,  it always gets No module named swiftclient error. but it is already installed in the .tox dir.  this does not happen to py27 test. could anyone help? thanks05:30
*** cmark has joined #openstack-dev05:30
*** SergeyLukjanov has joined #openstack-dev05:30
*** SergeyLukjanov has quit IRC05:31
*** garyk has joined #openstack-dev05:37
*** vartom117 has joined #openstack-dev05:38
*** mrunge has joined #openstack-dev05:39
*** noslzzp has quit IRC05:39
*** bdpayne has joined #openstack-dev05:40
*** morazi has quit IRC05:41
stevemarhmm, what are the odds morganfainberg is awake...05:42
morganfainbergstevemar: odds?05:42
stevemar:D05:43
morganfainbergwhat are the odds you're catching me just as i was about to pack up from work? :P05:43
stevemarapparently pretty good05:43
stevemard'oh05:43
morganfainberghaha all good man05:43
morganfainbergwhats up?05:43
stevemar3 things05:43
morganfainbergsure05:43
stevemar1st https://review.openstack.org/#/c/29130/52/keystone/auth/plugins/token.py05:43
stevemartoo lazy to fix that one05:43
morganfainbergit's a nit, no worries05:43
*** mrunge has quit IRC05:44
stevemarfigured05:44
stevemar2nd https://review.openstack.org/#/c/29130/52/keystone/contrib/delegated_auth/core.py05:44
*** mmagr has joined #openstack-dev05:44
*** mrunge has joined #openstack-dev05:44
morganfainberganythying i mark as such, meh, i figure best case you fix, worst case… meh05:44
stevemar"Should this be a ProjectNotFound and not an Unauthorized? I'm inclined to say this should be an Unauthorized as well"05:44
stevemarrookie question, how do i raise 2 exceptions :\05:44
stevemaroh wait05:44
morganfainbergsorry i wasn't clear05:44
stevemaryou wrote NOT05:44
morganfainbergyeah05:45
morganfainbergit should have said Unauthorized instead05:45
stevemarcoolio05:45
morganfainbergthe "as well" was referencing the previous exception05:45
morganfainbergon uh… 444? 443?05:45
*** sarob has joined #openstack-dev05:46
stevemarah okay05:46
morganfainbergso yeah, my thought was unauthorized instead of projectnot found05:46
stevemargood point05:46
stevemarits more correct05:46
stevemarand i'll update the driver api stuff later on :)05:46
stevemarlast one: https://review.openstack.org/#/c/29130/52/keystone/token/core.py05:47
morganfainbergbut i also was asking because i wasn't sure if you had a reason besides "project not found was the one that looked good at the time"05:47
stevemarlol05:47
stevemaryou got me pegged there05:47
morganfainberghey, i'm guilty of that stuff too05:47
morganfainberg"oh hay, this looks good"05:47
stevemararen't we all05:47
*** terriyu has quit IRC05:47
morganfainbergyeah that last one, right now, you don't do revocations in the other drivers when a consumer id is passed.05:48
stevemarughhh, yeah, totally missed the boat on that one05:48
morganfainbergwell to be fair, i think you're goign to delete _every_ token05:48
morganfainbergso it's not a security risk…05:49
*** dina_belova has joined #openstack-dev05:49
morganfainbergfor the user that is05:49
stevemaryeah, but you and dolph had mentioned to *not* do that :)05:49
morganfainbergyeah, it's important to not do that05:49
morganfainbergpeople will be very unhappy05:49
stevemarthoughts on it? should i change up the list? or just add some stuff between the list and loop to filter out only the consumer related ones?05:49
stevemarthough if people are using kvs...05:50
* stevemar rolls eyes05:50
morganfainbergkvs driver is annoying05:50
morganfainbergbut....05:50
morganfainberghave to support it until icehouse (officially)05:50
stevemaryeah05:50
morganfainbergwell… question for you, since you might have a thought on this.05:50
*** nati_uen_ has joined #openstack-dev05:50
morganfainbergshould the token driver expose a "list_tokens_for_user_and_consumer" and "list_tokens_for_user_and_trust"?05:51
morganfainbergbecause i'm trying to smash out kwargs in managers/drivers05:51
morganfainbergor do you think extending list_tokens() to have another optional arg (that, once caching is in play, you need to specify all arguments for anyways) is more correct?05:52
*** adjohn has quit IRC05:52
stevemarhmm...05:53
*** dina_belova has quit IRC05:53
morganfainbergi'd make the token_driver do the work of filtering out the consumer tokens via a list function (in either case). — i don't see a need for "delete_tokens" to get too much smarts in it, especially since you're already looping in the other drivers over a list05:53
stevemartrue true05:53
stevemardelete should do just that05:53
morganfainbergyeah, and ignore that the SQL delete_tokens has any real smarts to it05:54
*** nati_ueno has quit IRC05:54
morganfainbergthat is just the nature of SQL needing sessions and the like05:54
*** henrynash has joined #openstack-dev05:54
*** cmark_ has joined #openstack-dev05:54
stevemaryeah, let him be a special case05:54
*** cmark has quit IRC05:54
*** rohitk has quit IRC05:55
*** rohitk_alt has joined #openstack-dev05:55
stevemarokay, so make the list a bit smarter05:55
morganfainbergeither that, or add a new "list" function to extract the consumer specific tokens05:56
stevemaryeah, most of the time, the "list" does just that anyway05:56
morganfainbergi am thinking that i'll be implementing list_tokens_for_trust(user_id, trust_id)05:57
morganfainbergwhich will call _list_tokens(user_id, tenant_id=None, trust_id=None)05:57
morganfainbergand that will be the way i remove the kwargs to list_tokens()05:58
morganfainbergstevemar: anyway, i'm going to get going and grab some food and sleep.05:59
morganfainbergstevemar: let me know if you need anything else05:59
stevemarmorganfainberg: have fun dude05:59
stevemarmorganfainberg: ttyl05:59
morganfainbergunrelated, i felt left out without a mic today on the bridge :P05:59
*** alexxu has quit IRC06:02
*** bdpayne has quit IRC06:02
*** sarob has quit IRC06:03
*** sarob has joined #openstack-dev06:03
*** morganfainberg is now known as morganfainberg_a06:04
*** sarob has quit IRC06:07
*** morazi has joined #openstack-dev06:07
*** berendt has quit IRC06:08
*** kbringard has joined #openstack-dev06:09
*** tkammer has joined #openstack-dev06:11
*** ruhe has quit IRC06:12
*** ruhe has joined #openstack-dev06:14
*** jamielennox is now known as jamielennox|away06:16
*** ruhe has quit IRC06:18
*** sthaha has quit IRC06:18
*** zaneb has joined #openstack-dev06:20
*** bashok has joined #openstack-dev06:20
*** alexxu has joined #openstack-dev06:25
*** odyssey4me has joined #openstack-dev06:25
*** stevemar has quit IRC06:30
*** adjohn has joined #openstack-dev06:34
*** adjohn has quit IRC06:37
*** flaper87|afk is now known as flaper8706:40
*** henrynash has quit IRC06:41
*** mrunge_ has joined #openstack-dev06:43
*** mrunge has quit IRC06:43
*** xga has joined #openstack-dev06:44
*** asalkeld is now known as asalkeld_food06:45
*** ffio has joined #openstack-dev06:48
*** jerryz has quit IRC06:48
*** kirankv has joined #openstack-dev06:49
*** adjohn has joined #openstack-dev06:52
*** adjohn has quit IRC06:52
*** devvesa has joined #openstack-dev06:54
*** lexinator has quit IRC06:57
*** nsaje1 has joined #openstack-dev06:59
*** Guest6179 is now known as ohadlevy06:59
*** ohadlevy has joined #openstack-dev06:59
*** reidrac has joined #openstack-dev07:02
*** mrunge_ is now known as mrunge07:03
*** nati_uen_ has quit IRC07:03
*** nati_ueno has joined #openstack-dev07:04
*** nshaikh has joined #openstack-dev07:05
*** aeperezt has quit IRC07:06
*** morganfainberg_a is now known as morganfainberg07:07
*** alexxu has quit IRC07:09
*** jimjiang has joined #openstack-dev07:11
*** adjohn has joined #openstack-dev07:13
*** adjohn has quit IRC07:13
*** sarob has joined #openstack-dev07:14
*** basha has quit IRC07:14
*** kenperkins has quit IRC07:16
*** kenperkins_ has joined #openstack-dev07:16
*** ndipanov_gone is now known as ndipanov07:18
*** sarob has quit IRC07:18
*** xBsd has joined #openstack-dev07:21
*** dosaboy is now known as dosaboy__07:22
*** jaimegil has joined #openstack-dev07:23
*** adjohn has joined #openstack-dev07:24
*** xga_ has joined #openstack-dev07:25
*** adjohn has quit IRC07:25
*** xga has quit IRC07:28
*** wfoster_away is now known as wfoster07:30
*** jistr has joined #openstack-dev07:30
*** jprovazn has joined #openstack-dev07:32
*** alexb_ has joined #openstack-dev07:34
*** ruhe has joined #openstack-dev07:34
*** dguitarbite has joined #openstack-dev07:35
*** fbo_away is now known as fbo07:35
*** nsaje1 has quit IRC07:36
*** ifarkas has joined #openstack-dev07:36
*** psedlak has joined #openstack-dev07:37
*** shang has joined #openstack-dev07:39
*** feleouet has joined #openstack-dev07:39
*** rohitk has joined #openstack-dev07:41
*** alexxu has joined #openstack-dev07:42
*** ifarkas has quit IRC07:42
*** zoresvit has joined #openstack-dev07:42
*** rohitk_alt has quit IRC07:42
*** ifarkas has joined #openstack-dev07:44
*** troytoman is now known as troytoman-away07:49
*** jtomasek has joined #openstack-dev07:49
*** nati_uen_ has joined #openstack-dev07:52
*** nati_ueno has quit IRC07:55
*** afazekas has joined #openstack-dev07:55
*** afazekas has quit IRC07:55
*** zbitter has joined #openstack-dev07:55
*** afazekas has joined #openstack-dev07:55
*** basha has joined #openstack-dev07:57
*** zaneb has quit IRC07:58
*** zaneb has joined #openstack-dev07:59
*** MaxV has joined #openstack-dev07:59
*** safchain has joined #openstack-dev07:59
*** zbitter has quit IRC08:00
*** Aj0 has joined #openstack-dev08:01
*** safchain has quit IRC08:02
*** safchain has joined #openstack-dev08:03
*** Gwyxx has joined #openstack-dev08:03
*** henrynash has joined #openstack-dev08:03
*** zbitter has joined #openstack-dev08:04
*** adjohn has joined #openstack-dev08:04
*** zaneb has quit IRC08:05
*** adjohn has quit IRC08:05
*** zaneb has joined #openstack-dev08:07
*** Gwyxx has quit IRC08:07
*** zbitter has quit IRC08:08
*** boris-42 has joined #openstack-dev08:08
*** zyluo has joined #openstack-dev08:09
*** jpich has joined #openstack-dev08:09
zyluomikal, ping08:10
*** sungju has quit IRC08:11
*** JordanP has joined #openstack-dev08:11
*** asalkeld_food is now known as asalkeld_eaten08:12
*** asalkeld_eaten is now known as asalkeld08:12
*** safchain has quit IRC08:12
*** erkules_ is now known as erkules08:13
*** zul has quit IRC08:13
*** ffio has quit IRC08:14
*** ffio has joined #openstack-dev08:14
*** safchain has joined #openstack-dev08:14
*** xqueralt-afk is now known as xqueralt08:15
*** oNeToWn has joined #openstack-dev08:15
*** yaguang has quit IRC08:16
*** boden has joined #openstack-dev08:17
*** Lily_ has joined #openstack-dev08:18
*** lucasagomes has joined #openstack-dev08:18
*** zhongwenjia has joined #openstack-dev08:18
*** qba73 has joined #openstack-dev08:20
*** martyntaylor has joined #openstack-dev08:22
*** cmark_ has quit IRC08:23
*** mmoya has joined #openstack-dev08:25
*** dosaboy has joined #openstack-dev08:25
*** yaguang has joined #openstack-dev08:28
*** freedomhu has quit IRC08:29
*** freedomhui has joined #openstack-dev08:29
*** dguitarbite has quit IRC08:29
*** Alexei_987 has joined #openstack-dev08:33
*** athomas has joined #openstack-dev08:34
*** sushils has joined #openstack-dev08:34
*** alexxu has quit IRC08:35
*** markmc has joined #openstack-dev08:37
*** giulivo has joined #openstack-dev08:40
*** Mark___ has quit IRC08:44
*** lsmola has quit IRC08:46
*** jbresnah has quit IRC08:46
jprovaznlifeless: ping08:48
*** basha has quit IRC08:49
*** Lily_ has quit IRC08:51
*** japage has quit IRC08:52
*** japage has joined #openstack-dev08:52
*** rods has joined #openstack-dev08:54
*** zyluo has quit IRC08:55
holmsal-maisan: available :)?08:56
*** alexxu has joined #openstack-dev08:56
*** bashok has quit IRC08:59
*** lsmola has joined #openstack-dev09:00
*** lexinator has joined #openstack-dev09:00
*** yaguang has quit IRC09:00
*** AnilV4 has joined #openstack-dev09:02
*** lexinator has quit IRC09:05
*** xBsd has quit IRC09:05
*** ifarkas has quit IRC09:12
*** ifarkas has joined #openstack-dev09:12
*** adjohn has joined #openstack-dev09:17
*** mmoya has quit IRC09:17
*** mmoya has joined #openstack-dev09:17
*** yaguang has joined #openstack-dev09:17
*** adjohn has quit IRC09:21
*** mkerrin has quit IRC09:22
*** cmark has joined #openstack-dev09:24
*** zbitter has joined #openstack-dev09:24
*** gsilvis has quit IRC09:25
*** zaneb has quit IRC09:25
*** lsmola has quit IRC09:26
yaguangmrodden,ping09:30
*** zbitter is now known as zaneb09:31
*** alexxu has quit IRC09:31
*** adjohn has joined #openstack-dev09:31
*** ffio has quit IRC09:31
*** cmark has quit IRC09:33
*** wfoster is now known as wfoster_away09:34
*** basha has joined #openstack-dev09:36
*** devvesa has quit IRC09:36
*** valgrind has joined #openstack-dev09:38
*** yolanda has joined #openstack-dev09:40
*** lsmola has joined #openstack-dev09:40
*** ljjjustin has quit IRC09:41
*** mmoya_ has joined #openstack-dev09:47
*** SergeyLukjanov has joined #openstack-dev09:49
*** mmoya has quit IRC09:50
*** adjohn has quit IRC09:56
lifelessjprovazn: pong09:59
*** dina_belova has joined #openstack-dev09:59
*** wfoster_away is now known as wfoster10:00
*** ruhe has quit IRC10:01
*** annashen has quit IRC10:07
*** koolhead11 has quit IRC10:08
*** nayward has quit IRC10:11
*** nayward has joined #openstack-dev10:13
*** adjohn has joined #openstack-dev10:15
jprovaznlifeless: Hi, have a question about this commit: https://github.com/openstack/tripleo-incubator/commit/81335dd0bd43c0d3002e73595b813bb50b41c402 - does it mean that seedrc file should now be part of tripleo-incubator repository?10:17
*** Aarti has joined #openstack-dev10:19
*** adjohn has quit IRC10:20
holmswhat's the default username in dashboard? just installed devstack10:21
*** xga_ has quit IRC10:25
*** annashen has joined #openstack-dev10:26
*** jaimegil has quit IRC10:26
*** jaimegil has joined #openstack-dev10:27
*** jlabocki1 has joined #openstack-dev10:31
*** henrynash_ has joined #openstack-dev10:31
*** mrodden1 has joined #openstack-dev10:31
*** zbitter has joined #openstack-dev10:32
*** nati_ueno has joined #openstack-dev10:32
*** Aarti_ has joined #openstack-dev10:32
*** zaneb has quit IRC10:33
*** rods has quit IRC10:33
*** cp16net_ has joined #openstack-dev10:33
*** topol has joined #openstack-dev10:34
*** comstud_ has joined #openstack-dev10:35
*** zbitter has quit IRC10:35
*** slagle_ has joined #openstack-dev10:35
*** amerine_ has joined #openstack-dev10:35
*** clayg_ has joined #openstack-dev10:36
*** lifeless_ has joined #openstack-dev10:36
*** BLZbubba_ has joined #openstack-dev10:36
*** martitia_ has quit IRC10:36
*** tiamar has joined #openstack-dev10:37
*** kashyap` has joined #openstack-dev10:38
*** zaneb has joined #openstack-dev10:39
*** _cerberu` has joined #openstack-dev10:39
*** samalba_ has joined #openstack-dev10:39
*** Aarti has quit IRC10:40
*** SergeyLukjanov has quit IRC10:40
*** ifarkas has quit IRC10:40
*** dosaboy has quit IRC10:40
*** oNeToWn has quit IRC10:40
*** henrynash has quit IRC10:40
*** Aj0 has quit IRC10:40
*** nati_uen_ has quit IRC10:40
*** rohitk has quit IRC10:40
*** mrunge has quit IRC10:40
*** tkammer has quit IRC10:40
*** mrodden has quit IRC10:40
*** lifeless has quit IRC10:40
*** ayoung has quit IRC10:40
*** jlabocki has quit IRC10:40
*** amerine has quit IRC10:40
*** slagle has quit IRC10:40
*** sdake_ has quit IRC10:40
*** llu has quit IRC10:40
*** doude has quit IRC10:40
*** cp16net has quit IRC10:40
*** ianw has quit IRC10:40
*** BLZbubba has quit IRC10:40
*** yamahata has quit IRC10:40
*** dansmith has quit IRC10:40
*** harlowja has quit IRC10:40
*** s2r2 has quit IRC10:40
*** Vivek has quit IRC10:40
*** samalba has quit IRC10:40
*** akscram has quit IRC10:40
*** maurosr has quit IRC10:40
*** clayg has quit IRC10:40
*** toddnni has quit IRC10:40
*** comstud has quit IRC10:40
*** kashyap has quit IRC10:40
*** _cerberus_ has quit IRC10:40
*** uvirtbot has quit IRC10:40
*** henrynash_ is now known as henrynash10:40
*** Aarti_ is now known as Aarti10:40
*** cp16net_ is now known as cp16net10:40
*** samalba_ is now known as samalba10:40
*** zbitter has joined #openstack-dev10:41
*** zaneb has quit IRC10:43
*** ianw has joined #openstack-dev10:45
*** ruhe has joined #openstack-dev10:45
*** sdake_ has joined #openstack-dev10:45
*** sdake_ has quit IRC10:45
*** sdake_ has joined #openstack-dev10:45
*** adjohn has joined #openstack-dev10:45
*** zbitter has quit IRC10:46
*** uvirtbot has joined #openstack-dev10:46
*** tkammer has joined #openstack-dev10:46
*** dosaboy has joined #openstack-dev10:46
*** oNeToWn has joined #openstack-dev10:46
*** Aj0 has joined #openstack-dev10:46
*** rohitk has joined #openstack-dev10:46
*** mrunge has joined #openstack-dev10:46
*** doude has joined #openstack-dev10:46
*** dansmith has joined #openstack-dev10:46
*** Vivek has joined #openstack-dev10:46
*** akscram has joined #openstack-dev10:46
*** maurosr has joined #openstack-dev10:46
*** toddnni has joined #openstack-dev10:46
*** tkammer has quit IRC10:46
*** tkammer has joined #openstack-dev10:46
*** yamahata has joined #openstack-dev10:46
*** SergeyLukjanov has joined #openstack-dev10:46
*** ayoung has joined #openstack-dev10:46
*** zbitter has joined #openstack-dev10:47
*** oNeToWn has quit IRC10:47
*** mmoya_ has quit IRC10:47
*** ifarkas has joined #openstack-dev10:48
*** adjohn has quit IRC10:50
*** gongysh_ has quit IRC10:51
*** yaguang has quit IRC10:52
*** ruhe has quit IRC10:53
*** annashen has quit IRC10:54
*** fbo is now known as fbo_away10:56
*** anniec has joined #openstack-dev10:58
*** mjfork has joined #openstack-dev10:58
*** radez_g0n3 is now known as radez10:58
*** cmark has joined #openstack-dev10:59
*** annashen has joined #openstack-dev10:59
*** pcm_ has joined #openstack-dev11:00
*** anniec_ has joined #openstack-dev11:02
*** SergeyLukjanov has quit IRC11:02
*** anniec has quit IRC11:02
*** anniec_ is now known as anniec11:02
*** mkollaro has joined #openstack-dev11:05
*** cmark has quit IRC11:07
*** lucasagomes is now known as lucas-hungry11:10
*** zbitter is now known as zaneb11:11
*** mrda is now known as mrdabot11:15
*** dina_belova has quit IRC11:21
*** martyntaylor has quit IRC11:21
*** basha has quit IRC11:22
*** basha has joined #openstack-dev11:24
*** dina_belova has joined #openstack-dev11:24
*** ffio has joined #openstack-dev11:25
*** ruhe has joined #openstack-dev11:25
*** woodspa has joined #openstack-dev11:25
*** adalbas has joined #openstack-dev11:26
*** slagle_ has quit IRC11:28
*** s2r2 has joined #openstack-dev11:31
*** tkammer has quit IRC11:31
*** zbitter has joined #openstack-dev11:31
*** zaneb has quit IRC11:32
*** zbitter is now known as zaneb11:32
*** xga has joined #openstack-dev11:36
*** SergeyLukjanov has joined #openstack-dev11:37
*** nshaikh has left #openstack-dev11:39
*** Aj0 has quit IRC11:40
*** fbo_away is now known as fbo11:43
*** martyntaylor has joined #openstack-dev11:44
*** FunnyLookinHat has joined #openstack-dev11:46
*** adjohn has joined #openstack-dev11:46
*** Aj0 has joined #openstack-dev11:46
*** noslzzp has joined #openstack-dev11:47
*** shang has quit IRC11:47
*** nshaikh has joined #openstack-dev11:48
*** xga_ has joined #openstack-dev11:50
*** adjohn has quit IRC11:51
*** xga has quit IRC11:54
*** tmclaugh[work] has joined #openstack-dev11:54
*** dina_belova has quit IRC11:57
*** steveg_afk has joined #openstack-dev11:57
*** alexxu has joined #openstack-dev11:58
*** rfolco has joined #openstack-dev11:59
*** yaguang has joined #openstack-dev11:59
*** sgordon has quit IRC11:59
*** dina_belova has joined #openstack-dev12:01
*** tkammer has joined #openstack-dev12:03
*** dina_belova has quit IRC12:05
*** branen_ has joined #openstack-dev12:05
*** VictorLin has joined #openstack-dev12:06
*** branen has quit IRC12:08
*** zbitter has joined #openstack-dev12:09
*** ayoung has quit IRC12:10
*** xga has joined #openstack-dev12:11
*** zul has joined #openstack-dev12:11
*** jasondotstar has joined #openstack-dev12:12
*** zaneb has quit IRC12:12
*** xga_ has quit IRC12:12
*** xga_ has joined #openstack-dev12:14
*** zbitter has quit IRC12:15
*** zaneb has joined #openstack-dev12:16
*** xga has quit IRC12:16
*** Aarti has quit IRC12:17
*** adjohn has joined #openstack-dev12:17
*** Ryan_Lane has joined #openstack-dev12:17
*** martine has joined #openstack-dev12:19
*** martine is now known as Guest895612:19
*** jruzicka has joined #openstack-dev12:19
*** troytoman-away is now known as troytoman12:19
*** valgrind has quit IRC12:20
*** mberwanger has joined #openstack-dev12:20
*** adjohn has quit IRC12:21
*** egallen has joined #openstack-dev12:22
*** ruhe has quit IRC12:22
*** dina_belova has joined #openstack-dev12:24
*** zbitter has joined #openstack-dev12:25
*** sandywalsh has quit IRC12:25
*** jonesld has joined #openstack-dev12:26
*** zaneb has quit IRC12:27
*** radez is now known as radez_g0n312:29
*** morazi has quit IRC12:31
*** slagle has joined #openstack-dev12:31
*** dvarga has joined #openstack-dev12:33
*** jonesld has quit IRC12:33
*** dina_belova has quit IRC12:34
*** dina_belova has joined #openstack-dev12:34
*** psedlak has quit IRC12:35
*** dvarga has quit IRC12:36
*** zul has quit IRC12:37
*** sandywalsh has joined #openstack-dev12:39
*** zul has joined #openstack-dev12:40
*** afazekas has quit IRC12:41
*** basha has quit IRC12:43
*** basha has joined #openstack-dev12:43
*** mrunge has quit IRC12:44
*** Guest8956 is now known as martine_12:45
*** basha has quit IRC12:46
*** adjohn has joined #openstack-dev12:48
*** lbragstad has quit IRC12:49
*** adjohn has quit IRC12:52
*** xga_ has quit IRC12:55
*** prad_ has joined #openstack-dev12:56
*** steveg_afk is now known as sgordon12:57
*** jaimegil has quit IRC12:57
*** gordc has joined #openstack-dev12:58
*** lucas-hungry is now known as lucasagomes12:59
*** joesavak has joined #openstack-dev13:01
*** zul has quit IRC13:02
*** prad_ has quit IRC13:03
*** mberwanger has quit IRC13:03
*** xga has joined #openstack-dev13:03
*** alexpilotti has joined #openstack-dev13:04
*** zul has joined #openstack-dev13:04
*** anteaya has joined #openstack-dev13:05
*** dprince has joined #openstack-dev13:07
*** ruhe has joined #openstack-dev13:10
*** tkammer has quit IRC13:10
*** leif has joined #openstack-dev13:11
*** jsavak has joined #openstack-dev13:11
*** leif is now known as Guest9501413:11
*** psedlak has joined #openstack-dev13:12
*** zul has quit IRC13:15
*** joesavak has quit IRC13:16
*** prad_ has joined #openstack-dev13:16
*** Ryan_Lane1 has joined #openstack-dev13:17
*** Ryan_Lane has quit IRC13:17
*** burt has joined #openstack-dev13:18
*** sumanthns has quit IRC13:18
*** adjohn has joined #openstack-dev13:18
*** dina_belova has quit IRC13:19
*** morazi has joined #openstack-dev13:20
*** dina_belova has joined #openstack-dev13:22
*** vartom117 has quit IRC13:22
*** ffio has quit IRC13:22
*** ffio has joined #openstack-dev13:23
*** bcrochet has quit IRC13:23
*** rharwood has joined #openstack-dev13:23
*** adjohn has quit IRC13:23
*** navid__ has joined #openstack-dev13:24
*** bcrochet has joined #openstack-dev13:25
*** jayg|g0n3 is now known as jayg13:26
*** neelashah has joined #openstack-dev13:26
*** nshaikh has quit IRC13:26
*** rods has joined #openstack-dev13:27
*** ruhe has quit IRC13:28
*** litong has joined #openstack-dev13:28
*** boris-42 has quit IRC13:29
*** boris-42 has joined #openstack-dev13:30
*** bknudson has joined #openstack-dev13:30
*** haleyb has quit IRC13:32
*** FunnyLookinHat has quit IRC13:32
*** tkammer has joined #openstack-dev13:33
*** changbl has quit IRC13:34
*** stevemar has joined #openstack-dev13:35
*** jpeeler has joined #openstack-dev13:37
*** afazekas has joined #openstack-dev13:37
*** jpeeler has quit IRC13:37
*** jpeeler has joined #openstack-dev13:37
*** mmoya has joined #openstack-dev13:37
*** anteaya has quit IRC13:41
*** lbragstad has joined #openstack-dev13:41
*** anteaya has joined #openstack-dev13:42
*** zhongwenjia has quit IRC13:42
*** nati_ueno has quit IRC13:45
*** jrgcombr has joined #openstack-dev13:45
*** ruhe has joined #openstack-dev13:51
*** pmathews has quit IRC13:52
*** jprovazn has quit IRC13:52
*** edmund has joined #openstack-dev13:52
*** zbitter is now known as zaneb13:52
*** briancurtin has joined #openstack-dev13:56
*** jprovazn has joined #openstack-dev13:56
*** jrgcombr has quit IRC13:56
jswarrenflaper87: Any chance you could review https://review.openstack.org/#/c/40885/ and its dependencies?  They are t18n changes for glance, along the lines of what others have done in nova, ceilometer, etc.13:56
flaper87jswarren: sure, I'll take a look13:57
*** jimfehlig has joined #openstack-dev13:57
*** jrgcombr has joined #openstack-dev13:58
*** Ryan_Lane1 has quit IRC14:00
*** msbrown has joined #openstack-dev14:00
jswarrenflaper87: Many thanks!14:00
*** markmcclain has joined #openstack-dev14:00
*** msbrown has left #openstack-dev14:00
*** xga_ has joined #openstack-dev14:01
*** ydacheville has joined #openstack-dev14:01
*** topol has quit IRC14:01
*** anniec has quit IRC14:01
*** blamar has joined #openstack-dev14:02
*** zul has joined #openstack-dev14:02
*** ms_brown has joined #openstack-dev14:03
*** ruhe has quit IRC14:04
*** xga has quit IRC14:04
*** ayoung has joined #openstack-dev14:05
*** kbringard has joined #openstack-dev14:06
*** eharney has joined #openstack-dev14:08
*** fifieldt has quit IRC14:08
*** armax has joined #openstack-dev14:10
*** haleyb has joined #openstack-dev14:10
*** ruhe has joined #openstack-dev14:11
*** rnirmal has joined #openstack-dev14:12
*** dina_belova has quit IRC14:14
*** jrgcombr has quit IRC14:16
*** cppcabrera has joined #openstack-dev14:16
*** otherwiseguy has joined #openstack-dev14:17
*** jrgcombr has joined #openstack-dev14:18
*** radez_g0n3 is now known as radez14:19
*** zaneb has quit IRC14:20
*** zackf has joined #openstack-dev14:23
*** alexb_ has quit IRC14:25
*** utlemming has joined #openstack-dev14:27
*** datsun180b has joined #openstack-dev14:27
*** basha has joined #openstack-dev14:27
*** FunnyLookinHat has joined #openstack-dev14:28
*** rcleere has quit IRC14:28
*** mmagr has quit IRC14:29
*** rohitk has quit IRC14:29
*** basha_ has joined #openstack-dev14:30
*** cppcabrera has left #openstack-dev14:30
*** alunduil has quit IRC14:30
*** basha has quit IRC14:32
*** alexb_ has joined #openstack-dev14:34
*** zaneb has joined #openstack-dev14:34
*** basha_ has quit IRC14:34
*** lexinator has joined #openstack-dev14:35
*** devvesa has joined #openstack-dev14:35
*** devvesa has quit IRC14:35
*** galstrom_zzz is now known as galstrom14:36
*** devvesa has joined #openstack-dev14:36
*** bswartz has quit IRC14:39
*** alexxu has quit IRC14:39
*** mdenny has joined #openstack-dev14:40
*** changbl has joined #openstack-dev14:41
*** mkollaro has quit IRC14:41
*** esheffield has joined #openstack-dev14:41
*** esheffield has left #openstack-dev14:42
*** carl_baldwin has joined #openstack-dev14:42
*** MIDENN_ has joined #openstack-dev14:44
*** dina_belova has joined #openstack-dev14:44
*** esheffield has joined #openstack-dev14:45
*** mdenny has quit IRC14:45
*** wolfdreamer has joined #openstack-dev14:45
*** ruhe has quit IRC14:47
*** mdenny has joined #openstack-dev14:47
*** topol has joined #openstack-dev14:47
*** matiu has joined #openstack-dev14:49
*** basha has joined #openstack-dev14:49
*** aloga_ has quit IRC14:50
*** grepory has quit IRC14:51
*** basha_ has joined #openstack-dev14:53
*** egallen has quit IRC14:54
*** basha has quit IRC14:54
*** rcleere has joined #openstack-dev14:56
*** jprovazn has quit IRC14:57
*** jgallard has joined #openstack-dev14:57
*** joesavak has joined #openstack-dev14:57
*** bswartz has joined #openstack-dev14:58
*** jsavak has quit IRC14:58
*** hartsocks has joined #openstack-dev14:59
*** reidrac has quit IRC14:59
*** basha_ has quit IRC14:59
*** mrodden1 has quit IRC14:59
*** mkollaro has joined #openstack-dev15:00
*** edmund has quit IRC15:01
*** basha has joined #openstack-dev15:01
*** mdenny has quit IRC15:02
*** mdenny has joined #openstack-dev15:02
*** sthaha has joined #openstack-dev15:03
*** aelkikhia has joined #openstack-dev15:03
*** hartsocks has left #openstack-dev15:04
*** lexinator has quit IRC15:05
*** basha has quit IRC15:06
*** noslzzp is now known as noslzzp_lunch15:06
*** noslzzp_lunch has quit IRC15:08
*** _TheDodd_ has joined #openstack-dev15:09
*** viraptor has joined #openstack-dev15:09
*** sushils has quit IRC15:09
*** jecarey_ has quit IRC15:10
viraptorhi all, does anyone know where in the code are the instance disks chowned to kvm/libvirt? I can't find the place which does that :/ the only explicit change I can see is to root in case of "uml" virtualisation15:11
*** mrodden has joined #openstack-dev15:11
*** markwash has quit IRC15:11
*** sushils has joined #openstack-dev15:12
*** rackerjoe has quit IRC15:14
*** briancurtin has quit IRC15:14
JordanPviraptor, I believe libvirt does the chown15:15
*** phschwartz has quit IRC15:15
*** lorin1 has joined #openstack-dev15:15
JordanPviraptor, ./qemu.conf:#dynamic_ownership = 115:15
viraptorJordanP: that would explain the missing code :) thanks15:16
*** hughsaunders has quit IRC15:16
*** slagle has quit IRC15:17
*** troytoman has quit IRC15:17
*** alunduil has joined #openstack-dev15:17
*** devvesa has quit IRC15:19
*** vkmc has joined #openstack-dev15:20
*** vkmc has quit IRC15:20
*** vkmc has joined #openstack-dev15:20
*** basha has joined #openstack-dev15:21
*** briancurtin has joined #openstack-dev15:21
*** basha_ has joined #openstack-dev15:22
*** terriyu has joined #openstack-dev15:23
*** jcannava has quit IRC15:25
*** basha has quit IRC15:25
*** Aj0 has quit IRC15:26
*** basha_ has quit IRC15:27
*** basha_ has joined #openstack-dev15:28
*** pmathews has joined #openstack-dev15:28
*** ruhe has joined #openstack-dev15:28
*** alexb_ has quit IRC15:28
*** jmontemayor has joined #openstack-dev15:30
*** jtomasek has quit IRC15:30
*** jsavak has joined #openstack-dev15:30
*** gsilvis has joined #openstack-dev15:30
*** devoid has joined #openstack-dev15:31
*** basha_ has quit IRC15:32
*** basha has joined #openstack-dev15:32
*** jecarey has joined #openstack-dev15:33
*** zbitter has joined #openstack-dev15:33
*** hughsaunders has joined #openstack-dev15:33
*** joesavak has quit IRC15:33
*** basha_ has joined #openstack-dev15:34
*** zaneb has quit IRC15:35
*** basha has quit IRC15:36
*** zaneb has joined #openstack-dev15:36
*** ifarkas has quit IRC15:36
*** phschwartz has joined #openstack-dev15:37
*** Mandell has quit IRC15:37
*** zbitter has quit IRC15:38
*** troytoman-away has joined #openstack-dev15:38
*** rackerjoe has joined #openstack-dev15:39
*** basha_ has quit IRC15:39
*** basha has joined #openstack-dev15:42
*** basha_ has joined #openstack-dev15:46
*** basha has quit IRC15:47
*** basha__ has joined #openstack-dev15:48
*** markwash has joined #openstack-dev15:49
*** spzala has joined #openstack-dev15:50
*** basha_ has quit IRC15:51
*** ruhe has quit IRC15:51
*** drewlander has joined #openstack-dev15:51
*** devvesa has joined #openstack-dev15:52
*** basha__ has quit IRC15:52
*** basha has joined #openstack-dev15:53
*** clayg_ is now known as clayg15:54
mordredmarkmc: dude. the indentation in nova is so bonghits15:54
markmcmordred, whyso?15:54
mordredmarkmc: because NONE of the indentation rules are enforced15:54
markmcmordred, whyso?15:54
mordredmarkmc: if you turn any of them on it is an absolute phonebook of problems15:54
markmcignore = E121,E122,E123,E124,E126,E127,E128,E711,E712,H102,H302,H404,F403,H501,F811,F84115:55
markmcthis?15:55
mordredmarkmc: yeah. all of the E1215:55
mordredyou can't turn on any of them, because it's that bad15:55
mordredeven 'multiple of four'15:55
markmcah15:55
mordredforget about over or under indented for visual indent :)15:55
markmcthe assertEqual() patch shouldn't make it worse though15:55
mordredI don't know how to find the errors15:57
mordredbecause the error checker is useless15:57
*** basha has quit IRC15:57
*** troytoman-away is now known as troytoman15:57
*** doron has joined #openstack-dev15:57
mordredwithout actually maually looking at all bazillion lines of it - at some point, we or someone needs to write a "please properly pep8 indent my code kthxbai" tool15:58
*** jgallard has quit IRC15:58
*** ruhe has joined #openstack-dev15:58
mordredand then we need to run it over nova when we're all sitting in the room at the summit15:58
markmcmordred, well, whoever reviews it should look at all the bazillion lines15:58
*** basha has joined #openstack-dev15:59
*** lexinator has joined #openstack-dev15:59
*** bdpayne has joined #openstack-dev15:59
*** hemna has joined #openstack-dev16:01
mordredmarkmc: sure. but that's scanning a bunch of obviously global search and replaced lines. sigh. in any case - lemme see if I can figure out a way to script figure it out16:02
*** ociuhandu has joined #openstack-dev16:02
*** tkammer has quit IRC16:03
*** sarob has joined #openstack-dev16:03
*** mmagr has joined #openstack-dev16:03
*** safchain has quit IRC16:04
*** troytoman is now known as troytoman-away16:04
*** colinmcnamara has joined #openstack-dev16:05
*** navid__ has left #openstack-dev16:05
*** basha has quit IRC16:05
*** colinmcnamara has left #openstack-dev16:05
*** doron is now known as doron_afk16:05
*** dripton_ is now known as dripton16:06
*** jistr has quit IRC16:07
*** mrodden has quit IRC16:09
*** psedlak has quit IRC16:10
*** grepory has joined #openstack-dev16:11
*** basha has joined #openstack-dev16:11
*** markmc has quit IRC16:11
ayounghenrynash, https://review.openstack.org/#/c/39530/17/keystone/common/config.py16:13
ayounghttps://review.openstack.org/#/c/39530/16..17/keystone/common/config.py16:14
henrynashayoung: so the only reason I didn't do it that way was in case we wante dot break out the individual groups to be done closer to the code (i.e. the ldap group was moved to the ldap driver or whatever)16:15
henrynashayoung: however, I'm fine with the approach you have added16:15
*** basha has quit IRC16:16
*** comstud_ is now known as comstud16:16
henrynashayoung: nice16:16
*** mrodden has joined #openstack-dev16:18
*** zackf is now known as jrclouda16:18
*** rwsu-away is now known as rwsu16:18
*** jrclouda is now known as zackf16:19
*** blamar has quit IRC16:20
*** garyk has quit IRC16:20
*** jbresnah has joined #openstack-dev16:20
*** xga has joined #openstack-dev16:20
*** xqueralt is now known as xqueralt-afk16:20
*** sarob has quit IRC16:21
*** xga_ has quit IRC16:23
*** comay has joined #openstack-dev16:24
*** kaushikc has joined #openstack-dev16:25
*** troytoman-away is now known as troytoman16:27
*** slagle has joined #openstack-dev16:27
*** freedomhui has quit IRC16:28
*** sarob has joined #openstack-dev16:28
*** xga has quit IRC16:29
*** lexinator1 has joined #openstack-dev16:30
*** flaper87 is now known as flaper87|afk16:31
*** lexinator has quit IRC16:32
*** cppcabrera has joined #openstack-dev16:33
*** cppcabrera has left #openstack-dev16:33
*** radez is now known as radez_g0n316:33
*** sarob has quit IRC16:34
*** sarob has joined #openstack-dev16:34
*** stevemar has quit IRC16:34
*** doron_afk has quit IRC16:35
*** aeperezt has joined #openstack-dev16:37
*** psedlak has joined #openstack-dev16:38
*** Bobba is now known as BobBall16:40
*** rwsu has quit IRC16:41
*** ruhe has quit IRC16:41
*** gyee has joined #openstack-dev16:42
*** ruhe has joined #openstack-dev16:43
*** yaguang has quit IRC16:44
*** HenryG_ has quit IRC16:44
*** HenryG has joined #openstack-dev16:45
*** emagana has joined #openstack-dev16:46
*** rwsu has joined #openstack-dev16:47
*** kbrierly has joined #openstack-dev16:48
*** mmoya has quit IRC16:48
*** MaxV has quit IRC16:49
*** amir1 is now known as asadoughi16:50
*** mrodden has quit IRC16:50
*** mrodden1 has joined #openstack-dev16:50
*** ruhe has quit IRC16:52
*** fabio_ has joined #openstack-dev16:52
*** fbo is now known as fbo_away16:53
*** MaxV has joined #openstack-dev16:54
*** lcheng has quit IRC16:54
*** kaushikc has quit IRC16:54
*** fabio has quit IRC16:55
*** lucasagomes has quit IRC16:55
*** sarob has quit IRC16:55
*** lcheng has joined #openstack-dev16:55
*** mdenny has quit IRC16:55
*** MIDENN_ has quit IRC16:55
*** mdenny has joined #openstack-dev16:55
*** MIDENN_ has joined #openstack-dev16:56
*** lexinator1 has quit IRC16:57
*** mrunge has joined #openstack-dev16:57
*** xqueralt-afk is now known as xqueralt16:59
*** sthaha has quit IRC16:59
*** kirankv has quit IRC17:00
*** lexinator has joined #openstack-dev17:00
*** troytoman is now known as troytoman-away17:00
ayounghenrynash, went to lunch...you can still break out individual entries if you want17:01
ayoungthis just manages the values for the big config file.17:01
henrynashayoung: sure, I'm OK with either approach17:01
*** sthaha has joined #openstack-dev17:02
*** sthaha has quit IRC17:02
*** sthaha has joined #openstack-dev17:02
*** alop has joined #openstack-dev17:03
*** alunduil has quit IRC17:04
*** dosaboy has quit IRC17:04
*** sthaha has quit IRC17:04
*** ruhe has joined #openstack-dev17:05
*** mrodden has joined #openstack-dev17:05
*** JordanP has quit IRC17:06
*** mmoya has joined #openstack-dev17:07
*** mrodden1 has quit IRC17:07
*** stevemar has joined #openstack-dev17:07
*** cmark has joined #openstack-dev17:07
henrynashayoung: btw, now that you have updated the patch, how do I update my local git to contain you changes?17:08
*** Aj0 has joined #openstack-dev17:09
*** noslzzp has joined #openstack-dev17:10
*** nati_ueno has joined #openstack-dev17:10
*** SumitNaiksatam has quit IRC17:12
ayounghenrynash, gitrevew -d <reviewid>17:12
ayoungminus the typos17:13
henrynashand will that update my existing one?17:13
henrynash(i.e. the copy I have locally)17:13
ayounggit review -d I489e8e50035f88eca4235908ae8b1a532645daab17:13
ayoungwill make a new local branch17:13
*** colinmcnamara has joined #openstack-dev17:13
ayoungand fetch the commit from the gerrit repo17:13
henrynashok, so i just ditch my original branch17:13
ayounghenrynash, have you done any more work on it?17:13
henrynashno, not since 1617:14
henrynashok, thx17:14
ayoungthen yeah.  I use git review even when working on my own changes17:14
ayoungthat way I never accidentally work on an older copy17:14
ayoungit makes a decent branch structure.  I use it for review when I want to run the code as well.17:15
*** wfoster is now known as wfoster_away17:15
henrynashayoung: and fetching the commit  - you mean just the id or the whole commit message?17:16
*** afazekas has quit IRC17:16
*** slagle has quit IRC17:17
*** BobBall is now known as BobBall_Away17:18
*** xqueralt is now known as xqueralt-afk17:19
*** alexb_ has joined #openstack-dev17:19
*** cmark has quit IRC17:20
*** harlowja has joined #openstack-dev17:22
*** garyk has joined #openstack-dev17:22
*** fabio has joined #openstack-dev17:22
*** dina_belova has quit IRC17:23
fabioayoung: I am trying to move my OS-EP-FILTER extension to the your new database migration solution17:23
*** Mandell has joined #openstack-dev17:23
fabioayoung: and I am struggling to get my tables built in the db, can you shed some light, please?17:24
*** martyntaylor has quit IRC17:24
*** dina_belova has joined #openstack-dev17:24
*** vipul is now known as vipul-away17:25
*** yolanda has quit IRC17:25
*** francois_eleouet has joined #openstack-dev17:26
gyeeayoung, I think fabio is the first one using the new extension migration framework17:26
*** vipul-away is now known as vipul17:27
henrynashayoung: ok, got it, np17:28
*** freedomhui has joined #openstack-dev17:28
*** colinmcnamara has quit IRC17:30
*** jonesld has joined #openstack-dev17:30
*** neelashah has quit IRC17:30
*** Guest95014 has quit IRC17:33
*** slagle has joined #openstack-dev17:33
*** neelashah has joined #openstack-dev17:34
*** cyeoh has quit IRC17:35
*** cyeoh has joined #openstack-dev17:35
*** SumitNaiksatam has joined #openstack-dev17:35
*** briancurtin has quit IRC17:36
*** vartom117 has joined #openstack-dev17:36
*** jasond has joined #openstack-dev17:37
*** sarob has joined #openstack-dev17:40
*** jfriedly has joined #openstack-dev17:40
*** mrunge has quit IRC17:44
*** jonesld has quit IRC17:44
*** martyntaylor has joined #openstack-dev17:45
*** sarob has quit IRC17:46
*** vipul is now known as vipul-away17:46
*** ondergetekende_ has joined #openstack-dev17:46
*** ondergetekende_ has quit IRC17:47
ayounggyee, it is in the oauth review , too17:47
ayoungfabio, what is the problem17:47
fabioayoung, I created a new repo following your example17:47
fabiobut how do I register it for the db to create the table, please?17:48
fabiothe db_sync does not pick it up17:48
ayoungfabio, explicit call17:48
*** nati_ueno has quit IRC17:48
ayoungkeystone-manage db_sync ---17:48
*** dina_belova has quit IRC17:49
fabioayoung, ok I will give it a try, thanks17:49
ayoungkeystone-manage db_sync --extension yourextension17:49
*** dina_belova has joined #openstack-dev17:49
fabioayoung, is yourextension the migrate_repo of the extension?17:50
*** gordc has quit IRC17:50
ayoungfabio, the assumption is that all extensions that go in to H3 are disabled by default, and have to be explicitly enabled.  If we want to make one explicitly enabled in Icehouse, we  will put in a list of extension that also get migrated via the core call17:50
ayoungso something like17:50
ayoungfor extension in ['kds', 'foo','bar'] :  migration.db_version_control(....)17:51
*** jbresnah has quit IRC17:51
ayoungbut since we don't have any yet, that code is not yet written17:51
fabioayoung, I guess EP Filter will be the first then17:51
gyeeayoung, what does that mean? we have to enable the extension in order for migration to work?17:52
*** tjones has joined #openstack-dev17:53
*** zul has quit IRC17:55
ayounggyee, other way around17:55
ayounggyee, we will have to explictly run the migration in order to be able to use the extension17:55
*** jruzicka has quit IRC17:55
gyeeso enabling extension and migration are two different thing17:55
ayounggyee, one is a DB thing, the other a pasteconfig pipeline change17:56
*** martyntaylor has quit IRC17:56
gyeeright, but they don't have to occur in certain order, just need to do both at some point before the extension is usable17:56
ayounggyee, however, if you get dolph to sign off on it, I am ok with making the migration run by default.  It just not code that is written yet17:56
*** mrunge has joined #openstack-dev17:56
ayoungfabio, gyee see keystone/cli.py line 7417:57
*** zbitter has joined #openstack-dev17:57
ayoungline 77-91 should be refactored out to a function migrate_extension(extension_name)17:57
*** dolphm has joined #openstack-dev17:58
*** sarob has joined #openstack-dev17:59
*** jruzicka has joined #openstack-dev17:59
*** vipul-away is now known as vipul17:59
*** zaneb has quit IRC18:00
gyeeayoung, got it, we don't need to enable extension migration by default as long as they are self-contained as they supposed to be18:00
ayounggyee, sounds good.  Idea is that we will move some migrations into the default list in Icehouse.18:00
*** leif has joined #openstack-dev18:01
*** mmagr has quit IRC18:01
*** leif is now known as Guest228118:01
*** alunduil has joined #openstack-dev18:01
*** boris-42 has quit IRC18:02
*** spzala has quit IRC18:03
*** francois_eleouet has quit IRC18:03
*** sudorandom has joined #openstack-dev18:04
*** spzala has joined #openstack-dev18:04
*** zbitter is now known as zaneb18:04
*** neelashah1 has joined #openstack-dev18:05
*** blamar has joined #openstack-dev18:05
*** neelashah has quit IRC18:05
*** Guest2281 has quit IRC18:06
*** gordc has joined #openstack-dev18:06
*** alexb_ has quit IRC18:06
*** jonesld has joined #openstack-dev18:07
*** leif_ has joined #openstack-dev18:07
*** ffio_ has joined #openstack-dev18:08
*** ffio has quit IRC18:09
*** martine_ has quit IRC18:09
*** martine has joined #openstack-dev18:09
*** martine is now known as martine_18:09
icchaannegentle: spoke to koolhead17 , up for the pdl18:11
koolhead17annegentle, ^^18:12
*** radez_g0n3 is now known as radez18:13
*** sushils has quit IRC18:14
*** leif__ has joined #openstack-dev18:15
*** leif_ has quit IRC18:15
*** ociuhandu has quit IRC18:15
*** terryh has joined #openstack-dev18:17
*** jhesketh has quit IRC18:17
*** francois_eleouet has joined #openstack-dev18:17
*** ruhe has quit IRC18:17
*** alexb_ has joined #openstack-dev18:20
*** loteriety has joined #openstack-dev18:20
*** Mandell has quit IRC18:21
*** boris-42 has joined #openstack-dev18:22
annegentleiccha: awesome, thanks. Still working through it but will put your name in.18:23
*** briancurtin has joined #openstack-dev18:24
*** xga has joined #openstack-dev18:26
*** dina_belova has quit IRC18:28
*** SergeyLukjanov has quit IRC18:28
*** otherwiseguy has quit IRC18:29
*** ruhe has joined #openstack-dev18:29
*** ruhe has quit IRC18:29
*** zul has joined #openstack-dev18:30
*** xga has quit IRC18:30
*** devvesa has quit IRC18:30
*** venkatesh has joined #openstack-dev18:32
*** Mandell has joined #openstack-dev18:34
*** jonesld has quit IRC18:35
*** edmund has joined #openstack-dev18:37
*** nati_ueno has joined #openstack-dev18:37
*** jmontemayor has quit IRC18:37
*** alexpilotti has quit IRC18:38
*** aelkikhia has left #openstack-dev18:39
*** novas0x2a|laptop has joined #openstack-dev18:39
*** terryh has quit IRC18:44
*** tjones has quit IRC18:44
*** alexb_ has quit IRC18:45
*** nayward has quit IRC18:46
*** Alexei_987 has quit IRC18:48
*** melwitt has joined #openstack-dev18:48
*** jasdeepH has joined #openstack-dev18:49
*** SergeyLukjanov has joined #openstack-dev18:56
*** freedomhui has quit IRC18:57
*** noslzzp has quit IRC18:58
*** datsun180b_ has joined #openstack-dev19:00
*** comay has quit IRC19:00
*** francois_eleouet has quit IRC19:00
*** comay has joined #openstack-dev19:00
*** jlabocki1 has quit IRC19:01
*** datsun180b has quit IRC19:01
*** datsun180b_ is now known as datsun180b19:01
*** Aj0 has quit IRC19:01
*** colinmcnamara has joined #openstack-dev19:03
*** edmund has quit IRC19:04
*** troytoman-away is now known as troytoman19:04
jasondis anybody on the oslo.config team around?19:04
*** ffio_ has quit IRC19:06
*** zaneb has quit IRC19:06
*** zaneb has joined #openstack-dev19:07
*** colinmcnamara has quit IRC19:08
*** t-8ch has quit IRC19:09
*** datsun180b has quit IRC19:10
*** t-8ch has joined #openstack-dev19:10
*** datsun180b has joined #openstack-dev19:10
*** Aj0 has joined #openstack-dev19:11
*** zaneb has quit IRC19:12
*** martine_ has quit IRC19:12
*** zaneb has joined #openstack-dev19:13
*** Chaser has quit IRC19:14
*** nati_ueno has quit IRC19:15
*** Chaser has joined #openstack-dev19:16
*** markmc has joined #openstack-dev19:16
*** francois_eleouet has joined #openstack-dev19:17
*** adalbas has quit IRC19:17
markmcsimo, hey19:19
*** jbresnah has joined #openstack-dev19:19
*** spandhe has joined #openstack-dev19:19
simomarkmc: sup ?19:21
markmcsimo, wondering what's the latest on the secure messaging stuff19:21
markmcsimo, before release meeting in a couple of hours19:21
simomarkmc: working on it today19:22
simomarkmc: I should have patches for you tomorrow19:23
simomarkmc: some provisional as we are still reviewing the KDS API in keystone19:23
simomarkmc: but it should be only a minor change to KDSClient19:23
markmcsimo, yeah ... but there hasn't been any updates to the KDS patch review either?19:23
markmcsimo, where have the KDS API discussions been going on?19:24
simomarkmc: they told me late we needed to ogo through an api patch review first19:24
simoso we are reviewing the api document now19:24
simoonce that is final I can push a new revised patch for KDS itself19:24
simoI have those patches ready19:24
*** gyee has quit IRC19:25
markmcah, this: https://review.openstack.org/#/c/40692/19:25
* markmc looks19:25
markmcI'll add a comment to the blueprint and gerrit review19:25
markmcbecause anyone checking on the status just sees that there's been no progress19:25
jasondmarkmc: do you have any suggestions on how we might ensure the CLI options override the config file options? http://dunsmor.com/heat/bug-1195236.html19:25
*** JonnyNomad has joined #openstack-dev19:25
simomarkmc: thanks19:26
simosorry I coldn't speed this up,. but I had to work on a different project last week19:26
jasondright now --verbose and --debug are separate options.  making a --log-level option would solve this, but is there a nicer way?19:26
*** vipul is now known as vipul-away19:27
*** cthulhup has joined #openstack-dev19:27
*** neelashah1 has quit IRC19:27
markmcsimo, was there a bunch of discussion around patch set 1-4 of that review?19:28
simostevemar: Steve Martinelli ?19:28
markmcsimo, I only see stuff starting from patch set 519:28
stevemarsimo: hola19:28
*** odyssey4me has quit IRC19:28
simostevemar: I am reading your review, it is too dense19:28
simohalf of your remarks I can't understand what you want19:28
*** dina_belova has joined #openstack-dev19:28
simostevemar: what do you want to put in the header ?19:29
markmcjasond, what version of oslo.config is this?19:29
stevemarsimo: anything I can help with. sure, let me find an example19:29
*** adalbas has joined #openstack-dev19:29
simostevemar: keep in mind these code is already done19:29
simostevemar: so I want *very* good reasons for changes :)19:29
stevemarsimo: the implementation?19:30
*** chuckieb has quit IRC19:30
markmcjasond, see http://docs.openstack.org/developer/oslo.config/#a319:30
stevemarsimo: i just have issues with the spec :)19:30
markmcjasond, https://bugs.launchpad.net/oslo/+bug/117681719:30
uvirtbotLaunchpad bug 1176817 in oslo "Give priority to CLI args" [High,Fix released]19:30
stevemarsimo: if you look at https://review.openstack.org/#/c/37545/10/openstack-identity-api/v3/src/markdown/identity-api-v3-os-quotas-ext.md19:30
simostevemar: yeah the spec came after the implementation for various reasons19:31
*** xBsd has joined #openstack-dev19:31
stevemarthe headers all have the same format ie: #### Get resource list: `GET /OS-QUOTAS/resources`19:31
*** dina_belova has quit IRC19:31
stevemarsimo: whereas yours have: #### Request attributes19:31
stevemarsimo: then the method/endpoint afterward19:31
simostevemar: ooh19:31
simook19:32
stevemarsimo: just not consistent with the others :)19:32
simoI told you you were too dense19:32
simoI thought you meant HTTP Headers19:32
stevemaroh haha19:32
simoand I was all WTF ?19:32
stevemarnah nah19:32
stevemarsorry, i was trying to do too many things at once19:32
simonp19:32
stevemarlet me know if you have any other q's, i was very liberal in not being specific :)19:33
simoif it is just the document headers I am going to fix and push now19:33
stevemara few others too, I think you used Returns: or Reply: in some places, stick with "Response"19:34
stevemarsimo^19:34
simoyup I just saw that and was fixin;19:34
*** giulivo has quit IRC19:34
stevemarcool cool19:34
*** otherwiseguy has joined #openstack-dev19:35
*** neelashah has joined #openstack-dev19:36
*** tiamar has left #openstack-dev19:36
ayoungstevemar, thanks for the KDS review.  Putting you through the paces paid off.19:37
stevemarhaha, ayoung: yep, i've learned19:38
*** jmontemayor has joined #openstack-dev19:38
morganfainbergsimo: i think i have a couple of added notes regarding the phrasing, but it really doesn't have much that needs fixing19:38
*** dina_belova has joined #openstack-dev19:38
simostevemar: the link is perfectly valid though, why you say it is not valid ?19:38
simomorganfainberg: ack19:38
stevemarsimo: it wouldn't be click-able :D19:38
simostevemar: how do you make it clickable ?19:39
morganfainbergsimo: about to post my comments but they are mostly just for ease of reading :)19:39
stevemarsimo: http://daringfireball.net/projects/markdown/dingus19:39
simoI couldn't find a way, I am not markdown-savvy19:39
jasondmarkmc: i actually tested that code, but it didn't fix the problem19:39
*** qba73_ has joined #openstack-dev19:39
jasondmarkmc: the issue stems from the fact that --verbose and --debug are treated separately19:39
*** tiamar has joined #openstack-dev19:40
stevemarsimo: like this New link, click [here](http://www.blah.org)19:40
jasondwhen they are really one option19:40
stevemarthe text that you want to hyper-link should be in square braces19:40
stevemarand the actual link in ()19:40
stevemarsimo^19:40
*** sarob has quit IRC19:40
simostevemar: ok19:40
*** qba73_ has left #openstack-dev19:40
*** sarob has joined #openstack-dev19:41
*** dina_belova has quit IRC19:43
markmcjasond, ok - looking closer, that seems like the right behaviour to me19:44
markmcjasond, verbose increases the log level to INFO, debug increases it to DEBUG19:44
*** cthulhup has quit IRC19:44
markmcjasond, it's the behaviour I'd expect19:44
morganfainbergsimo: published my comments.  It looks good from a readablility standpoint (and Stevemar got most of the other things i would say in his comments)19:45
markmcjasond, if you want debug message, but not info messages ... using --log-config should do it I think19:45
* markmc adds those comments to the bug19:45
jasondmarkmc: senario #2 specifically http://dunsmor.com/heat/bug-1195236.html19:45
jasondin that case, the CLI option is being overridden by the config file19:46
markmcverbose=True, debug=True heat-engine -v19:46
markmcthat one ?19:46
markmc-v sets verbose=True19:47
markmcthe config file sets verbose=True19:47
jasondyes.  but those options aren't independent19:47
jasond--verbose is like --log-level=INFO19:48
markmcwhat behaviour do you expect in scenario #2 and why?19:48
jasond--debug is like --log-level=DEBUG19:48
*** portante is now known as portante|afk19:48
markmcnot exactly, no19:48
markmcdebug is enable debugging19:49
markmconly debug=False will turn off debugging19:49
markmcverbose=True has no effect if debug=True19:49
* markmc goes for dinner19:49
*** fabio has quit IRC19:50
*** dina_belova has joined #openstack-dev19:50
jasondmarkmc: if the config file says log-level=DEBUG and the CLI says --log-level=INFO, the log level should be INFO, not DEBUG19:51
ayoungmarkmc, when you come back, tell me if this is the general approach to configuration you think we should support:  https://review.openstack.org/#/c/39530/17/keystone/common/config.py19:51
ayounghenrynash, can you +1 your own review request if you think it is good, and I will do the same?19:51
ayounghttps://review.openstack.org/#/c/39530/1719:51
*** alop_ has joined #openstack-dev19:52
*** lifeless_ is now known as lifeless19:52
*** xBsd has quit IRC19:52
*** alop has quit IRC19:52
*** alop_ is now known as alop19:52
*** ruhe has joined #openstack-dev19:53
*** topol has quit IRC19:53
*** pcm_ has quit IRC19:53
*** zaitcev has joined #openstack-dev19:54
*** lexinator1 has joined #openstack-dev19:54
*** mdenny has quit IRC19:55
*** MIDENN_ has quit IRC19:55
*** cthulhup has joined #openstack-dev19:55
*** AlanClark has joined #openstack-dev19:55
*** lexinator has quit IRC19:56
*** mdenny has joined #openstack-dev19:56
simomorganfainberg: the principal advantage is one, why do you want me to make it plural ?19:56
*** MIDENN_ has joined #openstack-dev19:56
*** jruzicka has quit IRC19:56
morganfainbergsimo: you have a run-on sentence that is more of a list of "advantages" in the way it's written19:56
*** devvesa has joined #openstack-dev19:56
simono the 'and' is not a separator that define 2 advantages19:57
*** adjohn has joined #openstack-dev19:57
simoit is a conjunction that expands on the only one19:57
*** drewlander has quit IRC19:57
morganfainbergsec.19:57
simomorganfainberg: I blame ayoung for that convoluted phrase though, :)19:57
morganfainberghehe19:58
morganfainbergthe conjunction is just not clear19:58
*** adjohn has quit IRC19:58
morganfainberg"the Encryption and Signing Key exchange can be regulated by the Key Server" one phrase, "and it can apply access control" second phrase, "and deny communication between arbitrary peers in the system"19:59
morganfainbergthrd19:59
bknudsonayoung: you asked to be added to LDAP reviews, so I added you to some I submitted.19:59
morganfainbergthe issue is that when reading it, you get "and this and that"19:59
simomorganfainberg: I can see that20:00
morganfainbergsimo: so rephrasing without the second "and" would make it more readable, or call it multiple principal benefits :)20:00
simonot sure how to fix it20:00
morganfainbergsimo: if you give me a few moments i'll see if i can come up with something.20:00
*** neelashah has quit IRC20:00
*** francois_eleouet has quit IRC20:01
*** sandywalsh has quit IRC20:01
*** Aj0 has quit IRC20:02
simomorganfainberg: yup, still going through dolphm comments20:02
morganfainbergsimo: "The principal advantage of using a Key Server instead of a pure public-key based system is that the Encryption and Signing Key exchange can be regulated by the Key Server allowing application of access controls and denying communications between arbitrary peers within the system." ?20:03
*** francois_eleouet has joined #openstack-dev20:03
*** zul has quit IRC20:04
*** jonesld has joined #openstack-dev20:04
*** colinmcnamara has joined #openstack-dev20:06
*** tjones has joined #openstack-dev20:06
*** spzala has quit IRC20:07
*** Aj0 has joined #openstack-dev20:08
*** datsun180b_ has joined #openstack-dev20:08
*** jruzicka has joined #openstack-dev20:09
simomorganfainberg: I'll think about that, it look good at a quick read20:09
*** mkollaro has quit IRC20:10
morganfainbergsimo: sure. thing, just as an option.20:10
*** datsun180b has quit IRC20:11
*** datsun180b_ is now known as datsun180b20:11
*** venkatesh has quit IRC20:11
*** dprince has quit IRC20:12
*** sandywalsh has joined #openstack-dev20:13
*** dolphm has quit IRC20:13
*** troytoman is now known as troytoman-away20:13
*** vipul-away is now known as vipul20:14
*** adjohn has joined #openstack-dev20:16
*** vkmc has quit IRC20:16
*** sandywalsh has quit IRC20:20
*** neelashah has joined #openstack-dev20:20
ayoungstevemar, do you think you might want sql_upgrade testing for oauth?20:23
ayoungI won't insist on it, but it is probably worth adding20:23
*** colinmcnamara has quit IRC20:24
boris-42mordred Hi20:24
ayoungbknudson, since you wrote, and sahdev reviewed, I felt OK +2 and approving a few of those LDAP changes20:25
*** jkyle has quit IRC20:25
bknudsonayoung: great. We've got someone here testing active directory and they had these problems.20:26
bknudsonand I felt the need to update tests.20:26
ayoungbknudson, I want to reenable the Unicode one once we have a solution there.20:27
bknudsonayoung: yes. I put the skip in because I wanted to get clean runs.20:27
ayoungbknudson, agreed.  We really need to get LDAP support in the gate job.  With the split backend, it should be easier20:28
ayoungwe'll get testing of both SQL and LDAP in one pass20:28
morganfainbergayoung: that will be nice20:28
bknudsonjust need an active directory server20:29
bknudson;)20:29
*** vkmc has joined #openstack-dev20:29
ayoungbknudson, no.  No we do not.20:30
*** tserong_ has joined #openstack-dev20:30
*** tserong has quit IRC20:33
*** sandywalsh has joined #openstack-dev20:33
*** cthulhup has quit IRC20:35
*** jonesld has quit IRC20:35
*** woodspa has quit IRC20:35
ayoungbknudson, is https://review.openstack.org/#/c/40893/5/keystone/identity/backends/ldap.py  still safe for normal LDAP?20:38
ayoungint(self.enabled_default))  seems to imply it must be an integer.  THought that was an AD thing only20:38
*** dina_belova has quit IRC20:39
bknudsonayoung: we only get into this code if they have self.enabled_mask set.20:39
*** vipul is now known as vipul-away20:39
ayoungright...I misread that.  So it compares one int with another this way...20:40
bknudsonayoung: so if you have enabled_mask set, then enabled_default must be an integer20:40
*** francois_eleouet has quit IRC20:40
ayoungcfg.IntOpt('user_enabled_mask', default=0),20:40
*** nachi has joined #openstack-dev20:41
*** ruhe has quit IRC20:41
bknudsonayoung: the enabled_mask is checked for != 0 at line 12020:41
ayoungyep.  +2ed and approved20:42
ayoungget sahdev to chime in on https://review.openstack.org/#/c/40996/ and I'll approve as well. Or someone else with LDAP background20:42
*** adjohn has quit IRC20:43
ayoungbknudson, https://review.openstack.org/#/c/41515/3/keystone/common/ldap/core.py  do we always want to normalize?  This seems too AD specific too me20:45
*** ruhe has joined #openstack-dev20:45
bknudsonayoung: it is a little heavy-weight.20:45
*** mrunge has quit IRC20:45
*** vipul-away is now known as vipul20:45
bknudsonayoung: but I didn't make it AD-specific because it's really about LDAP compatibility20:45
*** adalbas has quit IRC20:45
bknudsonayoung: I don't think there's anything in the spec that says the server can't normalize DN attribute values.20:46
*** ruhe has quit IRC20:46
bknudsonthis is where it would be useful to have an AD-specific LDAP backend.20:46
nachitopol: you online20:47
bknudsonI think an LDAP server (and maybe AD does this) could do more types of normalization than just capitalizing the attr names...20:47
ayoungbknudson, this code bothers me.  I am not comfortable with doing something AD specific that might break non AD LDAP deployments.20:47
bknudsoncould probably change "commonName=xxx" to "CN=xxx" if it wanted.20:47
bennerls20:48
ayoungnot by default, and not if there is another way to confgure that gets the same result20:48
bknudsonayoung: the only thing we actually do is normalize the DNs when compare DNs in the role check.20:48
*** tmclaugh[work] has quit IRC20:48
bknudsonhttps://review.openstack.org/#/c/41515/3/keystone/assignment/backends/ldap.py20:48
bknudsonThat's the only real change. The others are testing.20:48
*** xqueralt-afk is now known as xqueralt20:49
*** troytoman-away is now known as troytoman20:49
bknudsonthere's no change to how the entries are sent to the db.20:49
*** xqueralt is now known as xqueralt-afk20:50
bknudsonI changed FakeLDAP to also mess up the member attribute and found that there was noplace where that caused a problem with comparing DNs.20:50
ayoungyeah, I see that.  I am not saying no, just seeing if my stomach settles before OKing this one20:50
bknudsontry ginger ale20:51
stevemarayoung: ping20:53
ayoungstevemar, yep20:53
stevemarayoung: ugh, nvm, i ping'ed too hastily...20:53
* stevemar walks away awkwardly20:54
morganfainbergstevemar: ministry of funny walks time?20:54
stevemarmorganfainberg: possibly20:55
ayoungstevemar, It's not particularly silly, is it? I mean, the right leg isn't silly at all and the left leg merely does a forward aerial half turn every alternate step.20:56
morganfainberglbragstad: just checking one more thing on your (initial implementation) logging patch, it's looking good20:56
*** loteriety has quit IRC20:56
*** boris-42 has quit IRC21:00
*** vkmc has quit IRC21:00
*** troytoman is now known as troytoman-away21:00
*** dolphm has joined #openstack-dev21:00
lbragstadmorganfainberg: cool, there is one dependent on it that does more of the refactoring21:01
*** moted has quit IRC21:02
*** vipul is now known as vipul-away21:02
*** moted has joined #openstack-dev21:02
*** boris-42 has joined #openstack-dev21:02
*** gabrielhurley has joined #openstack-dev21:03
*** ms_brown has quit IRC21:03
*** lorin1 has quit IRC21:03
morganfainberglbragstad: yeah.  i saw that.21:06
ayoungdolphm, https://review.openstack.org/#/c/41606/5  leaves me wondering if we should not be stating what the service types are at all.21:06
stevemarayoung: added upgrade/downgrade tests for sql in my oauth patch21:06
lbragstadmorganfainberg: cool, thanks again for checking it out21:06
ayoungstevemar, cool, I'll look21:06
dolphmayoung: agree21:06
morganfainberglbragstad: i am just setting up httpd keystone so i can verify it looks good, but it's easy, not surprises yet21:06
*** boris-42 has quit IRC21:07
morganfainbergno*21:07
dolphmayoung: especially with 'one of' instead of simply 'e.g.'21:07
*** adjohn has joined #openstack-dev21:07
lbragstadmorganfainberg: good deal!21:07
dolphmayoung: sounds like that list is going to be enforced21:07
*** jsavak has quit IRC21:07
*** andymccr has quit IRC21:07
*** t-8ch has quit IRC21:08
ayoungdolphm, yeah, and I think we will see an explosion of services in the not-too-distant future21:08
dolphmayoung: already seeing it!21:09
*** xBytez has quit IRC21:09
*** t-8ch has joined #openstack-dev21:11
*** sushils has joined #openstack-dev21:11
*** rfolco has quit IRC21:12
*** andymccr has joined #openstack-dev21:12
ayoungstevemar, +2 from me21:13
ayoungwell done21:13
*** vartom117 has quit IRC21:14
*** jpich has quit IRC21:14
stevemarayoung, yay! thanks man21:14
*** MaxV has quit IRC21:17
morganfainbergstevemar: i'm going to do 1 more pass on it, but i should get to that in the next 20 mins21:19
ayoungstevemar, did yousee what I wrote to fabio_ about migrations for extensions?  Right now,they will not be run unless you explicitly pass them to keystone-manage.  IN Icehouse, we can add supported extensions to the list of  migrations run by default.21:19
*** devvesa has quit IRC21:19
*** bswartz has quit IRC21:19
morganfainbergstevemar: but it looks like you hit the last of my concerns easily with the last patchsets.21:20
stevemarayoung: i didn't see that written to fabio, but i noticed it in the docs.21:20
stevemarmorganfainberg: i think so, between last night and this morning21:20
morganfainbergstevemar: yeah, it was def. super close.21:21
*** adjohn has quit IRC21:21
stevemarmaybe dolphm wants the final stamp of approval? he recommended the last 3 access_token apis21:21
morganfainbergI was going to +2 if it was good but not approve21:22
dolphmstevemar: which patch?21:22
morganfainbergstevemar: in case someone else wanted to say something.21:22
stevemardolphm: latest21:22
*** t-8ch has quit IRC21:22
*** andymccr has quit IRC21:22
stevemarmorganfainberg: ah21:22
dolphmstevemar: oauth impl?21:22
stevemardolphm: is there anything else i do? yes :)21:22
*** galstrom has quit IRC21:22
morganfainbergstevemar: it's pretty massive changeset.  lots of eyes and all21:23
*** Thor^^ has joined #openstack-dev21:23
*** markmc has quit IRC21:23
*** Thor has quit IRC21:23
morganfainbergoh whoopse. crap, did I approve before smokestack on that logging one?21:24
*** jkyle has joined #openstack-dev21:24
ayoungmhu, I like what you are doing with ec2 token stuff.  just want to make sure you rebase your approach on the other credential work going on. Let me know if you have any questions.21:24
morganfainbergnoticed jenkins said +1 but not smoekstack =/  sorry if that was wrong21:25
*** vipul-away is now known as vipul21:25
*** nati_ueno has joined #openstack-dev21:25
*** xBsd has joined #openstack-dev21:25
lbragstadmorganfainberg: thanks for the +2, I repushed the dep. commit. ayoung looked at that one too. https://review.openstack.org/#/c/41484/21:26
morganfainberglbragstad: ok.21:26
*** jasondotstar has quit IRC21:26
morganfainberglbragstad: i'm going to take a bit more time on that one.  there is a bunch of stuff (nothing major, but still)21:27
morganfainbergi don't expect it'll be any issue though.21:27
stevemarsimo: one last fix and i promise +1 next time :D21:28
lbragstadmorganfainberg: yeah, I agree.. that commit touches a lot of files.21:28
*** adjohn has joined #openstack-dev21:28
ayounglbragstad, tell me notifiers should not be stand alone library:  merge downs of +7351 lines...21:28
dolphmsimo: o/21:28
*** andymccr has joined #openstack-dev21:28
lbragstadayoung: that is the notifier and it's deps...21:29
lbragstadI didn't add or remove anything. that's just the sync from Oslo21:29
*** t-8ch has joined #openstack-dev21:29
bknudsonwe must have all of oslo by now21:29
lbragstadbknudson: pretty close21:29
ayounglbragstad, I am trusting that you did not put any of your own backdoors in there21:29
morganfainbergbknudson: on the plus side, we wont be lagging behind :P21:29
lbragstadayoung: hah no I didn't21:29
ayoungthere, I have it in writing21:30
simodolphm: hi21:30
lbragstadayoung: just a bunch of eventlet rewrites21:30
ayoungheh21:30
dolphmsimo: are you following #openstack-meeting?21:30
*** galstrom has joined #openstack-dev21:30
morganfainberglbragstad: oh my… just looked at the oslo sync....21:30
lbragstadmorganfainberg: hah yeah, that was my reaction too21:30
simodolphm: sorry no, let me join21:31
morganfainbergayoung: unless you have issue with it, i'll follow your lead in regards to that one. (the … 7000+ lines)21:31
ayoungsimo, probably too late, but you will get the logs from evesdrop...I'll link21:31
simoayoung: ok21:31
dolphmsimo: bit late... but we discussed the state of kds during oslo and keystone21:31
simook21:31
dolphmsimo: check the meeting logs?21:31
ayoungsimo http://eavesdrop.openstack.org/irclogs/%23openstack-meeting/%23openstack-meeting.2013-08-13.log21:31
dolphmayoung: danke!21:31
*** cp16net has left #openstack-dev21:32
lbragstadayoung: morganfainberg the majority of the change lies within https://github.com/openstack/oslo-incubator/tree/master/openstack/common/rpc and https://github.com/openstack/oslo-incubator/tree/master/openstack/common/notifier21:32
*** gyee has joined #openstack-dev21:33
*** neelashah has quit IRC21:33
morganfainberglbragstad: yeah i uhm.21:34
morganfainbergit's a ton21:34
morganfainberg:P21:34
*** boden has quit IRC21:34
simodolphm: checked, no much discussion I can see, except questions of whther kds should be included or not21:35
*** cthulhup has joined #openstack-dev21:35
simoI am of course in favor21:35
* simo totally unbiased :)21:36
*** diogogmt has joined #openstack-dev21:36
lbragstadmorganfainberg: yeah, I know it... quite a bit of code.21:37
morganfainbergstevemar: yeah +2'd just not clicking the approved so if dolphm wants to weigh in, etc they have a chance.  like i said, tons of code, deserves a hard look.21:37
morganfainbergdolphm or others that is.21:37
dolphmmorganfainberg: stevemar: send me a link21:37
morganfainbergdolphm: https://review.openstack.org/#/c/29130/21:38
dolphmwould love to21:38
stevemarbeat me to it!21:38
morganfainbergand still waiting on jenkins too it looks like.21:38
dolphmmorganfainberg: stevemar: thanks!21:38
stevemarmorganfainberg: dolphm: i'm getting out of here for now anyway. ayoung: thx for looking at the patch today21:39
morganfainbergstevemar: see ya later.21:39
*** dina_belova has joined #openstack-dev21:39
*** lbragstad has quit IRC21:39
bknudsonayoung: sent spzala a note and he was quick to review https://review.openstack.org/#/c/40996/21:40
ayoungstevemar, approved.21:40
*** litong has quit IRC21:40
ayoungOops.  dolphm want me to hold off on that?21:40
morganfainberghehe21:41
ayoungdroppped the approved, not sure if that stops the gate.21:41
dolphmayoung: yeah, i'd like to take a pass21:41
morganfainbergdon't know what happens in that case ayoung21:41
morganfainbergguess we'll find out right?21:42
dolphmayoung: i think you killed the check and verification and another check will be started21:42
ayoungmorganfainberg, it takes a while to get through anyway, so dolphm has time to review even if it continues processing.21:42
dolphmayoung: adding an +approve kills a running check; removing the +approve kills the verification21:42
morganfainbergayoung: yeah.21:42
*** armax has left #openstack-dev21:42
morganfainbergdolphm: oh, good to know21:43
ayoungbut it looks like it is still in the zuul queue21:43
dolphm(i could be lying - check zuul!)21:43
*** stevemar has quit IRC21:43
ayounghttp://status.openstack.org/zuul/21:43
morganfainbergzuul seems to still be chugging on it21:43
ayoungstill there.21:43
morganfainbergquick −2 it!21:43
morganfainberg:P21:43
ayoungbut the queue is like 45 minutes long.21:43
morganfainbergright21:43
*** dina_belova has quit IRC21:44
morganfainberga −2 would prevent merge if i understand gerrit21:44
ayounglet me see.21:44
morganfainbergbut, don't know if it would stop the gate21:44
*** cthulhup has quit IRC21:44
dolphmsimo: relevant bit- http://paste.openstack.org/raw/44075/21:44
morganfainbergi don't know how we do merging tbh, if gerrit does the merging, −2 or lack of approved should hold it.21:44
morganfainbergif jenkins does the actual merge, no idea21:45
dolphmmorganfainberg: it's a jenkins job21:45
morganfainbergdolphm: ah, then i don't know what the end result will be.21:45
dolphmmorganfainberg: the change is only in the check queue, not the queue to gate21:45
morganfainbergahh21:45
morganfainberggood ot know21:45
ayoungdolphm, I have a -2 on oauth for now.  Tell me and I will lift it.21:46
dolphmayoung: go ahead and lift it21:46
dolphmayoung: i'm just writing an email and then i'll review it21:46
*** pmathews has quit IRC21:47
ayoungdolphm, done.  On KDS, I think it is safe to get in to Keystone, as it will not be enabled by default.  If it is not there, no one can use it.  However, it is a significant imporvment over the existing RPC approach of no message security, so I would think it would not have a negative effect even if it were broken21:48
ayoungI'd say it is low risk21:48
*** Aj0 has quit IRC21:49
dolphmayoung: going to start a discussion on list about it21:49
*** dina_belova has joined #openstack-dev21:49
*** MaxV has joined #openstack-dev21:50
*** dina_belova has quit IRC21:54
*** rharwood has quit IRC21:54
*** stevemar-droid has joined #openstack-dev21:56
*** ayoung has quit IRC21:57
dolphmhenrynash: your biggest pagination stakeholder has spoken up on list :) (thanks gabrielhurley!)21:57
gabrielhurleyheh. for sure.21:58
gabrielhurleyI'm all for killing pagination. it blows. kill it.21:58
gabrielhurleyI just don't want to build pagination on top of an API that doesn't do a good job of it.21:58
gabrielhurleymaking everything else better is a great alternative21:58
*** rnirmal has quit IRC21:59
*** beagles has quit IRC22:01
*** datsun180b has quit IRC22:03
*** burt has quit IRC22:04
*** SergeyLu_ has joined #openstack-dev22:04
*** kbringard has quit IRC22:05
*** SergeyLukjanov has quit IRC22:06
*** beagles has joined #openstack-dev22:06
*** SergeyLu_ has quit IRC22:09
*** jecarey has quit IRC22:09
*** sarob has quit IRC22:12
*** aeperezt has quit IRC22:12
*** adjohn has quit IRC22:12
*** sarob has joined #openstack-dev22:12
*** stevemar-droid has quit IRC22:14
*** adjohn has joined #openstack-dev22:15
*** jasondotstar has joined #openstack-dev22:16
*** sarob has quit IRC22:17
*** andymccr has quit IRC22:19
*** t-8ch has quit IRC22:20
*** galstrom has quit IRC22:21
dolphmcc: ttx russellb jd__ http://lists.openstack.org/pipermail/openstack-dev/2013-August/013592.html22:21
dolphmbecause i didn't want to bump into the cc limit of openstack-dev again ;)22:22
*** mrodden has quit IRC22:23
bknudson"what percentage of the time do you click to the second page of results in Google" -- ayoung asked that yesterday.22:23
*** esheffield has quit IRC22:25
*** galstrom has joined #openstack-dev22:25
*** vkmc has joined #openstack-dev22:26
*** briancurtin has quit IRC22:26
*** adjohn has quit IRC22:26
*** andymccr has joined #openstack-dev22:27
*** jcannava has joined #openstack-dev22:28
gabrielhurleydarn. I missed that. I thought I was being original.22:28
*** _TheDodd_ has quit IRC22:28
*** t-8ch has joined #openstack-dev22:28
russellbdolphm: syn-ack22:29
*** changbl has quit IRC22:31
*** gabrielhurley has quit IRC22:31
*** dripton has quit IRC22:31
*** t-8ch has quit IRC22:33
*** MaxV has quit IRC22:35
*** dripton has joined #openstack-dev22:35
*** xBsd has quit IRC22:35
*** andymccr has quit IRC22:36
*** galstrom is now known as galstrom_zzz22:36
*** beagles has quit IRC22:36
*** t-8ch has joined #openstack-dev22:38
*** sarob has joined #openstack-dev22:38
*** andymccr has joined #openstack-dev22:38
*** cthulhup has joined #openstack-dev22:41
*** hartsocks has joined #openstack-dev22:41
*** jhesketh has joined #openstack-dev22:41
*** beagles has joined #openstack-dev22:42
*** FunnyLookinHat has quit IRC22:42
*** troytoman-away is now known as troytoman22:42
*** AlanClark has quit IRC22:43
*** morazi has quit IRC22:43
*** spandhe has quit IRC22:44
*** hartsocks has quit IRC22:45
*** hartsocks has joined #openstack-dev22:46
*** troytoman is now known as troytoman-away22:47
*** cthulhup has quit IRC22:49
*** sudorandom has quit IRC22:49
*** dina_belova has joined #openstack-dev22:50
*** jimfehlig has quit IRC22:53
*** dina_belova has quit IRC22:55
*** troytoman-away is now known as troytoman22:57
*** amerine_ has quit IRC22:58
*** wolfdreamer has quit IRC22:58
*** devoid has quit IRC22:59
*** carl_baldwin has quit IRC22:59
*** amerine has joined #openstack-dev23:00
*** anniec has joined #openstack-dev23:04
*** vaml has joined #openstack-dev23:07
samalbadoes anyone have the answer of that: https://answers.launchpad.net/devstack/+question/233734 ?23:09
samalbaI get that on my VM (after running ./rejoin.sh on devstack)23:10
*** xBsd has joined #openstack-dev23:10
*** _cerberu` is now known as _cerberus_23:11
*** sdague has quit IRC23:13
*** bknudson has quit IRC23:16
*** otherwiseguy has quit IRC23:16
morganfainbergaha, dolphm looks like removing approved means it verifies but doesn't merge (just looking att he state of the oauth stuff)23:16
*** xBsd has quit IRC23:16
*** kbrierly has quit IRC23:17
*** blamar has quit IRC23:18
*** jmontemayor has quit IRC23:23
*** jhesketh has quit IRC23:29
*** jhesketh has joined #openstack-dev23:29
*** vaml1 has joined #openstack-dev23:32
*** adjohn has joined #openstack-dev23:37
*** tjones has quit IRC23:39
dolphmmorganfainberg: weird, good to know23:40
*** markwash has quit IRC23:40
*** alop has quit IRC23:40
*** alop has joined #openstack-dev23:41
*** rcleere has quit IRC23:42
*** adjohn has quit IRC23:42
*** hartsocks has left #openstack-dev23:46
*** armax has joined #openstack-dev23:47
*** dina_belova has joined #openstack-dev23:50
*** athomas has quit IRC23:50
*** dina_belova has quit IRC23:53
*** sungju has joined #openstack-dev23:56
*** adjohn has joined #openstack-dev23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!