Tuesday, 2013-07-30

« Monday, 2013-07-29 Index Wednesday, 2013-07-31 »
*** dina_belova has quit IRC00:00
*** luis_ has quit IRC00:01
*** luis_ has joined #openstack-dev00:02
openstackgerritA change was merged to openstack/python-openstackclient: Add server resize command  https://review.openstack.org/3872000:02
*** nachi has quit IRC00:04
*** alunch has joined #openstack-dev00:05
*** alunduil has joined #openstack-dev00:05
*** anfrolov has quit IRC00:06
*** hemna is now known as hemnafk00:06
openstackgerritA change was merged to openstack/neutron: Clean-up in the unit tests for NVP plugin  https://review.openstack.org/3856100:07
*** diogogmt has quit IRC00:08
*** xmltok_ has quit IRC00:08
*** anfrolov has joined #openstack-dev00:10
*** mberwanger has quit IRC00:12
*** alop_ has joined #openstack-dev00:12
*** alop has quit IRC00:13
*** alop_ is now known as alop00:13
*** sarob_ has joined #openstack-dev00:14
*** nati_ueno has quit IRC00:16
*** emagana has quit IRC00:16
*** sarob has quit IRC00:17
*** nati_uen_ has quit IRC00:18
*** hartsocks has quit IRC00:18
*** nati_ueno has joined #openstack-dev00:19
*** flepied has joined #openstack-dev00:21
*** colinmcnamara has quit IRC00:22
*** epim has quit IRC00:23
*** jecarey has quit IRC00:25
*** gyee has quit IRC00:27
*** rwsu is now known as rwsu-away00:27
*** markwash has quit IRC00:28
*** nati_uen_ has joined #openstack-dev00:29
*** armax has joined #openstack-dev00:29
*** armax has quit IRC00:31
*** galstrom is now known as galstrom_zzz00:35
*** kaushikc has joined #openstack-dev00:37
*** nati_uen_ has quit IRC00:40
*** bdpayne has quit IRC00:44
*** nati_ueno has quit IRC00:47
*** pabelanger has quit IRC00:47
*** kaushikc has quit IRC00:48
*** zhiyan has joined #openstack-dev00:50
*** zb has quit IRC00:50
*** zb has joined #openstack-dev00:50
*** kaushikc has joined #openstack-dev00:50
*** nati_ueno has joined #openstack-dev00:51
*** jamielennox|away is now known as jamielennox00:51
openstackgerritA change was merged to openstack/tempest: Use assertIn and assertNotIn instead of assertTrue/assertFalse  https://review.openstack.org/3901900:52
*** nati_ueno_2 has joined #openstack-dev00:52
*** dkranz has joined #openstack-dev00:53
*** zhiyan has quit IRC00:55
*** dina_belova has joined #openstack-dev00:55
*** nati_ueno_2 has quit IRC00:56
*** zbitter has joined #openstack-dev00:56
ayoungjamielennox, this is in keeping with the client cleanup, right https://review.openstack.org/#/c/38363/5/tests/test_keystoneclient.py00:58
*** dosaboy has quit IRC00:59
*** zb has quit IRC00:59
jamielennoxayoung: oh, no that would be a reaction to my changing the checkout location01:00
jamielennoxi moved the server starting to early so that it was done before the checkout of an older version01:00
*** dina_belova has quit IRC01:00
jamielennoxapparently i moved it too early and so the backends weren't in place01:00
*** schwicht has joined #openstack-dev01:00
smosermikal, around ?01:00
*** alexb_ has joined #openstack-dev01:01
jamielennoxayoung: i'm not sure if it makes that much difference because the servers will load the backends, but the ordering is still good so it should be fine01:01
ayoungjamielennox, ok.  I'll ack it01:02
jamielennoxtry running the client tests individually01:03
jamielennoxif that works, no problem01:03
*** dkranz has quit IRC01:04
*** jrclouda has joined #openstack-dev01:04
*** briancurtin has joined #openstack-dev01:04
*** jrclouda is now known as zackf01:05
*** troytoman is now known as troytoman-away01:05
*** kaushikc has quit IRC01:05
*** troytoman-away is now known as troytoman01:06
*** kaushikc has joined #openstack-dev01:07
*** kaushikc has quit IRC01:07
openstackgerritA change was merged to openstack/tempest: Add Neutron CLI tests to tempest  https://review.openstack.org/3882901:08
openstackgerritA change was merged to openstack/tempest: Unskip test_register_get_deregister_ari_image  https://review.openstack.org/3874401:08
openstackgerritA change was merged to openstack/tempest: Handle a possible volume attachment visibility wait/race issue  https://review.openstack.org/3884101:08
*** kaushikc has joined #openstack-dev01:09
*** schwicht has quit IRC01:09
openstackgerritA change was merged to openstack/tempest: Simplify whitebox/manager  https://review.openstack.org/3530201:09
openstackgerritA change was merged to openstack/tempest: Ignore the default quota values  https://review.openstack.org/3694101:09
*** dani4571 has quit IRC01:11
*** yaguang has joined #openstack-dev01:11
openstackgerritA change was merged to openstack-dev/devstack: Fix various things when n-cell is enabled  https://review.openstack.org/3889701:14
openstackgerritA change was merged to openstack-dev/devstack: Update OpenVZ driver image  https://review.openstack.org/3893601:14
openstackgerritA change was merged to openstack-dev/devstack: xenapi: Uninstall instances  https://review.openstack.org/3904201:14
*** briancurtin has quit IRC01:15
*** yaguang has quit IRC01:16
*** jayg is now known as jayg|g0n301:19
*** jbresnah has quit IRC01:21
*** jbresnah has joined #openstack-dev01:21
* ayoung is one code reviewing fool. Probably a literal fool.01:21
*** Mandell has quit IRC01:22
ayoungjamielennox, I assume you ran the coverage tool yourself for https://review.openstack.org/#/c/38414/6  ?01:24
openstackgerritA change was merged to openstack/python-keystoneclient: Reorganize url creation.  https://review.openstack.org/3601901:25
openstackgerritA change was merged to openstack/tempest: Add tenant isolation for glance api tests  https://review.openstack.org/3837101:25
jamielennoxayoung: only thing i haven't tried to test regarding it is http certs, as i'm not sure how that works yet, but all of that stuff is c&p out of the main client anyway01:25
*** nati_ueno has quit IRC01:25
jamielennoxayoung: are you implying i've missed something?01:26
ayoungjamielennox, nope.01:26
ayoungjamielennox, it looks good, was just being lazy and letting you do the work for me01:26
ayoungjamielennox, did you do a devstack run on it?\01:26
* ayoung knows it doesn't matter as it is done by gate01:26
jamielennoxayoung: no, but i did pick up an error or two out of the tempest run01:26
*** Samos123 has quit IRC01:27
ayoungcool.  that is what it is there for. devstack is used by tempest.  I need to get it set up to run on my dev box again/01:27
jamielennoxit's been a little while since i've had to fire up devstack myself01:27
*** briancurtin has joined #openstack-dev01:27
*** carl_baldwin has quit IRC01:29
*** anteaya has quit IRC01:30
*** benonsoftware has quit IRC01:30
ayoungjamielennox, on https://review.openstack.org/#/c/38763/6  shouldn't there be corresponding code removal from somewhere?01:30
jamielennoxayoung: i'm trying to break it into steps01:31
jamielennoxdo the v2 validate, figure out some way of doing v3 and then swap over the middleware01:31
jamielennoxi think they can stand alone as features01:31
ayoungjamielennox, does the middleware currently validate?01:32
openstackgerritA change was merged to openstack/oslo-incubator: Import common quota code from nova and cinder  https://review.openstack.org/3559901:32
*** kaushikc has quit IRC01:32
jamielennoxyea but it does everything directly against the APIs01:32
jamielennoxand it handles it's own certificate fetching etc01:33
* ayoung realizes that was a dumb question.01:33
jamielennoxgood01:33
ayoungjamielennox, ok so all of that stuff really should be in the common client library.01:33
jamielennoxthere will be a merge conflict between the discovery and validate patches as i renamed client.py -> httpclient.py01:34
openstackgerritA change was merged to openstack/oslo-incubator: Update references with new Mailing List location  https://review.openstack.org/3910801:34
ayoungbut the validation you are doing is additional validation, no?01:34
openstackgerritA change was merged to openstack/tempest: Allow to run swift and keystone api tests standalone  https://review.openstack.org/3900101:34
jamielennoxbut that's ok i'll fix it based on which one looks like going in first01:34
*** freedomhui has joined #openstack-dev01:34
jamielennoxat the moment i'm not doing any additional validation, i'm just providing the functionality via the client01:34
jamielennoxnothing actually uses it yet01:34
ayoungjamielennox, why does the client,abesnt the auth_token middleware need to validate the token?01:35
ayoungyeah but what are you planning?01:35
*** neelashah has joined #openstack-dev01:35
*** pixelbeat has quit IRC01:35
jamielennoxprobably it will be the only use case, but the functionality is there via the api and can be done by anyone01:35
*** CaptTofu has joined #openstack-dev01:36
jamielennoxthere is no reason for it not to be exposed via the client, maybe heat tests out a token prior to using it again,01:36
jamielennoxso what do you mean by what am i planning01:37
ayoungjamielennox, I am thinking that it should be common code, and that the auth_token middleware would be better for actually validating the contents of the token it receives, but it does it already implicitly, by pulling informatioon out of the token.  The CLI doesn't tned to need the token data, just passes it along, but there is nothing wrong with giving even that the ability to validate a token.01:37
jamielennoxwhen you say common code, where so more common than in keystoneclient?01:38
ayoungjust trying to get a few last flopping cycles out of a tired brain.  I get it.  I am wondering, though, if validate should be validate-and-parse-into-python01:38
ayoungreal domain model type things01:38
jamielennoxso validate returns the token01:39
jamielennoxbut probably not what is usefule01:39
jamielennoxi think i maybe intended it to return the access_info01:39
*** spzala has quit IRC01:40
*** yaguang has joined #openstack-dev01:40
jamielennoxbecause auth_token sets a bunch of headers given information from the token01:40
jamielennoxso it's going to need to get this information from somewhere, hmm ok, so that's a mistake - there isn't much point returning the token string again01:41
jamielennoxayoung: the longer term plan of making it use client rather than doing it itself is that it will automatically get things like kerberos integration from the client01:43
jamielennoxalso related to https://bugs.launchpad.net/python-keystoneclient/+bug/119552801:43
uvirtbotLaunchpad bug 1195528 in python-keystoneclient "Auth Token Middleware should be able to use Keystone Client" [Wishlist,Confirmed]01:43
*** SumitNaiksatam has quit IRC01:47
*** alop has quit IRC01:50
*** malini1 has quit IRC01:51
*** sarob_ has quit IRC01:51
*** kaushikc has joined #openstack-dev01:54
*** dina_belova has joined #openstack-dev01:56
*** kaushikc has quit IRC01:58
*** dina_belova has quit IRC02:01
*** svilgelm has quit IRC02:04
*** svilgelm has joined #openstack-dev02:04
*** mirrorbox has quit IRC02:05
*** mirrorbox has joined #openstack-dev02:06
*** ffio has joined #openstack-dev02:07
openstackgerritA change was merged to openstack/keystone: default token format/provider handling  https://review.openstack.org/3840402:07
*** alexpilotti has quit IRC02:08
*** radsy has quit IRC02:13
*** markmcclain has quit IRC02:15
mikalsmoser: I am now02:15
*** novas0x2a|laptop has quit IRC02:15
smosermikal, hey. i'm begging for reviews02:16
smoserhttps://review.openstack.org/#/c/37964/02:16
* mikal looks02:16
mikalIn return, you have to talk to be about one of my reviews02:16
*** dguitarbite has joined #openstack-dev02:17
mikalsmoser: I'd be interested in your thoughts (or your team's) on https://review.openstack.org/#/c/39048/02:17
smoserwell, i know that rbasak went through this and tried to come up with a fix.02:19
smoseri disagree with berrange in that "it should go in libvirt".02:19
*** SumitNaiksatam has joined #openstack-dev02:19
mikalYeah, that's the bit I'm mostly thinking of. non-free is a problem for you guys I assume.02:19
*** CaptTofu has quit IRC02:19
smoseri think if you're going to add additional code then it should go in kvm (possibly exposed through libvirt)02:19
smosernon-free ?02:19
mikalsmoser: conservator is in non-free IIRC02:20
smoserconservator? i'm missing something.02:20
*** pabelanger has joined #openstack-dev02:21
*** nati_ueno has joined #openstack-dev02:22
smoserah. i see that now.02:22
mikalsmoser: Mr Berrange proposes that either this code be in libvirt, or just use "conservator", a user space log thingie02:22
smoseri spoke with aligoouri on this once.02:22
smoserand he convinced me that kvm was the right place for it.02:22
mikalYeah, this bug is an antique02:22
smoserwhile that only fixes kvm... that is "the right place"02:22
smoseras if your kvm process dies... well, who cares about your serial console02:22
smoserwell, i guess you'd want it pesisted on disk somewhere (the ring buffer) possibly, but that could be handled too.02:23
smoserbut, yeah, this is a fun bug.02:23
mikalThat might be true (that this should go into kvm), but from a nova perspective what we have now is very broken and I'd like to fix that.02:23
*** woodspa_ has quit IRC02:23
mikalNote as well that this bug, if the fix is turned on by default, will require changes to the apparmour templates02:23
smoserwhy do you think "really" broken?02:23
mikalThis is compute node DoS attack territory02:23
smosernot really.02:23
smoserhave you tried ?02:23
smoserit would be a very slow dos02:24
mikalWe've had reports from users02:24
smoseryeah, and i've not unserstood those.02:24
mikalOf multi-gb console logs02:24
smosertry it.02:24
smoserthe bigger issue, i believe was the whole console contents were going in the rabbit queue.02:24
mikalYep, I fixed that bit a while ago02:24
smoserhonestly, try it though.02:25
*** jamielennox is now known as jamielennox|away02:25
smoseri do suspec tthat you could dos, but it would be very slow attack.02:25
stevemarayoung: ping02:25
mikalWell, there's also no way for deployers to fix the problem apart from restarting the instance02:25
smoseryeah.02:25
smoseri agree  that it is abug.02:25
smoserso i guess you ahve my thoughts.02:26
mikalIt is the highest rated nova bug at the moment too02:26
smoserhonestly, rbasak might be able to give you good feedback.02:26
mikalCause its an antique02:26
mikalYeah, true02:26
mikalI do appreciate your thoughts. Especially because you mostly agree with me. :P02:26
mikalWhat hours does rbasak work?02:26
smoserhe's england.02:26
mikalOK, cool02:27
mikalI will ping him tonight02:27
*** michchap has quit IRC02:27
mikalStill doing that review for you...02:27
mikal...and done02:27
smoseryou can/should also just ping aligouri on it.02:28
smoserhe'll give you feedback.02:28
smoserit might not be what you want, but it will be well informed and knowledgable02:28
ayoungstevemar, yep02:30
stevemaryo, got time to chat? don't wanna bug you this late02:31
*** zackf has quit IRC02:31
smosermikal, how do i DocImpack flag ?02:31
stevemarayoung: ^02:32
ayoungstevemar, about my comments?  Sure02:32
*** alexxu has joined #openstack-dev02:32
stevemarayoung: i am confused about... "but I seen no handling for preventing an oauth issued token requesting an additional token"02:33
ayoungstevemar, yep02:33
stevemarayoung: i thought the changes I made to the token class fixed that :O02:33
ayoungnot that I can see.  WHere?02:33
stevemarkeystone/auth/plugins/token.py02:33
stevemarayoung: https://review.openstack.org/#/c/29130/45/keystone/auth/plugins/token.py02:34
stevemari thought that addresses the issue, unless i'm missing something else02:34
ayoungNo, you are aright...I foolde myself into thinking it was something else.  OK, that is one down.  How aboiut the other02:34
* ayoung tired02:34
stevemarhehe02:34
stevemarno problem02:34
* ayoung shouldn't be doing code review this late, but I was behind02:35
stevemars'all good02:35
ayoungso how about revocations?  we discussed that, but I thought you were piggybacking on the trust stuff there02:35
stevemarnope, i took another look at it, and noticed that since we are impersonating; then whenever an event happens that will delete tokens, it'll also delete the oauth issued tokens (since the user id would be the same)02:36
ayounghmmmm.02:36
*** colinmcnamara has joined #openstack-dev02:37
ayoungstevemar, and if a consumer is disabled, you cover that in the oauth provider?02:37
stevemaryup02:37
*** briancurtin has quit IRC02:37
stevemarayoung: i have to take a second look at that, i think I can do it better02:38
*** lbragstad has joined #openstack-dev02:38
ayoungstevemar, close enough for me to remove the -202:38
ayoungdown to a -102:38
stevemar1 step closer, woo hoo02:38
morganfainbergstevemar: nice.02:38
ayoungstevemar, you need the project xor the domain id in the token02:39
ayoungtoken's will be useless without that information in them02:39
*** colinmcnamara has quit IRC02:39
stevemari'm going to take another look at the revocation stuff tmrw / asap.02:39
stevemarhmm, project stuff is in there02:39
stevemarhey morganfainberg :)02:40
stevemarayoung ^^02:40
ayoungstevemar, not in the api documentation02:41
*** colinmcnamara has joined #openstack-dev02:42
stevemarayoung: hmm... but I just put the oauth section? are you saying it should be in there?02:43
stevemaroh wait, i see what you mean02:43
stevemarfor the request token02:43
smosermikal, i replied there.02:45
smoserhttps://review.openstack.org/#/c/37964/02:45
smoserbasically, if you insist we can add a '_'02:45
*** asalkeld is now known as asalkeld_food02:46
mikalsmoser: DocImpact is just a line by itself in the commit message with the text "DocImpact" on it02:49
smoseri got that.02:50
mikalsmoser: the flag thing is just about being consistent with other flags02:50
mikalSorry, distracted at the moment02:50
mikalI'll take another look in a minute02:50
*** kaushikc has joined #openstack-dev02:50
smoserthe word 'vendordata' is not unlike 'metadata' which is used in flags even as a single word.02:51
smoser6 in one half a doze in the other.02:51
*** aeperezt has quit IRC02:53
*** malini has joined #openstack-dev02:53
*** ayoung has quit IRC02:56
*** dina_belova has joined #openstack-dev02:56
*** jimjiang has joined #openstack-dev02:56
*** jjmb has joined #openstack-dev02:56
*** dina_belova has quit IRC03:01
*** jjmb has quit IRC03:04
openstackgerritA change was merged to openstack/swift: Encode unicode from JSON before using it as a string.  https://review.openstack.org/3801403:04
*** fandikurnia01 has joined #openstack-dev03:05
*** utlemming has joined #openstack-dev03:05
*** mberwanger has joined #openstack-dev03:08
*** Tross has joined #openstack-dev03:09
*** HenryG has quit IRC03:10
*** utlemming has quit IRC03:12
*** utlemming has joined #openstack-dev03:13
*** ffio has quit IRC03:13
*** jamielennox|away is now known as jamielennox03:14
smosermikal, thanks. are you able to +2 that ?03:18
*** sarob has joined #openstack-dev03:18
smoserthe only diff other than rebase from vishy's reviewed version (7) and current (9) is 'DocImpact' and s/Default// in etc/nova/nova.conf.sample03:18
*** martine_ has joined #openstack-dev03:19
*** fandikurnia01 has quit IRC03:23
*** fandikurnia01 has joined #openstack-dev03:23
*** cmark has quit IRC03:24
*** hartsocks has joined #openstack-dev03:24
*** melwitt has quit IRC03:25
*** Mandell has joined #openstack-dev03:26
*** bdpayne has joined #openstack-dev03:29
*** Tross has quit IRC03:33
*** malini has quit IRC03:37
*** martine_ has quit IRC03:38
*** marun has quit IRC03:38
*** jhesketh_ has joined #openstack-dev03:39
*** fandikurnia01 has quit IRC03:42
*** fandikurnia01 has joined #openstack-dev03:43
*** jrclouda has joined #openstack-dev03:43
*** anniec has joined #openstack-dev03:45
*** mberwang_ has joined #openstack-dev03:45
*** afazekas__ has quit IRC03:48
*** mberwanger has quit IRC03:48
*** asalkeld_food has quit IRC03:49
*** jrclouda is now known as zackf03:50
*** redbeard2 has joined #openstack-dev03:50
*** andrewbogott is now known as andrewbogott_afk03:54
*** dina_belova has joined #openstack-dev03:57
*** BLZbubba has quit IRC03:58
*** vkmc has quit IRC04:00
openstackgerritA change was merged to openstack/swift: Removed unnecessary monkeypatching of __builtin__  https://review.openstack.org/3894704:02
*** dina_belova has quit IRC04:02
*** afazekas has joined #openstack-dev04:03
*** edmund has quit IRC04:03
*** asalkeld has joined #openstack-dev04:04
*** prekarat has joined #openstack-dev04:05
*** yamahata has quit IRC04:05
*** martine has joined #openstack-dev04:06
*** martine is now known as Guest9350404:06
*** benonsoftware has joined #openstack-dev04:07
mordredAlex_Gaynor: ^^ wow, really?04:08
Alex_Gaynormordred: what about it :)04:08
mordredAlex_Gaynor: just saw the tweet and the patch title, then read the patch04:09
*** prekarat has quit IRC04:09
claygmordred: I was also impressed... but at least three people seemed ok with it.04:09
mordredAlex_Gaynor: did you consider openstack.common.gettextutils?04:09
Alex_Gaynormordred: swift doesn't use any of openstack.common yet, I don't have any objection to it though (that's how it was done in nova)04:10
mordredAlex_Gaynor: I have no problem with doing the import in each file, myself04:10
mordredfor some reason, someone thought doing that was a bad idea at some point - I do not know why04:10
* Alex_Gaynor would like to have a conversation with that prson04:11
*** SumitNaiksatam has quit IRC04:11
claygyou just have to remember to import it everywhere... i remember before I got my editor doing flake8 every save it was one more nameerror to run - test - fix04:11
*** gsilvis_ has quit IRC04:12
*** SumitNaiksatam has joined #openstack-dev04:12
*** gsilvis has joined #openstack-dev04:12
claygoh, lol - except now I have '_' added to gflake8_builtins04:13
claygAlex_Gaynor: IIRC I was the one that told redbo it was stupid to have to do that in every file, so if you're looking to throw tomatoes you may as well lob 'em at me04:14
* clayg goes to look at what openstack.common.gettextutils is doing if not adding names to __builtins__04:14
Alex_Gaynorgettextutils.install() is, yeah04:14
Alex_Gaynorotherwise it's just a common location to import from04:15
claygahhhh *U*gettext :P04:15
dstufftyay for not monkeypatching04:16
*** yamahata has joined #openstack-dev04:17
*** krtaylor has joined #openstack-dev04:20
*** Apsu has quit IRC04:21
*** Apsu has joined #openstack-dev04:22
*** zaitcev has quit IRC04:22
*** prekarat has joined #openstack-dev04:23
claygAlex_Gaynor: hey BTW, if you have questions about ssbench, don't forget swifterdarrell is just right around the corner from you and *loves* to talk about benchmarking swift :D04:23
*** comay has quit IRC04:26
*** dguitarbite has quit IRC04:27
mordredAlex_Gaynor: in general - I was also going to suggest that if you were doing things right-er, it would be neat to get that paradigm into openstack.common.gettextutils04:29
*** dguitarbite has joined #openstack-dev04:29
mordredAlex_Gaynor: so that we can reduce the level of wrong running around04:29
*** comay has joined #openstack-dev04:30
*** kaushikc has quit IRC04:30
*** kaushikc has joined #openstack-dev04:31
*** openf|y has joined #openstack-dev04:31
*** kaushikc1 has joined #openstack-dev04:32
*** kaushikc has quit IRC04:32
*** jhesketh_ has quit IRC04:33
*** anniec has quit IRC04:33
*** jhesketh_ has joined #openstack-dev04:34
*** yamahata has quit IRC04:34
*** gsilvis has quit IRC04:35
*** kaushikc has joined #openstack-dev04:35
*** gsilvis has joined #openstack-dev04:35
mordrediccha_, eglynn, flaper87: https://review.openstack.org/#/c/32625/ if you get a chance04:36
*** bdpayne has quit IRC04:36
*** dguitarbite has quit IRC04:36
*** yamahata has joined #openstack-dev04:36
*** Guest93504 has quit IRC04:36
*** garyk has quit IRC04:37
*** kaushikc1 has quit IRC04:38
*** colinmcnamara has quit IRC04:40
*** vipul is now known as vipul-away04:41
*** SergeyLukjanov has joined #openstack-dev04:42
*** vipul-away is now known as vipul04:47
*** melwitt has joined #openstack-dev04:49
*** terriyu has joined #openstack-dev04:50
*** terriyu has quit IRC04:50
*** neelashah has quit IRC04:51
*** sandeepr_ltp has joined #openstack-dev04:53
*** bdpayne has joined #openstack-dev04:54
*** mrunge has joined #openstack-dev04:57
*** mrunge has joined #openstack-dev04:57
*** dina_belova has joined #openstack-dev04:57
*** Ryan_Lane1 has joined #openstack-dev05:01
*** dina_belova has quit IRC05:02
*** Ryan_Lane has quit IRC05:02
*** Ryan_Lane1 is now known as Ryan_Lane05:02
*** Ryan_Lane has joined #openstack-dev05:02
*** mberwang_ has quit IRC05:03
*** kaushikc has quit IRC05:06
*** kaushikc has joined #openstack-dev05:06
*** michchap has joined #openstack-dev05:08
*** kushal has joined #openstack-dev05:12
*** bdpayne has quit IRC05:15
*** nati_ueno has quit IRC05:16
*** shang has quit IRC05:16
*** nati_ueno has joined #openstack-dev05:18
*** enikanorov-w_ has quit IRC05:19
*** kushal has quit IRC05:19
*** obondarev has quit IRC05:19
*** enikanorov-w has joined #openstack-dev05:20
*** obondarev has joined #openstack-dev05:21
*** emagana has joined #openstack-dev05:23
*** kushal has joined #openstack-dev05:23
*** sarob has quit IRC05:23
*** cschwede has joined #openstack-dev05:23
*** sarob has joined #openstack-dev05:24
*** kaushikc1 has joined #openstack-dev05:25
*** sarob_ has joined #openstack-dev05:25
*** kaushikc has quit IRC05:25
*** afazekas is now known as afazekas__05:25
*** sarob has quit IRC05:26
*** souvik has joined #openstack-dev05:27
lifeless[A305:28
*** afazekas__ has quit IRC05:30
*** nati_ueno has quit IRC05:31
*** jhesketh_ has quit IRC05:32
*** prekarat1 has joined #openstack-dev05:34
*** sarob_ has quit IRC05:36
*** prekarat has quit IRC05:36
*** nshaikh has joined #openstack-dev05:36
*** sarob has joined #openstack-dev05:36
*** dguitarbite has joined #openstack-dev05:38
*** devananda has quit IRC05:39
*** sarob has quit IRC05:40
*** emagana has quit IRC05:42
*** bdpayne has joined #openstack-dev05:42
*** jjmb has joined #openstack-dev05:46
*** jjmb has quit IRC05:48
*** afazekas has joined #openstack-dev05:49
*** salv-orlando has joined #openstack-dev05:51
*** dguitarbite has left #openstack-dev05:53
*** alop has joined #openstack-dev05:57
*** emagana has joined #openstack-dev05:58
*** stevemar has quit IRC05:58
*** dina_belova has joined #openstack-dev05:58
*** dina_belova has quit IRC06:03
*** michchap has quit IRC06:04
*** michchap has joined #openstack-dev06:05
*** toabctl has quit IRC06:05
*** garyk has joined #openstack-dev06:05
*** martyntaylor has joined #openstack-dev06:05
*** emagana has quit IRC06:08
*** sandeepr_ltp has quit IRC06:09
*** sandeepr_ltp has joined #openstack-dev06:10
*** SergeyLukjanov has quit IRC06:10
*** troytoman is now known as troytoman-away06:11
*** schwicht has joined #openstack-dev06:11
openstackgerritA change was merged to openstack/horizon: Make row actions menu visible for the lower row  https://review.openstack.org/3361706:13
*** prekarat1 has quit IRC06:14
*** toabctl has joined #openstack-dev06:14
*** toabctl has joined #openstack-dev06:14
*** jbresnah has quit IRC06:15
*** jimjiang has quit IRC06:15
*** jimjiang has joined #openstack-dev06:17
*** prekarat has joined #openstack-dev06:24
*** shang has joined #openstack-dev06:25
*** MaxV has joined #openstack-dev06:25
*** sushils has joined #openstack-dev06:26
*** toabctl has quit IRC06:26
*** michchap has quit IRC06:28
*** bdpayne has quit IRC06:28
*** xqueralt-afk is now known as xqueralt06:29
*** toabctl has joined #openstack-dev06:29
*** devvesa has joined #openstack-dev06:32
*** MaxV has quit IRC06:35
*** otherwiseguy has quit IRC06:37
*** sushils has quit IRC06:38
*** sushils has joined #openstack-dev06:38
*** arezmerita has quit IRC06:41
*** emagana has joined #openstack-dev06:41
*** souvik has left #openstack-dev06:45
*** sarob has joined #openstack-dev06:47
*** emagana has quit IRC06:47
*** reidrac has joined #openstack-dev06:49
*** Ryan_Lane has quit IRC06:50
*** nati_ueno has joined #openstack-dev06:51
*** sarob has quit IRC06:52
*** Ryan_Lane has joined #openstack-dev06:52
openstackgerritA change was merged to openstack/cinder: Fix running of migrations tests by Jenkins gate  https://review.openstack.org/3882606:53
*** jimjiang_ has joined #openstack-dev06:54
*** alop has quit IRC06:58
*** melwitt has quit IRC06:59
*** henrynash has joined #openstack-dev07:00
*** gargya has joined #openstack-dev07:00
*** egallen has joined #openstack-dev07:01
*** gmurphy has quit IRC07:03
*** xga has joined #openstack-dev07:05
*** gmurphy has joined #openstack-dev07:08
*** sarob has joined #openstack-dev07:09
*** SergeyLukjanov has joined #openstack-dev07:10
*** nati_ueno has quit IRC07:10
*** jbresnah has joined #openstack-dev07:10
*** vartom11111 has joined #openstack-dev07:20
*** safchain has joined #openstack-dev07:29
*** egallen has quit IRC07:32
*** michchap has joined #openstack-dev07:33
*** zyluo has joined #openstack-dev07:33
*** sandeepr_ltp has quit IRC07:33
*** sandeepr_ltp has joined #openstack-dev07:35
*** jcoufal has joined #openstack-dev07:38
*** ifarkas has joined #openstack-dev07:39
*** svilgelm has quit IRC07:39
*** egallen has joined #openstack-dev07:40
*** fandikurnia01 has quit IRC07:41
*** sarob has quit IRC07:41
*** sarob has joined #openstack-dev07:42
*** jpich has joined #openstack-dev07:42
*** MaxV has joined #openstack-dev07:43
*** mkollaro has joined #openstack-dev07:43
*** nayward has joined #openstack-dev07:43
*** nayward has quit IRC07:44
*** nayward has joined #openstack-dev07:44
*** sarob has quit IRC07:46
*** ruhe has joined #openstack-dev07:48
*** sungju_ has joined #openstack-dev07:50
*** mmagr has joined #openstack-dev07:50
*** sungju_ is now known as dkwon07:50
*** emagana has joined #openstack-dev07:58
*** dina_belova has joined #openstack-dev07:59
*** psedlak has joined #openstack-dev08:01
*** melwitt has joined #openstack-dev08:01
*** zyluo has quit IRC08:02
*** jaimegil has joined #openstack-dev08:02
*** SergeyLukjanov has quit IRC08:02
*** ffio has joined #openstack-dev08:03
*** emagana has quit IRC08:03
*** dina_belova has quit IRC08:03
*** romcheg has joined #openstack-dev08:04
*** xga has quit IRC08:04
*** jjmb has joined #openstack-dev08:05
*** SergeyLukjanov has joined #openstack-dev08:05
*** xga has joined #openstack-dev08:07
*** lucasagomes has joined #openstack-dev08:11
*** dina_belova has joined #openstack-dev08:14
*** odyssey4me has joined #openstack-dev08:14
*** iartarisi has joined #openstack-dev08:16
*** shang has quit IRC08:22
*** ruhe has quit IRC08:24
*** bashok has joined #openstack-dev08:29
*** Ryan_Lane has quit IRC08:30
*** arezmerita has joined #openstack-dev08:30
*** martyntaylor has quit IRC08:32
*** jjmb has quit IRC08:33
*** Alexei_987 has joined #openstack-dev08:33
*** martyntaylor has joined #openstack-dev08:34
*** pixelbeat has joined #openstack-dev08:37
*** vartom11112 has joined #openstack-dev08:37
*** derekh has joined #openstack-dev08:38
*** vartom11111 has quit IRC08:39
*** jgallard has joined #openstack-dev08:40
*** jjmb has joined #openstack-dev08:40
*** odyssey4me has quit IRC08:40
*** jjmb has quit IRC08:40
*** vartom11113 has joined #openstack-dev08:41
*** shang has joined #openstack-dev08:42
*** vartom11114 has joined #openstack-dev08:44
*** vartom11112 has quit IRC08:44
*** vartom11113 has quit IRC08:46
*** danpb has joined #openstack-dev08:46
*** markmc has joined #openstack-dev08:46
*** vartom11115 has joined #openstack-dev08:47
*** mkerrin has joined #openstack-dev08:48
*** vartom11114 has quit IRC08:48
*** odyssey4me has joined #openstack-dev08:49
*** nayward has quit IRC08:49
*** sarob has joined #openstack-dev08:52
*** vartom11116 has joined #openstack-dev08:52
*** lucasagomes_ has joined #openstack-dev08:54
*** sergmelikyan has joined #openstack-dev08:54
*** vartom11115 has quit IRC08:55
*** lucasagomes has quit IRC08:56
*** vartom11117 has joined #openstack-dev08:56
*** koolhead17 has quit IRC08:57
*** sarob has quit IRC08:57
*** AnilV4 has joined #openstack-dev08:57
*** vartom11118 has joined #openstack-dev08:59
openstackgerritA change was merged to openstack/cinder: Allow connect by FC-only or iSCSI-only systems.  https://review.openstack.org/3806708:59
*** vartom11116 has quit IRC09:00
*** vartom11117 has quit IRC09:01
*** henrynash has quit IRC09:02
*** lucasagomes_ is now known as lucasagomes09:02
*** vartom11119 has joined #openstack-dev09:04
*** nayward has joined #openstack-dev09:05
*** giovannone has joined #openstack-dev09:05
*** odyssey4me has quit IRC09:05
*** egallen has quit IRC09:06
*** vartom111110 has joined #openstack-dev09:06
*** vartom11118 has quit IRC09:06
*** yaguang has quit IRC09:06
*** dkwon has quit IRC09:07
*** egallen has joined #openstack-dev09:07
*** fandikurnia01 has joined #openstack-dev09:07
*** jimjiang_ has joined #openstack-dev09:08
*** vartom111111 has joined #openstack-dev09:08
*** vartom11119 has quit IRC09:08
*** dina_belova has quit IRC09:08
*** nayward has quit IRC09:09
*** henrynash has joined #openstack-dev09:09
*** jimjiang has quit IRC09:10
*** vartom111110 has quit IRC09:11
*** vartom111112 has joined #openstack-dev09:13
*** alexxu has quit IRC09:13
*** vartom111113 has joined #openstack-dev09:14
*** sride has joined #openstack-dev09:15
*** yaguang has joined #openstack-dev09:15
*** vartom111111 has quit IRC09:15
*** ruhe has joined #openstack-dev09:17
*** vartom111112 has quit IRC09:17
*** NetworkStatic has quit IRC09:18
*** mrunge has quit IRC09:18
*** nshaikh has left #openstack-dev09:19
*** vartom111114 has joined #openstack-dev09:19
*** vartom111113 has quit IRC09:21
*** vartom111115 has joined #openstack-dev09:21
*** vartom111116 has joined #openstack-dev09:23
*** vartom111114 has quit IRC09:23
*** vartom111115 has quit IRC09:25
*** romcheg has left #openstack-dev09:30
*** kaushikc1 has quit IRC09:31
*** kaushikc has joined #openstack-dev09:32
*** mrunge has joined #openstack-dev09:32
*** vartom111117 has joined #openstack-dev09:32
*** vartom111116 has quit IRC09:35
*** vartom111118 has joined #openstack-dev09:36
*** jgallard has quit IRC09:37
*** jgallard has joined #openstack-dev09:37
*** dina_belova has joined #openstack-dev09:39
*** vartom111117 has quit IRC09:39
*** vartom111119 has joined #openstack-dev09:41
*** vartom111118 has quit IRC09:42
*** egallen has quit IRC09:43
*** egallen has joined #openstack-dev09:45
*** vartom1111110 has joined #openstack-dev09:45
*** sushils has quit IRC09:47
*** vartom111119 has quit IRC09:47
*** dina_belova has quit IRC09:50
*** janisg has quit IRC09:51
*** vartom1111111 has joined #openstack-dev09:51
*** sushils has joined #openstack-dev09:52
*** vartom1111110 has quit IRC09:54
*** nshaikh has joined #openstack-dev09:59
*** vartom1111112 has joined #openstack-dev10:00
*** johnthetubaguy has joined #openstack-dev10:02
*** vartom1111113 has joined #openstack-dev10:03
*** michchap has quit IRC10:04
*** vartom1111111 has quit IRC10:04
*** michchap has joined #openstack-dev10:04
*** vartom1111112 has quit IRC10:05
*** ruhe has quit IRC10:06
*** nayward has joined #openstack-dev10:13
*** vartom1111114 has joined #openstack-dev10:13
*** mkollaro has quit IRC10:15
*** dina_belova has joined #openstack-dev10:15
*** vartom1111113 has quit IRC10:16
*** vartom1111115 has joined #openstack-dev10:16
*** vartom1111114 has quit IRC10:17
*** vartom1111116 has joined #openstack-dev10:18
ekarlso-ls10:18
*** sushils has quit IRC10:20
*** pcm_ has joined #openstack-dev10:20
*** vartom1111115 has quit IRC10:20
*** pcm_ has quit IRC10:20
*** pcm_ has joined #openstack-dev10:21
*** vartom1111117 has joined #openstack-dev10:23
*** sushils has joined #openstack-dev10:23
*** nayward has quit IRC10:23
*** egallen has quit IRC10:24
*** vartom1111116 has quit IRC10:24
*** MaxV has quit IRC10:27
*** MaxV has joined #openstack-dev10:29
*** asalkeld is now known as asalkeld_afk10:29
*** nayward has joined #openstack-dev10:30
*** sthaha has quit IRC10:31
*** martine has joined #openstack-dev10:32
*** jrclouda has joined #openstack-dev10:32
*** martine is now known as Guest9555910:32
*** jjmb has joined #openstack-dev10:34
*** zackf has quit IRC10:34
*** nayward has quit IRC10:35
*** Guest95559 has quit IRC10:36
*** shang has quit IRC10:37
*** melwitt has quit IRC10:39
*** prekarat1 has joined #openstack-dev10:39
*** prekarat has quit IRC10:39
*** giovannone has quit IRC10:39
*** ruhe has joined #openstack-dev10:39
*** MaxV has quit IRC10:44
*** prekarat1 has quit IRC10:46
*** kushal has quit IRC10:48
*** janisg has joined #openstack-dev10:48
*** prekarat has joined #openstack-dev10:49
*** prekarat has quit IRC10:49
*** dina_belova has quit IRC10:49
*** prekarat has joined #openstack-dev10:49
*** henrynash has quit IRC10:50
*** MaxV has joined #openstack-dev10:50
*** fandikurnia01 has quit IRC10:52
*** topol has joined #openstack-dev10:52
*** gargya has quit IRC10:56
*** yaguang has quit IRC10:56
*** nayward has joined #openstack-dev10:57
*** prekarat has quit IRC10:59
*** jgallard has quit IRC11:02
*** sandeepr_ltp has quit IRC11:02
*** odyssey4me has joined #openstack-dev11:03
*** kushal has joined #openstack-dev11:04
*** martine_ has joined #openstack-dev11:07
*** sthaha has joined #openstack-dev11:08
*** sthaha has quit IRC11:08
*** sthaha has joined #openstack-dev11:08
*** prekarat has joined #openstack-dev11:08
*** dina_belova has joined #openstack-dev11:15
*** dosaboy has joined #openstack-dev11:17
*** ruhe has quit IRC11:17
*** zul has quit IRC11:18
*** zul has joined #openstack-dev11:18
*** prekarat has quit IRC11:22
openstackgerritA change was merged to openstack/nova: Fix 2 pep8 errors in tests  https://review.openstack.org/3917311:29
openstackgerritA change was merged to openstack/nova: Change EC2 client tokens to use system_metadata  https://review.openstack.org/3768711:29
*** slagle has joined #openstack-dev11:32
*** sumanthns has joined #openstack-dev11:35
*** egallen has joined #openstack-dev11:36
*** xga has quit IRC11:37
*** flepied has quit IRC11:38
*** xga has joined #openstack-dev11:39
*** safchain_ has joined #openstack-dev11:40
*** safchain has quit IRC11:40
*** Max__ has joined #openstack-dev11:41
*** MaxV has quit IRC11:42
*** vkmc has joined #openstack-dev11:42
*** vkmc has quit IRC11:42
*** vkmc has joined #openstack-dev11:42
*** Max__ is now known as Guest406111:42
*** vartom1111117 has quit IRC11:42
*** prekarat has joined #openstack-dev11:42
*** drewlander has joined #openstack-dev11:45
*** romcheg1 has joined #openstack-dev11:46
*** lucasagomes is now known as lucas-hungry11:48
*** alunch has quit IRC11:51
*** zul has quit IRC11:53
*** zul has joined #openstack-dev11:55
*** mrunge has quit IRC11:57
*** alexb_ has quit IRC11:57
*** ifarkas has quit IRC11:58
*** ifarkas has joined #openstack-dev11:59
*** kaushikc has quit IRC11:59
*** zbitter is now known as zaneb12:00
*** zul has quit IRC12:01
*** rfolco has joined #openstack-dev12:01
*** topol has quit IRC12:01
*** kaushikc has joined #openstack-dev12:02
*** alexb_ has joined #openstack-dev12:06
*** zul has joined #openstack-dev12:10
*** noslzzp has joined #openstack-dev12:12
*** athomas has joined #openstack-dev12:12
openstackgerritA change was merged to openstack/nova: Enabled hacking check for Python3 compatible print (H233)  https://review.openstack.org/3893012:14
*** athomas has quit IRC12:14
*** neoXsys has quit IRC12:14
*** athomas has joined #openstack-dev12:15
*** zb has joined #openstack-dev12:16
*** cppcabrera has joined #openstack-dev12:16
*** morazi has joined #openstack-dev12:16
*** cppcabrera has left #openstack-dev12:16
*** zaneb has quit IRC12:17
*** asalkeld_afk is now known as asalkeld12:19
*** devvesa has quit IRC12:21
*** zul has quit IRC12:24
*** zul has joined #openstack-dev12:24
*** souvik has joined #openstack-dev12:24
*** prekarat has quit IRC12:25
*** romcheg has joined #openstack-dev12:26
*** sandywalsh has quit IRC12:26
*** ruhe has joined #openstack-dev12:27
*** kaushikc has quit IRC12:27
*** sandeepr_ltp has joined #openstack-dev12:28
*** kaushikc has joined #openstack-dev12:30
openstackgerritA change was merged to openstack/nova: Fix HTTP response for PortNotFound during boot  https://review.openstack.org/3535612:30
openstackgerritA change was merged to openstack/nova: Use valid IP addresses values in tests  https://review.openstack.org/3580812:30
*** romcheg1 has quit IRC12:30
openstackgerritA change was merged to openstack/horizon: remove 'import *' usage (or mark is #noqa)  https://review.openstack.org/3843512:30
*** ruhe has quit IRC12:32
*** kaushikc has quit IRC12:33
*** mkollaro has joined #openstack-dev12:33
*** dina_belova has quit IRC12:34
*** redbeard2 has quit IRC12:34
*** sride has quit IRC12:34
*** ruhe has joined #openstack-dev12:39
*** sandywalsh has joined #openstack-dev12:40
*** dkranz has joined #openstack-dev12:42
*** topol has joined #openstack-dev12:44
*** xga_ has joined #openstack-dev12:44
*** xga has quit IRC12:47
*** jaimegil has quit IRC12:47
*** alunduil has quit IRC12:48
*** dina_belova has joined #openstack-dev12:49
*** alunch has joined #openstack-dev12:49
*** eharney has joined #openstack-dev12:54
openstackgerritA change was merged to openstack/ceilometer: Fixes Hbase metadata query return wrong result  https://review.openstack.org/3902512:55
*** prekarat has joined #openstack-dev12:55
*** lbragstad has quit IRC12:55
*** ruhe has quit IRC12:58
*** souvik has quit IRC12:58
*** alexpilotti has joined #openstack-dev12:59
*** edmund has joined #openstack-dev13:00
*** anteaya has joined #openstack-dev13:01
*** mkollaro has quit IRC13:01
*** ruhe has joined #openstack-dev13:02
*** lucas-hungry is now known as lucasagomes13:02
*** topol has quit IRC13:05
*** jjmb has quit IRC13:11
*** odyssey4me has quit IRC13:11
*** nshaikh has left #openstack-dev13:12
openstackgerritA change was merged to openstack/tempest: Add wait_for_volume_status in upload_to_image test  https://review.openstack.org/3917813:12
*** briancurtin has joined #openstack-dev13:13
*** sumanthns has quit IRC13:14
*** redbeard2 has joined #openstack-dev13:14
*** cmagina_ is now known as cmagina13:15
*** bashok has quit IRC13:16
*** enikanorov has quit IRC13:16
*** changbl has quit IRC13:16
*** zb is now known as zaneb13:18
*** jayg|g0n3 is now known as jayg13:19
*** alexpilotti has quit IRC13:19
*** vartom1111117 has joined #openstack-dev13:21
*** cdub_ has joined #openstack-dev13:22
*** andrewbogott_afk is now known as andrewbogott13:22
*** Tedster has quit IRC13:24
*** rharwood has joined #openstack-dev13:25
*** alexpilotti has joined #openstack-dev13:25
*** blues-man has joined #openstack-dev13:26
*** prad_ has joined #openstack-dev13:28
*** lbragstad has joined #openstack-dev13:28
*** jecarey has joined #openstack-dev13:28
*** sudorandom has joined #openstack-dev13:29
*** neelashah has joined #openstack-dev13:29
*** briancurtin has quit IRC13:29
*** mestery has quit IRC13:32
*** mestery has joined #openstack-dev13:33
*** kbringard has joined #openstack-dev13:34
*** troytoman-away is now known as troytoman13:35
*** krtaylor has quit IRC13:36
*** emagana has joined #openstack-dev13:36
*** briancurtin has joined #openstack-dev13:37
*** CaptTofu has joined #openstack-dev13:37
*** maverick89 has joined #openstack-dev13:38
*** maverick89 has left #openstack-dev13:38
*** _TheDodd_ has joined #openstack-dev13:39
*** nayward has quit IRC13:41
*** kushal has quit IRC13:43
*** stevemar has joined #openstack-dev13:44
*** zaitcev has joined #openstack-dev13:46
iccha_sure mordred13:47
*** nayward has joined #openstack-dev13:48
*** pabelanger_ has joined #openstack-dev13:49
*** martine has joined #openstack-dev13:50
*** martine is now known as Guest2629813:50
*** martine_ has quit IRC13:51
*** bknudson has joined #openstack-dev13:51
*** iccha_ has quit IRC13:51
*** michchap has quit IRC13:52
*** iccha has joined #openstack-dev13:52
mordrediccha: thanks!13:53
mordrediccha: (glance is the last one with old-style names, and it was making me a sad pony)13:53
icchamordred: i had noticed it several times. should have been more proactive about it. thanks for the patch13:54
*** markmcclain has joined #openstack-dev13:55
*** markmcclain has quit IRC13:55
mordrediccha: no worries. I'm sure you were working on, you know, actual code13:56
*** jcoufal has quit IRC13:56
*** mkollaro has joined #openstack-dev13:57
*** pabelanger_ has quit IRC13:58
*** pabelanger_ has joined #openstack-dev13:58
*** pabelanger has quit IRC13:58
*** pabelanger_ is now known as pabelanger13:58
*** pabelanger_ has joined #openstack-dev13:58
*** ndipanov has quit IRC13:59
openstackgerritA change was merged to openstack/nova: XenAPI: Refactor Fake to create pools, SRs and VIFs automatically  https://review.openstack.org/3666814:00
*** ndipanov has joined #openstack-dev14:00
*** ayoung has joined #openstack-dev14:01
*** MIDENN_ has joined #openstack-dev14:04
*** jimfehlig has joined #openstack-dev14:06
*** DuncanT- has quit IRC14:08
*** cp16net is now known as cp16net|away14:08
*** mdenny has quit IRC14:08
*** kushal has joined #openstack-dev14:08
*** DuncanT- has joined #openstack-dev14:09
*** mrodden has joined #openstack-dev14:09
*** dina_belova has quit IRC14:10
*** iartarisi has quit IRC14:18
*** krtaylor has joined #openstack-dev14:18
*** devananda has joined #openstack-dev14:18
*** jcru has joined #openstack-dev14:19
*** dkranz has quit IRC14:19
*** markmcclain has joined #openstack-dev14:20
openstackgerritA change was merged to openstack/oslo-incubator: Fix policy default_rule issue  https://review.openstack.org/3782914:21
*** otherwiseguy has joined #openstack-dev14:21
*** spzala has joined #openstack-dev14:22
*** iartarisi has joined #openstack-dev14:22
*** spzala_ has joined #openstack-dev14:24
*** spzala has quit IRC14:24
*** ruhe has quit IRC14:24
*** spzala_ is now known as spzala14:24
*** cp16net|away is now known as cp16net14:24
*** litong has joined #openstack-dev14:27
*** mlavalle has joined #openstack-dev14:30
*** jcru has quit IRC14:30
*** ruhe has joined #openstack-dev14:31
*** burt has joined #openstack-dev14:31
*** carl_baldwin has joined #openstack-dev14:33
*** datsun180b has joined #openstack-dev14:33
*** dkranz has joined #openstack-dev14:34
*** sushils has quit IRC14:36
*** alunduil has joined #openstack-dev14:37
*** changbl has joined #openstack-dev14:38
*** derekh has quit IRC14:39
*** sushils has joined #openstack-dev14:40
*** jrclouda has quit IRC14:41
*** neoXsys has joined #openstack-dev14:42
*** jgallard has joined #openstack-dev14:42
*** dhellmann_ is now known as dhellmann14:44
openstackgerritA change was merged to openstack/tempest: Add boto tests for idempotent RunInstances calls  https://review.openstack.org/3783814:47
*** jgallard has quit IRC14:49
*** jgallard has joined #openstack-dev14:49
*** johnpur has joined #openstack-dev14:52
*** boris-42 has joined #openstack-dev14:53
*** dkranz has quit IRC14:55
*** pmathews has joined #openstack-dev14:55
*** sandeepr_ltp has quit IRC14:57
*** galstrom_zzz is now known as galstrom14:57
*** boris-42 has quit IRC14:57
openstackgerritA change was merged to openstack/glance: Rename requirements files to standard names.  https://review.openstack.org/3262514:58
openstackgerritA change was merged to openstack/neutron: Update to latest oslo rootwrap  https://review.openstack.org/3910414:58
*** prekarat has left #openstack-dev14:59
*** jjmb has joined #openstack-dev15:00
*** CaptTofu has quit IRC15:00
*** dkranz has joined #openstack-dev15:01
*** boris-42 has joined #openstack-dev15:04
*** hartsocks has quit IRC15:05
*** krtaylor has quit IRC15:05
*** alexb_ has quit IRC15:06
*** johnpur has left #openstack-dev15:07
*** MaxV has joined #openstack-dev15:07
*** reidrac has quit IRC15:07
*** edmund has quit IRC15:07
*** athomas has quit IRC15:07
*** Guest4061 has quit IRC15:07
*** iartarisi has quit IRC15:07
*** colinmcnamara has joined #openstack-dev15:08
*** ffio has quit IRC15:08
*** ruhe has quit IRC15:08
*** ffio_ has joined #openstack-dev15:08
*** mugsie has quit IRC15:09
*** eharney has quit IRC15:10
*** athomas has joined #openstack-dev15:10
*** jgallard has quit IRC15:11
*** jgallard has joined #openstack-dev15:11
*** alexb_ has joined #openstack-dev15:12
*** bswartz has quit IRC15:13
*** aelkikhia has joined #openstack-dev15:15
*** doron has joined #openstack-dev15:15
*** sthaha has quit IRC15:16
*** jrclouda has joined #openstack-dev15:16
*** jrclouda is now known as zackf15:18
*** dina_belova has joined #openstack-dev15:20
*** jimjiang_ has quit IRC15:22
*** utlemming has quit IRC15:23
*** freedomhui has quit IRC15:23
*** mmagr has quit IRC15:25
*** markmcclain has quit IRC15:27
*** ruhe has joined #openstack-dev15:33
*** jmckind has joined #openstack-dev15:33
*** cdub_ has quit IRC15:34
*** dina_belova has quit IRC15:36
*** jgallard has quit IRC15:36
*** rnirmal has joined #openstack-dev15:37
*** jgallard has joined #openstack-dev15:37
*** dina_belova has joined #openstack-dev15:37
*** sandywalsh has quit IRC15:37
openstackgerritA change was merged to openstack/glance: Fix stubs setup and exception message formatting  https://review.openstack.org/3869615:38
*** markwash has joined #openstack-dev15:40
*** jcoufal has joined #openstack-dev15:40
*** cschwede has quit IRC15:40
*** hk_peter has joined #openstack-dev15:41
*** alop has joined #openstack-dev15:41
openstackgerritA change was merged to openstack/horizon: Ignore non-existing attr in APIResourceWrapper __repr__  https://review.openstack.org/3862815:41
*** sride has joined #openstack-dev15:43
*** danwent has joined #openstack-dev15:44
*** dkranz has quit IRC15:47
*** marcos_sb has joined #openstack-dev15:48
*** topol has joined #openstack-dev15:49
*** hartsocks has joined #openstack-dev15:49
*** AlanClark has joined #openstack-dev15:50
*** zb has joined #openstack-dev15:51
*** zaneb has quit IRC15:51
*** devoid has joined #openstack-dev15:52
*** marcos_sb is now known as marcos-sb15:52
*** bnemec has joined #openstack-dev15:53
*** marcos-sb has left #openstack-dev15:53
*** sandywalsh has joined #openstack-dev15:53
*** egallen has quit IRC15:53
*** pabelanger has quit IRC15:54
*** egallen has joined #openstack-dev15:55
*** pabelanger has joined #openstack-dev15:55
*** jasdeepH has joined #openstack-dev15:55
*** jjmb has quit IRC15:55
stevemarmorganfainberg: ping15:57
*** ociuhandu has joined #openstack-dev15:57
*** zb is now known as zaneb15:57
*** neelashah has quit IRC15:58
*** zoresvit has quit IRC15:58
*** marcos-sb has joined #openstack-dev15:58
*** Mandell has quit IRC15:58
*** garyk has quit IRC15:59
hk_peterhi16:00
*** dkranz has joined #openstack-dev16:00
*** zoresvit has joined #openstack-dev16:00
*** zoresvit has quit IRC16:00
openstackgerritA change was merged to openstack/nova: Set VM back to its original state if cold migration failed  https://review.openstack.org/3863516:00
*** sushils has quit IRC16:01
*** alunduil has quit IRC16:02
*** utlemming has joined #openstack-dev16:02
*** jayg is now known as jayg|g0n316:03
*** jayg|g0n3 is now known as jayg16:03
*** sandeepr_ltp has joined #openstack-dev16:04
*** sushils has joined #openstack-dev16:04
*** safchain_ has quit IRC16:06
*** mugsie has joined #openstack-dev16:06
*** sarob has joined #openstack-dev16:06
*** doron is now known as doron_afk16:07
*** jgallard has quit IRC16:08
*** mrodden has quit IRC16:08
*** matiu_ is now known as matiu16:11
*** marun has joined #openstack-dev16:12
*** hartsocks has left #openstack-dev16:12
*** bswartz has joined #openstack-dev16:13
*** hk_peter has quit IRC16:14
*** diogogmt has joined #openstack-dev16:15
*** rcleere has joined #openstack-dev16:16
*** hemna has joined #openstack-dev16:17
*** sride has quit IRC16:18
*** jmckind has quit IRC16:19
*** alunduil has joined #openstack-dev16:19
*** MaxV has quit IRC16:19
*** eharney has joined #openstack-dev16:20
*** romcheg has quit IRC16:20
openstackgerritA change was merged to openstack/nova: Update references with new Mailing List location  https://review.openstack.org/3898216:20
*** mrodden has joined #openstack-dev16:21
openstackgerritA change was merged to openstack/nova: Use RetrievePropertiesEx instead of RetrieveProperties  https://review.openstack.org/3641116:21
*** cdub_ has joined #openstack-dev16:21
*** dina_belova has quit IRC16:22
*** SergeyLukjanov has quit IRC16:23
*** markmc has quit IRC16:23
*** stevemar has quit IRC16:24
*** bdpayne has joined #openstack-dev16:25
*** cp16net is now known as cp16net|away16:26
*** xmltok has joined #openstack-dev16:28
*** eglynn has quit IRC16:28
*** kbrierly has joined #openstack-dev16:30
*** krtaylor has joined #openstack-dev16:30
*** briancurtin has quit IRC16:31
*** markmcclain has joined #openstack-dev16:32
*** arezmerita has quit IRC16:33
*** blues-man has quit IRC16:34
*** jasdeepH has joined #openstack-dev16:35
*** BobBall is now known as BobBall_Away16:35
*** esp1 has joined #openstack-dev16:35
*** eglynn has joined #openstack-dev16:36
*** sride has joined #openstack-dev16:36
*** sride has quit IRC16:36
*** cp16net|away is now known as cp16net16:37
*** xga_ has quit IRC16:38
*** ruhe has quit IRC16:40
*** CaptTofu has joined #openstack-dev16:41
*** sushils has quit IRC16:41
*** esp1 has left #openstack-dev16:43
*** xqueralt is now known as xqueralt-afk16:44
*** neelashah has joined #openstack-dev16:44
*** sushils has joined #openstack-dev16:45
*** vartom1111118 has joined #openstack-dev16:45
*** dina_belova has joined #openstack-dev16:46
*** jjmb has joined #openstack-dev16:47
*** alexb_ has quit IRC16:47
*** vartom1111117 has quit IRC16:47
*** CaptTofu has quit IRC16:51
*** jjmb1 has joined #openstack-dev16:51
*** SergeyLukjanov has joined #openstack-dev16:51
*** sandeepr_ltp has quit IRC16:52
*** emagana has quit IRC16:52
*** enikanorov has joined #openstack-dev16:53
*** spzala has quit IRC16:53
*** enikanorov has quit IRC16:53
*** enikanorov has joined #openstack-dev16:53
*** jjmb has quit IRC16:54
*** mfer has joined #openstack-dev16:55
*** datsun180b has quit IRC16:56
*** sdague has quit IRC16:56
*** ndipanov is now known as ndipanov_gone16:57
*** emagana has joined #openstack-dev16:57
*** garyk has joined #openstack-dev16:57
*** sarob_ has joined #openstack-dev16:57
*** alexpilotti has quit IRC16:58
*** jyhc has joined #openstack-dev17:00
*** sarob has quit IRC17:00
*** jyhc has quit IRC17:00
*** sarob__ has joined #openstack-dev17:00
*** sarob_ has quit IRC17:01
*** gyee has joined #openstack-dev17:02
*** briancurtin has joined #openstack-dev17:03
*** reed has joined #openstack-dev17:03
*** NetworkStatic has joined #openstack-dev17:04
*** NetworkStatic has quit IRC17:05
*** alunduil has quit IRC17:06
*** Ryan_Lane has joined #openstack-dev17:06
*** freedomhui has joined #openstack-dev17:06
*** waa_ has joined #openstack-dev17:08
*** alexb_ has joined #openstack-dev17:08
*** mrunge has joined #openstack-dev17:09
*** MaxV has joined #openstack-dev17:09
*** lucasagomes has quit IRC17:10
*** psedlak has quit IRC17:10
*** ruhe has joined #openstack-dev17:11
*** waa_ has quit IRC17:12
*** sdague has joined #openstack-dev17:13
*** danpb has quit IRC17:16
*** doron_afk has quit IRC17:18
*** aeperezt has joined #openstack-dev17:18
*** mfer has quit IRC17:19
*** SumitNaiksatam has quit IRC17:19
*** anniec has joined #openstack-dev17:21
*** ruhe has quit IRC17:23
*** epim has joined #openstack-dev17:24
*** spzala has joined #openstack-dev17:26
*** cdub_ has quit IRC17:27
*** gordc has quit IRC17:28
*** markmcclain has quit IRC17:28
*** sushils has quit IRC17:29
*** markwash_ has joined #openstack-dev17:30
*** jmckind has joined #openstack-dev17:30
*** markmcclain has joined #openstack-dev17:30
openstackgerritA change was merged to openstack/python-glanceclient: Add v1 client side owner based filtering  https://review.openstack.org/3721217:31
openstackgerritA change was merged to openstack/python-glanceclient: Allow v1 client to list all users' images  https://review.openstack.org/3723817:31
openstackgerritA change was merged to openstack/neutron: Firewall as a Service (FWaaS) APIs and DB Model  https://review.openstack.org/2900417:31
openstackgerritA change was merged to openstack/python-swiftclient: Move multi-threading code to a library.  https://review.openstack.org/3468117:31
*** sdague has quit IRC17:32
*** danwent has quit IRC17:32
*** markwash has quit IRC17:32
*** markwash_ is now known as markwash17:32
*** nati_ueno has joined #openstack-dev17:34
*** bnemec has quit IRC17:35
*** sushils has joined #openstack-dev17:36
*** danwent has joined #openstack-dev17:36
*** sdague has joined #openstack-dev17:36
*** bnemec has joined #openstack-dev17:36
*** jjmb1 has quit IRC17:40
*** martyntaylor has quit IRC17:40
openstackgerritA change was merged to openstack/python-novaclient: Add user quota client API support  https://review.openstack.org/3920017:40
*** sdague has quit IRC17:41
*** sdague has joined #openstack-dev17:42
*** nayward has quit IRC17:42
*** johnthetubaguy has quit IRC17:43
*** sarob__ has quit IRC17:43
*** sarob has joined #openstack-dev17:44
*** SumitNaiksatam has joined #openstack-dev17:44
*** vipul is now known as vipul-away17:46
*** johnpur has joined #openstack-dev17:46
*** mohits has joined #openstack-dev17:47
*** sarob has quit IRC17:48
openstackgerritA change was merged to openstack/python-novaclient: Merge v1_1's base module into main base module  https://review.openstack.org/3881417:55
*** briancurtin has quit IRC17:55
*** sushils has quit IRC17:57
*** hk_peter has joined #openstack-dev17:57
*** prekarat has joined #openstack-dev17:57
*** gordc has joined #openstack-dev17:58
*** jyhc has joined #openstack-dev17:58
*** henrynash has joined #openstack-dev17:58
*** sarob has joined #openstack-dev17:59
*** sarob has quit IRC18:01
*** sarob has joined #openstack-dev18:01
*** sushils has joined #openstack-dev18:02
*** hk_peter has joined #openstack-dev18:02
*** koolhead17 has joined #openstack-dev18:03
*** sarob has quit IRC18:04
*** sarob has joined #openstack-dev18:04
*** danwent_ has joined #openstack-dev18:07
*** danwent has quit IRC18:07
*** danwent_ is now known as danwent18:07
*** danwent has quit IRC18:08
*** jmckind has quit IRC18:10
*** martyntaylor has joined #openstack-dev18:11
*** marun has quit IRC18:12
*** aelkikhia1 has joined #openstack-dev18:13
*** aelkikhia has quit IRC18:14
openstackgerritA change was merged to openstack/ceilometer: Make middleware.py Python 2.6 compatible  https://review.openstack.org/3915518:14
*** briancurtin has joined #openstack-dev18:14
*** mohits has quit IRC18:17
*** mohits has joined #openstack-dev18:18
*** mohits has joined #openstack-dev18:18
*** aelkikhia1 has quit IRC18:18
*** sarob has quit IRC18:18
*** sarob has joined #openstack-dev18:19
openstackgerritA change was merged to openstack/swift: When iterating over a range of a file, always close it  https://review.openstack.org/3921518:19
*** doron_afk has joined #openstack-dev18:19
*** nachi_ has joined #openstack-dev18:20
*** nachi has joined #openstack-dev18:20
*** danwent has joined #openstack-dev18:21
*** NetworkStatic has joined #openstack-dev18:23
*** afazekas has quit IRC18:23
*** ociuhandu has quit IRC18:23
*** sarob has quit IRC18:23
*** stevemar has joined #openstack-dev18:24
*** stevemar has quit IRC18:24
*** mohits has quit IRC18:25
openstackgerritA change was merged to openstack/nova: Fix extension rescue follow API v3 rules  https://review.openstack.org/3784518:25
*** otherwiseguy has quit IRC18:25
*** marcos-sb has quit IRC18:26
*** electrichead has joined #openstack-dev18:26
*** doron_afk is now known as doron18:26
*** vipul-away is now known as vipul18:27
*** briancurtin has quit IRC18:28
*** atiwari has joined #openstack-dev18:28
*** Alexei_987 has quit IRC18:28
*** prekarat has quit IRC18:28
*** stevemar has joined #openstack-dev18:28
*** zb has joined #openstack-dev18:29
*** marun has joined #openstack-dev18:29
*** Guest26298 has quit IRC18:29
*** martyntaylor has quit IRC18:30
*** sarob has joined #openstack-dev18:31
*** zaneb has quit IRC18:31
*** aelkikhia has joined #openstack-dev18:31
*** melwitt has joined #openstack-dev18:33
*** bashok has joined #openstack-dev18:34
*** hk_peter has quit IRC18:34
*** briancurtin has joined #openstack-dev18:36
*** armax has joined #openstack-dev18:36
*** koolhead17 has quit IRC18:37
openstackgerritA change was merged to openstack/nova: Fix flavor v3 follow API v3 rules  https://review.openstack.org/3825318:39
*** stevemar has quit IRC18:40
*** marun has quit IRC18:42
*** marun has joined #openstack-dev18:43
*** mrunge has quit IRC18:44
*** kmartin has quit IRC18:44
*** NetworkStatic has quit IRC18:46
*** edmund has joined #openstack-dev18:47
*** jvrbanac has joined #openstack-dev18:48
*** stevemar has joined #openstack-dev18:49
*** epim has quit IRC18:51
*** gordc has quit IRC18:52
*** gordc has joined #openstack-dev18:52
*** Mandell has joined #openstack-dev18:55
*** koolhead17 has joined #openstack-dev18:56
*** koolhead17 has quit IRC18:56
*** koolhead17 has joined #openstack-dev18:56
*** ruhe has joined #openstack-dev18:58
*** markmcclain has quit IRC18:58
ayoungtopol, dolph red xed it for the api review, but that has been merged.  He just needs to drop his -2, which he will do once he is back19:01
gyeeayoung, I think fabio's change have dependency on your extension migration repo19:02
ayounggyee, does it define a new table?19:03
ayounghttps://review.openstack.org/#/c/33118/14/keystone/common/sql/migrate_repo/versions/031_add_endpoint_filtering_table.py19:03
ayounggyee, goes into its own repo19:03
*** vipul is now known as vipul-away19:03
*** vipul-away is now known as vipul19:03
ayounggyee, I have another meeting.  Back in a bit19:03
bknudsonayoung: gyee: it has a foreign key on projects and endpoints19:04
henrynashayoung, gyee: me too, back a bit later19:04
*** BStokes has quit IRC19:04
*** markmcclain has joined #openstack-dev19:04
*** andrewbogott is now known as andrewbogott_afk19:05
*** doron is now known as doron_afk19:06
*** stevemar has quit IRC19:06
gyeebknudson, yeah, that'll have to change19:06
*** rnirmal has quit IRC19:07
bknudsongyee: and this extension then needs to know when a project or endpoint is deleted19:07
bknudsonso that it can clean up.19:07
*** rnirmal has joined #openstack-dev19:07
*** otherwiseguy has joined #openstack-dev19:07
*** alop has quit IRC19:07
*** egallen has quit IRC19:08
gyeebknudson, excellent point!19:08
bknudsongyee: how does it do that?19:09
*** rnirmal has quit IRC19:09
*** rnirmal has joined #openstack-dev19:10
gyeedknudson, dunno yet, need to think this through19:10
*** alop has joined #openstack-dev19:10
luis_bnemec, do u know how do  fix this?19:10
gyeebknudson, I was thinking of a callback mechanism you had on the global engine, but that obviously won't work when running multiple instances19:11
luis_babel is now at in babel 1.0+ list() is changed to locale_identifiers()19:11
bknudsonluis_: btw - I changed that in my version of the patch in keystone19:11
*** changbl has quit IRC19:12
luis_bknudson, what did u change?19:12
luis_list to the new method19:12
luis_?19:12
openstackgerritA change was merged to openstack/swift: Set default wsgi workers to cpu_count  https://review.openstack.org/3675119:12
bknudsonluis_: just changed list() to locale_identifiers()19:12
luis_yeah the thing is i want to have the common method be the right one, whether it is list or locale_identifiers() so that the common code for all the others is managed with an update from oslo19:13
bknudsongyee: we may need Lance's new notification19:13
bknudsonluis_: that sounds like a better way to go.19:13
lbragstad?19:13
luis_the thing is i cannot change babel in requirements.txt to say <1.0 (so we use list()) because the master list of reuqirements says Babel>0.9.619:14
luis_but if I just leave it as Babe>=0.9.6, the default that comes back is no longer 0.9.6 is 1.3 for some reason now, and that doesn't have list()19:14
*** freedomhui has quit IRC19:14
*** sarob has quit IRC19:14
*** sarob has joined #openstack-dev19:15
bknudsonluis_: could look for localedata.locale_identifiers and if that's not there use localedata.list19:15
luis_bknudson, that is what i was thinking, i just didn't know how the review was going to playout19:15
luis_wanted to get some feedback b419:16
bknudsonluis_:  like list_identifiers = getattr(localedata, 'locale_identifiers', None) or  localedata.list19:16
*** zaneb has joined #openstack-dev19:16
*** novas0x2a|laptop has joined #openstack-dev19:17
luis_yeah i think that is a good way around this, i still think it's kind of a requirements problem, that the requirement in the master list is no longer valid19:17
*** zackf has quit IRC19:17
bknudsonI don't know what the usual thing to do is... they went to a new major version with backwards-incompatible change, so seems like we'd usually switch to the new version and up the req'd version.19:18
*** danwent has quit IRC19:18
*** vipul is now known as vipul-away19:18
*** jrclouda has joined #openstack-dev19:18
*** zb has quit IRC19:18
*** sarob has quit IRC19:20
*** changbl has joined #openstack-dev19:21
luis_bknudson, yeah same here, not sure what usually happens19:21
*** drewlander has quit IRC19:21
*** zaitcev has quit IRC19:22
*** epim has joined #openstack-dev19:22
bknudsonsdague: you have advice on this? the babel project is up to 1.3 now from 0.9 and has backwards-incompatible change.19:23
*** gyee has quit IRC19:24
*** danwent has joined #openstack-dev19:25
*** zb has joined #openstack-dev19:26
*** zaneb has quit IRC19:28
*** zaitcev has joined #openstack-dev19:31
sdaguebknudson: typically propose the new global requirement version, get people to weigh in, and if we are going past it then projects need to get up to date19:34
bknudsonsdague: ok, thanks19:35
openstackgerritA change was merged to openstack/swift: Eliminate can_delete_db  https://review.openstack.org/3919319:35
*** holms has joined #openstack-dev19:36
luis_sdague, thanks..19:37
luis_bknudson, so while we do that and have everybody update, i think the sensible thing is to getattr() it19:37
luis_like u proposed19:37
*** dina_bel_ has joined #openstack-dev19:37
bknudsonluis_: ok, could you try it out with new and old babel?19:38
*** jyhc has quit IRC19:38
luis_y doing that now19:38
*** markmcclain has quit IRC19:39
*** diogogmt has quit IRC19:39
*** dina_belova has quit IRC19:39
*** mfer has joined #openstack-dev19:41
*** nati_uen_ has joined #openstack-dev19:44
*** jmckind has joined #openstack-dev19:45
*** jmckind has quit IRC19:45
*** nati_uen_ has quit IRC19:46
*** pixelbeat has quit IRC19:46
*** ruhe has quit IRC19:46
*** markmcclain has joined #openstack-dev19:47
*** nati_ueno has quit IRC19:47
*** nati_ueno has joined #openstack-dev19:47
*** dina_bel_ has quit IRC19:48
*** sarob has joined #openstack-dev19:49
*** diogogmt has joined #openstack-dev19:50
*** markmcclain has quit IRC19:51
*** vipul-away is now known as vipul19:53
*** afazekas has joined #openstack-dev19:55
*** epim has quit IRC19:57
*** lorin1 has joined #openstack-dev19:57
*** spzala has quit IRC19:58
*** noslzzp has quit IRC19:58
*** nayward has joined #openstack-dev20:00
*** noslzzp has joined #openstack-dev20:01
*** gabrielhurley has joined #openstack-dev20:02
*** markmcclain has joined #openstack-dev20:02
*** anniec has quit IRC20:03
*** agorodnev has quit IRC20:04
*** agorodnev has joined #openstack-dev20:05
*** rwsu-away is now known as rwsu20:06
*** jecarey_ has joined #openstack-dev20:06
*** dklyle is now known as david-lyle20:07
*** andrewbogott_afk is now known as andrewbogott20:08
*** jasdeepH has quit IRC20:09
*** changbl has quit IRC20:09
*** jecarey has quit IRC20:10
*** carl_baldwin has quit IRC20:10
*** adjohn has joined #openstack-dev20:11
*** doron_afk is now known as doron20:12
morganfainberghenrynash / bknudson / ayoung: https://blueprints.launchpad.net/keystone/+spec/caching-layer-for-driver-calls20:12
*** carl_baldwin has joined #openstack-dev20:12
*** changbl has joined #openstack-dev20:14
*** adjohn has quit IRC20:17
*** stevemar has joined #openstack-dev20:18
*** doron is now known as doron_afk20:18
morganfainbergstevemar: ping20:18
stevemarmorganfainberg: pong20:18
morganfainbergstevemar: i'm here now, saw i missed ya earlier on20:18
morganfainbergmaybe last night?20:19
stevemarmorganfainberg: hmmm, earlier i think20:19
*** ffio_ has quit IRC20:19
stevemarmorganfainberg: about adding an index, like you mentioned in your comments20:19
morganfainbergoh yeah20:20
morganfainbergthere is a way of doing it… i uhm.. hmmm20:20
morganfainbergi know i've seen it, but making it a PK is the wrong answer.20:20
morganfainberglook at 024_add_index_to_expires.py20:21
morganfainbergin the keystone migrate_repo.20:21
stevemarmorganfainberg: 1 sec, booting up my vm and i'll take a looksy20:21
Ryan_Laneis there a strong reason for using raw for ephemeral base images?20:21
Ryan_Lanethey are eating 350G of space on each of my hosts, and it would be awesome if they didn't20:22
Ryan_Lane350G of empty space is a little ugh... :)20:23
morganfainbergstevemar: also in Nova if you look in the folsom.py migrate (133) file you can see how they define indexes.20:23
holmsmaybe there's a channel for devstack..? or any board/mailing list whatever.. at all?20:24
*** atiwari has quit IRC20:25
*** bashok has quit IRC20:25
*** diogogmt_ has joined #openstack-dev20:25
*** diogogmt has quit IRC20:26
*** diogogmt_ is now known as diogogmt20:26
stevemarmorganfainberg: so just drop in ....  idx = sql.Index('ix_token_expires', request_token_table.c.consumer_key)20:26
*** aelkikhia has quit IRC20:27
morganfainbergstevemar: i'd likely do it like Nova does it, since you're not adding an index after the table exists:  Index('ix_consumer_key', request_token_table.c.consumer_key).create(migrate_engine)20:27
morganfainbergstevemar: sql.Index(….)...20:28
morganfainbergyou could do it with the idx = … then idx.create(migrate_engine)20:28
*** gyee has joined #openstack-dev20:28
morganfainbergbut i don't really see the need for 2 lines unless pep8 or some such is in the way.20:28
morganfainberg(though someone with more say that I might disagree with that)20:29
stevemarmorganfainberg: meh, i believe ya20:30
*** apevec has joined #openstack-dev20:30
stevemarmorganfainberg: who needs people with more say? pfft20:30
*** jasdeepH has joined #openstack-dev20:30
morganfainbergstevemar: hehe.20:30
morganfainbergstevemar:  yeah! who!?!20:30
morganfainberg;)20:30
stevemartrying to find where in token/backends/sql this is actually used...20:31
*** kushal has quit IRC20:31
*** mfer has quit IRC20:31
*** schwicht has quit IRC20:31
morganfainbergthe index?  the index is handled by the SQL engine, the code itself likely doesn't care20:31
morganfainbergthe python code that is20:31
*** schwicht has joined #openstack-dev20:32
openstackgerritA change was merged to openstack/glance: add doc/source/api in gitignore  https://review.openstack.org/3813120:32
stevemarwoo hoo20:32
Ryan_Laneactually, hell, why do ephemeral disks have base images anyway?20:32
openstackgerritA change was merged to openstack/tempest: Fix neutron cli tests skip for testr  https://review.openstack.org/3934220:32
openstackgerritA change was merged to openstack/neutron: Fix ill-formed column definition in migration downgrade step.  https://review.openstack.org/3935320:32
morganfainbergstevemar: in the api-doc: <<fix me>>20:33
morganfainberg?20:33
morganfainbergis that a note for later on?20:33
*** devoid has quit IRC20:33
stevemarmorganfainberg: yeah, i couldn't think of a way to make it clear that the tokens the consumer gets will be impersonating the authorizing user20:34
morganfainbergstevemar: you… uhm… have some trailing whitespace in your latest patchset line 18020:34
morganfainberg:P20:34
stevemard'oh20:34
stevemarmorganfainberg: i am super distracted, i'm at 'jury selection' this week, so everything is a rush job20:35
morganfainbergyeah i know :P20:35
morganfainbergstevemar: omg ouch20:35
morganfainbergstevemar: sorry  to hear =/20:35
stevemarmorgainfainberg: it's incredibly boring20:35
morganfainbergstevemar: yeah i know how it goes.20:35
stevemarmorganfainberg: anywho, know of a way to say "it's going to impersonate, but that's okay!"20:36
morganfainbergstevemar: hmmmmmm.20:36
morganfainbergstevemar: An OAuth-derived token will provide a means of acting on behalf of the authorizing user.20:37
morganfainberg?20:37
*** litong has quit IRC20:37
morganfainbergstevemar: it's a tough phrase to work out.20:37
morganfainbergstevemar: might be fine as is.20:38
stevemarhehe, not quite as-is ... <<fix-me>>20:38
stevemar:)20:38
morganfainbergstevemar: right :P20:38
stevemarmorganfainberg: but I like yours20:39
stevemarmorganfainberg: agree/disagree with what I replied to ayoung?20:39
morganfainbergstevemar: feel free to use it.— sec loking at your response to ayoung20:39
*** annegentle is now known as anneisgentle20:40
stevemarmorganfainberg: i think making expires an optional param, and setting the expiry to 8 hrs after its *authorized* is probably a good idea20:40
morganfainbergstevemar: the token expiry or the other one?20:40
stevemarexpiry first20:41
stevemarroles/domain/project stuff later20:41
morganfainbergthe unauthorized token is waiting for the response form the user to authorize the delegation right?20:42
openstackgerritA change was merged to openstack/python-glanceclient: Provide glance CLI man page.  https://review.openstack.org/3387920:42
morganfainbergif so, i don't see a problem with passing a requested expiry in, but it would only apply to the authorized token.20:42
morganfainbergif that makes sense.20:42
ayoungok I'm back.  Whereare we going and why are we in this handbasket?20:42
morganfainbergayoung: welcome back.20:43
ayoungmorganfainberg, when do you want to target the cahcing layer for?20:43
ayoungH3?20:43
morganfainbergayoung: yeah H320:43
morganfainbergwhoopse, forgot to select that.20:43
morganfainbergsorry.20:43
ayoungmorganfainberg, don't think you can, but I jsut did20:44
morganfainbergayoung: i could select it, at least it didn't prevent me from editing that field :P20:44
morganfainbergi can20:44
morganfainbergcan't set it as apporved20:44
morganfainbergor priority20:44
ayoungmorganfainberg, dolph may decide to lower it in the future, but I think we can target it for now.  Considering that therei s a review out for it, it should be a safe bet for H3\20:45
stevemarmorganfainberg: new patch of the spec20:45
*** schwicht has quit IRC20:45
morganfainbergayoung: i'll also get the kwargs patch commit message updated to reflect that BP.20:46
ayoungRyan_Lane, that may be the non-sequitur of the day.20:46
ayoungmorganfainberg, please continue to rock as hard as you have been recently.   \m/  __ \m/20:47
Ryan_Laneayoung: which one? :)20:47
morganfainbergayoung: of course! it's fun! I need fun when coding.20:47
ayoungRyan_Lane, "actually, hell, why do ephemeral disks have base images anyway?"  I just saw that quote out of context20:48
Ryan_Laneahhh. heh20:48
Ryan_Lanethey are empty disks. they can be created directly as qcow2 rather than raw with a base ;)20:48
*** dina_belova has joined #openstack-dev20:48
ayoungstevemar, I'll take a look20:48
openstackgerritA change was merged to openstack/tempest: Switch to using Oslo logging  https://review.openstack.org/3887920:48
Ryan_Laneit seems silly to waste hundreds of GBs of disk space for empty disks20:48
openstackgerritA change was merged to openstack/nova: Raise exception if both port and fixed-ip are in requested networks.  https://review.openstack.org/3798920:48
Ryan_Lane(or TBs in my case)20:49
ayoungRyan_Lane,  or just  sudo mount -t tmpfs -o size=256M tmpfs /opt/stack/keystone/keystone/tests/tmp/20:49
openstackgerritA change was merged to openstack/nova: Fix race between aggregate list and delete  https://review.openstack.org/3852620:49
Ryan_Laneayoung: ah, well, this is for nova ;)20:49
Ryan_Laneand it's for ephemeral disks20:49
ayoungyeah, yeah20:49
stevemarmorganfainberg: in the downgrade, would i need to drop the index too? or would dropping the table also drop the index too?20:49
ayoungwaht, ram isn't ephemeral enough for ya?20:49
Ryan_Laneheh20:49
Ryan_Laneephemeral disks survive reboots :)20:49
morganfainbergstevemar: hm.  don't think so, since dropping the table will take care of eliminating the index.  give me a sec to 2x check on that20:50
ayoungRyan_Lane, you keep using that word.  I do not think it means what you think it means.20:50
ayoungBut, I hear ya20:50
*** apevec has left #openstack-dev20:50
Ryan_Laneblame nova for that, not me! :D20:50
stevemarmorganfainberg: i'm thinking it should...20:50
ayoungstevemar, BTW, take a look at this pseudo review:  https://review.openstack.org/#/c/39351/  that is how I want to do your Oauth migrations20:50
ayoungI'm working on the docs for the main patch and I will update shortly20:51
morganfainbergstevemar: oh yeah, make use of ayoungs new sexy migration stuffs.20:51
*** dina_belova has quit IRC20:51
stevemarayoung: looks good buddy; morganfainberg: yeah, we had a chat about it yesterday, i already tried it out :D20:52
*** crobertsrh is now known as _crobertsrh20:52
morganfainbergstevemar: yeah, a drop of the table should be sufficent.20:53
stevemarayoung: are you going to re-arrange all the migration stuff over?20:53
stevemarmorganfainberg: egg-cellent20:53
morganfainbergstevemar: doesn't OAuth provide a response on maximum authorization time(s)?20:54
morganfainbergstevemar:  I could have sworn that was in there somewhere20:54
*** danwent has quit IRC20:54
stevemarmorganfainberg: hmmm... maybe i missed that20:55
*** hemanth has joined #openstack-dev20:55
*** xqueralt-afk is now known as xqueralt20:56
morganfainbergstevemar: Google Federated has that concept.  openid.pape.max_auth_age20:56
*** danwent has joined #openstack-dev20:56
stevemarmorganfainberg, ayoung: new patch of oauthy code, hooorah!20:57
*** Guest10612 has quit IRC20:57
morganfainbergstevemar: might not be relevant in this implementation.  I would agree with ayoung that 60 days seems a bit high.  perhaps make it configurable, and allow a length of time to be requested *shrug* not really sure on this one,20:57
*** topol has quit IRC20:58
stevemarmorganfainberg: todo list is just 1) delete *only* oauth based tokens when a delete consumer or delete authorization happens, and 2) might be changing expiry stuff a bit (that's mostly easy)20:58
morganfainbergstevemar: sounds good. man20:58
*** dina_belova has joined #openstack-dev20:58
openstackgerritA change was merged to openstack/tempest: Add environmental variables to test.conf  https://review.openstack.org/3882820:58
openstackgerritA change was merged to openstack/neutron: Imported Translations from Transifex  https://review.openstack.org/3936620:58
openstackgerritA change was merged to openstack/swift: Obscure the X-Auth-Token in proxy log  https://review.openstack.org/3829420:59
openstackgerritA change was merged to openstack/swift: Add option to make probetests more brittle  https://review.openstack.org/3785420:59
*** aclark_ has joined #openstack-dev20:59
*** jvrbanac has quit IRC20:59
*** michchap has joined #openstack-dev20:59
*** danwent has quit IRC20:59
*** AlanClark has quit IRC20:59
*** rfolco has quit IRC20:59
*** hemanth_ has joined #openstack-dev20:59
morganfainbergstevemar: I'll hold off until the new migration stuffs then and if you're gonna get the todo's done.20:59
morganfainbergstevemar: but it's all looking good.21:00
*** nati_ueno_2 has joined #openstack-dev21:00
*** michchap has quit IRC21:00
stevemarmorganfainberg: cool, i'll try and get 1 and 2 done asap... for passing in an expiry, how is that done? i suppose i should look at trusts21:01
morganfainbergstevemar: yeah.21:01
*** michchap has joined #openstack-dev21:01
morganfainbergstevemar:  ayoung's link should give some info.  if you get stuck, let me know i'll help you out (though it might be early tomorrow with a response)21:01
morganfainbergstevemar: time for dayjob meeting bbib21:01
*** epim has joined #openstack-dev21:02
stevemard'oh forget to run pep8 tests21:02
stevemarcool21:02
*** dina_belova has quit IRC21:03
ayounghenrynash, https://review.openstack.org/#/c/36731/12/doc/source/developing.rst  is that about what you were looking for?21:03
*** hemanth has quit IRC21:03
*** epopt37 has quit IRC21:04
*** boris-42 has quit IRC21:05
*** xqueralt is now known as xqueralt-afk21:06
*** epopt37 has joined #openstack-dev21:07
*** mattmale1ky has quit IRC21:08
*** romcheg has joined #openstack-dev21:08
*** bnemec has quit IRC21:08
*** romcheg has left #openstack-dev21:08
*** dkranz has quit IRC21:10
*** jasond has joined #openstack-dev21:10
*** lorin1 has left #openstack-dev21:10
openstackgerritA change was merged to openstack/swift: fix(gitignore) : ignore *.egg and *.egg-info  https://review.openstack.org/3936221:10
*** bnemec has joined #openstack-dev21:10
*** rharwood has quit IRC21:11
*** johnpur has left #openstack-dev21:12
*** rharwood has joined #openstack-dev21:13
*** bnemec has quit IRC21:13
*** ilyashakhat has quit IRC21:13
*** bnemec has joined #openstack-dev21:14
*** ilyashakhat has joined #openstack-dev21:15
*** sarob_ has joined #openstack-dev21:15
*** bnemec has quit IRC21:16
*** jrclouda has quit IRC21:16
*** ruhe has joined #openstack-dev21:16
*** stevemar has quit IRC21:16
*** jayg is now known as jayg|g0n321:17
*** sarob has quit IRC21:19
*** sarob_ has quit IRC21:20
jaypipesrussellb: wondering if you'd seen https://bugs.launchpad.net/nova/+bug/1206330 yet...21:21
uvirtbotLaunchpad bug 1206330 in nova "nova list failure when quantum_url points to HTTPS endpoint" [Undecided,New]21:21
*** spzala has joined #openstack-dev21:22
*** russellb has quit IRC21:22
*** mkollaro has quit IRC21:24
*** bswartz has quit IRC21:25
*** russellb has joined #openstack-dev21:26
*** redbeard2 has quit IRC21:28
*** adjohn has joined #openstack-dev21:29
*** vipul is now known as vipul-away21:33
*** adjohn has quit IRC21:33
*** SergeyLukjanov has quit IRC21:37
*** henrynash has quit IRC21:37
*** neelashah has quit IRC21:38
*** noslzzp has quit IRC21:40
*** athomas has quit IRC21:40
*** morazi has quit IRC21:40
*** shinylasers has joined #openstack-dev21:41
*** armax has left #openstack-dev21:44
*** vipul-away is now known as vipul21:44
*** pabelanger has quit IRC21:45
*** danwent has joined #openstack-dev21:48
*** alexb_ has quit IRC21:50
*** jimfehlig has quit IRC21:51
*** nati_ueno_2 has quit IRC21:52
*** spzala has quit IRC21:53
*** pmathews has quit IRC21:54
*** gyee has quit IRC21:55
*** rharwood has quit IRC21:56
*** bnemec has joined #openstack-dev21:56
*** esheffield has quit IRC21:56
*** pmathews has joined #openstack-dev21:58
*** bnemec has quit IRC21:58
*** dina_belova has joined #openstack-dev21:59
*** bnemec has joined #openstack-dev21:59
*** jrclouda has joined #openstack-dev22:00
*** jyhc has joined #openstack-dev22:00
*** ayoung has quit IRC22:01
*** bnemec has quit IRC22:01
*** burt has quit IRC22:02
*** bnemec has joined #openstack-dev22:02
*** pcm_ has quit IRC22:03
*** kbringard has quit IRC22:03
*** dina_belova has quit IRC22:03
*** bnemec has quit IRC22:04
*** pmathews has quit IRC22:07
holmshttps://answers.launchpad.net/devstack/+question/23328422:07
holmsmaybe someone be interested...22:08
openstackgerritA change was merged to openstack/python-glanceclient: Enable client library V2 to create an image.  https://review.openstack.org/3550422:08
*** changbl has quit IRC22:08
*** alexb_ has joined #openstack-dev22:08
*** alunch has quit IRC22:08
*** jvrbanac has joined #openstack-dev22:10
*** rwsu has quit IRC22:11
*** ruhe has quit IRC22:11
*** vipul is now known as vipul-away22:11
*** vipul-away is now known as vipul22:12
*** bknudson has quit IRC22:17
*** jecarey_ has quit IRC22:17
*** _TheDodd_ has quit IRC22:18
*** lbragstad has quit IRC22:20
*** lbragstad has joined #openstack-dev22:21
*** MaxV has quit IRC22:21
*** michchap has quit IRC22:24
*** eglynn has quit IRC22:24
*** michchap has joined #openstack-dev22:24
*** eglynn has joined #openstack-dev22:25
*** sudorandom has quit IRC22:26
*** rwsu has joined #openstack-dev22:26
*** markmcclain has quit IRC22:26
*** asalkeld has quit IRC22:26
*** sushils has quit IRC22:27
*** asalkeld has joined #openstack-dev22:27
*** lbragstad has quit IRC22:27
*** jhesketh has joined #openstack-dev22:28
*** dosaboy has quit IRC22:29
*** dosaboy has joined #openstack-dev22:30
*** rnirmal has quit IRC22:32
*** obondarev has quit IRC22:32
*** eharney has quit IRC22:34
*** obondarev has joined #openstack-dev22:34
*** jrclouda has quit IRC22:35
*** sushils has joined #openstack-dev22:37
*** nayward has quit IRC22:38
*** vipul is now known as vipul-away22:39
*** jvrbanac has quit IRC22:40
*** alop_ has joined #openstack-dev22:41
*** prad_ has quit IRC22:42
*** alop has quit IRC22:42
*** alop_ is now known as alop22:42
*** vipul-away is now known as vipul22:43
*** rcleere has quit IRC22:44
*** jpich has quit IRC22:44
*** jcoufal has quit IRC22:44
*** gabrielhurley has quit IRC22:44
*** anteaya has quit IRC22:45
*** galstrom is now known as galstrom_zzz22:46
*** EmilienM has quit IRC22:47
*** EmilienM has joined #openstack-dev22:52
*** TREllis has quit IRC22:53
*** lbragstad has joined #openstack-dev22:57
*** otherwiseguy has quit IRC22:57
*** krtaylor has quit IRC22:57
*** dina_belova has joined #openstack-dev22:59
*** gyee has joined #openstack-dev22:59
*** danwent has quit IRC23:00
*** sushils has quit IRC23:00
*** vipul is now known as vipul-away23:01
*** sushils has joined #openstack-dev23:02
*** mlavalle has quit IRC23:02
*** dina_belova has quit IRC23:03
openstackgerritA change was merged to openstack/tempest: Add locking to test_aggregates  https://review.openstack.org/3885723:04
openstackgerritA change was merged to openstack/keystone: sql.Driver:authenticate() signatures should match  https://review.openstack.org/3759423:04
openstackgerritA change was merged to openstack/nova: Fix timing issue in SimpleTenantUsageSample test  https://review.openstack.org/3929923:04
openstackgerritA change was merged to openstack/neutron: Add default route to dhcp agent netns.  https://review.openstack.org/3761923:04
*** emagana has quit IRC23:05
*** aclark_ has quit IRC23:08
openstackgerritA change was merged to openstack/nova: Logging virtual size of the QCOW2  https://review.openstack.org/3924123:08
*** gyee has quit IRC23:10
openstackgerritA change was merged to openstack/swift: Merge object base module into diskfile.  https://review.openstack.org/3914223:11
openstackgerritA change was merged to openstack/glance: Include pipeline option for using identity headers  https://review.openstack.org/3830223:11
openstackgerritA change was merged to openstack/neutron: Separate NVP create lport operation and neutron db transaction  https://review.openstack.org/3657023:11
*** kbrierly has quit IRC23:12
*** nati_ueno_2 has joined #openstack-dev23:12
*** vartom1111119 has joined #openstack-dev23:13
*** sandywalsh has quit IRC23:14
*** gyee has joined #openstack-dev23:16
*** sushils has quit IRC23:16
*** vartom1111118 has quit IRC23:16
*** vartom11111110 has joined #openstack-dev23:18
*** salv-orlando has quit IRC23:19
*** sushils has joined #openstack-dev23:19
*** Mandell has quit IRC23:19
morganfainbergjamielennox: ping23:20
*** andrewbogott is now known as andrewbogott_afk23:20
*** vartom11111111 has joined #openstack-dev23:20
*** alexpilotti has joined #openstack-dev23:20
*** vartom1111119 has quit IRC23:20
*** Mandell has joined #openstack-dev23:20
*** Mandell has quit IRC23:21
*** gyee has quit IRC23:22
*** gyee_ has joined #openstack-dev23:22
*** vartom11111110 has quit IRC23:23
*** reed has quit IRC23:23
*** reed has joined #openstack-dev23:24
*** vartom11111112 has joined #openstack-dev23:24
*** sean_s has joined #openstack-dev23:26
jamielennoxmorganfainberg: good morning23:26
*** mrodden has quit IRC23:27
*** briancurtin has quit IRC23:27
*** vartom11111111 has quit IRC23:27
morganfainbergjamielennox: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L896  should that raise an invalid token?  It seems odd to just silently return None (default behavior) if it's expired23:27
*** lexinator has joined #openstack-dev23:28
morganfainbergjamielennox: i mean… i just don't know which is why i was asking (looking at some code reviews and wasn't sure about that one… just stood out)23:28
morganfainbergjamielennox: also good morning…23:28
morganfainberg:)23:28
jamielennoxmorganfainberg: i'm not sure, L881, there is a precedent for returning None23:29
jamielennoxthough it probably shouldn't be silent23:29
morganfainbergjamielennox: yeah.  maybe it should be an explicit return None in that case.  again, just stood out as an oddity23:30
jamielennoxso it looks like a return of none is an indication that the token wasn't found in the cache23:30
morganfainbergjamielennox: i guess expired is roughly equiv to not in cache23:31
*** NetworkStatic has joined #openstack-dev23:31
morganfainbergwell, functionally speaking that is.23:31
jamielennoxright, but if a user is presenting a token that we have cached and know to be expired that should be an error23:31
*** carl_baldwin has quit IRC23:31
morganfainberghrm.23:31
jamielennoxI guess as it is currently if you present an expired token it falls through the cache23:32
*** MaxV has joined #openstack-dev23:32
jamielennoxgets decrypted and then the expired is picked up and rejected later on23:32
*** vartom11111113 has joined #openstack-dev23:32
morganfainbergjamielennox: yeah.23:32
*** markwash has quit IRC23:32
*** nati_ueno_2 has quit IRC23:33
jamielennoxmorganfainberg: i'm not sure who wrote the memcahce stuff23:33
*** vartom11111114 has joined #openstack-dev23:33
*** bill has joined #openstack-dev23:34
*** bill is now known as Guest9414523:34
jamielennoxmorganfainberg: blame says bdpayne https://github.com/openstack/python-keystoneclient/commit/eeefb784f24c37d5f56a421e1ccc911cace9385e23:35
morganfainbergjamielennox: since this is purely a cache, not an authoritative "token" system, falling through if the cache is claiming expired seems "correcT".  "pass a token, if it is expired in cache, make sure it's really expired"?23:35
morganfainbergvs. raise error because cache said "OMG EXPIRED" in theory, it shouldn't be in the cache if it's expired.23:35
*** vartom11111112 has quit IRC23:35
bdpaynehi23:35
bdpaynewhat did I do? :-)23:35
morganfainbergsince the TTL is set earlier23:35
morganfainbergbdpayne: keystoneclient memcache stuff23:35
jamielennoxbut the point of the cache would be to prevent having to re-decrypt the pki token23:35
*** vipul-away is now known as vipul23:35
*** diogogmt_ has joined #openstack-dev23:36
jamielennoxand you can't change it once it has been created so the only reason to recheck would be a hash collision - which has larger implications23:36
*** diogogmt has quit IRC23:36
*** diogogmt_ is now known as diogogmt23:36
morganfainbergjamielennox: right, but again, L922, you shouldn't be in the cache if it's expired23:36
*** vartom11111115 has joined #openstack-dev23:36
*** vartom11111113 has quit IRC23:36
*** PaulM has joined #openstack-dev23:36
morganfainbergerm 92423:36
*** MaxV has quit IRC23:37
*** colinmcnamara1 has joined #openstack-dev23:37
morganfainbergoh.23:37
bdpaynehey guys, I helped with some of this, but PaulM did most of the work23:37
morganfainbergnvm.23:37
bdpaynehe'll be stopping by shortly to help answer questions23:37
morganfainbergjamielennox: 5m cache23:37
PaulMwhat's up?23:37
jamielennoxbdpayne: ok, we'll have a look for him, we're just wondering why if memcache shows an expired token that it would just ignore it rather than say this is bad23:37
morganfainbergbdpayne: sure, it was just a question on if an expired token should be raising an exception or fall through (auth_token.py) cache23:38
*** colinmcnamara has quit IRC23:38
*** vartom11111114 has quit IRC23:38
*** bswartz has joined #openstack-dev23:38
PaulMThe reasoning behind that was that there are a non-zero number of non-malicious ways to get into that state, and so raising a scary error seemed less robust than simply treating it as expired23:39
PaulM(at least, that's what I think I was thinking)23:39
morganfainbergPaulM: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L896 if it's expired, we fall through the cache vs. raise an exception23:39
*** mrodden has joined #openstack-dev23:39
morganfainbergit wasn't clear if that was intended23:39
PaulMmorganfainberg: I haven't looked at the code in a while... why would we raise an exception there?23:40
*** sean_s has quit IRC23:40
morganfainbergPaulM: it's an implicit return of None, it just stood out as odd and i was unsure if that was the expected/intended result23:40
PaulMooh right23:41
*** dims has quit IRC23:41
PaulMwe could explicitly return none I suppose. You can see what we do with it elsewhere: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L69623:41
morganfainbergPaulM: I tend to err on the side of explicit returns so there isn't a question of the intent.23:41
jamielennoxthe comments do say: return token only if fresh (not expired) so i'm assuming it was intentional23:41
PaulMyeah, lemme find the other comment23:41
morganfainbergjamielennox / PaulM: yeah, not a big deal, just making sure we didn't miss something :)23:42
*** alunduil has joined #openstack-dev23:42
jamielennoxmorganfainberg: yea, it won't lead to incorrect behaviour, just more processing of something that we might be able to exit from early23:42
morganfainbergmy guess is for clarity we should probably do some explicit returns..but eh, you know how it goes… it's a small thing (but sometimes small things are bad)23:42
PaulMjamielennox: I'm not clear on what you mean by that23:43
morganfainbergjamielennox: the default cache is 5m, so at the very least, i don't think it's that impactful.23:43
morganfainbergPaulM: not having to decrypt the PKI token again.  if you fall through the cache, you have more work to do23:43
PaulMoh gotcha23:44
jamielennoxPaulM: so in the PKI and possible the UUID case it would just mean we need to decrypt it and check the contents of the token again rather than rely on previous results23:44
PaulM<shrug> yeah - when I was last touching that stuff, I was mostly trying to hew as closely as possible to the existing code so that I didn't introduce non-security-fix bugs23:44
PaulMsince that file is already unhappily complex23:45
morganfainbergPaulM: I will give you that.  complex file is complex23:45
jamielennoxi think that's a fairly common thing. A whole lot of my fixes as well are trying to adhere to the current behaviour rather than just changing it to something that makes more sense23:45
*** gyee_ has quit IRC23:45
*** sean_s has joined #openstack-dev23:46
PaulMsadly a bunch of those on top of each other tend to lead to an incomprehensible morass23:46
*** sandywalsh has joined #openstack-dev23:46
morganfainbergjamielennox: i think it's safe (and not a lot of overhead) to leave it as is.  maybe something to concider on the next pass (at least tossing an explicit return None in there for clarity)23:46
PaulMI'd say an explicit return None would be good, and maybe a comment to the effect of "None means a cache miss"23:46
PaulMmake it clearer for the next reader23:46
jamielennoxyea, i would leave it as is for now, i've got a number of things coming to clean up that file - i wasn't looking to mess with the cache though23:47
morganfainbergjamielennox: ok, sounds good.23:47
*** jasdeepH has quit IRC23:47
morganfainbergjamielennox: there are actually some concerns about race conditions with memcache the way it's being used there23:48
morganfainbergjamielennox: or. hm.23:48
morganfainbergno. nvm23:48
morganfainbergi'm wrong23:48
jamielennoxi don't have much experience with memcache, just basic how it works23:48
morganfainbergjamielennox: i did some refactor of the token provider, if we need to revisit that i can help.23:48
*** vartom11111116 has joined #openstack-dev23:49
morganfainbergjamielennox: but memcache is a strange beast.23:49
morganfainbergrevisit that = the memcache stuff in auth_token.py23:49
morganfainbergbut it looks fairly sane atm.23:49
jamielennoxof the token provider? where do you mean?23:49
*** dhellmann is now known as dhellmann_23:50
*** sudorandom has joined #openstack-dev23:50
jamielennoxPaulM: bdpayne thanks for your help23:50
PaulMnp23:50
bdpayne:-)23:50
morganfainbergjamielennox: erm crap, not token provider, token driver :P23:50
morganfainbergjamielennox: in keystone (not the client)23:50
jamielennoxo ok23:50
morganfainbergjamielennox: so if we want to revisit the caching stuff in keystoneclient, i can help.23:50
morganfainbergjamielennox: but it looks sane23:50
*** vartom11111115 has quit IRC23:51
morganfainbergand probably doesn't need much in reality (if anything)23:51
*** lbragstad_ has joined #openstack-dev23:51
jamielennoxok, that's fine then. I'm trying to extract all the validation logic at the moment, but i will try not to touch that if you feel the need23:51
morganfainbergjamielennox: nah, touch it all ya want, just let me know if you need help w/ it.23:52
jamielennoxok, will do23:52
*** vartom11111117 has joined #openstack-dev23:58
*** armax has joined #openstack-dev23:59
*** dina_belova has joined #openstack-dev23:59
« Monday, 2013-07-29 Index Wednesday, 2013-07-31 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!