ayoung | topol, one thing you could do is just create a role, and then change the config file to use the new role id | 00:00 |
---|---|---|
*** mlavalle has left #openstack-dev | 00:01 | |
henrynash | gyee: changes looking good… | 00:01 |
topol | ayoung, agreed. but not a long term solution :-). definitely would like the migrate function | 00:01 |
topol | ayoung, the config file does not get cached in memory? | 00:02 |
*** locke105 has joined #openstack-dev | 00:02 | |
ayoung | topol, yes, you would need to restart the keystone server....bummer | 00:02 |
*** boden has joined #openstack-dev | 00:02 | |
topol | ayoung, ldapadd it is. thanks | 00:03 |
*** mrodden has joined #openstack-dev | 00:03 | |
*** nsatterl_ has quit IRC | 00:03 | |
*** donaldh has quit IRC | 00:03 | |
henrynash | topol: I'm getting a failure load ldap module in my run_tests….have we change that recently? | 00:04 |
ayoung | topol, for LDAP, I think it is probably better to err on the side of making the admins do it and be involved. We don't automatethe LDAP deployment (except in devstack, thanks to you) | 00:04 |
*** alunduil has joined #openstack-dev | 00:04 | |
ayoung | OK, dinner time | 00:04 |
*** ayoung is now known as ayoung_omnomnom | 00:04 | |
topol | henrynash, I havent changed any code in keystone, just devstack making changes to keystone.conf | 00:05 |
topol | henrynash, so it cant even find the the module or the module as errors? | 00:06 |
henrynash | topol: yes, the "import ldap" fails…I didn't think we required that…I thought we could use the fake | 00:07 |
*** nsatterl_ has joined #openstack-dev | 00:08 | |
*** danwent_ has joined #openstack-dev | 00:08 | |
*** danwent has quit IRC | 00:08 | |
*** danwent_ is now known as danwent | 00:08 | |
*** markvoelker has quit IRC | 00:08 | |
topol | henrynash, I havent touched either of those. But other folks have. Do you know what error its getting? | 00:09 |
*** pabelanger has joined #openstack-dev | 00:09 | |
henrynash | topol: invetigating.... | 00:09 |
*** alexpilotti has joined #openstack-dev | 00:12 | |
gyee | henrynash, added my comments https://review.openstack.org/#/c/22223 | 00:13 |
henrynash | gyee: thx | 00:13 |
*** edmund has quit IRC | 00:13 | |
openstackgerrit | A change was merged to openstack/nova: Make nova security groups more pluggable https://review.openstack.org/22061 | 00:14 |
*** hemna is now known as hemnafk | 00:15 | |
*** danwent has quit IRC | 00:16 | |
openstackgerrit | A change was merged to openstack/nova: Add Nova quantum security group proxy https://review.openstack.org/22062 | 00:17 |
*** yamahata has quit IRC | 00:17 | |
*** vipul is now known as vipul|away | 00:19 | |
*** vipul|away is now known as vipul | 00:20 | |
*** dolphm has joined #openstack-dev | 00:20 | |
*** winston-d_ has joined #openstack-dev | 00:22 | |
henrynash | gyee: new patch that fixes them | 00:22 |
*** devoid has quit IRC | 00:23 | |
*** nsatterl_ has quit IRC | 00:24 | |
*** nsatterl_ has joined #openstack-dev | 00:24 | |
*** dwalleck has quit IRC | 00:26 | |
*** Qten has quit IRC | 00:26 | |
openstackgerrit | A change was merged to openstack/nova: Wait for baremetal deploy inside driver.spawn https://review.openstack.org/21564 | 00:29 |
openstackgerrit | A change was merged to openstack/nova: Better error handling in baremetal spawn & destroy https://review.openstack.org/21590 | 00:30 |
openstackgerrit | A change was merged to openstack/nova: Improve performance of baremetal list_instances. https://review.openstack.org/21589 | 00:30 |
*** alexpilotti has quit IRC | 00:30 | |
openstackgerrit | A change was merged to openstack/nova: Identify baremetal nodes by UUID. https://review.openstack.org/21939 | 00:30 |
openstackgerrit | A change was merged to openstack/nova: Baremetal driver returns accurate list of instance https://review.openstack.org/21605 | 00:32 |
openstackgerrit | A change was merged to openstack/nova: Remove race condition (in Networks) https://review.openstack.org/22155 | 00:32 |
openstackgerrit | A change was merged to openstack/nova: Removed duplicate spawn code in PowerVM driver https://review.openstack.org/22243 | 00:32 |
openstackgerrit | A change was merged to openstack/nova: libvirt: fix volume walk of /dev/disk/by-path https://review.openstack.org/22461 | 00:33 |
openstackgerrit | A change was merged to openstack/nova: ensure we run db tests in CI https://review.openstack.org/22420 | 00:33 |
openstackgerrit | A change was merged to openstack/nova: More gracefully handle TimeoutException in test https://review.openstack.org/22416 | 00:33 |
*** obondarev has quit IRC | 00:33 | |
openstackgerrit | A change was merged to openstack/nova: Fix pep8 issues with test_manager.py https://review.openstack.org/22398 | 00:33 |
openstackgerrit | A change was merged to openstack/oslo-incubator: Revert "Fast serialization of RPC envelopes for Kombu" https://review.openstack.org/22488 | 00:34 |
openstackgerrit | A change was merged to openstack/oslo-incubator: Don't s/oslo/base/ for files in the rpc lib. https://review.openstack.org/22487 | 00:34 |
clarkb | jeblair: vishy ^ \o/ | 00:35 |
*** obondarev has joined #openstack-dev | 00:36 | |
*** stevebaker has quit IRC | 00:36 | |
gyee | henrynash, approved it | 00:36 |
henrynash | gyee: thx | 00:36 |
*** jergerber has joined #openstack-dev | 00:36 | |
gyee | dolphm, henrynash, you guys want to apply the domin-scope patch? http://paste.openstack.org/show/32136/ | 00:38 |
gyee | not sure we have a bug open for this | 00:38 |
*** stevebaker has joined #openstack-dev | 00:38 | |
*** ctracey has quit IRC | 00:39 | |
gyee | bbl | 00:39 |
*** gyee has quit IRC | 00:39 | |
*** ctracey has joined #openstack-dev | 00:39 | |
henrynash | gyee: dolphm has a couple more comments on my patch…maybe not full approval yet | 00:40 |
*** salv-orlando has quit IRC | 00:43 | |
*** alexxu has joined #openstack-dev | 00:43 | |
*** monst_ has joined #openstack-dev | 00:44 | |
*** yuanz has quit IRC | 00:45 | |
*** njoy1__ has joined #openstack-dev | 00:45 | |
*** ctracey has quit IRC | 00:45 | |
*** annegentle has joined #openstack-dev | 00:45 | |
*** ctracey has joined #openstack-dev | 00:45 | |
*** ctracey has quit IRC | 00:46 | |
*** obondarev has quit IRC | 00:47 | |
*** hugo_kuo has joined #openstack-dev | 00:48 | |
*** ctracey has joined #openstack-dev | 00:48 | |
*** monst_ has quit IRC | 00:48 | |
*** esp1 has quit IRC | 00:48 | |
*** njoy_ has quit IRC | 00:49 | |
*** obondarev has joined #openstack-dev | 00:49 | |
*** alszar has quit IRC | 00:49 | |
topol | gyee, do you still need a +1 on pluggable authentication? | 00:50 |
*** esp has joined #openstack-dev | 00:50 | |
*** hugokuo has quit IRC | 00:51 | |
topol | dolphm, I was able to manually add into ldap _member_ with id of 9fe2ff9ee4384b1894a90878d3e92bab and with that in place I could successfully add a user to a specific tenant. | 00:52 |
topol | dolphm, _member_ being the magic role | 00:53 |
*** esp has quit IRC | 00:54 | |
*** soody has quit IRC | 00:54 | |
*** nsatterl__ has joined #openstack-dev | 00:55 | |
*** nsatterl_ has quit IRC | 00:55 | |
*** soody has joined #openstack-dev | 00:56 | |
*** dolphm has quit IRC | 00:57 | |
*** dolphm has joined #openstack-dev | 00:57 | |
*** njoy1__ has quit IRC | 00:57 | |
*** njoy_ has joined #openstack-dev | 00:57 | |
*** dolphm has quit IRC | 00:59 | |
openstackgerrit | A change was merged to openstack/oslo-incubator: Revert "Implement replay detection." https://review.openstack.org/22495 | 00:59 |
*** rpedde is now known as rpedde_away | 01:00 | |
*** sacharya has joined #openstack-dev | 01:02 | |
*** networkstatic has joined #openstack-dev | 01:03 | |
*** ayoung_omnomnom is now known as ayoung | 01:04 | |
ayoung | topol, I wouldn't do straight LDAP. I would use the internal API. Something like PYTHON_PATH=/opt/stack/keystone and then from keystone import identity | 01:05 |
*** colinmcnamara has quit IRC | 01:06 | |
*** bing_bu has joined #openstack-dev | 01:06 | |
jeblair | clarkb: ! | 01:07 |
henrynash | dolphm, gyee: new version of query filter patch that removes one of the two extra bits of in line code that Dolph spotted - if you'd both care to push the buttons again | 01:07 |
*** darjeeling has quit IRC | 01:07 | |
henrynash | https://review.openstack.org/#/c/22223/ | 01:07 |
*** soody has quit IRC | 01:07 | |
*** amerine has quit IRC | 01:09 | |
*** boden has quit IRC | 01:09 | |
*** amerine has joined #openstack-dev | 01:09 | |
topol | ayoung, I just wanted to test to see if anything else breaks when I added the magic role. It seemed OK. But what I am worried about is do we no longer have a model where you could wire up a real ldap and use it in read only mode. Wont this new role require that LDAP get updated with the new value? We have several folks who are comfortable with trying to wire it up to a read only ldap but... | 01:10 |
topol | ...will not be happy (i.e. they will have a fit!) if ldap must be updated to work. Will YorikSar's patch be like the enabled emulation where the ldap is not affected? | 01:10 |
ayoung | topol, roles to projects require role assignments. While you can have openstack without role assignements, many of the APIds don't work any way | 01:10 |
ayoung | so, while there might be other ways to represent role assignments, I am not sure how to map that to what we are doing any way | 01:11 |
ayoung | but I guess you could do it with groups somehow. | 01:12 |
topol | ayoung, we had folks wiring it up to an enterprise ldap that already had built in roles | 01:12 |
ayoung | topol, so you can use a preexisting role | 01:12 |
ayoung | it doesn't have to be the default one. | 01:12 |
topol | ayoung, I think that helps, how would that work? | 01:13 |
ayoung | say you have a Member role already, with a different Role Id, you set those two config values...they are | 01:13 |
ayoung | member_role_id and member_role_name | 01:14 |
ayoung | but for a read only database, you wouldn't be able to add roles to users anyway, so they would not make much of a difference. Understand that if you have any role in a project now, you are "in" that project | 01:15 |
ayoung | topol, the default role is just one to help transition the api for add_user_to_project. But if you had the foogley role in the project, that would work too, | 01:16 |
ayoung | Kapish? | 01:16 |
topol | ayoung, good point. so i could have a read only database and if I dont add anyone I dont need to worry correct? | 01:16 |
*** danwent has joined #openstack-dev | 01:16 | |
ayoung | topol, so long as you have a role abstraction you are good to go | 01:16 |
*** adalbas has quit IRC | 01:16 | |
topol | ayoung, K that helps. Now for devstack if YorikSar puts his fix in I dont have to do anything in devstack, correct? | 01:17 |
*** nsatterl__ has quit IRC | 01:17 | |
henrynash | gyee: have applied you patch and it passed the various tests | 01:17 |
openstackgerrit | A change was merged to openstack/nova: Move some context checking code from sqlalchemy https://review.openstack.org/22266 | 01:18 |
openstackgerrit | A change was merged to openstack/cinder: Moved cinder_emc_config.xml.sample to emc folder https://review.openstack.org/22460 | 01:19 |
openstackgerrit | A change was merged to openstack/cinder: Uses tempdir module to create/delete xml file https://review.openstack.org/22457 | 01:19 |
*** markmcclain has quit IRC | 01:21 | |
*** gongysh has joined #openstack-dev | 01:21 | |
*** amerine has quit IRC | 01:22 | |
topol | ayoung, another question is does this new role mapping flatten things out? if so folks will really like that | 01:22 |
*** gongysh has quit IRC | 01:23 | |
topol | ayoung, I got complaints regarding the roles being nested under tenants. Your new approach fixes that correct? | 01:24 |
ayoung | topol, probably want to inject that role when building the LDAP server. | 01:24 |
ayoung | topol, nope | 01:24 |
ayoung | topol, the issue is that tenants were | 01:24 |
ayoung | groupOfNames | 01:24 |
ayoung | and now there is no reason to maintain that | 01:24 |
ayoung | role assignments will be occupationalRoles still, and nested under project | 01:25 |
ayoung | but the project should probably become ou by default. | 01:25 |
ayoung | and that should be cleaner for everyone | 01:25 |
ayoung | henrynash, so I think I am going to need your filter as well, especially I am going to change the list behavior to what you suggest | 01:26 |
ayoung | GET /trusts?trustor_user_id={user_id) | 01:27 |
ayoung | will have different policy than | 01:27 |
ayoung | GET /trusts | 01:27 |
*** markvoelker has joined #openstack-dev | 01:27 | |
henrynash | ayoung: yes, that should work nicely I think | 01:27 |
ayoung | henrynash, so no filter is admin only | 01:27 |
ayoung | with filter is two different policies, one for trustor= and one for trustee= | 01:28 |
henrynash | ayoung: hmm, no filter in is admin…..true…but hope that is going away! | 01:28 |
topol | ayoung, here is what it looks like after running devstack and then also adding a user to a tenant: http://fpaste.org/bNJf/ | 01:29 |
ayoung | ugh, the role names should be thedns, not the role ids. But I guess there is no help for that | 01:30 |
ayoung | still nice work | 01:30 |
henrynash | ayoung: that filter change is on its way in…was approved, but then dolph suggested a minor nit cleanup… could you help send it on its way…? https://review.openstack.org/#/c/22223/ | 01:31 |
*** anniec has joined #openstack-dev | 01:32 | |
*** alunduil has quit IRC | 01:34 | |
*** diogogmt has quit IRC | 01:36 | |
*** pabelanger has quit IRC | 01:36 | |
*** bencherian has quit IRC | 01:36 | |
*** markvoelker1 has joined #openstack-dev | 01:36 | |
*** alunduil has joined #openstack-dev | 01:36 | |
*** roampune has quit IRC | 01:38 | |
topol | ayoung so how it looks now is that there are roles under projects and then each role has the users who have that role are stored as role occupant attributes. Is that how it should still look going fwd? | 01:39 |
henrynash | guang: you need any more help on domain scoping? | 01:40 |
*** markvoelker has quit IRC | 01:40 | |
ayoung | topol, yes | 01:40 |
ayoung | topol, technically it is roleAssignements under the project | 01:40 |
ayoung | theroles themselves are in a list in a node parallel with user and project | 01:41 |
topol | ayoung, YAY. I've earned dinner | 01:41 |
*** AlanClark__ has quit IRC | 01:42 | |
*** AlanClark__ has joined #openstack-dev | 01:43 | |
henrynash | dolphm, ayoung, guang: when you get a moment, could at least one of you re-apply approval to: https://review.openstack.org/#/c/22223/ following a suggested nit change | 01:43 |
*** sulrich has quit IRC | 01:44 | |
*** soody has joined #openstack-dev | 01:44 | |
ayoung | henrynash, I like that pattern. None and null pointers are usually best replaced with potentially empty lists/colections | 01:44 |
*** esp1 has joined #openstack-dev | 01:45 | |
henrynash | ayoung: :-) | 01:45 |
ayoung | henrynash, I approved. | 01:45 |
henrynash | ayoung: thx | 01:45 |
*** AlanClark__ has quit IRC | 01:46 | |
ayoung | henrynash, so the api doc is going to change to reflect your/dolph's suggestion on the list thing. Which means I might be stealing your filterpatch. | 01:46 |
ayoung | henrynash, are you going to rework it? | 01:46 |
henrynash | ayoung: so it's in that change, so feelfree | 01:46 |
henrynash | ayoungL for the flattening, idea? | 01:47 |
ayoung | well, I was thinking maybe we'd take my policy change and yours and put them into their own patch | 01:47 |
ayoung | so long as they have no dependencies, they can go in ahead of the trust API | 01:47 |
*** annegentle has quit IRC | 01:48 | |
henrynash | ayoung: could do…the one request people had was to make it just one protected wrapper that optionally took params….I struggled with that…but may try tomorrow to see if I can improve that | 01:48 |
*** vipul is now known as vipul|away | 01:49 | |
topol | gonna go eat. back in 20 mins | 01:49 |
henrynash | ayoungl I mean I struggled to make it work, not struggled conceptually (!) | 01:49 |
ayoung | henrynash, I'll give it a look later on tonight, gonna try and repost the API spec here first. | 01:49 |
*** yjiang5_away is now known as yjiang5 | 01:49 | |
henrynash | ayoung: ok | 01:49 |
henrynash | ayoung: there is one perhaps related change as well... | 01:50 |
ayoung | henrynash, I might just use your change ID and hack my changes into that | 01:50 |
*** vipul|away is now known as vipul | 01:50 | |
henrynash | ayoung:… we have overloaded things like create_grant to handle grants on both domains and projects | 01:50 |
*** anniec has quit IRC | 01:50 | |
*** anniec has joined #openstack-dev | 01:51 | |
ayoung | henrynash, that is internal, so we can rename them | 01:51 |
henrynash | ayoung: minimal code…but it means you only have one line in the policy file | 01:51 |
ayoung | henrynash, but with RBAC they should be protected by different roles | 01:51 |
ayoung | only a server admin shoud be able to create domains, and only a domain admin should be able to create projects | 01:52 |
ayoung | same with grants, I think | 01:52 |
*** burris has quit IRC | 01:53 | |
*** burris has joined #openstack-dev | 01:53 | |
henrynash | ayoung: exactly…you could do "identity:create_grant: [["domain_id=%(domain_id)"],["project_id=%(project_id)"]] which would mean you could only do domain grants if you had the roles on the domain and project grants if you had the roles on projects….. | 01:53 |
*** markwash has quit IRC | 01:53 | |
henrynash | ayoung: so maybe that is OK... | 01:54 |
ayoung | henrynash, maybe OK, but seems counterintuitive. Policy is confusing enough as is, no rason to obfusticate it. Is there anything gained by that? | 01:54 |
henrynash | ayoung: that was my point as well | 01:54 |
ayoung | henrynash, OK, we'll clean that one up. | 01:55 |
henrynash | ayoung: ok, so 3am in Europe…so I think it may be time for bed…will check in early tomorrow after a few house kip | 01:56 |
ayoung | henrynash, smoke me a kipper. I'll be back for breakfast | 01:56 |
henrynash | guang: let me know if you need more help on domain tokens..but you code and tests ran fine for me | 01:56 |
*** dprince has quit IRC | 01:57 | |
henrynash | ayoung: firing it up now :-) | 01:57 |
topol | good night henrynash | 01:57 |
openstackgerrit | A change was merged to openstack/nova: Fix message envelope keys. https://review.openstack.org/22483 | 01:58 |
*** soody has quit IRC | 01:58 | |
*** bencherian has joined #openstack-dev | 01:59 | |
*** gary_th has quit IRC | 01:59 | |
*** nati_ueno has quit IRC | 01:59 | |
*** soody has joined #openstack-dev | 02:00 | |
*** bearovercloud has left #openstack-dev | 02:00 | |
*** dolphm has joined #openstack-dev | 02:02 | |
*** dolphm has quit IRC | 02:02 | |
topol | ayoung, when is code freeze? if YorikSar writes code tomorrow for the magic role will it get in? | 02:02 |
*** danjared has quit IRC | 02:03 | |
*** markvoelker has joined #openstack-dev | 02:05 | |
*** darjeeling has joined #openstack-dev | 02:06 | |
clarkb | topol: feature freeze is tonight (before thierry wakes up morning time in France) | 02:07 |
*** danjared has joined #openstack-dev | 02:08 | |
*** kagan has quit IRC | 02:08 | |
*** unix has joined #openstack-dev | 02:08 | |
topol | clarkb, thanks! | 02:09 |
*** markvoelker1 has quit IRC | 02:10 | |
*** sulrich has joined #openstack-dev | 02:12 | |
*** sulrich has left #openstack-dev | 02:12 | |
*** sulrich has joined #openstack-dev | 02:13 | |
*** bencherian has quit IRC | 02:20 | |
*** pabelanger has joined #openstack-dev | 02:23 | |
*** mjfork has joined #openstack-dev | 02:24 | |
*** henrynash_ has joined #openstack-dev | 02:26 | |
*** andrewbogott is now known as andrewbogott_afk | 02:26 | |
*** bencherian has joined #openstack-dev | 02:27 | |
*** pixelbeat has quit IRC | 02:28 | |
*** henrynash has quit IRC | 02:29 | |
*** henrynash_ is now known as henrynash | 02:29 | |
*** bencherian has quit IRC | 02:31 | |
topol | ayoung,gyee will you need me to review anything tonight to push things through? I can be on call if needed | 02:32 |
*** jcmartin has quit IRC | 02:33 | |
*** danwent has quit IRC | 02:36 | |
*** sulrich has quit IRC | 02:36 | |
*** cp16net is now known as cp16net|away | 02:39 | |
*** nati_ueno has joined #openstack-dev | 02:39 | |
*** Tross has joined #openstack-dev | 02:40 | |
ayoung | topol, mine can wait until morning. | 02:40 |
ayoung | topol, We've missed code freeze | 02:40 |
topol | ayoung, OK really. clarkb said (before thierry wakes up morning time in France) | 02:41 |
openstackgerrit | A change was merged to openstack/keystone: enabled attribute emulation support https://review.openstack.org/20928 | 02:41 |
openstackgerrit | A change was merged to openstack/swift: Change in swift-drive-audit handling log rotation. https://review.openstack.org/16427 | 02:41 |
clarkb | I think that is what the email said | 02:41 |
topol | K, ayoung, I sent you my number if for some reason you need a review | 02:42 |
ayoung | topol, I'm not going to try to shoehorn anything in. Trusts is pretty much it. | 02:43 |
topol | ayoung, OK! | 02:43 |
*** sacharya1 has joined #openstack-dev | 02:44 | |
*** terryh has quit IRC | 02:45 | |
*** bencherian has joined #openstack-dev | 02:45 | |
*** bing_bu has quit IRC | 02:46 | |
*** bing_bu has joined #openstack-dev | 02:46 | |
*** anteaya has left #openstack-dev | 02:46 | |
*** reed has quit IRC | 02:47 | |
*** sacharya has quit IRC | 02:47 | |
*** nati_ueno has quit IRC | 02:49 | |
*** Ryan_Lane has quit IRC | 02:50 | |
openstackgerrit | A change was merged to openstack/ceilometer: pipeline: manager publish multiple counters https://review.openstack.org/21873 | 02:57 |
*** utlemming has quit IRC | 02:58 | |
*** esp1 has left #openstack-dev | 02:58 | |
*** tomoe_ has quit IRC | 02:59 | |
*** utlemming has joined #openstack-dev | 03:00 | |
*** tomoe_ has joined #openstack-dev | 03:00 | |
*** terryh has joined #openstack-dev | 03:02 | |
*** Mandell has quit IRC | 03:03 | |
*** bencherian has quit IRC | 03:03 | |
*** koolhead17 has joined #openstack-dev | 03:03 | |
*** darjeeling has quit IRC | 03:04 | |
*** adjohn has quit IRC | 03:08 | |
*** cp16net|away is now known as cp16net | 03:09 | |
*** bdpayne has quit IRC | 03:11 | |
*** anniec has quit IRC | 03:14 | |
openstackgerrit | A change was merged to openstack/keystone: v3 token API https://review.openstack.org/21487 | 03:17 |
*** imsplitbit has joined #openstack-dev | 03:23 | |
*** markmcclain has joined #openstack-dev | 03:23 | |
*** BalleS_ has joined #openstack-dev | 03:25 | |
*** anniec has joined #openstack-dev | 03:25 | |
*** anniec has quit IRC | 03:26 | |
*** susanne-balle has quit IRC | 03:29 | |
*** annegentle has joined #openstack-dev | 03:30 | |
*** ayoung has left #openstack-dev | 03:31 | |
*** ayoung has joined #openstack-dev | 03:32 | |
*** vkmc has quit IRC | 03:32 | |
*** mjfork has quit IRC | 03:32 | |
*** mjfork has joined #openstack-dev | 03:33 | |
*** gongysh has joined #openstack-dev | 03:35 | |
*** morganfainberg has quit IRC | 03:37 | |
*** BalleS_ has quit IRC | 03:38 | |
*** unix has quit IRC | 03:41 | |
*** mjfork has quit IRC | 03:47 | |
*** jergerber has quit IRC | 03:47 | |
*** mjfork has joined #openstack-dev | 03:47 | |
*** gyee has joined #openstack-dev | 03:47 | |
*** annegentle has quit IRC | 03:51 | |
openstackgerrit | A change was merged to openstack/glance: Filter images by status and add visibility shared https://review.openstack.org/21606 | 03:54 |
vipul | Anyone else seeing ImportError: No module named oslo.config during keystone launch? This is on latest devstack | 03:57 |
*** zyluo has joined #openstack-dev | 04:00 | |
*** martine has joined #openstack-dev | 04:01 | |
*** jab416171 has quit IRC | 04:04 | |
*** Dr_Who has joined #openstack-dev | 04:04 | |
*** amotoki has joined #openstack-dev | 04:05 | |
*** Dr_Who has quit IRC | 04:08 | |
*** Ryan_Lane has joined #openstack-dev | 04:08 | |
*** bdpayne has joined #openstack-dev | 04:10 | |
*** rui_ has joined #openstack-dev | 04:12 | |
*** thickski_ has joined #openstack-dev | 04:12 | |
thickski_ | http://ppa.launchpad.net/ubuntu-cloud-archive/grizzly-staging/ubuntu/pool/main/n/nova/ | 04:14 |
thickski_ | http://ppa.launchpad.net/ubuntu-cloud-archive/grizzly-staging/ubuntu/pool/main/n/nova/ | 04:14 |
*** markvoelker1 has joined #openstack-dev | 04:17 | |
*** aswadrangnekar has joined #openstack-dev | 04:18 | |
*** markvoelker has quit IRC | 04:20 | |
*** markvoelker1 has quit IRC | 04:20 | |
*** danwent has joined #openstack-dev | 04:21 | |
*** bdpayne has quit IRC | 04:22 | |
*** terryh has quit IRC | 04:25 | |
*** nati_ueno has joined #openstack-dev | 04:26 | |
*** dims has quit IRC | 04:28 | |
*** todo-stack has joined #openstack-dev | 04:29 | |
*** topol has quit IRC | 04:32 | |
*** nunosantos has quit IRC | 04:34 | |
*** imsplitbit has quit IRC | 04:34 | |
openstackgerrit | A change was merged to openstack/nova: Retry bw_usage_update() on innodb Deadlock https://review.openstack.org/22276 | 04:35 |
thickski_ | excuse me. when does grizzly-3 deb package release? > openstackgerrit | 04:36 |
*** terryh has joined #openstack-dev | 04:37 | |
*** Mandell has joined #openstack-dev | 04:37 | |
openstackgerrit | A change was merged to openstack/cinder: Implement a basic backup-volume-to-swift service https://review.openstack.org/19468 | 04:37 |
thickski_ | I am going to use that https://review.openstack.org/#/c/22276/ | 04:37 |
*** martine has quit IRC | 04:39 | |
*** navid has joined #openstack-dev | 04:40 | |
openstackgerrit | A change was merged to openstack-infra/devstack-gate: Enable tempest cli tests in devstack gate https://review.openstack.org/22096 | 04:42 |
openstackgerrit | A change was merged to openstack-dev/devstack: Added option Q_FLOATING_ALLOCATION_POOL to define an allocation-pool for floating IPs. https://review.openstack.org/22189 | 04:42 |
openstackgerrit | A change was merged to openstack-dev/devstack: Exercise cleanup https://review.openstack.org/22101 | 04:42 |
openstackgerrit | A change was merged to openstack/tempest: Clean up logging from glance_http.py https://review.openstack.org/22376 | 04:43 |
openstackgerrit | A change was merged to openstack/tempest: Add negative test for get server in test_servers_negative.py. https://review.openstack.org/22410 | 04:43 |
openstackgerrit | A change was merged to openstack/tempest: Add negative test for set server metadata https://review.openstack.org/22424 | 04:44 |
openstackgerrit | A change was merged to openstack/nova: Add an extension to show image size. https://review.openstack.org/21990 | 04:44 |
openstackgerrit | A change was merged to openstack/nova: Make add-fixed-ip update nwfilter wth in libvirt https://review.openstack.org/22154 | 04:44 |
openstackgerrit | A change was merged to openstack/cinder: Fix stale volume list for NetApp 7-mode ISCSI driver https://review.openstack.org/20229 | 04:44 |
thickski_ | oh ,thanks. | 04:45 |
thickski_ | when can I use that apt-get install command? | 04:45 |
thickski_ | I`d like to install g3 package, but there is no g3 deb packages in repository. | 04:46 |
*** yaguang has joined #openstack-dev | 04:51 | |
*** novas0x2a|laptop has quit IRC | 04:51 | |
*** pabelanger has quit IRC | 04:54 | |
*** pabelanger has joined #openstack-dev | 04:57 | |
*** todo-stack has quit IRC | 04:57 | |
*** rohitk has joined #openstack-dev | 05:03 | |
*** terryh has quit IRC | 05:08 | |
*** mohits has joined #openstack-dev | 05:08 | |
*** darjeeling has joined #openstack-dev | 05:10 | |
*** nati_ueno has quit IRC | 05:11 | |
*** markwash has joined #openstack-dev | 05:13 | |
*** gyee has quit IRC | 05:14 | |
*** koolhead17 has quit IRC | 05:16 | |
*** jcmartin has joined #openstack-dev | 05:16 | |
*** sulrich has joined #openstack-dev | 05:18 | |
*** KurtMartin has joined #openstack-dev | 05:19 | |
*** nati_ueno has joined #openstack-dev | 05:21 | |
*** nati_ueno has quit IRC | 05:21 | |
openstackgerrit | A change was merged to openstack/cinder: Skip timestamp check if 'capabilities' is none https://review.openstack.org/22510 | 05:26 |
*** rohitk has quit IRC | 05:26 | |
*** markmcclain has quit IRC | 05:27 | |
*** rohitk has joined #openstack-dev | 05:27 | |
*** amerine has joined #openstack-dev | 05:35 | |
*** henrynash has quit IRC | 05:38 | |
*** rui_ has quit IRC | 05:38 | |
*** zyluo has quit IRC | 05:40 | |
*** pabelanger has quit IRC | 05:40 | |
*** garyk has quit IRC | 05:40 | |
*** henrynash has joined #openstack-dev | 05:42 | |
*** ayoung has quit IRC | 05:44 | |
*** soody has quit IRC | 05:47 | |
*** aeperezt has quit IRC | 05:48 | |
openstackgerrit | A change was merged to openstack/quantum: Add check-nvp-config utility https://review.openstack.org/22288 | 05:58 |
*** melwitt has quit IRC | 06:00 | |
*** boris-42 has joined #openstack-dev | 06:03 | |
*** jab416171 has joined #openstack-dev | 06:04 | |
*** utlemming has quit IRC | 06:04 | |
*** bencherian has joined #openstack-dev | 06:04 | |
*** utlemming has joined #openstack-dev | 06:06 | |
*** jcmartin has quit IRC | 06:07 | |
*** sacharya1 has quit IRC | 06:10 | |
*** jbr_1 has joined #openstack-dev | 06:11 | |
openstackgerrit | A change was merged to openstack/nova: Move DB thread pooling to DB API. https://review.openstack.org/22163 | 06:12 |
*** hattwick has quit IRC | 06:18 | |
*** KurtMartin has quit IRC | 06:24 | |
*** almaisan-away is now known as al-maisan | 06:24 | |
*** al-maisan is now known as almaisan-away | 06:25 | |
*** nati_ueno has joined #openstack-dev | 06:28 | |
*** adjohn has joined #openstack-dev | 06:30 | |
*** garyk has joined #openstack-dev | 06:31 | |
*** gargya has joined #openstack-dev | 06:33 | |
*** jcmartin has joined #openstack-dev | 06:34 | |
*** zaitcev has quit IRC | 06:38 | |
*** jgriffit1 has joined #openstack-dev | 06:40 | |
*** jgriffit1 has joined #openstack-dev | 06:41 | |
*** sulrich has quit IRC | 06:43 | |
*** jgriffith has quit IRC | 06:45 | |
*** sulrich has joined #openstack-dev | 06:45 | |
openstackgerrit | A change was merged to openstack/swift: Documentation fixups https://review.openstack.org/22224 | 06:48 |
*** nati_ueno has joined #openstack-dev | 06:48 | |
*** sandywalsh has joined #openstack-dev | 06:49 | |
*** nati_ueno_2 has joined #openstack-dev | 06:52 | |
*** k4n0 has joined #openstack-dev | 06:54 | |
*** Nachi has joined #openstack-dev | 06:54 | |
*** eafonichev has quit IRC | 06:55 | |
*** nati_ueno has quit IRC | 06:55 | |
*** eafonichev has joined #openstack-dev | 06:56 | |
*** henrynash has quit IRC | 06:57 | |
*** henrynash has joined #openstack-dev | 06:58 | |
*** jgriffith has joined #openstack-dev | 06:58 | |
*** brucer has quit IRC | 07:00 | |
*** jgriffit1 has quit IRC | 07:03 | |
*** jcmartin has quit IRC | 07:08 | |
*** mars has joined #openstack-dev | 07:11 | |
*** mars is now known as Guest99378 | 07:11 | |
*** bing_bu has quit IRC | 07:15 | |
*** mindpixel has joined #openstack-dev | 07:17 | |
yjiang5 | gongysh: Hi | 07:25 |
gongysh | yjiang5: hi | 07:25 |
yjiang5 | I'm investigating about SR-IOV support on quantum, is it supported in quantum already now? | 07:26 |
yjiang5 | I didn't find related material in quantum documentation. | 07:26 |
gongysh | what is SR-IOV? | 07:26 |
yjiang5 | sorry, I should stated as SR-IOV NIC support. SR-IOV is a PCI-E extension, so that a physical device can be virtualized as multiple virtual function, and each can be assigned to a VM separtedly just like a real physical device. NIC with SR-IOV support will improve the network performance and reduce CPU utilization greatly, but also have some limitation like isolation etc. | 07:28 |
*** mrunge has joined #openstack-dev | 07:29 | |
gongysh | yjiang5: I am afraid quantum has no such stuff yet. If u want to implement it, you should find a point where u put it in quantum. | 07:30 |
yjiang5 | thanks. | 07:32 |
openstackgerrit | A change was merged to openstack/cinder: XenAPINFS: Create volume from image (generic) https://review.openstack.org/22454 | 07:34 |
openstackgerrit | A change was merged to openstack/nova: Fix instance directory path for lxc https://review.openstack.org/22289 | 07:34 |
openstackgerrit | A change was merged to openstack/quantum: Sync latest install_venv_common.py with olso https://review.openstack.org/22509 | 07:34 |
*** thingee is now known as thingee_zzz | 07:34 | |
ogelbukh | yjiang5: looks like the sr-iov is a hypervisor feature and thus belongs to nova rather than quantum | 07:38 |
*** yolanda has joined #openstack-dev | 07:40 | |
*** Nachi has quit IRC | 07:40 | |
yaguang | yjiang5,there is a blueprint for nova about SR-IOV | 07:40 |
yaguang | before | 07:40 |
yaguang | and someone has implemented it based on essex | 07:41 |
openstackgerrit | A change was merged to openstack/cinder: Implement metadata options for snapshots https://review.openstack.org/22253 | 07:41 |
*** kbrierly has quit IRC | 07:42 | |
*** retr0h has quit IRC | 07:42 | |
* ttx yawns | 07:43 | |
*** retr0h has joined #openstack-dev | 07:44 | |
*** retr0h has joined #openstack-dev | 07:44 | |
*** kbrierly has joined #openstack-dev | 07:44 | |
yjiang5 | ogelbukh: yaguang : SR-IOV is more a hypervisor feature, but SR-IO VNIC is more a quantum feature, which has several challenges. | 07:45 |
openstackgerrit | A change was merged to openstack/nova: Improve I/O performance for periodic tasks https://review.openstack.org/22432 | 07:45 |
*** boris-42 has quit IRC | 07:46 | |
*** gargya has quit IRC | 07:46 | |
zykes- | zul: / davidkranz ping | 07:48 |
*** flaper87 has joined #openstack-dev | 07:48 | |
*** rohitk_alt has joined #openstack-dev | 07:50 | |
*** nati_ueno_2 has quit IRC | 07:54 | |
*** nati_ueno has joined #openstack-dev | 07:54 | |
yjiang5 | ogelbukh: yaguang : for example, how to make sure the isolation between SR-IOV NIC device assgiedn to different VMs. | 07:55 |
*** mrodden has quit IRC | 07:56 | |
yaguang | yjing5,I am not insist on this must be implemend by nova | 07:57 |
ogelbukh | yjiang5: thanks, so that's rather about configuring physical NIC | 07:58 |
ogelbukh | something that quantum agent should do? | 07:58 |
yjiang5 | ogelbukh: yes. and SDN will make such support better because we may have better control of the NIC through the corresponding switch. but possibly quantum level may need some effort to handle it. | 07:59 |
*** rafaduran has joined #openstack-dev | 07:59 | |
yjiang5 | yaguang: understand . Nova SR-IOV support is infastucture for it. | 08:00 |
yaguang | https://blueprints.launchpad.net/nova/+spec/pci-passthrough | 08:01 |
*** reidrac has joined #openstack-dev | 08:02 | |
yjiang5 | yaguang: yes, I discussed that in mailing list before. | 08:04 |
yaguang | we can have a session at the Havana submit about this | 08:05 |
*** psedlak has quit IRC | 08:06 | |
*** eglynn__ has quit IRC | 08:06 | |
*** networkstatic has quit IRC | 08:08 | |
*** armaan has joined #openstack-dev | 08:08 | |
*** mikal has quit IRC | 08:19 | |
*** Ryan_Lane has quit IRC | 08:19 | |
*** mikal has joined #openstack-dev | 08:21 | |
*** jbr_1 has quit IRC | 08:21 | |
*** afazekas has joined #openstack-dev | 08:21 | |
openstackgerrit | A change was merged to openstack/nova: Fix instance can not be deleted after soft reboot https://review.openstack.org/22130 | 08:21 |
*** doude has joined #openstack-dev | 08:22 | |
*** gargya has joined #openstack-dev | 08:23 | |
*** almaisan-away is now known as al-maisan | 08:24 | |
*** eglynn__ has joined #openstack-dev | 08:25 | |
*** sc68cal has quit IRC | 08:25 | |
*** romcheg has joined #openstack-dev | 08:29 | |
*** dachary has joined #openstack-dev | 08:31 | |
*** sc68cal has joined #openstack-dev | 08:32 | |
*** gael__ has joined #openstack-dev | 08:32 | |
*** nati_ueno has quit IRC | 08:32 | |
*** xgauvrit has joined #openstack-dev | 08:33 | |
*** xga has joined #openstack-dev | 08:33 | |
*** xga__ has joined #openstack-dev | 08:34 | |
*** xgauvrit has quit IRC | 08:37 | |
*** xga has quit IRC | 08:37 | |
*** xga_ has joined #openstack-dev | 08:38 | |
*** eglynn__ has quit IRC | 08:39 | |
*** jpich has joined #openstack-dev | 08:40 | |
*** avishay has joined #openstack-dev | 08:41 | |
yjiang5 | yaguang: great. Will you submit it, or you want me to do that? | 08:42 |
*** Mandell has quit IRC | 08:42 | |
*** mmagr has joined #openstack-dev | 08:43 | |
*** dosaboy has joined #openstack-dev | 08:44 | |
yaguang | yjing5,I'd appreciate if you can submit | 08:44 |
*** fc__ has quit IRC | 08:47 | |
*** fc__ has joined #openstack-dev | 08:47 | |
*** navid has quit IRC | 08:49 | |
*** davidha has quit IRC | 08:51 | |
*** shardy_afk is now known as shardy | 08:51 | |
*** adjohn has quit IRC | 08:53 | |
*** jgallard has joined #openstack-dev | 08:57 | |
*** winston-d_ has quit IRC | 08:57 | |
*** markmc has joined #openstack-dev | 08:58 | |
henrynash | ttx: you there? | 09:00 |
ttx | henrynash: yes | 09:00 |
henrynash | tax; just sent you a mail on two keystone items... | 09:03 |
*** alexxu has quit IRC | 09:03 | |
henrynash | ttx: (I meant) | 09:03 |
ttx | henrynash: not received yet | 09:03 |
ttx | oh. gmail | 09:04 |
ttx | got it | 09:04 |
*** dachary has quit IRC | 09:04 | |
*** xga__ has quit IRC | 09:04 | |
*** xga_ has quit IRC | 09:04 | |
*** xga__ has joined #openstack-dev | 09:04 | |
*** xga_ has joined #openstack-dev | 09:04 | |
ttx | henrynash: maybe domain-scoping can get an exception | 09:05 |
henrynash | ttx: let me know if you are ok with those two | 09:06 |
*** danpb has joined #openstack-dev | 09:06 | |
ttx | henrynash: if the other review makes it in the following hour, i'll try to rush it in g3 | 09:06 |
*** dmner|away has quit IRC | 09:06 | |
ttx | henrynash: i wish it had a blueprint to cover for it | 09:06 |
*** xgauvrit has joined #openstack-dev | 09:06 | |
ttx | henrynash: it's been particularly difficult to follow what you guys were up to | 09:06 |
henrynash | ttx: there is, hold on: | 09:06 |
ttx | henrynash: not targeted to grizzly or grizzly-3... | 09:07 |
*** navid has joined #openstack-dev | 09:08 | |
henrynash | ttx: https://blueprints.launchpad.net/keystone/+spec/domain-scoping | 09:08 |
ttx | henrynash: no, I mean for policy query filter | 09:08 |
ttx | but that's a bugfix I guess | 09:08 |
henrynash | ttx: hey, someone just changed that to Havana! | 09:08 |
ttx | so we can backport it in g3 | 09:08 |
*** boden has joined #openstack-dev | 09:08 | |
ttx | henrynash: set to rc1 | 09:09 |
ttx | so 22223, whenever the queue will process it... we can backport to g3 as a bugfix | 09:09 |
ttx | 22515 - that gets an exception, if Joe agrees | 09:10 |
*** xga_ has quit IRC | 09:10 | |
*** xga__ has quit IRC | 09:10 | |
henrynash | ttx: so I know, is rc1 this release you are about to cut? | 09:10 |
henrynash | ttx: ok, sounds like a plan | 09:10 |
*** xgauvrit has quit IRC | 09:10 | |
*** salv-orlando has joined #openstack-dev | 09:10 | |
ttx | henrynash: no. g3 is the development milestone I'l about to cut | 09:11 |
*** iartarisi has joined #openstack-dev | 09:12 | |
henrynash | ttx: not sure why 22223 isn't queuing, been in that state since last night | 09:12 |
ttx | henrynash: I think it's missing the second +2 | 09:12 |
ttx | ayoung approved, but did not +2 | 09:12 |
henrynash | ttx: ahh, right | 09:12 |
ttx | so we can backport this one later today | 09:12 |
*** cyeoh has quit IRC | 09:13 | |
ttx | henrynash: it's in queue now though | 09:14 |
ttx | if it passes i'll just include it in g3 | 09:14 |
henrynash | ttx: ok, I think it would be good to do…since have more tests lined up I want fill out and beat on it | 09:14 |
*** zoresvit has joined #openstack-dev | 09:15 | |
henrynash | ttx: ok, great | 09:15 |
*** cyeoh has joined #openstack-dev | 09:15 | |
ttx | henrynash: friendly advice, next time, shoot for landing work one week earlier :) | 09:16 |
henrynash | ttx: gr8…btw, where are you in the world for us to be both on at this time | 09:17 |
henrynash | ttx: too bloody right :-) | 09:17 |
ttx | henrynash: France. | 09:17 |
henrynash | ttx: was really a dependancy issue with v3 auth…bit that was huge amount of work for Guang | 09:19 |
henrynash | txx: thought so, currently in Antibes ! | 09:19 |
ttx | henrynash: ahh. great! | 09:19 |
henrynash | ttx: :-) | 09:19 |
ttx | henrynash: are you based there ? | 09:20 |
*** darraghb has joined #openstack-dev | 09:21 | |
*** nsatterl_ has joined #openstack-dev | 09:21 | |
henrynash | ttx: no, sadly (!), just passing through…but used to live there when I was a kid | 09:23 |
*** psedlak has joined #openstack-dev | 09:24 | |
*** amerine has quit IRC | 09:26 | |
* ttx grabs a coffee | 09:27 | |
*** adjohn_ has joined #openstack-dev | 09:27 | |
*** iartarisi has quit IRC | 09:28 | |
*** 92AAB4WM6 has joined #openstack-dev | 09:28 | |
*** cyeoh has quit IRC | 09:30 | |
*** segv has left #openstack-dev | 09:31 | |
*** thickski_ has left #openstack-dev | 09:31 | |
*** cyeoh has joined #openstack-dev | 09:32 | |
*** dachary has joined #openstack-dev | 09:32 | |
*** darjeeling has quit IRC | 09:33 | |
*** gargya has quit IRC | 09:34 | |
*** susanne-balle has joined #openstack-dev | 09:34 | |
*** derekh has joined #openstack-dev | 09:35 | |
*** navid has quit IRC | 09:36 | |
*** adjohn_ has quit IRC | 09:36 | |
*** NobodyCam has quit IRC | 09:37 | |
*** susanne-balle has quit IRC | 09:38 | |
*** navid has joined #openstack-dev | 09:43 | |
*** eglynn__ has joined #openstack-dev | 09:47 | |
*** jruzicka has joined #openstack-dev | 09:47 | |
openstackgerrit | A change was merged to openstack/keystone: Pass query filter attributes to policy engine https://review.openstack.org/22223 | 09:48 |
*** zing has joined #openstack-dev | 09:51 | |
*** gargya has joined #openstack-dev | 09:52 | |
*** llu has quit IRC | 09:52 | |
ttx | henrynash: ok, it merged, so I'm including it in g3 | 09:53 |
*** llu has joined #openstack-dev | 09:55 | |
henrynash | ttx: excellent, thx | 09:55 |
henrynash | ttx: have sent a note to Joe on the domain scoping wire-up | 09:58 |
ttx | henrynash: i'm fine with it if it's as close as you pretend :) | 09:58 |
henrynash | ttx: :-) for once, c'est vrai! | 10:00 |
*** davidha has joined #openstack-dev | 10:01 | |
*** johnthetubaguy has joined #openstack-dev | 10:03 | |
*** dachary has quit IRC | 10:07 | |
*** davidh_ has joined #openstack-dev | 10:13 | |
*** mohits has quit IRC | 10:13 | |
*** davidha has quit IRC | 10:15 | |
*** psedlak has quit IRC | 10:20 | |
*** Guest99378 has quit IRC | 10:22 | |
*** zoresvit has quit IRC | 10:27 | |
shardy | markmc: Getting an oslo-config import error since your patch got merged into heat: | 10:28 |
shardy | http://www.fpaste.org/b993/ | 10:28 |
*** zoresvit has joined #openstack-dev | 10:28 | |
shardy | any idea what I need to do to fix it? Guess the python paths are messed up somehow.. | 10:28 |
markmc | shardy, it's quite odd - I'm not clear why it works, passes the tests etc. but fails in other circumstances | 10:28 |
markmc | shardy, bump the pip-requires from 2013.1b3 to 2013.1b4 and it should be fixed | 10:29 |
shardy | markmc: k, thanks trying that now | 10:29 |
markmc | shardy, np, sorry for the blip | 10:29 |
*** zoresvit has quit IRC | 10:31 | |
shardy | markmc: yup, that works, thanks | 10:31 |
*** adjohn has joined #openstack-dev | 10:34 | |
*** mohits has joined #openstack-dev | 10:35 | |
*** hattwick has joined #openstack-dev | 10:35 | |
*** psedlak has joined #openstack-dev | 10:38 | |
*** adjohn has quit IRC | 10:38 | |
openstackgerrit | A change was merged to openstack/ceilometer: Imported Translations from Transifex https://review.openstack.org/22499 | 10:39 |
*** Bobba_away has quit IRC | 10:40 | |
henrynash | ttx: fyi, just going through various bugs I raised to see if any are actually now fixed for g3 | 10:46 |
ttx | henrynash: ok, if any, let me know | 10:46 |
openstackgerrit | A change was merged to openstack/ceilometer: Support list/tuple as meter message value. https://review.openstack.org/22526 | 10:46 |
*** navid has quit IRC | 10:47 | |
*** yaguang has quit IRC | 10:47 | |
henrynash | ttxL Found 2: https://bugs.launchpad.net/keystone/+bug/1128925 | 10:48 |
uvirtbot | Launchpad bug 1128925 in keystone "v3 Identity api spec has come incorrect query filters" [High,Fix committed] | 10:48 |
henrynash | ttx: and: https://bugs.launchpad.net/keystone/+bug/1126043 | 10:48 |
uvirtbot | Launchpad bug 1126043 in keystone "Keystone RBAC should support checking against query filter items" [High,Fix committed] | 10:48 |
henrynash | ttx: I marked both of them Fix Committed for g3 | 10:48 |
*** zoresvit has joined #openstack-dev | 10:48 | |
ttx | henrynash: mark them fixreleased. they are in milestone-proposed now | 10:49 |
henrynash | ttx: ok, will do - didn't want to step on your toes | 10:51 |
openstackgerrit | A change was merged to openstack/ceilometer: plugin: don't use @staticmethod with abc https://review.openstack.org/22529 | 10:51 |
openstackgerrit | A change was merged to openstack/quantum: Add pagination support for xml https://review.openstack.org/21410 | 10:53 |
*** ondergetekende has joined #openstack-dev | 10:59 | |
henrynash | ttx: fyi, there is one other (https://bugs.launchpad.net/keystone/+bug/1093248) that will be fixed by the domain scoping change…bug for now left it as targeted at grc1 - and will pull it forward to g3 if we do get the domain scoping into g3 later today | 10:59 |
uvirtbot | Launchpad bug 1093248 in keystone "Domain role grants need to be honored in token authentication" [Undecided,In progress] | 10:59 |
henrynash | ttx: …actually, in reality, https://bugs.launchpad.net/keystone/+bug/1093248 is the thing that is missing in domain scoping, since the rest of the blueprint is already in | 11:00 |
*** pnavarro has joined #openstack-dev | 11:01 | |
ttx | hmm, yeah, we may backport it to g3 | 11:01 |
ttx | if it hits master soon | 11:01 |
*** davidha has joined #openstack-dev | 11:04 | |
*** adjohn has joined #openstack-dev | 11:04 | |
*** davidh_ has quit IRC | 11:05 | |
henrynash | ttx: as soon as one of those guys are on, it will go in…maybe what we should do is mark the blueprint complete, but tag the change agains this bug, not the blueprint | 11:05 |
ttx | henrynash: ok, i'll do that | 11:06 |
*** adjohn has quit IRC | 11:09 | |
henrynash | txx: ok, great - that does actually describe the situation correctly | 11:09 |
ttx | targeted bug 1093248 to g3 so that it stays on radar and we'll backport it | 11:09 |
uvirtbot | Launchpad bug 1093248 in keystone "Domain role grants need to be honored in token authentication" [High,In progress] https://launchpad.net/bugs/1093248 | 11:09 |
henrynash | ttx: great | 11:09 |
*** vkmc has joined #openstack-dev | 11:12 | |
*** gargya has quit IRC | 11:13 | |
*** trapni has joined #openstack-dev | 11:15 | |
*** trapni has joined #openstack-dev | 11:15 | |
*** psedlak is now known as psedlak|away | 11:16 | |
*** psedlak|away is now known as psedlak | 11:18 | |
*** psedlak is now known as psedlak|away | 11:19 | |
*** psedlak|away is now known as psedlak | 11:19 | |
*** sthaha has quit IRC | 11:20 | |
*** trapni has quit IRC | 11:21 | |
*** gongysh has quit IRC | 11:21 | |
*** ndipanov has quit IRC | 11:22 | |
*** ndipanov has joined #openstack-dev | 11:24 | |
*** psedlak is now known as psedlak|away | 11:25 | |
*** stevebaker has quit IRC | 11:27 | |
*** psedlak|away is now known as psedlak | 11:30 | |
*** mohits has quit IRC | 11:30 | |
*** alexxu has joined #openstack-dev | 11:32 | |
*** sthaha has joined #openstack-dev | 11:32 | |
*** danwent has quit IRC | 11:32 | |
*** al-maisan is now known as almaisan-away | 11:35 | |
*** trapni has joined #openstack-dev | 11:35 | |
*** adjohn has joined #openstack-dev | 11:35 | |
*** psedlak is now known as psedlak|away | 11:35 | |
*** gargya has joined #openstack-dev | 11:36 | |
*** BobBall has joined #openstack-dev | 11:39 | |
*** adjohn has quit IRC | 11:40 | |
*** trapni has quit IRC | 11:40 | |
*** trapni has joined #openstack-dev | 11:41 | |
*** henrynash has quit IRC | 11:42 | |
*** psedlak|away is now known as psedlak | 11:43 | |
*** GuilhermeMoro is now known as gmoro | 11:45 | |
*** henrynash has joined #openstack-dev | 11:47 | |
mordred | ttx: when you say "backport it to g3" - what do you mean? | 11:50 |
mordred | ttx: oh. nevermind | 11:50 |
mordred | ttx: ignore me | 11:50 |
*** alobbs has quit IRC | 11:51 | |
fc__ | aaway | 11:53 |
*** Hien has quit IRC | 11:53 | |
*** Hien has joined #openstack-dev | 11:53 | |
*** alobbs has joined #openstack-dev | 11:55 | |
*** dims has joined #openstack-dev | 11:57 | |
*** hugo_kuo has quit IRC | 11:57 | |
openstackgerrit | A change was merged to openstack/ceilometer: Document the rules for units https://review.openstack.org/22318 | 11:58 |
*** hugokuo has joined #openstack-dev | 11:59 | |
*** dprince has joined #openstack-dev | 12:00 | |
*** st has joined #openstack-dev | 12:01 | |
*** dhellmann-afk has quit IRC | 12:01 | |
*** adjohn has joined #openstack-dev | 12:06 | |
chmouel | fc__: fail | 12:06 |
fc__ | chmouel: shame on me :'( | 12:07 |
*** Yada has joined #openstack-dev | 12:09 | |
*** adjohn has quit IRC | 12:10 | |
*** dachary has joined #openstack-dev | 12:12 | |
openstackgerrit | A change was merged to openstack/ceilometer: Fix a bug in compute manager test case https://review.openstack.org/22304 | 12:20 |
*** adalbas has joined #openstack-dev | 12:21 | |
*** rohitk_alt has left #openstack-dev | 12:21 | |
*** ollie2 has joined #openstack-dev | 12:22 | |
*** soody has joined #openstack-dev | 12:26 | |
*** dims has quit IRC | 12:27 | |
*** dims has joined #openstack-dev | 12:28 | |
*** davidkranz_ has joined #openstack-dev | 12:32 | |
*** soody has quit IRC | 12:33 | |
*** davidkranz has quit IRC | 12:34 | |
*** adjohn has joined #openstack-dev | 12:37 | |
*** psedlak is now known as psedlak|away | 12:37 | |
*** psedlak|away is now known as psedlak | 12:37 | |
*** sandywalsh has quit IRC | 12:38 | |
*** psedlak is now known as psedlak|away | 12:38 | |
*** ollie2 has left #openstack-dev | 12:39 | |
*** mikal has quit IRC | 12:39 | |
*** romcheg has quit IRC | 12:39 | |
*** tomoe_ has quit IRC | 12:39 | |
*** mikal has joined #openstack-dev | 12:40 | |
*** tomoe_ has joined #openstack-dev | 12:40 | |
*** adjohn has quit IRC | 12:41 | |
*** mkollaro has joined #openstack-dev | 12:43 | |
*** yjiang5 is now known as yjiang5_away | 12:44 | |
*** rkukura has quit IRC | 12:47 | |
*** psedlak|away is now known as psedlak | 12:50 | |
*** sandywalsh has joined #openstack-dev | 12:52 | |
*** sulrich has quit IRC | 12:54 | |
*** sulrich has joined #openstack-dev | 12:55 | |
k4n0 | @sdague, @boris-42, @vishy, Nova-core please review https://review.openstack.org/#/c/21415/ | 12:55 |
*** gongysh has joined #openstack-dev | 12:55 | |
*** dprince has quit IRC | 12:56 | |
*** timello has quit IRC | 12:59 | |
*** sacharya has joined #openstack-dev | 13:02 | |
*** markvoelker has joined #openstack-dev | 13:03 | |
*** davidh_ has joined #openstack-dev | 13:03 | |
*** jaypipes has joined #openstack-dev | 13:06 | |
*** davidha has quit IRC | 13:06 | |
*** adjohn has joined #openstack-dev | 13:07 | |
*** sacharya has quit IRC | 13:09 | |
*** timello has joined #openstack-dev | 13:10 | |
*** adjohn has quit IRC | 13:12 | |
*** olaph has quit IRC | 13:15 | |
*** olaph has joined #openstack-dev | 13:15 | |
openstackgerrit | A change was merged to openstack/ceilometer: Update common to get new kombu serialization code https://review.openstack.org/22427 | 13:16 |
*** psedlak is now known as psedlak|away | 13:18 | |
*** psedlak|away is now known as psedlak | 13:18 | |
*** david2 has joined #openstack-dev | 13:23 | |
*** yamahata has joined #openstack-dev | 13:24 | |
markmc | eglynn__, jd__, uh oh ^^^ | 13:27 |
markmc | eglynn__, jd__, those changes were reverted | 13:27 |
*** psedlak is now known as psedlak|away | 13:27 | |
* markmc digs up a link | 13:27 | |
jd__ | in oslo? | 13:27 |
*** psedlak|away is now known as psedlak | 13:27 | |
markmc | eglynn__, jd__, https://review.openstack.org/22495 | 13:27 |
eglynn__ | markmc: right we need to revert in ceilo also in that case | 13:28 |
markmc | eglynn__, jd__, https://review.openstack.org/22488 | 13:28 |
markmc | eglynn__, jd__, I'll submit the ceilo revert asap | 13:28 |
jd__ | ack | 13:28 |
eglynn__ | k | 13:28 |
*** dolphm has joined #openstack-dev | 13:29 | |
*** psedlak is now known as psedlak|away | 13:29 | |
*** psedlak|away is now known as psedlak | 13:29 | |
*** psedlak is now known as psedlak|away | 13:31 | |
*** mrunge has quit IRC | 13:31 | |
markmc | eglynn__, jd__, https://review.openstack.org/22543 | 13:31 |
markmc | another one on the way | 13:31 |
*** darjeeling has joined #openstack-dev | 13:31 | |
*** psedlak|away is now known as psedlak | 13:32 | |
markmc | eglynn__, jd__, https://review.openstack.org/22544 | 13:32 |
*** 92AAB4WM6 has quit IRC | 13:32 | |
*** alunduil has quit IRC | 13:33 | |
eglynn__ | markmc: thanks! (both now approved ...) | 13:33 |
markmc | thanks guys | 13:34 |
*** st has quit IRC | 13:34 | |
*** mdomsch has quit IRC | 13:35 | |
* ttx waits for those two to get merged before cutting ceilometer milestone-proposed | 13:35 | |
*** pcm_ has joined #openstack-dev | 13:35 | |
ttx | markmc: let me know when I should tag oslo-incubator grizzly-3 and mark bugs fixreleased | 13:36 |
ttx | even if that doesn't mean a lot | 13:37 |
*** psedlak is now known as psedlak|away | 13:38 | |
markmc | ttx, now is fine, thanks | 13:38 |
*** psedlak|away is now known as psedlak | 13:39 | |
*** psedlak is now known as psedlak|away | 13:39 | |
*** davidh_ has quit IRC | 13:39 | |
ttx | markmc: bug 1095587 still open against grizzly-3 ? | 13:39 |
*** davidha has joined #openstack-dev | 13:39 | |
uvirtbot | Launchpad bug 1095587 in oslo "Make oslo rpc sanitization configuration project specific" [Medium,In progress] https://launchpad.net/bugs/1095587 | 13:39 |
openstackgerrit | A change was merged to openstack/ceilometer: Revert recent rpc wire format changes https://review.openstack.org/22543 | 13:39 |
ttx | move to RC1 ? | 13:39 |
markmc | ttx, I just de-milestoned it | 13:40 |
ttx | OK, on it | 13:40 |
openstackgerrit | A change was merged to openstack/ceilometer: Fix message envelope keys. https://review.openstack.org/22544 | 13:41 |
*** pcm_ has left #openstack-dev | 13:41 | |
*** DuncanT1 has joined #openstack-dev | 13:43 | |
nijaba | ttx: all seems to have been merged now. all green on bugs and bp as well | 13:43 |
*** sulrich has quit IRC | 13:43 | |
*** dolphm has quit IRC | 13:44 | |
ttx | nijaba: ok branching | 13:44 |
nijaba | thanks | 13:44 |
*** sc68cal has quit IRC | 13:45 | |
*** dabo has quit IRC | 13:45 | |
*** pcm__ has joined #openstack-dev | 13:46 | |
*** drewlander has joined #openstack-dev | 13:47 | |
*** sthaha has quit IRC | 13:48 | |
*** sacharya has joined #openstack-dev | 13:48 | |
*** dolphm has joined #openstack-dev | 13:48 | |
ttx | markmc: will tag as soon as I have confirmation what exact form I should be using | 13:50 |
markmc | ttx, from who? | 13:51 |
*** dabo has joined #openstack-dev | 13:51 | |
markmc | ttx, there's no tarball job or anything, so grizzly-3 is prolly fine | 13:51 |
ttx | markmc: hmm yeah, wanted it to be consistent with others, but meh | 13:51 |
markmc | ah, you have't tagged other projects yet | 13:51 |
markmc | that's fine | 13:51 |
markmc | sorry | 13:51 |
*** psedlak|away is now known as psedlak | 13:52 | |
ttx | making it consistent with the past (grizzly-2) is probably fine too | 13:52 |
ttx | yeah, let's do that | 13:52 |
*** dprince has joined #openstack-dev | 13:52 | |
*** sthaha has joined #openstack-dev | 13:52 | |
ttx | markmc: ok done | 13:53 |
*** rohitk has quit IRC | 13:53 | |
markmc | ttx, thankie | 13:54 |
*** xga_ has joined #openstack-dev | 13:54 | |
ttx | nijaba: milestone-proposed build is in. Will trun it into grizzly-3 at the end of the day unless you push a bug to the grizzly-3 buglist | 13:55 |
*** Tross has quit IRC | 13:58 | |
*** annegentle has joined #openstack-dev | 14:01 | |
*** anteaya has joined #openstack-dev | 14:01 | |
*** unix has joined #openstack-dev | 14:05 | |
henrynash | dolphm, ayoung, heckj: any of you around? | 14:07 |
*** sulrich has joined #openstack-dev | 14:08 | |
*** adjohn has joined #openstack-dev | 14:09 | |
*** bnemec has quit IRC | 14:09 | |
*** kbringard has joined #openstack-dev | 14:10 | |
*** afazekas has quit IRC | 14:13 | |
*** adjohn has quit IRC | 14:14 | |
*** imsplitbit has joined #openstack-dev | 14:15 | |
*** pixelbeat has joined #openstack-dev | 14:15 | |
*** bknudson has joined #openstack-dev | 14:16 | |
*** dhellmann has joined #openstack-dev | 14:17 | |
*** bnemec has joined #openstack-dev | 14:17 | |
*** annegentle_ has joined #openstack-dev | 14:22 | |
nijaba | ttx: ack | 14:23 |
*** annegentle_ has quit IRC | 14:24 | |
*** radez_g0n3 is now known as radez | 14:24 | |
*** ayoung has joined #openstack-dev | 14:25 | |
ayoung | henrynash, # user have no domain roles, therefore access denied | 14:25 |
ayoung | is that right? | 14:25 |
henrynash | ayoung: yes, a domain token will only be granted if you have a role on it | 14:26 |
*** pabelanger has joined #openstack-dev | 14:26 | |
ayoung | If a user passes a domain ID on a token request, and also a project ID, I would expect that they should get a token, assuming the project is in the domain | 14:26 |
henrynash | ayoung: there is no "default domain" equivilent | 14:26 |
ayoung | henrynash, no, I mean, a user defined in dom1 asks for a token for a project in dom2 | 14:27 |
ayoung | so they pass in dom2 | 14:27 |
ayoung | yes, they have no dom roles, but they do have roles on project2 | 14:27 |
ayoung | which is in domain 2 | 14:27 |
henrynash | ayoung: yes, they would get a project token (for the one in dome) | 14:27 |
henrynash | dom2 | 14:27 |
*** zing_ has joined #openstack-dev | 14:27 | |
ayoung | henrynash, the way it is written now,they would not | 14:28 |
ayoung | I just want to make sure that is intentional | 14:28 |
*** ron-slc_ has joined #openstack-dev | 14:28 | |
ayoung | https://review.openstack.org/#/c/22515/1/keystone/auth/token_factory.py | 14:28 |
*** zing has quit IRC | 14:28 | |
*** zing_ is now known as zing | 14:28 | |
ayoung | _get_role_for user will error out on the domain check bbefore getting to the project check | 14:28 |
*** pcm__ has quit IRC | 14:28 | |
henrynash | ayoungL actually the spec says you can ask for scope of domain or project, not both | 14:29 |
*** aeperezt has joined #openstack-dev | 14:30 | |
ayoung | ah, ok | 14:30 |
*** dolphm has quit IRC | 14:30 | |
annegentle | ayoung: hey do you happen to know if keystone user-disable was available for keystone in the folsom timeframe? | 14:32 |
ayoung | annegentle, I am sure it was | 14:32 |
annegentle | ayoung: ok thanks for confirmation | 14:32 |
henrynash | ayoung: and the fact that you only have one or the other is first checking in set_scope in token/controllers.py | 14:33 |
*** imsplitbit has quit IRC | 14:34 | |
*** pabelanger has quit IRC | 14:34 | |
*** Tross has joined #openstack-dev | 14:34 | |
*** pcm_ has joined #openstack-dev | 14:37 | |
ayoung | henrynash, yep, saw that | 14:37 |
*** alunduil has joined #openstack-dev | 14:38 | |
ayoung | henrynash, didn't get to the filter scope policy thing last night. About to look at that now | 14:38 |
henrynash | ayoung: ok..thanks for setting the 22515 on its way | 14:38 |
ayoung | https://review.openstack.org/#/c/22475/ henrynash | 14:39 |
*** alunduil has quit IRC | 14:39 | |
*** adjohn has joined #openstack-dev | 14:39 | |
*** alunduil has joined #openstack-dev | 14:40 | |
henrynash | ayoung: done | 14:40 |
ayoung | henrynash, where is your review? THe filter one? | 14:40 |
ayoung | Is it WIP? | 14:40 |
*** martine has joined #openstack-dev | 14:41 | |
*** dolphm has joined #openstack-dev | 14:41 | |
henrynash | ayoung: it already merged, but its at: https://review.openstack.org/#/c/22223/ | 14:41 |
ayoung | ah, cool | 14:41 |
*** bswartz has quit IRC | 14:41 | |
henrynash | ttx: OK, so https://review.openstack.org/#/c/22515/ is gating now | 14:42 |
*** psedlak is now known as psedlak|away | 14:42 | |
*** psedlak|away is now known as psedlak | 14:42 | |
ttx | henrynash: could you backport it to milestone-proposed ? | 14:43 |
ttx | henrynash: https://wiki.openstack.org/wiki/GerritJenkinsGithub#Authoring_Changes_for_milestone-proposed | 14:43 |
ayoung | henrynash, what would a policy rule look like under that scheme? | 14:43 |
ttx | henrynash: then i'll approve it for milestone-proposed as soon as it hits master | 14:43 |
henrynash | ttx: ok, will do | 14:43 |
*** FlorianOtel has quit IRC | 14:43 | |
*** adjohn has quit IRC | 14:44 | |
*** japage has quit IRC | 14:44 | |
*** martine has quit IRC | 14:44 | |
henrynash | ayoung: so basically you can just include anything that can be filtered in the rule | 14:44 |
*** nsatterl_ has quit IRC | 14:45 | |
*** martine has joined #openstack-dev | 14:45 | |
ayoung | henrynash, it doesn't change the policy file? | 14:45 |
ayoung | so If I need different policy based on filter? | 14:45 |
henrynash | ayoung: well, you have to mention the thing you want to check on in the policy file | 14:45 |
*** woodspa has joined #openstack-dev | 14:46 | |
henrynash | ayound: so you include it in there if you want to protect based on it, e.g. my classic: | 14:46 |
*** nsatterl_ has joined #openstack-dev | 14:46 | |
ayoung | henrynash, I was 3 policies for list_trusts. If it has no filter, is_admin, If it has a trustee_user_ids I want to ensure user_id = trustee_use Id (or is_admin) and if it is trustor_ ...you get the point | 14:46 |
henrynash | ayoung: yes, I think that's right…I think many rules will have "is admin or [some test]", you just happen to have two | 14:48 |
*** jimfehlig has joined #openstack-dev | 14:50 | |
*** psedlak is now known as psedlak|away | 14:50 | |
*** psedlak|away is now known as psedlak | 14:51 | |
ayoung | henrynash, http://www.fpaste.org/kbzO/ | 14:52 |
*** psedlak is now known as psedlak|away | 14:52 | |
*** gray-- has joined #openstack-dev | 14:52 | |
ayoung | is that right? | 14:53 |
*** mtreinish has joined #openstack-dev | 14:54 | |
henrynash | ayoung: not sure if including the query string in the target is right…I think you just or them together on one line | 14:54 |
ayoung | "identity:list_projects": [["rule:admin_required"], ["user_id:%(trustee_user_id)s"], ["user_id:%(trustor_user_id)s"]], | 14:54 |
henrynash | ayoung: yes, I think that's it | 14:55 |
*** n0ano has joined #openstack-dev | 14:56 | |
*** eglynn__ is now known as eglynn | 14:58 | |
*** rkukura has joined #openstack-dev | 14:58 | |
*** opilotte has joined #openstack-dev | 14:59 | |
*** maroh has joined #openstack-dev | 15:00 | |
*** k4n0 has left #openstack-dev | 15:00 | |
*** psedlak|away is now known as psedlak | 15:01 | |
*** davidkranz_ is now known as davidkranz | 15:02 | |
*** gary_th has joined #openstack-dev | 15:03 | |
*** hugokuo has quit IRC | 15:03 | |
*** gargya has quit IRC | 15:04 | |
*** terryh has joined #openstack-dev | 15:04 | |
*** radez is now known as radez_g0n3 | 15:04 | |
*** xga_ has quit IRC | 15:06 | |
*** psedlak is now known as psedlak|away | 15:06 | |
*** psedlak|away is now known as psedlak | 15:06 | |
flaper87 | bcwaldon: ping | 15:06 |
*** ndipanov has quit IRC | 15:07 | |
YorikSar | ayoung: Hi | 15:09 |
*** sulrich has quit IRC | 15:09 | |
*** networkstatic has joined #openstack-dev | 15:10 | |
YorikSar | ayoung: A have almost finished that migration for LDAP | 15:10 |
*** adjohn has joined #openstack-dev | 15:10 | |
*** sulrich has joined #openstack-dev | 15:10 | |
ayoung | YorikSar, cool. | 15:10 |
YorikSar | ayoung: But I ran into some crazy code introduced by https://review.openstack.org/21664 | 15:11 |
YorikSar | ayoung: I'm not sure how it even remotely can work. | 15:11 |
YorikSar | ayoung: It requires object to exist in LDAP to convert its id to DN, even if we are trying to create a new object. | 15:12 |
*** bswartz has joined #openstack-dev | 15:12 | |
*** kbrierly has quit IRC | 15:13 | |
YorikSar | I guess, I should ask dolphm or topol about this... | 15:13 |
ayoung | YorikSar, dolphm wouldn't know, topol would be better....but where are you seeing that | 15:14 |
dolphm | ayoung: +1 | 15:14 |
bknudson | YorikSar: "I think this bug fix is putting lipstick on a pig" | 15:14 |
*** kbrierly has joined #openstack-dev | 15:14 | |
*** adjohn has quit IRC | 15:15 | |
*** markmcclain has joined #openstack-dev | 15:15 | |
YorikSar | ayoung: https://review.openstack.org/#/c/21664/11/keystone/common/ldap/core.py - take a look at what happend to _id_to_dn | 15:15 |
*** alexxu has quit IRC | 15:15 | |
*** rpedde_away is now known as rpedde | 15:16 | |
YorikSar | And in create method we try to create DN=self._id_to_dn(id). | 15:16 |
ayoung | YorikSar, yep, that is wrong | 15:16 |
ayoung | how did that pass the unit tests...let me see | 15:17 |
*** dontalton has joined #openstack-dev | 15:17 | |
zigo_ | Any idea what's wrong in the quantumclient bash_completion script in 3.0.a1? | 15:17 |
zigo_ | It's not listing commands ... | 15:17 |
ayoung | YorikSar, I'm in the middle of some git ops...one second | 15:17 |
zigo_ | Just options starting with - and -- | 15:17 |
YorikSar | ayoung: They stubbed _id_to_dn everywhere... | 15:18 |
*** cloudchimp has joined #openstack-dev | 15:18 | |
davidkranz | dtroyer: Thanks for your +2 on https://review.openstack.org/#/c/22446/2. Who can we ask to Approve it? | 15:19 |
davidkranz | andreaf: ^^^^ | 15:19 |
YorikSar | ayoung: https://review.openstack.org/#/c/21664/11/tests/test_backend_ldap.py in setUp... | 15:20 |
*** sthaha has quit IRC | 15:20 | |
YorikSar | ayoung: Ok, I'll revert that part of that commit once I speak with topol about reasons for that. | 15:20 |
ayoung | YorikSar, hold on...that is my bad, I would never have approved this commit if I had seen that line....that is just...wrong | 15:21 |
*** kbrierly has quit IRC | 15:21 | |
*** kbrierly has joined #openstack-dev | 15:22 | |
ayoung | YorikSar, I'm going to revert that change | 15:22 |
dtroyer | @davidkranz: being a tempest thing I figured @sdague would have been all over that by now. It's simple enough, if you hit it with a +1 I'll approve it | 15:22 |
YorikSar | ayoung: Entirely? What if there still is something usefull there? | 15:22 |
ayoung | YorikSar, then it will get into Havanah | 15:22 |
YorikSar | ayoung: That scoping thing might be reasonable... | 15:22 |
ayoung | YorikSar, I am sure it is, but now that I se what it implies, it makes me too nervous this close to freeze. Wait one | 15:23 |
notmyname | sandywalsh: likewise, but I need to get off the computer now. want to follow up async over email? | 15:23 |
*** gongysh has quit IRC | 15:24 | |
sandywalsh | notmyname, sounds good ... cheers! | 15:24 |
*** eharney has joined #openstack-dev | 15:24 | |
*** eharney has quit IRC | 15:24 | |
*** eharney has joined #openstack-dev | 15:24 | |
notmyname | sandywalsh: great. I'll look for it :-) | 15:24 |
*** gongysh has joined #openstack-dev | 15:24 | |
*** sstent has joined #openstack-dev | 15:26 | |
openstackgerrit | A change was merged to openstack/keystone: Removed redundant assertion https://review.openstack.org/22491 | 15:27 |
openstackgerrit | A change was merged to openstack/keystone: Update oslo-config version. https://review.openstack.org/22475 | 15:27 |
*** nati_ueno has joined #openstack-dev | 15:27 | |
sdague | davidkranz: let me look right after I get out of this meeting, 30 minutes | 15:27 |
davidkranz | sdague: np. You already said you were fine with it. | 15:28 |
*** afazekas has joined #openstack-dev | 15:29 | |
*** maroh has quit IRC | 15:31 | |
*** Nachi has joined #openstack-dev | 15:32 | |
*** nati_ueno has quit IRC | 15:33 | |
*** devoid has joined #openstack-dev | 15:33 | |
sdague | dtroyer: sorry, I was a little behind on reviews, exhausted from review rush the last couple of days | 15:34 |
*** susanne-balle has joined #openstack-dev | 15:34 | |
dtroyer | @sdague: no worries, I didn't do much this week until last night myself… | 15:34 |
openstackgerrit | A change was merged to openstack/cinder: Cinder devref doc cleanups https://review.openstack.org/22527 | 15:36 |
ayoung | YorikSar, OK, assuming we would want to keep that commit, I assume that we need the original logic for create. That logic is only going to work for quesries. Creating a new object at a random point in the tree is not going to fly | 15:37 |
*** maroh has joined #openstack-dev | 15:37 | |
*** epim has quit IRC | 15:37 | |
ayoung | YorikSar, I assume that the people pushing for that change are dealing primarily with read only LDAP, which is the dominant use case | 15:37 |
YorikSar | ayoung: We select a place for every new object using configured *_tree_dn. It's not so random... | 15:38 |
*** Nachi has quit IRC | 15:38 | |
ayoung | YorikSar, I know that, that is not what I am saying | 15:39 |
ayoung | This code is assuming that the scope could be subtree | 15:39 |
YorikSar | ayoung: We definitely should add tempest tests for LDAP to gate. | 15:39 |
YorikSar | ayoung: Oh... | 15:39 |
ayoung | it means that objects can come from multiple locations in a subtree, say users are grouped. | 15:39 |
ayoung | YorikSar, yeah. | 15:39 |
ayoung | So...We can query the whole tree, but we need to know where to insert | 15:39 |
YorikSar | Then it's a different problem, it should not be solved on such global level. | 15:40 |
YorikSar | First of all, this should be configured per-class. | 15:40 |
*** crandquist has quit IRC | 15:40 | |
ayoung | YorikSar, OK, I think the fix is something like | 15:40 |
YorikSar | Then it should affect only _ldap_get* methods. | 15:40 |
ayoung | if self.LDAP_SCOPE == 'subtree' do that logic, otherwise, do the original | 15:41 |
*** adjohn has joined #openstack-dev | 15:41 | |
henrynash | ttx: just waiting for gate to finish before I back port…. | 15:41 |
chmouel | sdague, dtroyer: let me know if you want to chat about https://review.openstack.org/#/c/21104/ | 15:41 |
ayoung | that introduces a slew of weirdness | 15:41 |
YorikSar | ayoung: I don't like that logic at all... | 15:41 |
ttx | henrynash: awesome | 15:41 |
ayoung | but I bet it is the closest to what people need | 15:42 |
ayoung | YorikSar, I don't like it either | 15:42 |
chmouel | dtroyer: I did split it the services like you said in your comment but also enable swift by default on devstack (wiht swift_replicas=1 as well) | 15:42 |
ayoung | YorikSar, it also should be different logic for insert than lookup. Insert will do the old logic | 15:42 |
ayoung | lookup can look in the whole subtree | 15:42 |
*** psedlak is now known as psedlak|away | 15:43 | |
*** psedlak|away is now known as psedlak | 15:43 | |
ayoung | YorikSar, or we could do it in the excpetion | 15:43 |
dtroyer | @chmouel: In a multi-node config, what swift services would you want on the non-master nodes? | 15:43 |
chmouel | dtroyer: the proxy | 15:43 |
chmouel | dtroyer: i.e: s-proxy service in this case | 15:44 |
dtroyer | chmouel: that's all? | 15:44 |
chmouel | dtroyer: oh sorry i read it wrong | 15:44 |
chmouel | dtroyer: so proxy on /master/ and s-account, s-container, s-object on non master | 15:44 |
*** DuncanT1 has quit IRC | 15:44 | |
*** pabelanger has joined #openstack-dev | 15:45 | |
*** apevec has joined #openstack-dev | 15:45 | |
dtroyer | chmouel: ok. that's the split I was concerned with being able to do easily | 15:45 |
*** adjohn has quit IRC | 15:45 | |
ayoung | http://www.fpaste.org/tRF3/ YorikSar | 15:45 |
ayoung | testing now | 15:45 |
*** datsun180b has joined #openstack-dev | 15:46 | |
YorikSar | ayoung: First of all, there should be braces around list of exception types | 15:46 |
ayoung | YorikSar, heh | 15:46 |
YorikSar | ayoung: then... We should not add a lookup to every place where _id_to_dn can be called. | 15:47 |
ayoung | YorikSar, do you like the logic, though? | 15:47 |
YorikSar | \win 2 | 15:47 |
YorikSar | ayoung: No... It's like flipping a coin. | 15:47 |
*** alszar has joined #openstack-dev | 15:47 | |
ayoung | YorikSar, it will be expensive on creates, but correct | 15:48 |
chmouel | dtroyer: how does MULTI_HOST works I never used it | 15:48 |
chmouel | dtroyer: (i.e what should I grep) | 15:48 |
ayoung | YorikSar, Ah, they stubbed it out because fakeldap couldn't handle it | 15:48 |
YorikSar | ayoung: We should add an argument to _id_to_dn like may_lookup and do this lookup only if self.subtree_lokup and may_lookup. | 15:48 |
chmouel | dtroyer: because from what i can see it's seems tied to nova | 15:49 |
*** radez_g0n3 is now known as radez | 15:49 | |
YorikSar | ayoung: Of course it couldn't - these objects are not there, we're trying to create them! | 15:49 |
ayoung | YorikSar, no different issue | 15:49 |
*** dontalton has quit IRC | 15:49 | |
YorikSar | ayoung: (sorry, WAT?!s per second still high) | 15:50 |
ayoung | YorikSar, fakeldap can't handle the complex queries, I think | 15:50 |
YorikSar | ayoung: It can... | 15:50 |
*** ndipanov has joined #openstack-dev | 15:50 | |
YorikSar | ayoung: I'll defend my child :) | 15:50 |
dtroyer | chmouel: IIRC the only actual setting in stack.sh for it is MULTI_HOST and that just changes something in Nova. To use devstack that way is just runing it with a different localrc on other nodes pointing back to master. http://devstack.org/guides/multinode-lab.html describes it. I haven't actually tried it since we shut down the old RCB essex cluster. | 15:51 |
YorikSar | ayoung: Oh, wait... | 15:51 |
YorikSar | ayoung: the same Ionuț Arțăriși killed support of | operator there. | 15:52 |
chmouel | dtroyer: do you think it's a use case we should absolutely support? because that could get tricky (i.e: quite a bit of work) for swift with ring information and stuff | 15:53 |
*** nati_ueno has joined #openstack-dev | 15:53 | |
ayoung | YorikSar, nah, the problem isn't fakeldap | 15:54 |
*** rnirmal has joined #openstack-dev | 15:54 | |
ayoung | it is braindead code | 15:54 |
dtroyer | chmouel: That I don't know about, it may not make sense. I didn't want to just dismiss it automatically though | 15:54 |
YorikSar | ayoung: Yes, but he broke it as well! :( | 15:55 |
ayoung | Heh | 15:55 |
ayoung | YorikSar, blame me, I am the reviewer | 15:55 |
openstackgerrit | A change was merged to openstack/cinder: Fixed cinder-backup start errors seen with devstack https://review.openstack.org/22531 | 15:55 |
openstackgerrit | A change was merged to openstack/keystone: domain-scoping https://review.openstack.org/22515 | 15:55 |
ayoung | Wow, we have al ot of skip tests in LDAP | 15:56 |
YorikSar | They are mostly related to groups and domains. | 15:56 |
chmouel | dtroyer: it may be doable if we have something like SWIFT_{PROXY/ACCOUNT/CONTAINER/OBJECT}_SERVER_IP= | 15:56 |
chmouel | dtroyer: with not as much changes | 15:57 |
*** cp16net is now known as cp16net|away | 15:57 | |
*** john5223 has joined #openstack-dev | 15:57 | |
ttx | henrynash: backport away | 15:57 |
henrynash | ttx: yep, doing it now | 15:58 |
YorikSar | ayoung: Ok, let me push my proposal for migration, there's a lot to talk about there. Then I can try to clean up this mess with fakeldap and scopes. | 15:58 |
ttx | henrynash: ping me when done, i'll approve it | 15:58 |
*** gargya has joined #openstack-dev | 15:58 | |
ayoung | YorikSar, I think I want to get this fix in quickest. It breaks everything | 15:58 |
dtroyer | chmouel: I'd like to be able to show at least a minimal multi-node swift if possible. | 15:58 |
ayoung | I'll ping you when I have it ready for review | 15:59 |
chmouel | dtroyer: is that absolutely needed for this review? | 15:59 |
*** topol has joined #openstack-dev | 16:00 | |
henrynash | ttx: do I need to do a cherry-pick -m to get m most recent from master - without -m it is complaining saying that my commit is merge... | 16:00 |
*** john5223 has quit IRC | 16:00 | |
*** nati_ueno has quit IRC | 16:00 | |
dtroyer | chmouel: oh no! I'm just working through the reasons for the separation I asked for. | 16:00 |
*** david2 has quit IRC | 16:00 | |
*** john5223 has joined #openstack-dev | 16:01 | |
chmouel | dtroyer: oh cool yeah, it does make sense | 16:01 |
henrynash | ttx: just being cautious, given where we are :-) | 16:01 |
ayoung | YorikSar, can you file a bug for this?> | 16:01 |
ttx | henrynash: I think the instructions at https://wiki.openstack.org/wiki/GerritJenkinsGithub#Authoring_Changes_for_milestone-proposed should be clear | 16:01 |
chmouel | dtroyer: and how do you feel about enabling swift by default? | 16:01 |
*** hemna has joined #openstack-dev | 16:01 | |
chmouel | dtroyer: we have it on jenkins | 16:01 |
chmouel | dtroyer: it act as objectstore for nova and give a storage system for cinder-backup | 16:01 |
ttx | henrynash: oh, you mean cherrypick the merge or the original commit ? | 16:01 |
ttx | henrynash: i'd say the merge, but you can ask on -infra if you have a doubt | 16:02 |
henrynash | ttx: so I am following those instructions (the Submit Changes in master to milestone-proposed section) | 16:02 |
dtroyer | chmouel: my main hesitation is just the overall size of the default install. I may be a bit behind the times trying to run devstack in a 1GB vm... | 16:03 |
henrynash | ttx: since mine is the last commit into master, I was using "git cherry-pick master" | 16:03 |
ttx | henrynash: that should work. I ususally use the SHA of the commit | 16:03 |
ttx | henrynash: I'll check that the change is the same anyway | 16:03 |
chmouel | dtroyer: we can try at first and see if we get 'devstack got OOM killed' before disabling it ? | 16:03 |
*** gary_th has quit IRC | 16:04 | |
*** crandquist has joined #openstack-dev | 16:04 | |
henrynash | ttx: for the SHA, can you use the short 7 digit number, or do you have to quote the very long one (!) | 16:04 |
*** garyTh has joined #openstack-dev | 16:05 | |
*** smulcahy has joined #openstack-dev | 16:05 | |
*** Tross has quit IRC | 16:05 | |
dtroyer | chmouel: the problems I saw were much more subtle than that ;) the gate runs swift by default already, that was my other concern. | 16:07 |
dtroyer | chmouel: let's go ahead and try it | 16:07 |
*** gyee has joined #openstack-dev | 16:07 | |
ttx | henrynash: short works | 16:07 |
ttx | (sorry, on a call) | 16:07 |
*** john5223 has quit IRC | 16:07 | |
*** monst_ has joined #openstack-dev | 16:08 | |
*** afazekas has quit IRC | 16:08 | |
dtroyer | chmouel: is there anything in that patch to handle the existing 'swift' in locarc ENABLED_SERVICES?? | 16:08 |
chmouel | dtroyer: i think I'll need to speak to infra first to ge this | 16:08 |
chmouel | dtroyer: no | 16:08 |
chmouel | dtroyer: this is failing http://logs.openstack.org/21104/5/check/gate-tempest-devstack-vm-full/4876/logs/localrc.txt.gz | 16:08 |
chmouel | dtroyer: i could add it | 16:08 |
chmouel | dtroyer: but i was understanding you prefered moving to s-* services instead of just swift | 16:08 |
dtroyer | chmouel: that may be why the test fails? they set 'swift' in ENABLED_SERVICES | 16:08 |
chmouel | dtroyer: yep | 16:09 |
dtroyer | chmouel: that's right but we have to handle backward-compatability for a while | 16:09 |
chmouel | dtroyer: totally +1 it :) | 16:09 |
chmouel | dtroyer: will rework the patch to add it | 16:09 |
*** john5223 has joined #openstack-dev | 16:10 | |
*** john5223 has quit IRC | 16:10 | |
dtroyer | chmouel: also change the 'sw-' in the commit message to 's-' | 16:10 |
*** john5223 has joined #openstack-dev | 16:10 | |
YorikSar | ayoung: https://review.openstack.org/22558 | 16:10 |
YorikSar | ayoung: It requires some tests, of course, but the approach should be clear. | 16:11 |
*** reidrac has quit IRC | 16:11 | |
*** terryh has quit IRC | 16:11 | |
*** adjohn has joined #openstack-dev | 16:11 | |
ayoung | YorikSar, it looks like it competes with the sql upgrade scripts, but it is generally the right idea. | 16:12 |
YorikSar | ayoung: The problem is that it will break once ProjectAPI or RoleAPI changes. | 16:12 |
ayoung | Ah... | 16:12 |
smulcahy | I've submitted a small patch to devstack to enable a new cinder service - https://review.openstack.org/#/c/22533 - is this the right place to solicit comments? | 16:13 |
smulcahy | or does devstack have its own channel? | 16:13 |
ayoung | I think that is OK...but it only should run once, and at a specified DB level | 16:13 |
topol | Hi YorikSar | 16:13 |
ayoung | YorikSar, what if instead of what you have there at line 56 | 16:13 |
*** mlavalle has joined #openstack-dev | 16:13 | |
YorikSar | ayoung: Well... With DB migrations every migration operates with a very specific set of 'old' and 'new' models. | 16:13 |
dtroyer | @smulcahy: this is it… I haven't looked at anythign new today yet, needing to rebuild my dev environments atm | 16:13 |
ayoung | you check for the role and exit | 16:14 |
ayoung | if the role doesn't exist, create it and drive on. | 16:14 |
*** apevec has quit IRC | 16:14 | |
topol | YorikSar, looking at https://review.openstack.org/22558 right now | 16:14 |
*** nati_ueno has joined #openstack-dev | 16:14 | |
topol | ayoung + 1 | 16:14 |
YorikSar | ayoung: We can't provide such snapshot of LDAP scruture definition because it depends. | 16:15 |
*** nati_ueno_2 has joined #openstack-dev | 16:15 | |
*** ondergetekende has quit IRC | 16:15 | |
*** nati_ueno_2 has quit IRC | 16:15 | |
ayoung | YorikSar, you didn't open a bug for the id to dn thing irhgt? | 16:15 |
ayoung | right | 16:15 |
YorikSar | ayoung, topol: What if this migration was called over LDAP tree already in use? We should migrate all members to role. | 16:15 |
YorikSar | ayoung: No, not yet. | 16:16 |
henrynash | ayoung: have you done a back port from master to, e.g., milestone proposed? Having some git issues (I don't seem to have a good record recently) | 16:16 |
*** nati_ueno_2 has joined #openstack-dev | 16:16 | |
ayoung | YorikSar, ok, I'll open it. I want to refer to it in the ocmmit message | 16:16 |
*** adjohn has quit IRC | 16:16 | |
gyee | ayoung, I mostly fine with the Trust API spec | 16:16 |
gyee | only concern I have is the endpoints | 16:16 |
ayoung | henrynash, nope. talk to heckj,or dolphm | 16:16 |
YorikSar | ayoung, topol: And if we ran it once and failed by some reason, the second run should finish the job. | 16:16 |
ayoung | gyee, I switched them back to Ids. I think that is right | 16:17 |
gyee | ayoung, +2 | 16:17 |
henrynash | heckj, dolphm: either of you on? | 16:17 |
dolphm | henrynash: yeah, what's the question? | 16:17 |
ayoung | gyee, everything else is IDs too | 16:17 |
*** john5223 has quit IRC | 16:17 | |
gyee | ayoung, sound good | 16:17 |
*** john5223 has joined #openstack-dev | 16:18 | |
openstackgerrit | A change was merged to openstack-dev/devstack: Remove ssh tests diabling as #1074039 is fixed https://review.openstack.org/22446 | 16:18 |
henrynash | dolphm: sorry, not having a good week with git :-) trying to follow the instructions at https://wiki.openstack.org/wiki/GerritJenkinsGithub#Authoring_Changes_for_milestone-proposed to back port a chaneg in master into the current milestone proposed (as agreed with tax) | 16:18 |
*** dhellmann has quit IRC | 16:18 | |
*** john5223 has quit IRC | 16:19 | |
henrynash | dolphm: Following the "Submit Changes in master to milestone-proposed sectin | 16:19 |
topol | YorikSar, ayoung, so my question is should we play it safe and I'll have the devstack LDAP code add the magic role explicitly as well or just rely on YorikSar's code? | 16:19 |
gyee | ayoung, just 4 more comments | 16:19 |
*** john5223 has joined #openstack-dev | 16:19 | |
henrynash | dolphm: that sequence doesn't seem to work for me…. | 16:20 |
YorikSar | topol: With empty LDAP my migration will just add that role. | 16:20 |
*** nati_ueno_2 has quit IRC | 16:20 | |
topol | YorikSar, in theory this will get into the codebase that devstack pulls down very quickly. So we should not have a gap where people are using devstack to install ldap and your patch is not in place. Does that make sense? | 16:21 |
topol | YorikSar, just making sure I did not overlook anything. | 16:22 |
*** Nachi has joined #openstack-dev | 16:23 | |
*** thingee_zzz is now known as thingee | 16:23 | |
*** colinmcnamara has joined #openstack-dev | 16:23 | |
topol | YorikSar, I can pull this patch down and try it with my existing devstack install code and see if all goes well | 16:23 |
*** beagles is now known as beagles|brb | 16:24 | |
YorikSar | topol: It will fail... | 16:25 |
topol | YorikSar, why? | 16:25 |
YorikSar | topol: It requires some cleanup after couple changes landed to master. | 16:25 |
ayoung | topol, YorikSar henrynash https://review.openstack.org/#/c/22561/ | 16:26 |
*** amotoki has quit IRC | 16:26 | |
YorikSar | topol: https://review.openstack.org/21664 - this one destroyed the ability to create something in LDAP | 16:26 |
topol | YorikSar, OK you want to ping me when you think it is ready and I will test it in a live setting? | 16:26 |
ayoung | topol, see my review to fix that, please comment | 16:26 |
*** nati_ueno has quit IRC | 16:27 | |
*** avishay has quit IRC | 16:27 | |
henrynash | dolphm: Main issue that the cherry-pick keeps failing….says it is a merge and needs -m, but using that does not work eitehr | 16:27 |
henrynash | dolphm: just don;t want to fall at the last hurdle here | 16:27 |
topol | ayoung, which review do I need to look at? | 16:28 |
*** donfoo has joined #openstack-dev | 16:28 | |
chmouel | ayoung, henrynash, dolphm: can we have a quick review on that https://review.openstack.org/#/c/22402/ please? | 16:28 |
topol | ayoung, 22561? | 16:28 |
*** john5223 has quit IRC | 16:28 | |
*** john5223 has joined #openstack-dev | 16:29 | |
*** donfoo is now known as dwt | 16:29 | |
YorikSar | topol: Yes | 16:29 |
*** dwt is now known as dwt2 | 16:29 | |
*** john5223 has quit IRC | 16:29 | |
*** Gordonz has quit IRC | 16:29 | |
dolphm | henrynash: sorry, was in a meeting -- reading back | 16:30 |
*** john5223 has joined #openstack-dev | 16:30 | |
henrynash | dolphm: np | 16:30 |
*** Gordonz has joined #openstack-dev | 16:30 | |
openstackgerrit | A change was merged to openstack/tempest: Handle error in test_create_get_delete_service https://review.openstack.org/22501 | 16:30 |
smulcahy | dtroyer: ok, well ping me if any questions when you get to it | 16:30 |
dolphm | henrynash: if cherry-pick fails, then you should be able to do a git status and see what files need to be resolved | 16:31 |
henrynash | dolphm: basically just trying to pull the last commit that went into master back into milestone proposed | 16:31 |
*** gongysh has quit IRC | 16:31 | |
henrynash | dolphm: I am suspicious that something is not right with my git setup | 16:32 |
*** danwent has joined #openstack-dev | 16:32 | |
dolphm | henrynash: can you link me to the patch on gerrit / github that you want to backport? | 16:32 |
henrynash | dolphm: its already in master - if you pull down master now, its the last commit | 16:33 |
*** gyee has quit IRC | 16:34 | |
*** markmcclain has quit IRC | 16:34 | |
henrynash | dolphm: ahh, lolling at the log on master, it shows a few merges the actual commit of my change 5 back…is it that one I have to cherry-pick? (This is the review: https://review.openstack.org/#/c/22515/) | 16:36 |
openstackgerrit | A change was merged to openstack-dev/devstack: Fix create_userrc.sh private key hang https://review.openstack.org/22500 | 16:37 |
*** john5223 has quit IRC | 16:37 | |
henrynash | dolphm: ah, ok, I think that;s it | 16:37 |
*** adjohn has joined #openstack-dev | 16:38 | |
*** avishay has joined #openstack-dev | 16:38 | |
*** john5223 has joined #openstack-dev | 16:38 | |
*** Nachi is now known as nati_ueno | 16:38 | |
*** gyee has joined #openstack-dev | 16:38 | |
*** dwt2 has quit IRC | 16:38 | |
*** john5223 has quit IRC | 16:38 | |
*** annegentle has quit IRC | 16:39 | |
henrynash | dolphm: Ok, thx, worked it out (finally!) | 16:39 |
*** john5223 has joined #openstack-dev | 16:39 | |
*** reed has joined #openstack-dev | 16:39 | |
henrynash | ttx: ok, have pushed the backport up for https://review.openstack.org/#/c/22515/ , do you want to check it looks ok? | 16:40 |
*** dontalton has joined #openstack-dev | 16:40 | |
*** diogogmt has joined #openstack-dev | 16:40 | |
gyee | henrynash, you finishing up the kvs and ldap backend? | 16:40 |
gyee | or should I finish that up? | 16:40 |
henrynash | gyeeL I''l do that…you did enough! | 16:41 |
gyee | henrynahs, thank you sir | 16:41 |
dolphm | gyee: i only skimmed through that commit since it was already approved, but can you just put the driver call into the manager instead of implementing it within the driver, or is it really backend-specific? | 16:41 |
henrynash | gyee: won't push that into g3, put it into rc1 | 16:41 |
ayoung | gyee, got em. thanks for picking those nits... | 16:41 |
ttx | henrynash: looking | 16:42 |
*** ayoung has quit IRC | 16:42 | |
*** esp1 has joined #openstack-dev | 16:42 | |
*** ayoung has joined #openstack-dev | 16:42 | |
ttx | henrynash: approved | 16:42 |
dolphm | gyee: validate token doesn't return an X-Subject-Token -- intentional? | 16:42 |
gyee | dolphm, make sense, should be any backend changes | 16:42 |
gyee | shouldn't be | 16:42 |
henrynash | ttx: great | 16:43 |
gyee | dolphm, yes, no need to | 16:43 |
gyee | user already have the token | 16:43 |
*** winston-d_ has joined #openstack-dev | 16:43 | |
*** afazekas has joined #openstack-dev | 16:43 | |
dolphm | gyee: "The Identity service will return the exact same response as when the subject token was issued by POST /auth." | 16:43 |
henrynash | ttx: shall I mark bug fix as released? | 16:44 |
*** gargya has quit IRC | 16:44 | |
gyee | dolphm, see redundant to return the same token | 16:44 |
gyee | seem | 16:44 |
ttx | henrynash: not yet. when the backport merges | 16:44 |
dolphm | henrynash: no, ttx does that when he cuts a release | 16:44 |
henrynash | ttx: marked as commited | 16:44 |
ttx | henrynash: I beat you to that :P | 16:45 |
henrynash | ttx: :-) | 16:46 |
*** john5223 has quit IRC | 16:47 | |
*** mkollaro has quit IRC | 16:48 | |
*** yolanda has quit IRC | 16:48 | |
*** john5223 has joined #openstack-dev | 16:48 | |
*** esp1 has quit IRC | 16:48 | |
*** Tross has joined #openstack-dev | 16:50 | |
*** alexpilotti has joined #openstack-dev | 16:50 | |
*** garyk has quit IRC | 16:51 | |
*** markwash has quit IRC | 16:51 | |
*** john5223 has quit IRC | 16:52 | |
*** yamahata has quit IRC | 16:53 | |
*** john5223 has joined #openstack-dev | 16:53 | |
*** beagles|brb is now known as beagles | 16:54 | |
*** Nachi has joined #openstack-dev | 16:54 | |
gyee | ayoung, trust API spec looks fine | 16:55 |
*** READ10 has quit IRC | 16:55 | |
*** mindpixel has quit IRC | 16:56 | |
*** nati_ueno has quit IRC | 16:56 | |
*** john5223 has quit IRC | 16:59 | |
*** zoresvit has quit IRC | 16:59 | |
*** john5223 has joined #openstack-dev | 17:00 | |
*** john5223 has quit IRC | 17:00 | |
openstackgerrit | A change was merged to openstack/glance: Extend the domain model to v2 image data https://review.openstack.org/22518 | 17:01 |
YorikSar | ayoung, dolphm: Are there any reason for keystone-manage to never setup logging? | 17:01 |
*** epim has joined #openstack-dev | 17:01 | |
*** john5223 has joined #openstack-dev | 17:01 | |
*** davidha has quit IRC | 17:02 | |
*** epim_ has joined #openstack-dev | 17:02 | |
*** jaypipes has quit IRC | 17:03 | |
*** hemna has quit IRC | 17:04 | |
*** john5223 has quit IRC | 17:04 | |
*** mkollaro has joined #openstack-dev | 17:05 | |
*** epim has quit IRC | 17:06 | |
*** epim_ is now known as epim | 17:06 | |
dolphm | YorikSar: no, i actually had a fix for it going a while back, it needs to be merged asap | 17:06 |
*** thingee is now known as thingee_zzz | 17:06 | |
dolphm | YorikSar: there's an open bug for it | 17:06 |
dolphm | henrynash: gyee: more test coverage for v3 is ready to go https://review.openstack.org/#/c/22497/ | 17:07 |
openstackgerrit | A change was merged to openstack/tempest: Expand read only cli compute test https://review.openstack.org/22508 | 17:07 |
*** njoy1__ has joined #openstack-dev | 17:07 | |
*** rafaduran has left #openstack-dev | 17:08 | |
*** njoy1__ has quit IRC | 17:08 | |
*** njoy1__ has joined #openstack-dev | 17:08 | |
*** njoy_ has quit IRC | 17:08 | |
gyee | dolphm, you mentioned 6 broken tests yesterday | 17:08 |
gyee | are they covered in 22497? | 17:08 |
*** gongysh has joined #openstack-dev | 17:11 | |
*** jaypipes has joined #openstack-dev | 17:11 | |
*** networkstatic has quit IRC | 17:12 | |
*** david4 has joined #openstack-dev | 17:13 | |
dolphm | gyee: yes, you fixed them by implementing domain-scoped tokens | 17:13 |
*** njoy1__ has quit IRC | 17:13 | |
dolphm | gyee: they all passed today, with a bit of conflict resolution | 17:13 |
*** dachary has quit IRC | 17:13 | |
*** koolhead17 has joined #openstack-dev | 17:14 | |
*** andreaf has quit IRC | 17:14 | |
*** markmcclain has joined #openstack-dev | 17:14 | |
*** andreaf has joined #openstack-dev | 17:15 | |
*** esp1 has joined #openstack-dev | 17:15 | |
gyee | dolphm, awesome, thanks for the additional tests | 17:15 |
*** jcmartin has joined #openstack-dev | 17:16 | |
*** tomoe_ has quit IRC | 17:17 | |
*** tomoe_ has joined #openstack-dev | 17:17 | |
*** dhellmann has joined #openstack-dev | 17:18 | |
*** hemna has joined #openstack-dev | 17:19 | |
*** nati_ueno has joined #openstack-dev | 17:20 | |
*** derekh has quit IRC | 17:20 | |
*** tomoe_ has quit IRC | 17:21 | |
*** pixelbeat has quit IRC | 17:22 | |
*** nati_ueno has quit IRC | 17:23 | |
*** nati_ueno has joined #openstack-dev | 17:23 | |
*** avishay has quit IRC | 17:24 | |
*** nati_ueno_2 has joined #openstack-dev | 17:24 | |
*** avishay has joined #openstack-dev | 17:25 | |
*** eglynn has quit IRC | 17:25 | |
*** devananda has quit IRC | 17:25 | |
*** devananda has joined #openstack-dev | 17:25 | |
*** nati_ueno has quit IRC | 17:28 | |
*** garyk has joined #openstack-dev | 17:28 | |
*** xga__ has joined #openstack-dev | 17:28 | |
*** xxiao has quit IRC | 17:32 | |
*** nsatterl_ has quit IRC | 17:32 | |
*** networkstatic has joined #openstack-dev | 17:32 | |
BLZbubba | any idea why horizon would time out trying to look up quota information? | 17:34 |
BLZbubba | my launch buttons just broke this morning for some reason | 17:35 |
*** hemna has quit IRC | 17:35 | |
BLZbubba | VariableDoesNotExist while rendering: Failed lookup for key [usages] in ........ | 17:36 |
*** doude has left #openstack-dev | 17:37 | |
*** terryh has joined #openstack-dev | 17:37 | |
*** amerine has joined #openstack-dev | 17:40 | |
*** avishay has quit IRC | 17:40 | |
*** SlickNik has joined #openstack-dev | 17:41 | |
*** jgallard has quit IRC | 17:41 | |
*** gael__ has quit IRC | 17:44 | |
*** john5223 has joined #openstack-dev | 17:45 | |
*** digitalsanctum has joined #openstack-dev | 17:45 | |
*** davidha has joined #openstack-dev | 17:45 | |
*** hemna has joined #openstack-dev | 17:46 | |
*** Ryan_Lane has joined #openstack-dev | 17:48 | |
*** njoy has joined #openstack-dev | 17:49 | |
*** gongysh has quit IRC | 17:49 | |
*** nunosantos has joined #openstack-dev | 17:50 | |
*** john5223 has quit IRC | 17:51 | |
smoser | anyone want to ack https://review.openstack.org/#/c/22452/ | 17:51 |
*** john5223 has joined #openstack-dev | 17:52 | |
*** kashyap has quit IRC | 17:52 | |
*** AnilV4 has quit IRC | 17:52 | |
*** john5223 has quit IRC | 17:53 | |
*** john5223 has joined #openstack-dev | 17:54 | |
*** jaypipes has quit IRC | 17:54 | |
*** markmc has quit IRC | 17:55 | |
*** trapni has quit IRC | 17:56 | |
*** jaypipes has joined #openstack-dev | 17:56 | |
*** lglenden has joined #openstack-dev | 17:57 | |
*** devoid has quit IRC | 17:57 | |
BLZbubba | OK my problem was nova-network, rabbitmqctl showed: network.os-master 114 | 17:59 |
*** terryh has quit IRC | 17:59 | |
*** torandu has quit IRC | 17:59 | |
flaper87 | dhellmann: ping | 18:00 |
flaper87 | dhellmann: do you have a second? | 18:00 |
*** Mandell has joined #openstack-dev | 18:00 | |
flaper87 | dhellmann: I'd like to discuss a bit this review https://review.openstack.org/#/c/20393/ | 18:00 |
*** troytoman-away is now known as troytoman | 18:00 | |
flaper87 | dhellmann: about decode / encode stuff | 18:01 |
*** john5223 has quit IRC | 18:01 | |
*** john5223 has joined #openstack-dev | 18:02 | |
*** dolphm has quit IRC | 18:03 | |
*** dolphm has joined #openstack-dev | 18:04 | |
*** torandu has joined #openstack-dev | 18:04 | |
*** torandu has quit IRC | 18:05 | |
*** afazekas has quit IRC | 18:08 | |
*** john5223 has quit IRC | 18:08 | |
*** john5223 has joined #openstack-dev | 18:09 | |
*** AnilV4 has joined #openstack-dev | 18:09 | |
*** kashyap has joined #openstack-dev | 18:09 | |
*** alexpilotti has quit IRC | 18:10 | |
*** markmcclain has quit IRC | 18:10 | |
*** winston-d_ has quit IRC | 18:10 | |
*** danwent has quit IRC | 18:11 | |
*** PaulCarlton has joined #openstack-dev | 18:11 | |
*** torandu has joined #openstack-dev | 18:11 | |
*** olaph has quit IRC | 18:13 | |
*** olaph has joined #openstack-dev | 18:14 | |
dhellmann | flaper87: pong | 18:14 |
*** cschwede has joined #openstack-dev | 18:14 | |
zykes- | Daviey: or zul do you guys have G3 packages yet ? | 18:14 |
*** Tross has quit IRC | 18:15 | |
*** john5223 has quit IRC | 18:15 | |
*** dolphm has quit IRC | 18:15 | |
*** PaulCarlton has quit IRC | 18:15 | |
flaper87 | dhellmann: hey | 18:15 |
flaper87 | dhellmann: so, about this review https://review.openstack.org/#/c/20393/ | 18:16 |
dhellmann | yeah | 18:16 |
*** john5223 has joined #openstack-dev | 18:16 | |
zul | zykes-: no | 18:16 |
*** alexpilotti has joined #openstack-dev | 18:16 | |
*** Nachi has quit IRC | 18:16 | |
*** PaulCarlton has joined #openstack-dev | 18:16 | |
*** dolphm has joined #openstack-dev | 18:16 | |
dhellmann | flaper87: my concern is that those functions are doing 2 things: converting types and "fixing" encoding | 18:17 |
openstackgerrit | A change was merged to openstack-dev/devstack: Fix aggregates exercise https://review.openstack.org/22553 | 18:17 |
openstackgerrit | A change was merged to openstack/python-novaclient: Missing import for gnomekeyring https://review.openstack.org/22568 | 18:17 |
openstackgerrit | A change was merged to openstack/quantum: Correct permissions on quantum-hyperv-agent https://review.openstack.org/22366 | 18:17 |
*** PaulCarlton has quit IRC | 18:17 | |
zykes- | zul: in the pipe or ? :) | 18:17 |
*** PaulCarlton has joined #openstack-dev | 18:17 | |
dhellmann | flaper87: the type conversion part feels wrong, because str({'key': 'value'}).encode('utf-8') is fundamentally different from just encoding the keys and values separately | 18:17 |
*** PaulCarlton has quit IRC | 18:17 | |
flaper87 | dhellmann: yep, that's a way to put it. I see it more like, ensure that an incoming object is encoded / decoded into ... | 18:18 |
*** ctracey has quit IRC | 18:18 | |
zul | zul: are they out yet? | 18:18 |
zul | zykes-: er...are they out yet? | 18:18 |
*** PaulCarlton has joined #openstack-dev | 18:18 | |
zykes- | zul: I just wondered :) | 18:18 |
*** afazekas has joined #openstack-dev | 18:18 | |
zykes- | guess now ;) | 18:18 |
zykes- | not. | 18:18 |
zul | zykes-: when they are out we will put them out | 18:18 |
flaper87 | dhellmann: The thing is, I would agree on checking whether it is actually instance of basestring bevore calling str, and let that str call part to the outsideworl | 18:18 |
flaper87 | world | 18:18 |
* dhellmann senses a "but" coming | 18:19 | |
*** PaulCarlton_ has joined #openstack-dev | 18:19 | |
*** jruzicka has quit IRC | 18:19 | |
flaper87 | that would be fair enough anyway, I didn't see it as a bad practice since there are objects implementing __str__ __unicode__ that could be easily passed to it | 18:19 |
flaper87 | but, like I said, I'm ok with taking that str() part off and check for isinstance | 18:20 |
dhellmann | ok, cool | 18:20 |
dhellmann | if you do that, I'll be happy with it. maybe the names should be changed to reflect that the functions are really dealing with encoding? or not | 18:20 |
*** john5223 has quit IRC | 18:21 | |
*** john5223 has joined #openstack-dev | 18:21 | |
flaper87 | dhellmann: yep, we could rename those into encode_uncode and decode_str or something like that | 18:21 |
* flaper87 is not good with name | 18:22 | |
*** john5223 has quit IRC | 18:22 | |
*** PaulCarlton_ has quit IRC | 18:22 | |
* flaper87 will use a placeholder as a name if he ever becomes father | 18:22 | |
*** john5223 has joined #openstack-dev | 18:22 | |
dhellmann | flaper87: how about ensure_unicode -> safe_decode and ensure_str -> safe_encode | 18:23 |
*** xga__ has quit IRC | 18:23 | |
*** john5223 has quit IRC | 18:23 | |
*** john5223 has joined #openstack-dev | 18:23 | |
*** READ10 has joined #openstack-dev | 18:24 | |
*** bencherian has quit IRC | 18:24 | |
flaper87 | dhellmann: makes sense | 18:24 |
flaper87 | dhellmann: thanks :) | 18:24 |
*** andrewbogott_afk is now known as andrewbogott | 18:26 | |
openstackgerrit | A change was merged to openstack/cinder: Fix various exception paths https://review.openstack.org/22433 | 18:26 |
*** giroro_ has joined #openstack-dev | 18:29 | |
*** markmcclain has joined #openstack-dev | 18:29 | |
dhellmann | flaper87: thanks for being flexible! :-) | 18:30 |
*** armaan1 has joined #openstack-dev | 18:30 | |
*** zing has quit IRC | 18:30 | |
flaper87 | dhellmann: whatever is best for the project ;) | 18:30 |
*** bourke_ has joined #openstack-dev | 18:31 | |
*** johnthetubaguy has quit IRC | 18:31 | |
*** hyakuhei has quit IRC | 18:31 | |
openstackgerrit | A change was merged to openstack/quantum: Close file descriptors when executing sub-processes https://review.openstack.org/22486 | 18:31 |
*** jgallard has joined #openstack-dev | 18:32 | |
dhellmann | flaper87: indeed :-) | 18:32 |
*** armaan has quit IRC | 18:32 | |
*** Ruetobas has quit IRC | 18:32 | |
*** bourke has quit IRC | 18:32 | |
*** techlife has quit IRC | 18:32 | |
*** alunduil has quit IRC | 18:32 | |
*** devananda has quit IRC | 18:33 | |
*** techlife has joined #openstack-dev | 18:33 | |
*** alexpilotti has quit IRC | 18:33 | |
topol | ayoung, you should be good to go on 22561 if dolph bumps his +1 to a +2 | 18:33 |
*** devananda has joined #openstack-dev | 18:33 | |
*** alunduil has joined #openstack-dev | 18:34 | |
*** john5223 has quit IRC | 18:34 | |
*** techlife has joined #openstack-dev | 18:34 | |
*** hemna has quit IRC | 18:34 | |
*** john5223 has joined #openstack-dev | 18:34 | |
*** techlife has joined #openstack-dev | 18:34 | |
openstackgerrit | A change was merged to openstack/quantum: Imported Translations from Transifex https://review.openstack.org/22382 | 18:35 |
*** techlife has joined #openstack-dev | 18:35 | |
*** jgallard has quit IRC | 18:35 | |
*** techlife has joined #openstack-dev | 18:35 | |
*** techlife has joined #openstack-dev | 18:36 | |
*** danpb has quit IRC | 18:36 | |
*** yolanda has joined #openstack-dev | 18:36 | |
*** techlife has joined #openstack-dev | 18:36 | |
*** john5223 has quit IRC | 18:37 | |
ayoung | dolphm, can you bless/bleed on https://review.openstack.org/#/c/22063/ | 18:37 |
*** john5223 has joined #openstack-dev | 18:37 | |
*** eglynn has joined #openstack-dev | 18:39 | |
ayoung | topol, I consider a +1 from both you and YorikSar the equivalent of a +2 from core. Pushed the button to merge | 18:43 |
*** john5223 has quit IRC | 18:44 | |
*** bencherian has joined #openstack-dev | 18:44 | |
*** eglynn has quit IRC | 18:44 | |
ayoung | topol, I hope you are starting to appreciate the value of your LDAP devstack fix. The next step is getting LDAP support wiried up in tempest | 18:45 |
*** john5223 has joined #openstack-dev | 18:45 | |
kmartin | is anyone using PyCharm for OpenStack developement? | 18:45 |
ayoung | kmartin, I use PyDev (eclipse) | 18:45 |
flaper87 | kmartin: there's a good post out there explaining how to use pycharm with openstack | 18:46 |
* flaper87 looks for it | 18:46 | |
*** pcm___ has joined #openstack-dev | 18:47 | |
flaper87 | kmartin: https://tropicaldevel.wordpress.com/2013/01/24/debugging-openstack-with-pycharm-and-pydevd/ | 18:47 |
flaper87 | dunno if that helps | 18:47 |
* flaper87 uses vim + pdb | 18:47 | |
kmartin | flaper87: thanks...I see jetbrains is offering it free for OpenStack contributors | 18:47 |
*** flaper87 has quit IRC | 18:47 | |
*** john5223 has quit IRC | 18:47 | |
kmartin | just wondering if it's worth leaving vi? :) | 18:48 |
*** john5223 has joined #openstack-dev | 18:48 | |
*** pcm_ has quit IRC | 18:48 | |
*** joshuamckenty has joined #openstack-dev | 18:49 | |
*** Yada has quit IRC | 18:50 | |
*** nati_ueno_2 has quit IRC | 18:50 | |
*** spzala has joined #openstack-dev | 18:50 | |
*** nati_ueno has joined #openstack-dev | 18:50 | |
*** hemna has joined #openstack-dev | 18:50 | |
*** kagan has joined #openstack-dev | 18:51 | |
*** dachary has joined #openstack-dev | 18:52 | |
openstackgerrit | A change was merged to openstack/glance: Add migration 19 - move image location data https://review.openstack.org/20926 | 18:53 |
openstackgerrit | A change was merged to openstack/glance: Add migration 20 - drop images.location https://review.openstack.org/20927 | 18:54 |
*** john5223 has quit IRC | 18:54 | |
*** ek6 has joined #openstack-dev | 18:54 | |
*** john5223 has joined #openstack-dev | 18:55 | |
*** nati_ueno has quit IRC | 18:55 | |
*** lglenden has quit IRC | 18:57 | |
*** mmagr has quit IRC | 18:57 | |
*** annegentle has joined #openstack-dev | 18:57 | |
*** mrodden has joined #openstack-dev | 18:59 | |
*** joshuamckenty has quit IRC | 19:01 | |
*** john5223 has quit IRC | 19:01 | |
*** boris-42 has joined #openstack-dev | 19:02 | |
*** afazekas has quit IRC | 19:03 | |
*** ctracey has joined #openstack-dev | 19:03 | |
*** ctracey has quit IRC | 19:03 | |
*** roampune has joined #openstack-dev | 19:03 | |
*** john5223 has joined #openstack-dev | 19:04 | |
*** unix has quit IRC | 19:04 | |
*** baba has joined #openstack-dev | 19:04 | |
*** agentle_ has joined #openstack-dev | 19:05 | |
*** dachary has quit IRC | 19:06 | |
*** dachary has joined #openstack-dev | 19:06 | |
*** ctracey` has joined #openstack-dev | 19:06 | |
*** FatDarrel has joined #openstack-dev | 19:06 | |
*** psedlak has quit IRC | 19:07 | |
*** annegentle has quit IRC | 19:08 | |
*** agentle_ is now known as annegentle | 19:08 | |
*** john5223 has quit IRC | 19:08 | |
*** john5223 has joined #openstack-dev | 19:09 | |
*** Tross has joined #openstack-dev | 19:10 | |
dolphm | ayoung: reviewed the trust api ... i'm not sure if you meant to step on the toes of impersonation or not, but either the language needs to be revised or the spec needs to make impersonation opt-in | 19:11 |
ayoung | dolphm, "impersonation"? | 19:11 |
ayoung | line? | 19:12 |
dolphm | ayoung: cited at least two sentences that suggest that the token should be nearly indistinguishable from the trustor's identity, and not directly represent the trustee's identity | 19:12 |
dolphm | ayoung: there's a massive security difference between "i have been authorized to act on this user's behalf" vs "i have been authorized to act as this user" | 19:13 |
*** openstackjenkins has quit IRC | 19:14 | |
ayoung | dolphm, OK...so you are right in that it represents impoersonation. THat was discussed. THe reason is that otherwise, everything that accepts a token would have to be modified to now look at a different fiedl (trustor) | 19:14 |
ayoung | dolphm, this is the second | 19:14 |
ayoung | and it is due to the way that assets are owned | 19:14 |
*** openstackjenkins has joined #openstack-dev | 19:14 | |
dolphm | ayoung: i think it'd be awesome to support impersonation, but it needs to be opt-in | 19:14 |
ayoung | dolphm, opt in by whom? | 19:14 |
dolphm | ayoung: the trustor | 19:14 |
ayoung | only the user can create the trust | 19:14 |
*** john5223 has quit IRC | 19:14 | |
ayoung | only the trustor can create a trust | 19:15 |
ayoung | It is explicitly opt in | 19:15 |
ayoung | not even an admin has that power | 19:15 |
*** devoid has joined #openstack-dev | 19:15 | |
dolphm | ayoung: yes, but you're defaulting a trust to mean delegation+impersonation rather than just delegation | 19:15 |
*** Ryan_Lane has quit IRC | 19:15 | |
*** mkollaro has quit IRC | 19:15 | |
*** cp16net|away is now known as cp16net | 19:16 | |
ayoung | dolphm, ...so you want an option to say give the roles etc to the user, but use their own ID as the user_id in the token...I can accept that. | 19:16 |
ayoung | dolphm, so...a boolean field on the trust "impersonate" ? | 19:17 |
*** Ryan_Lane has joined #openstack-dev | 19:17 | |
*** morganfainberg has joined #openstack-dev | 19:17 | |
dolphm | ayoung: yeah, just "allow_impersonation" defaulting to false when creating the token | 19:17 |
ayoung | defaults to false? | 19:17 |
gyee | ayoung, what if trustor got fired? the Terry Child feature :) | 19:17 |
FatDarrel | Anyone here running packstack? | 19:17 |
ayoung | gyee, then the trust is useless | 19:17 |
dolphm | gyee: trust should be deleted when the trustor is deleted? | 19:17 |
ayoung | gyee, trust only allows access to what the trustor has at token creation time | 19:17 |
ayoung | even if the trust is still active, the trusto has nothing to give, and token create fails | 19:17 |
gyee | admin should at least allowed to delete the trust right? | 19:18 |
ayoung | gyee, I changed that | 19:18 |
ayoung | admin can delete trust, just not create | 19:18 |
gyee | ayoung, I am fine with that | 19:19 |
ayoung | coo | 19:19 |
ayoung | dolphm, ok, I like the impersonate flag. But the thing is, a trust is fixed, so you have to decide when creating a trust whether to do impersonation or not. I don't want to call it 'allow' as that implies a decision | 19:19 |
dolphm | ayoung: if i have an impersonated token, keystone needs to be careful about issuing a real token back to the trustee as a result of token auth | 19:20 |
ayoung | dolphm, trust token cannot get another token | 19:20 |
dolphm | ayoung: ah, a decision on the part of the trustee when consuming a trust? | 19:20 |
ayoung | dolphm, right | 19:20 |
FatDarrel | what do you guys do with selinux do yo guys enable it or disable it | 19:20 |
dolphm | ayoung: good point | 19:20 |
dolphm | ayoung: "include_impersonation" ? | 19:20 |
fungi | just a heads up to everyone, we're planning to shut down zuul and jenkins in a few minutes for some short-notice security updates, in case anybody happens to notice checks/merges being delayed | 19:20 |
dolphm | ayoung: "enable_impersonation" | 19:21 |
ayoung | dolphm, how about just 'impersonate'? | 19:21 |
dolphm | ayoung: i'm struggling to use that attribute in a sentence naturally | 19:21 |
gyee | dolphm, why do we need that flag as the trust information is already there in the token data? | 19:21 |
dolphm | gyee: because of the security differences between acting on a user's behalf and acting AS that user | 19:22 |
ayoung | dolphm, the 'impoersonate' attributes that when the trust is used to create a token, the trustee will impersonate the trustor | 19:22 |
*** imsplitbit has joined #openstack-dev | 19:22 | |
dolphm | gyee: i'm down with supporting impersonation -- i think it's awesome, but impersonation shouldn't be opt-out... that's all | 19:22 |
ayoung | or | 19:22 |
ayoung | gyee, it makes sense for some operations where I need to give you access to my project, but then the operations are tracked as you, not as me. | 19:23 |
dolphm | ayoung: "the trust enables impersonation, so the trustee is cloaked by the system as the trustor" | 19:24 |
ayoung | Whereas, with swift, you probably need to impersonate me to get access to the objects I've written | 19:24 |
ayoung | clocked->recorded | 19:24 |
dolphm | ayoung: clocked? | 19:24 |
ayoung | overclocked | 19:24 |
ayoung | did I go off half-cocked? | 19:25 |
dolphm | ayoung: cloaked as in bruce wayne disguised as batman | 19:25 |
ayoung | And the Joker got clocked! | 19:26 |
ayoung | POW! | 19:26 |
gyee | ha | 19:26 |
ayoung | dolphm, so...I can add in that field. I need to do the following as well | 19:26 |
ayoung | merge with the filter policy changes | 19:27 |
ayoung | get a policy that works for list_users | 19:27 |
ayoung | (list users with filter is working bbut needs more unit tests) | 19:27 |
ayoung | and...I'd like to hack this on to the V3 Auth API | 19:27 |
*** ChanServ sets mode: +o jeblair | 19:27 | |
ayoung | I'm thinking, though, that V2 should be the first patch, with v3 support in a follow on patch | 19:28 |
gyee | ayoung, that flag is part of user? | 19:28 |
dolphm | ayoung: sounds good -- can i help with testing list users? | 19:28 |
*** garyTh has quit IRC | 19:28 | |
dolphm | ayoung: what are attribute are you wanting to filter by? | 19:28 |
zykes- | dolphm: will v3 stuff land for G? | 19:28 |
dolphm | zykes-: landed | 19:28 |
ayoung | dolphm, either trustee_user_id or trustor_user_id...as henrynash suggested | 19:28 |
*** jeblair changes topic to "Jenkins and Zuul are shutting down for an emergency security-related upgrade. ETA 20:00 UTC." | 19:28 | |
jeblair | Jenkins and Zuul are shutting down for an emergency security-related upgrade. ETA 20:00 UTC. | 19:29 |
ayoung | dolphm, I am having, I think ,a merge problem with the filter..our changes are too similar, and henrynash 's changes and mine have become one due to an overzeolus git | 19:29 |
zykes- | dolphm: what's all the fuzz going on now then ? :p | 19:29 |
ayoung | let me untangle that and I'll repost, without the impersonate flag | 19:29 |
ayoung | gyee, impoersonate will be aflag on the tryust itself, and will be passed in to trusst create. | 19:30 |
dolphm | zykes-: impersonation and delegation features are on a FFE | 19:30 |
zykes- | ah | 19:30 |
*** nsatterl_ has joined #openstack-dev | 19:30 | |
*** spzala_ has joined #openstack-dev | 19:30 | |
dolphm | ayoung: when is your FFE until? | 19:31 |
ayoung | FFE? | 19:31 |
*** spzala has quit IRC | 19:31 | |
*** spzala_ is now known as spzala | 19:31 | |
dolphm | ayoung: feature freeze extension | 19:31 |
*** soren has quit IRC | 19:31 | |
ayoung | COB tomorrow | 19:31 |
*** soren has joined #openstack-dev | 19:31 | |
gyee | wow | 19:31 |
*** Tross has quit IRC | 19:32 | |
ayoung | gyee, well, they took pity on me since V3 Auth was taking so much attention | 19:32 |
zykes- | ayoung: COB ? | 19:32 |
ayoung | Close of Buisnes | 19:32 |
ayoung | s | 19:32 |
zykes- | ok :p | 19:32 |
ayoung | EIEIO! | 19:32 |
zykes- | getting to land it all before it ayoung ? :p | 19:32 |
gyee | ayoung, I need to be offline for an hour or so | 19:34 |
ayoung | gyee, NP...I'm headed back into code mode | 19:34 |
gyee | will review your new patch in the afternoon | 19:34 |
*** gyee has quit IRC | 19:35 | |
*** jeblair changes topic to "Jenkins and Zuul are down for an emergency security-related upgrade. ETA 20:00 UTC." | 19:36 | |
jeblair | Jenkins and Zuul are down for an emergency security-related upgrade. ETA 20:00 UTC. | 19:36 |
*** burris has quit IRC | 19:37 | |
*** mdomsch has joined #openstack-dev | 19:38 | |
vishy | garyk: noticed the following bug: https://bugs.launchpad.net/nova/+bug/1131358 | 19:38 |
uvirtbot | Launchpad bug 1131358 in nova "LibvirtHybridOVSBridgeDriver crashes when spawning an instance with NoopFirewallDriver" [High,New] | 19:38 |
vishy | garyk: have someone working on it, just want to make sure that is a valid configuration | 19:38 |
*** markwash has joined #openstack-dev | 19:38 | |
ayoung | dolphm, OK, I think I sortedthe policy failure. I'm going to repost. It won't have the impersonate flag, and policy will be imcomplete, but you should be able to see the list_trust functions | 19:39 |
*** openstackjenkins has quit IRC | 19:39 | |
ayoung | just running tests and pep8int | 19:39 |
*** openstackjenkins has joined #openstack-dev | 19:40 | |
*** darraghb has quit IRC | 19:43 | |
*** joshuamckenty has joined #openstack-dev | 19:44 | |
*** openstackjenkins has quit IRC | 19:44 | |
*** bearovercloud has joined #openstack-dev | 19:45 | |
*** openstackjenkins has joined #openstack-dev | 19:45 | |
*** Tross has joined #openstack-dev | 19:45 | |
*** Ryan_Lane has quit IRC | 19:45 | |
*** Ryan_Lane has joined #openstack-dev | 19:46 | |
*** armaan1 has left #openstack-dev | 19:47 | |
ttx | ayoung: you can push until Tuesday COB, I won't be here to punish you | 19:48 |
*** joshuamckenty has quit IRC | 19:48 | |
*** FatDarrel has quit IRC | 19:49 | |
ayoung | ttx, I hate it when deadlines get extended....now I have no excuse not to pull an all nighter tonight | 19:49 |
*** cschwede has quit IRC | 19:49 | |
ttx | dolphm: will push g3 in 90min if no bug gets targeted to grizzly-3 in the mean time | 19:49 |
ayoung | ttx, plus, you just let everyone know....they are going to beat me up on the playground and take my lunch money | 19:50 |
ttx | dolphm: I think we have all we want in | 19:50 |
ayoung | ttx, there is something inthe queue we wnt for g3... | 19:50 |
ttx | ayoung: you could show them how you nail FFEs. In one day. | 19:50 |
ayoung | https://review.openstack.org/#/c/22561/ | 19:50 |
*** colinmcnamara has quit IRC | 19:50 | |
ttx | ayoung: ah. linking to g3 then | 19:50 |
ayoung | ttx, without that, LDAP is broken. I missed a critical mistake in the review that should have raised a red flag. | 19:51 |
*** Birk_ has joined #openstack-dev | 19:51 | |
*** garyTh has joined #openstack-dev | 19:51 | |
ttx | ayoung: backport to milestone-proposed when it lands in master | 19:51 |
ayoung | ttx, wilco | 19:51 |
dolphm | ayoung: this fixes a couple bugs in v3 auth that should go in as well https://review.openstack.org/#/c/22497/ | 19:51 |
dolphm | ttx: i didn't target those two bugs to anything ^ | 19:51 |
ttx | ayoung: when you want me to block g3 on something, add it to the grizzly-3 targets | 19:52 |
ayoung | ttx, understood | 19:52 |
ttx | dolphm: doing it for you | 19:52 |
Birk_ | I changed my controller hostname and now the nova-manage service list command shows obsolet entries. How can I remove them? Any one know what is the database table that I must update? | 19:53 |
ttx | dolphm: please backport to milestone-proposed when in master | 19:53 |
*** jeblair changes topic to "OpenStack development || Support is in #openstack" | 19:53 | |
dolphm | ttx: will do | 19:53 |
jeblair | Jenkins and Zuul are back up | 19:53 |
*** nsatterl_ has quit IRC | 19:53 | |
jeblair | If you approved any changes during the downtime, you'll need to reapprove them (or leave a 'reverify no bug' comment) | 19:54 |
*** FatDarrel has joined #openstack-dev | 19:55 | |
*** bswartz has quit IRC | 19:55 | |
*** Birk_ has quit IRC | 19:56 | |
*** FatDarrel has quit IRC | 19:57 | |
*** stevebaker has joined #openstack-dev | 19:57 | |
*** dontalton has quit IRC | 19:59 | |
*** bearovercloud is now known as jz | 19:59 | |
*** maoy has joined #openstack-dev | 20:00 | |
*** FatDarrel has joined #openstack-dev | 20:00 | |
*** bswartz has joined #openstack-dev | 20:00 | |
*** jz is now known as Guest26236 | 20:00 | |
*** Guest26236 is now known as jsn | 20:01 | |
*** jsn is now known as zs | 20:01 | |
*** danwent has joined #openstack-dev | 20:02 | |
*** davidkranz has quit IRC | 20:02 | |
*** jeblair is now known as corvus | 20:02 | |
*** zs has left #openstack-dev | 20:02 | |
*** corvus is now known as jeblair | 20:03 | |
*** stevebaker has quit IRC | 20:03 | |
*** stevebaker has joined #openstack-dev | 20:03 | |
anteaya | zul: are you familiar with how the ubuntu-cloud-archive nova package are set up? | 20:04 |
*** vipul is now known as vipul|away | 20:04 | |
ayoung | ttx, https://review.openstack.org/#/c/22561/ is not showing up in zuul. | 20:04 |
zul | anteaya: yes | 20:04 |
*** gray-- has quit IRC | 20:04 | |
*** davidkranz has joined #openstack-dev | 20:04 | |
anteaya | a user in #openstack is getting an error around the nova-api not being found | 20:04 |
ayoung | ttx, did something change with the gating? There is very little in the queue now? | 20:05 |
anteaya | zul his name is swinchen if you could help | 20:05 |
anteaya | thanks | 20:05 |
*** zs has joined #openstack-dev | 20:05 | |
*** nsatterl_ has joined #openstack-dev | 20:06 | |
*** colinmcnamara has joined #openstack-dev | 20:07 | |
*** crandquist has quit IRC | 20:08 | |
garyk | vishy: ping | 20:08 |
*** zs has quit IRC | 20:08 | |
vishy | garyk: sup? | 20:08 |
*** zs has joined #openstack-dev | 20:08 | |
garyk | vishy: hi, regarding the Noop. I think I fixed it. | 20:09 |
vishy | garyk: oh? cburgess has a fix already | 20:09 |
*** zaitcev has joined #openstack-dev | 20:09 | |
sdague | ayoung: there is a queue restart | 20:09 |
*** zs has quit IRC | 20:09 | |
garyk | vishy: https://review.openstack.org/#/c/22136/ | 20:09 |
vishy | garyk: no that is a different review | 20:10 |
vishy | different bug | 20:10 |
vishy | and for stable/folsom | 20:10 |
*** zs has joined #openstack-dev | 20:10 | |
vishy | this one is for trunk | 20:10 |
vishy | garyk: https://review.openstack.org/#/c/22590/ | 20:10 |
garyk | vishy: oh, ok, my bad. sorry | 20:10 |
garyk | vishy: i was under the assumption that it worked in trunk. sorry | 20:10 |
*** zs has quit IRC | 20:10 | |
vishy | well it did | 20:10 |
vishy | it just broke recently | 20:11 |
vishy | hence the question about whether it was valid | 20:11 |
vishy | since the other was using a different vif driver | 20:11 |
garyk | vishy: good question. my latest testing has been with the quantum sec groups. | 20:12 |
cburgess | garyk: Yeah sorry about that, missed a line. | 20:12 |
garyk | i'll make sure to add this to my radar. | 20:12 |
garyk | cburgess: thanks for fixing | 20:12 |
cburgess | garyk: Well I broke it so only fair I fix it. | 20:13 |
*** thingee_zzz is now known as thingee | 20:13 | |
garyk | cburgess: :) | 20:13 |
garyk | vishy: there is another quantum issue - https://review.openstack.org/#/c/22546/. can you please take a look - i guess we should set it for rc-1 if possible. | 20:14 |
topol | ayoung, do trust provide functionality similar to oauth? | 20:14 |
*** sandywalsh has quit IRC | 20:15 | |
*** zs has joined #openstack-dev | 20:15 | |
*** davidkranz_ has joined #openstack-dev | 20:16 | |
vishy | eeww that is messy | 20:16 |
vishy | garyk: can we not set dhcp_server properly? | 20:17 |
garyk | vishy: not exactly sure that i follow. yes, the patch is ugly | 20:17 |
*** davidkranz has quit IRC | 20:17 | |
*** zs has quit IRC | 20:18 | |
vishy | garyk: we already have an exept rule for dhcp traffic | 20:18 |
vishy | as long as the network value for ['dhcp_server'] is set properly | 20:18 |
*** zs has joined #openstack-dev | 20:18 | |
topol | YorikSar, is https://review.openstack.org/22558 going to make it in? | 20:18 |
*** zs has quit IRC | 20:19 | |
vishy | garyk: got to head out for a bit. Commented on the review | 20:19 |
ayoung | topol, if I knew oauth well enough I could answer that. Can you restate the question? | 20:20 |
garyk | vishy: ok, thanks! | 20:20 |
*** dims has quit IRC | 20:20 | |
*** bearovercloud has joined #openstack-dev | 20:21 | |
*** bearovercloud is now known as zs | 20:21 | |
*** zs is now known as zz | 20:21 | |
*** zz is now known as zs | 20:22 | |
*** zs is now known as zzs | 20:23 | |
*** davidkranz has joined #openstack-dev | 20:23 | |
topol | ayoung, so OAuth is a standard that provides a method for clients to access server resources on behalf of a resource owner (such as a different client or an end-user). It also provides a process for end-users to authorize third-party access to their server resources without sharing their credentials (typically, a username and password pair). Seems similar to trusts | 20:23 |
*** zzs has quit IRC | 20:23 | |
ayoung | topol, yes, it does sound similar | 20:23 |
*** dims has joined #openstack-dev | 20:23 | |
*** zzs has joined #openstack-dev | 20:23 | |
*** davidkranz_ has quit IRC | 20:23 | |
ayoung | topol, also s4u2proxy in Kerberos, which was the inspriration | 20:24 |
topol | ayoung, perhaps a topic to discuss in portland. | 20:24 |
ayoung | sure | 20:24 |
*** zzs has quit IRC | 20:24 | |
*** bswartz has quit IRC | 20:25 | |
openstackgerrit | A change was merged to openstack/nova: Add snapshot methods to fakes.py https://review.openstack.org/22343 | 20:25 |
*** zzs has joined #openstack-dev | 20:25 | |
*** pcm___ has quit IRC | 20:26 | |
*** zzs has left #openstack-dev | 20:26 | |
*** colinmcnamara has quit IRC | 20:26 | |
*** aeperezt has quit IRC | 20:29 | |
*** davidkranz has quit IRC | 20:31 | |
*** sandywalsh has joined #openstack-dev | 20:31 | |
*** davidkranz has joined #openstack-dev | 20:31 | |
*** henrynash_ has joined #openstack-dev | 20:33 | |
*** davidkranz has quit IRC | 20:33 | |
*** jrodom has joined #openstack-dev | 20:34 | |
*** sandywalsh has quit IRC | 20:35 | |
*** FatDarrel has quit IRC | 20:35 | |
*** henrynash has quit IRC | 20:35 | |
*** henrynash_ is now known as henrynash | 20:35 | |
*** colinmcnamara has joined #openstack-dev | 20:36 | |
openstackgerrit | A change was merged to openstack/python-keystoneclient: Fix selef to self in class. https://review.openstack.org/22402 | 20:37 |
*** yolanda has quit IRC | 20:38 | |
topol | ayoung, do you have a sense whether YorikSar's migration code will get merged in soon? | 20:39 |
ayoung | topol, It should probably go in to grizzly as a bug fix, but not into G3. | 20:40 |
topol | ayoung, how about for folks that use devstack? That pulls from head so it could show up there pretty soon correct? | 20:41 |
ayoung | topol, the more I think about it, the more I think that we should not have to do that migration for LDAP. | 20:42 |
*** baba is now known as unix | 20:42 | |
ayoung | I mean, yes, for an existing ldap | 20:42 |
ayoung | but not moving forward. Devstack should not need it | 20:42 |
ayoung | My mind is focused on another task right now | 20:42 |
ayoung | but... | 20:42 |
*** riskable has quit IRC | 20:42 | |
topol | ayoung, don't worry about it. | 20:42 |
*** bswartz has joined #openstack-dev | 20:43 | |
*** riskable has joined #openstack-dev | 20:43 | |
ayoung | that API (add_user_to_project) should be deprecated. I assume (without looking) that it is called by add user | 20:43 |
ayoung | but...it doesn't need to be. let me look | 20:43 |
ayoung | if default_tenant_id: | 20:44 |
ayoung | self.identity_api.add_user_to_project(context, | 20:44 |
ayoung | default_tenant_id, user_id) | 20:44 |
ayoung | ok....so what do we do about that... | 20:44 |
*** Tross has quit IRC | 20:44 | |
*** adalbas has quit IRC | 20:44 | |
ayoung | Ifor devstack, if the role already exists, this just works, no migration necessary | 20:45 |
openstackgerrit | A change was merged to openstack/glance: Update oslo-config version. https://review.openstack.org/22473 | 20:45 |
ayoung | for an existing LDAP, run the migration.... | 20:45 |
*** dolphm has quit IRC | 20:45 | |
ayoung | topol, go ahead and submit a patch to devstack to create the role by default. | 20:45 |
ayoung | that makes sense for LDAP support coming out of the box...or does it? | 20:46 |
topol | ayoung, I think you need it for out of box. I'm creating the subtrees might as well create one extra little role | 20:47 |
ayoung | topol, what do you think? THe more I ponder, the more I realize ther are no right answers. Generating the role on the fly is fine for writable LDAP servers. For readable ones...nothing we can do. | 20:47 |
ayoung | topol, OK. It is a trivial change, and necessary | 20:47 |
ayoung | no migration required | 20:47 |
ayoung | I'm wondering, though ,if we should do the lazy creation of that role after all | 20:48 |
*** pnavarro has quit IRC | 20:48 | |
ayoung | I mean, it is on a read/write data store anyway, so...since we have to maintain the legacy api. I mean, we'll need migration, too, to move members to role assignments. | 20:49 |
topol | ayoung, I thought for readable ones we decided they probably would have their own roles already setup and we just mapped it to an existing role. The lazy creation was for when you have a production ldap where you are permitted to write to it. Those may be rare but a few | 20:49 |
*** novas0x2a|laptop has joined #openstack-dev | 20:50 | |
*** jaybuff has joined #openstack-dev | 20:50 | |
*** jaybuff has left #openstack-dev | 20:51 | |
topol | ayoung, I will say that having to create it manually is a pain and you have to get it correct. So from a consumability perspective its nice to have. Especially since the client does not allow you to create that role and specify the role-id that you need to match what is in the keystone.conf file | 20:52 |
YorikSar | I'm back. | 20:52 |
*** njoy_ has joined #openstack-dev | 20:52 | |
YorikSar | ayoung: We are not doing this on the fly. db_sync runs once in the deployment process. | 20:52 |
topol | ayoung, so even if its a 5% use case the migrate will save us a lot of serviceability calls | 20:53 |
YorikSar | ayoung: So it can mandate existence of this role or try to create it and fail for readonly LDAP with some meaningful message. | 20:53 |
topol | ayoung, so for folks that distribute OS (and have to service it) its better safe than sorry | 20:53 |
topol | YorikSar, +1 | 20:54 |
ayoung | I wantr the migration, too...just need to test it | 20:54 |
YorikSar | topol: Why doesn't client allow to create this role? | 20:54 |
YorikSar | ayoung: I've run it over my OpenLDAP, it worked, even (buzzword alarm) idempotent. | 20:55 |
*** annegentle has quit IRC | 20:55 | |
topol | YorikSar, chicken and egg. You create the role but keystone.cong is already loaded into memory so you can't go in and update the conf file with the role-id that was randomly chosen for you | 20:55 |
ayoung | YorikSar, Ok, I'm going to -1 that patch for now. Get a test in. Make sure that it is safe to run the migration multiple times. It should be idempotent to assign a role to a user | 20:55 |
*** vipul|away is now known as vipul | 20:55 | |
*** njoy has quit IRC | 20:56 | |
ayoung | heh...smae buzzword I wasn't even looking, honest | 20:56 |
YorikSar | ayoung: I was planning to add some tests there. | 20:56 |
ayoung | YorikSar, that isfine, but we need the test in with the patch. | 20:56 |
ayoung | YorikSar, Ok, we are tracking. | 20:56 |
openstackgerrit | A change was merged to openstack/nova: Spelling: compatable=>compatible https://review.openstack.org/22584 | 20:56 |
*** bswartz1 has joined #openstack-dev | 20:57 | |
openstackgerrit | A change was merged to openstack/nova: Sync rpc from oslo-incubator. https://review.openstack.org/22502 | 20:57 |
YorikSar | ayoung: Can you approve that description mapping change? | 20:57 |
ayoung | YorikSar, I +1ed it | 20:57 |
ayoung | henrynash, can you bless YorikSar 's change? | 20:57 |
*** bdpayne has joined #openstack-dev | 20:57 | |
*** bswartz has quit IRC | 20:58 | |
*** bswartz1 is now known as bswartz | 20:58 | |
smoser | sdague, around ? or mikal ? | 20:58 |
ayoung | https://review.openstack.org/#/c/22352/ henrynash | 20:58 |
*** annegentle has joined #openstack-dev | 20:58 | |
*** joshuamckenty has joined #openstack-dev | 20:58 | |
*** drewlander has quit IRC | 20:59 | |
YorikSar | ayoung, topol: What do you think about all that hacks in that migration? I had to dance around attribute limiting and stuff. | 20:59 |
sdague | smoser: yo | 20:59 |
*** dolphm has joined #openstack-dev | 20:59 | |
smoser | i'm looking at https://review.openstack.org/#/c/21884/ , and the complaints of lack of test. I'm biting my tounge, but it looks to me like *nothing* tests _create_image in nova/virt/libvirt/driver.py . | 20:59 |
ayoung | YorikSar, need to work on something else for a while...you guys thrash it out. | 20:59 |
topol | YorikSar, please explain. what was the concern? | 21:00 |
sdague | smoser: sure, but if we fix a bug, we want a test to make sure it doesn't regress | 21:00 |
openstackgerrit | A change was merged to openstack/nova: Sync eventlet_backdoor from oslo-incubator. https://review.openstack.org/22505 | 21:00 |
sdague | if we told every review that "well no one else wrote tests there, so you don't have to either" | 21:00 |
sdague | we'd have no tests | 21:00 |
openstackgerrit | A change was merged to openstack/python-keystoneclient: Update oslo-config version. https://review.openstack.org/22476 | 21:00 |
zykes- | anyone here using PyDev with a VirtualEnv ? | 21:01 |
sdague | that's been pretty common policy in the review queue | 21:01 |
smoser | sdague, this is probably the best example of bikeshed i've ever seen. | 21:01 |
YorikSar | ayoung: Ok. One more question then. Your _id_to_dn change https://review.openstack.org/22561 does not appear in zuul. How can that be? Will it pick it sometime? | 21:01 |
smoser | big hunk of code changed, tests aren't written, no one really reviews, it causes regression, and now everyone says "oh, i can review this code easily, you need a test" | 21:01 |
topol | YorikSar, that's what blocking your stuff from working, correct | 21:02 |
ayoung | YorikSar, there is something going on with zuul , sdague said a queue reset was in progress | 21:02 |
sdague | smoser: this is really common in the review queue. I'd say 1/3 of all -1s are "go add more tests to this" | 21:02 |
YorikSar | topol: Take a look at https://review.openstack.org/#/c/22558/1/keystone/identity/backends/ldap/core.py line 68-72 | 21:02 |
sdague | I'm sure stuff slips past that, but we need to catch it somewhere | 21:02 |
smoser | i'm not opposed to "write more tests", i'm opposed to "fixing a regression should block on writing more tests" | 21:04 |
*** zzs_ has joined #openstack-dev | 21:05 | |
smoser | and, fwiw, the only reason i *found* this bug is that I was trying to test that swap would be correctly utilized by cirros. | 21:05 |
*** zzs_ is now known as zzs | 21:06 | |
*** zzs has left #openstack-dev | 21:06 | |
*** armaan has joined #openstack-dev | 21:06 | |
*** zzs has joined #openstack-dev | 21:07 | |
smoser | sdague, you have suggestions on how you could write a test for _create_image that does anything more than show that you can write a test? | 21:07 |
smoser | ie, i'm honestly asking how i could write something that would have failed previously that passes after its fixed. | 21:08 |
*** jpich has quit IRC | 21:08 | |
topol | YorikSar, I understand the concern now :-) | 21:08 |
YorikSar | topol: It looks ugly, but I can't see a way around it. | 21:09 |
YorikSar | topol: Except doing the same, but in lower level. | 21:09 |
topol | YorikSar, Im trying to digest it a little | 21:09 |
*** gugl has joined #openstack-dev | 21:10 | |
*** vipul is now known as vipul|away | 21:10 | |
topol | YorikSar, so it looks like you try and migrate all the member attributes from all the projects? | 21:10 |
*** gugl has quit IRC | 21:10 | |
YorikSar | topol: Yes | 21:10 |
*** terry7 has joined #openstack-dev | 21:11 | |
topol | YorikSar, and this line: self.project.attribute_mapping['member'] = 'member' means I don't care what the mapping was I know these are member attributes? | 21:12 |
*** dprince has quit IRC | 21:12 | |
*** pabelanger has quit IRC | 21:13 | |
*** armaan has quit IRC | 21:13 | |
YorikSar | topol: I just needed 'member' in attribute_mapping.values(), because _ldap_get[_all] retrieves only attributes that appear there. | 21:13 |
*** henrynash_ has joined #openstack-dev | 21:13 | |
*** eglynn has joined #openstack-dev | 21:14 | |
*** nati_ueno has joined #openstack-dev | 21:14 | |
*** henrynash has quit IRC | 21:14 | |
*** henrynash_ is now known as henrynash | 21:14 | |
topol | YorikSar, and then you fix the mapping to look like how it used to look | 21:15 |
YorikSar | topol: Yes | 21:15 |
smoser | anyone have suggestions on how to write a proper test for https://review.openstack.org/#/c/21884/ ? | 21:15 |
sdague | smoser: looking through _create_image now (sorry, multiplexing with nova meeting) | 21:17 |
sdague | smoser: what about a tempest testing approach? | 21:17 |
*** melwitt has joined #openstack-dev | 21:17 | |
sdague | I agree, in looking at _create_image it's too big a function to actually be testable | 21:17 |
Vek | my first thought is that that is a monster function that needs to be broken up some... | 21:17 |
sdague | in it's current form | 21:17 |
vishy | smoser: you could probably do it with mox but yeah it will be hairy | 21:18 |
smoser | vishy, is just dont think it will demonstrate anything other than the ability to write a unit test | 21:18 |
vishy | smoser: yeah :( | 21:18 |
topol | YorikSar, then you skip anything in the enabled emulation project | 21:18 |
sdague | smoser: but it probably means we have no tempest tests that create images with swap, right? | 21:18 |
smoser | i've not done anything with tempest, but we clearly can *actually* test this code path rather than just unit test. | 21:19 |
sdague | would having one of those have tickled this | 21:19 |
smoser | yes, clearly. | 21:19 |
YorikSar | topol: We can ran into it with default settings, yes. | 21:19 |
sdague | smoser: so that's what I'd suggest | 21:19 |
smoser | i'll look at that. | 21:19 |
*** nsatterl_ has quit IRC | 21:19 | |
sdague | a response of "tempest will catch this with the following test case" is definitely acceptable comeback | 21:19 |
sdague | a lot of the wsgi stuff we have to lean on over there | 21:20 |
topol | YorikSar, then you skip the dumb member | 21:20 |
vishy | sdague: btw, how are we looking on coverage with the tempest run? | 21:20 |
bknudson | smoser: is it similar to this change? https://github.com/openstack/nova/commit/2bfe319b7096d61443a9b89b35a626e9e4040454#nova/virt/libvirt/driver.py | 21:20 |
YorikSar | topol: Yes, we keep it for now. | 21:20 |
vishy | is there a coverage report somewher using the extension? | 21:20 |
sdague | vishy: there is, mtreinish has the link | 21:21 |
sdague | it's only lit for nova-api right now, not the rest of nova | 21:21 |
sdague | and there is still some eventlet weirdness | 21:21 |
topol | YoriSar, then you add the users to role and delete them from the project | 21:21 |
*** nati_ueno has quit IRC | 21:21 | |
bknudson | smoser: here's another one: https://github.com/openstack/nova/commit/42cc03d8233fede7ed6ad5fa3b5fd351bd21c687 | 21:22 |
smoser | bknudson, i dont think so. | 21:22 |
*** nati_ueno has joined #openstack-dev | 21:22 | |
smoser | the failure in _create_image that exposed this was completely internal to _create_image. | 21:22 |
smoser | and even internal to the 4 lines there. | 21:22 |
topol | YorikSar, may not be pretty but looks good to me | 21:23 |
smoser | we'd have to excercise _create_image. | 21:23 |
*** nati_ueno has quit IRC | 21:23 | |
Vek | smoser: If you mean "exorcise", I'd agree :) | 21:23 |
YorikSar | topol: Ok. I'm thinking about tests now. | 21:23 |
*** boden has quit IRC | 21:23 | |
*** alunduil has quit IRC | 21:24 | |
*** gyee has joined #openstack-dev | 21:24 | |
*** armaan has joined #openstack-dev | 21:24 | |
*** nati_ueno has joined #openstack-dev | 21:24 | |
ttx | ayoung: there was a restart due to a Jenkins security patch, I think | 21:25 |
mtreinish | vishy, sdague: http://logs.openstack.org/periodic/periodic-tempest-devstack-coverage-vm-full/44/logs/coverage-report/ this is the most recent output from the periodic jenkins run. | 21:25 |
clarkb | ttx: ayoung yes that is correct. did something get missed? | 21:25 |
topol | YorikSar, as soon as _id_to_dn gets merged in I will then pull yours down and test with devstack | 21:25 |
ttx | clarkb: https://review.openstack.org/#/c/22561/ -- just set to reverify | 21:26 |
*** joshuamckenty has quit IRC | 21:26 | |
ttx | clarkb: still not in queue though | 21:26 |
vishy | mtreinish: odd, I feel like it isn't picking up everything yet | 21:26 |
ayoung | clarkb, I will check. There were patches approved that we are waiting on | 21:26 |
topol | YorikSar, I can't think of any other way you could write the code | 21:27 |
clarkb | ttx: ayoung that change is not mergable until it has at least on +2 code review | 21:27 |
YorikSar | ttx: What does this magic 'reverify no bug' mean? | 21:27 |
clarkb | so Zuul is ignoring it currently | 21:27 |
*** eglynn has quit IRC | 21:27 | |
*** bencherian has quit IRC | 21:27 | |
ayoung | clarkb, thanks | 21:27 |
clarkb | YorikSar: Zuul, the thing that triggers jobs in Jenkins based on Gerrit events, uses a comment with that content to indicate it should add a change to the gate queue | 21:28 |
ttx | YorikSar: https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures | 21:28 |
ttx | clarkb: any particular reason why ? | 21:28 |
clarkb | YorikSar: this is necessary only if things did not run properly for some reason the first time around | 21:28 |
mtreinish | vishy: it's only running on the nova-api service right now. Also there is some weirdness in the report because of eventlet | 21:28 |
clarkb | ttx: YorikSar: yeah Zuul relies on the Gerrit event stream to know when to do stuff. Adding a comment is a simple way of adding arbitrary content to that stream | 21:29 |
clarkb | so we didn't need to patch Gerrit to do something special | 21:29 |
ttx | clarkb: no I mean... why is it ignoring ? | 21:29 |
clarkb | ttx: yeah that change does not have a +2 code review | 21:29 |
YorikSar | Oh... I never knew it got this flexible :) | 21:29 |
ttx | clarkb: oh, it's in now | 21:29 |
openstackgerrit | A change was merged to openstack/python-glanceclient: Add docs for v0.8.0 https://review.openstack.org/22598 | 21:30 |
*** nsatterl_ has joined #openstack-dev | 21:31 | |
*** rkukura has quit IRC | 21:32 | |
*** sandywalsh_ has joined #openstack-dev | 21:33 | |
*** dolphm has quit IRC | 21:34 | |
*** alexpilotti has joined #openstack-dev | 21:35 | |
*** CaptTofu has joined #openstack-dev | 21:35 | |
*** alexpilotti has quit IRC | 21:35 | |
*** vipul|away is now known as vipul | 21:36 | |
*** vipul is now known as vipul|away | 21:37 | |
*** vipul|away is now known as vipul | 21:37 | |
*** boris-42 has quit IRC | 21:40 | |
*** armaan has left #openstack-dev | 21:43 | |
*** aeperezt has joined #openstack-dev | 21:46 | |
*** READ10 has quit IRC | 21:46 | |
*** cp16net is now known as cp16net|away | 21:46 | |
ewindisch | I have a draft for recursive dependency resolution in oslo's update.py, if anyone wants to request a peek at it. | 21:47 |
openstackgerrit | A change was merged to openstack/nova: Fix ComputeAPI.get_host_uptime https://review.openstack.org/21716 | 21:49 |
*** digitalbruin has quit IRC | 21:49 | |
openstackgerrit | A change was merged to openstack/nova: Flush tokens on instance delete https://review.openstack.org/22086 | 21:49 |
*** bencherian has joined #openstack-dev | 21:51 | |
*** bswartz has quit IRC | 21:51 | |
bcwaldon | mordred: who should I talk to about not being able to push signed tags to python-glanceclient? | 21:51 |
*** vipul is now known as vipul|away | 21:52 | |
bcwaldon | mordred: ignore me -pushing to github rather than gerrit | 21:53 |
mordred | bcwaldon: hang on a sec | 21:53 |
*** crandquist has joined #openstack-dev | 21:53 | |
bcwaldon | mordred: problem solved | 21:53 |
ayoung | gyee, when we report roles along with a token, wee have to look up each one separately. IS there no way to do a join in sql alchemy? | 21:53 |
*** cp16net|away is now known as cp16net | 21:53 | |
mordred | bcok | 21:53 |
*** radez is now known as radez_g0n3 | 21:55 | |
*** david4 has quit IRC | 21:56 | |
*** dolphm has joined #openstack-dev | 21:57 | |
*** markvoelker has quit IRC | 22:00 | |
ttx | ayoung, dolphm: would be great to make sure you can get https://review.openstack.org/#/c/22497/ and https://review.openstack.org/#/c/22561/ to land in master | 22:01 |
ttx | ayoung, dolphm: with that in I'll cut grizzly-3 tomorrow morning | 22:02 |
*** henrynash has quit IRC | 22:03 | |
*** dhellmann has quit IRC | 22:03 | |
*** dhellmann has joined #openstack-dev | 22:04 | |
jgriffith | dtroyer: I was going to update Cinder's rootwrap in devstack, wanted to make sure you weren't already doing it? | 22:07 |
openstackgerrit | A change was merged to openstack/python-glanceclient: Report name resolution errors properly https://review.openstack.org/22322 | 22:09 |
openstackgerrit | A change was merged to openstack/keystone: Fix id_to_dn for creating objects https://review.openstack.org/22561 | 22:09 |
dolphm | ttx: ^ | 22:10 |
*** shardy is now known as shardy_afk | 22:10 | |
dolphm | ayoung: can you review https://review.openstack.org/#/c/22497/ ? | 22:11 |
ttx | dolphm: propose backport ? | 22:11 |
*** diogogmt has quit IRC | 22:11 | |
dolphm | ttx: doing it now | 22:11 |
ayoung | dolphm, took all your suggestions save one on the trust api review: | 22:11 |
ayoung | roles don't have to be assigned when the trust is created, just executed | 22:11 |
*** FatDarrel has joined #openstack-dev | 22:12 | |
*** nati_ueno has quit IRC | 22:13 | |
ayoung | dolphm, Approved 22561 | 22:15 |
dolphm | ayoung: backport of your patch https://review.openstack.org/#/c/22620/ | 22:16 |
dolphm | ttx: ^ | 22:16 |
ttx | dolphm: approved | 22:17 |
dolphm | ttx: ayoung: and backport of my patch: https://review.openstack.org/#/c/22621/ | 22:17 |
ttx | dolphm: will cut g3 first thing tomorrow morning | 22:17 |
dolphm | ttx: woot | 22:17 |
*** Gordonz has quit IRC | 22:18 | |
*** topol has quit IRC | 22:19 | |
*** dolphm has quit IRC | 22:20 | |
*** mdomsch has quit IRC | 22:22 | |
*** aeperezt has quit IRC | 22:24 | |
*** aeperezt has joined #openstack-dev | 22:27 | |
*** dhellmann has quit IRC | 22:31 | |
*** numero8 has joined #openstack-dev | 22:34 | |
*** bswartz has joined #openstack-dev | 22:34 | |
*** numero8 has quit IRC | 22:35 | |
*** koolhead17 has quit IRC | 22:36 | |
zykes- | ttx: did all the v3 stuff get into g3 ? | 22:36 |
*** esheffield has quit IRC | 22:44 | |
*** radez_g0n3 is now known as radez | 22:45 | |
*** ecarlin has joined #openstack-dev | 22:46 | |
*** ron-slc_ has quit IRC | 22:46 | |
*** eharney has quit IRC | 22:48 | |
*** unix has quit IRC | 22:48 | |
*** jrodom has quit IRC | 22:50 | |
*** martine has quit IRC | 22:51 | |
*** maoy has quit IRC | 22:52 | |
*** dosaboy has quit IRC | 22:52 | |
*** john5223 has joined #openstack-dev | 22:54 | |
*** john5223 has quit IRC | 22:54 | |
*** annegentle has quit IRC | 22:55 | |
*** melwitt has quit IRC | 22:58 | |
*** dolphm has joined #openstack-dev | 22:58 | |
*** dolphm has quit IRC | 22:58 | |
*** dolphm has joined #openstack-dev | 22:59 | |
*** brucer has joined #openstack-dev | 22:59 | |
*** markmcclain has quit IRC | 23:00 | |
*** harlowja_ has quit IRC | 23:00 | |
openstackgerrit | A change was merged to openstack/keystone: Tests for domain-scoped tokens https://review.openstack.org/22497 | 23:00 |
*** zzs has left #openstack-dev | 23:01 | |
*** vipul|away is now known as vipul | 23:02 | |
*** nsatterl_ has quit IRC | 23:04 | |
*** tomoe_ has joined #openstack-dev | 23:06 | |
*** danwent has quit IRC | 23:06 | |
*** troytoman is now known as troytoman-away | 23:08 | |
*** harlowja has joined #openstack-dev | 23:08 | |
*** nsatterl_ has joined #openstack-dev | 23:09 | |
*** imsplitbit has quit IRC | 23:09 | |
*** kbringard has quit IRC | 23:09 | |
*** harlowja has quit IRC | 23:11 | |
*** harlowja has joined #openstack-dev | 23:12 | |
*** melwitt has joined #openstack-dev | 23:12 | |
*** bknudson has quit IRC | 23:12 | |
*** hattwick has quit IRC | 23:13 | |
*** digitalsanctum has quit IRC | 23:13 | |
*** hattwick has joined #openstack-dev | 23:14 | |
*** roampune1 has joined #openstack-dev | 23:14 | |
*** roampune has quit IRC | 23:17 | |
*** topol has joined #openstack-dev | 23:19 | |
*** spzala has quit IRC | 23:20 | |
*** zzs has joined #openstack-dev | 23:21 | |
*** eafonichev has quit IRC | 23:22 | |
dtroyer | jgriffith: is that what https://review.openstack.org/22474 does? | 23:23 |
dtroyer | smulcahy: sorry for the delay…I've got a couple of questions about the backup service... | 23:23 |
*** markmcclain has joined #openstack-dev | 23:24 | |
*** bknudson has joined #openstack-dev | 23:25 | |
*** mtreinish has quit IRC | 23:26 | |
*** bknudson has quit IRC | 23:29 | |
*** todo_stack has joined #openstack-dev | 23:31 | |
*** bknudson has joined #openstack-dev | 23:32 | |
*** pabelanger has joined #openstack-dev | 23:34 | |
*** sacharya has quit IRC | 23:35 | |
*** dolphm has quit IRC | 23:36 | |
*** openstackgerrit has quit IRC | 23:39 | |
*** openstackgerrit has joined #openstack-dev | 23:39 | |
*** cloudchimp has quit IRC | 23:40 | |
*** devoid has quit IRC | 23:40 | |
*** markmcclain has quit IRC | 23:41 | |
*** rnirmal has quit IRC | 23:41 | |
*** gongysh has joined #openstack-dev | 23:42 | |
*** henrynash has joined #openstack-dev | 23:44 | |
*** ndipanov has quit IRC | 23:45 | |
*** rpedde is now known as rpedde_away | 23:45 | |
henrynash | ayoung, YorikSar: which change do you need me to look at? https://review.openstack.org/#/c/22352/ ? | 23:45 |
ayoung | henrynash, that is one, yes | 23:45 |
ayoung | that might be it.... | 23:45 |
*** soody has joined #openstack-dev | 23:47 | |
henrynash | ayoung: how are we on Trusts? What can I do to help? | 23:47 |
ayoung | henrynash, I'm having some complext test interaction problem where the policy path is getting set to a mktemp path. It happended from a recent merge | 23:48 |
jgriffith | dtroyer: :) | 23:48 |
ayoung | beyond that...API review | 23:48 |
jgriffith | dtroyer: but I think the setup function needs handled too... I 'll check | 23:48 |
ayoung | henrynash, take a look at the current trust API patch and ge familiar with it. THe next one won't be radically different, and knowig it wil help. | 23:49 |
henrynash | ayoung: hmm, OK…that could possibly be me…which test are you failing in? | 23:49 |
ayoung | mine | 23:50 |
ayoung | test_v3_trust | 23:50 |
*** topol has quit IRC | 23:50 | |
ayoung | henrynash, yeah, it is the policy stuff. I was about to look through your patch again to see what is going on | 23:50 |
*** nsatterl_ has quit IRC | 23:51 | |
ayoung | henrynash, also, It looks like you rewrote the policy scanning so it only works with V3 tokens. Still need to support v2 | 23:51 |
ayoung | henrynash, but I have that working | 23:52 |
henrynash | ayoung: in test_v3_protection (which I added new) I set the policy file to a temp file….but sureful that should be reset by your new test class….I know that test_policy also does this | 23:52 |
ayoung | henrynash, so, what I am seeing is the if I run my tests alone, they work but if I run the whole test suite they fail | 23:52 |
henrynash | ayoung: I had a problem where if I had two test classes in the same file, one would mike up the other like this | 23:53 |
henrynash | ..muck up... | 23:53 |
ayoung | yep...that is what I am seeing. I thin I can straighten it out. | 23:53 |
ayoung | thanks for the pointer...I have a 6 year old here demanding I play chess with him. back in a few | 23:53 |
*** pabelanger has quit IRC | 23:53 | |
henrynash | ayoung: you can't win at everything, you know | 23:54 |
*** spzala has joined #openstack-dev | 23:54 | |
ayoung | henrynash, I am QUITE aware of that. I am visitng my parents, after all. | 23:55 |
henrynash | ayoung: :-) | 23:55 |
*** gongysh has quit IRC | 23:55 | |
*** gongysh has joined #openstack-dev | 23:56 | |
*** spzala_ has joined #openstack-dev | 23:56 | |
*** mrodden has quit IRC | 23:57 | |
jgriffith | dtroyer: yep, I thought it would require modifying the setup function but apparantly not. thx | 23:58 |
*** spzala has quit IRC | 23:58 | |
*** spzala_ is now known as spzala | 23:58 | |
zykes- | zul: or Daviey why does ceilometer-agent-compute want to install mongo ? | 23:58 |
SpamapS | hey if anybody is in LA for SCALE send me a private message .. would love to have an impromptu meetup of openstackers :) | 23:59 |
zykes- | in the daily packages | 23:59 |
*** danwent has joined #openstack-dev | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!