| jakeyip | hi all, something came up, I won't be able to make it on time for meeting later. I will join when I can. | 08:16 |
|---|---|---|
| jakeyip | I have a patch to mark CAPI driver as beta, so that it needs to be explicitly enabled by operators. I will send it up later for comments. | 08:17 |
| mnasiadka | jakeyip: I think it would be nice to merge backports of https://review.opendev.org/c/openstack/magnum/+/889144 | 08:56 |
| travisholton | hello all o/ | 09:01 |
| jakeyip | mnasiadka: does that affect anything other than the new rbac policies? | 12:40 |
| mnasiadka | well, there are people that might be using enforce_scope = True before the enforcement by default ;-) | 12:41 |
| jakeyip | do you mean using that w/o the patch https://review.opendev.org/c/openstack/magnum/+/874945 ? | 12:44 |
| mnasiadka | ah right, they can't - so I don't know why we have those backports ;-) | 12:45 |
| jakeyip | hmm yah should ask ricolin | 12:46 |
| jakeyip | ricolin: why did you backport https://review.opendev.org/c/openstack/magnum/+/891103 ? | 12:47 |
| ricolin | because we uses wrong token authentication all the time, so IMO is a bug | 12:48 |
| ricolin | jakeyip: ^^^ | 12:48 |
| jakeyip | yeah I agree it's a bug. but I think the policies are slightly broken too, so everything still works :D | 12:51 |
| jakeyip | I am just curious, is there currently broken functionality that the backports will fix? (excluding what your rbac patches need) | 12:51 |
| opendevreview | Rico Lin proposed openstack/magnum-ui master: Add magnum cluster config support https://review.opendev.org/c/openstack/magnum-ui/+/890894 | 14:26 |
| ricolin | jakeyip: only when user customize their own policies to more restrict rules | 15:47 |
| ricolin | I mean customize in policy.yaml | 15:47 |
| ricolin | mnasiadka the branch coverage for new patch is 100% now https://review.opendev.org/c/openstack/magnum-ui/+/890894 | 15:52 |
| mnasiadka | ricolin: fantastic, thanks | 15:53 |
| opendevreview | Merged openstack/magnum-ui master: Add magnum cluster config support https://review.opendev.org/c/openstack/magnum-ui/+/890894 | 16:11 |
| ricolin | jakeyip: I think we need https://review.opendev.org/c/openstack/releases/+/891565 for the merged https://review.opendev.org/c/openstack/magnum-ui/+/890894 otherwise it will fail | 17:26 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!