*** chandan_kumar has joined #openstack-climate | 05:02 | |
*** Nikolay_St has joined #openstack-climate | 05:36 | |
*** ddyachkov has joined #openstack-climate | 06:12 | |
*** saju_m has joined #openstack-climate | 06:15 | |
openstackgerrit | Dmitriy Dyachkov proposed a change to stackforge/climate: Add pylint check for Climate project https://review.openstack.org/58964 | 07:51 |
---|---|---|
*** bauzas has joined #openstack-climate | 08:22 | |
*** saju_m has quit IRC | 08:31 | |
*** ppetit has joined #openstack-climate | 08:52 | |
openstackgerrit | Dmitriy Dyachkov proposed a change to stackforge/climate: Add pylint check for Climate project https://review.openstack.org/58964 | 08:53 |
*** saju_m has joined #openstack-climate | 08:58 | |
openstackgerrit | Sylvain Bauza proposed a change to stackforge/climate: Port to Pecan/WSME for API v2 https://review.openstack.org/71011 | 09:01 |
*** chandan_kumar has quit IRC | 09:10 | |
*** chandan_kumar has joined #openstack-climate | 09:20 | |
*** DinaBelova_ is now known as DinaBelova | 09:50 | |
openstackgerrit | Yuriy Taraday proposed a change to stackforge/climate: Remove direct assignments of context attributes https://review.openstack.org/72673 | 10:11 |
openstackgerrit | Yuriy Taraday proposed a change to stackforge/climate: Remove explicit access to is_admin in context https://review.openstack.org/72742 | 10:11 |
bauzas | DinaBelova: FYI, https://wiki.openstack.org/wiki/Climate/REST_API#Hosts | 10:18 |
bauzas | DinaBelova: still examples are missing | 10:18 |
DinaBelova | bauzas, nya! | 10:18 |
bauzas | DinaBelova: but that's worth it | 10:18 |
DinaBelova | thanks :) | 10:18 |
bauzas | DinaBelova: I'll put the hosts examples once my lab env will be back up | 10:18 |
DinaBelova | how I understand u :D | 10:19 |
DinaBelova | this my day will be about namings checking :) | 10:19 |
DinaBelova | and lab fighting :) | 10:19 |
bauzas | DinaBelova: as I'm running 2 VMs on a single laptop, I'm context switching between documentation tasks and code tasks | 10:19 |
bauzas | I'm only having 4GB of RAM | 10:19 |
bauzas | I was trying to run a devstack with docker | 10:19 |
bauzas | still facing some issues | 10:19 |
bauzas | and have no time for further investigating | 10:20 |
DinaBelova | ok, got it... | 10:21 |
openstackgerrit | A change was merged to stackforge/climate: Fix pylint errors https://review.openstack.org/73529 | 10:25 |
openstackgerrit | A change was merged to stackforge/climate: Improve memory/performace in ManagerService https://review.openstack.org/73358 | 10:30 |
openstackgerrit | Dmitriy Dyachkov proposed a change to stackforge/climate: Add pylint check for Climate project https://review.openstack.org/58964 | 10:32 |
openstackgerrit | Swann Croiset proposed a change to stackforge/climate: Use config generator/check_update tools from Oslo incubator https://review.openstack.org/71243 | 10:56 |
openstackgerrit | Dmitriy Dyachkov proposed a change to stackforge/climate: Add pylint check for Climate project https://review.openstack.org/58964 | 11:06 |
*** DinaBelova is now known as DinaBelova_ | 11:36 | |
*** ddyachkov has quit IRC | 12:22 | |
*** cmart has joined #openstack-climate | 12:28 | |
*** pafuent has joined #openstack-climate | 12:57 | |
openstackgerrit | Pablo Andres Fuente proposed a change to stackforge/climate: Initial devstack support implemented https://review.openstack.org/60465 | 13:00 |
*** DinaBelova_ is now known as DinaBelova | 13:24 | |
pafuent | DinaBelova: Hi | 13:26 |
DinaBelova | pafuent, hello :) | 13:26 |
DinaBelova | Good morning :) | 13:26 |
pafuent | DinaBelova: Could you check a comment that I wrote in this bug https://bugs.launchpad.net/climate/+bug/1240021? | 13:27 |
DinaBelova | sure | 13:27 |
swann | hi all, morning Dina ;) | 13:27 |
pafuent | DinaBelova: If I tested correctly the bug is fixed | 13:27 |
DinaBelova | I think so, yes | 13:28 |
swann | for this bug ^^ I think so too | 13:28 |
DinaBelova | It was actual some time ago | 13:28 |
*** casanch1 has joined #openstack-climate | 13:28 | |
casanch1 | hi | 13:28 |
DinaBelova | o/ | 13:28 |
casanch1 | please, when you have time, could you review this https://review.openstack.org/#/c/73363/ ? | 13:28 |
casanch1 | thanks! | 13:28 |
DinaBelova | casanch1, sure, will do that | 13:29 |
swann | setted status to invalid for the bug : https://bugs.launchpad.net/climate/+bug/1240021? | 13:29 |
DinaBelova | I'm fighting with my lab now... | 13:29 |
DinaBelova | swann, yes - cause now we cannot even get it once more time | 13:29 |
DinaBelova | swann, I cannot find some other appropriate bug state in the list | 13:30 |
swann | DinaBelova: Do you know why we still need notifier.api (from oslo) ? | 13:45 |
DinaBelova | yes, I know it | 13:45 |
DinaBelova | it | 13:45 |
DinaBelova | it's becuase of middleware deps | 13:45 |
DinaBelova | it's not used really anywhere | 13:45 |
swann | which middleware ? | 13:46 |
DinaBelova | openstack.common.middleware | 13:46 |
DinaBelova | probably we may leave in that directory only debup.py | 13:46 |
swann | humm | 13:46 |
DinaBelova | debug.py | 13:46 |
DinaBelova | that is actually usen in climate | 13:46 |
DinaBelova | and remove everything else | 13:46 |
swann | ok, thanks for your lights :) | 13:47 |
DinaBelova | cause update.py file in oslo-incubator downloads full dirs - even if they are not really used | 13:47 |
swann | may we can ask to Cristian A Sanchez to remove all middleware except debug.py in his review : https://review.openstack.org/#/c/73363/ ? | 13:49 |
DinaBelova | I think that's quite good idea | 13:50 |
casanch1 | no problema | 13:50 |
swann | ok, I'll post a comment on the review + now it's outdated :) | 13:50 |
swann | casanch1: cool | 13:50 |
DinaBelova | casanch1, thank you | 13:51 |
DinaBelova | please check it, but I'm quite sure, that we only need debug.py in middleware package - everything else is just downloaded because of update.py script | 13:52 |
swann | Initial devstack support implemented: I'm going to test this one now :) | 13:53 |
pafuent | swann: If you find any issue with that, please let me know | 13:59 |
pafuent | bauzas: Are you around? | 13:59 |
bauzas | pafuent: yup | 14:00 |
pafuent | bauzas: Hi | 14:00 |
bauzas | pafuent: I'm sorry, I'm focusing on Nova things | 14:00 |
bauzas | pafuent: how are you ? | 14:00 |
pafuent | bauzas: Fine | 14:00 |
pafuent | bauzas: I have a question regarding Pecan routing | 14:00 |
bauzas | sure | 14:00 |
bauzas | pafuent: go ahead | 14:01 |
pafuent | bauzas: Why is the purpose of _lookup() in V2Controller? | 14:02 |
bauzas | http://pecan.readthedocs.org/en/latest/routing.html#routing-to-subcontrollers-with-lookup | 14:02 |
pafuent | bauzas: Yes I read that | 14:02 |
bauzas | pafuent: that's for matching os-hosts | 14:02 |
bauzas | the routing is based on the name of the controller | 14:03 |
bauzas | I can't create an object having os-hosts as name | 14:03 |
pafuent | bauzas: So the idea is to only access the HostController using os-host, right? | 14:03 |
bauzas | so I created oshosts and mapped to it using lookup() | 14:03 |
bauzas | pafuent: right | 14:03 |
bauzas | pafuent: well, with the current proposal, you can also access it using /oshosts/ | 14:04 |
bauzas | both are mapping to the same controller | 14:04 |
pafuent | bauzas: That was my concern | 14:04 |
bauzas | pafuent: ok, I think I got your idea, you dislike it ? | 14:04 |
bauzas | pafuent: having both /oshosts and /os-hosts matching the same ctrl ? | 14:05 |
bauzas | pafuent: I should be able to modify it | 14:05 |
pafuent | bauzas: I don't know much about API design, but I like only one way to do things | 14:05 |
bauzas | ok, will see what I can do | 14:05 |
bauzas | I will probably patch the lookup method by denying oshosts | 14:06 |
pafuent | bauzas: Ok, thanks. I'll add a comment to the review. | 14:06 |
bauzas | pafuent: please put a comment on the patch | 14:06 |
bauzas | pafuent: ok thanks | 14:06 |
bauzas | pafuent: there are still some things to do within the patch | 14:07 |
pafuent | bauzas: I added the comment without -1 or +1, because I had a meeting and I can't review the rest. After the meeting I'll review the rest | 14:10 |
bauzas | ok | 14:13 |
*** saju_m has quit IRC | 14:15 | |
DinaBelova | casanch1, you here? | 14:22 |
DinaBelova | I just wanted to ask you one more time about your lab | 14:23 |
DinaBelova | with latest master, etc. | 14:23 |
DinaBelova | did you try to create lease there somehow? | 14:24 |
DinaBelova | via VM reservation, whatever | 14:24 |
casanch1 | yes I did | 14:27 |
casanch1 | and it worked | 14:27 |
openstackgerrit | Christian Martinez proposed a change to stackforge/climate: Adding tests for sqlalchemy class https://review.openstack.org/72943 | 14:31 |
cmart | Nikolay_St: I added the tests you mentioned.. Please, take a look at them | 14:33 |
casanch1 | swann: do I have to remove all middleware except debug.py, even those that were already there? Like audit.py, base, correlation_id, etc? | 14:33 |
DinaBelova | casanch1, agrh :( I can't understand what's going on with my completely new VM with completely new devstack :( | 14:34 |
DinaBelova | casanch1, as for middleware, please lease only ones that are used in climate and their deps | 14:34 |
DinaBelova | so it looks like that only debug.py and base.py should be left there | 14:35 |
DinaBelova | the second one is needed by first | 14:35 |
casanch1 | I removed all of them except debug and tests fail now :( | 14:35 |
DinaBelova | base.py is also needed | 14:35 |
DinaBelova | it's dependency for debug | 14:36 |
DinaBelova | https://github.com/openstack/oslo-incubator/blob/master/openstack/common/middleware/debug.py#L25 | 14:36 |
DinaBelova | base.py has no interesting deps - https://github.com/openstack/oslo-incubator/blob/master/openstack/common/middleware/base.py#L18 | 14:36 |
DinaBelova | casanch1, ^^ | 14:36 |
casanch1 | uhmmm strange | 14:42 |
casanch1 | after updating oslo and only removing rpc and notifier (as it worked before), tests are not executed | 14:42 |
casanch1 | and pep8 fails :S | 14:42 |
DinaBelova | wowow | 14:45 |
DinaBelova | that's not good | 14:45 |
DinaBelova | casanch1, please run recheck on Jenkins | 14:46 |
DinaBelova | cause this your change worked before good | 14:46 |
DinaBelova | it's not the most fresh, but it's on review now, so you may use Jenkins for independent checking | 14:47 |
casanch1 | nop, it fails in my local environment | 14:47 |
DinaBelova | okay, so only in local env... | 14:48 |
DinaBelova | I'll check it now too | 14:48 |
DinaBelova | uno momento | 14:48 |
casanch1 | yes, actually without the oslo update tests work ok | 14:48 |
casanch1 | but fail just after updating | 14:48 |
DinaBelova | casanch1, copy your log to paste.openstack.org and give me link, please | 14:49 |
DinaBelova | I'll take a look | 14:49 |
casanch1 | here | 14:51 |
casanch1 | http://paste.openstack.org/show/66494/ | 14:51 |
DinaBelova | casanch1, I used your change https://review.openstack.org/#/c/73363/, ran update.py for it, removed rpc and notifier and everything from middleware except base and debug | 14:56 |
DinaBelova | I've got pep8 ok | 14:56 |
DinaBelova | casanch1 in my env everything is ok | 15:00 |
casanch1 | did you update oslo-incubator to the latest? | 15:00 |
casanch1 | and climate to the latest? | 15:00 |
DinaBelova | climate was on oslo.messaging | 15:02 |
DinaBelova | I may rebase it now | 15:02 |
DinaBelova | yes, I rebased | 15:03 |
*** YorikSar has joined #openstack-climate | 15:03 | |
DinaBelova | everything is ok with "your change https://review.openstack.org/#/c/73363/, ran update.py for it, removed rpc and notifier and everything from middleware except base and debug" | 15:03 |
casanch1 | did you get the latest changes in oslo-incubator? | 15:03 |
DinaBelova | casanch1, yes, cause "ran update.py for it" | 15:03 |
DinaBelova | and then "removed rpc and notifier and everything from middleware except base and debug" | 15:04 |
casanch1 | I mean, git pull in oslo-incubator | 15:04 |
casanch1 | update.py will not pull latest changes in oslo-incubator | 15:04 |
DinaBelova | casanch1, I'll try it now | 15:05 |
*** chandan_kumar has quit IRC | 15:07 | |
DinaBelova | I also have got error now | 15:12 |
DinaBelova | but other one ;) | 15:12 |
DinaBelova | with tests discovering :) | 15:12 |
DinaBelova | for pep8 I got errors like u, it seems | 15:15 |
DinaBelova | 0_0 | 15:15 |
DinaBelova | casanch1, it seems that now we have exactly same errors | 15:21 |
DinaBelova | both for py27 and for pep8 | 15:21 |
DinaBelova | I suppose that the key here is updated openstack.common.db stuff | 15:22 |
DinaBelova | cause it looks like for me that errors with IMPL = db_api.DBAPI(backend_mapping=_BACKEND_MAPPING) are main ones here | 15:22 |
DinaBelova | this file was modified and now we have errors with its using and tests listing | 15:23 |
DinaBelova | also in db stuff | 15:23 |
DinaBelova | casanch1, may you investigate that moment? | 15:24 |
casanch1 | I wil | 15:24 |
DinaBelova | ерфтл нщг | 15:24 |
DinaBelova | wowow | 15:24 |
DinaBelova | it was "thank you" :) | 15:24 |
casanch1 | :D | 15:28 |
*** DinaBelova is now known as DinaBelova_ | 16:08 | |
*** chandan_kumar has joined #openstack-climate | 16:29 | |
*** chandan_kumar has quit IRC | 16:29 | |
*** chandan_kumar has joined #openstack-climate | 16:30 | |
*** bauzas has quit IRC | 16:38 | |
*** chandan_kumar has quit IRC | 16:55 | |
*** DinaBelova_ is now known as DinaBelova | 17:02 | |
*** casanch1_ has joined #openstack-climate | 17:06 | |
*** casanch1 has quit IRC | 17:08 | |
*** casanch1_ is now known as casanch1 | 17:08 | |
*** bauzas has joined #openstack-climate | 17:11 | |
*** cmart has quit IRC | 17:13 | |
*** ppetit has quit IRC | 17:58 | |
*** ppetit has joined #openstack-climate | 17:59 | |
*** ppetit has quit IRC | 17:59 | |
*** openstackgerrit has quit IRC | 18:53 | |
*** openstackgerrit has joined #openstack-climate | 18:54 | |
*** DinaBelova is now known as DinaBelova_ | 20:54 | |
*** pafuent has left #openstack-climate | 21:09 | |
*** casanch1 has quit IRC | 21:25 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!