*** mhen_ is now known as mhen | 02:42 | |
opendevreview | Callum Dickinson proposed openstack/cinder master: Add the volume_type_name attribute to volume notifications https://review.opendev.org/c/openstack/cinder/+/940674 | 03:42 |
---|---|---|
opendevreview | Callum Dickinson proposed openstack/cinder master: Add the volume_type_name attribute to volume notifications https://review.opendev.org/c/openstack/cinder/+/940674 | 07:36 |
opendevreview | Saikumar Pulluri proposed openstack/cinder master: [NetApp] Certificate based authentication for NetApp drivers https://review.opendev.org/c/openstack/cinder/+/942342 | 08:31 |
yuval | whoami-rajat you want to talk about the retype doc's commit | 10:42 |
yuval | we tested it with few different backends and volume types. we dont see a reason to override the retype function | 10:43 |
yuval | this is the commit: https://review.opendev.org/c/openstack/cinder/+/939635 | 10:43 |
opendevreview | Merged openstack/cinder master: StorPool: Use os-brick instead of packages `storpool` and `storpool.spopenstack` https://review.opendev.org/c/openstack/cinder/+/933078 | 10:53 |
opendevreview | Rajat Dhasmana proposed openstack/os-brick master: FC: Improve exception handling during scanning https://review.opendev.org/c/openstack/os-brick/+/939916 | 11:34 |
whoami-rajat | yuval, hello, my question was not about retype working or not, it's about you are claiming support of retype but it's not clear if it's host assisted or driver assisted | 11:38 |
whoami-rajat | yuval, the purpose of overriding the method is not to make it "work" but to optimize it | 11:39 |
whoami-rajat | yuval, in your case it's host assisted as driver is not doing the actual retype but cinder is | 11:40 |
yuval | whoami-rajat can you explain the difference between host assisted and driver assisted | 11:42 |
whoami-rajat | yuval, if you are performing a retype with migration, in case of host assisted, cinder will create a new volume, copy data from old volume to new and delete the old volume | 11:43 |
whoami-rajat | if it's driver assisted, each driver can provide it's own implementation like RBD does here https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/rbd.py#L2355 | 11:45 |
yuval | I understand what you mean - so we mean host assisted. if customer have volumes in LVM backend he can retype them to lightbits volumes | 11:46 |
yuval | just mentioning it since its tested with few different backends and we see it works as expected | 11:47 |
whoami-rajat | yes, that should work with cinder generic retype+migration path | 11:47 |
whoami-rajat | jbernard, rosmaita hey, I've filed the bug and updated the fix for the os-brick patch so it is good to review | 11:48 |
whoami-rajat | LP: https://bugs.launchpad.net/os-brick/+bug/2098954 | 11:49 |
whoami-rajat | fix: https://review.opendev.org/c/openstack/os-brick/+/939916 | 11:49 |
yuval | whoami-rajat should I change the description from: "Volume retype" to something else? | 11:53 |
whoami-rajat | it should be fine as these are driver specific docs but I would've preferred the term "host assisted" there | 11:55 |
opendevreview | yuval proposed openstack/cinder master: lightbits: doc's "retype" support https://review.opendev.org/c/openstack/cinder/+/939635 | 12:14 |
yuval | whoami-rajat fixed, Thanks for the clarifications | 12:14 |
whoami-rajat | yuval, thanks for the change, +2ed | 12:28 |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph master: MDS Logging https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/942284 | 14:06 |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph master: MDS Logging https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/942284 | 14:08 |
opendevreview | Merged openstack/cinder master: lightbits: doc's "retype" support https://review.opendev.org/c/openstack/cinder/+/939635 | 18:02 |
opendevreview | Merged openstack/os-brick master: FC: Improve exception handling during scanning https://review.opendev.org/c/openstack/os-brick/+/939916 | 18:22 |
*** mhen_ is now known as mhen | 19:48 | |
*** jhorstmann is now known as Guest9655 | 22:17 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!