Wednesday, 2016-03-09

*** rhagarty__ has quit IRC00:00
*** diablo_rojo has joined #openstack-cinder00:00
*** rhagarty__ has joined #openstack-cinder00:00
*** rhagarty__ has quit IRC00:00
*** rhagarty__ has joined #openstack-cinder00:00
*** haomaiwang has quit IRC00:01
*** rhagarty__ has quit IRC00:01
*** rhagarty__ has joined #openstack-cinder00:01
*** rhagarty__ has quit IRC00:01
*** haomaiwang has joined #openstack-cinder00:01
*** rhagarty__ has joined #openstack-cinder00:01
*** rhagarty__ has quit IRC00:02
*** rhagarty_ has joined #openstack-cinder00:02
*** rhagarty_ has quit IRC00:02
*** rhagarty_ has joined #openstack-cinder00:02
*** rhagarty_ has quit IRC00:03
*** rhagarty_ has joined #openstack-cinder00:03
*** rhagarty_ has quit IRC00:03
*** rhagarty_ has joined #openstack-cinder00:03
*** rhagarty_ has quit IRC00:04
*** rhagarty_ has joined #openstack-cinder00:04
*** martyturner has quit IRC00:04
*** rhagarty_ has quit IRC00:04
*** rhagarty_ has joined #openstack-cinder00:04
*** rhagarty_ has quit IRC00:05
*** yangyapeng has quit IRC00:05
*** rhagarty_ has joined #openstack-cinder00:05
*** akshai has quit IRC00:05
*** rhagarty_ has quit IRC00:05
*** rhagarty_ has joined #openstack-cinder00:05
*** edmondsw has quit IRC00:06
*** rhagarty_ has quit IRC00:06
*** rhagarty_ has joined #openstack-cinder00:06
*** rhagarty_ has quit IRC00:06
*** rhagarty_ has joined #openstack-cinder00:06
*** rhagarty__ has joined #openstack-cinder00:07
*** rhagarty_ has quit IRC00:07
*** rhagarty__ has quit IRC00:07
*** rhagarty__ has joined #openstack-cinder00:07
*** davechen_afk has quit IRC00:07
*** rhagarty__ has quit IRC00:08
*** arch-nemesis has quit IRC00:13
*** diablo_rojo has quit IRC00:14
*** crose has quit IRC00:15
*** hemna is now known as hemnafk00:20
*** sasukeh has joined #openstack-cinder00:27
*** salv-orlando has joined #openstack-cinder00:30
*** smoriya_ has joined #openstack-cinder00:30
*** yhayashi has joined #openstack-cinder00:34
*** Julien-zte has joined #openstack-cinder00:37
*** tjcocozz has quit IRC00:37
*** bapalm has quit IRC00:37
*** Julien-zte has quit IRC00:38
openstackgerritNate Potter proposed openstack/cinder: Added more options while uploading volume as image  https://review.openstack.org/23061700:38
*** sheel has joined #openstack-cinder00:39
*** lixiaoy1 has joined #openstack-cinder00:40
openstackgerritNate Potter proposed openstack/cinder: Added more options while uploading volume as image  https://review.openstack.org/23061700:40
*** salv-orlando has quit IRC00:40
*** apoorvad has quit IRC00:43
*** mriedem has joined #openstack-cinder00:44
*** wxy has joined #openstack-cinder00:47
*** tjcocozz has joined #openstack-cinder00:53
*** bapalm has joined #openstack-cinder00:54
*** harlowja has quit IRC00:55
*** gouthamr has joined #openstack-cinder00:57
openstackgerritLisaLi proposed openstack/cinder: Report versions in cinder-manager service list  https://review.openstack.org/28827500:59
*** gouthamr_ has joined #openstack-cinder00:59
*** cheneydc has joined #openstack-cinder01:00
*** haomaiwang has quit IRC01:01
*** haomaiwang has joined #openstack-cinder01:01
*** mtanino has quit IRC01:02
*** gouthamr has quit IRC01:02
openstackgerritzwei proposed openstack/python-cinderclient: Bootable filter for listening volumes from CLI  https://review.openstack.org/28965701:03
*** jwcroppe has quit IRC01:04
openstackgerritzwei proposed openstack/python-cinderclient: Bootable filter for listening volumes from CLI  https://review.openstack.org/28965701:04
*** baojg has joined #openstack-cinder01:06
*** sdague has joined #openstack-cinder01:07
*** yangyapeng has joined #openstack-cinder01:08
*** gcb has joined #openstack-cinder01:10
*** baojg has quit IRC01:10
*** apoorvad has joined #openstack-cinder01:10
openstackgerritzengchen proposed openstack/cinder: RPC client recreates exception instance failed  https://review.openstack.org/29021701:18
*** Suyash has quit IRC01:19
openstackgerritwanghao proposed openstack/cinder: Clean up image tmp file if c-vol gets restarted  https://review.openstack.org/22508101:32
*** haomaiwang has quit IRC01:32
jgriffithsmcginnis: do they not even implement extend?  Guess ABC doesn't do what some thought :(01:33
*** scohen_ has joined #openstack-cinder01:35
openstackgerritzwei proposed openstack/python-cinderclient: Bootable filter for listening volumes from CLI  https://review.openstack.org/28965701:37
*** sdague has quit IRC01:38
*** arch-nemesis has joined #openstack-cinder01:38
openstackgerritzwei proposed openstack/python-cinderclient: Bootable filter for listening volumes from CLI  https://review.openstack.org/28965701:39
*** scohen_ has quit IRC01:40
*** scohen_ has joined #openstack-cinder01:41
*** scohen_ is now known as scohen101:42
*** scohen1 has left #openstack-cinder01:43
openstackgerritNate Potter proposed openstack/cinder: Added more options while uploading volume as image  https://review.openstack.org/23061701:43
*** scohen_ has joined #openstack-cinder01:43
*** scohen_ has left #openstack-cinder01:43
*** arch-nemesis has quit IRC01:44
openstackgerritChangBo Guo(gcb) proposed openstack/cinder: Let method CONF.set_override with enfore_type=true by default  https://review.openstack.org/25332801:44
*** sdague has joined #openstack-cinder01:46
*** mtanino has joined #openstack-cinder01:53
openstackgerritzengchen proposed openstack/cinder: RPC client recreates exception instance failed  https://review.openstack.org/29021701:55
*** arch-nemesis has joined #openstack-cinder01:56
*** salv-orlando has joined #openstack-cinder01:57
openstackgerritCheney proposed openstack/python-cinderclient: Parse filter item "name" correctly for snapshot-list  https://review.openstack.org/29022902:03
*** IlyaG_ has quit IRC02:03
*** salv-orlando has quit IRC02:04
*** RustShen has joined #openstack-cinder02:04
openstackgerritzhanghao proposed openstack/os-brick: Nova and Brick remain their used iscsi sessions  https://review.openstack.org/29023102:04
*** sdague has quit IRC02:05
*** Lee1092 has joined #openstack-cinder02:17
*** haomaiwang has joined #openstack-cinder02:20
openstackgerritNate Potter proposed openstack/cinder: Added more options while uploading volume as image  https://review.openstack.org/23061702:21
*** haomaiwang has quit IRC02:24
*** haomaiwa_ has joined #openstack-cinder02:25
*** haomaiwa_ has quit IRC02:26
*** haomaiwa_ has joined #openstack-cinder02:26
*** haomaiwa_ has quit IRC02:27
*** 20WAAIE7U has joined #openstack-cinder02:27
*** 20WAAIE7U has quit IRC02:28
*** haomaiwa_ has joined #openstack-cinder02:28
*** haomaiwa_ has quit IRC02:29
*** haomaiwang has joined #openstack-cinder02:29
*** haomaiwang has quit IRC02:30
*** haomaiwang has joined #openstack-cinder02:30
*** [1]Thelo has joined #openstack-cinder02:30
*** haomaiwang has quit IRC02:31
*** haomaiwang has joined #openstack-cinder02:31
*** haomaiwang has quit IRC02:32
*** haomaiwang has joined #openstack-cinder02:32
*** haomaiwang has quit IRC02:33
*** Thelo has quit IRC02:33
*** [1]Thelo is now known as Thelo02:33
*** haomaiwang has joined #openstack-cinder02:33
*** haomaiwang has quit IRC02:34
*** yangyapeng has quit IRC02:44
*** cknight has joined #openstack-cinder02:46
*** lprice has joined #openstack-cinder02:48
*** lprice1 has quit IRC02:48
*** gcb has quit IRC02:52
*** jwcroppe has joined #openstack-cinder02:53
*** mriedem has quit IRC02:54
openstackgerritLisaLi proposed openstack/cinder: Host selection in backup service  https://review.openstack.org/29024802:58
*** bardia has quit IRC02:59
*** cknight has quit IRC03:07
openstackgerritTom Barron proposed openstack/cinder: Run py34 tests with plain 'tox' command  https://review.openstack.org/28869603:07
*** sasukeh has quit IRC03:11
*** gcb has joined #openstack-cinder03:13
*** haomaiwang has joined #openstack-cinder03:14
*** dims has quit IRC03:25
*** apoorvad has quit IRC03:27
*** markvoelker has joined #openstack-cinder03:30
*** ebalduf has joined #openstack-cinder03:31
*** salv-orlando has joined #openstack-cinder03:32
*** cknight has joined #openstack-cinder03:34
*** salv-orlando has quit IRC03:35
*** cknight has quit IRC03:37
*** haomaiwang has quit IRC03:40
*** haomaiw__ has joined #openstack-cinder03:40
*** gouthamr_ has quit IRC03:43
*** jwcroppe has quit IRC03:51
*** garthb has quit IRC03:52
*** jamielennox is now known as jamielennox|away03:54
*** sasukeh has joined #openstack-cinder03:59
*** links has joined #openstack-cinder04:03
*** shausy has joined #openstack-cinder04:09
*** sayalilunkad has quit IRC04:22
*** yangds has quit IRC04:30
*** sayalilunkad has joined #openstack-cinder04:34
jgriffithanybody have a current count of how many drivers are in Cinder at this point?04:37
*** fifieldt has joined #openstack-cinder04:47
*** sayalilunkad has quit IRC04:50
*** sayalilunkad has joined #openstack-cinder04:51
*** sasukeh has quit IRC04:54
*** EinstCrazy has joined #openstack-cinder04:57
*** lprice1 has joined #openstack-cinder05:01
*** lprice has quit IRC05:01
*** deepakcs has joined #openstack-cinder05:06
*** salv-orlando has joined #openstack-cinder05:07
DuncanTI got 82 last time I counted for a presentation, but I wasn't being careful05:09
*** salv-orlando has quit IRC05:13
*** arch-nemesis has quit IRC05:16
*** EinstCrazy has quit IRC05:28
*** bardia has joined #openstack-cinder05:36
*** gcb has quit IRC05:41
*** daneyon_ has quit IRC05:41
*** Poornima has joined #openstack-cinder05:45
*** jwcroppe has joined #openstack-cinder05:52
*** nkrinner has joined #openstack-cinder05:54
openstackgerritCheney proposed openstack/python-cinderclient: Parse filter item "name" correctly for snapshot-list  https://review.openstack.org/29022905:58
*** garthb has joined #openstack-cinder05:59
*** gcb has joined #openstack-cinder06:00
*** baojg has joined #openstack-cinder06:01
*** sasukeh has joined #openstack-cinder06:05
*** garthb has quit IRC06:06
*** rcernin has joined #openstack-cinder06:09
*** gcb has quit IRC06:10
openstackgerritChangBo Guo(gcb) proposed openstack/cinder: Use imageutils from oslo_utils  https://review.openstack.org/25732806:14
*** baojg has quit IRC06:16
*** sgotliv has joined #openstack-cinder06:17
*** baojg has joined #openstack-cinder06:19
*** laughterwym has joined #openstack-cinder06:29
*** asselin__ has joined #openstack-cinder06:29
*** asselin_ has quit IRC06:31
*** salv-orlando has joined #openstack-cinder06:31
*** laughter_ has joined #openstack-cinder06:32
*** baojg has quit IRC06:32
*** laughter_ has quit IRC06:32
*** laughter_ has joined #openstack-cinder06:34
*** laughterwym has quit IRC06:35
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Zanata  https://review.openstack.org/29029906:35
*** salv-orlando has quit IRC06:36
*** baojg has joined #openstack-cinder06:38
*** baojg has quit IRC06:39
*** laughter_ has quit IRC06:39
*** abhishekk has joined #openstack-cinder06:44
openstackgerritDinesh Bhor proposed openstack/cinder: Provide user friendly messages for db sync  https://review.openstack.org/28415606:47
abhishekkeharney: hi you around?06:50
*** chlong has quit IRC06:54
*** baojg has joined #openstack-cinder06:59
*** baojg has quit IRC07:00
*** laughterwym has joined #openstack-cinder07:01
*** dave-mccowan has quit IRC07:02
openstackgerritjaveme proposed openstack/cinder: Remove those unnecessary statements "return True"  https://review.openstack.org/24680507:05
*** chlong has joined #openstack-cinder07:08
openstackgerritjaveme proposed openstack/cinder: Encode the url parameters for XIO driver  https://review.openstack.org/25415707:08
*** bjornar has quit IRC07:09
*** lpetrut has joined #openstack-cinder07:09
*** laughterwym has quit IRC07:10
*** mjura has joined #openstack-cinder07:12
*** laughter_ has joined #openstack-cinder07:13
*** sgotliv has quit IRC07:14
*** laughterwym has joined #openstack-cinder07:15
*** laughter_ has quit IRC07:18
openstackgerritAbhishek Kekane proposed openstack/cinder: volume upload-to-image fails for iso disk-format  https://review.openstack.org/28760607:20
*** anshul has joined #openstack-cinder07:21
*** esker has quit IRC07:22
*** bardia has quit IRC07:23
*** nkrinner has quit IRC07:27
*** ildikov has quit IRC07:28
openstackgerritCao ShuFeng proposed openstack/cinder: Add display_name to allowed_search_options  https://review.openstack.org/29031207:29
*** laughter_ has joined #openstack-cinder07:30
*** nkrinner has joined #openstack-cinder07:31
*** sasukeh has quit IRC07:32
*** laughterwym has quit IRC07:32
*** laughter_ has quit IRC07:34
*** laughterwym has joined #openstack-cinder07:34
*** lixiaoy1 has quit IRC07:36
*** laughterwym has quit IRC07:37
*** laughterwym has joined #openstack-cinder07:38
*** akolbasov has joined #openstack-cinder07:43
*** laughterwym has quit IRC07:43
*** laughterwym has joined #openstack-cinder07:44
*** yangyapeng has joined #openstack-cinder07:46
*** liverpooler has joined #openstack-cinder07:46
*** laughterwym has quit IRC07:48
openstackgerritMichal Jura proposed openstack/cinder: Fix failure with rbd on slow ceph clusters  https://review.openstack.org/28925207:49
*** yangyapeng has quit IRC07:49
*** yangyapeng has joined #openstack-cinder07:49
openstackgerritDanny Al-Gaaf proposed openstack/cinder: rbd: Change capacity calculation from integer to float  https://review.openstack.org/28939407:50
*** akolbasov has quit IRC07:52
*** ebalduf has quit IRC07:54
*** asselin__ has quit IRC07:56
*** belmoreira has joined #openstack-cinder07:56
*** sasukeh has joined #openstack-cinder07:59
*** ChubYann has quit IRC08:04
*** laughter_ has joined #openstack-cinder08:05
*** yangyapeng has quit IRC08:06
*** laughte__ has joined #openstack-cinder08:09
*** lixiaoy1 has joined #openstack-cinder08:09
*** e0ne has joined #openstack-cinder08:10
*** laughter_ has quit IRC08:11
*** yangyapeng has joined #openstack-cinder08:13
*** mjura has quit IRC08:13
*** lpetrut has quit IRC08:14
*** arecknag has joined #openstack-cinder08:14
openstackgerritxiexs proposed openstack/python-cinderclient: Use magic constants instead of magic numbers  https://review.openstack.org/29032208:14
*** lpetrut has joined #openstack-cinder08:18
*** e0ne has quit IRC08:19
*** laughte__ has quit IRC08:20
*** laughterwym has joined #openstack-cinder08:21
*** laughter_ has joined #openstack-cinder08:22
*** laughterwym has quit IRC08:25
*** mjura has joined #openstack-cinder08:28
*** smoriya_ has quit IRC08:29
*** timcl has joined #openstack-cinder08:30
*** jwcroppe has quit IRC08:32
*** jwcroppe has joined #openstack-cinder08:32
*** timcl has quit IRC08:35
*** ndipanov has quit IRC08:35
*** zhanghao has joined #openstack-cinder08:38
*** sgotliv has joined #openstack-cinder08:38
*** lpetrut has quit IRC08:39
*** openstackgerrit has quit IRC08:47
*** openstackgerrit has joined #openstack-cinder08:48
*** ndipanov has joined #openstack-cinder08:55
*** links has quit IRC08:55
*** baojg has joined #openstack-cinder08:55
*** baojg has quit IRC08:59
*** ChubYann has joined #openstack-cinder09:02
openstackgerritKeiichi KII proposed openstack/os-brick: Replace _get_multipath_device_name with generic _discover_mpath_device  https://review.openstack.org/29033609:05
openstackgerritKeiichi KII proposed openstack/os-brick: Replace _get_multipath_device_name with _discover_mpath_device  https://review.openstack.org/29033609:08
*** yhayashi has quit IRC09:08
*** bapalm has quit IRC09:14
*** zhanghao has quit IRC09:14
*** tjcocozz has quit IRC09:15
*** jistr has joined #openstack-cinder09:19
*** ildikov has joined #openstack-cinder09:19
*** slunkad has joined #openstack-cinder09:21
*** salv-orlando has joined #openstack-cinder09:21
*** lixiaoy1 has left #openstack-cinder09:22
*** zhanghao has joined #openstack-cinder09:22
*** bapalm has joined #openstack-cinder09:27
openstackgerritCheney proposed openstack/python-cinderclient: Parse filter item "name" correctly for snapshot-list  https://review.openstack.org/29022909:28
*** salv-orlando has quit IRC09:29
*** zhanghao has quit IRC09:31
*** tjcocozz has joined #openstack-cinder09:31
*** jordanP has joined #openstack-cinder09:31
*** kambiz has quit IRC09:32
*** slunkad has left #openstack-cinder09:34
*** sayalilunkad_lap has joined #openstack-cinder09:35
*** kambiz has joined #openstack-cinder09:35
*** avishay has joined #openstack-cinder09:36
openstackgerritGorka Eguileor proposed openstack/cinder: Refactor sqlalchemy service methods  https://review.openstack.org/28659809:40
openstackgerritGorka Eguileor proposed openstack/cinder: Add service_nodes table and related methods  https://review.openstack.org/28659909:40
openstackgerritGorka Eguileor proposed openstack/cinder: Add ServiceNode Versioned Object  https://review.openstack.org/28660009:40
openstackgerritGorka Eguileor proposed openstack/cinder: Change Job Distribution for HA A-A  https://review.openstack.org/28660109:40
*** e0ne has joined #openstack-cinder09:51
*** ChubYann has quit IRC09:58
*** huanan_L has joined #openstack-cinder09:59
*** huanan has quit IRC09:59
*** cheneydc has quit IRC10:00
openstackgerritSachin Yede proposed openstack/cinder: Bug id: 1514819 Message: Replaced "Openstack" with "OpenStack" in cinder-log-info.po  https://review.openstack.org/29037110:01
*** tpsilva has joined #openstack-cinder10:01
*** e0ne has quit IRC10:01
*** baojg has joined #openstack-cinder10:02
*** ChubYann has joined #openstack-cinder10:02
*** e0ne has joined #openstack-cinder10:04
*** lpetrut has joined #openstack-cinder10:08
*** bjornar has joined #openstack-cinder10:09
*** laughter_ has quit IRC10:11
*** RustShen has quit IRC10:11
*** ChubYann has quit IRC10:12
*** lpetrut has quit IRC10:13
*** laughterwym has joined #openstack-cinder10:14
*** baojg has quit IRC10:14
*** laughterwym has quit IRC10:16
*** laughterwym has joined #openstack-cinder10:16
*** lpetrut has joined #openstack-cinder10:20
*** mvk has joined #openstack-cinder10:21
*** laughterwym has quit IRC10:22
*** laughterwym has joined #openstack-cinder10:23
*** laughter_ has joined #openstack-cinder10:24
*** laughterwym has quit IRC10:27
*** yuriy_n17 has joined #openstack-cinder10:31
*** asselin__ has joined #openstack-cinder10:35
*** haomaiw__ has quit IRC10:45
*** salv-orlando has joined #openstack-cinder10:51
*** salv-orlando has quit IRC10:56
*** sdague has joined #openstack-cinder11:06
*** laughter_ has quit IRC11:06
*** dims has joined #openstack-cinder11:07
*** laughterwym has joined #openstack-cinder11:07
*** ildikov has quit IRC11:08
*** smoriya has quit IRC11:10
*** laughterwym has quit IRC11:10
*** laughterwym has joined #openstack-cinder11:11
*** ChubYann has joined #openstack-cinder11:18
*** smoriya_afk has joined #openstack-cinder11:19
*** takedakn has joined #openstack-cinder11:19
*** smoriya_afk is now known as smoriya11:19
*** ChubYann has quit IRC11:32
*** kmartin has quit IRC11:33
*** ociuhandu has quit IRC11:35
*** wxy has quit IRC11:39
*** ChubYann has joined #openstack-cinder11:41
*** yangyapeng has quit IRC11:42
*** chlong has quit IRC11:42
*** delatte has quit IRC11:45
*** laughter_ has joined #openstack-cinder11:47
*** links has joined #openstack-cinder11:48
*** laughterwym has quit IRC11:50
*** pots has quit IRC11:52
*** takedakn has quit IRC11:53
*** laughter_ has quit IRC11:53
*** takedakn has joined #openstack-cinder11:53
*** laughterwym has joined #openstack-cinder11:54
*** laughter_ has joined #openstack-cinder11:54
*** pots has joined #openstack-cinder11:56
*** laughterwym has quit IRC11:59
*** ildikov has joined #openstack-cinder12:04
*** avishay has quit IRC12:04
*** salv-orlando has joined #openstack-cinder12:06
*** yangds has joined #openstack-cinder12:10
*** chlong has joined #openstack-cinder12:14
*** EinstCrazy has joined #openstack-cinder12:15
openstackgerritGorka Eguileor proposed openstack/cinder: Remove API races on extend and volume_upload_image  https://review.openstack.org/21637812:16
openstackgerritGorka Eguileor proposed openstack/cinder: Remove API races from consistency groups  https://review.openstack.org/25942912:16
openstackgerritGorka Eguileor proposed openstack/cinder: Remove API races from migrate and retype  https://review.openstack.org/22144212:16
*** avishay has joined #openstack-cinder12:19
*** mvk has quit IRC12:20
*** ociuhandu has joined #openstack-cinder12:20
stevemarquestion for cinder folks12:22
stevemarwhats up with set_image_metadata ?12:23
stevemaris that the same as updating the metadata for an image via glance?12:23
stevemarreferring to https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/volumes.py12:23
*** lpetrut1 has joined #openstack-cinder12:26
*** lpetrut has quit IRC12:27
*** chlong has quit IRC12:27
*** nkrinner has quit IRC12:27
*** lpetrut1 is now known as lpetrut12:27
*** bapalm has quit IRC12:27
*** alaski has quit IRC12:27
*** takedakn has quit IRC12:27
*** bapalm has joined #openstack-cinder12:27
stevemaris `cinder volume update --image-property` the same as `glance image update --property` ?12:28
*** dalgaaf has joined #openstack-cinder12:28
stevemarwe're trying to fill the gap of missing cinder commands in OSC and were wondering if that is actually missing... https://review.openstack.org/#/c/290424/112:29
*** mjura has quit IRC12:29
stevemarjgriffith: smcginnis ^12:29
*** [1]Thelo has joined #openstack-cinder12:30
*** alaski has joined #openstack-cinder12:31
*** cdelatte has joined #openstack-cinder12:32
*** Thelo has quit IRC12:32
*** [1]Thelo is now known as Thelo12:32
*** nkrinner has joined #openstack-cinder12:40
*** chlong has joined #openstack-cinder12:40
*** mjura has joined #openstack-cinder12:44
*** Poornima has quit IRC12:49
*** deepakcs has quit IRC12:51
*** mvk has joined #openstack-cinder12:51
openstackgerritSteve Martinelli proposed openstack/python-cinderclient: WIP: switch to keystoneauth  https://review.openstack.org/29046412:58
*** ChubYann has quit IRC13:01
*** ChubYann has joined #openstack-cinder13:02
*** krtaylor has quit IRC13:02
*** dims has quit IRC13:05
*** dims_ has joined #openstack-cinder13:05
*** baojg has joined #openstack-cinder13:07
*** markvoelker_ has joined #openstack-cinder13:08
*** porrua has joined #openstack-cinder13:08
*** edmondsw has joined #openstack-cinder13:10
*** dims_ has quit IRC13:10
*** ankit_ag has quit IRC13:10
*** markvoelker has quit IRC13:11
DuncanTstevemar: It's for updating the image_metadata of a bootable volume13:12
stevemarDuncanT: so... different ya?13:12
*** crose has joined #openstack-cinder13:12
DuncanTstevemar: The metadata is copied from glance when the volume is created13:12
DuncanTstevemar: but since a volume is mutable, unlike an image, you sometimes want to update it13:13
stevemarDuncanT: i see13:13
DuncanTstevemar: So similar, but different13:13
stevemarDuncanT: yeah, it's up there for the terrible naming award, like our tenant v project fiasco :)13:13
stevemarbut okay, good to know it's different!13:13
DuncanTstevemar: Yeah, the naming sort of crept up on us13:14
*** dims has joined #openstack-cinder13:14
DuncanTstevemar: I'm considering shooting the next person who tries to call something 'metadata' in cinder13:15
stevemarDuncanT: ++13:15
stevemarDuncanT: if you have a suggestion, let us know here: https://review.openstack.org/#/c/290424/1 -- may as well not make the same mistake twice13:15
openstackgerritMerged openstack/cinder: Trim 5s+ from storwize unit tests  https://review.openstack.org/28957513:16
*** avishay has quit IRC13:17
DuncanTstevemar: stevemar Not sure what else you can call it... maybe boot_metadata rather than image_metadata... cinder already calls it image_metadata in a bunch of APIs though so hard to change13:17
stevemarDuncanT: boot-property?13:17
stevemarDuncanT: in osc-land we definitely do not use the word metadata anywhere13:18
stevemarwe have a strict policy on that :)13:18
DuncanTstevemar: What do you remap the volume metadata field to then?13:18
stevemarDuncanT: property13:19
DuncanTstevemar: boot-property might be good I guess13:19
DuncanTstevemar: That's going to get confusing, since it is called metadata in the api output, in horizon, in python-cinderclient, in the cinder docs and in searchlight13:20
*** yangyapeng has joined #openstack-cinder13:20
stevemarDuncanT: eek...13:20
*** markvoelker_ has quit IRC13:20
stevemarsheel: not sure if you can read the scrollback, but DuncanT and i talked about your patch13:21
sheelstevemar: i got some13:21
stevemarsheel: maybe calling it --boot-property will help differentiate it from --property13:21
*** martyturner has joined #openstack-cinder13:21
sheelI think its ok13:21
DuncanTstevemar: So I'd pick fault with using --property, and might file a bug... OSC shouldn't be causing confusion with every other consume IMO13:22
* stevemar shrugs 13:22
stevemarDuncanT: every project calls it something different13:22
*** dave-mccowan has joined #openstack-cinder13:22
stevemarwe picked one and went with it13:22
*** baojg has quit IRC13:22
stevemarDuncanT: that's a battle to fight with dtroyer13:23
sheelDuncanT: i agree on this but  osc already name it property for metadata..13:24
sheelstevemar: :)13:24
DuncanTsheel: stevemar: Is the meaning of 'property' even consistent between projects?13:25
DuncanTI get the feeling you're trying to make things equivelent that really aren't13:25
sheelDuncanT: right13:25
sheelDuncanT: any suggestion on name?13:26
sheelstevemar: may be we have to go back and rename property as well then13:26
sheelstevemar: :)13:26
DuncanTpyton-cinderclient, the rest api, horizon, searchlight, the docs and a couple of other places already call them 'metadata' and 'image-metadata'... for better or worse, that name is baked in now13:27
sheelDuncanT: exactly, i am with it and same name should be used everywhere13:29
stevemarDuncanT: file a bug with osc if it makes you unhappy, we can mark is as wishlist for now and if folks pile on then we can slowly make the change13:30
sheelstevemar: but may be we have to talk with dtroyer about why we named it properry in past13:30
sheelstevemar: i will work to update it if all agrees13:30
*** timcl has joined #openstack-cinder13:30
DuncanTstevemar: will do. I'll ping dtroyer with the bug number once it is filed13:31
stevemarDuncanT: cool13:31
stevemarDuncanT: dtroyer will have the history for why we did it in the first place. Guessing since osc isn't so widely adopted just yet, we could change things up now before it's too late13:31
* DuncanT wonders why python-openstackclient pulls in python-mock as an install dependecy, by and by13:32
stevemarwhaaaa13:32
DuncanTstevemar: Making them aliases for each other might actually be the best idea13:32
stevemarhttps://github.com/openstack/python-openstackclient/blob/master/requirements.txt13:32
stevemarDuncanT: yeah, was thinking that13:32
stevemarno mock there :O13:33
*** baojg has joined #openstack-cinder13:33
DuncanTstevemar: I'm just looking at the .deb - it's an indirect dependecy, so no openstack client's fault13:33
*** akerr has joined #openstack-cinder13:34
DuncanTstevemar: Just looking at the spec I started this week for volume groups, it has both metadata and properties as different things.... I'll change that before I create a monster13:34
*** links has quit IRC13:35
stevemarDuncanT: yay!13:37
stevemarDuncanT: yay x2 actually13:37
DuncanTstevemar: fortunately I haven't published it yet. I need a new name for things that add arbitrary functionality, but some from a known set and have strong semantic meanings13:38
*** markvoelker has joined #openstack-cinder13:39
DuncanTstevemar: Examples of these are 'consistency group' 'replication' 'fast snapshot' 'fast backup' and other properties a subset of volumes might have on a system13:40
DuncanTFeatures maybe?13:40
*** tsufiev has quit IRC13:41
sheeloptions, settings,13:44
sheelDuncanT: or may be atribute13:46
DuncanTattribute could be a good one13:47
sheelDuncanT: :)13:47
*** rlrossit has joined #openstack-cinder13:48
*** laughter_ has quit IRC13:48
*** laughterwym has joined #openstack-cinder13:51
*** gouthamr has joined #openstack-cinder13:52
*** akshai has joined #openstack-cinder13:55
*** salv-orlando has quit IRC13:55
*** markvoelker has quit IRC13:58
openstackgerritGorka Eguileor proposed openstack/cinder: Remove API races from consistency groups  https://review.openstack.org/25942914:07
openstackgerritMerged openstack/cinder: Remove those unnecessary statements "return True"  https://review.openstack.org/24680514:07
*** salv-orlando has joined #openstack-cinder14:07
*** jwcroppe has quit IRC14:10
*** salv-orlando has quit IRC14:14
*** fifieldt has quit IRC14:16
*** dustins has joined #openstack-cinder14:18
*** mriedem has joined #openstack-cinder14:19
*** mtanino has quit IRC14:19
openstackgerritWilson Liu proposed openstack/cinder: Huawei: Check before delete host  https://review.openstack.org/28295014:20
*** xyang1 has joined #openstack-cinder14:21
*** tsufiev has joined #openstack-cinder14:23
krotscheckHeya everyone. I've got a mitaka bug up for review at https://review.openstack.org/#/c/286795/ - Are there any cores around to review this?14:24
*** Guest40585 has joined #openstack-cinder14:29
*** Guest40585 has quit IRC14:29
openstackgerritAMIT KUMAR proposed openstack/cinder: Setting the value of limit argument from the request.  https://review.openstack.org/29053314:32
*** liu has joined #openstack-cinder14:32
*** jwcroppe has joined #openstack-cinder14:32
*** laughterwym has quit IRC14:37
*** laughterwym has joined #openstack-cinder14:37
*** laughter_ has joined #openstack-cinder14:39
*** crose has quit IRC14:40
*** jwcroppe has quit IRC14:40
*** laughterwym has quit IRC14:42
openstackgerritTom Barron proposed openstack/cinder: Fix invalid UUID warnings for test_volume_*  https://review.openstack.org/29054114:42
*** laughterwym has joined #openstack-cinder14:43
*** laughter_ has quit IRC14:43
*** merooney has joined #openstack-cinder14:46
*** laughterwym has quit IRC14:47
flip214DuncanT: may I ask you for a review of https://review.openstack.org/#/c/287807? Already got a +2...14:47
*** mmandel has joined #openstack-cinder14:47
*** knikolla has joined #openstack-cinder14:47
*** markvoelker has joined #openstack-cinder14:48
e0nesmcginnis: hi! why wo we use launchpad os-brick project only for bugs (http://bugs.launchpad.net/os-brick)? I'm looking where I should create a blueprint for it14:48
*** igornsa_ has joined #openstack-cinder14:48
*** haomaiwang has joined #openstack-cinder14:49
e0nes/wo we/do we14:49
*** ivase has joined #openstack-cinder14:50
*** jgregor has joined #openstack-cinder14:51
openstackgerritKyrylo Romanenko proposed openstack/python-cinderclient: Fix docstring according to function  https://review.openstack.org/29054914:51
*** mriedem is now known as mriedem_meeting14:52
*** frontrunner has joined #openstack-cinder14:54
*** igornsa_ has quit IRC14:55
*** baumann has joined #openstack-cinder14:59
*** lprice1 has quit IRC15:00
*** haomaiwang has quit IRC15:01
*** haomaiwa_ has joined #openstack-cinder15:01
*** cknight has joined #openstack-cinder15:03
*** xek_ is now known as xek15:05
*** mtanino has joined #openstack-cinder15:06
*** BigWillie has joined #openstack-cinder15:07
*** ebalduf has joined #openstack-cinder15:08
*** baojg has quit IRC15:12
openstackgerritMichal Dulko proposed openstack/cinder: Set expected_attrs in volume obj to what we join  https://review.openstack.org/29056915:12
smcginnise0ne: We should probably track them there.15:13
smcginnisNot sure how to get that changed to allow it though.15:13
smcginnise0ne: Digging through now to see how I enable it.15:13
*** liu has quit IRC15:13
*** edtubill has joined #openstack-cinder15:14
anteayasmcginnis: when you have a chance can you take a look at a patch I have up to governance regarding ptls leave of absence if they are required to take one: https://review.openstack.org/#/c/290141/215:14
smcginnisanteaya: Sure, thanks for the ping!15:15
anteayathank you15:15
*** baojg has joined #openstack-cinder15:15
*** merooney has quit IRC15:16
*** diablo_rojo has joined #openstack-cinder15:18
openstackgerritIce Yao proposed openstack/cinder: Add judgement of backing-up volume status  https://review.openstack.org/28887515:18
*** laughterwym has joined #openstack-cinder15:20
*** arch-nemesis has joined #openstack-cinder15:26
*** merooney has joined #openstack-cinder15:27
*** edtubill has quit IRC15:29
*** sasukeh has quit IRC15:30
*** baojg has quit IRC15:33
*** sasukeh has joined #openstack-cinder15:33
*** sasukeh has quit IRC15:34
*** sasukeh has joined #openstack-cinder15:34
*** lprice has joined #openstack-cinder15:34
*** darosale has joined #openstack-cinder15:35
*** edtubill has joined #openstack-cinder15:35
*** kprabhu has joined #openstack-cinder15:36
*** krtaylor has joined #openstack-cinder15:37
*** sasukeh has quit IRC15:39
*** ildikov has quit IRC15:40
*** mriedem_meeting is now known as mriedem15:40
openstackgerritMichal Jura proposed openstack/cinder: Put cinder.conf options in sorted order  https://review.openstack.org/26950315:43
*** nkrinner has quit IRC15:46
*** sayalilunkad_lap has quit IRC15:48
openstackgerritKendall Nelson proposed openstack/cinder: Add SnapshotStatus enum field  https://review.openstack.org/28482515:48
lpetrutHi guys, I have a question related to the oslo.versionedobjects transition. Are all the driver methods now receiving versioned objects instead of sqlalchemy models?15:49
*** jseiler has joined #openstack-cinder15:49
*** sayalilunkad_lap has joined #openstack-cinder15:49
*** avishay has joined #openstack-cinder15:53
lpetruthmm, I guess not: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L128615:53
e0nelpetrut: looks like you found the answer to your question, didn't you?15:55
*** kmartin has joined #openstack-cinder15:55
lpetrutyep, I guess so. Is there a reason we don't pass a versioned object here?15:55
*** EinstCrazy has quit IRC15:56
*** liverpooler has quit IRC15:56
lpetrutbasically, this causes us some issues because we don't know what to expect regarding the volume object attributes. note that the volume type extra specs will be either a dict, either a list of VolumeTypeExtraSpecs objects, depending on what the manager passes to the driver.15:57
*** cFouts is now known as cfouts15:59
e0nelpetrut: I would like to ask it ^^ to geguileo and dulek15:59
*** Poornima has joined #openstack-cinder16:00
*** haomaiwa_ has quit IRC16:01
geguileolpetrut: As you have noticed, not everything has been changed16:01
*** haomaiwang has joined #openstack-cinder16:01
lpetrutgeguileo: would it be safe to just pass a versioned object?16:02
geguileolpetrut: We'd have to confirm, but it should be safe16:02
*** zzzeek has quit IRC16:03
openstackgerritEric Harney proposed openstack/cinder: Remove "sqlite_clean_db" option  https://review.openstack.org/29061816:03
*** mjura has quit IRC16:03
*** vincent_hou has joined #openstack-cinder16:03
*** adrianofr_ has joined #openstack-cinder16:03
*** zzzeek has joined #openstack-cinder16:04
geguileolpetrut: Looks like the copy_volume_to_image has not been moved to VO yet16:04
geguileolpetrut: We should move it to VO16:04
lpetrutgeguileo: that's the only left, right?16:04
*** gcb has joined #openstack-cinder16:05
geguileolpetrut: Probably not...  lol16:05
geguileolpetrut: But I haven't gone through all the APIs checking16:05
lpetrutgeguileo: I can take a quick look to see where sqlalchemy models are still used. I may send a patch to see what the CIs say about it, if we pass VOs all the time.16:06
geguileolpetrut: Ping me once you have a patch and I'll help with the reviews16:07
lpetrutgeguileo: it would be great to have the manager consistent in what it passes to the drivers, while the drivers would not have to do extra checks on what they receive16:07
lpetrutgeguileo: sure, thanks a lot for your help guys16:07
geguileolpetrut: I agree, and we are working towards it16:07
geguileolpetrut: Now with your help we'll be a step closer :-)16:07
*** Poornima has quit IRC16:08
*** merooney has quit IRC16:11
*** cbinx has joined #openstack-cinder16:13
*** hemnafk is now known as hemna16:15
*** jwcroppe has joined #openstack-cinder16:15
*** Poornima has joined #openstack-cinder16:16
*** shausy has quit IRC16:16
*** gcb has quit IRC16:17
*** mmotiani has joined #openstack-cinder16:18
*** jungleboyj has joined #openstack-cinder16:18
Swansonfailover host is claiming "Host replication_status must be enabled or failed-over to failover." Is there anything other than replication_enabled that I need to be setting?16:19
*** BigWillie has quit IRC16:20
*** arecknag has quit IRC16:21
*** jwcroppe has quit IRC16:23
*** chris_morrell has joined #openstack-cinder16:27
*** bjornar has quit IRC16:27
*** edtubill has quit IRC16:30
*** gcb_ has joined #openstack-cinder16:30
*** edtubill has joined #openstack-cinder16:31
*** Poornima has quit IRC16:31
*** Poornima_K has joined #openstack-cinder16:31
*** Poornima_K is now known as Poornima16:31
*** Poornima has quit IRC16:32
smcginnishemna: Any idea how to enabled blueprints on https://launchpad.net/os-brick16:32
*** anshul has quit IRC16:32
*** dims has quit IRC16:33
aorourkeSwanson, that should be all you need to do.16:33
aorourkeSwanson, but replication_enabled cannot be reported in a pool16:33
*** laughterwym has quit IRC16:33
hemnasmcginnis, err, I think the project might be borked.   I dunno16:33
smcginnishemna: I don't see any kind of settings for that.16:34
smcginnisNot a big fan of launchpad.16:34
*** sasukeh has joined #openstack-cinder16:35
jgriffithaorourke: why not?16:35
aorourkejgriffith, it didn't work last time i tried it16:35
aorourkemight have changed though16:35
jgriffithaorourke: IIRC pools are presented just like any other c-vol16:35
jgriffithaorourke: just the extra suffix, no?  Maybe that's changed?16:36
aorourkejgriffith, i would have to try it again to confirm16:36
jgriffithaorourke: hmm... I don't have anything that does pools so I'm useless to you :)16:36
*** chris_morrell has quit IRC16:37
jgriffithhemna: did you never set up a team page?  https://launchpad.net/~os-brick ?16:38
openstackgerritDanny Al-Gaaf proposed openstack/cinder: Pass RBD order to clone call  https://review.openstack.org/28998716:38
sheelsmcginnis: hi16:40
*** sasukeh has quit IRC16:40
sheelsmcginnis: are we planning https://review.openstack.org/#/c/285293/ in mitaka?16:40
sheelstevemar: its related to microversioning...16:41
sheelsorry it was for smcginnis16:41
sheelsmcginnis: its related to microversioning..16:41
*** gcb_ has quit IRC16:41
Swansonaorourke, No pools.  No failover joy.  The host on the failover-host command is the full string from cinder service-list, right?16:42
SwansonNot seeing anything outside of c-api...16:42
*** chris_morrell has joined #openstack-cinder16:42
patrickeastSwanson: whats the output of service-list --withreplication ?16:42
patrickeastSwanson: is it showing up as enabled for replication?16:42
aorourkeSwanson, yes. and with what patrickeast said, you can see the replicaiton states of each host16:43
*** gcb_ has joined #openstack-cinder16:43
SwansonNot-capable16:43
SwansonWell.  There.16:43
patrickeastSwanson: mm thats your problem right there16:43
_alastor_Hey folks, is there a maximum amount of time that Nova/Cinder will wait for a request to complete from a driver?  Is that documented somewhere?16:44
SwansonI hate replication.16:44
*** dims has joined #openstack-cinder16:44
SwansonOkay.  Well, where on earth does that get set?16:44
patrickeastSwanson: whats your stats update look like?16:44
aorourkeSwanson, replication_enabled must not be set correctly then?16:44
*** chris_morrell has quit IRC16:44
patrickeastSwanson: the manager looks at the stats/capabilities on driver init16:44
scottdasmcginnis: sheel To be clear, That fix for microversions is not currently used by anyone, but it is a dependency for sheel's bootable filter fix: https://review.openstack.org/#/c/278605/16:45
sheelscottda: right.. :)16:45
patrickeast_alastor_: there are some commands that can time out from the rpc's, they are configurable though, and some of the like 'orchestrated' stuff from nova that calls cinder can fail with some other configurable timeouts that nova will wait for things to become available16:45
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/28834416:46
scottda_alastor_: I think most/all calls from Nova down to the Cinder driver are aysnc.16:46
patrickeast_alastor_: not sure if there is one nice place where they are all documented16:46
*** chris_morrell has joined #openstack-cinder16:46
patrickeastscottda: +116:46
*** avishay has quit IRC16:46
jgriffithSwanson: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L53616:46
*** akshai has quit IRC16:46
*** yuriy_n17 has quit IRC16:47
scottda_alastor_: But Nova can timeout waiting for state in Cinder to change, as patrickeast has said.16:47
_alastor_patrickeast: Ok.  I'm looking into implementing some retry logic in a driver and I'm trying to figure out the maximum amount of time I can take for retries before Cinder starts complaining.16:47
*** yuriy_n17 has joined #openstack-cinder16:47
jgriffith_alastor_: http://docs.openstack.org/developer/cinder/devref/attach_detach_conventions.html16:47
SwansonOMG paste is slow!16:48
jgriffith_alastor_: there are the old "nova volume-create/delete" calls in there still too but honestly the only Nova specific calls are those listed in attach/detach sequence16:48
jgriffith_alastor_: that doc has all of them16:48
*** akshai has joined #openstack-cinder16:49
_alastor_jgriffith: Thanks16:49
jgriffith_alastor_: you're most welcome16:49
*** e0ne has quit IRC16:50
*** chris_morrell has quit IRC16:50
*** belmoreira has quit IRC16:52
patrickeastjgriffith: oh, speaking of timeouts...16:52
SwansonWell, this shows up first in the list http://paste.openstack.org/show/489878/16:52
* jgriffith runs16:52
*** IlyaG has joined #openstack-cinder16:52
*** wolsen has quit IRC16:52
patrickeastjgriffith: remember that time i was like 'oh yea, failover can totally be call and we'll return the id and blah blah'16:52
*** wolsen has joined #openstack-cinder16:52
jgriffithSwanson: just trap on init int he manager and see if you're setting it or not16:52
patrickeastjgriffith: i miiiiight be changing my mind :(16:52
jgriffithpatrickeast: oh suuuure!!!16:52
jgriffithpatrickeast: see how you are!16:53
patrickeasthaha16:53
aorourkejgriffith,  I dumped stats in this case (https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L536) and when you have replicaiton_enabled in the pool, it does not register it16:53
jgriffithpatrickeast: rpc timeouts on the faiover op in the driver?16:53
patrickeastjgriffith: so it works fine for like a reasonably small number of volumes, which was my thinking from the past replication stuff16:53
patrickeastjgriffith: yea16:53
patrickeastjgriffith: but if like the backend has thousands16:53
*** haomaiwang has quit IRC16:53
patrickeastjgriffith: in my particular case i make 1 rest api call per volume16:54
patrickeastjgriffith: it adds up..16:54
jgriffithpatrickeast: yeah, I thought of that when I looked at avishay's patch the other day :(16:54
jgriffithpatrickeast: which sucks, because the only way to fix it is make that sync then introduce a new call to get backend-id16:54
jgriffith:(16:54
patrickeastjgriffith: granted i can always just put in the docs that if you have lots of volumes and you plan to failover just bump the rpc timeout up16:54
jgriffithpatrickeast: yeah, but that SUCKS16:55
*** jdurgin1 has joined #openstack-cinder16:55
patrickeastjgriffith: why a new call? we save it in the db and you see it with service-list16:55
patrickeastjgriffith: we just wont return it16:55
jgriffithpatrickeast: what we really need is individual rpc timeout values :)16:55
jgriffithpatrickeast: Ahh... yeah, that would work16:55
jgriffithpatrickeast: dErP16:55
jgriffithpatrickeast: ok, you want to do the honors or shall I?16:56
*** EinstCrazy has joined #openstack-cinder16:56
patrickeastjgriffith: i can pick this one up if you want16:56
patrickeasti've got some time open16:56
patrickeasttoday*16:56
jgriffithpatrickeast: that would be super awesome if you don't mind16:56
* jgriffith gets easily distracted as it is16:57
patrickeasthaha16:57
jgriffithSQUIRELL!!!16:57
jgriffithjungleboyj: smcginnis did you guys see my post on the ML regarding test length?16:57
jgriffithjungleboyj: smcginnis more specifically the point that mtreinish noted about "we already have that"16:58
jgriffithjungleboyj: smcginnis it's just set crazy high be default.  So we can just modify it.  I was going to push a patch but want to wait until we get through RC's16:58
jgriffithincase there are weird timing issues/failures that show up in the gate after dropping it down16:59
jgriffithI'll push the patch as WIP for now and we can just merge after things settle16:59
*** gcb_ has quit IRC16:59
duleklpetrut: Sorry, meeting. To access volume metadata in a consistent way you should use volume.volume_metadata.17:00
*** timcl has quit IRC17:00
*** haomaiwang has joined #openstack-cinder17:00
jgriffithmetadata should die in a fire17:00
lpetrutdulek: no worries. what about volume type extra specs ? :)17:00
* jgriffith is just sayin17:00
duleklpetrut: That will be list of SQLAlchemy objects in SQLAlchemy and list of MetadataObject in o.vo.17:00
duleklpetrut: Ooooh…17:00
*** haomaiwang has quit IRC17:01
duleklpetrut: I've never looked into that after thangp implemented it…17:01
duleklpetrut: Awww, this sucks so much - looks like we don't have a consistent implementation between SQLA and o.vo…17:02
lpetrutyep17:02
lpetrutdulek: so, your patch fixed the issue for volume metadata (https://review.openstack.org/#/c/247763/), but the volume type extra specs are still inconsistent17:03
*** EinstCrazy has quit IRC17:03
duleklpetrut: Yeah.17:03
duleklpetrut: At this stage of the release I would say that safest idea would be to probe it in the driver to see what's inside… :(17:04
lpetrutso, I thought that rather than doing some checks on the driver side, it would be better to make sure we always pass VOs to the drivers17:04
duleklpetrut: With a FIXME comment. :(17:04
lpetrutgot it17:04
duleklpetrut: I don't know if we won't break other drivers if we switch it suddenly.17:04
dulekOr is it the only place you're getting an SQLA obj?17:05
*** vincent_hou has quit IRC17:05
openstackgerritJohn Griffith proposed openstack/cinder: Modify default timeout for testr to 20 seconds  https://review.openstack.org/29069517:05
duleklpetrut: It probably isn't.17:05
Swansonhmm... restarted the services and replication was enabled.  Neato.  Something blew up, tho....17:06
*** BigWillie has joined #openstack-cinder17:06
*** jistr has quit IRC17:06
duleklpetrut: https://review.openstack.org/#/c/263765/17:07
lpetrutdulek: yeah, I guess there may be some leaked sqla objects in a few other places. I thought about trying to find this kind of situations, simply try to replace those with VOs, send a patch and see what the CIs say about it. But as you said, it may a bit to late for this release to make such a change17:07
duleklpetrut: That's abandoned just because DuncanT did that to discourage people to put work in patches unmerge'able in this state.17:07
*** laughterwym has joined #openstack-cinder17:08
*** haomaiwa_ has joined #openstack-cinder17:08
duleklpetrut: Yes, its late. I'm deeply ashamed that we have inconsistent driver interfaces, sorry. :(17:08
lpetrutdulek: thanks for mentioning that patch (actually chain of patches).17:08
duleklpetrut: https://review.openstack.org/#/q/topic:bp/cinder-objects17:09
*** apoorvad has joined #openstack-cinder17:09
*** rcernin has quit IRC17:09
duleklpetrut: Don't care if any of them is abandoned, that was purely procedural.17:09
lpetrutdulek: that's great. I guess I should first check for existing patches/bps before searching through the code/submitting a new one :)17:09
lpetrutdulek: well, I'll take care of this at the driver level for now. Thanks a lot for the info17:10
openstackgerritMerged openstack/cinder: Fix failure with rbd on slow ceph clusters  https://review.openstack.org/28925217:11
duleklpetrut: Thank you for finding this problem. I'll watch to sort it out in Newton.17:11
*** laughterwym has quit IRC17:12
*** merooney has joined #openstack-cinder17:14
jungleboyjjgriffith: So, the idea is, if your test runs more than 20 seconds it is going to fail with a timeout?17:20
jgriffithjungleboyj: yes17:20
*** bjornar has joined #openstack-cinder17:20
jgriffithjungleboyj: you an test it by setting that env variable to something like5 seconds17:21
jungleboyjSounds like an easy enough solution.17:21
jgriffithjungleboyj: yeah, mtreinish pointed it out... I completely forgot that setting even existed17:23
mtreinishjungleboyj, jgriffith: well you don't want to get too aggresive setting that you have to account for certain amount of jitter in the run time17:24
jgriffithmtreinish: hehe17:25
jungleboyjjgriffith: Do you want us to merge this after it passes CI or hold it for a while.17:25
jungleboyjmtreinish: I wondered about that.17:25
jgriffithmtreinish: yeah, I doubled our average longest test time  https://review.openstack.org/#/c/290695/117:25
jgriffithmtreinish: if that doesn't account for *jitter* we've got problems IMO :)17:25
jgriffithjungleboyj: I think it's safe, but I certainly don't mind if people want to hold it for a bit and do some stats gathering.  Or wait until after RC's go out17:26
jungleboyjjgriffith: I will defer to smcginnis .  :-)17:27
SwansonHmmm....  getting a raise on failover-host.  Also, I'm only getting replication status enabled after I restart c-vol....17:27
*** sayalilunkad_lap has quit IRC17:27
smcginnisjgriffith: Any concerns running unit tests on a crappy machine?17:28
smcginnisMight be interesting to spin up a resource constrained machine and see if we run into trouble.17:28
jgriffithsmcginnis: I can test that if you like, but frankly the only crappy machine I care about is the infra gate Instances :)17:28
smcginnisjgriffith: Yeah, true. I would hope most don't have problems running it17:29
jungleboyj:-)17:29
smcginnisI'm interested in seeing the gate results on that.17:29
patrickeastSwanson: its only enabled after restart the first time? or like every other time kind of thing?17:29
smcginnisI think it should be fine.17:29
jungleboyjI don't think we have too many test cases that are slowed by resource constraints.  jgregor fixed some of those up a few weeks ago.17:30
Swansonpatrickeast, I havent checked.  I don't allow failback so I kinda have to restack between.17:30
jgriffithSwanson: painful, just stub in a response for failback to make your life easier :)17:31
*** sgotliv has quit IRC17:31
patrickeastSwanson: or just go edit the db17:32
Swansonpatrickeast, jgriffith This https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L536 isn't being called until I restart c-vol.17:32
patrickeastSwanson: pretty easy to just change the service table17:32
jgriffithSwanson: do you want/need my lvm driver that implements this stuff?17:32
jgriffithSwanson: lemme see if I still have it17:32
Swansonjgriffith, I'll take it.17:32
patrickeastSwanson: i'll try and repro that.... looking at the code i have no idea why it would only call after restart though, is weird17:33
jgriffithSwanson: lemme see if I still have it17:33
jgriffithSwanson: hmm... I don't think I do17:35
jgriffithSwanson: it's EZ PZ though17:35
*** avishay has joined #openstack-cinder17:35
jgriffithjust update capabilities and stub in the failover method17:35
jgriffithnothing to it17:35
*** esker has joined #openstack-cinder17:36
jgriffithMy Nova Instance apparantly has died17:36
*** sasukeh has joined #openstack-cinder17:37
*** timcl has joined #openstack-cinder17:37
*** esker has quit IRC17:38
*** sasukeh has quit IRC17:41
*** lpetrut has quit IRC17:49
geguileodulek: ping - https://review.openstack.org/#/c/290569/17:49
*** lpetrut has joined #openstack-cinder17:49
*** dustins_ has joined #openstack-cinder17:54
*** dustins has quit IRC17:55
*** avishay has quit IRC17:57
*** lpetrut has quit IRC17:57
*** diablo_rojo has quit IRC17:58
*** ChubYann has quit IRC17:58
*** ChubYann has joined #openstack-cinder17:59
*** haomaiwa_ has quit IRC18:01
*** 20WAAIK4T has joined #openstack-cinder18:01
*** merooney has quit IRC18:02
*** Suyash has joined #openstack-cinder18:02
*** laughterwym has joined #openstack-cinder18:03
*** vincent_hou has joined #openstack-cinder18:03
*** jungleboyj has quit IRC18:03
*** dustins_ has quit IRC18:03
openstackgerritMerged openstack/cinder: Imported Translations from Zanata  https://review.openstack.org/29029918:05
*** akshai has quit IRC18:06
*** laughterwym has quit IRC18:07
*** meagleso has joined #openstack-cinder18:13
meaglesocan Liberty Cinder run without issue with a Kilo Nova?18:14
*** akshai has joined #openstack-cinder18:14
dulekgeguileo: This is why I've decided to add additional joinedload: https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L142118:14
dulekgeguileo: Basically I haven't seen a way to differentiate between _from_db_object for a volume_type for list and for show.18:15
dulekgeguileo: I'll take a closer look a little later.18:15
dulekgeguileo: Ah, and I understand your point of course. :)18:15
*** martyturner1 has joined #openstack-cinder18:17
*** martyturner has quit IRC18:18
geguileodulek: Where do you want to differentiate between the show and the list?18:18
geguileodulek: Oh, I think I see your point18:19
dulekgeguileo: https://github.com/openstack/cinder/blob/master/cinder/objects/volume.py#L248-L25318:19
dulekgeguileo: Okay, obj_make_list seems to be able to take extra_args.18:20
dulekgeguileo: So it should be possible. I'll post a new version as soon as I can. :)18:20
dulek(which may be tomorrow morning)18:21
*** jordanP has quit IRC18:21
geguileodulek: Ok, thanks18:21
geguileodulek: I appreciate the extra effort18:21
dulekgeguileo: Thanks for being diligent, I've just looked too shallow and assumed it would be hard.18:22
geguileodulek: Jaja18:22
*** vincent_hou has quit IRC18:22
* dulek just got his Austin travel approved!18:24
*** jgregor has quit IRC18:25
*** akerr has quit IRC18:25
*** crose has joined #openstack-cinder18:26
*** crose has quit IRC18:27
*** crose has joined #openstack-cinder18:27
*** IlyaG has quit IRC18:27
*** mvk has quit IRC18:27
*** crose has quit IRC18:28
*** crose has joined #openstack-cinder18:28
*** IlyaG has joined #openstack-cinder18:28
mc_nairdulek: nice!18:29
*** e0ne has joined #openstack-cinder18:29
*** takedakn has joined #openstack-cinder18:29
*** takedakn has quit IRC18:30
mc_nairI preordered some Franklins bbq for that Tuesday so people can try it18:30
*** martyturner1 has quit IRC18:30
openstackgerritMerged openstack/cinder: Dell SC: create_cloned_volume didn't honor size  https://review.openstack.org/29016418:32
*** ildikov has joined #openstack-cinder18:33
sheelsmcginnis: hi18:33
*** jdurgin1 has quit IRC18:34
sheelsmcginnis: is there any chances of  https://review.openstack.org/#/c/285293/ in mitaka?18:34
sheel To be clear, That fix for microversions is not currently used by anyone, but it is a dependency for my bootable filter fix: https://review.openstack.org/#/c/278605/18:34
*** mriedem has quit IRC18:36
*** mriedem has joined #openstack-cinder18:36
*** sasukeh has joined #openstack-cinder18:38
*** liewegas_ has quit IRC18:38
*** sage has joined #openstack-cinder18:39
*** sasukeh has quit IRC18:42
*** grumpycatt has quit IRC18:43
*** dims has quit IRC18:44
*** grumpycatt has joined #openstack-cinder18:45
*** jgregor has joined #openstack-cinder18:45
*** dims has joined #openstack-cinder18:46
*** meagleso has left #openstack-cinder18:47
*** akerr has joined #openstack-cinder18:49
krotscheckAny cores around to help review this mitaka bug? https://review.openstack.org/#/c/286795/18:55
* krotscheck had to rebase it a few times when the gate broke18:55
openstackgerritNate Potter proposed openstack/cinder: Added more options while uploading volume as image  https://review.openstack.org/23061718:57
*** rlrossit has quit IRC18:58
*** lpetrut has joined #openstack-cinder18:58
*** jwcroppe has joined #openstack-cinder18:59
*** rlrossit has joined #openstack-cinder19:00
*** 20WAAIK4T has quit IRC19:01
*** markvoelker has quit IRC19:01
*** haomaiwa_ has joined #openstack-cinder19:01
openstackgerritNate Potter proposed openstack/python-cinderclient: Add options when uploading images to Glance  https://review.openstack.org/23062219:02
*** markvoelker has joined #openstack-cinder19:03
*** garthb has joined #openstack-cinder19:05
*** liverpooler has joined #openstack-cinder19:06
*** dustins has joined #openstack-cinder19:06
*** huanan_L has quit IRC19:09
*** huanan has joined #openstack-cinder19:10
*** haomaiwa_ has quit IRC19:13
*** boris-42 has quit IRC19:14
*** haomaiwa_ has joined #openstack-cinder19:14
*** markvoelker has quit IRC19:17
*** markvoelker has joined #openstack-cinder19:18
*** SergeyLukjanov has quit IRC19:19
*** robcresswell has joined #openstack-cinder19:19
*** bardia has joined #openstack-cinder19:20
*** SergeyLukjanov has joined #openstack-cinder19:21
tbarronjgriffith: looks like test_migrations has cases that take more than 20s in gate :(19:22
tbarronmaybe set to 30s for now?19:22
jgriffithtbarron: oh?19:22
*** ociuhandu has quit IRC19:23
tbarronjgriffith: at least that's the way I'm reading jenkins on 29069519:23
* jgriffith looks19:23
tbarronI don't see them take that long running locally19:23
jgriffithtbarron: hmm... if that fixture timeout hits that's the exception you'd see19:24
jgriffithtbarron: not sure what's up here19:24
jgriffithtbarron: these all seem to be pymysql errors19:24
jgriffithtbarron: makes me wonder if there's something else going on here19:24
*** lpetrut has quit IRC19:25
tbarronjgriffith: yeah19:25
jgriffithtbarron: OHHH19:25
jgriffithtbarron: nah... there it is19:25
*** lpetrut has joined #openstack-cinder19:25
jgriffith2016-03-09 17:13:57.295 |         raise TimeoutException()19:25
jgriffithtbarron: wtf19:25
*** lpetrut has quit IRC19:25
jgriffithtbarron: and why would the db migration test take so long I wonder19:26
*** lpetrut has joined #openstack-cinder19:26
tbarronwhen I run test_migrations locally a bunch of the tests are skipped b/c DB backends are unavailable19:26
jgriffithtbarron: there's something else interesting going on here I suspect19:26
tbarronso I don't see them taking a long time.19:26
jgriffithtbarron: I was using samples straight out of Jenkins earlier19:26
jgriffithkinda surprised there would be this much variance in here19:27
bswartztbarron: I've seen the same problem in Manila19:27
bswartzmight be an infra issue19:27
jgriffithtbarron: bswartz http://paste.openstack.org/show/489895/19:28
tbarronbswartz: slow migration tests when the mysql or postgreql are available?19:28
jgriffithso that hangs up... and then the timeout is hit19:28
openstackgerritNate Potter proposed openstack/cinder: Show qos_specs_id based on policy  https://review.openstack.org/24165919:28
jgriffithwonder if there was an update to pymysql that broke something19:28
tbarronjgriffith: bswartz: yeah, may be infra/cross-project issue19:29
jgriffithtbarron: strange... well thanks for pointing it out19:29
jgriffithtbarron: I'll just let that dude sit for a bit and circle back later this week19:29
jgriffithtomorrow19:29
jgriffithwhenever19:29
jgriffith:)19:29
tbarronjgriffith: sure19:29
jgriffiththere's a lot of red going on in the gate right now it seems19:29
*** merooney has joined #openstack-cinder19:30
*** dustins has quit IRC19:31
*** martyturner has joined #openstack-cinder19:31
ntpttrjgriffith: smcginnis: sorry to bug, but if either of you have a moment would you mind giving https://review.openstack.org/#/c/241659/ a review? It fixes a problem that gives the user admin context when they don't necessarily need it and it's been hanging around for a while :)19:32
*** laughterwym has joined #openstack-cinder19:32
jgriffithntpttr: looking19:32
ntpttr(it was me that added that issue in the first place a little before that though hah)19:33
ntpttrjgriffith: thanks19:33
jgriffithntpttr: hehe... story of *MY* life :)19:33
*** jgregor has quit IRC19:35
jgriffithntpttr: small question regarding the validate-policy method....19:36
jgriffithntpttr: I'm a bit confused... I mean; it's great you moved that into common.py19:36
jgriffithntpttr: I'm trying to figure out why we had it in types and qos at all?19:36
jgriffithntpttr: as opposed to wrapping the volume.api method?19:37
*** jwcroppe has quit IRC19:37
*** laughterwym has quit IRC19:38
jgriffithntpttr: ahh... I see what ya did there19:38
jgriffithntpttr: it's because you're only using policy to impact the view19:38
*** sasukeh has joined #openstack-cinder19:38
*** dustins has joined #openstack-cinder19:39
*** mvk has joined #openstack-cinder19:39
ntpttrjgriffith: yeah, so it needs to just be able to return true or false rather than just throw an exception19:40
jgriffithguitarzan: would you mind taking a look since you -1'd earlier?  https://review.openstack.org/#/c/241659/1419:40
openstackgerritTom Swanson proposed openstack/cinder: Dell SC: Active_backend_id wrong type  https://review.openstack.org/29080619:41
guitarzanjgriffith: ntpttr: sure, I noticed gerrit happily sent me an email about this19:42
guitarzanfrom nov 4th, wow19:42
*** pots has quit IRC19:42
SwansonGoing to submit every patch with a subject of "Dell SC: Words long"19:42
ntpttrhaha yeah it's been there a little while guitarzan. thanks!19:42
*** sasukeh has quit IRC19:43
*** dustins has quit IRC19:44
*** ociuhandu has joined #openstack-cinder19:44
*** sdague has quit IRC19:45
*** pots has joined #openstack-cinder19:45
ntpttrjgriffith: looks like you +2ed the adding of the validate_policy method there in one of my earliest cinder patches, for specifically viewing extra_specs19:47
ntpttrhttps://review.openstack.org/#/c/237075/619:47
*** edtubill has quit IRC19:48
*** edtubill has joined #openstack-cinder19:50
*** salv-orlando has joined #openstack-cinder19:51
guitarzanntpttr: that definitely looks more like what you were after :)19:51
*** salv-orl_ has joined #openstack-cinder19:53
ntpttrguitarzan: yeah for sure, was definitely missing some needed fixes there at first.19:53
*** diablo_rojo has joined #openstack-cinder19:53
*** BigWillie has quit IRC19:54
*** IlyaG has quit IRC19:54
*** sdague has joined #openstack-cinder19:54
*** salv-orlando has quit IRC19:56
*** vincent_hou has joined #openstack-cinder19:56
*** rlrossit has quit IRC19:58
ntpttroops looks like it's about to fail pep8 based on a little change I made. Have to push up one more patch.19:58
*** jungleboyj has joined #openstack-cinder20:00
*** haomaiwa_ has quit IRC20:01
*** jgregor has joined #openstack-cinder20:01
*** baumann has left #openstack-cinder20:01
openstackgerritNate Potter proposed openstack/cinder: Show qos_specs_id based on policy  https://review.openstack.org/24165920:01
guitarzanack, was it the indentation?20:01
*** haomaiwang has joined #openstack-cinder20:01
*** rhagarty has joined #openstack-cinder20:01
*** rlrossi__ has joined #openstack-cinder20:02
ntpttrguitarzan: yeah I took out a paren because checking for the admin context was redundant, and that made it want me to move the indentation back a full four spaces20:02
guitarzanhmm, I think that's a subjective pep8 thing20:04
*** yangyape_ has joined #openstack-cinder20:08
*** mrrowden has joined #openstack-cinder20:08
*** yangyapeng has quit IRC20:09
jgriffithntpttr: indeed, I did :)20:09
*** garthb has quit IRC20:09
*** baumann has joined #openstack-cinder20:10
*** jwcroppe has joined #openstack-cinder20:19
*** jwcroppe has quit IRC20:21
*** martyturner has quit IRC20:28
*** martyturner has joined #openstack-cinder20:30
*** timcl has quit IRC20:31
*** timcl1 has joined #openstack-cinder20:31
*** ircuser-1 has quit IRC20:36
*** sasukeh has joined #openstack-cinder20:39
openstackgerritTom Swanson proposed openstack/cinder: Dell SC: Active_backend_id wrong type  https://review.openstack.org/29080620:42
openstackgerritNate Potter proposed openstack/cinder: Added more options while uploading volume as image  https://review.openstack.org/23061720:42
*** salv-orl_ has quit IRC20:43
*** sasukeh has quit IRC20:45
*** merooney has quit IRC20:47
diablo_rojodulek: Question for you :) So I am working on the patch to make volumes attach_status into a versioned object enum and I am trying to figure out how I need to bump the rpc versions. I updated volumeAttachment but do I also need to update Volume since I touched objects/volume.py?20:47
*** tsufiev has left #openstack-cinder20:48
*** edtubill has quit IRC20:49
openstackgerritVincent Hou proposed openstack/cinder: Storwize: Update replication to v2.1  https://review.openstack.org/28748320:50
*** ircuser-1 has joined #openstack-cinder20:51
*** IlyaG has joined #openstack-cinder20:52
diablo_rojodulek: That is assuming I need to bump the version at all when I only changed one field in volume.py and volume_attachment.py20:53
*** merooney has joined #openstack-cinder20:53
*** e0ne has quit IRC20:53
*** sgotliv has joined #openstack-cinder20:57
*** haomaiwang has quit IRC21:01
*** haomaiwang has joined #openstack-cinder21:01
*** Lee1092 has quit IRC21:02
*** sgotliv has quit IRC21:03
*** dims has quit IRC21:05
*** merooney has quit IRC21:06
*** mrrowden has quit IRC21:09
*** lcurtis has joined #openstack-cinder21:10
openstackgerritPatrick East proposed openstack/cinder: Switch failover-host from rpc call to cast  https://review.openstack.org/29085721:13
*** bill_az has joined #openstack-cinder21:16
*** porrua has quit IRC21:19
*** markvoelker has quit IRC21:20
*** sdague_ has joined #openstack-cinder21:24
patrickeastjgriffith: ^21:26
jgriffithpatrickeast: ohhh... excellllent21:26
*** kprabhu has quit IRC21:27
*** sheel has quit IRC21:27
patrickeastjgriffith: i switched it over, but as i'm looking at some of the output now from the api i'm wondering if i need to make it return a 202 instead of 200 now too21:27
jgriffithpatrickeast: :)21:27
*** kprabhu has joined #openstack-cinder21:27
jgriffithI was just commenting that we need to update cinder.api.contrib.service21:28
jgriffithpatrickeast: other than that so far so good21:28
*** akerr has quit IRC21:28
patrickeastjgriffith: turned out to be super easy to change21:28
jgriffithpatrickeast: so other than tht LGTM21:28
jgriffithpatrickeast: yeah, the nice thing about Cheesecake is it has very limited ingredients21:29
jgriffithpatrickeast: so it's not like unraveling the world to change something21:29
patrickeastjgriffith: yea def, its a nice change of pace for replication features :D21:29
jgriffithpatrickeast: we'll see if lasts, once you start throwing rasberries, caramel or god forbid cherries on it :)21:30
patrickeastjgriffith: yea i mean... you've got all those fancy marbled cheesecakes and what not too21:30
jgriffithpatrickeast: yeah... theyr'e all just marketing hype for the grahm cracker industry21:31
patrickeastlol21:31
openstackgerritGorka Eguileor proposed openstack/cinder: Remove API races from consistency groups  https://review.openstack.org/25942921:36
*** dims has joined #openstack-cinder21:37
*** sasukeh has joined #openstack-cinder21:40
*** kprabhu has quit IRC21:43
*** sasukeh has quit IRC21:44
*** cknight has quit IRC21:50
openstackgerritPatrick East proposed openstack/cinder: Switch failover-host from rpc call to cast  https://review.openstack.org/29085721:51
*** martyturner has quit IRC21:52
*** dims has quit IRC21:56
*** ndipanov has quit IRC21:57
*** timcl1 has quit IRC21:57
*** garthb has joined #openstack-cinder21:58
*** dims has joined #openstack-cinder21:58
*** martyturner has joined #openstack-cinder21:59
openstackgerritJay Bryant proposed openstack/cinder: Remove remaining oslo-incubator code from Cinder  https://review.openstack.org/29087522:00
*** haomaiwang has quit IRC22:01
*** haomaiwang has joined #openstack-cinder22:01
*** gouthamr has quit IRC22:02
*** eharney has quit IRC22:04
*** bardia has quit IRC22:06
*** lprice has quit IRC22:07
openstackgerritVincent Hou proposed openstack/cinder: Storwize: Update replication to v2.1  https://review.openstack.org/28748322:07
*** baumann has left #openstack-cinder22:08
*** knikolla has quit IRC22:10
*** eharney has joined #openstack-cinder22:11
*** IlyaG has quit IRC22:16
*** sdague_ has quit IRC22:17
*** sdague has quit IRC22:17
*** david-lyle has quit IRC22:19
*** dave-mccowan has quit IRC22:20
*** david-lyle has joined #openstack-cinder22:20
*** jordant has joined #openstack-cinder22:22
*** krtaylor has quit IRC22:23
*** gouthamr has joined #openstack-cinder22:23
*** jordant has quit IRC22:24
*** jordant has joined #openstack-cinder22:25
diablo_rojopatrickeast: Question for you.22:25
patrickeastdiablo_rojo: sure, whats up?22:25
*** IlyaG has joined #openstack-cinder22:25
diablo_rojopatrickeast: Sean had mentioned you knew the command to get back to a local reference in git when you accidentally commit files before continuing a rebase?22:26
Swansoninit_host isn't being called on initial startup....22:26
patrickeastdiablo_rojo: ah yea, 'git reflog' is the magic trick22:26
openstackgerritVincent Hou proposed openstack/cinder: Storwize: Update replication to v2.1  https://review.openstack.org/28748322:26
patrickeastdiablo_rojo: it shows you all the points things have changed, and you can just checkout or reset back to whatever point you want22:27
patrickeastSwanson: oh weird22:27
diablo_rojopatrickeast: Thank you :)22:27
patrickeastSwanson: that sounds like a bug22:27
patrickeastdiablo_rojo: np22:27
Swansonpatrickeast, There is a LOG.info right at the beginning of init_host and I am not seeing it in my c-vol log...22:28
*** jgregor has quit IRC22:28
patrickeastSwanson: that would certainly explain why the host wouldn't have replication enabled until restarting22:28
SwansonWait, there it is.22:29
*** dims has quit IRC22:29
SwansonI should just go home.22:29
patrickeastlol22:29
*** [1]Thelo has joined #openstack-cinder22:30
SwansonService not found for updating replication_status.22:31
*** mriedem has quit IRC22:31
*** bardia has joined #openstack-cinder22:32
*** crose has quit IRC22:32
*** Thelo has quit IRC22:33
*** [1]Thelo is now known as Thelo22:33
patrickeastSwanson: from this place https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L528 ?22:33
SwansonThat would be it.22:33
patrickeastmm thats not great22:34
patrickeasti like jgriffith's comment there22:34
SwansonYeah, saw that.22:34
openstackgerritKendall Nelson proposed openstack/cinder: Add VolumeAttachStatus Enum  https://review.openstack.org/29088522:34
*** dave-mccowan has joined #openstack-cinder22:34
patrickeastSwanson: oh yea, sure enough looking at my c-vol logs i have that message too22:35
jgriffithpatrickeast: :)22:35
patrickeastSwanson: i must have just some way or another required restarting the service before I actually looked at the status22:35
jgriffithpatrickeast: I was just being honest22:35
Swansonpatrickeast, Shared pain.22:35
*** krtaylor has joined #openstack-cinder22:36
patrickeastjgriffith: Swanson: so uh... i guess that means the very first time cinder starts up the service isn't in the db yet (or with enough info) and that query fails?22:36
*** tpsilva has quit IRC22:37
jgriffithpatrickeast: Swanson that shouldn't be the case....22:37
jgriffithpatrickeast: Swanson so what that would indicate to me is that the driver didn't init22:37
jgriffithpatrickeast: Swanson which is odd22:37
patrickeastjgriffith: whys that?22:37
patrickeastoh wait22:37
Swansonjgriffith, it works tho!22:38
jgriffithSwanson: ?22:38
patrickeastjgriffith: if its calling this *in* the init call... of course it wont be init'ed22:38
jgriffithpatrickeast: ohhhh..... hrmm22:38
patrickeastjgriffith: unless we set the driver status earlier22:38
Swansonjgriffith, I mean the driver clearly inits.  Just doesn't appear to be so at the time it is being called.22:38
* patrickeast should just go read the code22:38
openstackgerritKurt Martin proposed openstack/cinder: LeftHand: Create cloned volume didn't honor size  https://review.openstack.org/29089022:39
patrickeastnvm22:39
jgriffithSwanson: patrickeast so I added that *after* publish_service_capabilities22:39
patrickeasti think we have already called self.driver.set_initialized()22:39
jgriffithmeaning the service *should* be there22:39
jgriffithpatrickeast: yes22:39
*** martyturner has quit IRC22:40
jgriffithwhich means maybe Swanson chose another driver for a reference that does bad things :)22:40
jgriffithjust kidding Swanson22:40
patrickeasthaha22:41
*** sasukeh has joined #openstack-cinder22:41
*** vincent_hou has quit IRC22:41
Swansonjgriffith, solidfire and pure.22:41
jgriffithpatrickeast: Swanson seriously though, the reason I put that comment in there is because weve managed to send an rpc call to the right service22:41
jgriffithpatrickeast: Swanson therefore, we MUST have an entry in the Service table no?22:41
jgriffithpatrickeast: Swanson otherwise, "how did we even get here"22:42
patrickeastexcellent question22:42
patrickeastwho actually calls init_host?22:42
SwansonWell the next line after Driver initialization completed successfully is "Createing RPC server for service sinder-volume.22:42
SwansonI've already coughed up capabilities by this point...22:43
patrickeastoh22:43
patrickeastjgriffith: Swanson: take a look at service.py22:43
jgriffithwell, there certainly could be an issue here if you try and just do it the first go around22:44
patrickeastwe call init_host, and then do the service db stuff22:44
jgriffithcould move that init routine22:44
jgriffithreplication init routine that is22:44
*** dims has joined #openstack-cinder22:44
jgriffithjust set it up on the first capabilities update22:44
patrickeastseems like that would work22:44
*** sasukeh has quit IRC22:46
jgriffithpatrickeast: Swanson I'm still curious as to why it isn't working the way it is22:46
Swanson(Hey! Someone just closed a defect I opened 4 years ago!  Nice.  The product came. So too did the bug.  The product left and took the bug with it. Circle of life.)22:46
jgriffithSwanson: HA!22:46
*** rlrossi__ has quit IRC22:46
openstackgerritKendall Nelson proposed openstack/cinder: Add SnapshotStatus enum field  https://review.openstack.org/28482522:47
jgriffithSwanson: so this call works?  bdrvpn.solidfire.com:443222:47
jgriffithSwanson: but this one doesn't?  https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L52422:47
jgriffithSwanson: errr... um22:48
jgriffithSwanson: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L25822:48
patrickeasti dont think that one would have either22:49
jgriffithseems pretty piss-poor that we're doing things like init_capabilities etc on something that hasn't been initialized in the services table22:49
SwansonNeither seems to work.22:49
patrickeastso looking at https://github.com/openstack/cinder/blob/master/cinder/service.py#L150 which is calling init_host22:50
SwansonWhich is to say I have both errors.22:50
patrickeastits still got a bunch of junk to do initializing the service after it calls it22:50
jgriffithwell that's a kick in the shins22:51
jgriffithnot even sure where half of all that init crap came from.  Or why there's now "2" init methods22:52
*** darosale has quit IRC22:52
jgriffithpatrickeast: Swanson ahh... so init_host is a secondary routine called by service.py22:53
jgriffithsigh22:53
patrickeastjgriffith: looks like we could just add an implementation of init_host_with_rpc to the volume manager22:53
patrickeastjgriffith: its called after we save the service object22:54
patrickeastjgriffith: and is just a noop right now afaik22:54
jgriffithpatrickeast: yeah.... but I'd still like to understand why it isn't working for you guys a bit better22:54
patrickeastprobably why it was added in the first place22:54
jgriffithpatrickeast: because the call after manager.init_host is teh same Service_get_by_args that's failing for Swanson22:54
jgriffithOHHHH22:54
jgriffithheheehehheehehehe22:54
patrickeastyea but if it fails ther22:55
patrickeastit creates it22:55
*** diablo_rojo has quit IRC22:55
jgriffith        except exception.NotFound:22:55
jgriffith            self._create_service_ref(ctxt)22:55
jgriffithyup22:55
patrickeasthaha yea22:55
jgriffithdang it22:55
SwansonOh, nice.22:55
*** diablo_rojo has joined #openstack-cinder22:55
jgriffithbeautiful!22:55
jgriffithso we __init__, init_host, rpc_init_host_with_rpc22:57
patrickeastyep22:57
jgriffithJust throw in another Init_capabilities call... WTF, just another method call22:57
SwansonInit a little, init somewhat more, init it all?22:57
jgriffithwhat could go wrong... can't imagine it causing any confusion 4 months from now22:57
patrickeastsure why not, everybody gets a init hook!22:57
jgriffithinit hooks for ALL methods!!!22:57
patrickeastlol22:57
jgriffithjust like the is_driver_init checks everywhere22:58
jgriffith:)23:01
jgriffithwell crumbs23:01
*** bjornar has quit IRC23:01
jgriffithsorry guys23:01
jgriffithI should've caught that23:01
patrickeasthah don't feel bad... none of us knew how this worked either :p23:01
jgriffithLOL23:01
openstackgerritMitsuhiro Tanino proposed openstack/cinder: Permit volume type operations for policy authorized users  https://review.openstack.org/27420423:01
SwansonI'm pleased there was a rational explanation for what I was seeing.23:01
*** jungleboyj has quit IRC23:01
patrickeastso who wants to put the patch up to move it to init_host_with_rpc?23:01
patrickeastor add init_host_with_replication hooks? XD23:01
*** garthb_ has joined #openstack-cinder23:01
*** haomaiwang has quit IRC23:01
*** garthb has quit IRC23:01

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!