Thursday, 2017-08-03

*** masahito has joined #openstack-blazar00:00
*** hiro-kobayashi has joined #openstack-blazar01:23
*** masahito has quit IRC02:04
*** nicolasbock__ has joined #openstack-blazar03:14
*** hiro-kobayashi has quit IRC04:11
*** hiro-kobayashi has joined #openstack-blazar04:19
openstackgerritHiroaki Kobayashi proposed openstack/blazar-dashboard master: Add validation checks for the update form  https://review.openstack.org/49032904:27
*** bertys_ has joined #openstack-blazar05:28
*** hiro-kobayashi_ has joined #openstack-blazar06:26
*** hiro-kobayashi has quit IRC06:27
*** hiro-kobayashi_ has quit IRC06:36
*** hiro-kobayashi has joined #openstack-blazar06:36
*** masahito has joined #openstack-blazar06:37
openstackgerritMaho Koshiya proposed openstack/blazar master: Add a termination scenario test  https://review.openstack.org/49035106:47
openstackgerritMasahito Muroi proposed openstack/blazar-nova master: Add instance reservation filtering in Blazar filter  https://review.openstack.org/48647606:47
openstackgerritMasahito Muroi proposed openstack/blazar master: Add user guide for the new instance reservation feature  https://review.openstack.org/48830407:15
openstackgerritMasahito Muroi proposed openstack/blazar master: Enable devstack to setup the new instance reservation  https://review.openstack.org/48830207:15
openstackgerritMasahito Muroi proposed openstack/blazar master: Add a release note of the new instance reservation  https://review.openstack.org/48830307:15
openstackgerritPierre Riteau proposed openstack/blazar master: Add a release note of the new instance reservation feature  https://review.openstack.org/48830307:36
*** masahito has quit IRC07:37
*** priteau has joined #openstack-blazar07:39
*** egonzalez has joined #openstack-blazar07:43
openstackgerritPierre Riteau proposed openstack/blazar master: Configure ReservationPool with the blazar admin user  https://review.openstack.org/48779107:51
openstackgerritMerged openstack/blazar master: Revise endpoint creation part of the installation guide  https://review.openstack.org/48953607:55
priteauI don't understand why we're getting this Jenkins error: http://logs.openstack.org/03/488303/5/check/gate-blazar-devstack-dsvm/5960eba/logs/devstack-early.txt.gz#_2017-08-03_07_42_03_40007:57
priteauthere were no changes to the devstack plugin07:57
*** hiro-kobayashi has quit IRC08:07
*** hiro-kobayashi has joined #openstack-blazar08:11
priteauI see, it is caused by another non-merged parent patch08:15
*** openstackgerrit has quit IRC08:18
*** openstackgerrit has joined #openstack-blazar08:18
openstackgerritPierre Riteau proposed openstack/blazar master: Enable DevStack to set up the new instance reservation  https://review.openstack.org/48830208:18
openstackgerritPierre Riteau proposed openstack/blazar master: Enable DevStack to set up the new instance reservation feature  https://review.openstack.org/48830208:20
priteauhiro-kobayashi: I rewrote parts of the commit message for https://review.openstack.org/#/c/487791/ but no code change, you had a +2 before08:21
hiro-kobayashipriteau: thanks!08:21
openstackgerritPierre Riteau proposed openstack/blazar master: Create Nova resources for instance reservations  https://review.openstack.org/48092908:27
openstackgerritPierre Riteau proposed openstack/python-blazarclient master: Convert integer style parameters to integer values  https://review.openstack.org/48903308:37
openstackgerritMerged openstack/blazar master: Configure ReservationPool with the blazar admin user  https://review.openstack.org/48779108:51
*** bertys__ has joined #openstack-blazar08:52
*** masahito has joined #openstack-blazar08:56
masahitopriteau: hiro-kobayashi bertys_: hi, you there?09:01
priteauHello09:01
hiro-kobayashiHi09:02
openstackgerritHiroaki Kobayashi proposed openstack/blazar master: Support before_end parameter in the REST API  https://review.openstack.org/48954909:02
bertys__Bonjour, Hello, Konishiwa );09:02
hiro-kobayashiKonnichiwa :-)09:03
masahitogood morning/evening09:03
masahitolet's start review meeting!09:04
hiro-kobayashi\o/09:04
masahitoI plan to end the meeting after 1h and half later if it finish. then continue to next Monday.09:05
hiro-kobayashiOK for me09:05
masahitois it okay for you?09:05
priteauSounds good09:05
bertys__sure09:05
masahitos/if it finish/ if it doesn't finish/09:06
masahitook, let's start from the beginning of the gerrit.09:06
masahitohttps://review.openstack.org/#/q/status:open+blazar09:06
priteauAre we looking at oldest or newest first?09:07
masahitoI think newest first is better because any activities change the order.09:07
hiro-kobayashiHow about deciding a topic to focus on for the first09:08
hiro-kobayashi?09:08
priteau+1 for topic09:08
masahitohiro-kobayashi: nice idea.09:08
masahitothe category could be 1. bug fix, 2. horizon plugin, 3. instance reservation, 4. other BP09:09
priteauI think Horizon plugin is waiting for an Horizon core to check something09:10
hiro-kobayashipriteau: Horizon core has already CR+1ed for the first patch09:10
masahito'Akihiro Motoki' is a core of Horizon project.09:10
hiro-kobayashihttps://review.openstack.org/#/c/480331/09:10
priteauBut he just sent an email a few minutes ago09:11
priteau"Let me update the alternative approach. I think it is not well documented combined with horizon plugin with runserver. It is worth updating the horizon document. As a horizon core, I will check it."09:11
hiro-kobayashiOh, yeah09:11
hiro-kobayashiThen we should wait for that09:12
masahitoIIHO, he mentioned about tox plugin, doesn't he?09:12
hiro-kobayashimasahito: it cant affect the installation guide09:13
hiro-kobayashis/cant/can09:13
bertys__masahito: this is related to run_tests deprecation. Sorry I am the troublemaker...09:14
masahitos/IIHO/IMHO/09:14
masahitobertys__: np09:14
priteauThese four changes have a bug topic:09:14
priteauhttps://review.openstack.org/#/c/489033/09:14
priteauhttps://review.openstack.org/#/c/490351/09:14
priteauhttps://review.openstack.org/#/c/482532/09:14
priteauhttps://review.openstack.org/#/c/481518/09:14
hiro-kobayashibertys__: I really appreciate your noticing ;-)09:14
bertys__hiro-kobayashi: np09:15
hiro-kobayashithanks priteau09:15
masahitobertys__: hiro-kobayashi: IMO, it's ok to use deprecated one for the first cut.09:15
masahitook, let's start #1 category :-) then discuss Horizon in #209:16
hiro-kobayashiok09:16
hiro-kobayashifor https://review.openstack.org/#/c/489033/09:17
hiro-kobayashithanks for addressing my comments, masahito!09:17
hiro-kobayashiNow It'S LGTM09:17
masahitohiro-kobayashi: thank. then push CR+2 and W+1 :-)09:18
hiro-kobayashidone09:18
masahitonext09:18
masahitohttps://review.openstack.org/#/c/490351/09:18
priteauI haven't checked that one yet09:19
hiro-kobayashime neighther09:19
masahitome neighther09:20
masahitoit's a scenario test patch and pass the gate job.09:20
priteauI am going to fix a typo09:20
priteauI will edit directly if that's OK09:21
masahitomy proposal is if the scenario is ok, ready to go.09:21
openstackgerritMerged openstack/python-blazarclient master: Convert integer style parameters to integer values  https://review.openstack.org/48903309:22
openstackgerritPierre Riteau proposed openstack/blazar master: Add a termination scenario test  https://review.openstack.org/49035109:22
openstackgerritPierre Riteau proposed openstack/blazar master: Add a termination scenario test  https://review.openstack.org/49035109:23
priteauThe new function test_update_host_reservation uses wait_until_aggregated(), but it is defined within test_host_reservation09:24
masahitowhat's the problem?09:25
priteauah no, it has moved in an earlier patch09:25
priteauWe should be looking at this patch first: https://review.openstack.org/#/c/482532/09:25
priteauparent of 49035109:25
bertys__+109:26
masahitoFor the test of resource release, status of the first server created at L275 should be check after lease end.09:26
openstackgerritPierre Riteau proposed openstack/blazar master: Add scenario test of lease expiration  https://review.openstack.org/48253209:29
masahitook, most of us doesn't review the 2 patches yet, so check the scenario and comment.09:30
bertys__ok for me.09:31
priteauIs the order of the test always the same?09:31
masahitoand then the scenario becomes ok, ready to go.09:32
priteauBecause test_lease_expiration() assumes that the host was added to Blazar09:32
masahitopriteau: the order is random09:32
priteauThen I am afraid we might see failures09:33
openstackgerritPierre Riteau proposed openstack/blazar master: Add scenario test of lease expiration  https://review.openstack.org/48253209:34
bertys__#link https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/blazar.yaml#L2709:34
bertys__masahito is the expert09:35
priteauEven if the order is the always the same, it's not good practice to have one test depend on another one having already run09:36
masahitothe regex matches the file name, not for test methods.09:36
hiro-kobayashiThen self.reservation_client.create_host({'name': host['host']}) should be inserted in L222?09:36
priteauMaybe each test should remove the host at the end, so that the next test can add it?09:36
priteauhiro-kobayashi: I think that would might conflict with the host left over by the previous test09:37
priteauor have a function _add_host_once which would take action only if the host doesn't exists yet09:37
masahitopriteau is right. the number of compute hosts for the gate is just one.09:38
hiro-kobayashiUnderstood09:38
priteauShould we ask Maho to fix the patch?09:38
masahitoso one of the right way is each test add and remove the host at beginning and end.09:38
openstackgerritAkihiro Motoki proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar  https://review.openstack.org/48033109:39
bertys__masahito: really?09:39
priteauIf all tests do the same, it can go in setUp/tearDown09:39
bertys__masahito: can we ask for more hosts to infra?09:40
masahitopriteau: we can tell her what the patch is needed to improve. then if no reaction for weeks, we can take it over.09:40
priteauOK09:40
priteauIs she a collegue of yours?09:40
masahitobertys__: ah, the test works concurrently, so it would be good.09:41
masahitopriteau: not my collegue.09:41
masahitopriteau: but a member of NTT group. I heard her name before and she is working on testing things.09:42
priteauGreat to see new contributors!09:42
priteauOK so we will -1 these patches to point out the problem with host create09:43
masahitoright.09:43
priteauShould we move on to the next patch?09:43
hiro-kobayashiyes we should09:43
masahitoyup09:43
masahitohttps://review.openstack.org/#/c/481518/09:44
priteauI have +2 it already09:44
hiro-kobayashiThanks for reviewing it so far09:44
masahitohiro-kobayashi: the difference is just merging one line?09:45
hiro-kobayashiWhich diffrence you mention?09:46
priteauI think masahito is talking about the move of "values['count_range']" assignment09:46
priteauat the bottom blazar/plugins/oshosts/host_plugin.py09:47
masahitobetween patch set 8 and 9 except resolving rebase conflcit.09:47
priteauI asked hiro for this change09:47
masahitoif so, I think it's ok.09:47
hiro-kobayashiyes09:47
masahitogot it.09:48
masahitonext09:48
masahitohttps://review.openstack.org/#/c/481194/09:48
masahitoI -1ed the patch because of the coding style. but the patch fixes the bug well?09:49
hiro-kobayashiI think Yes it fixes the bug09:50
priteauI read your comments but didn't fully understand how you wanted me to change the code. Then I didn't have much time to work on it.09:50
priteauI believe it fixes the bug and there is a test case for it.09:50
masahitohiro-kobayashi: it's ok to merge or should improve the coding you mentioned?09:51
hiro-kobayashiI don't have a strong preference. it's okay to merge09:51
masahitopriteau: sorry, but an explanation.09:51
priteauI would be OK with putting your comments in a bug report for future fixes. I think we might want to rewrite completely this function to make it simpler.09:52
masahitos/but/bad/09:52
hiro-kobayashipriteau: +109:53
masahitoI re-read it today and I thought if we hit a performance issue later we can fix it later.09:53
masahitoso let's merge the patch09:53
priteauThanks09:54
priteauI am creating the bug.09:54
priteauhttps://bugs.launchpad.net/blazar/+bug/170841409:55
openstackLaunchpad bug 1708414 in Blazar "Improve clarity and performance of host_get_all_by_queries" [Undecided,New]09:55
masahitopriteau: thanks!09:56
masahitonext is https://review.openstack.org/#/c/481716/09:56
priteauThanks for the feedback09:56
masahitopriteau: do you have a plan to update it?09:57
masahitosame problem happens in the instance reservation plugin now.09:58
hiro-kobayashimasahito: your commented solution can solve both of host/instance plugins, right?09:59
masahitohiro-kobayashi: maybe09:59
priteauI was working on it but it's not as easy to do in the manager service because the order is quite different10:00
masahitoso the fix is important. if you have not enough time to fix,  I can take it over.10:01
priteauI will try to propose a new patch by Monday10:01
hiro-kobayashithanks priteau!10:02
bertys__thanks10:03
masahitothank.10:03
hiro-kobayashiBTW, the horizon core has updated the installation guide. I think we can merge it for now.10:04
hiro-kobayashihttps://review.openstack.org/#/c/480331/10:04
masahitodoes someone have other bug patches?10:05
masahitoif nothing, we can go Horizon.10:05
bertys__hiro-kobayashi: yep10:05
priteauhiro-kobayashi: I had one comment in the Horizon dashboard10:07
priteauIf you can make URLs https rather than http, that would avoid further patches10:07
priteaue.g. in https://review.openstack.org/#/c/480331/16/README.rst10:07
hiro-kobayashiI'm sorry, I cannot understand10:09
priteauWhen there are links using http:// in OpenStack code, we get a lot of new contributors updating these links to https://10:10
masahitoIt's an easy fix. so fix it now and merge it.10:10
hiro-kobayashiGot it :-)10:10
hiro-kobayashiI'm fixing them10:11
openstackgerritHiroaki Kobayashi proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar  https://review.openstack.org/48033110:12
masahitoDuring the fixing, I've not review the rests of the Horizon patches.10:12
masahitoDoes someone check it?10:12
priteauI haven't checked them yet. I would like to review them.10:13
bertys__masahito: I have shared screenshots. hope this is also helpful for non developers10:14
openstackgerritPierre Riteau proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar  https://review.openstack.org/48033110:14
priteau(only fixed wrong capitalization of OpenStack)10:14
hiro-kobayashipriteau: thanks!10:14
bertys__see e.g. https://imagebin.ca/v/3VSOl4Cwcx4H10:14
masahitobertys__: thanks.10:15
bertys__masahito: np10:16
masahitoso for the other related patches I try to deploy the patch in my local and if it works, I'm ok to gerge.10:17
openstackgerritPierre Riteau proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar  https://review.openstack.org/48033110:17
masahitoI want to include the 5 Horizon patches in P release.10:18
hiro-kobayashiI thinks the base patch https://review.openstack.org/480331 is ready to be merged10:18
priteauhiro-kobayashi: I will remove myself as co-author because I didn't write any of that code10:19
hiro-kobayashiand other patches do not take so much time to review10:19
priteauIt's all from Pablo10:19
masahitoso if no one says it doesn't work without a real scenario by 18th Aug. it's ok to merge.10:19
masahitohow do you think?10:19
hiro-kobayashipriteau: OK.10:19
openstackgerritPierre Riteau proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar  https://review.openstack.org/48033110:19
priteauThere is a comment from Akihiro10:20
hiro-kobayashimasahito: +110:20
priteauhttps://review.openstack.org/#/c/480331/18/doc/source/conf.py@36910:20
bertys__masahito: OK for me.10:21
masahitoyes, and looks fixed now. super quick response.10:21
priteaumasahito: +110:21
priteauah, didn't see Hiro's patch10:22
openstackgerritHiroaki Kobayashi proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar  https://review.openstack.org/48033110:22
masahitook, I'll write the criteria to https://review.openstack.org/#/c/489861/10:23
priteauI don't see it fixed10:23
priteauOK, see it now10:23
hiro-kobayashipriteau: sorry for delay10:23
openstackgerritPierre Riteau proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar  https://review.openstack.org/48033110:23
bertys__masahito: good idea, checking instance reservation is still on my todo list...10:24
openstackgerritMerged openstack/blazar master: Handle more exceptions raised in reserve_resource()  https://review.openstack.org/48151810:24
priteauI have +2 the Horizon dashboard patch10:25
masahitoonce Jenkins has +1ed, I'll add +2.10:26
priteauOK10:26
hiro-kobayashithanks all10:26
bertys__ok10:26
masahitoJenkins is a door keeper10:26
masahitoshould we go next? or end today's review?10:27
masahitonext is series of instance reservation.10:27
hiro-kobayashiI'm okay to continue10:28
priteauI have provided some comments on instance reservation patches, but haven't got through them all yet10:29
openstackgerritMerged openstack/blazar master: Fix host filtering by extra capability  https://review.openstack.org/48119410:29
priteauAlso we need Jenkins to +1 all of them10:29
priteauI fixed a syntax issue in the DevStack plugin which should help10:29
priteaumasahito: Could you check comments and rebase on master, and we'll discuss on Monday?10:30
bertys__masahito: before I forget, are u aware of https://etherpad.openstack.org/p/nova-ptg-queens?10:30
masahitopriteau: oh, I missed one your comment.10:31
masahitoI'll update it later.10:31
bertys__not sure if "spot instances..." will make it to ptg10:31
masahitobertys__: yes.10:31
bertys__but if yes, let's try to be there10:31
masahitoso end the meeting today, then continue on next Mon.10:32
bertys__thanks all10:33
priteauGood job today!10:33
hiro-kobayashiGood progress!10:33
masahitobertys__: yes. I'll ping Nova team and make an schedule it.10:33
hiro-kobayashithanks all10:33
masahitoyes, in the meeting we merged 4 or 5 patches? that's great progress!10:34
masahitosee you in next Monday!10:34
hiro-kobayashiSee you!10:34
masahitobtw, I pushed CR+2 and W+1 button of Horizon Plugin ;-)10:35
priteau\o/10:36
masahitowe finally got Blazar GUI!10:37
hiro-kobayashimasahito: thanks!10:38
openstackgerritHiroaki Kobayashi proposed openstack/blazar master: Support updating capacity of reservations  https://review.openstack.org/48281110:38
*** masahito has quit IRC10:38
*** hiro-kobayashi has quit IRC10:40
openstackgerritMerged openstack/blazar-dashboard master: Add Horizon plugin for Blazar  https://review.openstack.org/48033110:40
openstackgerritHiroaki Kobayashi proposed openstack/blazar-dashboard master: Support lease creation  https://review.openstack.org/48907910:43
openstackgerritHiroaki Kobayashi proposed openstack/blazar-dashboard master: Show reservations in more detail  https://review.openstack.org/48984610:43
openstackgerritHiroaki Kobayashi proposed openstack/blazar-dashboard master: Support creation of instance reservation  https://review.openstack.org/48986110:43
openstackgerritHiroaki Kobayashi proposed openstack/blazar-dashboard master: Add validation checks for the update form  https://review.openstack.org/49032910:43
*** bertys_ has quit IRC10:46
*** nicolasbock__ has quit IRC10:54
*** bertys__ has quit IRC11:17
*** bertys_ has joined #openstack-blazar11:20
*** masahito has joined #openstack-blazar12:09
*** masahito has quit IRC12:10
openstackgerritPierre Riteau proposed openstack/python-blazarclient master: Fix unicode issues with Python 3  https://review.openstack.org/49049814:27
openstackgerritPierre Riteau proposed openstack/python-blazarclient master: Fix unicode issues with Python 3  https://review.openstack.org/49049814:28
openstackgerritPierre Riteau proposed openstack/python-blazarclient master: Fix unicode issues with Python 3  https://review.openstack.org/49049814:33
*** priteau has quit IRC15:09
*** egonzalez has quit IRC16:03
*** bertys_ has quit IRC21:26

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!