*** masahito has joined #openstack-blazar | 00:00 | |
*** hiro-kobayashi has joined #openstack-blazar | 01:23 | |
*** masahito has quit IRC | 02:04 | |
*** nicolasbock__ has joined #openstack-blazar | 03:14 | |
*** hiro-kobayashi has quit IRC | 04:11 | |
*** hiro-kobayashi has joined #openstack-blazar | 04:19 | |
openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar-dashboard master: Add validation checks for the update form https://review.openstack.org/490329 | 04:27 |
---|---|---|
*** bertys_ has joined #openstack-blazar | 05:28 | |
*** hiro-kobayashi_ has joined #openstack-blazar | 06:26 | |
*** hiro-kobayashi has quit IRC | 06:27 | |
*** hiro-kobayashi_ has quit IRC | 06:36 | |
*** hiro-kobayashi has joined #openstack-blazar | 06:36 | |
*** masahito has joined #openstack-blazar | 06:37 | |
openstackgerrit | Maho Koshiya proposed openstack/blazar master: Add a termination scenario test https://review.openstack.org/490351 | 06:47 |
openstackgerrit | Masahito Muroi proposed openstack/blazar-nova master: Add instance reservation filtering in Blazar filter https://review.openstack.org/486476 | 06:47 |
openstackgerrit | Masahito Muroi proposed openstack/blazar master: Add user guide for the new instance reservation feature https://review.openstack.org/488304 | 07:15 |
openstackgerrit | Masahito Muroi proposed openstack/blazar master: Enable devstack to setup the new instance reservation https://review.openstack.org/488302 | 07:15 |
openstackgerrit | Masahito Muroi proposed openstack/blazar master: Add a release note of the new instance reservation https://review.openstack.org/488303 | 07:15 |
openstackgerrit | Pierre Riteau proposed openstack/blazar master: Add a release note of the new instance reservation feature https://review.openstack.org/488303 | 07:36 |
*** masahito has quit IRC | 07:37 | |
*** priteau has joined #openstack-blazar | 07:39 | |
*** egonzalez has joined #openstack-blazar | 07:43 | |
openstackgerrit | Pierre Riteau proposed openstack/blazar master: Configure ReservationPool with the blazar admin user https://review.openstack.org/487791 | 07:51 |
openstackgerrit | Merged openstack/blazar master: Revise endpoint creation part of the installation guide https://review.openstack.org/489536 | 07:55 |
priteau | I don't understand why we're getting this Jenkins error: http://logs.openstack.org/03/488303/5/check/gate-blazar-devstack-dsvm/5960eba/logs/devstack-early.txt.gz#_2017-08-03_07_42_03_400 | 07:57 |
priteau | there were no changes to the devstack plugin | 07:57 |
*** hiro-kobayashi has quit IRC | 08:07 | |
*** hiro-kobayashi has joined #openstack-blazar | 08:11 | |
priteau | I see, it is caused by another non-merged parent patch | 08:15 |
*** openstackgerrit has quit IRC | 08:18 | |
*** openstackgerrit has joined #openstack-blazar | 08:18 | |
openstackgerrit | Pierre Riteau proposed openstack/blazar master: Enable DevStack to set up the new instance reservation https://review.openstack.org/488302 | 08:18 |
openstackgerrit | Pierre Riteau proposed openstack/blazar master: Enable DevStack to set up the new instance reservation feature https://review.openstack.org/488302 | 08:20 |
priteau | hiro-kobayashi: I rewrote parts of the commit message for https://review.openstack.org/#/c/487791/ but no code change, you had a +2 before | 08:21 |
hiro-kobayashi | priteau: thanks! | 08:21 |
openstackgerrit | Pierre Riteau proposed openstack/blazar master: Create Nova resources for instance reservations https://review.openstack.org/480929 | 08:27 |
openstackgerrit | Pierre Riteau proposed openstack/python-blazarclient master: Convert integer style parameters to integer values https://review.openstack.org/489033 | 08:37 |
openstackgerrit | Merged openstack/blazar master: Configure ReservationPool with the blazar admin user https://review.openstack.org/487791 | 08:51 |
*** bertys__ has joined #openstack-blazar | 08:52 | |
*** masahito has joined #openstack-blazar | 08:56 | |
masahito | priteau: hiro-kobayashi bertys_: hi, you there? | 09:01 |
priteau | Hello | 09:01 |
hiro-kobayashi | Hi | 09:02 |
openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Support before_end parameter in the REST API https://review.openstack.org/489549 | 09:02 |
bertys__ | Bonjour, Hello, Konishiwa ); | 09:02 |
hiro-kobayashi | Konnichiwa :-) | 09:03 |
masahito | good morning/evening | 09:03 |
masahito | let's start review meeting! | 09:04 |
hiro-kobayashi | \o/ | 09:04 |
masahito | I plan to end the meeting after 1h and half later if it finish. then continue to next Monday. | 09:05 |
hiro-kobayashi | OK for me | 09:05 |
masahito | is it okay for you? | 09:05 |
priteau | Sounds good | 09:05 |
bertys__ | sure | 09:05 |
masahito | s/if it finish/ if it doesn't finish/ | 09:06 |
masahito | ok, let's start from the beginning of the gerrit. | 09:06 |
masahito | https://review.openstack.org/#/q/status:open+blazar | 09:06 |
priteau | Are we looking at oldest or newest first? | 09:07 |
masahito | I think newest first is better because any activities change the order. | 09:07 |
hiro-kobayashi | How about deciding a topic to focus on for the first | 09:08 |
hiro-kobayashi | ? | 09:08 |
priteau | +1 for topic | 09:08 |
masahito | hiro-kobayashi: nice idea. | 09:08 |
masahito | the category could be 1. bug fix, 2. horizon plugin, 3. instance reservation, 4. other BP | 09:09 |
priteau | I think Horizon plugin is waiting for an Horizon core to check something | 09:10 |
hiro-kobayashi | priteau: Horizon core has already CR+1ed for the first patch | 09:10 |
masahito | 'Akihiro Motoki' is a core of Horizon project. | 09:10 |
hiro-kobayashi | https://review.openstack.org/#/c/480331/ | 09:10 |
priteau | But he just sent an email a few minutes ago | 09:11 |
priteau | "Let me update the alternative approach. I think it is not well documented combined with horizon plugin with runserver. It is worth updating the horizon document. As a horizon core, I will check it." | 09:11 |
hiro-kobayashi | Oh, yeah | 09:11 |
hiro-kobayashi | Then we should wait for that | 09:12 |
masahito | IIHO, he mentioned about tox plugin, doesn't he? | 09:12 |
hiro-kobayashi | masahito: it cant affect the installation guide | 09:13 |
hiro-kobayashi | s/cant/can | 09:13 |
bertys__ | masahito: this is related to run_tests deprecation. Sorry I am the troublemaker... | 09:14 |
masahito | s/IIHO/IMHO/ | 09:14 |
masahito | bertys__: np | 09:14 |
priteau | These four changes have a bug topic: | 09:14 |
priteau | https://review.openstack.org/#/c/489033/ | 09:14 |
priteau | https://review.openstack.org/#/c/490351/ | 09:14 |
priteau | https://review.openstack.org/#/c/482532/ | 09:14 |
priteau | https://review.openstack.org/#/c/481518/ | 09:14 |
hiro-kobayashi | bertys__: I really appreciate your noticing ;-) | 09:14 |
bertys__ | hiro-kobayashi: np | 09:15 |
hiro-kobayashi | thanks priteau | 09:15 |
masahito | bertys__: hiro-kobayashi: IMO, it's ok to use deprecated one for the first cut. | 09:15 |
masahito | ok, let's start #1 category :-) then discuss Horizon in #2 | 09:16 |
hiro-kobayashi | ok | 09:16 |
hiro-kobayashi | for https://review.openstack.org/#/c/489033/ | 09:17 |
hiro-kobayashi | thanks for addressing my comments, masahito! | 09:17 |
hiro-kobayashi | Now It'S LGTM | 09:17 |
masahito | hiro-kobayashi: thank. then push CR+2 and W+1 :-) | 09:18 |
hiro-kobayashi | done | 09:18 |
masahito | next | 09:18 |
masahito | https://review.openstack.org/#/c/490351/ | 09:18 |
priteau | I haven't checked that one yet | 09:19 |
hiro-kobayashi | me neighther | 09:19 |
masahito | me neighther | 09:20 |
masahito | it's a scenario test patch and pass the gate job. | 09:20 |
priteau | I am going to fix a typo | 09:20 |
priteau | I will edit directly if that's OK | 09:21 |
masahito | my proposal is if the scenario is ok, ready to go. | 09:21 |
openstackgerrit | Merged openstack/python-blazarclient master: Convert integer style parameters to integer values https://review.openstack.org/489033 | 09:22 |
openstackgerrit | Pierre Riteau proposed openstack/blazar master: Add a termination scenario test https://review.openstack.org/490351 | 09:22 |
openstackgerrit | Pierre Riteau proposed openstack/blazar master: Add a termination scenario test https://review.openstack.org/490351 | 09:23 |
priteau | The new function test_update_host_reservation uses wait_until_aggregated(), but it is defined within test_host_reservation | 09:24 |
masahito | what's the problem? | 09:25 |
priteau | ah no, it has moved in an earlier patch | 09:25 |
priteau | We should be looking at this patch first: https://review.openstack.org/#/c/482532/ | 09:25 |
priteau | parent of 490351 | 09:25 |
bertys__ | +1 | 09:26 |
masahito | For the test of resource release, status of the first server created at L275 should be check after lease end. | 09:26 |
openstackgerrit | Pierre Riteau proposed openstack/blazar master: Add scenario test of lease expiration https://review.openstack.org/482532 | 09:29 |
masahito | ok, most of us doesn't review the 2 patches yet, so check the scenario and comment. | 09:30 |
bertys__ | ok for me. | 09:31 |
priteau | Is the order of the test always the same? | 09:31 |
masahito | and then the scenario becomes ok, ready to go. | 09:32 |
priteau | Because test_lease_expiration() assumes that the host was added to Blazar | 09:32 |
masahito | priteau: the order is random | 09:32 |
priteau | Then I am afraid we might see failures | 09:33 |
openstackgerrit | Pierre Riteau proposed openstack/blazar master: Add scenario test of lease expiration https://review.openstack.org/482532 | 09:34 |
bertys__ | #link https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/blazar.yaml#L27 | 09:34 |
bertys__ | masahito is the expert | 09:35 |
priteau | Even if the order is the always the same, it's not good practice to have one test depend on another one having already run | 09:36 |
masahito | the regex matches the file name, not for test methods. | 09:36 |
hiro-kobayashi | Then self.reservation_client.create_host({'name': host['host']}) should be inserted in L222? | 09:36 |
priteau | Maybe each test should remove the host at the end, so that the next test can add it? | 09:36 |
priteau | hiro-kobayashi: I think that would might conflict with the host left over by the previous test | 09:37 |
priteau | or have a function _add_host_once which would take action only if the host doesn't exists yet | 09:37 |
masahito | priteau is right. the number of compute hosts for the gate is just one. | 09:38 |
hiro-kobayashi | Understood | 09:38 |
priteau | Should we ask Maho to fix the patch? | 09:38 |
masahito | so one of the right way is each test add and remove the host at beginning and end. | 09:38 |
openstackgerrit | Akihiro Motoki proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar https://review.openstack.org/480331 | 09:39 |
bertys__ | masahito: really? | 09:39 |
priteau | If all tests do the same, it can go in setUp/tearDown | 09:39 |
bertys__ | masahito: can we ask for more hosts to infra? | 09:40 |
masahito | priteau: we can tell her what the patch is needed to improve. then if no reaction for weeks, we can take it over. | 09:40 |
priteau | OK | 09:40 |
priteau | Is she a collegue of yours? | 09:40 |
masahito | bertys__: ah, the test works concurrently, so it would be good. | 09:41 |
masahito | priteau: not my collegue. | 09:41 |
masahito | priteau: but a member of NTT group. I heard her name before and she is working on testing things. | 09:42 |
priteau | Great to see new contributors! | 09:42 |
priteau | OK so we will -1 these patches to point out the problem with host create | 09:43 |
masahito | right. | 09:43 |
priteau | Should we move on to the next patch? | 09:43 |
hiro-kobayashi | yes we should | 09:43 |
masahito | yup | 09:43 |
masahito | https://review.openstack.org/#/c/481518/ | 09:44 |
priteau | I have +2 it already | 09:44 |
hiro-kobayashi | Thanks for reviewing it so far | 09:44 |
masahito | hiro-kobayashi: the difference is just merging one line? | 09:45 |
hiro-kobayashi | Which diffrence you mention? | 09:46 |
priteau | I think masahito is talking about the move of "values['count_range']" assignment | 09:46 |
priteau | at the bottom blazar/plugins/oshosts/host_plugin.py | 09:47 |
masahito | between patch set 8 and 9 except resolving rebase conflcit. | 09:47 |
priteau | I asked hiro for this change | 09:47 |
masahito | if so, I think it's ok. | 09:47 |
hiro-kobayashi | yes | 09:47 |
masahito | got it. | 09:48 |
masahito | next | 09:48 |
masahito | https://review.openstack.org/#/c/481194/ | 09:48 |
masahito | I -1ed the patch because of the coding style. but the patch fixes the bug well? | 09:49 |
hiro-kobayashi | I think Yes it fixes the bug | 09:50 |
priteau | I read your comments but didn't fully understand how you wanted me to change the code. Then I didn't have much time to work on it. | 09:50 |
priteau | I believe it fixes the bug and there is a test case for it. | 09:50 |
masahito | hiro-kobayashi: it's ok to merge or should improve the coding you mentioned? | 09:51 |
hiro-kobayashi | I don't have a strong preference. it's okay to merge | 09:51 |
masahito | priteau: sorry, but an explanation. | 09:51 |
priteau | I would be OK with putting your comments in a bug report for future fixes. I think we might want to rewrite completely this function to make it simpler. | 09:52 |
masahito | s/but/bad/ | 09:52 |
hiro-kobayashi | priteau: +1 | 09:53 |
masahito | I re-read it today and I thought if we hit a performance issue later we can fix it later. | 09:53 |
masahito | so let's merge the patch | 09:53 |
priteau | Thanks | 09:54 |
priteau | I am creating the bug. | 09:54 |
priteau | https://bugs.launchpad.net/blazar/+bug/1708414 | 09:55 |
openstack | Launchpad bug 1708414 in Blazar "Improve clarity and performance of host_get_all_by_queries" [Undecided,New] | 09:55 |
masahito | priteau: thanks! | 09:56 |
masahito | next is https://review.openstack.org/#/c/481716/ | 09:56 |
priteau | Thanks for the feedback | 09:56 |
masahito | priteau: do you have a plan to update it? | 09:57 |
masahito | same problem happens in the instance reservation plugin now. | 09:58 |
hiro-kobayashi | masahito: your commented solution can solve both of host/instance plugins, right? | 09:59 |
masahito | hiro-kobayashi: maybe | 09:59 |
priteau | I was working on it but it's not as easy to do in the manager service because the order is quite different | 10:00 |
masahito | so the fix is important. if you have not enough time to fix, I can take it over. | 10:01 |
priteau | I will try to propose a new patch by Monday | 10:01 |
hiro-kobayashi | thanks priteau! | 10:02 |
bertys__ | thanks | 10:03 |
masahito | thank. | 10:03 |
hiro-kobayashi | BTW, the horizon core has updated the installation guide. I think we can merge it for now. | 10:04 |
hiro-kobayashi | https://review.openstack.org/#/c/480331/ | 10:04 |
masahito | does someone have other bug patches? | 10:05 |
masahito | if nothing, we can go Horizon. | 10:05 |
bertys__ | hiro-kobayashi: yep | 10:05 |
priteau | hiro-kobayashi: I had one comment in the Horizon dashboard | 10:07 |
priteau | If you can make URLs https rather than http, that would avoid further patches | 10:07 |
priteau | e.g. in https://review.openstack.org/#/c/480331/16/README.rst | 10:07 |
hiro-kobayashi | I'm sorry, I cannot understand | 10:09 |
priteau | When there are links using http:// in OpenStack code, we get a lot of new contributors updating these links to https:// | 10:10 |
masahito | It's an easy fix. so fix it now and merge it. | 10:10 |
hiro-kobayashi | Got it :-) | 10:10 |
hiro-kobayashi | I'm fixing them | 10:11 |
openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar https://review.openstack.org/480331 | 10:12 |
masahito | During the fixing, I've not review the rests of the Horizon patches. | 10:12 |
masahito | Does someone check it? | 10:12 |
priteau | I haven't checked them yet. I would like to review them. | 10:13 |
bertys__ | masahito: I have shared screenshots. hope this is also helpful for non developers | 10:14 |
openstackgerrit | Pierre Riteau proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar https://review.openstack.org/480331 | 10:14 |
priteau | (only fixed wrong capitalization of OpenStack) | 10:14 |
hiro-kobayashi | priteau: thanks! | 10:14 |
bertys__ | see e.g. https://imagebin.ca/v/3VSOl4Cwcx4H | 10:14 |
masahito | bertys__: thanks. | 10:15 |
bertys__ | masahito: np | 10:16 |
masahito | so for the other related patches I try to deploy the patch in my local and if it works, I'm ok to gerge. | 10:17 |
openstackgerrit | Pierre Riteau proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar https://review.openstack.org/480331 | 10:17 |
masahito | I want to include the 5 Horizon patches in P release. | 10:18 |
hiro-kobayashi | I thinks the base patch https://review.openstack.org/480331 is ready to be merged | 10:18 |
priteau | hiro-kobayashi: I will remove myself as co-author because I didn't write any of that code | 10:19 |
hiro-kobayashi | and other patches do not take so much time to review | 10:19 |
priteau | It's all from Pablo | 10:19 |
masahito | so if no one says it doesn't work without a real scenario by 18th Aug. it's ok to merge. | 10:19 |
masahito | how do you think? | 10:19 |
hiro-kobayashi | priteau: OK. | 10:19 |
openstackgerrit | Pierre Riteau proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar https://review.openstack.org/480331 | 10:19 |
priteau | There is a comment from Akihiro | 10:20 |
hiro-kobayashi | masahito: +1 | 10:20 |
priteau | https://review.openstack.org/#/c/480331/18/doc/source/conf.py@369 | 10:20 |
bertys__ | masahito: OK for me. | 10:21 |
masahito | yes, and looks fixed now. super quick response. | 10:21 |
priteau | masahito: +1 | 10:21 |
priteau | ah, didn't see Hiro's patch | 10:22 |
openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar https://review.openstack.org/480331 | 10:22 |
masahito | ok, I'll write the criteria to https://review.openstack.org/#/c/489861/ | 10:23 |
priteau | I don't see it fixed | 10:23 |
priteau | OK, see it now | 10:23 |
hiro-kobayashi | priteau: sorry for delay | 10:23 |
openstackgerrit | Pierre Riteau proposed openstack/blazar-dashboard master: Add Horizon plugin for Blazar https://review.openstack.org/480331 | 10:23 |
bertys__ | masahito: good idea, checking instance reservation is still on my todo list... | 10:24 |
openstackgerrit | Merged openstack/blazar master: Handle more exceptions raised in reserve_resource() https://review.openstack.org/481518 | 10:24 |
priteau | I have +2 the Horizon dashboard patch | 10:25 |
masahito | once Jenkins has +1ed, I'll add +2. | 10:26 |
priteau | OK | 10:26 |
hiro-kobayashi | thanks all | 10:26 |
bertys__ | ok | 10:26 |
masahito | Jenkins is a door keeper | 10:26 |
masahito | should we go next? or end today's review? | 10:27 |
masahito | next is series of instance reservation. | 10:27 |
hiro-kobayashi | I'm okay to continue | 10:28 |
priteau | I have provided some comments on instance reservation patches, but haven't got through them all yet | 10:29 |
openstackgerrit | Merged openstack/blazar master: Fix host filtering by extra capability https://review.openstack.org/481194 | 10:29 |
priteau | Also we need Jenkins to +1 all of them | 10:29 |
priteau | I fixed a syntax issue in the DevStack plugin which should help | 10:29 |
priteau | masahito: Could you check comments and rebase on master, and we'll discuss on Monday? | 10:30 |
bertys__ | masahito: before I forget, are u aware of https://etherpad.openstack.org/p/nova-ptg-queens? | 10:30 |
masahito | priteau: oh, I missed one your comment. | 10:31 |
masahito | I'll update it later. | 10:31 |
bertys__ | not sure if "spot instances..." will make it to ptg | 10:31 |
masahito | bertys__: yes. | 10:31 |
bertys__ | but if yes, let's try to be there | 10:31 |
masahito | so end the meeting today, then continue on next Mon. | 10:32 |
bertys__ | thanks all | 10:33 |
priteau | Good job today! | 10:33 |
hiro-kobayashi | Good progress! | 10:33 |
masahito | bertys__: yes. I'll ping Nova team and make an schedule it. | 10:33 |
hiro-kobayashi | thanks all | 10:33 |
masahito | yes, in the meeting we merged 4 or 5 patches? that's great progress! | 10:34 |
masahito | see you in next Monday! | 10:34 |
hiro-kobayashi | See you! | 10:34 |
masahito | btw, I pushed CR+2 and W+1 button of Horizon Plugin ;-) | 10:35 |
priteau | \o/ | 10:36 |
masahito | we finally got Blazar GUI! | 10:37 |
hiro-kobayashi | masahito: thanks! | 10:38 |
openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar master: Support updating capacity of reservations https://review.openstack.org/482811 | 10:38 |
*** masahito has quit IRC | 10:38 | |
*** hiro-kobayashi has quit IRC | 10:40 | |
openstackgerrit | Merged openstack/blazar-dashboard master: Add Horizon plugin for Blazar https://review.openstack.org/480331 | 10:40 |
openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar-dashboard master: Support lease creation https://review.openstack.org/489079 | 10:43 |
openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar-dashboard master: Show reservations in more detail https://review.openstack.org/489846 | 10:43 |
openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar-dashboard master: Support creation of instance reservation https://review.openstack.org/489861 | 10:43 |
openstackgerrit | Hiroaki Kobayashi proposed openstack/blazar-dashboard master: Add validation checks for the update form https://review.openstack.org/490329 | 10:43 |
*** bertys_ has quit IRC | 10:46 | |
*** nicolasbock__ has quit IRC | 10:54 | |
*** bertys__ has quit IRC | 11:17 | |
*** bertys_ has joined #openstack-blazar | 11:20 | |
*** masahito has joined #openstack-blazar | 12:09 | |
*** masahito has quit IRC | 12:10 | |
openstackgerrit | Pierre Riteau proposed openstack/python-blazarclient master: Fix unicode issues with Python 3 https://review.openstack.org/490498 | 14:27 |
openstackgerrit | Pierre Riteau proposed openstack/python-blazarclient master: Fix unicode issues with Python 3 https://review.openstack.org/490498 | 14:28 |
openstackgerrit | Pierre Riteau proposed openstack/python-blazarclient master: Fix unicode issues with Python 3 https://review.openstack.org/490498 | 14:33 |
*** priteau has quit IRC | 15:09 | |
*** egonzalez has quit IRC | 16:03 | |
*** bertys_ has quit IRC | 21:26 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!