| docaedo | still need to catch up on the scroll back and get a handle on the optimization goal here | 00:00 |
|---|---|---|
| kfox1111 | k. I submitted an updated cors patch with the bits I think need to be in it. I don't have a way to test though. | 00:03 |
| kfox1111 | do you have a horizon of your own that you can load the plugin into? | 00:03 |
| *** kzaitsev_mb has quit IRC | 00:04 | |
| kfox1111 | if not, we can do a bit of testing with curl. | 00:04 |
| docaedo | I don't have a running copy of horizon for testing the plugin | 00:06 |
| kfox1111 | k. | 00:06 |
| kfox1111 | then we can test with something like: | 00:06 |
| kfox1111 | curl -H "Origin: http://foo.com" -H "Access-Control-Request-Method: GET" -H "Access-Control-Request-Headers: X-App-Catalog-Versions: 1 2 3 4" -X OPTIONS localhost:18001/api/v1/assets -vvv | 00:06 |
| docaedo | so .. intention with the patch is to make the json file as small as possible be gzippin on the server each time it's created? | 00:06 |
| kfox1111 | part of it yes. | 00:07 |
| kfox1111 | the other part is to enable CORS on it. | 00:07 |
| kfox1111 | with the CORS preflight check working. | 00:07 |
| kfox1111 | we never used that feature before, so we didn't implement it before. | 00:07 |
| kfox1111 | I modified the plugin to send over the horizon/app-catalog-ui versions as part of the CORS call. That way, we can get a good handle on just when its safe to deprecate v1 once we've moved on. | 00:08 |
| kfox1111 | 2 years from now, when we don't see any more horzion liberties, we can say, wahoo, byby v1. :) | 00:09 |
| kfox1111 | or, shoot, we still have a million v1 users... :) | 00:11 |
| docaedo | that makes sense | 00:11 |
| docaedo | what's "CORS preflight check"? | 00:11 |
| kfox1111 | long story... short ver, if your handing over some other headers, it has to check with the server if its "ok" to do so. it does that by doing an OPTIONS http call. | 00:12 |
| kfox1111 | if the server returns stuff that looks like the request its about to make, the browser goes ahead and allows the call. | 00:12 |
| docaedo | got it | 00:14 |
| docaedo | I'll switch machines later tonight or else first thing tomorrow and test the compressing patch you posted | 00:16 |
| kfox1111 | k. and also please double check the OPTIONS thing works. | 00:16 |
| openstackgerrit | Kevin Fox proposed stackforge/apps-catalog-ui: Initial stab at pbr and version passing. https://review.openstack.org/219068 | 00:21 |
| kfox1111 | ok... we're getting to be in pretty good shape for liberty. | 00:22 |
| kfox1111 | The main things I'm hoping for by then are tighten-schema, ui-packages and hopefully magic-search-gridview. (And a bumch of patches get merged. :) | 00:24 |
| *** Berezin has joined #openstack-app-catalog | 00:45 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 01:01 | |
| *** kzaitsev_mb has quit IRC | 01:05 | |
| *** Berezin has quit IRC | 01:12 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 01:32 | |
| *** kzaitsev_mb has quit IRC | 01:48 | |
| *** Berezin has joined #openstack-app-catalog | 06:02 | |
| *** Berezin has quit IRC | 06:44 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 06:59 | |
| *** kzaitsev_mb has quit IRC | 07:04 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 08:24 | |
| *** kzaitsev_mb has quit IRC | 08:57 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 09:00 | |
| *** kzaitsev_mb has quit IRC | 09:04 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 10:10 | |
| *** kzaitsev_mb has quit IRC | 10:54 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 11:32 | |
| *** kebray has joined #openstack-app-catalog | 14:48 | |
| *** kebray has quit IRC | 15:04 | |
| *** kebray has joined #openstack-app-catalog | 15:11 | |
| *** kebray has quit IRC | 15:17 | |
| *** Alec has joined #openstack-app-catalog | 15:41 | |
| Alec | @docaedo hi Christopher, have a question regarding a review for an addition to openstack_catalog/web/static/assets.yaml | 15:44 |
| *** j_king has left #openstack-app-catalog | 15:50 | |
| kfox1111 | morning. | 16:03 |
| kfox1111 | Alec: hi. whats your question? | 16:03 |
| Alec | yes, was wondering if this review needs another +2 to move forward | 16:06 |
| Alec | https://review.openstack.org/#/c/218529/1 | 16:06 |
| kfox1111 | ah. yeah. | 16:07 |
| kfox1111 | so, its looking good. we were debating one thing. | 16:07 |
| kfox1111 | its tagged as an app, and has no icon. | 16:07 |
| Alec | was waiting for the app catalog web page to update with the new glance image | 16:07 |
| kfox1111 | we've been making a new ui as part of horizon: | 16:08 |
| kfox1111 | http://efox.cc/temp/app-catalog.png | 16:08 |
| Alec | ok, what is the semantic of "app" tag and what are the other choice? | 16:08 |
| kfox1111 | and it looks a little weird to not have icons for it. | 16:08 |
| kfox1111 | the semantic of app is, something a user is expecting to run. like: | 16:09 |
| Alec | I could add an icon but did not because the app catalog does not show any for the glance images | 16:09 |
| kfox1111 | user searches for Kloudbuster, hits "install", hits "Launch" and has a usable thingy. | 16:09 |
| Alec | ok that is not quite our situation | 16:09 |
| kfox1111 | everything else is a component, which is something that you load into openstack, as a resource. maybe a part of an app, or a solum language pack, or something that enhances openstack, but the user doesn't directly interact with. | 16:10 |
| Alec | in our case, this image is launched by an external app (kloudbuster) in potentially lots of VMs and is driven by that app | 16:10 |
| kfox1111 | ah. ok. so then its a component. | 16:11 |
| Alec | so normally you don;t launch that image directly (you could but it does not do anything by itself) | 16:11 |
| kfox1111 | so just drop the tag and I think we're good to go. :) | 16:11 |
| Alec | ok I'll just remove it then and resubmit | 16:11 |
| Alec | still need an icon? | 16:11 |
| kfox1111 | sorry for the delay. we were trying to figure out if openstack had an art subproject that we could get to build icons for openstack projects if no artwork was avaiable. | 16:11 |
| kfox1111 | no, we're good without one. thanks. :) | 16:12 |
| Alec | ok, the snapshot of app catalog looks nice though ;-) | 16:12 |
| Alec | why no icon for glance images that are just "component"? | 16:13 |
| *** kzaitsev_mb has quit IRC | 16:13 | |
| kfox1111 | Thanks. :) | 16:14 |
| kfox1111 | probably could add icons for all the components too. Just haven't gotten there yet. | 16:15 |
| kfox1111 | kzaitsev_ws: is it still broken? https://murano-ci.mirantis.com/logs/15/218515/5/check/gate-murano-dashboard-selenium/3091f48/artifacts/test_check_ability_create_two_dependent_apps.png | 16:17 |
| kfox1111 | kzaitsev_ws: oh. nm. murano ci check didn't retrigger. | 16:21 |
| openstackgerrit | Kevin Fox proposed stackforge/apps-catalog: More CORS support https://review.openstack.org/219024 | 16:23 |
| openstackgerrit | Kevin Fox proposed stackforge/apps-catalog: Break out the code to update assets. https://review.openstack.org/218670 | 16:30 |
| kfox1111 | docaedo: can I get a workflow on that last one? Based on the review on the cors infra patch, it might be good to try to just point it at the update_assets.sh script. | 16:31 |
| docaedo | kfox1111: Let's float the idea on #openstack-infra to see if there's going to be even more pushback - maybe I'm mistaken and they won't care at all about having the script that gets triggered live in the app-catalog repo | 16:35 |
| kfox1111 | one way or another, I think that review does clean up the code. so I think we should merge it. that being said, | 16:36 |
| kfox1111 | I'm ok floating the idea of calling it from the infra side if you think that woudl be quicker then just tweaking the revew and seing what happens. | 16:37 |
| kfox1111 | may be easier if the review was merged first though. | 16:38 |
| docaedo | color me wrong! | 16:38 |
| docaedo | clarkb says "if its an app catalog utility regardless of config management system I would put it there" | 16:38 |
| kfox1111 | cool. :) | 16:38 |
| kfox1111 | that makes it easy then. :) | 16:39 |
| docaedo | so I'll give you the workflow on that, and adjust my infra CORS one with yolandas notes, and have it call the script | 16:39 |
| kfox1111 | k. | 16:39 |
| kfox1111 | I think I have the newest version of it checked out already. I can tweak it pretty quickly if you'd rather. | 16:39 |
| docaedo | that works for me too, thank you! | 16:40 |
| kfox1111 | np. | 16:40 |
| docaedo | gotta step out, back in a bit though | 16:41 |
| kfox1111 | done. | 16:41 |
| kfox1111 | yeah, me too. meeting time. | 16:41 |
| *** kebray has joined #openstack-app-catalog | 16:42 | |
| *** rhagarty_ has quit IRC | 16:50 | |
| *** rhagarty has quit IRC | 16:50 | |
| openstackgerrit | Merged stackforge/apps-catalog: Break out the code to update assets. https://review.openstack.org/218670 | 16:51 |
| openstackgerrit | Alec Hothan proposed stackforge/apps-catalog: Add new glance image for the openstack/kloudbuster application https://review.openstack.org/218529 | 16:56 |
| *** rhagarty has joined #openstack-app-catalog | 16:57 | |
| *** rhagarty_ has joined #openstack-app-catalog | 16:58 | |
| *** kebray has quit IRC | 17:01 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 17:05 | |
| kfox1111 | kzaitsev_mb: interesting results... | 17:05 |
| kfox1111 | https://murano-ci.mirantis.com/logs/15/218515/5/check/gate-murano-dashboard-selenium/dbbf91d/artifacts/horizon_error.log | 17:05 |
| kzaitsev_mb | kfox1111: yep | 17:06 |
| kfox1111 | don't think that's anything I did? | 17:06 |
| kzaitsev_mb | the patch with compress was merged, but djang1.8 landed today | 17:06 |
| kzaitsev_mb | I thought I foresaw it =) | 17:06 |
| kfox1111 | ah. | 17:06 |
| kzaitsev_mb | but apparently I didn't | 17:06 |
| kzaitsev_mb | not cam out, but support landed to global/requirements | 17:06 |
| kfox1111 | so should I just recheck it, or should I wait? | 17:07 |
| kzaitsev_mb | and they moved formtools from django.contrib to a separate modeule, that is not present in global requirements. | 17:07 |
| kzaitsev_mb | unfortunatelly wait untill global requirements commit lands https://review.openstack.org/#/c/219222/ this one | 17:07 |
| kfox1111 | oh, yeah... I remember that.. I thougth that happened a while ago though? | 17:08 |
| kzaitsev_mb | cause murano has it's dashboard gate blocked =/ | 17:08 |
| kzaitsev_mb | django1.8 commit was submitted a week ago or so. but horizon doesn't seem to use the contrib.formtools module itself. So no one noticed =/ | 17:08 |
| kfox1111 | I've seen that somewhere though... where did I see that... I could have swarn it was horizon... | 17:09 |
| kfox1111 | brain.. .not .... working. :) | 17:09 |
| *** Alec has quit IRC | 17:37 | |
| *** kebray has joined #openstack-app-catalog | 17:49 | |
| *** kebray has quit IRC | 18:45 | |
| *** kebray has joined #openstack-app-catalog | 19:04 | |
| *** kebray has quit IRC | 19:26 | |
| *** kfox1111 has quit IRC | 19:34 | |
| *** kfox1111 has joined #openstack-app-catalog | 19:34 | |
| *** kebray has joined #openstack-app-catalog | 19:47 | |
| *** kfox1111 has quit IRC | 19:47 | |
| *** kfox1111 has joined #openstack-app-catalog | 19:52 | |
| *** kzaitsev_mb has quit IRC | 19:53 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 20:01 | |
| *** kebray has quit IRC | 20:03 | |
| *** kebray has joined #openstack-app-catalog | 20:05 | |
| *** kzaitsev_mb has quit IRC | 20:11 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 20:15 | |
| *** kzaitsev_mb has quit IRC | 20:44 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 20:54 | |
| docaedo | I'm in the cross project meeting ATM but wanted to share here, TC voted happily/easily to make app-catalog an official openstack project, in the big tent, or whatever the phrase is :) | 21:02 |
| * kfox1111 dances | 21:05 | |
| kfox1111 | congrats. :) | 21:06 |
| docaedo | thanks! couldn't have happened without you and kzaitsev_mb, should really help us with people considering it a "real" thing, and hopefully getting more folks involved | 21:11 |
| docaedo | kfox1111: I'm transferring a VM right now so I can test the infra stuff, and make some adjustments to cover what yolanda noted re: mod_rewrite | 21:12 |
| *** kebray has quit IRC | 21:17 | |
| kfox1111 | ok. cool. | 21:19 |
| kfox1111 | then I should be able to commit all the plugin changes. | 21:19 |
| *** kebray has joined #openstack-app-catalog | 21:21 | |
| *** kzaitsev_mb has quit IRC | 21:31 | |
| *** kzaitsev_mb has joined #openstack-app-catalog | 21:32 | |
| *** kebray has quit IRC | 21:35 | |
| *** kebray has joined #openstack-app-catalog | 21:36 | |
| kfox1111 | wow... my day reguarding instance users went to hopeless to hopeful again in the span of about two hours. :/ | 21:53 |
| docaedo | that's excellent | 21:56 |
| kfox1111 | but stoked about the tent! :) | 21:57 |
| *** kzaitsev_mb has quit IRC | 21:58 | |
| kfox1111 | so, do we know when the rename's going to happen? | 22:15 |
| docaedo | 9/8 is next gerrit downtime AFAIK, I'll coordinate with infra to make sure the repo is renamed accordingly (but I called the repos app-catalog in the governance change, so that alone might resolve things) | 22:17 |
| docaedo | and moving/renaming repos requires gerrit downtime, so that's when it happens | 22:18 |
| docaedo | and this gets it done before the mass move that's happening I think in October | 22:18 |
| kfox1111 | nice. :) | 22:20 |
| kfox1111 | will make packaging a bit easier too. | 22:20 |
| kfox1111 | I'm having to overide defaults since app-catalog != apps-catalog | 22:20 |
| kfox1111 | having them match again will help. | 22:21 |
| *** kzaitsev_mb has joined #openstack-app-catalog | 22:29 | |
| *** kebray has quit IRC | 22:42 | |
| kfox1111 | docaedo: can you review the kloudbuster image when you get a chance. I think its good to go. | 22:45 |
| docaedo | kfox1111: thanks for the poke - have many things to juggle with getting up to speed on new job, appreciate the reminders. Was just now looking for some examples in other puppet manifests hosted by infra for the mod_rewrite usage, and will see what I can find there | 22:47 |
| kfox1111 | np. just trying not to forget about it myself. :) | 22:48 |
| openstackgerrit | Merged stackforge/apps-catalog: Add new glance image for the openstack/kloudbuster application https://review.openstack.org/218529 | 22:48 |
| docaedo | kfox1111: I think this is what they're looking for: https://review.openstack.org/#/c/218898/ | 23:11 |
| docaedo | tested on my local infra copy with puppet apply, and it did all the things it was meant to and didn't seem to do anything it wasn't supposed to do | 23:11 |
| docaedo | that includes creating the assets stuff | 23:12 |
| kfox1111 | k... did you try the curl? | 23:12 |
| docaedo | oh no I didn't what the curl I should try again? | 23:12 |
| kfox1111 | sec.... let me find it again... | 23:13 |
| docaedo | also I just noticed I'm going to fail puppet lint, damnit :) I always get lazy on the little ones, it's going to have to get fixed in #7 | 23:13 |
| kfox1111 | curl -X OPTIONS localhost:18001/api/v1/assets -vvv | 23:16 |
| kfox1111 | with localhost:18001 updated. | 23:16 |
| kfox1111 | see what the output headers look like. | 23:16 |
| docaedo | http://paste.openstack.org/show/439008/ | 23:17 |
| kfox1111 | ok. I think that will work. | 23:18 |
| kfox1111 | wont know 100% for sure until we point a plugin at it. but it seems to have all the right bits in it. | 23:19 |
| docaedo | yep, nice work man! | 23:19 |
| kfox1111 | thanks. you too. :) | 23:19 |
| kfox1111 | the internet's full of answers. ;) | 23:19 |
| kfox1111 | heaven help mankind when the google evermind becomes conscious. ;) | 23:20 |
| docaedo | no doubt | 23:21 |
| kfox1111 | failed another lint? | 23:23 |
| docaedo | yeah but it failed the lines I thought we were supposed to add based on yolanda's comment, and the other manifests I looked at that were vaguely similar | 23:26 |
| docaedo | I put: | 23:27 |
| docaedo | httpd_mod { 'rewrite': | 23:27 |
| docaedo | notify => Service['httpd'], | 23:27 |
| docaedo | ensure => present | 23:27 |
| docaedo | } | 23:27 |
| *** Berezin has joined #openstack-app-catalog | 23:28 | |
| docaedo | oh I can swap those, let me see... | 23:28 |
| kfox1111 | ensure first maybe? | 23:28 |
| docaedo | yeah I think so | 23:28 |
| docaedo | yep, that resolved the issues, hopefully it still handles whatever is buggy about the mod module | 23:29 |
| kfox1111 | cool. | 23:30 |
| *** Berezin has quit IRC | 23:47 | |
| *** kebray has joined #openstack-app-catalog | 23:51 | |
| *** Berezin has joined #openstack-app-catalog | 23:52 | |
| *** Berezin has quit IRC | 23:56 | |
| *** Berezin1 has joined #openstack-app-catalog | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
