*** kzaitsev_mb has quit IRC | 00:34 | |
*** kebray has joined #openstack-app-catalog | 02:33 | |
*** kebray has quit IRC | 02:33 | |
*** kebray has joined #openstack-app-catalog | 02:34 | |
*** kebray_ has joined #openstack-app-catalog | 02:53 | |
*** kebray has quit IRC | 02:56 | |
kfox1111 | docaedo: for the kloudbustser asset, did you get the image? | 03:08 |
---|---|---|
docaedo | ah I downloaded but I don't think I uploaded (started DL then walked away and forgot). I'll verify hash and upload | 03:24 |
docaedo | btw the infra JSON patch merged :) | 03:24 |
docaedo | uploading now, eta 2 minutes, will review as soon as that asset it up there. | 03:33 |
*** kebray_ has quit IRC | 03:37 | |
*** kebray has joined #openstack-app-catalog | 03:37 | |
docaedo | kfox1111: thanks a ton for reminding me about that kloudbuster asset! | 03:42 |
*** ig0r__ has joined #openstack-app-catalog | 04:59 | |
*** ig0r_ has quit IRC | 04:59 | |
*** kebray has quit IRC | 05:17 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 08:49 | |
*** kzaitsev_mb has quit IRC | 09:17 | |
*** ig0r_ has joined #openstack-app-catalog | 09:37 | |
*** ig0r__ has quit IRC | 09:39 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 10:27 | |
kzaitsev_mb | kfox1111: https://review.openstack.org/#/c/218807/ this might fix the issue | 11:01 |
*** kzaitsev_mb has quit IRC | 11:44 | |
*** openstackgerrit has quit IRC | 11:46 | |
*** openstackgerrit has joined #openstack-app-catalog | 11:47 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 11:56 | |
kfox1111 | docaedo: np. thanks for posting the asset. | 13:33 |
kfox1111 | hmmm.. no icon for kloudbuster... | 13:39 |
kfox1111 | docaedo: Is there an openstack art project? Some folks that could make some icons for openstack projects that get submitted to the app catalog? | 13:44 |
openstackgerrit | Kevin Fox proposed stackforge/apps-catalog: Cleanup text a little https://review.openstack.org/218861 | 13:48 |
kfox1111 | Can I get a workflow on that one quick? | 13:49 |
docaedo | kfox1111: yep | 14:42 |
openstackgerrit | Merged stackforge/apps-catalog: Cleanup text a little https://review.openstack.org/218861 | 14:51 |
*** kebray has joined #openstack-app-catalog | 14:51 | |
kfox1111 | thx. | 15:01 |
kfox1111 | hmm... getting a 404 on http://apps.openstack.org/api/v1/assets | 15:02 |
kzaitsev_mb | kfox1111: parameters patch has landed | 15:02 |
kfox1111 | how long does it take to update? | 15:02 |
kfox1111 | kzaitsev_mb: yeah, thanks. :) | 15:02 |
kfox1111 | also saw your other patch. I think that might fix it. | 15:02 |
kfox1111 | docaedo: I think all we're waiting for then is the infra patch for CORS? | 15:03 |
kfox1111 | gota head to work. bbiab. | 15:03 |
kzaitsev_mb | yep, I've been playing with AUTO_DISCOVER options added in L horizon and had similar problems, so this might actually be the cause | 15:03 |
docaedo | takes around 15 minutes AFAIK between puppet runs | 15:05 |
docaedo | no more 404 on the assets, looks like it worked! | 15:11 |
kzaitsev_mb | might be a good idea to return Content-Type somehow, I guess =) just a suggestion ) | 15:13 |
kzaitsev_mb | this would probably require configuring web-server though. | 15:13 |
kfox1111 | back. | 15:25 |
kfox1111 | we need to reconfigure the webserver anyway to support CORS. would be a good time. | 15:26 |
docaedo | CORS update:https://review.openstack.org/#/c/218898/1 | 15:32 |
kfox1111 | thx. looking... | 15:34 |
kfox1111 | docaedo: thanks. comments in the review. | 15:39 |
kfox1111 | might switch from <Directory> to <Location> to implement it too. | 15:40 |
docaedo | ah that's true | 15:43 |
docaedo | I can update that to use location instead of directory - should we also drop /static at the same time? Do we have any reason to keep that? | 15:48 |
docaedo | (and thanks for that, I completely forgot about location config!) | 15:49 |
kfox1111 | probably safe to drop /static... would break existing plugin users, but I think that number is 0 at the moment. :) | 15:50 |
kfox1111 | (np. :) | 15:51 |
docaedo | <Location <%= @docroot %>/api/v1/assets> | 15:52 |
docaedo | Header set Access-Control-Allow-Origin "*" | 15:52 |
docaedo | Header set Content-type "application/json" | 15:52 |
docaedo | </Location> | 15:52 |
docaedo | <Location <%= @docroot %>/api/v1/assets> | 15:52 |
docaedo | Header set Access-Control-Allow-Origin "*" | 15:52 |
docaedo | Header set Content-type "application/json" | 15:52 |
docaedo | </Location> | 15:52 |
docaedo | erp .. did not mean to paste twice :) | 15:52 |
kfox1111 | hmm.. I think drop the docroot. | 15:52 |
kfox1111 | just <Location /api/v1/assets> | 15:52 |
docaedo | ah yep! thanks | 15:52 |
kfox1111 | perfect. thanks. :) | 15:55 |
docaedo | np.. stepping out for a bit but back soon | 15:56 |
kfox1111 | k. | 15:57 |
*** kebray has quit IRC | 16:08 | |
*** rhagarty_ has quit IRC | 17:09 | |
*** rhagarty has quit IRC | 17:09 | |
*** rhagarty has joined #openstack-app-catalog | 17:14 | |
*** rhagarty_ has joined #openstack-app-catalog | 17:14 | |
*** ig0r__ has joined #openstack-app-catalog | 17:43 | |
*** ig0r_ has quit IRC | 17:46 | |
*** kzaitsev_mb has quit IRC | 17:51 | |
kfox1111 | docaedo: did you see my icon question? Kloudbuster would be the only non murano app without an icon at this point if it gets added. | 18:15 |
docaedo | did not see the icon question, no sorry | 18:21 |
docaedo | I don't really have a strong opinion there, could give a response via review to note adding an icon would be good? ugh that reminds me I want to try to fix the instructions on the wiki today (though I'm not sure what guidance to provide regarding the size/placement options, so would need some help from you there I think) | 18:23 |
kfox1111 | k. was curious if you knew if there's an openstack artwork group or something? | 18:23 |
kfox1111 | icon should be 128x128. top = 0 and left = 0 if thats the case. | 18:24 |
kfox1111 | and height = 128. | 18:24 |
kfox1111 | if not, you can tweak height and top/left until it looks big and centered. | 18:24 |
docaedo | got it | 18:24 |
docaedo | don't know if there's a group that does artwork for openstack, though I don't think there is - like, do you mean something the foundation runs? | 18:25 |
kfox1111 | something like openstack-api but for artists. | 18:25 |
kfox1111 | hmm... I was going to throw the horizon/app-catalog-ui version in a header to the asset request, but that would require a preflight request, which may need a slightly different CORS setup... :/ | 18:26 |
*** ig0r__ has quit IRC | 18:48 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 19:00 | |
*** kebray has joined #openstack-app-catalog | 20:44 | |
*** kebray has quit IRC | 20:44 | |
*** kebray has joined #openstack-app-catalog | 20:45 | |
*** kebray has quit IRC | 20:59 | |
openstackgerrit | Kevin Fox proposed stackforge/apps-catalog: More CORS support https://review.openstack.org/219024 | 21:00 |
openstackgerrit | Arthur Berezin proposed stackforge/apps-catalog: Adding Couldify TOSCA Orchestrator to the App Catalog. https://review.openstack.org/219035 | 21:32 |
*** Berezin has joined #openstack-app-catalog | 21:34 | |
Berezin | kzaitsev_ws: kzaitsev_mb thanks for the help, I've commited a new patch, after the restructure of the files. | 21:36 |
Berezin | kzaitsev_ws: kzaitsev_mb https://review.openstack.org/#/c/219035/ | 21:36 |
kzaitsev_mb | Berezin: thanks =) We'll look at it =) The patch looked good the way it was before merge, so I guess it would be ok now too ) | 21:46 |
kzaitsev_mb | Berezin: could you maybe add a bit more info to description — at least the OS of the image | 21:52 |
*** Berezin has quit IRC | 21:57 | |
kfox1111 | docaedo: alive? | 22:18 |
docaedo | kfox1111: for some definition of alive ;) Went for an eye exam and had my pupils dilated, never done that before. holy crap does that wreck your vision for a while! | 22:33 |
docaedo | I'm just now starting to be able to make out letters on the screen, figure in 20-30 minutes I'll be back to norm | 22:34 |
kfox1111 | heh. yeah. :) | 22:34 |
kfox1111 | I've got another set of changes for the cors stuff. :/ | 22:34 |
kfox1111 | Something like this: http://pastebin.com/RAtYvvWw | 22:35 |
kfox1111 | we may want to set a cache header too. | 22:35 |
kzaitsev_mb | kfox1111: setting cache header is a good idea indeed | 22:37 |
kzaitsev_mb | hm. is it possible to utilise if-modified-since with this config? | 22:38 |
kzaitsev_mb | would be terriffic, considering the size of the file. | 22:38 |
kfox1111 | could. but you still get requests all the way to the server. if we cache the catalog for an hour or a few, then we get no hits at all if its cached. | 22:39 |
kzaitsev_mb | also gzipping it should reduce load time, since it should gzip really good. | 22:39 |
kfox1111 | yeah.... I've been wanting an apache module that let you pregzip the file and would then hand it out that way. Haven't seen such a beast yet. :/ | 22:39 |
kzaitsev_mb | I've always been an nginx guy for that matter =) | 22:40 |
kfox1111 | google has a very interesting version of gzip. it brute force compresses it, trying to make it as ideally compressed as possible. | 22:40 |
kfox1111 | takes a long time to compress, but makes the smallest possible gzip. :) | 22:40 |
kzaitsev_mb | http://httpd.apache.org/docs/2.4/mod/mod_deflate.html not this? | 22:41 |
kfox1111 | ah... the serving pre-compressed content thing. yeah. | 22:42 |
kzaitsev_mb | kfox1111: I'm more concerned, that a browser might cache the json forever | 22:42 |
kfox1111 | so... docaedo... you remember when I wanted to build the assets json file out of our own scripts? | 22:42 |
kzaitsev_mb | then we would not be able to update anything | 22:42 |
kfox1111 | cause now I want to change the infra code to pregzip it. ;) | 22:42 |
kfox1111 | kzaitsev_mb: have you run into that problem? | 22:43 |
kzaitsev_mb | kfox1111: why? deflate should be good enough for the task, I guess | 22:43 |
kzaitsev_mb | kfox1111: with some js/css files, sometimes. | 22:44 |
kzaitsev_mb | I'm not sure on the state of browser caching right now. | 22:44 |
* kfox1111 shurgs. no request scales better then some requests? :) | 22:44 | |
kfox1111 | guess we can just do the gzip thing for now. we can always enable more caching later. | 22:46 |
kzaitsev_mb | to fight that most projects use some hashing techique. we could too. | 22:46 |
kfox1111 | if we don't hit v2 before then. :) | 22:46 |
kzaitsev_mb | I've used some on pure apache at some point in time ) | 22:47 |
kfox1111 | I'm not sure I know of a way to do hashing without doing a round trip anwya. | 22:47 |
kzaitsev_mb | I mean md5sum the file and add it's hash to it's name like assets.12345qwerty and remove it with mod rewrite | 22:47 |
kzaitsev_mb | during file creation =) | 22:48 |
kfox1111 | yeah, but since the plugin hits http://apps.openstack.org/api/v1/assets, how would it know the sum to hit? | 22:48 |
kzaitsev_mb | it woudn't need to | 22:48 |
kzaitsev_mb | or it would | 22:48 |
kfox1111 | but then it wouldn't save you a round trip, which is the reason to cache it. | 22:49 |
kzaitsev_mb | yep, you're right =) | 22:49 |
kfox1111 | :) | 22:49 |
kzaitsev_mb | yeah, the requester needs to know that | 22:49 |
kzaitsev_mb | well as of now this is all not really that significant ) | 22:50 |
kfox1111 | what distro's the webserver running? | 22:51 |
kfox1111 | do we have this available? :) | 22:52 |
kfox1111 | https://github.com/google/zopfli | 22:52 |
kzaitsev_mb | although deflate looks like a bit more robust idea to me. it would set the header itself | 22:52 |
kzaitsev_mb | well, if you insist — do not forget to set "Content-Encoding: gzip" | 22:53 |
*** Berezin has joined #openstack-app-catalog | 22:53 | |
kfox1111 | Berezin: wb | 22:53 |
kfox1111 | kzaitsev_mb: I'm liking that serving pre-compressed content example. I think it should be pretty easy to adapt. | 22:55 |
kzaitsev_mb | and "Vary: Accept-Encoding" | 22:57 |
kzaitsev_mb | and not set the previous one =) | 22:58 |
kzaitsev_mb | I'm confused | 22:58 |
kzaitsev_mb | should probably get some sleep =) | 22:58 |
*** kzaitsev_mb has quit IRC | 23:19 | |
*** kzaitsev_mb has joined #openstack-app-catalog | 23:32 | |
*** Berezin has quit IRC | 23:35 | |
*** Berezin has joined #openstack-app-catalog | 23:45 | |
kfox1111 | docaedo: still here? | 23:50 |
*** Berezin has quit IRC | 23:57 | |
kfox1111 | docaedo: do you have a way to test the puppet stuff? | 23:58 |
docaedo | kfox1111: Hi, I'm here/back for a little bit | 23:59 |
docaedo | do have a way to test the puppet stuff | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!