Thursday, 2014-07-10

*** asalkeld has joined #murano00:17
*** IlyaE has joined #murano00:31
*** IlyaE has quit IRC00:47
*** asalkeld has quit IRC02:25
*** asalkeld_ has joined #murano02:25
*** IlyaE has joined #murano02:32
*** IlyaE has quit IRC02:38
*** killer_prince is now known as lazy_prince02:53
*** IlyaE has joined #murano03:04
*** IlyaE has quit IRC03:17
*** asalkeld_ has quit IRC03:21
*** IlyaE has joined #murano03:22
*** lazy_prince is now known as killer_prince03:37
*** drupalmonkey has joined #murano03:39
*** drupalmonkey has quit IRC03:39
*** IlyaE has quit IRC03:54
*** killer_prince is now known as lazy_prince04:11
*** chandankumar has joined #murano04:34
*** chandankumar has quit IRC04:44
*** IlyaE has joined #murano04:45
*** IlyaE has quit IRC04:58
*** chandankumar has joined #murano05:24
*** k4n0 has joined #murano05:35
*** lazy_prince is now known as killer_prince05:52
openstackgerritEkaterina Chernova proposed a change to stackforge/murano-dashboard: Fix statuses for environment state  https://review.openstack.org/10480106:12
*** killer_prince is now known as lazy_prince06:16
*** lazy_prince has quit IRC06:23
*** IlyaE has joined #murano06:47
*** killer_prince has joined #murano07:21
*** killer_prince has quit IRC07:21
*** lazy_prince has joined #murano07:22
openstackgerritEkaterina Chernova proposed a change to stackforge/murano-dashboard: Fix statuses for environment state  https://review.openstack.org/10480107:52
*** stanlagun has joined #murano08:08
*** IlyaE has quit IRC08:13
openstackgerritEkaterina Chernova proposed a change to stackforge/murano-dashboard: Fix statuses for environment state  https://review.openstack.org/10480108:28
openstackgerritA change was merged to stackforge/python-muranoclient: Add package-create command  https://review.openstack.org/9917708:56
openstackgerritA change was merged to stackforge/python-muranoclient: Update package-import command  https://review.openstack.org/10216208:56
*** lazy_prince is now known as killer_prince09:23
*** killer_prince is now known as lazy_prince09:30
openstackgerritStan Lagun proposed a change to stackforge/murano: Unit tests for MuranoPL assignment expressions  https://review.openstack.org/10472209:57
*** lazy_prince is now known as killer_prince09:59
*** sergmelikyan has quit IRC10:04
*** killer_prince is now known as lazy_prince10:06
openstackgerritRuslan Kamaldinov proposed a change to stackforge/murano: DO NOT MERGE: func tests debugging  https://review.openstack.org/10601711:18
*** k4n0 has quit IRC11:26
*** lazy_prince has quit IRC11:37
*** openstackgerrit has quit IRC11:47
*** killer_prince has joined #murano11:52
*** killer_prince is now known as lazy_prince11:53
*** lazy_prince has quit IRC12:07
*** killer_prince has joined #murano13:26
*** killer_prince is now known as lazy_prince13:26
*** rakhmerov has quit IRC13:47
*** akuznetsova has quit IRC13:48
*** katyafervent has quit IRC13:48
*** IgorYozhikov has quit IRC13:48
*** tsufiev has quit IRC13:48
*** igormarnat has quit IRC13:48
*** dteselkin has quit IRC13:48
*** ativelkov has quit IRC13:48
*** drupalmonkey has joined #murano13:48
*** sergmelikyan has joined #murano13:50
*** sjmc7 has joined #murano14:01
sergmelikyansjmc7, o/14:05
sjmc7hi14:06
sergmelikyansjmc7, https://review.openstack.org/105686 - added unit-tests :)14:06
sergmelikyanand integration test14:06
sjmc7ah, cool14:07
sjmc7i will take a look14:07
sergmelikyanBut unit-tests are not going to pass :( Some small issues in dsl tests foundation.14:08
sergmelikyanI think unit-tests for base class library are little bloated - this is caused fact that if you need mock/stubs something in PL classes you need to create class file14:09
sjmc7you mean you need a yaml file?14:10
sergmelikyanyes14:10
sjmc7yeah.. mocking those classes is hard14:10
sergmelikyanBut this is may be improved, but I suggest to do it in another patch. I think we need some generic mocking tool for murano PL. Something small - at least to stub something that is not used by SAT14:11
sergmelikyan*can be14:11
sjmc7you don't necessarily need yaml files - it could be a python structure14:11
sjmc7or just a string14:11
sergmelikyanmmm?14:11
sjmc7but yeah, that should be separate14:11
sjmc7sergmelikyan, have you taken a look at https://wiki.openstack.org/wiki/TaskFlow ?14:36
*** akuznetsova has joined #murano14:38
*** rakhmerov has joined #murano14:39
*** IgorYozhikov has joined #murano14:39
ruhesjmc7: do you that taskflow could help us somewhere?14:41
ruhe* do you think that14:42
*** ativelkov has joined #murano14:42
sjmc7i only discovered it today, but yeah, maybe. if you consider a 'task' updating and pushing a heat template, rollback to remove what you just added14:43
*** katyafervent has joined #murano14:43
*** dteselkin has joined #murano14:44
*** tsufiev has joined #murano14:47
*** igormarnat has joined #murano14:47
*** IlyaE has joined #murano14:55
*** chandankumar has quit IRC15:31
*** openstackgerrit has joined #murano15:32
openstackgerritSerg Melikyan proposed a change to stackforge/murano: Improve dsl testing framework foundation  https://review.openstack.org/10607715:32
openstackgerritSerg Melikyan proposed a change to stackforge/murano: Fix stack inconsistency after app deletion  https://review.openstack.org/10568615:34
openstackgerritSerg Melikyan proposed a change to stackforge/murano: Delete Heat stack when environment is deleted  https://review.openstack.org/10281015:42
sergmelikyansjmc7, in which timezone lives Ankur? :)16:05
sjmc7california16:05
sergmelikyanthx16:05
sjmc7GMT-816:05
sjmc7which is why he's rarely online the same time as you guys :)16:06
sergmelikyansjmc7, I think we need to resolve all questions about https://review.openstack.org/99465 and merge it today :)16:09
sjmc7drupalmonkey (ryan) is online16:10
sergmelikyanstanlagun, you work pretty late usually, can you catch up with Ankur and resolve all your open questions about this patch?16:10
stanlagunI can16:10
sergmelikyanYou will do? )16:11
sergmelikyanThere only one major thing actually - supplier info introduced only for murano packages - we need to introduce this for all types of packages16:11
stanlagunThe  problem is that hi is not here16:11
sergmelikyanstanlagun, he will be later :)16:11
sjmc7can we do that as a separate patch?16:11
sjmc7or discuss with ryan now16:11
sergmelikyansjmc7, sure, but I am little bit worried about merging patch with so easy and oblivious fix...16:12
stanlagunActually I have 2 questions, both in https://review.openstack.org/#/c/99465/15/murano/packages/versions/mpl_v1.py16:12
sjmc7ok, but it needs to get merged pretty quickly or not at all - we've spent way too much time on it16:12
sergmelikyansjmc7, today we discovered patch of one of the our coworker that going through really hellish phase: [3:44:35 PM | Edited 3:44:42 PM] Serg Melikyan: https://review.openstack.org/82488 - 23 patches, ~6 months16:13
sjmc7so yes, resolve questions today please16:13
sergmelikyansjmc7, sure :)16:13
stanlagun1. What is the purpose of renaming (long block of code that seems redundant) and can we duplicate changes in this file to hot_v1.py16:13
sergmelikyantoday it is going to be merged16:13
sjmc7oh yeah, heat's tough to get patches in16:13
sergmelikyandrupalmonkey, what do you think about questions from Stan?16:14
sergmelikyansjmc7, right after merging that patch - all related patches are going to be merged right away16:15
drupalmonkeyI'm not sure for the exact reason for the renaming of those variables.. my guess was to have "human-readable" names in the manifest file, but then to have the variables usable by the template files with underscores and such16:16
stanlagunwhat template files?16:17
drupalmonkeythe template files on the murano-dashboard side.. muranodashboard/templates/catalog/_overview.html16:18
sergmelikyanin python/templates snake_case looks more natural than Camel-Case with dashes. stanlagun I think this is may be leaved as is16:21
*** IlyaE has quit IRC16:21
drupalmonkeyalso i think part of this is because of multi-level data.. Ankur couldn't just use: package._supplier = yaml_content.get('Supplier'), because the Supplier info wasn't just a flat string16:24
stanlagun_supplier is dictionary anyway and stored in DB as JSON blob16:26
sergmelikyanLet's wait till ankurrr will wake up and do a little bit pair programming :)16:26
sergmelikyansjmc7, https://review.openstack.org/102321 - can you merge this one?16:26
sjmc7he's online, i'll get him to sign into IRC16:27
sjmc7done16:27
*** ankurrr has joined #murano16:27
sergmelikyansjmc7, thx!16:28
*** IlyaE has joined #murano16:28
sergmelikyanankurrr, morning!16:31
sergmelikyanSorry for disturbing you so early :)16:31
sergmelikyanhttp://eavesdrop.openstack.org/irclogs/%23murano/%23murano.2014-07-10.log - we had a little discussion about you patch. It's look pretty cool, only few small questions :) Lets fix them online?16:32
sergmelikyan*you patch/your patch16:32
ankurrrsergmelikyan: sure, how should we start16:33
sergmelikyanankurrr: ><stanlagun> Actually I have 2 questions, both in https://review.openstack.org/#/c/99465/15/murano/packages/versions/mpl_v1.py16:34
sergmelikyanankurrr, I think we need to support supplier info in both type of packages16:35
sergmelikyanand there was also a question about why do we make renaming - may be we can avoid it?16:36
sergmelikyanI think code for supplier info may be extracted to https://github.com/stackforge/murano/blob/master/murano/packages/application_package.py16:37
sergmelikyanstanlagun, what do you think?16:37
ankurrrsergmelikyan: the renaming is done just to be consistent with how the other attributes of a package are handled.16:37
ankurrreverything starts of upper case and is flattened eventually16:37
stanlagunankurrr: can we keep it as is? it just complicated code16:38
ankurrrstanlagun: then my preference would be to start off with these attribute names in lower case (in the manifest.yaml file).  however, I'm trying to understand: don't we currently do the same for the other fields? ("Name" becomes "name", "Logo" becomes "logo", "Author" becomes "author", etc)16:40
openstackgerritA change was merged to stackforge/murano-dashboard: Adds test coverage for flavor filter  https://review.openstack.org/10232116:41
stanlagunankurrr: AFAIU 'Name' attribute is stored in 'name' field of type string in DB. 'Supplier' will be stored in 'supplier' field of type JsonBlob. The inner structure can remain the same as in manifest16:42
stanlagunas far as I understand your code you do store it in JSON blob. I don't see any flattering. Or maybe I'm missing something?16:43
stanlagunCompany-URL will become JSON attribute name that is valid for JSON. There is no column with such name so no need for underscore16:44
*** chandankumar has joined #murano16:45
stanlagunand this can be simplified tp package._supplier = yaml_content.get('Suplier', {})16:45
ankurrrstanlagun: the structure goes as is into the json blob.  however, in the code, I'd personally prefer using lower-case values for the dictionary keys.  that way, a coder doesn't have to remember which names were upper-case and which weren't.  if the solution is to make everything under 'Supplier' lower case, then I'm fine doing that.16:46
ankurrrstanlagun: also, I think the hyphens cause an issue when pulling them out with the client for the related dashboard changes.16:46
ankurrri can't just start off with "company_url" in the manifest.yaml file instead of "Company-URL"16:47
ankurrr*can16:47
stanlagunankurrr: there is a convention that we use saying that all predefined keywords (keys, names etc) should be in PascalCase (Pascal-Case) and variable names (method names etc.) should be in camelCase.16:50
stanlagunAs for the code - those are strings, not variable names or something16:50
drupalmonkeyfor django template files variables can't have hyphens in them16:50
drupalmonkeycauses an exception16:50
drupalmonkeyparse error or something16:51
drupalmonkeythey have to be underscores16:51
ankurrrstanlagun: so the conversion of hyphens to underscores has to happen somewhere.  why don't we just start off with underscores in the manifest.yaml file then?16:52
stanlagunthose are not filenames and not Jango. It can be CompanyUrl if you'd like16:52
stanlaguncan you explain why it has to happen anywhere?16:52
ankurrrstanlagun: if we start off with hyphenated attribute names in the manifest.yaml file and wish to keep the code simple without doing any conversion on the API side, then the code on the dashboard side has to remove the hyphen before putting it in a variable for the Django template.16:54
stanlagunvariable_name = dict['Company-URL']['Link']. What is wrong with that code?16:56
stanlagunI'm not familiar with Django. Maybe thas why I don't understand :)16:56
ankurrrstanlagun: I believe, on the murano dashboard side, we can't simply just pass this dict into a template.  From what I understand, the hyphen in "Company-URL" will cause a problem in the django template if we pass dict as is.16:58
stanlaguntsufiev: katyafervent: are you here with us?16:58
ankurrrstanlagun: that then means that somewhere in the dashboard code, we would need some kind of treatment of the dict that removes the "-" from "Company-URL'16:59
sjmc7i can referee django questions16:59
sjmc7yes - you would put something in to rewrite the context data before sending it for rendering16:59
drupalmonkeystanlagun: a hyphen, in a line like so: {% if app.supplier.company-url.link %}17:00
drupalmonkeycauses this error: TemplateSyntaxError at /murano/catalog/details/222a237cf9ab4d49a6133b4e2f860aba17:00
drupalmonkeyCould not parse the remainder: '-url.link' from 'app.supplier.company-url.link'17:00
stanlagunok, got it17:00
sjmc7there may be a tag in horizon already that can do this, i haven't looked, but dashes in variable names or dictionary key cause trouble17:00
ankurrrI have no problem with that.  I simply want to point out that we have a desire to avoid needing the extra code of removing the hyphens in the api code.  but then we're just forcing that code to exist on the dashboard side.  maybe we should just start off with underscores everywhere.17:01
sjmc7it's reasonably simple to do the replacement in the dashboard if that's where it makes sense17:01
stanlagunWhat if we just change it to CompnayUrl?17:01
sjmc7then that's fine in django17:02
ankurrrstanlagun: CompanyUrl or "CompanyURL"?  Also, should all the key values in the dict be camel-case?17:02
sjmc7but django shouldn't necessarily drive data structures17:02
stanlagunThe reason I don't like renaming in API is because it has nothing to do with Django and seems obscure. And we need to duplicate all that code to HOT package and I'd wish to avoid having such code twice17:02
stanlagunCompanyUrl17:02
sjmc7name variables however they make sense, and fix names in the dashboard if necessary17:03
stanlagunKey values should be PascalCase because their names are fixed17:03
stanlagundashboard is a much better place to do that17:04
ankurrrstanlagun: ok.  so, (1) we want this in place for HOT packages and (2) PascalCase all the dict keys17:04
ankurrrstanlagun: I'll submit another patch set17:05
stanlagunyes. Just remove the renaming code (make it CompanyUrl instead of Company-URL in manifest if you like it more) and duplicate what is left to hot_v1.py17:07
stanlagunin dashboard you can rename it to anything you'd like. No problem with that17:08
stanlagunbtw can we just always call supplier logo supplier.png? Otherwise we need to have key for ordinary logo17:09
stanlagunand one more question: if I'm writing package for Oracle MySql who is author and who is supplier in that case?17:12
sjmc7stanlagun - this was for cases where e.g. HP package something but a different company is the supplier17:13
sjmc7just for additional company information17:13
stanlagunand in my example I will be author or supplier?17:14
sjmc7author17:14
*** lazy_prince is now known as killer_prince17:14
stanlagunso Oracle is supplier?17:14
sjmc7yes17:14
stanlagungot it17:15
stanlagunand what about logo?17:15
sjmc7what about it?17:15
stanlagunforget it. I thought author's logo file name is hardcoded so there is no reason to have it configurable for supplier. I was wrong17:17
*** sjmc7_ has joined #murano17:20
*** sjmc7 has quit IRC17:24
*** sjmc7_ is now known as sjmc717:27
sjmc7separate question - the 'signing_dir' in the keystone_authtoken config section, what exactly is that doing, and are there other services that use it so i can see how they configure it in deployments?17:28
stanlagunkeystone client uses it17:29
stanlagunit stores certificates there or something like that17:30
stanlagunDirectory used to cache files related to PKI tokens17:31
sjmc7is it required?17:31
sjmc7i've had it get out of date before; i'm trying to figure out what i need to do to make sure it's configured right in proper deployments17:32
stanlagunI'm not sure. I saw it being used but don't remember under what circumstances17:33
*** bharath has joined #murano17:50
*** IlyaE has quit IRC17:50
bharathstanlagun: hi17:51
stanlagunbharath: hi!17:51
*** bharath has quit IRC17:55
*** slagun has joined #murano18:00
*** stanlagun has quit IRC18:03
*** IlyaE has joined #murano18:11
openstackgerritAnkur Rishi proposed a change to stackforge/murano: Add optional fields to packages for supplier info  https://review.openstack.org/9946518:14
*** IlyaE has quit IRC18:14
ankurrrstanlagun: submitted an updated patch set for https://review.openstack.org/99465  with all names in PascalCase and with supplier info stuff included for HOT packages18:16
slagunankurrr: Excellent! +2 just after Jenkins/murano-ci18:21
ankurrrslagun: cool.  thanks for bearing with my while we sorted this out.18:22
slagunsorry for reviewing it so late. Don't hesitate to contact me next time is your commit doesn't get reviewed. Its my top priority18:25
ankurrrslagun: sure, will keep in mind for future code reviews18:29
slagunankurrr: unfortunately murano-ci failed at your commit :(18:31
slagun/usr/local/lib/python2.7/dist-packages/murano/packages/application_package.py", line 121, in _load_supplier_logo18:32
slagunTypeError: argument of type 'NoneType' is not iterable18:32
ankurrrhmm18:33
slagunyou should  yaml_content.get('Supplier', {}) instead of  yaml_content.get('Supplier')18:34
slagunthis will fix it18:34
ankurrrah, yeah, I was wondering about that.   sure, let me do that18:34
slagunor even better  yaml_content.get('Supplier') or {}18:34
openstackgerritAnkur Rishi proposed a change to stackforge/murano: Add optional fields to packages for supplier info  https://review.openstack.org/9946518:36
openstackgerritAnkur Rishi proposed a change to stackforge/murano: Add optional fields to packages for supplier info  https://review.openstack.org/9946518:44
slagunsjmc7: please take a look at my remark at https://review.openstack.org/#/c/100344/7/meta/io.murano/Classes/resources/HeatSWConfigInstance.yaml. This error remains in patch set 818:45
sjmc7ah, good catch, sorry18:45
openstackgerritSteve McLellan proposed a change to stackforge/murano: Add 'userdata_format' to Server heat template  https://review.openstack.org/10034418:46
slagunlooks good to me. Lets wait for ci18:48
slagun+2 for both commits.19:08
slagunruhe: need more cores to merge them19:09
*** chandankumar has quit IRC19:25
*** sjmc7_ has joined #murano19:32
*** sjmc7_ has quit IRC19:34
*** sjmc7_ has joined #murano19:34
*** sjmc7 has quit IRC19:35
*** sjmc7_ is now known as sjmc719:35
openstackgerritRyan Peters proposed a change to stackforge/murano-dashboard: Displays supplier info fields on Application Details page  https://review.openstack.org/10399020:26
*** serg_melikyan has joined #murano21:02
serg_melikyansjmc7: https://review.openstack.org/103990 - reviewd21:06
serg_melikyansjmc7: https://review.openstack.org/105545 - for this one we need to sort out issues with CI first :(21:07
serg_melikyanI thing that this change not going to cause issues but we need to fix CI to be sure21:09
openstackgerritA change was merged to stackforge/murano: Add optional fields to packages for supplier info  https://review.openstack.org/9946521:10
sjmc7hurrah! thanks21:10
serg_melikyanslagun, please recheck your changes against murano-ci21:10
serg_melikyansjmc7: I hope this will never happen again :)21:12
sjmc7yeah, that chage likely didnt cause the CI problem21:12
sjmc7i'm sure it will :)  it's no big deal, we just kept getting asked why it wasn't checked off our list21:12
slagunwell it seems that is because of commit21:12
slagunseveral unit tests failed. And they related to images21:13
serg_melikyanguys, don't hesitate do ask for review if something is stuck for more then one day21:13
slagunWhy glance behavior  changed but there was no update for glance client in requirements.txt?21:13
serg_melikyanslagun: change was done in openstack_dashboard https://github.com/openstack/horizon/commit/2428d78a156d215b6bdc0e6172c86609394ca72621:16
serg_melikyankatyafervent: do we install latest openstack_dashboard as part of testing?21:17
serg_melikyanAs part of tox we install stable-icehouse - https://github.com/stackforge/murano-dashboard/blob/master/tox.ini#L1821:19
serg_melikyanruhe: i think this is wrong21:19
serg_melikyanhttps://github.com/stackforge/murano-dashboard/blob/master/setup.sh relies on horizon to be installed...21:20
serg_melikyanI think IgorYozhikov can help us with this issue :) But, I guess, only tomorrow :_21:21
serg_melikyanhave a nice day, guys :)21:21
* serg_melikyan finally moving to bed21:21
*** serg_melikyan has quit IRC21:34
sjmc7slagun - i think when i looked at it that glance was getting pulled in with a minimum version but not a max21:41
sjmc7so the update started getting dragged in21:41
sjmc7yeah, serg is right, that was the commit21:45
*** btully has quit IRC22:29
*** sergmelikyan has quit IRC22:32
*** ankurrr has quit IRC22:32
*** IgorYozhikov has quit IRC22:32
*** rakhmerov has quit IRC22:32
*** akuznetsova has quit IRC22:32
*** tnurlygayanov has quit IRC22:33
*** katyafervent has quit IRC22:33
*** ativelkov has quit IRC22:33
*** drupalmonkey has quit IRC22:33
*** slagun has quit IRC22:33
*** dteselkin has quit IRC22:33
*** killer_prince has quit IRC22:33
*** ciypro|afk has quit IRC22:33
*** openstackgerrit has quit IRC22:33
*** sjmc7 has quit IRC22:33
*** peoplemerge has quit IRC22:33
*** igormarnat has quit IRC22:33
*** tsufiev has quit IRC22:33
*** ruhe has quit IRC22:33
*** sjmc7 has joined #murano22:36
*** slagun has joined #murano22:36
*** ankurrr has joined #murano22:36
*** openstackgerrit has joined #murano22:36
*** igormarnat has joined #murano22:36
*** tsufiev has joined #murano22:36
*** dteselkin has joined #murano22:36
*** katyafervent has joined #murano22:36
*** ativelkov has joined #murano22:36
*** IgorYozhikov has joined #murano22:36
*** rakhmerov has joined #murano22:36
*** akuznetsova has joined #murano22:36
*** sergmelikyan has joined #murano22:36
*** drupalmonkey has joined #murano22:36
*** killer_prince has joined #murano22:36
*** peoplemerge has joined #murano22:36
*** ciypro|afk has joined #murano22:36
*** tnurlygayanov has joined #murano22:36
*** ruhe has joined #murano22:36
*** drupalmonkey has quit IRC22:42

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!