Wednesday, 2014-07-09

*** IlyaE has quit IRC00:01
*** IlyaE has joined #murano00:17
*** ankurrr has quit IRC00:22
openstackgerritA change was merged to stackforge/murano: Fix setup.sh to import core library each time  https://review.openstack.org/10539801:12
*** asalkeld has joined #murano01:36
*** killer_prince has quit IRC01:41
*** IlyaE has quit IRC01:50
openstackgerritSteve McLellan proposed a change to stackforge/murano: Add 'userdata_format' to Server heat template  https://review.openstack.org/10034402:04
*** sjmc7 has quit IRC02:16
*** killer_prince has joined #murano02:20
*** killer_prince is now known as lazy_prince02:20
*** asalkeld has quit IRC02:20
*** IlyaE has joined #murano02:37
*** asalkeld has joined #murano02:40
*** IlyaE has quit IRC02:51
*** asalkeld has quit IRC02:54
*** IlyaE has joined #murano03:06
*** lazy_prince is now known as killer_prince03:09
*** IlyaE has quit IRC03:12
*** killer_prince is now known as lazy_prince03:21
*** IlyaE has joined #murano03:40
*** IlyaE has quit IRC04:21
*** IlyaE has joined #murano05:03
*** chandankumar has joined #murano05:19
*** IlyaE has quit IRC05:25
openstackgerritStan Lagun proposed a change to stackforge/murano: Fixes name generation for Heat stack  https://review.openstack.org/10537905:32
*** lazy_prince is now known as killer_prince05:32
*** IlyaE has joined #murano05:58
*** IlyaE has quit IRC06:56
*** IlyaE has joined #murano07:06
*** IlyaE has quit IRC07:15
*** lazy_prince has joined #murano08:09
*** lazy_prince has quit IRC08:10
*** killer_prince is now known as lazy_prince08:10
*** btully has quit IRC08:41
*** btully has joined #murano08:41
*** lazy_prince is now known as killer_prince08:56
*** killer_prince is now known as lazy_prince09:12
*** lazy_prince has quit IRC09:44
openstackgerritSerg Melikyan proposed a change to stackforge/murano: Fix stack inconsistency after app deletion  https://review.openstack.org/10568609:56
*** killer_prince has joined #murano10:03
*** killer_prince is now known as lazy_prince10:03
*** mihgen has left #murano10:04
openstackgerritSerg Melikyan proposed a change to stackforge/murano: Delete Heat stack when environment is deleted  https://review.openstack.org/10281010:48
*** lazy_prince has quit IRC11:08
openstackgerritSerg Melikyan proposed a change to stackforge/murano: Fix syntaxt error in Environment.yaml  https://review.openstack.org/10570511:24
*** killer_prince has joined #murano11:41
*** killer_prince is now known as lazy_prince11:41
openstackgerritSerg Melikyan proposed a change to stackforge/murano: Fix syntax error in Environment.yaml  https://review.openstack.org/10570511:42
openstackgerritSerg Melikyan proposed a change to stackforge/murano: Fix stack inconsistency after app deletion  https://review.openstack.org/10568611:57
sergmelikyanGuys, slagun, sjmc7 - I have committed separate fix for issue that you were talking about yesterday12:07
sergmelikyanhttps://review.openstack.org/#/c/105405/12:07
sergmelikyanruhe, I think we can't make murano-ci pass on this patch since this change is cross-blocked by issue fixed in https://review.openstack.org/105405 change12:08
sergmelikyanBut tests on murano-ci is passed for some part of tests, this mean that patch actually working.12:08
ruhesergmelikyan: ok. what should go first?12:09
sergmelikyanOnly tomcat test is failed - because of issue fixed in  https://review.openstack.org/10540512:09
sergmelikyanhttps://review.openstack.org/105705 - this one is a root12:10
sergmelikyanruhe, this issue prevents deployment of master branch12:10
sergmelikyanno environment can be deployed currently, unless this change is merged in12:10
ruhesergmelikyan: it looks pretty straightforward, i don't have objections to merging it without +1 from murano-ci12:11
sergmelikyanThan I suggest to abandon fix https://review.openstack.org/105405 introduced by Timur, and make another one that contains only fixes for timeout issue with tomcat and reference correct bug from launchpad12:11
sergmelikyanwe have evidence that we have issue with leak of floating ips12:12
sergmelikyanso this part of Timurs change is controversial12:12
sergmelikyanruhe, thx!12:12
sergmelikyanativelkov, tsufiev guys, could you also look at https://review.openstack.org/10570512:13
sergmelikyantnurlygayanov, do you have objections against my suggestions?12:13
sergmelikyanruhe, what do you think?12:13
sergmelikyanThis two fixes should finally fix gate12:14
ruhesergmelikyan: yeah, i think floating ips shouldn't be handled in the test code12:14
sergmelikyanhttps://review.openstack.org/105686 - this one is related to murano-ci gate too, but this is fix for issue that going to be discovered by tests in this fix https://review.openstack.org/10281012:15
sergmelikyanso it is more like preventive fix12:15
sergmelikyan*we have no evidence12:16
ruhesergmelikyan: you gave so many links :) people might be confused. first one to go is https://review.openstack.org/#/c/105705/ (fix syntax error). what's the second one?12:17
sergmelikyanruhe, second fix is https://review.openstack.org/105405 that I think we need to abandon and refactor to simple fix for timeouts12:18
ruhesergmelikyan: are you working on simpler version or are you asking Timur to do it?12:19
tnurlygayanovso....12:20
sergmelikyanruhe, I think I can do it by myself (we need to fix issue with gate ASAP)12:20
tnurlygayanovlet's discuss fix for integration tests with floating ips12:20
ruhesergmelikyan: ok12:20
sergmelikyanI am working on debugging gate, so if tnurlygayanov has no objection I will gladly do it by myself12:20
sergmelikyantnurlygayanov, I think we should not merge change without proof that we need this. We added code that clean-ups floating ips only because we thought that they caused "key error ipAddresses" issue. This was wrong assumption.12:22
ruhetnurlygayanov: there are two parts in your patch 1) timeouts for service availability checks. this is a part we really need and nobody has conserns about 2) handling of floating ips in the whole ci lab. this change has might cause problems at this moment and we need to spend more time to understand whether it's really floating ips or some other problem12:23
tnurlygayanovbut we find this way only with this patch set - without this patch set we said 'it is floating ips'12:23
tnurlygayanovok, team, I will update my patch sets12:24
tnurlygayanovbut I'm really want to add check for floating ips - it will be helpful in the future12:24
sergmelikyantnurlygayanov, thx. Remember that issue with timeouts in tomcat deployment verification (first part of the change) is blocking murano-ci gate12:25
sergmelikyantnurlygayanov, ok, check for floating ips can wait till we fix gate :)12:25
openstackgerritA change was merged to stackforge/murano: Fix syntax error in Environment.yaml  https://review.openstack.org/10570512:33
ruhesergmelikyan: tnurlygayanov: who's working on simpler version? it seems like both of you?12:35
sergmelikyanruhe, Timur said that he is going to do it12:39
ruhetnurlygayanov: we need it really soon12:39
tnurlygayanovruhe ok, 5 minutes..12:39
tnurlygayanovbug was created https://bugs.launchpad.net/murano/+bug/133969712:49
openstackgerritTimur Nurlygayanov proposed a change to stackforge/murano: Fixed issues with port checks timeout  https://review.openstack.org/10572912:50
tnurlygayanovhttps://review.openstack.org/10572912:50
tnurlygayanov^^^^^ fix commited12:50
tnurlygayanovruhe, sergmelikyan   need review ^^^^^12:51
sergmelikyantnurlygayanov, -112:56
sergmelikyantnurlygayanov, sorry +112:58
tnurlygayanov))) ok13:07
tnurlygayanovsergmelikyan you are core dev,  you can set +2 :)13:08
sergmelikyantnurlygayanov, sure :) When this patch going to work :)13:09
tnurlygayanovok13:09
sergmelikyanSorry for score that I have changed so many times :(13:09
openstackgerritTimur Nurlygayanov proposed a change to stackforge/murano: Fixed issues with port checks timeout  https://review.openstack.org/10572913:13
tnurlygayanovsergmelikyan no problem, new patch set is available13:14
ruhetnurlygayanov: i ran "recheck no bug" on your patch. py26 jobs failed because of pypi timeout13:31
openstackgerritTimur Nurlygayanov proposed a change to stackforge/murano: Fixed issues with port checks timeout  https://review.openstack.org/10572913:37
*** btully has quit IRC13:48
*** sergmelikyan has quit IRC13:48
*** iyozhikov has quit IRC13:48
openstackgerritTimur Nurlygayanov proposed a change to stackforge/murano: Fixed issues with port checks timeout  https://review.openstack.org/10572913:49
openstackgerritTimur Nurlygayanov proposed a change to stackforge/murano: Fixed issues with port checks timeout  https://review.openstack.org/10572913:50
openstackgerritTimur Nurlygayanov proposed a change to stackforge/murano: Fixed issues with port checks timeout  https://review.openstack.org/10572913:53
*** btully has joined #murano13:54
openstackgerritTimur Nurlygayanov proposed a change to stackforge/murano: Fixed issues with port checks timeout  https://review.openstack.org/10572913:55
openstackgerritTimur Nurlygayanov proposed a change to stackforge/murano: Fixed issues with port checks timeout  https://review.openstack.org/10572913:56
katyaferventHi13:58
katyaferventdo we need to get rid of unittest2 library?13:59
katyaferventor we can use both testtolls and unittest213:59
*** drupalmonkey has joined #murano13:59
katyaferventIn this patch I remove unittest2 from the requirements, but I found this https://github.com/stackforge/murano-dashboard/blob/master/functionaltests/base.py#L3014:00
katyaferventWhat do you think about using universal asserts which will be working on py27 and py27 at the time?14:01
katyaferventand finally remove the unittest2?14:01
openstackgerritTimur Nurlygayanov proposed a change to stackforge/murano: Fixed issues with port checks timeout  https://review.openstack.org/10572914:01
*** IgorYozhikov has joined #murano14:05
openstackgerritRuslan Kamaldinov proposed a change to stackforge/murano: Fix DB migration scripts  https://review.openstack.org/10420514:05
ruhekatyafervent: if it doesn't take too much time to get rid of unittest2 and use only testtols, then i support this14:07
ruheon the other hand we DON'T HAVE TO migrate all the tests to testtools right now14:08
ruheagain, i'm ok with it if it's a relatively a small change14:08
*** sergmelikyan has joined #murano14:23
tnurlygayanovlooks like I found the root of the problems with murano-ci https://murano-ci.mirantis.com/jenkins/job/murano-engine-app-deployment-tests-ubuntu/lastSuccessfulBuild/artifact/artifacts/murano.log14:25
tnurlygayanov No more IP addresses available on network 70af6a2f-2f7f-4096-8f87-c35f31bdc4ec.\n"14:25
sergmelikyantnurlygayanov, not root of the last failure :)14:26
sergmelikyanI mean only root of the last problem :(14:26
*** lazy_prince is now known as killer_prince14:33
tnurlygayanovI suggest to write bp about reuse of floating IPs and ability to select already prepared FloatingIPs14:45
tnurlygayanovbecause now we have only checkbox 'assign floating IP'14:46
openstackgerritGeorgy Okrokvertskhov proposed a change to stackforge/murano-dashboard: Add app images to topology page  https://review.openstack.org/10406414:57
openstackgerritGeorgy Okrokvertskhov proposed a change to stackforge/murano-dashboard: Fix topology page issue with dependencies  https://review.openstack.org/10403014:57
*** IlyaE has joined #murano15:02
*** sjmc7 has joined #murano15:10
openstackgerritTimur Nurlygayanov proposed a change to stackforge/murano: Fixed issues with port checks timeout  https://review.openstack.org/10572915:11
ruhetnurlygayanov: sergmelikyan: what's the current status of murano-ci. can you share what you have found?15:25
sergmelikyanruhe, waiting for https://review.openstack.org/10572915:26
sergmelikyanruhe, I am working on tests for https://review.openstack.org/10568615:26
*** killer_prince is now known as lazy_prince15:27
ruhesergmelikyan: do you expect this patch to pass murano-ci? it seems like we had other issues related to floating addresses15:28
sergmelikyanI expect to this patch pass murano-ci, we have cleaned-up our ci lab from excessive floating ips that were allocated but were not associated15:30
ruhesergmelikyan: ok. thank you (and tnurlygayanov) for working on this!15:32
tnurlygayanovlooks like now tests are passed for my commit! cool! :)15:34
tnurlygayanovall 'deployment' tests are passed on commit https://review.openstack.org/#/c/105729/ , need review15:37
sergmelikyanruhe, take a look on https://review.openstack.org/105729 I think we can merge this patch15:38
ruhesergmelikyan: already set +215:38
ruhedo you want me to merge it? maybe ativelkov, sjmc7, slagun, tsufiev would like to comment on it?15:39
sergmelikyandiscovered new critical issue :(15:39
sergmelikyanhttps://bugs.launchpad.net/murano/+bug/133976215:39
ruhedamn15:40
ruhesergmelikyan: are there any other critical bug fixes in pipeline?15:42
sjmc7reviewed15:42
sjmc7sergmelikyan - this happens e.g. with two instances of the same class?15:43
sergmelikyantwo instances of Instance class declared in Env for any App15:44
sergmelikyanI think this is the reason: https://github.com/stackforge/murano/blob/master/meta/io.murano/Classes/resources/Instance.yaml#L8915:44
sjmc7yep15:44
sergmelikyanI think, we can fix this by adding Instance id to the resource name15:45
sjmc7probably not even the whole id, just a few characters would be enough. or generate a couple of random characters like heat does15:46
ruhesergmelikyan: are there any other critical bug fixes in pipeline? or can we get back to reducing number of patches wating for review?15:46
sergmelikyanruhe, I think this one https://review.openstack.org/105686 is also important from gate point of view15:46
sergmelikyanbut after that no bugs should block our gate. At least there is no other identified bugs that was caused gate tests to fail15:47
sergmelikyanI was working on tests for the change above, when discovered that critical issue :(15:48
sergmelikyansjmc7, https://review.openstack.org/105686 - I had extracted this part from patch with Env/Stack deletion15:48
sergmelikyan*have15:48
sergmelikyanruhe, btw, I think we can retrigger murano-ci jobs15:49
ruhesergmelikyan: i suggest as a first step we help Ankur to finally drive his patch to be merged15:50
sjmc7yeah, sergmelikyan - i saw this last night. i'm a bit worried that it's getting a bit messy to be able to unroll things on deletion, but for now it'd be good enough to make sure that environment deletion gets rid of everything15:51
sjmc7i think i've hit the floating IP problem before15:51
sjmc7where it stops heat from removing a network15:51
sjmc7i think this patch 105686 will address that15:51
sergmelikyansjmc7, yeah, this change does not cover all pitfalls of deletion resource that may be referenced15:51
openstackgerritA change was merged to stackforge/murano: Fixed issues with port checks timeout  https://review.openstack.org/10572915:52
sjmc7sergmelikyan - is it difficult to write tests for this behavior?15:52
sjmc7i'd like to get these deletion fixes merged ASAP but i also like having tests15:53
sergmelikyansjmc7, I am debugging test that creates env with two apps, remove one of them, and than redeploy. Stack should stay consisted15:53
sjmc7i meant specifically unit tests for 105686; make sure that the heat template changes are as we expect15:54
sergmelikyanI don't know how to cover this change with unit-tests, but I think scenario above can cover from integration POV15:54
sjmc7ok. let me see if i can figure out a way to unit test it in a reasonable time; stan's test stuff may make it a bit easier15:55
sergmelikyanIt's hard to cover by unit-test existing class from existing package - we need to load actual packages and so on.15:55
sergmelikyansjmc7, ok, I will continue to work on integration tests for now15:56
sjmc7yeah. i'd like to be able to easily test changes to the base objects though; breaking them breaks everything15:56
ruhesjmc7: btw, it turned out that my patch https://review.openstack.org/#/c/104205/ fixes https://bugs.launchpad.net/murano/+bug/1339201 "package fqns are no longer unique". i decided to move all the db tests to this patch16:03
sjmc7ah, ok16:07
sjmc7looks like the gate test for 104205 failed from a pip timeout, ruhe16:09
ruheyes, i'll re-trigger it16:14
*** chandankumar has quit IRC16:18
ruhesergmelikyan: i guess we need to rebase https://review.openstack.org/#/c/99465/ on master16:21
*** sjmc7 has quit IRC16:44
*** sjmc7 has joined #murano16:44
openstackgerritIgor Yozhikov proposed a change to stackforge/murano: Add --log-file to each daemon init script  https://review.openstack.org/10579717:10
*** stan_lagun has joined #murano17:16
sergmelikyanAnother critical bug :(17:18
sergmelikyanFruitful day...17:18
sergmelikyanhttps://bugs.launchpad.net/murano/+bug/133981517:18
*** slagun has quit IRC17:19
sjmc7do you have an example for that one, serg?17:20
sjmc7i've not come across it17:20
sergmelikyanYep, hit this bug right now, during writing tests for 10568617:22
sergmelikyansjmc7, do you know some service where some files may be pasted for side by side diff?17:23
* sergmelikyan would like to show issue17:23
sjmc7http://www.diffchecker.com/17:24
sjmc7let me google that for you :)17:24
sergmelikyanthx :) My question to google was wrong :)17:25
* sergmelikyan googled for paste comparison17:25
sergmelikyanSo, scenario:17:25
sergmelikyan1)Deploy env with two instance of Telnet App17:25
sergmelikyan2)Remove 1 app17:26
sergmelikyan3)Redeploy17:26
sergmelikyanhttp://www.diffchecker.com/2rxim66x17:26
sergmelikyanOn the left you see first template send to Heat on deploy of the environment17:26
sergmelikyanOn the right template that was sent to Heat on "clean-up" action... This action takes place before deployment.17:27
sjmc7ok17:27
sergmelikyanAfter clean-up goes deployment stage, and this is diff of template after clean-up and template that was sent to deploy:17:28
sergmelikyanhttp://www.diffchecker.com/z6rvw93117:28
sergmelikyanIt is cleanly wrong17:28
sergmelikyan8 line17:28
sergmelikyanThis thing was causing so many troubles on CI %)17:29
openstackgerritIgor Yozhikov proposed a change to stackforge/murano: Add --log-file to each daemon init script  https://review.openstack.org/10579717:30
sjmc7hmmmmm17:30
sjmc7where'd that comma come from?17:30
sergmelikyanThis how our merge between templates worked... it is treated "addresses" that was already present in template and addresses in input as different ones... because first one is taken (toked) from Heat - unicode one, and second one is base string from YAML processing17:32
sjmc7i'm surprised string comparisons are behaving wrong17:33
sjmc7i wouldn't have thought a unicode/str difference would make that much of a difference17:33
sergmelikyansjmc7, that is why I hate unicode in Python :)17:34
openstackgerritSerg Melikyan proposed a change to stackforge/murano: Fix issues with Heat template updating  https://review.openstack.org/10580817:35
sergmelikyan^^ fix17:35
sjmc7that's why you should always use unicode everywhere :)17:38
sjmc7we should not be using types17:39
sergmelikyantypes?17:39
sjmc7isinstance(variable_name, basestring)17:39
*** IlyaE has quit IRC17:39
sergmelikyansjmc7, thx, updated17:39
sjmc7i think there's a BP or ticket about this somewhere already17:40
openstackgerritSerg Melikyan proposed a change to stackforge/murano: Fix issues with Heat template updating  https://review.openstack.org/10580817:40
sergmelikyansjmc7, we discussed this previously, since Python 2.x (x < 6) constructors like dict, basestring, int and so on are also types17:41
sjmc7yeah17:41
sjmc7ah, i see the problem in the utils code17:41
sergmelikyanWe can do a little refactor and replace all entrance of types usage to appropriate actual types, but this is really low priority thing I believe17:42
sjmc7yeah, agree17:42
sergmelikyanBut in the new code we definitely should use dict, basesting and so on. Thanks for reminding :)17:43
sergmelikyansjmc7, you mean other problems that are not fixed by patch above?17:43
sjmc7no, you fixed it. but i see how it happened, so i'm not surprised now :)17:44
sergmelikyan:)17:44
sergmelikyanWe had really neat external library that was handling difference thing :) But that library was not packaged and not present in global-requirement so was rewritten to home-grown thing :(17:44
openstackgerritSerg Melikyan proposed a change to stackforge/murano: Fix issues with Heat template updating  https://review.openstack.org/10580817:46
sjmc7this is why i try never to write code if someone else already did it :)17:47
*** asalkeld has joined #murano17:51
*** lazy_prince is now known as killer_prince17:55
*** IlyaE has joined #murano17:57
*** slagun has joined #murano17:59
*** stan_lagun has quit IRC18:03
openstackgerritIgor Yozhikov proposed a change to stackforge/murano: Add --log-file to each daemon init script  https://review.openstack.org/10579718:04
openstackgerritEkaterina Chernova proposed a change to stackforge/murano-dashboard: Fix statuses for environment state  https://review.openstack.org/10480118:12
openstackgerritEkaterina Chernova proposed a change to stackforge/murano-dashboard: Fix statuses for environment state  https://review.openstack.org/10480118:14
*** IlyaE has quit IRC18:30
*** IlyaE has joined #murano18:30
*** asalkeld has quit IRC18:53
openstackgerritEkaterina Chernova proposed a change to stackforge/murano-dashboard: Fix statuses for environment state  https://review.openstack.org/10480118:57
*** IlyaE has quit IRC19:12
*** asalkeld has joined #murano19:24
*** IlyaE has joined #murano19:34
*** IlyaE has quit IRC20:03
*** IlyaE has joined #murano20:06
slagunDoes Ankur present in this chat?20:16
*** IlyaE has quit IRC20:20
*** IlyaE has joined #murano20:30
*** IlyaE has quit IRC20:58
*** IlyaE has joined #murano21:02
*** IlyaE has quit IRC21:20
openstackgerritA change was merged to stackforge/murano: Fix issues with Heat template updating  https://review.openstack.org/10580821:25
*** drupalmonkey has quit IRC21:30
*** IlyaE has joined #murano21:52
*** IlyaE has quit IRC22:05
*** IlyaE has joined #murano22:12
*** IlyaE has quit IRC22:23
*** IlyaE has joined #murano22:37
*** sjmc7 has quit IRC22:54
*** asalkeld has quit IRC23:04
*** IlyaE has quit IRC23:53
*** slagun has quit IRC23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!