Thursday, 2015-07-23

openstackgerritAngus Salkeld proposed openstack/heat: Convergence: pass the input_data into Stack.load()  https://review.openstack.org/20479300:03
*** achanda has joined #heat00:05
*** sergmelikyan has quit IRC00:08
*** Raj3 has quit IRC00:08
*** pm90_ has quit IRC00:12
*** jdandrea has quit IRC00:18
*** shadower has quit IRC00:23
*** shadower has joined #heat00:23
*** ddaskal has joined #heat00:25
*** pm90_ has joined #heat00:28
asalkeldbrb00:31
*** cing has joined #heat00:35
*** jruano has quit IRC00:36
*** pm90_ has quit IRC00:50
*** pm90_ has joined #heat00:51
*** chlong has quit IRC00:52
openstackgerritRico Lin proposed openstack/python-heatclient: add with_detail parameter in heat resource-list request  https://review.openstack.org/20027700:56
*** pm90_ has quit IRC00:56
*** blomquisg has joined #heat01:07
*** erkules has joined #heat01:09
*** Qiming_ has joined #heat01:11
*** erkules_ has quit IRC01:12
*** ricolin has joined #heat01:25
*** jruano has joined #heat01:32
*** ddaskal has quit IRC01:34
*** Yanyanhu has joined #heat01:49
*** shangxdy has joined #heat01:51
*** huangtianhua has joined #heat01:52
*** EmilienM|off is now known as EmilienM01:52
openstackgerritSteve Baker proposed openstack/heat: Always commit after deployment db operations  https://review.openstack.org/20478001:55
*** kebray has joined #heat02:00
*** kebray has quit IRC02:02
*** chlong has joined #heat02:11
*** Qiming_ is now known as Qiming02:16
*** pal has joined #heat02:18
*** tspatzier__ has joined #heat02:29
*** jaime49 has quit IRC02:31
*** tspatzier has quit IRC02:33
ramishrastevebaker: hi02:46
stevebaker ramishra hi02:47
ramishrastevebaker: hope you had a good vacation.02:47
stevebakerit was great, got a bit of aussie winter sun02:47
ramishragreat.. just wanted to know your view on https://review.openstack.org/#/c/200366/,it seems you're not in favor of making server a mandatory property.02:49
asalkeldalmost the assie snow02:49
*** yuanying has joined #heat02:49
cmystermorning02:52
stevebakerramishra: yeah, this was my comment at the time, and I think I still agree "I'm thinking it is a useful convenience to make the server property optional for template development. If an author wants to temporarily not deploy something to a server they just need to comment out the server property rather than the whole resource."02:53
ramishrastevebaker: From the api standpoint, we don't have a way to associate a server to an existing deployment, right?02:54
stevebakerthe deployment is the association.02:55
stevebakerramishra: deployment-update should allow the server to be changed (including to/from None)02:56
ramishraso then you think we fix the db schema to fix the bug?02:59
*** kebray has joined #heat03:02
stevebakerramishra: how about server=''?03:05
*** pal has quit IRC03:06
*** htruta_ has quit IRC03:08
ramishramy understanding was deployment is a specific instance of a config for a specific server, hence server would be mandatory.03:08
ramishrastevebaker: yeah we can do that too03:08
*** Marga_ has quit IRC03:13
stevebakerramishra: as a matter of interest, what happens currently when server is not specified? because that property has nova.server validation on it.03:16
*** shangxdy has quit IRC03:16
ramishrastevebaker: it's in the bug description. It throws DB error. https://bugs.launchpad.net/heat/+bug/147306303:22
openstackLaunchpad bug 1473063 in heat "software deployment without server property specified fails with DB error" [Medium,In progress] - Assigned to Rabi Mishra (rabi)03:22
uvirtbotLaunchpad bug 1473063 in heat "software deployment without server property specified  fails with DB error" [Medium,In progress]03:22
*** FL1SK has quit IRC03:22
uvirtbotLaunchpad bug 1473063 in heat "software deployment without server property specified  fails with DB error" [Medium,In progress] https://launchpad.net/bugs/147306303:22
stevebakerramishra: ok, fine. make it mandatory :)03:24
ramishrastevebaker: :) . thanks03:25
stevebakernp03:25
*** yuanying has quit IRC03:26
*** Qiming is now known as Qiming_afk03:26
*** yuanying has joined #heat03:28
openstackgerritOpenStack Proposal Bot proposed openstack/heat: Updated from global requirements  https://review.openstack.org/20429703:29
*** liusheng has joined #heat03:30
*** pm90_ has joined #heat03:33
*** coolsvap|away is now known as coolsvap03:34
*** yuanying has quit IRC03:49
*** yuanying has joined #heat03:59
*** yuanying has quit IRC04:02
*** pal has joined #heat04:03
*** ananta_ has joined #heat04:11
openstackgerritRico Lin proposed openstack/heat: add new constraints to ceilometer  https://review.openstack.org/20417504:11
openstackgerritRico Lin proposed openstack/heat: add time_constraints property in OS::Ceilometer::Alarm  https://review.openstack.org/20149804:11
*** KanagarajM has joined #heat04:12
*** ananta_ has quit IRC04:12
*** ananta_ has joined #heat04:15
*** tspatzier__ has quit IRC04:16
*** tspatzier__ has joined #heat04:16
*** gberginc has joined #heat04:17
*** tspatzier__ has quit IRC04:17
*** ananta_ has quit IRC04:18
*** ananta_ has joined #heat04:18
*** ananta_ has quit IRC04:22
*** daneyon_ has joined #heat04:22
*** ananta_ has joined #heat04:23
*** daneyon has quit IRC04:24
*** vijayagurug has joined #heat04:37
openstackgerritOpenStack Proposal Bot proposed openstack/heat: Updated from global requirements  https://review.openstack.org/20429704:38
*** Kennan has quit IRC04:41
*** blomquisg has quit IRC04:42
*** Kennan has joined #heat04:42
*** FL1SK has joined #heat04:43
*** yuanying has joined #heat05:01
*** Qiming_afk is now known as Qiming05:09
openstackgerritAnant Patil proposed openstack/heat: Convergence: Refactor worker  https://review.openstack.org/20099505:10
*** rakesh_hs has joined #heat05:34
*** zeih has joined #heat05:53
*** inc0 has joined #heat05:53
*** zeih has quit IRC05:58
openstackgerritOpenStack Proposal Bot proposed openstack/heat: Imported Translations from Transifex  https://review.openstack.org/20489806:01
*** zeih has joined #heat06:06
*** jruano has quit IRC06:06
*** Murali has joined #heat06:07
*** vijayagurug has quit IRC06:09
*** tspatzier has joined #heat06:11
*** boris-42 has quit IRC06:12
*** zeih has quit IRC06:16
*** pm90_ has quit IRC06:18
*** ishant has joined #heat06:24
*** zeih has joined #heat06:26
openstackgerritRico Lin proposed openstack/heat: add new constraints to ceilometer  https://review.openstack.org/20417506:29
openstackgerritRico Lin proposed openstack/heat: add time_constraints property in OS::Ceilometer::Alarm  https://review.openstack.org/20149806:29
*** jprovazn has joined #heat06:31
*** ananta__ has joined #heat06:32
*** ananta_ has quit IRC06:34
*** zeih has quit IRC06:38
*** zeih has joined #heat06:42
*** guy_rodrigue has joined #heat06:42
*** chlong has quit IRC06:49
*** vijayagurug has joined #heat07:11
*** e0ne has joined #heat07:14
*** jcoufal has joined #heat07:18
*** daneyon_ has quit IRC07:20
*** daneyon has joined #heat07:21
*** skraynev_ is now known as skraynev07:24
*** Marga_ has joined #heat07:27
*** kairat_kushaev has left #heat07:28
*** pas-ha has joined #heat07:29
*** kairat has joined #heat07:30
*** dkusidlo has joined #heat07:42
*** zeih has quit IRC07:43
*** pal has quit IRC07:47
*** dkusidlo has quit IRC07:53
*** bdossant has joined #heat07:53
*** pal has joined #heat07:58
*** zeih has joined #heat07:59
*** jistr has joined #heat08:02
*** achanda has quit IRC08:13
pas-hamorning all08:14
pas-hawhat should I put in patch comment to run experimental gate jobs? simply "check experimental"?08:14
*** achanda has joined #heat08:16
*** jecarey has quit IRC08:16
pas-haalso, does anyone know if any of our jobs, including experimental, run actual server updates for any of flavor, image, networks?08:19
*** achanda has quit IRC08:21
*** rakesh_hs_ has joined #heat08:22
*** derekh has joined #heat08:25
*** Kennan has quit IRC08:26
*** rakesh_hs has quit IRC08:26
*** dkusidlo has joined #heat08:26
*** Kennan has joined #heat08:26
openstackgerritMartin Mágr proposed openstack/heat-templates: Improve handling of Puppet output  https://review.openstack.org/18873708:31
*** shardy_ has joined #heat08:31
*** shardy has quit IRC08:32
*** guy_rodrigue has quit IRC08:35
*** shardy_ has quit IRC08:36
*** dkusidlo has quit IRC08:36
*** shardy has joined #heat08:37
*** guy_rodrigue has joined #heat08:41
*** vijayagurug has quit IRC08:41
*** vijayagurug has joined #heat08:42
*** achanda has joined #heat08:44
openstackgerritMartin Mágr proposed openstack/heat-templates: Improve handling of Puppet output  https://review.openstack.org/18873708:45
KanagarajMpas-ha: good morning08:56
KanagarajMpas-ha: yes, 'check experimental' would trigger the job08:56
openstackgerritRabi Mishra proposed openstack/heat: Remove inheritance and refactor common functions to utility  https://review.openstack.org/19609108:59
openstackgerritRabi Mishra proposed openstack/heat: Add rolling_update to ResourceGroup  https://review.openstack.org/19405208:59
openstackgerritRabi Mishra proposed openstack/heat: Change native ASG to inherit from ResourceGroup  https://review.openstack.org/19405408:59
KanagarajMskraynev: hi, i may need your help on resolving this error http://logs.openstack.org/46/201046/5/check/gate-heat-python27/52a4f93/testr_results.html.gz . could you please help?09:00
skraynevramishra: why do we remove inheritance ASG from RG ? I though, that the idea was to leave it inherited09:00
*** jprovazn has quit IRC09:01
skraynevKanagarajM: :) sure, Honestly I already start fixing it.09:01
ramishraskraynev: these resources can evolve separately in the future without the dependancy. Also the major opinion was to remove it and move all the common functions to utility. we discussed this during the summit too.09:02
KanagarajMskraynev: :) ok. once you fix it, let me know, if i need to make any change to my patch https://review.openstack.org/#/c/201046/09:04
skraynevKanagarajM: sure. I will add you to review ;)09:04
KanagarajMskraynev: sure. thanks09:05
skraynevramishra - about moving functions to utility: I agree and know it. But the first item is confusing for me: 1. it does not match spec, which was introduced. 2. IMO, ASG it's specific case of RG (with scale additional logic)09:07
*** tochi has quit IRC09:13
*** gberginc has quit IRC09:16
ramishrano it does not follow the spec. therve and shardy can add more on the decision to remove the inheritance.09:17
therveWe can amend the spec09:18
KanagarajMkairat: ping09:20
* kairat interesting in OOP explanation of this choice09:21
kairatKanagarajM, pong09:21
thervekairat, Other than inheritance is terrible and we shouldn't use it?09:21
kairattherve, lol09:22
ramishratherve: :)09:22
kairattherve, so you are not a big fan of OOP?09:23
openstackgerritMartin Mágr proposed openstack/heat-templates: Improve handling of Puppet output  https://review.openstack.org/18873709:24
KanagarajMkairat: I tried to give my inputs for your comments in https://review.openstack.org/#/c/195697/09:24
openstackgerritPavlo Shchelokovskyy proposed openstack/heat: Do not use rich server objects in servers' create  https://review.openstack.org/18876609:24
openstackgerritPavlo Shchelokovskyy proposed openstack/heat: Do not use VolumeTasks in AWS Instance create  https://review.openstack.org/20132109:24
openstackgerritPavlo Shchelokovskyy proposed openstack/heat: WIP Don't use rich objects is servers update  https://review.openstack.org/20424809:24
kairatKanagarajM, you need to look at the Magnum client plugin09:25
kairatKanagarajM, it also not in global-requirements but we have some unit-tests for it09:25
kairatand it is in the main tree09:25
kairatI've heard there was thread somewhere about Magnum in heat09:26
KanagarajMkairat: i refered the mistral, some of the test cases are skiped, i believe.09:26
KanagarajMkairat: let me look at magnum as well09:27
openstackgerritAnant Patil proposed openstack/heat: Convergence: fix current traversal  https://review.openstack.org/20195809:27
thervekairat, in python, no. There is no interface separation, you just stuff things in your namespace, and everything is implicit and opaque.09:27
therveComposition is a much better way to share functionality09:28
KanagarajMkairat: I refered the https://github.com/openstack/heat/blob/master/heat/tests/clients/test_magnum_client.py#L2509:28
*** vijayagurug has left #heat09:28
KanagarajMkairat: but i beleive that by mocking the client library, we could unit-test the client plugin code as i have done the monasca patch09:30
kairattherve, IMO, incapsulation is also very important but it looks like python does not support it well. I need to know a lot of things when doing some patches in heat)09:30
therveYou'd better off consider that there is no incapsulation at all09:31
KanagarajMkairat: it helps to iterate the client-plugin code as per the expectation of its functionality :)09:31
kairatKanagarajM, agreed. There is the main question. Should we be responsible for this resource? Is it stable enough or we need to mark it UNSUPPORTED?09:32
KanagarajMkairat: we have already have the approved spec for monasca plugin09:33
KanagarajMkairat: and thanks for agreeing on the first part :)09:34
KanagarajMkairat: so, i believe, we could provide the support for monasca.09:36
kairatKanagarajM, so it something will be changed in monasca, how can we detect the error?09:36
kairatKanagarajM, although09:37
kairatwe have the same approach for the other clients09:37
KanagarajMkairat: i assume that you are asking to make it unsupported, because monasca in stackforge project?09:37
kairatyep09:38
kairatdoes it mean that it is not stable enough&09:38
kairatIMO, yes then out resource can potentially be broken09:39
kairat*our09:39
kairatKanagarajM, I think it is common question for the next meeting. Should we mark resources as unsupported it they are not presented in global-requirements09:41
KanagarajMkairat: sure. shall we get opinion from core09:41
KanagarajMkairat: sure09:42
kairat+109:42
openstackgerritAnant Patil proposed openstack/heat: Convergence: Re-trigger stack operation  https://review.openstack.org/20294409:44
*** dkusidlo has joined #heat09:46
kairatKanagarajM, or you can write a message to openstack-dev09:48
kairatKanagarajM, it saves a week for you+)09:48
KanagarajMkairat: yes, will do. about to tell you on it :-)09:49
openstackgerritTetiana Lashchova proposed openstack/python-heatclient: Add missing docstring for deployment-create  https://review.openstack.org/20497409:51
*** erkules has quit IRC09:53
*** erkules has joined #heat09:53
*** blinky_ghost has joined #heat10:04
*** dkusidlo has quit IRC10:04
blinky_ghostshardy: good morning :) can you give a hand with my OS::Heat::SoftwareDeployments stack? I'm having an error that I don't understand, "ERROR: Failed to validate: Failed to validate: The specified reference "mgm_cluster" (in CommonHostDeployment.Properties.servers) is incorrect." thanks10:06
*** zeih has quit IRC10:07
openstackgerritMerged openstack/heat: Add translate_properties for Resource  https://review.openstack.org/19183910:08
shardyblinky_ghost: the error seems pretty clear - you're referencing mgm_cluster somewhere it doesn't exist10:08
shardyhard to say more without seeing all the templates tbh10:08
*** Yanyanhu has quit IRC10:08
blinky_ghostshardy: I'll paste it10:09
openstackgerritMerged openstack/heat: Add documentation page for Support Status  https://review.openstack.org/16881610:10
openstackgerritMerged openstack/heat: Add HIDDEN status to RandomString sequence  https://review.openstack.org/19184110:10
blinky_ghostshardy: this is a nested stack, this is the main stack:  http://paste.openstack.org/show/403567/10:10
*** jprovazn has joined #heat10:11
openstackgerritRabi Mishra proposed openstack/python-heatclient: Add missing `deployment-list` to cli  https://review.openstack.org/19900810:11
blinky_ghostshardy: this is example-script-template.yaml that is called from the main stack: http://paste.openstack.org/show/403567/10:12
*** cing has quit IRC10:12
*** guy_rodrigue has quit IRC10:12
shardyblinky_ghost: those two pastes are the same..10:13
blinky_ghostshardy: sorry :P http://paste.openstack.org/show/403568/10:13
shardyblinky_ghost: there are a few problems10:15
shardy1. All templates should use heat_template_version: 2014-10-16 or newer10:15
shardy2. The get_attr: [mgm_cluster, name] should then be get_attr: [mgm_cluster, attributes, name]10:15
shardyhowever 3. The nested stack doesn't expose any output "name" (or "ip")10:16
shardyThe attributes referenced must match outputs in the nested stack template10:16
shardyhttp://docs.openstack.org/developer/heat/template_guide/openstack.html#OS::Heat::ResourceGroup-attrs10:16
shardyAlso, CommonHostDeployment needs to be in the parent template, like in the tripleo examples I shared yesterday10:17
shardythe nested stack defines the unit to be scaled (e.g each node in the cluster), then OS::Heat::SoftwareDeployments is used to configure the entire cluster (after each individual node is built)10:18
shardyI'll try to find time to post a more basic example to heat-templates later but I'm pretty busy today10:18
blinky_ghostshardy: ok thank you for your patience :) I'll test it with your advice.10:19
*** ricolin has quit IRC10:22
*** coolsvap is now known as coolsvap|away10:27
*** che-arne has joined #heat10:27
*** zeih has joined #heat10:30
*** dkusidlo has joined #heat10:31
*** gberginc has joined #heat10:31
openstackgerritAnant Patil proposed openstack/heat: Convergence: Fix for resource needed_by  https://review.openstack.org/20111010:36
openstackgerritIshant Tyagi proposed openstack/heat: DNM : convergence scenario tests  https://review.openstack.org/20366110:36
*** dims_ has joined #heat10:52
*** Qiming has quit IRC10:55
openstackgerritKanagaraj Manickam proposed openstack/heat: Adds python-mistralclient>=1.0.0 in requirements.txt  https://review.openstack.org/20500511:05
openstackgerritKanagaraj Manickam proposed openstack/heat: Import mistral python client directly  https://review.openstack.org/20500611:05
*** ochuprykov has joined #heat11:07
*** chlong has joined #heat11:08
*** dkusidlo has quit IRC11:11
*** prazumovsky has joined #heat11:11
openstackgerritTetiana Lashchova proposed openstack/heat: Add show_resource function to Sahara resources (3)  https://review.openstack.org/20109411:15
*** guy_rodrigue has joined #heat11:22
*** guy_rodrigue has quit IRC11:28
*** guy_rodrigue has joined #heat11:32
openstackgerritOleksii Chuprykov proposed openstack/heat: Add LbImageId magic param to aws loadbalancer nested template  https://review.openstack.org/20451411:33
*** zeih has quit IRC11:37
*** pal has quit IRC11:42
*** inc0_ has joined #heat11:44
*** inc0 has quit IRC11:44
*** Qiming has joined #heat11:44
openstackgerritSergey Kraynev proposed openstack/heat: Use base attributes with attribute_schema of class  https://review.openstack.org/20501811:45
openstackgerritOleksii Chuprykov proposed openstack/heat: Use default_client_name in aws s3 resource  https://review.openstack.org/20501911:47
*** pal has joined #heat11:50
*** pal has quit IRC11:54
*** KanagarajM has quit IRC12:01
*** dims_ has quit IRC12:02
openstackgerritOleksii Chuprykov proposed openstack/heat: Add LbImageId magic param to aws loadbalancer nested template  https://review.openstack.org/20451412:13
*** ananta__ has quit IRC12:13
*** andersonvom has joined #heat12:14
openstackgerritTetiana Lashchova proposed openstack/python-heatclient: Fix docstrings and add missing  https://review.openstack.org/20497412:14
*** bdossant has quit IRC12:15
*** Qiming has quit IRC12:16
*** Qiming has joined #heat12:20
*** kitch_ has joined #heat12:22
*** Raj3 has joined #heat12:26
openstackgerritTetiana Lashchova proposed openstack/heat: Use default_client_name for mistral  https://review.openstack.org/20503512:29
openstackgerritAnant Patil proposed openstack/heat: Convergence: Refactor convergence dependency  https://review.openstack.org/20348412:30
*** che-arne has quit IRC12:30
*** jaime49 has joined #heat12:32
*** jaime49 has quit IRC12:33
*** jaime49 has joined #heat12:33
*** zeih has joined #heat12:34
openstackgerritSergey Kraynev proposed openstack/heat: Use base attributes with attribute_schema of class  https://review.openstack.org/20501812:43
*** ishant has quit IRC12:44
openstackgerritMerged openstack/heat: Updated from global requirements  https://review.openstack.org/20429712:46
openstackgerritMerged openstack/heat: Enable caching for property constraints  https://review.openstack.org/18599912:50
openstackgerritMerged openstack/heat: Imported Translations from Transifex  https://review.openstack.org/20489812:50
*** vijayagurug has joined #heat12:50
*** vijayagurug has left #heat12:51
*** htruta has quit IRC12:51
*** htruta has joined #heat12:54
*** jcoufal has quit IRC12:54
*** cmyster has quit IRC12:58
*** cmyster has joined #heat12:58
*** pal has joined #heat13:03
*** jonesbr has joined #heat13:06
*** lkarm has joined #heat13:09
*** jruano has joined #heat13:11
*** tspatzier has quit IRC13:12
*** Raj3 has quit IRC13:12
*** Raj3 has joined #heat13:12
*** Raj3 has quit IRC13:15
*** Raj3 has joined #heat13:15
*** gberginc has quit IRC13:21
openstackgerritPeter Razumovsky proposed openstack/heat: Add show_resource function to Manila resources (5)  https://review.openstack.org/20123013:22
*** liusheng has quit IRC13:23
*** jcoufal has joined #heat13:29
*** yassine__ has joined #heat13:29
*** sergmelikyan has joined #heat13:30
*** dkusidlo has joined #heat13:30
*** inc0_ has quit IRC13:33
*** zeih has quit IRC13:33
openstackgerritTetiana Lashchova proposed openstack/heat: Add show_resource function to Sahara resources (3)  https://review.openstack.org/20109413:34
*** jdandrea has joined #heat13:34
*** zeih has joined #heat13:36
*** jasond has joined #heat13:36
*** pal has quit IRC13:39
*** jecarey has joined #heat13:40
*** pal has joined #heat13:40
*** shardy_ has joined #heat13:42
*** dims_ has joined #heat13:44
*** shardy has quit IRC13:44
*** dims_ has quit IRC13:45
*** dims_ has joined #heat13:45
*** blomquisg has joined #heat13:48
*** shardy_ has quit IRC13:48
*** shardy has joined #heat13:48
*** dkusidlo has quit IRC13:50
*** htruta has quit IRC13:51
*** EricGonczer_ has joined #heat13:57
*** dgrauet has joined #heat13:59
*** bnemec has joined #heat13:59
*** inc0 has joined #heat14:04
openstackgerritMerged openstack/heat: Support snapshot deletion policy in Server  https://review.openstack.org/18558214:04
openstackgerritMerged openstack/heat: Convergence: Refactor worker  https://review.openstack.org/20099514:04
openstackgerritMerged openstack/heat: Convergence: Fix concurrent update  https://review.openstack.org/20460114:05
*** Raj3 has quit IRC14:13
*** cchang has joined #heat14:13
*** thedodd has joined #heat14:18
shardyAny mock experts know how I'd mock a class (stack.Stack) then inspect the kwargs to assert the Template class passed to it contained a specific environment?14:18
shardySo far it seems like call_args_list gives me a mock call object, which doesn't appear to expose the kwargs in a form they can be used for assertions (other than comparison with other calls)14:19
shardybut I can't create an exact match call for comparison, because I don't have the template.HOTemplate object passed to the stack.Stack constructor14:20
*** htruta has joined #heat14:21
*** randallburt has joined #heat14:21
ryansbYou ought to be able to assert_called_with(...)14:22
ryansbwhere, for args you can't create exactly, you insert mock.ANY14:22
ryansbwhich is exactly what it says on the tin14:22
therveshardy, you mean call_args ?14:22
* ryansb isn't what you might call a mock expert14:23
therveI think between call_args and mock_calls you should find what you need14:24
*** randallburt has quit IRC14:25
*** jecarey has quit IRC14:28
shardytherve: thanks, yeah I'm using mock call_args_list, where I can see the object, but I can't figure out how to get a handle on it14:28
*** randallburt has joined #heat14:28
shardy(<heat.common.context.RequestContext object at 0x7fa7b4ccb810>, <MagicMock name='Stack.load().name' id='140358265756112'>, <heat.engine.hot.template.HOTemplate20141016 object at 0x7fa7b4925990>)14:28
shardyI want the heat.engine.hot.template.HOTemplate object, but I can't access it via the mock.call object contained in the call_args_list14:29
shardyI'm probably missing something obvious14:29
* shardy is easily confused by mock14:29
*** rakesh_hs_ has quit IRC14:29
therveshardy, Isn't that just [2]?14:30
shardyI expected to be able to do call_args_list[0][2] (to get the third tuple item) but it says tuple index out of range14:30
therveshardy, What if you do call_args?14:30
shardyYeah, I thought so, but not working atm14:30
ryansbuh, wouldn't it just be call_args_list[2] ? It doesn't look to be nested14:30
shardyryansb: what I pasted was call_args_list[0] - sorry should've clarified14:31
openstackgerritRico Lin proposed openstack/heat: add new constraints to ceilometer  https://review.openstack.org/20417514:32
openstackgerritRico Lin proposed openstack/heat: add time_constraints property in OS::Ceilometer::Alarm  https://review.openstack.org/20149814:32
ryansboh, well that's quite odd14:32
ryansbcan you [-1] it, or check len()14:33
shardytherve: call_args worked! Thanks! :)14:33
therve\o/14:33
jdandrea:)14:34
* shardy doesn't know why call_args_list didn't14:34
ryansb\o/ black mock magic survives another day14:34
therveshardy, *maybe* call_args_list[0][0][2]14:34
jdandrealol14:34
therveBut that's just a wild guess14:34
* jdandrea is in mock land right now ... whee ..14:34
shardytherve: you're on a roll, right again! :)14:35
*** pal has quit IRC14:35
shardyThanks for the help! :)14:35
ryansbmaybe []][[[[]]][][][][]][-1] ;)14:35
* therve doesn't want the mock expert label :/14:35
ryansblol14:36
jdandreaMock clues are good too though. :)14:36
jdandreaThe more I read tutorials the more it sinks in. Maybe. :-p14:37
*** kebray has quit IRC14:37
shardyI think the problem is my str() in my debug output, looks like the call_args_list __repr__ somehow loses the outer list, so it looks like a list containing one (tuple) call14:37
jdandreaHas anyone run into issues where a create call (in the tests) is missing a parameter but you aren't sure where to *add* that parameter in the test?14:37
*** pal has joined #heat14:37
*** jaime49 has quit IRC14:37
jdandrea(one of those "expected + but got -" things)14:37
shardyjdandrea: all the time, figuring it out gets gradually easier14:38
jdandreashardy: Good to know. I'm tracing up a storm and hunting it down14:38
shardyjdandrea: fwiw I still burn an embarrasing amount of time figuring out/fixing tests so you're not alone :)14:39
shardythe state of many of our tests doesn't really help :(14:39
*** sabeen1 has joined #heat14:39
jdandreashardy: *nods in appreciation* I hear you, and I hope that someday I have enough of a clue to help improve that situation!14:40
jdandreaThere's no lack of things to do, that's for sure! Anyone who thinks we must be bored is missing out. :)14:40
*** pm90_ has joined #heat14:49
*** jecarey has joined #heat14:50
*** Raj3 has joined #heat14:50
*** zeih has quit IRC14:53
openstackgerritRandall Burt proposed openstack/heat: Refactor and correct purge_deleted  https://review.openstack.org/20138414:54
*** Murali has quit IRC14:56
*** sjmc7_ has joined #heat15:01
*** sabeen3 has joined #heat15:01
*** kebray has joined #heat15:02
*** sabeen1 has quit IRC15:02
*** Raj3 has quit IRC15:03
*** kebray has quit IRC15:03
*** Raj3 has joined #heat15:03
*** jaime49 has joined #heat15:03
*** kebray has joined #heat15:03
*** jprovazn has quit IRC15:04
*** jaime49 has quit IRC15:04
*** jaime49 has joined #heat15:04
*** pm90_ has quit IRC15:05
*** cchang has quit IRC15:08
*** alex_xu has quit IRC15:10
*** alex_xu has joined #heat15:11
*** david-lyle has joined #heat15:17
*** dgrauet has quit IRC15:17
*** prazumovsky has quit IRC15:17
*** Drago has joined #heat15:18
*** zeih has joined #heat15:18
*** Drago has quit IRC15:18
*** Drago has joined #heat15:18
*** zeih has quit IRC15:23
*** cchang has joined #heat15:24
jdandreaTest weirdness conquered! \o/15:25
*** gberginc has joined #heat15:31
*** Raj3 has quit IRC15:38
*** Raj2 has joined #heat15:39
*** pal has quit IRC15:42
*** Qiming has quit IRC15:42
*** Raj2 has quit IRC15:43
*** pal has joined #heat15:43
*** pm90_ has joined #heat15:45
*** pm90__ has joined #heat15:47
*** zeih has joined #heat15:48
*** cing has joined #heat15:48
*** pm90_ has quit IRC15:50
*** cing has quit IRC15:52
*** cing has joined #heat15:53
*** ddaskal has joined #heat15:57
*** Michalik has quit IRC15:58
*** Michalik has joined #heat15:58
*** zhiyan has quit IRC15:58
*** zhiyan has joined #heat15:58
*** zeih has quit IRC16:00
*** jistr has quit IRC16:01
*** jcoufal has quit IRC16:01
openstackgerritKairat Kushaev proposed openstack/heat: [WIP] Allow output dynamic attributes  https://review.openstack.org/20512816:02
*** Raj2 has joined #heat16:03
*** inc0 has quit IRC16:04
*** Raj2 has quit IRC16:06
*** Raj2 has joined #heat16:06
*** zeih has joined #heat16:06
*** ameade has quit IRC16:08
*** ameade has joined #heat16:08
*** htruta has quit IRC16:09
*** signed8bit has joined #heat16:09
*** htruta has joined #heat16:10
*** serverascode has quit IRC16:14
*** serverascode has joined #heat16:15
*** zeih has quit IRC16:16
openstackgerritTetiana Lashchova proposed openstack/heat: Use default_client_name for mistral  https://review.openstack.org/20503516:17
*** Drago has quit IRC16:17
*** Slower has quit IRC16:18
*** Drago has joined #heat16:19
*** Drago has quit IRC16:20
*** Drago has joined #heat16:20
*** pas-ha has quit IRC16:22
openstackgerritJoe D'Andrea proposed openstack/heat: Adds resource uuid, volume support to lifecycle scheduler hints  https://review.openstack.org/20382316:23
*** achanda_ has joined #heat16:26
*** achanda has quit IRC16:26
*** tsandall_ has quit IRC16:27
*** jprovazn has joined #heat16:28
*** guy_rodrigue has quit IRC16:31
*** aweiteka has joined #heat16:31
*** signed8bit has quit IRC16:31
*** jprovazn has quit IRC16:31
*** jprovazn has joined #heat16:32
*** Slower has joined #heat16:36
*** cchang has quit IRC16:38
jdandreaIs there a queue that shows when Jenkins will run its tests on a change that is merely under review and not approved for merge?16:42
*** tsandall has joined #heat16:45
*** derekh has quit IRC16:46
ryansbThat should be the "check" column of http://zuul.openstack.org/16:49
ryansbjdandrea: ^16:49
*** sergmelikyan has quit IRC16:50
*** vijayagurug has joined #heat16:52
*** vijayagurug has quit IRC16:53
*** e0ne has quit IRC16:53
*** dsneddon_biab is now known as dsneddon16:53
jdandrearyansb: Ahh, thanks. I was looking here and not finding it: http://status.openstack.org/zuul/16:54
*** thedodd has quit IRC16:54
jdandrea... aaaand that would be because I was filtering on devstack. *grin*16:56
* jdandrea wanders back to his corner.16:56
ryansblol, there's a problem.17:00
shardyyes17:03
openstackgerritSteven Hardy proposed openstack/heat: Fix test_signal_returns_metadata wrong assertions  https://review.openstack.org/20516217:03
openstackgerritSteven Hardy proposed openstack/heat: Stop using eventlet threads in test_engine_service  https://review.openstack.org/20516317:03
openstackgerritSteven Hardy proposed openstack/heat: test_engine_service remove spurious deletes  https://review.openstack.org/20516417:03
openstackgerritSteven Hardy proposed openstack/heat: Fix/refactor test_stack_update_existing_parameters  https://review.openstack.org/20516517:03
openstackgerritSteven Hardy proposed openstack/heat: Add test covering PARAM_CLEAR_PARAMETERS for patch update  https://review.openstack.org/20516617:03
*** tsandall has quit IRC17:05
*** sergmelikyan has joined #heat17:08
*** cing has quit IRC17:08
*** rwsu has quit IRC17:11
*** dims_ has quit IRC17:12
*** rwsu has joined #heat17:12
*** Raj2 has quit IRC17:15
*** tsandall has joined #heat17:17
*** coolsvap|away is now known as coolsvap17:22
*** sergmelikyan has quit IRC17:30
*** sergmelikyan has joined #heat17:31
*** tsandall has quit IRC17:33
*** tsandall has joined #heat17:33
*** tsandall has quit IRC17:33
*** signed8bit has joined #heat17:33
*** Slower has quit IRC17:34
*** tsandall has joined #heat17:35
*** e0ne has joined #heat17:35
*** pal has quit IRC17:43
*** tspatzier has joined #heat17:44
*** dims has joined #heat17:45
*** signed8bit is now known as signed8bit_ZZZzz17:46
*** sergmelikyan has quit IRC17:46
*** signed8bit_ZZZzz is now known as signed8bit17:48
*** ochuprykov has quit IRC17:49
*** e0ne has quit IRC17:51
*** steveg_afk has quit IRC17:51
*** vasanth has joined #heat17:52
*** blinky_ghost has quit IRC17:54
*** sergmelikyan has joined #heat17:55
*** spzala has joined #heat17:56
*** sergmelikyan has quit IRC18:02
*** Raj2 has joined #heat18:02
*** tspatzier has quit IRC18:21
*** Slower has joined #heat18:22
*** Slower has quit IRC18:22
*** Slower has joined #heat18:22
*** kebray has quit IRC18:28
*** sergmelikyan has joined #heat18:28
*** kebray has joined #heat18:29
openstackgerritRico Lin proposed openstack/heat: add new constraints to ceilometer  https://review.openstack.org/20417518:32
openstackgerritRico Lin proposed openstack/heat: add time_constraints property in OS::Ceilometer::Alarm  https://review.openstack.org/20149818:32
*** signed8bit is now known as signed8bit_ZZZzz18:33
*** signed8bit_ZZZzz is now known as signed8bit18:35
*** jprovazn has quit IRC18:38
*** cmyster has quit IRC18:39
*** e0ne has joined #heat18:42
*** sergmelikyan has quit IRC18:54
*** Raj2 has quit IRC18:55
*** bitblt has joined #heat18:55
*** Raj2 has joined #heat18:55
*** bitblt has quit IRC18:58
*** cchang has joined #heat18:59
*** EricGonczer_ has quit IRC19:03
*** EricGonczer_ has joined #heat19:03
*** Raj2 has quit IRC19:07
*** Raj2 has joined #heat19:14
*** achanda_ has quit IRC19:14
openstackgerritPratik Mallya proposed openstack/heat: Fix RS CLB resource to handle HTTPS_REDIRECT correctly  https://review.openstack.org/20415119:21
*** sergmelikyan has joined #heat19:21
*** kebray has quit IRC19:24
*** gberginc has quit IRC19:26
*** kebray has joined #heat19:26
*** kebray has quit IRC19:28
*** gberginc has joined #heat19:30
*** sergmelikyan has quit IRC19:31
*** kebray has joined #heat19:33
*** sergmelikyan has joined #heat19:34
*** kebray has quit IRC19:34
*** lkarm has left #heat19:35
*** tspatzier has joined #heat19:36
*** sergmelikyan has quit IRC19:38
jdandreaWith regard to line 712: https://review.openstack.org/#/c/203823/4/heat/engine/resources/openstack/nova/server.py ... I'm starting to wonder if the key should be "heat_resource_uuid" or "heat_orchestration_id" instead.19:41
jdandrea(but _orchestration_ doesn't mention resource, and _resource_uuid looks too much like _resource_id)19:41
*** kebray has joined #heat19:41
*** sergmelikyan has joined #heat19:47
*** tspatzier has quit IRC19:50
*** sergmelikyan has quit IRC19:50
pm90__zaneb: could you please review https://review.openstack.org/#/c/195325/?19:50
zanebpm90__: I'll try to get to it but no guarantees19:53
*** kebray has quit IRC19:57
*** aweiteka has quit IRC19:58
*** Raj2 has quit IRC19:58
*** dims has quit IRC19:58
*** sorantis has joined #heat19:59
*** sergmelikyan has joined #heat20:03
*** e0ne has quit IRC20:04
*** kairat_ has joined #heat20:07
*** aweiteka has joined #heat20:08
*** kebray has joined #heat20:14
*** kebray has quit IRC20:14
*** kebray has joined #heat20:15
*** sergmelikyan has quit IRC20:19
jdandreahttps://review.openstack.org/#/c/203823/4 passes Jenkins - yay! If anyone's resting, please see the comments in the latest patch. Soliciting feedback/thoughts.20:24
*** sergmelikyan has joined #heat20:27
openstackgerritSteven Hardy proposed openstack/heat: Reuse existing environment on PATCH update  https://review.openstack.org/15461920:31
openstackgerritSteven Hardy proposed openstack/heat: Remove patch_previous_parameters from environment  https://review.openstack.org/20528320:31
openstackgerritSteve Baker proposed openstack/heat: Always commit after deployment db operations  https://review.openstack.org/20478020:32
*** gberginc has quit IRC20:33
*** sergmelikyan has quit IRC20:33
*** sergmelikyan has joined #heat20:34
*** sergmelikyan has quit IRC20:35
*** sergmelikyan has joined #heat20:36
openstackgerritPratik Mallya proposed openstack/heat: Removes replace-on-update for SwiftSignalHandle resource  https://review.openstack.org/20216220:39
*** kitch_ has quit IRC20:40
*** sergmelikyan has quit IRC20:40
*** signed8bit has quit IRC20:42
*** sergmelikyan has joined #heat20:44
openstackgerritPratik Mallya proposed openstack/heat: Removes replace-on-update for SwiftSignalHandle resource  https://review.openstack.org/20216220:45
*** aweiteka has quit IRC20:50
*** sergmelikyan has quit IRC20:50
*** e0ne has joined #heat20:51
openstackgerritPratik Mallya proposed openstack/heat: Removes replace-on-update for SwiftSignalHandle resource  https://review.openstack.org/20216220:54
*** neelashah has joined #heat20:54
*** shardy has quit IRC20:54
*** e0ne has quit IRC20:55
*** Raj2 has joined #heat20:57
*** pm90__ has quit IRC20:58
*** sergmelikyan has joined #heat21:04
*** sergmelikyan has quit IRC21:05
*** neelashah has quit IRC21:11
*** EricGonczer_ has quit IRC21:12
*** e0ne has joined #heat21:12
*** neelashah has joined #heat21:12
*** neelashah1 has joined #heat21:13
*** randallburt has quit IRC21:16
*** jaime49 has quit IRC21:17
*** neelashah has quit IRC21:17
*** neelashah1 has quit IRC21:25
*** sergmelikyan has joined #heat21:28
*** sergmelikyan has quit IRC21:29
*** sergmelikyan has joined #heat21:29
*** jonesbr has left #heat21:30
*** sergmelikyan has quit IRC21:31
*** sergmelikyan has joined #heat21:33
*** jasond has quit IRC21:34
*** sergmelikyan has quit IRC21:37
*** e0ne has quit IRC21:38
*** markvan has joined #heat21:39
*** sergmelikyan has joined #heat21:41
*** sergmelikyan has quit IRC21:42
*** pleia2 has quit IRC21:42
*** sergmelikyan has joined #heat21:43
*** spzala has quit IRC21:43
*** sergmelikyan has quit IRC21:44
*** sergmelikyan has joined #heat21:45
*** sergmelikyan has quit IRC21:46
*** sergmelikyan has joined #heat21:46
*** sergmelikyan has quit IRC21:46
*** sergmelikyan has joined #heat21:47
*** sergmelikyan has quit IRC21:47
*** sergmelikyan has joined #heat21:47
*** sergmelikyan has quit IRC21:48
*** cchang has quit IRC21:48
*** cchang has joined #heat21:48
*** achanda has joined #heat21:49
*** sorantis has quit IRC21:53
*** thedodd has joined #heat21:55
*** sergmelikyan has joined #heat21:59
*** sergmelikyan has quit IRC21:59
*** vasanth has quit IRC22:00
*** jaime49 has joined #heat22:01
*** kevinbenton has quit IRC22:01
*** sergmelikyan has joined #heat22:02
*** jaime49 has quit IRC22:02
*** jaime49 has joined #heat22:02
*** blomquisg has quit IRC22:05
*** randallburt has joined #heat22:05
*** randallburt has quit IRC22:06
*** randallburt has joined #heat22:06
*** htruta_ has joined #heat22:08
*** jecarey has quit IRC22:16
*** pleia2 has joined #heat22:16
*** bnemec has quit IRC22:18
*** EricGonczer_ has joined #heat22:22
*** achanda has quit IRC22:23
*** cing has joined #heat22:24
*** sabeen3 has quit IRC22:32
*** kitch has joined #heat22:32
*** signed8bit has joined #heat22:34
*** signed8bit has quit IRC22:37
*** signed8bit has joined #heat22:38
*** dims has joined #heat22:39
*** yassine__ has quit IRC22:43
*** mkoderer has quit IRC22:44
*** signed8b_ has joined #heat22:45
*** signed8bit has quit IRC22:46
*** Raj2 has quit IRC22:47
*** Raj2 has joined #heat22:50
*** chlong has quit IRC22:52
*** kairat_ has quit IRC22:55
*** coolsvap is now known as coolsvap|away23:00
*** Raj2 has quit IRC23:02
*** david-lyle has quit IRC23:02
*** ddaskal has quit IRC23:05
*** cchang has quit IRC23:05
*** ashuk has joined #heat23:10
*** signed8b_ is now known as signed8bit_ZZZzz23:15
*** signed8bit_ZZZzz is now known as signed8b_23:15
*** sergmelikyan has quit IRC23:15
*** sergmelikyan has joined #heat23:17
*** sergmelikyan has quit IRC23:18
*** serg_melikyan has joined #heat23:18
*** sjmc7_ has quit IRC23:18
*** serg_melikyan has quit IRC23:23
*** dims_ has joined #heat23:24
*** dims has quit IRC23:27
asalkeldmorning'ish23:27
*** signed8b_ is now known as signed8bit_ZZZzz23:28
stevebakermorning23:29
*** signed8bit_ZZZzz is now known as signed8b_23:32
*** pm90_ has joined #heat23:32
*** mikal has quit IRC23:32
*** Qiming has joined #heat23:32
*** mikal has joined #heat23:33
*** jruano has quit IRC23:34
*** randallburt has quit IRC23:35
*** pm90__ has joined #heat23:35
*** david-lyle has joined #heat23:36
*** tochi has joined #heat23:37
*** cchang has joined #heat23:38
*** pm90_ has quit IRC23:38
pm90__stevebaker: what is the reason behind having the swiftsignalhandle change to a different state on update? I'm still not clear if I understand correctly23:38
*** Drago has quit IRC23:41
stevebakerpm90__: wait conditions are usually used to notify that something is done during stack-create, but the server might be set up to do that thing on stack-update too, so the handle needs to go back into an IN_PROGRESS state so they can be signalled again23:42
stevebakerpm90__: arguably it is replicating what SoftwareDeployment resources enable, and we should keep wait conditions for creation-only use cases23:43
pm90__stevebaker: but isn't that the signal resource and not the signalhandle resources which must behave that?23:43
pm90__*like that23:43
*** sergmelikyan has joined #heat23:44
stevebakerUpdateWaitConditionHandle was implemented in the handle, but it might be better design to do it in the waitcondition (or swiftsignal) resource23:44
asalkeldeggs boiled, brb - yum23:45
*** dims_ has quit IRC23:46
stevebakerpm90__: the more I think about it, deployment resources handle this case.23:46
*** dsneddon is now known as dsneddon_biab23:48
openstackgerritPratik Mallya proposed openstack/heat: Removes replace-on-update for SwiftSignalHandle resource  https://review.openstack.org/20532723:50
*** thedodd has quit IRC23:50

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!