Wednesday, 2015-03-18

*** IlyaE has quit IRC00:01
*** kebray has joined #heat00:02
*** pm90_ has quit IRC00:07
*** pm90_ has joined #heat00:10
*** achanda has quit IRC00:15
*** achanda has joined #heat00:16
*** achanda has quit IRC00:18
*** achanda has joined #heat00:18
*** blomquisg has joined #heat00:23
openstackgerritMerged openstack/heat: Add integration scenario test for Neutron LBaaS  https://review.openstack.org/16218400:28
*** achanda has quit IRC00:30
*** pm90_ has quit IRC00:31
*** hdd has quit IRC00:36
*** pm90_ has joined #heat00:40
openstackgerritAngus Salkeld proposed openstack/heat: StackResource convert operations to use RPC  https://review.openstack.org/11633600:44
openstackgerritAngus Salkeld proposed openstack/heat: Pass the environment into the Template class and not Stack  https://review.openstack.org/16406700:44
*** kebray has quit IRC00:52
*** Qiming has joined #heat00:54
*** Qiming_ has joined #heat00:55
*** spzala has joined #heat00:58
*** Qiming has quit IRC00:59
*** Qiming_ is now known as Qiming00:59
openstackgerritSteve Baker proposed openstack/heat-templates: pip_mirror param for test image boot config  https://review.openstack.org/16526101:02
*** bandarji has joined #heat01:12
*** Qiming_ has joined #heat01:20
*** pm90_ has quit IRC01:23
*** Qiming has quit IRC01:23
openstackgerrityuntongjin proposed openstack/heat: Versioned object - WatchRule and WatchData  https://review.openstack.org/15348701:25
*** rdo has quit IRC01:41
asalkeldthis needs approving: https://review.openstack.org/#/c/164591/01:42
*** hdd has joined #heat01:45
*** bandarji has quit IRC01:49
asalkeldfor your convenience: https://etherpad.openstack.org/p/heat-kilo-3-reviews01:51
asalkeldstevebaker: ^01:52
asalkeldhuangtianhua: thanks01:57
asalkeld(for the review)01:57
huangtianhuaasalkeld: np :)01:57
*** LiJiansheng has joined #heat01:58
*** dims has quit IRC01:59
shaohe_fengasalkeld:  huangtianhua: the last version-object  https://review.openstack.org/#/c/153487/02:00
asalkeldshaohe_feng: yeah see my review etherpad: https://etherpad.openstack.org/p/heat-kilo-3-reviews02:00
shaohe_fengasalkeld:  great02:01
shaohe_fenghope this can be merged in this release.02:01
shaohe_fengand any comments, we will addressed it ASAP.02:02
asalkeldshaohe_feng: i don't see why not02:04
asalkeldshaohe_feng: i was just waiting for jenkins to +102:05
shaohe_feng  I 'm also waiting for it .:)02:05
*** harlowja_ is now known as harlowja_away02:06
*** hdd has quit IRC02:12
*** hdd has joined #heat02:12
*** Qiming_ is now known as Qiming02:17
*** coolsvap|afk is now known as coolsvap02:19
*** erkules_ has joined #heat02:20
*** sdake__ has joined #heat02:21
*** IlyaE has joined #heat02:22
openstackgerritMerged openstack/heat-templates: Remove experimental 'heat-config-docker' hook  https://review.openstack.org/16500602:23
*** erkules has quit IRC02:23
*** sdake has quit IRC02:25
sdake__asalkeld shoot02:26
asalkeldsdake__: no worries just about the ptl thing02:27
asalkeldsent the emali02:27
asalkeldwell done!02:27
sdake__thanks for that, i thought you maybe a day off :)02:27
sdake__sine aus ive in the future02:27
asalkeldyeah, it's the 18'th here02:27
zanebsdake__: congrats :)02:30
*** IlyaE has quit IRC02:30
sdake__lucky me ;)02:30
sdake__thanks zaneb02:30
stevebakerasalkeld: cool, thanks for that02:30
*** IlyaE has joined #heat02:31
ramishrasdake__: congrats!02:31
sdake__its not really a big deal but thanks guys :)02:32
*** hdd has quit IRC02:32
openstackgerritMerged openstack/heat: Remove capacity check from AWS::AG update  https://review.openstack.org/16374302:32
sdake__now, heat ptl, that would be a big deal - wonder who is going to be the sacrificial lamb :)02:32
sdake__anyone interested in officiating the magnum ptl election?02:33
*** coolsvap is now known as coolsvap|afk02:33
sdake__it only becomes real work if there are two candidates ;)02:34
stevebakerI'd go for PTL this cycle except the winter meeting time really clashes with family life02:35
asalkeldstevebaker: anyone from rht interested?02:36
asalkeldcurious who the next victim is going to be02:37
zanebasalkeld: for the record, I definitely wouldn't have time atm :(02:38
*** kfjohnson has joined #heat02:38
asalkeldzaneb: what on earth are you up to now adays?02:38
asalkeldmanaging the things...02:38
zanebmeetings02:39
asalkeldwell i hope they are worth it02:39
zanebthey're not02:39
asalkeldlol02:39
zanebso that leaves only ryansb and therve from RH02:40
asalkeldyikes02:40
asalkeldrht pulling back from heat eh?02:40
zaneband shardy of course, but he's even busier than I am02:40
openstackgerritQiming Teng proposed openstack/heat: Remove usage of 'long' data type  https://review.openstack.org/16527702:40
zanebasalkeld: no, not at all02:40
asalkeldwell feet on the ground..02:41
asalkeldmaybe therve is keen?02:41
asalkeldo, well we will soon see02:42
zanebit's more that we've decided we can't leave the tripleo-heat integration to the tripleo people any more02:42
zanebespecially since Clint is no longer focusing on that02:42
asalkeldyeah, you find out what using the api is like :-O02:42
*** coolsvap|afk is now known as coolsvap02:45
*** kebray has joined #heat02:49
asalkeldwow, that etherpad is working wonders02:54
zanebok, bedtime02:55
asalkeldlater zaneb02:55
zanebo/02:55
*** KarolynChambers has quit IRC02:56
*** KarolynChambers has joined #heat02:57
*** IlyaE has quit IRC02:57
asalkeldfor a laugh: http://slim.top.me/wp-content/uploads/2013/10/Cloud-Guy_PM.jpg03:05
*** GonZo2000 has quit IRC03:08
*** coolsvap is now known as coolsvap|afk03:09
*** Marga_ has quit IRC03:09
openstackgerritMerged openstack/heat: Pin the target keystone endpoint to the context auth url  https://review.openstack.org/16432503:09
*** blomquisg has quit IRC03:15
*** coolsvap|afk is now known as coolsvap03:16
openstackgerritMerged openstack/heat: Versioned-object SyncPoint  https://review.openstack.org/16459103:28
openstackgerritMerged openstack/heat: Versioned object Service  https://review.openstack.org/16413503:28
openstackgerritMerged openstack/heat: Pass the environment into the Template class and not Stack  https://review.openstack.org/16406703:28
openstackgerritMerged openstack/heat: Pass the environment into the Template class and not Stack  https://review.openstack.org/16406703:28
*** IlyaE has joined #heat03:31
asalkeldoo, mergy time03:31
*** rakesh_hs has joined #heat03:33
*** hdd has joined #heat03:33
*** sdake__ has quit IRC03:39
rakesh_hszaneb: Hi, thanks for reviewing, I also had some doubts https://review.openstack.org/#/c/159444/6/heat/engine/stack.py #LNO 904 I have posted it as comments03:39
asalkeldrakesh_hs: i think he has just gone to bed03:41
*** sdake has joined #heat03:41
*** sarob has joined #heat03:41
rakesh_hsoh ok sorry, saw his comments now, and replied03:41
rakesh_hsI will address the other comments by then03:41
openstackgerritSteve Baker proposed openstack/heat: Func tests use fedora-heat-test-image  https://review.openstack.org/16328703:42
openstackgerritSteve Baker proposed openstack/heat: iniset heat_integrationtests.conf  https://review.openstack.org/16528603:42
openstackgerritSteve Baker proposed openstack/heat: WIP Enable software config integration test  https://review.openstack.org/16528703:42
openstackgerritMerged openstack/heat-specs: Add Trove cluster resource  https://review.openstack.org/15912803:45
*** sarob has quit IRC03:47
*** IlyaE has quit IRC03:53
asalkeldQiming: been super crazy busy -> http://stackalytics.com/?project_type=all&metric=commits03:54
asalkeldQiming: wow #103:55
*** vijayagurug has joined #heat03:56
*** asdf1234 has joined #heat03:58
stevebakerI have no idea what senlin is03:59
asalkeldstevebaker: our new autoscaling project03:59
asalkeldQiming: is just doing it03:59
stevebakersweet, someone needs to04:00
*** Marga_ has joined #heat04:11
*** Marga__ has joined #heat04:12
*** Marga_ has quit IRC04:16
*** IlyaE has joined #heat04:16
elynnHi do you know how to run python34 tests for heatclient?04:23
elynntox  -epy34 seems not work for me.04:24
elynnNo mater what unittests I run , it always return a error04:26
elynnerror: testr failed (3)04:26
elynnand no details for what tests are failed.04:26
*** kebray has quit IRC04:30
*** kebray has joined #heat04:31
*** IlyaE has quit IRC04:35
*** hdd has quit IRC04:38
asalkeldelynn: you need to install python3404:38
elynnalready installed.04:40
elynn.tox/py34/bin/python -m testtools.run heatclient.tests.test_template_utils04:41
elynnthis could work.04:41
elynnha04:41
asalkeldbrb, picking kids up from school04:42
*** boris-42 has joined #heat04:47
openstackgerritEthan Lynn proposed openstack/python-heatclient: Parse nested files if they are template  https://review.openstack.org/16441704:48
lifelesselynn: try04:51
lifelesselynn: . .tox/py34/bin/activate04:51
lifelesselynn: testr run04:51
lifelessthen you'll see testr's full output04:51
*** rakesh_hs has quit IRC04:55
*** IlyaE has joined #heat05:02
*** achanda has joined #heat05:06
elynnthanks lifeless , will have a try.05:08
*** sdake_ has quit IRC05:13
*** sdake has quit IRC05:13
*** xek has quit IRC05:18
*** nkhare has joined #heat05:21
openstackgerritAngus Salkeld proposed openstack/heat: StackResource convert operations to use RPC  https://review.openstack.org/11633605:22
*** sarob has joined #heat05:43
*** Yanyanhu has joined #heat05:49
*** sarob has quit IRC05:49
*** Yanyan has joined #heat05:56
*** Yanyanhu has quit IRC06:00
*** asdf1234 has quit IRC06:02
*** Tango has quit IRC06:08
*** Yanyanhu has joined #heat06:14
*** asdf1234 has joined #heat06:16
*** Yanyan has quit IRC06:16
*** Yanyan has joined #heat06:17
*** Yanyanhu has quit IRC06:20
*** achanda has quit IRC06:25
*** Yanyan has quit IRC06:26
*** Yanyan has joined #heat06:26
*** achanda has joined #heat06:27
*** liusheng has quit IRC06:31
*** liusheng has joined #heat06:31
*** inc0 has joined #heat06:31
inc0good morning06:31
*** ishant has joined #heat06:35
*** IlyaE has quit IRC06:36
*** Yanyanhu has joined #heat06:36
*** Yanyan has quit IRC06:37
*** KarolynChambers has quit IRC06:39
*** rakesh_hs has joined #heat06:40
openstackgerrityuntongjin proposed openstack/heat: Versioned object - WatchRule and WatchData  https://review.openstack.org/15348706:40
*** KanagarajM has joined #heat06:45
*** sarob has joined #heat06:45
*** Yanyan has joined #heat06:45
inc0asalkeld, hello, https://bugs.launchpad.net/heat/+bug/1433340 I started to think about it06:46
openstackLaunchpad bug 1433340 in heat "stack actions do not guarantee that the stack will be placed into IN_PROGRESS by the time they return" [High,Triaged]06:46
inc0we can't really assume we have correct status at any given point of time - a pain of async...06:46
*** jtomasek has joined #heat06:47
*** rakesh_hs has quit IRC06:49
*** Yanyanhu has quit IRC06:49
inc0one solution I can think of is to introduce some sort of action queue, an db table which will be sychronious, when we call stack-update we add record06:49
inc0and when it completes we update record06:49
inc0and stack is complete only when latest record is complete06:50
*** sarob has quit IRC06:50
*** kebray has quit IRC06:51
asalkeldinc0: it's not very hard06:53
asalkeldwe just need to not create the thread until we have set the state06:53
asalkeldwe do very little until that point06:53
*** Yanyanhu has joined #heat06:54
asalkeldhttps://github.com/openstack/heat/blob/master/heat/engine/stack.py#L645-L66206:54
asalkeldjust move that logic  to before it's run in the green thread06:55
inc0yeah...but what about current stack_update running?06:56
asalkeldit's within the lock06:56
*** Yanyan has quit IRC06:56
asalkeldlock, then set state, then run task06:57
inc0then release lock, and before that we call stack update, and we can't set new state before last one release lock..06:57
inc0or am I missing something?06:57
asalkeldhuh?06:58
inc0hold on, I'll digest what you've just;)06:59
asalkeldinc0: we release lock when the action is done06:59
inc0yeah, thats my point, so we will block creation of green thread until that07:00
asalkeldit's just moving a small bit of logic from stack.py into service.py07:00
asalkeldinc0: yes07:00
inc0so if person calls stack_update, we won't be able to guarantee that stack will be in update_in_progress when it returns?07:01
inc0or will we block return until previous upgrade is complete?07:01
asalkeldinc0: if there is an update we will get ActionInProgress (same as now)07:01
asalkeldthat doesn't change07:02
inc0only that won't be action we're calling for right?:)07:02
asalkeldinc0: that's an exception - your update will fail07:03
inc0ok, I get it now...I'll look deeper into code07:04
asalkeldi just want to know that my action has started when the call returns07:04
asalkeldor it must fail07:04
asalkeldotherwise it's really hard to figure out what's going on07:04
inc0that will be kinda cheating tho, because in reality they will not yet start;)07:04
asalkeldinc0: well at least i can query it and the state makes sense07:05
inc0yeah, true07:05
*** Trozz has joined #heat07:05
asalkeldatm i can query it and actually not be any more informed07:05
inc0other alternative would be something like upgrade_init07:05
*** IlyaE has joined #heat07:05
inc0and then in_prog when its actually in progress07:06
asalkeldi then in progress is fine07:06
asalkelddont' want yet more states07:06
inc0I guess there isn't much value added by init status07:06
asalkeldbut sure, as long as *something* changes07:06
inc0there are events for more inquisitive users07:07
inc0(ah, using complicated english words and hoping I've used them in correct context...)07:07
asalkeldinc0: that's not very efficient07:07
asalkeldthis comes from me wanting more certainty in stack_resource.py07:08
inc0I mean, I agree that we can solve that by putting in_progress immediately07:08
*** Yanyan has joined #heat07:09
inc0and if person wants to check whats really going on, he can check events07:09
*** jtomasek has quit IRC07:10
inc0allright, thanks for claryfying that, I'll think some more about this action queue tho...I think there are few good use cases for that07:11
inc0like queue of updates to make one stack-create contains few single atomic upgrades...07:12
*** Yanyanhu has quit IRC07:13
*** IlyaE has quit IRC07:13
KanagarajMasalkeld: are we maintaining the api-ref for heat in heat repo https://github.com/openstack/heat/tree/master/doc/docbkx/api-ref, but openstack-api to be use instead, right?07:14
*** asdf1234 has quit IRC07:15
KanagarajMasalkeld: recently i have introduced changes in openstack api-site repo for new REST api changes, so wanted to know wheter it should be changes in heat repo as well?07:16
asalkeldKanagarajM: for the api just make the changes in api-site07:29
asalkeldnot sure why we have the intree one07:30
*** jprovazn has joined #heat07:34
KanagarajMok, may be we can remove it as it doesn't hold any value now07:34
*** achanda has quit IRC07:35
KanagarajMand  https://github.com/openstack/heat/tree/master/doc/docbkx/README.rst  says, evently we move from heat to api-site,07:38
KanagarajMfor admin guide, i'm trying to collect content and evetually will place them in the openstack-manual repo.07:39
*** achanda has joined #heat07:39
*** jtomasek has joined #heat07:46
*** Yanyan has quit IRC07:46
openstackgerritMerged openstack/heat: Add OS::Trove::Cluster resource  https://review.openstack.org/15946307:46
*** sarob has joined #heat07:46
*** ishant has quit IRC07:50
*** ishant has joined #heat07:51
*** sarob has quit IRC07:51
*** KarolynChambers has joined #heat07:53
*** jcoufal has joined #heat07:55
*** jtomasek has quit IRC08:01
ishantasalkeld: Hi08:03
ishantasalkeld: I am working on this blueprint https://blueprints.launchpad.net/heat/+spec/lazy-load-outputs . Can you please assign this to me?08:03
*** shardy has joined #heat08:04
*** KarolynChambers has quit IRC08:04
*** KarolynChambers has joined #heat08:06
*** pas-ha has joined #heat08:08
*** dulek has joined #heat08:09
*** achanda has quit IRC08:10
pas-hamorning all08:12
*** Marga__ has quit IRC08:13
*** KarolynChambers has quit IRC08:13
*** KarolynChambers has joined #heat08:15
*** KarolynChambers has quit IRC08:17
*** KarolynChambers has joined #heat08:18
*** KarolynChambers has quit IRC08:20
*** KarolynChambers has joined #heat08:22
cmystermmorning pas-ha08:22
cmyster-m08:22
*** jistr has joined #heat08:22
asalkeldishant: no problem08:23
shadowerhey everyone08:24
*** KarolynChambers has quit IRC08:24
cmysterhey08:24
shardymorning all08:25
*** lsmola has joined #heat08:25
*** KarolynChambers has joined #heat08:26
cmystermorning08:26
asalkeldhi all08:27
asalkeldishant: done08:27
inc0 https://review.openstack.org/#/c/153487/ guys can I have review plz? it already had 2 * +2 but had to rebase..08:27
cmysterls -rtl08:27
cmysterls -rtl08:27
cmysterumm08:28
cmystermore coffeee....08:28
*** Trozz is now known as zzTrozz08:28
*** zzTrozz is now known as Trozz08:28
*** ifarkas has joined #heat08:30
pas-haasalkeld, you W+1ed just as was giving my +2 :)08:31
asalkeld:-)08:32
inc0thanks a lot, that was fast:)08:32
ishantasalkeld: thanks08:35
asalkeldpas-ha: that's odd08:35
asalkeldi didn't change the db schema at all08:35
shardyshadower: hey, sorry for the delay on the init_complete patch - I've been having trouble finding an approach to persist that state which doesn't break things :(08:36
shardyshadower: about to have my third attempt, will let you know how it goes..08:36
asalkeldpas-ha:  and i have never seen that unit test failer08:36
*** Yanyanhu has joined #heat08:36
pas-haasalkeld, most probably an implicit rebase done by gerrit introduced those.. and may be some other artifacts08:37
asalkeldi tried a recheck08:37
asalkeld(i did rebase not long ago)08:37
pas-haok, let's see08:37
pas-hamay be a DB glitch..08:37
asalkeldbusy time for infra08:38
inc0I remember after juno, when gates took 24h to finish08:42
inc0that was bad.08:42
asalkeldyeah08:43
shardy24h w/multiple rechecks :-O08:43
asalkeldand one day till ff08:44
asalkeldok test are fine locally08:44
openstackgerritAngus Salkeld proposed openstack/heat: StackResource convert operations to use RPC  https://review.openstack.org/11633608:44
asalkeldtry *again*08:44
*** Yanyan has joined #heat08:46
shadowershardy: thanks, no worries08:48
shadowerI assumed it wasn't trivial08:48
shadowershardy: anything I could help with?08:49
*** Yanyanhu has quit IRC08:50
*** rakesh_hs_ has joined #heat08:53
*** BManojlovic has joined #heat08:57
openstackgerritKarolyn Chambers proposed openstack/heat: Implements stack lifecycle scheduler hints  https://review.openstack.org/9688908:57
shardyshadower: maybe, I'll tidy up what I have and post it shortly09:01
shardythere are several inter-related problems09:02
shardy1. Several places make state assumptions based on the resource having an ID (not by checking the actual state)09:02
*** Yanyanhu has joined #heat09:03
shardy2. The resource _store() method stores resolved metadata, so this is wrong if you store() before CREATE_IN_PROGRESS, but then the store_or_update doesn't then store metadata at all09:03
shardy3. There's something odd in the AutoScalingGroup/InstanceGroup code so even if you store all resources in stack.Stack.store, the nested resources inside the group aren't stored09:04
shardySome fresh eyes may help :)09:04
*** Yanyan has quit IRC09:05
*** erkules_ is now known as erkules09:07
*** erkules has joined #heat09:07
*** boris-42 has quit IRC09:12
*** Yanyan has joined #heat09:20
openstackgerritEthan Lynn proposed openstack/heat: Switch config deferred_auth_method to trusts by default  https://review.openstack.org/12217709:21
*** Yanyanhu has quit IRC09:23
*** blues-man has joined #heat09:25
*** Yanyanhu has joined #heat09:26
*** Yanyan has quit IRC09:29
*** Yanyan has joined #heat09:31
*** dmn_ has joined #heat09:34
dmn_shardy: support for ansible in HOT is same as puppet?09:34
shardydmn_: There is an ansible software config hook, yes09:35
shardyHOT, the DSL, doesn't care about what CM tool you use, the interface is in the in-instance hook script09:35
*** Yanyanhu has quit IRC09:36
elynnhttps://review.openstack.org/#/c/164417/  https://review.openstack.org/#/c/122177/09:36
elynn^_^09:36
shardyhttps://github.com/openstack/heat-templates/tree/master/hot/software-config/elements/heat-config-ansible/install.d09:36
shardydmn_: ^^09:36
openstackgerritKanagaraj Manickam proposed openstack/heat: Fix SoftwareConfigService to use Resource object  https://review.openstack.org/16534209:37
openstackgerritMerged openstack/heat: Versioned object - WatchRule and WatchData  https://review.openstack.org/15348709:38
dmn_shardy: oh okay09:38
*** sorantis has joined #heat09:38
inc0asalkeld, last versioned objects has been merged:) mind setting up bp as implemented?09:39
openstackgerritKanagaraj Manickam proposed openstack/heat: Fixes SoftwareConfigService to use Resource object  https://review.openstack.org/16534209:39
asalkeldinc0: great job09:41
inc0ah, its already done, thanks:)09:41
inc0there will be more work in L09:41
inc0about RPC09:41
inc0and we'll make bunch of unit tests for this mechanism09:42
*** rakesh_hs_ has quit IRC09:42
asalkeldsounds good09:42
asalkeldinc0: maybe make a summit session about it09:42
*** dims_ has joined #heat09:43
inc0there will be one proposed in oslo09:43
inc0brb->scrum09:43
*** aweiteka has joined #heat09:46
*** alexpilotti has joined #heat09:47
*** dmn__ has joined #heat09:51
*** dmn_ has quit IRC09:51
*** dmn__ has quit IRC09:53
*** Qiming has quit IRC09:56
*** pitr-ch has joined #heat09:59
*** inc0 has quit IRC10:08
*** Yanyanhu has joined #heat10:09
*** xek has joined #heat10:12
*** Yanyan has quit IRC10:12
*** dmn__ has joined #heat10:12
*** Yanyan has joined #heat10:12
*** Yanyanhu has quit IRC10:14
*** Yanyanhu has joined #heat10:14
*** aweiteka has quit IRC10:15
*** inc0 has joined #heat10:16
*** Yanyan has quit IRC10:17
*** Yanyan has joined #heat10:17
*** dmn__ has quit IRC10:17
*** sergmelikyan has quit IRC10:19
asalkeldpas-ha: +A please -> https://review.openstack.org/#/c/116336/10:19
*** dmn__ has joined #heat10:20
pas-haasalkeld, done :)10:20
*** Yanyanhu has quit IRC10:21
*** Yanyan has quit IRC10:22
asalkeldthx10:23
openstackgerritKanagaraj Manickam proposed openstack/heat: Fixes StackWatchService to use objects in place of db  https://review.openstack.org/16534910:29
*** ifarkas has quit IRC10:44
*** ifarkas has joined #heat10:47
*** boris-42 has joined #heat10:51
*** Qiming has joined #heat10:52
*** jtomasek has joined #heat10:53
asalkeldremember meeting in an hour: https://wiki.openstack.org/wiki/Meetings/HeatAgenda10:55
shardyasalkeld: question about https://github.com/openstack/heat/blob/master/heat/engine/resources/stack_resource.py#L26310:56
shardyif we've stored the failed state, surely the resource record will already be stored?10:56
shardy(even if the underlying stack wasn't)10:57
*** KarolynChambers has quit IRC10:58
shardyI'm trying to persist INIT_COMPLETE to the DB for breakpoints, but it turns out the point when you call _store() is important, because _store_or_update doesn't do the same thing (updates different columns)10:58
*** dulek has quit IRC11:02
*** dulek has joined #heat11:02
*** inc0_ has joined #heat11:02
KanagarajMasalkeld: as the heat objects are now in place, shall i re-implement https://review.openstack.org/#/c/110557/ ?11:05
*** inc0 has quit IRC11:06
*** sorantis has quit IRC11:07
*** KarolynChambers has joined #heat11:07
asalkeldKanagarajM: you could - but it's super low priority11:10
KanagarajMasalkeld: ok. sure.11:11
*** KarolynChambers has quit IRC11:14
*** rakesh_hs_ has joined #heat11:15
*** KarolynChambers has joined #heat11:15
openstackgerritKanagaraj Manickam proposed openstack/heat: Versioned-object StackLock  https://review.openstack.org/16536311:16
*** pitr-ch has quit IRC11:19
*** KanagarajM is now known as KanagarajM_afk11:19
*** KarolynChambers has quit IRC11:21
*** KarolynChambers has joined #heat11:22
*** sorantis has joined #heat11:23
*** KanagarajM_afk has quit IRC11:24
*** KarolynChambers has quit IRC11:25
*** KarolynChambers has joined #heat11:26
*** pas-ha has quit IRC11:27
*** KarolynChambers has quit IRC11:28
*** cdent has joined #heat11:29
*** KarolynChambers has joined #heat11:30
openstackgerritMerged openstack/heat: Remove usage of 'long' data type  https://review.openstack.org/16527711:31
*** Drago has joined #heat11:32
*** Drago has quit IRC11:33
*** Drago has joined #heat11:33
*** KarolynChambers has quit IRC11:35
*** ParsectiX has joined #heat11:35
*** KarolynChambers has joined #heat11:36
*** jprovazn has quit IRC11:37
*** KarolynChambers has quit IRC11:39
*** jprovazn has joined #heat11:40
*** pas-ha has joined #heat11:40
*** KarolynChambers has joined #heat11:40
*** achanda has joined #heat11:45
*** KarolynChambers has quit IRC11:45
asalkeldakuznetsova: that neutron test seems to have just gotten our tests to the point of timing out11:45
asalkeld:-(11:46
asalkeldheat_integrationtests.functional.test_autoscaling.AutoScalingSignalTest.test_signal_with_policy_update [832.644550s] ... ok11:48
akuznetsovaasalkeld, actually, it test take less than 2 min in regular devstack11:49
*** KarolynChambers has joined #heat11:49
*** achanda has quit IRC11:49
*** tspatzier has joined #heat11:49
asalkeldakuznetsova: they could just be very slow test machines11:49
asalkeldheat_integrationtests.functional.test_instance_group.InstanceGroupUpdatePolicyTest.test_instance_group_update_replace_huge_min_in_service [508.550756s] ... ok11:49
asalkeldthese tests ^ are normally a lot faster too11:49
asalkeldBuild timed out (after 125 minutes). Marking the build as failed.11:50
asalkeld2 hours - wow11:50
akuznetsovathe initial and main  problem is too slow nodes11:50
*** sarob has joined #heat11:50
akuznetsovaneed to do something with it11:50
shardyasalkeld: I think we may want to rethink that replace_huge_min_in_service test, it kinda worked as a "unit" test, but it's really slow even locally as a functional test11:51
shardyI've been running that a lot debugging this init_complete patch11:51
akuznetsovawe can't skip scenario tests - they are important11:51
asalkeldshardy: yeah11:51
asalkeldakuznetsova: totally11:51
shardyakuznetsova: It didn't say skip anything, we should figure out another way to get coverage of corner cases like that test11:51
asalkeldneed a bug for this, causes false failures11:52
*** KarolynChambers has quit IRC11:54
asalkeldhttps://bugs.launchpad.net/heat/+bug/143355511:55
openstackLaunchpad bug 1433555 in heat "functional tests are taking too long and cause false failures" [Undecided,New]11:55
*** sarob has quit IRC11:55
*** KarolynChambers has joined #heat11:55
*** KarolynChambers has quit IRC11:57
asalkeldooo, meeting in 2mins11:58
*** KarolynChambers has joined #heat11:59
*** david-lyle_afk is now known as david-lyle12:00
*** KarolynChambers has quit IRC12:01
skraynevI have  today some corporate event, so will be just partially involved in meeting and work unfortunately12:01
*** KarolynChambers has joined #heat12:03
*** KarolynChambers has quit IRC12:05
*** KarolynChambers has joined #heat12:06
*** KarolynChambers has quit IRC12:08
*** KarolynChambers has joined #heat12:11
*** KanagarajM has joined #heat12:13
*** dmn__ has quit IRC12:14
*** rakesh_hs_ has quit IRC12:15
*** Qiming_ has joined #heat12:15
*** vijayagurug has quit IRC12:15
*** Qiming has quit IRC12:18
*** derekh has joined #heat12:19
*** KarolynChambers has quit IRC12:21
*** vishalcdac07 has joined #heat12:21
*** dims_ has quit IRC12:22
vishalcdac07@stevebaker12:22
*** KarolynChambers has joined #heat12:22
*** dims_ has joined #heat12:22
*** sdake has joined #heat12:23
*** KarolynChambers has quit IRC12:24
*** aaa__ has joined #heat12:25
*** KarolynChambers has joined #heat12:26
skraynevpas-ha: ping12:28
pas-haskraynev, pong12:28
skraynevhave you seen my message in slack?12:28
pas-hayep12:29
*** blues-man has quit IRC12:29
*** tochi has quit IRC12:29
skraynevpas-ha: ok cool. just to want be sure, that you know about it ;)12:30
*** KarolynChambers has quit IRC12:31
*** sorantis has quit IRC12:32
*** tspatzier has quit IRC12:32
*** KarolynChambers has joined #heat12:32
*** Qiming has joined #heat12:33
Qiminghuangtianhua: online?12:34
*** KarolynChambers has quit IRC12:35
*** dmn_ has joined #heat12:35
*** Qiming has quit IRC12:36
*** KarolynChambers has joined #heat12:37
*** sdake_ has joined #heat12:37
*** aaa__ has quit IRC12:38
*** KarolynChambers has quit IRC12:39
*** jistr is now known as jistr|biab12:39
*** KarolynChambers has joined #heat12:40
*** sorantis has joined #heat12:40
*** sdake has quit IRC12:41
*** KarolynChambers has quit IRC12:42
*** KarolynChambers has joined #heat12:43
*** KarolynChambers has quit IRC12:45
*** KarolynChambers has joined #heat12:45
*** dulek has quit IRC12:46
*** blomquisg has joined #heat12:47
*** KarolynChambers has quit IRC12:49
*** KarolynChambers has joined #heat12:50
*** tiantian has joined #heat12:51
openstackgerritKanagaraj Manickam proposed openstack/heat: Fixes SoftwareConfigService to use Resource object  https://review.openstack.org/16534212:51
*** sarob has joined #heat12:51
*** KarolynChambers has quit IRC12:53
openstackgerritAngus Salkeld proposed openstack/heat: Set num_engine_workers=2 for gate functional tests  https://review.openstack.org/16539612:53
asalkeldpas-ha: shardy you think it's ok to have 2 engine workers?12:54
*** KarolynChambers has joined #heat12:54
asalkeld(to speed things up)12:54
asalkeldlets see if the tests pass12:54
pas-hayes, exactly12:54
*** blomquisg has quit IRC12:54
asalkeldok with that i am off to bed12:55
asalkeldnight all12:55
*** asalkeld has quit IRC12:55
*** KarolynChambers has quit IRC12:55
*** KarolynChambers has joined #heat12:56
*** sarob has quit IRC12:56
*** GonZo2K has joined #heat12:57
*** nkhare has quit IRC12:58
*** GonZo2K has quit IRC12:58
*** inc0_ has quit IRC12:59
*** KarolynChambers has quit IRC13:00
*** hdd has joined #heat13:00
*** nkhare has joined #heat13:02
*** boris-42 has quit IRC13:02
*** KarolynChambers has joined #heat13:02
*** hdd has quit IRC13:04
*** KarolynChambers has quit IRC13:04
*** radez_g0n3 is now known as radez13:06
*** KanagarajM has quit IRC13:07
*** aweiteka has joined #heat13:08
*** KarolynChambers has joined #heat13:08
*** rakesh_hs has joined #heat13:08
*** blomquisg has joined #heat13:09
*** KarolynChambers has quit IRC13:11
*** KarolynChambers has joined #heat13:12
*** KarolynChambers has quit IRC13:13
*** rakesh_hs has quit IRC13:14
*** KarolynChambers has joined #heat13:15
*** rakesh_hs has joined #heat13:16
*** KarolynChambers has quit IRC13:19
*** dmn_ has quit IRC13:19
*** kaufer has joined #heat13:20
*** KarolynChambers has joined #heat13:21
*** vijayagurug has joined #heat13:21
openstackgerritMerged openstack/heat: StackResource convert operations to use RPC  https://review.openstack.org/11633613:24
shardy\o/13:26
*** KarolynChambers has quit IRC13:29
*** KarolynChambers has joined #heat13:31
*** hdd has joined #heat13:32
*** alexpilotti has quit IRC13:35
*** KarolynChambers has quit IRC13:38
*** jistr|biab is now known as jistr13:39
*** KarolynChambers has joined #heat13:39
*** boris-42 has joined #heat13:41
*** rakesh_hs has quit IRC13:41
*** KarolynChambers has quit IRC13:43
*** nzrf has left #heat13:43
*** jmckind has joined #heat13:43
*** KarolynChambers has joined #heat13:43
*** cdent has quit IRC13:47
*** ishant has quit IRC13:48
*** dulek has joined #heat13:49
*** cdent has joined #heat13:49
*** rakesh_hs has joined #heat13:50
*** pm90_ has joined #heat13:52
*** sarob has joined #heat13:52
*** nkhare has quit IRC13:53
*** pm90_ has quit IRC13:53
*** blues-man has joined #heat13:54
*** pm90_ has joined #heat13:54
*** rakesh_hs has quit IRC13:56
*** InblEric has joined #heat13:57
*** sarob has quit IRC13:57
*** vishalcdac07 has quit IRC13:58
*** dulek has quit IRC13:59
*** sabeen1 has joined #heat13:59
*** dulek has joined #heat14:00
*** blues-man has quit IRC14:00
*** blues-man has joined #heat14:00
*** aweiteka has quit IRC14:01
*** alexpilotti has joined #heat14:03
*** kaufer1 has joined #heat14:08
*** kaufer has quit IRC14:09
*** inc0 has joined #heat14:11
*** kaufer1 has quit IRC14:13
*** alexpilotti has quit IRC14:14
*** alexpilotti has joined #heat14:15
*** kaufer has joined #heat14:15
*** aweiteka has joined #heat14:16
*** InblEric1 has joined #heat14:20
*** InblEric has quit IRC14:23
*** jmckind has quit IRC14:27
*** kaufer has quit IRC14:27
*** kaufer has joined #heat14:28
*** inc0 has quit IRC14:28
pas-hanope, 2 engine workers did not help - test run timed out14:29
Qiming_shardy, there?14:30
*** jmckind has joined #heat14:31
Qiming_anyone has seen this before? heat-api cannot start ->  CRITICAL heat-api [-] DuplicateOptError: duplicate option: admin_user14:32
*** Qiming_ has quit IRC14:32
*** pitr-ch has joined #heat14:33
*** Qiming_ has joined #heat14:33
pas-hano, I was wrong, the error is genuinely related to multiple engines http://logs.openstack.org/96/165396/1/check/check-heat-dsvm-functional-mysql/cbd0edd/console.html#_2015-03-18_13_54_23_63814:33
*** InblEric1 has quit IRC14:35
*** kebray has joined #heat14:35
*** lkarm has joined #heat14:35
*** InblEric has joined #heat14:35
*** jprovazn has quit IRC14:38
*** rakesh_hs_ has joined #heat14:38
*** vijendar has joined #heat14:40
*** jprovazn has joined #heat14:41
*** tiantian has quit IRC14:45
*** achanda has joined #heat14:47
DragoQiming_: randallburt was seeing that yesterday and he probably solved it. He'll be on in a couple of hours. I know I've seen it before but can't remember why it happens14:48
Qiming_thanks, Drago14:49
*** Qiming_ is now known as Qiming14:49
*** achanda has quit IRC14:52
*** sarob has joined #heat14:53
*** InblEric1 has joined #heat14:55
*** InblEric has quit IRC14:56
*** sarob has quit IRC14:58
*** reed has joined #heat14:59
*** Raj2 has joined #heat15:04
*** Raj2 has quit IRC15:04
*** Raj2 has joined #heat15:05
*** kebray has quit IRC15:06
*** rakesh_hs_ has quit IRC15:07
*** rakesh_hs_ has joined #heat15:07
*** Marga_ has joined #heat15:07
*** ParsectiX has quit IRC15:10
*** Trozz has quit IRC15:10
*** Trozz has joined #heat15:11
*** InblEric has joined #heat15:11
*** jaypipes has quit IRC15:12
*** InblEric1 has quit IRC15:13
*** hdd has quit IRC15:14
*** vijayagurug has left #heat15:21
*** Raj2 has quit IRC15:24
*** Raj2 has joined #heat15:24
*** pitr-ch has quit IRC15:26
shardyQiming: I've seen that before, I think I fixed it by removing all my stale oslo stuff (probably oslo.config in this case) and reinstalling oslo.config from pip15:32
shardyheat ends up picking up an old installed-from-git version instead of the pip version15:33
Qimingshardy, thanks, will give it a try15:34
*** pitr-ch has joined #heat15:34
*** Tango has joined #heat15:37
Qimingnight all15:37
*** Qiming has quit IRC15:38
shadowershardy: okay, the state stuff is indeed quite complicated15:39
*** kebray has joined #heat15:39
*** LiJiansheng has quit IRC15:40
*** packet has joined #heat15:41
*** dulek has quit IRC15:44
*** rakesh_hs_ has quit IRC15:45
*** dulek has joined #heat15:47
*** Raj2 has quit IRC15:47
*** Raj2 has joined #heat15:48
*** spzala has quit IRC15:49
*** sdake_ has quit IRC15:51
*** sdake has joined #heat15:52
*** sarob has joined #heat15:55
*** hdd has joined #heat15:55
*** blues-man has left #heat15:56
*** thedodd has joined #heat15:59
*** pm90_ has quit IRC16:00
*** dulek has quit IRC16:00
*** sarob has quit IRC16:00
*** InblEric1 has joined #heat16:06
*** kebray has quit IRC16:06
*** kebray has joined #heat16:07
*** InblEric has quit IRC16:09
*** spzala has joined #heat16:15
*** jtomasek has quit IRC16:18
*** sorantis has quit IRC16:23
*** BManojlovic has quit IRC16:24
*** KanagarajM has joined #heat16:25
*** smc7 has joined #heat16:35
*** Marga_ has quit IRC16:42
*** Marga_ has joined #heat16:43
*** Raj2 has quit IRC16:50
*** Raj1 has joined #heat16:52
*** KanagarajM has quit IRC16:53
*** kebray has quit IRC16:55
*** sarob has joined #heat16:56
*** pitr-ch has quit IRC16:58
*** openstackgerrit has quit IRC16:59
*** openstackgerrit has joined #heat16:59
*** sarob has quit IRC17:01
*** pm90_ has joined #heat17:01
*** alexpilotti has quit IRC17:02
*** alexpilotti_ has joined #heat17:02
*** achanda has joined #heat17:04
*** Raj1 has quit IRC17:07
*** jistr has quit IRC17:08
*** InblEric has joined #heat17:11
*** InblEric1 has quit IRC17:13
*** randallburt has joined #heat17:19
*** randallburt has quit IRC17:21
*** randallburt has joined #heat17:21
*** harlowja_away is now known as harlowja_17:27
*** Marga_ has quit IRC17:28
*** pm90_ has quit IRC17:29
*** pm90_ has joined #heat17:29
*** sdake_ has joined #heat17:31
*** sdake has quit IRC17:35
*** pitr-ch has joined #heat17:35
*** InblEric1 has joined #heat17:36
*** rdo has joined #heat17:38
*** InblEric has quit IRC17:39
*** rakesh_hs has joined #heat17:39
*** coolsvap is now known as coolsvap|afk17:41
*** ParsectiX has joined #heat17:49
*** derekh has quit IRC17:49
pas-hag'night all17:54
*** pas-ha has quit IRC17:55
*** sarob has joined #heat17:57
lkarmrandallburt: drago mentioned that you were seeing this error -- heat-api cannot start ->  CRITICAL heat-api [-] DuplicateOptError: duplicate option: admin_user18:00
lkarmdid you figure out what was happening ?18:00
randallburtlkarm:  sort of, it was a duplicate config option registered in the authtoken middleware and something else that escapes me atm18:01
*** sarob has quit IRC18:02
*** jcoufal has quit IRC18:02
*** kebray has joined #heat18:02
*** sdake has joined #heat18:04
lkarmrandallburt: so you dont remember how to fix it?18:06
randallburtlkarm:  not really. though you can search for that configuration option and see where its registered.18:07
*** sdake_ has quit IRC18:07
*** ParsectiX has quit IRC18:07
*** ParsectiX has joined #heat18:08
shardylkarm: you probably have a stale version of either python-keystoneclient, keystonemiddleware or both18:08
shardysimilar errors also happen if you upgrade heat with stale versions of oslo libraries around18:09
shardythe solution is to figure out which library the error relates to, completely remove all old versions, then reinstall the required versions via pip18:09
lkarmokay thanks, i already tried cleaning up stale olso but not with keystoneclient or keystonemiddleware. let me try that18:10
randallburtlkarm:  found it again I think, though I doubt its the same. Its registered in the keystone authtoken middleware and also in the keystone v2 auth plugin18:10
randallburtlkarm:  whoops, ignore my last, that is wrong18:11
*** Marga_ has joined #heat18:12
openstackgerritRakesh H S proposed openstack/heat: Convergence prepare traversal  https://review.openstack.org/15944418:15
*** hdd has quit IRC18:16
*** Raj1 has joined #heat18:22
*** Raj1 has quit IRC18:23
*** Raj1 has joined #heat18:23
*** blomquisg has quit IRC18:25
*** hdd has joined #heat18:28
*** kebray has quit IRC18:29
*** smc7 has quit IRC18:31
*** hdd has quit IRC18:33
*** achanda has quit IRC18:48
*** kebray has joined #heat18:50
*** Marga_ has quit IRC18:51
*** Marga_ has joined #heat18:53
*** jprovazn has quit IRC18:57
*** sarob has joined #heat18:58
*** achanda has joined #heat19:01
*** sarob has quit IRC19:03
*** alexpilotti_ has quit IRC19:04
*** Marga_ has quit IRC19:04
*** Marga_ has joined #heat19:05
*** liusheng has quit IRC19:05
*** liusheng has joined #heat19:06
*** dsneddon is now known as dsneddon_lunch19:12
*** Tango|2 has joined #heat19:13
*** lkarm1 has joined #heat19:14
*** Tango has quit IRC19:16
*** lkarm has quit IRC19:16
*** rakesh_hs has quit IRC19:21
*** blomquisg has joined #heat19:23
*** spzala has quit IRC19:24
*** smc7 has joined #heat19:28
openstackgerritRakesh H S proposed openstack/heat: Hard delete backup stack after successful update.  https://review.openstack.org/12891819:28
*** dsneddon_lunch is now known as dsneddon19:29
*** boris-42 has quit IRC19:37
*** stevebaker has quit IRC19:39
*** stevebaker has joined #heat19:40
*** boris-42 has joined #heat19:42
*** Marga_ has quit IRC19:43
*** Marga_ has joined #heat19:44
*** blomquisg has quit IRC19:51
*** sdake_ has joined #heat19:52
*** Marga_ has quit IRC19:54
*** pitr-ch has quit IRC19:54
*** zigo__ has joined #heat19:56
*** zigo has quit IRC19:56
*** sdake has quit IRC19:56
*** sarob has joined #heat19:59
*** achanda has quit IRC20:00
*** jruano has joined #heat20:01
*** ifarkas has quit IRC20:01
openstackgerritTon Ngo proposed openstack/heat: Reuse existing template  https://review.openstack.org/15462020:02
openstackgerritTon Ngo proposed openstack/heat: Reuse existing registry  https://review.openstack.org/15461920:02
openstackgerritTon Ngo proposed openstack/heat: Handle parameter overriding in an environment  https://review.openstack.org/15461820:02
*** InblEric has joined #heat20:03
*** InblEric1 has quit IRC20:03
*** sarob has quit IRC20:04
*** kebray has quit IRC20:11
*** spzala has joined #heat20:12
*** Raj1 has quit IRC20:12
*** openstackgerrit has quit IRC20:14
*** openstackgerrit has joined #heat20:15
*** kebray has joined #heat20:18
*** Marga_ has joined #heat20:21
*** Raj1 has joined #heat20:22
openstackgerritRandall Burt proposed openstack/heat: Ignore migrating environments for deleted stacks  https://review.openstack.org/16485620:31
*** kebray has quit IRC20:31
*** InblEric has quit IRC20:33
*** KarolynChambers has quit IRC20:33
*** Raj2 has joined #heat20:34
*** KarolynChambers has joined #heat20:34
*** kebray has joined #heat20:35
*** InblEric has joined #heat20:36
*** Raj1 has quit IRC20:36
*** pm90_ has quit IRC20:36
*** radez is now known as radez_g0n320:38
*** Raj2 has quit IRC20:39
*** Raj1 has joined #heat20:39
*** elynn has quit IRC20:40
*** elynn has joined #heat20:40
*** pm90_ has joined #heat20:43
*** InblEric1 has joined #heat20:44
openstackgerritSteve Baker proposed openstack/heat: Func tests use fedora-heat-test-image  https://review.openstack.org/16328720:45
openstackgerritSteve Baker proposed openstack/heat: WIP Enable software config integration test  https://review.openstack.org/16528720:45
openstackgerritSteve Baker proposed openstack/heat: iniset heat_integrationtests.conf  https://review.openstack.org/16528620:45
*** InblEric has quit IRC20:47
*** achanda has joined #heat20:48
*** blomquisg has joined #heat20:49
*** sdake has joined #heat20:52
*** ParsectiX has quit IRC20:52
*** ParsectiX has joined #heat20:53
*** sdake_ has quit IRC20:56
*** alexpilotti has joined #heat20:56
*** sarob has joined #heat21:00
*** InblEric has joined #heat21:02
*** InblEric has quit IRC21:02
*** InblEric1 has quit IRC21:04
*** hdd has joined #heat21:05
*** sarob has quit IRC21:05
*** InblEric has joined #heat21:11
*** InblEric1 has joined #heat21:15
*** InblEric has quit IRC21:18
*** hdd has quit IRC21:19
*** aweiteka has quit IRC21:20
*** ParsectiX has quit IRC21:21
*** ParsectiX has joined #heat21:21
*** pm90_ has quit IRC21:22
*** __TheDodd__ has joined #heat21:27
*** thedodd has quit IRC21:28
*** jruano has quit IRC21:30
*** jamielennox is now known as jamielennox|away21:31
*** kaufer has quit IRC21:35
*** ParsectiX has quit IRC21:38
*** ParsectiX has joined #heat21:38
*** Marga_ has quit IRC21:39
*** Marga_ has joined #heat21:40
*** Marga_ has quit IRC21:40
*** Marga_ has joined #heat21:40
openstackgerritSteven Hardy proposed openstack/heat: Persist initialized resources to DB on create  https://review.openstack.org/16465121:42
openstackgerritSteven Hardy proposed openstack/heat: Remove _store from stack_resource  https://review.openstack.org/16562221:42
openstackgerritSteven Hardy proposed openstack/heat: Refactor Resource store logic  https://review.openstack.org/16562321:42
openstackgerritSteven Hardy proposed openstack/heat: Resource persist state_reset to DB  https://review.openstack.org/16562421:42
*** Raj1 has quit IRC21:43
*** randallburt has quit IRC21:43
*** pm90_ has joined #heat21:44
*** pm90_ has quit IRC21:44
*** pm90_ has joined #heat21:45
shardyzaneb: If you're still about, I'm giving up for today and I've not made a lot of progress on https://review.openstack.org/#/c/164651/21:46
*** InblEric1 has quit IRC21:46
shardyI've so far failed to find a way to persist resources pre-create without breaking loads of tests in exciting ways and/or breaking functionality21:46
*** lkarm1 has left #heat21:46
shardyIf anyone fancies taking a crack at it, feel free :)21:47
*** InblEric has joined #heat21:48
zanebshardy: so what have you discovered so far?21:48
shadowerI'm about to hit the sack, will look at it tomorrow21:48
*** hdd has joined #heat21:49
zanebI can try to maybe make some progress tonight21:49
*** ParsectiX has quit IRC21:49
*** spzala has quit IRC21:50
*** spzala has joined #heat21:50
*** InblEric1 has joined #heat21:53
*** GonZo2K has joined #heat21:55
shardyzaneb: So, I think the patches I posted there work around the metadata issue, by storing the right thing when we move to CREATE_IN_PROGRESS21:56
*** InblEric has quit IRC21:56
zanebok21:56
zanebbut the world is still broken?21:56
shardyBut then I got stuck here:21:56
shardyhttps://github.com/openstack/heat/blob/master/heat/tests/test_volume_utils.py#L7421:57
*** InblEric1 has quit IRC21:57
shardythe resource_id gets set in the Volume persisted in the DB, then the test creates a new volume without loading it from the DB21:58
shardythat's one of quite a few test failures21:58
*** sarob has joined #heat21:58
zanebwhere does the volume get persisted in that example?21:59
*** asalkeld has joined #heat21:59
shardyzaneb: basically a bunch of stuff is returning name from FnGetRefId, whereas without the store() loop in stack.Stack.store we get the resource ID (which the stubs expect)22:00
zanebah22:00
shardyzaneb: it gets persisted via the stk.store() in tests.utils.parse_stack22:01
shardywhich, with the loop I added, saves all the resources22:01
zanebhmm, what if we were to persist the resources when we call stk.create()?22:01
zaneb(that's what convergence needs anyway)22:02
shardyah, and that's still before we hit the hook, despite us not having moved to CREATE_IN_PROGRESS?22:02
*** boris-42 has quit IRC22:02
zanebI believe so, yes22:02
shardyCool, yeah maybe that will work better22:03
zanebok, I can try that out22:03
shardysome fresh eyes on this may well yield a simpler approach :)22:03
zanebwere most of the problems in the unit tests?22:03
zanebi.e. if I get something passing the unit tests locally is it likely to be good, or are there a bunch more failures in the functional tests awaiting?22:04
shardyheat_integrationtests/functional/test_autoscaling.py was failing, but that was initially due to the metadata problem, which should be solved by the reworked _store_or_update22:04
*** jmckind has quit IRC22:05
shardyzaneb: I'd guess getting the unit tests passing will be a good start :)22:05
zanebheh, ok ;)22:05
shardybut the test_autoscaling.py may still hold some further excitement22:05
shardyin particular I was seeing problems with the InstanceGroup memebers not getting persisted, despite the stack.store persisting all resources22:06
shardyHmm, running test_autoscaling.py on my latest patch series looks OK actually22:06
shardy\o/22:07
shardyAt least my day hasn't been completely wasted ;)22:07
zanebhow are you handling storing new resources on stack update?22:07
*** Raj1 has joined #heat22:08
shardyzaneb: Hmm, I'm not handling it explicitly atm, but won't they get stored as soon as they make a state transistion during the update?22:09
shardye.g via state_set?22:09
zanebshould do, yeah22:09
zanebI was just curious because it's different behaviour between create vs. update22:10
shardythe problem I started out trying to solve was sending a signal to a resource before it goes from INIT_COMPLETE to CREATE_IN_PROGRESS22:10
shardyIf you set a hook on update, must the resource already exist?22:10
shardyor is it valid to set a hook on something which is only getting added via the update?22:11
zanebnot necessarily22:11
*** sabeen1 has quit IRC22:11
shardyIf so then that's probably missing too, unless we can handle it via persisting the INIT_COMPLETE before we start creating it, like on create22:11
zanebjust realised that when I was looking at the error logs yesterday, I was actually looking at the Tempest one instead of the functional test22:11
zanebtesttools.matchers._impl.MismatchError: 'state changed' != u'Resource initialized'22:12
shardyI've just ben running nosetests -svx heat_integrationtests/functional/test_autoscaling.py to run the test against my devstack heat22:12
zanebhope we don't have to change tempest to get around that :/22:12
shardyugh22:12
*** jamielennox|away is now known as jamielennox22:12
*** Raj1 has quit IRC22:13
zanebin test_show_event22:13
shardywell we don't currently expose INIT_COMPLETE as a state at all via the API, so I'm not sure how that breaks tempest22:13
zanebso maybe we just need to suppress creating an event for INIT22:13
*** crose has quit IRC22:14
zanebpossibly your latest patch series already does that22:14
*** Raj1 has joined #heat22:14
shardyNo, I deliberately generate one, because bug #1319813 asks for an event22:14
openstackbug 1319813 in heat "no event recorded for INIT_* resources" [Medium,In progress] https://launchpad.net/bugs/1319813 - Assigned to Steven Hardy (shardy)22:14
shardywe don't have to do that though, for breakpoints/hooks all we need is to make signalling the resource while it's pending create possible22:15
zanebbecause the reporter didn't know what he was talking about ;)22:15
shardyheh22:15
shardyOh wait, actually I did remove it in this version:22:16
shardyhttps://review.openstack.org/#/c/164651/3/heat/engine/resource.py22:16
* shardy is getting tired22:16
shardyI made store() just save the current state, and moved all the state-dependent logic to store_or_update22:16
shardyso no event22:17
zanebcool, hopefully that tempest failure will go away then22:17
shardyOk, cool, well I'm going to head to bed, any help much appreciated22:18
zanebcool, thanks for the update22:18
shardyfeel free to push to my patches, or do something completely different if you have a better idea :)22:18
shardyI can pick things up again in the morning as needed22:19
zanebI'll see what I can do before I fall asleep at the keyboard ;)22:19
*** packet has quit IRC22:19
shardyawesome, thanks very much22:19
*** vijendar has quit IRC22:20
*** shardy is now known as shardy_z22:20
*** Drago has quit IRC22:24
*** Marga_ has quit IRC22:36
stevebakerthis command is hypnotic when running integration tests locally22:37
stevebakerwatch heat resource-list -n 5 `heat stack-list -l 1 | cut -d' ' -f4 | tail -2 | head -1`22:37
stevebaker|| true22:45
*** Marga_ has joined #heat22:47
asalkeldzaneb: is the hook bp really important to tripleO? if so we should mark it higher priority and get a FFE22:54
asalkeldatm it is low priority22:55
stevebakerdefn high priority for tripleo22:55
asalkeldok, set to high22:57
*** kebray has quit IRC23:21
*** mburns has quit IRC23:29
*** Raj1 has quit IRC23:29
*** dims__ has joined #heat23:29
*** boris-42 has joined #heat23:30
*** mburns has joined #heat23:30
*** dims_ has quit IRC23:33
*** pm90_ has quit IRC23:34
*** hdd has quit IRC23:37
*** smc7 has quit IRC23:40
*** jrist has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!