Tuesday, 2014-02-18

*** arbylee has quit IRC00:05
*** edmund has quit IRC00:08
*** kebray_ has joined #heat00:14
openstackgerritTon Ngo proposed a change to openstack/heat: Add Heat engine support for troubleshooting failed stack  https://review.openstack.org/7395200:14
*** kebray_ has quit IRC00:15
*** kebray_ has joined #heat00:15
*** kebray_ has joined #heat00:18
openstackgerritSteve Baker proposed a change to openstack/heat: RPC method to fetch deployments metadata  https://review.openstack.org/7420200:18
openstackgerritSteve Baker proposed a change to openstack/heat: REST deployment metadata method  https://review.openstack.org/7420300:18
openstackgerritSteve Baker proposed a change to openstack/heat: REST API for software deployment  https://review.openstack.org/7259100:18
openstackgerritTon Ngo proposed a change to openstack/heat: Add API suppport for troubleshooting failed stack  https://review.openstack.org/7136700:20
openstackgerritSteve Baker proposed a change to openstack/heat: SignalResponder move signed URL deleting to its own method  https://review.openstack.org/7420500:24
openstackgerritSteve Baker proposed a change to openstack/heat: Resource type implementation for structured software config  https://review.openstack.org/7420600:24
openstackgerritSteve Baker proposed a change to openstack/heat: OS::Nova::Server support for software config  https://review.openstack.org/6762500:24
openstackgerritSteve Baker proposed a change to openstack/heat: Resource type implementation for software deployment  https://review.openstack.org/6762400:24
openstackgerritSteve Baker proposed a change to openstack/heat: Nova server to ref cloud-config resources in user_data  https://review.openstack.org/6923800:25
*** zigo has quit IRC00:25
*** zigo has joined #heat00:26
*** kebray_ has quit IRC00:27
*** matsuhashi has joined #heat00:28
*** edmund has joined #heat00:39
*** zigo has quit IRC00:42
*** blomquisg has quit IRC00:48
*** topol has joined #heat00:56
*** arbylee has joined #heat00:57
*** zigo has joined #heat00:59
*** zigo has quit IRC01:08
*** zigo has joined #heat01:13
kebraystevebaker you around by chance?01:16
stevebakerkebray: indeed I am01:16
asalkeldkiwi version of kebray is keybro :-)01:17
kebrayI'm curious the expected outcome from conversation you may (hopefully) have had with Randall today... about, getting python-heatclient updated in pypi.  I don't know what's involved with that... and, what the plans are, so thought I'd ask.01:17
* asalkeld lets stevebaker explain kiwi'isms01:17
kebraykiwi, the fruit :-)  ??01:18
asalkeldkiwi = new zealander01:18
stevebakerkebray: I want to cut a release as soon as this is in https://review.openstack.org/#/c/74159/01:18
stevebakerkebray: which will let me put together instructions for actually trying out software-config01:19
*** lindsayk has quit IRC01:19
kebrayoh cool.01:20
*** zigo has quit IRC01:20
*** randallburt has quit IRC01:20
kebraywhat's the overhead in cutting two separate releases, one now and one later.. a lot?01:20
kebrayreason I'm asking is, I view it as a security concern to have people connecting to the heat service by passing -k.. and, that's the experience for MAC users right now.01:21
stevebakerkebray: its very quick, but I would like to get this one change in01:22
*** zigo has joined #heat01:22
kebrayI don't enjoy telling folks, yeah, don't worry about a secure connection.01:22
stevebakerkebray: and I expect there will be frequent heatclient releases in the lead-up to juno01:22
stevebakerkebray: well if you know anyone who can do reviews then please help ;)01:22
asalkeldwhich ones?01:23
kebraystevebaker sounds like the reviews is a nice-to-have.. overhead on the cutting the release without 74159 landing is low :-)  So, can I appeal to your do-me-favor side? :-)01:23
asalkeldwowzerers we have a lot of reviews on heatclient01:24
stevebakerasalkeld: yes, that is the delay on releasing - not enough reviews01:26
*** zigo has quit IRC01:27
stevebakerkebray: putting together the release notes takes the longest, I'll start pulling them together now01:27
kebraythanks stevebaker ... I'll ask my team to review 74159 at tomorrow's team huddle... but, hopefully that won't gate the pypi release of python-heatclient.01:28
*** zigo has joined #heat01:28
asalkeldlol everyone is trying to add py3 support01:28
asalkeld(easy commits?)01:28
stevebakerclients are more likely to be run in a py3 environment01:29
*** nosnos has joined #heat01:33
*** zhiyan_ is now known as zhiyan01:35
asalkeldok, I have done a bunch of reviews01:36
asalkeldphew01:36
* asalkeld heads back to solum land01:37
stevebakerasalkeld: thanks for dropping by01:37
asalkeld:-)01:37
asalkeldany time01:37
asalkeldjust ping if you need a review01:37
stevebakerasalkeld: OK, https://review.openstack.org/#/c/72591/ :)01:39
radixnooo01:39
radixapproved-rebase :(01:39
stevebakerradix: hmph?01:40
asalkeldyou could have used this a chance to use wsme01:40
asalkeldhe got approved, but needs a rebase01:40
radixyeah :P heh01:40
asalkeldYEA ... no01:40
radixoh right, therve's change got merged01:41
asalkeldso stevebaker /tenant_id/...01:42
stevebakerasalkeld: yes01:42
asalkeldstarting with a broke api;)01:42
asalkeldconsistent, but broke?01:42
stevebakerasalkeld: /software_configs is already merged, so that ship has sailed ;)01:42
asalkeldstevebaker, you can't update the signal_id?01:44
openstackgerritChristopher Armstrong proposed a change to openstack/heat: Replace hardcoded schema strings in autoscaling.py  https://review.openstack.org/7388501:45
*** pvaneck has quit IRC01:45
stevebakerasalkeld: its stored as resource data once its created, so how could you change it even if you wanted to?01:45
asalkeldthis is and api, it doen't care about that detail (the user's limitations)01:46
asalkeldis an01:46
stevebakerasalkeld: there is no fundamental reason why you couldn't update a signal_id, except that I haven't thought of a use for that yet01:47
asalkeldwell if you update the signal?01:47
asalkeldand you have to update the deployment because of it?01:47
stevebakeryes, that is conceivable01:47
asalkeldno biggie, you can add later01:47
openstackgerritChristopher Armstrong proposed a change to openstack/heat: Replace hardcoded schema strings in autoscaling.py  https://review.openstack.org/7388501:48
radixsigh01:49
*** alexheneveld has quit IRC01:50
radixI keep confusing myself01:50
*** zigo has quit IRC01:51
asalkeldradix, you must be smart to do that;)01:51
openstackgerritChristopher Armstrong proposed a change to openstack/heat: Replace hardcoded schema strings in autoscaling.py  https://review.openstack.org/7388501:52
radix(sorry jenkins)01:52
asalkeldgroan, I just re-approved that01:52
*** zigo has joined #heat01:53
radixI messed up a NUMBER/INTEGER thing in the rebase :(01:54
radixI was trying to *not* make any additional changes... and then I did01:54
radixI don't think zuul picked up on the earlier approval anyway01:55
openstackgerritChristopher Armstrong proposed a change to openstack/heat: de-hardcode adjustment type strings in autoscaling  https://review.openstack.org/7388701:56
radixok, and there's the second one rebased on the first01:56
radixI need to grab some food, but I'll be right back to submit my AutoScalingResourceGroup, I was about to upload it until I noticed those rebase failures01:57
openstackgerritJia Dong proposed a change to openstack/heat: Replace assertEqual(None, *) with assertIsNone in tests  https://review.openstack.org/7377301:59
openstackgerritA change was merged to openstack/heat: Native Nova Server compatibility for Cloud Server  https://review.openstack.org/5804302:03
*** zigo has quit IRC02:04
*** zigo has joined #heat02:06
openstackgerritA change was merged to openstack/heat: Refactor resource loading functions  https://review.openstack.org/7198902:07
openstackgerritA change was merged to openstack/heat: Remove spurious tracebacks from tests, part 2  https://review.openstack.org/7416102:07
openstackgerritA change was merged to openstack/heat: Display max_template_size when a template is too large  https://review.openstack.org/7337302:07
openstackgerritA change was merged to openstack/heat: Add engine preview stack with Template and Params  https://review.openstack.org/6557602:07
*** fandi has joined #heat02:07
openstackgerritA change was merged to openstack/heat: Add API support for stack preview  https://review.openstack.org/6840602:07
radixOK, back02:19
*** spzala has quit IRC02:20
*** liang has joined #heat02:24
*** faramir1 has joined #heat02:26
*** faramir1 has quit IRC02:27
openstackgerritChristopher Armstrong proposed a change to openstack/heat: add OS::Heat::AutoScalingResourceGroup  https://review.openstack.org/7422902:33
radixoh, and of course, there's a bug in the commit message ;-)02:33
openstackgerritChristopher Armstrong proposed a change to openstack/heat: add OS::Heat::AutoScalingGroup  https://review.openstack.org/7422902:33
*** erkules_ has joined #heat02:34
*** zigo has quit IRC02:35
*** pablosan has quit IRC02:36
*** pablosan has joined #heat02:37
*** erkules has quit IRC02:37
*** zigo has joined #heat02:48
*** arbylee has quit IRC02:49
*** killer_prince has quit IRC02:55
*** killer_prince has joined #heat02:59
openstackgerritA change was merged to openstack/heat: RandomString use the random string as the resource_id  https://review.openstack.org/7338803:02
openstackgerritA change was merged to openstack/python-heatclient: Make POST/PUT redirects use original methods  https://review.openstack.org/7356703:04
*** tteggel has quit IRC03:09
openstackgerritA change was merged to openstack/heat: Don't disable SELinux in cloud-init's boothook.sh  https://review.openstack.org/7366903:09
openstackgerritA change was merged to openstack/heat: REST API for software deployment  https://review.openstack.org/7259103:09
*** arbylee has joined #heat03:10
*** tteggel has joined #heat03:10
openstackgerritA change was merged to openstack/heat-cfntools: Log stdout and stderr on non-zero exit status  https://review.openstack.org/7295303:15
*** matsuhashi has quit IRC03:23
openstackgerritSteven Dake proposed a change to openstack/heat: Use olso.messaging  https://review.openstack.org/7279803:26
sdakedown to 18 test failures03:26
sdakefrom 15003:26
sdaketime for bed03:26
*** lifeless has quit IRC03:29
*** lifeless has joined #heat03:31
*** fandi has quit IRC03:41
openstackgerritSteve Baker proposed a change to openstack/heat-templates: Software config hook to provision using shell scripts  https://review.openstack.org/7029703:43
openstackgerritSteve Baker proposed a change to openstack/heat-templates: Software config hook to provision using puppet  https://review.openstack.org/7063903:43
openstackgerritSteve Baker proposed a change to openstack/heat-templates: An example template demonstrating cloud-init config resources  https://review.openstack.org/6854903:43
openstackgerritA change was merged to openstack/heat: Replace hardcoded schema strings in autoscaling.py  https://review.openstack.org/7388503:53
*** sballe has quit IRC03:55
*** sballe has joined #heat03:55
*** fandi has joined #heat03:55
*** david-lyle has quit IRC04:00
*** gokrokve has quit IRC04:01
*** gokrokve has joined #heat04:01
*** gokrokve has quit IRC04:01
*** gokrokve has joined #heat04:02
*** gokrokve has quit IRC04:02
*** gokrokve has joined #heat04:02
*** david-lyle has joined #heat04:04
*** gokrokve has quit IRC04:07
*** arbylee has quit IRC04:09
*** ramishra has joined #heat04:16
openstackgerritVictor Howard proposed a change to openstack/heat: run_tests.sh default doc omits pep8  https://review.openstack.org/7425704:17
*** ramishra_ has joined #heat04:18
ramishra_stevebaker: Hi04:19
* radix -> bed04:21
*** nkhare has joined #heat04:21
*** ramishra_ has quit IRC04:21
*** ramishra has quit IRC04:23
*** arbylee has joined #heat04:30
*** gokrokve has joined #heat04:33
*** gokrokve_ has joined #heat04:35
*** rpothier has joined #heat04:35
*** akuznetsov has joined #heat04:37
*** gokrokve has quit IRC04:37
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Add StackResource specific preview behavior  https://review.openstack.org/6840704:38
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Add preview for LoadBalancer  https://review.openstack.org/6841204:38
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Add preview for NestedStack  https://review.openstack.org/6840804:38
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Add preview for ResourceGroup  https://review.openstack.org/6840904:38
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Add preview for InstanceGroup  https://review.openstack.org/6841004:38
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Add preview for TemplateResource  https://review.openstack.org/6841104:38
*** gokrokve_ has quit IRC04:40
*** matsuhashi has joined #heat04:43
*** arbylee has quit IRC04:43
*** akuznetsov has quit IRC04:44
*** zhiyan has quit IRC04:46
*** akuznetsov has joined #heat04:49
*** arbylee has joined #heat04:51
*** skraynev_afk is now known as skraynev04:51
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Make Keystone client pluggable  https://review.openstack.org/7419004:51
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Add Keystone V2 plugin  https://review.openstack.org/7419104:51
skraynevmorning04:51
*** gokrokve has joined #heat04:52
*** zhiyan has joined #heat04:52
*** akuznetsov has quit IRC04:53
*** akuznetsov has joined #heat04:53
*** akuznetsov has quit IRC04:53
*** gokrokve has quit IRC04:56
*** arbylee has quit IRC04:56
*** akuznetsov has joined #heat04:59
*** arbylee has joined #heat04:59
*** matsuhashi has quit IRC05:09
*** matsuhashi has joined #heat05:09
*** matsuhashi has quit IRC05:10
*** matsuhashi has joined #heat05:10
*** arbylee has quit IRC05:10
*** akuznetsov has quit IRC05:18
*** chandan_kumar has joined #heat05:20
openstackgerritVictor Howard proposed a change to openstack/heat: run_tests.sh default doc omits pep8  https://review.openstack.org/7425705:23
*** akuznetsov has joined #heat05:25
*** gokrokve has joined #heat05:27
*** ramishra has joined #heat05:32
*** nosnos has quit IRC05:33
*** nosnos has joined #heat05:34
*** matsuhashi has quit IRC05:36
*** matsuhashi has joined #heat05:37
*** akuznetsov has quit IRC05:38
*** matsuhas_ has joined #heat05:38
*** matsuhashi has quit IRC05:39
*** gokrokve has quit IRC05:41
*** gokrokve has joined #heat05:41
*** gokrokve_ has joined #heat05:42
*** akuznetsov has joined #heat05:43
*** gokrokve has quit IRC05:46
openstackgerritMitsuru Kanabuchi proposed a change to openstack/heat: Implements resource type NetworkGateway  https://review.openstack.org/6228705:46
*** lazzurs has quit IRC05:46
*** akuznetsov has quit IRC05:47
*** lazzurs has joined #heat05:47
*** aignatov_ is now known as aignatov05:59
*** akuznetsov has joined #heat06:03
openstackgerritJenkins proposed a change to openstack/heat: Imported Translations from Transifex  https://review.openstack.org/7256606:07
*** nosnos_ has joined #heat06:10
*** nosnos has quit IRC06:10
*** akuznetsov has quit IRC06:12
*** daneyon has joined #heat06:16
*** daneyon has quit IRC06:16
*** daneyon has joined #heat06:17
*** liang has quit IRC06:17
*** liang has joined #heat06:18
*** daneyon has quit IRC06:25
*** coolsvap has joined #heat06:26
*** liang has quit IRC06:33
*** topol has quit IRC06:33
*** liang has joined #heat06:33
*** radez is now known as radez_g0n306:34
*** ifarkas has joined #heat06:42
*** akuznetsov has joined #heat06:42
*** yogesh has joined #heat06:43
*** akuznetsov has quit IRC06:47
*** saju_m has joined #heat06:48
openstackgerritJun Jie Nan proposed a change to openstack/heat: Wrapper a static method to prepare data  https://review.openstack.org/7427606:51
*** yogesh_ has joined #heat06:52
openstackgerritA change was merged to openstack/heat: Fix usage of resource_data_get_all in stack-abandon  https://review.openstack.org/7245806:52
*** yogesh has quit IRC06:54
*** aignatov is now known as aignatov_06:55
*** gokrokve_ has quit IRC06:56
*** gokrokve has joined #heat06:57
*** gokrokve has quit IRC07:01
*** jpeeler has quit IRC07:03
*** tspatzier has joined #heat07:07
*** aignatov_ is now known as aignatov07:14
*** jpeeler has joined #heat07:17
*** jpeeler has quit IRC07:17
*** jpeeler has joined #heat07:17
*** erkules_ is now known as erkules07:19
*** nosnos_ has quit IRC07:19
*** nosnos has joined #heat07:19
*** ramishra has quit IRC07:23
*** gokrokve has joined #heat07:27
*** e0ne has joined #heat07:27
*** gokrokve_ has joined #heat07:29
*** e0ne has quit IRC07:30
*** gokrokve has quit IRC07:32
*** angus_ has joined #heat07:33
angus_stevebaker, you about07:33
*** killer_prince has quit IRC07:33
angus_can you send my your latest fedora devstack localrc?07:33
*** gokrokve_ has quit IRC07:34
skraynevangus_: s/ my/ me  ?07:34
angus_lol, yeah07:34
*** gokrokve has joined #heat07:35
skraynevangus_: happens )07:35
*** nanjj has joined #heat07:36
*** gokrokve has quit IRC07:40
*** angus_ is now known as angus_on_pc07:41
*** angus_on_pc has quit IRC07:41
*** aignatov is now known as aignatov_07:43
*** jprovazn has joined #heat07:45
pshchelomorning :)07:46
nanjjasalkeld: hi07:57
asalkeldhi07:57
nanjjI got one exception when using environment yaml, say Unknown resource Type : My::WP::Server07:58
asalkeldok, err - I need more info07:59
asalkeldwhat's the env file look like and your template?08:00
nanjjhttp://paste.openstack.org/show/66794/08:00
*** tspatzier has quit IRC08:00
*** ppetit has joined #heat08:01
therveGood morning!08:03
asalkeldnanjj, the name is wrong08:04
asalkeldit should end in .template or .yaml08:04
asalkeldnot .json08:04
nanjjasalkeld: the ext name is just used for loading, right?08:07
asalkeldnanjj, can't remember all the details08:07
asalkeldheat/engine/environment.py:        if name.endswith(('.yaml', '.template'))08:08
asalkeldthere is this ^ kind of code about08:08
nanjjyes, I saw that08:09
*** ramishra has joined #heat08:12
nanjjasalkeld: thanks, it solved my problem08:13
*** TonyBurn_ has joined #heat08:20
asalkeldnp08:21
nanjjasalkeld: I may add 1 lines in environment.rst to say this08:21
*** aignatov_ is now known as aignatov08:23
asalkeldsure08:24
*** tspatzier has joined #heat08:33
*** akuznetsov has joined #heat08:33
*** tspatzier has quit IRC08:33
*** gokrokve has joined #heat08:35
openstackgerritThomas Herve proposed a change to openstack/heat: Implement glance image constraint  https://review.openstack.org/7291908:37
*** jistr has joined #heat08:38
openstackgerritThomas Herve proposed a change to openstack/heat: Add neutron network constraint  https://review.openstack.org/7397608:39
*** gokrokve has quit IRC08:40
*** cmyster has joined #heat08:42
shardymorning all08:56
*** tomek_adamczewsk has joined #heat08:56
shardytherve: FYI I got the heat resource-signal stuff working yesterday, after a couple of non-obvious problems08:56
therveshardy, Ah sweet. using your serie of patches?08:58
openstackgerritSergey Kraynev proposed a change to openstack/heat: Make OS::Nova::Server networks property updatable  https://review.openstack.org/7429908:58
shardytherve: There were two issues, one is that if you forget to update the policy.json, you get a non-obvious API error when the policy enforcement drops through to the default rule (which is to deny access)08:59
shardythe second is the routes mapper silently discards the body if it doesn't matche the expected content type08:59
shardyso heat resource-signal stack resource -D "foo" won't work09:00
shardywell the signal is handled, but the body is None09:00
shardyprobably need to enforce a json check in the client I guess09:00
therveOh hum09:00
therveshardy, I changed the policy file though? What did I miss?09:01
shardytherve: Yeah, it was my mistake, I just forgot to copy the new policy under /etc/heat09:01
*** alexheneveld has joined #heat09:01
therveOh :)09:01
shardybut when you do that the failure doesn't exactly make that obvious09:01
shardyso I'll look at making a clearer warning :)09:02
*** chandankumar_ has joined #heat09:02
therveThanks for checking it out09:02
*** chandan_kumar has quit IRC09:03
*** derekh has joined #heat09:04
*** tspatzier has joined #heat09:04
shardytherve: np, glad that it's basically working09:04
*** tspatzier has quit IRC09:05
shardythat content type thing had me confused for quite a while ;)09:05
shardypassing -D "blah" is just silently discarded by the mapper09:05
*** e0ne has joined #heat09:07
*** tspatzier has joined #heat09:07
*** mkollaro has joined #heat09:13
*** tomek_adamczewsk has quit IRC09:19
*** tomek_adamczewsk has joined #heat09:19
*** yogesh_ has quit IRC09:29
*** alexheneveld has quit IRC09:35
*** gokrokve has joined #heat09:36
*** saju_m has quit IRC09:37
*** saju_m has joined #heat09:38
*** e0ne_ has joined #heat09:38
*** e0ne__ has joined #heat09:40
*** e0ne_ has quit IRC09:40
*** e0ne_ has joined #heat09:40
*** nosnos has quit IRC09:41
*** nosnos_ has joined #heat09:41
*** gokrokve has quit IRC09:41
openstackgerrithuangtianhua proposed a change to openstack/heat: Adding "device_owner" property for Port resource  https://review.openstack.org/6965409:42
*** e0ne has quit IRC09:42
*** tspatzier has quit IRC09:43
*** e0ne__ has quit IRC09:45
*** saju_m has quit IRC09:46
openstackgerritJun Jie Nan proposed a change to openstack/heat: Environment template guide enhancement  https://review.openstack.org/7431109:47
*** tspatzier has joined #heat09:48
*** saju_m has joined #heat10:05
*** nanjj has quit IRC10:13
*** tspatzier has quit IRC10:14
*** david-lyle has quit IRC10:17
*** tspatzier has joined #heat10:17
*** coolsvap has quit IRC10:28
*** chandan_kumar has joined #heat10:30
shardychmouel: Hey, can I bug you for a devstack review?10:30
shardychmouel: https://review.openstack.org/#/c/73324/10:30
*** tspatzier has quit IRC10:30
shardyIt's a blocker for the remaining instance-users patches, which we want in before i310:30
chmouelshardy: sure, give me a litle bit injured my left hand so a bit slow today10:31
shardychmouel: ouch, sorry to hear that :(10:31
*** aignatov is now known as aignatov_10:33
*** chandankumar_ has quit IRC10:34
chmouelshardy: done10:37
shardychmouel: thanks!10:37
*** gokrokve has joined #heat10:37
*** liang has quit IRC10:38
*** gokrokve has quit IRC10:42
openstackgerritA change was merged to openstack/heat: Prevent user introspection of Python objects  https://review.openstack.org/7381210:44
openstackgerritA change was merged to openstack/heat: Add a base class for pluggable functions  https://review.openstack.org/7381310:46
openstackgerritA change was merged to openstack/heat: Refactor re-resolving of templates  https://review.openstack.org/7381410:46
openstackgerritA change was merged to openstack/heat: Re-resolve functions during stack update  https://review.openstack.org/7381510:46
openstackgerritA change was merged to openstack/heat: Calculate dependencies based on unresolved template  https://review.openstack.org/7381610:46
*** alexheneveld has joined #heat10:48
openstackgerritA change was merged to openstack/heat: Remove empty unit test directory  https://review.openstack.org/7397210:51
openstackgerritA change was merged to openstack/python-heatclient: REST method to fetch deployments metadata for a server  https://review.openstack.org/7415911:02
*** tspatzier has joined #heat11:04
openstackgerritChmouel Boudjnah proposed a change to openstack/python-heatclient: Don't use request builtin redirect for any methods  https://review.openstack.org/7432911:05
openstackgerritChmouel Boudjnah proposed a change to openstack/python-heatclient: Don't use request builtin redirect for any methods  https://review.openstack.org/7432911:08
*** aignatov_ is now known as aignatov11:09
cmysteroh and good morning11:14
*** tspatzier has quit IRC11:15
*** ppetit has quit IRC11:15
chmouelshardy: any chances to exchange this for another (alreadya approved) review? https://review.openstack.org/#/c/6716011:18
*** nkhare has quit IRC11:18
shardychmouel: sure :)11:19
chmouel:)11:19
*** ramishra_ has joined #heat11:31
*** ramishra has quit IRC11:31
*** fandi has quit IRC11:32
*** gokrokve has joined #heat11:38
*** gokrokve has quit IRC11:42
*** nosnos_ has quit IRC11:43
*** nosnos has joined #heat11:44
*** tspatzier has joined #heat12:02
*** aignatov is now known as aignatov_12:11
openstackgerritA change was merged to openstack/python-heatclient: Decode all headers before logging curl commands  https://review.openstack.org/6716012:13
openstackgerritA change was merged to openstack/python-heatclient: Python3: use six.iteritems() rather than dict.iteritems()  https://review.openstack.org/7280212:19
*** che-arne has joined #heat12:20
*** pafuent has joined #heat12:25
*** tspatzier has quit IRC12:26
*** rpothier_ has joined #heat12:31
*** alexpilotti has joined #heat12:31
*** rpothier has quit IRC12:32
*** e0ne has joined #heat12:36
*** e0ne_ has quit IRC12:36
*** gokrokve has joined #heat12:39
openstackgerritThomas Herve proposed a change to openstack/heat: Implement glance image constraint  https://review.openstack.org/7291912:41
*** nosnos_ has joined #heat12:43
*** nosnos has quit IRC12:43
*** gokrokve has quit IRC12:43
*** tspatzier has joined #heat12:51
*** matsuhas_ has quit IRC13:04
*** ramishra_ has quit IRC13:05
*** mkollaro has quit IRC13:06
*** matsuhashi has joined #heat13:06
*** mkollaro has joined #heat13:06
*** tspatzier has quit IRC13:07
*** vvechkanov has quit IRC13:10
*** tspatzier has joined #heat13:13
*** jdob has joined #heat13:15
*** aweiteka has joined #heat13:15
*** lpmulligan has quit IRC13:19
*** blomquisg has joined #heat13:19
*** ramishra has joined #heat13:26
*** achampion has quit IRC13:29
*** yogesh has joined #heat13:30
*** yogesh has quit IRC13:35
andersonvommorning!13:38
*** gokrokve has joined #heat13:39
*** tspatzier has quit IRC13:44
*** gokrokve has quit IRC13:44
*** saju_m has quit IRC13:50
radixgood morning13:51
radixhuh13:54
radixwas the behavior of Properties.get recently changed?13:54
*** mkollaro has quit IRC13:56
*** mkollaro1 has joined #heat13:56
radixskraynev: strange that I didn't have any problem with that code when I tested it, I thought .get() would not raise an error if the key didn't exist13:56
*** topol has joined #heat13:56
therveradix, No it was always kind of bad13:56
radixtherve: heh: )13:57
therveYou basically don't want to use it13:57
thervethat's why we have lots of "[key] or stuff" in the properties13:57
radixI'm just trying to figure out how I was able to create an AutoScalingGroup and skraynev wasn't13:59
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Make Keystone client pluggable  https://review.openstack.org/7419014:00
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Add Keystone V2 plugin  https://review.openstack.org/7419114:00
sdakemorning14:01
andersonvommorning!14:02
cmystermorning14:03
therveradix, One thing I noticed: shouldn't resource_def be a list?14:03
radixtherve: ehhhh, maybe?14:04
radixtherve: I think it'd be convenient, but I think it was something that others didn't like :)14:04
therveradix, Why? We should use provider stuff?14:04
radixprovider stuff? no I mean because you can always use a Stack resource to get multiple resources where only one will fit14:05
therveRight but how will a user scale pairs?14:05
radixby scaling a Stack with two items in it14:05
therveSo providing another template basically14:06
radixyeah14:06
radixI don't really love that it needs to be in a separate template14:06
therveOkay we can see later :)14:07
radixI would actually be happy making resource_def into resource_defs and allowing a list, could you post a comment about that?14:08
radixfirst I need to double-check that the basis of the implementation will even work :P14:08
therveradix, We would need to solve the reference problem though, so let's forget it :)14:10
radixtherve: hmm, yeah :)14:10
*** tspatzier has joined #heat14:10
radixtherve: well14:11
radixtherve: there's an easy way to solve it: put each group into a nested stack :)14:11
radixthat way they get to keep their names14:11
radixoh, except the parent template will still try to resolve {get_resource} calls...14:11
radixso yeah, maybe the whole separate template thing is good ;)14:11
radixtoo bad dealing with multiple templates is a pain (have to run an HTTP server somewhere..)14:11
therveI don't think it's the only way, though I don't know the details14:21
*** sgordon has joined #heat14:23
therveThat other error though is another side effect of lazy gettext14:24
therveWhy do we enabled that again?14:24
*** dims has quit IRC14:26
*** tspatzier has quit IRC14:27
therveWhy don't we enable lazy translations during tests?14:28
radix=(14:29
radixOHHHH14:30
radixnow I just actually read _abcoll.py get14:30
radixso okay, it's fine because... I ran heat without gettext enabled? or something?14:31
therveBecause you didn't rebase14:31
therveIt was merged yesterday14:31
*** vijendar has joined #heat14:31
radixah, so it _did_ change :)14:31
radixbut not directly14:31
therve99 tests fail when I enable it :/14:32
radixyeah, let's enable that in the tests :P14:32
therveradix, So maybe get() is good in your usecase14:32
radixtherve: yeah, I think so14:32
radixactually that's already what it was doing, I didn't modify this code14:32
therveshardy, Have you seen https://review.openstack.org/#/c/69133/ ?14:33
therveI'm actually surprised tempest didn't yel14:33
*** killer_prince has joined #heat14:33
*** jcru has joined #heat14:33
*** sabeen has joined #heat14:37
radixtherve: so I'm trying to figure out what to do with rolling updates14:37
radixand whether the properties for configuring them for OS::Heat::AutoScalingGroup should be in the "UpdatePolicy" section, or just properties14:38
*** funzo has quit IRC14:39
*** jcru has quit IRC14:39
therveI don't know if hot supports UpdatePolicy14:40
*** arbylee has joined #heat14:40
therveHopefully it's easy to go one way or the other?14:40
*** dims has joined #heat14:40
*** gokrokve has joined #heat14:40
radixI think it does14:40
*** funzo has joined #heat14:40
radixbut obviously it's kind of a sore thumb since it's not update_policy14:40
*** achampion has joined #heat14:41
radixtherve: the extra interesting thing is that if this is eventually backed by an API, it makes more sense for it to be properties since they would actually be sent to the API, not handled locally14:41
therveradix, Right.14:42
therveI like properties14:43
*** arbylee has quit IRC14:43
radixI think I do too :)14:43
*** arbylee has joined #heat14:43
radixI kinda wish HOT didn't even have a "properties" key, and just had all of the properties as siblings of "type"14:43
*** gokrokve has quit IRC14:45
therveMaybe it can be done :)14:46
radixtherve: so I'll file a bug about this Message addition thing14:48
radixto clarify: is it always a bug to add the result of _()?14:48
*** aignatov_ is now known as aignatov14:49
therveradix, I don't know. It seems it may be, but we do it all over the place14:49
radixyeah, it looks like these lines are really old14:49
radixthe line in the tracebcak from skraynev is from last october14:50
radix(as an aside, it seems pretty wrong to me that _() returns non-unicode)14:51
therveradix, https://bugs.launchpad.net/oslo/+bug/1280826 :/14:51
therveI guess "%s" works?14:51
therveThat's a lot of work though14:51
radixmaybe the first step is to revert the lazy translations merge14:52
radixbecause it's clearly breaking everything14:52
radixthen, reintroduce it, with tests14:52
*** jergerber has joined #heat14:52
therve+114:52
radix^cores14:53
*** funzo has quit IRC14:55
*** nosnos_ has quit IRC14:57
*** funzo has joined #heat14:58
*** gokrokve has joined #heat15:01
*** mkollaro has joined #heat15:02
*** mkollaro1 has quit IRC15:02
*** radez_g0n3 is now known as radez15:06
openstackgerritAlex Gaynor proposed a change to openstack/python-heatclient: Fixed incorrect indentation in the tests  https://review.openstack.org/7440415:06
*** tspatzier has joined #heat15:07
*** aignatov is now known as aignatov_15:11
*** aignatov_ is now known as aignatov15:13
radixI just sent a message to openstack-dev about the lazy translations thing, since nobody's around now :P15:15
*** killer_prince is now known as lazy_prince15:19
*** mkollaro1 has joined #heat15:21
*** mkollaro has quit IRC15:21
*** radez is now known as radez_g0n315:27
*** radez_g0n3 is now known as radez15:28
*** tims has joined #heat15:28
openstackgerritVijendar Komalla proposed a change to openstack/python-heatclient: Adding stack-adopt support to python-heatclient  https://review.openstack.org/7038015:30
*** lazy_prince has quit IRC15:33
*** killer_prince has joined #heat15:34
shardytherve: FYI:https://bugs.launchpad.net/python-heatclient/+bug/128161915:35
therveCOK cool15:36
*** david-lyle has joined #heat15:36
openstackgerritVijendar Komalla proposed a change to openstack/heat: Add Heat API reference to developer docs  https://review.openstack.org/7301115:36
*** chandan_kumar has quit IRC15:43
*** jprovazn has quit IRC15:47
*** gokrokve has quit IRC15:49
*** gokrokve has joined #heat15:49
*** pafuent has quit IRC15:49
skraynevradix: my apologize, I was not near of computer and could not answer on your question15:50
radixskraynev: no problem :)15:50
*** akuznetsov has quit IRC15:50
skraynevAs I understand now all is ok. it was other problem and you created bug for it. right?15:51
*** rcleere has joined #heat15:51
*** killer_prince has quit IRC15:52
*** killer_prince has joined #heat15:52
*** coolsvap has joined #heat15:54
*** gokrokve has quit IRC15:54
radixskraynev: I haven't created a bug, but I did send a message to openstack-dev15:54
radixprobably need some input from cores15:54
*** zhiyan is now known as zhiyan_15:56
skraynevOh. ok, unfortunately I have not such status)) I think, that they give feedback, when they can)15:57
therveradix, It'd be nice to have a reproducible error15:58
therveNot involving your patch15:58
radixwell, lemme try turning it on for unit tests I guess15:59
shardyradix: agree, the ML post is a good thing, and anyone can weigh in to the discussion there, but to fix it we need a bug with details of the error and a reproducer16:00
*** aignatov is now known as aignatov_16:00
*** tomek_adamczewsk has quit IRC16:01
skraynevradix: will you do reproduce plan for it? If you are busy I could try to do it;)16:02
shardytherve: oops, I just realized that bug I raised is for a patch we haven't merged yet!16:04
radixskraynev: If you can reproduce it "in the wild" (outside of the unit tests) that'd be cool, I'm filing the bug now with instructions on how to get the tests to fail16:04
radixskraynev: https://bugs.launchpad.net/heat/+bug/128164416:04
therveshardy, Oh. Yeah. We should fix it there :)16:04
shardytherve: I cherry-picked it into my local tree then completely forgot :)16:05
shardyI'll update the review16:05
skraynevradix: ok.16:06
radixok, I have to run for a bit16:06
radixbe back in an hour or so16:07
skraynevok16:07
*** tspatzier has quit IRC16:11
*** jamieh has joined #heat16:12
shardyDoes anyone else think it's weird that we're translating log messages and not strings in our CLI interface, which users actually read?16:14
* shardy wonders if translators work on python-*client16:14
therveI guess it's matter of prioritie16:18
thervepriorities16:18
shardyI guess that's my whole point, we're translating *debug* logs, but not user visible error strings16:19
* shardy <shrugs>16:19
*** akuznetsov has joined #heat16:19
*** alexheneveld has quit IRC16:21
*** tomek_adamczewsk has joined #heat16:24
*** jistr has quit IRC16:27
*** alexheneveld has joined #heat16:28
openstackgerritSergey Kraynev proposed a change to openstack/heat: Make OS::Nova::Server networks property updatable  https://review.openstack.org/7429916:32
*** matsuhashi has quit IRC16:32
*** killer_prince is now known as lazy_prince16:35
*** varora has joined #heat16:35
*** edmund has quit IRC16:39
*** tomek_adamczewsk has quit IRC16:40
*** pafuent has joined #heat16:41
*** varora has left #heat16:42
*** daneyon has joined #heat16:44
skraynevtherve: are still here? ;)16:50
therveskraynev, Yep16:50
skraynevk. about constraint for neutron resource16:50
skraynevdo you plan add other same constraints not only for network?16:51
skraynevOr how about make it configurable for other instances (subnet, port and other)16:52
*** gokrokve has joined #heat16:52
skraynevIt's just a guess ;)16:52
*** varora has joined #heat16:52
*** varora has left #heat16:53
therveskraynev, We need to add more for other resources16:53
therveI don't know about make it configurable16:53
therveMaybe we could reused some code16:53
*** gokrokve_ has joined #heat16:54
*** aignatov_ is now known as aignatov16:55
*** nkhare has joined #heat16:56
skraynevtherve: sounds good. I like it constraint, but it is so lonely ... only net... alone :)16:57
*** gokrokve has quit IRC16:57
therveErr, sorry?16:58
skraynevSorry, I am kidding. I just was wondered that it checks only network. never mind.17:00
skraynevmay be it's my bad sense of humor17:01
*** jamieh has quit IRC17:01
openstackgerritRabi Mishra proposed a change to openstack/heat: Add ability to create provider networks (vlan,flat).  https://review.openstack.org/7245417:02
*** jamieh has joined #heat17:04
*** aignatov is now known as aignatov_17:04
*** aignatov_ is now known as aignatov17:07
*** TonyBurn_ has quit IRC17:08
*** aignatov is now known as aignatov_17:09
*** edmund has joined #heat17:09
*** coolsvap1 has joined #heat17:11
*** coolsvap1 has quit IRC17:12
*** varora has joined #heat17:12
openstackgerritSimon Pasquier proposed a change to openstack/heat-cfntools: Support of ignoreErrors for commands  https://review.openstack.org/6709917:12
*** coolsvap1 has joined #heat17:13
*** coolsvap has quit IRC17:14
*** coolsvap1 is now known as coolsvap17:15
therveshardy, If the signal data should be JSON, should it be a file argument?17:15
thervePassing JSON in the CL is a pain17:15
openstackgerritSimon Pasquier proposed a change to openstack/heat-cfntools: cfn-signal provides a unique default id  https://review.openstack.org/6482617:16
shardytherve: I think some method to pass signal data on the CLI will be useful17:16
shardye.g if we want userdata scripts to send signals via heatclient in the future17:16
therveshardy, can't they just put the data in a file before sending the signal?17:17
shardymaybe we need some additional signal CLI call which formats several args into a json blob tho17:17
*** cadenzajon has joined #heat17:17
shardytherve: I guess, just seems invonvenient17:17
*** aignatov_ is now known as aignatov17:17
shardyheat --debug resource-signal s1234567 random -D '{"id": 1, "status": "SUCCESS"}'17:17
shardyThat's what I'm doing17:17
therveadopt uses a file fwiw17:17
shardywe could add heat wait-signal stack resource --status SUCCESS I guess17:18
therveBut okay17:18
therveI just need to figure out how to test it because it doesn't seem nice17:19
shardytherve: certainly passing a file can be *a* way, but for debugging, I'd like a CLI method, even if it's piping something in via stdin17:19
shardymaybe we can pass the signal data in via a parameters-like list?17:20
shardytherve: the issue is the various things which respond to signals don't all expect the same data format17:21
*** spzala has joined #heat17:22
therveYeah I don't have a problem with passing a string for now17:22
therveI just need to build the string properly :)17:22
*** jamieh_ has joined #heat17:24
*** jamieh has quit IRC17:25
*** ifarkas has quit IRC17:29
therveThe fact that I can't use a debugger is pretty ridiculous...17:35
*** ramishra has quit IRC17:37
openstackgerritDaneyon Hansen proposed a change to openstack/heat-templates: Adds Support for OpenShift Origin v3.0 on Fedora 19  https://review.openstack.org/7445017:41
*** Linz has joined #heat17:41
radixshardy: wait, we're actually translating stuff now? who's working on that?17:41
radixI thought we were just i18n stuff17:41
*** aignatov is now known as aignatov_17:41
*** e0ne has quit IRC17:44
*** e0ne has joined #heat17:45
*** jamieh has joined #heat17:45
*** aignatov_ is now known as aignatov17:46
*** jamieh_ has quit IRC17:47
*** jamieh_ has joined #heat17:48
*** e0ne has quit IRC17:49
*** jamieh has quit IRC17:50
openstackgerritThomas Herve proposed a change to openstack/python-heatclient: Support the native signal API  https://review.openstack.org/7399617:52
therveradix, Most messages are using gettext?17:53
*** aignatov is now known as aignatov_17:54
openstackgerritThomas Herve proposed a change to openstack/heat: Revert "Merge "Re-enable lazy translation""  https://review.openstack.org/7445417:58
*** Linz has quit IRC17:59
radixtherve: well, what I mean is, are people actually producing localization?18:00
*** tims1 has joined #heat18:00
*** nkhare has quit IRC18:01
*** tims has quit IRC18:02
therveradix, Yeah18:03
therveLike korean is pretty good18:04
*** jamieh_ has quit IRC18:04
*** yogesh has joined #heat18:06
*** mkollaro1 has quit IRC18:09
jasond`would someone mind reviewing this?  https://review.openstack.org/#/c/72443/18:11
thervejasond`, I made a comment on the bug fwiw18:14
*** derekh has quit IRC18:15
*** mkollaro has joined #heat18:21
*** mkollaro has quit IRC18:21
*** jehb has joined #heat18:21
*** cmyster has quit IRC18:25
*** jehb has quit IRC18:25
*** yogesh has quit IRC18:31
*** yogesh has joined #heat18:32
*** tomek_adamczewsk has joined #heat18:32
*** coolsvap has quit IRC18:36
*** yogesh has quit IRC18:36
*** nati_ueno has joined #heat18:37
*** spzala has quit IRC18:41
*** e0ne has joined #heat18:43
*** uvirtbot has joined #heat18:45
*** shakayumi has joined #heat18:46
*** shakayumi has quit IRC18:46
*** tomek_adamczewsk has quit IRC18:46
*** tomek_adamczewsk has joined #heat18:47
*** shakayumi has joined #heat18:47
*** cadenzajon has quit IRC18:50
*** shakayumi has quit IRC18:51
*** shakayumi has joined #heat18:52
*** cadenzajon has joined #heat18:52
*** jistr has joined #heat18:53
*** shakayumi has quit IRC18:53
*** aignatov_ is now known as aignatov18:55
openstackgerritDaneyon Hansen proposed a change to openstack/heat-templates: Adds Support for OpenShift Origin v3.0 on Fedora 19  https://review.openstack.org/7445018:56
*** yogesh has joined #heat18:56
*** tomek_adamczewsk has quit IRC19:01
*** tomek_adamczewsk has joined #heat19:01
*** lindsayk has joined #heat19:04
*** jprovazn has joined #heat19:05
*** tims has joined #heat19:06
*** tims1 has quit IRC19:06
*** rpothier_ has quit IRC19:08
*** kebray_ has joined #heat19:09
*** tims1 has joined #heat19:10
*** jrist has quit IRC19:10
sdakejasond` reviewed looks good19:11
*** kebray_ has quit IRC19:11
*** tims2 has joined #heat19:11
*** tomek_adamczewsk has quit IRC19:11
*** tomek_adamczewsk has joined #heat19:12
jasond`sdake: thanks19:12
*** tims has quit IRC19:12
*** tomek_adamczewsk has quit IRC19:14
*** tims1 has quit IRC19:14
*** tomek_adamczewsk has joined #heat19:14
*** randallburt has joined #heat19:16
*** rpothier_ has joined #heat19:16
randallburtjasond`:  which patch did you want me to look at?19:17
*** tomek_adamczewsk has quit IRC19:17
*** jrist has joined #heat19:17
*** tomek_adamczewsk has joined #heat19:17
stevebakershardy, therve, how much would you like https://review.openstack.org/#/c/73996 to be in the heatclient release I'm about to do?19:18
shardystevebaker: yes please!19:18
* shardy pulls it to test19:18
*** kebray_ has joined #heat19:19
*** tomek_adamczewsk has quit IRC19:19
*** tomek_adamczewsk has joined #heat19:19
jasond`randallburt: https://review.openstack.org/#/c/72443/19:20
*** pafuent has quit IRC19:20
randallburtjasond`:  approved19:21
jasond`thanks19:21
*** pafuent has joined #heat19:21
shardystevebaker: approved19:21
shardystevebaker: relatedly, native-waitcondition is going to miss FPF I'm afraid19:22
*** tomek_adamczewsk has quit IRC19:22
andersonvomstevebaker: hey, I had to manually rebase a few patches you approved last night. would you have a few secs to take a quick look at them again? (https://review.openstack.org/#/q/status:open+project:openstack/heat+branch:master+topic:bp/preview-stack,n,z)19:22
*** tomek_adamczewsk has joined #heat19:22
shardyI've got most of the work done, but I've burned too much time getting the native signal stuff working and it's going to take a bit longer to finish off19:22
stevebakershardy: With a bit of luck SoftwareDeployment can serve the function of a native waitcondition19:23
shardystevebaker: I have two days PTO so ETA is Friday, feel free to bump, or we can make an exception if you think it's appropriate19:23
sdakeanyone know what     @rpc_common.client_exceptions(exception.StackNotFound)19:23
sdake does?19:23
shardystevebaker: using the native signal API and no ec2tokens?19:23
*** che-arne has quit IRC19:24
stevebakersdake: It flags that exception as expected, so it doesn't get logged as an ERROR19:24
stevebakershardy: I haven't tried it but that should just work. It just has a handle_signal19:25
stevebakershardy: keep on working on the native one19:25
shardystevebaker: Ok, cool - do you have a review up for that already?19:25
stevebakershardy: if you want19:25
stevebakershardy: https://review.openstack.org/#/c/67624/19:25
shardystevebaker: I'll see where we are on Friday, and if it looks worthwhile I'll complete it19:25
sdakestevebaker thanks, for the moment I'm going to take those out and figure out how to solve that with oslo.messaing19:27
stevebakersdake: oslo.messaging might not log ERROR anyway, so don't worry about that for now19:27
sdakewhat about @request_context19:27
shardystevebaker: Ok, sounds good, I'll look at how that might work with native auth, as subclassing SignalResponder currently imples ec2token only (no password set for the StackUser)19:28
stevebakersdake: the decorator is at the top of service.py it builds and includes a RequestContext to the method call19:28
*** tomek_adamczewsk has quit IRC19:29
*** nati_ueno has quit IRC19:29
*** nati_ueno has joined #heat19:29
sdakeI get the impression I need to essentially rewrite service.py to work with oslo.messaging19:30
stevebakerouch19:30
sdakeya big ugh19:30
*** tomek_adamczewsk has joined #heat19:30
sdakeall of the details of rpc are abstracted now19:31
sdakeversus rpc being all over the place19:31
shardyWe don't want to do *that* a week before I-3 :(19:31
sdake(as is in oslo-incubator)19:31
openstackgerritSteven Hardy proposed a change to openstack/heat: migrate User/AccessKey resources to StackUser base class  https://review.openstack.org/7276319:31
openstackgerritSteven Hardy proposed a change to openstack/heat: StackUser add _delete_keypair function  https://review.openstack.org/7276219:31
openstackgerritSteven Hardy proposed a change to openstack/heat: engine: allow stack_user_project users to retrieve stack  https://review.openstack.org/7130019:31
openstackgerritSteven Hardy proposed a change to openstack/heat: Add test for StackUser._create_keypair  https://review.openstack.org/7276119:31
openstackgerritSteven Hardy proposed a change to openstack/heat: StackUser add suspend/resume support  https://review.openstack.org/7193019:31
openstackgerritSteven Hardy proposed a change to openstack/heat: migrate StackUser base class to stack domain users  https://review.openstack.org/7121019:31
openstackgerritSteven Hardy proposed a change to openstack/heat: heat_keystoneclient add delete_stack_domain_user_keypair  https://review.openstack.org/7192919:31
openstackgerritSteven Hardy proposed a change to openstack/heat: Modify stack_user_domain config option to take domain ID  https://review.openstack.org/7397819:31
* shardy has to head out for a bit19:32
*** shardy is now known as shardy_afk19:32
*** kebray_ has quit IRC19:33
*** tomek_adamczewsk has quit IRC19:33
*** tomek_adamczewsk has joined #heat19:33
stevebakerheatclient adopt-stack looks good, if it gets a review it will get into the release too https://review.openstack.org/#/c/70380/ <- jasond` randallburt19:33
randallburtstevebaker:  done.19:34
stevebakerrandallburt: ta19:36
*** p2kash has joined #heat19:37
*** nati_uen_ has joined #heat19:38
*** kebray_ has joined #heat19:40
sdakezaneb I have a question re StubOutWithMock19:40
zanebshoot19:40
sdakemy code is     self.m.StubOutWithMock(engine_client._client, 'call')^M19:40
zanebok19:40
sdake_client is created in __init__ of the engine_client's EngineClient object19:41
sdakecall is a function in _client19:41
sdakeI know you said use self.engine._client for that19:41
sdakethere is no self.engine19:42
*** tomek_adamczewsk has quit IRC19:42
sdakethere is a stackcntroller.engine19:42
sdakebut that also doesn't work19:42
zanebI think I was just making stuff up because I didn't know your exact object hierarchy19:42
*** nati_ueno has quit IRC19:42
sdakeEngineClient inherits object19:42
sdakeEngineClient's __init__ creates _client from RPCClient19:42
*** tomek_adamczewsk has joined #heat19:42
*** kebray_ has quit IRC19:42
zanebso engine_client = EngineClient(*args, **kwargs)19:43
sdakefrom heat.rpc import client as engine_client19:43
zaneboh, ok19:43
sdakeI guess what I dont get is what actually constructs that and what is mock actually mocking :)19:44
zanebI thought engine_client was an object, but it's a module19:44
sdakeI see that stackcontroller creates a "engine" in its __init__19:44
sdakeand I could use self.stackcontroller.engine19:44
sdakebut that also doesn't seem to work19:44
*** tomek_adamczewsk has quit IRC19:45
*** tomek_adamczewsk has joined #heat19:45
sdakethe existing tests seem to mock out the rpc module19:46
sdake(rather then an instantiated object)19:46
zanebthe question you have to ask is "where is the RPCClient instance that the functions I am testing are going to call?"19:46
zanebthat's the one you need to stub19:46
zanebbut I can't answer that without seeing your code19:46
openstackgerritSteven Dake proposed a change to openstack/heat: Use olso.messaging  https://review.openstack.org/7279819:47
sdakethere ya go19:47
sdakethis is really giving me fits19:47
*** tomek_adamczewsk has quit IRC19:47
*** kebray_ has joined #heat19:47
*** tomek_adamczewsk has joined #heat19:47
sdaketest_api_cfn_v1.py is where the mocking is19:48
sdakethere is a "self.controller"19:48
sdakeits init contains a engine object19:48
*** tims2 has quit IRC19:48
sdakethat engine object contains a _client object19:48
*** tims has joined #heat19:48
sdaketeh _client object contains the call operation19:48
zanebok, so that's what you want to stub19:49
sdakeI am pretty sure I tried that19:49
*** p2kash has quit IRC19:49
zanebself.m.StubOutWithMock(self.controller.engine._client, 'call')19:49
sdakebut I'll double check19:49
*** randallburt has quit IRC19:49
*** tomek_adamczewsk has quit IRC19:50
sdakehow would I call it then?19:50
sdakeself.controller.engine._client.call?19:50
*** tomek_adamczewsk has joined #heat19:50
zanebyes19:50
zanebexcept it's actually called engine_rpcapi https://github.com/openstack/heat/blob/master/heat/api/cfn/v1/stacks.py#L4919:52
sdakezaneb why does the existing tests work on modules?19:52
zanebso  self.m.StubOutWithMock(self.controller.engine_rpcapi._client, 'call')19:52
sdakethanks19:52
zaneband self.controller.engine_rpcapi._client.call(mock_params)19:52
*** tomek_adamczewsk has quit IRC19:52
*** tomek_adamczewsk has joined #heat19:53
zanebsdake: because in the existing code, call() is a function in a module. It's not an instance (or even class/static) method19:53
sdakegot it19:53
sdakeso basically its a module global19:54
zanebthat changed in Oslo because having one global sucked19:54
zanebyeah, exactly19:54
sdakezaneb so this is what I get: AttributeError: call does not take 2 or more positional arguments^M19:55
stevebakershardy_afk: can you un-approve https://review.openstack.org/#/c/73996/ ? check is actually failing on that19:55
stevebakertherve: ^19:55
sdakeI looked into mox, and this might be because "call" is a mox api19:56
sdakebut tbh I have no idea what causes that error19:56
zanebis it possible the api of the call() method has changed in olso too?19:56
sdakelooking19:57
zanebhttps://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/rpc/client.py#L32719:57
zanebit appears not19:57
therveHum19:57
sdakeThe error is coming from mox.py line 91119:58
zaneboh, wait, it has changed19:59
thervestevebaker, What's the error?19:59
stevebakertherve: its in the left column of http://status.openstack.org/zuul/19:59
zanebsdake: it was def call(context, topic, msg, timeout=None)19:59
zanebsdake: now def call(self, ctxt, method, **kwargs):19:59
sdakethanks for debug for noobs :)20:00
zanebsdake: :param kwargs: a dict of method arguments20:00
zanebso instead of passing the message as a dict, you pass it as kwargs20:00
zanebi.e. just put ** in front and it will work20:01
*** skraynev is now known as skraynev_afk20:01
zanebsdake: same applies in heat/rpc/client.py20:01
*** jistr has quit IRC20:01
*** jamieh has joined #heat20:02
thervestevebaker, Yeah hard to tell what's going on20:02
stevebakertherve: I think I'll need to do the heatclient release without it, but there will be more releases soon20:03
thervestevebaker, We don't have adopt in it either?20:04
*** spzala has joined #heat20:04
stevebakertherve: I'll wait for that, its gating20:04
therveAh so if I fix it soon I have a go :)20:04
stevebakertherve: it will still need a check and a gate, which is currently looking around 4 hours20:05
stevebakertherve: I don't think I can wait for that20:05
therveOh good I committed something wrong20:05
zanebsdake: actually may not be as simple as **, but I'm sure you will figure it out20:05
sdake       self.controller.engine_rpcapi._client.call(dummy_req.context,20:06
sdake                 'show_stack',20:06
sdake                  **{'stack_identity': identity}).AndReturn(engine_resp)20:06
sdakelike that?20:06
openstackgerritThomas Herve proposed a change to openstack/python-heatclient: Support the native signal API  https://review.openstack.org/7399620:06
thervestevebaker, Okay :/20:06
*** tomek_adamczewsk has quit IRC20:07
*** tomek_adamczewsk has joined #heat20:08
*** randallburt has joined #heat20:09
*** spzala has quit IRC20:09
*** pafuent has quit IRC20:10
*** pafuent has joined #heat20:11
*** spzala has joined #heat20:12
*** randallburt has quit IRC20:14
*** jcru has joined #heat20:14
zanebsdake: something like that. the oslo.messaging docs are not super clear20:17
sdakezaneb agree20:17
*** pafuent has quit IRC20:17
openstackgerritZane Bitter proposed a change to openstack/heat: Replace function resolution with lazy evaluation  https://review.openstack.org/7382220:23
*** e0ne_ has joined #heat20:25
openstackgerritLon Hohberger proposed a change to openstack/heat: Add systemd notification support to heat  https://review.openstack.org/7448920:26
*** cadenzajon has quit IRC20:27
*** jaustinpage has joined #heat20:28
*** e0ne has quit IRC20:29
openstackgerritJun Jie Nan proposed a change to openstack/heat: Environment template guide enhancement  https://review.openstack.org/7431120:31
*** denis_makogon has quit IRC20:31
andersonvomstevebaker: thanks! =)20:32
*** dmakogon_ has joined #heat20:32
jaustinpageif in an environment, I am doing a type rewrite with a resource registry, and i have a template that references another template, shouldn't the environment resource registry type rewrite apply to both templates?20:34
*** lindsayk has quit IRC20:41
*** akuznetsov has quit IRC20:42
*** jamieh has quit IRC20:43
*** pvaneck has joined #heat20:43
*** akuznetsov has joined #heat20:46
andersonvomhey fellows, if anybody has some spare time around, could you take a look at https://review.openstack.org/#/c/63041/ (Unscoped list stacks)? It's been just sitting there for a little while now... all lonely...20:56
*** randallburt has joined #heat20:56
*** yogesh has quit IRC21:00
*** p2kash has joined #heat21:02
*** p2kash has left #heat21:03
*** akuznetsov has quit IRC21:04
openstackgerritAnderson Mesquita proposed a change to openstack/python-heatclient: Add stack-preview support  https://review.openstack.org/7449821:07
*** cadenzajon has joined #heat21:09
*** e0ne_ has quit IRC21:10
*** yogesh has joined #heat21:10
*** lindsayk has joined #heat21:11
*** yogesh has quit IRC21:12
*** yogesh has joined #heat21:13
*** yogesh has quit IRC21:17
*** nati_uen_ has quit IRC21:18
*** nati_ueno has joined #heat21:19
stevebakershardy_afk: still awake?21:24
openstackgerritLon Hohberger proposed a change to openstack/heat: Add systemd notification support to heat  https://review.openstack.org/7448921:24
openstackgerritLon Hohberger proposed a change to openstack/heat: Add systemd notification support to heat  https://review.openstack.org/7448921:29
*** kfox1111 has joined #heat21:33
kfox1111question. for stack users, does the user really need to be associated with the tenant or will everything work if that isn't true?21:33
*** kebray_ has quit IRC21:34
*** jprovazn has quit IRC21:34
zanebkfox1111: the user would have to have a role that allows them it to do what it needs to do... the specifics depend entirely on your policy.json21:36
*** greghaynes has quit IRC21:41
*** sgordon has quit IRC21:50
*** jdob has quit IRC21:55
openstackgerritJun Jie Nan proposed a change to openstack/heat: Environment template guide enhancement  https://review.openstack.org/7431122:00
*** jaustinpage has quit IRC22:00
pscheieApproximately when is icehouse supposed to be released?22:03
pscheieMarch?  April?22:03
timshttps://wiki.openstack.org/wiki/Icehouse_Release_Schedule22:06
pscheietims, thank you.22:07
timspscheie: anytime :)22:07
*** nati_uen_ has joined #heat22:07
openstackgerritLon Hohberger proposed a change to openstack/heat: Add systemd notification support to heat  https://review.openstack.org/7448922:08
*** nati_ueno has quit IRC22:10
*** ramishra has joined #heat22:10
*** aignatov is now known as aignatov_22:11
*** radez is now known as radez_g0n322:17
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Refactor Stack timestamps  https://review.openstack.org/7451922:18
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Alter stack_count_all_by_tenant to stack_count_all  https://review.openstack.org/7085322:18
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Replace stack_get_all_by_tenant with stack_get_all  https://review.openstack.org/7085222:18
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Unscoped List Stacks  https://review.openstack.org/6304122:18
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Add tenant to unscoped stack list response  https://review.openstack.org/7278922:18
openstackgerritRabi Mishra proposed a change to openstack/heat: Add ability to create provider networks (vlan,flat).  https://review.openstack.org/7245422:20
*** e0ne has joined #heat22:21
*** asalkeld has quit IRC22:23
openstackgerritJun Jie Nan proposed a change to openstack/heat: Filter the params from dict  https://review.openstack.org/7427622:24
*** randallburt has quit IRC22:25
*** e0ne has quit IRC22:26
*** tomek_adamczewsk has quit IRC22:27
*** blomquisg has quit IRC22:28
*** derekh has joined #heat22:35
*** ramishra has quit IRC22:37
*** daneyon has quit IRC22:38
*** arbylee has quit IRC22:38
*** asalkeld has joined #heat22:40
*** vijendar has quit IRC22:43
*** achampion has quit IRC22:44
*** jcru has quit IRC22:48
*** KiwiMartin has joined #heat22:51
*** randallburt has joined #heat22:51
*** topol has quit IRC22:51
*** nati_ueno has joined #heat22:55
*** nati_uen_ has quit IRC22:59
*** dims has quit IRC23:04
*** dims has joined #heat23:05
*** arbylee has joined #heat23:05
*** arbylee has quit IRC23:05
*** KiwiMartin has quit IRC23:10
*** KiwiMartin has joined #heat23:10
*** kfox1111_ has joined #heat23:11
*** edmund has quit IRC23:12
*** lindsayk has quit IRC23:12
*** topol has joined #heat23:14
openstackgerritRandall Burt proposed a change to openstack/heat: Refactor CLB to work with groups  https://review.openstack.org/6558623:14
*** lindsayk has joined #heat23:15
*** arbylee has joined #heat23:16
*** arbylee has quit IRC23:16
*** kfox1111 has quit IRC23:16
*** openstackgerrit has quit IRC23:16
*** alexpilotti has quit IRC23:17
*** arbylee has joined #heat23:18
*** openstackgerrit has joined #heat23:18
*** spzala has quit IRC23:21
*** arbylee has quit IRC23:29
*** asalkeld has quit IRC23:31
*** sabeen has quit IRC23:33
*** tims has quit IRC23:36
*** randallburt has quit IRC23:41
*** andersonvom has quit IRC23:41
*** cadenzajon_ has joined #heat23:41
openstackgerritSteve McLellan proposed a change to openstack/heat: Server secgroups and network/port together invalid  https://review.openstack.org/6905223:42
*** cadenzajon has quit IRC23:43
*** asalkeld has joined #heat23:43
*** nati_uen_ has joined #heat23:44
*** nati_ueno has quit IRC23:47
*** lindsayk has quit IRC23:53
*** lindsayk has joined #heat23:54
*** jergerber has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!