| *** jhesketh has joined #airshipit | 00:49 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #airshipit | 05:33 | |
| *** roman_g has joined #airshipit | 07:14 | |
| *** awander has quit IRC | 07:42 | |
| *** muhaha has joined #airshipit | 10:30 | |
| airship-irc-bot | <mf4716> good morning - additional reviews of craig's image-builder patchset would be appreciated - thanks in advance - https://review.opendev.org/#/c/730777/ | 14:24 |
|---|---|---|
| *** muhaha has quit IRC | 15:21 | |
| airship-irc-bot | <craig.anderson> the airshipctl integration changeset for image-builder is also available now, https://review.opendev.org/#/c/758782/ I have added it to the airship meeting etherpad | 15:32 |
| airship-irc-bot | <mf4716> great @craig.anderson - ty | 15:55 |
| airship-irc-bot | <kk6740> @craig.anderson did u test if progress bar working for this ? | 15:58 |
| airship-irc-bot | <pb269f> @kk6740 how would the progress bar be able to calc where it is? | 15:59 |
| airship-irc-bot | <kk6740> because i see logs there, seems like we should get rid of that | 15:59 |
| airship-irc-bot | <kk6740> i don’t expect it to work | 16:00 |
| airship-irc-bot | <kk6740> i expect it to be broken and removed tbh | 16:00 |
| airship-irc-bot | <pb269f> ++ same | 16:00 |
| airship-irc-bot | <pb269f> :) | 16:00 |
| airship-irc-bot | <kk6740> :+1: | 16:02 |
| airship-irc-bot | <craig.anderson> the iso gets generated within a couple of minutes. maybe we don't need it now? | 16:05 |
| airship-irc-bot | <pb269f> like @kk6740 id advocate for its removal | 16:06 |
| airship-irc-bot | <kk6740> i think we may need progress shown somehow, but i also think that the whole approach of current bar should be removed | 16:06 |
| airship-irc-bot | <pb269f> log to stdout i think is likely to be the only sustainable path long term | 16:07 |
| airship-irc-bot | <kk6740> so we should remove it for now instead of trying to align it with image builder | 16:07 |
| airship-irc-bot | <kk6740> i believe we can have generic progress bar for every phase, including image builder. But then we would need image to write updates in json/yaml format to stdout, these yamls/json would be marshaled in a progress type objects, so it would be a contract, between image and airshipctl, so that if u want ur image builder to show progress, it should: 1. calculate itself steps and send them to airshipctl via stdout via well defined yaml/json | 16:13 |
| airship-irc-bot | 2. update those steps as it goes by writing to stdout well define update yamls to stdout between steps. but it’s too complicated develop and support for now imho, lets just focus on builder itself rather than it’s progress | 16:13 |
| airship-irc-bot | <craig.anderson> ok sounds good. thx for the info | 16:14 |
| airship-irc-bot | <kk6740> so you can remove that log file as well as progress flag | 16:15 |
| airship-irc-bot | <james.gu> Could the team please review treasuremap v1.8 prime fix required for CNTT healthcheck test? Here is the link: https://review.opendev.org/#/c/757647. It has been tested successfully in CNTT lab intel pod 17. | 17:04 |
| airship-irc-bot | <james.gu> Thanks in advance! | 17:04 |
| *** roman_g has quit IRC | 18:48 | |
| *** GoldenBear_ has quit IRC | 20:05 | |
| *** GoldenBear has joined #airshipit | 20:12 | |
| *** howell has quit IRC | 22:30 | |
| *** howell has joined #airshipit | 22:32 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!