| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 935574: Add mirror-container-images role and job https://review.opendev.org/c/zuul/zuul-jobs/+/935574 | 04:20 | |
| @mhuin:matrix.org | hi zuul-maint, as extensive users of the openshiftpods driver we're going to patch our prod env with https://review.opendev.org/c/zuul/nodepool/+/936015 but ideally this lands and triggers a minor release ASAP. Please let me know what I can do to get this merged! | 10:44 |
|---|---|---|
| -@gerrit:opendev.org- Karolina Kula proposed on behalf of Joel Capitao: [zuul/zuul-jobs] 936023: DNM Switch to KVM https://review.opendev.org/c/zuul/zuul-jobs/+/936023 | 11:58 | |
| -@gerrit:opendev.org- Joel Capitao proposed: [zuul/zuul-jobs] 936023: DNM Switch to KVM https://review.opendev.org/c/zuul/zuul-jobs/+/936023 | 13:10 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/nodepool] 936015: Openshift/pods drivers: refactor, fix doc https://review.opendev.org/c/zuul/nodepool/+/936015 | 13:37 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 936162: Revert "Delete blob store lock paths on unlock" https://review.opendev.org/c/zuul/zuul/+/936162 | 15:01 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Jeremy Stanley https://matrix.to/#/@fungicide:matrix.org: [opendev/zone-zuul-ci.org] 935977: Add Bluesky Verification Record for Zuul Account https://review.opendev.org/c/opendev/zone-zuul-ci.org/+/935977 | 15:48 | |
| @clarkb:matrix.org | > <@mhuin:matrix.org> hi zuul-maint, as extensive users of the openshiftpods driver we're going to patch our prod env with https://review.opendev.org/c/zuul/nodepool/+/936015 but ideally this lands and triggers a minor release ASAP. Please let me know what I can do to get this merged! | 15:59 |
| The change has been approved but the config validation part of the change looks odd to me. It uses two identical functions except for the name to check max-servers isn't overloaded in a portion of code dedicated to ensuring labels are valid | ||
| @fungicide:matrix.org | clarkb: i'll unapprove for now if you want to review | 16:00 |
| @clarkb:matrix.org | No I think it is fine. corvus had previously +2'd the code in question too | 16:01 |
| @fungicide:matrix.org | standing down | 16:01 |
| @clarkb:matrix.org | I'm just wondering if there is a more direct way to enforce that config restriction via voluptuous rules or something | 16:01 |
| @fungicide:matrix.org | like whether it has some sort of mutually-exclusive alias rule built in that could be used instead? | 16:02 |
| @clarkb:matrix.org | Ya or even just checking that max-servers and max-pods are not defined in the voluptuous schema specific to open shift rather than the top level validation routine | 16:04 |
| @jim:acmegating.com | Clark: yes there absolutely is a better way of doing that, and there are examples of that in nodepool | 16:15 |
| @jim:acmegating.com | it's not worth worrying about though because it's all about to be deleted :) | 16:16 |
| @jim:acmegating.com | mhu, Clark fungi : i did -1 for a different reason though. | 16:24 |
| @jim:acmegating.com | oh i didn't notice that was in the top-level validation | 16:25 |
| @jim:acmegating.com | yeah that at *least* needs to be pushed into the drivers themselves. it *should* use the voluptuous stuff, but that's not necessary. | 16:26 |
| @jim:acmegating.com | there are some drivers that use the voluptuous mutex; and others that just "manually" enforce it like that. i don't care which it uses, but it shoud not be at the top level. | 16:27 |
| -@gerrit:opendev.org- Clark Boylan proposed: [opendev/zone-zuul-ci.org] 936179: Fix bluesky atproto verification record https://review.opendev.org/c/opendev/zone-zuul-ci.org/+/936179 | 16:56 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Clark Boylan: [opendev/zone-zuul-ci.org] 936179: Fix bluesky atproto verification record https://review.opendev.org/c/opendev/zone-zuul-ci.org/+/936179 | 17:00 | |
| @mhuin:matrix.org | > <@clarkb:matrix.org> I'm just wondering if there is a more direct way to enforce that config restriction via voluptuous rules or something | 17:20 |
| I tried that approach: https://github.com/alecthomas/voluptuous?tab=readme-ov-file#multi-field-validation but then the schema's extend function that is used in the validator complained that schemas should be dictionaries, so I didn't push further | ||
| @mhuin:matrix.org | corvus: re: the debugs, I thought that'd be interesting to have some info on what is actually loaded, let me remove them then | 17:23 |
| @mhuin:matrix.org | > <@jim:acmegating.com> Clark: yes there absolutely is a better way of doing that, and there are examples of that in nodepool | 17:26 |
| you mean voluptuous.Exclusive as in the aws driver I guess | ||
| @jim:acmegating.com | mhu: yep. but like i said, i don't think it's necessary here. doing it "manually" is fine. just do it in the drivers rather than config_loader.py | 17:31 |
| @jim:acmegating.com | (if you want to use Exclusive, that is the better way i think -- it just depends on how you want to spend your time :) | 17:31 |
| @mhuin:matrix.org | I'm doing it right now instead of having lasagna | 17:32 |
| @mhuin:matrix.org | so I'll let you be the judge of that use of my time 🙂 | 17:32 |
| @jim:acmegating.com | mhu: not the choice i would have made, but i respect it :) | 17:32 |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/nodepool] 936015: Openshift/pods drivers: refactor, fix doc https://review.opendev.org/c/zuul/nodepool/+/936015 | 17:44 | |
| @mhuin:matrix.org | and now, lasagna | 17:44 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 936162: Revert "Delete blob store lock paths on unlock" https://review.opendev.org/c/zuul/zuul/+/936162 | 18:05 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 936204: Delete LockableZKObject lock paths https://review.opendev.org/c/zuul/zuul/+/936204 | 21:24 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!