| @fungicide:matrix.org | Jens Harbott: i don't find any direct references in zuul's javascript codebase to `ne.utc` so i wonder if it's being raised in an installed js lib the dashboard is utilizing? though we do seem to be using moment.utc() in a bunch of places and i see people complaining about getting similar errors when they fail to install the separate `moment-timezone` library | 13:14 |
|---|---|---|
| @fungicide:matrix.org | though we include that in the lists in `package.json` and `yarn.lock` so maybe that isn't the problem in this case | 13:16 |
| @fungicide:matrix.org | maybe we need to import moment-timezone in more files? i see `pages/Status.jsx` has an explicit `import * as moment from 'moment-timezone'` and there's another similar import in `containers/timezone/SelectTz.jsx` but nowhere else that i can find | 13:19 |
| @fungicide:matrix.org | https://review.opendev.org/c/zuul/zuul/+/900484 "Update moment version" merged on wednesday, so would have appeared in opendev's update over the weekend | 13:21 |
| @fungicide:matrix.org | i don't see any changes around the usage of moment in zuul since august though | 13:22 |
| @fungicide:matrix.org | so seems like this is probably a breaking change in the new version of moment? skimming https://github.com/moment/moment/blob/develop/CHANGELOG.md i don't see anything that jumps out at me since the 2.22.2 version we were previously specifying | 13:29 |
| @fungicide:matrix.org | not sure if the problem would be solved by also updating `moment-timezone` but seems it also has some more recently fixed advisories: https://github.com/moment/moment-timezone/releases/tag/0.5.35 | 13:41 |
| @fungicide:matrix.org | according to `yarn.lock`, the version of the `patternfly` library we're specifying depends on older versions of `moment` and `moment-timezone` too, but i'm unfamiliar enough with javascript that i don't know whether or not that's actually a problem | 13:44 |
| -@gerrit:opendev.org- Jeremy Stanley https://matrix.to/#/@fungicide:matrix.org proposed: [zuul/zuul] 901945: Use moment-timezone for moment's tz method https://review.opendev.org/c/zuul/zuul/+/901945 | 14:08 | |
| @fungicide:matrix.org | the commit message in that ^ is full of wild speculation on my part, a shot in the dark really | 14:08 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Jeremy Stanley https://matrix.to/#/@fungicide:matrix.org: [zuul/zuul] 901945: Use moment-timezone for moment's tz method https://review.opendev.org/c/zuul/zuul/+/901945 | 15:18 | |
| @fungicide:matrix.org | thanks! yeah, i figured it was more complicated than what i had there | 15:22 |
| @fungicide:matrix.org | also apparently the moment maintainers decided circa several years ago they were not going to continue feature development, and have been recommending that projects migrate off it: https://momentjs.com/docs/ | 15:24 |
| @jim:acmegating.com | Jens Harbott: you can add ?limit=1000 or similar to the api url to get more errors | 15:19 |
| @jim:acmegating.com | fungi: thank you for finding the moment-tz issue :) | 15:41 |
| @fungicide:matrix.org | np, just wanted to get a head start on it since we're seeing reports from multiple confused users | 15:51 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 15:56 | |
| - [zuul/zuul] 901511: Use server-side filtering and pagination in config error page https://review.opendev.org/c/zuul/zuul/+/901511 | ||
| - [zuul/zuul] 901512: Use tenant-status endpoint to show the bell https://review.opendev.org/c/zuul/zuul/+/901512 | ||
| @fungicide:matrix.org | ttps://c39a150332b4ff64be1b-686a0804f7bfb930ff5f607c5138e359.ssl.cf1.rackcdn.com/t/opendev/build/16085a4d6a294de4a7f0043fec42ef5f seems to work, yay! | 15:56 |
| @fungicide:matrix.org | * https://c39a150332b4ff64be1b-686a0804f7bfb930ff5f607c5138e359.ssl.cf1.rackcdn.com/t/opendev/build/16085a4d6a294de4a7f0043fec42ef5f seems to work, yay! | 15:57 |
| @jim:acmegating.com | i think we should go ahead and +w it. | 15:58 |
| @fungicide:matrix.org | just did, thanks again! | 15:58 |
| @clarkb:matrix.org | ++ | 16:32 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 16:47 | |
| - [zuul/zuul] 901511: Use server-side filtering and pagination in config error page https://review.opendev.org/c/zuul/zuul/+/901511 | ||
| - [zuul/zuul] 901512: Use tenant-status endpoint to show the bell https://review.opendev.org/c/zuul/zuul/+/901512 | ||
| @jim:acmegating.com | if we'd like to move the config error paging along, https://049ba57594689831b62c-0e3fb6aa51c198ca1006120f0b98db06.ssl.cf2.rackcdn.com/901512/3/check/zuul-build-dashboard-opendev/7071ab7/npm/html/ is the latest preview build for https://review.opendev.org/901512 (including its parent https://review.opendev.org/901511 ). that seems to be working as expected for me. | 18:09 |
| -@gerrit:opendev.org- Zuul merged on behalf of Jeremy Stanley https://matrix.to/#/@fungicide:matrix.org: [zuul/zuul] 901945: Use moment-timezone for moment's tz method https://review.opendev.org/c/zuul/zuul/+/901945 | 18:20 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 18:34 | |
| - [zuul/nodepool] 899083: Fix metastatic missing pool config https://review.opendev.org/c/zuul/nodepool/+/899083 | ||
| - [zuul/nodepool] 899084: Use backing node attributes as metastatic default https://review.opendev.org/c/zuul/nodepool/+/899084 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 901624: Fix some old entries in zuul_ref table https://review.opendev.org/c/zuul/zuul/+/901624 | 18:55 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!