| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 899022: Force Nodepool re-election on connection suspended https://review.opendev.org/c/zuul/zuul/+/899022 | 07:22 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 899022: Force Nodepool re-election on connection suspended https://review.opendev.org/c/zuul/zuul/+/899022 | 07:27 | |
| @clarkb:matrix.org | corvus: `Change 356941: Do not set real_author in ChangeMessageInfo if author == real_author` is one of Gerrit 3.8's breaking changes. Thought I'd check with you really quickly if you know if this would affect zuul | 14:44 |
|---|---|---|
| @clarkb:matrix.org | More info: `It’s not needed to return the author twice if the change message was not impersonated. Documentation already stated this, but clients should double check they don’t rely on real_author always being returned.` | 14:45 |
| @clarkb:matrix.org | if not thats fine I'll dig into the zuul driver later today when I have time to determine if this is a problem. I have a big list of changes to cross check as part of upgrade prep | 14:45 |
| @jim:acmegating.com | Clark: real_author doesn't show up in a grep :) hopefully i'm parsing that right... | 14:46 |
| @clarkb:matrix.org | ya I think that means we'll be good | 14:46 |
| @clarkb:matrix.org | I'm not a fan of that change though. if you have fields in api responses you should always set them even if the value is null | 14:47 |
| @clarkb:matrix.org | rather than omitting the field entirely | 14:47 |
| @clarkb:matrix.org | its more explicit that the field is unset rather than missing | 14:47 |
| @jim:acmegating.com | ++ | 14:48 |
| @clarkb:matrix.org | corvus: `Change 360219: Delete vote now fails for an already deleted vote` is another one that might cause problems for zuul if we don't handle failure of vote deletion when clearing out votes. | 15:33 |
| @clarkb:matrix.org | I'm making a note to try and dig into the driver to see if that is a problem | 15:33 |
| @jim:acmegating.com | Clark: is "delete vote" an action distinct from "vote 0"? (i think maybe it is?) | 15:47 |
| @clarkb:matrix.org | that is a good question. I'm not 100% sure but I think applying a vote is different than deleting a vote | 15:48 |
| @jim:acmegating.com | Clark: if so, i don't think we expose "delete vote" as a pipeline reporter action | 15:48 |
| @jim:acmegating.com | and if that's right, then that shouldn't be a problem for us (but something to keep in mind if we ever add that) | 15:49 |
| @jim:acmegating.com | (we do support the event as a trigger action, which further leads me to think that's a distinct action from leaving a vote) | 15:50 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 17:22 | |
| - [zuul/nodepool] 899083: Fix metastatic missing pool config https://review.opendev.org/c/zuul/nodepool/+/899083 | ||
| - [zuul/nodepool] 899084: Use backing node attributes as metastatic default https://review.opendev.org/c/zuul/nodepool/+/899084 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 899096: Add auth token to websocket https://review.opendev.org/c/zuul/zuul/+/899096 | 23:37 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!