| -@gerrit:opendev.org- Simon Westphahl proposed on behalf of Benedikt Löffler: | 06:17 | |
| - [zuul/nodepool] 883335: Log time how long the import-snapshot takes https://review.opendev.org/c/zuul/nodepool/+/883335 | ||
| - [zuul/nodepool] 892535: For debugging print image import task id https://review.opendev.org/c/zuul/nodepool/+/892535 | ||
| - [zuul/nodepool] 892536: Debug no SnapshotId in SnapshotTaskDetail https://review.opendev.org/c/zuul/nodepool/+/892536 | ||
| @mhuin:matrix.org | > <@clarkb:matrix.org> mhu: looking at the statsd change. The k8s lib is generated but the openshift lib which depends on the k8s lib is not. We actually use the openshift library iirc. Maybe try upstreaming to openshift first? | 06:56 |
|---|---|---|
| Not sure I follow: from what I can tell, | ||
| * openshift is in nodepool's requirements.txt and since the k8s lib is a dependency for the openshift lib, it is also pulled for nodepool | ||
| * the openshift client is only used by the openshift* providers, the k8s provider uses the k8s' client directly | ||
| @mhuin:matrix.org | openshift's DynamicClient wrapper could probably be modified to emit metrics on API calls but that would not cover the kubernetes provider | 06:57 |
| -@gerrit:opendev.org- Felix Edel proposed on behalf of Simon Westphahl: [zuul/zuul] 865942: DNM: Debug config errros in Zuul web https://review.opendev.org/c/zuul/zuul/+/865942 | 07:44 | |
| @mhuin:matrix.org | but seeing corvus 's comment I think I'll just rework this to extend the rate limiter to include metrics emissions | 07:56 |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 898221: dnm: Test non-voting failing build with provides/requires + cdep https://review.opendev.org/c/zuul/zuul/+/898221 | 12:10 | |
| @jim:acmegating.com | mhu: well, i was trying to say upstream client is the best. :) | 13:49 |
| @mhuin:matrix.org | > <@jim:acmegating.com> mhu: well, i was trying to say upstream client is the best. :) | 13:53 |
| I think the rate limiter approach is sound and should be less "hacky" than what I initially came up with. But I don't expect upstream clients to accept contributions adding statsd metrics emission as it doesn't necessary fall under the scope of the clients | ||
| @mhuin:matrix.org | or they will need some serious convincing, like "well openstacksdk does it and it's pretty cool" | 13:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!