| -@gerrit:opendev.org- Jeremy Stanley https://matrix.to/#/@fungicide:matrix.org proposed: [zuul/zuul-website] 890040: Blog article titles link to themselves https://review.opendev.org/c/zuul/zuul-website/+/890040 | 12:17 | |
| @fungicide:matrix.org | seems there were new flake8 and pycodestyle releases yesterday, so now nox-linters is full of complaints about places we used line continuations immediately after a comma, because apparently that bothers somebody | 13:21 |
|---|---|---|
| @fungicide:matrix.org | looks like they adjusted e231 "missing whitespace after ','" to also match `...something,\` | 13:22 |
| @fungicide:matrix.org | 33 matches in zuul/zuul | 13:23 |
| @fungicide:matrix.org | not sure whether it's better to pin back pycodestyle, skip all e231 checks, or "fix" those 33 lines | 13:24 |
| @fungicide:matrix.org | i'm happy to push up a change for any one of those solutions if there are opinions as to which is preferable | 13:30 |
| @jim:acmegating.com | i find that pretty disagreeable myself; the newline serves the function of the whitespace in that scenario. i like the old rule though. wish they split it. | 15:55 |
| @fungicide:matrix.org | it's also quite possible this is a false positive match and they didn't intend to start matching on line continuations | 19:04 |
| @fungicide:matrix.org | but if that's the suspicion, then probably worth filing an issue about it | 19:05 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!