| @flaper87:matrix.org | tristanC: any chance you will have time to review https://review.opendev.org/c/zuul/zuul/+/885455 ? :) | 12:01 |
|---|---|---|
| @flaper87:matrix.org | Another review request: Wondering who is more familiar with the elasticsearch driver that could provide a review here: https://review.opendev.org/c/zuul/zuul/+/883837 | 12:03 |
| @tristanc_:matrix.org | flaper87: thank you for the ping, i forgot about it :-) I ran some test and left you a comment | 13:04 |
| @flaper87:matrix.org | > <@tristanc_:matrix.org> flaper87: thank you for the ping, i forgot about it :-) I ran some test and left you a comment | 13:21 |
| thank you so much. I will incorporate your feedback. To make sure I understood what you mean, your suggestion is to add the `PUBLIC_URL` check to the new implementation. RIght? | ||
| -@gerrit:opendev.org- Flavio Percoco Premoli proposed: [zuul/zuul] 885455: Use built-in URL data type instead of custom parse https://review.opendev.org/c/zuul/zuul/+/885455 | 13:31 | |
| @flaper87:matrix.org | tristanC: ok, pushed a new version | 13:31 |
| @jim:acmegating.com | dpawlik: might want to review 883837 | 13:32 |
| @flaper87:matrix.org | tristanC: thanks for the review and +2. I will check the web page preview (as mentioned in the description, I also tested this manually on our env 😄) | 13:38 |
| @flaper87:matrix.org | will wait for CI and then see who else can provide an approve there 🤞 | 13:38 |
| @jim:acmegating.com | i'm happy to do that after the preview | 13:39 |
| @flaper87:matrix.org | I was checking the list of jobs and didn't see one mentioning the web preview. Is the preview generated automatically by one of the jobs? How can I check it? | 13:43 |
| @jim:acmegating.com | flaper87: zuul-build-dashboard-* | 13:46 |
| @jim:acmegating.com | eg, site preview on https://zuul.opendev.org/t/zuul/build/96db8bda8d104216b30ac55afd4048ef/artifacts (old version of change) | 13:47 |
| @jpew:matrix.org | Does anyone use Zuul with VM migration in OpenSTack? | 14:17 |
| @flaper87:matrix.org | > <@jim:acmegating.com> eg, site preview on https://zuul.opendev.org/t/zuul/build/96db8bda8d104216b30ac55afd4048ef/artifacts (old version of change) | 14:45 |
| Thanks! I just checked and the preview for the new run has been generated: https://2531b055144b2704e366-0ec349b737fff6d791676e2f8057b6a5.ssl.cf5.rackcdn.com/tenants | ||
| I saw the docs job failed but it seems unrelated to the change :/ | ||
| @flaper87:matrix.org | > <@jim:acmegating.com> eg, site preview on https://zuul.opendev.org/t/zuul/build/96db8bda8d104216b30ac55afd4048ef/artifacts (old version of change) | 14:46 |
| * Thanks! I just checked and the preview for the new run has been generated: https://2531b055144b2704e366-0ec349b737fff6d791676e2f8057b6a5.ssl.cf5.rackcdn.com/tenants | ||
| I saw the docs job failed but it seems unrelated to the change :/ | ||
| https://zuul.opendev.org/t/zuul/buildset/534d544483a64f17add153edbf4d9b7c | ||
| -@gerrit:opendev.org- Benjamin Schanzel proposed: [zuul/nodepool] 887858: Metastatic: fix user_data type https://review.opendev.org/c/zuul/nodepool/+/887858 | 15:40 | |
| -@gerrit:opendev.org- Benjamin Schanzel proposed: [zuul/nodepool] 887858: Metastatic: fix user_data type https://review.opendev.org/c/zuul/nodepool/+/887858 | 15:42 | |
| -@gerrit:opendev.org- Flavio Percoco Premoli proposed: [zuul/zuul] 885455: Use built-in URL data type instead of custom parse https://review.opendev.org/c/zuul/zuul/+/885455 | 17:30 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 887865: Pin pillow for docs build https://review.opendev.org/c/zuul/zuul/+/887865 | 17:38 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 887732: Add explicit foreign key indexes https://review.opendev.org/c/zuul/zuul/+/887732 | 17:43 | |
| @fungicide:matrix.org | > <@jpew:matrix.org> Does anyone use Zuul with VM migration in OpenSTack? | 18:42 |
| not that i'm aware of, but i'm curious as to how you were considering combining those features... what would (live? cold?) migration of a server instance do in your job? i assume you're asking with regard to nodepool's openstack driver, not testing live migration with something like devstack nested on a test node | ||
| @jpew:matrix.org | Our openstack team migrates live vms to do maintenance on the servers. This causes jumps in time, which affects some of our tests. I was wondering if zuul would handle the nodes just being deleted (by restarting the job) instead of migrated | 18:44 |
| @jim:acmegating.com | jpew: no promises, but in general zuul will try to detect that as a connection failure and restart the job | 18:48 |
| @jim:acmegating.com | iow, it's worth a shot | 18:48 |
| @fungicide:matrix.org | also i gather there's a way to put hosts in "maintenance mode" where the (openstack) scheduler will exclude them from consideration for booting new nodes. if you keep fairly short "ready node" lifetimes, they could simply set those hosts in maintenance well in advance of beginning to migrate instances off of them, which would give the running jobs time to finish up and any unused ready nodes an opportunity to expire and be culled automatically | 18:55 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 887732: Add explicit foreign key indexes https://review.opendev.org/c/zuul/zuul/+/887732 | 20:04 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 887907: Use low-level OpenStack SDK calls for server listing https://review.opendev.org/c/zuul/nodepool/+/887907 | 22:17 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 887907: Use low-level OpenStack SDK calls for server listing https://review.opendev.org/c/zuul/nodepool/+/887907 | 22:43 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!