-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 885423: Clear tree cache queues on disconnect https://review.opendev.org/c/zuul/nodepool/+/885423 | 00:42 | |
@jim:acmegating.com | Clark: ^ i think i found a way for the opposite to happen and used nodes to accumulate, but it's extremely unlikely in opendev, so can wait till tomorrow | 00:43 |
---|---|---|
@jjbeckman:matrix.org | Thanks for the advice. That makes sense, let me look into that. | 02:11 |
-@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 883446: Use buildx to build images https://review.opendev.org/c/zuul/zuul/+/883446 | 02:12 | |
-@gerrit:opendev.org- Jeremy Stanley https://matrix.to/#/@fungicide:matrix.org proposed: [zuul/zuul] 885155: Add config metadata to identify project-templates https://review.opendev.org/c/zuul/zuul/+/885155 | 03:24 | |
-@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 885426: [WIP] Add dict to file matchers to allow for merging https://review.opendev.org/c/zuul/zuul/+/885426 | 05:08 | |
-@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/nodepool] 885418: Correct node cache lock handling https://review.opendev.org/c/zuul/nodepool/+/885418 | 06:49 | |
@jjbeckman:matrix.org | kubectl exec from the `executor` to the node pod is instantaneous. Also, the first job in a pipeline that uses kubectl exec completes in about 4 seconds, and all jobs after that take 30+ seconds, so it doesn't seem to be network related. | 07:08 |
Very odd... Has anyone else experienced this with the Kubernetes driver? | ||
@flaper87:matrix.org | Do we have folks that are familiar with the Elasticsearch reporter? I've got 2 reviews up and I will likely be pushing another one. It's been a while since I contributed to opendev/zuul so, hopefully, I following the updated/right process :) | 07:16 |
- https://review.opendev.org/c/zuul/zuul/+/883837 | ||
- https://review.opendev.org/c/zuul/zuul/+/884663 | ||
@flaper87:matrix.org | > <@flaper87:matrix.org> Do we have folks that are familiar with the Elasticsearch reporter? I've got 2 reviews up and I will likely be pushing another one. It's been a while since I contributed to opendev/zuul so, hopefully, I following the updated/right process :) | 07:16 |
> | ||
> - https://review.opendev.org/c/zuul/zuul/+/883837 | ||
> - https://review.opendev.org/c/zuul/zuul/+/884663 | ||
One question on this topic: I couldn't find tests for this reporter. Maybe it's being tested with some generic tests(?). | ||
-@gerrit:opendev.org- Radosław Piliszek https://matrix.to/#/@yoctozepto:matrix.org proposed: [zuul/zuul] 885430: [docs] Mention that paused dependencies are OK https://review.opendev.org/c/zuul/zuul/+/885430 | 07:33 | |
-@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 885426: job: Allow dict in file matchers to allow for YAML merging https://review.opendev.org/c/zuul/zuul/+/885426 | 08:43 | |
-@gerrit:opendev.org- Flavio Percoco Premoli proposed: [zuul/zuul] 885455: Use # instead of /# to find hash anchors in URL https://review.opendev.org/c/zuul/zuul/+/885455 | 10:55 | |
@flaper87:matrix.org | Alright, I figured out why `auth_callback` is not working in my environment but I'm unsure whether this is the right fix: https://review.opendev.org/c/zuul/zuul/+/885455 | 10:58 |
More specifically, I'm wondering if I'm missing something in the setup given that: | ||
1. From the code, it doesn't seem like `auth_callback` would ever end with a `/` | ||
2. The `api.js` code for `getHomepageUrl` doesn't seem to have been touched in ages so, I'm assuming this used to work. | ||
In general, it is weird to only search for `/#` rather than `#` but I may be missing something here. Hope this helps | ||
@fungicide:matrix.org | > <@jim:acmegating.com> fungi: re 155 -- the first error (cache) does not appear related to your change and is probably a non-deterministic failure; the second one (with the big data structure) i think just needs the extra attr added to the expected output | 11:33 |
thanks! and yeah, i noticed the same when comparing the expected and actual json for the test | ||
@fungicide:matrix.org | Clark: do you recall what the plan was for getting the multi-scheduler job working? it looks like it has never succeeded once since it was added by https://review.opendev.org/819735 about 18 months ago | 12:01 |
@fungicide:matrix.org | current builds of it are failing around 30 tests, no idea if it's something that's been getting slowly whittled away at or gotten worse than it was originally | 12:04 |
-@gerrit:opendev.org- Flavio Percoco Premoli proposed: [zuul/zuul] 884663: Add start_time to buildset in the ES report https://review.opendev.org/c/zuul/zuul/+/884663 | 12:49 | |
-@gerrit:opendev.org- Flavio Percoco Premoli proposed: [zuul/nodepool] 875847: Allow to pass ImagePullSecrets to Kubernetes pods https://review.opendev.org/c/zuul/nodepool/+/875847 | 12:57 | |
@jim:acmegating.com | fungi: that's more or less stalled at this point. you can ignore it for now; i think if no one is interested in it in a few months we can probably drop it. | 13:31 |
@flaper87:matrix.org | corvus: re https://review.opendev.org/c/zuul/zuul/+/885455 | 15:00 |
Do you have any preference between the current version or moving `getHomepageUrl` to using `URL` as suggested by Radoslaw? | ||
I ran tests with keycloack from the examples (built a local web container) and it seemed to work as expected. I think I could add some tests for this function with the various types of URLs `/#` and `#` which may be enough | ||
@jim:acmegating.com | flaper87: no preference, whatever gets the job done. probably worth checking in with tristanC too | 15:03 |
@flaper87:matrix.org | I'll quickly draft a version of the change using `URL` and wait for tristanC feedback before pushing it :) | 15:04 |
@flaper87:matrix.org | I'd add tests for this while at it | 15:04 |
@jim:acmegating.com | that probably also needs to consider whitelabel vs multi-tenant hosting... i don't think that should affect the actual change, but tests of that method should include all those possibilities | 15:06 |
-@gerrit:opendev.org- Zuul merged on behalf of Radosław Piliszek https://matrix.to/#/@yoctozepto:matrix.org: [zuul/zuul] 885430: [docs] Mention that paused dependencies are OK https://review.opendev.org/c/zuul/zuul/+/885430 | 15:27 | |
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 885423: Clear tree cache queues on disconnect https://review.opendev.org/c/zuul/nodepool/+/885423 | 15:53 | |
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 20:36 | |
- [zuul/nodepool] 885198: Add extra-resources quota handling to the k8s driver https://review.opendev.org/c/zuul/nodepool/+/885198 | ||
- [zuul/nodepool] 885199: Add extra-resources handling to openshift drivers https://review.opendev.org/c/zuul/nodepool/+/885199 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!